[Libreoffice-commits] .: 2 commits - writerfilter/inc writerfilter/Library_writerfilter.mk writerfilter/source

2012-05-21 Thread Lubos Lunak
 writerfilter/Library_writerfilter.mk   |5 -
 writerfilter/inc/resourcemodel/SubSequence.hxx |2 +-
 writerfilter/source/dmapper/PropertyIds.cxx|2 +-
 writerfilter/source/dmapper/PropertyMap.hxx|2 +-
 writerfilter/source/doctok/Dff.cxx |2 +-
 writerfilter/source/doctok/Dff.hxx |4 ++--
 writerfilter/source/doctok/DffImpl.cxx |2 +-
 writerfilter/source/doctok/PLCF.hxx|2 +-
 writerfilter/source/doctok/WW8Annotation.cxx   |2 +-
 writerfilter/source/doctok/WW8Clx.cxx  |2 +-
 writerfilter/source/doctok/WW8Clx.hxx  |4 ++--
 writerfilter/source/doctok/WW8DocumentImpl.hxx |2 +-
 writerfilter/source/doctok/WW8FKP.hxx  |2 +-
 writerfilter/source/doctok/WW8FontTable.cxx|2 +-
 writerfilter/source/doctok/WW8LFOTable.cxx |2 +-
 writerfilter/source/doctok/WW8ListTable.cxx|2 +-
 writerfilter/source/doctok/WW8Picture.cxx  |2 +-
 writerfilter/source/doctok/WW8PropertySetImpl.hxx  |4 ++--
 writerfilter/source/doctok/WW8ResourceModelImpl.cxx|6 +++---
 writerfilter/source/doctok/WW8ResourceModelImpl.hxx|2 +-
 writerfilter/source/doctok/WW8StructBase.cxx   |2 +-
 writerfilter/source/doctok/WW8Sttbf.cxx|2 +-
 writerfilter/source/doctok/WW8Sttbf.hxx|4 ++--
 writerfilter/source/doctok/WW8StyleSheet.cxx   |2 +-
 writerfilter/source/doctok/WW8Table.cxx|2 +-
 writerfilter/source/doctok/WW8Text.cxx |2 +-
 writerfilter/source/doctok/resources.xsl   |8 
 writerfilter/source/doctok/resourcesimpl.xsl   |6 +++---
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx  |2 +-
 writerfilter/source/ooxml/OOXMLFastDocumentHandler.cxx |2 +-
 writerfilter/source/ooxml/factory.xsl  |2 +-
 writerfilter/source/ooxml/factory_ns.xsl   |4 ++--
 writerfilter/source/ooxml/factoryimpl.xsl  |6 +++---
 writerfilter/source/ooxml/factoryimpl_ns.xsl   |2 +-
 writerfilter/source/ooxml/gperffasttokenhandler.xsl|2 +-
 35 files changed, 48 insertions(+), 53 deletions(-)

New commits:
commit e1ff97ab62a94db662832bafe4441b063de2256a
Author: Luboš Luňák 
Date:   Tue May 22 08:51:37 2012 +0200

remove number of -I directives in writerfilter

Windows length path limitations strike again, and this should reduce the 
total
argument length.

Change-Id: I76fefabc8201e51494a7003d7ca4f9fd92ffa3b9

diff --git a/writerfilter/Library_writerfilter.mk 
b/writerfilter/Library_writerfilter.mk
index b06ee75..3644c42 100644
--- a/writerfilter/Library_writerfilter.mk
+++ b/writerfilter/Library_writerfilter.mk
@@ -38,11 +38,6 @@ $(eval $(call gb_Library_set_include,writerfilter,\
 $$(INCLUDE) \
 -I$(SRCDIR)/writerfilter/inc \
 -I$(SRCDIR)/writerfilter/source \
--I$(SRCDIR)/writerfilter/source/dmapper \
--I$(SRCDIR)/writerfilter/source/doctok \
--I$(SRCDIR)/writerfilter/source/ooxml \
--I$(WORKDIR)/CustomTarget/writerfilter/source/doctok \
--I$(WORKDIR)/CustomTarget/writerfilter/source/ooxml \
 ))
 
 $(eval $(call gb_Library_use_api,writerfilter,\
diff --git a/writerfilter/source/dmapper/PropertyIds.cxx 
b/writerfilter/source/dmapper/PropertyIds.cxx
index 62445ab..0f46606 100644
--- a/writerfilter/source/dmapper/PropertyIds.cxx
+++ b/writerfilter/source/dmapper/PropertyIds.cxx
@@ -25,7 +25,7 @@
  * for a copy of the LGPLv3 License.
  *
  /
-#include 
+#include "PropertyIds.hxx"
 #include 
 #include 
 
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx 
b/writerfilter/source/dmapper/PropertyMap.hxx
index 5c455dd..ba5e1ab 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -33,7 +33,7 @@
 #include 
 #include 
 #include 
-#include 
+#include "PropertyIds.hxx"
 #include 
 #include 
 #include 
diff --git a/writerfilter/source/doctok/Dff.cxx 
b/writerfilter/source/doctok/Dff.cxx
index 8ec8f45..41a9482 100644
--- a/writerfilter/source/doctok/Dff.cxx
+++ b/writerfilter/source/doctok/Dff.cxx
@@ -30,7 +30,7 @@
 #include "Dff.hxx"
 #include 
 #include 
-#include "resources.hxx"
+#include "doctok/resources.hxx"
 
 namespace writerfilter {
 namespace doctok {
diff --git a/writerfilter/source/doctok/Dff.hxx 
b/writerfilter/source/doctok/Dff.hxx
index c987e52..3a1f18c 100644
--- a/writerfilter/source/doctok/Dff.hxx
+++ b/writerfilter/source/doctok/Dff.hxx
@@ -30,8 +30,8 @@
 #define INCLUDED_DFF_HXX
 
 #include 
-#include 
-#include 
+#include "WW8StructBase.hxx"
+#include "WW8ResourceModelImpl.hxx"
 
 namespace writerfilter {
 namespace doctok
diff --git a/writerfilter/s

Re: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

2012-05-21 Thread David Ostrovsky

Hi Rene,

thank you for review and comments!
I was indeed not sure with arm and was told on irc that eabi would be 
the right way to go...

And who really cares, which ARCH are we using for Mips ;-)
Anyway I fixed it accordingly and here is the new version.

Ciao
David

On 21.05.2012 23:17, Rene Engelhard wrote:

Hi,

On Mon, May 21, 2012 at 09:39:52PM +0200, David Ostrovsky wrote:

with this patch sal/rtl/source/macro.hxx is merged into configure
process and
rtlbootstrap.mk is not generated any more.

  arm*)
  CPU=R
  CPUNAME=ARM
+RTL_ARCH=ARM_EABI
  EPM_FLAGS="-a arm"
  OUTPATH=unxlngr
  ;;

is wrong.

arm*-linux-gnueabi) is RTL_ARCH=ARM_EABI.
arm*-linux) is RTL_ARCH=ARM_OABI.

Yes, arm oabi is dead...

  mips64el)
  CPU=M
  CPUNAME=GODSON
+RTL_ARCH=MIPS_EB
  EPM_FLAGS="-a mips64el"
  OUTPATH=unxlngmips
  ;;
  mipsel)
  CPU=M
  CPUNAME=GODSON
+RTL_ARCH=MIPS_EB
  EPM_FLAGS="-a mipsel"
  OUTPATH=unxlngmips
  ;;

is obviously also wrong. it's called mipsel for a reason. Yes, it's little 
endian,
so MIPS_EL would be right here.

I bet that more of this might be wrong,
I actually think that getting these values from what the compiler gives is 
safest as
that one *does* know what it's supoosed to compile for.

Regards,

Rene


>From 6ba134db991f0445b45806022d89ea6eae8a95e0 Mon Sep 17 00:00:00 2001
From: David Ostrovsky 
Date: Mon, 21 May 2012 19:01:29 +0200
Subject: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

Change-Id: I241be2704a069ec1f6be5861084039569673cc12
---
 config_host.mk.in |2 +
 configure.in  |   54 +-
 instsetoo_native/util/makefile.mk |1 -
 sal/CustomTarget_generated.mk |   21 +--
 sal/Library_sal.mk|2 +
 sal/Package_generated.mk  |1 -
 sal/rtl/source/bootstrap.cxx  |6 +-
 sal/rtl/source/macro.hxx  |  116 -
 sdext/platform.mk |8 +-
 solenv/inc/settings.mk|2 -
 10 files changed, 64 insertions(+), 149 deletions(-)
 delete mode 100644 sal/rtl/source/macro.hxx

diff --git a/config_host.mk.in b/config_host.mk.in
index 0a85bfd..76d4a1d 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -426,6 +426,8 @@ export REDLAND_CFLAGS=@REDLAND_CFLAGS@
 export REDLAND_LIBS=@REDLAND_LIBS@
 export RHINO_JAR=@RHINO_JAR@
 export RPM=@RPM@
+export RTL_OS=@RTL_OS@
+export RTL_ARCH=@RTL_ARCH@
 export SAC_JAR=@SAC_JAR@
 export SAL_ENABLE_FILE_LOCKING=1
 export SAMPLEICC_CFLAGS=@SAMPLEICC_CFLAGS@
diff --git a/configure.in b/configure.in
index 510d82a..acc0030 100644
--- a/configure.in
+++ b/configure.in
@@ -2991,6 +2991,8 @@ aix*)
 GUI=UNX
 GUIBASE=unx
 OS=AIX
+RTL_OS=AIX
+RTL_ARCH=PowerPC
 OUTPATH=unxaigppc
 P_SEP=:
 SOLARLIB="-L../lib -L$SRC_ROOT/solenv/$OUTPATH/lib"
@@ -3003,6 +3005,7 @@ cygwin*)
 GUI=WNT
 GUIBASE=WIN
 OS=WNT
+RTL_OS=Windows
 P_SEP=";"
 
 case "$host_cpu" in
@@ -3010,11 +3013,13 @@ cygwin*)
 if test "$CL_X64" != ""; then
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 LIB64="lib/x64"
 OUTPATH=wntmscx$COMEX
 else
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=wntmsci$COMEX
 fi
 ;;
@@ -3033,12 +3038,14 @@ darwin*)
 # Not sure if "Aqua" is the right term to use?
 GUIBASE="aqua"
 OS=MACOSX
+RTL_OS=MacOSX
 P_SEP=:
 
 case "$host_cpu" in
 arm*)
 CPU=R
 CPUNAME=ARM
+RTL_ARCH=ARM_EABI
 GUIBASE=cocoatouch
 OUTPATH=unxiosr
 OS=IOS;
@@ -3046,11 +3053,13 @@ darwin*)
 powerpc*)
 CPU=P
 CPUNAME=POWERPC
+RTL_ARCH=PowerPC
 OUTPATH=unxmacxp
 ;;
 i*86|x86_64)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxmacxi
 ;;
 *)
@@ -3065,6 +3074,7 @@ dragonfly*)
 GUI=UNX
 GUIBASE=unx
 OS=DRAGONFLY
+RTL_OS=DragonFly
 OUTPATH=unxdfly
 P_SEP=:
 
@@ -3072,10 +3082,12 @@ dragonfly*)
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 ;;
 x86_64)
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 ;;
 *)
 AC_MSG_ERROR([Unsupported host_cpu $host_cpu for host_os $host_os])
@@ -3090,6 +3102,7 @@ freebsd*)
 COM=GCC
 GUI=UNX
 GUIBASE=unx
+RTL_OS=FreeBSD
 OS=FREEBSD
 OUTPATH=unxfbsd
 P_SEP=:
@@ -3098,11 +3111,13 @@ freebsd*)
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxfbsdi
 ;;
 x86_64)
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 ;;
 *)
 AC_MSG_ERROR([Unsupported host_cpu $host_cpu for host_os $host_os])
@@ -3118,17 +31

Re: main in libsofficeapp ...

2012-05-21 Thread Stephan Bergmann

On 05/21/2012 11:16 PM, Michael Stahl wrote:

On 21/05/12 23:08, Michael Meeks wrote:

commit c7458a4a71a1e875e03772b0f6e8ad9e1a982006
Author: Michael Stahl
Date:   Mon Mar 12 16:24:34 2012 +0100

 desktop: libsofficeapp shouln't need a main()

Is that a random cleanup, or something that fixes an issue ? if the
latter, which issue ? :-)


the issue was that some object ended up being linked into 2 LinkTargets,
and this somehow fixed it, though i don't remember details...


The lo_main generated in there is needed by android to get some of our
samples bootstrapped&  runnning.


perhaps the other thing that links this doesn't exist on android, then
add it back with an "if ANDROID"?


BTW, splitting libsofficeapp.so out of soffice.bin was done for the 
infamous three-layer thing.  It could be folded back in nowadays.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Calc/ODFF spreadsheet functions

2012-05-21 Thread Regina Henschel

Hi,

Eike Rathke schrieb:

Hi,

On Wednesday, 2012-05-16 09:28:16 +0200, Winfried Donkers wrote:


Ehh.. I'm not familiar with adding content to (wiki/web) pages. And
anyway, Eike deserves at least as much credit for this patch.


I've no problem with being not explicitly mentioned, but add me if you
think I deserve it ;-)


I don't see any LibreOffice comments, would this (DATEDIF) be the first one?


Yes, indeed, this would be an interesting precedence case.. it's
probably better to setup our own page for this.


I'm not sure about that. It means to double the work and makes 
information scattered.


 Also Wolfgang's BIT*

functions are in LibO, so would need to be flagged as integrated, same
with Regina's CSC/SEC functions.


Yes, I haven't update the Wiki. But it is a Wiki and in no way _my_ 
page. So you can alter it as needed.




@Regina:
As all significant work on that OOo wiki page is your's, would you be
willing to contribute it in its entirety to the TDF/LibO wiki?


If you want to copy the content, you may do it. But I see no necessity.



Btw, seeing your work on IMSEC and such is lingering as a patch attached
to https://issues.apache.org/ooo/show_bug.cgi?id=111609 what's the state
of the patch? Would it be ready to be integrated? And if so, would you
contribute it?


Oh, that is two years old and I've lost sight of it. As far as I 
remember, the mathematics are right, but there have been some problems 
with xls and sxc file format, import/export and round trips. Some 
problems are mentioned in 
http://www.mail-archive.com/dev@sc.openoffice.org/msg02387.html, for 
example. And the parts for the help are missing too. So no, that is not 
ready to integrate. From point of license I prefer to get it under 
APL2.0 license too, otherwise an integration to AOO will be difficult. 
Differences in UI for AOO and LO are OK, but things which are close to 
ODF file format and touch import/export filters should be exchangeable.






Also, coukld this page be a source for me to add more formulas that are in 
ODF1.2 and not yet in calc?


Yes, it should be pretty up-to-date. Just give us a heads-up what you
would like to pick so we can get into details. If possible we should
focus on functions defined in the Small/Medium/Large sets of ODFF in
that order, see
http://docs.oasis-open.org/office/v1.2/cs01/OpenDocument-v1.2-cs01-part2.html#__RefHeading__1018916_7159801101

I think we cover all of Small and most of Medium, only a few missing,
a double check would be good.



Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

2012-05-21 Thread Tor Lillqvist
On 22 May 2012 08:51, David Tardon  wrote:
>  IMHO it makes sense to put the
> definitions together in one place.

Definitely, yes, and (the other) David's patch seems nice, just needs
some minor fixes as Rene said.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: GSoC Week 1

2012-05-21 Thread Tor Lillqvist
> you mean, with 10.000 lines of changes per week, in the fine tradition
> of OpenOffice.org?  :-P

That is a possibility, yes. *I* don't need it, and I assume GSoC
students don't need it either, they should be capable of building and
installing automake and autoconf.

(Another possibility is to keep the pre-generated configure script on
the web and download it when necessary.)

But we need more Mac-knowledgeable developers to make LO into a better
app on the Mac, don't we? And we want to make it as easy as possible
for them to start hacking on the actual code. Now when it is possible
to build LO with the *current* Xcode (one doesn't need to hunt for the
obsolete, ever more difficult to find and difficult to install, Xcode
3), we are a big step in that direction. Our principle has always been
that for the Mac one shouldn't need any 3rd-party software. But now
when Apple in their wisdom (or by accident) stopped including automake
and autoconf in Xcode, that isn't true any more.

Consider some Mac-savvy developer with a slight interest in FLOSS, who
tries LO and notices some of the many things that are a bit broken on
the Mac. "Oh, I could try to fix that", would be the reaction we want,
right? So source is downloaded, some getting started wiki pages read,
and then ./autogen.sh stops with a missing aclocal. "aclocal, never
heard of that, must be some Linux crack, oh well, I have other things
to do".

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: vcl/inc

2012-05-21 Thread Tor Lillqvist
 vcl/inc/vcl/outdev.hxx |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 11e9ba6353dc42e85dddc346a174503d493bf82a
Author: Tor Lillqvist 
Date:   Mon May 21 17:38:44 2012 +0300

Bin unused OUTDEV_BUFFER_SIZE

Change-Id: I14bc964e931d9ae1981e7a22e66d2699e16457f3

diff --git a/vcl/inc/vcl/outdev.hxx b/vcl/inc/vcl/outdev.hxx
index 284340f..c1459c0 100644
--- a/vcl/inc/vcl/outdev.hxx
+++ b/vcl/inc/vcl/outdev.hxx
@@ -112,9 +112,6 @@ namespace vcl
 class RenderGraphic;
 }
 
-#define OUTDEV_BUFFER_SIZE  128
-
-
 // -
 // - OutputDevice-Data -
 // -
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

2012-05-21 Thread David Tardon
On Mon, May 21, 2012 at 11:17:23PM +0200, Rene Engelhard wrote:
> I actually think that getting these values from what the compiler gives is 
> safest as
> that one *does* know what it's supoosed to compile for.

The point is that determination of values for THIS_OS and THIS_ARCH in
sal/rtl/source/macro.hxx (which are then assigned to RTL_OS and
RTL_ARCH, see sal/CustomTarget_generated.mk) is in big part based on
variables set by configure (CPUNAME, OS). IMHO it makes sense to put the
definitions together in one place.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: css::uno::DeploymentException

2012-05-21 Thread Terrence Enger
On Mon, 2012-05-21 at 23:22 +0200, Michael Stahl wrote:
> 
> you are probably running into this problem, which can be resolved by
> deleting something from your user profile:
> 
> http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/28734


Heh, heh, heh.  When I was watching the exceptions roll by in gdb, I
wrote myself a note (just in case I run out of things to do )
to look into the four exceptions css::uno::RuntimeException thrown
from xmlreader::XmlReader::XmlReader( ... ) with message text "missing
whitespace before attribute in " and naming files ...


.config/libreoffice/3/user/uno_packages/cache/registry/com.sun.star.comp.deployment.component.PackageRegistryBackend/common.rdb


.config/libreoffice/3/user/uno_packages/cache/registry/com.sun.star.comp.deployment.component.PackageRegistryBackend/Linux_x86.rdb


.config/libreoffice/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.component.PackageRegistryBackend/common_.rdb


.config/libreoffice/3/user/extensions/bundled/registry/com.sun.star.comp.deployment.component.PackageRegistryBackend/Linux_x86_.rdb

Each of the these files looks like it has binary data, and each was
last changed at least several months ago.  What, I wondered, *should*
these files be doing for LibreOffice?


So, I have moved those four files away, and both localbuilt LO and LO
provided with ubuntu-natty run normally; neither recreates any of the
four files.


Now, if only I can remember what bug I wanted a new LO for hacking on!


Thank you, Michael, for your help.
Terry.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH-3-5] fdo#35270 - kill first-use grammar checker freeze ...

2012-05-21 Thread Daniel Naber
On Montag, 21. Mai 2012, Olivier R. wrote:

Hello Olivier,

> The differences look imho more technical than philosophical, even if
> there are specific features in both of them.

thanks for your explanations of the LT/Lightproof differences.

> Another solution might be to tag Hunspell dictionaries with
> LT tags, but all Hunspell dictionaries were probably not conceived with
> grammar checking in mind, and that’s probably more a dream than a
> doable solution.

Yes, the difficulty comes from the flags used in hunspell. If a hunspell 
dictionary was just a long list of words without flags, one could easily add 
the tags from LT to each word.

> If Lightproof could use LT lexicons, that could be a temporary solution,
> but maybe memory-consuming, as you would have a dictionary for spell
> checking and a lexicon for grammar checking.

I have never tried that but I think the finite state machine used internally 
by LT is quite memory-friendly.

If we could work together more closely that would be great. As you know, 
each rule in LT has an id so it can be identified. Maybe that id could be 
used to keep track of similar rules. Does LightProof also have integrated 
test sentences? Then LT could use them to see what rules are missing in LT 
and vice-versa.

Regards
 Daniel

-- 
http://www.danielnaber.de
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: scp2/source

2012-05-21 Thread Jesús Corrius
 scp2/source/base/registryitem_base.scp   |8 +++
 scp2/source/calc/registryitem_calc.scp   |   32 +++
 scp2/source/draw/registryitem_draw.scp   |   32 +++
 scp2/source/impress/registryitem_impress.scp |   32 +++
 scp2/source/math/registryitem_math.scp   |   16 +++
 scp2/source/writer/registryitem_writer.scp   |   56 +++
 6 files changed, 176 insertions(+)

New commits:
commit 3cd1a896d41e30294fd4113101a69432ee3cae02
Author: Jesús Corrius 
Date:   Mon May 21 23:49:49 2012 +0200

Use Aplication User Model IDs for the native file types

Change-Id: I4941d97a8eb540bbf63320db83230707ced9f90f

diff --git a/scp2/source/base/registryitem_base.scp 
b/scp2/source/base/registryitem_base.scp
index fce66e8..e763fd3 100644
--- a/scp2/source/base/registryitem_base.scp
+++ b/scp2/source/base/registryitem_base.scp
@@ -94,6 +94,14 @@ RegistryItem 
gid_Regitem_Openoffice_Databasedocument_1_Defaulticon
 Value = "\program\soffice.bin,11";
 End
 
+RegistryItem gid_Regitem_Openoffice_Databasedocument_1_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Base_Bin;
+Subkey = "opendocument.DatabaseDocument.1";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Base";
+End
+
 #ifdef _MSC_VER
 RegistryItem gid_Regitem_odb_FullDetails
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
diff --git a/scp2/source/calc/registryitem_calc.scp 
b/scp2/source/calc/registryitem_calc.scp
index 0824608..08dfece 100644
--- a/scp2/source/calc/registryitem_calc.scp
+++ b/scp2/source/calc/registryitem_calc.scp
@@ -286,6 +286,14 @@ RegistryItem 
gid_Regitem_Soffice_Starcalcdocument_6_Defaulticon
 Value = "\program\soffice.bin,3";
 End
 
+RegistryItem gid_Regitem_Soffice_Starcalcdocument_6_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "soffice.StarCalcDocument.6";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Calc";
+End
+
 RegistryItem gid_Regitem_Soffice_Starcalcdocument_6_Insertable
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 ModuleID = gid_Module_Prg_Calc_Bin;
@@ -383,6 +391,14 @@ RegistryItem 
gid_Regitem_Soffice_Starcalctemplate_6_Defaulticon
 Value = "\program\soffice.bin,4";
 End
 
+RegistryItem gid_Regitem_Soffice_Starcalctemplate_6_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "soffice.StarCalcTemplate.6";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Calc";
+End
+
 RegistryItem gid_Regitem_Soffice_Starcalctemplate_6_Shell
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 Subkey = "soffice.StarCalcTemplate.6\shell";
@@ -672,6 +688,14 @@ RegistryItem 
gid_Regitem_Openoffice_Calcdocument_1_Defaulticon
 Value = "\program\soffice.bin,3";
 End
 
+RegistryItem gid_Regitem_Openoffice_Calcdocument_1_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "opendocument.CalcDocument.1";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Calc";
+End
+
 #ifdef _MSC_VER
 RegistryItem gid_Regitem_ods_FullDetails
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
@@ -881,6 +905,14 @@ RegistryItem 
gid_Regitem_Openoffice_Calctemplate_1_Defaulticon
 Value = "\program\soffice.bin,4";
 End
 
+RegistryItem gid_Regitem_Openoffice_Calctemplate_1_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "opendocument.CalcTemplate.1";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Calc";
+End
+
 #ifdef _MSC_VER
 RegistryItem gid_Regitem_ots_FullDetails
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
diff --git a/scp2/source/draw/registryitem_draw.scp 
b/scp2/source/draw/registryitem_draw.scp
index 5357146..c461a4f 100644
--- a/scp2/source/draw/registryitem_draw.scp
+++ b/scp2/source/draw/registryitem_draw.scp
@@ -286,6 +286,14 @@ RegistryItem 
gid_Regitem_Soffice_Stardrawdocument_6_Defaulticon
 Value = "\program\soffice.bin,5";
 End
 
+RegistryItem gid_Regitem_Soffice_Stardrawdocument_6_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Draw_Bin;
+Subkey = "soffice.StarDrawDocument.6";
+Name = "AppUserModelID";
+Value = "TheDocumentFoundation.LibreOffice.Draw";
+End
+
 RegistryItem gid_Regitem_Soffice_Stardrawdocument_6_Shell
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 ModuleID = gid_Module_Prg_Draw_Bin;
@@ -383,6 +391,14 @@ RegistryItem 
gid_Regitem_Soffice_Stardrawtemplate_6_Defaulticon
 Value = "\program\soffice.bin,6";
 End
 
+RegistryItem gid_Regitem_Soffice_Stardrawtemplate_6_AppUserModelID
+ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
+ModuleID = gid_Module_Prg_Draw_Bin;
+Subkey = "soffice.StarDrawTemplate.6";
+Name = "AppUserMo

Re: [PUSHED:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Christian Lohmaier
HI *,

On Mon, May 21, 2012 at 4:30 PM, Petr Mladek  wrote:
> Fridrich Strba píše v Po 21. 05. 2012 v 16:12 +0200:
>> +1 from me for 3.5.4
>
> Thanks for approvals. This was the third one => pushed into 3-5-4
> branch, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=20987a1d0ec675f3a23a4be58eb7309f60fc62de
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=d4f45305ecdb38d3c2b5f91ec4f29cb89e29f770

Thanks a lot for the reviews & pushing it :-)

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [GSoC 2011][svg export filter] GSoC project start

2012-05-21 Thread Christian Lohmaier
Hi *,

On Mon, May 21, 2012 at 4:32 PM, Marco Cecchetti  wrote:
> On Mon, 21 May 2012 12:45:37 +0200, Christian Lohmaier
>  wrote:
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=43060
>>
>> So please put
>> * use coordinate system that all tools agree upon.
> [...]
> I was not aware of this problem, anyway having a presentation
> not resized automatically and placed top left is not really appealing.
> For these reasons I take the following decision: export of page extents
> with units is back but only when a single slide/page is exported.

Sounds very reasonable.  - Thanks a lot!

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

2012-05-21 Thread Rene Engelhard
Hi,

On Mon, May 21, 2012 at 09:39:52PM +0200, David Ostrovsky wrote:
> with this patch sal/rtl/source/macro.hxx is merged into configure
> process and
> rtlbootstrap.mk is not generated any more.

 arm*)
 CPU=R
 CPUNAME=ARM
+RTL_ARCH=ARM_EABI
 EPM_FLAGS="-a arm"
 OUTPATH=unxlngr
 ;;

is wrong.

arm*-linux-gnueabi) is RTL_ARCH=ARM_EABI.
arm*-linux) is RTL_ARCH=ARM_OABI.

Yes, arm oabi is dead...

 mips64el)
 CPU=M
 CPUNAME=GODSON
+RTL_ARCH=MIPS_EB
 EPM_FLAGS="-a mips64el"
 OUTPATH=unxlngmips
 ;;
 mipsel)
 CPU=M
 CPUNAME=GODSON
+RTL_ARCH=MIPS_EB
 EPM_FLAGS="-a mipsel"
 OUTPATH=unxlngmips
 ;;

is obviously also wrong. it's called mipsel for a reason. Yes, it's little 
endian,
so MIPS_EL would be right here.

I bet that more of this might be wrong,
I actually think that getting these values from what the compiler gives is 
safest as
that one *does* know what it's supoosed to compile for.

Regards,

Rene
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [GSoC 2011][svg export filter] GSoC project start

2012-05-21 Thread Thorsten Behrens
Marco Cecchetti wrote:
> At present there are two initial commits: the first one is
> a technical commit where I fixed some indentation issue,
> the second is an improvement of the Python script that generates
> the c++ header from the JavaScript engine: now debug printers are
> turned off automatically by the Python script, so there is no more
> the need to turn them off manually before performing a commit.
> 
Hi Marco,

nice, and much appreciated - while sounding trifle, I personally
enjoy reading nicely formatted code much more. :)

> [snip]
> 
> So, that is the initial plan.
> I'll provide a log book and a weekly report.
> 
Perfect - let's go for it. Just, you sure I can't talk into blogging
that weekly report instead? In that case, IIRC Miklos had a nice
text2rss script around somewhere. ;)

Cheers,

-- Thorsten


pgpOVkUYx6UOB.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: css::uno::DeploymentException

2012-05-21 Thread Michael Stahl
On 21/05/12 23:14, Terrence Enger wrote:
> ServiceManager::readRdbFile() throws
> css::uno::DeploymentException.  The program is well on its way to
> falling over.  e.Message in the thrown exception says, with
> newlines inserted freely, ...
> 
> file:///home/terry/lo_hacking/git/libo/solver/unxlngi6/
> installation/opt/program/../share/extensions/
> script-provider-for-python/components.rdb: duplicate
> 
> 

you are probably running into this problem, which can be resolved by
deleting something from your user profile:

http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/28734

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc, part 2

2012-05-21 Thread Albert Thuswaldner
Hi Markus,

Forgot to CC the list in my previous mail, sorry for the noise.
The patch in the last mail was also wrong.

On Fri, May 18, 2012 at 12:10 PM, Markus Mohrhard
 wrote:
> Hello Albert,
>
> Sorry that it took me a bit to review your patch but my master trees
> are totally screwed for my own feature. I now checked your patch and
> solved the conflicts that were related to my last fix for sort
> dialogs. Attached you'll find a patch that applies cleanly on master.

Thanks.

> I checked the dialog and it looks like we need to move some items a
> bit.

Yea, that's related to different themes/widget set, I guess. It looks
great on my computer running LO under KDE. I had a fixed offset which
dictated the spacing between two sort key items, in the new patch I
now calculate the spacing based on position and height of the widgets.
Still not perfect, needs some wiggling.
It would be great if someone could help out with this :)

> I've attached a simple patch showing how to do this. The patch will
> not compile but shows already the basic ideas. The idea is to move the
> ScSortKeyItems variable into tpsort and only pass a reference. I think
> a good final step is to use a boost::ptr_vector which will control the
> lifetime of the contained objects.

Thanks for the code pointer regarding the reference, It was along the
line what I was thinking. I've now implemented this using
boost::ptr_vector in the new patch. It seems to work, however
strangely enough LO now segfaults on exit of the sort dialog. The
stack trace suggest the problem to be in the Window class, however
boost::ptr_vector should take care of the deletion of its members, so
no dedicated destructor should be necessary. I'm confused...

Could you have a look at this problem. Thanks. I'm feeling the heat of
the feature freeze...

/Albert
From 1237b47bd646285deebc792a469e509640233b79 Mon Sep 17 00:00:00 2001
From: Albert Thuswaldner 
Date: Mon, 21 May 2012 23:04:12 +0200
Subject: [PATCH] fdo#45747 remove the limitation to 3 sort entries in calc part2

Change-Id: I699c424f536b0096b35d3db3aee371793e9e56c4
---
 sc/Library_scui.mk|1 +
 sc/inc/helpids.h  |1 +
 sc/inc/sc.hrc |4 +-
 sc/source/ui/dbgui/sortkeydlg.cxx |  196 
 sc/source/ui/dbgui/tpsort.cxx |  255 -
 sc/source/ui/inc/sortdlg.hrc  |   23 ++--
 sc/source/ui/inc/sortkeydlg.hxx   |  107 
 sc/source/ui/inc/tpsort.hxx   |   28 +
 sc/source/ui/src/sortdlg.src  |  142 +++--
 9 files changed, 485 insertions(+), 272 deletions(-)
 create mode 100644 sc/source/ui/dbgui/sortkeydlg.cxx
 create mode 100644 sc/source/ui/inc/sortkeydlg.hxx

diff --git a/sc/Library_scui.mk b/sc/Library_scui.mk
index 9af5a63..37478a2 100644
--- a/sc/Library_scui.mk
+++ b/sc/Library_scui.mk
@@ -72,6 +72,7 @@ $(eval $(call gb_Library_add_exception_objects,scui,\
 sc/source/ui/dbgui/scuiasciiopt \
 sc/source/ui/dbgui/scuiimoptdlg \
 sc/source/ui/dbgui/sortdlg \
+sc/source/ui/dbgui/sortkeydlg \
 sc/source/ui/dbgui/subtdlg \
 sc/source/ui/dbgui/textimportoptions \
 sc/source/ui/dbgui/tpsort \
diff --git a/sc/inc/helpids.h b/sc/inc/helpids.h
index 8d41ab7..7c5955c 100644
--- a/sc/inc/helpids.h
+++ b/sc/inc/helpids.h
@@ -88,6 +88,7 @@
 #define HID_SC_FORM_ARGS"SC_HID_SC_FORM_ARGS"
 #define HID_SCPAGE_SORT_FIELDS  "SC_HID_SCPAGE_SORT_FIELDS"
 #define HID_SCPAGE_SORT_OPTIONS "SC_HID_SCPAGE_SORT_OPTIONS"
+#define HID_SCPAGE_SORTKEY_FIELDS   "SC_HID_SCPAGE_SORTKEY_FIELDS"
 #define HID_SCPAGE_SUBT_OPTIONS "SC_HID_SCPAGE_SUBT_OPTIONS"
 #define HID_SCPAGE_SUBT_GROUP   "SC_HID_SCPAGE_SUBT_GROUP"
 #define HID_SCPAGE_PROTECTION   "SC_HID_SCPAGE_PROTECTION"
diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 59b6564..ee8c042 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -1225,7 +1225,9 @@
 #define RID_POPUP_FILTER(SC_DIALOGS_START + 153)
 #define RID_SCDLG_TAB_BG_COLOR  (SC_DIALOGS_START + 154)
 
-#define SC_DIALOGS_END  (SC_DIALOGS_START + 155)
+#define RID_SCPAGE_SORTKEY_FIELDS   (SC_DIALOGS_START + 155)
+#define RID_SCDLG_SORTKEY   (SC_DIALOGS_START + 156)
+#define SC_DIALOGS_END  (SC_DIALOGS_START + 157)
 
 #ifndef STD_MASKCOLOR
 #define STD_MASKCOLOR Color { Red = 0xFF00; Green = 0x; Blue = 0xFF00; }
diff --git a/sc/source/ui/dbgui/sortkeydlg.cxx b/sc/source/ui/dbgui/sortkeydlg.cxx
new file mode 100644
index 000..0801b8d
--- /dev/null
+++ b/sc/source/ui/dbgui/sortkeydlg.cxx
@@ -0,0 +1,196 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ *
+ * The contents o

Re: main in libsofficeapp ...

2012-05-21 Thread Michael Stahl
On 21/05/12 23:08, Michael Meeks wrote:
> Hi Michael,
> 
> commit c7458a4a71a1e875e03772b0f6e8ad9e1a982006
> Author: Michael Stahl 
> Date:   Mon Mar 12 16:24:34 2012 +0100
> 
> desktop: libsofficeapp shouln't need a main()
> 
>   Is that a random cleanup, or something that fixes an issue ? if the
> latter, which issue ? :-)

the issue was that some object ended up being linked into 2 LinkTargets,
and this somehow fixed it, though i don't remember details...

>   The lo_main generated in there is needed by android to get some of our
> samples bootstrapped & runnning.

perhaps the other thing that links this doesn't exist on android, then
add it back with an "if ANDROID"?

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] Corrected max inital worksheet number in debughelper message

2012-05-21 Thread Albert Thuswaldner
Hi,
A simple fix of a debughelper message, which I forgot to correct in
one of my previous path.
/Albert
From b4e9b7ff4c371b18d787d5482c28f219f018af84 Mon Sep 17 00:00:00 2001
From: Albert Thuswaldner 
Date: Mon, 21 May 2012 23:02:12 +0200
Subject: [PATCH] Corrected max inital worksheet number in debughelper message

Change-Id: Icd40cc3bdc70e0ff55c82a6a4099411d1da47f56
---
 sc/source/ui/vba/vbaapplication.cxx |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sc/source/ui/vba/vbaapplication.cxx b/sc/source/ui/vba/vbaapplication.cxx
index bb31732..d962395 100644
--- a/sc/source/ui/vba/vbaapplication.cxx
+++ b/sc/source/ui/vba/vbaapplication.cxx
@@ -1030,7 +1030,7 @@ void SAL_CALL ScVbaApplication::setSheetsInNewWorkbook( sal_Int32 SheetsInNewWor
 if ( SheetsInNewWorkbook < MININITTAB
   || SheetsInNewWorkbook > MAXINITTAB )
 {
-DebugHelper::exception( OUString(RTL_CONSTASCII_USTRINGPARAM("The number must be between 1 and 1")),
+DebugHelper::exception( OUString(RTL_CONSTASCII_USTRINGPARAM("The number must be between 1 and 1024")),
 uno::Exception(), SbERR_METHOD_FAILED, OUString() );
 }
 else
-- 
1.7.3.4

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


css::uno::DeploymentException

2012-05-21 Thread Terrence Enger
First, my thanks to Caolán McNamara and Stephan Bergmann for helping
me with my build problems.


Now, my build is successful, but soffice.bin falls over quickly with
css::uno::DeploymentException.  Before the program ends, I see ten
exceptions being thrown and caught; the attachment has a backtrace
from what I guess might be an interesting point.  Continuing from
there, I see ...

OStoreSuperBlock::verify(), finds m_aGuard.m_nMagic !=
STORE_MAGIC_SUPERBLOCK and returns store_E_WrongFormat.

SuperBlockPage::verify() sees this twice and returns
store_E_WrongFormat.  This return value propagates through six
call levels to ORegistry::initRegistry().

ORegistry::initRegistry() returns REG_INVALID_REGISTRY.  This
return value propagates through three call levels to
ServiceManager::readLegacyRdbFile().

ServiceManager::readLegacyRdbFile() decides that there is no good
reason for this result, and it returns false.

ServiceManager::readRdbFile() throws
css::uno::DeploymentException.  The program is well on its way to
falling over.  e.Message in the thrown exception says, with
newlines inserted freely, ...

file:///home/terry/lo_hacking/git/libo/solver/unxlngi6/
installation/opt/program/../share/extensions/
script-provider-for-python/components.rdb: duplicate



I have master commit d015384, pulled around 2012-05-20 12:53 UTC; but
I also saw the problem with master commit cdd4d96, pulled around
2012-05-15 15:15 UTC.  My latest configuration parameters are ...

--disable-mozilla
--enable-symbols
--enable-dbgutil
--enable-crashdump
--disable-build-mozilla
--without-system-postgresql
--enable-debug

but I also saw the problem when I configured with an additional ...

--enable-python=internal

(Yes, I have been reduced to poking things at random.  Sigh!)


Suggestions welcome.


Thanks,
Terry.

#0  OStoreSuperBlock::verify (this=0x8077f98) at 
/home/terry/lo_hacking/git/libo/store/source/storbios.cxx:161
#1  0x040dc83d in store::SuperBlockPage::verify (this=0x8077f78, rBIOS=...) at 
/home/terry/lo_hacking/git/libo/store/source/storbios.cxx:387
#2  0x040dcf21 in store::OStorePageBIOS::initialize_Impl (this=0x8068640, 
pLockBytes=0x8073d64, eAccessMode=store_AccessReadOnly, rnPageSize=@0xbfffe4fc) 
at /home/terry/lo_hacking/git/libo/store/source/storbios.cxx:624
#3  0x040dcde8 in store::OStorePageBIOS::initialize (this=0x8068640, 
pLockBytes=0x8073d64, eAccessMode=store_AccessReadOnly, rnPageSize=@0xbfffe4fc) 
at /home/terry/lo_hacking/git/libo/store/source/storbios.cxx:585
#4  0x040e7af9 in store::OStorePageManager::initialize (this=0x8068640, 
pLockBytes=0x8073d64, eAccessMode=store_AccessReadOnly, rnPageSize=@0xbfffe4fc) 
at /home/terry/lo_hacking/git/libo/store/source/storpage.cxx:95
#5  0x040eb796 in store_openFile (pFilename=0x806d8b0, 
eAccessMode=store_AccessReadOnly, nPageSize=512, phFile=0xbfffe59c) at 
/home/terry/lo_hacking/git/libo/store/source/store.cxx:174
#6  0x02f0f585 in store::OStoreFile::create (this=0xbfffe59c, rFilename=..., 
eAccessMode=store_AccessReadOnly, nPageSize=512) at 
/home/terry/lo_hacking/git/libo/solver/unxlngi6/inc/store/store.hxx:450
#7  0x02f0abd9 in ORegistry::initRegistry (this=0x8073fa0, regName=..., 
accessMode=1) at /home/terry/lo_hacking/git/libo/registry/source/regimpl.cxx:489
#8  0x02f153b8 in openRegistry (registryName=0x806d8b0, phRegistry=0xbfffe77c, 
accessMode=1) at 
/home/terry/lo_hacking/git/libo/registry/source/registry.cxx:174
#9  0x008e5ad3 in Registry::open (this=0xbfffe778, registryName=..., 
accessMode=1) at 
/home/terry/lo_hacking/git/libo/solver/unxlngi6/inc/registry/registry.hxx:1223
#10 0x008c2204 in (anonymous namespace)::ServiceManager::readLegacyRdbFile 
(this=0x806b890, uri=...) at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:1311
#11 0x008c20c0 in (anonymous namespace)::ServiceManager::readRdbFile 
(this=0x806b890, uri=..., optional=true) at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:1297
#12 0x008c1a3a in (anonymous namespace)::ServiceManager::readRdbs 
(this=0x806b890, uris=...) at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:1254
#13 0x008be354 in (anonymous namespace)::ServiceManager::ServiceManager 
(this=0x806b890, rdbUris=...) at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:575
#14 0x008c6a3a in (anonymous namespace)::bootstrapComponentContext 
(typeRegistry=uno::Reference to { = 
{_vptr.XInterface = 0x43b4d48}, }, serviceUris=..., 
bootstrap=...) at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:1791
#15 0x008c8563 in cppu::defaultBootstrap_InitialComponentContext (iniUri=...) 
at /home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:1995
#16 0x008c86ac in cppu::defaultBootstrap_InitialComponentContext () at 
/home/terry/lo_hacking/git/libo/cppuhelper/source/defaultbootstrap.cxx:

main in libsofficeapp ...

2012-05-21 Thread Michael Meeks
Hi Michael,

commit c7458a4a71a1e875e03772b0f6e8ad9e1a982006
Author: Michael Stahl 
Date:   Mon Mar 12 16:24:34 2012 +0100

desktop: libsofficeapp shouln't need a main()

Is that a random cleanup, or something that fixes an issue ? if the
latter, which issue ? :-)

The lo_main generated in there is needed by android to get some of our
samples bootstrapped & runnning.

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


License statement: Dwayne Bailey

2012-05-21 Thread Dwayne Bailey

Hi All,

All of my past and future contributions to LibreOffice may be licensed 
under the MPL/LGPLv3+ dual license.


--
Dwayne Bailey
+27 12 460 1095

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Michael Meeks

On Mon, 2012-05-21 at 18:06 +0200, Stephan Bergmann wrote:
> I rarely use a debugger to step through code, so I prefer to avoid the 

Egad - is this thread still going on :-) Could we create a set of the
pros / cons & a concrete proposal for the ESC call on Thursday ?

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

2012-05-21 Thread David Ostrovsky

Hi,

with this patch sal/rtl/source/macro.hxx is merged into configure 
process and

rtlbootstrap.mk is not generated any more.

Btw, it seems that we still do not have native 64-bit MacOS X port, why?

cat configure.in
[...]
darwin*)
[...]
i*86|x86_64)
CPU=I
CPUNAME=INTEL
RTL_ARCH=x86
[...]

Ciao
David

>From 3aa8559bddb9db832bd7c451d546ad970aae9f71 Mon Sep 17 00:00:00 2001
From: David Ostrovsky 
Date: Mon, 21 May 2012 19:01:29 +0200
Subject: [PATCH] fdo#50162 merge rtlbootstrap.mk into configure.in

Change-Id: I241be2704a069ec1f6be5861084039569673cc12
---
 config_host.mk.in |2 +
 configure.in  |   54 +-
 instsetoo_native/util/makefile.mk |1 -
 sal/CustomTarget_generated.mk |   21 +--
 sal/Library_sal.mk|2 +
 sal/Package_generated.mk  |1 -
 sal/rtl/source/bootstrap.cxx  |6 +-
 sal/rtl/source/macro.hxx  |  116 -
 sdext/platform.mk |8 +-
 solenv/inc/settings.mk|2 -
 10 files changed, 64 insertions(+), 149 deletions(-)
 delete mode 100644 sal/rtl/source/macro.hxx

diff --git a/config_host.mk.in b/config_host.mk.in
index 0a85bfd..76d4a1d 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -426,6 +426,8 @@ export REDLAND_CFLAGS=@REDLAND_CFLAGS@
 export REDLAND_LIBS=@REDLAND_LIBS@
 export RHINO_JAR=@RHINO_JAR@
 export RPM=@RPM@
+export RTL_OS=@RTL_OS@
+export RTL_ARCH=@RTL_ARCH@
 export SAC_JAR=@SAC_JAR@
 export SAL_ENABLE_FILE_LOCKING=1
 export SAMPLEICC_CFLAGS=@SAMPLEICC_CFLAGS@
diff --git a/configure.in b/configure.in
index 510d82a..64efe0a 100644
--- a/configure.in
+++ b/configure.in
@@ -2991,6 +2991,8 @@ aix*)
 GUI=UNX
 GUIBASE=unx
 OS=AIX
+RTL_OS=AIX
+RTL_ARCH=PowerPC
 OUTPATH=unxaigppc
 P_SEP=:
 SOLARLIB="-L../lib -L$SRC_ROOT/solenv/$OUTPATH/lib"
@@ -3003,6 +3005,7 @@ cygwin*)
 GUI=WNT
 GUIBASE=WIN
 OS=WNT
+RTL_OS=Windows
 P_SEP=";"
 
 case "$host_cpu" in
@@ -3010,11 +3013,13 @@ cygwin*)
 if test "$CL_X64" != ""; then
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 LIB64="lib/x64"
 OUTPATH=wntmscx$COMEX
 else
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=wntmsci$COMEX
 fi
 ;;
@@ -3033,12 +3038,14 @@ darwin*)
 # Not sure if "Aqua" is the right term to use?
 GUIBASE="aqua"
 OS=MACOSX
+RTL_OS=MacOSX
 P_SEP=:
 
 case "$host_cpu" in
 arm*)
 CPU=R
 CPUNAME=ARM
+RTL_ARCH=ARM_EABI
 GUIBASE=cocoatouch
 OUTPATH=unxiosr
 OS=IOS;
@@ -3046,11 +3053,13 @@ darwin*)
 powerpc*)
 CPU=P
 CPUNAME=POWERPC
+RTL_ARCH=PowerPC
 OUTPATH=unxmacxp
 ;;
 i*86|x86_64)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxmacxi
 ;;
 *)
@@ -3065,6 +3074,7 @@ dragonfly*)
 GUI=UNX
 GUIBASE=unx
 OS=DRAGONFLY
+RTL_OS=DragonFly
 OUTPATH=unxdfly
 P_SEP=:
 
@@ -3072,10 +3082,12 @@ dragonfly*)
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 ;;
 x86_64)
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 ;;
 *)
 AC_MSG_ERROR([Unsupported host_cpu $host_cpu for host_os $host_os])
@@ -3090,6 +3102,7 @@ freebsd*)
 COM=GCC
 GUI=UNX
 GUIBASE=unx
+RTL_OS=FreeBSD
 OS=FREEBSD
 OUTPATH=unxfbsd
 P_SEP=:
@@ -3098,11 +3111,13 @@ freebsd*)
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxfbsdi
 ;;
 x86_64)
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 ;;
 *)
 AC_MSG_ERROR([Unsupported host_cpu $host_cpu for host_os $host_os])
@@ -3118,17 +3133,19 @@ kfreebsd*)
 GUI=UNX
 GUIBASE=unx
 OS=LINUX
-
+RTL_OS=kFreeBSD
 case "$host_cpu" in
 
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxkfgi6
 ;;
 x86_64)
 CPU=X
 CPUNAME=X86_64
+RTL_ARCH=X86_64
 LIB64="lib64"
 OUTPATH=unxkfgx6
 ;;
@@ -3146,6 +3163,7 @@ linux-gnu*)
 GUI=UNX
 GUIBASE=unx
 OS=LINUX
+RTL_OS=Linux
 P_SEP=:
 
 case "$host_cpu" in
@@ -3153,89 +3171,105 @@ linux-gnu*)
 alpha)
 CPU=L
 CPUNAME=AXP
+RTL_ARCH=ALPHA
 OUTPATH=unxlngaxp
 ;;
 arm*)
 CPU=R
 CPUNAME=ARM
+RTL_ARCH=ARM_EABI
 EPM_FLAGS="-a arm"
 OUTPATH=unxlngr
 ;;
 hppa)
 CPU=H
 CPUNAME=HPPA
+RTL_ARCH=HPPA
 EPM_FLAGS="-a hppa"
 OUTPATH=unxlnghppa
 ;;
 i*86)
 CPU=I
 CPUNAME=INTEL
+RTL_ARCH=x86
 OUTPATH=unxlngi6
 ;;
 ia64)
 CPU=A
   

Re: GSoC Week 1

2012-05-21 Thread Michael Stahl
On 21/05/12 13:45, Tor Lillqvist wrote:
> You need to download tarballs for some recent version of automake and
> autoconf, configure and install them somewhere, like /usr/local. A bit
> of bother, yes. I wonder if we should start including a pre-autogened
> configure script somewhere in the git tree.

you mean, with 10.000 lines of changes per week, in the fine tradition
of OpenOffice.org?  :-P


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 3 commits - instsetoo_native/inc_openoffice solenv/bin

2012-05-21 Thread Andras Timar
 instsetoo_native/inc_openoffice/windows/msi_languages/LaunchCo.ulf |2 --
 instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf |6 
+++---
 instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf  |8 
+---
 instsetoo_native/inc_openoffice/windows/msi_templates/LaunchCo.idt |1 -
 solenv/bin/modules/installer/windows/property.pm   |3 ---
 5 files changed, 4 insertions(+), 16 deletions(-)

New commits:
commit 3d5c23f1cfeec3a9bc2f683e460e21afef728a6a
Author: Andras Timar 
Date:   Mon May 21 16:25:49 2012 +0200

MSI: remove always true LaunchCondition

Change-Id: Ia2b63502dbd8b5e4e0ca7faa34e06df73f094a78

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/LaunchCo.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/LaunchCo.ulf
index 20f2a60..e3f6f7f 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/LaunchCo.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/LaunchCo.ulf
@@ -1,4 +1,2 @@
 [OOO_LAUNCH_1]
 en-US = "The Installation Wizard cannot be run properly because you are logged 
in as a user without sufficient administrator rights for this system."
-[OOO_LAUNCH_2]
-en-US = "Please use the file setup.exe to start the installation."
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/LaunchCo.idt 
b/instsetoo_native/inc_openoffice/windows/msi_templates/LaunchCo.idt
index 7c8ee15..35d7869 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/LaunchCo.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/LaunchCo.idt
@@ -2,4 +2,3 @@ Condition   Description
 s255   l255
 WINDOWSENCODINGTEMPLATELaunchCondition Condition
 Privileged OOO_LAUNCH_1
-(VersionNT < 900) or (SETUP_USED=1) or Installed   OOO_LAUNCH_2
diff --git a/solenv/bin/modules/installer/windows/property.pm 
b/solenv/bin/modules/installer/windows/property.pm
index 934802d..32195e1 100644
--- a/solenv/bin/modules/installer/windows/property.pm
+++ b/solenv/bin/modules/installer/windows/property.pm
@@ -333,9 +333,6 @@ sub set_important_properties
 {
 my $onepropertyline = "ISPATCH" . "\t" . "1" . "\n";
 push(@{$propertyfile}, $onepropertyline);
-
-$onepropertyline = "SETUP_USED" . "\t" . "0" . "\n";
-push(@{$propertyfile}, $onepropertyline);
 }
 
 if ( $installer::globals::languagepack )
commit c5766287c119f9af704538bf1f861b3f2b6c0863
Author: Andras Timar 
Date:   Mon May 21 16:09:56 2012 +0200

strings for MSI Summary Info

Change-Id: Iae8eb4a1a7f3a0d429ac47f64a77dcd4404d14d1

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf
index 6429037..3376c3d 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf
@@ -1,14 +1,8 @@
 [OOO_SIS_TITLE]
 en-US = "Installation database"
 
-[OOO_SIS_AUTHOR]
-en-US = "Author"
-
-[OOO_SIS_SUBJECT]
-en-US = "Subject"
-
 [OOO_SIS_COMMENT]
-en-US = "Comment"
+en-US = "This installer database contains the logic and data required to 
install LibreOffice."
 
 [OOO_SIS_KEYWORDS]
 en-US = "Install,MSI"
commit 911d5488c58bb513fe9242097a388faa950ab702
Author: Andras Timar 
Date:   Mon May 21 16:00:53 2012 +0200

MSI: ARP strings for Summary Info

Change-Id: If47645a381a8da9851ba1bc19431f6341151906f

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
index 81ae531..b1bc76c 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
@@ -1,8 +1,8 @@
 [OOO_ARPCONTACTTEMPLATE]
-en-US = "Department for technical support"
+en-US = "LibreOffice Community"
 
 [OOO_ARPHELPLINKTEMPLATE]
-en-US = "http://www.documentfoundation.org";
+en-US = "http://www.libreoffice.org/get-help";
 
 [OOO_ARPHELPTELEPHONETEMPLATE]
 en-US = "x-xxx-xxx-xxx"
@@ -11,7 +11,7 @@ en-US = "x-xxx-xxx-xxx"
 en-US = "http://www.documentfoundation.org";
 
 [OOO_ARPURLUPDATEINFOTEMPLATE]
-en-US = "http://www.documentfoundation.org";
+en-US = "http://www.libreoffice.org/download";
 
 [OOO_STR_NEW_DISPLAY_NAME]
 en-US = "~New"
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Pierre-André Jacquod

Hello,

On 05/20/2012 11:24 PM, Norbert Thiebaud wrote:

On Wed, May 16, 2012 at 11:30 PM, Pierre-André Jacquod
  wrote:

expecting to get symbols without optimization, not wanting all asserts
outputs.


If you are intending to debug why wouldn't you want the misnamed
'assert output' ?
Better said, I do not care of them / are not useful: I try to solve some 
bugzilla points and it happens I have not yet have seen one caught by an 
assert :- )


Hence the minimum is the best for me. But yeah, I admit I most probably 
did not get the power of all this stuff.


Regards
Pierre-André
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


UPDATE: Swedish hunspell dictionary

2012-05-21 Thread Göran Andersson
The Swedish spell checking dictionary has been updated.
The latest version, 2.5, is available at
http://extensions.libreoffice.org/extension-center/swedish-spelling-dictionary-den-stora-svenska-ordlistan
(it can also be downloaded from http://code.google.com/p/dsso/downloads/list
).

There are now two versions of the dictionary; one for the sv_SE locale and
one for the sv_FI locale.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: codemaker/source

2012-05-21 Thread Michael Stahl
 codemaker/source/javamaker/classfile.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 26643fb59e0005f0bc83708b785d20d62d8e7411
Author: Michael Stahl 
Date:   Fri May 18 00:50:25 2012 +0200

codemaker: write version 49 (1.5) class files

The trick of writing generic types into class files of versions < 49
does no longer work with javac from OpenJDK 7:

/comphelper/qa/complex/comphelper/Map.java:154: error: type Pair does
not take parameters
  Pair< ?, ? >[] initialMappings = new Pair< ?, ? >[ _keys.length ];

There appears to be a related JDK bug for this, at some time javac had
an undocumented option to produce similar class files that are also
rejected now, this has been closed as "Not a Defect":

http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7078419

Change-Id: I8a504f6cbb3bb58cd914aebb88637cc6feb0bd48

diff --git a/codemaker/source/javamaker/classfile.cxx 
b/codemaker/source/javamaker/classfile.cxx
index 1a8bf01..8efdddb 100644
--- a/codemaker/source/javamaker/classfile.cxx
+++ b/codemaker/source/javamaker/classfile.cxx
@@ -693,7 +693,7 @@ void ClassFile::addMethod(
 void ClassFile::write(FileStream & file) const {
 writeU4(file, 0xCAFEBABE);
 writeU2(file, 0);
-writeU2(file, 46);
+writeU2(file, 49); // class file version of JRE 1.5
 writeU2(file, m_constantPoolCount);
 writeStream(file, m_constantPool);
 writeU2(file, static_cast< sal_uInt16 >(m_accessFlags));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[REVIEW][3-5] Re: fdo#40874 border macro regression

2012-05-21 Thread Michael Stahl
argh, set subject accordingly...

On 21/05/12 18:42, Michael Stahl wrote:
> 
> running macros that set borders is broken since 3.4, this commit should
> fix it and go into libreoffice-3-5:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=18ab7f52ebf78f41f824b2245a8a180d97081716


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


fdo#40874 border macro regression

2012-05-21 Thread Michael Stahl

running macros that set borders is broken since 3.4, this commit should
fix it and go into libreoffice-3-5:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=18ab7f52ebf78f41f824b2245a8a180d97081716

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 2 commits - editeng/source solenv/gbuild

2012-05-21 Thread Michael Stahl
 editeng/source/items/frmitems.cxx |   43 +++---
 solenv/gbuild/SdiTarget.mk|4 +++
 2 files changed, 44 insertions(+), 3 deletions(-)

New commits:
commit e81f02795425f2fcd910c9845adc8e9b919833f4
Author: Michael Stahl 
Date:   Mon May 21 18:10:46 2012 +0200

SdiTarget.mk: need explicit rule to get object files rebuilt

Without this, when changing sdi file, the objects that include the
generated header are only rebuilt at the second make invocation.

Change-Id: Idd52a12dd162ec780da3a3b9f24d3bdd9b408a33

diff --git a/solenv/gbuild/SdiTarget.mk b/solenv/gbuild/SdiTarget.mk
index d911856..43e38ab 100644
--- a/solenv/gbuild/SdiTarget.mk
+++ b/solenv/gbuild/SdiTarget.mk
@@ -52,6 +52,10 @@ $(call gb_SdiTarget_get_target,%) : $(SRCDIR)/%.sdi 
$(gb_SdiTarget_SVIDLTARGET)
-fM$(call gb_SdiTarget_get_dep_target,$*) \
$<)
 
+# rule necessary to rebuild cxx files that include the header
+$(call gb_SdiTarget_get_target,%.hxx) : $(call gb_SdiTarget_get_target,%)
+   @true
+
 ifeq ($(gb_FULLDEPS),$(true))
 $(call gb_SdiTarget_get_dep_target,%) :
$(if $(wildcard $@),touch $@,\
commit 18ab7f52ebf78f41f824b2245a8a180d97081716
Author: Michael Stahl 
Date:   Mon May 21 14:02:36 2012 +0200

fdo#40874: make recorded border macros run:

When the new BorderLine2 struct with its added members was introduced,
the PutValues methods that are called by the macro recorder with
seqeunces of Anys were not adapted, so running recorded macro for
".uno:BorderInner" ".uno:BorderOuter" ".uno:SetBorderStyle" fails.
(regression from b624e6e6cf2ecfc6e6e983af45212fce5e731006,
7db30f7aa037f52eb07cbb4fd2796bd869204af8)

Change-Id: Icd8a11d7f5c8d79c57020f213a1554540b6c666d

diff --git a/editeng/source/items/frmitems.cxx 
b/editeng/source/items/frmitems.cxx
index f98058e..8651534 100644
--- a/editeng/source/items/frmitems.cxx
+++ b/editeng/source/items/frmitems.cxx
@@ -2064,7 +2064,7 @@ bool SvxBoxItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 catch (const uno::Exception&) {}
 
 aNew >>= aSeq;
-if ( aSeq.getLength() == 4 )
+if (aSeq.getLength() >= 4 && aSeq.getLength() <= 6)
 {
 sal_Int32 nVal = 0;
 if ( aSeq[0] >>= nVal )
@@ -2075,6 +2075,20 @@ bool SvxBoxItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 aBorderLine.OuterLineWidth = (sal_Int16) nVal;
 if ( aSeq[3] >>= nVal )
 aBorderLine.LineDistance = (sal_Int16) nVal;
+if (aSeq.getLength() >= 5) // fdo#40874 added fields
+{
+if (aSeq[4] >>= nVal)
+{
+aBorderLine.LineStyle = nVal;
+}
+if (aSeq.getLength() >= 6)
+{
+if (aSeq[5] >>= nVal)
+{
+aBorderLine.LineWidth = nVal;
+}
+}
+}
 }
 else
 return sal_False;
@@ -2854,7 +2868,8 @@ bool SvxBoxInfoItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 try { aNew = xConverter->convertTo( rVal, ::getCppuType((const 
uno::Sequence < uno::Any >*)0) ); }
 catch (const uno::Exception&) {}
 
-if( (aNew >>= aSeq) && aSeq.getLength() == 4 )
+if ((aNew >>= aSeq) &&
+aSeq.getLength() >= 4  && aSeq.getLength() <= 6)
 {
 sal_Int32 nVal = 0;
 if ( aSeq[0] >>= nVal )
@@ -2865,6 +2880,20 @@ bool SvxBoxInfoItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 aBorderLine.OuterLineWidth = (sal_Int16) nVal;
 if ( aSeq[3] >>= nVal )
 aBorderLine.LineDistance = (sal_Int16) nVal;
+if (aSeq.getLength() >= 5) // fdo#40874 added fields
+{
+if (aSeq[4] >>= nVal)
+{
+aBorderLine.LineStyle = nVal;
+}
+if (aSeq.getLength() >= 6)
+{
+if (aSeq[5] >>= nVal)
+{
+aBorderLine.LineWidth = nVal;
+}
+}
+}
 }
 else
 return sal_False;
@@ -2874,12 +2903,20 @@ bool SvxBoxInfoItem::PutValue( const uno::Any& rVal, 
sal_uInt8 nMemberId )
 // serialization for basic macro recording
 ::com::sun::star::uno::Sequence < sal_Int16 > aSeq;
 rVal >>= aSeq;
-if ( aSeq.getL

Re: [REVIEW][3-5] fdo#42865, SVN 1.7, etc.

2012-05-21 Thread Michael Stahl
On 18/05/12 17:28, Michael Stahl wrote:
> * fdo#42865 the --enable-dbgutil only problem of _GLIBCXX_DEBUG adding a
> new symbol with unique linkage has re-surfaced and spread further, most
> likely due to the new std::string based SAL_LOG stuff; strangely it
> seems to work on Fedora 16 but on 17 it crashes and burns immediately in
> sal unit tests; attached patch fixes it for -3-5 (the Conflicts are all
> the gbuild converted libs on master, on -3-5 it is sufficient to fix the
> addsym.awk)

as cloph has found out, this breaks the build on Mac PPC (but
surprisingly not on Mac Intel), so the following commit is also necessary:
9b72a692ee3ef3381a0881ead4afa5bd73fff776

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Stephan Bergmann

On 05/21/2012 05:10 PM, Lubos Lunak wrote:

On Friday 18 of May 2012, Stephan Bergmann wrote:

Ah, you wanted --enable-dbgutil to disable -O2, the same way that
--enable-debug does.  Had missed that point.  Hm, as I said, I prefer my
--enable-dbgutil --disable-debug builds to be -O2.


  What is the point of that combination? As far as I can tell --enable-dbgutil
is like --enable-debug but for changes that are BIC, so only dbgutil without
debug does not make much sense to me.


I rarely use a debugger to step through code, so I prefer to avoid the 
--enable-debug settings that, AFAIU, are mainly there to aid in 
step-through debugging, but nevertheless cause potential deviation from 
a production build (like -O0, -fno-inline).



So if we change
--enable-dbgutil to imply -O0, I'd like to see that changeset also offer
a reliable way to get back -O2.  (And I'm not sure having to set
C(XX)FLAGS can be considered reliable enough, given that pre-set
C(XX)FLAGS impact more decisions in our build system than just -O2 vs.
-O0.  But maybe I'm asking for too much.)


  What other (relevant) decisions should be affected by that?


OK, tracing gb_LinkTarget__get_{c,objc,cxx,objcxx}flags 
(solenv/gbuild/LinkTarget.mk), for a --disable-debug build these 
environment variables indeed seem to only affect -O switches.  (From 
Michael Stahl's explanations, I would have assumed they would at least 
also affect -g switches, however.)  But looking at that code also shows 
that explicitly setting CFLAGS and CXXFLAGS would give potentially 
unexpected results -- one needs to set OBJCFLAGS and OBJCXXFLAGS as well 
-- which brings me back to my point of reliability.


Turning this around:  What is it that you find problematic with 
--enable-dbgutil not affecting the default -O2?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Michael Meeks  changed:

   What|Removed |Added

 Depends on||50173

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED:3-5][REVIEW:3-5-4?] fdo#48914 uninstall process should remove .pyc files from install directory

2012-05-21 Thread Petr Mladek
David Tardon píše v Pá 18. 05. 2012 v 12:44 +0200:
> On Wed, May 16, 2012 at 12:56:47PM +0200, Andras Timar wrote:
> > Hi,
> > 
> > When install location is writable to user (typical on Windows XP),
> > Python generates .pyc files. We can remove them using the RemoveFile
> > table in MSI. We generate an entry for each .py file in the install
> > set.
> 
> I did not actually try it, but the code looks sensible. Well, except the
> variable names ($filesinproductlanguageresolvedarrayref, seriously? :-),
> but these are not new...

It is pushed in 3-5, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=86d1dc9737a73e2034fb60e09c820b4fee64d83a

It looks fine to me. If we get one more approval, we could even add it
into 3-5-4 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 47644, which changed state.

Bug 47644 Summary: FILEOPEN: Huge load time and CPU load with .doc file
https://bugs.freedesktop.org/show_bug.cgi?id=47644

   What|Old Value   |New Value

 Resolution||FIXED
 Status|REOPENED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: --enable-debug vs --enable-symbols (Re: [Libreoffice-commits] .: 12 commits - config_host.mk.in configure.in filter/source oox/source sal/inc sc/source solenv/gbuild toolkit/source xmlhelp/source)

2012-05-21 Thread Lubos Lunak
On Friday 18 of May 2012, Stephan Bergmann wrote:
> On 05/18/2012 04:05 PM, Lubos Lunak wrote:
> > On Friday 18 of May 2012, Stephan Bergmann wrote:
> >> On 05/16/2012 05:01 PM, Lubos Lunak wrote:
> >>> - non-debug/dbgutils (i.e. also the default) ->   -O2
> >>> - symbols ->   -g  (probably even -g1, if this is actually meant for
> >>> release builds with debug info sufficient mainly for backtraces)
> >>> - debug/dbgutils ->   -g, making sure it overrides -g1 from symbols
> >>> - explicit C(XX)FLAGS overrides anything
> >>
> >> ...and, as something of a special case, no -O... at all (instead of the
> >> default -O2) for sc under --enable-debug=-sc/?
> >
> >   Yes, but I don't think it's special. The rule, missing in the list
> > above, would be 'debug/dbgutils ->  optimizations disabled'. So as soon
> > as there's --enable-debug, nothing would get -O2, regardless of symbols.
> >
> >   That's actually one more reason why I think -g should be primarily
> > controlled by --enable-symbols and not --enable-debug.
>
> Ah, you wanted --enable-dbgutil to disable -O2, the same way that
> --enable-debug does.  Had missed that point.  Hm, as I said, I prefer my
> --enable-dbgutil --disable-debug builds to be -O2.

 What is the point of that combination? As far as I can tell --enable-dbgutil 
is like --enable-debug but for changes that are BIC, so only dbgutil without 
debug does not make much sense to me.

> So if we change 
> --enable-dbgutil to imply -O0, I'd like to see that changeset also offer
> a reliable way to get back -O2.  (And I'm not sure having to set
> C(XX)FLAGS can be considered reliable enough, given that pre-set
> C(XX)FLAGS impact more decisions in our build system than just -O2 vs.
> -O0.  But maybe I'm asking for too much.)

 What other (relevant) decisions should be affected by that?

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED:3-5-4] Release notes: use bug titles instead of commit messages if possible

2012-05-21 Thread Petr Mladek
Ivan Timofeev píše v Pá 18. 05. 2012 v 20:44 +0400:
> On 18.05.2012 20:21, Petr Mladek wrote:
> > 2. The titles from other bugzillas were ignored because "-" in the title
> > was  wide character here. I am not sure why it worked for you.
> > Probably something with UTF-8 locales. Anyway, I solved it by
> > replacing:
> >
> > -   if ( $title =~ s/^Bug \d+ - // ) {
> > +   if ( $title =~ s/^Bug \d+ . // ) {
> >
> > It is not perfect but... Any better solution is welcome.
> 
> I simply copied that character (en dash) from what the $response->title 
> returns and pasted it to the regular expression...
> Maybe adding 'use utf8;' to the script will solve the problem?

Cool, 'use utf8;' helped. I have pushed it into master, see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=521ae23254b6fbf45d27cc76354bc774a453baf7


>> If you agree with my changes, I will push it also for 3-5 branch.
> Sure!

I have pushed all 4 commits into 3-5 branch.

Heh, it does not affect the application and there are only very few
people using the script. I think that we do not need triple review for
this => pushed also into 3-5-4 branch as well :-)

Thanks a lot for another great hint.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - bin/lo-commit-stat

2012-05-21 Thread Petr Mladek
 bin/lo-commit-stat |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 000a9304b79b2825c6f0606649b4971673667f62
Author: Ivan Timofeev 
Date:   Mon May 21 16:54:25 2012 +0200

lo-commit-stat: use utf8 to be able to query a dash in the bug title

Change-Id: I691616575b5ea0b35e0ec0cc98db6772a7ad3b25
Signed-off-by: Petr Mladek 

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index a61b326..1572924 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -5,6 +5,7 @@
 
 use strict;
 use LWP::UserAgent;
+use utf8;
 
 my $main_repo="core";
 my @pieces=("binfilter", "dictionaries", "help", "translations");
@@ -297,7 +298,7 @@ sub get_bug_name($$)
 my $response = $ua->get($url);
 if ($response->is_success) {
 my $title = $response->title;
-if ( $title =~ s/^Bug \d+ . // ) {
+if ( $title =~ s/^Bug \d+ – // ) {
 print "$title\n";
 return $title;
 } else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - bin/lo-commit-stat

2012-05-21 Thread Petr Mladek
 bin/lo-commit-stat |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ef4e83c698fa065de3242564d8c4e7aab5e86dd7
Author: Ivan Timofeev 
Date:   Mon May 21 16:54:25 2012 +0200

lo-commit-stat: use utf8 to be able to query a dash in the bug title

Change-Id: I691616575b5ea0b35e0ec0cc98db6772a7ad3b25
Signed-off-by: Petr Mladek 

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index a61b326..1572924 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -5,6 +5,7 @@
 
 use strict;
 use LWP::UserAgent;
+use utf8;
 
 my $main_repo="core";
 my @pieces=("binfilter", "dictionaries", "help", "translations");
@@ -297,7 +298,7 @@ sub get_bug_name($$)
 my $response = $ua->get($url);
 if ($response->is_success) {
 my $title = $response->title;
-if ( $title =~ s/^Bug \d+ . // ) {
+if ( $title =~ s/^Bug \d+ – // ) {
 print "$title\n";
 return $title;
 } else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: bin/lo-commit-stat

2012-05-21 Thread Petr Mladek
 bin/lo-commit-stat |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 521ae23254b6fbf45d27cc76354bc774a453baf7
Author: Ivan Timofeev 
Date:   Mon May 21 16:54:25 2012 +0200

lo-commit-stat: use utf8 to be able to query a dash in the bug title

Change-Id: I691616575b5ea0b35e0ec0cc98db6772a7ad3b25

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index a61b326..1572924 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -5,6 +5,7 @@
 
 use strict;
 use LWP::UserAgent;
+use utf8;
 
 my $main_repo="core";
 my @pieces=("binfilter", "dictionaries", "help", "translations");
@@ -297,7 +298,7 @@ sub get_bug_name($$)
 my $response = $ua->get($url);
 if ($response->is_success) {
 my $title = $response->title;
-if ( $title =~ s/^Bug \d+ . // ) {
+if ( $title =~ s/^Bug \d+ – // ) {
 print "$title\n";
 return $title;
 } else {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: feature/gbuild_scp2 is ready for review

2012-05-21 Thread David Tardon
On Sun, May 20, 2012 at 02:08:04PM -0500, Norbert Thiebaud wrote:
> ok, after some back and forth the result, on Mac, is:

Okay, so this simple comparison is useless in practice. I uploaded a new
version of the script that does the comparison in two steps: in first
step it removes the Dirs and Files lists and does a diff of the rest and
in second step it extracts the Dirs and Files lists for all modules,
sorts them and compares them. The output of the second step (if there is
any difference) is in pseudo-diff format.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - 3 commits - bin/lo-commit-stat

2012-05-21 Thread Petr Mladek
 bin/lo-commit-stat |  149 ++---
 1 file changed, 108 insertions(+), 41 deletions(-)

New commits:
commit 11f2d5842c45624f540becab4cc6833642e24b26
Author: Petr Mladek 
Date:   Fri May 18 18:02:37 2012 +0200

lo-commit-stat: problem with wide character in bug title

+ do not check for "-" in the bug title; it might be also wide character
  in some cases

+ show result when looking for bug titles

+ sort bugs when loolking for bug titles and printing bug numbers

Signed-off-by: Ivan Timofeev 

Change-Id: I39496f7d0cf5f7a116e7d3c506b76b4a3de1dee1

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index a14eb3e..a61b326 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -283,7 +283,7 @@ sub print_stat($$)
 sub get_bug_name($$)
 {
 my ($bug, $summary) = @_;
-print "$bug\n";
+print "$bug: ";
 
 $bug =~ m/(?:(\w*)\#+(\d+))/; # fdo#12345
 my $bugzilla = $1;# fdo
@@ -296,9 +296,12 @@ sub get_bug_name($$)
 $ua->env_proxy;
 my $response = $ua->get($url);
 if ($response->is_success) {
-my $title = $response->title();
-if ( $title =~ s/^Bug \d+ – // ) {
+my $title = $response->title;
+if ( $title =~ s/^Bug \d+ . // ) {
+print "$title\n";
 return $title;
+} else {
+print "warning: not found; using commit message\n";
 }
 }
 }
@@ -324,7 +327,8 @@ sub print_bugs($$)
 }
 
 # try to replace summaries with bug names from bugzilla
-foreach my $bug ( keys %bugs) {
+print "Getting bug titles:\n";
+foreach my $bug ( sort { $a cmp $b } keys %bugs) {
 $bugs{$bug}{'summary'} = get_bug_name($bug, $bugs{$bug}{'summary'});
 }
 
@@ -355,7 +359,7 @@ sub print_bugnumbers($$)
 }
 }
 
-printf $log join ("\n", keys %bugs) . "\n";
+printf $log join ("\n", sort { $a cmp $b } keys %bugs) . "\n";
 }
 
 
commit f1ea289d65d6704f5075b080b6a141c23984cb8e
Author: Ivan Timofeev 
Date:   Thu May 17 18:42:46 2012 +0400

lo-commit-stat: remove flags and print_filters

Signed-off-by: Petr Mladek 

Change-Id: I3d5ecb3cc52aeba780087f4ecb6b3bf86353276c

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index 1f067e2..a14eb3e 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -49,7 +49,6 @@ sub search_bugs()
 # save the bug number
 %{$pdata->{$piece}{$commit_id}{'bugs'}} = () if (! defined 
%{$pdata->{$piece}{$commit_id}{'bugs'}});
 $pdata->{$piece}{$commit_id}{'bugs'}{$bug} = 1;
-$pdata->{$piece}{$commit_id}{'flags'}{'bug'} = 1;
 }
 
 return $line;
@@ -99,7 +98,6 @@ sub load_git_log($)
 $commit_id = "$1";
 $summary=undef;
 %{$pdata->{$piece}{"$commit_id"}} = ();
-%{$pdata->{$piece}{"$commit_id"}{'flags'}} = ();
 next;
 }
 
@@ -222,23 +220,12 @@ sub open_log_file($)
 return $log;
 }
 
-sub print_summary_in_stat()
+sub print_summary_in_stat($$)
 {
-my ($summary, $pprint_filters, $ppiece_title, $pflags, $pbugs, $pauthors, 
$prefix, $log) = @_;
+my ($summary, $ppiece_title, $pbugs, $pauthors, $prefix, $log) = @_;
 
 return if ( $summary eq "" );
 
-# do we want to print this summary at all?
-my $print;
-if (%{$pprint_filters}) {
-foreach my $flag (keys %{$pprint_filters}) {
-$print = 1 if (defined $pflags->{$flag});
-}
-} else {
-$print = 1;
-}
-return unless (defined $print);
-
 # print piece title if not done yet
 if ( defined ${$ppiece_title} ) {
 printf $log "${$ppiece_title}\n";
@@ -259,9 +246,9 @@ sub print_summary_in_stat()
 printf $log $prefix . $summary . $bugs . $authors . "\n";
 }
 
-sub print_stat($$$)
+sub print_stat($$)
 {
-my ($pdata, $pprint_filters, $log) = @_;
+my ($pdata, $log) = @_;
 
 foreach my $piece ( sort { $a cmp $b } keys %{$pdata}) {
 # check if this piece has any entries at all
@@ -270,15 +257,13 @@ sub print_stat($$$)
 my $old_summary="";
 my %authors = ();
 my %bugs = ();
-my %flags = ();
 foreach my $id ( sort { $pdata->{$piece}{$a}{'summary'} cmp 
$pdata->{$piece}{$b}{'summary'} } keys %{$pdata->{$piece}}) {
 my $summary = $pdata->{$piece}{$id}{'summary'};
 if ($summary ne $old_summary) {
-print_summary_in_stat($old_summary, $pprint_filters, 
\$piece_title, \%flags, \%bugs, \%authors, "+ ", $log);
+print_summary_in_stat($old_summary, \$piece_title, \%bugs, 
\%authors, "+ ", $log);
 $old_summary = $summary;
 %authors = ();
 %bugs = ();
- 

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - bin/lo-commit-stat

2012-05-21 Thread Petr Mladek
 bin/lo-commit-stat |  149 ++---
 1 file changed, 108 insertions(+), 41 deletions(-)

New commits:
commit 3284aaff33c4fa875053798439d5a1ed69c00a82
Author: Petr Mladek 
Date:   Fri May 18 18:02:37 2012 +0200

lo-commit-stat: problem with wide character in bug title

+ do not check for "-" in the bug title; it might be also wide character
  in some cases

+ show result when looking for bug titles

+ sort bugs when loolking for bug titles and printing bug numbers

Signed-off-by: Ivan Timofeev 

Change-Id: I39496f7d0cf5f7a116e7d3c506b76b4a3de1dee1

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index a14eb3e..a61b326 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -283,7 +283,7 @@ sub print_stat($$)
 sub get_bug_name($$)
 {
 my ($bug, $summary) = @_;
-print "$bug\n";
+print "$bug: ";
 
 $bug =~ m/(?:(\w*)\#+(\d+))/; # fdo#12345
 my $bugzilla = $1;# fdo
@@ -296,9 +296,12 @@ sub get_bug_name($$)
 $ua->env_proxy;
 my $response = $ua->get($url);
 if ($response->is_success) {
-my $title = $response->title();
-if ( $title =~ s/^Bug \d+ – // ) {
+my $title = $response->title;
+if ( $title =~ s/^Bug \d+ . // ) {
+print "$title\n";
 return $title;
+} else {
+print "warning: not found; using commit message\n";
 }
 }
 }
@@ -324,7 +327,8 @@ sub print_bugs($$)
 }
 
 # try to replace summaries with bug names from bugzilla
-foreach my $bug ( keys %bugs) {
+print "Getting bug titles:\n";
+foreach my $bug ( sort { $a cmp $b } keys %bugs) {
 $bugs{$bug}{'summary'} = get_bug_name($bug, $bugs{$bug}{'summary'});
 }
 
@@ -355,7 +359,7 @@ sub print_bugnumbers($$)
 }
 }
 
-printf $log join ("\n", keys %bugs) . "\n";
+printf $log join ("\n", sort { $a cmp $b } keys %bugs) . "\n";
 }
 
 
commit 50981a067f5e2e2126af549b51da191e7aeb61da
Author: Ivan Timofeev 
Date:   Thu May 17 18:42:46 2012 +0400

lo-commit-stat: remove flags and print_filters

Signed-off-by: Petr Mladek 

Change-Id: I3d5ecb3cc52aeba780087f4ecb6b3bf86353276c

diff --git a/bin/lo-commit-stat b/bin/lo-commit-stat
index 1f067e2..a14eb3e 100755
--- a/bin/lo-commit-stat
+++ b/bin/lo-commit-stat
@@ -49,7 +49,6 @@ sub search_bugs()
 # save the bug number
 %{$pdata->{$piece}{$commit_id}{'bugs'}} = () if (! defined 
%{$pdata->{$piece}{$commit_id}{'bugs'}});
 $pdata->{$piece}{$commit_id}{'bugs'}{$bug} = 1;
-$pdata->{$piece}{$commit_id}{'flags'}{'bug'} = 1;
 }
 
 return $line;
@@ -99,7 +98,6 @@ sub load_git_log($)
 $commit_id = "$1";
 $summary=undef;
 %{$pdata->{$piece}{"$commit_id"}} = ();
-%{$pdata->{$piece}{"$commit_id"}{'flags'}} = ();
 next;
 }
 
@@ -222,23 +220,12 @@ sub open_log_file($)
 return $log;
 }
 
-sub print_summary_in_stat()
+sub print_summary_in_stat($$)
 {
-my ($summary, $pprint_filters, $ppiece_title, $pflags, $pbugs, $pauthors, 
$prefix, $log) = @_;
+my ($summary, $ppiece_title, $pbugs, $pauthors, $prefix, $log) = @_;
 
 return if ( $summary eq "" );
 
-# do we want to print this summary at all?
-my $print;
-if (%{$pprint_filters}) {
-foreach my $flag (keys %{$pprint_filters}) {
-$print = 1 if (defined $pflags->{$flag});
-}
-} else {
-$print = 1;
-}
-return unless (defined $print);
-
 # print piece title if not done yet
 if ( defined ${$ppiece_title} ) {
 printf $log "${$ppiece_title}\n";
@@ -259,9 +246,9 @@ sub print_summary_in_stat()
 printf $log $prefix . $summary . $bugs . $authors . "\n";
 }
 
-sub print_stat($$$)
+sub print_stat($$)
 {
-my ($pdata, $pprint_filters, $log) = @_;
+my ($pdata, $log) = @_;
 
 foreach my $piece ( sort { $a cmp $b } keys %{$pdata}) {
 # check if this piece has any entries at all
@@ -270,15 +257,13 @@ sub print_stat($$$)
 my $old_summary="";
 my %authors = ();
 my %bugs = ();
-my %flags = ();
 foreach my $id ( sort { $pdata->{$piece}{$a}{'summary'} cmp 
$pdata->{$piece}{$b}{'summary'} } keys %{$pdata->{$piece}}) {
 my $summary = $pdata->{$piece}{$id}{'summary'};
 if ($summary ne $old_summary) {
-print_summary_in_stat($old_summary, $pprint_filters, 
\$piece_title, \%flags, \%bugs, \%authors, "+ ", $log);
+print_summary_in_stat($old_summary, \$piece_title, \%bugs, 
\%authors, "+ ", $log);
 $old_summary = $summary;
 %authors = ();
 %bugs = ();
- 

[Libreoffice-commits] .: writerfilter/Library_writerfilter.mk

2012-05-21 Thread Matus Kukan
 writerfilter/Library_writerfilter.mk |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 4283c433b91bb2b1d9479bc071d8c02e0c3c4d69
Author: Matúš Kukan 
Date:   Sat May 19 10:10:16 2012 +0200

add dependency on generated files

Change-Id: Idad4558cfa741f1f2e17b270989a8a96ac80dd06

diff --git a/writerfilter/Library_writerfilter.mk 
b/writerfilter/Library_writerfilter.mk
index 0964cac..b06ee75 100644
--- a/writerfilter/Library_writerfilter.mk
+++ b/writerfilter/Library_writerfilter.mk
@@ -30,6 +30,10 @@ include $(SRCDIR)/writerfilter/source/generated.mk
 
 $(eval $(call gb_Library_Library,writerfilter))
 
+$(eval $(call gb_Library_use_custom_headers,writerfilter,\
+   writerfilter/source \
+))
+
 $(eval $(call gb_Library_set_include,writerfilter,\
 $$(INCLUDE) \
 -I$(SRCDIR)/writerfilter/inc \
@@ -37,7 +41,6 @@ $(eval $(call gb_Library_set_include,writerfilter,\
 -I$(SRCDIR)/writerfilter/source/dmapper \
 -I$(SRCDIR)/writerfilter/source/doctok \
 -I$(SRCDIR)/writerfilter/source/ooxml \
--I$(WORKDIR)/CustomTarget/writerfilter/source \
 -I$(WORKDIR)/CustomTarget/writerfilter/source/doctok \
 -I$(WORKDIR)/CustomTarget/writerfilter/source/ooxml \
 ))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [Libreoffice] [GSoC 2011][svg export filter] GSoC project start

2012-05-21 Thread Marco Cecchetti
On Mon, 21 May 2012 12:45:37 +0200, Christian Lohmaier  
 wrote:



Hi Marco,

On Mon, May 21, 2012 at 9:12 AM, Marco Cecchetti   
wrote:


Hi Thorsten, everyone,
so it's time to start working on the project. :)

I pushed a new feature branch named feature/svg-export,
where I'll commit all contributions I 'm going to provide
on GSoC time-frame.


Shameless abuse of your thread, but related:
Please rething your decision about having the browser scale svg being
more important than other tools processing the svg with the expected
size.

https://bugs.freedesktop.org/show_bug.cgi?id=43060

So please put
* use coordinate system that all tools agree upon.

As mentioned in the bug either use no units and convert to pixel, or
specify size with units. I really think having it scaled in the
browser is less important than not breaking other tools that run out
of memory because they assume pixels.




Hi Christian,
I was not aware of this problem, anyway having a presentation
not resized automatically and placed top left is not really appealing.
For these reasons I take the following decision: export of page extents
with units is back but only when a single slide/page is exported.

Cheers,
-- Marco

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-05-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 47644, which changed state.

Bug 47644 Summary: FILEOPEN: Huge load time and CPU load with .doc file
https://bugs.freedesktop.org/show_bug.cgi?id=47644

   What|Old Value   |New Value

 Resolution|FIXED   |
 Status|VERIFIED|REOPENED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Petr Mladek
Fridrich Strba píše v Po 21. 05. 2012 v 16:12 +0200:
> +1 from me for 3.5.4

Thanks for approvals. This was the third one => pushed into 3-5-4
branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=20987a1d0ec675f3a23a4be58eb7309f60fc62de
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=d4f45305ecdb38d3c2b5f91ec4f29cb89e29f770


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'feature/svg-export' - filter/source

2012-05-21 Thread Marco Cecchetti
 filter/source/svg/svgexport.cxx |   18 ++
 1 file changed, 18 insertions(+)

New commits:
commit 0fb8a4ef462f53ec8ac8aa0ff8bc78884e0d223d
Author: Marco Cecchetti 
Date:   Mon May 21 16:08:11 2012 +0200

In order to fix bug 43060 the width and height attributes are exported  
with units (mm)  for the  element when a single slide/page is exported.

diff --git a/filter/source/svg/svgexport.cxx b/filter/source/svg/svgexport.cxx
index e73074a..39e8feb 100644
--- a/filter/source/svg/svgexport.cxx
+++ b/filter/source/svg/svgexport.cxx
@@ -704,6 +704,24 @@ sal_Bool SVGFilter::implExportDocument()
 if( mpSVGExport->IsUseTinyProfile() )
  mpSVGExport->AddAttribute( XML_NAMESPACE_NONE, "baseProfile", 
B2UCONST( "tiny" ) );
 
+// enabling _SVG_WRITE_EXTENTS means that the slide size is not adapted
+// to the size of the browser window, moreover the slide is top left 
aligned
+// instead of centered.
+#define _SVG_WRITE_EXTENTS
+#ifdef _SVG_WRITE_EXTENTS
+if( mbSinglePage )
+{
+aAttr = OUString::valueOf( nDocWidth * 0.01 );
+aAttr += B2UCONST( "mm" );
+mpSVGExport->AddAttribute( XML_NAMESPACE_NONE, "width", aAttr );
+
+aAttr = OUString::valueOf( nDocHeight * 0.01 );
+aAttr += B2UCONST( "mm" );
+mpSVGExport->AddAttribute( XML_NAMESPACE_NONE, "height", aAttr );
+}
+#endif
+
+
 aAttr = B2UCONST( "0 0 " );
 aAttr += OUString::valueOf( nDocWidth );
 aAttr += B2UCONST( " " );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - vcl/unx

2012-05-21 Thread Bjoern Michaelsen
 vcl/unx/gtk/window/gtkframe.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 5ae02ce08a270ea7a5c0dd6d37d95a29be2cbbf0
Author: Bjoern Michaelsen 
Date:   Sun May 20 00:25:07 2012 +0200

fdo#50173: fix Styles and Formatting gtk crasher

- when using the gtk vcl plugin, pressing F11 in writer crashes
  libreoffice on some systems with an X error
- related: fdo#46687

Change-Id: I235cf327d812b606a357de859b1a959be728d2a1
Signed-off-by: Michael Meeks 
Signed-off-by: Fridrich Å trba 
Signed-off-by: Lubos Lunak 

diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index 3488adb..c5df600 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -3288,6 +3288,7 @@ gboolean GtkSalFrame::signalMap( GtkWidget *pWidget, 
GdkEvent*, gpointer frame )
 XSetInputFocus( pThis->getDisplay()->GetDisplay(),
 widget_get_xid(pWidget),
 RevertToParent, CurrentTime );
+XSync( pThis->getDisplay()->GetDisplay(), False );
 GetGenericData()->ErrorTrapPop();
 }
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - 2 commits - jpeg/makefile.mk jpeg/struct_alignment.patch

2012-05-21 Thread Petr Mladek
 jpeg/makefile.mk|9 +---
 jpeg/struct_alignment.patch |   48 
 2 files changed, 54 insertions(+), 3 deletions(-)

New commits:
commit d4f45305ecdb38d3c2b5f91ec4f29cb89e29f770
Author: Christian Lohmaier 
Date:   Sat May 19 14:05:10 2012 +0200

fdo#47035: Fix saving of jpeg files on Mac/PPC

jpeg_compress_struct gets padded with the same effect as the
jpeg_decompress_struct, so needs some reordering as well to make Mac/PPC
happy (a27a399)

Signed-off-by: Petr Mladek 
Signed-off-by: Tor Lillqvist 
Signed-off-by: Fridrich Strba 

diff --git a/jpeg/struct_alignment.patch b/jpeg/struct_alignment.patch
index 2eb41bf..09966c3 100644
--- a/jpeg/struct_alignment.patch
+++ b/jpeg/struct_alignment.patch
@@ -1,8 +1,38 @@
-without this patch, the jpeg_decompress_struct will be padded, this in turn
+without this patch, the jpeg_decompress_struct & jpec_compress_struct will be 
padded, this in turn
 results in a mismatch when the jpeg filter in svtools is built, where no
 padding is assumed. Only affects Mac/PPC apparenlty, see fdo#47035
 --- misc/jpeg-8c/jpeglib.h 2010-11-17 22:01:56.0 +0100
-+++ misc/build/jpeg-8c/jpeglib.h   2012-05-19 03:38:44.0 +0200
 misc/build/jpeg-8c/jpeglib.h   2012-05-19 13:58:31.0 +0200
+@@ -288,9 +288,9 @@
+   JDIMENSION image_width; /* input image width */
+   JDIMENSION image_height;/* input image height */
+   int input_components;   /* # of color components in input image 
*/
+-  J_COLOR_SPACE in_color_space;   /* colorspace of input image */
+ 
+   double input_gamma; /* image gamma of input image */
++  J_COLOR_SPACE in_color_space;   /* colorspace of input image */
+ 
+   /* Compression parameters --- these fields must be set before calling
+* jpeg_start_compress().  We recommend calling jpeg_set_defaults() to
+@@ -359,16 +359,16 @@
+   /* Parameters controlling emission of special markers. */
+ 
+   boolean write_JFIF_header;  /* should a JFIF marker be written? */
++  boolean write_Adobe_marker; /* should an Adobe marker be written? */
+   UINT8 JFIF_major_version;   /* What to write for the JFIF version number */
+   UINT8 JFIF_minor_version;
+   /* These three values are not used by the JPEG code, merely copied */
+   /* into the JFIF APP0 marker.  density_unit can be 0 for unknown, */
+   /* 1 for dots/inch, or 2 for dots/cm.  Note that the pixel aspect */
+   /* ratio is defined by X_density/Y_density even when density_unit=0. */
+-  UINT8 density_unit; /* JFIF code for pixel size units */
+   UINT16 X_density;   /* Horizontal pixel density */
+   UINT16 Y_density;   /* Vertical pixel density */
+-  boolean write_Adobe_marker; /* should an Adobe marker be written? */
++  UINT8 density_unit; /* JFIF code for pixel size units */
+   
+   /* State variable: index of next scanline to be written to
+* jpeg_write_scanlines().  Application may use this to control its
 @@ -583,11 +583,11 @@
/* Data copied from JFIF marker; only valid if saw_JFIF_marker is TRUE: */
UINT8 JFIF_major_version;   /* JFIF version number */
commit 20987a1d0ec675f3a23a4be58eb7309f60fc62de
Author: Christian Lohmaier 
Date:   Sat May 19 04:02:42 2012 +0200

fdo#47035: Fix loading of jpeg files on Mac/PPC

jpeg_decompress_struct gets padded when compiling libjpeg, but the
jpeg filter in svtools assume non-padded size, resulting in a mismatch
that makes libjpeg refuse to do its work.

Signed-off-by: Petr Mladek 
Signed-off-by: Tor Lillqvist 
Signed-off-by: Fridrich Strba 

diff --git a/jpeg/makefile.mk b/jpeg/makefile.mk
index adc0c66..3c6cf49 100644
--- a/jpeg/makefile.mk
+++ b/jpeg/makefile.mk
@@ -36,8 +36,8 @@ TARGET=jpeg
 
 .IF "$(SYSTEM_JPEG)" == "YES"
 all:
-@echo "An already available installation of libjpeg should exist on your 
system."
-@echo "Therefore the version provided here does not need to be built in 
addition."
+   @echo "An already available installation of libjpeg should exist on 
your system."
+   @echo "Therefore the version provided here does not need to be built in 
addition."
 .ENDIF
 
 # --- Files 
@@ -50,6 +50,9 @@ TARFILE_MD5=a2c10c04f396a9ce72894beb18b4e1f9
 
 #PATCH_FILES=jpeg-6b.patch
 PATCH_FILES=jpeg-8c.patch
+.IF "$(OS)$(CPU)"=="MACOSXP"
+PATCH_FILES+=struct_alignment.patch
+.ENDIF
 
 ADDITIONAL_FILES=makefile.mk jconfig.h 
 
@@ -58,7 +61,7 @@ ADDITIONAL_FILES=makefile.mk jconfig.h
 BUILD_DIR=$(CONFIGURE_DIR)
 BUILD_ACTION=dmake $(MFLAGS) $(CALLMACROS)
 
-OUT2INC=   jconfig.h   \
+OUT2INC=jconfig.h  \
 jerror.h   \
 jmorecfg.h \
 jpegint.h  \
diff --git a/jpeg/struct_alignment.patch b/jpeg/struct_alignment.patch
new file mode 100644
index 000..2eb41bf
--- /dev/null
+++ b/jpeg/struct_alignment.patch
@@ -0,0 

Re: [REVIEW:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Norbert Thiebaud
On Mon, May 21, 2012 at 7:08 AM, Petr Mladek  wrote:
> Christian Lohmaier píše v So 19. 05. 2012 v 14:12 +0200:
>> Hi *,
>>
>> please review and pick for 3.5 & 3.5.4 if possible. It is Mac PPC
>> only, and no change of the logic of the code, but just reordering to
>> avoid padding of elements in two structs in libjpeg.
>>
>> bug:
>> https://bugs.freedesktop.org/show_bug.cgi?id=47035
>>
>> changes:
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a27a3990b8bbfa8924d2b55c38ceab7c9049ea6d
>>
>> and
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8ecb8801f4330c2d2da88b992e2039e020d4fa4
>>
>> The padding is the cause of a regression compared to LO 3.4.x that
>> makes it impossible to open/insert and jpeg images.
>>
>> When trying to open/save a jpeg on Mac/PPC one gets a "Graphic filter
>> not found" message
>
> Great catch! I can't test it myself on MAC but I believe that you did
> it. The patch makes sense => pushed into 3-5 branch, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=efdd08cf8985c0b322ef94f62877caa5c4b3694d
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a220ec769d6489df7f3dd01cf25ea59dfd793276
>
> We need two more approvals for 3-5-4.

(non-suse) +1
:-)

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - vcl/unx

2012-05-21 Thread Bjoern Michaelsen
 vcl/unx/gtk/window/gtkframe.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4e9eca4feb3115869107d71db464a08448a001aa
Author: Bjoern Michaelsen 
Date:   Sun May 20 00:25:07 2012 +0200

fdo#50173: fix Styles and Formatting gtk crasher

- when using the gtk vcl plugin, pressing F11 in writer crashes
  libreoffice on some systems with an X error
- related: fdo#46687

Change-Id: I235cf327d812b606a357de859b1a959be728d2a1
Signed-off-by: Michael Meeks 

diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index 3488adb..c5df600 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -3288,6 +3288,7 @@ gboolean GtkSalFrame::signalMap( GtkWidget *pWidget, 
GdkEvent*, gpointer frame )
 XSetInputFocus( pThis->getDisplay()->GetDisplay(),
 widget_get_xid(pWidget),
 RevertToParent, CurrentTime );
+XSync( pThis->getDisplay()->GetDisplay(), False );
 GetGenericData()->ErrorTrapPop();
 }
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [PUSHED:3-5-4] crasher fdo#45987

2012-05-21 Thread Petr Mladek
Kohei Yoshida píše v Pá 18. 05. 2012 v 14:39 -0400:
> On Fri, May 18, 2012 at 1:43 PM, Markus Mohrhard
>  wrote:
> > Hello Noel, Kohei,
> >
> > I think [1] is a better patch for 3-5. I'm still not happy with it
> > because I had hoped that we could init the number of sheets already in
> > the constructor but this works only while loading a file and not when
> > we create an empty one. This hack is a bit dirty but was the only
> > useful place that already knows about the number of sheets and does
> > not force us to create some more ugly hacks. It just makes sure that
> > the number of sheets in ScViewData and ScDocument is the same.
> >
> > It is a safe fix and we can include it in 3-5.
> 
> I concur.  I also verified that this change fixes the reported bug.
> 
> Pushed to 3-5 with my sign off.

It looks sane. I have got third approval from Noel on irc and pushed
into 3-5-4 branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-4&id=6c24c4f0becb40ac0450ccdb49c9af4ebcbd581b


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: Branch 'libreoffice-3-5-4' - sc/source

2012-05-21 Thread Petr Mladek
 sc/source/ui/view/viewdata.cxx |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit 6c24c4f0becb40ac0450ccdb49c9af4ebcbd581b
Author: Markus Mohrhard 
Date:   Fri May 18 19:34:11 2012 +0200

ensure that number of tabs is correctly set in ScViewData, fdo#45987

Signed-off-by: Kohei Yoshida 
Signed-off-by: Petr Mladek 
Signed-off-by: Noel Power 

Change-Id: Ia77ea939f6ce9301afeabe1d1679998ce34b397e

diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 26c6346..ee7ab0d 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -2737,6 +2737,9 @@ void ScViewData::ReadUserDataSequence(const uno::Sequence 

 sal_Int32 nTemp32(0);
 sal_Int16 nTemp16(0);
 sal_Bool bPageMode(false);
+
+EnsureTabDataSize(GetDocument()->GetTableCount()-1);
+
 for (sal_Int32 i = 0; i < nCount; i++)
 {
 // SC_VIEWID has to parse and use by mba
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: [REVIEWED] [3.5-4] crasher fdo#45987

2012-05-21 Thread Noel Power

On 18/05/12 19:39, Kohei Yoshida wrote:

On Fri, May 18, 2012 at 1:43 PM, Markus Mohrhard
  wrote:

Hello Noel, Kohei,

I think [1] is a better patch for 3-5. I'm still not happy with it
because I had hoped that we could init the number of sheets already in
the constructor but this works only while loading a file and not when
we create an empty one. This hack is a bit dirty but was the only
useful place that already knows about the number of sheets and does
not force us to create some more ugly hacks. It just makes sure that
the number of sheets in ScViewData and ScDocument is the same.

It is a safe fix and we can include it in 3-5.

I concur.  I also verified that this change fixes the reported bug.

Pushed to 3-5 with my sign off.

need that for 3-5-4, I think Petr will push it, so will update the 
subject when that happens


Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [REVIEW:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Fridrich Strba
+1 from me for 3.5.4

F.

On 21/05/12 16:08, Petr Mladek wrote:
> Christian Lohmaier píše v So 19. 05. 2012 v 14:12 +0200:
>> Hi *,
>>
>> please review and pick for 3.5 & 3.5.4 if possible. It is Mac PPC
>> only, and no change of the logic of the code, but just reordering to
>> avoid padding of elements in two structs in libjpeg.
>>
>> bug:
>> https://bugs.freedesktop.org/show_bug.cgi?id=47035
>>
>> changes:
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a27a3990b8bbfa8924d2b55c38ceab7c9049ea6d
>>
>> and
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8ecb8801f4330c2d2da88b992e2039e020d4fa4
>>
>> The padding is the cause of a regression compared to LO 3.4.x that
>> makes it impossible to open/insert and jpeg images.
>>
>> When trying to open/save a jpeg on Mac/PPC one gets a "Graphic filter
>> not found" message
> 
> Great catch! I can't test it myself on MAC but I believe that you did
> it. The patch makes sense => pushed into 3-5 branch, see
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=efdd08cf8985c0b322ef94f62877caa5c4b3694d
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a220ec769d6489df7f3dd01cf25ea59dfd793276
> 
> We need two more approvals for 3-5-4.
> 
> 
> Best Regards,
> Petr
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [REVIEW:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Tor Lillqvist
> We need two more approvals for 3-5-4.

If one more from SUSE counts, +1.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [REVIEW:3-5-4] fdo#47035: Fix loading & saving of jpeg files on Mac/PPC

2012-05-21 Thread Petr Mladek
Christian Lohmaier píše v So 19. 05. 2012 v 14:12 +0200:
> Hi *,
> 
> please review and pick for 3.5 & 3.5.4 if possible. It is Mac PPC
> only, and no change of the logic of the code, but just reordering to
> avoid padding of elements in two structs in libjpeg.
> 
> bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=47035
> 
> changes:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a27a3990b8bbfa8924d2b55c38ceab7c9049ea6d
> 
> and
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=a8ecb8801f4330c2d2da88b992e2039e020d4fa4
> 
> The padding is the cause of a regression compared to LO 3.4.x that
> makes it impossible to open/insert and jpeg images.
> 
> When trying to open/save a jpeg on Mac/PPC one gets a "Graphic filter
> not found" message

Great catch! I can't test it myself on MAC but I believe that you did
it. The patch makes sense => pushed into 3-5 branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=efdd08cf8985c0b322ef94f62877caa5c4b3694d
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=a220ec769d6489df7f3dd01cf25ea59dfd793276

We need two more approvals for 3-5-4.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: vcl/unx

2012-05-21 Thread Bjoern Michaelsen
 vcl/unx/gtk/window/gtkframe.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 21f8ec1c49efd716669ca55ab946fadd5c97bb7e
Author: Bjoern Michaelsen 
Date:   Sun May 20 00:25:07 2012 +0200

fdo#50173: fix Styles and Formatting gtk crasher

- when using the gtk vcl plugin, pressing F11 in writer crashes
  libreoffice on some systems with an X error
- related: fdo#46687

Change-Id: I235cf327d812b606a357de859b1a959be728d2a1

diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index eb77e75..36be0b2 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -3248,6 +3248,7 @@ gboolean GtkSalFrame::signalMap( GtkWidget *pWidget, 
GdkEvent*, gpointer frame )
 XSetInputFocus( pThis->getDisplay()->GetDisplay(),
 widget_get_xid(pWidget),
 RevertToParent, CurrentTime );
+XSync( pThis->getDisplay()->GetDisplay(), False );
 GetGenericData()->ErrorTrapPop();
 }
 #else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 2 commits - jpeg/makefile.mk jpeg/struct_alignment.patch

2012-05-21 Thread Petr Mladek
 jpeg/makefile.mk|9 +---
 jpeg/struct_alignment.patch |   48 
 2 files changed, 54 insertions(+), 3 deletions(-)

New commits:
commit a220ec769d6489df7f3dd01cf25ea59dfd793276
Author: Christian Lohmaier 
Date:   Sat May 19 14:05:10 2012 +0200

fdo#47035: Fix saving of jpeg files on Mac/PPC

jpeg_compress_struct gets padded with the same effect as the
jpeg_decompress_struct, so needs some reordering as well to make Mac/PPC
happy (a27a399)

Signed-off-by: Petr Mladek 

diff --git a/jpeg/struct_alignment.patch b/jpeg/struct_alignment.patch
index 2eb41bf..09966c3 100644
--- a/jpeg/struct_alignment.patch
+++ b/jpeg/struct_alignment.patch
@@ -1,8 +1,38 @@
-without this patch, the jpeg_decompress_struct will be padded, this in turn
+without this patch, the jpeg_decompress_struct & jpec_compress_struct will be 
padded, this in turn
 results in a mismatch when the jpeg filter in svtools is built, where no
 padding is assumed. Only affects Mac/PPC apparenlty, see fdo#47035
 --- misc/jpeg-8c/jpeglib.h 2010-11-17 22:01:56.0 +0100
-+++ misc/build/jpeg-8c/jpeglib.h   2012-05-19 03:38:44.0 +0200
 misc/build/jpeg-8c/jpeglib.h   2012-05-19 13:58:31.0 +0200
+@@ -288,9 +288,9 @@
+   JDIMENSION image_width; /* input image width */
+   JDIMENSION image_height;/* input image height */
+   int input_components;   /* # of color components in input image 
*/
+-  J_COLOR_SPACE in_color_space;   /* colorspace of input image */
+ 
+   double input_gamma; /* image gamma of input image */
++  J_COLOR_SPACE in_color_space;   /* colorspace of input image */
+ 
+   /* Compression parameters --- these fields must be set before calling
+* jpeg_start_compress().  We recommend calling jpeg_set_defaults() to
+@@ -359,16 +359,16 @@
+   /* Parameters controlling emission of special markers. */
+ 
+   boolean write_JFIF_header;  /* should a JFIF marker be written? */
++  boolean write_Adobe_marker; /* should an Adobe marker be written? */
+   UINT8 JFIF_major_version;   /* What to write for the JFIF version number */
+   UINT8 JFIF_minor_version;
+   /* These three values are not used by the JPEG code, merely copied */
+   /* into the JFIF APP0 marker.  density_unit can be 0 for unknown, */
+   /* 1 for dots/inch, or 2 for dots/cm.  Note that the pixel aspect */
+   /* ratio is defined by X_density/Y_density even when density_unit=0. */
+-  UINT8 density_unit; /* JFIF code for pixel size units */
+   UINT16 X_density;   /* Horizontal pixel density */
+   UINT16 Y_density;   /* Vertical pixel density */
+-  boolean write_Adobe_marker; /* should an Adobe marker be written? */
++  UINT8 density_unit; /* JFIF code for pixel size units */
+   
+   /* State variable: index of next scanline to be written to
+* jpeg_write_scanlines().  Application may use this to control its
 @@ -583,11 +583,11 @@
/* Data copied from JFIF marker; only valid if saw_JFIF_marker is TRUE: */
UINT8 JFIF_major_version;   /* JFIF version number */
commit efdd08cf8985c0b322ef94f62877caa5c4b3694d
Author: Christian Lohmaier 
Date:   Sat May 19 04:02:42 2012 +0200

fdo#47035: Fix loading of jpeg files on Mac/PPC

jpeg_decompress_struct gets padded when compiling libjpeg, but the
jpeg filter in svtools assume non-padded size, resulting in a mismatch
that makes libjpeg refuse to do its work.

Signed-off-by: Petr Mladek 

diff --git a/jpeg/makefile.mk b/jpeg/makefile.mk
index adc0c66..3c6cf49 100644
--- a/jpeg/makefile.mk
+++ b/jpeg/makefile.mk
@@ -36,8 +36,8 @@ TARGET=jpeg
 
 .IF "$(SYSTEM_JPEG)" == "YES"
 all:
-@echo "An already available installation of libjpeg should exist on your 
system."
-@echo "Therefore the version provided here does not need to be built in 
addition."
+   @echo "An already available installation of libjpeg should exist on 
your system."
+   @echo "Therefore the version provided here does not need to be built in 
addition."
 .ENDIF
 
 # --- Files 
@@ -50,6 +50,9 @@ TARFILE_MD5=a2c10c04f396a9ce72894beb18b4e1f9
 
 #PATCH_FILES=jpeg-6b.patch
 PATCH_FILES=jpeg-8c.patch
+.IF "$(OS)$(CPU)"=="MACOSXP"
+PATCH_FILES+=struct_alignment.patch
+.ENDIF
 
 ADDITIONAL_FILES=makefile.mk jconfig.h 
 
@@ -58,7 +61,7 @@ ADDITIONAL_FILES=makefile.mk jconfig.h
 BUILD_DIR=$(CONFIGURE_DIR)
 BUILD_ACTION=dmake $(MFLAGS) $(CALLMACROS)
 
-OUT2INC=   jconfig.h   \
+OUT2INC=jconfig.h  \
 jerror.h   \
 jmorecfg.h \
 jpegint.h  \
diff --git a/jpeg/struct_alignment.patch b/jpeg/struct_alignment.patch
new file mode 100644
index 000..2eb41bf
--- /dev/null
+++ b/jpeg/struct_alignment.patch
@@ -0,0 +1,18 @@
+without this patch, the jpeg_decompress_struct will be padded, this in turn
+results in a mismatch when the jpeg filter in svtoo

[Libreoffice-commits] .: sc/inc sc/source

2012-05-21 Thread Markus Mohrhard
 sc/inc/colorscale.hxx |8 ++
 sc/source/core/data/colorscale.cxx|  106 ++
 sc/source/filter/inc/condformatbuffer.hxx |4 -
 sc/source/filter/oox/condformatbuffer.cxx |   10 +-
 4 files changed, 109 insertions(+), 19 deletions(-)

New commits:
commit f654980aebb5d41a83dd7de94ec2ebf0173c67a7
Author: Markus Mohrhard 
Date:   Mon May 21 15:47:23 2012 +0200

initial support for percentile in data bars/color scales

Color Scales look correctly but in the databar code seems to be an error
if all values are positive.

Change-Id: I0bfb277df50021bd20a4b13a5da342670102b649

diff --git a/sc/inc/colorscale.hxx b/sc/inc/colorscale.hxx
index 997c2a0..9f4d02f 100644
--- a/sc/inc/colorscale.hxx
+++ b/sc/inc/colorscale.hxx
@@ -32,6 +32,8 @@
 #include 
 #include 
 
+#include 
+
 //TODO: merge this with conditio.hxx
 
 class ScDocument;
@@ -49,6 +51,7 @@ private:
 bool mbMin;
 bool mbMax;
 bool mbPercent;
+bool mbPercentile;
 public:
 ScColorScaleEntry(double nVal, const Color& rCol);
 ScColorScaleEntry(const ScColorScaleEntry& rEntry);
@@ -65,11 +68,13 @@ public:
 bool GetMin() const;
 bool GetMax() const;
 bool GetPercent() const;
+bool GetPercentile() const;
 bool HasFormula() const;
 const ScTokenArray* GetFormula() const;
 void SetMin(bool bMin);
 void SetMax(bool bMax);
 void SetPercent(bool bPercent);
+void SetPercentile(bool bPercentile);
 };
 
 namespace databar
@@ -160,6 +165,8 @@ public:
 virtual ScColorFormatType GetType() const = 0;
 
 protected:
+void getValues( std::vector& rValues ) const;
+
 ScRangeList maRanges;
 ScDocument* mpDoc;
 };
@@ -175,6 +182,7 @@ private:
 
 void calcMinMax(double& nMin, double& nMax) const;
 bool CheckEntriesForRel(const ScRange& rRange) const;
+double CalcValue(double nMin, double nMax, 
ColorScaleEntries::const_iterator& rItr) const;
 public:
 ScColorScaleFormat(ScDocument* pDoc);
 ScColorScaleFormat(ScDocument* pDoc, const ScColorScaleFormat& rFormat);
diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 8306107..9636365 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -37,7 +37,8 @@ ScColorScaleEntry::ScColorScaleEntry(double nVal, const 
Color& rCol):
 mpCell(NULL),
 mbMin(false),
 mbMax(false),
-mbPercent(false)
+mbPercent(false),
+mbPercentile(false)
 {
 }
 
@@ -47,7 +48,8 @@ ScColorScaleEntry::ScColorScaleEntry(const ScColorScaleEntry& 
rEntry):
 mpCell(),
 mbMin(rEntry.mbMin),
 mbMax(rEntry.mbMax),
-mbPercent(rEntry.mbPercent)
+mbPercent(rEntry.mbPercent),
+mbPercentile(rEntry.mbPercentile)
 {
 }
 
@@ -57,7 +59,8 @@ ScColorScaleEntry::ScColorScaleEntry(ScDocument* pDoc, const 
ScColorScaleEntry&
 mpCell(),
 mbMin(rEntry.mbMin),
 mbMax(rEntry.mbMax),
-mbPercent(rEntry.mbPercent)
+mbPercent(rEntry.mbPercent),
+mbPercentile(rEntry.mbPercentile)
 {
 if(rEntry.mpCell)
 {
@@ -179,6 +182,11 @@ bool ScColorScaleEntry::GetPercent() const
 return mbPercent;
 }
 
+bool ScColorScaleEntry::GetPercentile() const
+{
+return mbPercentile;
+}
+
 bool ScColorScaleEntry::HasFormula() const
 {
 return mpCell;
@@ -199,6 +207,11 @@ void ScColorScaleEntry::SetPercent(bool bPercent)
 mbPercent = bPercent;
 }
 
+void ScColorScaleEntry::SetPercentile(bool bPercentile)
+{
+mbPercentile = bPercentile;
+}
+
 namespace {
 
 double getMinValue(const ScRange& rRange, ScDocument* pDoc)
@@ -336,6 +349,37 @@ const ScRangeList& ScColorFormat::GetRange() const
 return maRanges;
 }
 
+void ScColorFormat::getValues(std::vector& rValues) const
+{
+size_t n = maRanges.size();
+for(size_t i = 0; i < n; ++i)
+{
+const ScRange* pRange = maRanges[i];
+SCTAB nTab = pRange->aStart.Tab();
+for(SCCOL nCol = pRange->aStart.Col(); nCol <= pRange->aEnd.Col(); 
++nCol)
+{
+for(SCCOL nRow = pRange->aStart.Row(); nRow <= pRange->aEnd.Row(); 
++nRow)
+{
+ScAddress aAddr(nCol, nRow, nTab);
+CellType eType = mpDoc->GetCellType(aAddr);
+if(eType == CELLTYPE_VALUE)
+{
+double aVal = mpDoc->GetValue(nCol, nRow, nTab);
+rValues.push_back(aVal);
+}
+else if(eType == CELLTYPE_FORMULA)
+{
+
if(static_cast(mpDoc->GetCell(aAddr))->IsValue())
+{
+double aVal = mpDoc->GetValue(nCol, nRow, nTab);
+rValues.push_back(aVal);
+}
+}
+}
+}
+}
+}
+
 namespace {
 
 sal_uInt8 GetColorValue( double nVal, double nVal1, sal_uInt8 nColVal1, double 
nVal2, sal_uInt8 nColVal2 )
@@ -359,7 +403,27 @@ Color CalcColor( double nVal, d

[Libreoffice-commits] .: sc/qa

2012-05-21 Thread Eike Rathke
 sc/qa/unit/ucalc.cxx |   77 +--
 1 file changed, 57 insertions(+), 20 deletions(-)

New commits:
commit 485792374600cd9919ab6edf201e8bd97d640261
Author: Eike Rathke 
Date:   Mon May 21 15:48:07 2012 +0200

added unit tests for DATEDIF fdo#44456

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index ef33e64..7c5d8c5 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -286,6 +286,26 @@ void printRange(ScDocument* pDoc, const ScRange& rRange, 
const char* pCaption)
 printer.print(pCaption);
 }
 
+template
+ScRange insertRangeData(ScDocument* pDoc, const ScAddress& rPos, const char* 
aData[][_Size], size_t nRowCount)
+{
+for (size_t i = 0; i < _Size; ++i)
+{
+for (size_t j = 0; j < nRowCount; ++j)
+{
+SCCOL nCol = i + rPos.Col();
+SCROW nRow = j + rPos.Row();
+pDoc->SetString(nCol, nRow, rPos.Tab(), OUString(aData[j][i], 
strlen(aData[j][i]), RTL_TEXTENCODING_UTF8));
+}
+}
+
+ScRange aRange(rPos);
+aRange.aEnd.SetCol(rPos.Col()+_Size-1);
+aRange.aEnd.SetRow(rPos.Row()+nRowCount-1);
+printRange(pDoc, aRange, "Range data content");
+return aRange;
+}
+
 Test::Test()
 : m_pDoc(0)
 {
@@ -773,6 +793,42 @@ void testFuncCELL(ScDocument* pDoc)
 }
 }
 
+/** See also test case document fdo#44456 sheet cpearson */
+void testFuncDATEDIF( ScDocument* pDoc )
+{
+const char* aData[][5] = {
+{ "2007-01-01", "2007-01-10",  "d",   "9", "=DATEDIF(A1;B1;C1)" } ,
+{ "2007-01-01", "2007-01-31",  "m",   "0", "=DATEDIF(A2;B2;C2)" } ,
+{ "2007-01-01", "2007-02-01",  "m",   "1", "=DATEDIF(A3;B3;C3)" } ,
+{ "2007-01-01", "2007-02-28",  "m",   "1", "=DATEDIF(A4;B4;C4)" } ,
+{ "2007-01-01", "2007-12-31",  "d", "364", "=DATEDIF(A5;B5;C5)" } ,
+{ "2007-01-01", "2007-01-31",  "y",   "0", "=DATEDIF(A6;B6;C6)" } ,
+{ "2007-01-01", "2008-07-01",  "d", "547", "=DATEDIF(A7;B7;C7)" } ,
+{ "2007-01-01", "2008-07-01",  "m",  "18", "=DATEDIF(A8;B8;C8)" } ,
+{ "2007-01-01", "2008-07-01", "ym",   "6", "=DATEDIF(A9;B9;C9)" } ,
+{ "2007-01-01", "2008-07-01", "yd", "182", "=DATEDIF(A10;B10;C10)" } ,
+{ "2008-01-01", "2009-07-01", "yd", "181", "=DATEDIF(A11;B11;C11)" } ,
+{ "2007-01-01", "2007-01-31", "md",  "30", "=DATEDIF(A12;B12;C12)" } ,
+{ "2007-02-01", "2009-03-01", "md",   "0", "=DATEDIF(A13;B13;C13)" } ,
+{ "2008-02-01", "2009-03-01", "md",   "0", "=DATEDIF(A14;B14;C14)" } ,
+{ "2007-01-02", "2007-01-01", "md", "Err:502", "=DATEDIF(A15;B15;C15)" 
}// fail date1 > date2
+};
+
+clearRange( pDoc, ScRange(0, 0, 0, 4, SAL_N_ELEMENTS(aData), 0));
+ScAddress aPos(0,0,0);
+ScRange aDataRange = insertRangeData( pDoc, aPos, aData, 
SAL_N_ELEMENTS(aData));
+CPPUNIT_ASSERT_MESSAGE("failed to insert range data at correct position", 
aDataRange.aStart == aPos);
+
+pDoc->CalcAll();
+
+for (size_t i = 0; i < SAL_N_ELEMENTS(aData); ++i)
+{
+rtl::OUString aVal = pDoc->GetString( 4, i, 0);
+//std::cout << "row "<< i << ": " << rtl::OUStringToOString( aVal, 
RTL_TEXTENCODING_UTF8).getStr() << ", expected " << aData[i][3] << std::endl;
+CPPUNIT_ASSERT_MESSAGE("Unexpected result for DATEDIF", 
aVal.equalsAscii( aData[i][3]));
+}
+}
+
 void Test::testCellFunctions()
 {
 rtl::OUString aTabName(RTL_CONSTASCII_USTRINGPARAM("foo"));
@@ -786,6 +842,7 @@ void Test::testCellFunctions()
 testFuncVLOOKUP(m_pDoc);
 testFuncMATCH(m_pDoc);
 testFuncCELL(m_pDoc);
+testFuncDATEDIF(m_pDoc);
 
 m_pDoc->DeleteTab(0);
 }
@@ -1141,26 +1198,6 @@ struct DPFieldDef
 };
 
 template
-ScRange insertRangeData(ScDocument* pDoc, const ScAddress& rPos, const char* 
aData[][_Size], size_t nRowCount)
-{
-for (size_t i = 0; i < _Size; ++i)
-{
-for (size_t j = 0; j < nRowCount; ++j)
-{
-SCCOL nCol = i + rPos.Col();
-SCROW nRow = j + rPos.Row();
-pDoc->SetString(nCol, nRow, rPos.Tab(), OUString(aData[j][i], 
strlen(aData[j][i]), RTL_TEXTENCODING_UTF8));
-}
-}
-
-ScRange aRange(rPos);
-aRange.aEnd.SetCol(rPos.Col()+_Size-1);
-aRange.aEnd.SetRow(rPos.Row()+nRowCount-1);
-printRange(pDoc, aRange, "Range data content");
-return aRange;
-}
-
-template
 ScRange insertDPSourceData(ScDocument* pDoc, DPFieldDef aFields[], size_t 
nFieldCount, const char* aData[][_Size], size_t nDataCount)
 {
 // Insert field names in row 0.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] .: 3 commits - connectivity/source dbaccess/source filter/source sd/source stoc/source svx/source toolkit/source xmlscript/source

2012-05-21 Thread Takeshi Abe
 connectivity/source/commontools/TKeys.cxx|1 -
 connectivity/source/commontools/dbtools.cxx  |4 
 connectivity/source/drivers/ado/ADriver.cxx  |2 --
 connectivity/source/drivers/flat/EConnection.cxx |1 -
 connectivity/source/drivers/hsqldb/HViews.cxx|2 +-
 connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx |7 ---
 connectivity/source/parse/sqlnode.cxx|2 --
 dbaccess/source/ui/dlg/queryorder.cxx|5 -
 filter/source/msfilter/svdfppt.cxx   |6 --
 sd/source/filter/eppt/epptso.cxx |5 -
 stoc/source/javavm/jvmargs.cxx   |2 --
 svx/source/dialog/docrecovery.cxx|4 
 svx/source/engine3d/float3d.cxx  |6 ++
 toolkit/source/helper/formpdfexport.cxx  |1 -
 xmlscript/source/xmldlg_imexp/xmldlg_impmodels.cxx   |1 -
 15 files changed, 3 insertions(+), 46 deletions(-)

New commits:
commit e08e630110b6bf367766f2e47dc4988404a692d8
Author: Takeshi Abe 
Date:   Mon May 21 21:46:11 2012 +0900

deleting NULL is safe

Change-Id: Iad17d77d61eccf0973fff0da91089e7a59fc9df0

diff --git a/svx/source/engine3d/float3d.cxx b/svx/source/engine3d/float3d.cxx
index 0670380..b6cfd4b 100644
--- a/svx/source/engine3d/float3d.cxx
+++ b/svx/source/engine3d/float3d.cxx
@@ -453,8 +453,7 @@ Svx3DWin::~Svx3DWin()
 delete pConvertTo3DItem;
 delete pConvertTo3DLatheItem;
 
-if(mpRemember2DAttributes)
-delete mpRemember2DAttributes;
+delete mpRemember2DAttributes;
 
 delete mpImpl;
 }
@@ -3116,8 +3115,7 @@ void Svx3DWin::UpdatePreview()
 // document is to be reloaded, destroy remembered ItemSet
 void Svx3DWin::DocumentReload()
 {
-if(mpRemember2DAttributes)
-delete mpRemember2DAttributes;
+delete mpRemember2DAttributes;
 mpRemember2DAttributes = 0L;
 }
 
commit 5f2ef2b270a70f3ad486012976e95d1192e04c2d
Author: Takeshi Abe 
Date:   Mon May 21 21:43:58 2012 +0900

removed unused #defines

Change-Id: I2aeba0342e46c3a4bd50f49b8a43ebb125269dfa

diff --git a/connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx 
b/connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx
index e27ab34..320bca0 100644
--- a/connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx
+++ b/connectivity/source/drivers/hsqldb/StorageNativeOutputStream.cxx
@@ -60,13 +60,6 @@ using namespace ::com::sun::star::io;
 using namespace ::com::sun::star::lang;
 using namespace ::connectivity::hsqldb;
 
-#define OUSTR(x) ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(x) )
-/*/
-/* exception macros */
-
-#define ThrowException(env, type, msg) { \
-env->ThrowNew(env->FindClass(type), msg); }
-
 // 
-
 /*
  * Class: com_sun_star_sdbcx_comp_hsqldb_StorageNativeOutputStream
diff --git a/dbaccess/source/ui/dlg/queryorder.cxx 
b/dbaccess/source/ui/dlg/queryorder.cxx
index 0f8a89c..95a35a4 100644
--- a/dbaccess/source/ui/dlg/queryorder.cxx
+++ b/dbaccess/source/ui/dlg/queryorder.cxx
@@ -153,11 +153,6 @@ DlgOrderCrit::DlgOrderCrit( Window * pParent,
 }
 
 
//--
-
-#define LbText(x)   ((x).GetSelectEntry())
-#define LbPos(x)((x).GetSelectEntryPos())
-
-//--
 DlgOrderCrit::~DlgOrderCrit()
 {
 DBG_DTOR(DlgOrderCrit,NULL);
diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 0501d4a..8e24fcf 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -139,15 +139,9 @@
 #define PPT_COLSCHEME_A_H_GESICHERT (0x0807)
 
 #define ANSI_CHARSET0
-#define DEFAULT_CHARSET 1
 #define SYMBOL_CHARSET  2
-#define SHIFTJIS_CHARSET128
-#define HANGEUL_CHARSET 129
-#define CHINESEBIG5_CHARSET 136
-#define OEM_CHARSET 255
 
 /* Font Families */
-#define FF_DONTCARE 0x00
 #define FF_ROMAN0x10
 #define FF_SWISS0x20
 #define FF_MODERN   0x30
diff --git a/sd/source/filter/eppt/epptso.cxx b/sd/source/filter/eppt/epptso.cxx
index 36dda36..70cf9a4 100644
--- a/sd/source/filter/eppt/epptso.cxx
+++ b/sd/source/filter/eppt/epptso.cxx
@@ -94,12 +94,7 @@ using namespace ::com::sun::star;
 

 
 #define ANSI_CHARSET0
-#define DEFAULT_CHARSET 1
 #define SYMBOL_CHARSET 

Re: [PATCH-3-5] fdo#35270 - kill first-use grammar checker freeze ...

2012-05-21 Thread Olivier R.
Hello Daniel,


Daniel Naber-2 wrote
> 
> now that this is fixed I searched the archives for the reason LanguageTool 
> is not enabled by default.
> 

LanguageTool should be split in modules per language, for it prevents to use
other grammar checkers. At the moment, when you install LT, you install it
for English, German, French, Polish, Russian, Dutch, Romanian, etc. We
should be able to select what grammar checker we prefer for each locale.

Regards,
Olivier

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-3-5-fdo-35270-kill-first-use-grammar-checker-freeze-tp3983822p3985009.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: lo-commit-stat: why lowercase the first letter?

2012-05-21 Thread Korrawit Pruegsanusak
Hello Petr, Christian, all,

On Mon, May 21, 2012 at 5:38 PM, Christian Lohmaier
 wrote:
> On Mon, May 21, 2012 at 10:51 AM, Petr Mladek  wrote:
>>    Also there is problem with shortcats, for example, the script
>>    sometimes replaces "XML" with "xML" which looks ugly
>
> The XML, RTF,... case can be handled by only lowercasing when the
> second letter is not uppercae. That should

Thanks for the information! :-)

I'll try as Christian suggest, but it might take some times as I'm
quite busy at the college.

Best Regards,
-- 
Korrawit Pruegsanusak
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


REMINDER: Release 3.5.4-rc2 from libreoffice-3-5-4 branch

2012-05-21 Thread Petr Mladek
Hi,

please note that the commit deadline for 3.5.4-rc2 is today, May 21,
2012. It will be used as LO-3.5.4 final if no blocker is reported.

See also
http://wiki.documentfoundation.org/ReleasePlan#3.5_release
http://wiki.documentfoundation.org/Release_Criteria
http://wiki.documentfoundation.org/Development/Branches


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: 2 commits - sc/source

2012-05-21 Thread Markus Mohrhard
 sc/source/core/data/colorscale.cxx|4 ++--
 sc/source/filter/oox/condformatbuffer.cxx |1 +
 sc/source/filter/oox/extlstcontext.cxx|2 ++
 3 files changed, 5 insertions(+), 2 deletions(-)

New commits:
commit aaf0b2faab845c624e568d6e1acbc501f5f355cb
Author: Markus Mohrhard 
Date:   Mon May 21 13:50:32 2012 +0200

this needs to be the upper limit

Change-Id: I4b6f826f8f87b2c4a4bb73d9b6246505d2632b23

diff --git a/sc/source/core/data/colorscale.cxx 
b/sc/source/core/data/colorscale.cxx
index 3361d72..8306107 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -654,10 +654,10 @@ double ScDataBarFormat::getMax(double nMin, double nMax) 
const
 
 if(mpFormatData->mpUpperLimit->GetPercent())
 {
-return nMin + (nMax-nMin)/100*mpFormatData->mpLowerLimit->GetValue();
+return nMin + (nMax-nMin)/100*mpFormatData->mpUpperLimit->GetValue();
 }
 
-return mpFormatData->mpLowerLimit->GetValue();
+return mpFormatData->mpUpperLimit->GetValue();
 }
 
 ScDataBarInfo* ScDataBarFormat::GetDataBarInfo(const ScAddress& rAddr) const
commit e8d4b5b6c39d2d0abcd9e814b9fe9ce8c3e2150f
Author: Markus Mohrhard 
Date:   Mon May 21 11:11:19 2012 +0200

better import for excel 2007 data bar files

Change-Id: I0d32a82aa4829ae635967f24293b2f32a71a4cbe

diff --git a/sc/source/filter/oox/condformatbuffer.cxx 
b/sc/source/filter/oox/condformatbuffer.cxx
index 8792546..05681b8 100644
--- a/sc/source/filter/oox/condformatbuffer.cxx
+++ b/sc/source/filter/oox/condformatbuffer.cxx
@@ -264,6 +264,7 @@ DataBarRule::DataBarRule( const CondFormat& rFormat ):
 mrCondFormat( rFormat ),
 mpFormat(new ScDataBarFormatData)
 {
+mpFormat->meAxisPosition = databar::NONE;
 }
 
 void DataBarRule::importColor( const AttributeList& rAttribs )
diff --git a/sc/source/filter/oox/extlstcontext.cxx 
b/sc/source/filter/oox/extlstcontext.cxx
index d8c2d1f..3f6991e 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -31,6 +31,8 @@
 #include 
 #include "colorscale.hxx"
 
+#include 
+
 using ::oox::core::ContextHandlerRef;
 
 namespace oox {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: GSoC Week 1

2012-05-21 Thread Tor Lillqvist
Ah, yes. With a current Xcode 4.3, the automake and autoconf tools are
no longer included, sigh, not even when you add the "command-line
tools" (or whatever they are called, don't recall exactly). (aclocal
is part of the automake package.)

You need to download tarballs for some recent version of automake and
autoconf, configure and install them somewhere, like /usr/local. A bit
of bother, yes. I wonder if we should start including a pre-autogened
configure script somewhere in the git tree.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: GSoC Week 1

2012-05-21 Thread Iain Billett
>
> You just need to pass in some options to autogen.sh; this should word:
>
> CC_FOR_BUILD=ccache clang -arch i386 -mmacosx-version-min=10.6
> CXX_FOR_BUILD=ccache clang++ -arch i386 -mmacosx-version-min=10.6
>
> --with-build-platform-configure-options=--with-macosx-version-min-required=10.6
> --with-macosx-sdk=10.6
>
> (put that in your autogen.lastrun, i.e. treat autogen.lastrun as an
> input file. or if you pass as command-line parameters, add quotes
> around the "--with-macosx-version-min-required=10.6
> --with-macosx-sdk=10.6".)
>
>
My problem with mac os x (lion) is that I haven't been able to get
autogen.sh to run at all (Even --help gives no output). Every time it gives
aclocal failed to run line 155 (It's also not recognised as a command).
Looks like I need to install aclocal or something which contains it. I
haven't been able to find any instructions for lion, any Ideas?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH-3-5] fdo#35270 - kill first-use grammar checker freeze ...

2012-05-21 Thread Olivier R.
Hello Michael,


Michael Meeks-2 wrote
> 
>   Beyond that - I've no idea :-) presumably there are philosophical
> differences between lightproof and languagetool that I'm not clued-up
> on. It'd be interesting to hear what Laszlo & you think about it, and
> other people's views on the list ...
> 

The differences look imho more technical than philosophical, even if there
are specific features in both of them. They both parse text with a set of
written rules describing what might be mistakes. I already converted LT
rules for LP, and you can also convert LP rules for LT, but you can’t always
write exactly the same rules. LanguageTool checks all words in a sentence,
whereas Lightproof checks only what you ask to check, based on regex
triggers.

LT rules are written in a very formal way, in XML files.
LP rules are written with a lot of regex mixed with Python code.


One of the main differences is how the grammar checkers retrieve
informations about words.
Lightproof calls the spell checker Hunspell to know what a word might be
(part of speech, etc.), whereas LanguageTool bundles his own lexicon for
every language.

AFAIK, at the moment, only the Hungarian Hunspell dictionary and the French
one are grammatically tagged.
Although you can do grammar checking without grammatically tagged
dictionaries, rules describing mistakes will be limited.

The lack of grammatically tagged Hunspell dictionaries is one of the main
issue to improve grammar checking for other languages with Lightproof.



What hope is there for sharing work, rules, etc. ?
Writting rules for both GC is doable by a human, though it might be
difficult automatically.

Working on dictionaries or lexicons is a time-consuming work.
At the moment, the French Hunspell dictionary is converted regularly into a
lexicon for LT. That’s not really hard, as the Hunspell dictionary was
conceived for grammar checking. I don’t know if converting LT lexicons into
Hunspell dictionaries would be easily feasible. It probably depends on the
complexity of the language. I don’t even know if LT lexicons would be good
replacements for spell checking. Another solution might be to tag Hunspell
dictionaries with LT tags, but all Hunspell dictionaries were probably not
conceived with grammar checking in mind, and that’s probably more a dream
than a doable solution.

If Lightproof could use LT lexicons, that could be a temporary solution, but
maybe memory-consuming, as you would have a dictionary for spell checking
and a lexicon for grammar checking.



Would that offend the minimal modus operandi of lightproof ? could that
> light mode be made an option ?

Lightproof can work as hard as LT. It just depends on what you ask to it. :)
The Lightproof French grammar checker already does approximatively as much
as LT, and will do much more in few months, I hope. I work on that.

HTH.

Regards,
Olivier

--
View this message in context: 
http://nabble.documentfoundation.org/PATCH-3-5-fdo-35270-kill-first-use-grammar-checker-freeze-tp3983822p3984998.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: solenv/bin

2012-05-21 Thread Christian Lohmaier
 solenv/bin/addsym.awk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9b72a692ee3ef3381a0881ead4afa5bd73fff776
Author: Christian Lohmaier 
Date:   Mon May 21 13:19:56 2012 +0200

don't let the Mac/PPC linker complain when the symbol isn't used

diff --git a/solenv/bin/addsym.awk b/solenv/bin/addsym.awk
index a9e64fb..181a077 100644
--- a/solenv/bin/addsym.awk
+++ b/solenv/bin/addsym.awk
@@ -43,7 +43,7 @@ END {
 print "GLIBCXX_3.4 {"
 print "global:"
 print "_ZGVNSt7num_put*; _ZNSt7num_put*;"
-print "_ZNSs4_Rep20_S_empty_rep_storageE;"
+print "_ZNSs4_Rep20_S_empty_rep_storageE*;"
 print "};"
 }
 state == 2 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: loader.loadComponentFromURL works slow when we are restoring CALC sheet from byte array | loader.loadComponentFromURL

2012-05-21 Thread Michael Meeks

On Mon, 2012-05-21 at 12:03 +0200, Stephan Bergmann wrote:
> On 05/21/2012 10:28 AM, Michael Meeks wrote:
> > I assume this is from C++ (?) anything else would of course cause tons
> > of bridging overhead in the streams.
> 
>  From the code, it looks more like they are using Java, presumably from 
> a remote process.  So any data from the buffer needs to be marshalled 
> through (remote) UNO to OOo/LO's C++ side.  What can potentially reduce 
> throughput there is if the C++ side calls XInputStream.readBytes in 
> small instead of large chunks, but I don't know the implementation 
> details of the relevant Calc import code.

Ah - in which case, thousands of calls via the Java bridge will be
where the time is spent I suppose :-); I suggest writing the data out to
a file, and/or (somehow?) creating an UNO memory-stream and writing the
data to it all in one big lump, so the code can do native C++ <-> C++
for reading that back out. For the quick & easy fix the temporary file
is almost certainly far faster - I assume you're keeping it in memory to
try to make it fast ? :-)

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: "5729da1 fdo#42865: privatized unique empty string symbol" - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Stephan Bergmann

On 05/21/2012 12:32 PM, Christian Lohmaier wrote:

On Mon, May 21, 2012 at 12:08 PM, Michael Stahl  wrote:

On 21/05/12 11:46, Stephan Bergmann wrote:

On 05/20/2012 05:06 PM, Christian Lohmaier wrote:

print "_ZNSs4_Rep20_S_empty_rep_storageE*;"

[...]
also, you'd have to check in libstdc++ because the debug mode is never
active on MacOS currently so LO libraries shouldn't reference the symbol
(would perhaps be nice to enable it if it works).


libstdc++ contains it:

$ nm /Developer/SDKs/MacOSX10.4u.sdk/usr/lib/libstdc++.dylib  |grep -i
empty_rep_storage
a0b1addc S __ZNSbIwSt11char_traitsIwESaIwEE4_Rep20_S_empty_rep_storageE
a0b1ad9c S __ZNSs4_Rep20_S_empty_rep_storageE


Ah, so the problem after all is indeed that our lib happens to not 
define the symbol and at least Mac OS X PPC linker complains about that. 
 In other words, current solution is just fine.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice] [GSoC 2011][svg export filter] GSoC project start

2012-05-21 Thread Christian Lohmaier
Hi Marco,

On Mon, May 21, 2012 at 9:12 AM, Marco Cecchetti  wrote:
>
> Hi Thorsten, everyone,
> so it's time to start working on the project. :)
>
> I pushed a new feature branch named feature/svg-export,
> where I'll commit all contributions I 'm going to provide
> on GSoC time-frame.

Shameless abuse of your thread, but related:
Please rething your decision about having the browser scale svg being
more important than other tools processing the svg with the expected
size.

https://bugs.freedesktop.org/show_bug.cgi?id=43060

So please put
* use coordinate system that all tools agree upon.

As mentioned in the bug either use no units and convert to pixel, or
specify size with units. I really think having it scaled in the
browser is less important than not breaking other tools that run out
of memory because they assume pixels.

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: lo-commit-stat: why lowercase the first letter?

2012-05-21 Thread Christian Lohmaier
Hi Petr, *,

On Mon, May 21, 2012 at 10:51 AM, Petr Mladek  wrote:
> Korrawit Pruegsanusak píše v Ne 20. 05. 2012 v 11:28 +0700:
>> Hello Petr, all,
>
> [*] I do not have any string opinion whether lower or uppercase letter
>    is better. Maybe, we should use upper case because there are
>    sometimes longer sentences, see
>    http://www.grammar-quizzes.com/punc-lists.html
>
>    Also there is problem with shortcats, for example, the script
>    sometimes replaces "XML" with "xML" which looks ugly

The XML, RTF,... case can be handled by only lowercasing when the
second letter is not uppercae. That should

>> * could this behavior be removed? If yes, I can push the patch to master.
>
> I am open for any improvement or changes. I am just curious, why don't
> you like the current behavior? ;-)

I understand that rTF and xML looks ugly :-)
But that of course doesn't say anything about the "first character
shall be lowercase" rule, just that that rule needs exceptions :-)

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: scp2/inc scp2/source

2012-05-21 Thread Jesús Corrius
 scp2/inc/macros.inc  |   12 +
 scp2/source/base/registryitem_base.scp   |8 +++
 scp2/source/calc/registryitem_calc.scp   |   40 
 scp2/source/draw/registryitem_draw.scp   |   40 
 scp2/source/impress/registryitem_impress.scp |   40 
 scp2/source/math/registryitem_math.scp   |   16 ++
 scp2/source/writer/registryitem_writer.scp   |   64 +++
 7 files changed, 220 insertions(+)

New commits:
commit 93a90946576202435d87e92a8a542c606baac97f
Author: Jesús Corrius 
Date:   Mon May 21 12:27:36 2012 +0200

Register Kind Names for supported file types for Windows Vista and higher

diff --git a/scp2/inc/macros.inc b/scp2/inc/macros.inc
index 690a21d..d776797 100755
--- a/scp2/inc/macros.inc
+++ b/scp2/inc/macros.inc
@@ -459,6 +459,16 @@ End
 Value = STRING(CONCAT2(LibreOffice.,name)); \
 Styles = (); \
 End
+
+#define REGISTRY_ENTRY_KINDMAP(name, modid, key) \
+RegistryItem 
CONCAT2(gid_Regitem_Software_Manufacturer_Productname_Productversion_Explorer_KindMap_,name)
 \
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE; \
+ModuleID = modid; \
+ComponentCondition = "VersionNT >= 600"; \
+Subkey = 
STRING(SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap); \
+Name = STRING(CONCAT2(.,key)); \
+Value = "document"; \
+End
 
 #define 
CONDITIONAL_REGISTER_DOC_EXTENSION(name,modid,key,cond,disp_name,icon_id,app,default,doc_type)
 \
 CONDITIONAL_MODULE_ENTRY(name,modid) \
@@ -472,6 +482,7 @@ End
 REGISTRY_ENTRY_PRINT_CMD(name,modid,app) \
 REGISTRY_ENTRY_PRINTTO_CMD(name,modid,app) \
 REGISTRY_ENTRY_CAPABILITIES(name,modid,key,doc_type) \
+REGISTRY_ENTRY_KINDMAP(name, modid, key) \
 
 #define 
CONDITIONAL_REGISTER_DOCTEMPLATE_EXTENSION(name,modid,key,cond,disp_name,icon_id,app,default,doc_type)
 \
 CONDITIONAL_MODULE_ENTRY(name,modid) \
@@ -485,6 +496,7 @@ End
 REGISTRY_ENTRY_PRINT_CMD(name,modid,app) \
 REGISTRY_ENTRY_PRINTTO_CMD(name,modid,app) \
 REGISTRY_ENTRY_TEMPLATE_CAPABILITIES(name,modid,key,doc_type) \
+REGISTRY_ENTRY_KINDMAP(name, modid, key) \
 
 // ---
 
diff --git a/scp2/source/base/registryitem_base.scp 
b/scp2/source/base/registryitem_base.scp
index 29bde7b..fce66e8 100644
--- a/scp2/source/base/registryitem_base.scp
+++ b/scp2/source/base/registryitem_base.scp
@@ -104,6 +104,14 @@ RegistryItem gid_Regitem_odb_FullDetails
 End
 #endif
 
+RegistryItem gid_Regitem_odb_KindMap
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE;
+ModuleID = gid_Module_Prg_Base_Bin;
+Subkey = "SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap";
+Name = ".odb";
+Value = "Document";
+End
+
 RegistryItem gid_Regitem_Openoffice_Databasedocument_1_Shell
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 Subkey = "opendocument.DatabaseDocument.1\shell";
diff --git a/scp2/source/calc/registryitem_calc.scp 
b/scp2/source/calc/registryitem_calc.scp
index 49a648d..0824608 100644
--- a/scp2/source/calc/registryitem_calc.scp
+++ b/scp2/source/calc/registryitem_calc.scp
@@ -506,6 +506,14 @@ RegistryItem gid_Regitem_stc_FullDetails
 End
 #endif
 
+RegistryItem gid_Regitem_stc_KindMap
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap";
+Name = ".stc";
+Value = "Document";
+End
+
 RegistryItem gid_Regitem_Sxc_Contenttype
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 ModuleID = gid_Module_Prg_Calc_Bin;
@@ -549,6 +557,14 @@ RegistryItem gid_Regitem_sxc_FullDetails
 End
 #endif
 
+RegistryItem gid_Regitem_sxc_KindMap
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap";
+Name = ".sxc";
+Value = "Document";
+End
+
 // new ods file extension 
 
 RegistryItem gid_Regitem_Ods_PersistentHandler
@@ -666,6 +682,14 @@ RegistryItem gid_Regitem_ods_FullDetails
 End
 #endif
 
+RegistryItem gid_Regitem_ods_KindMap
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap";
+Name = ".ods";
+Value = "Document";
+End
+
 RegistryItem gid_Regitem_Openoffice_Calcdocument_1_Insertable
 ParentID = PREDEFINED_HKEY_CLASSES_ROOT;
 ModuleID = gid_Module_Prg_Calc_Bin;
@@ -790,6 +814,14 @@ RegistryItem gid_Regitem_Fods_Contenttype
 Value = "application/vnd.oasis.opendocument.spreadsheet";
 End
 
+RegistryItem gid_Regitem_fods_KindMap
+ParentID = PREDEFINED_HKEY_LOCAL_MACHINE;
+ModuleID = gid_Module_Prg_Calc_Bin;
+Subkey = "SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\KindMap";
+Name = ".fods";
+Value = "Document";
+End
+
 // new ots file extension 
 
 RegistryItem gid_Regitem_Ots_Persisten

Re: "5729da1 fdo#42865: privatized unique empty string symbol" - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Christian Lohmaier
Hi Michael, *,

On Mon, May 21, 2012 at 12:08 PM, Michael Stahl  wrote:
> On 21/05/12 11:46, Stephan Bergmann wrote:
>> On 05/20/2012 05:06 PM, Christian Lohmaier wrote:
>>> print "_ZNSs4_Rep20_S_empty_rep_storageE*;"
> [...]
> also, you'd have to check in libstdc++ because the debug mode is never
> active on MacOS currently so LO libraries shouldn't reference the symbol
> (would perhaps be nice to enable it if it works).

libstdc++ contains it:

$ nm /Developer/SDKs/MacOSX10.4u.sdk/usr/lib/libstdc++.dylib  |grep -i
empty_rep_storage
a0b1addc S __ZNSbIwSt11char_traitsIwESaIwEE4_Rep20_S_empty_rep_storageE
a0b1ad9c S __ZNSs4_Rep20_S_empty_rep_storageE
$

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: "5729da1 fdo#42865: privatized unique empty string symbol" - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Christian Lohmaier
Hi Stephan, *,

On Mon, May 21, 2012 at 11:46 AM, Stephan Bergmann  wrote:
> On 05/20/2012 05:06 PM, Christian Lohmaier wrote:
>>
>> print "_ZNSs4_Rep20_S_empty_rep_storageE*;"
>>
>> doesn't break the build.
>
>
> What could also be the problem is that the mangled name is slightly
> different for Mac OS X PPC.  Does nm show any symbol name containing
> "_S_empty_rep_storage," say?

No - at least not for neon, bridges & remotebridges...
$ nm neon/unxmacxp.pro/lib/libneon.dylib
bridges/unxmacxp.pro/lib/libgcc3_uno.dylib
remotebridges/unxmacxp.pro/lib/uuresolver.uno.dylib  |grep -i empty
00019fbc s _empty_atts
daf0 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_N7bridges7cpp_uno6shared13VtableFactory7VtablesEE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISG_NS0_9ungroupedEEEm
fdd0 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_N7bridges7cpp_uno6shared13VtableFactory7VtablesEE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISG_NS0_9ungroupedEEEm.eh
ac60 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_PSt9type_infoE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISD_NS0_9ungroupedEEEm
e850 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_PSt9type_infoE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISD_NS0_9ungroupedEEEm.eh
d290 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_lE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISB_NS0_9ungroupedEEEm
fd24 s 
__ZN5boost16unordered_detail10hash_tableINS0_3mapIN3rtl8OUStringENS3_12OUStringHashESt8equal_toIS4_ESaISt4pairIKS4_lE28emplace_empty_impl_with_nodeERNS0_21hash_node_constructorISB_NS0_9ungroupedEEEm.eh
$

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] .: instsetoo_native/inc_openoffice

2012-05-21 Thread Andras Timar
 instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 80cbf517a671b5225c8b3033729d30f5cf721e06
Author: Andras Timar 
Date:   Mon May 21 11:47:10 2012 +0200

MSI: remove unused string

Change-Id: I3c5778ae39561c5a87bef6a2adbb8d45112f0fbd

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
index 28a1219..81ae531 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Property.ulf
@@ -1,6 +1,3 @@
-[OOO_ARPCOMMENTSTEMPLATE]
-en-US = "Comment in the Add-Remove-Programs Applet"
-
 [OOO_ARPCONTACTTEMPLATE]
 en-US = "Department for technical support"
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: "5729da1 fdo#42865: privatized unique empty string symbol" - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Michael Stahl
On 21/05/12 11:46, Stephan Bergmann wrote:
> On 05/20/2012 05:06 PM, Christian Lohmaier wrote:
>> print "_ZNSs4_Rep20_S_empty_rep_storageE*;"
>>
>> doesn't break the build.
> 
> What could also be the problem is that the mangled name is slightly 
> different for Mac OS X PPC.  Does nm show any symbol name containing 
> "_S_empty_rep_storage," say?  Then, a better solution would be to place 
> the wildcard "*" so that both symbol name variants would match.

that would also be possible, the only arithmetic type in the signature
is "char", which may be signed or unsigned, but i don't know if that
makes a difference in name mangling.

 std::basic_string, std::allocator
>::_Rep::_S_empty_rep_storage

also, you'd have to check in libstdc++ because the debug mode is never
active on MacOS currently so LO libraries shouldn't reference the symbol
(would perhaps be nice to enable it if it works).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: loader.loadComponentFromURL works slow when we are restoring CALC sheet from byte array | loader.loadComponentFromURL

2012-05-21 Thread Stephan Bergmann

On 05/21/2012 10:28 AM, Michael Meeks wrote:

I assume this is from C++ (?) anything else would of course cause tons
of bridging overhead in the streams.


From the code, it looks more like they are using Java, presumably from 
a remote process.  So any data from the buffer needs to be marshalled 
through (remote) UNO to OOo/LO's C++ side.  What can potentially reduce 
throughput there is if the C++ side calls XInputStream.readBytes in 
small instead of large chunks, but I don't know the implementation 
details of the relevant Calc import code.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Porting a Java extension to Python

2012-05-21 Thread Michael Meeks

On Tue, 2012-05-15 at 12:12 +, Ishan Thilina wrote:
> Thanks a lot!. That solved the problem :-)

Cool :-) incidentally, debugging python problems can be really nasty;
there is some code in this commit:

commit 1a7eee2446dfbe06ac39941473010fc8915ee6e6
Author: Michael Meeks 
Date:   Mon Dec 5 19:44:49 2011 +

Improve pyuno debugging in various ways - add stack traces etc.

That enables more useful debug on the console if DEBUG is enabled; not
sure if there a good / user-friendly way to turn that on globally, but -
you can manually enable it I suspect.

All the best with your extension !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: "5729da1 fdo#42865: privatized unique empty string symbol" - change of addsym.awk breaks the build on Mac/PPC

2012-05-21 Thread Stephan Bergmann

On 05/20/2012 05:06 PM, Christian Lohmaier wrote:

print "_ZNSs4_Rep20_S_empty_rep_storageE*;"

doesn't break the build.


What could also be the problem is that the mangled name is slightly 
different for Mac OS X PPC.  Does nm show any symbol name containing 
"_S_empty_rep_storage," say?  Then, a better solution would be to place 
the wildcard "*" so that both symbol name variants would match.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PUSHED][REVIEW-3-5] Revert fix for "#i86306# prepare against really broken CUPS installations..."

2012-05-21 Thread Michael Meeks

On Sat, 2012-05-19 at 20:47 +0100, Caolán McNamara wrote:
> ah good, that code always really bugged me and it bit me recently in its
> ability to make a simple crash complicated if it happens while the cups
> printer discovery is underway so I'd planned to remove it myself.
> Pushed.

Wow - that is a horror ! trying to protect against SEGV's in that
busted CUPS code ? :-) hideous ... IIRC it is already nasty enough to
try to work out which of Java, Mono, OO.o caused a signal and whether
they intended to, without this mess too.

Thanks for finding / fixing Stephan :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [REVIEW][3-5] codemaker: write Java 1.5 class files

2012-05-21 Thread Stephan Bergmann

On 05/18/2012 05:53 PM, Michael Stahl wrote:

for this reason i'm in favor of immediately dropping support for
anything older than Java 1.5 on master, and also on libreoffice-3-5.
(i don't actually know what our "official" Java baseline is, perhaps it
is already 1.5?)


+1 on requiring a baseline of Java 1.5.  Not sure if anybody ever 
bothered to explicitly specify a Java baseline for LO, but Java 1.5 
would apparently be in line with old OOo, see 
 "Increase Java 
minimum version to 1.5 in jvmfwk."  (My memory told me that old OOo had 
still been at Java 1.4, but my memory was apparently wrong there.  The 
only potential gotcha would be that if you write extensions that shall 
be compatible with really old OOo, you would need to compile with really 
old javac -- but who cares.)



the attached (uncommitted) patch changes codemaker to produce class
files in version 49, supported by JREs 1.5 or later, effectively raising
the baseline to Java 1.5 (if it is not there already).


So I'd say, apply that to both master and libreoffice-3-5 (i.e., you can 
use my sign-off for the latter).


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: GSoC Week 1

2012-05-21 Thread Tor Lillqvist
> Just checking in. I plan to work 10am - 6pm UTC most days with an hour for
> lunch at 1 or 2, just so you know.

Great! Please keep all dicsussion on the libreoffice list (unless
specifically private). Cc:ing this reply there.

> In addition to that I'll be working on
> building LO for Android on Mac os x.

That should work as well as from Linux, yes. I used to compile for
Android on Mac OS X, too, but then I ran into disk space issues with
somany build trees on my Mac, and switched to using a Linux laptop
instead.

> I'm downloading xcode 3.2.6 to get the 10.4u SDK.

That should not be necessary now. Building with the clang from newest
Xcode, and against the 10.6 SDK, should work also; at least well
enough for the bits that are needed in a cross-compilation.  (Or gcc,
but I have tested clang lately)

You just need to pass in some options to autogen.sh; this should word:

CC_FOR_BUILD=ccache clang -arch i386 -mmacosx-version-min=10.6
CXX_FOR_BUILD=ccache clang++ -arch i386 -mmacosx-version-min=10.6
--with-build-platform-configure-options=--with-macosx-version-min-required=10.6
--with-macosx-sdk=10.6

(put that in your autogen.lastrun, i.e. treat autogen.lastrun as an
input file. or if you pass as command-line parameters, add quotes
around the "--with-macosx-version-min-required=10.6
--with-macosx-sdk=10.6".)

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [PATCH-3-5] fdo#35270 - kill first-use grammar checker freeze ...

2012-05-21 Thread Michael Meeks
Hi Daniel,

On Sun, 2012-05-20 at 19:11 +0200, Daniel Naber wrote:
> now that this is fixed I searched the archives for the reason LanguageTool 
> is not enabled by default. The slowness you talk about in [1] does not 
> sound like general Java overhead, it sounds like exactly the issue that has 
> just been fixed.

Indeed ! :-) good to have that nailed - thank you.

>  Were there other reasons LanguageTool is disabled by default? Should this
> decision maybe re-evaluated now?

So - there is/was of course, also the Java issue - that the JRE is not
present on many machines, whereas we bundle our own python runtime. That
can lead either to the horrible user-experience of complaining about
missing JRE's on first-start, and/or simply silently disabling those
components, or worse moaning about JREs as the user types which is not
that pleasant either. The other issue that windows Java downloads were
advertising the competing openoffice project in the past seems also to
be fixed now.

I guess many Linux distribution (where Java is ubiquitous) ship
languagetool, though no doubt having lightproof also enabled by default
presents some issues there. There is a minor licensing issue around the
MPL vs. LGPL.

Personally, I'm looking for a good, consistent out-of-box experience,
and (given the size of our download) am not really over-eager about
packaging / bundling an OpenJDK for windows.

Beyond that - I've no idea :-) presumably there are philosophical
differences between lightproof and languagetool that I'm not clued-up
on. It'd be interesting to hear what Laszlo & you think about it, and
other people's views on the list ...

What hope is there for sharing work, rules, etc. ? could we (for
example) have authoritative languagetool Java code, and use one of those
java2py things to compile it to python ? [ crazy thoughts of course ].
Would that offend the minimal modus operandi of lightproof ? could that
light mode be made an option ?

Thoughts on clever technical solutions much appreciated :-)

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: lo-commit-stat: why lowercase the first letter?

2012-05-21 Thread Petr Mladek
Korrawit Pruegsanusak píše v Ne 20. 05. 2012 v 11:28 +0700:
> Hello Petr, all,
> 
> Seeing a fix in wiki [1], IIUC this is generated by lo-commit-stat,
> which is intended to lowercase the first letter [2].
> 
> By git annotate, this part of code is there since the start, so I
> would like to ask:
> * why lowercase the first letter?

Every developer uses another style for the summary. I did not want to
make complicated rules and annoyed developers with "Hey, do right commit
messages" mails. So, I tried to make the commit summary more consistent
by the script. It is supposed to do:

+ use lower case for the first letter[*]
+ move bugzilla numbers at the end of the line[**]
+ put bugzilla numbers into brackets to make it better visually
  readable
+ use standardized shortcats for bugzillas, e.g. bnc# for
  bugzilla.novell.com
+ remove "." from the end of the line [***]


[*] I do not have any string opinion whether lower or uppercase letter
is better. Maybe, we should use upper case because there are
sometimes longer sentences, see
http://www.grammar-quizzes.com/punc-lists.html

Also there is problem with shortcats, for example, the script
sometimes replaces "XML" with "xML" which looks ugly


[**] It is not perfect. Developers are inventive and some styles are
 still not handled by the script.

 Note that it is useful also because we add bugzilla numbers from
 the whole commit message; It would look ugly if there are bugzilla
 numbers on two locations, with two styles, in the same sentence.


[***] I think that this it not implemented now.


> * could this behavior be removed? If yes, I can push the patch to master.

I am open for any improvement or changes. I am just curious, why don't
you like the current behavior? ;-)


> Sorry if this mail sounds offensive, it is not intended, of course :-)

It was not offensive :-) I am happy that you are trying to improve the
script.

BTW: Another problem is that it uses "git log tag1..tag2" to show new
fixes in a new release; It is not ideal because it does not detect
cherry-picked commits. It would be better to use "git cherry". Though,
it is more complicated because "git cherry" is not able to print the
full commit message and the name of the author. You would need to call
"git log" for the given commit id to get this information. If you would
want to look at it, it would be great.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Branch 'feature/gbuild_testtools' - review request

2012-05-21 Thread Stephan Bergmann

On 05/19/2012 11:44 AM, David Ostrovsky wrote:

Then of course we have to preserve them!
I just pushed another iteration. With new CustomTarget_bridgetest.mk all
those batch file are generated now and run without error, magic ;-)


Thanks.  Works great, yes.


I need a decision here: to merge it in this state to master or try to
clean it a little bit more and may be take care of pyuno directory first?


I would be fine either way.  (I'll try to remember and give this a try 
on Mac OS X, too, later today.)


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Hackfest in Munich on November 23-25

2012-05-21 Thread Marc Paré

Hi Florian,

Le 2012-05-21 03:20, Florian Effenberger a écrit :

Dear Community,

we are pleased to announce that the next LibreOffice Hackfest, the event
where developers from all over the world gather to work on the code,
discuss and have a good time, will take place

November 23-25
in Munich, Germany

For the second time already, the LiMux project team of the city of
Munich invited us, and we are proud and honoured to be their guests.

More details on the agenda, the venue and travel information will be
published over time.

Looking forward to meeting you there!


I've added this event to the LibreOffice International Calendar of 
events[1].


Marc

[1] 
http://www.libreoffice.org/about-us/libreoffice-international-events-calendar/


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: loader.loadComponentFromURL works slow when we are restoring CALC sheet from byte array | loader.loadComponentFromURL

2012-05-21 Thread Michael Meeks
Hi there,

On Mon, 2012-05-21 at 10:59 +0400, libreoffice...@gmail.com wrote:
> We use OpenOffice.org 3.2.1 Library  to   restore   OOO | LO  CALC
> sheet  from byte array and have issue  with the performance while
> using loader.loadComponentFromURL("private:stream", "_default", 0,
> args)  :

Oh - wow, 3.2.1 is pretty old :-) One rather good way to improve
performance, should be to move to using a much more recent build, say
LibreOffice 3.5.4rc1.

> I have to get XComponent object and i do it with following code:

I assume this is from C++ (?) anything else would of course cause tons
of bridging overhead in the streams.

> The problem is that loader.loadComponentFromURL("private:stream",
> "_default", 0, args); method needs 2 - 4 seconds which is not
> acceptable. If anyone knows how to improve performance, please reply.

There is ongoing work to accelerate import; what format of what is in
your byte array ? is it ODF ? 2-4 seconds sounds a lot of time - do you
have a LibreOffice instance around - ie. have you started up the suite
before that, and that's just the load time ?

HTH,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Branch 'feature/gbuild_testtools' - win & mac test request

2012-05-21 Thread d . ostrovsky

Zitat von Norbert Thiebaud :

On Mon, May 21, 2012 at 1:52 AM, David Ostrovsky  
 wrote:

Hi,

with help of David T. Stephan and Matúš this branch can be merged to master.
It would be really nice, if some of you with win & mac could test it.
If we do not hear anything withing 2 days we would merge it to master anyway
;-)


As I mentionned to dtardon earlier,
due to the number of such gebuild feature branch (half a dozen or so),
it would be nice to merge them all on a 'meta' feature branch where
merge conflict, and otehr kink can be ironed-out and tested and all
platforms.. and _then_ get it to master.


Another possibility would be to do reviewing, verification and  
hardening on gerrit. Unfortunately gerrit was outdating last time i  
tried to push to it,

and you and Bjorn were busy at UDC ;-)

When can we really use it with:
git push gerrit HEAD:refs/for/master
or even push to gerrit before merge to master:
git push gerrit HEAD:refs/for/feature/gbuild_testtools

Note: I'm aware that at this time no push from gerrit to fdo git  
repository is possible. But anybody could review and pull from gerrit  
and feed their tinderboxes (or whatever CI build server they use) with  
it.


Thanks
David
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: Branch 'feature/gbuild_testtools' - win & mac test request

2012-05-21 Thread Norbert Thiebaud
On Mon, May 21, 2012 at 1:52 AM, David Ostrovsky  wrote:
> Hi,
>
> with help of David T. Stephan and Matúš this branch can be merged to master.
> It would be really nice, if some of you with win & mac could test it.
> If we do not hear anything withing 2 days we would merge it to master anyway
> ;-)

As I mentionned to dtardon earlier,
due to the number of such gebuild feature branch (half a dozen or so),
it would be nice to merge them all on a 'meta' feature branch where
merge conflict, and otehr kink can be ironed-out and tested and all
platforms.. and _then_ get it to master.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Hackfest in Munich on November 23-25

2012-05-21 Thread Florian Effenberger

Dear Community,

we are pleased to announce that the next LibreOffice Hackfest, the event 
where developers from all over the world gather to work on the code, 
discuss and have a good time, will take place


November 23-25
in Munich, Germany

For the second time already, the LiMux project team of the city of 
Munich invited us, and we are proud and honoured to be their guests.


More details on the agenda, the venue and travel information will be 
published over time.


Looking forward to meeting you there!

And for those attending LinuxTag in Berlin this week, LibreOffice and 
TDF will have a booth there, and in Friday's office track, several 
exciting talks will be held by members of our community.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice] [GSoC 2011][svg export filter] GSoC project start

2012-05-21 Thread Marco Cecchetti


Hi Thorsten, everyone,
so it's time to start working on the project. :)

I pushed a new feature branch named feature/svg-export,
where I'll commit all contributions I 'm going to provide
on GSoC time-frame.
At present there are two initial commits: the first one is
a technical commit where I fixed some indentation issue,
the second is an improvement of the Python script that generates
the c++ header from the JavaScript engine: now debug printers are
turned off automatically by the Python script, so there is no more
the need to turn them off manually before performing a commit.

The first task I'll tackle is to rework the navigation part of the
JavaScript engine in order to be able to implement the support for
slide transition.

In order to enable support for slide transitions we need to modify
the way draw pages and master pages are exported by the svg export
filter.

The following two examples point out the motivations for such
modifications.

  * Given two slides A and B targeting the same master page and
a push transition (say from left to right) used to pass from slide A
to slide B, we have that the shared master page has to be both
leaving from the right and entering from the left at the same time.

  * Given two slides A and B targeting the same master page, but
with two different master page footer field contents, and a fade
transition used to pass from slide A to slide B, the shared footer
field should be updated with the specific content of both slides
at the same time.

Master page elements will be wrapped by a  element and
referenced by  elements where needed.
An exported draw page will have the following structure:
* 
*
*
*// this is the old Slide element
*
* 

The master page view will have the following structure:
*  
* // reference to master page
background element
*  
* // cloned elements
*  
*  ...
*  
*  
*  ...
*  
*  
*  ...
*  
*  
*  ...
*  
*  
*   // reference to the group of
shapes
* // on the master page
*  

So in a master page view the Background and BackgroundShapes elements
are referenced by  elements, whilst text field elements are cloned
from the master page into the master page view per each slide, in order
to support different text content for each slide.

So, that is the initial plan.
I'll provide a log book and a weekly report.

I wish good work (and fun) to all gsocers. :)

Cheers,
-- Marco

--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice