[Libreoffice-commits] .: regexp/inc

[David Tardon]

 regexp/inc/regexp/reclass.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 591395a832aba635f9c8cf4e71a3558f14f41a37
Author: David Tardon 
Date:   Mon Aug 6 06:46:06 2012 +0200

add accidentally removed */

Change-Id: I876a229f623ac53f994570297eb51248997b0a92

diff --git a/regexp/inc/regexp/reclass.hxx b/regexp/inc/regexp/reclass.hxx
index 1b1f6d9..f61112d 100644
--- a/regexp/inc/regexp/reclass.hxx
+++ b/regexp/inc/regexp/reclass.hxx
@@ -199,7 +199,7 @@ typedef enum
 on_failure_keep_string_jump,
 
 /** Throw away latest failure point and then
-jump to following two-byte relative address.
+jump to following two-byte relative address. */
 pop_failure_jump,
 
 /** Change to pop_failure_jump if know won't have to backtrack to match;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-qa] OLE Objects and Impress/Draw

[Olivier Hallot]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Thanks Regina for the answer.

It is interesting to apply the fix in the bug id=118505 to LibreOffice,
if possible (and legal).

Regards,


Em 04-08-2012 18:32, Regina Henschel escreveu:
> Hi Oliver,
> 
> Olivier Hallot schrieb:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> Hi
>>
>> The context menu of an OLE object inside Impress or Draw shows "OLE
>> Object" entry. However, clicking on it does absolutely nothing (since LO
>> 3.3). What this entry is supposed to do? (I tried with a Calc range
>> pasted in Impress as calc8 object)
> 
> It should call .uno:ObjectMenue. That is the same item as "Object" in
> the menu Edit. The items in that sub-menu provide so called "VerbID" as
> parameter to this command. These VerbID are actions, which are possible
> with the application which is connected to the object.
> 
> The item 'Object' has never worked. But it is not needed at all, because
> the items from the sub-menu are already directly available as last items
> in the context menu. In AOO the item 'Object' is already removed.
> https://issues.apache.org/ooo/show_bug.cgi?id=118505
> 
>>
>> It also seems that we cannot paste a range of cell inside Impress or
>> Draw as a DDE link... but we can do it in Writer. Is that correct?
> 
> It seems so. But I don't know why. Perhaps the new table objects of
> Draw/Impress are not able to held a DDE connection?
> 
> Kind regards
> Regina
> 

- -- 
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Fundação responsável civilmente, de acordo com o direito civil
Detalhes Legais: http://www.documentfoundation.org/imprint
LibreOffice translation leader for Brazilian Portuguese
+55-21-8822-8812
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJQHx38AAoJEJp3R7nH3vLxRrwIAKkJUTZ5t0JR+A2jhNH7IoGY
4Vdr9sTaHCfilePlmSXE21w5cqNBGrtak+aWvpTEmOzRbr9iMytabYmh/62uq/v+
9rFDwjr0YQl46dTU0PXpdQ0jwpGRLTzOnU0iD+eWJlfGnLayhGFoyRYlaAgy38hU
SITaLViIT4uZ+G6BuQpmxzAhKH/u3UBHsqF8bcMc9TpBfQVDkX0G6tys+wGxRvcP
yI2YaIMmqlvcMQ2ML4Ck3l4MAADMelqvn1vMNm1W4eRvNSTu0zk4+/V7M8jn34G+
oV0UTDtAJ0oRXnloanSHg4LN898+etDeoypulrDy6lv+fTPNUeo5ihRwIVnqJWs=
=mMZv
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/inc sc/source

[Markus Mohrhard]

 sc/inc/column.hxx   |3 
 sc/source/core/data/column2.cxx |  169 ++--
 2 files changed, 117 insertions(+), 55 deletions(-)

New commits:
commit 1e2964e55e6fc791b911998ca710a9f174c3d1ef
Author: Markus Mohrhard 
Date:   Sun Aug 5 20:28:03 2012 +0200

skip hidden rows when moving with the cursor, fdo#45020

Change-Id: I3b12d774914599489dea2bb711b2d057111b677b

diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx
index 6f776e1..6bc8c8c 100644
--- a/sc/inc/column.hxx
+++ b/sc/inc/column.hxx
@@ -389,6 +389,9 @@ public:
 
 private:
 ScBaseCell* CloneCell(SCSIZE nIndex, sal_uInt16 nFlags, ScDocument& 
rDestDoc, const ScAddress& rDestPos);
+
+SCROW FindNextVisibleRowWithContent(SCROW nRow, bool bForward) const;
+SCROW FindNextVisibleRow(SCROW nRow, bool bForward) const;
 };
 
 
diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index dba0fc6..f22fec0 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1307,11 +1307,102 @@ bool ScColumn::GetNextDataPos(SCROW& rRow) const   
 // greater than rRow
 return bMore;
 }
 
+SCROW ScColumn::FindNextVisibleRow(SCROW nRow, bool bForward) const
+{
+if(bForward)
+{
+nRow++;
+SCROW nEndRow = 0;
+bool bHidden = pDocument->RowHidden(nRow, nTab, NULL, &nEndRow);
+if(bHidden)
+return std::min(MAXROW, nEndRow + 1);
+else
+return nRow;
+}
+else
+{
+nRow--;
+SCROW nStartRow = MAXROW;
+bool bHidden = pDocument->RowHidden(nRow, nTab, &nStartRow, NULL);
+if(bHidden)
+return std::max(0, nStartRow - 1);
+else
+return nRow;
+}
+}
+
+SCROW ScColumn::FindNextVisibleRowWithContent(SCROW nRow, bool bForward) const
+{
+if(bForward)
+{
+bool bFound = false;
+do
+{
+nRow++;
+SCROW nEndRow = 0;
+bool bHidden = pDocument->RowHidden(nRow, nTab, NULL, &nEndRow);
+if(bHidden)
+{
+nRow = nEndRow + 1;
+if(nRow >= MAXROW)
+return MAXROW;
+}
+
+SCSIZE nIndex;
+bool bThere = Search( nRow, nIndex );
+if( bThere && !maItems[nIndex].pCell->IsBlank())
+return nRow;
+else if(nIndex >= maItems.size())
+return MAXROW;
+else
+{
+if(bThere)
+nRow = maItems[nIndex+1].nRow - 1;
+else
+nRow = maItems[nIndex].nRow - 1;
+}
+}
+while(!bFound && nRow < MAXROW);
+
+return MAXROW;
+}
+else
+{
+bool bFound = false;
+do
+{
+nRow--;
+SCROW nStartRow = MAXROW;
+bool bHidden = pDocument->RowHidden(nRow, nTab, &nStartRow, NULL);
+if(bHidden)
+{
+nRow = nStartRow - 1;
+if(nRow <= 0)
+return 0;
+}
+
+SCSIZE nIndex;
+bool bThere = Search( nRow, nIndex );
+if(bThere && !maItems[nIndex].pCell->IsBlank())
+return nRow;
+else if(nIndex == 0)
+return 0;
+else
+nRow = maItems[nIndex-1].nRow + 1;
+}
+while(!bFound && nRow > 0);
+
+return 0;
+}
+}
+
 void ScColumn::FindDataAreaPos(SCROW& rRow, long nMovY) const
 {
-if (!nMovY) return;
+if (!nMovY)
+   return;
 bool bForward = (nMovY>0);
 
+// check if we are in a data area
 SCSIZE nIndex;
 bool bThere = Search(rRow, nIndex);
 if (bThere && maItems[nIndex].pCell->IsBlank())
@@ -1320,69 +1411,37 @@ void ScColumn::FindDataAreaPos(SCROW& rRow, long nMovY) 
const
 size_t nLastIndex = maItems.size() - 1;
 if (bThere)
 {
-SCROW nLast = rRow;
-SCSIZE nOldIndex = nIndex;
-if (bForward)
+SCROW nNextRow = FindNextVisibleRow(rRow, bForward);
+SCSIZE nNewIndex;
+bool bNextThere = Search(nNextRow, nNewIndex);
+if(bNextThere && maItems[nNewIndex].pCell->IsBlank())
+bNextThere = false;
+
+if(bNextThere)
 {
-if (nIndexIsBlank())
-{
-++nIndex;
-++nLast;
-}
-if (nIndex==nLastIndex)
-if (maItems[nIndex].nRow==nLast+1 && 
!maItems[nIndex].pCell->IsBlank())
-++nLast;
+nNextRow = FindNextVisibleRow(nLastRow, bForward);
+bNextThere = Search(nNextRow, nNewIndex);
+if(!bNextThere || maItems[nNewIndex].pCell->IsBlank())
+bNextThere = false;
+else
+nLastRow = nNextRow;
 }
+while(bNextTh

[Libreoffice-commits] .: regexp/inc sd/inc sd/source

[Philipp Riemer]

 regexp/inc/regexp/reclass.hxx|  233 ++-
 sd/inc/anminfo.hxx   |   26 +-
 sd/inc/sdpage.hxx|   30 +-
 sd/inc/sdpptwrp.hxx  |2 
 sd/inc/sdxmlwrp.hxx  |6 
 sd/source/filter/eppt/eppt.hxx   |4 
 sd/source/filter/eppt/escherex.hxx   |   16 -
 sd/source/filter/eppt/pptexsoundcollection.hxx   |4 
 sd/source/filter/html/htmlex.hxx |   10 
 sd/source/ui/animations/motionpathtag.hxx|   11 -
 sd/source/ui/annotations/annotationtag.hxx   |   10 
 sd/source/ui/presenter/CanvasUpdateRequester.hxx |4 
 12 files changed, 162 insertions(+), 194 deletions(-)

New commits:
commit 78b55ad11365bb97def308071bc45ca52cc557c7
Author: Norah A. Abanumay 
Date:   Sun Aug 5 13:32:31 2012 +0300

Convert documents to follow the doxygen standard (fdo#44502, fdo#39468)

Change-Id: I58c73f74d53b5dc2eb462fb03664be65d4500170
Reviewed-by: Philipp Riemer 

diff --git a/regexp/inc/regexp/reclass.hxx b/regexp/inc/regexp/reclass.hxx
index cc9bf1d..1b1f6d9 100644
--- a/regexp/inc/regexp/reclass.hxx
+++ b/regexp/inc/regexp/reclass.hxx
@@ -45,35 +45,35 @@
 typedef enum
 {
 #ifdef _XOPEN_SOURCE
-  REG_ENOSYS = -1,  /* This will never happen for this implementation.  */
+  REG_ENOSYS = -1,  ///< This will never happen for this implementation.
 #endif
 
-  REG_NOERROR = 0,  /* Success.  */
-  REG_NOMATCH,  /* Didn't find a match (for regexec).  */
+  REG_NOERROR = 0,  ///< Success.
+  REG_NOMATCH,  ///< Didn't find a match (for regexec).
 
   /* POSIX regcomp return error codes.  (In the order listed in the
  standard.)  */
-  REG_BADPAT,   /* Invalid pattern.  */
-  REG_ECOLLATE, /* Not implemented.  */
-  REG_ECTYPE,   /* Invalid character class name.  */
-  REG_EESCAPE,  /* Trailing backslash.  */
-  REG_ESUBREG,  /* Invalid back reference.  */
-  REG_EBRACK,   /* Unmatched left bracket.  */
-  REG_EPAREN,   /* Parenthesis imbalance.  */
-  REG_EBRACE,   /* Unmatched \{.  */
-  REG_BADBR,/* Invalid contents of \{\}.  */
-  REG_ERANGE,   /* Invalid range end.  */
-  REG_ESPACE,   /* Ran out of memory.  */
-  REG_BADRPT,   /* No preceding re for repetition op.  */
+  REG_BADPAT,   ///< Invalid pattern.
+  REG_ECOLLATE, ///< Not implemented.
+  REG_ECTYPE,   ///< Invalid character class name.
+  REG_EESCAPE,  ///< Trailing backslash.
+  REG_ESUBREG,  ///< Invalid back reference.
+  REG_EBRACK,   ///< Unmatched left bracket.
+  REG_EPAREN,   ///< Parenthesis imbalance.
+  REG_EBRACE,   ///< Unmatched \{.
+  REG_BADBR,///< Invalid contents of \{\}.
+  REG_ERANGE,   ///< Invalid range end.
+  REG_ESPACE,   ///< Ran out of memory.
+  REG_BADRPT,   ///< No preceding re for repetition op.
 
   /* Error codes we've added.  */
-  REG_EEND, /* Premature end.  */
-  REG_ESIZE,/* Compiled pattern bigger than 2^16 bytes.  */
-  REG_ERPAREN   /* Unmatched ) or \); not returned from regcomp.  */
+  REG_EEND, ///< Premature end.
+  REG_ESIZE,///< Compiled pattern bigger than 2^16 bytes.
+  REG_ERPAREN   ///< Unmatched ) or \); not returned from regcomp.
 } reg_errcode_t;
 
 
-/* This data structure represents a compiled pattern.  Before calling
+/** This data structure represents a compiled pattern.  Before calling
the pattern compiler, the fields `buffer', `allocated', `fastmap',
can be set.  After the pattern has been
compiled, the `re_nsub' field is available.  All other fields are
@@ -83,44 +83,41 @@ struct REGEXP_DLLPUBLIC re_pattern_buffer
 {
 /* [[[begin pattern_buffer]]] */
 /* Space that holds the compiled pattern.  It is declared as
-  `unsigned char *' because its elements are
-   sometimes used as array indexes.  */
+   `unsigned char *' because its elements are
+sometimes used as array indexes. */
   sal_Unicode *buffer;
 
-/* Number of bytes to which `buffer' points.  */
+  /// Number of bytes to which `buffer' points.
   sal_uInt32 allocated;
 
-/* Number of bytes actually used in `buffer'.  */
+  /// Number of bytes actually used in `buffer'.
   sal_uInt32 used;
 
-/* Pointer to a fastmap, if any, otherwise zero.  re_search uses
-   the fastmap, if there is one, to skip over impossible
-   starting points for matches.  */
+  /** Pointer to a fastmap, if any, otherwise zero.  re_search uses the 
fastmap,
+  if there is one, to skip over impossible starting points for matches. */
   sal_Unicode *fastmap;
 
-
-/* Number of subexpressions found by the compiler.  */
+  /// Number of subexpressions found by the compiler.
   size_t re_nsub;
 
-/* Zero if this pattern cannot match the empty string, one else.
-   Well, in truth it's used only in `re_search2', to se

[Libreoffice-commits] .: bean/com bridges/test javaunohelper/com javaunohelper/test odk/examples qadevOOo/runner qadevOOo/tests sc/qa scripting/workben unotest/source

[Julien Nabet]

 bean/com/sun/star/beans/LocalOfficeConnection.java |2 
+-
 bridges/test/testclient.java   |9 
++---
 javaunohelper/com/sun/star/comp/helper/Bootstrap.java  |2 
+-
 javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java |2 
+-
 javaunohelper/test/com/sun/star/lib/uno/helper/WeakBase_Test.java  |4 
++--
 odk/examples/DevelopersGuide/Charts/SelectionChangeListener.java   |2 
+-
 qadevOOo/runner/util/utils.java|2 
+-
 qadevOOo/tests/java/ifc/sheet/_XEnhancedMouseClickBroadcaster.java |2 
+-
 qadevOOo/tests/java/ifc/ucb/_XCommandProcessor.java|2 
+-
 qadevOOo/tests/java/mod/_sc/ScAccessiblePreviewHeaderCell.java |3 
+--
 qadevOOo/tests/java/mod/_toolkit/AccessibleTabControl.java |3 
+--
 qadevOOo/tests/java/mod/_toolkit/AccessibleTabPage.java|2 
+-
 sc/qa/complex/calcPreview/ViewForwarder.java   |6 
+++---
 scripting/workben/ifc/scripting/SecurityDialogUtil.java|2 
+-
 unotest/source/java/org/openoffice/test/OfficeConnection.java  |2 
+-
 15 files changed, 19 insertions(+), 26 deletions(-)

New commits:
commit b80b7ba1791cdd9e79ed7a380b8981878f46b8a4
Author: Julien Nabet 
Date:   Mon Aug 6 00:12:34 2012 +0200

Static method sleep from Thread should be accessed in a static way

Change-Id: I7d875dd74f8eff05f7a291100841779abbf5fd1c

diff --git a/bean/com/sun/star/beans/LocalOfficeConnection.java 
b/bean/com/sun/star/beans/LocalOfficeConnection.java
index f999ee4..6d81ac6 100644
--- a/bean/com/sun/star/beans/LocalOfficeConnection.java
+++ b/bean/com/sun/star/beans/LocalOfficeConnection.java
@@ -242,7 +242,7 @@ public class LocalOfficeConnection
 try
 {
 // try to connect to soffice
-Thread.currentThread().sleep( 500 );
+Thread.sleep( 500 );
 aInitialObject = xUrlResolver.resolve( mURL );
 }
 catch( com.sun.star.connection.NoConnectException aEx )
diff --git a/bridges/test/testclient.java b/bridges/test/testclient.java
index 217fe96..402485c 100644
--- a/bridges/test/testclient.java
+++ b/bridges/test/testclient.java
@@ -69,9 +69,8 @@ class MyCallMe implements XCallMe
 public void callOneway( /*IN*/String s, /*IN*/int nToDo ) throws 
com.sun.star.uno.RuntimeException
 {
 System.out.println( "entering callOneway" );
-//  this.wait( 5 );
 try {
-Thread.currentThread().sleep( 4000 );
+Thread.sleep( 4000 );
 }
 catch ( java.lang.Exception e )
 {
@@ -125,12 +124,8 @@ public class testclient
 new Object[]{"iiop", xConnection, new 
MyInstanceProvider()});
 
 System.out.println( "after building bridge" );
-//  Object rInitialObject = m_bridge.mapInterfaceFrom(rootOid, 
XInterface.class);
-//  XTestFactory rFactory =
-//  
UnoRuntime.queryInterface(XTestFactory.class,rInitialObject );
 
-//  XCallMe callMerFactory->
-Thread.currentThread().sleep( 10 );
+Thread.sleep( 10 );
 }
 }
 catch( com.sun.star.uno.Exception e)
diff --git a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java 
b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
index b8a3bf1..120217f 100644
--- a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
+++ b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java
@@ -282,7 +282,7 @@ public class Bootstrap {
 if (i == 600) {
 throw new BootstrapException(ex.toString());
 }
-Thread.currentThread().sleep( 500 );
+Thread.sleep( 500 );
 }
 }
 } catch ( BootstrapException e ) {
diff --git 
a/javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java 
b/javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java
index 68b1f1a..c452fc5 100644
--- a/javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java
+++ b/javaunohelper/test/com/sun/star/lib/uno/helper/ComponentBase_Test.java
@@ -102,7 +102,7 @@ public class ComponentBase_Test
 {
 try
 {
-Thread.currentThread().sleep(100);
+Thread.sleep(100);
 System.gc();
 System.runFinalization();
 }catch (InterruptedException ie)
diff --git a/javaunohelper/test/com/sun/star/lib/uno/helper/WeakBase_Test.java 
b/javaunohelper/test/com/sun/star/lib/uno/helper/WeakBase_Test.java
index 25e93eb..

[Libreoffice-commits] .: binfilter/inc

[Thomas Arnhold]

 binfilter/inc/bf_basic/sbxcore.hxx |   15 
 binfilter/inc/bf_sfx2/docfac.hxx   |  128 -
 2 files changed, 143 deletions(-)

New commits:
commit e238a59430ce1f2e45469faf14d9c0a4d151b60e
Author: Thomas Arnhold 
Date:   Sun Aug 5 20:31:14 2012 +0200

Remove unused macros

Change-Id: I494b76bfd37a255ac4a2ab1cab000ff4af485030

diff --git a/binfilter/inc/bf_basic/sbxcore.hxx 
b/binfilter/inc/bf_basic/sbxcore.hxx
index 64ade67..988720d 100644
--- a/binfilter/inc/bf_basic/sbxcore.hxx
+++ b/binfilter/inc/bf_basic/sbxcore.hxx
@@ -47,11 +47,6 @@ namespace rtl { class OUString; }
 virtual UINT16 GetVersion() const { return nVer;   }\
 virtual UINT16 GetSbxId() const   { return nSbxId; }
 
-#define SBX_DECL_PERSIST_NODATA_()  \
-virtual UINT32 GetCreator() const;  \
-virtual UINT16 GetVersion() const;  \
-virtual UINT16 GetSbxId() const;
-
 // Diese Version des Makros definiert Load/StorePrivateData()-Methoden
 
 #define SBX_DECL_PERSIST( nCre, nSbxId, nVer )  \
@@ -59,16 +54,6 @@ namespace rtl { class OUString; }
 virtual BOOL StorePrivateData( SvStream& ) const;   \
 SBX_DECL_PERSIST_NODATA( nCre, nSbxId, nVer )
 
-#define SBX_DECL_PERSIST_() \
-virtual BOOL LoadPrivateData( SvStream&, USHORT );  \
-virtual BOOL StorePrivateData( SvStream& ) const;   \
-SBX_DECL_PERSIST_NODATA_()
-
-#define SBX_IMPL_PERSIST( C, nCre, nSbxId, nVer )   \
-UINT32 C::GetCreator() const { return nCre;   } \
-UINT16 C::GetVersion() const { return nVer;   } \
-UINT16 C::GetSbxId() const   { return nSbxId; }
-
 namespace binfilter {
 
 class SbxBase;
diff --git a/binfilter/inc/bf_sfx2/docfac.hxx b/binfilter/inc/bf_sfx2/docfac.hxx
index 7b88fce..23018ef 100644
--- a/binfilter/inc/bf_sfx2/docfac.hxx
+++ b/binfilter/inc/bf_sfx2/docfac.hxx
@@ -147,35 +147,6 @@ private:
 
 //=
 
-/*  SFX_DECL_OBJECTFACTORY
-
-[Description]
-
-This macro declares an SfxObjectFactory for subclasses of SfxObjectShell
-which are derived too from SfxInPlaceObject and are linked to an executable
-or linked to a permanently loaded library.
-The macro must be used in the public-area of the declaration of the
-SfxObjectShell subclass.
-*/
-
-#define SFX_DECL_OBJECTFACTORY(Class)   \
-private:\
-static SfxObjectFactory*pObjectFactory; \
-protected:  \
-virtual BOOLClose();\
-public: \
-SO2_DECL_BASIC_CLASS(Class) \
-virtual BOOLDoClose();  \
-static SfxObjectShell*  CreateObject(SfxObjectCreateMode eMode = 
SFX_CREATE_MODE_STANDARD); \
-static void InitFactory();  \
-static SfxObjectFactory&Factory() { return 
*(SfxObjectFactory*)ClassFactory(); } \
-static void RegisterFactory( USHORT nPrio = USHRT_MAX );\
-virtual BOOLDoInitNew( SvStorage * );   \
-virtual voidModifyChanged();\
-virtual SfxObjectFactory&   GetFactory() const
-
-//-
-
 /*  SFX_DECL_OBJECTFACTORY_DLL
 
 [Description]
@@ -203,107 +174,8 @@ public:   
  \
 virtual voidModifyChanged();\
 virtual SfxObjectFactory&   GetFactory() const
 
-//
-
-/*  SFX_DECL_SIMPLE_OBJECTFACTORY
-
-[Description]
-
-This macro declares an SfxObjectFactory for subclasses of SfxObjectShell
-which are NOT derived from SfxInPlaceObject but are linked to an executable
-or to permanently loaded dll.
-The macro must be used in the public-area of the declaration of the
-SfxObjectShell subclass.
-*/
-
-#define SFX_DECL_SIMPLE_OBJECTFACTORY(Class)\
-private:\
-static SfxObjectFactory*pObjectFactory; \
-public: \
-static SfxObjectShell*  CreateObject(SfxObjectCreateMode eMode = 
SFX_CREATE_MODE_STANDARD); \
-static void InitFactory();  \
-static SfxObjectFactory&Factor

[Libreoffice-commits] .: connectivity/source dbaccess/source extensions/source framework/inc idl/inc sc/source tools/inc ucb/source UnoControls/source

[Thomas Arnhold]

 UnoControls/source/base/registercontrols.cxx |   20 --
 connectivity/source/drivers/postgresql/pq_connection.hxx |5 --
 dbaccess/source/inc/apitools.hxx |   28 ---
 dbaccess/source/ui/misc/TokenWriter.cxx  |5 --
 extensions/source/scanner/sane.cxx   |8 
 framework/inc/macros/generic.hxx |4 --
 framework/inc/macros/xserviceinfo.hxx|   13 --
 idl/inc/basobj.hxx   |8 
 sc/source/filter/html/htmlexp.cxx|6 ---
 sc/source/ui/inc/reffact.hxx |8 
 sc/source/ui/view/formatsh.cxx   |   19 --
 tools/inc/tools/link.hxx |3 -
 tools/inc/tools/pstm.hxx |4 --
 tools/inc/tools/ref.hxx  |7 ---
 tools/inc/tools/string.hxx   |5 --
 ucb/source/ucp/ftp/ftpurl.cxx|   14 ---
 16 files changed, 157 deletions(-)

New commits:
commit c04c2114d91596464807d026c9fee6953817
Author: Thomas Arnhold 
Date:   Sun Aug 5 20:31:29 2012 +0200

Remove unused macros

Change-Id: I184a7f9c65dd762407b2431d9c6557e718b954b2

diff --git a/UnoControls/source/base/registercontrols.cxx 
b/UnoControls/source/base/registercontrols.cxx
index 5389f3e..50dd26c 100644
--- a/UnoControls/source/base/registercontrols.cxx
+++ b/UnoControls/source/base/registercontrols.cxx
@@ -67,18 +67,6 @@ using namespace ::com::sun::star::registry   
   ;
 }
 
 
//**
-#define CREATEFACTORY_ONEINSTANCE(CLASS)   
 \
-   
 \
-/* Create right factory ... */ 
 \
-xFactory = Reference< XSingleServiceFactory >  
 \
-(  
 \
-cppu::createOneInstanceFactory  (   xServiceManager
 ,   \
-
CLASS::impl_getStaticImplementationName ()  ,   \
-
CLASS##_createInstance  ,   \
-
CLASS::impl_getStaticSupportedServiceNames  ()  )   \
-) ;
 \
-
-//**
 #define CREATEFACTORY_SINGLE(CLASS)
 \

 \
 /* Create right factory ... */ 
 \
@@ -91,14 +79,6 @@ using namespace ::com::sun::star::registry   
   ;
 ) ;
 \
 
 
//**
-#define IF_NAME_CREATECOMPONENTFACTORY_ONEINSTANCE(CLASS)  
 \
-   
 \
-if ( CLASS::impl_getStaticImplementationName().equals( 
OUString::createFromAscii( pImplementationName ) ) ) \
-{  
 \
-CREATEFACTORY_ONEINSTANCE ( CLASS )
 \
-}
-
-//**
 #define IF_NAME_CREATECOMPONENTFACTORY_SINGLE(CLASS)   
 \

 \
 if ( CLASS::impl_getStaticImplementationName().equals( 
OUString::crea

[Libreoffice-commits] .: sw/source unusedcode.easy

[Julien Nabet]

 sw/source/filter/ww8/rtfattributeoutput.cxx |   10 --
 sw/source/filter/ww8/rtfattributeoutput.hxx |1 -
 unusedcode.easy |1 -
 3 files changed, 12 deletions(-)

New commits:
commit a76dac1fb62823c357ad8f2bd789483b7ea7badd
Author: Julien Nabet 
Date:   Sun Aug 5 19:28:40 2012 +0200

Bin OString RtfAttributeOutput::WriteHex (unusedcode.easy)

Change-Id: I6c76d43319aec669982a9694e7f98e5ae1d1a4de

diff --git a/sw/source/filter/ww8/rtfattributeoutput.cxx 
b/sw/source/filter/ww8/rtfattributeoutput.cxx
index a02d407..de19745 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.cxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.cxx
@@ -3230,16 +3230,6 @@ OString RtfAttributeOutput::WriteHex(sal_Int32 nNum)
 return RtfAttributeOutput::WriteHex((sal_uInt8*)&nNum, sizeof(sal_Int32));
 }
 
-OString RtfAttributeOutput::WriteHex(OString sString)
-{
-RtfStringBuffer aRet;
-
-aRet->append(WriteHex(sString.getLength()+1));
-aRet->append(RtfAttributeOutput::WriteHex((sal_uInt8*)sString.getStr(), 
sString.getLength()+1));
-
-return aRet.makeStringAndClear();
-}
-
 void lcl_AppendSP( OStringBuffer& rBuffer,
 const char cName[],
 const ::rtl::OUString& rValue,
diff --git a/sw/source/filter/ww8/rtfattributeoutput.hxx 
b/sw/source/filter/ww8/rtfattributeoutput.hxx
index 14e59f3..4a13da4 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.hxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.hxx
@@ -589,7 +589,6 @@ public:
 /// Writes binary data as a hex dump.
 static rtl::OString WriteHex(const sal_uInt8* pData, sal_uInt32 nSize, 
SvStream* pStream = 0, sal_uInt32 nLimit = 64);
 static rtl::OString WriteHex(sal_Int32 nNum);
-static rtl::OString WriteHex(rtl::OString sString);
 };
 
 #endif // _RTFATTRIBUTEOUTPUT_HXX_
diff --git a/unusedcode.easy b/unusedcode.easy
index 2a0f9b0..b0b79a2 100755
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -1,6 +1,5 @@
 FontSelectPattern::FontSelectPattern(PhysicalFontFace const&, Size const&, 
float, int, bool)
 PopupMenu::SetSelectedEntry(unsigned short)
-RtfAttributeOutput::WriteHex(rtl::OString)
 SanExtensionImpl::setCertExtn(com::sun::star::uno::Sequence, 
com::sun::star::uno::Sequence, unsigned char)
 SanExtensionImpl::setCertExtn(unsigned char*, unsigned int, unsigned char*, 
unsigned int, unsigned char)
 ScCompressedArray::GetEntryCount() const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 4 commits - starmath/source

[Ivan Timofeev]

 starmath/source/view.cxx |   65 ++-
 1 file changed, 14 insertions(+), 51 deletions(-)

New commits:
commit c4486f247891cefe662dae0f5ef6581ebdca
Author: Ivan Timofeev 
Date:   Sun Aug 5 20:29:20 2012 +0400

SmCmdBoxWindow: use single-line frame

Change-Id: I527ae337a9e445d911dba956daf9d76f9d7572de

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index ad6c232..5707439 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -730,7 +730,7 @@ void SmCmdBoxWindow::Resize()
 aRect.Bottom() -= CMD_BOX_PADDING;
 
 DecorationView aView(this);
-aRect = aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN | FRAME_DRAW_NODRAW );
+aRect = aView.DrawFrame( aRect, FRAME_DRAW_IN | FRAME_DRAW_NODRAW );
 
 aEdit.SetPosSizePixel(aRect.TopLeft(), aRect.GetSize());
 SfxDockingWindow::Resize();
@@ -747,7 +747,7 @@ void SmCmdBoxWindow::Paint(const Rectangle& /*rRect*/)
 aRect.Bottom() -= CMD_BOX_PADDING;
 
 DecorationView aView(this);
-aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN );
+aView.DrawFrame( aRect, FRAME_DRAW_IN );
 }
 
 
commit d1501aa5e8f40b6016753f9fb34181a4f914a1d5
Author: Ivan Timofeev 
Date:   Sun Aug 5 19:12:39 2012 +0400

SmCmdBoxWindow: reduce padding from 8 to 4

Change-Id: If87bc63b4bd3fd27eef665261667478d9284ff0b

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index a7af464..ad6c232 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -74,6 +74,9 @@
 #define MINZOOM 25
 #define MAXZOOM 800
 
+// space around the edit window, in pixels
+#define CMD_BOX_PADDING 4
+
 #define SmViewShell
 #include "smslots.hxx"
 
@@ -721,9 +724,12 @@ SmViewShell * SmCmdBoxWindow::GetView()
 void SmCmdBoxWindow::Resize()
 {
 Rectangle aRect = Rectangle(Point(0, 0), GetOutputSizePixel());
+aRect.Left()   += CMD_BOX_PADDING;
+aRect.Top()+= CMD_BOX_PADDING;
+aRect.Right()  -= CMD_BOX_PADDING;
+aRect.Bottom() -= CMD_BOX_PADDING;
+
 DecorationView aView(this);
-aRect.Left() += 8; aRect.Top()   += 8;
-aRect.Right()-= 8; aRect.Bottom()-= 8;
 aRect = aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN | FRAME_DRAW_NODRAW );
 
 aEdit.SetPosSizePixel(aRect.TopLeft(), aRect.GetSize());
@@ -735,10 +741,13 @@ void SmCmdBoxWindow::Resize()
 void SmCmdBoxWindow::Paint(const Rectangle& /*rRect*/)
 {
 Rectangle aRect = Rectangle(Point(0, 0), GetOutputSizePixel());
+aRect.Left()   += CMD_BOX_PADDING;
+aRect.Top()+= CMD_BOX_PADDING;
+aRect.Right()  -= CMD_BOX_PADDING;
+aRect.Bottom() -= CMD_BOX_PADDING;
+
 DecorationView aView(this);
-aRect.Left() += 8; aRect.Top()   += 8;
-aRect.Right()-= 8; aRect.Bottom()-= 8;
-aRect = aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN );
+aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN );
 }
 
 
commit 20d4cd5e08c1400fcc5ae5eb45861f429b914969
Author: Ivan Timofeev 
Date:   Sun Aug 5 18:54:52 2012 +0400

SmCmdBoxWindow: no drawing in Resize()

Change-Id: I7cd7bb2e1bf37e41c0bea81c3ac6ec74feaa87bf

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 798b998..a7af464 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -724,7 +724,7 @@ void SmCmdBoxWindow::Resize()
 DecorationView aView(this);
 aRect.Left() += 8; aRect.Top()   += 8;
 aRect.Right()-= 8; aRect.Bottom()-= 8;
-aRect = aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN );
+aRect = aView.DrawFrame( aRect, FRAME_DRAW_DOUBLEIN | FRAME_DRAW_NODRAW );
 
 aEdit.SetPosSizePixel(aRect.TopLeft(), aRect.GetSize());
 SfxDockingWindow::Resize();
commit 79509fa629055cdfaca2011fddb4291ed8b3f7dd
Author: Ivan Timofeev 
Date:   Sun Aug 5 18:51:49 2012 +0400

SmCmdBoxWindow: too many frames...

Change-Id: If93baa96c7eacdeae6ad2fdecbe33fc141934094

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index f1365b4..798b998 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -721,20 +721,6 @@ SmViewShell * SmCmdBoxWindow::GetView()
 void SmCmdBoxWindow::Resize()
 {
 Rectangle aRect = Rectangle(Point(0, 0), GetOutputSizePixel());
-
-if (! IsFloatingMode())
-{
-switch (GetAlignment())
-{
-case SFX_ALIGN_TOP: aRect.Bottom()--;   break;
-case SFX_ALIGN_BOTTOM:  aRect.Top()++;  break;
-case SFX_ALIGN_LEFT:aRect.Right()--;break;
-case SFX_ALIGN_RIGHT:   aRect.Left()++; break;
-default:
-break;
-}
-}
-
 DecorationView aView(this);
 aRect.Left() += 8; aRect.Top()   += 8;
 aRect.Right()-= 8; aRect.Bottom()-= 8;
@@ -750,38 +736,6 @@ void SmCmdBoxWindow::Paint(const Rectangle& /*rRect*/)
 {
 Rectangle aRect = Rectangle(Point(0, 0), GetOutputSizePixel());
 DecorationView aView(this);
-
-if (! IsFloatingMode())
-{
-Point aFrom, aTo;
-switch (G

MPL/LGPLv3+ blanket license

[Norah A. Abanumay]

Hello,

All of my past & future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.

Regards,
Norah Abanumay
Motah Program, KACST
http://www.motah.org.sa
Warning: This message and its attachment, if any, are confidential and may 
contain information protected by law. If you are not the intended recipient, 
please contact the sender immediately and delete the message and its 
attachment, if any. You should not copy the message and its attachment, if any, 
or disclose its contents to any other person or use it for any purpose. 
Statements and opinions expressed in this e-mail and its attachment, if any, 
are those of the sender, and do not necessarily reflect those of King Abdulaziz 
city for Science and Technology (KACST) in the Kingdom of Saudi Arabia. KACST 
accepts no liability for any damage caused by this email.

?: ??? ??? ??? ? ?? ?? (?? )  ?  ?? ? ??? 
??? ? ? ???. ??? ?? ??? ? ??  ???   
? ???  ?? ?  ??? ? (?? )? ???  ?? 
??? ?? ? ??? ??? ??  (?? ) ?? ?? ??? ? ?? ? 
?? ? ?? ? ??? ???. ? ???  ??? ??? ? (?? 
)  ?? ??? ???   ??? ? ? ? ?? 
  ??? ? ??? ? ??? ?? ??? ?? ??? 
??? ?? ?? ?? ?? ??? ??.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/source

[Julien Nabet]

 vcl/source/control/button.cxx |8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit a4e937d5b04b10c2d6ebecce6e77c57a02a95d17
Author: Julien Nabet 
Date:   Sun Aug 5 17:45:17 2012 +0200

Declare all the members in ImplCommonButtonData ctor

Change-Id: Ie3bb75617eef66ea5af77c8013d42a49dd69d2d0

diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx
index 37752bb..13e3abd 100644
--- a/vcl/source/control/button.cxx
+++ b/vcl/source/control/button.cxx
@@ -86,13 +86,9 @@ public:
 };
 
 // ---
-ImplCommonButtonData::ImplCommonButtonData()
+ImplCommonButtonData::ImplCommonButtonData() : maFocusRect(), mnSeparatorX(0), 
mnButtonState(0),
+mbSmallSymbol(sal_False), maImage(), meImageAlign(IMAGEALIGN_TOP), 
meSymbolAlign(SYMBOLALIGN_LEFT)
 {
-mnButtonState   = 0;
-mbSmallSymbol = sal_False;
-
-meImageAlign = IMAGEALIGN_TOP;
-meSymbolAlign = SYMBOLALIGN_LEFT;
 }
 
 // ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: feature/gbuild_ure needs testing

[Matúš Kukan]

Hi David,

On 2 August 2012 12:00, David Tardon  wrote:
> Hi all,
>
> now that 3.6.0 is sucessfully out, I have started pushing gbuild
> conversion forward again. The latest result of my effort is on branch
> feature/gbuild_ure

Nice, looks really good :-)

> 1/ Module bridges has been converted to gbuild. This module is _crucial_
>for UNO. Have I already said that you want to test the branch? The
>absolute minimum to check that C++ bridge still works is to run
>
>make testtools.all

I need for both linux and windows to add proper version of
+-env:URE_INTERNAL_LIB_DIR=file://$(OUTDIR)/lib \
into CustomTarget_uno_test.mk
No idea why and how it works in master, so I did not commit it.

Thanks,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[m...@marcpare.com: [libreoffice-marketing] Re: Ubuntu Developer Summit]

[Bjoern Michaelsen]

Hi there,

Marc wrote:
> Le 2012-07-30 14:52, leif a écrit :
> > Hi,
> > Does anyone plan to speak at the Ubuntu Developer Summit in Copenhagen
> > later this year?
> > http://uds.ubuntu.com/
> > 
> > I'm not a developer so I think someone with blood type C++ should hold
> > the flag ;-)
> > 
> > Otherwise I plan to participate in the summit - just to stay up to date.
> I have added this to the LibreOffice events calendar. Could I add you
>
> as the LibreOffice contact person for this event seeing as you are
> attending? Do you think there are any events during the summit where
> LibreOffice could make its presence known?

So while UDS is not at all a C++ hacker only conference, of course I might be
interested in meeting lots of LibreOffice hackers there. As it is rumoured that
not too few live in that little town called Hamburg which isnt too far from
Copenhagen, feel free to join (or even register your own session as per
http://www.jonobacon.org/2009/11/04/start-your-uds-blueprint-registering-engines/)

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED] Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

[John Smith]

On Sun, Aug 5, 2012 at 1:55 PM, julien2412  wrote:
> Hi,
>
> The John Smith's clang report reminded me this thread.
> I pushed this easy fix on master (see
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=4de603d28ce884fb2a3720b6d132465b6dcc98a9).
> I don't know if this part of code is or will be used but it can't do any
> harm.
>
> Julien
>
That's great! It's nice to see people really taking the time and
effort to look into that clang report.


- John
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/gbuild_ure' - solenv/gbuild

[Matus Kukan]

 solenv/gbuild/UnoApiTarget.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit be91742ceaa09e18b788a79c46d45f754851c96c
Author: Matúš Kukan 
Date:   Sun Aug 5 15:17:52 2012 +0200

gbuild: add missing dependency on regmerge

visible with 'make udkapi.all'

Change-Id: I7fcd72e4d6849e3457551d85d507a15f6f72077b

diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk
index 64c49b6..49219a5 100644
--- a/solenv/gbuild/UnoApiTarget.mk
+++ b/solenv/gbuild/UnoApiTarget.mk
@@ -222,6 +222,7 @@ endef
 define gb_UnoApiTarget_add_idlfiles
 $(foreach idl,$(3),$(call gb_UnoApiTarget_add_idlfile,$(1),$(2),$(idl)))
 $(call gb_UnoApiTarget__add_idlfiles,$(1),$(2),$(3))
+$(call gb_UnoApiTarget_get_target,$(1)) : $(gb_UnoApiTarget_REGMERGETARGET)
 
 endef
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Bug 38840] add coverage analysis to unit tests

[John Smith]

On Sun, Aug 5, 2012 at 3:02 PM, Matúš Kukan  wrote:
> On 5 August 2012 13:11, John Smith  wrote:
>> LDFLAGS+='-lgcov' CFLAGS+='-fprofile-arcs -ftest-coverage'
>> CXXFLAGS+='-fprofile-arcs -ftest-coverage' CPPFLAGS+='-fprofile-arcs
>> -ftest-coverage' make
>
> If you would google for undefined reference to `__gcov_merge_add'
> You could get to
> http://stackoverflow.com/questions/566472/where-is-the-gcov-symbols
> And try LDFLAGS+='-fprofile-arcs' instead of -lgcov which seems to help
>
> Best,
> Matus

Thanks. That makes your suggestion below work :

make sal.all
cd sal
make clean
LDFLAGS+='--fprofile-arcs' CFLAGS+='-fprofile-arcs -ftest-coverage' \
CXXFLAGS+='-fprofile-arcs -ftest-coverage' \
CPPFLAGS+='-fprofile-arcs -ftest-coverage' make


I'll try LDFLAGS+='-fprofile-arcs' on the entire project now.


- John.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 38840] add coverage analysis to unit tests

[Matúš Kukan]

On 5 August 2012 13:11, John Smith  wrote:
> LDFLAGS+='-lgcov' CFLAGS+='-fprofile-arcs -ftest-coverage'
> CXXFLAGS+='-fprofile-arcs -ftest-coverage' CPPFLAGS+='-fprofile-arcs
> -ftest-coverage' make

If you would google for undefined reference to `__gcov_merge_add'
You could get to
http://stackoverflow.com/questions/566472/where-is-the-gcov-symbols
And try LDFLAGS+='-fprofile-arcs' instead of -lgcov which seems to help

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - sc/source vcl/inc vcl/source

[Markus Mohrhard]

 sc/source/ui/condformat/condformatdlg.cxx |   22 +-
 sc/source/ui/inc/condformatdlg.hxx|1 +
 vcl/inc/vcl/edit.hxx  |1 +
 vcl/source/control/edit.cxx   |   17 ++---
 4 files changed, 37 insertions(+), 4 deletions(-)

New commits:
commit 76ccb5fe45aef020f51a6c0d5ed14c95390a471f
Author: Markus Mohrhard 
Date:   Sun Aug 5 14:48:51 2012 +0200

highlight invalid formulas in cond format dlg, fdo#43653, bnc#730048

Change-Id: I4893eb176aca976c037f8196dd3043e98fbf91dc

diff --git a/sc/source/ui/condformat/condformatdlg.cxx 
b/sc/source/ui/condformat/condformatdlg.cxx
index 641b02e..cd850ac 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -320,8 +320,11 @@ void ScCondFrmtEntry::Init()
 maLbEntryTypeMin.SetSelectHdl( LINK( this, ScCondFrmtEntry, EntryTypeHdl ) 
);
 maLbEntryTypeMax.SetSelectHdl( LINK( this, ScCondFrmtEntry, EntryTypeHdl ) 
);
 maLbEntryTypeMiddle.SetSelectHdl( LINK( this, ScCondFrmtEntry, 
EntryTypeHdl ) );
+maEdVal1.SetStyle( maEdVal1.GetStyle() | WB_FORCECTRLBACKGROUND );
+maEdVal2.SetStyle( maEdVal2.GetStyle() | WB_FORCECTRLBACKGROUND );
 
-
+maEdVal1.SetModifyHdl( LINK( this, ScCondFrmtEntry, EdModifyHdl ) );
+maEdVal2.SetModifyHdl( LINK( this, ScCondFrmtEntry, EdModifyHdl ) );
 
 SfxStyleSheetIterator aStyleIter( mpDoc->GetStyleSheetPool(), 
SFX_STYLE_FAMILY_PARA );
 for ( SfxStyleSheetBase* pStyle = aStyleIter.First(); pStyle; pStyle = 
aStyleIter.Next() )
@@ -813,6 +816,23 @@ IMPL_LINK_NOARG(ScCondFrmtEntry, TypeListHdl)
 return 0;
 }
 
+IMPL_LINK(ScCondFrmtEntry, EdModifyHdl, Edit*, pEdit)
+{
+rtl::OUString aFormula = pEdit->GetText();
+ScCompiler aComp( mpDoc, maPos );
+aComp.SetGrammar( mpDoc->GetGrammar() );
+boost::scoped_ptr mpCode(aComp.CompileString(aFormula));
+if(mpCode->GetCodeError())
+{
+
pEdit->SetControlBackground(GetSettings().GetStyleSettings().GetHighlightColor());
+}
+else
+{
+
pEdit->SetControlBackground(GetSettings().GetStyleSettings().GetWindowColor());
+}
+return 0;
+}
+
 IMPL_LINK_NOARG(ScCondFrmtEntry, ColFormatTypeHdl)
 {
 if(maLbColorFormat.GetSelectEntryPos() < 2)
diff --git a/sc/source/ui/inc/condformatdlg.hxx 
b/sc/source/ui/inc/condformatdlg.hxx
index 3100d9b..98e5926 100644
--- a/sc/source/ui/inc/condformatdlg.hxx
+++ b/sc/source/ui/inc/condformatdlg.hxx
@@ -125,6 +125,7 @@ private:
 DECL_LINK( DataBarTypeSelectHdl, void* );
 DECL_LINK( ConditionTypeSelectHdl, void* );
 DECL_LINK( EntryTypeHdl, ListBox* );
+DECL_LINK( EdModifyHdl, Edit* );
 
 public:
 ScCondFrmtEntry( Window* pParent, ScDocument* pDoc, const ScAddress& rPos 
);
commit 7b322f9aa315740625f265ce78dd06effd61531a
Author: Markus Mohrhard 
Date:   Sun Aug 5 14:24:02 2012 +0200

paint Edit's native borders after background color

Change-Id: I3b5865d862ac7b9958d22d2ff1d3dc693cea2536

diff --git a/vcl/inc/vcl/edit.hxx b/vcl/inc/vcl/edit.hxx
index 16c0e2f..58f88be 100644
--- a/vcl/inc/vcl/edit.hxx
+++ b/vcl/inc/vcl/edit.hxx
@@ -105,6 +105,7 @@ private:
 SAL_DLLPRIVATE voidImplInsertText( const rtl::OUString& rStr, 
const Selection* pNewSelection = 0, sal_Bool bIsUserInput = sal_False );
 SAL_DLLPRIVATE String  ImplGetValidString( const String& rString ) 
const;
 SAL_DLLPRIVATE voidImplClearBackground( long nXStart, long nXEnd );
+SAL_DLLPRIVATE voidImplPaintBorder( long nXStart, long nXEnd );
 SAL_DLLPRIVATE voidImplShowCursor( sal_Bool bOnlyIfVisible = 
sal_True );
 SAL_DLLPRIVATE voidImplAlign();
 SAL_DLLPRIVATE voidImplAlignAndPaint();
diff --git a/vcl/source/control/edit.cxx b/vcl/source/control/edit.cxx
index 8c47e2c..2d5e53e 100644
--- a/vcl/source/control/edit.cxx
+++ b/vcl/source/control/edit.cxx
@@ -556,7 +556,7 @@ void Edit::ImplRepaint( xub_StrLen nStart, xub_StrLen nEnd, 
bool bLayout )
 Push( PUSH_FILLCOLOR | PUSH_LINECOLOR );
 SetLineColor();
 SetFillColor( GetControlBackground() );
-DrawRect( Rectangle( aPos, Size( GetOutputSizePixel().Width() - 
2*mnXOffset, nTH ) ) );
+DrawRect( Rectangle( aPos, Size( GetOutputSizePixel().Width() - 
2*mnXOffset, GetOutputSizePixel().Height() ) ) );
 Pop();
 
 SetTextFillColor( GetControlBackground() );
@@ -566,6 +566,8 @@ void Edit::ImplRepaint( xub_StrLen nStart, xub_StrLen nEnd, 
bool bLayout )
 else
 SetTextFillColor( IsControlBackground() ? GetControlBackground() : 
rStyleSettings.GetFieldColor() );
 
+ImplPaintBorder( 0, GetOutputSizePixel().Width() );
+
 sal_Bool bDrawSelection = maSelection.Len() && ( HasFocus() || ( 
GetStyle() & WB_NOHIDESELECTION ) || mbActivePopup );
 
 long nPos = nStart ? pDX[2*nStart] : 0;
@@ -1095,6 +1097,17 @@ void Edit::ImplClearBackground( long nXStart, long nXEnd 
)
 aRect.Left()

[REVIEW-3-6] fix for fdo#52351, remove conditional formatting if all its cells are removed

[Markus Mohrhard]

Hey,

[1] is mostly a fix for a strange behavior of ScRangeList which
affects also conditional formats. ScRangeList did not delete a ScRange
if UpdateReference removed all the ScRange cells. The second step of
the patch is to remove the conditional formatting if the ScRangeList
is empty after updating the range.

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f56b5e8d4abf17682aa75b7cf183b883809234
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

[julien2412]

Hi,

The John Smith's clang report reminded me this thread.
I pushed this easy fix on master (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4de603d28ce884fb2a3720b6d132465b6dcc98a9).
I don't know if this part of code is or will be used but it can't do any
harm.

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-Null-pointer-passed-as-an-argument-to-a-nonnull-parameter-in-vcl-unx-generic-app-i18n-wrp-cxx-tp3752158p3999352.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/unx

[Julien Nabet]

 vcl/unx/generic/app/i18n_wrp.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4de603d28ce884fb2a3720b6d132465b6dcc98a9
Author: Julien Nabet 
Date:   Sun Aug 5 13:49:37 2012 +0200

Clang:Null pointer passed as an argument to a 'nonnull' parameter

Change-Id: Ia07c50f4822af256b3b35f39f46dc442750c8439

diff --git a/vcl/unx/generic/app/i18n_wrp.cxx b/vcl/unx/generic/app/i18n_wrp.cxx
index 05dfd10..e152135 100644
--- a/vcl/unx/generic/app/i18n_wrp.cxx
+++ b/vcl/unx/generic/app/i18n_wrp.cxx
@@ -235,7 +235,7 @@ Status XvaCloseIM(XIM)
 {
   Status s = False;
 
-if (!g_dlmodule)
+if (g_dlmodule)
 {
 /* assuming one XvaOpenIM call */
 dlclose(g_dlmodule);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Convert documents to follow the doxygen standard

[Gerrit]

>From Norah A. Abanumay  :

Norah A. Abanumay  has uploaded a new change for review.

Change subject: Convert documents to follow the doxygen standard
..

Convert documents to follow the doxygen standard

Change-Id: I58c73f74d53b5dc2eb462fb03664be65d4500170
---
M regexp/inc/regexp/reclass.hxx
M sd/inc/anminfo.hxx
M sd/inc/sdpage.hxx
M sd/inc/sdpptwrp.hxx
M sd/inc/sdxmlwrp.hxx
M sd/source/filter/eppt/eppt.hxx
M sd/source/filter/eppt/escherex.hxx
M sd/source/filter/eppt/pptexsoundcollection.hxx
M sd/source/filter/html/htmlex.hxx
M sd/source/ui/animations/motionpathtag.hxx
M sd/source/ui/annotations/annotationtag.hxx
M sd/source/ui/presenter/CanvasUpdateRequester.hxx
12 files changed, 108 insertions(+), 110 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/370/1
--
To view, visit https://gerrit.libreoffice.org/370
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I58c73f74d53b5dc2eb462fb03664be65d4500170
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norah A. Abanumay  

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 38840] add coverage analysis to unit tests

[John Smith]

On Sun, Aug 5, 2012 at 12:16 PM,   wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=38840
>
> --- Comment #5 from bfoman  2012-08-05 10:16:44 
> UTC ---
> Seems there is a trace of gcov work in the source already:
> http://cgit.freedesktop.org/libreoffice/core/tree/sal/qa/helper/gcov
>
> --

The 'issue' does not really seem to be getting the data at this point.
If I read the man pages of gcov/lcov correctly, it could be as easy as
something like this :



./configure --enable-debug --with-system-libcmis=no
--with-system-saxon=no --with-system-libs

LDFLAGS+='-lgcov' CFLAGS+='-fprofile-arcs -ftest-coverage'
CXXFLAGS+='-fprofile-arcs -ftest-coverage' CPPFLAGS+='-fprofile-arcs
-ftest-coverage' make

lcov --base-directory /usr/local/src/libreoffice --capture --initial
--directory /usr/local/src/libreoffice --output-file
libreoffice_base.info

make check

lcov --base-directory /usr/local/src/libreoffice --capture --directory
/usr/local/src/libreoffice --output-file libreoffice_test.info

lcov --add-tracefile libreoffice_base.info --add-tracefile
libreoffice_test.info --output-file libreoffice_total.info

genhtml --demangle-cpp libreoffice_total.info --frames --show-details
--legend --output-directory=/tmp/libreoffice-lcov



But the 'problem' im currently running into, is that LibreOffice wont
build when I specify LDFLAGS/CFLAGS/CXXFLAGS as mentioned above.



Regards,


John Smith.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Change in core[master]: Translate German comments in sw/source/core/docnode/ndcopy.c...

[Philipp Riemer]

Hey Bertrand,

2012/8/4 Bertrand Lorentz :
> Hi,
>
> On Sat, Aug 4, 2012 at 4:07 PM, Philipp Riemer  wrote:
>> Good work! However, I couldn't find your name on
>>  and also
>> no license statement of you (but the search page for the mailing
>> archives is quite buggy)... Did you already send such a mail to the
>> LibreOffice mailing list? If you did, could you please send me a link
>> to the respective nabble/archive/... url? I will then add you to the
>> wiki page and also integrate the patch as soon as possible.
>
> I've just sent my license statement to the list (my subscription
> request took some time to go through):
> http://lists.freedesktop.org/archives/libreoffice/2012-August/036264.html
>
> Cheers,

Cool! I added your name to the respective wiki page and pushed the change ;-)

ATB,
Philipp
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/source

[Philipp Riemer]

 sw/source/core/docnode/ndcopy.cxx |  190 ++
 1 file changed, 91 insertions(+), 99 deletions(-)

New commits:
commit bf68634a4ee34fb465cf35e019812b3ed48787a4
Author: Bertrand Lorentz 
Date:   Fri Aug 3 19:23:57 2012 +0200

fdo#39468: Translate German comments in sw/source/core/docnode/ndcopy.cxx

Change-Id: I6de2586d54d3e0938e2e9701885a043c76f686ae
Reviewed-by: Philipp Riemer 

diff --git a/sw/source/core/docnode/ndcopy.cxx 
b/sw/source/core/docnode/ndcopy.cxx
index fb49030..c15e6fc 100644
--- a/sw/source/core/docnode/ndcopy.cxx
+++ b/sw/source/core/docnode/ndcopy.cxx
@@ -224,9 +224,8 @@ namespace
 }
 }
 
-// Struktur fuer das Mappen von alten und neuen Frame-Formaten an den
-// Boxen und Lines einer Tabelle
-
+// Structure for the mapping from old and new frame formats to the
+// boxes and lines of a table
 struct _MapTblFrmFmt
 {
 const SwFrmFmt *pOld, *pNew;
@@ -246,7 +245,7 @@ SwCntntNode* SwTxtNode::MakeCopy( SwDoc* pDoc, const 
SwNodeIndex& rIdx ) const
 SwTxtNode* pCpyTxtNd = (SwTxtNode*)this;
 SwTxtNode* pCpyAttrNd = pCpyTxtNd;
 
-// kopiere die Formate in das andere Dokument:
+// Copy the formats to the other document
 SwTxtFmtColl* pColl = 0;
 if( pDoc->IsInsOnlyTextGlossary() )
 {
@@ -265,9 +264,9 @@ SwCntntNode* SwTxtNode::MakeCopy( SwDoc* pDoc, const 
SwNodeIndex& rIdx ) const
 // METADATA: register copy
 pTxtNd->RegisterAsCopyOf(*pCpyTxtNd);
 
-// kopiere Attribute/Text
+// Copy Attribute/Text
 if( !pCpyAttrNd->HasSwAttrSet() )
-// wurde ein AttrSet fuer die Numerierung angelegt, so loesche diesen!
+// An AttrSet was added for numbering, so delete it
 pTxtNd->ResetAllAttr();
 
 // if Copy-Textnode unequal to Copy-Attrnode, then copy first
@@ -284,29 +283,25 @@ SwCntntNode* SwTxtNode::MakeCopy( SwDoc* pDoc, const 
SwNodeIndex& rIdx ) const
 }
 }
 
-// ??? reicht das ??? was ist mit PostIts/Feldern/FeldTypen ???
+// Is that enough? What about PostIts/Fields/FieldTypes?
 // #i96213# - force copy of all attributes
 pCpyTxtNd->CopyText( pTxtNd, SwIndex( pCpyTxtNd ),
 pCpyTxtNd->GetTxt().Len(), true );
 
-//FEATURE::CONDCOLL
 if( RES_CONDTXTFMTCOLL == pColl->Which() )
 pTxtNd->ChkCondColl();
-//FEATURE::CONDCOLL
 
 return pTxtNd;
 }
 
-
 static bool lcl_SrchNew( const _MapTblFrmFmt& rMap, const SwFrmFmt** pPara )
 {
 if( rMap.pOld != *pPara )
 return true;
 *pPara = rMap.pNew;
-return false;   // abbrechen, Pointer gefunden
+return false;
 }
 
-
 struct _CopyTable
 {
 SwDoc* pDoc;
@@ -332,7 +327,7 @@ static void lcl_CopyTblBox( SwTableBox* pBox, _CopyTable* 
pCT )
 for( _MapTblFrmFmts::const_iterator it = pCT->rMapArr.begin(); it != 
pCT->rMapArr.end(); ++it )
 if ( !lcl_SrchNew( *it, (const SwFrmFmt**)&pBoxFmt ) )
 break;
-if( pBoxFmt == pBox->GetFrmFmt() ) // ein neues anlegen ??
+if( pBoxFmt == pBox->GetFrmFmt() ) // Create a new one?
 {
 const SfxPoolItem* pItem;
 if( SFX_ITEM_SET == pBoxFmt->GetItemState( RES_BOXATR_FORMULA, 
sal_False,
@@ -369,7 +364,7 @@ static void lcl_CopyTblBox( SwTableBox* pBox, _CopyTable* 
pCT )
 {
 SwNodeIndex aNewIdx( *pCT->pTblNd,
 pBox->GetSttIdx() - pCT->nOldTblSttIdx );
-OSL_ENSURE( aNewIdx.GetNode().IsStartNode(), "Index nicht auf einem 
StartNode" );
+OSL_ENSURE( aNewIdx.GetNode().IsStartNode(), "Index is not on the 
start node" );
 pNewBox = new SwTableBox( pBoxFmt, aNewIdx, pCT->pInsLine );
 pNewBox->setRowSpan( pBox->getRowSpan() );
 }
@@ -384,7 +379,7 @@ static void lcl_CopyTblBox( SwTableBox* pBox, _CopyTable* 
pCT )
 lcl_CopyTblLine( pLine, &aPara );
 }
 else if( pNewBox->IsInHeadline( &pCT->pTblNd->GetTable() ))
-// in der HeadLine sind die Absaetze mit BedingtenVorlage anzupassen
+// In the headline, the paragraphs must match conditional styles
 pNewBox->GetSttNd()->CheckSectionCondColl();
 }
 
@@ -394,7 +389,7 @@ static void lcl_CopyTblLine( const SwTableLine* pLine, 
_CopyTable* pCT )
 for( _MapTblFrmFmts::const_iterator it = pCT->rMapArr.begin(); it != 
pCT->rMapArr.end(); ++it )
 if ( !lcl_SrchNew( *it, (const SwFrmFmt**)&pLineFmt ) )
 break;
-if( pLineFmt == pLine->GetFrmFmt() )   // ein neues anlegen ??
+if( pLineFmt == pLine->GetFrmFmt() ) // Create a new one?
 {
 pLineFmt = pCT->pDoc->MakeTableLineFmt();
 pLineFmt->CopyAttrs( *pLine->GetFrmFmt() );
@@ -402,7 +397,7 @@ static void lcl_CopyTblLine( const SwTableLine* pLine, 
_CopyTable* pCT )
 }
 SwTableLine* pNewLine = new SwTableLine( pLineFmt,
 pLine->GetTabBoxes().size(), pCT->pInsBox );
-// die neue Zeile in die Tabelle eintragen
+// Insert the new row into the table
 if( pCT->pInsBox )
 {
 pCT

[PUSHED-3-6] Re: [REVIEW-3-6] fix for fdo#53010, use correct length for string

[Lubos Lunak]

On Sunday 05 of August 2012, Markus Mohrhard wrote:
> Hey,
>
> [1] fixes the problem with the "is between" conditional format. The
> problem was that I missed one character when I calculated the string
> length which prevented the import of the values/formulas.

 Pushed. Note that, as I already said in a reply to the master commit before 
noticing this mail, it's much better to simply write strlen( "foo" ). It'll 
get optimized away and not only that's more likely to get the number right, 
but here it's also completely non-obvious that the number has to be length + 
1.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Lubos Lunak]

 sc/source/filter/xml/xmlcondformat.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 38d7b11915c9c4e5fcebcb7eb3ae1b2846b26267
Author: Markus Mohrhard 
Date:   Sun Aug 5 11:47:19 2012 +0200

use correct string length for "between", fdo#53010

Change-Id: I282c6a4436984d268b107ffef01022831c05a0fa
Signed-off-by: Luboš Luňák 

diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index ed9bc49..a8a47f1 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -313,7 +313,7 @@ void GetConditionData(const rtl::OUString& rValue, 
ScConditionMode& eMode, rtl::
 else if(rValue.indexOf("between") == 0)
 {
 const sal_Unicode* pStr = rValue.getStr();
-const sal_Unicode* pStart = pStr + 7;
+const sal_Unicode* pStart = pStr + 8;
 const sal_Unicode* pEnd = pStr + rValue.getLength();
 rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ',');
 rExpr2 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-commits] .: sc/source

[Lubos Lunak]

On Sunday 05 of August 2012, Markus Mohrhard wrote:
>  sc/source/filter/xml/xmlcondformat.cxx |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> New commits:
> commit 507305afa0d826b7e3cb3cc9a4b389f0ba854638
> Author: Markus Mohrhard 
> Date:   Sun Aug 5 11:47:19 2012 +0200
>
> use correct string length for "between", fdo#53010
>
> Change-Id: I282c6a4436984d268b107ffef01022831c05a0fa
>
> diff --git a/sc/source/filter/xml/xmlcondformat.cxx
> b/sc/source/filter/xml/xmlcondformat.cxx index 7878b82..636e76a 100644
> --- a/sc/source/filter/xml/xmlcondformat.cxx
> +++ b/sc/source/filter/xml/xmlcondformat.cxx
> @@ -313,7 +313,7 @@ void GetConditionData(const rtl::OUString& rValue,
> ScConditionMode& eMode, rtl:: else if(rValue.indexOf("between") == 0)
>  {
>  const sal_Unicode* pStr = rValue.getStr();
> -const sal_Unicode* pStart = pStr + 7;
> +const sal_Unicode* pStart = pStr + 8;
>  const sal_Unicode* pEnd = pStr + rValue.getLength();
>  rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ',');
>  rExpr2 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')');

 It's usually better to just write strlen( "foo" ) rather than hardcode 
numbers, compilers can optimize away calls to strlen with string literals 
anyway.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Modifiying some comments to follow the Doxygen standards

[Gerrit]

>From Faisal al-otaibi :

Faisal al-otaibi has uploaded a new change for review.

Change subject: Modifiying some comments to follow the Doxygen standards
..

Modifiying some comments to follow the Doxygen standards

Change-Id: I5f65593544439f0b4ffd7e9733834e46889e7c3e
---
M cui/source/inc/connect.hxx
M cui/source/inc/cuicharmap.hxx
M cui/source/inc/cuifmsearch.hxx
M cui/source/inc/cuihyperdlg.hxx
M cui/source/inc/cuisrchdlg.hxx
M cui/source/inc/cuitabarea.hxx
M cui/source/inc/cuitabline.hxx
M cui/source/inc/dlgname.hxx
M cui/source/inc/hangulhanjadlg.hxx
M cui/source/inc/headertablistbox.hxx
M cui/source/inc/hldoctp.hxx
M cui/source/inc/hlinettp.hxx
M cui/source/inc/hlmailtp.hxx
M cui/source/inc/hltpbase.hxx
M cui/source/inc/iconcdlg.hxx
M cui/source/inc/insdlg.hxx
M cui/source/inc/labdlg.hxx
M cui/source/inc/measure.hxx
M cui/source/inc/numfmt.hxx
M cui/source/inc/numpages.hxx
20 files changed, 96 insertions(+), 93 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/69/369/1
--
To view, visit https://gerrit.libreoffice.org/369
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f65593544439f0b4ffd7e9733834e46889e7c3e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Faisal al-otaibi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

Roman Eisele  changed:

   What|Removed |Added

 Depends on||52639

--- Comment #67 from Roman Eisele  2012-08-05 10:13:26 UTC ---
Added Bug 52639 - "ReportBuilder: Creating a new report destroys .odb"
(reproducible according to comment no. 10 there; urgent regresssion).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW-3-6] fix for fdo#53010, use correct length for string

[Markus Mohrhard]

Hey,

[1] fixes the problem with the "is between" conditional format. The
problem was that I missed one character when I calculated the string
length which prevented the import of the values/formulas.

Regards,
Markus

[1] 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=507305afa0d826b7e3cb3cc9a4b389f0ba854638
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

[Markus Mohrhard]

 sc/source/filter/xml/xmlcondformat.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 507305afa0d826b7e3cb3cc9a4b389f0ba854638
Author: Markus Mohrhard 
Date:   Sun Aug 5 11:47:19 2012 +0200

use correct string length for "between", fdo#53010

Change-Id: I282c6a4436984d268b107ffef01022831c05a0fa

diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index 7878b82..636e76a 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -313,7 +313,7 @@ void GetConditionData(const rtl::OUString& rValue, 
ScConditionMode& eMode, rtl::
 else if(rValue.indexOf("between") == 0)
 {
 const sal_Unicode* pStr = rValue.getStr();
-const sal_Unicode* pStart = pStr + 7;
+const sal_Unicode* pStart = pStr + 8;
 const sal_Unicode* pEnd = pStr + rValue.getLength();
 rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ',');
 rExpr2 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')');
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits