date:20120819

[Libreoffice-commits] .: filter/source

2012-08-19 Thread Libreoffice Gerrit user

 filter/source/graphicfilter/epict/epict.cxx |2 +-
 filter/source/msfilter/msdffimp.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ef1fabb29d8b38da11c75384cec8979bfbc2dca4
Author: David Tardon dtar...@redhat.com
Date:   Sun Aug 19 07:31:26 2012 +0200

fix mangled comments breaking build

Change-Id: I4684ba6c30a2499093ceefeb096d9cfc3de76de9

diff --git a/filter/source/graphicfilter/epict/epict.cxx 
b/filter/source/graphicfilter/epict/epict.cxx
index 3ca6863..3efdacc 100644
--- a/filter/source/graphicfilter/epict/epict.cxx
+++ b/filter/source/graphicfilter/epict/epict.cxx
@@ -920,7 +920,7 @@ void PictWriter::WriteOpcode_BitsRect(const Point  rPoint, 
const Size  rSize,
 // If 24-Bit, then create the Opcode 'DirectBitsRect':
 if ( nBitsPerPixel == 24 )
 {
-:Anzahl Bytes einer (ungepackten) Zeile in Quelle und Ziel berechnen:
+// Anzahl Bytes einer (ungepackten) Zeile in Quelle und Ziel berechnen:
 nSrcRowBytes =( ( 3 * nWidth ) + 0x0003 )  0xfffc;
 nDstRowBytes = nWidth * 4;
 
diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 4f7ebcb..501d04b 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6470,7 +6470,7 @@ sal_Bool SvxMSDffManager::GetBLIP( sal_uLong nIdx_, 
Graphic rData, Rectangle* p
 
 // passende Info-Struct aus unserem Pointer Array nehmen
 SvxMSDffBLIPInfo rInfo = (*pBLIPInfos)[ nIdx-1 ];
-in the data streamim Daten Stream anspringen
+// das BLIP Atom im Daten Stream anspringen
 pStData-Seek( rInfo.nFilePos );
 // ggfs. Fehlerstatus zuruecksetzen
 if( pStData-GetError() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Few notes about optimizing files (Windows OS)

2012-08-19 Thread ape

Hi all!

Few notes about optimizing files that are loaded into RAM at startup
LibreOffice.

1. Icons of executable files contain extra pictures the size of 128 by 128
pixels. Desktop environment of operating systems Windows XP-7 don’t need
these pictures. Best appearance requires that icons contain pictures size 20
at 20 pixels (for Windows XP: 120% or 120 dpi) and 24 on 24 pixel (for
Windows 7: 150% or 144 dpi). Changing these resources reduces the size of
executable files from 50 to 40 kilobytes.

2. The file “soffice.bin” is loaded into RAM, but serves an additional
function: it shows the file icons in Explorer. Propose to entrust this
function to an additional file loicons.dll which will not be loaded into
RAM when running LibreOffice. This solution makes it possible to compile
file soffice.bin only with the necessary icons and reduces the file size
from 680 to 96 kilobytes.

3. The Windows operating system does not assign icons of text documents,
spreadsheets, presentations or databases. This makes the program that opens
files. Icons for ODF files and Microsoft’s documents appear identically
because of this reason. File size soffice.bin will grow, if you eliminate
this problem. Consequently, program’s startup time will increase too. It's
not going to happen, if the program will have a separate library of icons
(loicons.dll) for Windows Explorer.

I don't know programming and use the resource editor for this purpose. Files
(LibO-3.7.0_alpha+) that allow you to check my notes are attached. I can
explain the purpose of each of the icons contained in the files, and publish
all PNG images here, if someone will fix the code.
--
ape

--
View this message in context:
http://nabble.documentfoundation.org/Few-notes-about-optimizing-files-Windows-OS-tp4002255.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: basic/source

2012-08-19 Thread Libreoffice Gerrit user

 basic/source/comp/dim.cxx   |   88 
 basic/source/comp/loops.cxx |4 -
 basic/source/comp/parser.cxx|8 +--
 basic/source/inc/namecont.hxx   |   16 +++
 basic/source/inc/parser.hxx |   16 +++
 basic/source/uno/dlgcont.cxx|8 +--
 basic/source/uno/namecont.cxx   |   40 +-
 basic/source/uno/scriptcont.cxx |8 +--
 8 files changed, 94 insertions(+), 94 deletions(-)

New commits:
commit 38f3fe04324f68af67478f2f582129513c6c567e
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Sun Aug 19 17:49:02 2012 +0900

sal_Bool to bool

Change-Id: I6206ee7e17e12388ea644123e180842df3e3a7ee

diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index 7fa0c00..ea27e63 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -29,7 +29,7 @@ SbxObject* cloneTypeObjectImpl( const SbxObject rTypeObj );
 // Return-value: a new instance, which were inserted and then deleted.
 // Array-Indexex were returned as SbiDimList
 
-SbiSymDef* SbiParser::VarDecl( SbiDimList** ppDim, sal_Bool bStatic, sal_Bool 
bConst )
+SbiSymDef* SbiParser::VarDecl( SbiDimList** ppDim, bool bStatic, bool bConst )
 {
 bool bWithEvents = false;
 if( Peek() == WITHEVENTS )
@@ -188,34 +188,34 @@ void SbiParser::TypeDecl( SbiSymDef rDef, sal_Bool 
bAsNewAlreadyParsed )
 
 void SbiParser::Dim()
 {
-DefVar( _DIM, ( pProc  bVBASupportOn ) ? pProc-IsStatic() : sal_False );
+DefVar( _DIM, ( pProc  bVBASupportOn ) ? pProc-IsStatic() : false );
 }
 
-void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
+void SbiParser::DefVar( SbiOpcode eOp, bool bStatic )
 {
 SbiSymPool* pOldPool = pPool;
-sal_Bool bSwitchPool = sal_False;
-sal_Bool bPersistantGlobal = sal_False;
+bool bSwitchPool = false;
+bool bPersistantGlobal = false;
 SbiToken eFirstTok = eCurTok;
 if( pProc  ( eCurTok == GLOBAL || eCurTok == PUBLIC || eCurTok == 
PRIVATE ) )
 Error( SbERR_NOT_IN_SUBR, eCurTok );
 if( eCurTok == PUBLIC || eCurTok == GLOBAL )
 {
-bSwitchPool = sal_True; // at the right moment switch to the 
global pool
+bSwitchPool = true; // at the right moment switch to the global 
pool
 if( eCurTok == GLOBAL )
-bPersistantGlobal = sal_True;
+bPersistantGlobal = true;
 }
 // behavior in VBA is that a module scope variable's lifetime is
 // tied to the document. e.g. a module scope variable is global
if(  GetBasic()-IsDocBasic()  bVBASupportOn  !pProc )
-bPersistantGlobal = sal_True;
+bPersistantGlobal = true;
 // PRIVATE is a synonymous for DIM
 // _CONST_?
-sal_Bool bConst = sal_False;
+bool bConst = false;
 if( eCurTok == _CONST_ )
-bConst = sal_True;
+bConst = true;
 else if( Peek() == _CONST_ )
-Next(), bConst = sal_True;
+Next(), bConst = true;
 
 // #110004 It can also be a sub/function
 if( !bConst  (eCurTok == SUB || eCurTok == FUNCTION || eCurTok == 
PROPERTY ||
@@ -236,7 +236,7 @@ void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
 if( bNewGblDefs  nGblChain == 0 )
 {
 nGblChain = aGen.Gen( _JUMP, 0 );
-bNewGblDefs = sal_False;
+bNewGblDefs = false;
 }
 Next();
 DefProc( sal_False, bPrivate );
@@ -293,7 +293,7 @@ void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
 aGen.Statement();   // catch up on static here
 }
 
-sal_Bool bDefined = sal_False;
+bool bDefined = false;
 while( ( pDef = VarDecl( pDim, bStatic, bConst ) ) != NULL )
 {
 EnableErrors();
@@ -302,12 +302,12 @@ void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
 pPool = aGlobals;
 SbiSymDef* pOld = pPool-Find( pDef-GetName() );
 // search also in the Runtime-Library
-sal_Bool bRtlSym = sal_False;
+bool bRtlSym = false;
 if( !pOld )
 {
 pOld = CheckRTLForSym( pDef-GetName(), SbxVARIANT );
 if( pOld )
-bRtlSym = sal_True;
+bRtlSym = true;
 }
 if( pOld  !(eOp == _REDIM || eOp == _REDIMP) )
 {
@@ -316,7 +316,7 @@ void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
 }
 if( pOld )
 {
-bDefined = sal_True;
+bDefined = true;
 // always an error at a RTL-S
 if( !bRtlSym  (eOp == _REDIM || eOp == _REDIMP) )
 {
@@ -362,7 +362,7 @@ void SbiParser::DefVar( SbiOpcode eOp, sal_Bool bStatic )
 }
 global: aGen.BackChain( nGblChain );
 nGblChain = 0;
-bGblDefs = bNewGblDefs = sal_True;
+bGblDefs = bNewGblDefs = true;

Re: Few notes about optimizing files (Windows OS)

2012-08-19 Thread Noel Grandin

Are you offering to implement these ideas?

We're not short on ideas, but we need more hands on deck, so if you're
keen, start by visiting the 'libreoffice native build' page and get
hacking.
Feel free to ask on this list if you get stuck.

On Sunday, 19 August 2012, ape wrote:

Hi all!

Few notes about optimizing files that are loaded into RAM at startup
LibreOffice.

1. Icons of executable files contain extra pictures the size of 128 by 128
pixels. Desktop environment of operating systems Windows XP-7 don’t need
these pictures. Best appearance requires that icons contain pictures size
20
at 20 pixels (for Windows XP: 120% or 120 dpi) and 24 on 24 pixel (for
Windows 7: 150% or 144 dpi). Changing these resources reduces the size of
executable files from 50 to 40 kilobytes.

I don't know programming and use the resource editor for this purpose.
Files
(LibO-3.7.0_alpha+) that allow you to check my notes are attached. I can
explain the purpose of each of the icons contained in the files, and
publish
all PNG images here, if someone will fix the code.
--
ape

--
View this message in context:
http://nabble.documentfoundation.org/Few-notes-about-optimizing-files-Windows-OS-tp4002255.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org javascript:;
http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Few notes about optimizing files (Windows OS)

2012-08-19 Thread ape

Hi, Noel!

I made a mistake and was not able to attach the ZIP file to the 1st post.
--
ape
http://nabble.documentfoundation.org/file/n4002279/LO37win.zip LO37win.zip 



--
View this message in context: 
http://nabble.documentfoundation.org/Few-notes-about-optimizing-files-Windows-OS-tp4002255p4002279.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [GSoC 2012][svg export filter] embedded svg pictures

2012-08-19 Thread Marco Cecchetti



Hi all,
I have an XShape instance that supports the GraphicObjectShape
service and embedding an svg image.
How can I get the image embedded into the XShape instance,
check its mime type, and in case is of type image/svg excract
the svg document ?

Cheers,
-- Marco


--
Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Fix TDE VCL interface

2012-08-19 Thread Timothy Pearson

This patch restores the TDE VCL and filepicker interfaces to full
functionality in LO 3.6.0:
http://git.trinitydesktop.org/cgit/tde/plain/main/thirdparty/libreoffice/3.6.0/patches/libreoffice-fix-tde-vcl.diff

This patch does not affect the KDE3 plugin and should be committed to LO
GIT.  The LO code currently in GIT both does not display widgets and also
hangs when used under TDE; this patch resolves these issues.

As always if you have any questions please feel free to ask!

Thank you,

Timothy Pearson
Trinity Desktop Project

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: pptx import filter

2012-08-19 Thread Jean-Tiare LE BIGOT


Hi all,

Thanks for the tip. I spend hours tracing the bug with GDB but I stuck. 
I can not figure out where to fix it.


Here is the situation: I have a pptx file with

- title (fine)
- 4 items in a list (buggy)

In Powerpoint, all the text in the list is 18p but a signe word is 8p.
In Impress, the begin of the text is 20p, the word at 8p is 8p an the 
remaining text is 8p also.


After bisecting the pptx file, it appears that there is an empty span 
at the very beginning of the first list item. It's size is set to 20p. 
The only other span with a size specified is the one at 8p. All other 
elements have no size information on them.


When an element has no size specified, it is imported with the same size 
as the immediate previous element whereas it should take the default 
size specified in the theme. In my case, the size is specified in the 
MasterSlide-OtherStyle-lvl1pPr.


in the import filter, there is a file 
oox/source/drawingml/textrun.cxx:63 This is the only line where the size 
appears to be used in a computation. Ideed, manually forcing the size to 
18 when at 0 fixes the problem for me.


But... It's really not the right place nor the right way to do it since 
it would orverride the theme...

I also know the themes in the master slide are imported properly.

I also traced the code down to pptshape.cxx where the text seems to be 
imported into the core. I obviously missed something...


My question is: where can I fix this 

Thanks a lot for your help (and patient reading)

Le 2012-08-17 15:31, Miklos Vajna a écrit :

On Fri, Aug 17, 2012 at 03:54:25PM +0200, Jean-Tiare LE BIGOT ad...@jtlebi.fr 
wrote:

Is there anyone already working on the pptx import filter ?
I'd like to work on the font size import.

Is there any code shared between the pptx/docx/... filters ?


Hi,

Look under the oox/ module, that's shared between docx/xlsx/pptx.

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice




--
Jean-Tiare
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: notice: module dictionaries converted to gbuild

2012-08-19 Thread Andrea Pescetti


On 07/08/2012 David Tardon wrote:

When testing the conversion--I wrote a script to compare the old and new
content of all the dictionaries--I have identified several files that
have not been packed into the extensions previously ...
dictionaries/it_IT/CHANGELOG.txt


I added this one to the Italian dictionary recently, so it should be 
added to the generated extensions package too.


Regards,
  Andrea.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: notice: module dictionaries converted to gbuild

2012-08-19 Thread Andrea Pescetti


On 07/08/2012 David Tardon wrote:

When testing the conversion--I wrote a script to compare the old and new
content of all the dictionaries--I have identified several files that
have not been packed into the extensions previously ...
dictionaries/it_IT/CHANGELOG.txt


I added this one to the Italian dictionary recently, so it should be 
added to the generated extension package too.


Regards,
  Andrea.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Closing NEEDINFO bugs

2012-08-19 Thread Florian Reisinger

Hi!

About one week ago, I did a mass change, here is pre-final statistic (by
bugzilla):

In fact, it was a good choice... (I hope you can read this table...)

*
*UNCONFIRMED1https://bugs.freedesktop.org/buglist.cgi?action=wrapbug_file_loc=bug_file_loc_type=allwordssubstrbug_id=bug_id_type=anyexactchfieldfrom=chfieldto=Nowchfieldvalue=cumulate=1email1=email2=email3=emailassigned_to1=1emailassigned_to2=1emailcc2=1emailqa_contact2=1emailreporter2=1emailtype1=substringemailtype2=substringemailtype3=substringfield0-0-0=noopheight=350keywords=keywords_type=allwordslongdesc=Due%20to%20the%20fact%2C%20that%20there%20are%20a%20lot%20of%20NEEDINFO%20bugslongdesc_type=allwordssubstrproduct=LibreOfficeresolution=---resolution=FIXEDresolution=INVALIDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGshort_desc=short_desc_type=allwordssubstrstatus_whiteboard=status_whiteboard_type=allwordssubstrtype0-0-0=noopvalue0-0-0=width=700x_labels_vertical=1=bug_status=UNCONFIRMED
NEW51https://bugs.freedesktop.org/buglist.cgi?action=wrapbug_file_loc=bug_file_loc_type=allwordssubstrbug_id=bug_id_type=anyexactchfieldfrom=chfieldto=Nowchfieldvalue=cumulate=1email1=email2=email3=emailassigned_to1=1emailassigned_to2=1emailcc2=1emailqa_contact2=1emailreporter2=1emailtype1=substringemailtype2=substringemailtype3=substringfield0-0-0=noopheight=350keywords=keywords_type=allwordslongdesc=Due%20to%20the%20fact%2C%20that%20there%20are%20a%20lot%20of%20NEEDINFO%20bugslongdesc_type=allwordssubstrproduct=LibreOfficeresolution=---resolution=FIXEDresolution=INVALIDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGshort_desc=short_desc_type=allwordssubstrstatus_whiteboard=status_whiteboard_type=allwordssubstrtype0-0-0=noopvalue0-0-0=width=700x_labels_vertical=1=bug_status=NEW
REOPENED37https://bugs.freedesktop.org/buglist.cgi?action=wrapbug_file_loc=bug_file_loc_type=allwordssubstrbug_id=bug_id_type=anyexactchfieldfrom=chfieldto=Nowchfieldvalue=cumulate=1email1=email2=email3=emailassigned_to1=1emailassigned_to2=1emailcc2=1emailqa_contact2=1emailreporter2=1emailtype1=substringemailtype2=substringemailtype3=substringfield0-0-0=noopheight=350keywords=keywords_type=allwordslongdesc=Due%20to%20the%20fact%2C%20that%20there%20are%20a%20lot%20of%20NEEDINFO%20bugslongdesc_type=allwordssubstrproduct=LibreOfficeresolution=---resolution=FIXEDresolution=INVALIDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGshort_desc=short_desc_type=allwordssubstrstatus_whiteboard=status_whiteboard_type=allwordssubstrtype0-0-0=noopvalue0-0-0=width=700x_labels_vertical=1=bug_status=REOPENED
RESOLVED800https://bugs.freedesktop.org/buglist.cgi?action=wrapbug_file_loc=bug_file_loc_type=allwordssubstrbug_id=bug_id_type=anyexactchfieldfrom=chfieldto=Nowchfieldvalue=cumulate=1email1=email2=email3=emailassigned_to1=1emailassigned_to2=1emailcc2=1emailqa_contact2=1emailreporter2=1emailtype1=substringemailtype2=substringemailtype3=substringfield0-0-0=noopheight=350keywords=keywords_type=allwordslongdesc=Due%20to%20the%20fact%2C%20that%20there%20are%20a%20lot%20of%20NEEDINFO%20bugslongdesc_type=allwordssubstrproduct=LibreOfficeresolution=---resolution=FIXEDresolution=INVALIDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGshort_desc=short_desc_type=allwordssubstrstatus_whiteboard=status_whiteboard_type=allwordssubstrtype0-0-0=noopvalue0-0-0=width=700x_labels_vertical=1=bug_status=RESOLVED
CLOSED1https://bugs.freedesktop.org/buglist.cgi?action=wrapbug_file_loc=bug_file_loc_type=allwordssubstrbug_id=bug_id_type=anyexactchfieldfrom=chfieldto=Nowchfieldvalue=cumulate=1email1=email2=email3=emailassigned_to1=1emailassigned_to2=1emailcc2=1emailqa_contact2=1emailreporter2=1emailtype1=substringemailtype2=substringemailtype3=substringfield0-0-0=noopheight=350keywords=keywords_type=allwordslongdesc=Due%20to%20the%20fact%2C%20that%20there%20are%20a%20lot%20of%20NEEDINFO%20bugslongdesc_type=allwordssubstrproduct=LibreOfficeresolution=---resolution=FIXEDresolution=INVALIDresolution=WONTFIXresolution=DUPLICATEresolution=WORKSFORMEresolution=MOVEDresolution=NOTABUGresolution=NOTOURBUGshort_desc=short_desc_type=allwordssubstrstatus_whiteboard=status_whiteboard_type=allwordssubstrtype0-0-0=noopvalue0-0-0=width=700x_labels_vertical=1=bug_status=CLOSED

[Libreoffice-commits] .: solenv/bin

2012-08-19 Thread Libreoffice Gerrit user

 solenv/bin/make_installer.pl|   46 ++--
 solenv/bin/modules/installer/globals.pm |3 --
 2 files changed, 15 insertions(+), 34 deletions(-)

New commits:
commit fa98546caa64ff830c5fa91bc603f2685e99c64f
Author: Tim Retout t...@retout.co.uk
Date:   Sun Aug 19 13:33:53 2012 +0100

installer: Some cleanup of packages loop and unused globals.

Change-Id: I219247cacc9924eed33d0aeb85097dbbe73697d0

diff --git a/solenv/bin/make_installer.pl b/solenv/bin/make_installer.pl
index 1603c5d..18f3838 100644
--- a/solenv/bin/make_installer.pl
+++ b/solenv/bin/make_installer.pl
@@ -1071,18 +1071,24 @@ for ( my $n = 0; $n = 
$#installer::globals::languageproducts; $n++ )
 
 if (  $installer::globals::issolarisbuild ) { 
installer::epmfile::read_packagemap($allvariableshashref, $includepatharrayref, 
$languagesarrayref); }
 
+###
+# Checking epm state
+###
+
 my $epmexecutable = ;
-my $found_epm = 0;
+if ( $installer::globals::call_epm )
+{
+$epmexecutable = 
installer::epmfile::find_epm_on_system($includepatharrayref);
+installer::epmfile::set_patch_state($epmexecutable);# setting 
$installer::globals::is_special_epm
+}
 
 # shuffle array to reduce parallel packaging process in pool
 installer::worker::shuffle_array($packages)
 unless $installer::globals::simple;
 
 # iterating over all packages
-for ( my $k = 0; $k = $#{$packages}; $k++ )
+for my $onepackage ( @{$packages} )
 {
-my $onepackage = ${$packages}[$k];
-
 # checking, if this is a language pack or a project pack.
 # Creating language packs only, if 
$installer::globals::languagepack is set. Parameter: -languagepack
 
@@ -1123,14 +1129,11 @@ for ( my $n = 0; $n = 
$#installer::globals::languageproducts; $n++ )
 # Debian allows no underline in package name
 if ( $installer::globals::debian ) { $packagename =~ s/_/-/g; }
 
-# Debian allows no underline in package name
-if ( $installer::globals::debian ) { $packagename =~ s/_/-/g; }
-
 
 # Header for this package into log file
 
 
-installer::logger::include_header_into_logfile(Creating package: 
$packagename ($k));
+installer::logger::include_header_into_logfile(Creating package: 
$packagename);
 
 ###
 # Root path, can be defined as parameter
@@ -1218,29 +1221,10 @@ for ( my $n = 0; $n = 
$#installer::globals::languageproducts; $n++ )
 strip_libraries($filesinpackage, $languagestringref);
 }
 
-###
-# Simple installation mechanism
-###
-
-if ( $installer::globals::simple ) { 
installer::worker::install_simple($onepackagename, $$languagestringref, 
$dirsinpackage, $filesinpackage, $linksinpackage, $unixlinksinpackage); }
-
-###
-# Checking epm state
-###
-
-if (( $installer::globals::call_epm )  ( ! $found_epm ))
-{
-$epmexecutable = 
installer::epmfile::find_epm_on_system($includepatharrayref);
-installer::epmfile::set_patch_state($epmexecutable);# 
setting $installer::globals::is_special_epm
-$found_epm = 1; # searching only once
+if ( $installer::globals::simple ) {
+installer::worker::install_simple($onepackagename, 
$$languagestringref, $dirsinpackage, $filesinpackage, $linksinpackage, 
$unixlinksinpackage);
 }
-
-###
-# Creating epm list file
-###
-
-if ( ! $installer::globals::simple )
-{
+else {
 # epm list file format:
 # type mode owner group destination source options
 # Example for a file: f 755 root sys /usr/bin/foo foo
@@ -1372,7 +1356,7 @@ for ( my $n = 0; $n = 
$#installer::globals::languageproducts; $n++ )
 
 } # end of if ( ! $installer::globals::simple )
 
-}   # end of for ( my $k = 0; $k = $#{$packages}; $k++ )
+}   # end of for ( @{$packages} )
 
 ##
 # Post epm functionality, after the last package is packed
diff --git a/solenv/bin/modules/installer/globals.pm 
b/solenv/bin/modules/installer/globals.pm
index

Re: [Libreoffice-qa] Closing NEEDINFO bugs

2012-08-19 Thread Bjoern Michaelsen

Hi Flo, all,

On Sun, Aug 19, 2012 at 07:53:35PM +0300, Florian Reisinger wrote:
 In fact, it was a good choice... (I hope you can read this table...)

While the statistic alone do not really prove this to be good move, but there
was a consensus on the qa call(*) and the qa list that this needs to be done to
allow the QA team to keep moving and not getting bogged down in thousends of
incomplete or controversal bug reports.

Now, of course, such a bulk move will always hit some false positives. If that
is the case for one of the bugs you reported (that is: the bug is
welldocumented, complete and noncontroversial) please check:

 http://wiki.documentfoundation.org/BugTriage

if the bug indeed contains all the information needed and thus send it back to
REOPENED.

Thanks!

Best,

Bjoern

(*) 
http://nabble.documentfoundation.org/minutes-of-the-LibreOffice-QA-Call-2012-06-29-1400UTC-td3992888.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Bug 38840 - Adding coverage analysis to unit tests

2012-08-19 Thread John Smith

Hi,


Im playing around with gcov/lcov coverage analysis for a bit, and one
of the things im running into/wondering about is what 'tests' should
be run ? I believe there are a few 'make targets' that sound like good
candidates, but which one to run ? Is 'make check' enough ?  Or should
I (also/instead) run 'make unitcheck' and 'make slowcheck' ? Or any
others ?


Regards,


John Smith.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-19 Thread Bjoern Michaelsen

Hi,

On Sun, Aug 19, 2012 at 08:51:16PM +0200, John Smith wrote:
 Im playing around with gcov/lcov coverage analysis for a bit, and one
 of the things im running into/wondering about is what 'tests' should
 be run ? I believe there are a few 'make targets' that sound like good
 candidates, but which one to run ? Is 'make check' enough ?  Or should
 I (also/instead) run 'make unitcheck' and 'make slowcheck' ? Or any
 others ?

We you run plain make in a module, it the default target already runs the
unitcheck target. If you run make from the top-level, it also runs slowcheck.

If you are doing really tricky work (like changing a very lowlevel class), I
would recommend to also run 'make subsequentcheck' -- or at least closely watch
the Linux-RHEL6-x86_64_14-with-check tinderbox that runs these tests too (as
you can see from all the [ build SCK ] in its log.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: solenv/bin

2012-08-19 Thread Libreoffice Gerrit user

 solenv/bin/modules/installer/epmfile.pm   |   16 ++---
 solenv/bin/modules/installer/systemactions.pm |   32 --
 2 files changed, 8 insertions(+), 40 deletions(-)

New commits:
commit c55a340a992199c5eb2d8b9cbe2fea539c6f83aa
Author: Tim Retout t...@retout.co.uk
Date:   Sun Aug 19 19:50:05 2012 +0100

installer: Replace remove_empty_directory with rmdir.

Change-Id: Ief3248e0b591a9216ac243fca38904366bab6391

diff --git a/solenv/bin/modules/installer/epmfile.pm 
b/solenv/bin/modules/installer/epmfile.pm
index 36fd78d..7d7da01 100644
--- a/solenv/bin/modules/installer/epmfile.pm
+++ b/solenv/bin/modules/installer/epmfile.pm
@@ -2602,14 +2602,14 @@ sub create_new_directory_structure
 
 if ( $machine ne  )
 {
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS/$machine);
-}
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS/powerpc);
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS/x86_64);
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS/i586);
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS/i386);
-
installer::systemactions::remove_empty_directory($installer::globals::epmoutpath/RPMS);
-
+rmdir $installer::globals::epmoutpath/RPMS/$machine;
+}
+rmdir $installer::globals::epmoutpath/RPMS/powerpc;
+rmdir $installer::globals::epmoutpath/RPMS/x86_64;
+rmdir $installer::globals::epmoutpath/RPMS/i586;
+rmdir $installer::globals::epmoutpath/RPMS/i386;
+rmdir $installer::globals::epmoutpath/RPMS
+or warn Could not remove RPMS dir: $!;
 }
 
 # Setting unix rights to 775 for $newdir (RPMS or packages)
diff --git a/solenv/bin/modules/installer/systemactions.pm 
b/solenv/bin/modules/installer/systemactions.pm
index 2607588..3c54ed1 100644
--- a/solenv/bin/modules/installer/systemactions.pm
+++ b/solenv/bin/modules/installer/systemactions.pm
@@ -154,38 +154,6 @@ sub create_directory_with_privileges
 }
 }
 
-##
-# Removing a new direcotory
-##
-
-sub remove_empty_directory
-{
-my ($directory) = @_;
-
-my $returnvalue = 1;
-
-if (-d $directory)
-{
-my $systemcall = rmdir $directory;
-
-$returnvalue = system($systemcall);
-
-my $infoline = Systemcall: $systemcall\n;
-push( @installer::globals::logfileinfo, $infoline);
-
-if ($returnvalue)
-{
-$infoline = ERROR: Could not remove \$directory\!\n;
-push( @installer::globals::logfileinfo, $infoline);
-}
-else
-{
-$infoline = Success: Removed \$directory\!\n;
-push( @installer::globals::logfileinfo, $infoline);
-}
-}
-}
-
 ###
 # Calculating the number of languages in the string
 ###
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Bug 38840 - Adding coverage analysis to unit tests

2012-08-19 Thread John Smith

On Sun, Aug 19, 2012 at 9:03 PM, Bjoern Michaelsen
bjoern.michael...@canonical.com wrote:
 Hi,

 We you run plain make in a module, it the default target already runs the
 unitcheck target. If you run make from the top-level, it also runs slowcheck.

Perhaps I got it all wrong, what gets run during the plain 'make' in
the toplevel is not really relevant here. The point is to figure out
how much code is actually 'tested' with the make check/etc target(s).

- First you run a plain make in the top level directory to build LO
(with analysis stuff enabled).
- then you create a 'baseline' with lcov (sort of create a 'before
snapshot' of LO)
- *then* you run all your tests (whatever they may be)
- then you re-run lcov to create an 'after snapshot'
- then you compare the 'before' and 'after' snapshots, and you can
tell what code was actually executed and therefore tested by your
tests.

At least, thats the way I understand it to be.

When I run 'make help' I get this :

   unitcheckrun unit tests
   slowcheckrun slow unit tests
   subsequentcheck  run system tests (requires full installation)
   checkrun unit tests and if in toplevel subsequentcheck

Which gives me the idea that, when run from the top level, 'make
check' also runs 'make subsequentcheck ', and that it would make sense
to also run 'make unitcheck' and 'make slowcheck' here ? Or am I
missing something ?


Thanks for the feedback,


Regards,


John Smith.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

1 2 3 >

1 - 100 of 251 matches

Mail list logo