Re: Master failed to compile on framework module
I runned make clean make this morning and here are the details. [ build LNK ] Library/libxstor.so /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx: In member function ‘void FrameHelper::dispatchCommand(rtl::OUString)’: /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx:721:40: error: ‘DispatchHelper’ has not been declared make[2]: *** [/home/julien/compile-libreoffice/libo/workdir/unxlngx6/CxxObject/framework/source/lomenubar/FrameHelper.o] Erreur 1 make[2]: *** Attente des tâches non terminées make[2]: *** wait: Aucun processus enfant. Arrêt. git last commit retrieved: 3ee97489ea49b339c4a7578afd85f85f77dd0f68 gcc (Debian 4.7.1-2) 4.7.1 GNU Make 3.81 autogen.lastrun: --enable-lomenubar --with-system-odbc --enable-ext-mysql-connector --with-system-mysql --enable-symbols --enable-ext-barcode --enable-ext-diagram --enable-ext-google-docs --enable-ext-hunart --enable-ext-nlpsolver --enable-ext-ct2n --enable-ext-numbertext --enable-ext-oooblogger --enable-ext-pdfimport --enable-postgresql-sdbc --enable-ext-presenter-console --enable-ext-presenter-minimizer --enable-ext-report-builder --enable-ext-scripting-beanshell --enable-ext-scripting-javascript --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-ext-wiki-publisher --enable-dbus --enable-graphite --enable-evolution2 --enable-werror --enable-debug --enable-dbgutil --enable-crashdump --enable-kde4 --enable-dependency-tracking --enable-online-update -- View this message in context: http://nabble.documentfoundation.org/Master-failed-to-compile-on-framework-module-tp4003926p4003941.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Master failed to compile on framework module
Looks like fallout from my recent UNO patches. Until it's fixed, add a line like using com::sun::star::frame::DispatchHelper; near line 100. On 2012-08-28 08:18, julien2412 wrote: I runned make clean make this morning and here are the details. [ build LNK ] Library/libxstor.so /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx: In member function ‘void FrameHelper::dispatchCommand(rtl::OUString)’: /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx:721:40: error: ‘DispatchHelper’ has not been declared make[2]: *** [/home/julien/compile-libreoffice/libo/workdir/unxlngx6/CxxObject/framework/source/lomenubar/FrameHelper.o] Erreur 1 make[2]: *** Attente des tâches non terminées make[2]: *** wait: Aucun processus enfant. Arrêt. git last commit retrieved: 3ee97489ea49b339c4a7578afd85f85f77dd0f68 gcc (Debian 4.7.1-2) 4.7.1 GNU Make 3.81 autogen.lastrun: --enable-lomenubar --with-system-odbc --enable-ext-mysql-connector --with-system-mysql --enable-symbols --enable-ext-barcode --enable-ext-diagram --enable-ext-google-docs --enable-ext-hunart --enable-ext-nlpsolver --enable-ext-ct2n --enable-ext-numbertext --enable-ext-oooblogger --enable-ext-pdfimport --enable-postgresql-sdbc --enable-ext-presenter-console --enable-ext-presenter-minimizer --enable-ext-report-builder --enable-ext-scripting-beanshell --enable-ext-scripting-javascript --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-ext-wiki-publisher --enable-dbus --enable-graphite --enable-evolution2 --enable-werror --enable-debug --enable-dbgutil --enable-crashdump --enable-kde4 --enable-dependency-tracking --enable-online-update -- View this message in context: http://nabble.documentfoundation.org/Master-failed-to-compile-on-framework-module-tp4003926p4003941.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Bug 53673 - [LABELS][MAILMERGE] Labels broken with mailmerge - help requested
Hi all, Libreoffice 3.6 introduced bug 53673, a problem when working with documents generated by the label wizard. The layout of the frames gets broken when saving (or opening?) these documents. It is possible that the cause of this is in the label wizard (e.g. incorrect placement of frames), although it did work in 3.5. Who knows all about writer-document file saving/reading and frame-positons and is willing to -look at the bug (how to reproduce problem is described) -and/or look at the document-creation code (core/sw/source/ui/app/applab.cxx, function SwModule::InsertLab()), -and give me some clues to solve the problem? I must say that if the problem is not in the label wizard code, chances are that I will not be able to solve the bug. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: ios/qa
ios/qa/sc/Makefile | 14 +- ios/qa/sc/filters-test.m | 14 -- 2 files changed, 21 insertions(+), 7 deletions(-) New commits: commit 9148c703235527d863978e1e947cce060cf49ef9 Author: Tor Lillqvist t...@iki.fi Date: Mon Aug 27 19:39:59 2012 +0300 Incomplete hacks on the iOS sc filters-test unit test Change-Id: I6b1f22d0623e8746af755dd25fc9f3194d6f11d3 diff --git a/ios/qa/sc/Makefile b/ios/qa/sc/Makefile index 4308132..8b2546f 100644 --- a/ios/qa/sc/Makefile +++ b/ios/qa/sc/Makefile @@ -60,6 +60,16 @@ stuff: ) $(APPDIR)/fundamentalrc # +# An unorc is *mandatory*, sigh. We leave it empty except for the +# [Bootstrap} section header, though, and set all the stuff using +# -env: options in filters-test.m. Whether that makes sense or not, +# no idea. The ideal would clearly be if *none* of the various rc +# files was mandatory, and the code would automatically use sane +# defaults. (Sane for the particular platform, that is.) + ( \ +echo '[Bootstrap]' \ + ) $(APPDIR)/unorc +# # hmm, once again, a hodgepodge of stuff, I don't really know which # files of which are actually needed... mkdir -p $(APPDIR)/registry/res @@ -69,9 +79,11 @@ stuff: # # .rdb files cp $(OUTDIR)/bin/udkapi.rdb $(OUTDIR)/bin/types.rdb $(OUTDIR)/xml/ure/services.rdb $(APPDIR) + mkdir -p $(APPDIR)/ure + cp $(OUTDIR)/bin/ure/types.rdb $(APPDIR)/ure # # a bunch of .component files - for F in framework/util/fwk i18npool/util/i18npool sfx2/util/sfx ucb/source/core/ucb1 ucb/source/ucp/file/ucpfile1 unoxml/source/service/unoxml configmgr/source/configmgr basic/util/sb chart2/source/controller/chartcontroller chart2/source/tools/chartcore comphelper/util/comphelp eventattacher/source/evtatt fileaccess/source/fileacc filter/source/config/cache/filterconfig1 oox/util/oox package/source/xstor/xstor package/util/package2 sax/source/expatwrap/expwrap sax/source/fastparser/fastsax sc/util/sc sc/util/scfilt scaddins/source/analysis/analysis scaddins/source/datefunc/date sot/util/sot svl/util/svl toolkit/util/tk ucb/source/ucp/tdoc/ucptdoc1 unotools/util/utl unoxml/source/rdf/unordf; do \ + for F in framework/util/fwk i18npool/util/i18npool sfx2/util/sfx ucb/source/core/ucb1 ucb/source/ucp/file/ucpfile1 unoxml/source/service/unoxml configmgr/source/configmgr basic/util/sb chart2/source/controller/chartcontroller chart2/source/chartcore comphelper/util/comphelp eventattacher/source/evtatt fileaccess/source/fileacc filter/source/config/cache/filterconfig1 oox/util/oox package/source/xstor/xstor package/util/package2 sax/source/expatwrap/expwrap sax/source/fastparser/fastsax sc/util/sc sc/util/scfilt scaddins/source/analysis/analysis scaddins/source/datefunc/date sot/util/sot svl/util/svl toolkit/util/tk ucb/source/ucp/tdoc/ucptdoc1 unotools/util/utl unoxml/source/rdf/unordf; do \ mkdir -p $(APPDIR)/ComponentTarget/`dirname $$F`; \ cp $(WORKDIR)/ComponentTarget/$$F.component $(APPDIR)/ComponentTarget/$$F.component; \ done diff --git a/ios/qa/sc/filters-test.m b/ios/qa/sc/filters-test.m index df6afd3..9116464 100644 --- a/ios/qa/sc/filters-test.m +++ b/ios/qa/sc/filters-test.m @@ -119,7 +119,7 @@ didFinishLaunchingWithOptions: (NSDictionary *) launchOptions --protector, dummy-libunobootstrapprotector, unobootstrapprotector, -placeholder-ure-internal-lib-dir, +-env:URE_INTERNAL_LIB_DIR=file:///, placeholder-uno-types, placeholder-uno-services }; @@ -128,18 +128,20 @@ didFinishLaunchingWithOptions: (NSDictionary *) launchOptions NSString *app_root_escaped = [[[NSBundle mainBundle] bundlePath] stringByAddingPercentEscapesUsingEncoding: NSUTF8StringEncoding]; -argv[argc-3] = -env:URE_INTERNAL_LIB_DIR=file:///; - NSString *uno_types = @-env:UNO_TYPES=; uno_types = [uno_types stringByAppendingString: @file://]; uno_types = [uno_types stringByAppendingString: [app_root_escaped stringByAppendingPathComponent: @udkapi.rdb]]; uno_types = [uno_types stringByAppendingString: @ ]; - uno_types = [uno_types stringByAppendingString: @file://]; uno_types = [uno_types stringByAppendingString: [app_root_escaped stringByAppendingPathComponent: @types.rdb]]; +uno_types = [uno_types stringByAppendingString: @ ]; +uno_types = [uno_types stringByAppendingString: @file://]; +uno_types = [uno_types stringByAppendingString: [app_root_escaped stringByAppendingPathComponent: @ure/types.rdb]]; + +assert(strcmp(argv[argc-2], placeholder-uno-types) == 0); argv[argc-2] = [uno_types UTF8String]; NSString *uno_services = @-env:UNO_SERVICES=; @@ -148,8 +150,7 @@ didFinishLaunchingWithOptions: (NSDictionary *) launchOptions services.rdb, ComponentTarget/basic/util/sb.component,
[Libreoffice-commits] .: sal/qa toolkit/inc unusedcode.easy
sal/qa/rtl/uuid/rtl_Uuid.cxx| 12 toolkit/inc/toolkit/awt/vclxprinter.hxx |3 ++- unusedcode.easy |3 +-- 3 files changed, 3 insertions(+), 15 deletions(-) New commits: commit 78fe6b835840049434170003a8dcf14535fd7bf2 Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 28 09:06:58 2012 +0100 callcatcher: make VCLXPrinterServer an XTypeProvider Change-Id: Ib6e4e4c61c56cea9c6171f36989e903f3c35aa4e diff --git a/sal/qa/rtl/uuid/rtl_Uuid.cxx b/sal/qa/rtl/uuid/rtl_Uuid.cxx index 056ae3d..36d355c 100644 --- a/sal/qa/rtl/uuid/rtl_Uuid.cxx +++ b/sal/qa/rtl/uuid/rtl_Uuid.cxx @@ -153,18 +153,6 @@ public: CPPUNIT_TEST_SUITE_END(); }; // class createUuid -namespace ThreadHelper -{ - void thread_sleep(sal_Int32 _nSec) -{ -#ifdef WNT //Windows -::Sleep(_nSec * 10); -#elif defined UNX -::sleep(_nSec); -#endif -} -} - class createNamedUuid : public CppUnit::TestFixture { public: diff --git a/toolkit/inc/toolkit/awt/vclxprinter.hxx b/toolkit/inc/toolkit/awt/vclxprinter.hxx index 6671f83..03eed25 100644 --- a/toolkit/inc/toolkit/awt/vclxprinter.hxx +++ b/toolkit/inc/toolkit/awt/vclxprinter.hxx @@ -191,7 +191,8 @@ public: // class VCLXPrinterServer : public ::com::sun::star::awt::XPrinterServer, -public ::cppu::OWeakObject +public ::com::sun::star::lang::XTypeProvider, +public ::cppu::OWeakObject { public: diff --git a/unusedcode.easy b/unusedcode.easy index f0992ae..6597467 100755 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -7,14 +7,13 @@ ScVbaFormatooo::vba::excel::XStyle::setAddIndent(com::sun::star::uno::Any cons ScVbaFormatooo::vba::excel::XStyle::setNumberFormat(com::sun::star::lang::Locale, rtl::OUString const) SvtSlideSorterBarOptions::AddListenerLink(Link const) SvtSlideSorterBarOptions::RemoveListenerLink(Link const) +SwEditWin::ShowHeaderFooterSeparator(bool, bool) TextEngine::GetLeftMargin() const ThumbnailView::GetItemCount() const ThumbnailView::ImplScroll(Point const) ThumbnailView::InsertItem(unsigned short, BitmapEx const, rtl::OUString const, unsigned long) ThumbnailViewItemAcc::FireAccessibleEvent(short, com::sun::star::uno::Any const, com::sun::star::uno::Any const) ThumbnailViewItemAcc::getImplementation(com::sun::star::uno::Referencecom::sun::star::uno::XInterface const) -VCLXPrinterServer::getImplementationId() -VCLXPrinterServer::getTypes() VirtualDevice::SetOutputSizePixelScaleOffsetAndBuffer(Size const, Fraction const, Point const, boost::shared_arrayunsigned char const) Window::PostUserEvent(unsigned long, unsigned long, void*) XclExpPivotCache::GetFieldAcc(rtl::OUString const) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/core/edit/edundo.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit fb63bdd04119698a2c8e40f946cd222d3114cb7f Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Tue Aug 28 10:07:21 2012 +0200 fdo#36681: fixed view window after redoing a frame delete Change-Id: I2b9f618ba6869fabf7c5ae2339421688aab127c7 diff --git a/sw/source/core/edit/edundo.cxx b/sw/source/core/edit/edundo.cxx index 26b64b0..8341cd2 100644 --- a/sw/source/core/edit/edundo.cxx +++ b/sw/source/core/edit/edundo.cxx @@ -41,6 +41,7 @@ #include frmfmt.hxx #include viewimp.hxx #include docsh.hxx +#include pagefrm.hxx /** helper function to select all objects in an SdrMarkList; @@ -82,6 +83,12 @@ SwEditShell::HandleUndoRedoContext(::sw::UndoRedoContext rContext) static_castSwFlyFrmFmt*(pSelFmt)-GetFrm( aPt, false); if (pFly) { +// fdo#36681: Invalidate the content and layout to refresh +// the picture anchoring properly +SwPageFrm* pPageFrm = pFly-FindPageFrmOfAnchor(); +pPageFrm-InvalidateFlyLayout(); +pPageFrm-InvalidateCntnt(); + static_castSwFEShell*(this)-SelectFlyFrm(*pFly, true); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: make_installer 'touching' files in solver ?
Hi, On Mon, Aug 27, 2012 at 08:53:16AM +0200, Stephan Bergmann wrote: On 08/25/2012 10:42 AM, Matúš Kukan wrote: I was doing --enable-epm build (it was probably mistake) and had problems with 'make check' something seems to be 'touching' version libraries in solver. (libuno_sal.so.3 libuno_salhelpergcc3.so.3 libstore.so.3 ...) My accumulated autogen.lastrun contains a commented out --enable-epm with comment # --enable-epm leads to stripped solver So looks like instsetoo_native still strips libraries, and does so in-place in the solver. (I at least lost track of the when and what to srip discussion we had not too long ago.) It seems that solver is not stripped by default since commit 65840941eeeab7021168a17797b6129ea15a722d . D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/core/tool/address.cxx | 95 +++- 1 file changed, 65 insertions(+), 30 deletions(-) New commits: commit 2a6ada4a4dab3edb0896ac5665623c0d4727baf7 Author: Eike Rathke er...@redhat.com Date: Tue Aug 28 00:04:20 2012 +0200 resolved fdo#51926 handle .xlsm link to external sheet with space In MOOXML '[1]Sheet 4'!$A$1 represents a reference to an external document's cache index with a sheet name containing blank, and not [1]'Sheet 4'!$A$1 Change-Id: I5caf9e1d9a80154116dc7a72b33d34229092839c diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index 30558bd..8af1314 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -326,6 +326,57 @@ lcl_XL_ParseSheetRef( const sal_Unicode* start, } +/** Tries to obtain the external document index and replace by actual document +name. + +@param ppErrRet + Contains the default pointer the caller would return if this method + returns FALSE, may be replaced by NULL for type or data errors. + +@returns FALSE only if the input name is numeric and not within the index +sequence, or the link type cannot be determined or data mismatch. Returns +TRUE in all other cases, also when there is no index sequence or the input +name is not numeric. + */ +bool lcl_XL_getExternalDoc( const sal_Unicode** ppErrRet, String rExternDocName, +const uno::Sequence const sheet::ExternalLinkInfo * pExternalLinks) +{ +// 1-based, sequence starts with an empty element. +if (pExternalLinks pExternalLinks-getLength() 1) +{ +// A numeric document name is an index into the sequence. +if (CharClass::isAsciiNumeric( rExternDocName)) +{ +sal_Int32 i = rExternDocName.ToInt32(); +if (i = 0 || i = pExternalLinks-getLength()) +return false; // with default *ppErrRet +const sheet::ExternalLinkInfo rInfo = (*pExternalLinks)[i]; +switch (rInfo.Type) +{ +case sheet::ExternalLinkType::DOCUMENT : +{ +rtl::OUString aStr; +if (!(rInfo.Data = aStr)) +{ +OSL_TRACE( ScRange::Parse_XL_Header: Data type mismatch for ExternalLinkInfo %d, i); +*ppErrRet = NULL; +return false; +} +rExternDocName = aStr; +} +break; +default: +OSL_TRACE( ScRange::Parse_XL_Header: unhandled ExternalLinkType %d for index %d, +rInfo.Type, i); +*ppErrRet = NULL; +return false; +} +} +} +return true; +} + + const sal_Unicode* ScRange::Parse_XL_Header( const sal_Unicode* p, const ScDocument* pDoc, @@ -368,36 +419,10 @@ const sal_Unicode* ScRange::Parse_XL_Header( } ++p; -// 1-based, sequence starts with an empty element. -if (pExternalLinks pExternalLinks-getLength() 1) -{ -// A numeric document name is an index into the sequence. -if (CharClass::isAsciiNumeric( rExternDocName)) -{ -sal_Int32 i = rExternDocName.ToInt32(); -if (i = 0 || i = pExternalLinks-getLength()) -return start; -const sheet::ExternalLinkInfo rInfo = (*pExternalLinks)[i]; -switch (rInfo.Type) -{ -case sheet::ExternalLinkType::DOCUMENT : -{ -rtl::OUString aStr; -if (!(rInfo.Data = aStr)) -{ -OSL_TRACE( ScRange::Parse_XL_Header: Data type mismatch for ExternalLinkInfo %d, i); -return NULL; -} -rExternDocName = aStr; -} -break; -default: -OSL_TRACE( ScRange::Parse_XL_Header: unhandled ExternalLinkType %d for index %d, -rInfo.Type, i); -return NULL; -} -} -} +const sal_Unicode* pErrRet = start; +if (!lcl_XL_getExternalDoc( pErrRet, rExternDocName, pExternalLinks)) +return pErrRet; + rExternDocName = ScGlobal::GetAbsDocName(rExternDocName, pDoc-GetDocumentShell()); } else if (*p == '\'') @@ -407,6 +432,8 @@ const sal_Unicode* ScRange::Parse_XL_Header( // 'E:\[EXTDATA12B.XLSB]Sheet1:Sheet3'!$A$11 // But, 'Sheet1'!B3 would also be a valid! // Excel does not allow [ and ]
Re:[PUSHED] [REVIEW 3-6] resolved fdo#51926 handle .xlsm link to external sheet with space
On 27/08/12 23:28, Eike Rathke wrote: Hi, We may want this in 3-6 http://cgit.freedesktop.org/libreoffice/core/commit/?id=85e40d787e9aacadfd8599791c83d09eb04e46d5 fixes https://bugs.freedesktop.org/show_bug.cgi?id=51926 Formula references to external documents' sheets with names containing blanks (and other irregular characters, hence quoted) vanish. looks reasonable to me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][REVIEW-3-6] fix for fdo#53839, don't crash for invalid repaint range in cond format code
On 28/08/12 02:36, Markus Mohrhard wrote: Hey, This patch is absolutely safe and will prevent the crash for now. For master I will need to think about a clean concept that also removes the performance problems with the current approach. agreed, patch is safe Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Modifying comments to meet doxygen standards
From abdulmajeed ahmed aalabdulraz...@kacst.edu.sa: abdulmajeed ahmed has uploaded a new change for review. Change subject: Modifying comments to meet doxygen standards .. Modifying comments to meet doxygen standards Change-Id: Iaf83b7119767cf0b953cab62d141e8e154bb --- M sw/inc/docary.hxx M sw/inc/docfac.hxx M sw/inc/docsh.hxx M sw/inc/docstyle.hxx M sw/inc/docufld.hxx M sw/inc/drawdoc.hxx M sw/inc/edglbldc.hxx M sw/inc/editsh.hxx M sw/inc/expfld.hxx M sw/inc/fchrfmt.hxx M sw/inc/fesh.hxx M sw/inc/fldbas.hxx M sw/inc/flyenum.hxx M sw/inc/flypos.hxx M sw/inc/fmtanchr.hxx M sw/inc/fmtautofmt.hxx M sw/inc/fmtclbl.hxx M sw/inc/fmtclds.hxx M sw/inc/fmtcnct.hxx M sw/inc/fmtcntnt.hxx M sw/inc/fmtcol.hxx M sw/inc/fmteiro.hxx M sw/inc/fmtflcnt.hxx M sw/inc/fmtfld.hxx M sw/inc/fmtfollowtextflow.hxx M sw/inc/fmtfordr.hxx M sw/inc/fmtfsize.hxx M sw/inc/fmtftn.hxx M sw/inc/fmtftntx.hxx M sw/inc/fmthdft.hxx M sw/inc/fmtinfmt.hxx M sw/inc/fmtline.hxx M sw/inc/fmtlsplt.hxx M sw/inc/fmtmeta.hxx M sw/inc/fmtornt.hxx M sw/inc/fmtpdsc.hxx 36 files changed, 716 insertions(+), 715 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/496/1 -- To view, visit https://gerrit.libreoffice.org/496 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaf83b7119767cf0b953cab62d141e8e154bb Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: abdulmajeed ahmed aalabdulraz...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/core/data/conditio.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9f14fa5f5f6c6edd596a0bfaa9a24facb5c6d83f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 28 02:59:39 2012 +0200 don't crash for invalid repaint ranges in cond formats, fdo#53839 Change-Id: I83cbb2574849c69fba3ca315d7507358654ff2b9 diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx index 97ffd61..a5e637c 100644 --- a/sc/source/core/data/conditio.cxx +++ b/sc/source/core/data/conditio.cxx @@ -1126,7 +1126,7 @@ void ScConditionEntry::SourceChanged( const ScAddress rChanged ) ScRange aPaint( nCol1,nRow1,nTab1, nCol2,nRow2,nTab2 ); // kein Paint, wenn es nur die Zelle selber ist -if ( aPaint.aStart != rChanged || aPaint.aEnd != rChanged ) +if ( aPaint.IsValid() (aPaint.aStart != rChanged || aPaint.aEnd != rChanged )) DataChanged( aPaint ); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: framework/source
framework/source/lomenubar/FrameHelper.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 043d6b6442c1f60838f9502a1e198a1e6a57a123 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Aug 28 10:46:42 2012 +0200 Missing using com::sun::star::frame::DispatchHelper Change-Id: Ia4a830c342077bdc5b61daba1edccca2edb544c6 diff --git a/framework/source/lomenubar/FrameHelper.cxx b/framework/source/lomenubar/FrameHelper.cxx index cd40491..91ae62b 100644 --- a/framework/source/lomenubar/FrameHelper.cxx +++ b/framework/source/lomenubar/FrameHelper.cxx @@ -95,6 +95,7 @@ using com::sun::star::beans::XPropertySet; using com::sun::star::beans::PropertyValue; using com::sun::star::container::XNameAccess; using com::sun::star::container::NoSuchElementException; +using com::sun::star::frame::DispatchHelper; using com::sun::star::frame::XController; using com::sun::star::frame::XComponentLoader; using com::sun::star::frame::XDispatch; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
--enable-lomenubar (was: Master failed to compile on framework module)
On 08/28/2012 08:18 AM, julien2412 wrote: I runned make clean make this morning and here are the details. [ build LNK ] Library/libxstor.so /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx: In member function ‘void FrameHelper::dispatchCommand(rtl::OUString)’: /home/julien/compile-libreoffice/libo/framework/source/lomenubar/FrameHelper.cxx:721:40: error: ‘DispatchHelper’ has not been declared make[2]: *** [/home/julien/compile-libreoffice/libo/workdir/unxlngx6/CxxObject/framework/source/lomenubar/FrameHelper.o] Erreur 1 make[2]: *** Attente des tâches non terminées make[2]: *** wait: Aucun processus enfant. Arrêt. git last commit retrieved: 3ee97489ea49b339c4a7578afd85f85f77dd0f68 gcc (Debian 4.7.1-2) 4.7.1 GNU Make 3.81 autogen.lastrun: --enable-lomenubar Should be fixed now with http://cgit.freedesktop.org/libreoffice/core/commit/?id=043d6b6442c1f60838f9502a1e198a1e6a57a123 Missing using com::sun::star::frame::DispatchHelper. However, I'm unable to configure --enable-lomenubar on Fedora 17. configure.in checks for dbusmenu-gtk, but Fedora only has dbusmenu-qt. Any known solution for this? Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH (partial)] Writer autocompletion feature
Hi Tomaž, Tomaž Vajngerl píše v Po 27. 08. 2012 v 10:42 +0200: [...snipped lots of good stuff...] I will remove all the usage of old sorted vector for autocompletion in the near future, but other things will need to wait. Beautiful, thanks so much for all that! :-) All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: localize spreadsheet style template names runtime
Hi UX guys, Any input on this, please? :-) Should we add it to menu somewhere? [Summary: One can apply themes/templates for sheets in Calc, but the functionality is buried under a button that is not even visible by default.] Thank you, Kendy Olivier Hallot píše v Ne 26. 08. 2012 v 07:05 -0300: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Andras Em 26-08-2012 04:06, Andras Timar escreveu: 2012/8/26 Olivier Hallot olivier.hal...@documentfoundation.org: -BEGIN PGP SIGNED MESSAGE- If not, which wizzard is responsible for these templates? It's a bit misleading, because it is not a wizard. I'd like to sort out paths later. In Calc make Tools toolbar visible (View - Toolbars - Tools). From Tools toolbar select the Choose Themes button. See also http://help.libreoffice.org/Calc/Selecting_Themes_for_Sheets Best regards, Andras Wow!!... this is digital archeology or digital paleontology... finding burried palaces or buried bones in the code. I think it deserves a better place in the UI to play with. (and, while we are there, shouldn't we use open fonts?) Regards - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQOfTwAAoJEJp3R7nH3vLx9hsH/3+6MZN8hA1KE4ZcOeI+707F 6cc9k6w3gcfBJ33EVsP4+/IullOcW+bDZHSv5x5t4ge/TkEclUG2W7qVvzoBHv+D esNx2Foz8/0yMoEiFOQatJKcXBClz0isk+jUGG7viBge8P92LeotHgiskYZFnXGa pCw+QittBZptJTaMtSlsr/+sCaz05+webCoJ2mJH6oVsnwfWLvCAmJW7+h5y1FX2 C29nOO75TGzgmDgZhKj1DfooUFLZtODR5fm2Uqema08QxO04D6BLY+revM/LCIu3 KwZEjpZWbZTaxuv4viGYC2BI7WsoDdG3k3hXPRD9QzuTlq8/Wwpw714eJecVc7s= =h2AL -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: using syslog instead of console for messages
On 08/27/2012 08:04 PM, Riccardo Magliocchetti wrote: So here's a quick patch, not even compile tested because i have few questions to resolve before considering it ready for review: - what about errors? it looks like SAL does not have a level for errors. I'd like to have the errors in vcl/headless/headlessinst.cxx going to syslog too. Should i use straight syslog or can i use another facility? IMO, those uses of fprintf in headlessinst.cxx should be replaced with appropriate uses of SAL_INFO/SAL_WARN/assert to begin with. - is it ok to initialize syslog in desktop/source/app/sofficemain.cxx? Should either go to sal_detail_initialize or be done on demand in log.cxx. - can you suggests something better than WANT_SYSLOG_LOGS ? :) Make compilation dependent on HAVE_SYSLOG_H, make the behavior of log() dependent on some env var (either extend the syntax of SAL_LOG to also contain the target, or add a SAL_LOG_TARGET with values syslog, stderr, say). - should i add a switch for syslog logging to configure so that the feature may be used also in other environments? May be useful for large deployments i think where you want centralized logs. I would make it configurable at runtime, see above. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: localize spreadsheet style template names runtime
Hi Olivier, 2012/8/26 Olivier Hallot olivier.hal...@documentfoundation.org: (and, while we are there, shouldn't we use open fonts?) Yes, we should. If I remember correctly you did it for other templates, so feel free to fix these, too. Also, the internal name of xos.ots (Be) could be changed. I think it refers to the colors of BeOS, an alternative operating system from 90s, but hardly anyone remembers that. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/ui/view/cliputil.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d27a7b8c5b96eb328918cc67b9b5562b8870f2ac Author: Noel Power noel.po...@suse.com Date: Mon Aug 27 18:02:18 2012 +0100 allow paste paste special for unmatching dest (single) range Change-Id: I420c044c9bcc49e479956f9118fb173a0350fda2 diff --git a/sc/source/ui/view/cliputil.cxx b/sc/source/ui/view/cliputil.cxx index 74ac721..723bb89 100644 --- a/sc/source/ui/view/cliputil.cxx +++ b/sc/source/ui/view/cliputil.cxx @@ -114,7 +114,7 @@ bool ScClipUtil::CheckDestRanges( SCCOL nCols = aTest.aEnd.Col() - aTest.aStart.Col() + 1; SCROW nRowTest = (nRows / nSrcRows) * nSrcRows; SCCOL nColTest = (nCols / nSrcCols) * nSrcCols; -if (nRows != nRowTest || nCols != nColTest) +if ( rDest.size() 1 ( nRows != nRowTest || nCols != nColTest ) ) { // Destination range is not a multiple of the source range. Bail out. return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED-3-6] fdo#53399 Word count is inconsistent and wrong with non-brea...
On Wed, 2012-08-22 at 17:25 +0100, Michael Meeks wrote: It'd be great to have: http://cgit.freedesktop.org/libreoffice/core/commit/?id=3ba107606682b5e675127483a514f0e6580ecfd1 reviewed and cherry-picked by someone - Caolan ? Looks sane to me, and its got a regression test, what's not to love. Pushed to 3-6. The original lcl_IsSkippableWhitespace came from http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea79d03a68d7490e50a6d8b75905d081c4ddd470 which was to fix https://issues.apache.org/ooo/show_bug.cgi?id=13474 and that remains fixed after this change. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/qa sw/source
sw/qa/core/swdoc-test.cxx | 10 -- sw/source/core/txtnode/txtedt.cxx | 13 +++-- 2 files changed, 11 insertions(+), 12 deletions(-) New commits: commit 48d1979dc3fb4618e04f37e5090c66ddf2fdad3a Author: Muhammad Haggag mhag...@gmail.com Date: Wed Aug 22 16:46:23 2012 +0200 fdo#53399 Word count is inconsistent and wrong with non-breaking space This change replaces lcl_IsSkippableWhitespace with a call to ICU's u_isspace, which covers all Unicode separators. It also updates and fixes one of the SwScanner unit tests. Bug details: SwScanner::NextWord skips whitespace before calling into ICU's BreakIterator. The function used to identify whitespace (lcl_IsSkippableWhitespace) doesn't cover the full category of Unicode separators (code [Zs], 18 in total. See: http://www.fileformat.info/info/unicode/category/Zs/index.htm). Since 0xA0 (no-break space) is not identified as whitespace and not skipped, we end up calling ICU starting at the position 0xA0, asking it to get us the boundary of the next word forward. ICU sees that it's called at the end of a word, and reverses the query direction to backward, and returns the word before. This causes NextWord to think we've hit the end of the string and call it a day, terminating word count for the rest of the line. Change-Id: I29c89ddb0b26e88da822501253898856b28e3fa5 Reviewed-on: https://gerrit.libreoffice.org/453 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com (cherry picked from commit 3ba107606682b5e675127483a514f0e6580ecfd1) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sw/qa/core/swdoc-test.cxx b/sw/qa/core/swdoc-test.cxx index a3f795a..f19e9e5 100644 --- a/sw/qa/core/swdoc-test.cxx +++ b/sw/qa/core/swdoc-test.cxx @@ -307,6 +307,7 @@ void SwDocTest::testSwScanner() } //See https://issues.apache.org/ooo/show_bug.cgi?id=89042 +//See https://bugs.freedesktop.org/show_bug.cgi?id=53399 { SwDocStat aDocStat; @@ -323,15 +324,20 @@ void SwDocTest::testSwScanner() CPPUNIT_ASSERT_MESSAGE(Should be 3, aDocStat.nWord == 3); const sal_Unicode aShouldBeFive[] = { +// fr e n c h space 0x0046, 0x0072, 0x0065, 0x006E, 0x0063, 0x0068, 0x0020, +//nbsps a v o i 0x00AB, 0x00A0, 0x0073, 0x0061, 0x0076, 0x006F, 0x0069, -0x0072, 0x0020, 0x0063, 0x0061, 0x006C, 0x0063, 0x0075, -0x006C, 0x0065, 0x0072, 0x00A0, 0x00BB +// rnnbsp c a l c u +0x0072, 0x202f, 0x0063, 0x0061, 0x006C, 0x0063, 0x0075, +// le r idspace +0x006C, 0x0065, 0x0072, 0x3000, 0x00BB }; m_pDoc-AppendTxtNode(*aPaM.GetPoint()); m_pDoc-InsertString(aPaM, rtl::OUString(aShouldBeFive, SAL_N_ELEMENTS(aShouldBeFive))); pTxtNode = aPaM.GetNode()-GetTxtNode(); +aDocStat.Reset(); pTxtNode-CountWords(aDocStat, 0, SAL_N_ELEMENTS(aShouldBeFive)); CPPUNIT_ASSERT_MESSAGE(Should be 5, aDocStat.nWord == 5); } diff --git a/sw/source/core/txtnode/txtedt.cxx b/sw/source/core/txtnode/txtedt.cxx index 7f350c6..2cbe32a 100644 --- a/sw/source/core/txtnode/txtedt.cxx +++ b/sw/source/core/txtnode/txtedt.cxx @@ -71,6 +71,7 @@ #include txtatr.hxx #include fmtautofmt.hxx #include istyleaccess.hxx +#include unicode/uchar.h #include unomid.h @@ -96,14 +97,6 @@ using namespace ::com::sun::star::smarttags; extern const SwTxtNode *pLinguNode; extern SwTxtFrm *pLinguFrm; -bool lcl_IsSkippableWhiteSpace( xub_Unicode cCh ) -{ -return 0x3000 == cCh || - ' ' == cCh || - '\t' == cCh || - 0x0a == cCh; -} - /* * This has basically the same function as SwScriptInfo::MaskHiddenRanges, * only for deleted redlines @@ -731,7 +724,7 @@ sal_Bool SwScanner::NextWord() // skip non-letter characters: while ( nBegin aText.getLength() ) { -if ( !lcl_IsSkippableWhiteSpace( aText[nBegin] ) ) +if ( !u_isspace( aText[nBegin] ) ) { if ( !pLanguage ) { @@ -1879,7 +1872,7 @@ void SwTxtNode::CountWords( SwDocStat rStat, //do the count // all counts exclude hidden paras and hidden+redlined within para // definition of space/white chars in SwScanner (and BreakIter!) -// uses both lcl_IsSkippableWhiteSpace and BreakIter getWordBoundary in SwScanner +// uses both u_isspace and BreakIter getWordBoundary in SwScanner sal_uInt32 nTmpWords = 0;// count of all words sal_uInt32 nTmpAsianWords = 0; //count of all Asian codepoints sal_uInt32 nTmpChars = 0;// count of all chars ___ Libreoffice-commits mailing list
Re: --enable-lomenubar (was: Master failed to compile on framework module)
On Tue, Aug 28, 2012 at 10:52:21AM +0200, Stephan Bergmann wrote: However, I'm unable to configure --enable-lomenubar on Fedora 17. configure.in checks for dbusmenu-gtk, but Fedora only has dbusmenu-qt. Any known solution for this? Pleas dont bother too much with that --enable-lomenubar code -- it will be obsolete and replaced for 3.7 by the work in feature/unitymenus. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 53399, which changed state. Bug 53399 Summary: Word count inconsistent and wrong with non-breaking space https://bugs.freedesktop.org/show_bug.cgi?id=53399 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-6] fix for fdo#46250
This patch makes lessens the strictness when determining when paste special-paste can be applied, please consider http://cgit.freedesktop.org/libreoffice/core/commit/?id=d27a7b8c5b96eb328918cc67b9b5562b8870f2ac for cherry-picking to 3.6. Kohei, my initial gung-ho-ness for additionally squashing the paste always on behaviour has waned a little, if we do that I'd prefer to do it separately. ps. in the commit message I forgot to mention the bug number, if cherry-picking please do a git commit --amend to add it before pushing, thanks Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 36681, which changed state. Bug 36681 Summary: EDITING: after insert/removal of a picture (or alike) view scrolls to begin/end of document https://bugs.freedesktop.org/show_bug.cgi?id=36681 What|Old Value |New Value Resolution||FIXED Status|REOPENED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: HardHacks
Hi Rainer, On Sat, 2012-08-25 at 08:31 +0200, Rainer Bielefeld wrote: 36681 All Writer - EDITING: after insert/removal of a picture (or alike) view scrolls to begin/end of document https://bugs.freedesktop.org/show_bug.cgi?id=36681 Fixed. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/breakiterator/data/README |3 +++ 1 file changed, 3 insertions(+) New commits: commit 5d1d4c940ad47ec3dacdf40d82b40836c99e02c3 Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 28 10:48:57 2012 +0100 document what the three FOO_word things are for Change-Id: Ie93c06a9304fd45a1c0c10af81cc09c88baf106f diff --git a/i18npool/source/breakiterator/data/README b/i18npool/source/breakiterator/data/README index 8967c73..e50b061 100644 --- a/i18npool/source/breakiterator/data/README +++ b/i18npool/source/breakiterator/data/README @@ -2,6 +2,9 @@ The originals of these come from svn checkout http://source.icu-project.org/repos/icu/icu/trunk/source/data/brkitr they no longer appear in the icu tarballs, but are in icu's svn +dict_word is used for dictionary word break, edit_word is for cursor +travelling, while count_word is for word count. + At various stages these copies have been customized and are now horribly out of sync. It unclear which diffs from the base versions are deliberate and which are now accidental :-( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sw/qa writerfilter/source
sw/qa/extras/rtfimport/data/fdo52052.rtf | 23 +++ sw/qa/extras/rtfimport/rtfimport.cxx |9 sw/qa/extras/swmodeltestbase.hxx | 15 +-- writerfilter/source/rtftok/rtfdocumentimpl.cxx | 51 ++--- writerfilter/source/rtftok/rtfdocumentimpl.hxx |3 + 5 files changed, 92 insertions(+), 9 deletions(-) New commits: commit 1efa576ef88141c4deb5da9818537e053dc6517b Author: Miklos Vajna vmik...@suse.cz Date: Tue Aug 28 11:21:50 2012 +0200 fdo#52052 fix RTF import of page breaks on landscape pages The problem was that we tried to insert a page break before reaching the first section break, where section properties are sent. Additionally, the continuous section break at the end of the doc caused trouble, so ignore it explicitly. Change-Id: I22bc355994991beeadb41d26b44ce3e2beedbdb2 diff --git a/sw/qa/extras/rtfimport/data/fdo52052.rtf b/sw/qa/extras/rtfimport/data/fdo52052.rtf new file mode 100644 index 000..329762e --- /dev/null +++ b/sw/qa/extras/rtfimport/data/fdo52052.rtf @@ -0,0 +1,23 @@ +{\rtf1\ansi\ansicpg1251\deff0\deflang1033 +{\fonttbl +{\f0\fswiss\fcharset204 Arial;} +} +{\colortbl;\red0\green0\blue0;} +{\info +{\title } +{\author Crystal Reports} +{\doccomm Powered By Crystal} +{\company Crystal Decisions} +} +\landscape\paperw16836\paperh11904\margl567\margr397\margt567\margb284\gutter0\windowctrl\ftnbj\viewkind1\viewscale100\sectd\linex0\sbknone +{\pard first +\par } +\page\sect +{\pard \pvpg\phpg\posx13152\posy612\absw2984\absh-210\fi0 \ltrpar\qr\tx360\tx720\tx1080\tx1440\tx1800\tx2160\tx2520\tx2880 +{\ltrch\f0 \b\i0\ul0\strike0\fs15 \cf1 second} +\par } +\page\sect +{\pard \pvpg\phpg\posx13152\posy612\absw2984\absh-210\fi0 \ltrpar\qr\tx360\tx720\tx1080\tx1440\tx1800\tx2160\tx2520\tx2880 +{\ltrch\f0 \b\i0\ul0\strike0\fs15 \cf1 third} +\par } +\sect } diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index 219acbe..918e7a5 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -106,6 +106,7 @@ public: void testFdo48446(); void testFdo47495(); void testAllGapsWord(); +void testFdo52052(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -153,6 +154,7 @@ public: CPPUNIT_TEST(testFdo48446); CPPUNIT_TEST(testFdo47495); CPPUNIT_TEST(testAllGapsWord); +CPPUNIT_TEST(testFdo52052); #endif CPPUNIT_TEST_SUITE_END(); @@ -915,6 +917,13 @@ void Test::testAllGapsWord() borderTest.testTheBorders(mxComponent); } +void Test::testFdo52052() +{ +load(fdo52052.rtf); +// Make sure the textframe containing the text third appears on the 3rd page. +CPPUNIT_ASSERT_EQUAL(OUString(third), parseDump(/root/page[3]/body/txt/anchored/fly/txt/text())); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 8120540..330c34d 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -270,7 +270,8 @@ RTFDocumentImpl::RTFDocumentImpl(uno::Referenceuno::XComponentContext const x m_bFormField(false), m_bIsInFrame(false), m_aUnicodeBuffer(), -m_aHexBuffer() +m_aHexBuffer(), +m_bDeferredContSectBreak(false) { OSL_ASSERT(xInputStream.is()); m_pInStream.reset(utl::UcbStreamHelper::CreateStream(xInputStream, sal_True)); @@ -1093,6 +1094,7 @@ void RTFDocumentImpl::replayBuffer(RTFBuffer_t rBuffer) int RTFDocumentImpl::dispatchDestination(RTFKeyword nKeyword) { checkUnicode(); +checkDeferredContSectBreak(); RTFSkipDestination aSkip(*this); switch (nKeyword) { @@ -1516,6 +1518,7 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword) { if (nKeyword != RTF_HEXCHAR) checkUnicode(); +checkDeferredContSectBreak(); RTFSkipDestination aSkip(*this); sal_uInt8 cCh = 0; @@ -1572,7 +1575,17 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword) } break; case RTF_SECT: -sectBreak(); +{ +RTFValue::Pointer_t pBreak = m_aStates.top().aSectionSprms.find(NS_sprm::LN_SBkc); +if (pBreak.get() !pBreak-getInt()) +{ +// This is a continous section break, don't send it yet. +// It's possible that we'll have nothing after this token, and then we should ignore it. +m_bDeferredContSectBreak = true; +} +else +sectBreak(); +} break; case RTF_NOBREAK: { @@ -1693,10 +1706,21 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword) break; case RTF_PAGE: { -
Re: localize spreadsheet style template names runtime
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Kendy, All Thanks for raising the issue. May be as one of the buttons in the Styles and Formatting window. There are spots available in the window for Calc. But I think it should be visible in the templates selection as well. There are some cell styles in the templates that are not easy to understand where they fit. Regards Olivier Em 28-08-2012 06:01, Jan Holesovsky escreveu: Hi UX guys, Any input on this, please? :-) Should we add it to menu somewhere? [Summary: One can apply themes/templates for sheets in Calc, but the functionality is buried under a button that is not even visible by default.] Thank you, Kendy Olivier Hallot píše v Ne 26. 08. 2012 v 07:05 -0300: Hi Andras Em 26-08-2012 04:06, Andras Timar escreveu: 2012/8/26 Olivier Hallot olivier.hal...@documentfoundation.org: -BEGIN PGP SIGNED MESSAGE- If not, which wizzard is responsible for these templates? It's a bit misleading, because it is not a wizard. I'd like to sort out paths later. In Calc make Tools toolbar visible (View - Toolbars - Tools). From Tools toolbar select the Choose Themes button. See also http://help.libreoffice.org/Calc/Selecting_Themes_for_Sheets Best regards, Andras Wow!!... this is digital archeology or digital paleontology... finding burried palaces or buried bones in the code. I think it deserves a better place in the UI to play with. (and, while we are there, shouldn't we use open fonts?) Regards ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQPJaYAAoJEJp3R7nH3vLxa3kH/3x2oMzNtRtk5KyXnkZ1PvkJ 4yBgjs4mIGUEFQc5t6HZzjLQ21IlKEuFYfuVhNaeCfqHf/WAgsc9fitvY1KuGE+O bIt0EKesQRtHtlWQZKWB2fKifzXjmXDg/ivzxvh8xasqk5KxyBm9bbXV9FNGxc1w qffczrTEdYGXHwt/t3TZdEbhMm08+eNzOiKr5P8jpI4rbl4c1KWS5ewW8wWoI4C8 xcVWraIq3pF8H1xIaSNiQv6Hcsklmt7gTQhBAta4WdTJM/z/TbfMHLT/zrrRHYGS dsEMdd4Zmt2GvlljZa0+8ML1RraQh92/SiLjMdejof1Ni98e9KHoWSuHtlfY590= =ZnYV -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - cui/source i18npool/source sc/source svl/inc svl/source
cui/source/tabpages/numfmt.cxx|9 + i18npool/source/localedata/data/en_GB.xml |6 ++ i18npool/source/localedata/data/en_US.xml |6 ++ sc/source/core/tool/cellform.cxx |6 +++--- sc/source/ui/view/output2.cxx |6 +++--- svl/inc/svl/zforlist.hxx |4 ++-- svl/source/numbers/zforlist.cxx | 14 -- svl/source/numbers/zformat.cxx|6 +++--- 8 files changed, 40 insertions(+), 17 deletions(-) New commits: commit 84c54990c0dbd3385a4a653afe63d0fa7b1c435b Author: Johann Messner johann.mess...@jku.at Date: Tue Aug 28 11:08:58 2012 +0100 add some built in number formats for fill in character support in Calc Change-Id: Ib70b737af3628c77a72b6b8e9267ad31890597c8 diff --git a/i18npool/source/localedata/data/en_GB.xml b/i18npool/source/localedata/data/en_GB.xml index 8f23482..02ec91d 100644 --- a/i18npool/source/localedata/data/en_GB.xml +++ b/i18npool/source/localedata/data/en_GB.xml @@ -187,6 +187,12 @@ FormatElement msgid=CurrencyFormatskey6 default=false type=medium usage=CURRENCY formatindex=17 FormatCode[CURRENCY]#,##0.--;[RED]-[CURRENCY]#,##0.--/FormatCode /FormatElement +FormatElement msgid=CurrencyFormatskey7 default=false type=short usage=CURRENCY formatindex=72 + FormatCode[CURRENCY]* #,##0;-[CURRENCY]* #,##0/FormatCode +/FormatElement +FormatElement msgid=CurrencyFormatskey8 default=false type=medium usage=CURRENCY formatindex=73 + FormatCode[CURRENCY]* #,##0.00;-[CURRENCY]* #,##0.00/FormatCode +/FormatElement FormatElement msgid=PercentFormatskey1 default=true type=short usage=PERCENT_NUMBER formatindex=8 FormatCode0%/FormatCode /FormatElement diff --git a/i18npool/source/localedata/data/en_US.xml b/i18npool/source/localedata/data/en_US.xml index f3172bf..69f4939 100644 --- a/i18npool/source/localedata/data/en_US.xml +++ b/i18npool/source/localedata/data/en_US.xml @@ -107,6 +107,12 @@ FormatElement msgid=CurrencyFormatskey6 default=false type=medium usage=CURRENCY formatindex=17 FormatCode[CURRENCY]#,##0.--;[RED]-[CURRENCY]#,##0.--/FormatCode /FormatElement +FormatElement msgid=CurrencyFormatskey7 default=false type=short usage=CURRENCY formatindex=72 + FormatCode[CURRENCY]* #,##0;-[CURRENCY]* #,##0/FormatCode +/FormatElement +FormatElement msgid=CurrencyFormatskey8 default=false type=medium usage=CURRENCY formatindex=73 + FormatCode[CURRENCY]* #,##0.00;-[CURRENCY]* #,##0.00/FormatCode +/FormatElement FormatElement msgid=DateFormatskey1 default=true type=short usage=DATE formatindex=18 FormatCodeM/D/YY/FormatCode /FormatElement commit f727644ad18838a78525256623a33f864fe13fb2 Author: Johann Messner johann.mess...@jku.at Date: Tue Aug 28 10:51:15 2012 +0100 tweaking the fill in character support in Calc Number Format Strings a) changed ordering of repeat code marker ( 0x1b ) and repeat code to more sensible ( and correct imo ) order b) prevent some possible div/0 errors c) added some missing formatter 'GetOutputString' calls diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx index c603726..855cc90 100644 --- a/cui/source/tabpages/numfmt.cxx +++ b/cui/source/tabpages/numfmt.cxx @@ -132,8 +132,7 @@ void SvxNumberPreviewImpl::NotifyChange( const String rPrevStr, mnPos = aPrevStr.Search( 0x1B ); if ( mnPos != STRING_NOTFOUND ) { ---mnPos; -mnChar = aPrevStr.GetChar( mnPos ); +mnChar = aPrevStr.GetChar( mnPos + 1 ); // delete placeholder and char to repeat aPrevStr.Erase( mnPos, 2 ); } @@ -168,9 +167,11 @@ void SvxNumberPreviewImpl::Paint( const Rectangle ) if ( mnPos != STRING_NOTFOUND ) { long nCharWidth = GetTextWidth( rtl::OUString::valueOf( mnChar ) ); -int nNumCharsToInsert = nLeadSpace / nCharWidth; -if ( nNumCharsToInsert ) +int nNumCharsToInsert = 0; +if (nCharWidth 0) nNumCharsToInsert = nLeadSpace / nCharWidth; + +if ( nNumCharsToInsert 0) { for ( int i = 0; i nNumCharsToInsert; ++i ) aTmpStr.Insert( mnChar, mnPos ); diff --git a/sc/source/core/tool/cellform.cxx b/sc/source/core/tool/cellform.cxx index 5fdd0d2..93f71fb 100644 --- a/sc/source/core/tool/cellform.cxx +++ b/sc/source/core/tool/cellform.cxx @@ -63,7 +63,7 @@ void ScCellFormat::GetString( ScBaseCell* pCell, sal_uLong nFormat, rtl::OUStrin case CELLTYPE_STRING: { rtl::OUString aCellString = ((ScStringCell*)pCell)-GetString(); -rFormatter.GetOutputString( aCellString, nFormat, rString, ppColor ); +rFormatter.GetOutputString( aCellString, nFormat, rString, ppColor, bUseStarFormat ); } break; case CELLTYPE_EDIT: @@ -135,12 +135,12 @@ void
[PATCH] Change in core[libreoffice-3-6]: fdo#52052 fix RTF import of page breaks on landscape pages
From Miklos Vajna vmik...@suse.cz: Miklos Vajna has uploaded a new change for review. Change subject: fdo#52052 fix RTF import of page breaks on landscape pages .. fdo#52052 fix RTF import of page breaks on landscape pages The problem was that we tried to insert a page break before reaching the first section break, where section properties are sent. Additionally, the continuous section break at the end of the doc caused trouble, so ignore it explicitly. (cherry picked from commit 1efa576ef88141c4deb5da9818537e053dc6517b) Change-Id: I22bc355994991beeadb41d26b44ce3e2beedbdb2 --- M writerfilter/source/rtftok/rtfdocumentimpl.cxx M writerfilter/source/rtftok/rtfdocumentimpl.hxx 2 files changed, 48 insertions(+), 6 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/497/1 -- To view, visit https://gerrit.libreoffice.org/497 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I22bc355994991beeadb41d26b44ce3e2beedbdb2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: PATCH (tweaking the fill in character support in Calc Number Format Strings)
On 27/08/12 15:29, Johann Messner wrote: Now, I am wound up to a high pitch ... I am looking forward to a binary LO release in the future featuring the fill in character Cell format specifier ;-))) thanks once again for your nice patches, you can see them http://cgit.freedesktop.org/libreoffice/core/commit/?id=f727644ad18838a78525256623a33f864fe13fb2 http://cgit.freedesktop.org/libreoffice/core/commit/?id=84c54990c0dbd3385a4a653afe63d0fa7b1c435b thanks again also to Eike who reviewed also. also I added your details ( and license attribution ) here https://wiki.documentfoundation.org/Development/Developers#First_name_from_G_to_N Look forward to the next patch from you ( please see details https://wiki.documentfoundation.org/Development#Preparing_patches on the preferred methods of sharing patches with us ) thanks again, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: writerfilter/source
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 16 - writerfilter/source/rtftok/rtfdocumentimpl.hxx |4 --- writerfilter/source/rtftok/rtftokenizer.cxx| 30 +++-- writerfilter/source/rtftok/rtftokenizer.hxx|8 ++ 4 files changed, 36 insertions(+), 22 deletions(-) New commits: commit b6c18e3bc78724e65c78577c6e513f894c4e93b4 Author: Miklos Vajna vmik...@suse.cz Date: Tue Aug 28 12:57:55 2012 +0200 Move group handling from RTFDocumentImpl to RTFTokenizer This is one step towards hiding the RTFDocument implementation from RTFTokenizer. Change-Id: Ief35a2440cac3147495675d344e1efc64f5fbc2e diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 330c34d..bd72dd6 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -232,7 +232,6 @@ RTFDocumentImpl::RTFDocumentImpl(uno::Referenceuno::XComponentContext const x m_xDstDoc(xDstDoc), m_xFrame(xFrame), m_xStatusIndicator(xStatusIndicator), -m_nGroup(0), m_aDefaultState(this), m_bSkipUnknown(false), m_aFontEncodings(), @@ -3203,7 +3202,7 @@ int RTFDocumentImpl::dispatchToggle(RTFKeyword nKeyword, bool bParam, int nParam int RTFDocumentImpl::pushState() { -//SAL_INFO(writerfilter, OSL_THIS_FUNC before push: m_nGroup); +//SAL_INFO(writerfilter, OSL_THIS_FUNC before push: m_pTokenizer-getGroup()); checkUnicode(); m_nGroupStartPos = Strm().Tell(); @@ -3219,7 +3218,7 @@ int RTFDocumentImpl::pushState() m_aStates.push(aState); m_aStates.top().aDestinationText.setLength(0); -m_nGroup++; +m_pTokenizer-pushGroup(); switch (m_aStates.top().nDestinationState) { @@ -3297,7 +3296,7 @@ void RTFDocumentImpl::resetAttributes() int RTFDocumentImpl::popState() { -//SAL_INFO(writerfilter, OSL_THIS_FUNC before pop: m_nGroup m_nGroup +//SAL_INFO(writerfilter, OSL_THIS_FUNC before pop: m_pTokenizer-getGroup() m_pTokenizer-getGroup() // , dest state: m_aStates.top().nDestinationState); checkUnicode(); @@ -3756,7 +3755,7 @@ int RTFDocumentImpl::popState() } // This is the end of the doc, see if we need to close the last section. -if (m_nGroup == 1 !m_bFirstRun) +if (m_pTokenizer-getGroup() == 1 !m_bFirstRun) { m_bDeferredContSectBreak = false; sectBreak(true); @@ -3764,7 +3763,7 @@ int RTFDocumentImpl::popState() m_aStates.pop(); -m_nGroup--; +m_pTokenizer-popGroup(); // list table if (aState.nDestinationState == DESTINATION_LISTENTRY) @@ -3935,11 +3934,6 @@ RTFParserState RTFDocumentImpl::getState() return m_aStates.top(); } -int RTFDocumentImpl::getGroup() const -{ -return m_nGroup; -} - void RTFDocumentImpl::setDestinationText(OUString rString) { m_aStates.top().aDestinationText.setLength(0); diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.hxx b/writerfilter/source/rtftok/rtfdocumentimpl.hxx index e3120b7..e2a5aa6 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.hxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.hxx @@ -424,8 +424,6 @@ namespace writerfilter { void seek(sal_uInt32 nPos); uno::Referencelang::XMultiServiceFactory getModelFactory(); RTFParserState getState(); -/// Number of states on the stack. -int getGroup() const; void setDestinationText(rtl::OUString rString); /// Resolve a picture: If not inline, then anchored. int resolvePict(bool bInline); @@ -493,8 +491,6 @@ namespace writerfilter { Stream* m_pMapperStream; boost::shared_ptrRTFSdrImport m_pSdrImport; boost::shared_ptrRTFTokenizer m_pTokenizer; -/// Same as m_aStates.size(), except that this can be negative for invalid input. -int m_nGroup; std::stackRTFParserState m_aStates; /// Read by RTF_PARD. RTFParserState m_aDefaultState; diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx b/writerfilter/source/rtftok/rtftokenizer.cxx index abe8cff..3e7a750 100644 --- a/writerfilter/source/rtftok/rtftokenizer.cxx +++ b/writerfilter/source/rtftok/rtftokenizer.cxx @@ -46,7 +46,8 @@ RTFTokenizer::RTFTokenizer(RTFDocumentImpl rImport, SvStream* pInStream, uno::R : m_rImport(rImport), m_pInStream(pInStream), m_xStatusIndicator(xStatusIndicator), -m_aRTFControlWords(std::vectorRTFSymbol(aRTFControlWords, aRTFControlWords + nRTFControlWords)) +m_aRTFControlWords(std::vectorRTFSymbol(aRTFControlWords, aRTFControlWords + nRTFControlWords)), +m_nGroup(0) { std::sort(m_aRTFControlWords.begin(), m_aRTFControlWords.end()); } @@ -93,9 +94,9 @@ int
[Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|RESOLVED|CLOSED CC||b...@eikota.de --- Comment #261 from Roman Eisele b...@eikota.de 2012-08-28 11:04:41 UTC --- Set status to CLOSED/FIXED, in order to make it really obvious (especially for beginners) that no more bugs should be added to this tracking bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: i18npool/source
i18npool/source/localedata/data/hr_HR.xml |1 + 1 file changed, 1 insertion(+) New commits: commit c2b40d6fa57e0176d52ec4ac0565de352064c661 Author: Eike Rathke er...@redhat.com Date: Tue Aug 28 13:35:53 2012 +0200 fdo#52240 added D.M date acceptance pattern to [hr-HR] Change-Id: I682bd186b571973acbe98a00af7f6a83ce83e9d4 diff --git a/i18npool/source/localedata/data/hr_HR.xml b/i18npool/source/localedata/data/hr_HR.xml index 53f7417..75f497b 100644 --- a/i18npool/source/localedata/data/hr_HR.xml +++ b/i18npool/source/localedata/data/hr_HR.xml @@ -52,6 +52,7 @@ MeasurementSystemMetric/MeasurementSystem /LC_CTYPE LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$kn-41A] +DateAcceptancePatternD.M/DateAcceptancePattern FormatElement msgid=DateFormatskey1 default=false type=medium usage=DATE formatindex=34 FormatCodeMM.YY/FormatCode /FormatElement ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/unx
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 17 + vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 14 ++ 2 files changed, 27 insertions(+), 4 deletions(-) New commits: commit 58d757fd295d48bcd2eef51c2f41f5014c1cda21 Author: Ivan Timofeev timofeev@gmail.com Date: Tue Aug 28 14:58:34 2012 +0400 gtk: sumulate native insensitivity of scrollbar buttons Change-Id: I13ac2c43aadd494389586166771b1d0e6bfb9ea6 diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx index f28cb0a..011e755 100644 --- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx @@ -1948,11 +1948,17 @@ sal_Bool GtkSalGraphics::NWPaintGTKScrollbar( ControlType, ControlPart nPart, GTK_WIDGET(scrollbarWidget)-allocation.width = w; GTK_WIDGET(scrollbarWidget)-allocation.height = h; +bool backwardButtonInsensitive = +pScrollbarVal-mnCur == pScrollbarVal-mnMin; +bool forwardButtonInsensitive = pScrollbarVal-mnMax == 0 || +pScrollbarVal-mnCur + pScrollbarVal-mnVisibleSize = pScrollbarVal-mnMax; + // - BUTTON 1 // if ( has_backward ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton1State, stateType, shadowType ); -if ( stateType == GTK_STATE_INSENSITIVE )stateType = GTK_STATE_NORMAL; +if ( backwardButtonInsensitive ) +stateType = GTK_STATE_INSENSITIVE; gtk_paint_box( style, gdkDrawable, stateType, shadowType, gdkRect, GTK_WIDGET(scrollbarWidget), scrollbarTag, x+hShim+button11BoundRect.Left(), y+vShim+button11BoundRect.Top(), @@ -1967,7 +1973,8 @@ sal_Bool GtkSalGraphics::NWPaintGTKScrollbar( ControlType, ControlPart nPart, if ( has_forward2 ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton2State, stateType, shadowType ); -if ( stateType == GTK_STATE_INSENSITIVE )stateType = GTK_STATE_NORMAL; +if ( forwardButtonInsensitive ) +stateType = GTK_STATE_INSENSITIVE; gtk_paint_box( style, gdkDrawable, stateType, shadowType, gdkRect, GTK_WIDGET(scrollbarWidget), scrollbarTag, x+hShim+button12BoundRect.Left(), y+vShim+button12BoundRect.Top(), @@ -1983,7 +1990,8 @@ sal_Bool GtkSalGraphics::NWPaintGTKScrollbar( ControlType, ControlPart nPart, if ( has_backward2 ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton1State, stateType, shadowType ); -if ( stateType == GTK_STATE_INSENSITIVE )stateType = GTK_STATE_NORMAL; +if ( backwardButtonInsensitive ) +stateType = GTK_STATE_INSENSITIVE; gtk_paint_box( style, gdkDrawable, stateType, shadowType, gdkRect, GTK_WIDGET(scrollbarWidget), scrollbarTag, x+hShim+button21BoundRect.Left(), y+vShim+button21BoundRect.Top(), @@ -1998,7 +2006,8 @@ sal_Bool GtkSalGraphics::NWPaintGTKScrollbar( ControlType, ControlPart nPart, if ( has_forward ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton2State, stateType, shadowType ); -if ( stateType == GTK_STATE_INSENSITIVE )stateType = GTK_STATE_NORMAL; +if ( forwardButtonInsensitive ) +stateType = GTK_STATE_INSENSITIVE; gtk_paint_box( style, gdkDrawable, stateType, shadowType, gdkRect, GTK_WIDGET(scrollbarWidget), scrollbarTag, x+hShim+button22BoundRect.Left(), y+vShim+button22BoundRect.Top(), diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx index 45e8977..0774699 100644 --- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx @@ -431,10 +431,18 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext *context, gtk_style_context_restore(context); } + +bool backwardButtonInsensitive = +pScrollbarVal-mnCur == pScrollbarVal-mnMin; +bool forwardButtonInsensitive = pScrollbarVal-mnMax == 0 || +pScrollbarVal-mnCur + pScrollbarVal-mnVisibleSize = pScrollbarVal-mnMax; + // - BUTTON 1 // if ( has_backward ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton1State, stateFlags, shadowType ); +if ( backwardButtonInsensitive ) +stateFlags = GTK_STATE_FLAG_INSENSITIVE; gtk_style_context_save(context); gtk_style_context_set_state(context, stateFlags); @@ -459,6 +467,8 @@ void GtkSalGraphics::PaintScrollbar(GtkStyleContext *context, if ( has_forward2 ) { NWConvertVCLStateToGTKState( pScrollbarVal-mnButton2State, stateFlags, shadowType ); +if ( forwardButtonInsensitive ) +stateFlags = GTK_STATE_FLAG_INSENSITIVE; gtk_style_context_save(context);
[Libreoffice-commits] .: wizards/com wizards/source
wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java |9 wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.java| 52 ++ wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.java | 16 wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.java | 79 +++- wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.java | 22 + wizards/com/sun/star/wizards/report/ReportLayouter.java | 18 wizards/com/sun/star/wizards/report/ReportTextImplementation.java| 132 ++ wizards/com/sun/star/wizards/report/ReportWizard.java|4 wizards/source/formwizard/dbwizres.src | 191 +- 9 files changed, 505 insertions(+), 18 deletions(-) New commits: commit 5eb16c1cf277a8a3514e81e64b211a2e4f4c7a8f Author: Istvan Turi turipi...@freemail.hu Date: Tue Aug 28 13:38:40 2012 +0200 fixes to new template localization code * Crash when launching the Report Builder is now fixed. * Added listbox localized templates to fax, report and letter wizard. * Made some optimalization with the template path search. Change-Id: Ie3f91fea301427b15891411c0192f9217b39ecae diff --git a/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java b/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java index 6cdcde5..5374f58 100644 --- a/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java +++ b/wizards/com/sun/star/wizards/agenda/AgendaWizardDialogImpl.java @@ -50,6 +50,9 @@ import com.sun.star.wizards.ui.event.DataAware; import com.sun.star.wizards.ui.event.RadioDataAware; import com.sun.star.wizards.ui.event.UnoDataAware; +import com.sun.star.beans.XPropertySet; +import com.sun.star.uno.XInterface; + /** * This class is the dialog implementation class - * there is not much business logic here - but mostley @@ -202,10 +205,8 @@ public class AgendaWizardDialogImpl extends AgendaWizardDialog private void initializePaths() { try { -sTemplatePath = FileAccess.getOfficePath(xMSF, Template, share, /wizard); sUserTemplatePath = FileAccess.getOfficePath(xMSF, Template, user, PropertyNames.EMPTY_STRING); sBitmapPath = FileAccess.combinePaths(xMSF, sTemplatePath, /../wizard/bitmap); -sTemplatePath = FileAccess.combinePaths(xMSF, sTemplatePath, /../common); } catch (NoValidPathException e) { e.printStackTrace(); } @@ -305,7 +306,9 @@ public class AgendaWizardDialogImpl extends AgendaWizardDialog */ public boolean initializeTemplates() { try { -String sTemplatePath = FileAccess.getOfficePath(xMSF, Template, share, /wizard); +XInterface xPathInterface = (XInterface) xMSF.createInstance(com.sun.star.util.PathSettings); +XPropertySet xPropertySet = UnoRuntime.queryInterface(XPropertySet.class, xPathInterface); +sTemplatePath = ((String[]) xPropertySet.getPropertyValue(Template_user))[0]; //sCurrentNorm = Norms[getCurrentLetter().cp_Norm]; String sAgendaPath = FileAccess.combinePaths(xMSF, sTemplatePath, /../common/wizard/agenda ); diff --git a/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.java b/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.java index 88b8283..43e9c5a 100644 --- a/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.java +++ b/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.java @@ -65,6 +65,8 @@ import com.sun.star.wizards.common.TextElement; import com.sun.star.wizards.common.PlaceholderTextElement; import java.util.List; +import com.sun.star.beans.XPropertySet; +import com.sun.star.uno.XInterface; public class FaxWizardDialogImpl extends FaxWizardDialog { @@ -461,6 +463,45 @@ public class FaxWizardDialogImpl extends FaxWizardDialog } +private void exchangeTitlesToLocalizedOnes() +{ + for(int i = 0; i BusinessFiles[0].length; ++i) + { +if( BusinessFiles[0][i].equals(Classic Fax) ) +{ + BusinessFiles[0][i] = resources.resBusinessFaxClassic; +} +else if( BusinessFiles[0][i].equals(Classic Fax from Private) ) +{ + BusinessFiles[0][i] = resources.resBusinessFaxClassicPrivate; +} +else if( BusinessFiles[0][i].equals(Modern Fax) ) +{ + BusinessFiles[0][i] = resources.resBusinessFaxModern; +} +else if( BusinessFiles[0][i].equals(Modern Fax from Private) ) +{ + BusinessFiles[0][i] = resources.resBusinessFaxModernPrivate; +} + } + + for(int i = 0; i PrivateFiles[0].length; ++i) + { +if( PrivateFiles[0][i].equals(Bottle) ) +{ + PrivateFiles[0][i] = resources.resPrivateFaxBottle; +} +else if( PrivateFiles[0][i].equals(Lines) ) +{ + PrivateFiles[0][i] = resources.resPrivateFaxLines;
[PATCH] Change in core[libreoffice-3-6]: fdo#52240 added D.M date acceptance pattern to [hr-HR]
From Eike Rathke er...@redhat.com: Eike Rathke has uploaded a new change for review. Change subject: fdo#52240 added D.M date acceptance pattern to [hr-HR] .. fdo#52240 added D.M date acceptance pattern to [hr-HR] Change-Id: I682bd186b571973acbe98a00af7f6a83ce83e9d4 --- M i18npool/source/localedata/data/hr_HR.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/498/1 -- To view, visit https://gerrit.libreoffice.org/498 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I682bd186b571973acbe98a00af7f6a83ce83e9d4 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Eike Rathke er...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - i18npool/qa i18npool/source package/source
i18npool/qa/cppunit/test_breakiterator.cxx | 40 i18npool/source/breakiterator/data/README |8 - package/source/zipapi/XUnbufferedStream.cxx |4 ++ 3 files changed, 45 insertions(+), 7 deletions(-) New commits: commit e2f3312ea2e547fbca7e131ed7824b1de4573b43 Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 28 13:05:47 2012 +0100 throw earlier on broken zip streams Change-Id: I0de705b4c6a9176e98baed21b2cd960d4d091563 diff --git a/package/source/zipapi/XUnbufferedStream.cxx b/package/source/zipapi/XUnbufferedStream.cxx index 9f289ba..d028c14 100644 --- a/package/source/zipapi/XUnbufferedStream.cxx +++ b/package/source/zipapi/XUnbufferedStream.cxx @@ -78,6 +78,10 @@ XUnbufferedStream::XUnbufferedStream( mnZipSize = maEntry.nSize; mnZipEnd = maEntry.nMethod == DEFLATED ? maEntry.nOffset + maEntry.nCompressedSize : maEntry.nOffset + maEntry.nSize; } + +if (mnZipSize 0) +throw ZipIOException(OUString(The stream seems to be broken!), uno::Reference XInterface ()); + sal_Bool bHaveEncryptData = ( rData.is() rData-m_aSalt.getLength() rData-m_aInitVector.getLength() rData-m_nIterationCount != 0 ) ? sal_True : sal_False; sal_Bool bMustDecrypt = ( nStreamMode == UNBUFF_STREAM_DATA bHaveEncryptData bIsEncrypted ) ? sal_True : sal_False; commit 8c205bfccdf625d70cfc9fcf617f89548c1521b1 Author: Caolán McNamara caol...@redhat.com Date: Tue Aug 28 12:14:15 2012 +0100 Related: #i58513# add regression test for Finnish break iterator rules Change-Id: I5b8c1190db08f781143fd8d12b007dc05a4d6046 diff --git a/i18npool/qa/cppunit/test_breakiterator.cxx b/i18npool/qa/cppunit/test_breakiterator.cxx index e03fbe4..52dc05f 100644 --- a/i18npool/qa/cppunit/test_breakiterator.cxx +++ b/i18npool/qa/cppunit/test_breakiterator.cxx @@ -487,6 +487,46 @@ void TestBreakIterator::testWordBoundaries() while (nPos++ aTest.getLength()); CPPUNIT_ASSERT(i == SAL_N_ELEMENTS(aExpected)); } + +//See https://issues.apache.org/ooo/show_bug.cgi?id=58513 +{ +aLocale.Language = fi; +aLocale.Country = FI; + +rtl::OUString aTest(Kuorma-auto kaakkois- ja Keski-Suomi); + +{ +sal_Int32 nPos = 0; +sal_Int32 aExpected[] = {12, 22, 25, 36}; +size_t i = 0; +do +{ +CPPUNIT_ASSERT(i SAL_N_ELEMENTS(aExpected)); +nPos = m_xBreak-getWordBoundary(aTest, nPos, aLocale, +i18n::WordType::WORD_COUNT, true).endPos; +CPPUNIT_ASSERT(aExpected[i++] == nPos); +} +while (nPos++ aTest.getLength()); +CPPUNIT_ASSERT(i == SAL_N_ELEMENTS(aExpected)); +} + +{ +sal_Int32 nPos = 0; +sal_Int32 aExpected[] = {0, 11, 12, 21, 22, 24, 25, 36}; +size_t i = 0; +do +{ +CPPUNIT_ASSERT(i SAL_N_ELEMENTS(aExpected)); +aBounds = m_xBreak-getWordBoundary(aTest, nPos, aLocale, +i18n::WordType::DICTIONARY_WORD, true); +CPPUNIT_ASSERT(aExpected[i++] == aBounds.startPos); +CPPUNIT_ASSERT(aExpected[i++] == aBounds.endPos); +nPos = aBounds.endPos; +} +while (nPos++ aTest.getLength()); +CPPUNIT_ASSERT(i == SAL_N_ELEMENTS(aExpected)); +} +} } //See http://qa.openoffice.org/issues/show_bug.cgi?id=52 diff --git a/i18npool/source/breakiterator/data/README b/i18npool/source/breakiterator/data/README index e50b061..7d67cf0 100644 --- a/i18npool/source/breakiterator/data/README +++ b/i18npool/source/breakiterator/data/README @@ -354,13 +354,6 @@ Date: Tue Oct 24 12:53:13 2006 + INTEGRATION: CWS tl29 (1.12.24); FILE MERGED 2006/09/20 01:24:53 khong 1.12.24.1: #i69482# fixed mismatch of nextWord and getWordBoundary -commit be43820c99d96a9e03e2ec5871f6259283b53b58 -Author: Rüdiger Timm r...@openoffice.org -Date: Thu May 4 08:11:17 2006 + - -INTEGRATION: CWS locales203 (1.1.2); FILE ADDED -2006/04/25 22:47:02 khong 1.1.2.1: #i58513 add break iterator rules for Finish - commit 97d89862a2285071202cc8010d888ffcbf96279a Author: Jens-Heiner Rechtien h...@openoffice.org Date: Thu Nov 17 19:30:35 2005 + @@ -592,6 +585,7 @@ Date: Mon Mar 8 16:17:05 2004 + done, regression tests added: +#i58513# add break iterator rules for Finish #i19716# fix wrong line break on bracket characters #i21290# extend Greek script type #i21907# fix isBeginWord and isEndWord problem ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||afriza...@gmail.com, ||carlo.str...@tiscali.it, ||c...@nouenoff.nl, ||courrier.oou.fr.mjk@googlem ||ail.com, ||jbf.fa...@orange.fr, ||karlsen-ma...@dfn-cert.de, ||libreoffice@lists.freedeskt ||op.org, ||michael.me...@novell.com, ||mihh...@gmail.com, ||mikeyy@gmail.com CC||serval2...@yahoo.fr, ||thard...@suse.de, ||vitriol_vitr...@katamail.co ||m --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-08-28 13:08:08 UTC --- I added all who were in CC for Bug 6 - LibreOffice 3.6 most annoying bugs to CC here, please feel free to remove yourself if you do not want to get info concerning latest 3.7 MAB. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek pmla...@suse.cz changed: What|Removed |Added Depends on||48828 --- Comment #359 from Petr Mladek pmla...@suse.cz 2012-08-28 13:11:26 UTC --- (In reply to comment #358) I'd like to nominate a href=https://bugs.freedesktop.org/show_bug.cgi?id=48828;Bug 48828/a as it actually corrupts document content. This was still an issue with 3.5.5 and is also an issue with 3.6.0 added -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change Calc templates fonts
From Olivier Hallot olivier.hal...@alta.org.br: Olivier Hallot has uploaded a new change for review. Change subject: Change Calc templates fonts .. Change Calc templates fonts Replace non free fonts from Calc templates with open, LibreOffice-packaged fonts. Albany - Liberation Sans Thorndale - Liberation Serif Cumberland - liberation Mono Imprint MT Shadow - Linux Libertine G Sheffield - Liberation Sans Change-Id: I52946adf884f360e8a2359db65a58fd4d4269293 --- M extras/source/templates/wizard/styles/black_white.ots M extras/source/templates/wizard/styles/blackberry.ots M extras/source/templates/wizard/styles/default.ots M extras/source/templates/wizard/styles/diner.ots M extras/source/templates/wizard/styles/fall.ots M extras/source/templates/wizard/styles/glacier.ots M extras/source/templates/wizard/styles/green_grapes.ots M extras/source/templates/wizard/styles/jeans.ots M extras/source/templates/wizard/styles/marine.ots M extras/source/templates/wizard/styles/millennium.ots M extras/source/templates/wizard/styles/nature.ots M extras/source/templates/wizard/styles/neon.ots M extras/source/templates/wizard/styles/night.ots M extras/source/templates/wizard/styles/nostalgic.ots M extras/source/templates/wizard/styles/pastell.ots M extras/source/templates/wizard/styles/pool.ots M extras/source/templates/wizard/styles/pumpkin.ots M extras/source/templates/wizard/styles/xos.ots 18 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/499/1 -- To view, visit https://gerrit.libreoffice.org/499 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I52946adf884f360e8a2359db65a58fd4d4269293 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Olivier Hallot olivier.hal...@alta.org.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: localize spreadsheet style template names runtime
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Andras Em 28-08-2012 06:08, Andras Timar escreveu: Hi Olivier, 2012/8/26 Olivier Hallot olivier.hal...@documentfoundation.org: (and, while we are there, shouldn't we use open fonts?) Yes, we should. If I remember correctly you did it for other templates, so feel free to fix these, too. Also, the internal name of xos.ots (Be) could be changed. I think it refers to the colors of BeOS, an alternative operating system from 90s, but hardly anyone remembers that. Thanks, Andras Fonts changed. - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQPMVCAAoJEJp3R7nH3vLxTG4IAJsmP0af3Hj/diV7IuTk6Aqg r4G2suDSjr0+Dd3QxLzMVeMZ7G7NuFk9Gf5fRfyV3kYS3aOCqoujlmgTa1Gyi/sI DeLW7a3FuFk9jHQi+Zwc9DOOViVbszTtR9Ft3mb+mZYorAlycTZuWC9Xnz7HcrpH +Wdi5u8+zTCzNo/gKNwIMQ7QAe031094QEpo00W72i1PPR+xsAprcuiVCOE5i1DZ dwi4AgaNE8jKEKGN4mC7s6X3XwrcWTs6HcqPqtSm+zCttlSS9A6MHtC0XLK14Rmr z4Iis+COl+pVAeGG/oncF3ofLXNQsTUPif+vRkM7Dt7bHcOM4zQZ+hHt64lbPVE= =fGOI -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: extras/source
extras/source/templates/wizard/styles/black_white.ots |binary extras/source/templates/wizard/styles/blackberry.ots |binary extras/source/templates/wizard/styles/default.ots |binary extras/source/templates/wizard/styles/diner.ots|binary extras/source/templates/wizard/styles/fall.ots |binary extras/source/templates/wizard/styles/glacier.ots |binary extras/source/templates/wizard/styles/green_grapes.ots |binary extras/source/templates/wizard/styles/jeans.ots|binary extras/source/templates/wizard/styles/marine.ots |binary extras/source/templates/wizard/styles/millennium.ots |binary extras/source/templates/wizard/styles/nature.ots |binary extras/source/templates/wizard/styles/neon.ots |binary extras/source/templates/wizard/styles/night.ots|binary extras/source/templates/wizard/styles/nostalgic.ots|binary extras/source/templates/wizard/styles/pastell.ots |binary extras/source/templates/wizard/styles/pool.ots |binary extras/source/templates/wizard/styles/pumpkin.ots |binary extras/source/templates/wizard/styles/xos.ots |binary 18 files changed New commits: commit f0b7b2e30f493c1aa9881d25d6812225bd658708 Author: Olivier Hallot olivier.hal...@alta.org.br Date: Tue Aug 28 10:07:42 2012 -0300 Change Calc templates fonts Replace non free fonts from Calc templates with open, LibreOffice-packaged fonts. Albany - Liberation Sans Thorndale - Liberation Serif Cumberland - liberation Mono Imprint MT Shadow - Linux Libertine G Sheffield - Liberation Sans Change-Id: I52946adf884f360e8a2359db65a58fd4d4269293 Reviewed-on: https://gerrit.libreoffice.org/499 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com diff --git a/extras/source/templates/wizard/styles/black_white.ots b/extras/source/templates/wizard/styles/black_white.ots index 5ae085a..0d2e5df 100644 Binary files a/extras/source/templates/wizard/styles/black_white.ots and b/extras/source/templates/wizard/styles/black_white.ots differ diff --git a/extras/source/templates/wizard/styles/blackberry.ots b/extras/source/templates/wizard/styles/blackberry.ots index 05254b7..65d8a0a 100644 Binary files a/extras/source/templates/wizard/styles/blackberry.ots and b/extras/source/templates/wizard/styles/blackberry.ots differ diff --git a/extras/source/templates/wizard/styles/default.ots b/extras/source/templates/wizard/styles/default.ots index d24f038..94d8a48 100644 Binary files a/extras/source/templates/wizard/styles/default.ots and b/extras/source/templates/wizard/styles/default.ots differ diff --git a/extras/source/templates/wizard/styles/diner.ots b/extras/source/templates/wizard/styles/diner.ots index b90c7e7..7d6a41b 100644 Binary files a/extras/source/templates/wizard/styles/diner.ots and b/extras/source/templates/wizard/styles/diner.ots differ diff --git a/extras/source/templates/wizard/styles/fall.ots b/extras/source/templates/wizard/styles/fall.ots index 1dda638..236b221 100644 Binary files a/extras/source/templates/wizard/styles/fall.ots and b/extras/source/templates/wizard/styles/fall.ots differ diff --git a/extras/source/templates/wizard/styles/glacier.ots b/extras/source/templates/wizard/styles/glacier.ots index 72956b3..c60c9d0 100644 Binary files a/extras/source/templates/wizard/styles/glacier.ots and b/extras/source/templates/wizard/styles/glacier.ots differ diff --git a/extras/source/templates/wizard/styles/green_grapes.ots b/extras/source/templates/wizard/styles/green_grapes.ots index c2eea8e..b0c9414 100644 Binary files a/extras/source/templates/wizard/styles/green_grapes.ots and b/extras/source/templates/wizard/styles/green_grapes.ots differ diff --git a/extras/source/templates/wizard/styles/jeans.ots b/extras/source/templates/wizard/styles/jeans.ots index 9d5acfc..f3c9fe4 100644 Binary files a/extras/source/templates/wizard/styles/jeans.ots and b/extras/source/templates/wizard/styles/jeans.ots differ diff --git a/extras/source/templates/wizard/styles/marine.ots b/extras/source/templates/wizard/styles/marine.ots index 9c45bf3..3c99e94 100644 Binary files a/extras/source/templates/wizard/styles/marine.ots and b/extras/source/templates/wizard/styles/marine.ots differ diff --git a/extras/source/templates/wizard/styles/millennium.ots b/extras/source/templates/wizard/styles/millennium.ots index b9c3a0b..f2f5960 100644 Binary files a/extras/source/templates/wizard/styles/millennium.ots and b/extras/source/templates/wizard/styles/millennium.ots differ diff --git a/extras/source/templates/wizard/styles/nature.ots b/extras/source/templates/wizard/styles/nature.ots index 8c5c55e..a977dfd 100644 Binary files a/extras/source/templates/wizard/styles/nature.ots and b/extras/source/templates/wizard/styles/nature.ots differ diff --git a/extras/source/templates/wizard/styles/neon.ots b/extras/source/templates/wizard/styles/neon.ots index
[PUSHED] Change Calc templates fonts
From Andras Timar ati...@suse.com: Andras Timar has submitted this change and it was merged. Change subject: Change Calc templates fonts .. Change Calc templates fonts Replace non free fonts from Calc templates with open, LibreOffice-packaged fonts. Albany - Liberation Sans Thorndale - Liberation Serif Cumberland - liberation Mono Imprint MT Shadow - Linux Libertine G Sheffield - Liberation Sans Change-Id: I52946adf884f360e8a2359db65a58fd4d4269293 --- M extras/source/templates/wizard/styles/black_white.ots M extras/source/templates/wizard/styles/blackberry.ots M extras/source/templates/wizard/styles/default.ots M extras/source/templates/wizard/styles/diner.ots M extras/source/templates/wizard/styles/fall.ots M extras/source/templates/wizard/styles/glacier.ots M extras/source/templates/wizard/styles/green_grapes.ots M extras/source/templates/wizard/styles/jeans.ots M extras/source/templates/wizard/styles/marine.ots M extras/source/templates/wizard/styles/millennium.ots M extras/source/templates/wizard/styles/nature.ots M extras/source/templates/wizard/styles/neon.ots M extras/source/templates/wizard/styles/night.ots M extras/source/templates/wizard/styles/nostalgic.ots M extras/source/templates/wizard/styles/pastell.ots M extras/source/templates/wizard/styles/pool.ots M extras/source/templates/wizard/styles/pumpkin.ots M extras/source/templates/wizard/styles/xos.ots 18 files changed, 0 insertions(+), 0 deletions(-) Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/499 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52946adf884f360e8a2359db65a58fd4d4269293 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Olivier Hallot olivier.hal...@alta.org.br Gerrit-Reviewer: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 4 commits - sc/source
sc/source/core/data/conditio.cxx |2 - sc/source/filter/xml/XMLStylesImportHelper.cxx | 33 - sc/source/filter/xml/xmlcelli.cxx | 30 +++--- 3 files changed, 16 insertions(+), 49 deletions(-) New commits: commit 309b4e24d2507a93a0825dff2a6df13859e9487e Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 28 02:59:39 2012 +0200 don't crash for invalid repaint ranges in cond formats, fdo#53839 Change-Id: I83cbb2574849c69fba3ca315d7507358654ff2b9 diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx index 1438a78..4a842fb 100644 --- a/sc/source/core/data/conditio.cxx +++ b/sc/source/core/data/conditio.cxx @@ -1123,7 +1123,7 @@ void ScConditionEntry::SourceChanged( const ScAddress rChanged ) ScRange aPaint( nCol1,nRow1,nTab1, nCol2,nRow2,nTab2 ); // kein Paint, wenn es nur die Zelle selber ist -if ( aPaint.aStart != rChanged || aPaint.aEnd != rChanged ) +if ( aPaint.IsValid() (aPaint.aStart != rChanged || aPaint.aEnd != rChanged )) DataChanged( aPaint ); } } commit fd1fad4f4228630fa244820e5f0314c5835c5333 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Aug 24 22:58:48 2012 +0200 remove some more null pointer checks before delete Change-Id: I5997f0440a8a4875e800e830df211e8108752b37 diff --git a/sc/source/filter/xml/XMLStylesImportHelper.cxx b/sc/source/filter/xml/XMLStylesImportHelper.cxx index 438ac0e..c40ba95 100644 --- a/sc/source/filter/xml/XMLStylesImportHelper.cxx +++ b/sc/source/filter/xml/XMLStylesImportHelper.cxx @@ -264,22 +264,16 @@ ScMyStylesImportHelper::ScMyStylesImportHelper(ScXMLImport rTempImport) ScMyStylesImportHelper::~ScMyStylesImportHelper() { -if (pPrevStyleName) -delete pPrevStyleName; -if (pPrevCurrency) -delete pPrevCurrency; -if (pStyleName) -delete pStyleName; -if (pCurrency) -delete pCurrency; +delete pPrevStyleName; +delete pPrevCurrency; +delete pStyleName; +delete pCurrency; } void ScMyStylesImportHelper::ResetAttributes() { -if (pPrevStyleName) -delete pPrevStyleName; -if (pPrevCurrency) -delete pPrevCurrency; +delete pPrevStyleName; +delete pPrevCurrency; pPrevStyleName = pStyleName; pPrevCurrency = pCurrency; nPrevCellType = nCellType; @@ -331,8 +325,7 @@ void ScMyStylesImportHelper::AddDefaultRange(const ScRange rRange) ScRange aRange(rRange); aRange.aStart.SetCol(nStartCol); aRange.aEnd.SetCol(i - 1); -if (pPrevStyleName) -delete pPrevStyleName; +delete pPrevStyleName; pPrevStyleName = new rtl::OUString(aPrevItr-sStyleName); AddSingleRange(aRange); nStartCol = i; @@ -343,8 +336,7 @@ void ScMyStylesImportHelper::AddDefaultRange(const ScRange rRange) { ScRange aRange(rRange); aRange.aStart.SetCol(nStartCol); -if (pPrevStyleName) -delete pPrevStyleName; +delete pPrevStyleName; pPrevStyleName = new rtl::OUString(aPrevItr-sStyleName); AddSingleRange(aRange); } @@ -360,8 +352,7 @@ void ScMyStylesImportHelper::AddDefaultRange(const ScRange rRange) } else { -if (pPrevStyleName) -delete pPrevStyleName; +delete pPrevStyleName; pPrevStyleName = new rtl::OUString(aRowDefaultStyle-sStyleName); AddSingleRange(rRange); } @@ -411,10 +402,8 @@ void ScMyStylesImportHelper::SetRowStyle(const rtl::OUString sStyleName) void ScMyStylesImportHelper::SetAttributes(rtl::OUString* pStyleNameP, rtl::OUString* pCurrencyP, const sal_Int16 nCellTypeP) { -if (this-pStyleName) -delete this-pStyleName; -if (this-pCurrency) -delete this-pCurrency; +delete this-pStyleName; +delete this-pCurrency; this-pStyleName = pStyleNameP; this-pCurrency = pCurrencyP; this-nCellType = nCellTypeP; commit 06784203728ae5c03edd2a5e311fae532c3e7a12 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Aug 24 22:55:18 2012 +0200 remove redundant function Change-Id: If082663aea3e5ed4d242997a1fdd3fd2769daf8d diff --git a/sc/source/filter/xml/xmlcelli.cxx b/sc/source/filter/xml/xmlcelli.cxx index f1e49fe..3b6ca50 100644 --- a/sc/source/filter/xml/xmlcelli.cxx +++ b/sc/source/filter/xml/xmlcelli.cxx @@ -511,25 +511,6 @@ ScValidErrorStyle validAlertToValidError( const sheet::ValidationAlertStyle eVAl return eVErrStyle; } -ScConditionMode conditionOpToMode( const sheet::ConditionOperator
[PATCH] Basic IDE: namespace basctl
From János Uray uray.ja...@gmail.com: János Uray has uploaded a new change for review. Change subject: Basic IDE: namespace basctl .. Basic IDE: namespace basctl Now all names in basctl are in namespace 'basctl'. There were lots of names that included the word 'Basic' or 'BasicIDE' in it, e.g. BasicIDEData, BasicDocumentEntry, BasicTreeListBox, BasicIDEModule, IDEBaseWindow etc. This information is now stored in the namespace name, so the names could be shortened: basctl::DocumentEntry, basctl::TreeListBox, basctl::Module, basctl::BaseWindow etc. Some other minor changes: * LibInfos, LibInfoItem, LibInfoKey - LibInfos, LibInfos::Item, LibInfos::Key * The header guards are now uniformly BASCTL_FILENAME_HXX, instead of e.g. _FILENAME_HXX, which is undefined behaviour because of the '_'. * namespace BasicIDE, BasicIDEGlobals, basicide - namespace basctl * BASICIDE_TYPE_MODULE, ... - basctl::TYPE_MODULE, ... Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b --- M basctl/inc/iderdll.hxx M basctl/sdi/baside.sdi M basctl/source/accessibility/accessibledialogcontrolshape.cxx M basctl/source/accessibility/accessibledialogwindow.cxx M basctl/source/basicide/basdoc.cxx M basctl/source/basicide/basdoc.hxx M basctl/source/basicide/basicbox.cxx M basctl/source/basicide/basicbox.hxx M basctl/source/basicide/basicmod.hxx M basctl/source/basicide/basicrenderable.cxx M basctl/source/basicide/basicrenderable.hxx M basctl/source/basicide/baside2.cxx M basctl/source/basicide/baside2.hrc M basctl/source/basicide/baside2.hxx M basctl/source/basicide/baside2b.cxx M basctl/source/basicide/baside3.cxx M basctl/source/basicide/basidectrlr.cxx M basctl/source/basicide/basides1.cxx M basctl/source/basicide/basides2.cxx M basctl/source/basicide/basides3.cxx M basctl/source/basicide/basidesh.cxx M basctl/source/basicide/basobj2.cxx M basctl/source/basicide/basobj3.cxx M basctl/source/basicide/bastype2.cxx M basctl/source/basicide/bastype2.hxx M basctl/source/basicide/bastype3.cxx M basctl/source/basicide/bastype3.hxx M basctl/source/basicide/bastypes.cxx M basctl/source/basicide/breakpoint.cxx M basctl/source/basicide/breakpoint.hxx M basctl/source/basicide/brkdlg.cxx M basctl/source/basicide/brkdlg.hrc M basctl/source/basicide/brkdlg.hxx M basctl/source/basicide/iderdll.cxx M basctl/source/basicide/iderdll2.hxx M basctl/source/basicide/idetemp.hxx M basctl/source/basicide/layout.cxx M basctl/source/basicide/layout.hxx M basctl/source/basicide/linenumberwindow.cxx M basctl/source/basicide/linenumberwindow.hxx M basctl/source/basicide/localizationmgr.cxx M basctl/source/basicide/macrodlg.cxx M basctl/source/basicide/macrodlg.hrc M basctl/source/basicide/macrodlg.hxx M basctl/source/basicide/moduldl2.cxx M basctl/source/basicide/moduldlg.cxx M basctl/source/basicide/moduldlg.hrc M basctl/source/basicide/moduldlg.hxx M basctl/source/basicide/moptions.hrc M basctl/source/basicide/objdlg.cxx M basctl/source/basicide/objdlg.hxx M basctl/source/basicide/register.cxx M basctl/source/basicide/sbxitem.cxx M basctl/source/basicide/scriptdocument.cxx M basctl/source/basicide/tbxctl.cxx M basctl/source/basicide/tbxctl.hxx M basctl/source/basicide/unomodel.cxx M basctl/source/basicide/unomodel.hxx M basctl/source/dlged/dlged.cxx M basctl/source/dlged/dlgedclip.cxx M basctl/source/dlged/dlgedfac.cxx M basctl/source/dlged/dlgedfunc.cxx M basctl/source/dlged/dlgedlist.cxx M basctl/source/dlged/dlgedmod.cxx M basctl/source/dlged/dlgedobj.cxx M basctl/source/dlged/dlgedpage.cxx M basctl/source/dlged/dlgedview.cxx M basctl/source/dlged/managelang.cxx M basctl/source/dlged/managelang.hrc M basctl/source/dlged/propbrw.cxx M basctl/source/inc/accessibledialogcontrolshape.hxx M basctl/source/inc/accessibledialogwindow.hxx M basctl/source/inc/baside3.hxx M basctl/source/inc/basidectrlr.hxx M basctl/source/inc/basidesh.hxx M basctl/source/inc/basobj.hxx M basctl/source/inc/bastypes.hxx M basctl/source/inc/dlged.hxx M basctl/source/inc/dlgedclip.hxx M basctl/source/inc/dlgeddef.hxx M basctl/source/inc/dlgedfac.hxx M basctl/source/inc/dlgedfunc.hxx M basctl/source/inc/dlgedlist.hxx M basctl/source/inc/dlgedmod.hxx M basctl/source/inc/dlgedobj.hxx M basctl/source/inc/dlgedpage.hxx M basctl/source/inc/dlgedview.hxx M basctl/source/inc/dlgresid.hrc M basctl/source/inc/iderid.hxx M basctl/source/inc/localizationmgr.hxx M basctl/source/inc/managelang.hxx M basctl/source/inc/propbrw.hxx M basctl/source/inc/sbxitem.hxx M basctl/source/inc/scriptdocument.hxx M basctl/source/inc/svheader.hxx 95 files changed, 2,308 insertions(+), 2,211 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/501/1 -- To view, visit https://gerrit.libreoffice.org/501 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2a9b493562d0d8a2510d569798fbe9e1161b7c9b Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master
[PATCH] Cleanup in Tools Options User Data
From János Uray uray.ja...@gmail.com: János Uray has uploaded a new change for review. Change subject: Cleanup in Tools Options User Data .. Cleanup in Tools Options User Data Change-Id: I4f0a0304d7dd23ed8ce011e6f8f90e170bfbe5df Cleanup in Tools Options User Data Change-Id: If89f19e22b6efeb0fdd811ff8afe2cb6c0b0bf4e --- M cui/source/inc/cuioptgenrl.hxx M cui/source/options/optgenrl.cxx M cui/source/options/optgenrl.hrc M cui/source/options/optgenrl.src M unotools/inc/unotools/useroptions.hxx M unotools/source/config/useroptions.cxx 6 files changed, 669 insertions(+), 1,733 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/500/1 -- To view, visit https://gerrit.libreoffice.org/500 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If89f19e22b6efeb0fdd811ff8afe2cb6c0b0bf4e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: János Uray uray.ja...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] java cleanup patches
On 08/27/2012 01:43 PM, Noel Grandin wrote: These patches remove various bits of dead code, and perform some mild cleanup. The change to jurt/com/sun/star/lib/uno/environments/remote/Job.java in 0006 was unsound. The rest looked good. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Higher‐resolution OpenDocument icons for Mac OS X
Hi Nicholas, I am taking the liberty to add the design list into CC here... Astron. On 27 August 2012 16:58, Nicholas Shanks nicksha...@nickshanks.com wrote: Since I am unable to compile LO, I figured I would work on the artwork a bit. I noticed that the Windows .ico files included a 256px icon, and that there were 256px icons in PNG form in the tree, yet the Mac icons were only provided up to 128px in size. So I have created revised versions of the sysui/desktop/icons/oasis-*.icns files, derived directly from the PNG files. The Mac icon format also supports 512x512 and 1024x1024 sized icons, so I have generated PNGs for these sizes and included them in the icns files. (512px is used for the iTunes‐like carousel view called Cover Flow, and 1024 is used for the same on high pixel density displays.) These additional sizes add 2MB to the Mac distribution over the icns files with just 256 added (not attached), which itself adds very little due to better compression than the files currently in the tree. The LO Mac distribution is already 640 MB so I figured another two to make it look spiffy wouldn't hurt. If anyone objects though I can re‐send with just 256 or just 512 included. If you extract the attached tape archive into the sysui/desktop/ directory everything should be placed in the correct location. I have NOT created equivalents for the OOo 1.0 and Microsoft file formats because I think LO is wrong to use identical icons for them. I will prepare new icons for all platforms which have the LibreOffice document branding (detached upper right corner and tinted thick border) but with elements that allow users to identify the file format too, so that a user can see directly from the icon that oh, this is a Microsoft Word document, but double‐clicking it will open the file in LibreOffice. I also intend to create a new extension icon, the predominant shape of which will be like the current one, but rotated 90° clockwise and with the upper right corner detached, and a thick grey border and plain white interior (no green plus). I will try to make it suck less in appearance too, using main.svg as a starting point. I also have some ideas for the main application icon (which currently looks like a blank document, not an application). I think taking the brown, yellow, green, blue and purple triangles used to identify the main document types and arranging them radially in a circle 60° apart from one another would look good. This motif would then be placed in a square, rather than a rectangle, and adhere to platform conventions for the appearance of applications, e.g. 0° for Windows, 30° for Mac Gnome, 45° for BeOS etc. Sound good? -- Nicholas. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 53839, which changed state. Bug 53839 Summary: CRASH when insert row in particular document https://bugs.freedesktop.org/show_bug.cgi?id=53839 What|Old Value |New Value Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED] java cleanup patches
On 2012-08-28 16:16, Stephan Bergmann wrote: On 08/27/2012 01:43 PM, Noel Grandin wrote: These patches remove various bits of dead code, and perform some mild cleanup. The change to jurt/com/sun/star/lib/uno/environments/remote/Job.java in 0006 was unsound. The rest looked good. Thanks. The change to Job.java was OK, because 3 lines up we had already checked the exception field for null, so it was not possible for it to be null at that point. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54157] LibreOffice 3.7 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||53872 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-08-28 14:50:44 UTC --- Add Bug 53872 - CRASH - opening database report - Regression -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - accessibility/inc accessibility/source dbaccess/source framework/source svtools/inc svtools/source svx/source
accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx | 4 - accessibility/source/extended/AccessibleBrowseBoxCheckBoxCell.cxx| 2 accessibility/source/helper/acc_factory.cxx | 5 - dbaccess/source/ui/control/TableGrantCtrl.cxx| 4 - framework/source/uielement/menubarmanager.cxx| 37 ++ svtools/inc/svtools/accessiblefactory.hxx| 1 svtools/inc/svtools/editbrowsebox.hxx| 2 svtools/source/brwbox/editbrowsebox2.cxx | 3 svtools/source/contnr/svtabbx.cxx| 2 svtools/source/misc/svtaccessiblefactory.cxx | 1 svx/source/fmcomp/gridctrl.cxx | 2 11 files changed, 45 insertions(+), 18 deletions(-) New commits: commit 9cfc64c66ff9e0f0251a006f039bf4e26a63147a Author: Stephan Bergmann sberg...@redhat.com Date: Tue Aug 28 17:07:56 2012 +0200 fdo#36149: Do not display error dialogs while showing a menu ...it apparently leads to crashes, but is probably not good from a usability perspective anyway (as the menu closes again when the dialog appears/is operated on by the user). For now, just disable the Java specific interaction handler here; might make sense to address this more generally though (there's framework::QuietInteraction btw). Change-Id: I6ae303c0084549b5339d219e158cdb89e5a6b331 diff --git a/framework/source/uielement/menubarmanager.cxx b/framework/source/uielement/menubarmanager.cxx index 26b1233..0361632 100644 --- a/framework/source/uielement/menubarmanager.cxx +++ b/framework/source/uielement/menubarmanager.cxx @@ -49,6 +49,7 @@ #include com/sun/star/container/XEnumeration.hpp #include com/sun/star/util/XStringWidth.hpp #include com/sun/star/uno/XComponentContext.hpp +#include com/sun/star/uno/XCurrentContext.hpp #include com/sun/star/lang/XMultiComponentFactory.hpp #include com/sun/star/frame/XPopupMenuController.hpp #include com/sun/star/frame/XUIControllerRegistration.hpp @@ -67,6 +68,8 @@ #include comphelper/processfactory.hxx #include comphelper/extract.hxx #include svtools/menuoptions.hxx +#include svtools/javainteractionhandler.hxx +#include uno/current_context.hxx #include unotools/historyoptions.hxx #include unotools/pathoptions.hxx #include unotools/cmdoptions.hxx @@ -800,11 +803,45 @@ static void lcl_CheckForChildren(Menu* pMenu, sal_uInt16 nItemId) // vcl handler //_ +namespace { + +class QuietInteractionContext: +public cppu::WeakImplHelper1 com::sun::star::uno::XCurrentContext , +private boost::noncopyable +{ +public: +QuietInteractionContext( +com::sun::star::uno::Reference com::sun::star::uno::XCurrentContext +const context): +context_(context) {} + +private: +virtual ~QuietInteractionContext() {} + +virtual com::sun::star::uno::Any SAL_CALL getValueByName( +rtl::OUString const Name) +throw (com::sun::star::uno::RuntimeException) +{ +return Name != JAVA_INTERACTION_HANDLER_NAME context_.is() +? context_-getValueByName(Name) +: com::sun::star::uno::Any(); +} + +com::sun::star::uno::Reference com::sun::star::uno::XCurrentContext +context_; +}; + +} + IMPL_LINK( MenuBarManager, Activate, Menu *, pMenu ) { RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, framework, ocke.jans...@sun.com, MenuBarManager::Activate ); if ( pMenu == m_pVCLMenu ) { +com::sun::star::uno::ContextLayer layer( +new QuietInteractionContext( +com::sun::star::uno::getCurrentContext())); + // set/unset hiding disabled menu entries sal_Bool bDontHide = SvtMenuOptions().IsEntryHidingEnabled(); const StyleSettings rSettings = Application::GetSettings().GetStyleSettings(); commit 7f7e0a668204678b06d711487137a9f8b13c91e1 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Aug 28 16:49:11 2012 +0200 -Werror,-Wunused-private-field (Clang towards 3.2) Change-Id: I2a181d1442ef3b41ecba009d160d2d18d6fb71ac diff --git a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx index 3106def..c0af453 100644 --- a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx +++ b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxCheckBoxCell.hxx @@ -38,7 +38,6 @@ namespace accessibility { private: TriState m_eState; -sal_Bool m_bEnabled; sal_Bool m_bIsTriState;
[PATCH] fdo#50089 UI accelerators for Table design and Slide transit...
From Samuel Mehrbrodt s.mehrbr...@gmail.com: Samuel Mehrbrodt has uploaded a new change for review. Change subject: fdo#50089 UI accelerators for Table design and Slide transition .. fdo#50089 UI accelerators for Table design and Slide transition Change-Id: I327491d113ad328baf0e18f23e71c918a1d00eca --- M sd/source/ui/animations/CustomAnimation.src M sd/source/ui/animations/SlideTransitionPane.src M sd/source/ui/table/TableDesignPane.src 3 files changed, 15 insertions(+), 15 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/502/1 -- To view, visit https://gerrit.libreoffice.org/502 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I327491d113ad328baf0e18f23e71c918a1d00eca Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Samuel Mehrbrodt s.mehrbr...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][REVIEW-3-5] fix for fdo#49255 FORMATTING: row height not preserved after FILESAVE and reopen
I never did attach the patch in question :-/ cherry-pickers welcome Noel On 24/08/12 11:24, Noel Power wrote: please excuse my old school use of the mail-list, Looking at http://wiki.documentfoundation.org/Development/gerrit/SubmitPatch Only the last line is special and will push all patches in your current branch to the review queue for the master branch (Adjust accordingly, if you want to submit a patch to one of the release branches). I read the line above as referring to the fact that 'logerrit' ( the special thing in the last line ) doesn't exist in the branch tree so adjust accordingly e.g. don't use it, things will happen automatically. So... that's what I did I pushed the patch and expected it to go to the review queue for 3.6. However I see that I have committed the patch directly to 3.6 ( reverted now. ) I wonder what you really are supposed to do, obviously I am too dumb to figure it out Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice From 9efd8deb867c89baf0f5df410b87e8310fff524b Mon Sep 17 00:00:00 2001 From: Noel Power noel.po...@suse.com Date: Fri, 24 Aug 2012 10:31:45 +0100 Subject: [PATCH] fix for fdo#49255 This patch disables row height calculations ( and uses the hard heights read from the xml instead ) The bug here partially exisits because the height calculation doesn't work correctly because the factor from ScDocShell::GetOutputFactor() has not been calculated yet ( and has a default value of 1 ) This number is used in setting up the correct nPPTX and because it isn't setup correctly the height calculated for the text is incorrect. We use EnableAdjustHeight to inhibit auto height calculations that result from various changes ( like style changes etc. ) from the start of the load and re-enabled it at the end. Change-Id: Ib6715c39b7cb5793458f15b1f0b3c9ecd16412f9 --- sc/source/filter/xml/xmlimprt.cxx |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sc/source/filter/xml/xmlimprt.cxx b/sc/source/filter/xml/xmlimprt.cxx index bf7c18b..d0234b2 100644 --- a/sc/source/filter/xml/xmlimprt.cxx +++ b/sc/source/filter/xml/xmlimprt.cxx @@ -2811,6 +2811,7 @@ throw(::com::sun::star::lang::IllegalArgumentException, ::com::sun::star::uno::R uno::Referencedocument::XActionLockable xActionLockable(xDoc, uno::UNO_QUERY); if (xActionLockable.is()) xActionLockable-addActionLock(); +pDoc-EnableAdjustHeight(false); } // XServiceInfo @@ -3105,7 +3106,6 @@ throw( ::com::sun::star::xml::sax::SAXException, ::com::sun::star::uno::RuntimeE pDoc-SetStreamValid( nTab, true ); } -aTables.UpdateRowHeights(); aTables.FixupOLEs(); } if (GetModel().is()) @@ -3120,6 +3120,7 @@ throw( ::com::sun::star::xml::sax::SAXException, ::com::sun::star::uno::RuntimeE { ScModelObj::getImplementation(GetModel())-AfterXMLLoading(true); } +pDoc-EnableAdjustHeight( true ); } // XEventListener -- 1.7.3.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sc/source
sc/source/core/data/column3.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 7a8040665f40fbcb4fa58c036aa066f061abd9ba Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 28 18:47:37 2012 +0200 prevent double delete of broadcaster, fdo#54074, fdo#53364 Change-Id: I7d94525daaeb7c8268fb10594c8a21ebcd52311c diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 861158c..00ac9fa 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -400,7 +400,10 @@ void ScColumn::DeleteRange( SCSIZE nStartIndex, SCSIZE nEndIndex, sal_uInt16 nDe bool bKeepBC = pBC pBC-HasListeners(); // #i99844# do not release broadcaster from old cell, it still has to notify deleted content if (bKeepBC) +{ pNoteCell = new ScNoteCell( pBC ); +pOldCell-ReleaseBroadcaster(); +} // remove cell entry in cell item list SCROW nOldRow = maItems[nIdx].nRow; commit 73de74bb6ecbbbc390710ddd9d6c930378cdf142 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 28 16:56:31 2012 +0200 fix indentation Change-Id: I666f130fe75bd0e0fcba54fee68b97ae153db2ef diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index 1d2e21c..861158c 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -399,8 +399,8 @@ void ScColumn::DeleteRange( SCSIZE nStartIndex, SCSIZE nEndIndex, sal_uInt16 nDe SvtBroadcaster* pBC = pOldCell-GetBroadcaster(); bool bKeepBC = pBC pBC-HasListeners(); // #i99844# do not release broadcaster from old cell, it still has to notify deleted content -if ( bKeepBC) -pNoteCell = new ScNoteCell( pBC ); +if (bKeepBC) +pNoteCell = new ScNoteCell( pBC ); // remove cell entry in cell item list SCROW nOldRow = maItems[nIdx].nRow; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[REVIEW-3-6] fix for fdo#54074, fdo#53364 and maybe for fdo#49520, don't delete broadcasters in formula cells twice
Hey, [1] fixes a serious bug in calc that happens in a formula cell with a broadcaster that has listeners is deleted. The problem is that the Broadcaster is deleted twice. Once as part of the ScFormulaCell and once as part of the ScNoteCell that is used as replacement for the ScFormulaCell. We need to release the broadcaster from ScFormulaCell because the ScNoteCell is taking over control and is only there to keep track of the Broadcaster. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=7a8040665f40fbcb4fa58c036aa066f061abd9ba ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/excel/xecontent.cxx | 27 +-- sc/source/filter/inc/xecontent.hxx |1 + 2 files changed, 26 insertions(+), 2 deletions(-) New commits: commit efc7e271384b161dcfbea0f97a3e3efc41823f16 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Aug 28 19:47:53 2012 +0200 hopefully a working version for databar ext guid creation Change-Id: Ide7261955168dc13b47b29705e22eb2c3154d24e diff --git a/sc/source/filter/excel/xecontent.cxx b/sc/source/filter/excel/xecontent.cxx index ffdaa3f..905073e 100644 --- a/sc/source/filter/excel/xecontent.cxx +++ b/sc/source/filter/excel/xecontent.cxx @@ -54,6 +54,7 @@ #include xehelper.hxx #include xestyle.hxx #include xename.hxx +#include rtl/uuid.h using namespace ::oox; @@ -1080,6 +1081,25 @@ void XclExpColorScale::SaveXml( XclExpXmlStream rStrm ) // OOXTODO: XML_extLst } +namespace { + +rtl::OString createGuidStringFromInt(sal_uInt8 nGuid[16]) +{ +rtl::OStringBuffer aBuffer; +aBuffer.append('{'); +for(size_t i = 0; i 16; ++i) +{ +aBuffer.append(static_castsal_Int32(nGuid[i]), 16); +if(i == 3|| i == 5 || i == 7 || i == 9 ) +aBuffer.append('-'); +} +aBuffer.append('}'); +rtl::OString aString = aBuffer.makeStringAndClear(); +return aString.toAsciiUpperCase(); +} + +} + XclExpDataBar::XclExpDataBar( const XclExpRoot rRoot, const ScDataBarFormat rFormat, sal_Int32 nPriority, XclExtLstRef xExtLst ): XclExpRecord(), XclExpRoot( rRoot ), @@ -1101,7 +1121,10 @@ XclExpDataBar::XclExpDataBar( const XclExpRoot rRoot, const ScDataBarFormat rF xExtLst-AddRecord( XclExpExtRef(new XclExpExtCondFormat( *xExtLst.get() )) ); pParent = xExtLst-GetItem( XclExpExtDataBarType ); } -static_castXclExpExtCondFormat*(xExtLst-GetItem( XclExpExtDataBarType ).get())-AddRecord( XclExpExtConditionalFormattingRef(new XclExpExtConditionalFormatting( *pParent, rFormat, aAddr, rtl::OString({64A12B6B-50E9-436E-8939-DBE15E5BE1DC}) )) ); +sal_uInt8 nGuid[16]; +rtl_createUuid(nGuid, NULL, true); +maGuid = createGuidStringFromInt(nGuid); +static_castXclExpExtCondFormat*(xExtLst-GetItem( XclExpExtDataBarType ).get())-AddRecord( XclExpExtConditionalFormattingRef(new XclExpExtConditionalFormatting( *pParent, rFormat, aAddr, maGuid) )); } } @@ -1130,7 +1153,7 @@ void XclExpDataBar::SaveXml( XclExpXmlStream rStrm ) FSEND ); rWorksheet-startElementNS( XML_x14, XML_id, FSEND ); -rWorksheet-write( {64A12B6B-50E9-436E-8939-DBE15E5BE1DC} ); +rWorksheet-write( maGuid.getStr() ); rWorksheet-endElementNS( XML_x14, XML_id ); rWorksheet-endElement( XML_ext ); diff --git a/sc/source/filter/inc/xecontent.hxx b/sc/source/filter/inc/xecontent.hxx index c6388de..668641b 100644 --- a/sc/source/filter/inc/xecontent.hxx +++ b/sc/source/filter/inc/xecontent.hxx @@ -274,6 +274,7 @@ private: const ScDataBarFormat mrFormat; sal_Int32 mnPriority; +rtl::OString maGuid; }; // ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: --enable-lomenubar (was: Master failed to compile on framework module)
Thank you Stephan for the fix, it works now. Julien -- View this message in context: http://nabble.documentfoundation.org/Master-failed-to-compile-on-framework-module-tp4003926p4004086.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#39468: Translated German comments in sc/source/core/tool
From gerhard öttl lo...@ogersoft.at: gerhard öttl has uploaded a new change for review. Change subject: fdo#39468: Translated German comments in sc/source/core/tool .. fdo#39468: Translated German comments in sc/source/core/tool Change-Id: I3d27d33a973c601234b5b6e48756df16f567149d --- M sc/source/core/tool/address.cxx M sc/source/core/tool/adiasync.cxx M sc/source/core/tool/autoform.cxx M sc/source/core/tool/callform.cxx M sc/source/core/tool/chartarr.cxx M sc/source/core/tool/chartlis.cxx 6 files changed, 31 insertions(+), 31 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/503/1 -- To view, visit https://gerrit.libreoffice.org/503 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3d27d33a973c601234b5b6e48756df16f567149d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: gerhard öttl lo...@ogersoft.at ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: --enable-lomenubar (was: Master failed to compile on framework module)
Bjoern, do you mean lomenubar part could be removed completely on master from now or is it a little early to think about it? -- View this message in context: http://nabble.documentfoundation.org/Master-failed-to-compile-on-framework-module-tp4003926p4004094.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
make check fails on master with --enable-ext-numbertext
Hello, On pc Debian x86-64 with master sources updated today, I runned make check. I had this: : SUCCESS: Source for services.rdb: /home/julien/compile-libreoffice/libo/solver/unxlngx6/xml/services.rdb : : ERROR: Removing file numbertext.oxt from file list. : : : Removing directory /tmp/ooopackaging/i_163041346179524 : : *** : ERROR: Missing files : in function: remove_Files_Without_Sourcedirectory : *** Tue Aug 28 20:45:26 2012 (00:02 min.) Failed to install: at /home/julien/compile-libreoffice/libo/solenv/bin/ooinstall line 124. make[1]: *** [dev-install] Erreur 255 make[1]: quittant le répertoire « /home/julien/compile-libreoffice/libo » make: *** [check] Erreur 2 I've got --enable-ext-numbertext in my autogen.lastrun Any idea? Julien -- View this message in context: http://nabble.documentfoundation.org/make-check-fails-on-master-with-enable-ext-numbertext-tp4004097.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: basic/inc basic/source
basic/inc/basic/basmgr.hxx |4 ++-- basic/source/basmgr/basmgr.cxx | 12 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 9e2f8b9ec2d7418145cf514431e248e55e732cdb Author: Takeshi Abe t...@fixedpoint.jp Date: Tue Aug 28 13:52:19 2012 +0900 Fix typo ImpLoadLibary Change-Id: I773678437aae6577f22078e97bcac1377c4307d8 Reviewed-on: https://gerrit.libreoffice.org/495 Reviewed-by: Tor Lillqvist t...@iki.fi Tested-by: Kohei Yoshida kohei.yosh...@gmail.com diff --git a/basic/inc/basic/basmgr.hxx b/basic/inc/basic/basmgr.hxx index f8c4b40..a52771e 100644 --- a/basic/inc/basic/basmgr.hxx +++ b/basic/inc/basic/basmgr.hxx @@ -131,8 +131,8 @@ private: BASIC_DLLPRIVATE void Init(); protected: -sal_BoolImpLoadLibary( BasicLibInfo* pLibInfo ) const; -sal_BoolImpLoadLibary( BasicLibInfo* pLibInfo, SotStorage* pCurStorage, sal_Bool bInfosOnly = sal_False ); +sal_BoolImpLoadLibrary( BasicLibInfo* pLibInfo ) const; +sal_BoolImpLoadLibrary( BasicLibInfo* pLibInfo, SotStorage* pCurStorage, sal_Bool bInfosOnly = sal_False ); voidImpCreateStdLib( StarBASIC* pParentFromStdLib ); voidImpMgrNotLoaded( const String rStorageName ); BasicLibInfo* CreateLibInfo(); diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx index 733e469..62fde97 100644 --- a/basic/source/basmgr/basmgr.cxx +++ b/basic/source/basmgr/basmgr.cxx @@ -749,7 +749,7 @@ void BasicManager::SetLibraryContainerInfo( const LibraryContainerInfo rInfo ) StarBASIC* pLib = pBasLibInfo-GetLib(); if( !pLib ) { -sal_Bool bLoaded = ImpLoadLibary( pBasLibInfo, NULL, sal_False ); +sal_Bool bLoaded = ImpLoadLibrary( pBasLibInfo, NULL, sal_False ); if( bLoaded ) pLib = pBasLibInfo-GetLib(); } @@ -900,7 +900,7 @@ void BasicManager::LoadBasicManager( SotStorage rStorage, const String rBaseUR if ( bLoadLibs pInfo-DoLoad() ( ( !pInfo-IsExtern() ) || ( pInfo-IsReference() ) ) ) { -ImpLoadLibary( pInfo, rStorage ); +ImpLoadLibrary( pInfo, rStorage ); } } @@ -1044,7 +1044,7 @@ BasicLibInfo* BasicManager::CreateLibInfo() return pInf; } -sal_Bool BasicManager::ImpLoadLibary( BasicLibInfo* pLibInfo, SotStorage* pCurStorage, sal_Bool bInfosOnly ) +sal_Bool BasicManager::ImpLoadLibrary( BasicLibInfo* pLibInfo, SotStorage* pCurStorage, sal_Bool bInfosOnly ) { DBG_CHKTHIS( BasicManager, 0 ); @@ -1235,14 +1235,14 @@ StarBASIC* BasicManager::AddLib( SotStorage rStorage, const String rLibName, s aNewLibName += '_'; BasicLibInfo* pLibInfo = CreateLibInfo(); -// Use original name otherwise ImpLoadLibary failes... +// Use original name otherwise ImpLoadLibrary failes... pLibInfo-SetLibName( rLibName ); // but doesn't work this way if name exists twice sal_uInt16 nLibId = (sal_uInt16) pLibs-GetPos( pLibInfo ); // Set StorageName before load because it is compared with pCurStorage pLibInfo-SetStorageName( aStorageName ); -sal_Bool bLoaded = ImpLoadLibary( pLibInfo, rStorage ); +sal_Bool bLoaded = ImpLoadLibrary( pLibInfo, rStorage ); if ( bLoaded ) { @@ -1480,7 +1480,7 @@ sal_Bool BasicManager::LoadLib( sal_uInt16 nLib ) } else { -bDone = ImpLoadLibary( pLibInfo, NULL, sal_False ); +bDone = ImpLoadLibrary( pLibInfo, NULL, sal_False ); StarBASIC* pLib = GetLib( nLib ); if ( pLib ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Fix typo ImpLoadLibary
From Kohei Yoshida kohei.yosh...@gmail.com: Kohei Yoshida has submitted this change and it was merged. Change subject: Fix typo ImpLoadLibary .. Fix typo ImpLoadLibary Change-Id: I773678437aae6577f22078e97bcac1377c4307d8 --- M basic/inc/basic/basmgr.hxx M basic/source/basmgr/basmgr.cxx 2 files changed, 8 insertions(+), 8 deletions(-) Approvals: Kohei Yoshida: Verified Tor Lillqvist: Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/495 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I773678437aae6577f22078e97bcac1377c4307d8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Takeshi Abe t...@fixedpoint.jp Gerrit-Reviewer: Kohei Yoshida kohei.yosh...@gmail.com Gerrit-Reviewer: Tor Lillqvist t...@iki.fi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: configure.in
configure.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 571a7cba185788bcf9e91599da8e16fb050681df Author: Stephan Bergmann sberg...@redhat.com Date: Tue Aug 28 21:53:36 2012 +0200 Stray 2 Change-Id: I6647f46e7fbe13a9359ea8211c73996290d90b48 diff --git a/configure.in b/configure.in index 51c1ff2..885bd6c 100644 --- a/configure.in +++ b/configure.in @@ -1,4 +1,4 @@ -2dnl -*- Mode: Autoconf; tab-width: 4; indent-tabs-mode: nil; fill-column: 102 -*- +dnl -*- Mode: Autoconf; tab-width: 4; indent-tabs-mode: nil; fill-column: 102 -*- dnl configure.in serves as input for the GNU autoconf package dnl in order to create a configure script. ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: make check fails on master with --enable-ext-numbertext
By adding some traces, I found that error line is from this part of solenv/bin/modules/installer/scriptitems.pm: 1246 if ( ! $installer::globals::languagepack !$installer::globals::helppack) 1247 { 1248 $infoline = ERROR: Removing file $filename from file list.\n; 1249 push( @installer::globals::logfileinfo, $infoline); Hope it may help Julien -- View this message in context: http://nabble.documentfoundation.org/make-check-fails-on-master-with-enable-ext-numbertext-tp4004097p4004106.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: --enable-lomenubar (was: Master failed to compile on framework module)
On Tue, Aug 28, 2012 at 12:43:02PM -0700, julien2412 wrote: Bjoern, do you mean lomenubar part could be removed completely on master from now or is it a little early to think about it? A little early. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: android/sdremote officecfg/registry sd/source
android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java |3 android/sdremote/src/org/libreoffice/impressremote/communication/NetworkClient.java | 40 +- officecfg/registry/schema/org/openoffice/Office/Impress.xcs | 21 +++ sd/source/ui/remotecontrol/Server.cxx | 64 +- 4 files changed, 116 insertions(+), 12 deletions(-) New commits: commit 9ca3b5366211e998599c2cf7a7818ca38e3d74a0 Author: Andrzej J.R. Hunt andr...@ahunt.org Date: Tue Aug 28 22:17:35 2012 +0200 Saving of authorised remotes. Change-Id: I4cf6542352ac4213e66e2bbd6cc54d4f9372de62 diff --git a/android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java b/android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java index 89b94dd..214103a 100644 --- a/android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java +++ b/android/sdremote/src/org/libreoffice/impressremote/communication/CommunicationService.java @@ -86,8 +86,7 @@ public class CommunicationService extends Service implements Runnable { mState = State.CONNECTING; switch (mServerDesired.getProtocol()) { case NETWORK: -mClient = new NetworkClient( -mServerDesired.getAddress(), this); +mClient = new NetworkClient(mServerDesired, this); break; case BLUETOOTH: mClient = new BluetoothClient( diff --git a/android/sdremote/src/org/libreoffice/impressremote/communication/NetworkClient.java b/android/sdremote/src/org/libreoffice/impressremote/communication/NetworkClient.java index 47e0e37..dcb88a5 100644 --- a/android/sdremote/src/org/libreoffice/impressremote/communication/NetworkClient.java +++ b/android/sdremote/src/org/libreoffice/impressremote/communication/NetworkClient.java @@ -17,6 +17,8 @@ import java.util.Random; import android.content.Context; import android.content.Intent; +import android.content.SharedPreferences; +import android.content.SharedPreferences.Editor; import android.support.v4.content.LocalBroadcastManager; /** @@ -30,20 +32,16 @@ public class NetworkClient extends Client { private Socket mSocket; -public NetworkClient(String ipAddress, Context aContext) { +public NetworkClient(Server aServer, Context aContext) { super(aContext); try { -mSocket = new Socket(ipAddress, PORT); +mSocket = new Socket(aServer.getAddress(), PORT); mInputStream = mSocket.getInputStream(); mReader = new BufferedReader(new InputStreamReader(mInputStream, CHARSET)); mOutputStream = mSocket.getOutputStream(); // Pairing. -Random aRandom = new Random(); -String aPin = + (aRandom.nextInt(9000) + 1000); -while (aPin.length() 4) { -aPin = 0 + aPin; // Add leading zeros if necessary -} +String aPin = setupPin(aServer); Intent aIntent = new Intent( CommunicationService.MSG_PAIRING_STARTED); aIntent.putExtra(PIN, aPin); @@ -82,6 +80,34 @@ public class NetworkClient extends Client { } +private String setupPin(Server aServer) { +// Get settings +SharedPreferences aPreferences = mContext.getSharedPreferences( +sdremote_authorisedremotes, +android.content.Context.MODE_PRIVATE); +if (aPreferences.contains(aServer.getName())) { +return aPreferences.getString(aServer.getName(), ); +} else { +String aPin = generatePin(); + +Editor aEdit = aPreferences.edit(); +aEdit.putString(aServer.getName(), aPin); +aEdit.commit(); + +return aPin; +} + +} + +private String generatePin() { +Random aRandom = new Random(); +String aPin = + (aRandom.nextInt(9000) + 1000); +while (aPin.length() 4) { +aPin = 0 + aPin; // Add leading zeros if necessary +} +return aPin; +} + @Override public void closeConnection() { try { diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs index cb8c31a..6ad225f 100644 --- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs +++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs @@ -2,7 +2,7 @@ !--*** * * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. - * + * *
License statement
Dear all, All of my contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Thanks, Jack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/ui/view/cliputil.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7da3738ab903a180b5038ee92ad40869fdbff950 Author: Noel Power noel.po...@suse.com Date: Mon Aug 27 18:02:18 2012 +0100 fdo#46250: Allow paste paste special for unmatching dest (single) range. Change-Id: I420c044c9bcc49e479956f9118fb173a0350fda2 Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com diff --git a/sc/source/ui/view/cliputil.cxx b/sc/source/ui/view/cliputil.cxx index 74ac721..723bb89 100644 --- a/sc/source/ui/view/cliputil.cxx +++ b/sc/source/ui/view/cliputil.cxx @@ -114,7 +114,7 @@ bool ScClipUtil::CheckDestRanges( SCCOL nCols = aTest.aEnd.Col() - aTest.aStart.Col() + 1; SCROW nRowTest = (nRows / nSrcRows) * nSrcRows; SCCOL nColTest = (nCols / nSrcCols) * nSrcCols; -if (nRows != nRowTest || nCols != nColTest) +if ( rDest.size() 1 ( nRows != nRowTest || nCols != nColTest ) ) { // Destination range is not a multiple of the source range. Bail out. return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [REVIEW-3-6] fix for fdo#46250
Hi Noel, On 08/28/2012 05:23 AM, Noel Power wrote: This patch makes lessens the strictness when determining when paste special-paste can be applied, please consider http://cgit.freedesktop.org/libreoffice/core/commit/?id=d27a7b8c5b96eb328918cc67b9b5562b8870f2ac Pushed to 3-6 with my sign-off (and amended the commit message to include the bug number). Kohei, my initial gung-ho-ness for additionally squashing the paste always on behaviour has waned a little, if we do that I'd prefer to do it separately. Yup, I'm fine with that. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-6][PUSHED 3-6] fix for fdo#46250
PUSHED ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] HardHacks
Hi Rainer, On Sat, 2012-08-25 at 08:31 +0200, Rainer Bielefeld wrote: 36681 All Writer - EDITING: after insert/removal of a picture (or alike) view scrolls to begin/end of document https://bugs.freedesktop.org/show_bug.cgi?id=36681 Fixed. -- Cedric ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] NEEDINFO Status
After thinking about it I agree. The message should probably be done on closing the bug as INVALID or adding a new status of PLEASETEST (I am not hugely in favor of this, we already have too many status' IMO). But for more experienced triagers there's no harm in letting the user know on marking it as NEEDINFO that the bug will be auto closed after 30 days. No need to make this a big deal, just for those of us who have been working with LibO for awhile we can add the friendly message. We don't want to get too strict or mechanical for many reasons, two that come to mind is pissing off our user base because we sound like robots and also making it more difficult for new members to get involved. We should try to finalize this before our next conference call so we can move on to more important stuff :) Joel P.S. Also, is there an ongoing agenda for the next conference? On Mon, Aug 27, 2012 at 3:58 AM, Petr Mladek pmla...@suse.cz wrote: Rainer Bielefeld píše v So 25. 08. 2012 v 11:30 +0200: Joel Madero schrieb: when we actually put a bug into NEEDINFO status we put a comment that has a small blurb on our procedure. Something like we have put this bug in NEEDINFO status because we need you to provide.we will leave the bug in this status for 6 months I recommend that we agree to a standard sentence like This bug will be closed after 14 days if requested information will not be provided. Additional information concerning the reasons for this proceeding and how you can reopen this Bug you can find at jttp://...Wiki... , to be inserted by copy /paste from Wiki. I appreciate you carefulness and sense for details. Well, I am still not convinced that we need to warn people before. I understand the point but it has some drawbacks: + reporters might get angry that we force them to answer within 30 days and then do not fix bug several months; and we are not able to fix all 5000 bugs within one month + the standard message is yet another thing that bug triagers should memorize; it makes the process more complicated and harder to learn + it is another message that makes the report longer and harder to read I still thing that the best solution would be to tune the closing message. It has to be short, explanatory, friendly, encouraging. I suggest something like: We would like to solve this bug but nobody has provided the requested information during last 30 days. We can't move forward and close this bug for now. Feel free to reopen it together with the needed details. This can be done automatically, so nobody need to memorize it. Best Regards, Petr ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 49261] Problems with changing color of text in the List Box
https://bugs.freedesktop.org/show_bug.cgi?id=49261 Jochen d...@jochenschiffers.de changed: What|Removed |Added Status|NEEDINFO|NEW Severity|minor |enhancement --- Comment #3 from Jochen d...@jochenschiffers.de 2012-08-28 06:14:50 UTC --- Status changed to NEW Importance changed to enhancement -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36858] Oracle Report Builder date calculation error
https://bugs.freedesktop.org/show_bug.cgi?id=36858 Jochen d...@jochenschiffers.de changed: What|Removed |Added Status|NEW |NEEDINFO -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54015] ld(1) requires -z origin when -rpath contains $ORIGIN
https://bugs.freedesktop.org/show_bug.cgi?id=54015 --- Comment #4 from Jung-uk Kim j...@freebsd.org 2012-08-28 06:27:51 UTC --- To confirm, I did the following before start building: find . -type f -print0 | \ xargs -0 sed -i '' -e 's#-Wl,-rpath,#-Wl,-z,origin,-rpath,#g' Now objdump -p uno or readelf --dynamic uno shows the flag is set correctly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49261] Problems with changing color of text in the List Box
https://bugs.freedesktop.org/show_bug.cgi?id=49261 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-08-28 06:35:37 UTC --- This one is not NEW as long as we do not have a minimum of a concept what we want to do: https://wiki.documentfoundation.org/BugTriage#Process item 5 Here we need a simple sample document with what we can define all requirements. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49261] Problems with changing color of text in the List Box
https://bugs.freedesktop.org/show_bug.cgi?id=49261 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever Confirmed|1 |0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54144] New: PRINTING: Printer Language defaults to PDF, special printer settings are ignored
https://bugs.freedesktop.org/show_bug.cgi?id=54144 Bug #: 54144 Summary: PRINTING: Printer Language defaults to PDF, special printer settings are ignored Classification: Unclassified Product: LibreOffice Version: 3.4.5 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: hein2h...@googlemail.com Created attachment 66200 -- https://bugs.freedesktop.org/attachment.cgi?id=66200 printer dialog screen with default values Problem description: If I want to print a document, the default printer language is PDF, no matter what I have chosen before. In mode PDF, special settings like printing from another than standard tray, are ignored. Steps to reproduce: 1. make a new document in writer 2. type some lines 3. go to File - Print - Printer Properties - Printer Language Current behavior: it always appears PDF as default language Expected behavior: the default printer language should be post script (level of driver), so printer-specific options are no longer ignored. See also bug nr. 50358 This bug is also present in the current libreoffice release which I use on another machine. Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20100101 Firefox/14.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33838] FORMATTING, FILEOPEN: Default bullet point not showing correctly (.lwp import)
https://bugs.freedesktop.org/show_bug.cgi?id=33838 sasha.libreoff...@gmail.com changed: What|Removed |Added Version|3.6.0.4 release |3.3.0 release --- Comment #10 from sasha.libreoff...@gmail.com 2012-08-28 06:47:29 UTC --- @ Jaxson Lee Thanks for additional testing Version is most old version of LO where bug appears, not current version. Changing back to 3.3.0 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46410] EDITING: Alphabetical index with concordance file
https://bugs.freedesktop.org/show_bug.cgi?id=46410 --- Comment #14 from sasha.libreoff...@gmail.com 2012-08-28 06:52:32 UTC --- when can we expect a fix for it? I hope that in this year. But I am afraid that even in next year this bug will not fixed. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49261] Problems with changing color of text in the List Box
https://bugs.freedesktop.org/show_bug.cgi?id=49261 --- Comment #5 from Jochen d...@jochenschiffers.de 2012-08-28 07:13:53 UTC --- Hi Mateusz, how do you see exist a problem with your report. Your report does not correspond to the triage concpt. That's why I was asking (comment 1). I changed status to NEW. But this is not accepted. Please understand that. You must accurately describe your problem/request. It is not enough to point to a forum post. Also quote Rainer: Here we need a simple sample document with what we can define all requirements. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49261] Problems with changing color of text in the List Box
https://bugs.freedesktop.org/show_bug.cgi?id=49261 Jochen d...@jochenschiffers.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever Confirmed|0 |1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54023] CRASH on launch when loading local libiconv.2.dylib (liblangtag.0.dylib requires version 8.0.0 or later, but libiconv.2.dylib provides version 7.0)
https://bugs.freedesktop.org/show_bug.cgi?id=54023 --- Comment #17 from Roman Eisele b...@eikota.de 2012-08-28 07:16:57 UTC --- @ Alex Thurgood: Thank you for all the details! - So the current master builds work, if libiconv.2.dylib is installed at /usr/local/lib/ and is of version 8.0.0 or better (iconv --version gives a number = 1.12). Right? IMHO this confirm Tor's idea: (In reply to comment #10) ... that /usr/local indeed is a sign that something from the *build system* that is peculiar to that got pipcked up, hopefully unintentionally. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47511] PDF: Writer: exporting a document as pdf file will crash Writer.
https://bugs.freedesktop.org/show_bug.cgi?id=47511 Roman Eisele b...@eikota.de changed: What|Removed |Added Version|3.6.0.4 release |3.5.1 release --- Comment #27 from Roman Eisele b...@eikota.de 2012-08-28 07:21:27 UTC --- @ alix.helme-guizon@numericab: Thank you for confirming that this bug is still reproducible with LibreOffice 3.6.0.4! However, if you find that a bug is still reproducible with a newer version, please just leave an additional comment about this, but do not update the Version field: we use the Version field for the FIRST version in which a bug is known to exist (is reproducible), and NOT the newest one. Thank you! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50423] EDITING: Reference fields to other files doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=50423 Hashem Masoud wraithl...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||WORKSFORME CC||jmadero@gmail.com, ||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Hashem Masoud wraithl...@gmail.com 2012-08-28 07:44:46 UTC --- (In reply to comment #0) Works for me. The referencing file shows the referenced field in the other file. I'm using Version 3.6.0.4 (Build ID: 932b512) On Slackware Linux 13.37 Please re-open the bug if you face the issue again. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47567] FORMATTING - animation bug
https://bugs.freedesktop.org/show_bug.cgi?id=47567 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|NEEDINFO|NEW Severity|major |normal --- Comment #4 from Roman Eisele b...@eikota.de 2012-08-28 07:50:25 UTC --- (In reply to comment #3) The description Roman made is precisely the bug i talk about : At least I don’t see a wild background here; when the 6th line appears, a big radial gradient appears and overlaps much of the previous lines, but it seems this is intentional behaviour. But it is not intentionnal and i couldn' get ride it by designing a new slide, etc. @ rreno56: Thank you very much for clarification! OK, _this_ problem is reproducible for me with LibreOffice 3.5.6.2 (see comment #2) and also with LibreOffice 3.6.1.2 (Build ID: e29a214), both on MacOS X 10.6.8 (Intel). What is necessary now: 1) Could someone please test again if this issue (see precise description above) is reproducible also on Windows and/or Linux? 2) Some Impress expert (I’m not an expert for Impress, of course) should examinate the sample presentation closely, if he/she can find any reason for that strange behaviour. If not, this is really a strange and important bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54055] FILESAVE: Open .XLS with links to external files. while editing or saving to .ODS LO crashes
https://bugs.freedesktop.org/show_bug.cgi?id=54055 --- Comment #3 from Hashem Masoud wraithl...@gmail.com 2012-08-28 07:51:42 UTC --- (In reply to comment #1) Created attachment 66108 [details] XLS file with external reference crashes while saving to ods on Windows 7. Libroffice 3.6.0 and 3.6.1.1 Tested with: Version 3.6.0.4 (Build ID: 932b512) Slackware Linux 13.37 I didn't face any crash (while saving and later opening the .ODS file). -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54145] New: Plantage de LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=54145 Bug #: 54145 Summary: Plantage de LibreOffice Classification: Unclassified Product: LibreOffice Version: 3.6.0.0.beta1 Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: epicenter.pa...@gmail.com Impossible à mettre Libre Office en route. Il ne démarre pas et plante avec un message de windows explorer. Plantage complet. La mise en route ne se fait pas. La petite bande verte marquant l'avancement du logiciel s'arrête dès le départ. Message: Libre Office 3.6.0 a planté. Windows recherche un solution... Marre d'un logiciel comme ça!!! My mail address: epicenter.pa...@gmail.com. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53901] No way to specify default document directories for each or any component
https://bugs.freedesktop.org/show_bug.cgi?id=53901 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Severity|major |enhancement Ever Confirmed|1 |0 --- Comment #3 from Jean-Baptiste Faure jbf.fa...@orange.fr 2012-08-28 07:54:53 UTC --- (In reply to comment #2) [...] Microsoft Office (I hate to use it as an example) provides a default setting for each app within the suite. Perhaps, and ? From my point of view it is a very bad idea. But you are free to submit a patch or discuss the idea on ux-advice mailing list : http://nabble.documentfoundation.org Not a bug anyway; so set to enhancement. Best regards. JBF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50423] EDITING: Reference fields to other files doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=50423 Hashem Masoud wraithl...@gmail.com changed: What|Removed |Added Status Whiteboard|BSA |BSA (target:3.6.0.4) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53073] Make quickstarter available for Linux non-distro builds
https://bugs.freedesktop.org/show_bug.cgi?id=53073 Petr Mladek pmla...@suse.cz changed: What|Removed |Added CC||fridrich.st...@bluewin.ch, ||michael.me...@novell.com --- Comment #3 from Petr Mladek pmla...@suse.cz 2012-08-28 07:58:45 UTC --- According to the configure check, the quickstarter stuff requires GTK-2.10 at least. The universal Linux build is done using gtk-2.4 to be compatible with most existing systems. The result is that the quickstarter stuff is not available in the universal build. I know that we can't build against newer gtk easily because of dependency on cairo. Fridrich knows more here. I am not sure how complicated would be to port the quickstarter stuff for GTK-2.4. Note that there were several discussions to remove the quickstarter functionality at all. IMHO, there were problems with session management in the past. It causes troubles when upgrading the application, ... A solution would be to provide distro-specific build for the given user. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47567] FORMATTING - animation bug
https://bugs.freedesktop.org/show_bug.cgi?id=47567 --- Comment #5 from Roman Eisele b...@eikota.de 2012-08-28 07:59:17 UTC --- Created attachment 66202 -- https://bugs.freedesktop.org/attachment.cgi?id=66202 Screenshot - how it looks in LibO 3.6.1.2 To make clear what the problem is, a screenshot is better than 1000 words -- here is the 1st one: the sample presentation in the last step (line 6 visible), seen in LibreOffice 3.6.1.2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47567] FORMATTING - animation bug
https://bugs.freedesktop.org/show_bug.cgi?id=47567 --- Comment #6 from Roman Eisele b...@eikota.de 2012-08-28 08:00:35 UTC --- Created attachment 66203 -- https://bugs.freedesktop.org/attachment.cgi?id=66203 Screenshot - how it looks in LibO 3.5.6.2 Next screenshot: the sample presentation in the last step (line 6 visible), seen in LibreOffice 3.5.6.2; the same as in LibreOffice 3.6.1.2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47567] FORMATTING - animation bug
https://bugs.freedesktop.org/show_bug.cgi?id=47567 --- Comment #7 from Roman Eisele b...@eikota.de 2012-08-28 08:02:01 UTC --- Created attachment 66204 -- https://bugs.freedesktop.org/attachment.cgi?id=66204 Screenshot - how it looks in LibO 3.4.0 and 3.4.6 Next screenshot - in LibreOffice 3.4.0 to 3.4.6, the animation looks quite different in the last step; but still wrong, only that the irritating radial gradient is at another place and has another size. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47567] FORMATTING - animation bug
https://bugs.freedesktop.org/show_bug.cgi?id=47567 --- Comment #8 from Roman Eisele b...@eikota.de 2012-08-28 08:03:14 UTC --- Created attachment 66205 -- https://bugs.freedesktop.org/attachment.cgi?id=66205 Bug 47567 - how it looks in LibO 3.3.0 Last screenshot -- how the animation looks in LibreOffice 3.0.0; mostly correct, this time, but there is still a light grey horizontal line which should not be there. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51733] Update icons for high-resolution HiDPI / Retina display
https://bugs.freedesktop.org/show_bug.cgi?id=51733 Roman Eisele b...@eikota.de changed: What|Removed |Added Severity|normal |enhancement CC||b...@eikota.de --- Comment #1 from Roman Eisele b...@eikota.de 2012-08-28 08:11:40 UTC --- Thank you very much for your report! I completely agree on y This is an enhancement request, therefore adapted Importance picker to enhancement. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54015] ld(1) requires -z origin when -rpath contains $ORIGIN
https://bugs.freedesktop.org/show_bug.cgi?id=54015 --- Comment #5 from Stephan Bergmann sberg...@redhat.com 2012-08-28 08:17:23 UTC --- (In reply to comment #3) FreeBSD ld must have -zorigin with -rpath. Otherwise, $ORIGIN is not translated and it is literal. So the true fix for LO will be to add -zorigin in solenv/{inc,gbuild} for FreeBSD, right? Will you create a new patch? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs