[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/source
vcl/source/window/builder.cxx | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
New commits:
commit 360b532ed5562c9831cb8d43852641c4a0f041c5
Author: Caolán McNamara caol...@redhat.com
Date: Thu Aug 30 13:03:44 2012 +0100
drop autoshow of all widgets, and honour visibility flag
Change-Id: I752c8be2830441114b747a809eb1a331ac19472a
diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index 50e6b94..d85966f 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -126,17 +126,6 @@ VclBuilder::VclBuilder(Window *pParent, rtl::OUString
sUIDir, rtl::OUString sUIF
//drop maps, etc. now
delete m_pParserState;
-
-//auto-show (really necessary ?, maybe drop it when complete)
-for (std::vectorWinAndId::iterator aI = m_aChildren.begin(),
- aEnd = m_aChildren.end(); aI != aEnd; ++aI)
-{
-Window *pWindow = aI-m_pWindow;
-if (pWindow)
-{
-pWindow-Show();
-}
-}
}
VclBuilder::~VclBuilder()
@@ -375,11 +364,13 @@ Window *VclBuilder::makeObject(Window *pParent, const
rtl::OString name, const
if (!bIsPlaceHolder)
{
TabPage* pPage = new TabPage(pTabControl);
+pPage-Show();
m_aChildren.push_back(WinAndId(rtl::OString(), pPage));
//And give the page one container as a child to make it a layout
enabled
//tab page
VclBin* pContainer = new VclBin(pPage);
+pContainer-Show();
m_aChildren.push_back(WinAndId(rtl::OString(), pContainer));
pParent = pContainer;
@@ -789,8 +780,6 @@ void VclBuilder::handleRow(xmlreader::XmlReader reader,
const rtl::OString rID
{
int nLevel = 1;
-fprintf(stderr, handleRow for %s\n, rID.getStr());
-
ListStore::row aRow;
while(1)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: embeddedobj/source
embeddedobj/source/inc/oleembobj.hxx | 10 ++
1 file changed, 10 insertions(+)
New commits:
commit 3748a0534edf9ee48ee002fee680e6d2f437126d
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Aug 31 09:50:06 2012 +0200
Removed private fields were acutally used #ifdef WNT
Change-Id: I0c4d70884d8735eb6941bc252d0aad838c80fd38
diff --git a/embeddedobj/source/inc/oleembobj.hxx
b/embeddedobj/source/inc/oleembobj.hxx
index 04f8d63..52e03da 100644
--- a/embeddedobj/source/inc/oleembobj.hxx
+++ b/embeddedobj/source/inc/oleembobj.hxx
@@ -46,6 +46,8 @@
#include com/sun/star/util/XCloseListener.hpp
#include cppuhelper/implbase5.hxx
+#include osl/thread.h
+
namespace cppu {
class OMultiTypeInterfaceContainerHelper;
}
@@ -56,6 +58,10 @@ class VerbExecutionController
::osl::Mutexm_aVerbExecutionMutex;
sal_Bool m_bVerbExecutionInProgress;
+#ifdef WNT
+oslThreadIdentifier m_nVerbExecutionThreadIdentifier;
+sal_Bool m_bChangedOnVerbExecution;
+#endif
sal_Bool m_bWasEverActive;
sal_Int32 m_nNotificationLock;
@@ -64,6 +70,10 @@ public:
VerbExecutionController()
: m_bVerbExecutionInProgress( sal_False )
+#ifdef WNT
+, m_nVerbExecutionThreadIdentifier( 0 )
+, m_bChangedOnVerbExecution( sal_False )
+#endif
, m_bWasEverActive( sal_False )
, m_nNotificationLock( 0 )
{}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Missing ICU Library
Sorry, I didn't read this mail earlier, it was filtered with the others... Well, UI is something I'd like to work on, but I think someone else took the bug you mentioned. I'd like to work on improving the GTK theme, but at the moment my build fails with the following error: [ build CXX ] writerfilter/source/rtftok/rtfdocumentimpl.cxx [ build CXX ] writerfilter/source/rtftok/rtfvalue.cxx libo/writerfilter/source/rtftok/rtfdocumentimpl.cxx: In Elementfunktion »int writerfilter::rtftok::RTFDocumentImpl::dispatchToggle(writerfilter::rtftok::RTFKeyword, bool, int)«: libo/writerfilter/source/rtftok/rtfdocumentimpl.cxx:3190:83: Fehler: »OOXML_del« ist kein Element von »writerfilter::ooxml« libo/writerfilter/source/rtftok/rtfdocumentimpl.cxx:3190:102: Fehler: »OOXML_ins« ist kein Element von »writerfilter::ooxml« make[2]: *** [libo/workdir/unxlngi6.pro/CxxObject/writerfilter/source/rtftok/rtfdocumentimpl.o] Fehler 1 Any idea what is wrong this time? Thanks Samuel Am 15.08.2012 13:14, schrieb Michael Meeks: On Tue, 2012-08-14 at 21:51 +0200, Samuel Mehrbrodt wrote: and finally the build is finished :) Cool :-) so - hopefully subsequent builds will work better :-) Out of interest, what are you planning to hack on ? and/or would you like some code pointers ? or most-annoying-bugs or ? :-) I'm personally looking for someone who would like to look into: https://bugs.freedesktop.org/show_bug.cgi?id=46141 not to make it only do it when clicking, but to ensure that simply scrolling the document in any way except by using the mouse does not show the fade-in / pop-up beasties ;-) any chance of some love there ? All the best, Michael. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source
vcl/inc/vcl/layout.hxx | 24 ++-
vcl/source/window/layout.cxx | 67 ---
2 files changed, 68 insertions(+), 23 deletions(-)
New commits:
commit 5f0b8da8cab56fbb107a19b48acc058efbd6692e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 09:16:39 2012 +0100
make spanning of empty row/cols work better
Change-Id: I4ef6cee2ffdfced8d98dc48cf21a142bb15fd4a3
diff --git a/vcl/inc/vcl/layout.hxx b/vcl/inc/vcl/layout.hxx
index db35196..3da9edd 100644
--- a/vcl/inc/vcl/layout.hxx
+++ b/vcl/inc/vcl/layout.hxx
@@ -313,7 +313,29 @@ private:
bool m_bColumnHomogeneous;
int m_nRowSpacing;
int m_nColumnSpacing;
-typedef boost::multi_arrayWindow*, 2 array_type;
+
+struct GridEntry
+{
+Window *pChild;
+sal_Int32 nSpanWidth;
+sal_Int32 nSpanHeight;
+GridEntry()
+: pChild(0)
+, nSpanWidth(0)
+, nSpanHeight(0)
+{
+}
+};
+
+typedef boost::multi_arrayGridEntry, 2 array_type;
+
+struct ExtendedGridEntry : GridEntry
+{
+int x;
+int y;
+};
+
+typedef boost::multi_arrayExtendedGridEntry, 2 ext_array_type;
array_type assembleGrid() const;
bool isNullGrid(const array_type A) const;
diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index bd27819..db51243 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -385,7 +385,7 @@ void VclButtonBox::setAllocation(const Size rAllocation)
VclGrid::array_type VclGrid::assembleGrid() const
{
-array_type A;
+ext_array_type A;
for (Window* pChild = GetWindow(WINDOW_FIRSTCHILD); pChild;
pChild = pChild-GetWindow(WINDOW_NEXT))
@@ -410,9 +410,23 @@ VclGrid::array_type VclGrid::assembleGrid() const
A.resize(boost::extents[nCurrentMaxXPos+1][nCurrentMaxYPos+1]);
}
-A[nLeftAttach][nTopAttach] = pChild;
-}
+ExtendedGridEntry rEntry = A[nLeftAttach][nTopAttach];
+rEntry.pChild = pChild;
+rEntry.nSpanWidth = nWidth;
+rEntry.nSpanHeight = nHeight;
+rEntry.x = nLeftAttach;
+rEntry.y = nTopAttach;
+for (sal_Int32 nSpanX = 0; nSpanX nWidth; ++nSpanX)
+{
+for (sal_Int32 nSpanY = 0; nSpanY nHeight; ++nSpanY)
+{
+ExtendedGridEntry rSpan =
A[nLeftAttach+nSpanX][nTopAttach+nSpanY];
+rSpan.x = nLeftAttach;
+rSpan.y = nTopAttach;
+}
+}
+}
//see if we have any empty rows/cols
sal_Int32 nMaxX = A.shape()[0];
@@ -425,16 +439,12 @@ VclGrid::array_type VclGrid::assembleGrid() const
{
for (sal_Int32 y = 0; y nMaxY; ++y)
{
-const Window *pChild = A[x][y];
-if (pChild)
+const GridEntry rEntry = A[x][y];
+const Window *pChild = rEntry.pChild;
+if (pChild pChild-IsVisible())
{
-sal_Int32 nWidth = pChild-get_grid_width();
-for (sal_Int32 nSpanX = 0; nSpanX nWidth; ++nSpanX)
-aNonEmptyCols[x+nSpanX] = true;
-
-sal_Int32 nHeight = pChild-get_grid_height();
-for (sal_Int32 nSpanY = 0; nSpanY nHeight; ++nSpanY)
-aNonEmptyRows[y+nSpanY] = true;
+aNonEmptyCols[x] = true;
+aNonEmptyRows[y] = true;
}
}
}
@@ -442,9 +452,19 @@ VclGrid::array_type VclGrid::assembleGrid() const
sal_Int32 nNonEmptyCols = std::count(aNonEmptyCols.begin(),
aNonEmptyCols.end(), true);
sal_Int32 nNonEmptyRows = std::count(aNonEmptyRows.begin(),
aNonEmptyRows.end(), true);
-//no empty rows or cols
-if (nNonEmptyCols == nMaxX nNonEmptyRows == nMaxY)
-return A;
+//reduce the spans of elements that span empty rows or columns
+for (sal_Int32 x = 0; x nMaxX; ++x)
+{
+for (sal_Int32 y = 0; y nMaxY; ++y)
+{
+ExtendedGridEntry rSpan = A[x][y];
+ExtendedGridEntry rEntry = A[rSpan.x][rSpan.y];
+if (!aNonEmptyCols[x])
+--rEntry.nSpanWidth;
+if (!aNonEmptyRows[y])
+--rEntry.nSpanHeight;
+}
+}
//make new grid without empty rows and columns
array_type B(boost::extents[nNonEmptyCols][nNonEmptyRows]);
@@ -456,7 +476,8 @@ VclGrid::array_type VclGrid::assembleGrid() const
{
if (aNonEmptyRows[y] == false)
continue;
-B[x2][y2++] = A[x][y];
+GridEntry rEntry = A[x][y];
+B[x2][y2++] = rEntry;
}
++x2;
}
@@ -486,19 +507,20 @@ void VclGrid::calcMaxs(const array_type A,
std::vectorValue rWidths, std::ve
{
for (sal_Int32 y = 0; y nMaxY; ++y)
{
-const Window *pChild = A[x][y];
+const GridEntry
[Libreoffice-commits] .: 3 commits - i18npool/CppunitTest_i18npool_test_breakiterator.mk i18npool/qa i18npool/source solenv/inc tools/inc tools/source
i18npool/CppunitTest_i18npool_test_breakiterator.mk |4
i18npool/qa/cppunit/test_breakiterator.cxx | 21 ++-
i18npool/source/breakiterator/data/README |7 -
solenv/inc/settings.mk |2
tools/inc/tools/inetmsg.hxx | 126 +-
tools/source/inet/inetmsg.cxx | 135 +---
tools/source/inet/inetstrm.cxx |2
7 files changed, 157 insertions(+), 140 deletions(-)
New commits:
commit edfa6cd3e5d27d793bfb2e7d23e2fdb4dbc09a69
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 10:30:35 2012 +0100
Related: #i103552# add regression test for ã·ã£ãããã¦ã³
Change-Id: I30117fdf70036f6df8dc494fe33a8a56d5544635
diff --git a/i18npool/CppunitTest_i18npool_test_breakiterator.mk
b/i18npool/CppunitTest_i18npool_test_breakiterator.mk
index 62100a0..3a7855d 100644
--- a/i18npool/CppunitTest_i18npool_test_breakiterator.mk
+++ b/i18npool/CppunitTest_i18npool_test_breakiterator.mk
@@ -51,4 +51,8 @@ $(eval $(call
gb_CppunitTest_use_components,i18npool_test_breakiterator,\
i18npool/util/i18npool \
))
+$(call gb_CppunitTest_get_target,i18npool_test_breakiterator) : \
+$(call gb_Library_get_target,dict_ja) \
+$(call gb_Library_get_target,dict_zh)
+
# vim: set noet sw=4 ts=4:
diff --git a/i18npool/qa/cppunit/test_breakiterator.cxx
b/i18npool/qa/cppunit/test_breakiterator.cxx
index 3fb555d..63f9708 100644
--- a/i18npool/qa/cppunit/test_breakiterator.cxx
+++ b/i18npool/qa/cppunit/test_breakiterator.cxx
@@ -61,6 +61,7 @@ public:
void testNorthernThai();
#endif
void testKhmer();
+void testJapanese();
CPPUNIT_TEST_SUITE(TestBreakIterator);
CPPUNIT_TEST(testLineBreaking);
@@ -75,6 +76,7 @@ public:
CPPUNIT_TEST(testWordBoundaries);
CPPUNIT_TEST(testKhmer);
#endif
+CPPUNIT_TEST(testJapanese);
CPPUNIT_TEST_SUITE_END();
private:
uno::Referencei18n::XBreakIterator m_xBreak;
@@ -820,9 +822,9 @@ void TestBreakIterator::testKhmer()
aLocale.Language = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(km));
aLocale.Country = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(KH));
-const sal_Unicode KHMER1[] = { 0x17B2, 0x17D2, 0x1799, 0x1782, 0x17C1 };
+const sal_Unicode KHMER[] = { 0x17B2, 0x17D2, 0x1799, 0x1782, 0x17C1 };
-rtl::OUString aTest(KHMER1, SAL_N_ELEMENTS(KHMER1));
+rtl::OUString aTest(KHMER, SAL_N_ELEMENTS(KHMER));
i18n::Boundary aBounds = m_xBreak-getWordBoundary(aTest, 0, aLocale,
i18n::WordType::DICTIONARY_WORD, true);
@@ -835,6 +837,21 @@ void TestBreakIterator::testKhmer()
}
#endif
+void TestBreakIterator::testJapanese()
+{
+lang::Locale aLocale;
+aLocale.Language = OUString(ja);
+aLocale.Country = OUString(JP);
+
+const sal_Unicode JAPANESE[] = { 0x30B7, 0x30E3, 0x30C3, 0x30C8, 0x30C0,
0x30A6, 0x30F3 };
+
+rtl::OUString aTest(JAPANESE, SAL_N_ELEMENTS(JAPANESE));
+i18n::Boundary aBounds = m_xBreak-getWordBoundary(aTest, 5, aLocale,
+i18n::WordType::DICTIONARY_WORD, true);
+
+CPPUNIT_ASSERT(aBounds.startPos == 0 aBounds.endPos == 7);
+}
+
void TestBreakIterator::setUp()
{
BootstrapFixtureBase::setUp();
diff --git a/i18npool/source/breakiterator/data/README
b/i18npool/source/breakiterator/data/README
index 4899f60..95f6b00 100644
--- a/i18npool/source/breakiterator/data/README
+++ b/i18npool/source/breakiterator/data/README
@@ -16,12 +16,6 @@ latest versions.
to-review, later are ok:
-commit ae9d7c2cef9ecd42687d64f985b9e2dcbc68a034
-Author: Thomas Lange [tl] t...@openoffice.org
-Date: Tue Apr 27 10:09:22 2010 +0200
-
-cws tl80: #i103552# Japanese word for 'shutdown' added to ja.dic
-
commit ffdc043d7272d2e0a664f530bbc112f952acadab
Author: Thomas Lange [tl] t...@openoffice.org
Date: Mon Mar 15 09:22:49 2010 +0100
@@ -561,6 +555,7 @@ Date: Mon Mar 8 16:17:05 2004 +
done, regression tests added:
+#i103552# Japanese word for 'shutdown' added to ja.dic
#i113785# ligatures for spell checking will no longer break words
An opening quote should not be counted as a word by word count tool
(regression test in in writer)
fdo#31271 wrong line break with (
commit aac3ff1d15bcc8e4d498900386bf6b05f3cad905
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 10:23:32 2012 +0100
-DRTL_USING for dmake modules as well
following logic of 608025986
Change-Id: I016b76bf350432a29e02d528814584c5dbbfff61
diff --git a/solenv/inc/settings.mk b/solenv/inc/settings.mk
index 7c28ad5..230c060 100644
--- a/solenv/inc/settings.mk
+++ b/solenv/inc/settings.mk
@@ -1119,6 +1119,8 @@ CDEFS += -DHAVE_THREADSAFE_STATICS
CDEFS += -DDISABLE_DYNLOADING
.ENDIF
+CDEFS += -DRTL_USING
+
# compose flags and defines for GUI
.IF $(TARGETTYPE)==GUI
CFLAGSSLO+=$(CFLAGSSLOGUIMT)
commit 3e0e87545fa20dfeabe904395e2a6767a5d5ea4a
Author: Caolán McNamara caol...@redhat.com
[Libreoffice-commits] .: Branch 'feature/unitymenus' - vcl/unx
vcl/unx/gtk/window/glomenu.cxx|2 -
vcl/unx/gtk/window/gtksalmenu.cxx | 60 --
2 files changed, 62 deletions(-)
New commits:
commit 5b1f90a2b608486a7b34c566372eca3ab24401d4
Author: Antonio Fernandez antonio.fernan...@aentos.es
Date: Fri Aug 31 11:38:35 2012 +0100
Cleaned up some code.
Change-Id: I47bc6a29a01a2cacd3e77a9ec9ac4f9b6223093f
diff --git a/vcl/unx/gtk/window/glomenu.cxx b/vcl/unx/gtk/window/glomenu.cxx
index 657d0c2..9c0f835 100644
--- a/vcl/unx/gtk/window/glomenu.cxx
+++ b/vcl/unx/gtk/window/glomenu.cxx
@@ -24,8 +24,6 @@
#include stdio.h
#include string.h
-#include unx/gtk/gtksalmenu.hxx
-
#include unx/gtk/glomenu.h
struct _GLOMenu
diff --git a/vcl/unx/gtk/window/gtksalmenu.cxx
b/vcl/unx/gtk/window/gtksalmenu.cxx
index 4f6dda2..ca3e9ef 100644
--- a/vcl/unx/gtk/window/gtksalmenu.cxx
+++ b/vcl/unx/gtk/window/gtksalmenu.cxx
@@ -32,65 +32,6 @@
using namespace std;
-//Some menus are special, this is the list of them
-//gboolean
-//isSpecialSubmenu (OUString command)
-//{
-//const gchar * specialSubmenus[11] = {.uno:CharFontName,
-// .uno:FontHeight,
-// .uno:ObjectMenue,
-// .uno:InsertPageHeader,
-// .uno:InsertPageFooter,
-// .uno:ChangeControlType,
-// .uno:AvailableToolbars,
-// .uno:ScriptOrganizer,
-// .uno:RecentFileList,
-// .uno:AddDirect,
-// .uno:AutoPilotMenu};
-
-//for (gint i = 0; i 11; i++)
-//{
-//if (command.equals (OUString::createFromAscii (specialSubmenus[i])))
-//return TRUE;
-//}
-//return FALSE;
-//}
-
-//static void UpdateNativeMenu( GtkSalMenu* pMenu ) {
-//if ( pMenu == NULL )
-//return;
-
-//Menu* pVCLMenu = pMenu-GetMenu();
-
-//for ( sal_uInt16 i = 0; i pMenu-GetItemCount(); i++ ) {
-//GtkSalMenuItem *pSalMenuItem = pMenu-GetItemAtPos( i );
-//sal_uInt16 nId = pSalMenuItem-mnId;
-
-//if ( pSalMenuItem-mnType == MENUITEM_SEPARATOR )
-//continue;
-
-//String aText = pVCLMenu-GetItemText( nId );
-//String aCommand = pVCLMenu-GetItemCommand( nId );
-//sal_Bool itemEnabled = pVCLMenu-IsItemEnabled( nId );
-//KeyCode nAccelKey = pVCLMenu-GetAccelKey( nId );
-//sal_Bool itemChecked = pVCLMenu-IsItemChecked( nId );
-
-//// Force updating of native menu labels.
-//pMenu-SetItemCommand( i, pSalMenuItem, aCommand );
-//pMenu-SetItemText( i, pSalMenuItem, aText );
-//pMenu-EnableItem( i, itemEnabled );
-//pMenu-SetAccelerator( i, pSalMenuItem, nAccelKey,
nAccelKey.GetName( pMenu-GetFrame()-GetWindow() ) );
-//pMenu-CheckItem( i, itemChecked );
-
-//GtkSalMenu* pSubmenu = pSalMenuItem-mpSubMenu;
-
-//if ( pSubmenu pSubmenu-GetMenu() ) {
-//pSubmenu-GetMenu()-Activate();
-//pSubmenu-GetMenu()-Deactivate();
-//UpdateNativeMenu( pSubmenu );
-//}
-//}
-//}
static void UpdateNativeMenu( GtkSalMenu* pMenu )
{
@@ -592,7 +533,6 @@ void GtkSalMenu::SetNativeItemCommand( unsigned nSection,
unsigned nItemPos, Gtk
if ( aCurrentCommand == NULL || g_strcmp0( aCurrentCommand, aCommand ) !=
0 )
{
-cout __FUNCTION__ endl;
g_lo_menu_set_command_to_item_in_section( pMenu, nSection, nItemPos,
aCommand );
gchar* aItemCommand = g_strconcat(win., aCommand, NULL );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/inc i18npool/Package_inc.mk
i18npool/Package_inc.mk |1 +
i18npool/inc/i18npool/languagetag.hxx |3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit ba7afe4e8ebf55d35300c7fbb4cc6937798b2d60
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 11:58:32 2012 +0100
export LanguageTag header and class
Change-Id: Idaf2c48cc6f291199973fd910d3c8ddf29774c6e
diff --git a/i18npool/Package_inc.mk b/i18npool/Package_inc.mk
index 69eaf0c..140edc9 100644
--- a/i18npool/Package_inc.mk
+++ b/i18npool/Package_inc.mk
@@ -30,6 +30,7 @@ $(eval $(call
gb_Package_Package,i18npool_inc,$(SRCDIR)/i18npool/inc))
$(eval $(call
gb_Package_add_file,i18npool_inc,inc/i18npool/i18npooldllapi.h,i18npool/i18npooldllapi.h))
$(eval $(call
gb_Package_add_file,i18npool_inc,inc/i18npool/lang.h,i18npool/lang.h))
+$(eval $(call
gb_Package_add_file,i18npool_inc,inc/i18npool/languagetag.hxx,i18npool/languagetag.hxx))
$(eval $(call
gb_Package_add_file,i18npool_inc,inc/i18npool/mslangid.hxx,i18npool/mslangid.hxx))
# vim: set noet sw=4 ts=4:
diff --git a/i18npool/inc/i18npool/languagetag.hxx
b/i18npool/inc/i18npool/languagetag.hxx
index 0066d8e..d8eb207 100644
--- a/i18npool/inc/i18npool/languagetag.hxx
+++ b/i18npool/inc/i18npool/languagetag.hxx
@@ -13,6 +13,7 @@
#include sal/config.h
#include rtl/ustring.hxx
#include com/sun/star/lang/Locale.hpp
+#include i18npool/i18npooldllapi.h
#include i18npool/lang.h
@@ -23,7 +24,7 @@
const methods. Getter methods return either the original value or matching
converted values.
*/
-class LanguageTag
+class I18NISOLANG_DLLPUBLIC LanguageTag
{
public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/source
i18npool/source/languagetag/languagetag.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 7e36822b706f3da04cec7c57d319b06a5f2e07df
Author: Eike Rathke er...@redhat.com
Date: Fri Aug 31 13:20:17 2012 +0200
removed nonsense incRef() in operator=()
Change-Id: I62e330ff47a60cc0acaf6deb3cd1011c7deb3f45
diff --git a/i18npool/source/languagetag/languagetag.cxx
b/i18npool/source/languagetag/languagetag.cxx
index 9eae6ea..9c64b7c 100644
--- a/i18npool/source/languagetag/languagetag.cxx
+++ b/i18npool/source/languagetag/languagetag.cxx
@@ -249,8 +249,6 @@ LanguageTag::LanguageTag( const LanguageTag rLanguageTag )
LanguageTag LanguageTag::operator=( const LanguageTag rLanguageTag )
{
-theDataRef.incRef();
-
maLocale= rLanguageTag.maLocale;
maBcp47 = rLanguageTag.maBcp47;
maCachedLanguage= rLanguageTag.maCachedLanguage;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/unitymenus' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtksalmenu.hxx|7 +++---
vcl/unx/gtk/window/gtksalmenu.cxx | 43 --
2 files changed, 45 insertions(+), 5 deletions(-)
New commits:
commit 5645ed605633bf866468c35310d4e0aebe5f88c2
Author: Antonio Fernandez antonio.fernan...@aentos.es
Date: Fri Aug 31 12:28:33 2012 +0100
Added code for special items.
Change-Id: I8fb03bee33da052654559329a84d9a753d091ae1
diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx
index 5525b19..2d4cbe3 100644
--- a/vcl/inc/unx/gtk/gtksalmenu.hxx
+++ b/vcl/inc/unx/gtk/gtksalmenu.hxx
@@ -86,9 +86,10 @@ public:
virtual voidSetActionGroup( GActionGroup* pActionGroup ) {
mpActionGroup = pActionGroup; }
virtual GActionGroup* GetActionGroup() { return mpActionGroup; }
-virtual voidSetNativeItemText( unsigned nSection, unsigned
nItemPos, const rtl::OUString rText );
-virtual voidSetNativeItemCommand( unsigned nSection,
unsigned nItemPos, GtkSalMenuItem* pItem, const gchar* aCommandStr );
-virtual voidSetNativeEnableItem( gchar* aCommand, gboolean
bEnable );
+voidSetNativeItemText( unsigned nSection, unsigned
nItemPos, const rtl::OUString rText );
+voidSetNativeItemCommand( unsigned nSection,
unsigned nItemPos, GtkSalMenuItem* pItem, const gchar* aCommandStr );
+voidSetNativeEnableItem( gchar* aCommand, gboolean
bEnable );
+voidNativeCheckItem( unsigned nSection, unsigned
nItemPos, GtkSalMenuItem* pItem, gboolean bCheck );
};
class GtkSalMenuItem : public SalMenuItem
diff --git a/vcl/unx/gtk/window/gtksalmenu.cxx
b/vcl/unx/gtk/window/gtksalmenu.cxx
index ca3e9ef..f098d76 100644
--- a/vcl/unx/gtk/window/gtksalmenu.cxx
+++ b/vcl/unx/gtk/window/gtksalmenu.cxx
@@ -93,7 +93,7 @@ static void UpdateNativeMenu( GtkSalMenu* pMenu )
{
pMenu-SetNativeItemCommand( nSection, nItemPos, pSalMenuItem,
aNativeCommand );
pMenu-SetNativeEnableItem( aNativeCommand, bEnabled );
-//pMenu-CheckItem( nItem, itemChecked );
+pMenu-NativeCheckItem( nSection, nItemPos, pSalMenuItem, bChecked
);
}
g_free( aNativeCommand );
@@ -269,7 +269,7 @@ GtkSalMenu::~GtkSalMenu()
sal_Bool GtkSalMenu::VisibleMenuBar()
{
-return sal_False;
+return sal_True;
}
void GtkSalMenu::InsertItem( SalMenuItem* pSalMenuItem, unsigned nPos )
@@ -429,6 +429,45 @@ void GtkSalMenu::CheckItem( unsigned nPos, sal_Bool bCheck
)
//g_free( aCommand );
}
+void GtkSalMenu::NativeCheckItem( unsigned nSection, unsigned nItemPos,
GtkSalMenuItem* pItem, gboolean bCheck )
+{
+gchar* aCommand = g_lo_menu_get_command_from_item_in_section( G_LO_MENU(
mpMenuModel ), nSection, nItemPos );
+
+if ( aCommand == NULL g_strcmp0( aCommand, ) != 0 )
+{
+if ( mpActionGroup != NULL )
+{
+GVariant *pCheckValue = NULL;
+
+// FIXME: Why pItem-mnBits differs from GetItemBits value?
+MenuItemBits bits = pItem-mpVCLMenu-GetItemBits( pItem-mnId );
+
+if ( bits MIB_CHECKABLE ) {
+GVariant* pState = g_action_group_get_action_state(
mpActionGroup, aCommand );
+gboolean bCurrentState = g_variant_get_boolean( pState );
+
+if ( bCurrentState != bCheck )
+pCheckValue = g_variant_new_boolean( bCheck );
+}
+else if ( bits MIB_RADIOCHECK )
+{
+GVariant* pState = g_action_group_get_action_state(
mpActionGroup, aCommand );
+gchar* aCurrentState = (gchar*) g_variant_get_string( pState,
NULL );
+gboolean bCurrentState = g_strcmp0( aCurrentState, ) != 0;
+
+if ( bCurrentState != bCheck )
+pCheckValue = ( bCheck == TRUE ) ? g_variant_new_string(
aCommand ) : g_variant_new_string( );
+}
+
+if ( pCheckValue )
+g_action_group_change_action_state( mpActionGroup, aCommand,
pCheckValue );
+}
+}
+
+if ( aCommand )
+g_free( aCommand );
+}
+
void GtkSalMenu::EnableItem( unsigned nPos, sal_Bool bEnable )
{
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: android/experimental
android/experimental/LibreOffice4Android/Makefile |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 0d6e3a01a57146a74520c551b3cd316640cea0b7
Author: Tor Lillqvist t...@iki.fi
Date: Fri Aug 31 13:56:06 2012 +0300
Add offapi.rdb and oovbaapi.rdb
Change-Id: I58809d549dc4da2f709397d0d6a2b307d75d8885
diff --git a/android/experimental/LibreOffice4Android/Makefile
b/android/experimental/LibreOffice4Android/Makefile
index 20253ac..fd45641 100644
--- a/android/experimental/LibreOffice4Android/Makefile
+++ b/android/experimental/LibreOffice4Android/Makefile
@@ -116,6 +116,8 @@ copy-stuff:
#
mkdir -p assets/bin/ure assets/lib assets/program assets/xml/ure
assets/ComponentTarget/i18npool/util
cp $(OUTDIR)/bin/udkapi.rdb assets/bin
+ cp $(OUTDIR)/bin/offapi.rdb assets/bin
+ cp $(OUTDIR)/bin/oovbaapi.rdb assets/bin
cp $(OUTDIR)/bin/types.rdb assets/bin
cp $(OUTDIR)/bin/ure/types.rdb assets/bin/ure
# For some reason the vnd.sun.star.expand:$LO_LIB_DIR doesn't seem to work, it
expands to empty!?
@@ -156,7 +158,7 @@ copy-stuff:
echo 'BRAND_BASE_DIR=file:///assets' assets/program/fundamentalrc
echo 'CONFIGURATION_LAYERS=xcsxcu:$${BRAND_BASE_DIR}/share/registry
module:$${BRAND_BASE_DIR}/share/registry/modules
res:$${BRAND_BASE_DIR}/share/registry' assets/program/fundamentalrc
echo
'URE_BIN_DIR=file:///assets/ure/bin/dir/not-here/can-we/exec-anyway'
assets/program/fundamentalrc
- echo 'URE_MORE_TYPES=file:///assets/bin/ure/types.rdb
file:///assets/bin/types.rdb' assets/program/fundamentalrc
+ echo 'URE_MORE_TYPES=file:///assets/bin/ure/types.rdb
file:///assets/bin/types.rdb file:///assets/bin/offapi.rdb
file:///assets/bin/oovbaapi.rdb' assets/program/fundamentalrc
echo 'URE_MORE_SERVICES=file:///assets/xml/services.rdb
$$BRAND_BASE_DIR/program/services*' assets/program/fundamentalrc
#
# Set up unorc
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Basic IDE: Docking property browser under object catalog
From János Uray uray.ja...@gmail.com: János Uray has uploaded a new change for review. Change subject: Basic IDE: Docking property browser under object catalog .. Basic IDE: Docking property browser under object catalog Now the property browser can be docked in the same way as all other dialogs in the Basic IDE and the Dialog Editor. The property browser (PropBrw, for which PropertyBrowser would be a better and easier-to-remember name IMO) is derived from basctl::DockingWindow instead of SfxDockingWindow. PropBrwMgr was removed (it seemed to be only a wrapper), and PropBrw is now a data member of DialogWindowLayout (aPropertyBrowser). Change-Id: I06737a5cbc985888432630714cb919d1bbbcbb49 --- M basctl/source/basicide/baside2.cxx M basctl/source/basicide/baside3.cxx M basctl/source/basicide/basides1.cxx M basctl/source/basicide/iderdll.cxx M basctl/source/basicide/layout.hxx M basctl/source/dlged/dlged.cxx M basctl/source/dlged/propbrw.cxx M basctl/source/inc/baside3.hxx M basctl/source/inc/dlged.hxx M basctl/source/inc/propbrw.hxx 10 files changed, 71 insertions(+), 109 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/518/1 -- To view, visit https://gerrit.libreoffice.org/518 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06737a5cbc985888432630714cb919d1bbbcbb49 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: János Uray uray.ja...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: vcl/generic
vcl/generic/fontmanager/fontconfig.cxx | 63 -
1 file changed, 39 insertions(+), 24 deletions(-)
New commits:
commit fab0a2c6068577081abdad90a3b1191b6fc5df29
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 13:17:55 2012 +0100
workaround fdo#35118 in the absence of fdo#19869
Change-Id: Ie87671bbb9a7c883651a9467b9364dbbcd0da9a1
diff --git a/vcl/generic/fontmanager/fontconfig.cxx
b/vcl/generic/fontmanager/fontconfig.cxx
index fbe18dd..a90ecaf 100644
--- a/vcl/generic/fontmanager/fontconfig.cxx
+++ b/vcl/generic/fontmanager/fontconfig.cxx
@@ -32,7 +32,7 @@
#include vcl/fontmanager.hxx
#include vcl/vclenum.hxx
#include outfont.hxx
-#include i18npool/mslangid.hxx
+#include i18npool/languagetag.hxx
using namespace psp;
@@ -777,6 +777,37 @@ static void addtopattern(FcPattern *pPattern,
}
}
+namespace
+{
+//Someday fontconfig will hopefully use bcp47, see fdo#19869
+//In the meantime try something that will fit to workaround fdo#35118
+OString mapToFontConfigLangTag(const LanguageTag rLangTag)
+{
+FcStrSet *pLangSet = FcGetLangs();
+OString sLangAttrib;
+
+sLangAttrib = OUStringToOString(rLangTag.getBcp47(),
RTL_TEXTENCODING_UTF8).toAsciiLowerCase();
+if (FcStrSetMember(pLangSet, (const FcChar8*)sLangAttrib.getStr()))
+return sLangAttrib;
+
+sLangAttrib = OUStringToOString(rLangTag.getLanguageAndScript(),
RTL_TEXTENCODING_UTF8).toAsciiLowerCase();
+if (FcStrSetMember(pLangSet, (const FcChar8*)sLangAttrib.getStr()))
+return sLangAttrib;
+
+OString sLang = OUStringToOString(rLangTag.getLanguage(),
RTL_TEXTENCODING_UTF8).toAsciiLowerCase();
+OString sRegion = OUStringToOString(rLangTag.getCountry(),
RTL_TEXTENCODING_UTF8).toAsciiLowerCase();
+
+sLangAttrib = sLang + OString('-') + sRegion;
+if (FcStrSetMember(pLangSet, (const FcChar8*)sLangAttrib.getStr()))
+return sLangAttrib;
+
+if (FcStrSetMember(pLangSet, (const FcChar8*)sLang.getStr()))
+return sLangAttrib;
+
+return OString();
+}
+}
+
bool PrintFontManager::Substitute( FontSelectPattern rPattern, rtl::OUString
rMissingCodes )
{
bool bRet = false;
@@ -793,16 +824,10 @@ bool PrintFontManager::Substitute( FontSelectPattern
rPattern, rtl::OUString r
const FcChar8* pTargetNameUtf8 = (FcChar8*)aTargetName.getStr();
FcPatternAddString(pPattern, FC_FAMILY, pTargetNameUtf8);
-const rtl::OString aLangAttrib =
MsLangId::convertLanguageToIsoByteString(rPattern.meLanguage);
-if( !aLangAttrib.isEmpty() )
-{
-const FcChar8* pLangAttribUtf8;
-if
(aLangAttrib.equalsIgnoreAsciiCase(OString(RTL_CONSTASCII_STRINGPARAM(pa-in
-pLangAttribUtf8 = (FcChar8*)pa;
-else
-pLangAttribUtf8 = (FcChar8*)aLangAttrib.getStr();
-FcPatternAddString(pPattern, FC_LANG, pLangAttribUtf8);
-}
+const LanguageTag aLangTag(rPattern.meLanguage);
+const rtl::OString aLangAttrib = mapToFontConfigLangTag(aLangTag);
+if (!aLangAttrib.isEmpty())
+FcPatternAddString(pPattern, FC_LANG, (FcChar8*)aLangAttrib.getStr());
// Add required Unicode characters, if any
if ( !rMissingCodes.isEmpty() )
@@ -1040,20 +1065,10 @@ bool PrintFontManager::matchFont( FastPrintFontInfo
rInfo, const com::sun::star
FcConfig* pConfig = FcConfigGetCurrent();
FcPattern* pPattern = FcPatternCreate();
-OString aLangAttrib;
// populate pattern with font characteristics
-if( !rLocale.Language.isEmpty() )
-{
-OUStringBuffer aLang(6);
-aLang.append( rLocale.Language );
-if( !rLocale.Country.isEmpty() )
-{
-aLang.append( sal_Unicode('-') );
-aLang.append( rLocale.Country );
-}
-aLangAttrib = OUStringToOString( aLang.makeStringAndClear(),
RTL_TEXTENCODING_UTF8 );
-}
-if( !aLangAttrib.isEmpty() )
+const LanguageTag aLangTag(rLocale);
+const rtl::OString aLangAttrib = mapToFontConfigLangTag(aLangTag);
+if (!aLangAttrib.isEmpty())
FcPatternAddString(pPattern, FC_LANG, (FcChar8*)aLangAttrib.getStr());
OString aFamily = OUStringToOString( rInfo.m_aFamilyName,
RTL_TEXTENCODING_UTF8 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/source solenv/gbuild
i18npool/source/languagetag/languagetag.cxx |3 ++-
solenv/gbuild/CppunitTest.mk|1 +
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit f7347f2eddb9e0b1dc1e3478e9f1efe07355067e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Aug 31 13:41:26 2012 +0100
stuff in a mechanism to find the liblangtag share dir during unit tests
Change-Id: Idf67c3dfbff7ee5c13831159a913ce8a517732ca
diff --git a/i18npool/source/languagetag/languagetag.cxx
b/i18npool/source/languagetag/languagetag.cxx
index 9c64b7c..df1533b 100644
--- a/i18npool/source/languagetag/languagetag.cxx
+++ b/i18npool/source/languagetag/languagetag.cxx
@@ -114,7 +114,8 @@ void LiblantagDataRef::setupDataPath()
{
// maDataPath is assumed to be empty here.
OUString aURL;
-if (!rtl::Bootstrap::get( BRAND_BASE_DIR, aURL))
+
+if (!rtl::Bootstrap::get(BRAND_BASE_DIR, aURL)
!rtl::Bootstrap::get(LIBLANGTAG_SHARE, aURL))
OSL_FAIL( LiblantagDataRef: can't get BRAND_BASE_DIR);
else
{
diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk
index feaec22..ef8f320 100644
--- a/solenv/gbuild/CppunitTest.mk
+++ b/solenv/gbuild/CppunitTest.mk
@@ -59,6 +59,7 @@ gb_CppunitTest__get_linktargetname = CppunitTest/$(call
gb_CppunitTest_get_filen
define gb_CppunitTest__make_args
--headless \
+-env:LIBLANGTAG_SHARE=$(call gb_Helper_make_url,$(OUTDIR)) \
$(if $(URE),\
$(if $(strip $(CONFIGURATION_LAYERS)),\
-env:CONFIGURATION_LAYERS=$(strip $(CONFIGURATION_LAYERS))) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Change in core[feature/killsdf]: Make Regexpr class safer
From Zolnai Tamás zolnaitamas2...@gmail.com: Zolnai Tamás has uploaded a new change for review. Change subject: Make Regexpr class safer .. Make Regexpr class safer Make copy constructor and copy operator private Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94 --- M regexp/inc/regexp/reclass.hxx 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/519/1 -- To view, visit https://gerrit.libreoffice.org/519 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#44925: list box contents should be same direction/alignment as sheet, not the interface
Hello,
Could you please review the attached patch.
Thank you.
Regards,
Manal M. Alhassoun
Motah Program, KACST
http://www.motah.org.sa
Warning: This message and its attachment, if any, are confidential and may
contain information protected by law. If you are not the intended recipient,
please contact the sender immediately and delete the message and its
attachment, if any. You should not copy the message and its attachment, if any,
or disclose its contents to any other person or use it for any purpose.
Statements and opinions expressed in this e-mail and its attachment, if any,
are those of the sender, and do not necessarily reflect those of King Abdulaziz
city for Science and Technology (KACST) in the Kingdom of Saudi Arabia. KACST
accepts no liability for any damage caused by this email.
?: ??? ??? ??? ? ?? ?? (?? ) ? ?? ? ???
??? ? ? ???. ??? ?? ??? ? ?? ???
? ??? ?? ? ??? ? (?? )? ??? ??
??? ?? ? ??? ??? ?? (?? ) ?? ?? ??? ? ?? ?
?? ? ?? ? ??? ???. ? ??? ??? ??? ? (??
) ?? ??? ??? ??? ? ? ? ??
??? ? ??? ? ??? ?? ??? ?? ???
??? ?? ?? ?? ?? ??? ??.
From 9d1dbdad4035cc44e7f14fed25fba97ae8dfbf85 Mon Sep 17 00:00:00 2001
From: Manal Alhassoun malhass...@kacst.edu.sa
Date: Thu, 30 Aug 2012 22:46:38 +0300
Subject: [PATCH] fdo#44925
Change-Id: Ieb4aa3e1dbfa46c58352eefe951ee404efd1ad1f
---
sc/source/ui/view/gridwin.cxx | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index d823937..8640993 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1187,8 +1187,17 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec
pFilterFloat-SetPopupModeEndHdl( LINK( this, ScGridWindow, PopupModeEndHdl ) );
pFilterBox = new ScFilterListBox(
pFilterFloat, this, nCol, nRow, bDataSelect ? SC_FILTERBOX_DATASELECT : SC_FILTERBOX_FILTER );
-if ( bLayoutRTL )
+// Fix for bug #44925
+if(Application::GetSettings().GetLayoutRTL())
+{
+ if ( !bLayoutRTL )
+pFilterBox-EnableMirroring();
+}
+else
+{
+ if ( bLayoutRTL )
pFilterBox-EnableMirroring();
+}
nSizeX += 1;
--
1.7.7.6
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Help Locating Base Code
On Wed, Aug 22, 2012 at 08:20:45AM -0700, Joel Madero wrote: Thanks for letting me know it's Lionel :) In general, you can find subject-specific experts listed at http://wiki.documentfoundation.org/FindTheExpert I told Rafael yesterday in the chat that just because I enjoy being angry (actually just enjoy a good challenge) I'll probably assign myself another base bug in the coming weeks and spend 20 hours to fix one line ;) Don't be too disappointed by this asymmetry; it is often like that: finding *where* to fix is harder than actually fixing :) On Wed, Aug 22, 2012 at 12:16 AM, Jan Holesovsky ke...@suse.cz wrote: On 2012-08-21 at 11:10 -0700, Joel Madero wrote: Thanks to everyone who helped me along the way. The code actually ended up being in formcomponenthandler.cxx, FormComponentPropertyHandler::impl_browseImage_nothrow. Great to hear; I hope I did not mislead you too much - that was the other occurrence of FILEOPEN_LINK_PREVIEW/CHECKBOX_LINK :-) I think we need to start looking for a database expert, someone who enjoys it and is willing to get into the grit of the crappy code. Any takers ? ;) Oh - database expert, that's Lionel :-) But of course, having more database experts would be great! I'll get the patch done tonight after I clear all the other stuff I was testing with, going to attempt gerritt for the first time. Looking forward to the patch! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/unitymenus' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtksalmenu.hxx|7 ++-
vcl/unx/gtk/window/gtksalmenu.cxx | 75 +++---
2 files changed, 26 insertions(+), 56 deletions(-)
New commits:
commit 91f332524f3b632b3e96d69921e2593c161f0ea5
Author: Antonio Fernandez antonio.fernan...@aentos.es
Date: Fri Aug 31 14:41:26 2012 +0100
Added code for accelerators.
Change-Id: I427b15dd6faca18d34d94ba0a25fd8b6b9844bea
diff --git a/vcl/inc/unx/gtk/gtksalmenu.hxx b/vcl/inc/unx/gtk/gtksalmenu.hxx
index 2d4cbe3..dc30260 100644
--- a/vcl/inc/unx/gtk/gtksalmenu.hxx
+++ b/vcl/inc/unx/gtk/gtksalmenu.hxx
@@ -86,10 +86,11 @@ public:
virtual voidSetActionGroup( GActionGroup* pActionGroup ) {
mpActionGroup = pActionGroup; }
virtual GActionGroup* GetActionGroup() { return mpActionGroup; }
-voidSetNativeItemText( unsigned nSection, unsigned
nItemPos, const rtl::OUString rText );
-voidSetNativeItemCommand( unsigned nSection,
unsigned nItemPos, GtkSalMenuItem* pItem, const gchar* aCommandStr );
-voidSetNativeEnableItem( gchar* aCommand, gboolean
bEnable );
+voidNativeSetItemText( unsigned nSection, unsigned
nItemPos, const rtl::OUString rText );
+voidNativeSetItemCommand( unsigned nSection,
unsigned nItemPos, GtkSalMenuItem* pItem, const gchar* aCommandStr );
+voidNativeSetEnableItem( gchar* aCommand, gboolean
bEnable );
voidNativeCheckItem( unsigned nSection, unsigned
nItemPos, GtkSalMenuItem* pItem, gboolean bCheck );
+voidNativeSetAccelerator( unsigned nSection,
unsigned nItemPos, const KeyCode rKeyCode, const rtl::OUString rKeyName );
};
class GtkSalMenuItem : public SalMenuItem
diff --git a/vcl/unx/gtk/window/gtksalmenu.cxx
b/vcl/unx/gtk/window/gtksalmenu.cxx
index f098d76..7312699 100644
--- a/vcl/unx/gtk/window/gtksalmenu.cxx
+++ b/vcl/unx/gtk/window/gtksalmenu.cxx
@@ -86,13 +86,13 @@ static void UpdateNativeMenu( GtkSalMenu* pMenu )
gchar* aNativeCommand = g_strdup( rtl::OUStringToOString( aCommand,
RTL_TEXTENCODING_UTF8 ).getStr() );
// Force updating of native menu labels.
-pMenu-SetNativeItemText( nSection, nItemPos, aText );
+pMenu-NativeSetItemText( nSection, nItemPos, aText );
pMenu-SetAccelerator( nItem, pSalMenuItem, nAccelKey,
nAccelKey.GetName( pMenu-GetFrame()-GetWindow() ) );
if ( g_strcmp0( aNativeCommand, ) != 0
pSalMenuItem-mpVCLMenu-GetPopupMenu( nId ) == NULL )
{
-pMenu-SetNativeItemCommand( nSection, nItemPos, pSalMenuItem,
aNativeCommand );
-pMenu-SetNativeEnableItem( aNativeCommand, bEnabled );
+pMenu-NativeSetItemCommand( nSection, nItemPos, pSalMenuItem,
aNativeCommand );
+pMenu-NativeSetEnableItem( aNativeCommand, bEnabled );
pMenu-NativeCheckItem( nSection, nItemPos, pSalMenuItem, bChecked
);
}
@@ -380,53 +380,6 @@ const GtkSalFrame* GtkSalMenu::GetFrame() const
void GtkSalMenu::CheckItem( unsigned nPos, sal_Bool bCheck )
{
-//GtkSalMenuItem* pItem = maItems[ nPos ];
-
-//if ( pItem-mpSubMenu )
-//return;
-
-//unsigned nSection, nItemPos;
-//GetItemSectionAndPosition( nPos, nSection, nItemPos );
-
-//gchar* aCommand = g_lo_menu_get_command_from_item_in_section( G_LO_MENU(
mpMenuModel ), nSection, nItemPos );
-
-//if ( aCommand == NULL g_strcmp0( aCommand, ) != 0 )
-//{
-//GActionGroup* pActionGroup = GetActionGroupFromMenubar( this );
-
-//if ( pActionGroup != NULL )
-//{
-
-//GVariant *pCheckValue = NULL;
-//gboolean bCheckedValue = ( bCheck == sal_True ) ? TRUE : FALSE;
-
-//// FIXME: Why pItem-mnBits differs from GetItemBits value?
-//MenuItemBits bits = pItem-mpVCLMenu-GetItemBits( pItem-mnId );
-
-//if ( bits MIB_CHECKABLE ) {
-//GVariant* pState = g_action_group_get_action_state(
pActionGroup, aCommand );
-//gboolean bCurrentState = g_variant_get_boolean( pState );
-
-//if ( bCurrentState != bCheck )
-//pCheckValue = g_variant_new_boolean( bCheckedValue );
-//}
-//else if ( bits MIB_RADIOCHECK )
-//{
-//GVariant* pState = g_action_group_get_action_state(
pActionGroup, aCommand );
-//gchar* aCurrentState = (gchar*) g_variant_get_string(
pState, NULL );
-//gboolean bCurrentState = g_strcmp0( aCurrentState, ) != 0;
-
-//if ( bCurrentState != bCheck )
-//pCheckValue = (bCheckedValue) ? g_variant_new_string(
aCommand ) : g_variant_new_string( );
-//}
-
-//if ( pCheckValue )
-//g_action_group_change_action_state(
[Libreoffice-commits] .: 5 commits - sc/inc sc/source
sc/inc/conditio.hxx |2
sc/inc/rangelst.hxx |8
sc/source/core/data/conditio.cxx | 22 ++
sc/source/core/data/table2.cxx| 11 +
sc/source/core/tool/rangelst.cxx | 329 ++
sc/source/filter/oox/condformatbuffer.cxx |1
sc/source/ui/condformat/condformatdlg.cxx |4
7 files changed, 375 insertions(+), 2 deletions(-)
New commits:
commit 10efe1bcedfa450e95cbc3f08642d239ba2ab579
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Aug 31 04:29:49 2012 +0200
handle missing cond format entries more gracefully, related fdo#52340
Change-Id: Id1cf7d99a13c04541e87ad00c5418dd4f766d268
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 12c9212..afb9c6b 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -669,6 +669,12 @@ void ScTable::CopyConditionalFormat( SCCOL nCol1, SCROW
nRow1, SCCOL nCol2, SCRO
if (aOldIdToNewId.find(nId) == aOldIdToNewId.end())
{
ScConditionalFormat* pFormat =
pOldCondFormatList-GetFormat(nId);
+if(!pFormat)
+{
+// may happen in some strange circumstances where cell
storage and
+// cond format storage are not in sync
+continue;
+}
ScConditionalFormat* pNewFormat = pFormat-Clone(pDocument);
pNewFormat-SetKey(0);
//not in list = create entries in both maps and new format
commit 3cf91a21fc5089fb7f051bf8a04d2049da88179f
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Aug 31 04:25:47 2012 +0200
use Red as error color for cond format dlg
Change-Id: I1526a8d1f2999742f28600e771891e1489d62f4b
diff --git a/sc/source/ui/condformat/condformatdlg.cxx
b/sc/source/ui/condformat/condformatdlg.cxx
index a84103c..1f9d638 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -836,7 +836,7 @@ IMPL_LINK_NOARG(ScCondFrmtEntry, TypeListHdl)
SetHeight();
return 0;
}
-
+#include iostream
IMPL_LINK(ScCondFrmtEntry, EdModifyHdl, Edit*, pEdit)
{
rtl::OUString aFormula = pEdit-GetText();
@@ -845,7 +845,7 @@ IMPL_LINK(ScCondFrmtEntry, EdModifyHdl, Edit*, pEdit)
boost::scoped_ptrScTokenArray mpCode(aComp.CompileString(aFormula));
if(mpCode-GetCodeError())
{
-
pEdit-SetControlBackground(GetSettings().GetStyleSettings().GetHighlightColor());
+pEdit-SetControlBackground(COL_RED);
}
else
{
commit a3c4ee1653166ee2ac1f1b9d65ff1065b6288ebc
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Aug 31 04:02:10 2012 +0200
update cond formats for deleting, moving and cutpaste
Change-Id: I52987e957918853bcd1abd1460c6166b52454d62
diff --git a/sc/inc/conditio.hxx b/sc/inc/conditio.hxx
index 4967e82..9890758 100644
--- a/sc/inc/conditio.hxx
+++ b/sc/inc/conditio.hxx
@@ -290,6 +290,7 @@ public:
voidCompileXML();
voidUpdateReference( UpdateRefMode eUpdateRefMode,
const ScRange rRange, SCsCOL nDx, SCsROW nDy,
SCsTAB nDz );
+voidDeleteArea( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW
nRow2 );
voidUpdateMoveTab( SCTAB nOldPos, SCTAB nNewPos );
voidRenameCellStyle( const String rOld, const String rNew );
@@ -349,6 +350,7 @@ public:
const ScRange rRange, SCsCOL nDx, SCsROW nDy,
SCsTAB nDz );
voidRenameCellStyle( const String rOld, const String rNew );
voidUpdateMoveTab( SCTAB nOldPos, SCTAB nNewPos );
+voidDeleteArea( SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2 );
voidSourceChanged( const ScAddress rAddr );
diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index 4a842fb..17483c3 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -1471,6 +1471,12 @@ void ScConditionalFormat::UpdateReference( UpdateRefMode
eUpdateRefMode,
itr-UpdateReference(eUpdateRefMode, rRange, nDx, nDy, nDz);
}
+void ScConditionalFormat::DeleteArea( SCCOL nCol1, SCROW nRow1, SCCOL nCol2,
SCROW nRow2 )
+{
+SCTAB nTab = maRanges[0]-aStart.Tab();
+maRanges.DeleteArea( nCol1, nRow1, nTab, nCol2, nRow2, nTab );
+}
+
void ScConditionalFormat::RenameCellStyle(const String rOld, const String
rNew)
{
for(CondFormatContainer::iterator itr = maEntries.begin(); itr !=
maEntries.end(); ++itr)
@@ -1626,6 +1632,22 @@ void ScConditionalFormatList::UpdateMoveTab( SCTAB
nOldPos, SCTAB nNewPos )
itr-UpdateMoveTab( nOldPos, nNewPos );
}
+void ScConditionalFormatList::DeleteArea( SCCOL nCol1, SCROW nRow1, SCCOL
nCol2, SCROW nRow2 )
+{
+for( iterator itr = begin(); itr != end(); ++itr)
+
[Libreoffice-commits] .: configure.in cui/source icon-themes/README icon-themes/tango_testing officecfg/registry scp2/source vcl/inc vcl/source
configure.in | 31 ++--- cui/source/options/optgdlg.src |1 icon-themes/README | 18 +-- icon-themes/tango_testing/cmd/sc_insertgraphic.png |binary icon-themes/tango_testing/cmd/sc_insertsection.png |binary officecfg/registry/schema/org/openoffice/Office/Common.xcs |5 ++ scp2/source/ooo/file_ooo.scp |9 +++ scp2/source/ooo/module_hidden_ooo.scp |3 + vcl/inc/vcl/settings.hxx |5 +- vcl/source/app/settings.cxx|3 + 10 files changed, 52 insertions(+), 23 deletions(-) New commits: commit 4b27695fea841d54f7f6407b873bbd33709eeab5 Author: Petr Mladek pmla...@suse.cz Date: Fri Aug 31 15:43:46 2012 +0200 add Tango Testing icon theme It is enabled by default for dev build. It will be used for reworking the Tango theme by the design team. The them was requested by Stefan Knorr (Astron) heinzlesspam at gmail dot com The two intial icons are from Alexander Wilms alexander dot wilms at zoho dot com Change-Id: I9205a3164352442a2cdc02e75e58b15b327dfbd3 diff --git a/configure.in b/configure.in index e14fb66..4e87f1a 100644 --- a/configure.in +++ b/configure.in @@ -1153,7 +1153,7 @@ AC_ARG_WITH(vba-package-format, AC_ARG_WITH(theme, AS_HELP_STRING([--with-theme=theme1 theme2...], [Choose which themes to include. By default those themes with an '*' are included. - Possible choices: *crystal, *default (galaxy), *hicontrast, human, industrial, *oxygen, *tango.]), + Possible choices: *crystal, *default (galaxy), *hicontrast, human, industrial, *oxygen, *tango, *tango_testing.]), ,) AC_ARG_WITH(helppack-integration, @@ -2075,6 +2075,19 @@ AC_ARG_WITH(check-jobs, ,) dnl === +dnl Test whether build target is Release Build +dnl === +AC_MSG_CHECKING([whether build target is Release Build]) +if test $enable_release_build = -o $enable_release_build = no; then +AC_MSG_RESULT([no]) +ENABLE_RELEASE_BUILD=FALSE +else +AC_MSG_RESULT([yes]) +ENABLE_RELEASE_BUILD=TRUE +fi +AC_SUBST(ENABLE_RELEASE_BUILD) + +dnl === dnl MacOSX build and runtime environment options dnl === @@ -10396,12 +10409,13 @@ AC_MSG_CHECKING([which themes to include]) # if none given use default subset of available themes if test x$with_theme = x -o x$with_theme = xyes; then with_theme=crystal default hicontrast oxygen tango +test $ENABLE_RELEASE_BUILD = FALSE with_theme=$with_theme tango_testing fi WITH_THEMES= for theme in $with_theme; do case $theme in -crystal|default|galaxy|hicontrast|human|industrial|oxygen|tango) : ;; + crystal|default|galaxy|hicontrast|human|industrial|oxygen|tango|tango_testing) : ;; *) AC_MSG_ERROR([Unknown value for --with-theme: $theme]) ;; esac WITH_THEMES=$WITH_THEMES $theme @@ -10863,19 +10877,6 @@ fi AC_SUBST(ENABLE_ONLINE_UPDATE) dnl === -dnl Test whether build target is Release Build -dnl === -AC_MSG_CHECKING([whether build target is Release Build]) -if test $enable_release_build = -o $enable_release_build = no; then -AC_MSG_RESULT([no]) -ENABLE_RELEASE_BUILD=FALSE -else -AC_MSG_RESULT([yes]) -ENABLE_RELEASE_BUILD=TRUE -fi -AC_SUBST(ENABLE_RELEASE_BUILD) - -dnl === dnl Test whether to create MSI with LIMITUI=1 (silent install) dnl === AC_MSG_CHECKING([whether to create MSI with LIMITUI=1 (silent install)]) diff --git a/cui/source/options/optgdlg.src b/cui/source/options/optgdlg.src index 67abcf0..4d0267d 100644 --- a/cui/source/options/optgdlg.src +++ b/cui/source/options/optgdlg.src @@ -267,6 +267,7 @@ TabPage OFA_TP_VIEW Oxygen ; ; Classic ; ; Human ; ; + Tango Testing ; ; }; }; CheckBox CB_SYSTEM_FONT diff --git a/icon-themes/README b/icon-themes/README index 9088715..4fa769b 100644 --- a/icon-themes/README +++ b/icon-themes/README @@ -24,20 +24,24 @@ How to add a new image set: - Create a directory for it here (let's call it e.g. new_set) -- Add its name (new_set) to WITH_THEMES variable + FIXME: It is important to use an underscore '_' to delimit more words. + scp2 compilation crashes when using a dash '-'. + It evidently splits the name into two strings. +
[Libreoffice-commits] .: Branch 'feature/killsdf' - regexp/inc
regexp/inc/regexp/reclass.hxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 574ddaba5315816a5629550a0a12f9c694b79370 Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Fri Aug 31 14:40:14 2012 +0200 Make Regexpr class safer Make copy constructor and copy operator private Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94 Reviewed-on: https://gerrit.libreoffice.org/519 Reviewed-by: Andras Timar ati...@suse.com Tested-by: Andras Timar ati...@suse.com diff --git a/regexp/inc/regexp/reclass.hxx b/regexp/inc/regexp/reclass.hxx index f61112d..4be52bb 100644 --- a/regexp/inc/regexp/reclass.hxx +++ b/regexp/inc/regexp/reclass.hxx @@ -357,6 +357,9 @@ class REGEXP_DLLPUBLIC Regexpr sal_Bool iswordend(const sal_Unicode *d, sal_Unicode *string, sal_Int32 ssize); void set_list_bit(sal_Unicode c, sal_Unicode *b); +Regexpr(const Regexpr); +Regexpr operator=(const Regexpr); + public: // constructors Regexpr( const ::com::sun::star::util::SearchOptions rOptions, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] Change in core[feature/killsdf]: Make Regexpr class safer
From Andras Timar ati...@suse.com: Andras Timar has submitted this change and it was merged. Change subject: Make Regexpr class safer .. Make Regexpr class safer Make copy constructor and copy operator private Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94 --- M regexp/inc/regexp/reclass.hxx 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/519 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com Gerrit-Reviewer: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - configure.in sdext/source
configure.in |4 +++- sdext/source/pdfimport/test/tests.cxx |2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) New commits: commit 7442cf3c4a503394f73cfd930a07982b837513b6 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Aug 31 16:00:01 2012 +0200 Don't fail configure with older gstreamer-plugins-base-0.10 Change-Id: Ia00293747d6041b86975f0e6539246310abfb957 diff --git a/configure.in b/configure.in index 4e87f1a..c954789 100644 --- a/configure.in +++ b/configure.in @@ -9348,7 +9348,9 @@ if test $build_gstreamer_0_10 = yes; then if test x$enable_gstreamer_0_10 != xno; then ENABLE_GSTREAMER_0_10=TRUE AC_MSG_RESULT([yes]) -PKG_CHECK_MODULES( GSTREAMER_0_10, gstreamer-0.10 gstreamer-plugins-base-0.10 gstreamer-interfaces-0.10 ) +PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10 gstreamer-plugins-base-0.10 gstreamer-interfaces-0.10],, [ +PKG_CHECK_MODULES( [GSTREAMER_0_10], [gstreamer-0.10 gstreamer-plugins-base-0.10] ) +]) else AC_MSG_RESULT([no]) fi commit a9b7c8ba65d74d7ee5fef2750ae9e81945b9e1e3 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Thu Aug 30 20:31:58 2012 +0200 Temporary workaround for failing XPDF tests Change-Id: Ic5a0a60068c871dfbe154e8f5fc7a0f622eaad30 diff --git a/sdext/source/pdfimport/test/tests.cxx b/sdext/source/pdfimport/test/tests.cxx index 4be6541..9593d0a 100644 --- a/sdext/source/pdfimport/test/tests.cxx +++ b/sdext/source/pdfimport/test/tests.cxx @@ -121,12 +121,14 @@ namespace CPPUNIT_ASSERT_DOUBLES_EQUAL_MESSAGE( A4 page size (in 100th of points): Height , m_aPageSize.Height, 59500, 0.001 ); CPPUNIT_ASSERT_MESSAGE( endPage() called, m_bPageEnded ); CPPUNIT_ASSERT_EQUAL_MESSAGE( Num pages equal one, m_nNumPages, (sal_Int32) 1 ); +#if 0 CPPUNIT_ASSERT_MESSAGE( Correct hyperlink bounding box, rtl::math::approxEqual(m_aHyperlinkBounds.X1,34.7 ) rtl::math::approxEqual(m_aHyperlinkBounds.Y1,386.0) rtl::math::approxEqual(m_aHyperlinkBounds.X2,166.7) rtl::math::approxEqual(m_aHyperlinkBounds.Y2,406.2) ); CPPUNIT_ASSERT_EQUAL_MESSAGE( Correct hyperlink URI, m_aURI, ::rtl::OUString(http://download.openoffice.org/;) ); +#endif const char* sText = \n \nThis is a testtext\nNew paragraph,\nnew line\n Hyperlink, this is\n?\nThis is more text\noutline mode\n?\nNew paragraph\n; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 52340, which changed state. Bug 52340 Summary: EDITING: CRASH when Copy+Paste row with conditional formatting to other sheet and back to inserted row https://bugs.freedesktop.org/show_bug.cgi?id=52340 What|Old Value |New Value Resolution||FIXED Status|REOPENED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-6] fix related to fdo#52340 , don't crash if cell attribute storage and cond format range get out of sync
Hey, [1] fixes a crash that happens if in an area where cell storage and cond format are out of sync, the cells are copied. I'd like this simple fix in for 3-6 and will try to eliminate all the cases where they get out of sync for 3-7. These involves such nasty commits like [2] so I will not ask for backporting all the fixes to get them in sync. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=10efe1bcedfa450e95cbc3f08642d239ba2ab579 [2] http://cgit.freedesktop.org/libreoffice/core/commit/?id=7222a571d0d458810c1b23871f8b91491db4462d ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/core/tool/rangelst.cxx | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) New commits: commit 0e1e59057d005c9333a49ce7b2ae949a3121c55e Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Aug 31 15:55:43 2012 +0200 remove debug output Change-Id: If6a58b2cf022c704603a3fb01b3ed75d1881f918 diff --git a/sc/source/core/tool/rangelst.cxx b/sc/source/core/tool/rangelst.cxx index 14cf8b4..f9e57b7 100644 --- a/sc/source/core/tool/rangelst.cxx +++ b/sc/source/core/tool/rangelst.cxx @@ -39,8 +39,6 @@ #include compiler.hxx #include stlalgorithm.hxx -#include iostream - using ::std::vector; using ::std::advance; using ::std::find_if; @@ -739,12 +737,12 @@ void ScRangeList::DeleteArea( SCCOL nCol1, SCROW nRow1, SCTAB nTab1, // r.aStart.X() = p.aStart.X() r.aEnd.X() = p.aEnd.X() // ( r.aStart.Y() = p.aStart.Y() || r.aEnd.Y() = r.aEnd.Y() ) if(handleOneRange( aRange, *itr )) -std::cout handled 1 Range case std::endl; +continue; // getting two ranges // r.aStart.X() else if(handleTwoRanges( aRange, *itr, aNewRanges )) -std::cout handled 2 Ranges std::endl; +continue; // getting 3 ranges // r.aStart.X() p.aStart.X() r.aEnd.X() = p.aEnd.X() @@ -753,13 +751,13 @@ void ScRangeList::DeleteArea( SCCOL nCol1, SCROW nRow1, SCTAB nTab1, // r.aStart.X() = p.aStart.X() r.aEnd.X() p.aEnd.X() // r.aStart.Y() p.aStart.Y() r.aEnd.Y() p.aEnd.Y() else if(handleThreeRanges( aRange, *itr, aNewRanges )) -std::cout handled 3 Ranges std::endl; +continue; // getting 4 ranges // r.aStart.X() p.aStart.X() r.aEnd().X() p.aEnd.X() // r.aStart.Y() p.aStart.Y() r.aEnd().Y() p.aEnd.Y() else if(handleFourRanges( aRange, *itr, aNewRanges )) -std::cout handle 4 Ranges std::endl; +continue; } for(vectorScRange::iterator itr = aNewRanges.begin(); itr != aNewRanges.end(); ++itr) Join( *itr, false); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/core/data/table2.cxx |6 ++
1 file changed, 6 insertions(+)
New commits:
commit 4bcd9947774c05df6031e3b2228939150aa8c78b
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Fri Aug 31 04:29:49 2012 +0200
handle missing cond format entries more gracefully, related fdo#52340
Change-Id: Id1cf7d99a13c04541e87ad00c5418dd4f766d268
Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 9dd2afb..21d9307 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -667,6 +667,12 @@ void ScTable::CopyConditionalFormat( SCCOL nCol1, SCROW
nRow1, SCCOL nCol2, SCRO
if (aOldIdToNewId.find(nId) == aOldIdToNewId.end())
{
ScConditionalFormat* pFormat =
pOldCondFormatList-GetFormat(nId);
+if(!pFormat)
+{
+// may happen in some strange circumstances where cell
storage and
+// cond format storage are not in sync
+continue;
+}
ScConditionalFormat* pNewFormat = pFormat-Clone(pDocument);
pNewFormat-SetKey(0);
//not in list = create entries in both maps and new format
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [REVIEW-3-6][PUSHED 3-6] fix related to fdo#52340 , don't crash if cell attribute storage and cond format range get out of sync
On 08/31/2012 10:08 AM, Markus Mohrhard wrote: [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=10efe1bcedfa450e95cbc3f08642d239ba2ab579 Pushed this to 3-6 with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Change in core[feature/killsdf]: Implement more Po method for merge
From Zolnai Tamás zolnaitamas2...@gmail.com: Zolnai Tamás has uploaded a new change for review. Change subject: Implement more Po method for merge .. Implement more Po method for merge Implement file oprerations(entire reading and rest part of writing) Convert text to merge/sdf form Plus cleanup Change-Id: I6bab9bb202fcdc6d0f2a13f6c44d28e22c688e1e --- M l10ntools/Executable_localize.mk M l10ntools/Executable_renewpo.mk M l10ntools/StaticLibrary_transex.mk M l10ntools/inc/po.hxx M l10ntools/source/po.cxx M l10ntools/source/renewpo.cxx 6 files changed, 303 insertions(+), 57 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/520/1 -- To view, visit https://gerrit.libreoffice.org/520 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bab9bb202fcdc6d0f2a13f6c44d28e22c688e1e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: nlpsolver/Extension_nlpsolver.mk sdext/Extension_presenter.mk solenv/gbuild swext/Extension_wiki-publisher.mk
nlpsolver/Extension_nlpsolver.mk | 15 ++-- sdext/Extension_presenter.mk |6 - solenv/gbuild/Extension.mk| 23 +- solenv/gbuild/ExtensionTarget.mk | 132 -- swext/Extension_wiki-publisher.mk | 18 ++--- 5 files changed, 148 insertions(+), 46 deletions(-) New commits: commit b23bb8e0de3dbdc2c66c3dedf70dfd318868f76c Author: Stephan Bergmann sberg...@redhat.com Date: Fri Aug 31 17:04:43 2012 +0200 fdo#53009: Compile extension help in gbuild ...as had been done in the old build system (solenv/inc/extension_helplink.mk). Especially for bundled extensions, this removes the need to compile the help data per user on first start. gb_Extension_add_helpfile(s) replaces gb_Extension_localize_help, and takes care of all the steps (localization, compilation, inclusion in .oxt), even for the en-US data (which was handled with additional gb_Extension_add_file calls before). Change-Id: Ie4bab66d3cad2b713780a23bf2606ca56cfff37f diff --git a/nlpsolver/Extension_nlpsolver.mk b/nlpsolver/Extension_nlpsolver.mk index b7de4b0..6f2690f 100644 --- a/nlpsolver/Extension_nlpsolver.mk +++ b/nlpsolver/Extension_nlpsolver.mk @@ -1,3 +1,4 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- # # Version: MPL 1.1 / GPLv3+ / LGPLv3+ # @@ -39,11 +40,9 @@ $(eval $(call gb_Extension_add_file,nlpsolver,locale/NLPSolverStatusDialog_en_US $(eval $(call gb_Extension_localize_properties,nlpsolver,locale/NLPSolverCommon_en_US.properties,$(SRCDIR)/nlpsolver/src/locale/NLPSolverCommon_en_US.properties)) $(eval $(call gb_Extension_localize_properties,nlpsolver,locale/NLPSolverStatusDialog_en_US.properties,$(SRCDIR)/nlpsolver/src/locale/NLPSolverStatusDialog_en_US.properties)) -$(eval $(call gb_Extension_add_file,nlpsolver,help/en-US/com.sun.star.comp.Calc.NLPSolver/Options.xhp, \ - $(SRCDIR)/nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Options.xhp)) -$(eval $(call gb_Extension_add_file,nlpsolver,help/en-US/com.sun.star.comp.Calc.NLPSolver/Usage.xhp, \ - $(SRCDIR)/nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Usage.xhp)) -$(eval $(call gb_Extension_localize_help,nlpsolver,help/lang/com.sun.star.comp.Calc.NLPSolver/Options.xhp, \ - $(SRCDIR)/nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Options.xhp)) -$(eval $(call gb_Extension_localize_help,nlpsolver,help/lang/com.sun.star.comp.Calc.NLPSolver/Usage.xhp, \ - $(SRCDIR)/nlpsolver/help/en/com.sun.star.comp.Calc.NLPSolver/Usage.xhp)) +$(eval $(call gb_Extension_add_helpfiles,nlpsolver,$(SRCDIR)/nlpsolver/help/en, \ +com.sun.star.comp.Calc.NLPSolver/Options.xhp \ + com.sun.star.comp.Calc.NLPSolver/Usage.xhp \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/sdext/Extension_presenter.mk b/sdext/Extension_presenter.mk index 2a83712..ba5a51a 100644 --- a/sdext/Extension_presenter.mk +++ b/sdext/Extension_presenter.mk @@ -141,10 +141,6 @@ $(eval $(call gb_Extension_add_files,presenter-screen,registry/data/org/openoffi $(call gb_XcuDataTarget_get_target,sdext/source/presenter/registry/data/org/openoffice/Office/ProtocolHandler.xcu) \ )) -$(eval $(call gb_Extension_add_files,presenter-screen,help/en-US/com.sun.PresenterScreen-$(sdext_PLATFORM),\ - $(WORKDIR)/CustomTarget/sdext/source/presenter/help/en-US/com.sun.PresenterScreen/presenter.xhp \ -)) - -$(eval $(call gb_Extension_localize_help,presenter-screen,help/lang/com.sun.PresenterScreen-$(sdext_PLATFORM)/presenter.xhp,$(WORKDIR)/CustomTarget/sdext/source/presenter/help/en-US/com.sun.PresenterScreen/presenter.xhp)) +$(eval $(call gb_Extension_add_helpfile,presenter-screen,$(WORKDIR)/CustomTarget/sdext/source/presenter/help/en-US,com.sun.PresenterScreen-$(sdext_PLATFORM)/presenter.xhp,com.sun.PresenterScreen/presenter.xhp)) # vim:set shiftwidth=4 softtabstop=4 expandtab: diff --git a/solenv/gbuild/Extension.mk b/solenv/gbuild/Extension.mk index e501e18..2779dda 100644 --- a/solenv/gbuild/Extension.mk +++ b/solenv/gbuild/Extension.mk @@ -93,9 +93,26 @@ $(call gb_ExtensionTarget_localize_properties,$(1),$(2),$(3)) endef -# localize extension help -define gb_Extension_localize_help -$(call gb_ExtensionTarget_localize_help,$(1),$(2),$(3)) +# add an .xhp help file, to be localized and compiled +# $(1): extension identifier +# $(2): absolute path prefix of en-US source file without $(3) (resp. $(4)) +# suffix +# $(3): relative path of (target) .xhp file (e.g., +# com.sun.wiki-publisher/wiki.xhp) +# $(4): optional relative path of source .xhp file, when it differs from $(3) +# (i.e., if $(4) is empty the en-US source file is $(2)/$(3), otherwise it +# is $(2)/$(4)) +define gb_Extension_add_helpfile +$(call gb_ExtensionTarget_add_helpfile,$(1),$(2),$(3),$(4)) + +endef + +# add a list of .xhp help files, to be localized and compiled +# $(1): extension identifier +# $(2): absolute path prefix of en-US source files
[PATCH] fdo#39468: Translated German comments in sc/source/core/tool
From gerhard öttl lo...@ogersoft.at: gerhard öttl has uploaded a new change for review. Change subject: fdo#39468: Translated German comments in sc/source/core/tool .. fdo#39468: Translated German comments in sc/source/core/tool Change-Id: If39cd8391a8b8bfccd33349c4c81ab9b0c05991d --- M sc/source/core/tool/chartpos.cxx M sc/source/core/tool/detdata.cxx 2 files changed, 38 insertions(+), 39 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/521/1 -- To view, visit https://gerrit.libreoffice.org/521 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If39cd8391a8b8bfccd33349c4c81ab9b0c05991d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: gerhard öttl lo...@ogersoft.at ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/killsdf' - l10ntools/Executable_localize.mk l10ntools/Executable_renewpo.mk l10ntools/inc l10ntools/source l10ntools/StaticLibrary_transex.mk
l10ntools/Executable_localize.mk |1
l10ntools/Executable_renewpo.mk|1
l10ntools/StaticLibrary_transex.mk |2
l10ntools/inc/po.hxx | 20 ++
l10ntools/source/po.cxx| 324 +++--
l10ntools/source/renewpo.cxx |4
6 files changed, 299 insertions(+), 53 deletions(-)
New commits:
commit 8a8a39c4c129daa3547dce5f0caf20429997e919
Author: Zolnai Tamás zolnaitamas2...@gmail.com
Date: Fri Aug 31 15:09:06 2012 +0200
Implement more Po method for merge
Implement file oprerations(entire reading
and rest part of writing)
Convert text to merge/sdf form
Plus cleanup
Change-Id: I6bab9bb202fcdc6d0f2a13f6c44d28e22c688e1e
Reviewed-on: https://gerrit.libreoffice.org/520
Reviewed-by: Andras Timar ati...@suse.com
Tested-by: Andras Timar ati...@suse.com
diff --git a/l10ntools/Executable_localize.mk b/l10ntools/Executable_localize.mk
index 6184a89..e6e7f1f 100644
--- a/l10ntools/Executable_localize.mk
+++ b/l10ntools/Executable_localize.mk
@@ -33,6 +33,7 @@ $(eval $(call gb_Executable_set_include,localize,\
$(eval $(call gb_Executable_use_libraries,localize,\
sal \
+i18nregexp \
))
$(eval $(call gb_Executable_use_static_libraries,localize,\
diff --git a/l10ntools/Executable_renewpo.mk b/l10ntools/Executable_renewpo.mk
index 4872e8a..5aa036a 100644
--- a/l10ntools/Executable_renewpo.mk
+++ b/l10ntools/Executable_renewpo.mk
@@ -18,6 +18,7 @@ $(eval $(call gb_Executable_set_include,renewpo,\
$(eval $(call gb_Executable_use_libraries,renewpo,\
sal \
+i18nregexp \
))
$(eval $(call gb_Executable_use_static_libraries,renewpo,\
diff --git a/l10ntools/StaticLibrary_transex.mk
b/l10ntools/StaticLibrary_transex.mk
index 21f50e5..82e20a0 100644
--- a/l10ntools/StaticLibrary_transex.mk
+++ b/l10ntools/StaticLibrary_transex.mk
@@ -32,6 +32,8 @@ $(eval $(call gb_StaticLibrary_set_include,transex,\
$$(INCLUDE) \
))
+$(eval $(call gb_StaticLibrary_use_sdk_api,transex))
+
$(eval $(call gb_StaticLibrary_add_exception_objects,transex,\
l10ntools/source/export2 \
l10ntools/source/merge \
diff --git a/l10ntools/inc/po.hxx b/l10ntools/inc/po.hxx
index c03baf8..df3004c 100644
--- a/l10ntools/inc/po.hxx
+++ b/l10ntools/inc/po.hxx
@@ -31,6 +31,14 @@ public:
GenPoEntry();
virtual ~GenPoEntry();
+virtual OString getWhiteSpace() const { return m_sWhiteSpace; }
+virtual OString getExtractCom() const { return m_sExtractCom; }
+virtual OString getReference() const{ return m_sReference; }
+virtual OString getContext() const { return m_sContext; }
+virtual OString getUnTransStr() const { return m_sUnTransStr; }
+virtual OString getTransStr() const { return m_sTransStr; }
+virtual boolgetFuzzy() const{ return m_bFuzzy; }
+
virtual voidsetWhiteSpace(const OString rWhiteSpace)
{ m_sWhiteSpace = rWhiteSpace; }
virtual voidsetExtractCom(const OString rExtractCom)
@@ -46,7 +54,9 @@ public:
virtual voidsetFuzzy(bool bFuzzy)
{ m_bFuzzy = bFuzzy; }
virtual voidgenKeyId();
-virtual voidwriteToFile(std::ofstream io_rOFStream);
+
+virtual voidwriteToFile(std::ofstream rOFStream);
+virtual voidreadFromFile(std::ifstream rIFStream);
};
class PoEntry: public GenPoEntry
@@ -67,13 +77,19 @@ private:
public:
+PoEntry();
PoEntry(const OString i_rSDFLine,
-const TYPE eType = TTEXT);
+const TYPE eType = TTEXT);
virtual ~PoEntry();
+virtual OString getUnTransStr() const;
+virtual OString getTransStr() const;
virtual voidsetUnTransStr(const OString rUnTransStr);
virtual voidsetTransStr(const OString rTransStr);
+virtual voidwriteToFile(std::ofstream rOFStream);
+virtual voidreadFromFile(std::ifstream rIFStream);
+
};
class PoHeader: public GenPoEntry
diff --git a/l10ntools/source/po.cxx b/l10ntools/source/po.cxx
index 6848d7e..a82a88b 100644
--- a/l10ntools/source/po.cxx
+++ b/l10ntools/source/po.cxx
@@ -7,11 +7,20 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
-#include po.hxx
+#include com/sun/star/util/SearchOptions.hpp
+#include com/sun/star/util/SearchFlags.hpp
+#include com/sun/star/i18n/XExtendedTransliteration.hpp
+#include regexp/reclass.hxx
+#include rtl/ustring.hxx
+
+#include string
+#include cstring
#include ctime
#include vector
#include boost/crc.hpp
+#include po.hxx
+
#define POESCAPED OString(\\n\\t\\r\\\)
#define POUNESCAPED OString(\n\t\r\\\)
@@ -69,17 +78,17 @@ OString ImplUnEscapeText(const OString rText,
return sResult;
}
-//Generate msgctxt, msgid and msgstr
[PUSHED] Change in core[feature/killsdf]: Implement more Po method for merge
From Andras Timar ati...@suse.com: Andras Timar has submitted this change and it was merged. Change subject: Implement more Po method for merge .. Implement more Po method for merge Implement file oprerations(entire reading and rest part of writing) Convert text to merge/sdf form Plus cleanup Change-Id: I6bab9bb202fcdc6d0f2a13f6c44d28e22c688e1e --- M l10ntools/Executable_localize.mk M l10ntools/Executable_renewpo.mk M l10ntools/StaticLibrary_transex.mk M l10ntools/inc/po.hxx M l10ntools/source/po.cxx M l10ntools/source/renewpo.cxx 6 files changed, 303 insertions(+), 57 deletions(-) Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/520 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bab9bb202fcdc6d0f2a13f6c44d28e22c688e1e Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com Gerrit-Reviewer: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Need help fixing fdo#38557
Hi I'm currently looking at fdo#38557 [1] and could use some pointers. Summary of the bug: After using the Header and footer dialog (View menu) changes does not get displayed until you add a new page (or something else that triggers an update of the page layout). I tracked down the dialog to headerfooterdlg.cxx [2] the HeaderFooterDialog:apply is called from ApplyToAll or Apply depending on witch button you press. In HeaderFooterDialog::apply the properties from the dialog is set but it does not update the view on screen. Where is such an update supposed to happen? In the execute function? Is it even supposed to be handled in headerfooterdlg.cxx or do I have to go deeper? [1] https://bugs.freedesktop.org/show_bug.cgi?id=38557 [2] http://opengrok.libreoffice.org/xref/core/sd/source/ui/dlg/headerfooterdlg.cxx#304 -- Thankful for any guidence, Niklas Johansson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-commits] Make Regexpr class safer
On 08/31/2012 03:59 PM, Libreoffice Gerrit user wrote:
New commits:
commit 574ddaba5315816a5629550a0a12f9c694b79370
Author: Zolnai Tamás zolnaitamas2...@gmail.com
Date: Fri Aug 31 14:40:14 2012 +0200
Make Regexpr class safer
Make copy constructor and copy operator private
Change-Id: Ifdaff6d74bebb0406432d470c84d221f2c06ba94
Reviewed-on: https://gerrit.libreoffice.org/519
Reviewed-by: Andras Timar ati...@suse.com
Tested-by: Andras Timar ati...@suse.com
diff --git a/regexp/inc/regexp/reclass.hxx b/regexp/inc/regexp/reclass.hxx
index f61112d..4be52bb 100644
--- a/regexp/inc/regexp/reclass.hxx
+++ b/regexp/inc/regexp/reclass.hxx
@@ -357,6 +357,9 @@ class REGEXP_DLLPUBLIC Regexpr
sal_Bool iswordend(const sal_Unicode *d, sal_Unicode *string, sal_Int32
ssize);
void set_list_bit(sal_Unicode c, sal_Unicode *b);
+Regexpr(const Regexpr);
+Regexpr operator=(const Regexpr);
+
public:
// constructors
Regexpr( const ::com::sun::star::util::SearchOptions rOptions,
FYI, the standard idiom is to privately derive the class from
boost::noncopyable instead.
One general advantage of doing it that way is that at least with Clang
3.2 --std=c++11, it does not prevent the compiler from flagging a
class's unused private fields in a compilation unit that sees
definitions for all of that class's declared member functions. That is,
class Foo: private boost::noncopyable {
int n;
public:
Foo() {}
};
will cause
warning: private field 'n' is not used [-Wunused-private-field]
while
class Foo {
int n;
Foo(Foo const );
public:
Foo() {}
will not.
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/core/tool/chartpos.cxx | 71 +++
sc/source/core/tool/detdata.cxx |6 +--
2 files changed, 38 insertions(+), 39 deletions(-)
New commits:
commit 38d446da561c0c70de4b399e8b645a5c85e56ad2
Author: gerhard oettl lo...@ogersoft.at
Date: Fri Aug 31 17:19:29 2012 +0200
fdo#39468: Translated German comments in sc/source/core/tool
Change-Id: If39cd8391a8b8bfccd33349c4c81ab9b0c05991d
Reviewed-on: https://gerrit.libreoffice.org/521
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/core/tool/chartpos.cxx b/sc/source/core/tool/chartpos.cxx
index e5bd8c0..48169c3 100644
--- a/sc/source/core/tool/chartpos.cxx
+++ b/sc/source/core/tool/chartpos.cxx
@@ -123,7 +123,7 @@ void ScChartPositioner::GlueState()
if ( pR-aStart.Tab() == pR-aEnd.Tab() )
eGlue = SC_CHARTGLUE_NONE;
else
-eGlue = SC_CHARTGLUE_COLS; // mehrere Tabellen spaltenweise
+eGlue = SC_CHARTGLUE_COLS; // several tables column by column
nStartCol = pR-aStart.Col();
nStartRow = pR-aStart.Row();
}
@@ -144,7 +144,7 @@ void ScChartPositioner::GlueState()
nMaxCols = nEndCol = 0;
nMaxRows = nEndRow = 0;
for ( size_t i = 1, nRanges = aRangeListRef-size(); i = nRanges; ++i )
// = so 1 extra pass after last item
-{ // umspannenden Bereich etc. feststellen
+{ // detect spanning/surrounding area etc.
SCCOLROW nTmp, n1, n2;
if ( (n1 = pR-aStart.Col()) nStartCol ) nStartCol =
static_castSCCOL(n1 );
if ( (n2 = pR-aEnd.Col() ) nEndCol ) nEndCol =
static_castSCCOL(n2 );
@@ -170,12 +170,11 @@ void ScChartPositioner::GlueState()
sal_uLong nCR = (sal_uLong)nC * nR;
//2do:
/*
-Erstmal simpel ohne Bitmaskiererei, maximal koennten so 8MB alloziert
-werden (256 Cols mal 32000 Rows), das liesse sich mit 2 Bit je Eintrag
-auf 2MB reduzieren, andererseits ist es so schneller.
-Weitere Platz-Optimierung waere, in dem Array nur die wirklich benutzten
-Zeilen/Spalten abzulegen, wuerde aber ein weiteres durchlaufen der
-RangeList und indirekten Zugriff auf das Array bedeuten.
+First do it simple without bit masking. A maximum of 8MB could be allocated
+this way (256 Cols x 32000 Rows). That could be reduced to 2MB by
+using 2 Bits per entry, but it is faster this way.
+Another optimizing would be to store only used rows/columns in the array,
but
+would mean another iteration of the RangeList indirect access to the array.
*/
const sal_uInt8 nHole = 0;
const sal_uInt8 nOccu = 1;
@@ -188,7 +187,7 @@ void ScChartPositioner::GlueState()
SCCOL nCol, nCol1, nCol2;
SCROW nRow, nRow1, nRow2;
for ( size_t i = 0, nRanges = aRangeListRef-size(); i nRanges; ++i )
-{ // Selektionen 2D als belegt markieren
+{ // mark selections as used in 2D
pR = (*aRangeListRef)[i];
nCol1 = pR-aStart.Col() - nStartCol;
nCol2 = pR-aEnd.Col() - nStartCol;
@@ -205,7 +204,7 @@ void ScChartPositioner::GlueState()
sal_Bool bGlueCols = false;
for ( nCol = 0; bGlue nCol nC; nCol++ )
-{ // Spalten probieren durchzugehen und als frei markieren
+{ // iterate columns and try to mark as unused
p = pA + (sal_uLong)nCol * nR;
for ( nRow = 0; bGlue nRow nR; nRow++, p++ )
{
@@ -214,7 +213,7 @@ void ScChartPositioner::GlueState()
// moeglich. Am Rand koennte ok sein, wenn in dieser Spalte
// in jeder belegten Zeile einer belegt ist.
if ( nRow 0 nCol 0 )
-bGlue = false; // nCol==0 kann DummyUpperLeft sein
+bGlue = false; // nCol==0 can be DummyUpperLeft
else
nRow = nR;
}
@@ -222,22 +221,22 @@ void ScChartPositioner::GlueState()
*p = nFree;
}
if ( bGlue *(p = (pA + sal_uLong)nCol+1) * nR) - 1))) == nFree )
-{ // Spalte als komplett frei markieren
+{ // mark column as totally unused
*p = nGlue;
-bGlueCols = sal_True; // mindestens eine freie Spalte
+bGlueCols = sal_True; // one unused column at least
}
}
sal_Bool bGlueRows = false;
for ( nRow = 0; bGlue nRow nR; nRow++ )
-{ // Zeilen probieren durchzugehen und als frei markieren
+{ // iterate rows and try to mark as unused
p = pA + nRow;
for ( nCol = 0; bGlue nCol nC; nCol++, p+=nR )
{
if ( *p == nOccu )
{
if ( nCol 0 nRow 0 )
-bGlue = false; // nRow==0 kann DummyUpperLeft sein
+bGlue = false; // nRow==0 can be DummyUpperLeft
else
nCol = nC;
[PUSHED] fdo#39468: Translated German comments in sc/source/core/tool
From Eike Rathke er...@redhat.com: Eike Rathke has submitted this change and it was merged. Change subject: fdo#39468: Translated German comments in sc/source/core/tool .. fdo#39468: Translated German comments in sc/source/core/tool Change-Id: If39cd8391a8b8bfccd33349c4c81ab9b0c05991d --- M sc/source/core/tool/chartpos.cxx M sc/source/core/tool/detdata.cxx 2 files changed, 38 insertions(+), 39 deletions(-) Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/521 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If39cd8391a8b8bfccd33349c4c81ab9b0c05991d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: gerhard öttl lo...@ogersoft.at Gerrit-Reviewer: Eike Rathke er...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Warning with NSBundle when running LO 3.5.6 on OSX 10.8.1
Hi all, I've noticed this warning message in my console logs and the terminal on OSX 10.8.1 with LO 3.5.6 : Warning: NSBundle NSBundle /Library/Printers/Samsung/CLX-3170/PDEs/About.bundle (loaded) was released too many times. For compatibility, it will not be deallocated, but this may change in the future. Set a breakpoint on __NSBundleOverreleased() to debug Anything to worry about ? Alex ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: package/source
package/source/zipapi/ByteGrabber.cxx |8 +--
package/source/zipapi/XUnbufferedStream.cxx | 12 ++--
package/source/zipapi/ZipFile.cxx | 72 ++--
package/source/zipapi/ZipOutputStream.cxx |4 -
package/source/zipapi/blowfishcontext.cxx |6 +-
package/source/zipapi/sha1context.cxx |2
6 files changed, 52 insertions(+), 52 deletions(-)
New commits:
commit 363c1edea638a1d2cbf42e49c2021ec581740caa
Author: Miklos Vajna vmik...@suse.cz
Date: Fri Aug 31 18:02:25 2012 +0200
package: kill RTL_CONSTASCII_USTRINGPARAM in zipapi
Change-Id: Ic53f613cfaa5bd4affd0c27b5ed4ed20536ee055
diff --git a/package/source/zipapi/ByteGrabber.cxx
b/package/source/zipapi/ByteGrabber.cxx
index 6a8fc2a..65a8b8f 100644
--- a/package/source/zipapi/ByteGrabber.cxx
+++ b/package/source/zipapi/ByteGrabber.cxx
@@ -64,14 +64,14 @@ sal_Int64 SAL_CALL ByteGrabber::seek( sal_Int64 location )
{
sal_Int64 nLen = xSeek-getLength();
if ( location 0 || location nLen )
-throw lang::IllegalArgumentException( ::rtl::OUString(
RTL_CONSTASCII_USTRINGPARAM( OSL_LOG_PREFIX ) ), uno::Reference
uno::XInterface (), 1 );
+throw lang::IllegalArgumentException(OSL_LOG_PREFIX,
uno::Reference uno::XInterface (), 1 );
if (location nLen )
location = nLen;
xSeek-seek( location );
return location;
}
else
-throw io::IOException( ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
OSL_LOG_PREFIX ) ), uno::Reference uno::XInterface () );
+throw io::IOException(OSL_LOG_PREFIX, uno::Reference uno::XInterface
() );
}
sal_Int64 SAL_CALL ByteGrabber::getPosition( )
@@ -81,7 +81,7 @@ sal_Int64 SAL_CALL ByteGrabber::getPosition( )
if (xSeek.is() )
return xSeek-getPosition();
else
-throw io::IOException( ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
OSL_LOG_PREFIX ) ), uno::Reference uno::XInterface () );
+throw io::IOException(OSL_LOG_PREFIX, uno::Reference uno::XInterface
() );
}
sal_Int64 SAL_CALL ByteGrabber::getLength( )
@@ -91,7 +91,7 @@ sal_Int64 SAL_CALL ByteGrabber::getLength( )
if (xSeek.is() )
return xSeek-getLength();
else
-throw io::IOException( ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(
OSL_LOG_PREFIX ) ), uno::Reference uno::XInterface () );
+throw io::IOException(OSL_LOG_PREFIX, uno::Reference uno::XInterface
() );
}
ByteGrabber ByteGrabber::operator (sal_Int8 rInt8)
diff --git a/package/source/zipapi/XUnbufferedStream.cxx
b/package/source/zipapi/XUnbufferedStream.cxx
index d028c14..559e72f 100644
--- a/package/source/zipapi/XUnbufferedStream.cxx
+++ b/package/source/zipapi/XUnbufferedStream.cxx
@@ -230,15 +230,15 @@ sal_Int32 SAL_CALL XUnbufferedStream::readBytes(
Sequence sal_Int8 aData, sa
if ( nRead nRequestedBytes )
throw RuntimeException(
-OUString( RTL_CONSTASCII_USTRINGPARAM( Should not be
possible to read more then requested! ) ),
+Should not be possible to read more then requested!,
Reference XInterface () );
if ( maInflater.finished() || maInflater.getLastInflateError()
)
-throw ZipIOException( OUString(
RTL_CONSTASCII_USTRINGPARAM( The stream seems to be broken! ) ),
+throw ZipIOException(The stream seems to be broken!,
Reference XInterface () );
if ( maInflater.needsDictionary() )
-throw ZipIOException( OUString(
RTL_CONSTASCII_USTRINGPARAM( Dictionaries are not supported! ) ),
+throw ZipIOException(Dictionaries are not supported!,
Reference XInterface () );
sal_Int32 nDiff = static_cast sal_Int32 ( mnZipEnd -
mnZipCurrent );
@@ -253,7 +253,7 @@ sal_Int32 SAL_CALL XUnbufferedStream::readBytes( Sequence
sal_Int8 aData, sa
sal_Int32 nZipRead = mxZipStream-readBytes( maCompBuffer,
nToRead );
if ( nZipRead nToRead )
-throw ZipIOException( OUString(
RTL_CONSTASCII_USTRINGPARAM( No expected data! ) ),
+throw ZipIOException(No expected data!,
Reference XInterface () );
mnZipCurrent += nZipRead;
@@ -280,7 +280,7 @@ sal_Int32 SAL_CALL XUnbufferedStream::readBytes( Sequence
sal_Int8 aData, sa
}
else
{
-throw ZipIOException( OUString(
RTL_CONSTASCII_USTRINGPARAM( The stream seems to be broken! ) ),
+throw ZipIOException(The stream seems to be broken!,
Reference XInterface () );
}
}
@@ -297,7 +297,7 @@
[Libreoffice-commits] .: dbaccess/source
dbaccess/source/core/api/KeySet.cxx |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
New commits:
commit cdadb1b4fb207392961a24788d44bd7ffa529046
Author: Lionel Elie Mamane lio...@mamane.lu
Date: Fri Aug 31 18:14:59 2012 +0200
fdo#53557: use metadata's idea of column count to allocate a row
m_pColumnNames contains only the columns that come straight from a table,
not calculated columns
Change-Id: I2706790e8c1447d1c4e144bbdef773deeca3e2e8
diff --git a/dbaccess/source/core/api/KeySet.cxx
b/dbaccess/source/core/api/KeySet.cxx
index 6d8f58e..c2dadcd 100644
--- a/dbaccess/source/core/api/KeySet.cxx
+++ b/dbaccess/source/core/api/KeySet.cxx
@@ -1441,11 +1441,12 @@ sal_Bool OKeySet::fetchRow()
bRet = m_xDriverSet-next();
if ( bRet )
{
+const int cc = m_xSetMetaData-getColumnCount();
+
ORowSetRow aKeyRow = new connectivity::ORowVector ORowSetValue
((*m_pKeyColumnNames).size() + m_pForeignColumnNames-size());
-ORowSetRow aFullRow = new connectivity::ORowVector ORowSetValue
(m_pColumnNames-size());
+ORowSetRow aFullRow = new connectivity::ORowVector ORowSetValue (cc);
// Fetch the columns only once and in order, to satisfy restrictive
backends such as ODBC
-const int cc = m_xSetMetaData-getColumnCount();
connectivity::ORowVector ORowSetValue ::Vector::iterator aFRIter =
aFullRow-get().begin();
// Column 0 is reserved for the bookmark; unused here.
++aFRIter;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Change in core[libreoffice-3-6]: fdo#53557: use metadata's idea of column count to allocate a...
From Lionel Elie Mamane lio...@mamane.lu: Lionel Elie Mamane has uploaded a new change for review. Change subject: fdo#53557: use metadata's idea of column count to allocate a row .. fdo#53557: use metadata's idea of column count to allocate a row m_pColumnNames contains only the columns that come straight from a table, not calculated columns Change-Id: I2706790e8c1447d1c4e144bbdef773deeca3e2e8 --- M dbaccess/source/core/api/KeySet.cxx 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/522/1 -- To view, visit https://gerrit.libreoffice.org/522 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2706790e8c1447d1c4e144bbdef773deeca3e2e8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-3-6 Gerrit-Owner: Lionel Elie Mamane lio...@mamane.lu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added Depends on||53557 --- Comment #101 from Lionel Elie Mamane lio...@mamane.lu 2012-08-31 16:23:16 UTC --- bug 53557, base crasher on any calculated field -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: solenv/gbuild
solenv/gbuild/ExtensionTarget.mk | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) New commits: commit 152ffaa15f963f92b1564946a648c53d6b5c808c Author: Stephan Bergmann sberg...@redhat.com Date: Fri Aug 31 18:28:41 2012 +0200 Call HelpIndexer/Linker with gb_Helper_set_ld_path Change-Id: Id3d1b203dee34ab6e59e8790c9caa5ea9d565f45 diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk index 94e4832..14b50e0 100644 --- a/solenv/gbuild/ExtensionTarget.mk +++ b/solenv/gbuild/ExtensionTarget.mk @@ -41,6 +41,14 @@ gb_ExtensionTarget_PROPMERGECOMMAND := \ gb_ExtensionTarget_HELPEXTARGET := $(call gb_Executable_get_target_for_build,helpex) gb_ExtensionTarget_HELPEXCOMMAND := \ $(gb_Helper_set_ld_path) $(gb_ExtensionTarget_HELPEXTARGET) +gb_ExtensionTarget_HELPINDEXERTARGET := \ +$(call gb_Executable_get_target_for_build,HelpIndexer) +gb_ExtensionTarget_HELPINDEXERCOMMAND := \ + $(gb_Helper_set_ld_path) $(gb_ExtensionTarget_HELPINDEXERTARGET) +gb_ExtensionTarget_HELPLINKERTARGET := \ +$(call gb_Executable_get_target_for_build,HelpLinker) +gb_ExtensionTarget_HELPLINKERCOMMAND := \ + $(gb_Helper_set_ld_path) $(gb_ExtensionTarget_HELPLINKERTARGET) # does not contain en-US because it is special cased in gb_ExtensionTarget_ExtensionTarget gb_ExtensionTarget_TRANS_LANGS := $(filter-out en-US,$(gb_WITH_LANG)) gb_ExtensionTarget_ALL_LANGS := en-US $(gb_ExtensionTarget_TRANS_LANGS) @@ -282,8 +290,8 @@ endef # gb_ExtensionTarget_add_helpfile) define gb_ExtensionTarget__compile_help_onelang $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(2).done : \ -$(call gb_Executable_get_target_for_build,HelpIndexer) \ -$(call gb_Executable_get_target_for_build,HelpLinker) \ +$(gb_ExtensionTarget_HELPINDEXERTARGET) \ +$(gb_ExtensionTarget_HELPLINKERTARGET) \ $(OUTDIR_FOR_BUILD)/bin/embed.xsl \ $(OUTDIR_FOR_BUILD)/bin/idxcaption.xsl \ $(OUTDIR_FOR_BUILD)/bin/idxcontent.xsl | \ @@ -292,7 +300,7 @@ $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(2).done : \ $$(call gb_Helper_abbreviate_dirs, \ rm -rf $$(basename $$@) \ mkdir $$(basename $$@) \ -$(call gb_Executable_get_target_for_build,HelpLinker) -mod help \ +$(gb_ExtensionTarget_HELPLINKERCOMMAND) -mod help \ -extlangsrc $(call gb_ExtensionTarget_get_workdir,$(1))/help/$(2) \ -sty $(OUTDIR_FOR_BUILD)/bin/embed.xsl \ -extlangdest $$(basename $$@) \ @@ -302,8 +310,8 @@ $(call gb_ExtensionTarget_get_rootdir,$(1))/help/$(2).done : \ (cd $(call gb_ExtensionTarget_get_workdir,$(1))/help/$(2) \ $(gb_ExtensionTarget_ZIPCOMMAND) -r $$(basename $$@)/help.jar \ $$(HELPFILES)) \ -$(call gb_Executable_get_target_for_build,HelpIndexer) -lang $(2) \ --mod help -dir $$(basename $$@) \ +$(gb_ExtensionTarget_HELPINDEXERCOMMAND) -lang $(2) -mod help \ +-dir $$(basename $$@) \ touch $$@) endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sdext/Module_sdext.mk sdext/Zip_minimizer.mk sdext/Zip_presenter.mk solenv/inc swext/Module_swext.mk swext/Zip_mediawiki_develop.mk
sdext/Module_sdext.mk|2 - sdext/Zip_minimizer.mk | 35 --- sdext/Zip_presenter.mk | 34 -- solenv/inc/extension_helplink.mk | 58 -- swext/Module_swext.mk|1 swext/Zip_mediawiki_develop.mk | 59 --- 6 files changed, 189 deletions(-) New commits: commit ec5fb295b0fcbb334707bc6e33c9a77bae34737b Author: Stephan Bergmann sberg...@redhat.com Date: Fri Aug 31 18:31:24 2012 +0200 The *_develop.zip files appear to be unused Change-Id: I1bb3d359b087421f4acf67955549514fc3c6a236 diff --git a/sdext/Module_sdext.mk b/sdext/Module_sdext.mk index 6280984..7bba9d9 100644 --- a/sdext/Module_sdext.mk +++ b/sdext/Module_sdext.mk @@ -33,7 +33,6 @@ $(eval $(call gb_Module_add_targets,sdext,\ Extension_minimizer \ Library_minimizer \ Rdb_minimizer \ -Zip_minimizer \ )) endif @@ -61,7 +60,6 @@ $(eval $(call gb_Module_add_targets,sdext,\ Extension_presenter \ Library_presenter \ Rdb_presenter \ -Zip_presenter \ )) endif diff --git a/sdext/Zip_minimizer.mk b/sdext/Zip_minimizer.mk deleted file mode 100644 index c19446b..000 --- a/sdext/Zip_minimizer.mk +++ /dev/null @@ -1,35 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# Version: MPL 1.1 / GPLv3+ / LGPLv3+ -# -# The contents of this file are subject to the Mozilla Public License Version -# 1.1 (the License); you may not use this file except in compliance with -# the License or as specified alternatively below. You may obtain a copy of -# the License at http://www.mozilla.org/MPL/ -# -# Software distributed under the License is distributed on an AS IS basis, -# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License -# for the specific language governing rights and limitations under the -# License. -# -# Major Contributor(s): -# Copyright (C) 2012 Red Hat, Inc., David Tardon dtar...@redhat.com -# (initial developer) -# -# All Rights Reserved. -# -# For minor contributions see the git repository. -# -# Alternatively, the contents of this file may be used under the terms of -# either the GNU General Public License Version 3 or later (the GPLv3+), or -# the GNU Lesser General Public License Version 3 or later (the LGPLv3+), -# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable -# instead of those above. - -$(eval $(call gb_Zip_Zip,minimizer/presentation_minimizer_develop,$(SRCDIR)/sdext/source/minimizer/registry/data)) - -$(eval $(call gb_Zip_add_files,minimizer/presentation_minimizer_develop,\ -org/openoffice/Office/Addons.xcu \ -org/openoffice/Office/extension/SunPresentationMinimizer.xcu \ -)) - -# vim:set shiftwidth=4 softtabstop=4 expandtab: diff --git a/sdext/Zip_presenter.mk b/sdext/Zip_presenter.mk deleted file mode 100644 index 114095c..000 --- a/sdext/Zip_presenter.mk +++ /dev/null @@ -1,34 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# Version: MPL 1.1 / GPLv3+ / LGPLv3+ -# -# The contents of this file are subject to the Mozilla Public License Version -# 1.1 (the License); you may not use this file except in compliance with -# the License or as specified alternatively below. You may obtain a copy of -# the License at http://www.mozilla.org/MPL/ -# -# Software distributed under the License is distributed on an AS IS basis, -# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License -# for the specific language governing rights and limitations under the -# License. -# -# Major Contributor(s): -# Copyright (C) 2012 Red Hat, Inc., David Tardon dtar...@redhat.com -# (initial developer) -# -# All Rights Reserved. -# -# For minor contributions see the git repository. -# -# Alternatively, the contents of this file may be used under the terms of -# either the GNU General Public License Version 3 or later (the GPLv3+), or -# the GNU Lesser General Public License Version 3 or later (the LGPLv3+), -# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable -# instead of those above. - -$(eval $(call gb_Zip_Zip,presenter/presenter-screen_develop,$(SRCDIR)/sdext/source/presenter/help)) - -$(eval $(call gb_Zip_add_files,presenter/presenter-screen_develop,\ -en-US/com.sun.PresenterScreen/presenter.xhp \ -)) - -# vim:set shiftwidth=4 softtabstop=4 expandtab: diff --git a/swext/Module_swext.mk b/swext/Module_swext.mk index 00229f8..f2f6da3 100644 --- a/swext/Module_swext.mk +++ b/swext/Module_swext.mk @@ -33,7 +33,6 @@ ifeq ($(ENABLE_MEDIAWIKI),YES) $(eval $(call gb_Module_add_targets,swext,\ Jar_mediawiki \ Configuration_mediawiki \ - Zip_mediawiki_develop \ Extension_wiki-publisher \ )) endif diff --git a/swext/Zip_mediawiki_develop.mk b/swext/Zip_mediawiki_develop.mk deleted file mode 100644 index f74d885..000 --- a/swext/Zip_mediawiki_develop.mk +++ /dev/null
[PATCH] Change in core[feature/killsdf]: Correct KeyId generator
From Zolnai Tamás zolnaitamas2...@gmail.com: Zolnai Tamás has uploaded a new change for review. Change subject: Correct KeyId generator .. Correct KeyId generator Use integer aritmetic and less cast Change-Id: I6fc0667fcbcee5f1a2dc964e2653c042338afa0c --- M l10ntools/source/po.cxx 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/523/1 -- To view, visit https://gerrit.libreoffice.org/523 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6fc0667fcbcee5f1a2dc964e2653c042338afa0c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/excel/xipivot.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit b4f913b5f5c48335dc80a5322b078e1d6ac2e3fe Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Aug 31 12:46:54 2012 -0400 fdo#54303: Prevent crash on load. Another simple null pointer check, to save the day. This unfortunately prevents the properties of the skipped field from being loaded properly, but it's still better than a immediate crash. Change-Id: I49398d80eb3bf0834b7e9830ac8be3ac776cb354 diff --git a/sc/source/filter/excel/xipivot.cxx b/sc/source/filter/excel/xipivot.cxx index 2d30efb..8f9596a 100644 --- a/sc/source/filter/excel/xipivot.cxx +++ b/sc/source/filter/excel/xipivot.cxx @@ -1091,7 +1091,11 @@ ScDPSaveDimension* XclImpPTField::ConvertRCPField( ScDPSaveData rSaveData ) con if( !pCacheField || !pCacheField-IsSupportedField() ) return 0; -ScDPSaveDimension rSaveDim = *rSaveData.GetNewDimensionByName( rFieldName ); +ScDPSaveDimension* pTest = rSaveData.GetNewDimensionByName(rFieldName); +if (!pTest) +return NULL; + +ScDPSaveDimension rSaveDim = *pTest; // orientation rSaveDim.SetOrientation( static_cast sal_uInt16 ( maFieldInfo.GetApiOrient( EXC_SXVD_AXIS_ROWCOLPAGE ) ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: i18npool/qa
i18npool/qa/cppunit/test_languagetag.cxx | 23 ---
1 file changed, 23 deletions(-)
New commits:
commit b75664ce3ceb0673f61cb5320b1e8b44f1b805d1
Author: Eike Rathke er...@redhat.com
Date: Fri Aug 31 18:42:58 2012 +0200
testInit() with overrideDataPath() is obsolete now
Change-Id: Ic59da3ff8f86af3e74cc526b2f4c490bd144686d
diff --git a/i18npool/qa/cppunit/test_languagetag.cxx
b/i18npool/qa/cppunit/test_languagetag.cxx
index 4569e81..3bb7163 100644
--- a/i18npool/qa/cppunit/test_languagetag.cxx
+++ b/i18npool/qa/cppunit/test_languagetag.cxx
@@ -40,36 +40,13 @@ public:
TestLanguageTag() {}
virtual ~TestLanguageTag() {}
-void testInit();
void testAllTags();
CPPUNIT_TEST_SUITE(TestLanguageTag);
-CPPUNIT_TEST(testInit);
CPPUNIT_TEST(testAllTags);
CPPUNIT_TEST_SUITE_END();
};
-void TestLanguageTag::testInit()
-{
-#if USE_LIBLANGTAG !defined(SYSTEM_LIBLANGTAG)
-// file:///$SRCDIR/solver/$INPATH/share/liblangtag
-// file:///$OUTDIR/share/liblangtag
-OUStringBuffer aBuf(128);
-const char* pEnv = getenv(OUTDIR);
-CPPUNIT_ASSERT_MESSAGE(No $OUTDIR, pEnv);
-aBuf.append( file:///).append( OStringToOUString( pEnv,
RTL_TEXTENCODING_UTF8)).append( /share/liblangtag);
-OUString aURL( aBuf.makeStringAndClear());
-OUString aData( aURL);
-aData += /language-subtag-registry.xml;
-osl::DirectoryItem aDirItem;
-CPPUNIT_ASSERT_MESSAGE(liblangtag data not found,
-osl::DirectoryItem::get( aData, aDirItem) ==
osl::DirectoryItem::E_None);
-OUString aPath;
-CPPUNIT_ASSERT( osl::FileBase::getSystemPathFromFileURL( aURL, aPath) ==
osl::FileBase::E_None);
-LanguageTag::overrideDataPath( aPath);
-#endif
-}
-
void TestLanguageTag::testAllTags()
{
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[REVIEW 3-6] Prevent crash on loading xls with pivot table (fdo#54303)
Hi there, I'd like https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b4f913b5f5c48335dc80a5322b078e1d6ac2e3fe cherry-picked to 3-6 in order to fix https://bugs.freedesktop.org/show_bug.cgi?id=54303 Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6][REVIEWED] Prevent crash on loading xls with pivot table (fdo#54303)
Hey Kohei, https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b4f913b5f5c48335dc80a5322b078e1d6ac2e3fe cherry-picked to 3-6 in order to fix https://bugs.freedesktop.org/show_bug.cgi?id=54303 Looks safe. You've my sign-off for 3-6. Thanks, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/filter/excel/xipivot.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 98ec92335d18bb361a63cea3e1e71a87ed2b Author: Kohei Yoshida kohei.yosh...@gmail.com Date: Fri Aug 31 12:46:54 2012 -0400 fdo#54303: Prevent crash on load. Another simple null pointer check, to save the day. This unfortunately prevents the properties of the skipped field from being loaded properly, but it's still better than a immediate crash. Change-Id: I49398d80eb3bf0834b7e9830ac8be3ac776cb354 Signed-off-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/filter/excel/xipivot.cxx b/sc/source/filter/excel/xipivot.cxx index 2d30efb..8f9596a 100644 --- a/sc/source/filter/excel/xipivot.cxx +++ b/sc/source/filter/excel/xipivot.cxx @@ -1091,7 +1091,11 @@ ScDPSaveDimension* XclImpPTField::ConvertRCPField( ScDPSaveData rSaveData ) con if( !pCacheField || !pCacheField-IsSupportedField() ) return 0; -ScDPSaveDimension rSaveDim = *rSaveData.GetNewDimensionByName( rFieldName ); +ScDPSaveDimension* pTest = rSaveData.GetNewDimensionByName(rFieldName); +if (!pTest) +return NULL; + +ScDPSaveDimension rSaveDim = *pTest; // orientation rSaveDim.SetOrientation( static_cast sal_uInt16 ( maFieldInfo.GetApiOrient( EXC_SXVD_AXIS_ROWCOLPAGE ) ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [REVIEW 3-6][REVIEWED][PUSHED 3-6] Prevent crash on loading xls with pivot table (fdo#54303)
On 08/31/2012 12:58 PM, Markus Mohrhard wrote: Hey Kohei, https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=b4f913b5f5c48335dc80a5322b078e1d6ac2e3fe cherry-picked to 3-6 in order to fix https://bugs.freedesktop.org/show_bug.cgi?id=54303 Looks safe. You've my sign-off for 3-6. Thanks. Just pushed to 3-6 with your sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/XMLExportDataPilot.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit fe0ef1b2f13d1c2cc8e4f777911c158390183053
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Aug 31 13:17:51 2012 -0400
Don't export the internal field name suffix '*' to ods.
These '*' suffix is used internally to make duplicate field names
unique. However, we were exporting the raw names (names with the '*'s)
by mistake when saving to ods. We need to stop this ASAP before someone
gets hurt.
Change-Id: Iaff7a6343cf202f5fb9855fb7dfe59b872920e4f
diff --git a/sc/source/filter/xml/XMLExportDataPilot.cxx
b/sc/source/filter/xml/XMLExportDataPilot.cxx
index 92532d9..191319c 100644
--- a/sc/source/filter/xml/XMLExportDataPilot.cxx
+++ b/sc/source/filter/xml/XMLExportDataPilot.cxx
@@ -46,6 +46,7 @@
#include dpsdbtab.hxx
#include dpdimsave.hxx
#include dpgroup.hxx
+#include dputil.hxx
#include rangeutl.hxx
#include queryentry.hxx
#include com/sun/star/sheet/DataImportMode.hpp
@@ -608,8 +609,9 @@ void ScXMLExportDataPilot::WriteGroupDimAttributes(const
ScDPSaveGroupDimension*
{
if (pGroupDim)
{
+OUString aSrcFieldName =
ScDPUtil::getSourceDimensionName(pGroupDim-GetSourceDimName());
rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_IS_GROUP_FIELD,
XML_TRUE);
-rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
pGroupDim-GetSourceDimName());
+rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
aSrcFieldName);
if (pGroupDim-GetDatePart())
{
WriteDatePart(pGroupDim-GetDatePart());
@@ -682,7 +684,8 @@ void
ScXMLExportDataPilot::WriteGroupDimElements(ScDPSaveDimension* pDim, const
void ScXMLExportDataPilot::WriteDimension(ScDPSaveDimension* pDim, const
ScDPDimensionSaveData* pDimData)
{
-rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
rtl::OUString(pDim-GetName()));
+OUString aSrcDimName = ScDPUtil::getSourceDimensionName(pDim-GetName());
+rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
aSrcDimName);
if (rExport.getDefaultVersion() SvtSaveOptions::ODFVER_012)
{
// Export display names only for ODF 1.2 extended or later.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Added some more icons to tango_testing
From Alexander Wilms alexander.wi...@zoho.com: Alexander Wilms has uploaded a new change for review. Change subject: Added some more icons to tango_testing .. Added some more icons to tango_testing Change-Id: Ia9a21c213f58d01b3f96d479e81461e82cf7b7d7 --- A icon-themes/tango_testing/cmd/lc_backcolor.png A icon-themes/tango_testing/cmd/lc_backcolor.svg A icon-themes/tango_testing/cmd/lc_color-lc_fontcolor.svg A icon-themes/tango_testing/cmd/lc_color.png A icon-themes/tango_testing/cmd/lc_color.svg A icon-themes/tango_testing/cmd/lc_defaultbullet.png A icon-themes/tango_testing/cmd/lc_defaultbullet.svg A icon-themes/tango_testing/cmd/lc_defaultnumbering.png A icon-themes/tango_testing/cmd/lc_defaultnumbering.svg A icon-themes/tango_testing/cmd/lc_drawchart.png A icon-themes/tango_testing/cmd/lc_drawchart.svg A icon-themes/tango_testing/cmd/lc_fontcolor.png A icon-themes/tango_testing/cmd/lc_spelldialog-lc_spelling-lc_spellingandgrammar.svg A icon-themes/tango_testing/cmd/lc_spelldialog.png A icon-themes/tango_testing/cmd/lc_spelling.png A icon-themes/tango_testing/cmd/lc_spellingandgrammar.png A icon-themes/tango_testing/cmd/lc_spellonline.png A icon-themes/tango_testing/cmd/lc_spellonline.svg 18 files changed, 4,110 insertions(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/524/1 -- To view, visit https://gerrit.libreoffice.org/524 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia9a21c213f58d01b3f96d479e81461e82cf7b7d7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Alexander Wilms alexander.wi...@zoho.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW 3-6] Prevent exporting raw field names in pivot table to ODS
Hi there, I'd like https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=fe0ef1b2f13d1c2cc8e4f777911c158390183053 cherry-picked to 3-6 to prevent us from exporting any internal field names in pivot table to ODS. Background Our pivot table code internally appends '*' character to a duplicate field name, because we require that each field name be unique. The decision was not mine but it had been done this way historically. Unfortunately, this scheme has a big drawback that, if the real field name ends with '*', it would cause a catastrophic result. To make matters worse, the document that caused a crash earlier in this bug report https://bugs.freedesktop.org/show_bug.cgi?id=54303 contained a field whose name was just '*'! During the 3.6 cycle, I had spent a great deal to isolate the parts of the code that adds and removes these '*' from the real field name, with the intention of changing this suffix character from '*' to something else (probably one that's outside the printable range). So, it's very important that we prevent these characters from being exported into ODS. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Mirosław Zalewski mini...@poczta.onet.pl changed: What|Removed |Added Depends on||38606 --- Comment #362 from Mirosław Zalewski mini...@poczta.onet.pl 2012-08-31 17:37:13 UTC --- I am adding #38606: Under Style and Formatting, clicking Apply always resets to initial tab. If I understand correctly, no one worked on this, because there are plans to redesign style modification dialogs, and chances are that Apply button will be removed. But this redesign will happen in 3.7 at best, which is around six months from now. This bug has been opened for over a year. Instead of having users waiting next half year, please fix it in at least 3.6 branch. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Change in core[feature/killsdf]: Correct KeyId generator
From Andras Timar ati...@suse.com: Andras Timar has submitted this change and it was merged. Change subject: Correct KeyId generator .. Correct KeyId generator Use integer aritmetic and less cast Change-Id: I6fc0667fcbcee5f1a2dc964e2653c042338afa0c --- M l10ntools/source/po.cxx 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/523 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc0667fcbcee5f1a2dc964e2653c042338afa0c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: feature/killsdf Gerrit-Owner: Zolnai Tamás zolnaitamas2...@gmail.com Gerrit-Reviewer: Andras Timar ati...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/filter/xml/XMLExportDataPilot.cxx |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
New commits:
commit 6781ee7039adc7248d887589b1369dda4dc45791
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Aug 31 13:17:51 2012 -0400
Don't export the internal field name suffix '*' to ods.
These '*' suffix is used internally to make duplicate field names
unique. However, we were exporting the raw names (names with the '*'s)
by mistake when saving to ods. We need to stop this ASAP before someone
gets hurt.
Change-Id: Iaff7a6343cf202f5fb9855fb7dfe59b872920e4f
(cherry picked from commit fe0ef1b2f13d1c2cc8e4f777911c158390183053)
Signed-off-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/filter/xml/XMLExportDataPilot.cxx
b/sc/source/filter/xml/XMLExportDataPilot.cxx
index 5b5622c..fe3dfcb 100644
--- a/sc/source/filter/xml/XMLExportDataPilot.cxx
+++ b/sc/source/filter/xml/XMLExportDataPilot.cxx
@@ -48,6 +48,7 @@
#include dpsdbtab.hxx
#include dpdimsave.hxx
#include dpgroup.hxx
+#include dputil.hxx
#include rangeutl.hxx
#include queryentry.hxx
#include com/sun/star/sheet/DataImportMode.hpp
@@ -610,8 +611,9 @@ void ScXMLExportDataPilot::WriteGroupDimAttributes(const
ScDPSaveGroupDimension*
{
if (pGroupDim)
{
+OUString aSrcFieldName =
ScDPUtil::getSourceDimensionName(pGroupDim-GetSourceDimName());
rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_IS_GROUP_FIELD,
XML_TRUE);
-rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
pGroupDim-GetSourceDimName());
+rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
aSrcFieldName);
if (pGroupDim-GetDatePart())
{
WriteDatePart(pGroupDim-GetDatePart());
@@ -684,7 +686,8 @@ void
ScXMLExportDataPilot::WriteGroupDimElements(ScDPSaveDimension* pDim, const
void ScXMLExportDataPilot::WriteDimension(ScDPSaveDimension* pDim, const
ScDPDimensionSaveData* pDimData)
{
-rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
rtl::OUString(pDim-GetName()));
+OUString aSrcDimName = ScDPUtil::getSourceDimensionName(pDim-GetName());
+rExport.AddAttribute(XML_NAMESPACE_TABLE, XML_SOURCE_FIELD_NAME,
aSrcDimName);
if (rExport.getDefaultVersion() SvtSaveOptions::ODFVER_012)
{
// Export display names only for ODF 1.2 extended or later.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [REVIEW 3-6] Prevent exporting raw field names in pivot table to ODS
Hi Kohei, On Friday, 2012-08-31 13:27:19 -0400, Kohei Yoshida wrote: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=fe0ef1b2f13d1c2cc8e4f777911c158390183053 cherry-picked to 3-6 with my sign-off https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=6781ee7039adc7248d887589b1369dda4dc45791 Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpnEq4FcpwTh.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 3-6] Prevent exporting raw field names in pivot table to ODS
mark PUSHED pgpceeUAa4GQs.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmldpimp.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 9b721623b69b1c2a54dc1dba04b9c92e5e4fd13e
Author: Kohei Yoshida kohei.yosh...@gmail.com
Date: Fri Aug 31 14:25:05 2012 -0400
Bool and string cleanup, as usual.
Change-Id: Id287047d54c2c75647486cc3b07152ddbe295534
diff --git a/sc/source/filter/xml/xmldpimp.cxx
b/sc/source/filter/xml/xmldpimp.cxx
index 8c44968..3bf88f6 100644
--- a/sc/source/filter/xml/xmldpimp.cxx
+++ b/sc/source/filter/xml/xmldpimp.cxx
@@ -935,8 +935,8 @@ ScXMLDataPilotFieldContext::ScXMLDataPilotFieldContext(
ScXMLImport rImport,
bAutoEnd(false),
mbHasHiddenMember(false)
{
-sal_Bool bHasName(false);
-sal_Bool bDataLayout(false);
+bool bHasName = false;
+bool bDataLayout = false;
OUString aDisplayName;
sal_Int16 nAttrCount = xAttrList.is() ? xAttrList-getLength() : 0;
const SvXMLTokenMap rAttrTokenMap =
GetScImport().GetDataPilotFieldAttrTokenMap();
@@ -953,7 +953,7 @@ ScXMLDataPilotFieldContext::ScXMLDataPilotFieldContext(
ScXMLImport rImport,
case XML_TOK_DATA_PILOT_FIELD_ATTR_SOURCE_FIELD_NAME :
{
sName = sValue;
-bHasName = sal_True;
+bHasName = true;
}
break;
case XML_TOK_DATA_PILOT_FIELD_ATTR_DISPLAY_NAME:
@@ -980,7 +980,7 @@ ScXMLDataPilotFieldContext::ScXMLDataPilotFieldContext(
ScXMLImport rImport,
case XML_TOK_DATA_PILOT_FIELD_ATTR_SELECTED_PAGE :
{
sSelectedPage = sValue;
-bSelectedPage = sal_True;
+bSelectedPage = true;
}
break;
case XML_TOK_DATA_PILOT_FIELD_ATTR_USED_HIERARCHY :
@@ -992,7 +992,7 @@ ScXMLDataPilotFieldContext::ScXMLDataPilotFieldContext(
ScXMLImport rImport,
}
if (bHasName)
{
-pDim = new ScDPSaveDimension(String(sName), bDataLayout);
+pDim = new ScDPSaveDimension(sName, bDataLayout);
if (!aDisplayName.isEmpty())
pDim-SetLayoutName(aDisplayName);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
license statement
All of my past and future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. gerhard öttl ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Added some more icons to tango_testing
From Alexander Wilms alexander.wi...@zoho.com: Alexander Wilms has submitted this change and it was merged. Change subject: Added some more icons to tango_testing .. Added some more icons to tango_testing Change-Id: Ia9a21c213f58d01b3f96d479e81461e82cf7b7d7 --- A icon-themes/tango_testing/cmd/lc_backcolor.png A icon-themes/tango_testing/cmd/lc_backcolor.svg A icon-themes/tango_testing/cmd/lc_color-lc_fontcolor.svg A icon-themes/tango_testing/cmd/lc_color.png A icon-themes/tango_testing/cmd/lc_color.svg A icon-themes/tango_testing/cmd/lc_defaultbullet.png A icon-themes/tango_testing/cmd/lc_defaultbullet.svg A icon-themes/tango_testing/cmd/lc_defaultnumbering.png A icon-themes/tango_testing/cmd/lc_defaultnumbering.svg A icon-themes/tango_testing/cmd/lc_drawchart.png A icon-themes/tango_testing/cmd/lc_drawchart.svg A icon-themes/tango_testing/cmd/lc_fontcolor.png A icon-themes/tango_testing/cmd/lc_spelldialog-lc_spelling-lc_spellingandgrammar.svg A icon-themes/tango_testing/cmd/lc_spelldialog.png A icon-themes/tango_testing/cmd/lc_spelling.png A icon-themes/tango_testing/cmd/lc_spellingandgrammar.png A icon-themes/tango_testing/cmd/lc_spellonline.png A icon-themes/tango_testing/cmd/lc_spellonline.svg 18 files changed, 4,110 insertions(+), 0 deletions(-) -- To view, visit https://gerrit.libreoffice.org/524 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9a21c213f58d01b3f96d479e81461e82cf7b7d7 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Alexander Wilms alexander.wi...@zoho.com Gerrit-Reviewer: Alexander Wilms alexander.wi...@zoho.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/CppunitTest_sc_filters_test.mk sc/CppunitTest_sc_subsequent_filters_test.mk sc/CppunitTest_sc_ucalc.mk sc/Library_scfilt.mk sc/Library_scui.mk
sc/CppunitTest_sc_filters_test.mk|2 ++ sc/CppunitTest_sc_subsequent_filters_test.mk |2 ++ sc/CppunitTest_sc_ucalc.mk |2 ++ sc/Library_scfilt.mk |2 ++ sc/Library_scui.mk |2 ++ 5 files changed, 10 insertions(+) New commits: commit 69d03c69d442e8936bde3e6ef4d270d943e18b86 Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Aug 31 22:40:12 2012 +0200 forgot to use external mdds headers here Change-Id: I066e2716095722343603a684935f0b7b24ce08be diff --git a/sc/CppunitTest_sc_filters_test.mk b/sc/CppunitTest_sc_filters_test.mk index 7883ef7..e7554d2 100644 --- a/sc/CppunitTest_sc_filters_test.mk +++ b/sc/CppunitTest_sc_filters_test.mk @@ -31,6 +31,8 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sc_filters_test, \ sc/qa/unit/filters-test \ )) +$(eval $(call gb_CppunitTest_use_external,sc_filters_test,mdds_headers)) + $(eval $(call gb_CppunitTest_use_libraries,sc_filters_test, \ avmedia \ basegfx \ diff --git a/sc/CppunitTest_sc_subsequent_filters_test.mk b/sc/CppunitTest_sc_subsequent_filters_test.mk index c716924..6efbc85 100644 --- a/sc/CppunitTest_sc_subsequent_filters_test.mk +++ b/sc/CppunitTest_sc_subsequent_filters_test.mk @@ -31,6 +31,8 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sc_subsequent_filters_test, \ sc/qa/unit/subsequent_filters-test \ )) +$(eval $(call gb_CppunitTest_use_external,sc_subsequent_filters_test,mdds_headers)) + $(eval $(call gb_CppunitTest_use_libraries,sc_subsequent_filters_test, \ avmedia \ basegfx \ diff --git a/sc/CppunitTest_sc_ucalc.mk b/sc/CppunitTest_sc_ucalc.mk index 64a0d55..817bec0 100644 --- a/sc/CppunitTest_sc_ucalc.mk +++ b/sc/CppunitTest_sc_ucalc.mk @@ -37,6 +37,8 @@ $(eval $(call gb_CppunitTest_add_exception_objects,sc_ucalc, \ $(eval $(call gb_CppunitTest_use_library_objects,sc_ucalc,sc)) +$(eval $(call gb_CppunitTest_use_external,sc_ucalc,mdds_headers)) + ifeq ($(ENABLE_TELEPATHY),TRUE) $(eval $(call gb_CppunitTest_use_libraries,sc_ucalc,tubes)) endif diff --git a/sc/Library_scfilt.mk b/sc/Library_scfilt.mk index 870f28c..7efd7d1 100644 --- a/sc/Library_scfilt.mk +++ b/sc/Library_scfilt.mk @@ -34,6 +34,8 @@ $(eval $(call gb_Library_set_include,scfilt,\ $(eval $(call gb_Library_use_sdk_api,scfilt)) +$(eval $(call gb_Library_use_external,scfilt,mdds_headers)) + $(eval $(call gb_Library_use_libraries,scfilt,\ basegfx \ comphelper \ diff --git a/sc/Library_scui.mk b/sc/Library_scui.mk index 3e1a087..6d67de0 100644 --- a/sc/Library_scui.mk +++ b/sc/Library_scui.mk @@ -33,6 +33,8 @@ $(eval $(call gb_Library_set_include,scui,\ $(eval $(call gb_Library_use_sdk_api,scui)) +$(eval $(call gb_Library_use_external,scui,mdds_headers)) + $(eval $(call gb_Library_use_libraries,scui,\ comphelper \ cppu \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] kill RTL_CONSTASCII_USTRINGPARAM in xmlhelp
From Olivier Hallot olivier.hal...@alta.org.br: Olivier Hallot has uploaded a new change for review. Change subject: kill RTL_CONSTASCII_USTRINGPARAM in xmlhelp .. kill RTL_CONSTASCII_USTRINGPARAM in xmlhelp + ::rtl:: drop (only on rebased files) Change-Id: I5a773936ceb012b0655cee8db7250b496e088464 --- M xmlhelp/source/cxxhelp/inc/excep/XmlSearchExceptions.hxx M xmlhelp/source/cxxhelp/inc/qe/Query.hxx M xmlhelp/source/cxxhelp/provider/content.hxx M xmlhelp/source/cxxhelp/provider/contentcaps.cxx M xmlhelp/source/cxxhelp/provider/inputstream.hxx M xmlhelp/source/cxxhelp/provider/provider.hxx M xmlhelp/source/cxxhelp/provider/resultsetbase.hxx M xmlhelp/source/cxxhelp/test/abidebug.hxx M xmlhelp/source/cxxhelp/test/searchdemo.cxx M xmlhelp/source/treeview/tvfactory.hxx 10 files changed, 94 insertions(+), 122 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/525/1 -- To view, visit https://gerrit.libreoffice.org/525 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a773936ceb012b0655cee8db7250b496e088464 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Olivier Hallot olivier.hal...@alta.org.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: boost/StaticLibrary_boostdatetime.mk
boost/StaticLibrary_boostdatetime.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ceaa802b1fab878b51564f38543087d838da3bff Author: Matúš Kukan matus.ku...@gmail.com Date: Sat Sep 1 05:39:44 2012 +0200 boost: use add_generated_exception_objects Change-Id: I360f2fd6ee0b9b99410f83b7f56470bbea3571d6 diff --git a/boost/StaticLibrary_boostdatetime.mk b/boost/StaticLibrary_boostdatetime.mk index eaba81e..85ba8ff 100644 --- a/boost/StaticLibrary_boostdatetime.mk +++ b/boost/StaticLibrary_boostdatetime.mk @@ -15,7 +15,7 @@ $(eval $(call gb_StaticLibrary_use_unpacked,boostdatetime,boost)) $(eval $(call gb_StaticLibrary_set_cxx_suffix,boostdatetime,cpp)) -$(eval $(call gb_StaticLibrary_add_generated_cxxobjects,boostdatetime,\ +$(eval $(call gb_StaticLibrary_add_generated_exception_objects,boostdatetime,\ UnpackedTarball/boost/libs/date_time/src/gregorian/date_generators \ UnpackedTarball/boost/libs/date_time/src/gregorian/gregorian_types \ UnpackedTarball/boost/libs/date_time/src/gregorian/greg_month \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Proposed HARDHACK
Bjoern Michaelsen schrieb: Hi, based on Bjoern's suggestion I added some more conditions for the report (+ MAB3.5, + major severity, - already assigned), Result is [1] with 42 Hits. According query is this one [2]! I put that query into a spreadsheet to collect more info (Number of Comments, Number of DUPs, ..., you can download it by FTP Dpcument HardHacks2a.ods from folder /Collab Server: bielefeldundbuss.de User Name: f0023e73 Password: AERzjßf Document Password: HardHack If you really download document for edits you should rename document _x.txt with something like 2012-08-31-MyName (and rename back when ready) so that everybody can see that the current version might be obsolete. Or may be you manage to open the document on the server? LibO Master Password: anitram I always only get general i/o error (or LibO crashes) Best Regards Rainer Hyperlinks: [1] https://bugs.freedesktop.org/report.cgi?x_axis_field=bug_severityy_axis_field=componentz_axis_field=query_format=report-tableshort_desc_type=allwordssubstrshort_desc=product=LibreOfficebug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFObug_status=PLEASETESTlongdesc_type=allwordssubstrlongdesc=bug_file_loc_type=allwordssubstrbug_file_loc=status_whiteboard_type=allwordssubstrstatus_whiteboard=keywords_type=allwordskeywords=bug_id=bug_id_type=anyexactbug_severity=blockerbug_severity=criticalbug_severity=majoremailassigned_to1=1emailtype1=substringemail1=libreoffice-bugs%40lists.freedesktop.orgemailtype2=substringemail2=emailtype3=substringemail3=chfieldvalue=chfieldfrom=chfieldto=Nowfield0-0-0=blockedtype0-0-0=anywordssubstrvalue0-0-0=6%2C+37361field0-1-0=nooptype0-1-0=noopvalue0-1-0=format=tableaction=wrap [2] https://bugs.freedesktop.org/buglist.cgi?cmdtype=doremremaction=runnamedcmd=ProposedHardHacks2 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Proposed HARDHACK
Am 30.08.12 14:43, schrieb Bjoern Michaelsen: On Thu, Aug 30, 2012 at 11:52:38AM +0200, Roman Eisele wrote: * https://bugs.freedesktop.org/show_bug.cgi?id=47368 * https://bugs.freedesktop.org/show_bug.cgi?id=39007 * https://bugs.freedesktop.org/show_bug.cgi?id=44664 The report only shows 3.6 MAB, it should be easy to extend to 3.5 and 3.7 MABs, too. Ah, thank you for clarification! IMHO Bjoern's query/report proposal is a very good base for selecting the hardhack proposals, given that the query is extended to include 3.5 and 3.7 MABs, too. Best regards, Roman ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-accessibility] Adding Accessibility component to Bug Assistant
Hi :) In bug-reports there are several drop-downs. One has feature request and i think another has Easy hack? Would one of those be better than the other? Which of those was which option of the a, b, c etc? Regards from Tom :) From: Ti tengo d'occhio i...@titengodocchio.it To: libreoff...@bielefeldundbuss.de Cc: Roman Eisele p...@roman-eisele.de; Marc Paré m...@marcpare.com; libreoffice-qa@lists.freedesktop.org; accessibil...@global.libreoffice.org Sent: Friday, 31 August 2012, 10:35 Subject: Re: [libreoffice-accessibility] [Libreoffice-qa] Adding Accessibility component to Bug Assistant Hi Rainer, well, I didn't know that there were developers focused on specific components; in this case adding an accessibility component won't be the best thing to do, in my opinion… At this point I think we could go for solution C or solution A; in case of solution A, would it be possible to view all issues with the pseudo-keyword accessibility? However I think that solution C could be very suitable; in drupal, for instance, to report accessibility issues there are two special tags: - Accessibility: it means that this is an accessibility issue (it could be a bug, a feature request, a task, etc etc) ; - needs accessibility review: this means that the issue or the patch to solve it needs to be tested by a blind user or an accessibility expert. Now we could choose to use only the accessibility keyword or maybe both accessibility and needs accessibility review, I don't know; but also using just the first keyword would be a great thing… Vincenzo. Il giorno 31/ago/2012, alle ore 06:36, Rainer Bielefeld libreoff...@bielefeldundbuss.de ha scritto: Ti tengo d'occhio schrieb: in my opinion it would be great to have a component for accessibility; it could let developers to better focus on accessibility bugs and, on the other hand, blind people to know that accessibility is important for this project and that submitting bug reports of this type is more than encouraged… Hi, the advantage of an Accessibility Component would be that it can easily be selected from a pulldown, no typos or other mistakes can happen.But a problem is that an Accessibility Component would not indicate what developer might be the one who can fix the problem. So it always would be replaced during the bug triaging and fixing process. An other possibility would be a Whiteboard entry, but that only can be done after a report in a second step, typos might happen, it is too modest. So I currently think about a Bug Submission Assistant enhancement. We can add a checkbox Accessibility affected, and the Assistant will add Accessibility a) as additional pseudo key word to the Bug Summary line. The advantage of this solution is that the key word would be very visible. or b) as additional pseudo key word to the whiteboard or will c) set Key word Accessibility to the Keyword pane (it should not be a problem to get this new key word from FDO). The advantae of this solution is that it also eases and unifies handling in Bugzilla itself, not only via BSA. And of course d) New Component Accessibility still can be discussed. My order of preference (descending): c - a - b - d Your opinion? When we have a solution here, we can start to mark and process accessibility bugs with increased priority. Best regards Rainer -- Unsubscribe instructions: E-mail to accessibility+h...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/accessibility/ All messages sent to this list will be publicly archived and cannot be deleted -- Unsubscribe instructions: E-mail to accessibility+h...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/accessibility/ All messages sent to this list will be publicly archived and cannot be deleted ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-accessibility] Adding Accessibility component to Bug Assistant
Hi, As I've been rather vocal on this issue in the last couple of days in particular, I'd really like to be in a better position to lend a hand with any proceedings. Can anyone point me to some docs to look over for bug reporting in LO? And, does the user account creation mechanism for the bug reporting site have one of those abominable captcha thingies on it? It's always been a barrier to me before since I can never, for the life of me make out the audio challenges. After the third or fourth time I replay it, I am ready to toss the old pc out the window to the accompaniment of mad cackling and jumping up and down in maniacle glee. Alex M On 8/31/12, Tom Davies tomdavie...@yahoo.co.uk wrote: Hi :) In bug-reports there are several drop-downs. One has feature request and i think another has Easy hack? Would one of those be better than the other? Which of those was which option of the a, b, c etc? Regards from Tom :) From: Ti tengo d'occhio i...@titengodocchio.it To: libreoff...@bielefeldundbuss.de Cc: Roman Eisele p...@roman-eisele.de; Marc Paré m...@marcpare.com; libreoffice-qa@lists.freedesktop.org; accessibil...@global.libreoffice.org Sent: Friday, 31 August 2012, 10:35 Subject: Re: [libreoffice-accessibility] [Libreoffice-qa] Adding Accessibility component to Bug Assistant Hi Rainer, well, I didn't know that there were developers focused on specific components; in this case adding an accessibility component won't be the best thing to do, in my opinion… At this point I think we could go for solution C or solution A; in case of solution A, would it be possible to view all issues with the pseudo-keyword accessibility? However I think that solution C could be very suitable; in drupal, for instance, to report accessibility issues there are two special tags: - Accessibility: it means that this is an accessibility issue (it could be a bug, a feature request, a task, etc etc) ; - needs accessibility review: this means that the issue or the patch to solve it needs to be tested by a blind user or an accessibility expert. Now we could choose to use only the accessibility keyword or maybe both accessibility and needs accessibility review, I don't know; but also using just the first keyword would be a great thing… Vincenzo. Il giorno 31/ago/2012, alle ore 06:36, Rainer Bielefeld libreoff...@bielefeldundbuss.de ha scritto: Ti tengo d'occhio schrieb: in my opinion it would be great to have a component for accessibility; it could let developers to better focus on accessibility bugs and, on the other hand, blind people to know that accessibility is important for this project and that submitting bug reports of this type is more than encouraged… Hi, the advantage of an Accessibility Component would be that it can easily be selected from a pulldown, no typos or other mistakes can happen.But a problem is that an Accessibility Component would not indicate what developer might be the one who can fix the problem. So it always would be replaced during the bug triaging and fixing process. An other possibility would be a Whiteboard entry, but that only can be done after a report in a second step, typos might happen, it is too modest. So I currently think about a Bug Submission Assistant enhancement. We can add a checkbox Accessibility affected, and the Assistant will add Accessibility a) as additional pseudo key word to the Bug Summary line. The advantage of this solution is that the key word would be very visible. or b) as additional pseudo key word to the whiteboard or will c) set Key word Accessibility to the Keyword pane (it should not be a problem to get this new key word from FDO). The advantae of this solution is that it also eases and unifies handling in Bugzilla itself, not only via BSA. And of course d) New Component Accessibility still can be discussed. My order of preference (descending): c - a - b - d Your opinion? When we have a solution here, we can start to mark and process accessibility bugs with increased priority. Best regards Rainer -- Unsubscribe instructions: E-mail to accessibility+h...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/accessibility/ All messages sent to this list will be publicly archived and cannot be deleted -- Unsubscribe instructions: E-mail to accessibility+h...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/accessibility/ All messages sent to this list will be publicly archived and cannot be deleted -- Unsubscribe instructions: E-mail to
[Libreoffice-bugs] [Bug 54235] Form element data loss when saving in .docx format, text field
https://bugs.freedesktop.org/show_bug.cgi?id=54235 --- Comment #7 from Karl Bowden karlbow...@gmail.com 2012-08-31 06:13:41 UTC --- Also interested in seeing this resolved. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54235] Form element data loss when saving in .docx format, text field
https://bugs.freedesktop.org/show_bug.cgi?id=54235 --- Comment #8 from Janine janine_har...@debortoli.com.au 2012-08-31 06:18:00 UTC --- Really eager to see this resolved!! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35834] The efficiency of TABLES in LibreOffice is bad in some situation (CPU 100%)
https://bugs.freedesktop.org/show_bug.cgi?id=35834 sasha.libreoff...@gmail.com changed: What|Removed |Added Resolution|INVALID |WORKSFORME CC||sasha.libreoff...@gmail.com --- Comment #8 from sasha.libreoff...@gmail.com 2012-08-31 06:34:10 UTC --- not reproduced in 3.6.1. WFM -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35837] [FileOpen/Formatting] pptx from 2010 - Background Gradients Ignored
https://bugs.freedesktop.org/show_bug.cgi?id=35837 sasha.libreoff...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO CC||sasha.libreoff...@gmail.com --- Comment #3 from sasha.libreoff...@gmail.com 2012-08-31 06:40:35 UTC --- Thanks for bugreport Please, attach file that demonstrates problem -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35837] [FileOpen/Formatting] pptx from 2010 - Background Gradients Ignored
https://bugs.freedesktop.org/show_bug.cgi?id=35837 Kenney Phillis Jr kphilli...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||FIXED --- Comment #4 from Kenney Phillis Jr kphilli...@gmail.com 2012-08-31 06:45:13 UTC --- I just tested the files that had the issue with a newer release of Libreoffice. Libreoffice 3.5.4.2 ( version from Ubuntu 12.04 ) did not display this issue. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35837] [FileOpen/Formatting] pptx from 2010 - Background Gradients Ignored
https://bugs.freedesktop.org/show_bug.cgi?id=35837 sasha.libreoff...@gmail.com changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #5 from sasha.libreoff...@gmail.com 2012-08-31 06:51:03 UTC --- Thanks for additional testing -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35860] Writer thinks that all pages of .doc file with mixed album/portrait pages have portrait orientation
https://bugs.freedesktop.org/show_bug.cgi?id=35860 sasha.libreoff...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #16 from sasha.libreoff...@gmail.com 2012-08-31 06:56:00 UTC --- in 3.6.1 on Fedora 64 bit works correctly. Changing to WFM -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48741] [FORMATTING] container issue for Page styles/formatting header and footer
https://bugs.freedesktop.org/show_bug.cgi?id=48741 Bug 48741 depends on bug 35860, which changed state. Bug 35860 Summary: Writer thinks that all pages of .doc file with mixed album/portrait pages have portrait orientation https://bugs.freedesktop.org/show_bug.cgi?id=35860 What|Old Value |New Value Status|UNCONFIRMED |NEW Resolution||WORKSFORME Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54302] New: Data sorting with dzong-ka language doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=54302 Bug #: 54302 Summary: Data sorting with dzong-ka language doesn't work Classification: Unclassified Product: LibreOffice Version: 3.6.1.2 release Platform: x86 (IA32) OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: max.kamme...@yahoo.com When try to sort table data (in LibreOffice Calc 3.6.1) with language specific order (in my case it was dzong-ka) the data sorted in wrong way: it seems that office sort it via charcodes. It was work in Calc 3.5.4!!! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54257] RTF document created by Oracle Report - text areas close table framing
https://bugs.freedesktop.org/show_bug.cgi?id=54257 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever Confirmed|0 |1 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:03:46 UTC --- Please provide a sample ODB file containing a report with the default, and detailed steps to reproduce the problem. For the moment, your description is too vague. The RTF document you provide is only 1 page long. What do you mean by text areas enclose framing ? For the moment, I can't determine where the problem lies, perhaps it is : - the RTF export filter ; - the Report generator ; - some other unknown factor, like page or printer configuration. In order to be able to test/confirm, we need you to provide us with the steps that led to the result that you consider buggy. Setting NEEDINFO status. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54303] New: FILEOPEN: specific XLS (Office 2003) file crashes LibO 3.6
https://bugs.freedesktop.org/show_bug.cgi?id=54303 Bug #: 54303 Summary: FILEOPEN: specific XLS (Office 2003) file crashes LibO 3.6 Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: behou...@ckdkh.cz Created attachment 66384 -- https://bugs.freedesktop.org/attachment.cgi?id=66384 sample file that causes LibO 3.6 crashing Problem description: There are specific files created in MS Office 2003 which cause LibO 3.6.0 / 3.6.1 crashing (when opened). The same files worked fine with LibO 3.4.x/3.5.x. Sample file attached. Steps to reproduce: 1. (try to) open the attached file Current behavior: LibreOffice crashes with the message Due to an unexpected error, LibreOffice crashed. All the files you were working on will now be saved. The next time LibreOffice is launched, your files will be recovered automatically. Expected behavior: the file opens -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54303] FILEOPEN: specific XLS (Office 2003) file crashes LibO 3.6
https://bugs.freedesktop.org/show_bug.cgi?id=54303 Karel Behounek behou...@ckdkh.cz changed: What|Removed |Added Platform|Other |x86 (IA32) OS/Version|All |Windows (All) Version|unspecified |3.6.1.2 release -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52273] Base's open-existing-file dropdown list can not display Thai database name correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=52273 --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:18:45 UTC --- IMO, this is a Unicode character support problem. For me, on Linux Mint 12 64bit, the file name is displayed correctly in the Open dialog drop down list, independently of whether I open it with LO 3.5.4 or Version 3.6.0.4 (Build ID: 932b512). However, the title bar of the main ODB window is displayed incorrectly as a series of rectangles, whereas the data contained within the table of the database is displayed correctly. I am enclosing a screenshot. So, basically, I can not confirm the reporter's findings on Linux, with regard to the Open dialog, IMO, this is Windows specific. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52273] Base's open-existing-file dropdown list can not display Thai database name correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=52273 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:19:59 UTC --- Created attachment 66385 -- https://bugs.freedesktop.org/attachment.cgi?id=66385 Screenshot in LO 3.6.0.4 Linux Mint 12 64bit -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52273] Base's open-existing-file dropdown list can not display Thai database name correctly.
https://bugs.freedesktop.org/show_bug.cgi?id=52273 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||tima...@gmail.com --- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:21:36 UTC --- Andras might have an idea about this, setting him on CC. @Andras : any idea what has happened here ? Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54304] New: Commandline Admin Installation - INSTALLLOCATION ignored
https://bugs.freedesktop.org/show_bug.cgi?id=54304 Bug #: 54304 Summary: Commandline Admin Installation - INSTALLLOCATION ignored Classification: Unclassified Product: LibreOffice Version: 3.5.6.2 rc Platform: All OS/Version: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Installation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: reisi...@gmail.com Installing LibreOffice 3.6.0.4 and 3.5.6 as an administrative ( aka. Server or Parallel ) installation does not allow setting the installlocation (see the text in a .cmd file for further info. If I use normal installation ( /i instead of /a ) it is working. I am filing this bug as major, because you are not able to install LibreOffice onto a command line server in a custom path... -- install.cmd -- @ECHO off start /wait msiexec /qr /norestart /a T:\_chrome\LibO_3.5.6_Win_x86_install_multi.msi INSTALLLOCATON=L:\3.6.0 exit -- END -- -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52027] ODBC, opening one table calls SQLTables for many tables
https://bugs.freedesktop.org/show_bug.cgi?id=52027 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:32:14 UTC --- @Jochen : Terry knows what he's doing, he's already helped debug other ODBC problems, so am setting this as NEW and passing directly to Lionel. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52027] ODBC, opening one table calls SQLTables for many tables
https://bugs.freedesktop.org/show_bug.cgi?id=52027 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added AssignedTo|libreoffice-b...@lists.free |lio...@mamane.lu |desktop.org | --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:33:07 UTC --- @Lionel : your call I guess. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51767] RTL: Named Parameters not supported in MySQL ODBC queries in Ubuntu 12.04
https://bugs.freedesktop.org/show_bug.cgi?id=51767 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:39:12 UTC --- @Andrew : I am assuming that you did set the option ParameterNameSubstitution in the Advanced Properties dialog of your database connection ? Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54272] When I used the funktion autoformat sw crashed see attachment
https://bugs.freedesktop.org/show_bug.cgi?id=54272 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||DUPLICATE CC||bfo.bugm...@spamgourmet.com --- Comment #1 from bfoman bfo.bugm...@spamgourmet.com 2012-08-31 07:44:48 UTC --- Do not hesitate to reopen in case of mistriage. *** This bug has been marked as a duplicate of bug 47466 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47466] FORMATTING: Autoformat empty rows causes app to crash
https://bugs.freedesktop.org/show_bug.cgi?id=47466 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added CC||roland.g...@freenet.de --- Comment #12 from bfoman bfo.bugm...@spamgourmet.com 2012-08-31 07:44:48 UTC --- *** Bug 54272 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47283] EDITING: crash when accepting a change at the end of the undo stack (updated title)
https://bugs.freedesktop.org/show_bug.cgi?id=47283 Roman Eisele b...@eikota.de changed: What|Removed |Added Platform|Other |All CC||b...@eikota.de -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51767] RTL: Named Parameters not supported in MySQL ODBC queries in Ubuntu 12.04
https://bugs.freedesktop.org/show_bug.cgi?id=51767 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 07:53:32 UTC --- (In reply to comment #2) @Andrew : I am assuming that you did set the option ParameterNameSubstitution in the Advanced Properties dialog of your database connection ? Alex Forget that last comment, it seems that the option in question is no longer present, at least in LO 3.5.4 and 3.6.0.4 - hmm, I wonder when that happened ? I will have to check on an older version of OpenOffice.org. Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53955] Filesave to samba share is not working in Ubuntu 12.04
https://bugs.freedesktop.org/show_bug.cgi?id=53955 Hashem Masoud wraithl...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever Confirmed|0 |1 --- Comment #1 from Hashem Masoud wraithl...@gmail.com 2012-08-31 07:55:24 UTC --- (In reply to comment #0) Could be a duplicate of bug 39093. Are you getting any errors while saving the document? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54305] New: After installation of this version I have a borderline around my logo in write and do not know how to fix this
https://bugs.freedesktop.org/show_bug.cgi?id=54305 Bug #: 54305 Summary: After installation of this version I have a borderline around my logo in write and do not know how to fix this Classification: Unclassified Product: LibreOffice Version: 3.5.6.2 rc Platform: Other OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: krugerf...@gmail.com -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51767] RTL: Named Parameters not supported in MySQL ODBC queries in Ubuntu 12.04
https://bugs.freedesktop.org/show_bug.cgi?id=51767 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk 2012-08-31 08:00:29 UTC --- So, this feature was definitely in the OOo UI at one stage, and somehow is no longer there, see this page, where it was talked about in OOo 2.0 and then introduced : http://www.openoffice.org/dba/howto/param_subst.html Alex -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54235] Form element data loss when saving in .docx format, text field
https://bugs.freedesktop.org/show_bug.cgi?id=54235 --- Comment #9 from Shane Dunn dunn.sh...@gmail.com 2012-08-31 08:01:03 UTC --- Would also like to see this resolved. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48078] Impress: exporting GIF animation from context menu not works
https://bugs.freedesktop.org/show_bug.cgi?id=48078 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added CC||bfo.bugm...@spamgourmet.com --- Comment #1 from bfoman bfo.bugm...@spamgourmet.com 2012-08-31 08:04:22 UTC --- Checked with: LO 3.5.6.2 Build ID: own W7 debug build Windows 7 Professional SP1 64 bit Could not reproduce. Anim GIF saved. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54257] RTF document created by Oracle Report - text areas close table framing
https://bugs.freedesktop.org/show_bug.cgi?id=54257 --- Comment #2 from Timon kaktebyaviru...@gmail.com 2012-08-31 08:05:09 UTC --- Created attachment 66388 -- https://bugs.freedesktop.org/attachment.cgi?id=66388 Another file preview Here is another multirow file. If you try to open it, then you'll see how difficult to scroll this document. In Preview you can see how file looks like and how it is printed (tested with HP, Kyocera, Xerox). Framing disappears in document (text covers frames of the table) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54306] New: PDF: Export to PDF - Strange behaviour regarding filenames
https://bugs.freedesktop.org/show_bug.cgi?id=54306 Bug #: 54306 Summary: PDF: Export to PDF - Strange behaviour regarding filenames Classification: Unclassified Product: LibreOffice Version: 3.5.2 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: antak...@yahoo.com Problem description: Steps to reproduce: 1. Have a presentation ODP open. (in my case 9 pages) 2. Click File-Export to PDF an then click Export. 3. In the explorer window Export, rename an existing pdf file using windows functionality. 4. Now try to save the Exported PDF with a filename entered under File Name (in my case the original filename of the file in point 3) Current behavior: The Software tries to save the PDF with the filename that the file in point 3 was renamed to, and ignores the filename in the File Name (in my case the original filename of the file in point 3). Resulting in a request to overwrite the file I just renamed. Expected behavior: The Software should save the file using the filename entered under the File Name field Platform (if different from the browser): OS: Windows XP 32-bit Libreoffice 3.5.2.2 Build ID: 281b639-6baa1d3-ef66a77-d866f25-f36d45f Browser: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/537.1 (KHTML, like Gecko) Chrome/21.0.1180.79 Safari/537.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54305] After installation of this version I have a borderline around my logo in write and do not know how to fix this
https://bugs.freedesktop.org/show_bug.cgi?id=54305 --- Comment #1 from Faan krugerf...@gmail.com 2012-08-31 08:08:42 UTC --- Created attachment 66389 -- https://bugs.freedesktop.org/attachment.cgi?id=66389 Example of borderline around logo -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36017] Make Extension manager the only way to install addons (Not directly from file manager, not directly from browser)
https://bugs.freedesktop.org/show_bug.cgi?id=36017 sasha.libreoff...@gmail.com changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INVALID | Severity|major |enhancement CC||sasha.libreoff...@gmail.com Ever Confirmed|1 |0 --- Comment #7 from sasha.libreoff...@gmail.com 2012-08-31 08:09:35 UTC --- something like RFE -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
