date:20120907

[PUSHED] sax: com.sun.star.xml.sax.FastSerializer seems to be unused

2012-09-07 Thread Kohei Yoshida (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/480

Approvals:
  Kohei Yoshida: Verified
  Michael Meeks: Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/480
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I826da00c83589f468c499879d86546d60b2aa515
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan 
Gerrit-Reviewer: Kohei Yoshida 
Gerrit-Reviewer: Matúš Kukan 
Gerrit-Reviewer: Michael Meeks 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sax/inc sax/source

2012-09-07 Thread Libreoffice Gerrit user

 sax/inc/fastserializer.hxx  |  202 
 sax/source/fastparser/facreg.cxx|   17 --
 sax/source/fastparser/fastsax.component |3 
 sax/source/tools/fastserializer.cxx |2 
 sax/source/tools/fastserializer.hxx |  202 
 sax/source/tools/fshelper.cxx   |2 
 6 files changed, 204 insertions(+), 224 deletions(-)

New commits:
commit 2ecd5b0372e7953a57ece3c669c22e6545e19f2e
Author: MatÃºÅ¡ Kukan 
Date:   Fri Aug 24 21:43:27 2012 +0200

sax: com.sun.star.xml.sax.FastSerializer seems to be unused

Change-Id: I826da00c83589f468c499879d86546d60b2aa515
Reviewed-on: https://gerrit.libreoffice.org/480
Reviewed-by: Michael Meeks 
Tested-by: Kohei Yoshida 

diff --git a/sax/inc/fastserializer.hxx b/sax/inc/fastserializer.hxx
deleted file mode 100644
index 765cafb..000
--- a/sax/inc/fastserializer.hxx
+++ /dev/null
@@ -1,202 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef SAX_FASTSERIALIZER_HXX
-#define SAX_FASTSERIALIZER_HXX
-
-#include 
-#include 
-#include 
-#include 
-#include 
-#include 
-
-#include 
-#include 
-
-#include 
-
-#include "sax/fshelper.hxx"
-
-#define SERIALIZER_IMPLEMENTATION_NAME  
"com.sun.star.comp.extensions.xml.sax.FastSerializer"
-#define SERIALIZER_SERVICE_NAME "com.sun.star.xml.sax.FastSerializer"
-
-namespace sax_fastparser {
-
-class SAX_DLLPUBLIC FastSaxSerializer : public ::cppu::WeakImplHelper2< 
::com::sun::star::xml::sax::XFastSerializer, 
::com::sun::star::lang::XServiceInfo >
-{
-typedef ::com::sun::star::uno::Sequence< ::sal_Int8 > Int8Sequence;
-typedef ::com::sun::star::uno::Sequence< ::sal_Int32 > Int32Sequence;
-
-public:
-explicitFastSaxSerializer(  );
-virtual ~FastSaxSerializer();
-
-::com::sun::star::uno::Reference< ::com::sun::star::io::XOutputStream > 
getOutputStream() {return mxOutputStream;}
-
-// The implementation details
-static ::com::sun::star::uno::Sequence< ::rtl::OUString >   
getSupportedServiceNames_Static(void);
-
-// XFastSerializer
-virtual void SAL_CALL startDocument(  ) throw 
(::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL endDocument(  ) throw 
(::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL startFastElement( ::sal_Int32 Element, const 
::com::sun::star::uno::Reference< 
::com::sun::star::xml::sax::XFastAttributeList >& Attribs )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL startUnknownElement( const ::rtl::OUString& 
Namespace, const ::rtl::OUString& Name, const ::com::sun::star::uno::Reference< 
::com::sun::star::xml::sax::XFastAttributeList >& Attribs )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL endFastElement( ::sal_Int32 Element )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL endUnknownElement( const ::rtl::OUString& Namespace, 
const ::rtl::OUString& Name )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL singleFastElement( ::sal_Int32 Element, const 
::com::sun::star::uno::Reference< 
::com::sun::star::xml::sax::XFastAttributeList >& Attribs )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL singleUnknownElement( const ::rtl::OUString& 
Namespace, const ::rtl::OUString& Name, const ::com::sun::star::uno::Reference< 
::com::sun::star::xml::sax::XFastAttributeList >& Attribs )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual void SAL_CALL characters( const ::rtl::OUString& aChars )
-throw (::com::sun::star::xml::sax::SAXException, 
::com::sun::star::uno::RuntimeException);
-virtual voi

[Libreoffice-commits] Changes to 'feature/calc-xml-source'

2012-09-07 Thread Libreoffice Gerrit user

New branch 'feature/calc-xml-source' available with the following commits:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] OUString cleanup in accessibility

2012-09-07 Thread Olivier Hallot (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/583

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/583
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifceaa764231306c1f542183afc2e852cc418
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .:

2012-09-07 Thread Libreoffice Gerrit user

 0 files changed

New commits:
commit ea744ff9e8d2d6bb463e6f8f44405f9b574b37d1
Author: Ricardo Montania 
Date:   Fri Sep 7 05:42:09 2012 -0300

OUString cleanup in accessibility

Change-Id: Ifceaa764231306c1f542183afc2e852cc418
Reviewed-on: https://gerrit.libreoffice.org/583
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: valgrinding with python stuff active

2012-09-07 Thread julien2412

Sorry, I didn't get the point about G_SLICE or the Stephan's commit.
For a beginner like me, what must I change/add to this line:
valgrind --tool=memcheck --num-callers=50 --trace-children=yes ./soffice.bin
2>&1 | tee /tmp/valgrind.log

so I get no false positive with Python and/or Java?

I read this:
"
By default LibreOffice uses a custom memory allocator, so valgrind won't be
able to give full results unless this is disabled, disable it at runtime
with...

$ export G_SLICE=always-malloc
"
on this page http://wiki.documentfoundation.org/Development/How_to_debug
but what about if custom memory allocator is bugged? (BTW why do we use
this? Historical reason?) Wouldn't Valgrind be helpful to detect it?

I'm a bit lost here :-(

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/valgrinding-with-python-stuff-active-tp4006046p4006167.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Design-related questions

2012-09-07 Thread Alexander Wilms

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi,

during the last IRC meeting of the design team a few questions were
raised and maybe some devs could answer them.

1) Would it be feasible to create a new UI element, a modal bar like
the one shown in Nautilus when e.g. an MP3 player is plugged. After
the user exits Impress' slideshow mode while using the Android remote,
a modal bar should appear, featuring a button to disconnect the phone
and one to stay connected for future presentations.

2) Do you need the option 'Size optimization for ODF format'. We're
not sure whether it's an advanced feature used by devs or if it's
unneccessary.

3) Is it possible to integrate warnings like 'You're saving to OOXML,
which means some formatting might get lost.' into the system file dialogs?

Thanks a lot

Alex
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQEcBAEBAgAGBQJQSnc8AAoJECO1/tAiWGrNSJMH/3ZVK8B2A1Geg63y84m3WnHo
LgjLUGQZiUjL1GUY8QOrKnNYaZ+RuRIeE6hWzNVQBtF9WOXXRz+lDBhxqS2dzBgF
RySiHOJWHoQqBdFA1GTaUndikYHIFfnZ+X70FTG0NPPdq9sUB3VpPjR4jl3LykqG
vPI8LxpvoZhvxEImGA8CtmVi46CFX6be4aeH+g5IxEWDqiJkuv67bwDoL6/VTui4
BOg1huMB57YwN/7Jt1c6qCuSfW+O02aRjfD5ly8eAq9dGkoOa1VnAcUFOThkPdAW
kO1M+oEn/6fICjkYkmu6VVy2NCjAHOMFS+03XTMY+FBolxaqWGvSFHRcdnnJEf8=
=Njy/
-END PGP SIGNATURE-

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUString cleanup in animations

2012-09-07 Thread Olivier Hallot (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/584

Approvals:
  Olivier Hallot: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/584
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib858f9fa709d72539f71a6473a4ecb519d68e98e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Olivier Hallot 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: animations/source

2012-09-07 Thread Libreoffice Gerrit user

 animations/source/animcore/animcore.cxx|5 --
 animations/source/animcore/factreg.hxx |4 -
 animations/source/animcore/targetpropertiescreator.cxx |   36 -
 3 files changed, 22 insertions(+), 23 deletions(-)

New commits:
commit 1bbe1743c288392b9b2421f9d33efa8d05a01008
Author: Ricardo Montania 
Date:   Fri Sep 7 16:54:11 2012 -0300

OUString cleanup in animations

Change-Id: Ib858f9fa709d72539f71a6473a4ecb519d68e98e
Reviewed-on: https://gerrit.libreoffice.org/584
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/animations/source/animcore/animcore.cxx 
b/animations/source/animcore/animcore.cxx
index f372bbb..a194dcc 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -55,7 +55,6 @@
 
 using ::osl::Mutex;
 using ::osl::Guard;
-using ::rtl::OUString;
 using ::cppu::OInterfaceContainerHelper;
 using ::cppu::OInterfaceIteratorHelper;
 using ::com::sun::star::uno::Any;
@@ -515,12 +514,12 @@ Reference< XInterface > SAL_CALL createInstance_##N( 
const Reference< XComponent
 }\
 OUString getImplementationName_##N()\
 {\
-return OUString( RTL_CONSTASCII_USTRINGPARAM ( IN ) );\
+return OUString( IN );\
 }\
 Sequence getSupportedServiceNames_##N(void)\
 {\
 Sequence aRet(1);\
-aRet.getArray()[0] = OUString( RTL_CONSTASCII_USTRINGPARAM( SN ));\
+aRet.getArray()[0] = SN;\
 return aRet;\
 }
 
diff --git a/animations/source/animcore/factreg.hxx 
b/animations/source/animcore/factreg.hxx
index 09b7a36..a809c06 100644
--- a/animations/source/animcore/factreg.hxx
+++ b/animations/source/animcore/factreg.hxx
@@ -24,8 +24,8 @@ extern rtl_StandardModuleCount g_moduleCount;
 
 #define DECL_NODE_FACTORY(N)\
 extern ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > 
SAL_CALL createInstance_##N( const ::com::sun::star::uno::Reference< 
::com::sun::star::uno::XComponentContext > & rSMgr ) throw 
(::com::sun::star::uno::Exception);\
-extern ::rtl::OUString getImplementationName_##N();\
-extern ::com::sun::star::uno::Sequence< ::rtl::OUString> 
getSupportedServiceNames_##N(void)
+extern OUString getImplementationName_##N();\
+extern ::com::sun::star::uno::Sequence< OUString> 
getSupportedServiceNames_##N(void)
 
 DECL_NODE_FACTORY( PAR );
 DECL_NODE_FACTORY( SEQ );
diff --git a/animations/source/animcore/targetpropertiescreator.cxx 
b/animations/source/animcore/targetpropertiescreator.cxx
index 128b5f1..4ecdce4 100644
--- a/animations/source/animcore/targetpropertiescreator.cxx
+++ b/animations/source/animcore/targetpropertiescreator.cxx
@@ -70,12 +70,12 @@ namespace animcore
 virtual uno::Sequence< animations::TargetProperties > SAL_CALL 
createInitialTargetProperties( const uno::Reference< animations::XAnimationNode 
>& rootNode ) throw (uno::RuntimeException);
 
 // XServiceInfo
-virtual ::rtl::OUString SAL_CALL getImplementationName() throw( 
uno::RuntimeException );
-virtual sal_Bool SAL_CALL supportsService( const ::rtl::OUString& 
ServiceName ) throw( uno::RuntimeException );
-virtual uno::Sequence< ::rtl::OUString > SAL_CALL 
getSupportedServiceNames()  throw( uno::RuntimeException );
+virtual OUString SAL_CALL getImplementationName() throw( 
uno::RuntimeException );
+virtual sal_Bool SAL_CALL supportsService( const OUString& ServiceName 
) throw( uno::RuntimeException );
+virtual uno::Sequence< OUString > SAL_CALL getSupportedServiceNames()  
throw( uno::RuntimeException );
 
 // XServiceName
-virtual ::rtl::OUString SAL_CALL getServiceName(  ) throw 
(uno::RuntimeException);
+virtual OUString SAL_CALL getServiceName(  ) throw 
(uno::RuntimeException);
 
 protected:
 ~TargetPropertiesCreator(); // we're a ref-counted UNO class. _We_ 
destroy ourselves.
@@ -95,15 +95,15 @@ namespace animcore
 return TargetPropertiesCreator::createInstance( rSMgr );
 }
 
-::rtl::OUString getImplementationName_TargetPropertiesCreator()
+OUString getImplementationName_TargetPropertiesCreator()
 {
-return ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM ( 
IMPLEMENTATION_NAME ) );
+return OUString( IMPLEMENTATION_NAME );
 }
 
-uno::Sequence< ::rtl::OUString > 
getSupportedServiceNames_TargetPropertiesCreator(void)
+uno::Sequence< OUString > 
getSupportedServiceNames_TargetPropertiesCreator(void)
 {
-uno::Sequence< ::rtl::OUString > aRet(1);
-aRet.getArray()[0] = ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( 
SERVICE_NAME ) );
+uno::Sequence< OUString > aRet(1);
+aRet.getArray()[0] = SERVICE_NAME;
 return aRet;
 }
 
@@ -342,7 +342,7 @@ namespace animcore
 if( !(aAny >>= bVisible) )
 {
 // try to extract string
-::rtl::OUString aString;
+

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-09-07 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #373 from Joel Madero  2012-09-07 21:47:29 
UTC ---
Nominating fdo#50285
https://bugs.freedesktop.org/show_bug.cgi?id=50285

This bug has the potential of really creating an unprofessional document. This
could be a real problem for business people or students if they save as a
document and then submit the work as it completely changes the text.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] How Can I Provide More Info For Developers

2012-09-07 Thread julien2412

Just some thoughts here.
First backtrace are very useful only if they contain symbols.
It's more difficult to retrieve bt on Windows than on Linux (I don't know
how MacOs could be compared with them)
It seems no daily builds contain symbols or missed it
(http://dev-builds.libreoffice.org/daily/).
It's more complicated to compile on Windows (a little less for MacOs) than
for Linux. At least, it seems so according to what I read.
We can't expect any user build sources or have an idea about what's a
backtrace/strace/Valgrind trace is
As a simple QA contributor, I think preserving time of Devs is very
important, more important than QA people time, because:
- dev guys are few compared to the size of the project, especially in some
parts like Base
- it's easier to learn the basics of QA than C++. Of course, QA time mustn't
be spoiled because they're few too

But:
Main (all?) Linux distributions provide the LO symbols package so you don't
need to build LO to retrieve useful bt.
Doc efforts have been made to help retrieved bt in:
- Linux
(http://wiki.documentfoundation.org/BugReport#How_to_get_backtrace_.28on_Linux.29)
- Windows
(http://wiki.documentfoundation.org/BugReport#How_to_get_backtrace_.28on_WINDOWS.29)
A great video has been made by jesus corrius to explain how to install the
required tools on Windows and retrieve an useful bt and guys like bfo
retrieved a lot of bt (greatly appreciated for Windows only trackers).
- wiki pages (eg: Native build and bug reporting) and BSA bring and help a
lot new comers (computer student or simple user) who take some dev tasks or
do some QA. So let's keep on to improve these tools

The fact is we can't guess in general the computer skill of a reporter so we
can only ask politely these info by giving him/her the links quoted above.
It can't be an offense or a scarecrow to ask technical info to people ! :-)

Julien

--
View this message in context:
http://nabble.documentfoundation.org/How-Can-I-Provide-More-Info-For-Developers-tp4006100p4006162.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

1 2 >

1 - 100 of 123 matches

Mail list logo