Re: LibreOffice Forums Categories Proposal

[Marc Paré]

Hi Simos and thanks for the tips!

Le 2012-09-27 19:00, Simos Xenitellis a écrit :



At the moment http://jforum.andowson.com/ does not work. I suppose it
will be back soon.
I would like to try it out.

My concern with jforum2 is that it is different from other popular
forum packages such as phpbb or vbulletin (closed source).
Christian should make sure that he trains more admins into this forum software.

Whether a forum works or not, depends on the first few months. There
should be several volunteers that help out so that new users find
quality answers soon.

Some questions will be repeated, so the volunteers will try to write
them down in a HowTo post or a Wiki page. Do not count that there will
always be volunteers to answer the same question repeatedly. Does not
scale.
Something that we do at our local forum is have a HowTo section that
we add there good solutions to common problems, then pinpoint new
users to check there.
A good solution is needed here.

I highly recommend to get new users for the forum to accept a Code of
Conduct such as
http://fridge.ubuntu.com/2012/09/27/code-of-conduct-v2-request-for-feedback/
This will help the volunteers to deal with fights, etc.

In order to motivate users, some forum software have the facility to
say thanks to a good reply. Such a facility will be good to have.

Simos


We are just at the point of setting the categories which is taking place 
on the discuss list. We are hoping to hold most of the discussions on 
the forums there.


As for the choice of forums, we had eventually settled on jForums and 
phpBB with the final choice going to jForums. Christian is in charge of 
all that is technical. We are 5 co-coordinators (admins) and already 
have a pre-list of approximately 8 moderators (even before starting to 
look for them). We are hoping to have 2 moderators/forums, hopefully 
more on busy forums. I don't think coming up with moderators will be a 
problem and we will recruit more as the forums become busier.


Code of conduct is being investigated by one of the co-coordinators and 
this should be ready withing a week or so. I will pass on the link to 
the Ubuntu code of conduct to that person.


As soon as the categories are discussed and we come to an agreement on 
this (on the discussion list), we will get to work on the nitty-gritty 
of the forums site. As we all know, the topic of putting up a forums is 
quite an emotional topic, we are hoping that everyone will have a say 
with the choice of forum categories.


We (co-coordinators) have already discussed between ourselves of putting 
up "stickies" for HowTo's to help users out, but, not really as a 
separate section, although, this may prove to be a good idea.


Feel free to join in on the discussion on the Discuss list.

Thanks again for the useful tips!

Marc


--
Marc Paré
m...@marcpare.com
http://www.parEntreprise.com
parEntreprise.com Supports OpenDocument Formats (ODF)
parEntreprise.com Supports http://www.LibreOffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/inc

[Libreoffice Gerrit user]

 sc/inc/dpcache.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3f27767397831b061fa6517434c5190e9f64eab2
Author: Kohei Yoshida 
Date:   Thu Sep 27 23:31:05 2012 -0400

Remove unnecessary semicolon.

Change-Id: Ia63d73b79ffaae15f82d3abc4addca39a98c7e04

diff --git a/sc/inc/dpcache.hxx b/sc/inc/dpcache.hxx
index b69e3c2..2ebae6d 100644
--- a/sc/inc/dpcache.hxx
+++ b/sc/inc/dpcache.hxx
@@ -108,7 +108,7 @@ public:
 virtual bool next() = 0;
 virtual void finish() = 0;
 virtual void getValue(long nCol, ScDPItemData& rData, short& rNumType) 
const = 0;
-virtual ~DBConnector() { };
+virtual ~DBConnector() {}
 };
 
 private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: svtools/inc svtools/source

[Libreoffice Gerrit user]

 svtools/inc/svtools/svlbox.hxx   |   20 ++--
 svtools/inc/svtools/treelist.hxx |   37 --
 svtools/source/contnr/svlbox.cxx |   65 +++
 3 files changed, 83 insertions(+), 39 deletions(-)

New commits:
commit 77a0acae58828d2186bce241b562c363da93343b
Author: Kohei Yoshida 
Date:   Thu Sep 27 15:37:27 2012 -0400

Remove DECLARE_SVTREELIST.

There is only one place that uses it.

Change-Id: Ie3a41b36a5273c9b658b6a2f0e5d029bcb148546

diff --git a/svtools/inc/svtools/svlbox.hxx b/svtools/inc/svtools/svlbox.hxx
index 6c7c0fb..b582806 100644
--- a/svtools/inc/svtools/svlbox.hxx
+++ b/svtools/inc/svtools/svlbox.hxx
@@ -215,6 +215,24 @@ public:
 voidSetFlags( sal_uInt16 nFlags ) { nEntryFlags = nFlags; }
 };
 
+class SVT_DLLPUBLIC SvLBoxTreeList : public SvTreeList
+{
+public:
+SvLBoxEntry* First() const;
+SvLBoxEntry* Next( SvListEntry* pEntry, sal_uInt16* pDepth=0 ) const;
+SvLBoxEntry* Prev( SvListEntry* pEntry, sal_uInt16* pDepth=0 ) const;
+SvLBoxEntry* Last() const;
+SvLBoxEntry* Clone( SvListEntry* pEntry, sal_uLong& nCloneCount ) const;
+SvLBoxEntry* GetEntry( SvListEntry* pParent, sal_uLong nPos ) const;
+SvLBoxEntry* GetEntry( sal_uLong nRootPos ) const;
+SvLBoxEntry* GetParent( SvListEntry* pEntry ) const;
+SvLBoxEntry* FirstChild( SvLBoxEntry* pParent ) const;
+SvLBoxEntry* NextSibling( SvLBoxEntry* pEntry ) const;
+SvLBoxEntry* PrevSibling( SvLBoxEntry* pEntry ) const;
+SvLBoxEntry* LastSibling( SvLBoxEntry* pEntry ) const;
+SvLBoxEntry* GetEntryAtAbsPos( sal_uLong nAbsPos ) const;
+};
+
 // *
 // ** SvLBox ***
 // *
@@ -232,8 +250,6 @@ public:
 // Das Drop-Target ist in diesem Fall 0
 #define SV_DRAGDROP_ENABLE_TOP  (DragDropMode)0x0020
 
-DECLARE_SVTREELIST(SvLBoxTreeList, SvLBoxEntry*)
-
 #define SVLISTBOX_ID_LBOX 0   // fuer SvLBox::IsA()
 
 #define SVLBOX_IN_EDT   0x0001
diff --git a/svtools/inc/svtools/treelist.hxx b/svtools/inc/svtools/treelist.hxx
index d5ba003..bc0b683 100644
--- a/svtools/inc/svtools/treelist.hxx
+++ b/svtools/inc/svtools/treelist.hxx
@@ -603,43 +603,6 @@ inline SvListEntry* SvTreeList::GetParent( SvListEntry* 
pEntry ) const
 return pParent;
 }
 
-#define DECLARE_SVTREELIST( ClassName, Type )  
 \
-class ClassName : public SvTreeList
 \
-{  
 \
-public:
 \
-TypeFirst() const  
 \
-{ return (Type)SvTreeList::First(); }  
 \
-TypeNext( SvListEntry* pEntry, sal_uInt16* pDepth=0 ) const
 \
-{ return (Type)SvTreeList::Next(pEntry,pDepth); }  
 \
-TypePrev( SvListEntry* pEntry, sal_uInt16* pDepth=0 ) const
 \
-{ return (Type)SvTreeList::Prev(pEntry,pDepth); }  
 \
-TypeLast() const   
 \
-{ return (Type)SvTreeList::Last(); }   
 \
-   
 \
-TypeClone( SvListEntry* pEntry, sal_uLong& nCloneCount ) const 
 \
-{ return (Type)SvTreeList::Clone(pEntry,nCloneCount); }
 \
-TypeGetEntry( SvListEntry* pParent, sal_uLong nPos ) const 
 \
-{ return (Type)SvTreeList::GetEntry(pParent,nPos); }   
 \
-TypeGetEntry( sal_uLong nRootPos ) const   
 \
-{ return (Type)SvTreeList::GetEntry(nRootPos); }   
 \
-TypeGetParent( SvListEntry* pEntry ) const 
 \
-{ return (Type)SvTreeList::GetParent(pEntry); }
 \
-using SvTreeList::FirstChild;  
 \
-TypeFirstChild( Type pParent ) const   
 \
-{ return (Type)SvTreeList::FirstChild(pParent); }  
 \
-using SvTreeList::NextSibling; 
 \
-TypeNextSibling( Type pEntry ) const   
 \
-{ return (Type)SvTreeList::NextSibling(pEntry); }  
 \
-using SvTreeList::PrevSibling; 
 \
-TypePrevSibling( Type pEntry ) const   
 \
-{ return (Type)SvTreeList::PrevSibling(pEntry); }  
 \
-usin

[Libreoffice-commits] .: 2 commits - sc/source

[Libreoffice Gerrit user]

 sc/source/filter/oox/extlstcontext.cxx |8 +++-
 sc/source/filter/oox/formulabuffer.cxx |   17 +
 2 files changed, 16 insertions(+), 9 deletions(-)

New commits:
commit 6ed264ffca065ed2aa36624ba29d9764ff042a72
Author: Markus Mohrhard 
Date:   Fri Sep 28 01:22:44 2012 +0200

fix vell value import from ooxml with array formulas, fdo#54559

Change-Id: I3a7e30940c543a178bba3008db2c6056b4d3

diff --git a/sc/source/filter/oox/formulabuffer.cxx 
b/sc/source/filter/oox/formulabuffer.cxx
index f2f1d69..70efcaf 100644
--- a/sc/source/filter/oox/formulabuffer.cxx
+++ b/sc/source/filter/oox/formulabuffer.cxx
@@ -99,23 +99,23 @@ void FormulaBuffer::finalizeImport()
 applyCellFormulas( cellIt->second );
 }
 
+ArrayFormulaDataMap::iterator itArray = cellArrayFormulas.find( nTab );
+if ( itArray != cellArrayFormulas.end() )
+{
+applyArrayFormulas( itArray->second );
+}
+
 FormulaValueMap::iterator itValues = cellFormulaValues.find( nTab );
 if ( itValues != cellFormulaValues.end() )
 {
 std::vector< ValueAddressPair > & rVector = itValues->second;
 applyCellFormulaValues( rVector );
 }
-
-ArrayFormulaDataMap::iterator itArray = cellArrayFormulas.find( nTab );
-
-if ( itArray != cellArrayFormulas.end() )
-{
-applyArrayFormulas( itArray->second );
-}
 }
 rDoc.SetAutoNameCache( NULL );
 xFormulaBar->setPosition( 1.0 );
 }
+
 void FormulaBuffer::applyCellFormula( ScDocument& rDoc, const 
ApiTokenSequence& rTokens, const ::com::sun::star::table::CellAddress& rAddress 
)
 {
 ScTokenArray aTokenArray;
@@ -145,7 +145,8 @@ void FormulaBuffer::applyCellFormulaValues( const 
std::vector< ValueAddressPair
 ScAddress aCellPos;
 ScUnoConversion::FillScAddress( aCellPos, it->first );
 ScBaseCell* pBaseCell = rDoc.GetCell( aCellPos );
-if ( pBaseCell->GetCellType() == CELLTYPE_FORMULA )
+SAL_WARN_IF( !pBaseCell, "sc", "why is the formula not imported? 
bug?");
+if ( pBaseCell && pBaseCell->GetCellType() == CELLTYPE_FORMULA )
 {
 ScFormulaCell* pCell = static_cast< ScFormulaCell* >( pBaseCell );
 pCell->SetHybridDouble( it->second );
commit fcd85be5d5e44b00c6fa5717c7ec13ea657483d4
Author: Markus Mohrhard 
Date:   Fri Sep 28 01:21:41 2012 +0200

ooxml spec allow ext ref to non existent entry, fdo#54558

Change-Id: I717917d04a93975472d60248eb61066cd04d1bbe

diff --git a/sc/source/filter/oox/extlstcontext.cxx 
b/sc/source/filter/oox/extlstcontext.cxx
index c1949e8..78fd832 100644
--- a/sc/source/filter/oox/extlstcontext.cxx
+++ b/sc/source/filter/oox/extlstcontext.cxx
@@ -200,7 +200,13 @@ ContextHandlerRef ExtGlobalContext::onCreateContext( 
sal_Int32 nElement, const A
 if(nElement == XLS_EXT_TOKEN( cfRule ))
 {
 rtl::OUString aId = rAttribs.getString( XML_id, rtl::OUString() );
-void* pInfo = getExtLst().find( aId )->second;
+
+// an ext entrie does not need to have an existing corresponding 
entry
+ExtLst::const_iterator aExt = getExtLst().find( aId );
+if(aExt == getExtLst().end())
+return NULL;
+
+void* pInfo = aExt->second;
 if (!pInfo)
 {
 return NULL;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: need help with unit test and process service factory

[Matúš Kukan]

On 28 September 2012 01:03, Matúš Kukan  wrote:
> Also, it would be really great to have at least one linux tinderbox
> with --enable-telepathy.
> Only recent telepathy-glib is needed.

Ah, that's not true. It should be for building,
but I forgot that for unit test we need empathy with two jabber
accounts configured.
Is that too much for tinderbox ?

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

comment about using constructor and destructor in cppunit tests

[Markus Mohrhard]

Hey Matus,

I just saw that you started using the constructor and the destructor
in the tubes unit test. It would be a better idea to move this into
setUp and tearDown and check there with CPPUNIT_ASSERT that all
variables are set. In contrast to the constructor and the destructor
setUp and tearDown are protected inside the cppunit framework against
thrown exceptions. In general using the constructor and destructor in
a cppunit test should only be done for the few cases where it is
really necessary and setUp and tearDown are no alternative.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

need help with unit test and process service factory

[Matúš Kukan]

Hi,

I've tried --enable-telepathy again and found out that the unit test
does not work now.
After 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4917f0ceb2a7b1bb3ba878373f71f38d156278af
I am getting:
- Exception while getting config.ini url: null process service factory
It's from tubes/qa/test_manager.cxx :
utl::LocalFileHelper::ConvertPhysicalNameToURL

Maybe 
http://cgit.freedesktop.org/libreoffice/core/diff/unotools/source/ucbhelper/localfilehelper.cxx?id=9ac86f484b0c278aafbce685ed19d3ea005ee8f8
is responsible ?
What I need for using process service factory ?
I've tried to add +$(eval $(call gb_CppunitTest_use_ure,tubes_test))
but then I get:
terminate called after throwing an instance of
'com::sun::star::uno::DeploymentException'
Any thoughts ?

Also, it would be really great to have at least one linux tinderbox
with --enable-telepathy.
Only recent telepathy-glib is needed.

Thanks,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: LibreOffice Forums Categories Proposal

[Simos Xenitellis]

On Fri, Sep 28, 2012 at 12:44 AM, Marc Paré  wrote:
> Hi Anton,
>
> Le 2012-09-27 12:00, Anton Meixome a écrit :
>>
>> What about l10n?
>>
>> I see in wiki being jforum the selected software. I'm a bit confuse
>>
>> May be a fork between Jforum and CodeRanch? As I don't find the
>> translation framework in JForum
>>
>> Which version? Is important for NL teams
>>
>> is it?
>>
>> https://github.com/rafaelsteil/jforum3/blob/master/src/main/resources/jforumConfig/languages/en_US.properties
>> Or
>> http://jforum2.googlecode.com/svn-history/trunk/src/main/config/languages/en_US.properties
>>
>> Or anywhere here?
>>
>> https://github.com/rafaelsteil/jforum2
>>
>
> I have received this note from Christian Lohmaier:
>
> "This installation is based on the fork/maintenance version whose home is
> http://code.google.com/p/jforum2/ - with associated forum at
> http://jforum.andowson.com/";
>
> Christian will be in charge of all technical aspect of the forums as well as
> implementation.
>

At the moment http://jforum.andowson.com/ does not work. I suppose it
will be back soon.
I would like to try it out.

My concern with jforum2 is that it is different from other popular
forum packages such as phpbb or vbulletin (closed source).
Christian should make sure that he trains more admins into this forum software.

Whether a forum works or not, depends on the first few months. There
should be several volunteers that help out so that new users find
quality answers soon.

Some questions will be repeated, so the volunteers will try to write
them down in a HowTo post or a Wiki page. Do not count that there will
always be volunteers to answer the same question repeatedly. Does not
scale.
Something that we do at our local forum is have a HowTo section that
we add there good solutions to common problems, then pinpoint new
users to check there.
A good solution is needed here.

I highly recommend to get new users for the forum to accept a Code of
Conduct such as
http://fridge.ubuntu.com/2012/09/27/code-of-conduct-v2-request-for-feedback/
This will help the volunteers to deal with fights, etc.

In order to motivate users, some forum software have the facility to
say thanks to a good reply. Such a facility will be good to have.

Simos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: solenv/gbuild

[Libreoffice Gerrit user]

 solenv/gbuild/UnoApiTarget.mk |2 +-
 solenv/gbuild/gbuild.mk   |2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 72846a5c528cf66f01036978bf77eabc9f039025
Author: Matúš Kukan 
Date:   Fri Sep 28 00:39:43 2012 +0200

and also use new gb_UCPPTARGET; gb_UCPP unused

Change-Id: I8cd066e61cdfdef65385a2482f1a8f0aa1fb90cb

diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk
index a4c6e19..fd7a0a3 100644
--- a/solenv/gbuild/UnoApiTarget.mk
+++ b/solenv/gbuild/UnoApiTarget.mk
@@ -69,7 +69,7 @@ endef
 
 $(call gb_UnoApiPartTarget_get_target,%.done) : \
$(gb_UnoApiPartTarget_IDLCTARGET) \
-   | $(gb_UnoApiPartTarget_UCPPTARGET)
+   | $(gb_UCPPTARGET)
$(call gb_UnoApiPartTarget__command,$@,$*,$(filter-out 
$(gb_UnoApiPartTarget_IDLCTARGET),$?))
 
 ifeq ($(gb_FULLDEPS),$(true))
diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 2a51440..85f2956 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -405,10 +405,8 @@ gb_PYTHON := $(gb_PYTHON_PRECOMMAND) $(gb_PYTHONTARGET)
 endif
 
 ifneq (,$(SYSTEM_UCPP))
-gb_UCPP := $(SYSTEM_UCPP)
 gb_UCPPTARGET :=
 else
-gb_UCPP := ucpp
 gb_UCPPTARGET := $(call gb_Executable_get_target_for_build,ucpp)
 endif
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: LibreOffice Forums Categories Proposal

[Marc Paré]

Hi Anton,

Le 2012-09-27 12:00, Anton Meixome a écrit :

What about l10n?

I see in wiki being jforum the selected software. I'm a bit confuse

May be a fork between Jforum and CodeRanch? As I don't find the
translation framework in JForum

Which version? Is important for NL teams

is it?

https://github.com/rafaelsteil/jforum3/blob/master/src/main/resources/jforumConfig/languages/en_US.properties

Or

http://jforum2.googlecode.com/svn-history/trunk/src/main/config/languages/en_US.properties

Or anywhere here?

https://github.com/rafaelsteil/jforum2




--
Antón Méixome - Galician Native Lang Coordination
Galician community LibO & AOO





I have received this note from Christian Lohmaier:

"This installation is based on the fork/maintenance version whose home 
is http://code.google.com/p/jforum2/ - with associated forum at 
http://jforum.andowson.com/";


Christian will be in charge of all technical aspect of the forums as 
well as implementation.


Cheers,

Marc


--
Marc Paré
m...@marcpare.com
http://www.parEntreprise.com
parEntreprise.com Supports OpenDocument Formats (ODF)
parEntreprise.com Supports http://www.LibreOffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED-3-6] fix for fdo#55022, crash when opening the test file in ScDBQueryDataIterator

[Markus Mohrhard]

Hey Michael,

2012/9/27 Michael Meeks :
> Hi Markus,
>
> On Thu, 2012-09-27 at 00:34 +0200, Markus Mohrhard wrote:
>> [1] fixes a crash when opening the test file. The problem is that we
>> dereference a past the end element. The code was always wrong but we
>> fixed another bug in this part of the code for 3-6 so that it now
>> crashes.
>
> Amusing :-)
>
>> [1] 
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=70412d0f3f7979d3d069be8121d49dbb96775cce
>
> Seems reasonable, but would:
>
> @@ -564,7 +564,7 @@ bool 
> ScDBQueryDataIterator::DataAccessInternal::getCurrent(Value& rValue)
>  return false;
>
>  SCROW nThisRow = 
> ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, nTab, nCol, nColRow);
> -while ( (nColRow < nCellCount) && (nThisRow < nRow) )
> +while ( (nColRow < nCellCount - 1) && (nThisRow < nRow) )
>  nThisRow = ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, 
> nTab, nCol, ++nColRow);
>
>  if ( nColRow < nCellCount && nThisRow <= mpParam->nRow2 )
>
> Not have the same effect ? either way I cherry-picked as-is to -3-6.
>

No this one results in a infinite loop because the check nColRow <
nCellCount in the next if will be always true when it was not before.
My patch still increments so that the check there is false and we stop
iterating through the DB range.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: solenv/bin

[Libreoffice Gerrit user]

 solenv/bin/modules/installer.pm  |3 +--
 solenv/bin/modules/installer/archivefiles.pm |5 ++---
 solenv/bin/modules/installer/environment.pm  |3 +--
 solenv/bin/modules/installer/profiles.pm |3 +--
 4 files changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 39157dfbcb96d3df7a90c1819d0f5492a1c05d6b
Author: Tim Retout 
Date:   Thu Sep 27 22:02:19 2012 +0100

installer: Replace various uses of exit_program with die

Change-Id: I1b16de6b01e34afb19bc394f33f16eef08b1703e

diff --git a/solenv/bin/modules/installer.pm b/solenv/bin/modules/installer.pm
index 2c1f855..54b64b0 100644
--- a/solenv/bin/modules/installer.pm
+++ b/solenv/bin/modules/installer.pm
@@ -40,7 +40,6 @@ use installer::copyproject;
 use installer::download;
 use installer::environment;
 use installer::epmfile;
-use installer::exiter;
 use installer::files;
 use installer::globals;
 use installer::helppack;
@@ -273,7 +272,7 @@ sub run {
 my $includepathref = 
installer::ziplist::getinfofromziplist($allsettingsarrayref, "include");
 if ( $$includepathref eq "" )
 {
-installer::exiter::exit_program("ERROR: Definition for \"include\" not 
found in $installer::globals::ziplistname", "Main");
+die 'Definition for "include" not found in ' . 
$installer::globals::ziplistname;
 }
 
 my $includepatharrayref = 
installer::converter::convert_stringlist_into_array($includepathref, ",");
diff --git a/solenv/bin/modules/installer/archivefiles.pm 
b/solenv/bin/modules/installer/archivefiles.pm
index 066aed0..6862c6f 100644
--- a/solenv/bin/modules/installer/archivefiles.pm
+++ b/solenv/bin/modules/installer/archivefiles.pm
@@ -28,7 +28,6 @@
 package installer::archivefiles;
 
 use Archive::Zip qw( :ERROR_CODES :CONSTANTS );
-use installer::exiter;
 use installer::files;
 use installer::globals;
 use installer::logger;
@@ -277,7 +276,7 @@ sub resolving_archive_flag
 {
 if ( $installer::globals::dounzip ) # really unpacking 
the files
 {
-if ( $zip->extractTree("", $unzipdir) != AZ_OK ) { 
installer::exiter::exit_program("ERROR: $infoline", "resolving_archive_flag"); }
+if ( $zip->extractTree("", $unzipdir) != AZ_OK ) { die 
"Could not unzip: $!"; }
 
 if (( $^O =~ /cygwin/i ) && ( $contains_dll ))
 {
@@ -533,7 +532,7 @@ sub resolving_archive_flag
 
 if ( $maxcounter == 5 ) # exiting the program
 {
-installer::exiter::exit_program("ERROR: Failed to 
unzip $sourcepath !", "resolving_archive_flag");
+die "Failed to unzip $sourcepath !";
 }
 }
 else
diff --git a/solenv/bin/modules/installer/environment.pm 
b/solenv/bin/modules/installer/environment.pm
index b0c541b..a0cf5f3 100644
--- a/solenv/bin/modules/installer/environment.pm
+++ b/solenv/bin/modules/installer/environment.pm
@@ -27,7 +27,6 @@
 
 package installer::environment;
 
-use installer::exiter;
 use installer::globals;
 
 ##
@@ -94,7 +93,7 @@ sub check_tilde_in_directory
 # exit, because "~" is not allowed, if HOME is not set
 my $infoline = "ERROR: If \"~\" is used in \"LOCALINSTALLDIR\", 
environment variable \"HOME\" needs to be defined!\n";
 push(@installer::globals::logfileinfo, $infoline);
-installer::exiter::exit_program("ERROR: If \"~\" is used in 
\"LOCALINSTALLDIR\", environment variable \"HOME\" needs to be defined!", 
"check_tilde_in_directory");
+die 'If "~" is used in "LOCALINSTALLDIR", environment variable "HOME" 
needs to be defined!';
 }
 }
 
diff --git a/solenv/bin/modules/installer/profiles.pm 
b/solenv/bin/modules/installer/profiles.pm
index ef0ce7d..7b621f7 100644
--- a/solenv/bin/modules/installer/profiles.pm
+++ b/solenv/bin/modules/installer/profiles.pm
@@ -28,7 +28,6 @@
 package installer::profiles;
 
 use installer::converter;
-use installer::exiter;
 use installer::files;
 use installer::globals;
 use installer::logger;
@@ -98,7 +97,7 @@ sub add_profile_into_filelist
 if ( $allvariables->{'GLOBALFILEGID'} ) { $vclgid = 
$allvariables->{'GLOBALFILEGID'}; }
 my ($vclfile) = grep {$_->{gid} eq $vclgid} @{$filesarrayref};
 if (! defined $vclfile) {
-installer::exiter::exit_program("ERROR: Could not find file $vclgid in 
list of files!", "add_profile_into_filelist");
+die "Could not find file $vclgid in list of files!";
 }
 
 # copying all base data
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 4 commits - bridges/Library_gcc3_macosx_x86-64.mk bridges/source lingucomponent/source postprocess/packcomponents scp2/InstallModule_ooo.mk scp2/source

[Libreoffice Gerrit user]

 bridges/Library_gcc3_macosx_x86-64.mk   |5 
 bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx  |   73 
 bridges/source/cpp_uno/gcc3_macosx_x86-64/call.s|   79 -
 bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno.cxx   |2 
 bridges/source/cpp_uno/gcc3_macosx_x86-64/share.hxx |  105 +---
 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm |2 
 postprocess/packcomponents/makefile.mk  |5 
 scp2/InstallModule_ooo.mk   |3 
 scp2/source/ooo/file_library_ooo.scp|2 
 9 files changed, 168 insertions(+), 108 deletions(-)

New commits:
commit 05f1bf896661cf0127ca9bd9ea282d46b724db75
Author: Tor Lillqvist 
Date:   Thu Sep 27 23:51:50 2012 +0300

No 64-bit QuickTime

Change-Id: Ie287d12c2142342fb89650bf715a2e12edabff78

diff --git a/scp2/InstallModule_ooo.mk b/scp2/InstallModule_ooo.mk
index 5ca6b6c..459cbf6 100644
--- a/scp2/InstallModule_ooo.mk
+++ b/scp2/InstallModule_ooo.mk
@@ -166,6 +166,9 @@ $(eval $(call gb_InstallModule_add_defs,scp2/ooo,\
$(if $(filter-out YES,$(WITH_MYSPELL_DICTS)),\
-DWITHOUT_MYSPELL_DICTS \
) \
+   $(if $(BITNESS_OVERRIDE),\
+   -DBITNESS_OVERRIDE=$(BITNESS_OVERRIDE) \
+   ) \
 ))
 
 ifeq ($(DISABLE_PYTHON),TRUE)
diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 13579ef..828c476 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -528,6 +528,7 @@ File gid_File_Lib_MacOSXSpell
Dir = SCP2_OOO_BIN_DIR;
 End
 
+#if !defined(BITNESS_OVERRIDE) || BITNESS_OVERRIDE==32
 File gid_File_Lib_avmediaQuickTime
LIB_FILE_BODY;
Styles = (PACKED);
@@ -535,6 +536,7 @@ File gid_File_Lib_avmediaQuickTime
Dir = SCP2_OOO_BIN_DIR;
 End
 #endif
+#endif
 
 #ifdef WNT
 SPECIAL_COMPONENT_LIB_FILE( gid_File_Lib_Fps_ODMA, fps_odma.uno )
commit b3888e74956bcfe027e9903ff34e10d95b2bebb3
Author: Tor Lillqvist 
Date:   Thu Sep 27 23:03:47 2012 +0300

No 64-bit QuickTime

Change-Id: I07eed5c66195b006ae96da9c71a1ef57b8e2d020

diff --git a/postprocess/packcomponents/makefile.mk 
b/postprocess/packcomponents/makefile.mk
index 8111a10..998a13f 100644
--- a/postprocess/packcomponents/makefile.mk
+++ b/postprocess/packcomponents/makefile.mk
@@ -328,8 +328,11 @@ my_components += \
 .END
 
 .IF "$(GUIBASE)" == "aqua"
+.IF "$(BITNESS_OVERRIDE)" != "64"
+my_components += \
+component/avmedia/source/quicktime/avmediaQuickTime
+.ENDIF
 my_components += \
-component/avmedia/source/quicktime/avmediaQuickTime \
 component/lingucomponent/source/spellcheck/macosxspell/MacOSXSpell
 .END
 
commit 9f5227d66bfca9dd2ffc338f68001ad6ba3b485d
Author: Tor Lillqvist 
Date:   Thu Sep 27 22:27:49 2012 +0300

Make exceptions work better in the x86-64 MacOSX C++-UNO bridge

Putting the privateSnippetExecutor() assembly code as inline asm
inside an otherwise empty C++ function helps, for some reason.

Use the actual _Unwnd_Exception and __cxa_exception definitions as
used by Apple (from opensource.apple.com libunwind and libcppabi
sources) instead of guessing.

Change-Id: I1ef22a9c0c664d3a357b9a6474406141f53cc490

diff --git a/bridges/Library_gcc3_macosx_x86-64.mk 
b/bridges/Library_gcc3_macosx_x86-64.mk
index b7b69c4..309d672 100644
--- a/bridges/Library_gcc3_macosx_x86-64.mk
+++ b/bridges/Library_gcc3_macosx_x86-64.mk
@@ -46,12 +46,9 @@ $(eval $(call gb_Library_use_libraries,gcc3_uno,\
sal \
 ))
 
-$(eval $(call gb_Library_add_asmobjects,gcc3_uno,\
-   bridges/source/cpp_uno/gcc3_macosx_x86-64/call \
-))
-
 $(eval $(call gb_Library_add_exception_objects,gcc3_uno,\
bridges/source/cpp_uno/gcc3_macosx_x86-64/abi \
+   bridges/source/cpp_uno/gcc3_macosx_x86-64/call \
bridges/source/cpp_uno/gcc3_macosx_x86-64/callvirtualmethod \
bridges/source/cpp_uno/gcc3_macosx_x86-64/cpp2uno \
bridges/source/cpp_uno/gcc3_macosx_x86-64/except \
diff --git a/bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx
new file mode 100644
index 000..96834da
--- /dev/null
+++ b/bridges/source/cpp_uno/gcc3_macosx_x86-64/call.cxx
@@ -0,0 +1,73 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information reg

[Libreoffice-commits] .: 3 commits - config_host.mk.in configure.in idlc/Executable_idlc.mk idlc/prj idlc/source Module_cross_tail_build.mk Module_tail_build.mk odk/pack odk/util Repository.mk solenv/

[Libreoffice Gerrit user]

 Module_cross_tail_build.mk|4 +++-
 Module_tail_build.mk  |4 +++-
 Repository.mk |4 +++-
 config_host.mk.in |1 +
 configure.in  |   32 
 idlc/Executable_idlc.mk   |7 +++
 idlc/prj/build.lst|2 +-
 idlc/source/idlccompile.cxx   |5 -
 odk/pack/copying/makefile.mk  |6 +-
 odk/util/check.pl |5 -
 solenv/gbuild/UnoApiTarget.mk |1 -
 solenv/gbuild/gbuild.mk   |8 
 12 files changed, 71 insertions(+), 8 deletions(-)

New commits:
commit 97e7f62481d8d3b6653f292c5069df133c684f3e
Author: Rene Engelhard 
Date:   Thu Sep 27 21:23:03 2012 +0200

move ucpp definitions into gbuild.mk (as e.g.xsltproc)

Change-Id: Ib59ca9ac4d88db6e009c656e31ee866f4d9818e9

diff --git a/solenv/gbuild/UnoApiTarget.mk b/solenv/gbuild/UnoApiTarget.mk
index 7e2ea13..a4c6e19 100644
--- a/solenv/gbuild/UnoApiTarget.mk
+++ b/solenv/gbuild/UnoApiTarget.mk
@@ -30,9 +30,6 @@
 
 gb_UnoApiPartTarget_IDLCTARGET := $(call 
gb_Executable_get_target_for_build,idlc)
 gb_UnoApiPartTarget_IDLCCOMMAND := $(gb_Helper_set_ld_path) 
SOLARBINDIR=$(OUTDIR_FOR_BUILD)/bin $(gb_UnoApiPartTarget_IDLCTARGET)
-ifeq (,$(SYSTEM_UCPP))
-gb_UnoApiPartTarget_UCPPTARGET := $(call 
gb_Executable_get_target_for_build,ucpp)
-endif
 
 # The .urd files are actually created by the gb_UnoApiPartTarget__command,
 # invoked for the per-directory .done files.
diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index ee2f985..2a51440 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -404,6 +404,14 @@ gb_PYTHONTARGET := $(call 
gb_Executable_get_target_for_build,python)
 gb_PYTHON := $(gb_PYTHON_PRECOMMAND) $(gb_PYTHONTARGET)
 endif
 
+ifneq (,$(SYSTEM_UCPP))
+gb_UCPP := $(SYSTEM_UCPP)
+gb_UCPPTARGET :=
+else
+gb_UCPP := ucpp
+gb_UCPPTARGET := $(call gb_Executable_get_target_for_build,ucpp)
+endif
+
 .PHONY: help
 help:
@cat $(SRCDIR)/solenv/gbuild/gbuild.help.txt
commit 7b9fb8f6736248f1c218ef1667eae6523487368d
Author: Rene Engelhard 
Date:   Thu Sep 27 20:49:25 2012 +0200

add --with-idlc-cpp to allow  use of "normal" cpp

Change-Id: Ib32bb0b3e9cf4ce6aeb60a417a2f07d72facf41d

diff --git a/configure.in b/configure.in
index 09fb9cb..17b13c6 100644
--- a/configure.in
+++ b/configure.in
@@ -2078,6 +2078,16 @@ AC_ARG_WITH(mingw-cross-compiler,
 ],
 ,)
 
+AC_ARG_WITH(idlc-cpp,
+AS_HELP_STRING([--with-idlc-cpp],
+[Specify the C Preprocessor to use for idlc.])
+[
+  Usage: --with-idlc-cpp=cpp
+
+  Default is ucpp.
+]
+,)
+
 AC_ARG_WITH(build-version,
 AS_HELP_STRING([--with-build-version],
 [Allows the builder to add a custom version tag that will appear in the
@@ -6318,13 +6328,20 @@ else
 fi
 AC_SUBST(BUILD_DMAKE)
 
-AC_MSG_CHECKING([which ucpp tp use])
-if test -n "$with_system_ucpp" -a "$with_system_ucpp" != "no"; then
-AC_MSG_RESULT([external])
-AC_PATH_PROG(SYSTEM_UCPP, ucpp)
+AC_MSG_CHECKING([which C preprocessor to use in idlc])
+if test -n "$with_idlc_cpp"; then
+AC_MSG_RESULT([$with_idlc_cpp])
+AC_PATH_PROG(SYSTEM_UCPP, $with_idlc_cpp)
 else
-AC_MSG_RESULT([internal])
-BUILD_TYPE="$BUILD_TYPE UCPP"
+AC_MSG_RESULT([ucpp])
+AC_MSG_CHECKING([which ucpp tp use])
+if test -n "$with_system_ucpp" -a "$with_system_ucpp" != "no"; then
+AC_MSG_RESULT([external])
+AC_PATH_PROG(SYSTEM_UCPP, ucpp)
+else
+AC_MSG_RESULT([internal])
+BUILD_TYPE="$BUILD_TYPE UCPP"
+fi
 fi
 AC_SUBST(SYSTEM_UCPP)
 
commit c0fb5ed758c9ed8c1bb6b8344592c4781f475443
Author: Rene Engelhard 
Date:   Thu Sep 27 19:51:33 2012 +0200

add --with-system-ucpp

Change-Id: Ic322d1be23033049fa3b5cd60c00479bb6cae3ca

diff --git a/Module_cross_tail_build.mk b/Module_cross_tail_build.mk
index 61b5145..e15848b 100644
--- a/Module_cross_tail_build.mk
+++ b/Module_cross_tail_build.mk
@@ -84,7 +84,9 @@ $(eval $(call gb_Module_add_moduledirs,cross_tail_build,\
translations \
) \
ucbhelper \
-   ucpp \
+   $(if $(filter UCPP,$(BUILD_TYPE)),\
+   ucpp \
+   ) \
udkapi \
udm \
unoil \
diff --git a/Module_tail_build.mk b/Module_tail_build.mk
index 8e5c1c1..3155b7b 100644
--- a/Module_tail_build.mk
+++ b/Module_tail_build.mk
@@ -187,7 +187,9 @@ $(eval $(call gb_Module_add_moduledirs,tail_end,\
 twain \
 ucb \
ucbhelper \
-   ucpp \
+   $(if $(filter UCPP,$(BUILD_TYPE)),\
+   ucpp \
+   ) \
udkapi \
udm \
 unixODBC \
diff --git a/Repository.mk b/Repository.mk
index 79f2004..68ddbfc 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -62,7 +62,9 @@ $(eval $(call gb_Helper_register_executables,NONE, \
 svidl \
 transex3 \
 typesconfig \
-ucpp \
+$(if $(filter UCPP,$(BUILD_TYPE))

[Libreoffice-commits] .: 2 commits - tubes/qa

[Libreoffice Gerrit user]

 tubes/qa/test_manager.cxx |   44 +++-
 1 file changed, 19 insertions(+), 25 deletions(-)

New commits:
commit 4e6907b5d526241c93767fd25d8c2866c034a8d8
Author: Matúš Kukan 
Date:   Thu Sep 27 22:24:51 2012 +0200

tubes: let's use ctor, dtor and less methods in the test

They are not independent anyway.
This way it may fail only once in constructor and avoid segmentation
faults.

Change-Id: I304f688b187f9870bf664517112550ad9a2a87c7

diff --git a/tubes/qa/test_manager.cxx b/tubes/qa/test_manager.cxx
index 2ccbe32..6296eb3 100644
--- a/tubes/qa/test_manager.cxx
+++ b/tubes/qa/test_manager.cxx
@@ -49,25 +49,17 @@ class TestTeleTubes: public CppUnit::TestFixture
 {
 public:
 
-TestTeleTubes() {}
-~TestTeleTubes() {}
+TestTeleTubes();
+~TestTeleTubes();
 // This could happen in costructor wasn't there TestTeleTubes instance for 
each test:
-void testInitialize();
-void testInitTeleManager();
 void testContactList();
-void testStartBuddySession();
-void testSendPacket();
-void testDestroyTeleTubes();
+void testSession();
 void testFailAlways();
 
 // Order is significant.
 CPPUNIT_TEST_SUITE( TestTeleTubes );
-CPPUNIT_TEST( testInitialize );
-CPPUNIT_TEST( testInitTeleManager );
 CPPUNIT_TEST( testContactList );
-CPPUNIT_TEST( testStartBuddySession );
-CPPUNIT_TEST( testSendPacket );
-CPPUNIT_TEST( testDestroyTeleTubes );
+CPPUNIT_TEST( testSession );
 #if 0
 CPPUNIT_TEST( testFailAlways ); // test failure displays SAL_LOG, 
uncomment for debugging
 #endif
@@ -105,7 +97,7 @@ static gboolean timed_out( void * )
 return FALSE;
 }
 
-void TestTeleTubes::testInitialize()
+TestTeleTubes::TestTeleTubes()
 {
 g_timeout_add_seconds (10, timed_out, NULL);
 try
@@ -135,10 +127,7 @@ void TestTeleTubes::testInitialize()
 
 mpCollaboration1 = new TestCollaboration();
 mpCollaboration2 = new TestCollaboration();
-}
 
-void TestTeleTubes::testInitTeleManager()
-{
 CPPUNIT_ASSERT( TeleManager::init( true));
 }
 
@@ -189,7 +178,7 @@ static void lcl_FileSent( bool success, void * )
 }
 */
 
-void TestTeleTubes::testStartBuddySession()
+void TestTeleTubes::testSession()
 {
 TeleConference* pConference = NULL;
 CPPUNIT_ASSERT( mpOffererAccount != 0);
@@ -209,17 +198,14 @@ void TestTeleTubes::testStartBuddySession()
 pConference = TeleManager::getConference();
 CPPUNIT_ASSERT( pConference != NULL);
 mpCollaboration2->SetConference( pConference );
-}
 
-void TestTeleTubes::testSendPacket()
-{
 mpCollaboration1->SendPacket( "from 1 to 2");
 
 while (!mbPacketReceived)
 g_main_context_iteration( NULL, TRUE);
 }
 
-void TestTeleTubes::testDestroyTeleTubes()
+TestTeleTubes::~TestTeleTubes()
 {
 if (mpOffererAccount) {
 g_object_unref(mpOffererAccount);
commit 4917f0ceb2a7b1bb3ba878373f71f38d156278af
Author: Matúš Kukan 
Date:   Thu Sep 27 22:07:53 2012 +0200

tubes: catch exception to get more info

Also add timeout as a first thing to not loop forever if something else
goes wrong.

Change-Id: I3c752f74bfd32c1a0a6d1ce85408271a530fb379

diff --git a/tubes/qa/test_manager.cxx b/tubes/qa/test_manager.cxx
index 545947d..2ccbe32 100644
--- a/tubes/qa/test_manager.cxx
+++ b/tubes/qa/test_manager.cxx
@@ -107,9 +107,18 @@ static gboolean timed_out( void * )
 
 void TestTeleTubes::testInitialize()
 {
-utl::LocalFileHelper::ConvertPhysicalNameToURL(
-OUString::createFromAscii( getenv("SRCDIR") ) + 
"/tubes/qa/test-config.ini",
-maTestConfigIniURL );
+g_timeout_add_seconds (10, timed_out, NULL);
+try
+{
+utl::LocalFileHelper::ConvertPhysicalNameToURL(
+OUString::createFromAscii( getenv("SRCDIR") ) + 
"/tubes/qa/test-config.ini",
+maTestConfigIniURL );
+}
+catch (const com::sun::star::uno::Exception& e)
+{
+CPPUNIT_ASSERT_MESSAGE( OUStringToOString( "Exception while getting 
config.ini url: "
++ e.Message, RTL_TEXTENCODING_UTF8).getStr(), false);
+}
 rtl::Bootstrap aTestConfig( maTestConfigIniURL );
 
 TeleManager::addSuffixToNames( "TeleTest");
@@ -124,7 +133,6 @@ void TestTeleTubes::testInitialize()
 aTestConfig.getFrom("accepter", aAccepterIdentifier));
 maAccepterIdentifier = OUStringToOString( aAccepterIdentifier, 
RTL_TEXTENCODING_UTF8);
 
-g_timeout_add_seconds (10, timed_out, NULL);
 mpCollaboration1 = new TestCollaboration();
 mpCollaboration2 = new TestCollaboration();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: oox/inc oox/source unusedcode.easy

[Libreoffice Gerrit user]

 oox/inc/oox/ole/axcontrol.hxx  |7 ---
 oox/inc/oox/ole/vbacontrol.hxx |2 --
 oox/inc/oox/ole/vbamodule.hxx  |2 --
 oox/source/ole/axcontrol.cxx   |   10 --
 oox/source/ole/vbacontrol.cxx  |5 -
 oox/source/ole/vbamodule.cxx   |   26 --
 unusedcode.easy|4 
 7 files changed, 56 deletions(-)

New commits:
commit c563ca3843387a2cc5a7a667856154ae2f13985b
Author: Julien Nabet 
Date:   Thu Sep 27 22:02:40 2012 +0200

Bin some newly unused methods

Change-Id: I1bbbdbb68f073d19b7d99b5ccb4985efd5bde80c

diff --git a/oox/inc/oox/ole/axcontrol.hxx b/oox/inc/oox/ole/axcontrol.hxx
index 285cb74..30187a4 100644
--- a/oox/inc/oox/ole/axcontrol.hxx
+++ b/oox/inc/oox/ole/axcontrol.hxx
@@ -812,9 +812,6 @@ public:
 virtual ApiControlType getControlType() const;
 virtual voidconvertProperties( PropertyMap& rPropMap, const 
ControlConverter& rConv ) const;
 
-/** Returns the caption with the specified zero-based index. */
-::rtl::OUString getCaption( sal_Int32 nIndex ) const;
-
 private:
 AxStringArray   maCaptions; ///< Captions of all tabs.
 sal_uInt32  mnBackColor;///< Fill color.
@@ -906,10 +903,6 @@ public:
 virtual ApiControlType getControlType() const;
 virtual voidconvertProperties( PropertyMap& rPropMap, const 
ControlConverter& rConv ) const;
 
-/** Sets the tabstrip control model related to this multipage control.
-Contains all formatting attributes of the page tabs. */
-voidsetTabStripModel( const AxTabStripModelRef& rxTabStrip 
);
-
 private:
 AxTabStripModelRef  mxTabStrip;
 };
diff --git a/oox/inc/oox/ole/vbacontrol.hxx b/oox/inc/oox/ole/vbacontrol.hxx
index 8c56ac6..9edd454 100644
--- a/oox/inc/oox/ole/vbacontrol.hxx
+++ b/oox/inc/oox/ole/vbacontrol.hxx
@@ -123,8 +123,6 @@ public:
 
 /** Returns the programmatical name of the control. */
 ::rtl::OUString getControlName() const;
-/** Returns the unique identifier of this control. */
-sal_Int32   getControlId() const;
 
 /** Creates the UNO control model, inserts it into the passed container,
 and converts all control properties. */
diff --git a/oox/inc/oox/ole/vbamodule.hxx b/oox/inc/oox/ole/vbamodule.hxx
index 65cd41a..91f5b62 100644
--- a/oox/inc/oox/ole/vbamodule.hxx
+++ b/oox/inc/oox/ole/vbamodule.hxx
@@ -74,8 +74,6 @@ public:
 const ::com::sun::star::uno::Reference< 
::com::sun::star::container::XNameAccess >& rxDocObjectNA ) const;
 
 private:
-void extractOleOverrideFromAttr( const rtl::OUString& rAttribute,
- const ::com::sun::star::uno::Reference< 
::com::sun::star::container::XNameContainer >& rxOleNameOverrides ) const;
 /** Reads and returns the VBA source code from the passed storage. */
 ::rtl::OUString readSourceCode( StorageBase& rVbaStrg ) const;
 
diff --git a/oox/source/ole/axcontrol.cxx b/oox/source/ole/axcontrol.cxx
index 0190f7f..8592ba6 100644
--- a/oox/source/ole/axcontrol.cxx
+++ b/oox/source/ole/axcontrol.cxx
@@ -2319,11 +2319,6 @@ void AxTabStripModel::convertProperties( PropertyMap& 
rPropMap, const ControlCon
 AxFontDataModel::convertProperties( rPropMap, rConv );
 }
 
-OUString AxTabStripModel::getCaption( sal_Int32 nIndex ) const
-{
-return ContainerHelper::getVectorElement( maCaptions, nIndex, OUString() );
-}
-
 // 
 
 AxContainerModelBase::AxContainerModelBase( bool bFontSupport ) :
@@ -2489,11 +2484,6 @@ void AxMultiPageModel::convertProperties( PropertyMap& 
rPropMap, const ControlCo
 AxContainerModelBase::convertProperties( rPropMap, rConv );
 }
 
-void AxMultiPageModel::setTabStripModel( const AxTabStripModelRef& rxTabStrip )
-{
-mxTabStrip = rxTabStrip;
-}
-
 // 
 
 AxUserFormModel::AxUserFormModel()
diff --git a/oox/source/ole/vbacontrol.cxx b/oox/source/ole/vbacontrol.cxx
index 8f68491..91474c6 100644
--- a/oox/source/ole/vbacontrol.cxx
+++ b/oox/source/ole/vbacontrol.cxx
@@ -363,11 +363,6 @@ OUString VbaFormControl::getControlName() const
 return mxSiteModel.get() ? mxSiteModel->getName() : OUString();
 }
 
-sal_Int32 VbaFormControl::getControlId() const
-{
-return mxSiteModel.get() ? mxSiteModel->getId() : -1;
-}
-
 void VbaFormControl::createAndConvert( sal_Int32 nCtrlIndex,
 const Reference< XNameContainer >& rxParentNC, const ControlConverter& 
rConv ) const
 {
diff --git a/oox/source/ole/vbamodule.cxx b/oox/source/ole/vbamodule.cxx
index 0766f97..1a404de 100644
--- a/oox/source/ole/vbamodule.cxx
+++ b/oox/source/ole/vbamodule.cxx
@@ -327,32 +327,6 @@ OUString VbaModule::readSourceCode( StorageBase& rVbaStrg 
) const
 return aSourceCode.makeStringAndClear();
 }
 
-void VbaModule::extractOleOverrideFromAttr( cons

[Libreoffice-commits] .: wizards/com

[Libreoffice Gerrit user]

 wizards/com/sun/star/wizards/common/TextElement.py   |   41 +++
 wizards/com/sun/star/wizards/fax/CallWizard.py   |1 
 wizards/com/sun/star/wizards/fax/FaxDocument.py  |9 +-
 wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py  |   34 -
 wizards/com/sun/star/wizards/fax/FaxWizardDialogResources.py |   31 +++-
 5 files changed, 106 insertions(+), 10 deletions(-)

New commits:
commit 74e4137cf89d3e1e8b73853702636e3ff70a3b4e
Author: Xisco Fauli 
Date:   Thu Sep 27 22:12:21 2012 +0200

pyfax: Translate the template at run-time

Change-Id: Ied94eaeb33dcfab582ac1d4702b736cf81c5d7ca

diff --git a/wizards/com/sun/star/wizards/common/TextElement.py 
b/wizards/com/sun/star/wizards/common/TextElement.py
new file mode 100644
index 000..f035808
--- /dev/null
+++ b/wizards/com/sun/star/wizards/common/TextElement.py
@@ -0,0 +1,41 @@
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+# This file incorporates work covered by the following license notice:
+#
+#   Licensed to the Apache Software Foundation (ASF) under one or more
+#   contributor license agreements. See the NOTICE file distributed
+#   with this work for additional information regarding copyright
+#   ownership. The ASF licenses this file to you under the Apache
+#   License, Version 2.0 (the "License"); you may not use this file
+#   except in compliance with the License. You may obtain a copy of
+#   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+#
+import traceback
+from .Helper import Helper
+from com.sun.star.text.PlaceholderType import TEXT
+
+class TextElement(object):
+
+def __init__(self, item, placeHolderText, hint, xmsf):
+self.item = item
+self.placeHolderText = placeHolderText
+self.xmsf = xmsf
+self.paraStyle = Helper.getUnoPropertyValue(
+item.Start, "ParaStyleName")
+
+def write(self):
+try:
+if self.item is not None:
+self.item.String = ""
+cursor = self.item.Text.createTextCursorByRange(
+self.item.Start)
+cursor.String = self.placeHolderText
+Helper.setUnoPropertyValue(
+cursor, "ParaStyleName", self.paraStyle)
+except Exception, e:
+traceback.print_exc()
diff --git a/wizards/com/sun/star/wizards/fax/CallWizard.py 
b/wizards/com/sun/star/wizards/fax/CallWizard.py
index 427a703..8ef1d24 100644
--- a/wizards/com/sun/star/wizards/fax/CallWizard.py
+++ b/wizards/com/sun/star/wizards/fax/CallWizard.py
@@ -30,7 +30,6 @@ class CallWizard(unohelper.Base, XJobExecutor):
self.ctx = ctx
 
def trigger(self, args):
-   print "hello"
try:
fw = FaxWizardDialogImpl(self.ctx.ServiceManager)
fw.startWizard(self.ctx.ServiceManager)
diff --git a/wizards/com/sun/star/wizards/fax/FaxDocument.py 
b/wizards/com/sun/star/wizards/fax/FaxDocument.py
index 95072de..f86a3f5 100644
--- a/wizards/com/sun/star/wizards/fax/FaxDocument.py
+++ b/wizards/com/sun/star/wizards/fax/FaxDocument.py
@@ -15,9 +15,9 @@
 #   except in compliance with the License. You may obtain a copy of
 #   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 #
-
-from ..text.TextDocument import TextDocument, traceback, Helper,\
-   TextFieldHandler, Configuration
+from ..text.TextDocument import *
+#TextDocument, traceback, Helper,\
+#TextFieldHandler, Configuration
 from ..text.TextSectionHandler import TextSectionHandler
 from ..common.PropertyNames import PropertyNames
 
@@ -51,8 +51,8 @@ class FaxDocument(TextDocument):
 
 def switchFooter(self, sPageStyle, bState, bPageNumber, sText):
 if TextDocument.xTextDocument is not None:
-TextDocument.xTextDocument.lockControllers()
 try:
+TextDocument.xTextDocument.lockControllers()
 xPageStyleCollection = \
 
TextDocument.xTextDocument.StyleFamilies.getByName("PageStyles")
 xPageStyle = xPageStyleCollection.getByName(sPageStyle)
@@ -84,6 +84,7 @@ class FaxDocument(TextDocument):
 
 TextDocument.xTextDocument.unlockControllers()
 except Exception:
+TextDocument.xTextDocument.lockControllers()
 traceback.print_exc()
 
 def hasElement(self, sElement):
diff --git a/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py 
b/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py
index e008aeb..249c249 100644
--- a/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py
+++ b/wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py
@@ -32,6 +32,7 @@ from ..common.NoValidPathExcep

[Libreoffice-commits] .: bridges/source

[Libreoffice Gerrit user]

 bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e66cce3a146023fe3509217d32223ba162150b7
Author: Tor Lillqvist 
Date:   Thu Sep 27 14:11:27 2012 +0300

WaE: format specifiers in debug output

Change-Id: Ifab851a1294f2e09f31bec9ca517ef6f62b73550

diff --git a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx 
b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
index c12c26c..e171203 100644
--- a/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_macosx_intel/cpp2uno.cxx
@@ -438,7 +438,7 @@ unsigned char * codeSnippet(
 OSL_ASSERT(p - code <= codeSnippetSize);
 #if OSL_DEBUG_LEVEL > 1
 fprintf(stderr,
-"==> codeSnippet to %s, functionIndex=%d%s, vtableOffset=%d\n",
+"==> codeSnippet to %s, functionIndex=%lu%s, 
vtableOffset=%"SAL_PRIdINT32"\n",
 (exec == privateSnippetExecutorGeneral ? "General" :
  (exec == privateSnippetExecutorVoid ? "Void" :
   (exec == privateSnippetExecutorHyper ? "Hyper" :
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - solenv/bin

[Libreoffice Gerrit user]

 solenv/bin/modules/installer/epmfile.pm   |   46 ++
 solenv/bin/modules/installer/systemactions.pm |   25 ++
 solenv/bin/modules/installer/worker.pm|   31 +
 3 files changed, 39 insertions(+), 63 deletions(-)

New commits:
commit 0ab561bffadad1eab9eb98c05106f4c0132ccb36
Author: Tim Retout 
Date:   Thu Sep 27 19:22:32 2012 +0100

installer: Move two copies of make_systemcall into systemactions.pm

Change-Id: I526fae59d28e75d27259867e3fc7e7c99be0d437

diff --git a/solenv/bin/modules/installer/epmfile.pm 
b/solenv/bin/modules/installer/epmfile.pm
index 58bca0b..157e83d 100644
--- a/solenv/bin/modules/installer/epmfile.pm
+++ b/solenv/bin/modules/installer/epmfile.pm
@@ -2227,7 +2227,7 @@ sub create_packages_without_epm
 my $pkginfoorig = "$destinationdir/$packagename/pkginfo";
 my $pkginfotmp = "$destinationdir/$packagename" . 
".pkginfo.tmp";
 $systemcall = "cp -p $pkginfoorig $pkginfotmp";
- make_systemcall($systemcall);
+installer::systemactions::make_systemcall($systemcall);
 
 $faspac = $$compressorref;
 $infoline = "Found compressor: $faspac\n";
@@ -2236,13 +2236,14 @@ sub create_packages_without_epm
 installer::logger::print_message( "... $faspac ...\n" );
 installer::logger::include_timestamp_into_logfile("Starting 
$faspac");
 
- $systemcall = "/bin/sh $faspac -a -q -d $destinationdir 
$packagename";  # $faspac has to be the absolute path!
- make_systemcall($systemcall);
+$systemcall = "/bin/sh $faspac -a -q -d $destinationdir 
$packagename";  # $faspac has to be the absolute path!
+installer::systemactions::make_systemcall($systemcall);
 
- # Setting time stamp for pkginfo, because faspac-so.sh 
changed the pkginfo file,
- # updated the size and checksum, but not the time stamp.
- $systemcall = "touch -r $pkginfotmp $pkginfoorig";
- make_systemcall($systemcall);
+# Setting time stamp for pkginfo, because faspac-so.sh
+# changed the pkginfo file, updated the size and
+# checksum, but not the time stamp.
+$systemcall = "touch -r $pkginfotmp $pkginfoorig";
+installer::systemactions::make_systemcall($systemcall);
 if ( -f $pkginfotmp ) { unlink($pkginfotmp); }
 
 installer::logger::include_timestamp_into_logfile("End of 
$faspac");
@@ -2530,31 +2531,6 @@ sub remove_temporary_epm_files
 }
 }
 
-##
-# Making the systemcall
-##
-
-sub make_systemcall
-{
-my ($systemcall) = @_;
-
-my $returnvalue = system($systemcall);
-
-my $infoline = "Systemcall: $systemcall\n";
-push( @installer::globals::logfileinfo, $infoline);
-
-if ($returnvalue)
-{
-$infoline = "ERROR: Could not execute \"$systemcall\"!\n";
-push( @installer::globals::logfileinfo, $infoline);
-}
-else
-{
-$infoline = "Success: Executed \"$systemcall\" successfully!\n";
-push( @installer::globals::logfileinfo, $infoline);
-}
-}
-
 ###
 # Creating a better directory structure in the solver.
 ###
@@ -2683,11 +2659,11 @@ sub unpack_tar_gz_file
 
 # unpacking gunzip
 my $systemcall = "cd $destdir; cat $packagename | gunzip | tar -xf -";
-make_systemcall($systemcall);
+installer::systemactions::make_systemcall($systemcall);
 
 # deleting the tar.gz files
 $systemcall = "cd $destdir; rm -f $packagename";
-make_systemcall($systemcall);
+installer::systemactions::make_systemcall($systemcall);
 
 # Finding new content -> that is the package name
 my ($newcontent, $allcontent ) = 
installer::systemactions::find_new_content_in_directory($destdir, $oldcontent);
@@ -2709,7 +2685,7 @@ sub copy_and_unpack_tar_gz_files
 my ($sourcefile, $destdir) = @_;
 
 my $systemcall = "cd $destdir; cat $sourcefile | gunzip | tar -xf -";
-make_systemcall($systemcall);
+installer::systemactions::make_systemcall($systemcall);
 }
 
 ##
diff --git a/solenv/bin/modules/installer/systemactions.pm 
b/solenv/bin/modules/installer/systemactions.pm
index 702b6fe..22d83fb 100644
--- a/solenv/bin/modules/installer/systemactions.pm
+++ b/solenv/bin/modules/installer/systemactions.pm
@@ -1358,4 +1358,29 @@ sub remove_empty_dirs_in_folder
 
 }
 
+##
+# Making systemcall
+##
+
+sub make_systemcall
+{
+my 

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - distro-configs/LibreOfficeMacOSX.conf distro-configs/LibreOfficeMinGW.conf distro-configs/LibreOfficeWin32.conf distro-configs/LibreOfficeWin64.conf

[Libreoffice Gerrit user]

 distro-configs/LibreOfficeMacOSX.conf |1 +
 distro-configs/LibreOfficeMinGW.conf  |1 +
 distro-configs/LibreOfficeWin32.conf  |1 +
 distro-configs/LibreOfficeWin64.conf  |1 +
 4 files changed, 4 insertions(+)

New commits:
commit c91e260587473ec349faa9111ff60a1b492f5c66
Author: Andras Timar 
Date:   Thu Sep 27 18:35:40 2012 +0200

explicitly --disable-gtk for Windows and MacOSX

Change-Id: I0b90350cd1fb9221213e052c1b0f5605663f5090
Signed-off-by: Michael Meeks 

diff --git a/distro-configs/LibreOfficeMacOSX.conf 
b/distro-configs/LibreOfficeMacOSX.conf
index 108ef81..20a66dd 100644
--- a/distro-configs/LibreOfficeMacOSX.conf
+++ b/distro-configs/LibreOfficeMacOSX.conf
@@ -13,3 +13,4 @@
 --enable-extension-integration
 --enable-online-update
 --without-system-postgresql
+--disable-gtk
diff --git a/distro-configs/LibreOfficeMinGW.conf 
b/distro-configs/LibreOfficeMinGW.conf
index 32df782..f582e1f 100644
--- a/distro-configs/LibreOfficeMinGW.conf
+++ b/distro-configs/LibreOfficeMinGW.conf
@@ -29,3 +29,4 @@
 --disable-mozilla
 --disable-xmlsec
 --disable-postgresql-sdbc
+--disable-gtk
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index f608e9b..1a34632 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -7,6 +7,7 @@
 --enable-extension-integration
 --with-java-target-version=1.5
 --disable-activex-component
+--disable-gtk
 --enable-binfilter
 --enable-ext-scripting-beanshell
 --enable-ext-scripting-javascript
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index b4e21c6..2c0b022 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -3,5 +3,6 @@
 --with-java-target-version=1.5
 --enable-cl-x64
 --disable-activex-component
+--disable-gtk
 --enable-ext-scripting-beanshell
 --enable-ext-scripting-javascript
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Are the messages on the splash screen useful?

[Michael Meeks]

On Thu, 2012-09-27 at 19:55 +0400, Ivan Timofeev wrote:
> There is Bug 52268 - Splash Screen: Messages on first start displayed in
> wrong colour in the wrong place
> https://bugs.freedesktop.org/show_bug.cgi?id=52268

Annoying :-) we should fix that.

> and what I want to do is to remove those messages. Is that OK? I cannot
> imagine when the messages can be really useful. Moreover, messages come from

They are useful when we're doing a first-ever startup, and a lot of
heavy-lifting gets done during that first run: creating your home
directory skeleton, compiling help, registering extensions etc. etc.

Luckily a lot of this is getting a lot quicker with Stephan's work, and
we shouldn't really be stuffing tons of duplicate stuff in per-user
directories anyway, so - perhaps in future it'll not be necessary (we
hope ;-).

I guess for slow tasks, it gives the user the impression something is
happening while they start [ though the progress bar can give that too
but is not very granular ].

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Adding Extension for Experimental Thai Spelling

[Richard Wordingham]

On Thu, 27 Sep 2012 21:08:13 +0700
Nathan Wells  wrote:

> Firstly, you are right, I was mistaken about ICU and the breakiterator
> working for sentences (I just tried it right now and it does work,
> but just not with the normal "khan" or "period" of Khmer rather it
> works with Latin sentence markers which is not enough).  I had
> thought when we put in the code for the breakiterator that it also
> covered the sentence, but I guess not (I will work towards getting it
> working for Khmer).

It may be worth modifying the CLDR definition - sentence breaks can be
customised, though it is presently only done for Greek.  However, if
you want Khmer *sentence* rather than *clause* breaking, it will need a
lot of work - papers are still being published on breaking Thai into
sentences (e.g. www.mt-archive.info/Coling-2010-Slayden.pdf ).

> In response to your comments:
> 
> > 1) The user always marks word breaks with ZWSP.
> > In this case, the ideal is to switch off the break iterator for the
> > language.
> 
> 
> There is some truth to this - and that is why I had it as my last
> option (just turning the whole thing off). But the ICU breakiterator
> for Khmer actually works quite well with normal language - it breaks
> down when there are proper names. So turning it off is an option, but
> not the most ideal solution. Some users will continue to always mark
> breaks with a ZWSP (for full control), but I also think having the
> option to turn it off for more complex sentences would be ideal.
> 
> > 2) The user never marks word breaks.
> > In this case, the user is totally dependent on the break iterator,
> > and cannot be helped when it fails.
> 
> As I said above, I think a both/and solution would be idea for Khmer.
> But if in the end it would work better for Thai to have and "off" and
> "on" option only, that would be fine for Khmer as well for now, until
> we can come up with a more ideal solution.
> 
> 
> > 3) The user only marks word breaks and non-word breaks when the
> > iterator fails.
> 
> The problem with this in Khmer is the user cannot tell when the
> breakiterator fails, unless it is on a line-break.  A word could be
> broken up into three parts and the user would never know it.

I usually notice iterator failures in Thai with unrecognised words,
which prompts red ink over strange extents. Usually the words are not
recognised because they're misspelt, but not always.  The problem I see
in Thai is usually not so much as extra word boundaries as misplaced
word boundaries. 

> Actually, if users could see where the
> breakiterator is breaking words, that would simplify things a lot.

That is a very significant observation.

> The only problem with this would be at the beginning of a document or
> the beginning of any new "re-syncing" segment because you might run
> into something like this:

> User input (example in English so others can make sense of it I hope):
> wordwordwordwordword.
> How the sentence is broken up by the breakiterator: wo r d word word
> wo rd word.
> User adds ZWSP to fix broken word on line-break: wo r d word word
> ZWSPwordword.

This example confuses me.  The problem here seems to be extra word
breaks rather than missing word breaks, and I don't see how confirming
a word break helps.

> But user has no idea the first word is broken incorrectly and that it
> is also spelled incorrectly.

> This is why it would be best (I think) as Martin suggested that when
> a ZWSP is detected it also turn off break iteration for the previous
> words up until a re-sync point.  This would practicly give the user
> an "off" option for the whole document if they so chose, and without
> the confusion of having to find some option in the Tools menu to turn
> it on or off - it would just be automatic, depending on the user's
> habit.

I was clearly not clear enough.  In the example above,
'wordwordwordwordword' is what I would call a dictionariless word - a
word-breaker without a dictionary (e.g. a shell's parser) would see it
as just one 'word'.  Therefore, once ZWSP is inserted and
word-breaking disabled, dictionary-based word-breaking is not applied to
wordwordwordZWSPwordword, and, typically, red squiggles appear under
wordwordword and wordword.  The boundary may be revealed by a phase
discontinuity or gap in the squiggle.  Under the proposed scheme, user
has to introduce another three ZWSPs even if the dictionary contains
all the words.

> I agree with this:
> 
> > Considering these four use cases, it seems simplest to let ZWSP, WJ
> > and ZWNBSP disable the iterator for the extent of the
> > dictionariless word in which it occurs.

> Except, it also should disable the breakiterator up to the previous
> re-sync point...

But that is what I meant!

> But actually, there is a rule in ICU for the MAIYAMOK
> so unless that is not working properly, I am not sure why LibreOffice
> doesn't break correctly...

I'll have to look further into this - and check that misbehaviour is
still happening.  Squiggl

Re: [Libreoffice-qa] minutes of ESC call ...

[Bjoern Michaelsen]

On Thu, Sep 27, 2012 at 04:37:43PM +0100, Michael Meeks wrote:
> AI:   + create a new wiki page, based on GSOC page,
> present as the next-step on the Easy Hacks page (Michael)
>   + AmbitiousHacks.
So a few additional thoughts on that:
- having all the stuff in one database (bugzilla) IMHO still makes sense, OTOH
  bugs will clutter with comment noise for larger features
- a three sentence abstract in bugzilla bug ending with "details and discussion
  here: WIKILINK" could still make sense though: it keeps the thing
  discoverable and queriable (esp. for the folks who are already moving around
  on the EasyHacks)
  Yes, that likely means introducing a AmbitiousHacks whiteboard status -- for:
   http://wiki.documentfoundation.org/Development/Easy_Hacks_by_Difficulty
  thats quick and easy, for:
   http://wiki.documentfoundation.org/Development/Easy_Hacks_by_required_Skill
   http://wiki.documentfoundation.org/Development/Easy_Hacks_by_Topic
  it is a bit more work, but OTOH maybe not that urgent ...
- if the scale is ~three month for such an AmbitiousHack, there will be a lot
  of back and forth once work on it is started. IMHO such AmbitiousHacks should
  by that time move to a wikipage on its own, not one shared with other
  AmbitiousHacks -- otherwise things will get messy.

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 5 commits - svtools/inc svtools/source

[Libreoffice Gerrit user]

 svtools/inc/svtools/treelist.hxx   |  107 +-
 svtools/source/contnr/svlbox.cxx   |   24 ++--
 svtools/source/contnr/treelist.cxx |  219 +++--
 3 files changed, 205 insertions(+), 145 deletions(-)

New commits:
commit 1f48c56387fa95bc52e88512f82bc5b5436d7c4c
Author: Kohei Yoshida 
Date:   Thu Sep 27 09:32:19 2012 -0400

Use more STL iterators instead of First(), Next() and last() (sic).

Change-Id: If5f7b749539979e95548b93b840412f18fcb68d7

diff --git a/svtools/inc/svtools/treelist.hxx b/svtools/inc/svtools/treelist.hxx
index 98e5675..d5ba003 100644
--- a/svtools/inc/svtools/treelist.hxx
+++ b/svtools/inc/svtools/treelist.hxx
@@ -66,10 +66,13 @@ class SvListEntry;
 class SVT_DLLPUBLIC SvTreeEntryList
 {
 private:
-std::vector maEntryList;
-size_t mnCurrent;
+typedef std::vector ListType;
+ListType maEntryList;
 
 public:
+typedef ListType::const_iterator const_iterator;
+typedef ListType::iterator iterator;
+
 SvTreeEntryList();
 SvTreeEntryList(const SvTreeEntryList& rList);
 
@@ -88,9 +91,14 @@ public:
 
 SvListEntry* operator[](size_t i);
 const SvListEntry* operator[](size_t i) const;
-SvListEntry* First();
-SvListEntry* Next();
-SvListEntry* last();
+
+const_iterator begin() const;
+const_iterator end() const;
+
+iterator begin();
+iterator end();
+SvListEntry* front();
+SvListEntry* back();
 };
 
 //=
@@ -321,7 +329,7 @@ public:
 sal_BoolHasParent( SvListEntry* pEntry ) const
 { return (sal_Bool)(pEntry->pParent!=pRootItem); }
 
-sal_BoolIsChild( SvListEntry* pParent, SvListEntry* pChild ) 
const;
+boolIsChild(const SvListEntry* pParent, const SvListEntry* 
pChild) const;
 SvListEntry*GetEntry( SvListEntry* pParent, sal_uLong nPos ) const;
 SvListEntry*GetEntry( sal_uLong nRootPos ) const;
 SvListEntry*GetEntryAtAbsPos( sal_uLong nAbsPos ) const;
diff --git a/svtools/source/contnr/svlbox.cxx b/svtools/source/contnr/svlbox.cxx
index bc95659..d3e0c03 100644
--- a/svtools/source/contnr/svlbox.cxx
+++ b/svtools/source/contnr/svlbox.cxx
@@ -827,9 +827,10 @@ sal_Bool SvLBox::CopySelection( SvLBox* pSource, 
SvLBoxEntry* pTarget )
 pSourceEntry = pSource->NextSelected( pSourceEntry );
 }
 
-pSourceEntry = (SvLBoxEntry*)aList.First();
-while ( pSourceEntry )
+SvTreeEntryList::iterator it = aList.begin(), itEnd = aList.end();
+for (; it != itEnd; ++it)
 {
+pSourceEntry = static_cast(*it);
 SvLBoxEntry* pNewParent = 0;
 sal_uLong nInsertionPos = ULONG_MAX;
 sal_Bool 
bOk=NotifyCopying(pTarget,pSourceEntry,pNewParent,nInsertionPos);
@@ -855,8 +856,6 @@ sal_Bool SvLBox::CopySelection( SvLBox* pSource, 
SvLBoxEntry* pTarget )
 
 if( bOk == (sal_Bool)2 )  // HACK: make visible moved entry?
 MakeVisible( pSourceEntry );
-
-pSourceEntry = (SvLBoxEntry*)aList.Next();
 }
 pModel->SetCloneLink( aCloneLink );
 return bSuccess;
@@ -888,9 +887,11 @@ sal_Bool SvLBox::MoveSelectionCopyFallbackPossible( 
SvLBox* pSource, SvLBoxEntry
 pSourceEntry = pSource->NextSelected( pSourceEntry );
 }
 
-pSourceEntry = (SvLBoxEntry*)aList.First();
-while ( pSourceEntry )
+SvTreeEntryList::iterator it = aList.begin(), itEnd = aList.end();
+for (; it != itEnd; ++it)
 {
+pSourceEntry = static_cast(*it);
+
 SvLBoxEntry* pNewParent = 0;
 sal_uLong nInsertionPos = ULONG_MAX;
 sal_Bool bOk = 
NotifyMoving(pTarget,pSourceEntry,pNewParent,nInsertionPos);
@@ -926,8 +927,6 @@ sal_Bool SvLBox::MoveSelectionCopyFallbackPossible( SvLBox* 
pSource, SvLBoxEntry
 
 if( bOk == (sal_Bool)2 )  // HACK: make moved entry visible?
 MakeVisible( pSourceEntry );
-
-pSourceEntry = (SvLBoxEntry*)aList.Next();
 }
 pModel->SetCloneLink( aCloneLink );
 return bSuccess;
@@ -948,11 +947,12 @@ void SvLBox::RemoveSelection()
 SelectChildren( pEntry, sal_False );
 pEntry = NextSelected( pEntry );
 }
-pEntry = (SvLBoxEntry*)aList.First();
-while ( pEntry )
+
+SvTreeEntryList::iterator it = aList.begin(), itEnd = aList.end();
+for (; it != itEnd; ++it)
 {
-pModel->Remove( pEntry );
-pEntry = (SvLBoxEntry*)aList.Next();
+pEntry = static_cast(*it);
+pModel->Remove(pEntry);
 }
 }
 
diff --git a/svtools/source/contnr/treelist.cxx 
b/svtools/source/contnr/treelist.cxx
index 72f24a1..cb12059 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -31,7 +31,7 @@
 DBG_NAME(SvListEntry);
 
 
-SvTreeEntryList::SvTreeEntryList() : mnCurrent(0) {}
+SvTreeEntryList::SvTreeEntryList() {}
 
 void SvTreeEntryList::push_back( SvListEntry* pItem )
 {
@@ -114,36 +114,46 @@ co

Re: Are the messages on the splash screen useful?

[Ivan Timofeev]

Hi Terrence,

On 27.09.2012 21:39, Terrence Enger wrote:
> What messages?  Yes, that is an answer .
> 
> ( Wait a minute. ... Okay, I'm back. )
> 
> With LO master, commit b6e33e2, pulled on 2012-09-17, built and
> running on ubuntu-natty (11.04) with desktop "ubuntu classic (no
> effects)", all I see on the splash screen is message "LibreOffice" and
> the progress bar.

Forgot to mention: on linux the messages are not shown at all. Another
reason to remove them completely. :)

Cheers,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Are the messages on the splash screen useful?

[Terrence Enger]

--
View this message in context: 
http://nabble.documentfoundation.org/Are-the-messages-on-the-splash-screen-useful-tp4009651p4009681.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] add supporting target and options to generate patches for Ex...

[Norbert Thiebaud (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/712

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/712/1

add supporting target and options to generate patches for ExternalProjects

usage:

generate a 'reference' copy of the expanded and patched file structure
$> make clucene.clean
$> patches=t make clucene

go to the module
$> cd clucene

edit files in $WORKDIR/UnpackedTarball/clucene

force a rebuild of things that depend on that UnpackedTarball
$> make clucene.rebuild


create a -p1 patch named clucene.new.patch in the module's directory
$> make clucene.genpatch

you can then rename it, place it where appropriate in the module
hierarchy, update the UnpackedTarball_lucene.mk to apply it.

rinse and repeat from the top (yes the make lucene.clean is needed
to regenerate a 'reference' expanded and patched tarball)

Change-Id: I419c54a5981cffa385521596ba5016d2ca7ef52a
---
M solenv/gbuild/TargetLocations.mk
M solenv/gbuild/UnpackedTarball.mk
M solenv/gbuild/gbuild.mk
3 files changed, 34 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/712
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I419c54a5981cffa385521596ba5016d2ca7ef52a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] ::rtl::OUString to OUString in basctl

[Ricardo Montania (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/711

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/711/1

::rtl::OUString to OUString in basctl

Change-Id: I7be699102eab9cbf7184a5777a4b161db885adec
---
M basctl/source/basicide/unomodel.cxx
M basctl/source/basicide/unomodel.hxx
M basctl/source/inc/accessibledialogcontrolshape.hxx
M basctl/source/inc/baside3.hxx
M basctl/source/inc/dlgedobj.hxx
M basctl/source/inc/iderid.hxx
6 files changed, 26 insertions(+), 26 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/711
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7be699102eab9cbf7184a5777a4b161db885adec
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxattributeoutput.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7d92ac2f05679933d9a2df131786efa6ece00705
Author: Matúš Kukan 
Date:   Thu Sep 27 18:50:49 2012 +0200

sw: hopefully fix windows build

Change-Id: If8d2b964cad9dfd8b847fbc89f9e13ebfb5bc191

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 1252a3b..29aafd2 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2182,7 +2182,7 @@ void DocxAttributeOutput::FlyFrameGraphic( const 
SwGrfNode& rGrfNode, const Size
 if ( aShadowItem.GetLocation() != SVX_SHADOW_NONE )
 {
 // Distance is measured diagonally from corner
-double nShadowDist = 
sqrt((aShadowItem.GetWidth()*aShadowItem.GetWidth())*2);
+double nShadowDist = 
sqrt((aShadowItem.GetWidth()*aShadowItem.GetWidth())*2.0);
 OString aShadowDist( OString::valueOf( TwipsToEMU( nShadowDist ) ) );
 OString aShadowColor = impl_ConvertColor( aShadowItem.GetColor() );
 sal_uInt32 nShadowDir = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

License Statement

[Anurag Jain]

Hi Everyone,

I've received approval from my employer to contribute to Libreoffice. I was
student contributor in last year's GSOC 2011. All of my code/patch
contributions towards Libreoffice will be under MPL/LGPLv3+ dual license.

Regards,
-- 
Anurag Jain
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: uninitialized member warnings ?

[Terrence Enger]

--
View this message in context: 
http://nabble.documentfoundation.org/REVIEW-3-6-trivial-cups-thread-init-issue-tp4008339p4009665.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: distro-configs/LibreOfficeMacOSX.conf distro-configs/LibreOfficeMinGW.conf distro-configs/LibreOfficeWin32.conf distro-configs/LibreOfficeWin64.conf

[Libreoffice Gerrit user]

 distro-configs/LibreOfficeMacOSX.conf |1 +
 distro-configs/LibreOfficeMinGW.conf  |1 +
 distro-configs/LibreOfficeWin32.conf  |1 +
 distro-configs/LibreOfficeWin64.conf  |1 +
 4 files changed, 4 insertions(+)

New commits:
commit 4fed2075cc3ae3857485cf5f370ad7717e823be4
Author: Andras Timar 
Date:   Thu Sep 27 18:35:40 2012 +0200

explicitly --disable-gtk for Windows and MacOSX

Change-Id: I0b90350cd1fb9221213e052c1b0f5605663f5090

diff --git a/distro-configs/LibreOfficeMacOSX.conf 
b/distro-configs/LibreOfficeMacOSX.conf
index 108ef81..20a66dd 100644
--- a/distro-configs/LibreOfficeMacOSX.conf
+++ b/distro-configs/LibreOfficeMacOSX.conf
@@ -13,3 +13,4 @@
 --enable-extension-integration
 --enable-online-update
 --without-system-postgresql
+--disable-gtk
diff --git a/distro-configs/LibreOfficeMinGW.conf 
b/distro-configs/LibreOfficeMinGW.conf
index b7cfd36..642dcc9 100644
--- a/distro-configs/LibreOfficeMinGW.conf
+++ b/distro-configs/LibreOfficeMinGW.conf
@@ -29,3 +29,4 @@
 --disable-extension-integration
 --disable-mozilla
 --disable-postgresql-sdbc
+--disable-gtk
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index f608e9b..1a34632 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -7,6 +7,7 @@
 --enable-extension-integration
 --with-java-target-version=1.5
 --disable-activex-component
+--disable-gtk
 --enable-binfilter
 --enable-ext-scripting-beanshell
 --enable-ext-scripting-javascript
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index b4e21c6..2c0b022 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -3,5 +3,6 @@
 --with-java-target-version=1.5
 --enable-cl-x64
 --disable-activex-component
+--disable-gtk
 --enable-ext-scripting-beanshell
 --enable-ext-scripting-javascript
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: solenv/bin

[Libreoffice Gerrit user]

 solenv/bin/modules/installer/windows/feature.pm |   39 
 1 file changed, 39 deletions(-)

New commits:
commit 08fef531b59412bd6a1ae4cf986c102994711127
Author: Andras Timar 
Date:   Thu Sep 27 18:24:09 2012 +0200

Revert "sorting additional language packs and dictionaries fdo#34479"

This reverts commit f34252f647db9f5d274afb0b12bc897544236003.

We sort these lists with a custom action, no need to sort them in
Perl script. See 39bb77fd667

diff --git a/solenv/bin/modules/installer/windows/feature.pm 
b/solenv/bin/modules/installer/windows/feature.pm
index 80f7954..c22b864 100644
--- a/solenv/bin/modules/installer/windows/feature.pm
+++ b/solenv/bin/modules/installer/windows/feature.pm
@@ -426,45 +426,6 @@ sub create_feature_table
 }
 }
 
-# Sorting names of language packs and dictionaries
-my @tempfeaturetable;
-my @langlist;
-my @langpack;
-my @dictlist;
-my @sorteddictlist;
-my @sortedlanglist;
-
-foreach (@featuretable) {
-if (/^gm_r_Extension_Dictionary_/) {
-push (@dictlist, $_);
-}
-elsif (/^gm_Langpack_r_/) {
-push (@langlist, $_);
-}
-elsif (/\tgm_Langpack_r_/) {
-push (@langpack, $_);
-}
-else {
-push (@tempfeaturetable, $_);
-}
-}
-
-@sorteddictlist = sort { (split(/\t/, $a))[2] cmp (split(/\t/, $b))[2] 
} @dictlist;
-@sortedlanglist = sort { (split(/\t/, $a))[2] cmp (split(/\t/, $b))[2] 
} @langlist;
-
-@featuretable = (@tempfeaturetable, @sorteddictlist);
-
-foreach (@sortedlanglist) {
-my $sortedlanglistline = $_;
-push (@featuretable, $sortedlanglistline);
-foreach (@langpack) {
-my $langpackline = $_;
-if ( (split(/\t/, $langpackline))[1] eq (split(/\t/, 
$sortedlanglistline))[0] ) {
-push (@featuretable, $langpackline);
-}
-}
-}
-
 # Saving the file
 
 my $featuretablename = $basedir . $installer::globals::separator . 
"Feature.idt" . "." . $onelanguage;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: LibreOffice Forums Categories Proposal

[Anton Meixome]

What about l10n?

I see in wiki being jforum the selected software. I'm a bit confuse

May be a fork between Jforum and CodeRanch? As I don't find the translation
framework in JForum

Which version? Is important for NL teams

is it?

https://github.com/rafaelsteil/jforum3/blob/master/src/main/resources/jforumConfig/languages/en_US.properties

Or

http://jforum2.googlecode.com/svn-history/trunk/src/main/config/languages/en_US.properties

Or anywhere here?

https://github.com/rafaelsteil/jforum2



2012/9/27 Marc Paré 

> FYI, there is a post on the discussion list regarding a LibreOffice forums
> categories proposal. As you may or may not know, we are readying a forums
> solution for LibreOffice users and contributors (for those lists who wish
> to have a forums of their own; or, for those lists who are unsure and would
> like to try out a forums for a while alongside their mailing list). In
> order to keep the noise down in the lists, I have posted the proposal on
> the discuss list without including the mailing lists in the address part of
> the email.
>
> Keep in mind that this is a proposal, thus, changes will be made to the
> forums where there is consensus. We would like to keep the main discussion
> of this topic on the discussion list as well as make any decision regarding
> changes from feedback on the discussion list. Feel free to join in on the
> discussion or to contact any of the LibreOffice co-coordinators if you have
> any questions.
>
> You can find the proposal as well as useful links here [
> http://listarchives.**documentfoundation.org/www/**discuss/msg08990.html
> ].
>
> Cheers,
>
> Marc Paré
> Forums co-coordinator
>
> --
> Marc Paré
> m...@marcpare.com
> http://www.parEntreprise.com
> parEntreprise.com Supports OpenDocument Formats (ODF)
> parEntreprise.com 
> Supportshttp://www.**LibreOffice.org
>
> __**_
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.**org 
> http://lists.freedesktop.org/**mailman/listinfo/libreoffice
>



-- 
Antón Méixome - Galician Native Lang Coordination
Galician community LibO & AOO
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Are the messages on the splash screen useful?

[Ivan Timofeev]

Hi,

There is Bug 52268 - Splash Screen: Messages on first start displayed in
wrong colour in the wrong place
https://bugs.freedesktop.org/show_bug.cgi?id=52268

and what I want to do is to remove those messages. Is that OK? I cannot
imagine when the messages can be really useful. Moreover, messages come from

 commit 85c93f5779b0382769cf9dfb5a6306a018c17edd
 Author: Dirk Voelzke 
 Date:   Tue Apr 20 07:59:05 2010 +0200

 jl152 import 263447 from native0jl:#i77196#  Show progress on startup

i.e. only 2010, the API (SplashScreen::setText()) was there since the
first commit.

Regards,
Ivan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

minutes of ESC call ...

[Michael Meeks]

* Present:
+ Joel, Caolan, Stephan, Andras, Tibby, Michael M, Norbert,
  Michael S, Kohei, Kendy, Fridrich, Bjoern, Cedric, Thorsten

* Completed Action Items
+ gerrit - patch abandonment can only be done by owner or gerrit admin 
(Bjoern)
+ apparently non-actionable
+ get some more HardHacks (Joel)
+ shrink Android Remote icon & integrate that (Andrzej Hunt)
+ look at fdo#48366 - xlx import failure (Kohei)
+ look at fdo#48692 - writer table corruption (Michael S)
+ look at fdo#49819 - docx import failure (Michael M)

* Pending Action Items
+ [pending] make bytemark windows box do release builds (Fridrich)
+ Petr to decide release-schedule / overlap gap issue
+ change to contract and OSL_TRACE for oob results in OUString::copy 
(Michael)
+ look at fdo#44278 picture duplication on save (Cedric)
+ look into fdo#54225, fdo#54744 PDF export regressions (Stephan)

* OUString cleanup ongoing
+ no need to use rtl:: prefix anymore for OUString, OString
  OStringToOUString, OUStringToOString

* Release Engineering update (Fridrich)
+ 3.5.7 rc2 ?
+ rc1 will be final, unless someone complains
  no issues raised => go Tuesday.
+ nominally the last release from this branch.
+ 3.6.2 release status
+ rc2 is out - only one known regression in
  Windows custom install: bogus GNOME integration
  option from Linux.
+ Petr back next week.

* UI / design update (Kendy)
+ discussion and mourning for death of impress pop-up actions
+ toolbar will be moved to be nearby
+ conditional dialog management issues - UX input pending ?

* gerrit configuration (Norbert)
+ Tor requested branches that can't be deleted accidentally ?
+ people can continue to use a private repo on freedesktop (Kohei)
+ of course, for those with accounts.
+ branches get synched to freedesktop.
+ configuration tweak to add:
+ private//branch in gerrit to do that.

* older gerrit patches
AI: + https://gerrit.libreoffice.org/#/c/502/ (Bjoern to review)
AI: + bug 53673 - Labels broken with mailmerge (Kendy to find a writer 
volunteer)

* New Layout funkiness (Caolan)
+ re-basing underway, merge later today / tomorrow
+ much prettier dialogs are possible
+ surprisingly little thrash in vcl/ etc.
+ full conversions:
+ remove all the code to load widgets you
  don't touch afterwards
+ remove all hand-crafted awful layout
+ remove the .src and .hrc files
+ unless you need unrelated strings
+ https://wiki.documentfoundation.org/Development/WidgetLayout
+ lots of beautiful things about to start.

* conference (Thorsten)
+ in-person ESC meeting 16th October, 17:00 at the venue.

**  PLEASE REGSISTER BEFORE OCTOBER 8TH **

+ http://conference.libreoffice.org/@@register-for-the-conference
+ speakers please just enter "No" for have you paid;
  that is a valid option.
+ if you have a last-minute paper poke Thorsten for
  the waiting list ...

* Easy Hacks (Michael)
+ propose new Topic: TopicFeature
+ just copying on the wiki page, no objections (Bjoern)
+ propose new Difficulty: DifficultyHard
+ are hard easy hacks an oxymoron ? (Bjoern)
+ adding a category is hard work
+ things like iWorks filter integration, or more (Michael)
+ DifficultyAmbitious ? (Stephan)
AI: + create a new wiki page, based on GSOC page,
  present as the next-step on the Easy Hacks page (Michael)
+ AmbitiousHacks.

* Ensuring on-line help is kept up-to-date (Kendy)
+ possible to update it automatically
+ worried about bad translations slipping through ?
  might take time before we realise something went wrong.
+ is pootle spamming common ? (Michael)
+ not yet.
AI: + enable automatic help build / sync. on a cron-job (Kendy)

* QA update (Joel)
+ QA meeting yesterday
+ lots of vacation going on this time of year
+ interest from discuss/user list to help triage
+ 5x new volunteers interested in helping
AI: + request to dumb-down the back-trace generation page to
  make it more accessible (Michael)
+ 
http://wiki.documentfoundation.org/BugReport#How_to_get_backtrace_.28on_Linux.29
+ explain difference valgrind -> gdb
+ give a simple example / sample output ?
+ use new --valgrind and --backtrace options
+ QA meet-up 

Change in core[libreoffice-3-6]: Highlight X errorbars data range when a chart is selected.

[Norbert Thiebaud (via Code Review)]

Norbert Thiebaud has abandoned this change.

Change subject: Highlight X errorbars data range when a chart is selected.
..


Patch Set 1: Abandoned

per reviewer request

--
To view, visit https://gerrit.libreoffice.org/478
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I90b4f71fb74da59c6c578ccd0e9b62f14620d4e6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot 
Gerrit-Reviewer: Eike Rathke 
Gerrit-Reviewer: Miklos Vajna 
Gerrit-Reviewer: Rafael Dominguez 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: Fix crash on Mac when a11y in use, and avoid infinite loop, ...

[Kohei Yoshida (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/708


--
To view, visit https://gerrit.libreoffice.org/708
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot 
Gerrit-Reviewer: Kohei Yoshida 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Tor Lillqvist 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Change in core[libreoffice-3-6]: Fix crash on Mac when a11y in use, and avoid infinite loop, ...

[Kohei Yoshida (via Code Review)]

Hello Norbert Thiebaud,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/708

to look at the new patch set (#2).

Change subject: Fix crash on Mac when a11y in use, and avoid infinite loop, 
fdo#47275
..

Fix crash on Mac when a11y in use, and avoid infinite loop, fdo#47275

The code used static_cast blindly even if the object not necessarily
was of the assumed subclass. Crash followed. Use dynamic_cast instead
to be able to check, like the corresponding code for GTK a11y. After
that fix we then got a nice infinite loop whn an object apparently is
its own parent. Detect that and break out.

Whether accessibility for the affected parts of the GUI actually works
now for its real use cases, no idea. But anything is better than a
crash...

Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Signed-off-by: Norbert Thiebaud 
---
M vcl/aqua/source/a11y/aqua11yfocustracker.cxx
M vcl/aqua/source/a11y/aqua11ywrapper.mm
2 files changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/708/2
--
To view, visit https://gerrit.libreoffice.org/708
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: LibreOffice gerrit bot 
Gerrit-Reviewer: Kohei Yoshida 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Tor Lillqvist 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: bridges/Library_gcc3_macosx_powerpc.mk

[Libreoffice Gerrit user]

 bridges/Library_gcc3_macosx_powerpc.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 0ed36db9f3eb2fbb5d0a328ae7680cef4a4071bf
Author: Matúš Kukan 
Date:   Thu Sep 27 17:11:48 2012 +0200

bridges: fix macosx build

Change-Id: If05c724cc0bdebea31c31ba9442710c9d951a0cf

diff --git a/bridges/Library_gcc3_macosx_powerpc.mk 
b/bridges/Library_gcc3_macosx_powerpc.mk
index e9ce5d9..450ebe7 100644
--- a/bridges/Library_gcc3_macosx_powerpc.mk
+++ b/bridges/Library_gcc3_macosx_powerpc.mk
@@ -38,7 +38,6 @@ $(eval $(call gb_Library_add_cxxflags,gcc3_uno,\
 
 $(eval $(call gb_Library_use_libraries,gcc3_uno,\
cppu \
-   dl \
sal \
 ))
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PUSHED 3-6] Fix autofilter crasher on OS X

[Kohei Yoshida]

On 09/26/2012 11:16 AM, Kohei Yoshida wrote:

Hi,

I'd like to have

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f373a002df2f083109bb7b2e0987258b6e2f9c4


backported to 3-6, and I would be willing to sign off.  The problem is
that this is a Mac specific code, and I can't verify this.  Could
someone with OS X please verify and cherry-pick to 3-6?


Norbert signed off on this on IRC.  With that, I've pushed it to 3-6.

Kohei


--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - vcl/aqua

[Libreoffice Gerrit user]

 vcl/aqua/source/a11y/aqua11yfocustracker.cxx |   15 ++-
 vcl/aqua/source/a11y/aqua11ywrapper.mm   |7 ++-
 2 files changed, 20 insertions(+), 2 deletions(-)

New commits:
commit 50a72d18900a7faf01ab176bef04dc880f59317a
Author: Tor Lillqvist 
Date:   Wed Sep 26 13:42:54 2012 +0300

Fix crash on Mac when a11y in use, and avoid infinite loop, fdo#47275

The code used static_cast blindly even if the object not necessarily
was of the assumed subclass. Crash followed. Use dynamic_cast instead
to be able to check, like the corresponding code for GTK a11y. After
that fix we then got a nice infinite loop whn an object apparently is
its own parent. Detect that and break out.

Whether accessibility for the affected parts of the GUI actually works
now for its real use cases, no idea. But anything is better than a
crash...

Change-Id: I862234e168db0bd19d185b0f1f73b733b570cac4
Signed-off-by: Norbert Thiebaud 

diff --git a/vcl/aqua/source/a11y/aqua11yfocustracker.cxx 
b/vcl/aqua/source/a11y/aqua11yfocustracker.cxx
index 822b2b4..3bb1168 100644
--- a/vcl/aqua/source/a11y/aqua11yfocustracker.cxx
+++ b/vcl/aqua/source/a11y/aqua11yfocustracker.cxx
@@ -81,7 +81,20 @@ long 
AquaA11yFocusTracker::WindowEventHandler(AquaA11yFocusTracker *pFocusTracke
 pFocusTracker->tabpage_activated( getWindow(pEvent) );
 break;
 case VCLEVENT_MENU_HIGHLIGHT:
-pFocusTracker->menu_highlighted( static_cast < const VclMenuEvent * > 
(pEvent) );
+// Inspired by code in WindowEventHandler in
+// vcl/unx/gtk/a11y/atkutil.cxx, find out what kind of event
+// it is to avoid blindly using a static_cast and crash,
+// fdo#47275.
+if( const VclMenuEvent* pMenuEvent = dynamic_cast < const 
VclMenuEvent* > (pEvent) )
+{
+pFocusTracker->menu_highlighted( pMenuEvent );
+}
+else if( const VclAccessibleEvent* pAccEvent = dynamic_cast < const 
VclAccessibleEvent* > (pEvent) )
+{
+Reference< XAccessible > xAccessible = pAccEvent->GetAccessible();
+if( xAccessible.is() )
+pFocusTracker->setFocusedObject( xAccessible );
+}
 break;
 default:
 break;
diff --git a/vcl/aqua/source/a11y/aqua11ywrapper.mm 
b/vcl/aqua/source/a11y/aqua11ywrapper.mm
index 9f4e55e..2398e82 100644
--- a/vcl/aqua/source/a11y/aqua11ywrapper.mm
+++ b/vcl/aqua/source/a11y/aqua11ywrapper.mm
@@ -379,7 +379,12 @@ static BOOL isPopupMenuOpen = NO;
 // go upstairs until reaching the broken connection
 AquaA11yWrapper * aWrapper = self;
 while ( [ aWrapper accessibleContext ] -> getAccessibleParent().is() ) {
-aWrapper = [ AquaA11yFactory wrapperForAccessibleContext: [ aWrapper 
accessibleContext ] -> getAccessibleParent() -> getAccessibleContext() ];
+AquaA11yWrapper *aTentativeParentWrapper = [ AquaA11yFactory 
wrapperForAccessibleContext: [ aWrapper accessibleContext ] -> 
getAccessibleParent() -> getAccessibleContext() ];
+// Quick-and-dirty fix for infinite loop after fixing crash in
+// fdo#47275
+if ( aTentativeParentWrapper == aWrapper )
+break;
+aWrapper = aTentativeParentWrapper;
 [ aWrapper autorelease ];
 }
 // get associated NSWindow
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Adding Extension for Experimental Thai Spelling

[Richard Wordingham]

On Thu, 27 Sep 2012 11:52:26 +0700
Nathan Wells  wrote:

>> 1. If you are shutting off the ICU breakiterator for text following,
>> we
>> should probably also do it for text preceding. Thus if there is a
>> ZWSP or ZWNBSP (U+2060 WJ) anywhere in a text then ICU break
>> iteration is disabled for the whole sentence.
 
> Yes, I think you are right. If a ZWSP of ZWNBSP is detected then ICU
> break iteration should be disabled for the whole sentence.

What is the logic of this?

The use cases I see are:

1) The user always marks word breaks with ZWSP.

In this case, the ideal is to switch off the break iterator for the
language.

2) The user never marks word breaks.

In this case, the user is totally dependent on the break iterator, and
cannot be helped when it fails.

3) The user only marks word breaks and non-word breaks when the iterator
fails.

In this case, the iterator need only be switched off from the point of
override until it can clearly re-synch.  The obvious re-synching points
are word external punctuation, such as end-of-line, white space,
quotation marks, commas and dandas (and as dandas I would include U+0E2F
THAI CHARACTER PAIYANNOI in its role as angkhandeaw, as well as U+17D5
KHMER SIGN BARIYOOSAN, though an exception may be worthwhile for Thai
ฯลฯ and ฯเปฯ).

Now, it may be easier to explain the rule if it applies to the whole
'word' - for what we are looking at is pretty much a 'word' as
understood by dictionariless editors.

4) Different parts of the text comes from different sources - some mark
word breaks, others expect the application to correctly identify them.

A ZWSP in a chunk of text would then tag the text as having come from a
a user in case 1 or 3; we have no reliable way of distinguishing the
two cases.  A WJ (U+2060) or ZWNBSP (U+FEFF) (when not a BOM, so
paragraph initial is suspect) would strongly suggest use case 3 - but
might occur in use case 1 if the user has had to fight a break
iterator.

(end of use cases)

Considering these four use cases, it seems simplest to let ZWSP, WJ and
ZWNBSP disable the iterator for the extent of the dictionariless word
in which it occurs.

What is the definition of an ICU sentence boundary?  I see no evidence
from CLDR 2.9 that it should be even approximately right for Khmer (or
Thai). Splitting Thai text into sentences is known to be challenging -
we can therefore expect different applications to split text
differently.

The one downside I can see to my suggestion is that if all word
boundaries are marked, switching the iterator off dictionariless word
by dictionariless word will require slightly greater use of WJ, for a
ZWSP later in the sentence will not necessarily be in the same
dictionariless word.

A related issue that seems not to being handled is repetition mark U+0E46 THAI
CHARACTER MAIYAMOK.  It should be separated from the preceding
alphabetic characters by a space, but Libreoffice doesn't recognised
the sequence as a possible continuation of the word.  Sometimes it
is a necessary part of a word.  I don't know what the situation is in
Khmer.

Richard.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice Forums Categories Proposal

[Marc Paré]

FYI, there is a post on the discussion list regarding a LibreOffice 
forums categories proposal. As you may or may not know, we are readying 
a forums solution for LibreOffice users and contributors (for those 
lists who wish to have a forums of their own; or, for those lists who 
are unsure and would like to try out a forums for a while alongside 
their mailing list). In order to keep the noise down in the lists, I 
have posted the proposal on the discuss list without including the 
mailing lists in the address part of the email.


Keep in mind that this is a proposal, thus, changes will be made to the 
forums where there is consensus. We would like to keep the main 
discussion of this topic on the discussion list as well as make any 
decision regarding changes from feedback on the discussion list. Feel 
free to join in on the discussion or to contact any of the LibreOffice 
co-coordinators if you have any questions.


You can find the proposal as well as useful links here 
[http://listarchives.documentfoundation.org/www/discuss/msg08990.html].


Cheers,

Marc Paré
Forums co-coordinator

--
Marc Paré
m...@marcpare.com
http://www.parEntreprise.com
parEntreprise.com Supports OpenDocument Formats (ODF)
parEntreprise.com Supportshttp://www.LibreOffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Adding Extension for Experimental Thai Spelling

[Martin Hosken]

Dear Nathan,

> Here are some new ideas, ordered by desirability, with number one being the
> most desired, to number three being the least.
> 
> 1) When a zero-width space is detected (U+200B), shut off ICU breakiterator
> for Khmer spell checking for characters following the zero-width space
> until encounters real space (U+0020) or end of sentence (detect end of
> sentence using ICU Sentence Boundary).

I think this is a good direction to head. I have to follow on comments:

1. If you are shutting off the ICU breakiterator for text following, we should 
probably also do it for text preceding. Thus if there is a ZWSP or ZWNBSP 
(U+2060 WJ) anywhere in a text then ICU break iteration is disabled for the 
whole sentence.

2. Why limit this to Khmer? I suspect as a model it should work for any 
non-space broken text.

Yours,
Martin



> 
> 2) Disable use of ICU breakiterator for Khmer spell checking by default,
> but allow users to enable it by adding a check-box to enable ICU
> breakiterator in the Tools > Options > Language Settings > Writing Aids >
> Options dialogue when a Khmer Hunspell dictionary is present (
> http://extensions.libreoffice.org/extension-center/khmer-spelling-checker-sbbic-version
>  ).
> 
> 3) Disable use of ICU breakiterator for Khmer spell checking until the ICU
> breakiterator for Khmer is more accurate.
> 
> Currently, with the ICU breakiterator for Khmer enabled in LibreOffice 3.6
> it causes a lot of spelling errors to go unnoticed since the ICU
> breakiterator breaks words up incorrectly. So hopfully we can find a
> solution that will work with the current ICU breakiterator - though with
> ICU 50.1 the breakiterator for Khmer will have some improvements. But I do
> feel if solution 1 or 2 (or if someone else has better ideas) cannot
> be implemented the breakiterator for spelling with Khmer should be turned
> off in LibreOffice until the ICU breakiterator for Khmer is more accurate.
> 
> 
> Thanks again for your help and time, your input is greatly appreciated!
> 
> Sincerely,
> 
> Nathan
> 
> 
> 
> On Thu, Jul 26, 2012 at 4:33 PM, Martin Hosken wrote:
> 
> > Dear All,
> >
> > > > An automatic word and line breaker is very necessary for Khmer and
> > > > Thai because traditionally they have no spaces between words, and so
> > > > line-breaking and spell checking require the use of a zero-width space
> > > > between words which is counterintuitive for most native speakers, and
> > > > so spell checking goes widely unused.
> >
> > I agree that automatic word breaking is a good thing and I am relieved to
> > see that libreoffice does it based on language selection and not on
> > automatic language guessing based on scripts. There are more languages that
> > use Thai script and Khmer script than just Thai and Khmer. So one of my
> > fears is already alleviated :)
> >
> > > > But now with the ICU code you implemented, Thai and Khmer can be
> > > > automatically broken, and the results are quite good. But with its
> > > > implementation in the real world, I have found some issues that I
> > > > wanted to raise and also suggest possible solutions. I write this as
> > > > an end-user, not so much as a programmer, nor do I claim to fully
> > > > understand the inner-workings of ICU and LibreOffice (because I don't!
> > > > ).
> > > >
> > > > First, I will do my best to explain the current results of the ICU
> > > > break iterator with Khmer:
> > > >
> > > > Input sentence: មានប្រាជ្ញាឈ្លាសវៃឈ្មោះសិវកឥវលិយៈ
> > > >
> > > > Current ICU line-breaking: មាន|ប្រាជ្ញាឈ្លាស|វៃ|ឈ្មោះ|សិវ|កឥ|វលិ|យៈ
> > > >
> > > > Compared with the sentence manually broken: មាន|ប្រាជ្ញា|ឈ្លាសវៃ|
> > > > ឈ្មោះ|សិវកឥវលិយៈ
> > > >
> > > > The differences should be clear – the ICU break iterator does not
> > > > break the words with 100% accuracy.
> > > >
> > > > One possible solution to this issue is by how the ICU Break Iterator
> > > > interacts with zero-width spaces (U+200B) in LibreOffice. Before ICU
> > > > code was enabled to automatically break Khmer, if an end-user wanted
> > > > to spell check Khmer, they had to manually place U+200B characters to
> > > > separate words. This solution worked quite well, but was
> > > > counterintuitive to most native speakers, because Khmer has no spaces
> > > > (as stated before). But with this solution, an end-user could be sure
> > > > that their document was broken with 100% accuracy, if there was no
> > > > human error (something automatic solutions cannot do – it is more
> > > > along the lines of 80% accurate). What I propose, is that the break
> > > > iterator code in LibreOffice looks for U+200B characters in a given
> > > > string and considers them as a sign to NOT automatically break, but to
> > > > allow the end-user full control to manually break words. Let me
> > > > explain:
> > > >
> > > >  1. The code starts processing the text and automatically breaking
> > > > it until it comes across a U+200B character. If one is found,
> > > > it 

Code Submissions

[Christopher Copits]

Hi, all,
Just submitted a patch for fdo#43497, but I forgot to mention that all of my 
past & future contributions to LibreOffice may be licensed under the 
MPL/LGPLv3+ dual license.
Thanks,Christopher___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Adding Extension for Experimental Thai Spelling

[Nathan Wells]

Thanks for your input Richard,

Firstly, you are right, I was mistaken about ICU and the breakiterator
working for sentences (I just tried it right now and it does work, but just
not with the normal "khan" or "period" of Khmer rather it works with Latin
sentence markers which is not enough).  I had thought when we put in the
code for the breakiterator that it also covered the sentence, but I guess
not (I will work towards getting it working for Khmer).

In response to your comments:

1) The user always marks word breaks with ZWSP.
> In this case, the ideal is to switch off the break iterator for the
> language.


There is some truth to this - and that is why I had it as my last option
(just turning the whole thing off). But the ICU breakiterator for Khmer
actually works quite well with normal language - it breaks down when there
are proper names. So turning it off is an option, but not the most ideal
solution. Some users will continue to always mark breaks with a ZWSP (for
full control), but I also think having the option to turn it off for more
complex sentences would be ideal.

2) The user never marks word breaks.
> In this case, the user is totally dependent on the break iterator, and
> cannot be helped when it fails.

As I said above, I think a both/and solution would be idea for Khmer. But
if in the end it would work better for Thai to have and "off" and "on"
option only, that would be fine for Khmer as well for now, until we can
come up with a more ideal solution.


3) The user only marks word breaks and non-word breaks when the iterator
> fails.

The problem with this in Khmer is the user cannot tell when the
breakiterator fails, unless it is on a line-break.  A word could be broken
up into three parts and the user would never know it. This is why the issue
is so complex. Actually, if users could see where the breakiterator is
breaking words, that would simplify things a lot. Though I still think the
option to turn the breakiterator "on" or "off" for certain sentences would
be ideal (especially sentences with a ton of proper nouns where the ICU
breakiterator for Khmer has the most trouble).

As far as finding re-syncing points (when to turn the breakitorator back on
when it is turned off by a ZWSP) I agree with you:

> The obvious re-synching points
> are word external punctuation, such as end-of-line, white space,
> quotation marks, commas and dandas (and as dandas I would include U+0E2F
> THAI CHARACTER PAIYANNOI in its role as angkhandeaw, as well as U+17D5
> KHMER SIGN BARIYOOSAN, though an exception may be worthwhile for Thai
> ??? and ).


The only problem with this would be at the beginning of a document or the
beginning of any new "re-syncing" segment because you might run into
something like this:

User input (example in English so others can make sense of it I hope):
wordwordwordwordword.
How the sentence is broken up by the breakiterator: wo r d word word wo rd
word.
User adds ZWSP to fix broken word on line-break: wo r d word word
ZWSPwordword.
But user has no idea the first word is broken incorrectly and that it is
also spelled incorrectly.

This is why it would be best (I think) as Martin suggested that when a ZWSP
is detected it also turn off break iteration for the previous words up
until a re-sync point.  This would practicly give the user an "off" option
for the whole document if they so chose, and without the confusion of
having to find some option in the Tools menu to turn it on or off - it
would just be automatic, depending on the user's habit.

I agree with this:

> Considering these four use cases, it seems simplest to let ZWSP, WJ and
> ZWNBSP disable the iterator for the extent of the dictionariless word
> in which it occurs.


Except, it also should disable the breakiterator up to the previous re-sync
point to enable users to functionally "turn off" the breakitorator if they
so choose (for Khmer this is necessary because for a book editor like
myself, I will want to manually put the breaks and not let the
breakitorator do anything automatically - but the feature is nice for the
casual user because it is much faster and more intuitive to not type spaces
between words for Cambodians).

A related issue that seems not to being handled is repetition mark U+0E46
> THAI
> CHARACTER MAIYAMOK.  It should be separated from the preceding
> alphabetic characters by a space, but Libreoffice doesn't recognised
> the sequence as a possible continuation of the word.  Sometimes it
> is a necessary part of a word.  I don't know what the situation is in
> Khmer.


In Khmer the repeat character (U+17D7 LEK TOO) is not separated from the
preceding word by a space, but is connected, so this is not an issue for
us.  But actually, there is a rule in ICU for the MAIYAMOK so unless that
is not working properly, I am not sure why LibreOffice doesn't break
correctly...

Here's the code from ICU4c for the Thai  MAIYAMOK from dictbe.cpp if anyone
is interested...

if (uc == 
THAI_MAIYAMOK

[Libreoffice-commits] .: apache-commons/patches apache-commons/UnpackedTarball_apache_commons_codec.mk

[Libreoffice Gerrit user]

 apache-commons/UnpackedTarball_apache_commons_codec.mk |4 ++
 apache-commons/patches/codec.patch |   28 -
 2 files changed, 18 insertions(+), 14 deletions(-)

New commits:
commit f0a29602b50418dd427e7bfa093d5671f33fa307
Author: Norbert Thiebaud 
Date:   Thu Sep 27 08:10:02 2012 -0500

fix patch eol issue in apache_commons_codec

Change-Id: Ie03b654538fc18d02c33aadd7e99fe76b29bef56

diff --git a/apache-commons/UnpackedTarball_apache_commons_codec.mk 
b/apache-commons/UnpackedTarball_apache_commons_codec.mk
index 2e7ae65..17d7e50 100644
--- a/apache-commons/UnpackedTarball_apache_commons_codec.mk
+++ b/apache-commons/UnpackedTarball_apache_commons_codec.mk
@@ -11,6 +11,10 @@ $(eval $(call 
gb_UnpackedTarball_UnpackedTarball,apache_commons_codec))
 
 $(eval $(call 
gb_UnpackedTarball_set_tarball,apache_commons_codec,$(APACHE_COMMONS_CODEC_TARBALL)))
 
+$(eval $(call gb_UnpackedTarball_fix_end_of_line,apache_commons_codec,\
+build.xml \
+))
+
 $(eval $(call gb_UnpackedTarball_add_patches,apache_commons_codec,\
apache-commons/patches/codec.patch \
 ))
diff --git a/apache-commons/patches/codec.patch 
b/apache-commons/patches/codec.patch
index dea25ad..ffbcb57 100644
--- a/apache-commons/patches/codec.patch
+++ b/apache-commons/patches/codec.patch
@@ -1,17 +1,17 @@
 --- misc/build/commons-codec-1.3/build.xml-old 2008-01-31 15:28:58.0 
+0100
 +++ misc/build/commons-codec-1.3/build.xml 2008-01-31 15:29:21.0 
+0100
 @@ -90,14 +90,12 @@
- 
- 
- 
--
- 
- 
- 
- 
- 
- 
--
- 
- 
- 
+ 
+ 
+ 
+-
+ 
+ 
+ 
+ 
+ 
+ 
+-
+ 
+ 
+ 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: solenv/gbuild

[Libreoffice Gerrit user]

 solenv/gbuild/gbuild.mk |9 +
 1 file changed, 9 insertions(+)

New commits:
commit 8c20367a2e6d61f830f6dc336761909e38a6bcca
Author: Norbert Thiebaud 
Date:   Thu Sep 27 07:56:12 2012 -0500

gbuild: allow for SHELL to be set by the env variable gb_SHELL

This allow to build using a non bash shell on system for which
/bin/sh is bash

Change-Id: I276c777d1fca20858219ac95457a367300644b16

diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 0f11ea0..ee2f985 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -48,7 +48,16 @@ GBUILDDIR:=$(SRCDIR)/solenv/gbuild
 
 .DELETE_ON_ERROR:
 
+# by default gbuild use /bin/sh
+# if you want to use a particular shell
+# you can export gb_SHELL=
+#
+ifdef gb_SHELL
+SHELL := $(gb_SHELL)
+else
 SHELL := /bin/sh
+endif
+
 true := T
 false :=
 define NEWLINE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

bug 53673; writer hacker help requested ...

[Michael Meeks]

Hi there,

On Wed, 2012-09-12 at 10:43 +0200, Winfried Donkers wrote:
> My previous request on the list did not get any response and you seem
> to remenber my label-work.

Yes of course ! I see you knocked up a patch in:

https://bugs.freedesktop.org/show_bug.cgi?id=53673

And the current state suggests that it is some saving / re-loading
issue that is at fault.

https://bugs.freedesktop.org/show_bug.cgi?id=53673#c9

Anyone on the writer / filter side that can help Winfried out ?

Thanks,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] String to OUString in basctl

[Noel Power (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/706

Approvals:
  Noel Power: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/706
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52ce4fcf4b02746df898c7fbbf57a58b274dd0b2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Noel Power 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString cleanup in basctl

[Noel Power (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/705

Approvals:
  Noel Power: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/705
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icb6f04d6ad22f1652abbb399beb08645daf8b9c9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Noel Power 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: avmedia/source basctl/source

[Libreoffice Gerrit user]

 avmedia/source/gstreamer/gstframegrabber.cxx |4 +--
 basctl/source/inc/accessibledialogwindow.hxx |   14 ++---
 basctl/source/inc/basidesh.hxx   |   28 +--
 basctl/source/inc/dlged.hxx  |4 +--
 4 files changed, 25 insertions(+), 25 deletions(-)

New commits:
commit 1a42e2458bda63e7c11b5298bee34eebbaedd022
Author: Ricardo Montania 
Date:   Wed Sep 26 21:24:26 2012 -0300

::rtl::OUString cleanup in basctl

Change-Id: Icb6f04d6ad22f1652abbb399beb08645daf8b9c9
Reviewed-on: https://gerrit.libreoffice.org/705
Reviewed-by: Noel Power 
Tested-by: Noel Power 

diff --git a/avmedia/source/gstreamer/gstframegrabber.cxx 
b/avmedia/source/gstreamer/gstframegrabber.cxx
index d9a4ed1..ed998dd 100644
--- a/avmedia/source/gstreamer/gstframegrabber.cxx
+++ b/avmedia/source/gstreamer/gstframegrabber.cxx
@@ -51,7 +51,7 @@ void FrameGrabber::disposePipeline()
 }
 }
 
-FrameGrabber::FrameGrabber( const rtl::OUString &rURL ) :
+FrameGrabber::FrameGrabber( const OUString &rURL ) :
 FrameGrabber_BASE()
 {
 gchar *pPipelineStr;
@@ -97,7 +97,7 @@ FrameGrabber::~FrameGrabber()
 disposePipeline();
 }
 
-FrameGrabber* FrameGrabber::create( const rtl::OUString &rURL )
+FrameGrabber* FrameGrabber::create( const OUString &rURL )
 {
 return new FrameGrabber( rURL );
 }
diff --git a/basctl/source/inc/accessibledialogwindow.hxx 
b/basctl/source/inc/accessibledialogwindow.hxx
index c8885ea..884cb64 100644
--- a/basctl/source/inc/accessibledialogwindow.hxx
+++ b/basctl/source/inc/accessibledialogwindow.hxx
@@ -122,9 +122,9 @@ public:
 DECLARE_XTYPEPROVIDER()
 
 // XServiceInfo
-virtual ::rtl::OUString SAL_CALL getImplementationName() throw 
(::com::sun::star::uno::RuntimeException);
-virtual sal_Bool SAL_CALL supportsService( const ::rtl::OUString& 
rServiceName ) throw (::com::sun::star::uno::RuntimeException);
-virtual ::com::sun::star::uno::Sequence< ::rtl::OUString > SAL_CALL 
getSupportedServiceNames() throw (::com::sun::star::uno::RuntimeException);
+virtual OUString SAL_CALL getImplementationName() throw 
(::com::sun::star::uno::RuntimeException);
+virtual sal_Bool SAL_CALL supportsService( const OUString& rServiceName ) 
throw (::com::sun::star::uno::RuntimeException);
+virtual ::com::sun::star::uno::Sequence< OUString > SAL_CALL 
getSupportedServiceNames() throw (::com::sun::star::uno::RuntimeException);
 
 // XAccessible
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::accessibility::XAccessibleContext > SAL_CALL 
getAccessibleContext(  ) throw (::com::sun::star::uno::RuntimeException);
@@ -135,8 +135,8 @@ public:
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::accessibility::XAccessible > SAL_CALL getAccessibleParent(  ) 
throw (::com::sun::star::uno::RuntimeException);
 virtual sal_Int32 SAL_CALL getAccessibleIndexInParent(  ) throw 
(::com::sun::star::uno::RuntimeException);
 virtual sal_Int16 SAL_CALL getAccessibleRole(  ) throw 
(::com::sun::star::uno::RuntimeException);
-virtual ::rtl::OUString SAL_CALL getAccessibleDescription(  ) throw 
(::com::sun::star::uno::RuntimeException);
-virtual ::rtl::OUString SAL_CALL getAccessibleName(  ) throw 
(::com::sun::star::uno::RuntimeException);
+virtual OUString SAL_CALL getAccessibleDescription(  ) throw 
(::com::sun::star::uno::RuntimeException);
+virtual OUString SAL_CALL getAccessibleName(  ) throw 
(::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::accessibility::XAccessibleRelationSet > SAL_CALL 
getAccessibleRelationSet(  ) throw (::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::accessibility::XAccessibleStateSet > SAL_CALL 
getAccessibleStateSet(  ) throw (::com::sun::star::uno::RuntimeException);
 virtual ::com::sun::star::lang::Locale SAL_CALL getLocale(  ) throw 
(::com::sun::star::accessibility::IllegalAccessibleComponentStateException, 
::com::sun::star::uno::RuntimeException);
@@ -149,8 +149,8 @@ public:
 
 // XAccessibleExtendedComponent
 virtual ::com::sun::star::uno::Reference< ::com::sun::star::awt::XFont > 
SAL_CALL getFont(  ) throw (::com::sun::star::uno::RuntimeException);
-virtual ::rtl::OUString SAL_CALL getTitledBorderText(  ) throw 
(::com::sun::star::uno::RuntimeException);
-virtual ::rtl::OUString SAL_CALL getToolTipText(  ) throw 
(::com::sun::star::uno::RuntimeException);
+virtual OUString SAL_CALL getTitledBorderText(  ) throw 
(::com::sun::star::uno::RuntimeException);
+virtual OUString SAL_CALL getToolTipText(  ) throw 
(::com::sun::star::uno::RuntimeException);
 
 // XAccessibleSelection
 virtual void SAL_CALL selectAccessibleChild( sal_Int32 nChildIndex ) throw 
(::com::sun::star::lang::IndexOutOfBoundsException, 
::com::sun::star::uno::RuntimeException);
diff --git a/basctl/source/inc/basidesh.hxx 

[Libreoffice-commits] .: basctl/source

[Libreoffice Gerrit user]

 basctl/source/basicide/baside2b.cxx |   58 ++--
 1 file changed, 29 insertions(+), 29 deletions(-)

New commits:
commit f25adb4954eaea92e1d98a652a66eeaa4c8fe7c3
Author: Ricardo Montania 
Date:   Wed Sep 26 23:07:35 2012 -0300

String to OUString in basctl

Change-Id: I52ce4fcf4b02746df898c7fbbf57a58b274dd0b2
Reviewed-on: https://gerrit.libreoffice.org/706
Tested-by: Noel Power 
Reviewed-by: Noel Power 

diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index fefed79..914a916 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -91,22 +91,22 @@ char const cSuffixes[] = "%&!#@$";
  *
  * get/setText() only supports tools Strings limited to 64K).
  */
-rtl::OUString getTextEngineText (ExtTextEngine& rEngine)
+OUString getTextEngineText (ExtTextEngine& rEngine)
 {
 SvMemoryStream aMemStream;
 aMemStream.SetStreamCharSet( RTL_TEXTENCODING_UTF8 );
 aMemStream.SetLineDelimiter( LINEEND_LF );
 rEngine.Write( aMemStream );
 sal_uLong nSize = aMemStream.Tell();
-::rtl::OUString aText( (const sal_Char*)aMemStream.GetData(),
+OUString aText( (const sal_Char*)aMemStream.GetData(),
 nSize, RTL_TEXTENCODING_UTF8 );
 return aText;
 }
 
-void setTextEngineText (ExtTextEngine& rEngine, rtl::OUString const& aStr)
+void setTextEngineText (ExtTextEngine& rEngine, OUString const& aStr)
 {
 rEngine.SetText(String());
-::rtl::OString aUTF8Str = ::rtl::OUStringToOString( aStr, 
RTL_TEXTENCODING_UTF8 );
+OString aUTF8Str = ::rtl::OUStringToOString( aStr, RTL_TEXTENCODING_UTF8 );
 SvMemoryStream aMemStream( (void*)aUTF8Str.getStr(), aUTF8Str.getLength(),
 STREAM_READ | STREAM_SEEK_TO_BEGIN );
 aMemStream.SetStreamCharSet( RTL_TEXTENCODING_UTF8 );
@@ -237,9 +237,9 @@ EditorWindow::EditorWindow (Window* pParent, ModulWindow* 
pModulWindow) :
 osl::MutexGuard g(mutex_);
 notifier_ = n;
 }
-Sequence< rtl::OUString > s(2);
-s[0] = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("FontHeight"));
-s[1] = rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("FontName"));
+Sequence< OUString > s(2);
+s[0] = OUString( "FontHeight" );
+s[1] = OUString( "FontName" );
 n->addPropertiesChangeListener(s, listener_.get());
 }
 
@@ -556,7 +556,7 @@ bool EditorWindow::SetSourceInBasic()
 
 // Returns the position of the last character of any of the following
 // EOL char combinations: CR, CR/LF, LF, return -1 if no EOL is found
-sal_Int32 searchEOL( const ::rtl::OUString& rStr, sal_Int32 fromIndex )
+sal_Int32 searchEOL( const OUString& rStr, sal_Int32 fromIndex )
 {
 sal_Int32 iRetPos = -1;
 
@@ -592,7 +592,7 @@ void EditorWindow::CreateEditEngine()
 
 bool bWasDoSyntaxHighlight = bDoSyntaxHighlight;
 bDoSyntaxHighlight = false; // too slow for large texts...
-rtl::OUString aOUSource(rModulWindow.GetModule());
+OUString aOUSource(rModulWindow.GetModule());
 sal_Int32 nLines = 0;
 sal_Int32 nIndex = -1;
 do
@@ -646,7 +646,7 @@ void EditorWindow::CreateEditEngine()
 
 // set readonly mode for readonly libraries
 ScriptDocument aDocument(rModulWindow.GetDocument());
-rtl::OUString aOULibName(rModulWindow.GetLibName());
+OUString aOULibName(rModulWindow.GetLibName());
 Reference< script::XLibraryContainer2 > xModLibContainer( 
aDocument.getLibraryContainer( E_SCRIPTS ), UNO_QUERY );
 if ( xModLibContainer.is() && xModLibContainer->hasByName( aOULibName ) && 
xModLibContainer->isLibraryReadOnly( aOULibName ) )
 {
@@ -776,7 +776,7 @@ void EditorWindow::InitScrollBars()
 {
 rModulWindow.GetHScrollBar()->SetVisibleSize( aOutSz.Width() );
 rModulWindow.GetHScrollBar()->SetPageSize( aOutSz.Width() * 8 / 10 );
-rModulWindow.GetHScrollBar()->SetLineSize( GetTextWidth( 
rtl::OUString('x') ) );
+rModulWindow.GetHScrollBar()->SetLineSize( GetTextWidth( OUString('x') 
) );
 rModulWindow.GetHScrollBar()->SetThumbPos( 
pEditView->GetStartDocPos().X() );
 rModulWindow.GetHScrollBar()->Show();
 }
@@ -820,9 +820,9 @@ void EditorWindow::UpdateSyntaxHighlighting ()
 
 void EditorWindow::ImplSetFont()
 {
-rtl::OUString sFontName(
+OUString sFontName(
 officecfg::Office::Common::Font::SourceViewFont::FontName::get().
-get_value_or( rtl::OUString() ) );
+get_value_or( OUString() ) );
 if ( sFontName.isEmpty() )
 {
 Font aTmpFont( OutputDevice::GetDefaultFont( DEFAULTFONT_FIXED, 
Application::GetSettings().GetUILanguage(), 0 , this ) );
@@ -1361,8 +1361,8 @@ void WatchWindow::AddWatch( const String& rVName )
 lcl_SeparateNameAndIndex( rVName, aVar, aIndex );
 WatchItem* pWatchItem = new WatchItem(aVar);
 
-String aWatchStr_( aVar );
-aWatchStr_ += String( RTL_CONSTASCII_USTRINGPARAM( "\t\t" ) );
+OUString aWatchStr_( aVar );
+aWatchStr_ += OUString( "\t\t" );
  

[PUSHED] Export image shadow effects to docx.

[Noel Power (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/709

Approvals:
  Noel Power: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/709
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8be107eeaeed286359869fd7e6712c3f740fba5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Eilidh McAdam 
Gerrit-Reviewer: Noel Power 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxattributeoutput.cxx |   32 +++
 1 file changed, 32 insertions(+)

New commits:
commit 57633e42ffba2f495fd685233695acad6b9dde94
Author: Eilidh McAdam 
Date:   Thu Sep 27 12:39:59 2012 +0100

Export image shadow effects to docx.

Change-Id: Ic8be107eeaeed286359869fd7e6712c3f740fba5
Reviewed-on: https://gerrit.libreoffice.org/709
Reviewed-by: Noel Power 
Tested-by: Noel Power 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index e4cd092..1252a3b 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -2176,6 +2176,38 @@ void DocxAttributeOutput::FlyFrameGraphic( const 
SwGrfNode& rGrfNode, const Size
 m_pSerializer->singleElementNS( XML_a, XML_tailEnd,
 FSEND );
 m_pSerializer->endElementNS( XML_a, XML_ln );
+
+// Output effects
+SvxShadowItem aShadowItem = rGrfNode.GetFlyFmt()->GetShadow();
+if ( aShadowItem.GetLocation() != SVX_SHADOW_NONE )
+{
+// Distance is measured diagonally from corner
+double nShadowDist = 
sqrt((aShadowItem.GetWidth()*aShadowItem.GetWidth())*2);
+OString aShadowDist( OString::valueOf( TwipsToEMU( nShadowDist ) ) );
+OString aShadowColor = impl_ConvertColor( aShadowItem.GetColor() );
+sal_uInt32 nShadowDir = 0;
+switch ( aShadowItem.GetLocation() )
+{
+case SVX_SHADOW_TOPLEFT: nShadowDir = 1350; break;
+case SVX_SHADOW_TOPRIGHT: nShadowDir = 1890; break;
+case SVX_SHADOW_BOTTOMLEFT: nShadowDir = 810; break;
+case SVX_SHADOW_BOTTOMRIGHT: nShadowDir = 270; break;
+case SVX_SHADOW_NONE:
+case SVX_SHADOW_END:
+break;
+}
+OString aShadowDir( OString::valueOf( long(nShadowDir) ) );
+
+m_pSerializer->startElementNS( XML_a, XML_effectLst, FSEND );
+m_pSerializer->startElementNS( XML_a, XML_outerShdw,
+   XML_dist, aShadowDist.getStr(),
+   XML_dir, aShadowDir.getStr(), FSEND );
+m_pSerializer->singleElementNS( XML_a, XML_srgbClr,
+XML_val, aShadowColor.getStr(), FSEND 
);
+m_pSerializer->endElementNS( XML_a, XML_outerShdw );
+m_pSerializer->endElementNS( XML_a, XML_effectLst );
+}
+
 m_pSerializer->endElementNS( XML_pic, XML_spPr );
 
 m_pSerializer->endElementNS( XML_pic, XML_pic );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: solenv/gbuild

[Libreoffice Gerrit user]

 solenv/gbuild/gbuild.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dca431cfea27385ffbcbebd3f080176a809bf9a2
Author: Norbert Thiebaud 
Date:   Thu Sep 27 07:38:02 2012 -0500

revert the change in gbuild.mk : use /bin/sh as SHELL

This is for performance reasons.
there is a measurable benefit of being able to use /bin/dash
vs /bin/bash
and since make is a big consumer of shells, it is worth the pain.

Change-Id: I0654bee1e7bab1041cd00b5e71498bd593aeeecb

diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index c7f8a83..0f11ea0 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -48,7 +48,7 @@ GBUILDDIR:=$(SRCDIR)/solenv/gbuild
 
 .DELETE_ON_ERROR:
 
-SHELL := /usr/bin/env bash
+SHELL := /bin/sh
 true := T
 false :=
 define NEWLINE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: apache-commons/ExternalProject_apache_commons_codec.mk apache-commons/ExternalProject_apache_commons_httpclient.mk apache-commons/ExternalProject_apache_commons_lang.mk apache

[Libreoffice Gerrit user]

 apache-commons/ExternalProject_apache_commons_codec.mk  |2 +-
 apache-commons/ExternalProject_apache_commons_httpclient.mk |2 +-
 apache-commons/ExternalProject_apache_commons_lang.mk   |2 +-
 apache-commons/ExternalProject_apache_commons_logging.mk|2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1cb87841f452ad7bb52aa0279edba6b6e980fbc7
Author: Norbert Thiebaud 
Date:   Thu Sep 27 07:33:53 2012 -0500

use a form that please /bin/dash in apache_commons build script

Change-Id: I2a7061f428d402751627fc93ca559e119aab94d2

diff --git a/apache-commons/ExternalProject_apache_commons_codec.mk 
b/apache-commons/ExternalProject_apache_commons_codec.mk
index 7e07d39..cf3a284 100644
--- a/apache-commons/ExternalProject_apache_commons_codec.mk
+++ b/apache-commons/ExternalProject_apache_commons_codec.mk
@@ -20,7 +20,7 @@ $(eval $(call 
gb_ExternalProject_register_targets,apache_commons_codec,\
 
 $(call gb_ExternalProject_get_state_target,apache_commons_codec,build) :
cd "$(call gb_UnpackedTarball_get_dir,apache_commons_codec)" && \
-   ANT_OPTS+="-Dfile.encoding=ISO-8859-1" \
+   ANT_OPTS="$$ANT_OPTS -Dfile.encoding=ISO-8859-1" \
"$(ANT)" \
-q \
-f build.xml \
diff --git a/apache-commons/ExternalProject_apache_commons_httpclient.mk 
b/apache-commons/ExternalProject_apache_commons_httpclient.mk
index e1a55bd..9dad40d 100644
--- a/apache-commons/ExternalProject_apache_commons_httpclient.mk
+++ b/apache-commons/ExternalProject_apache_commons_httpclient.mk
@@ -23,7 +23,7 @@ $(eval $(call 
gb_ExternalProject_register_targets,apache_commons_httpclient,\
 
 $(call gb_ExternalProject_get_state_target,apache_commons_httpclient,build) :
cd "$(call gb_UnpackedTarball_get_dir,apache_commons_httpclient)" && \
-   ANT_OPTS+="-Dfile.encoding=ISO-8859-1" \
+   ANT_OPTS="$$ANT_OPTS -Dfile.encoding=ISO-8859-1" \
"$(ANT)" \
-q \
-f build.xml \
diff --git a/apache-commons/ExternalProject_apache_commons_lang.mk 
b/apache-commons/ExternalProject_apache_commons_lang.mk
index 87ac5e0..23c3b56 100644
--- a/apache-commons/ExternalProject_apache_commons_lang.mk
+++ b/apache-commons/ExternalProject_apache_commons_lang.mk
@@ -20,7 +20,7 @@ $(eval $(call 
gb_ExternalProject_register_targets,apache_commons_lang,\
 
 $(call gb_ExternalProject_get_state_target,apache_commons_lang,build) :
cd "$(call gb_UnpackedTarball_get_dir,apache_commons_lang)" && \
-   ANT_OPTS+="-Dfile.encoding=ISO-8859-1" \
+   ANT_OPTS="$$ANT_OPTS -Dfile.encoding=ISO-8859-1" \
"$(ANT)" \
-q \
-f build.xml \
diff --git a/apache-commons/ExternalProject_apache_commons_logging.mk 
b/apache-commons/ExternalProject_apache_commons_logging.mk
index d51c3a9..fce2635 100644
--- a/apache-commons/ExternalProject_apache_commons_logging.mk
+++ b/apache-commons/ExternalProject_apache_commons_logging.mk
@@ -20,7 +20,7 @@ $(eval $(call 
gb_ExternalProject_register_targets,apache_commons_logging,\
 
 $(call gb_ExternalProject_get_state_target,apache_commons_logging,build) :
cd "$(call gb_UnpackedTarball_get_dir,apache_commons_logging)" && \
-   ANT_OPTS+="-Dfile.encoding=ISO-8859-1" \
+   ANT_OPTS="$$ANT_OPTS -Dfile.encoding=ISO-8859-1" \
"$(ANT)" \
-q \
-f build.xml \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: SHELL=/bin/sh vs bash performance

[Michael Stahl]

On 27/09/12 13:57, Michael Stahl wrote:
> following numbers are from my Fedora 17 system, with the toy attachment
> that spawns 100k shells running "true" (only one run each):

argh... stupid me forgot to attach it and even clicked the wrong button
on the thunderbird warning...

#include 
#include 
#include 
#include 

int main(void)
{
char * shell = getenv("SHELL");
printf("%s\n", shell);
for (int i = 0; i < 10; ++i)
{
if (fork())
{
wait(0);
}
else
{
char *const argv[] = { shell, "-c", "true", 0 };
execv(shell, argv);
}
}
}
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

SHELL=/bin/sh vs bash performance

[Michael Stahl]

because the topic of shells for the build system came up on IRC:

in [1] it is claimed that dash is faster, that could be relevant to us
given how we spawn boatloads of shells: "The boot speed improvements in
Ubuntu 6.10 were often incorrectly attributed to Upstart ... These
improvements were in fact largely due to the changed /bin/sh."

also man bash says:

> BUGS
>It's too big and too slow.

following numbers are from my Fedora 17 system, with the toy attachment
that spawns 100k shells running "true" (only one run each):

> [0] ms@bastet:~ > SHELL=/bin/bash time ./a.out 
> /bin/bash
> 92.95user 113.48system 3:45.26elapsed 91%CPU (0avgtext+0avgdata 
> 1276maxresident)k
> 0inputs+0outputs (0major+37438873minor)pagefaults 0swaps

> [0] ms@bastet:~ > ls -l /bin/sh
> lrwxrwxrwx. 1 root root 4  5. Aug 23:25 /bin/sh -> bash
> [0] ms@bastet:~ > SHELL=/bin/sh time ./a.out 
> /bin/sh
> 93.47user 112.89system 3:45.37elapsed 91%CPU (0avgtext+0avgdata 
> 1276maxresident)k
> 0inputs+0outputs (0major+37338986minor)pagefaults 0swaps

> [0] ms@bastet:~ > SHELL=/bin/dash time ./a.out 
> /bin/dash
> 1.11user 9.06system 1:34.89elapsed 10%CPU (0avgtext+0avgdata 608maxresident)k
> 0inputs+0outputs (0major+19148968minor)pagefaults 0swaps

because i couldn't believe the difference i thought perhaps my .bashrc
makes it much slower so i've cleared it and logged in via ssh, which
makes it not that much faster:

> -bash-4.2$ SHELL=/bin/sh time ./a.out
> /bin/sh
> 85.96user 110.53system 3:38.24elapsed 90%CPU (0avgtext+0avgdata 
> 1264maxresident)k
> 0inputs+0outputs (0major+37067614minor)pagefaults 0swaps

so clearly there is a measurable benefit to using /bin/dash as shell.

considering the above i'd like the build system to continue to support
non-bash shells and also it would be great to have a tinderbox using
non-bash /bin/sh to build in order to detect breakage (this does not
require a new tinderbox, at least for Fedora there is a "dash" package,
it would just require symlinking /bin/sh to it).

on a related note it would also be great to have a tinderbox with GNU
make 3.81, because (on non-windows platforms) that is supposed to work
but breaks from time to time because only Debian still ships it by
default AFAIK.

[1] https://wiki.ubuntu.com/DashAsBinSh



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: No dictionaries were preselected for en_US langpack

[Andras Timar (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/707

Approvals:
  Andras Timar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/707
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann 
Gerrit-Reviewer: Andras Timar 
Gerrit-Reviewer: Stephan Bergmann 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - setup_native/source

[Libreoffice Gerrit user]

 setup_native/source/win32/customactions/sellang/sellang.cxx |  160 +---
 1 file changed, 70 insertions(+), 90 deletions(-)

New commits:
commit b04ffe037117c35ebd05b41569379e8acded4fbc
Author: Stephan Bergmann 
Date:   Thu Sep 27 08:31:41 2012 +0200

No dictionaries were preselected for en_US langpack

...as gm_Langpack_r_en_US was explicitly excluded from langs[] in
SelectLanguage, so addMatchingDictionaries was never called for it.  (This 
was
only evident in installation sets conaining only few langpacks, as the
"official" multi-lang installation set also contains en_GB etc., so 
appropriate
dictionaries were selected through those.)

Reworked the logic of chosing which langpacks to preselect (see the comment 
in
SelectLanguage); hope it still works as intended for the various cases (of 
which
the "official" multi-lang installation set is the only truly relevant one, 
for
now).

(cherry picked from commit 8cb7464130634551fd2f043efc14f8f8f8bdf447)

Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
Reviewed-on: https://gerrit.libreoffice.org/707
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/setup_native/source/win32/customactions/sellang/sellang.cxx 
b/setup_native/source/win32/customactions/sellang/sellang.cxx
index 8d243b0..cda413c 100644
--- a/setup_native/source/win32/customactions/sellang/sellang.cxx
+++ b/setup_native/source/win32/customactions/sellang/sellang.cxx
@@ -172,7 +172,7 @@ langid_to_string( LANGID langid )
 CASE(sh, SERBIAN, SERBIAN_LATIN);
 CASE(sr, SERBIAN, SERBIAN_CYRILLIC);
 #undef CASE
-default: return "";
+default: return 0;
 }
 }
 }
@@ -183,14 +183,20 @@ langid_to_string( LANGID langid )
 static const char *ui_langs[MAX_LANGUAGES];
 static int num_ui_langs = 0;
 
+void add_ui_lang(char const * lang)
+{
+if (lang != 0 && num_ui_langs != SAL_N_ELEMENTS(ui_langs)) {
+ui_langs[num_ui_langs++] = lang;
+}
+}
+
 BOOL CALLBACK
 enum_ui_lang_proc (LPTSTR language, LONG_PTR /* unused_lParam */)
 {
 long langid = strtol(language, NULL, 16);
 if (langid > 0x)
 return TRUE;
-ui_langs[num_ui_langs] = langid_to_string((LANGID) langid);
-num_ui_langs++;
+add_ui_lang(langid_to_string((LANGID) langid));
 if (num_ui_langs == SAL_N_ELEMENTS(ui_langs) )
 return FALSE;
 return TRUE;
@@ -207,12 +213,13 @@ present_in_ui_langs(const char *lang)
 
 namespace {
 
-struct Dictionary {
+struct InstallLocalized {
 char lang[sizeof("xx_XX")];
 bool install;
 };
 
-void addMatchingDictionaries(char const * lang, Dictionary * dicts, int ndicts)
+void addMatchingDictionaries(
+char const * lang, InstallLocalized * dicts, int ndicts)
 {
 for (int i = 0; i != SAL_N_ELEMENTS(setup_native::languageDictionaries);
  ++i)
@@ -242,9 +249,9 @@ extern "C" UINT __stdcall SelectLanguage( MSIHANDLE handle )
 MSIHANDLE database, view, record;
 DWORD length;
 int nlangs = 0;
-char langs[MAX_LANGUAGES][6];
+InstallLocalized langs[MAX_LANGUAGES];
 int ndicts = 0;
-Dictionary dicts[MAX_LANGUAGES];
+InstallLocalized dicts[MAX_LANGUAGES];
 
 database = MsiGetActiveDatabase(handle);
 
@@ -269,11 +276,11 @@ extern "C" UINT __stdcall SelectLanguage( MSIHANDLE 
handle )
 return ERROR_SUCCESS;
 }
 
-/* Keep track of what languages are included in this installer, if
- * it is a multilanguage one.
+/* Keep track of what langpacks are included in this installer.
  */
-if (strcmp(feature, "gm_Langpack_r_en_US") != 0)
-strcpy(langs[nlangs++], feature + strlen("gm_Langpack_r_"));
+strcpy(langs[nlangs].lang, feature + strlen("gm_Langpack_r_"));
+langs[nlangs].install = false;
+++nlangs;
 
 MsiCloseHandle(record);
 }
@@ -315,92 +322,65 @@ extern "C" UINT __stdcall SelectLanguage( MSIHANDLE 
handle )
 MsiCloseHandle(view);
 }
 
-if (nlangs > 0) {
-int i;
-char* pVal = NULL;
-if ( (GetMsiProp( handle, "UI_LANGS", &pVal )) && pVal ) {
-/* user gave UI languages explicitely with UI_LANGS property */
-int sel_ui_lang = 0;
-strcpy(langs[nlangs++], "en_US");
-char *str_ptr;
-str_ptr = strtok(pVal, ",");
-for(; str_ptr != NULL ;) {
-ui_langs[num_ui_langs] = str_ptr;
-num_ui_langs++;
-str_ptr = strtok(NULL, ",");
-}
-for (i = 0; i < nlangs; i++) {
-if (!present_in_ui_langs(langs[i])) {
-UINT rc;
-sprintf(feature, "gm_Langpack_r_%s", langs[i]);
-rc = MsiSetFeatureStateA(handle, feature, 
INSTALLSTATE_ABSENT);
-}
-else {
-addMatchingDictionaries(langs[i], dicts, ndicts);
-   

[PATCH] Export image shadow effects to docx.

[Eilidh McAdam (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/709

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/709/1

Export image shadow effects to docx.

Change-Id: Ic8be107eeaeed286359869fd7e6712c3f740fba5
---
M sw/source/filter/ww8/docxattributeoutput.cxx
1 file changed, 32 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/709
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic8be107eeaeed286359869fd7e6712c3f740fba5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Eilidh McAdam 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED][REVIEW-3-6] fix for fdo#55022, crash when opening the test file in ScDBQueryDataIterator

[Noel Power]

On 26/09/12 23:34, Markus Mohrhard wrote:

Hey,

[1] fixes a crash when opening the test file. The problem is that we
dereference a past the end element. The code was always wrong but we
fixed another bug in this part of the code for 3-6 so that it now
crashes.

Regards,
Markus


found to be pushed, marking thread as such
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/source

[Libreoffice Gerrit user]

 vcl/source/app/help.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 6357857bbfb927f78bf22202d08ffd8440a25a6a
Author: Frank Schoenheit [fs] 
Date:   Tue Mar 8 12:26:55 2011 +0100

gridfixes: UpdateTip: need a Invalidate after setting the help text, to 
really show the (possibly) new text

diff --git a/vcl/source/app/help.cxx b/vcl/source/app/help.cxx
index 45e7721..9cb7a03 100644
--- a/vcl/source/app/help.cxx
+++ b/vcl/source/app/help.cxx
@@ -285,6 +285,7 @@ void Help::UpdateTip( sal_uIntPtr nId, Window* pParent, 
const Rectangle& rScreen
 pParent->OutputToScreenPixel( pParent->GetPointerPosPixel() ), 
&rScreenRect );
 
 pHelpWin->SetHelpText( rText );
+pHelpWin->Invalidate();
 }
 
 // ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] fdo#51304: Remove @author annotation

[Noel Power]

On 27/09/12 05:12, guilherme@gmail.com wrote:

From: Jose Guilherme Vanz 

This patch removes '@author' annotations and some unnecessary comments
in java sources


sorry doesn't seem to apply on current master, could you update please?

Noel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/unitymenus' - vcl/unx

[Libreoffice Gerrit user]

 vcl/unx/gtk/window/gloactiongroup.cxx |   17 +++--
 vcl/unx/gtk/window/gtksalmenu.cxx |4 +---
 2 files changed, 16 insertions(+), 5 deletions(-)

New commits:
commit dacd6fc042074a205c89e8fcf8ed482da9ac1483
Author: Antonio Fernandez 
Date:   Thu Sep 27 11:28:44 2012 +0100

All special items are now correctly displayed.

Change-Id: Ifce96d3e740a7ac89132dd23f9f51447e4372716

diff --git a/vcl/unx/gtk/window/gloactiongroup.cxx 
b/vcl/unx/gtk/window/gloactiongroup.cxx
index 37a2278..756779a 100644
--- a/vcl/unx/gtk/window/gloactiongroup.cxx
+++ b/vcl/unx/gtk/window/gloactiongroup.cxx
@@ -219,8 +219,15 @@ g_lo_action_group_change_state (GActionGroup *group,
 g_lo_action_group_perform_submenu_action (lo_group, 
action_name, value);
 else
 {
+gboolean is_new = FALSE;
+
+/* If action already exists but has no state, it should be 
removed and added again. */
 if (action->state_type == NULL)
+{
+g_action_group_action_removed (G_ACTION_GROUP (group), 
action_name);
 action->state_type = g_variant_type_copy 
(g_variant_get_type(value));
+is_new = TRUE;
+}
 
 if (g_variant_is_of_type (value, action->state_type) == TRUE)
 {
@@ -229,7 +236,10 @@ g_lo_action_group_change_state (GActionGroup *group,
 
 action->state = g_variant_ref (value);
 
-g_action_group_action_state_changed (group, action_name, 
value);
+if (is_new)
+g_action_group_action_added (G_ACTION_GROUP (group), 
action_name);
+else
+g_action_group_action_state_changed (group, 
action_name, value);
 }
 }
 }
@@ -241,13 +251,16 @@ g_lo_action_group_change_state (GActionGroup *group,
 static void
 g_lo_action_group_activate (GActionGroup *group,
 const gchar  *action_name,
-GVariant */*parameter */)
+GVariant *parameter)
 {
 GTK_YIELD_GRAB();
 
 GLOActionGroup *lo_group = G_LO_ACTION_GROUP (group);
 GtkSalFrame *pFrame = lo_group->priv->frame;
 
+if ( parameter != NULL )
+g_action_group_change_action_state( group, action_name, parameter );
+
 if ( pFrame != NULL )
 {
 GtkSalMenu* pSalMenu = static_cast< GtkSalMenu* >( pFrame->GetMenu() );
diff --git a/vcl/unx/gtk/window/gtksalmenu.cxx 
b/vcl/unx/gtk/window/gtksalmenu.cxx
index fa80ec4..1bfa247 100644
--- a/vcl/unx/gtk/window/gtksalmenu.cxx
+++ b/vcl/unx/gtk/window/gtksalmenu.cxx
@@ -321,9 +321,7 @@ static void NativeCheckItem( GLOMenu*pMenu,
 GVariant *pCurrentState = g_action_group_get_action_state( 
G_ACTION_GROUP( pActionGroup ), aCommand );
 
 if ( bits & MIB_RADIOCHECK )
-{
 pCheckValue = ( bCheck == TRUE ) ? g_variant_new_string( aCommand 
) : g_variant_new_string( "" );
-}
 else
 {
 // By default, all checked items are checkmark buttons.
@@ -334,7 +332,7 @@ static void NativeCheckItem( GLOMenu*pMenu,
 if ( pCheckValue != NULL && ( pCurrentState == NULL || 
g_variant_equal( pCurrentState, pCheckValue ) == FALSE ) )
 g_action_group_change_action_state( G_ACTION_GROUP( pActionGroup 
), aCommand, pCheckValue );
 
-if ( pCurrentState )
+if ( pCurrentState != NULL )
 g_variant_unref( pCurrentState );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: solenv/gbuild

[Libreoffice Gerrit user]

 solenv/gbuild/gbuild.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 35ce9c76c3ac768332998428e48ec839da709f4a
Author: Norbert Thiebaud 
Date:   Thu Sep 27 05:25:53 2012 -0500

bash is already a pre-req. and ubuntu /bin/sh is a borked variation of it

Change-Id: Ic3d9aee7d5ee50dfc3ffedc30d6a9c88260d7794

diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 0f11ea0..c7f8a83 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -48,7 +48,7 @@ GBUILDDIR:=$(SRCDIR)/solenv/gbuild
 
 .DELETE_ON_ERROR:
 
-SHELL := /bin/sh
+SHELL := /usr/bin/env bash
 true := T
 false :=
 define NEWLINE
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - translations/CustomTarget_translate.mk

[Libreoffice Gerrit user]

 translations/CustomTarget_translate.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f67bb60e49ac041a932770e11782842b3d5573e6
Author: Caolán McNamara 
Date:   Thu Sep 27 09:05:06 2012 +0100

add depend on uiex

diff --git a/translations/CustomTarget_translate.mk 
b/translations/CustomTarget_translate.mk
index 2e363cb..33d3d9c 100644
--- a/translations/CustomTarget_translate.mk
+++ b/translations/CustomTarget_translate.mk
@@ -78,7 +78,7 @@ $(translations_DIR)/sdf-l10n/qtz.sdf : \
$(if $(findstring s,$(MAKEFLAGS)),> /dev/null))
 
 $(translations_DIR)/sdf-template/en-US.sdf : $(OUTDIR_FOR_BUILD)/bin/propex \
-   $(foreach exec,cfgex helpex localize transex3 ulfex xrmex, \
+   $(foreach exec,cfgex helpex localize transex3 uiex ulfex xrmex, 
\
$(call gb_Executable_get_target_for_build,$(exec)))
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),LOC,1)
$(call gb_Helper_abbreviate_dirs, \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: desktop/Library_sofficeapp.mk sc/Library_sc.mk solenv/gbuild

[Libreoffice Gerrit user]

 desktop/Library_sofficeapp.mk |4 
 sc/Library_sc.mk  |4 
 solenv/gbuild/gbuild.mk   |4 
 3 files changed, 4 insertions(+), 8 deletions(-)

New commits:
commit 3e5c86705120ec5144db67104036f2fa5790be21
Author: Matúš Kukan 
Date:   Thu Sep 27 09:50:24 2012 +0200

tubes: fix glibc detected memory corruption in ScDocShell

ENABLE_TELEPATHY was used in docsh.hxx but not defined consistently.
Add global define to gbuild.

Change-Id: I9746297a0be0e01573e336d4ee237bcc14d2d47d

diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 607d751..9e4fa37 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -90,10 +90,6 @@ $(eval $(call gb_Library_add_exception_objects,sofficeapp,\
 
 ifeq ($(ENABLE_TELEPATHY),TRUE)
 $(eval $(call gb_Library_use_libraries,sofficeapp,tubes))
-
-$(eval $(call gb_Library_add_defs,sofficeapp,\
--DENABLE_TELEPATHY \
-))
 endif
 
 #
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 345c7b5..bbbab8f 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -49,10 +49,6 @@ $(eval $(call gb_Library_use_externals,sc,\
 ifeq ($(ENABLE_TELEPATHY),TRUE)
 $(eval $(call gb_Library_use_libraries,sc,tubes))
 
-$(eval $(call gb_Library_add_defs,sc,\
-   -DENABLE_TELEPATHY \
-))
-
 $(eval $(call gb_Library_add_exception_objects,sc,\
sc/source/ui/collab/sccollaboration \
sc/source/ui/collab/sendfunc \
diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index aeb59a8..0f11ea0 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -278,6 +278,10 @@ ifeq ($(HAVE_THREADSAFE_STATICS),TRUE)
 gb_GLOBALDEFS += -DHAVE_THREADSAFE_STATICS
 endif
 
+ifeq ($(ENABLE_TELEPATHY),TRUE)
+gb_GLOBALDEFS += -DENABLE_TELEPATHY
+endif
+
 gb_GLOBALDEFS := $(sort $(gb_GLOBALDEFS))
 
 include $(GBUILDDIR)/Deliver.mk
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: uninitialized member warnings ?

[Michael Meeks]

On Wed, 2012-09-26 at 15:29 +0200, Lubos Lunak wrote:
>  I don't think it can go anywhere practical:

:-) while it's certainly possibly to find cases where it is hard to
detect and warn about these problems, I imagine that catching many of
the banal cases and warning about those would be reasonably do-able -
while punting on the false positives.

> class A
> {
> bool foo;
> void init();
> public:
> A() { init(); }
> };
> 
>  How should the compiler know?

In this case; it should be clever ;-) we could defer the checking until
we compiled the init function: but of course, this soon gets pretty
intense cost-wise, and (absent LTO-scale visibility of all the code)
can't be perfect.

Warnings for constructors that don't call member functions, don't
initialise POD types, and/or don't pass references to them elsewhere
would surely be a useful if not complete win.

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] soltools conversion to gbuild

[Michael Stahl]

On 27/09/12 11:51, Stephan Bergmann wrote:
> On 09/27/2012 09:04 AM, David Ostrovsky wrote:
>> soltools/testhxx is *realy* a lovely one: testhxx.cxx file is empty and the
>> code generation and compilation take place in create.pl script.
>> I am going to nominate it for the "make file obfuscation" contest this year
>> ;-)
> 
> Would probably make more sense to have this functionality as some sort 
> of make target now, if we wanted to continue to have it.  (It was esp. 
> useful back when we made the code base warning-clean, to check that 
> exported headers where warning-clean before trying to make cxx files 
> warning-clean that included them.  But I at least don't mind if it goes 
> away.)

it's useful functionality, but surely that can be implemented without
resorting to use of perl and qualifying for a make file obfuscation
contest; kill it with fire i say!


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: setup_native/source

[Libreoffice Gerrit user]

 0 files changed

New commits:
commit d2aa4ebb7aebbf9f574a719f4b10ab53781aa533
Author: Stephan Bergmann 
Date:   Thu Sep 27 11:58:47 2012 +0200

Revert inadvertent chmod

Change-Id: I0b1865719da2e3c5a669b30a635c333721c9c41d

diff --git a/setup_native/source/win32/customactions/sellang/sellang.cxx 
b/setup_native/source/win32/customactions/sellang/sellang.cxx
old mode 100755
new mode 100644
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] soltools conversion to gbuild

[Stephan Bergmann]

On 09/27/2012 09:04 AM, David Ostrovsky wrote:

soltools/testhxx is *realy* a lovely one: testhxx.cxx file is empty and the
code generation and compilation take place in create.pl script.
I am going to nominate it for the "make file obfuscation" contest this year
;-)


Would probably make more sense to have this functionality as some sort 
of make target now, if we wanted to continue to have it.  (It was esp. 
useful back when we made the code base warning-clean, to check that 
exported headers where warning-clean before trying to make cxx files 
warning-clean that included them.  But I at least don't mind if it goes 
away.)


Stephan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/source

[Libreoffice Gerrit user]

 sw/source/core/unocore/unodraw.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f1c2c09439aed30dec6c1b4f26dc9f70ce4985f8
Author: Caolán McNamara 
Date:   Thu Sep 27 10:09:45 2012 +0100

WaE: uninit variable

Change-Id: I39d63b53fa400235d772cd2525695970081db91b

diff --git a/sw/source/core/unocore/unodraw.cxx 
b/sw/source/core/unocore/unodraw.cxx
index 8b141e4..8605b97 100644
--- a/sw/source/core/unocore/unodraw.cxx
+++ b/sw/source/core/unocore/unodraw.cxx
@@ -1273,7 +1273,7 @@ void SwXShape::setPropertyValue(const rtl::OUString& 
rPropertyName, const uno::A
 if(pSvxShape)
 {
 SdrObject* pObj = pSvxShape->GetSdrObject();
-sal_Int16 nPercent;
+sal_Int16 nPercent(100);
 aValue >>= nPercent;
 if ( pEntry->nMemberId == MID_FRMSIZE_REL_WIDTH )
 pObj->SetRelativeWidth( nPercent / 100.0 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PUSHED-3-6] fix for fdo#55022, crash when opening the test file in ScDBQueryDataIterator

[Michael Meeks]

Hi Markus,

On Thu, 2012-09-27 at 00:34 +0200, Markus Mohrhard wrote:
> [1] fixes a crash when opening the test file. The problem is that we
> dereference a past the end element. The code was always wrong but we
> fixed another bug in this part of the code for 3-6 so that it now
> crashes.

Amusing :-)

> [1] 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=70412d0f3f7979d3d069be8121d49dbb96775cce

Seems reasonable, but would:

@@ -564,7 +564,7 @@ bool 
ScDBQueryDataIterator::DataAccessInternal::getCurrent(Value& rValue)
 return false;
 
 SCROW nThisRow = ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, 
nTab, nCol, nColRow);
-while ( (nColRow < nCellCount) && (nThisRow < nRow) )
+while ( (nColRow < nCellCount - 1) && (nThisRow < nRow) )
 nThisRow = ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, 
nTab, nCol, ++nColRow);
 
 if ( nColRow < nCellCount && nThisRow <= mpParam->nRow2 )

Not have the same effect ? either way I cherry-picked as-is to -3-6.

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/dociter.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 541fbcd2fae54a7b8bce25873d4d1b4891c1c796
Author: Markus Mohrhard 
Date:   Wed Sep 26 20:01:20 2012 +0200

don't access out of bound array index, fdo#55022

Change-Id: Ica088822055b2fb5bbd6dabe6482b7cb6c472c48
Signed-off-by: Michael Meeks 

diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 92c7cbd..187a327 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -568,7 +568,11 @@ bool 
ScDBQueryDataIterator::DataAccessInternal::getCurrent(Value& rValue)
 
 SCROW nThisRow = ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, 
nTab, nCol, nColRow);
 while ( (nColRow < nCellCount) && (nThisRow < nRow) )
-nThisRow = ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, 
nTab, nCol, ++nColRow);
+{
+++nColRow;
+if(nColRow < nCellCount)
+nThisRow = 
ScDBQueryDataIterator::GetRowByColEntryIndex(*mpDoc, nTab, nCol, nColRow);
+}
 
 if ( nColRow < nCellCount && nThisRow <= mpParam->nRow2 )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - accessibility/source sfx2/source

[Libreoffice Gerrit user]

 accessibility/source/standard/vclxaccessibleedit.cxx |6 --
 sfx2/source/dialog/dinfdlg.cxx   |4 +---
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit d6279f57e0a61aa5ab9b15a631cb3f76bc072245
Author: Caolán McNamara 
Date:   Wed Sep 26 20:45:38 2012 +0100

useless sTEST and side-effect-less methd call

Change-Id: I0b3fd9f951c286fbd6be7d9e5b404d37b7573a68

diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 79feb0c..ee59b5e 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -2311,8 +2311,6 @@ CustomPropertiesControl::CustomPropertiesControl( Window* 
pParent, const ResId&
 
 FreeResource();
 
-XubString sTEST = m_aHeaderBar.GetItemText( HI_NAME );
-
 m_aPropertiesWin.InitControls( &m_aHeaderBar, &m_aVertScroll );
 m_aPropertiesWin.SetRemovedHdl( LINK( this, CustomPropertiesControl, 
RemovedHdl ) );
 
commit d3788f3276c55c9996fb4ed83cebe7e30519ce2f
Author: Caolán McNamara 
Date:   Wed Sep 26 20:44:58 2012 +0100

UniString::Fill->padToLength(OUStringBuffer

Change-Id: I61a562982af75fd3141b4b5d55840c0ebc94306c

diff --git a/accessibility/source/standard/vclxaccessibleedit.cxx 
b/accessibility/source/standard/vclxaccessibleedit.cxx
index 2fb078a..95fda2b 100644
--- a/accessibility/source/standard/vclxaccessibleedit.cxx
+++ b/accessibility/source/standard/vclxaccessibleedit.cxx
@@ -41,6 +41,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -154,8 +155,9 @@ OUString VCLXAccessibleEdit::implGetText()
 xub_Unicode cEchoChar = pEdit->GetEchoChar();
 if ( !cEchoChar )
 cEchoChar = '*';
-XubString sTmp;
-aText = sTmp.Fill( (sal_uInt16)aText.getLength(), cEchoChar );
+OUStringBuffer sTmp;
+aText = comphelper::string::padToLength(sTmp, aText.getLength(),
+cEchoChar).makeStringAndClear();
 }
 }
 
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 78dbfe3..79feb0c 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -884,7 +884,7 @@ IMPL_LINK_NOARG(SfxDocumentPage, DeleteHdl)
 now.Get100Sec(), now.GetSec(), now.GetMin(), now.GetHour(),
 now.GetDay(), now.GetMonth(), now.GetYear() );
 aCreateValFt.SetText( ConvertDateTime_Impl( aName, uDT, aLocaleWrapper ) );
-XubString aEmpty;
+OUString aEmpty;
 aChangeValFt.SetText( aEmpty );
 aPrintValFt.SetText( aEmpty );
 const Time aTime( 0 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||55379

--- Comment #127 from Rainer Bielefeld  ---
Add "Bug 55379 - FILEOPEN CRASH for particular .ods", at least for me with
3.6.2 loss of access to hundreds of documents.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

[Libreoffice Gerrit user]

 vcl/inc/vcl/builder.hxx  |   28 ++-
 vcl/inc/vcl/layout.hxx   |   28 ++-
 vcl/source/uipreviewer/previewer.cxx |   27 ++
 vcl/source/window/builder.cxx|   65 ++-
 vcl/source/window/layout.cxx |   27 ++
 vcl/source/window/window.cxx |4 +-
 6 files changed, 47 insertions(+), 132 deletions(-)

New commits:
commit 16daab13a0c4a25e9b6fe14fa53c2d0634828219
Author: Caolán McNamara 
Date:   Thu Sep 27 09:38:41 2012 +0100

sort child positions within parents according to grid position

so that tabbing between widgets jumps between then in a sensible
order

Change-Id: I852f4fb08781da2b703f8f87e84abdf4c366fa26

diff --git a/vcl/inc/vcl/builder.hxx b/vcl/inc/vcl/builder.hxx
index bd5cd6e..a84f6d1 100644
--- a/vcl/inc/vcl/builder.hxx
+++ b/vcl/inc/vcl/builder.hxx
@@ -1,30 +1,12 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
- * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ * This file is part of the LibreOffice project.
  *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the specific language governing rights and limitations under the
- * License.
- *
- * The Initial Developer of the Original Code is
- *Caolán McNamara  (Red Hat, Inc.)
- * Portions created by the Initial Developer are Copyright (C) 2011 the
- * Initial Developer. All Rights Reserved.
- *
- * Contributor(s): Caolán McNamara 
- *
- * Alternatively, the contents of this file may be used under the terms of
- * either the GNU General Public License Version 3 or later (the "GPLv3+"), or
- * the GNU Lesser General Public License Version 3 or later (the "LGPLv3+"),
- * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
- * instead of those above.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
+
 #ifndef _VCLBUILDER_HXX
 #define _VCLBUILDER_HXX
 
diff --git a/vcl/inc/vcl/layout.hxx b/vcl/inc/vcl/layout.hxx
index 4735528..9e869a3 100644
--- a/vcl/inc/vcl/layout.hxx
+++ b/vcl/inc/vcl/layout.hxx
@@ -1,30 +1,12 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
- * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ * This file is part of the LibreOffice project.
  *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the specific language governing rights and limitations under the
- * License.
- *
- * The Initial Developer of the Original Code is
- *Caolán McNamara  (Red Hat, Inc.)
- * Portions created by the Initial Developer are Copyright (C) 2011 the
- * Initial Developer. All Rights Reserved.
- *
- * Contributor(s): Caolán McNamara 
- *
- * Alternatively, the contents of this file may be used under the terms of
- * either the GNU General Public License Version 3 or later (the "GPLv3+"), or
- * the GNU Lesser General Public License Version 3 or later (the "LGPLv3+"),
- * in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
- * instead of those above.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
+
 #ifndef _VCLLAYOUT_HXX
 #define _VCLLAYOUT_HXX
 
diff --git a/vcl/source/uipreviewer/previewer.cxx 
b/vcl/source/uipreviewer/previewer.cxx
index 42c0353..2432986 100644
--- a/vcl/source/uipreviewer/previewer.cxx
+++ b/vcl/source/uipreviewer/previewer.cxx
@@ -1,29 +1,10 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
- * Version: MPL 1.1 / GPLv3+ / LGPLv3+
+ * This file is part of the LibreOffice project.
  *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the spec

[Libreoffice-commits] .: writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   20 
 1 file changed, 20 deletions(-)

New commits:
commit 1278b084be1b128cd4d85473df0b0f62de16bf25
Author: Miklos Vajna 
Date:   Thu Sep 27 10:34:24 2012 +0200

writerfilter: unused includes in DomainMapper_Impl

Change-Id: I6df840e20da98918a8f1531e8d77a5b5c53101fb

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index d9dee50..d4f4b85 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -22,30 +22,21 @@
 #include 
 #include 
 #include 
-#include 
 #include 
-#include 
 #include 
 #include 
 #include 
-#include 
-#include 
 #include 
 #include 
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -56,24 +47,13 @@
 #include 
 #include 
 #include 
-#include 
-#include 
-#include 
 #include 
-#include 
 #include 
-#include 
 #include 
-#include 
-#include 
 #include 
 #include 
-#include 
-#include 
-#include "FieldTypes.hxx"
 #include 
 
-#include 
 #ifdef DEBUG_DOMAINMAPPER
 #include 
 #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - basctl/source cui/source desktop/source extensions/source filter/source offapi/com offapi/UnoApi_offapi.mk sfx2/source ucb/source

[Libreoffice Gerrit user]

 basctl/source/basicide/doceventnotifier.cxx   |8 -
 cui/source/customize/eventdlg.cxx |   23 ++---
 desktop/source/app/app.cxx|   13 +--
 extensions/source/update/ui/updatecheckui.cxx |   12 --
 filter/source/config/cache/filtercache.cxx|2 
 filter/source/config/cache/lateinitlistener.cxx   |7 -
 filter/source/config/cache/lateinitlistener.hxx   |   10 --
 filter/source/xsltdialog/xmlfiltertestdialog.cxx  |   38 -
 offapi/UnoApi_offapi.mk   |3 
 offapi/com/sun/star/frame/GlobalEventBroadcaster.idl  |   17 
 offapi/com/sun/star/frame/XGlobalEventBroadcaster.idl |   56 +
 sfx2/source/appl/appinit.cxx  |   15 +--
 sfx2/source/config/evntconf.cxx   |5 -
 sfx2/source/doc/objstor.cxx   |   23 ++---
 sfx2/source/inc/eventsupplier.hxx |   13 +--
 ucb/source/ucp/tdoc/tdoc_docmgr.cxx   |   75 +++---
 ucb/source/ucp/tdoc/tdoc_docmgr.hxx   |   14 ---
 ucb/source/ucp/tdoc/tdoc_provider.cxx |3 
 18 files changed, 151 insertions(+), 186 deletions(-)

New commits:
commit 272f0e97b12e634cdf49a1bff45e1b9068af7d9c
Author: Stephan Bergmann 
Date:   Thu Sep 27 10:19:04 2012 +0200

Improvements on previous commit

* Made XGlobalEventBroadcaster inherit document::XDocumentEventBroadcaster/
  Listener replacements for obsolete document::XEventBroadcaster/Listener.  
This
  means some client sides unfortunately still need to use UNO_QUERY_THROW to
  obtain the obsolete interfaces; those client sides should be cleaned up 
to use
  the replacement interfaces instead.

* Added @since tag (even to unpublished entities, on "it doesn't hurt" 
grounds).

* Made client sides use XGlobalEventBroadcaster directly instead of 
querying for
  its super-interfaces.

* Replaced new uses of comphelper::ComponentContext::getUNOContext with
  comphelper::getComponentContext (see 
03a9f139bd9ea1a4f9096fc982e6b326def58532
  "ComponentContext::getUnoContext -> getComponentContext simplification;" I
  intend to get rid of comphelper/componentcontext.hxx much sooner than of
  comphelper/processfactory.hxx).

Change-Id: I6d971ebdaea83d0c3fa9ba299fb6b37e58cdfe9b

diff --git a/cui/source/customize/eventdlg.cxx 
b/cui/source/customize/eventdlg.cxx
index 55381f5..8cd495f 100644
--- a/cui/source/customize/eventdlg.cxx
+++ b/cui/source/customize/eventdlg.cxx
@@ -89,11 +89,10 @@ SvxEventConfigPage::SvxEventConfigPage( Window *pParent, 
const SfxItemSet& rSet,
 aSaveInListBox.SetSelectHdl( LINK( this, SvxEventConfigPage,
 SelectHdl_Impl ) );
 
-uno::Reference< document::XEventsSupplier > xSupplier;
+uno::Reference< frame::XGlobalEventBroadcaster > xSupplier;
 
-xSupplier = uno::Reference< document::XEventsSupplier > (
-
frame::GlobalEventBroadcaster::create(::comphelper::getProcessComponentContext()),
-uno::UNO_QUERY_THROW );
+xSupplier =
+
frame::GlobalEventBroadcaster::create(::comphelper::getProcessComponentContext());
 
 sal_uInt16 nPos(0);
 m_xAppEvents = xSupplier->getEvents();
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 378d188..4741ce6 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1532,7 +1532,7 @@ int Desktop::Main()
 
 // create service for loadin SFX (still needed in startup)
 pExecGlobals->xGlobalBroadcaster = Reference < 
css::document::XEventListener >
-( 
css::frame::GlobalEventBroadcaster::create(comphelper::ComponentContext(xSMgr).getUNOContext()),
 UNO_QUERY );
+( 
css::frame::GlobalEventBroadcaster::create(comphelper::getComponentContext(xSMgr)),
 UNO_QUERY_THROW );
 
 /* ensure existance of a default window that messages can be 
dispatched to
This is for the benefit of testtool which uses PostUserEvent 
extensively
@@ -1567,12 +1567,9 @@ int Desktop::Main()
 // keep a language options instance...
 pExecGlobals->pLanguageOptions.reset( new 
SvtLanguageOptions(sal_True));
 
-if (pExecGlobals->xGlobalBroadcaster.is())
-{
-css::document::EventObject aEvent;
-aEvent.EventName = ::rtl::OUString("OnStartApp");
-pExecGlobals->xGlobalBroadcaster->notifyEvent(aEvent);
-}
+css::document::EventObject aEvent;
+aEvent.EventName = ::rtl::OUString("OnStartApp");
+pExecGlobals->xGlobalBroadcaster->notifyEvent(aEvent);
 
 SetSplashScreenProgress(50);
 
diff --git a/filter/source/config/cache/filtercache.cxx 
b/filter/source/config/cache/filtercache.cxx
index b7c3474..764c085 100644
--- a/filter/source/config/cache/filtercache.cxx
+++ b/filter/source/config/cache/filtercache.cxx
@@ -

Re: Efforts to document LO build system

[Michael Meeks]

Hi David,

On Thu, 2012-09-27 at 09:18 +0200, David Ostrovsky wrote:
> FYI: i just added new wiki page:
> https://wiki.documentfoundation.org/Development/Build_System
> 
> I am going to add there more inforamtion (and some diagrams).
> Many thanks to David Tardon for help!

Nice :-)

> The target is: after reading this page, every one should not only
> understand LO build process itself, but be able to explain it to
> his wife (or husband)

A shorter, more hacker-targetted summary that can go into:
solenv/README - might be good too ;-)

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/qa writerfilter/source

[Libreoffice Gerrit user]

 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |2 +-
 writerfilter/source/dmapper/DomainMapper.cxx |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 526e007bb6340e2c4a2cb96f5612ba268fcd5583
Author: Miklos Vajna 
Date:   Thu Sep 27 09:37:36 2012 +0200

n#781825 fix DOCX import of bottom para margin autospacing

If w:doNotUseHTMLParagraphAutoSpacing is enabled, it should be 100, not
200, see SwWW8ImplReader::GetParagraphAutoSpace().

Change-Id: I29c5e97c828f0f55b655410198bfa03dc42a196d

diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 5214b49..1cefa39 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -841,7 +841,7 @@ void Test::testN778140()
 load("n778140.docx");
 
 CPPUNIT_ASSERT_EQUAL(sal_Int32(176), 
getProperty(getParagraph(0), "ParaTopMargin"));
-CPPUNIT_ASSERT_EQUAL(sal_Int32(353), 
getProperty(getParagraph(0), "ParaBottomMargin"));
+CPPUNIT_ASSERT_EQUAL(sal_Int32(176), 
getProperty(getParagraph(0), "ParaBottomMargin"));
 }
 
 void Test::testN778828()
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 9bcccf3..52d8c1a 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1166,7 +1166,7 @@ void DomainMapper::lcl_attribute(Id nName, Value & val)
 if 
(!m_pImpl->GetSettingsTable()->GetDoNotUseHTMLParagraphAutoSpacing())
 m_pImpl->GetTopContext()->Insert( PROP_PARA_BOTTOM_MARGIN, 
false, uno::makeAny( AUTO_PARA_SPACING ) );
 else
-m_pImpl->GetTopContext()->Insert( PROP_PARA_BOTTOM_MARGIN, 
false, uno::makeAny( ConversionHelper::convertTwipToMM100(200) ) );
+m_pImpl->GetTopContext()->Insert( PROP_PARA_BOTTOM_MARGIN, 
false, uno::makeAny( ConversionHelper::convertTwipToMM100(100) ) );
 break;
 case NS_ooxml::LN_CT_SmartTagRun_uri:
 case NS_ooxml::LN_CT_SmartTagRun_element:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Efforts to document LO build system

[Matúš Kukan]

Hi David,

On 27 September 2012 09:18, David Ostrovsky  wrote:
> Hi,
>
> FYI: i just added new wiki page:
> https://wiki.documentfoundation.org/Development/Build_System
>
> I am going to add there more inforamtion (and some diagrams).
> Many thanks to David Tardon for help!

Just to know: There is also something in
https://wiki.documentfoundation.org/Development/buildsystemtargets

> The target is: after reading this page, every one should not only
> understand LO build process itself,
> but be able to explain it to his wife (or husband)
> ;-)

Looking forward to it :-)

Thanks,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - apache-commons/ExternalProject_apache_commons_codec.mk apache-commons/ExternalProject_apache_commons_httpclient.mk apache-commons/ExternalProject_apache_commons_la

[Libreoffice Gerrit user]

 Makefile.top|2 
 apache-commons/ExternalProject_apache_commons_codec.mk  |   37 +
 apache-commons/ExternalProject_apache_commons_httpclient.mk |   42 ++
 apache-commons/ExternalProject_apache_commons_lang.mk   |   37 +
 apache-commons/ExternalProject_apache_commons_logging.mk|   41 ++
 apache-commons/Makefile |7 +
 apache-commons/Module_apache_commons.mk |   32 
 apache-commons/Package_apache_commons_codec.mk  |   16 ++
 apache-commons/Package_apache_commons_httpclient.mk |   16 ++
 apache-commons/Package_apache_commons_lang.mk   |   16 ++
 apache-commons/Package_apache_commons_logging.mk|   16 ++
 apache-commons/UnpackedTarball_apache_commons_codec.mk  |   18 ++
 apache-commons/UnpackedTarball_apache_commons_httpclient.mk |   14 ++
 apache-commons/UnpackedTarball_apache_commons_lang.mk   |   14 ++
 apache-commons/UnpackedTarball_apache_commons_logging.mk|   22 +++
 apache-commons/java/codec/makefile.mk   |   75 ---
 apache-commons/java/httpclient/makefile.mk  |   78 ---
 apache-commons/java/lang/makefile.mk|   75 ---
 apache-commons/java/logging/makefile.mk |   81 
 apache-commons/prj/build.lst|7 -
 apache-commons/prj/d.lst|5 
 config_host.mk.in   |4 
 configure.in|8 +
 ooo.lst.in  |9 -
 solenv/gbuild/ExternalProject.mk|6 
 25 files changed, 353 insertions(+), 325 deletions(-)

New commits:
commit 6d64bfd8c0086a9d3e8a05ecf49b1af84ec58436
Author: Norbert Thiebaud 
Date:   Thu Sep 27 02:31:15 2012 -0500

gbuildification of appache_commons

Change-Id: I517c808c9ea799aac0d2cd2b3bb6c18564c76823

diff --git a/Makefile.top b/Makefile.top
index da83b1b..642ec00 100644
--- a/Makefile.top
+++ b/Makefile.top
@@ -35,6 +35,7 @@ accessibility\
 afms\
 android\
 animations\
+apache-commons\
 apple_remote\
 autodoc\
 avmedia\
@@ -192,7 +193,6 @@ xmlsecurity\
 xsltml\
 
 dmake_modules:=\
-apache-commons\
 beanshell\
 berkeleydb\
 binfilter \
diff --git a/apache-commons/ExternalProject_apache_commons_codec.mk 
b/apache-commons/ExternalProject_apache_commons_codec.mk
new file mode 100644
index 000..7e07d39
--- /dev/null
+++ b/apache-commons/ExternalProject_apache_commons_codec.mk
@@ -0,0 +1,37 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# for RSCREVISION
+include $(SOLARENV)/inc/minor.mk
+
+$(eval $(call gb_ExternalProject_ExternalProject,apache_commons_codec))
+
+$(eval $(call 
gb_ExternalProject_use_unpacked,apache_commons_codec,apache_commons_codec))
+
+$(eval $(call gb_ExternalProject_register_targets,apache_commons_codec,\
+   build \
+))
+
+$(call gb_ExternalProject_get_state_target,apache_commons_codec,build) :
+   cd "$(call gb_UnpackedTarball_get_dir,apache_commons_codec)" && \
+   ANT_OPTS+="-Dfile.encoding=ISO-8859-1" \
+   "$(ANT)" \
+   -q \
+   -f build.xml \
+   -Dbuild.label="build-$(RSCREVISION)" \
+   $(if $(filter yes,$(JAVACISGCJ))\
+   ,-Dbuild.compiler=gcj \
+   ,-Dant.build.javac.source=$(JAVA_SOURCE_VER) \
+   -Dant.build.javac.target=$(JAVA_TARGET_VER) \
+   ) \
+   $(if $(debug),-Dbuild.debug="on") \
+   jar && \
+   touch $@
+
+# vim: set noet sw=4 ts=4:
diff --git a/apache-commons/ExternalProject_apache_commons_httpclient.mk 
b/apache-commons/ExternalProject_apache_commons_httpclient.mk
new file mode 100644
index 000..e1a55bd
--- /dev/null
+++ b/apache-commons/ExternalProject_apache_commons_httpclient.mk
@@ -0,0 +1,42 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+# for RSCREVISION
+include $(SOLARENV)/inc/minor.mk
+
+$(eval $(call gb_ExternalProject_ExternalProject,apache_commons_httpclient))
+
+$(eval $(call 
gb_ExternalProject_use_unpacked,apache_commons_codec,apache_commons_httpclient))
+
+$(eval $(call 
gb_ExternalProject_use_external,apache_commons_httpclient,apache_commons_co

[Libreoffice-commits] Changes to 'apache-common'

[Libreoffice Gerrit user]

New branch 'apache-common' available with the following commits:
commit 6d64bfd8c0086a9d3e8a05ecf49b1af84ec58436
Author: Norbert Thiebaud 
Date:   Thu Sep 27 02:31:15 2012 -0500

gbuildification of appache_commons

Change-Id: I517c808c9ea799aac0d2cd2b3bb6c18564c76823

commit ee22be5d7f1e9077c139a9ca18cdb9e0ec75a766
Author: Norbert Thiebaud 
Date:   Thu Sep 27 02:30:56 2012 -0500

add gb_ExternalProject_use_external to deal with ExternalProject inter-dep

One may have multiple ExternalProject in a given module
and these ExternalProject may have dependencies among each others
This api allow to explicit such dependencies so that the
ExternalProjects in a given module are built in the right order

Change-Id: Ib8a1b9bdcad0dda08b6fe133113b01a80e02421c

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - oox/inc oox/source svx/inc svx/source sw/inc sw/qa sw/source

[Libreoffice Gerrit user]

 oox/inc/oox/vml/vmlshape.hxx |6 +++
 oox/source/token/properties.txt  |4 ++
 oox/source/vml/vmlshape.cxx  |   54 ++-
 oox/source/vml/vmlshapecontext.cxx   |6 +++
 svx/inc/svx/svdoashp.hxx |2 -
 svx/inc/svx/svdobj.hxx   |9 
 svx/inc/svx/svdogrp.hxx  |2 -
 svx/inc/svx/svdovirt.hxx |2 -
 svx/source/svdraw/svdoashp.cxx   |4 +-
 svx/source/svdraw/svdobj.cxx |7 +++
 svx/source/svdraw/svdogrp.cxx|6 +--
 svx/source/svdraw/svdovirt.cxx   |4 +-
 sw/inc/dcontact.hxx  |2 -
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |   22 ++-
 sw/source/core/draw/dcontact.cxx |4 +-
 sw/source/core/draw/dflyobj.cxx  |2 -
 sw/source/core/inc/dflyobj.hxx   |2 -
 sw/source/core/layout/anchoreddrawobject.cxx |   23 +++
 sw/source/core/unocore/unodraw.cxx   |   16 
 sw/source/core/unocore/unomap.cxx|2 +
 20 files changed, 152 insertions(+), 27 deletions(-)

New commits:
commit d4474dd0411d7de29ce42e181c97cbf032bf57ea
Author: Cédric Bosdonnat 
Date:   Wed Sep 26 13:10:31 2012 +0200

sw: implement page-relative size for drawing objects and import them from 
docx

Change-Id: I98b5c53d4860278e3646324ca045114e37b4cf61

diff --git a/oox/inc/oox/vml/vmlshape.hxx b/oox/inc/oox/vml/vmlshape.hxx
index 385f9ea..c7f288d 100644
--- a/oox/inc/oox/vml/vmlshape.hxx
+++ b/oox/inc/oox/vml/vmlshape.hxx
@@ -74,6 +74,10 @@ struct ShapeTypeModel
 ::rtl::OUString maPositionVerticalRelative; ///< The Y position is 
relative to this.
 ::rtl::OUString maPositionHorizontal;   ///< The X position 
orientation (default: absolute).
 ::rtl::OUString maPositionVertical; ///< The Y position 
orientation.
+::rtl::OUString maWidthPercent; ///< The width in percents of 
the WidthRelative
+::rtl::OUString maHeightPercent;///< The height in percents of 
the HeightRelative
+::rtl::OUString maWidthRelative;///< To what the width is 
relative
+::rtl::OUString maHeightRelative;   ///< To what the height is 
relative
 ::rtl::OUString maRotation; ///< Rotation of the shape, in 
degrees.
 ::rtl::OUString maFlip; ///< Flip type of the shape 
(can be "x" or "y").
 sal_BoolmbAutoHeight;   ///< If true, the height value 
is a minimum value (mostly used for textboxes)
diff --git a/oox/source/token/properties.txt b/oox/source/token/properties.txt
index ff4e47b..c925d1f 100644
--- a/oox/source/token/properties.txt
+++ b/oox/source/token/properties.txt
@@ -374,9 +374,11 @@ ReferenceSheet
 RefreshPeriod
 RegularExpressions
 RelId
+RelativeHeight
 RelativeHorizontalTabbarWidth
 RelativePosition
 RelativeSize
+RelativeWidth
 Repeat
 RepeatDelay
 Representation
diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx
index 7d8d166..7773d8a 100644
--- a/oox/source/vml/vmlshape.cxx
+++ b/oox/source/vml/vmlshape.cxx
@@ -450,6 +450,32 @@ Reference< XShape > SimpleShape::implConvertAndInsert( 
const Reference< XShapes
 PropertySet( xShape ).setAnyProperty( PROP_FrameIsAutomaticHeight, 
makeAny( maTypeModel.mbAutoHeight ) );
 PropertySet( xShape ).setAnyProperty( PROP_SizeType, makeAny( 
maTypeModel.mbAutoHeight ? SizeType::MIN : SizeType::FIX ) );
 }
+else
+{
+// FIXME Setting the relative width/heigh only for everything but text 
frames as
+// TextFrames already have relative widht/heigh feature... but 
currently not working
+// in the way we need.
+
+// Set the relative width / height if any
+if ( !maTypeModel.maWidthPercent.isEmpty( ) )
+{
+// Only page-relative width is supported ATM
+if ( maTypeModel.maWidthRelative.isEmpty() || 
maTypeModel.maWidthRelative == "page" )
+{
+sal_Int16 nWidth = maTypeModel.maWidthPercent.toInt32() / 10;
+PropertySet( xShape ).setAnyProperty(PROP_RelativeWidth, 
makeAny( nWidth ) );
+}
+}
+if ( !maTypeModel.maHeightPercent.isEmpty( ) )
+{
+// Only page-relative height is supported ATM
+if ( maTypeModel.maHeightRelative.isEmpty() || 
maTypeModel.maHeightRelative == "page" )
+{
+sal_Int16 nHeight = maTypeModel.maHeightPercent.toInt32() / 10;
+PropertySet( xShape ).setAnyProperty(PROP_RelativeHeight, 
makeAny( nHeight ) );
+}
+}
+}
 
 // Import Legacy Fragments (if any)
 if( xShape.is() && !maShapeModel.maLegacyDiagramPath.isEmpty() )
diff --git a/oox/source/vml/vmlshapecontext.cxx 
b/oox/source/vml/vmlshapecontext.cxx
index 01543c3..3

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

--- Comment #126 from Michael Pappas  ---
Nominating bug# 54862: Broken formatting for .DOC files after some on some
libreoffice version > 3.5.2 (found on 3.6.1.2)

Affects installations where documents are stored in Word format.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Efforts to document LO build system

[David Ostrovsky]

Hi,

FYI: i just added new wiki page:
https://wiki.documentfoundation.org/Development/Build_System

I am going to add there more inforamtion (and some diagrams).
Many thanks to David Tardon for help!

The target is: after reading this page, every one should not only
understand LO build process itself,
but be able to explain it to his wife (or husband)
;-)

To achieve that, your help is highly appreciated.

Regards
David
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 54157] LibreOffice 3.7 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=54157

Roman Eisele  changed:

   What|Removed |Added

 Depends on||55350

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 54157] LibreOffice 3.7 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=54157

--- Comment #11 from Roman Eisele  ---
Adding bug 55350 - “Letter spacing and ‘expand single word’ do not work
anymore”.

Not the most terrible bug in the world, but a blameful regression, which would
make MS and AOO folks laugh at us and our users angry with us, introduced
between 2012-09-20 and 2012-09-24.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] soltools conversion to gbuild

[David Ostrovsky]

Hi,

i submitted gerrit patch that convert soltools to gbuild:
https://gerrit.libreoffice.org/#/c/698

The follow tools considered to be obsolete and are discontinued:
ldump,giparser,support and testhxx.

Are there any objections to that?

soltools/testhxx is *realy* a lovely one: testhxx.cxx file is empty and the
code generation and compilation take place in create.pl script.
I am going to nominate it for the "make file obfuscation" contest this year
;-)

Regards
David
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice