Re: fdo#51004: some progress and 10 years old bug pending
Am 15.10.2012 09:50, schrieb Lionel Elie Mamane: done:https://gerrit.libreoffice.org/#/c/841/ Hey, great! Next time I feel the need to scratch the unit test itch, I'll certainly take inspiration from that. Actually it might be easy to create a comlete cpp unit test for a file based database driver: 1. create a data source and bind it to a file 2. execute some DDLs 3. execute some DMLs 4. check expected results 5. destroy datasource and file. Do we have a programmatic way for creating data sources? If not how about to add it? It seems to do more than introduce the unit test, and also introduce the feature that one can now access several tables, while before one could access only one, namely AddressBook? yepp. The only missing features compared to old mozab driver are missing regular expression implementation in where criterion and handling of history.mab file (all gathered addresses). I wasn't sure what would be the best way to differentiate between test and production case, so i abused driver url... It would be nice if someone could review it. Rather than special-case the test case, how about extend the production case so that it can be directed to an arbitrary file? sounds reasonable. With that in place LO would have even more features as the thunderbird itself ;-) At least I am not aware how you can open backup address book in thunderbird? Only thing that worked for me is to replace the deafult one from the user profile. But take into considreation that on windows old mozab driver still used. So if we are going to extend the databse creation UI and introduce new path input field it should also work for old mozab driver (unless we sort that platform out). So that, for example: sdbc:address:thunderbird would get the abook.mab from the default profile, but sdbc:address:thunderbird:/home/user/backup/blah.mab would open file /home/user/backup/blah.mab This would be useful to open .mab files that come from backups, that are copied from other computers or other users, etc. Actually, I can see another specific case, which is to access other profiles than the default. It would be nice not to hard-code the full path there, so maybe something like sdbc:address:thunderbird:profile:FOO to open the profile called FOO in profiles.ini? In connectivity/source/drivers/mork/MConnection.cxx, I see: OUString defaultProfile = m_pProfileAccess-getDefaultProfile(::com::sun::star::mozilla::MozillaProductType_Thunderbird); Not sure what object m_pProfileAccess is, but if it has something like a method getNamedProfile(::com::sun::star::mozilla::MozillaProductType_Thunderbird, FOO) we should be in business? So maybe change the file path case to sdbc:address:thunderbird:file:/home/user/backup/blah.mab for more clarity? Interesting point, but how one should extend the profile? Ideas? Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to build on Windows, multiple target patterns
Hi, Am 16.10.2012 07:57, schrieb Noel Grandin: On 2012-10-15 20:40, Jeremy Brown wrote: #1 My current problem is that I run make and it runs for a while and then dies in tail_build with an error like this: D:/Dev/libo/libo/workdir/wntmsci12.pro/Dep/LinkTarget/Library/iacc.lib.d:948: *** multiple target patterns. Stop. You need the LO-specific gmake. http://wiki.documentfoundation.org/Development/Windows_Build_Dependencies $ which make /opt/lo/bin/make $ make -version GNU Make 3.82 [...] LibreOffice patched version and still: $ make verbose=true tail_build make -r -f /cygdrive/c/libo/Makefile.top tail_build make[1]: Entering directory `/cygdrive/c/libo' cd tail_build /opt/lo/bin/make -j 2 -r gb_PARTIALBUILD=T make[2]: Entering directory `/cygdrive/c/libo/tail_build' C:/libo/workdir/wntmsci12.pro/Dep/LinkTarget/Library/ivcl.lib.d:217: *** multiple target patterns. Stop. make[2]: Leaving directory `/cygdrive/c/libo/tail_build' make[1]: *** [tail_build] Error 2 make[1]: Leaving directory `/cygdrive/c/libo' make: *** [tail_build] Error 2 Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to build on Windows, multiple target patterns
On 15 October 2012 20:40, Jeremy Brown jeremy.r.br...@gmail.com wrote: #1 My current problem is that I run make and it runs for a while and then dies in tail_build with an error like this: D:/Dev/libo/libo/workdir/wntmsci12.pro/Dep/LinkTarget/Library/iacc.lib.d:948: *** multiple target patterns. Stop. Oh, this one is probably new, related to changes in solenv/bin/concat-deps.c : http://cgit.freedesktop.org/libreoffice/core/commit/?id=140281898f21f707582f395918e5234bdb67e435 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d0bf1510632801e15f1f498320c90efb6d773d6e What is in D:/Dev/libo/libo/workdir/wntmsci12.pro/Dep/LinkTarget/Library/iacc.lib.d ? Tinderboxes do not suffer because they use --disable-dependency-tracking You can use it if you do not intend to do incremental re-builds later. If you add it to autogen.lastrun, also remove workdir/*/Dep #2 Another question: I'm looking at Tinderbox, and if I'm trying to tell when a good time to build is, which Windows column should I be looking W2008R2_16-minimal_build and Win-x86_6. if Win-x86_6 fails in smoketest, that's fine, you'll be able to build. at? Also, is there any way to find out what build options (e.g. in autogen.lastrun) those builds are using, so I could try to copy them? in full log, search for: 'running ./configure with' #3 or this line: error CS1548: Cryptographic failure while signing assembly 'd:\Dev\libo\libo\workdir\wntmsci12.pro\CliLibraryTarget\cli_basetypes.dll' -- 'Error reading key file 'D:\\Dev\\libo\\libo\\solver\\wntmsci12.pro\\bin\\cliuno.snk' -- The system cannot find the file specified. ' This is bad, missing dependency, but it may disappear on next make, or make cli_ure HTH, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Docx, Odt to Text
Hi Karthik, On Tue, 2012-10-16 at 10:46 +0530, Karthik Raj wrote: Can someone tell me in which part of the source code does the conversion from docx and odt to text file takes place ( save as text ) ? I need to know how the conversion occurs. Your question sounds like containing several ones to me. First there is no place where the conversion from a format to another happens, it's a sequence of: * Import via a filter (read) * Layout * Export via another filter (save) As for the filters code (which is what you seem to want): * docx and rtf import is located in the whole writerfilter module (and bits in oox) * doc import is located in sw/source/filter/ww8/ww8par*.{h,c}xx * docx, rtf, doc export is located in sw/source/filter/ww8 * odt import and export is split between the xmloff module and sw/source/filter/xml * export as ascii text happens in sw/source/filter/ascii/wrtasc.{h,c}xx and sw/source/filter/ascii/ascatr.cxx I hope this will answer your question. -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/moduldlg.cxx | 72 ++-- basctl/source/basicide/register.cxx |1 basctl/source/basicide/sbxitem.cxx | 10 ++--- 3 files changed, 41 insertions(+), 42 deletions(-) New commits: commit 20e7a9bda9ae9eae2af47402903e17f95ae3510a Author: Ricardo Montania rica...@linuxafundo.com.br Date: Sun Oct 14 18:31:59 2012 -0300 rtl::OUString cleanup in basctl Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0 Reviewed-on: https://gerrit.libreoffice.org/872 Reviewed-by: Olivier Hallot olivier.hal...@alta.org.br Tested-by: Olivier Hallot olivier.hal...@alta.org.br diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx index 4a8cdb5..337063d 100644 --- a/basctl/source/basicide/moduldlg.cxx +++ b/basctl/source/basicide/moduldlg.cxx @@ -70,7 +70,7 @@ sal_Bool ExtTreeListBox::EditingEntry( SvLBoxEntry* pEntry, Selection ) { EntryDescriptor aDesc = GetEntryDescriptor(pEntry); ScriptDocument aDocument( aDesc.GetDocument() ); -::rtl::OUString aLibName( aDesc.GetLibName() ); +OUString aLibName( aDesc.GetLibName() ); Reference script::XLibraryContainer2 xModLibContainer( aDocument.getLibraryContainer( E_SCRIPTS ), UNO_QUERY ); Reference script::XLibraryContainer2 xDlgLibContainer( aDocument.getLibraryContainer( E_DIALOGS ), UNO_QUERY ); if ( !( ( xModLibContainer.is() xModLibContainer-hasByName( aLibName ) xModLibContainer-isLibraryReadOnly( aLibName ) ) || @@ -85,7 +85,7 @@ sal_Bool ExtTreeListBox::EditingEntry( SvLBoxEntry* pEntry, Selection ) return bRet; } -sal_Bool ExtTreeListBox::EditedEntry( SvLBoxEntry* pEntry, const rtl::OUString rNewText ) +sal_Bool ExtTreeListBox::EditedEntry( SvLBoxEntry* pEntry, const OUString rNewText ) { if ( !IsValidSbxName(rNewText) ) { @@ -93,7 +93,7 @@ sal_Bool ExtTreeListBox::EditedEntry( SvLBoxEntry* pEntry, const rtl::OUString return false; } -rtl::OUString aCurText( GetEntryText( pEntry ) ); +OUString aCurText( GetEntryText( pEntry ) ); if ( aCurText == rNewText ) // nothing to do return true; @@ -103,7 +103,7 @@ sal_Bool ExtTreeListBox::EditedEntry( SvLBoxEntry* pEntry, const rtl::OUString DBG_ASSERT( aDocument.isValid(), ExtTreeListBox::EditedEntry: no document! ); if ( !aDocument.isValid() ) return false; -::rtl::OUString aLibName( aDesc.GetLibName() ); +OUString aLibName( aDesc.GetLibName() ); EntryType eType = aDesc.GetType(); bool bSuccess = eType == OBJ_TYPE_MODULE ? @@ -145,7 +145,7 @@ DragDropMode ExtTreeListBox::NotifyStartDrag( TransferDataContainer, SvLBoxEntr nMode_ = SV_DRAGDROP_CTRL_COPY; EntryDescriptor aDesc = GetEntryDescriptor(pEntry); ScriptDocument aDocument( aDesc.GetDocument() ); -::rtl::OUString aLibName( aDesc.GetLibName() ); +OUString aLibName( aDesc.GetLibName() ); // allow MOVE mode only for libraries, which are not readonly Reference script::XLibraryContainer2 xModLibContainer( aDocument.getLibraryContainer( E_SCRIPTS ), UNO_QUERY ); Reference script::XLibraryContainer2 xDlgLibContainer( aDocument.getLibraryContainer( E_DIALOGS ), UNO_QUERY ); @@ -192,13 +192,13 @@ sal_Bool ExtTreeListBox::NotifyAcceptDrop( SvLBoxEntry* pEntry ) { // get source module/dialog name EntryDescriptor aSourceDesc = GetEntryDescriptor(pSelected); -rtl::OUString aSourceName = aSourceDesc.GetName(); +OUString aSourceName = aSourceDesc.GetName(); EntryType eSourceType = aSourceDesc.GetType(); // get target shell and target library name EntryDescriptor aDestDesc = GetEntryDescriptor(pEntry); ScriptDocument const rDestDoc = aDestDesc.GetDocument(); -rtl::OUString aDestLibName = aDestDesc.GetLibName(); +OUString aDestLibName = aDestDesc.GetLibName(); // check if module library is not loaded, readonly or password protected Reference script::XLibraryContainer2 xModLibContainer( rDestDoc.getLibraryContainer( E_SCRIPTS ), UNO_QUERY ); @@ -255,10 +255,10 @@ sal_Bool ExtTreeListBox::NotifyCopying( SvLBoxEntry* pTarget, SvLBoxEntry* pEntr void Shell::CopyDialogResources( Reference io::XInputStreamProvider io_xISP, ScriptDocument const rSourceDoc, -rtl::OUString const rSourceLibName, +OUString const rSourceLibName, ScriptDocument const rDestDoc, -rtl::OUString const rDestLibName, -rtl::OUString const rDlgName +OUString const rDestLibName, +OUString const rDlgName ) { if ( !io_xISP.is() ) @@ -285,7 +285,7 @@ void Shell::CopyDialogResources( // create dialog model Reference lang::XMultiServiceFactory xMSF = ::comphelper::getProcessServiceFactory(); Reference
[PUSHED] rtl::OUString cleanup in basctl
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/872 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/872 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If57c184b355224f31fdf7872ab1f52c034e5c7f0 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Olivier Hallot olivier.hal...@alta.org.br Gerrit-Reviewer: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Error on rebuild in Windows cp: missing destination file operand after
I guys, I've done a successful build on windows just to test... It went fine (after a hard fight ;-)) Now I've changed some things on the autogen (for instance change languages from en-US pt to just en-US) and re-run it and also changed the product name on *instsetoo_native/util/openoffice.lst* and now everytime it gets to the tail_buil if fails doing the extensions in the OXT... it fails in every extension with this: [ build OXT ] report-builder S=C:/libre362 O=$S/solver/wntmsci12.pro W=$S/workdir/wntmsci12.pro mkdir -p $W/Extension/report-builder/root/META-INF $W/Extension/report-builder/root/registration cp -f $W/Extension/report-builder/description.xml $W/Extension/report-builder/root/description.xml cp -f $S/reportbuilder/util/manifest.xml $W/Extension/report-builder/root/META-INF/manifest.xml cp -f $O/bin/osl/license.txt $W/Extension/report-builder/root/registration cp $W/Extension/report-builder/root cd $W/Extension/report-builder/root zip -rX --filesync $W/Extension/report-builder.oxt META-INF THIRDPARTYREADMELICENSE.html commons-logging-1.1.1.jar components.rdb description-en-US.txt description.xml flow-engine-0.9.4.jar flute-1.1.6.jar images/extension_32.png libbase-1.1.6.jar libfonts-1.1.6.jar libformula-1.1.7.jar liblayout-0.2.10.jar libloader-1.1.6.jar librepository-1.1.6.jar libserializer-1.1.6.jar libxml-1.1.7.jar readme_en-US.html readme_en-US.txt registration registry/data/org/openoffice/Office/Accelerators.xcu registry/data/org/openoffice/Office/DataAccess.xcu registry/data/org/openoffice/Office/Embedding.xcu registry/data/org/openoffice/Office/ExtendedColorScheme.xcu registry/data/org/openoffice/Office/Paths.xcu registry/data/org/openoffice/Office/ReportDesign.xcu registry/data/org/openoffice/Office/UI/Controller.xcu registry/data/org/openoffice/Office/UI/DbReportWindowState.xcu registry/data/org/openoffice/Office/UI/ReportCommands.xcu registry/data/org/openoffice/Setup.xcu registry/data/org/openoffice/TypeDetection/Filter.xcu registry/data/org/openoffice/TypeDetection/Types.xcu registry/schema/org/openoffice/Office/ReportDesign.xcs registry/schema/org/openoffice/Office/UI/DbReportWindowState.xcs registry/schema/org/openoffice/Office/UI/ReportCommands.xcs reportbuilderwizard.jar sac.jar sun-report-builder.jar template/en-US/wizard/report/default.otr cp: missing destination file operand after `C:/libre362/workdir/ wntmsci12.pro/Extension/report-builder/root' Try `cp --help' for more information. make[2]: *** [C:/libre362/workdir/wntmsci12.pro/Extension/report-builder.oxt] Error 1 make[2]: Leaving directory `/cygdrive/c/libre362/tail_build' Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand Can someone help me finding what's worng.. is there some environment variable that went missing? Where dows this cp command line commes from so that I can try to see what should be there (I didn't found it)? Thanks a lot -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Trying to build on Windows, multiple target patterns
I, I've done a sucessful build using this steps: http://wiki.documentfoundation.org/User:Foral/Build_Win Also had to apply this patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=6cfe3c93dc55264e57f1057a2911d54232353d13 Hope it helps. Cheers -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa 2012/10/15 Jeremy Brown jeremy.r.br...@gmail.com I'm trying to build LibreOffice on Windows. I tried about a year ago but gave up because I couldn't figure it out. In the meantime, I set up a VirtualBox Kubuntu install and was able to build LibreOffice there. No big deal, but it's the first time I've ever really make'd something on Linux with LibreOffice's level of complexity. Anyways, I'm back to trying to build on Windows because I realized that the thing I'm interested in trying to 'fix' works just fine on Linux, and the difficulty is Windows-specific, so I really need a Windows build to test if what I'm doing works or not. OK, so I've been trying to build LibreOffice on Windows from master following the directions in the wiki, but I'm having a lot of trouble. I've tried being as careful as I can getting it all configured right, but maybe I missed something. So here are 4 sort of related questions... #1 My current problem is that I run make and it runs for a while and then dies in tail_build with an error like this: D:/Dev/libo/libo/workdir/ wntmsci12.pro/Dep/LinkTarget/Library/iacc.lib.d:948: *** multiple target patterns. Stop. I saw this pop up a few times too when I was trying to make various modules independently.. They would die with: ../LinkTarget/[Static]Library/foobar.lib.d:123: *** multiple target patterns. Stop. Does anyone recognize what this could be caused by? #2 Another question: I'm looking at Tinderbox, and if I'm trying to tell when a good time to build is, which Windows column should I be looking at? Also, is there any way to find out what build options (e.g. in autogen.lastrun) those builds are using, so I could try to copy them? #3 In my failed build on Windows, can anyone tell me if I should be concerned about these types of messages which I'm receiving quite a few of LinkTarget Library/glib-2.0.lib not defined: Assuming headers to be there! D:/Dev/libo/libo/solenv/inc/shlinfo.rc(55) : warning RC4003: not enough actual parameters for macro 'PPSX' C:/PROGRA~2/MICROS~1.0/VC/include\stdlib.h(772) : warning C4068: unknown pragma Command line warning D9025 : overriding '/DNOMINMAX' with '/UNOMINMAX' or this line: error CS1548: Cryptographic failure while signing assembly 'd:\Dev\libo\libo\workdir\wntmsci12.pro \CliLibraryTarget\cli_basetypes.dll' -- 'Error reading key file 'D:\\Dev\\libo\\libo\\solver\\wntmsci12.pro\\bin\\cliuno.snk' -- The system cannot find the file specified. ' #4 Finally, in tandem, I'm looking into the idea of cross compiling a Windows binary from Kubuntu (or whatever) based on the information here: http://wiki.documentfoundation.org/User:Ploum Is this a valid route for hacking on and testing a Windows build? Can I build and then copy files over to a Windows machine and run LibreOffice there? Thanks for any pointers anyone could provide. Jeremy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
On 2012-10-16 10:32, Flavio Moringa wrote: I guys, I've done a successful build on windows just to test... It went fine (after a hard fight ;-)) Now I've changed some things on the autogen (for instance change languages from en-US pt to just en-US) and re-run it and also changed the product name on /instsetoo_native/util/openoffice.lst/ and now everytime it gets to the tail_buil if fails doing the extensions in the OXT... it fails in every extension with this: You might have to do a 'make clean' after doing autogen changes. The build dependencies are not perfect and sometimes they mess up. Can someone help me finding what's worng.. is there some environment variable that went missing? Where dows this cp command line commes from so that I can try to see what should be there (I didn't found it)? cp is part of the cygwin environment. It's normally a built-in i.e. part of the bash program. Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Hi, On Tue, Oct 16, 2012 at 09:32:20AM +0100, Flavio Moringa wrote: I guys, I've done a successful build on windows just to test... It went fine (after a hard fight ;-)) Now I've changed some things on the autogen (for instance change languages from en-US pt to just en-US) and re-run it and also changed the product name on *instsetoo_native/util/openoffice.lst* and now everytime it gets to the tail_buil if fails doing the extensions in the OXT... it fails in every extension with this: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand Can someone help me finding what's worng.. is there some environment variable that went missing? Where dows this cp command line commes from so that I can try to see what should be there (I didn't found it)? It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Add a 'fromIndex' parameter to OUString::replaceAll
On 10/05/2012 09:09 AM, Noel Grandin (via Code Review) wrote: I have submitted a patch for review: https://gerrit.libreoffice.org/768 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/68/768/1 Add a 'fromIndex' parameter to OUString::replaceAll Change-Id: I001099baaca5cd402aebcd15c031d9060286a8f9 --- M sal/inc/rtl/ustring.h M sal/inc/rtl/ustring.hxx M sal/rtl/source/ustring.cxx M sal/util/sal.map 4 files changed, 32 insertions(+), 3 deletions(-) Noel, for consistency, can you also extend OString::replaceAll and the other two OUString::replaceAll overloads (the templated ones that allow using plain string literals as arguments)? Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
I David... so if I remove the --with-lang=en-US from my autogen and rerun it, it might work... hummm I'm going to try that... Will tell if it works... Thanks a lot... Your's trully -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa 2012/10/16 David Tardon dtar...@redhat.com Hi, On Tue, Oct 16, 2012 at 09:32:20AM +0100, Flavio Moringa wrote: I guys, I've done a successful build on windows just to test... It went fine (after a hard fight ;-)) Now I've changed some things on the autogen (for instance change languages from en-US pt to just en-US) and re-run it and also changed the product name on *instsetoo_native/util/openoffice.lst* and now everytime it gets to the tail_buil if fails doing the extensions in the OXT... it fails in every extension with this: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand Can someone help me finding what's worng.. is there some environment variable that went missing? Where dows this cp command line commes from so that I can try to see what should be there (I didn't found it)? It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Hi, Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? Ciao David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/inc sw/qa sw/source
sw/inc/acmplwrd.hxx |2 +- sw/inc/bparr.hxx|2 +- sw/inc/doc.hxx |2 +- sw/inc/ndarr.hxx|2 +- sw/inc/swmodule.hxx |4 ++-- sw/qa/core/Test-BigPtrArray.cxx |2 +- sw/source/core/bastyp/SwSmartTagMgr.cxx |4 ++-- sw/source/core/doc/acmplwrd.cxx |2 +- sw/source/core/doc/doc.cxx | 14 ++ sw/source/core/doc/docedt.cxx |6 +++--- sw/source/core/doc/docfmt.cxx | 12 ++-- sw/source/core/docnode/nodes.cxx|6 +++--- sw/source/core/inc/rootfrm.hxx |2 +- sw/source/core/layout/newfrm.cxx|2 +- sw/source/ui/app/docsh2.cxx |4 ++-- sw/source/ui/app/swmodul1.cxx |8 sw/source/ui/docvw/edtwin.cxx |8 sw/source/ui/inc/edtwin.hxx |2 +- sw/source/ui/uiview/view0.cxx |2 +- sw/source/ui/uiview/view2.cxx |2 +- sw/source/ui/uno/dlelstnr.cxx | 14 +++--- 21 files changed, 50 insertions(+), 52 deletions(-) New commits: commit b1167e125076c8d088119585672105fd0bcbd6ee Author: Takeshi Abe t...@fixedpoint.jp Date: Tue Oct 16 18:29:11 2012 +0900 sal_Bool to bool Change-Id: I89050a1aa899b1a6cd49800f805af9611fd0a9a7 diff --git a/sw/inc/acmplwrd.hxx b/sw/inc/acmplwrd.hxx index 09586c8..b267213 100644 --- a/sw/inc/acmplwrd.hxx +++ b/sw/inc/acmplwrd.hxx @@ -91,7 +91,7 @@ public: // Returns all words matching a given prefix aMatch. If bIgnoreCurrentPos is set, the current // position within the tree is ignored and replaced by aMatch. -bool GetWordsMatching(String aMatch, std::vectorString aWords, sal_Bool bIgnoreCurrentPos) const; +bool GetWordsMatching(String aMatch, std::vectorString aWords, bool bIgnoreCurrentPos) const; }; diff --git a/sw/inc/bparr.hxx b/sw/inc/bparr.hxx index e5035a8..2a644d3 100644 --- a/sw/inc/bparr.hxx +++ b/sw/inc/bparr.hxx @@ -54,7 +54,7 @@ protected: typedef BigPtrEntry* ElementPtr; -typedef sal_Bool (*FnForEach)( const ElementPtr, void* pArgs ); +typedef bool (*FnForEach)( const ElementPtr, void* pArgs ); // 1000 entries per Block = a bit less then 4K #define MAXENTRY 1000 diff --git a/sw/inc/doc.hxx b/sw/inc/doc.hxx index 76a7ef4..9649c7e 100644 --- a/sw/inc/doc.hxx +++ b/sw/inc/doc.hxx @@ -1795,7 +1795,7 @@ public: sal_Bool DeleteSelection( SwDrawView ); /// Invalidates OnlineSpell-WrongLists. -void SpellItAgainSam( sal_Bool bInvalid, sal_Bool bOnlyWrong, sal_Bool bSmartTags ); +void SpellItAgainSam( bool bInvalid, bool bOnlyWrong, bool bSmartTags ); void InvalidateAutoCompleteFlag(); void SetCalcFieldValueHdl(Outliner* pOutliner); diff --git a/sw/inc/ndarr.hxx b/sw/inc/ndarr.hxx index 2f393af..a7401a0 100644 --- a/sw/inc/ndarr.hxx +++ b/sw/inc/ndarr.hxx @@ -79,7 +79,7 @@ struct SwPosition; // typedef SwNode * SwNodePtr; -typedef sal_Bool (*FnForEach_SwNodes)( const SwNodePtr, void* pArgs ); +typedef bool (*FnForEach_SwNodes)( const SwNodePtr, void* pArgs ); typedef struct _xmlTextWriter *xmlTextWriterPtr; struct CompareSwOutlineNodes diff --git a/sw/inc/swmodule.hxx b/sw/inc/swmodule.hxx index 64584f5..e11ac47 100644 --- a/sw/inc/swmodule.hxx +++ b/sw/inc/swmodule.hxx @@ -232,8 +232,8 @@ public: voidRemoveAttrPool(); // Invalidates online spell-wrong-lists if necessary. -voidCheckSpellChanges( sal_Bool bOnlineSpelling, -sal_Bool bIsSpellWrongAgain, sal_Bool bIsSpellAllAgain, sal_Bool bSmartTags ); +voidCheckSpellChanges( bool bOnlineSpelling, +bool bIsSpellWrongAgain, bool bIsSpellAllAgain, bool bSmartTags ); inline ::com::sun::star::uno::Reference ::com::sun::star::linguistic2::XLinguServiceEventListener diff --git a/sw/qa/core/Test-BigPtrArray.cxx b/sw/qa/core/Test-BigPtrArray.cxx index 117c79a..d295238 100644 --- a/sw/qa/core/Test-BigPtrArray.cxx +++ b/sw/qa/core/Test-BigPtrArray.cxx @@ -78,7 +78,7 @@ namespace /* private */ sal_uLong count_; }; -sal_Bool AddToCount(const ElementPtr rElem, void* pArgs) +bool AddToCount(const ElementPtr rElem, void* pArgs) { BigPtrEntryMock* const pbem = static_castBigPtrEntryMock* const(rElem); pbem-setCount(pbem-getCount() + *((sal_uLong*)pArgs)); diff --git a/sw/source/core/bastyp/SwSmartTagMgr.cxx b/sw/source/core/bastyp/SwSmartTagMgr.cxx index b2caf30..c35b646 100644 --- a/sw/source/core/bastyp/SwSmartTagMgr.cxx +++ b/sw/source/core/bastyp/SwSmartTagMgr.cxx @@ -62,7 +62,7 @@ void SwSmartTagMgr::modified( const lang::EventObject rEO ) throw( RuntimeExcep SolarMutexGuard aGuard; // Installed recognizers have changed. We remove all existing smart tags: -SW_MOD()-CheckSpellChanges( sal_False, sal_True, sal_True, sal_True
Re: Error on rebuild in Windows cp: missing destination file operand after
On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.mk. I understand that the other David is doing that. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Well, the main contact with developers should be the mailling list: libreoffice@lists.freedesktop.org 2012/10/16 Stephan Bergmann sberg...@redhat.com On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/**root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.**mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.**mk. I understand that the other David is doing that. Stephan __**_ LibreOffice mailing list LibreOffice@lists.freedesktop.**org LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/**mailman/listinfo/libreofficehttp://lists.freedesktop.org/mailman/listinfo/libreoffice -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Sorry.. wrong thread 2012/10/16 Flavio Moringa flavio.mori...@caixamagica.pt Well, the main contact with developers should be the mailling list: libreoffice@lists.freedesktop.org 2012/10/16 Stephan Bergmann sberg...@redhat.com On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/**root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.** mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.**mk. I understand that the other David is doing that. Stephan __**_ LibreOffice mailing list LibreOffice@lists.freedesktop.**org LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/**mailman/listinfo/libreofficehttp://lists.freedesktop.org/mailman/listinfo/libreoffice -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Fwd: LibreOffice for the enterprise
HI guys ! What do you think about this ? Any info ? =) -- Forwarded message -- From: Florian Monfort florian.monf...@gmail.com Date: Tue, Oct 16, 2012 at 11:02 AM Subject: LibreOffice for the enterprise To: market...@global.libreoffice.org, disc...@documentfoundation.org Hi everyone ! At last Open World Forum in Paris I was talking to a colleague from Red Hat. We were discussing LibreOffice and our projects. An idea he gave is to my sense SO CLEVER, and I think we should push it to whoever might be interested, developers, discuss list or whatever... The idea : Enterprises are looking for a office productivity infrastructure that they can deploy in the cloud, and that could act the same as Google Doc/Drive does, but by doing it with full control over the documents. He told me that this would doable and that we should take a look. He also told me that not a lot of people are capable of providing such solution right, and so if we can do this the Open Source way, it might even be better. One great also to gain some revenue by having enterprise -oriented solution. What do you guys think ? -- *Monfort Florian* BM2 Student at France Business School Marketing Apprentice at Red Hat Marketing Team Member at The Document Foundation florian.monf...@gmail.com Mobile : +33 6 58 97 15 61 -- *Monfort Florian* BM2 Student at France Business School Marketing Apprentice at Red Hat Marketing Team Member at The Document Foundation florian.monf...@gmail.com Mobile : +33 6 58 97 15 61 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6-3' - sc/source
sc/source/core/data/table2.cxx | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) New commits: commit 39e7aefe5d3645f08867c84e1c5dd08c7209a439 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Oct 12 16:46:55 2012 +0200 don't insert notes from deleted cells, fdo#55885 Change-Id: I036f0531dc2290c5eb480258bc70ec13b810e6bc Signed-off-by: Kohei Yoshida kohei.yosh...@gmail.com Signed-off-by: Eike Rathke er...@redhat.com Signed-off-by: Noel Power nopo...@novell.com diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx index 4230cbd..cd193c1 100644 --- a/sc/source/core/data/table2.cxx +++ b/sc/source/core/data/table2.cxx @@ -267,8 +267,13 @@ void ScTable::DeleteRow( SCCOL nStartCol, SCCOL nEndCol, SCROW nStartRow, SCSIZE if (nRow = nStartRow) { -aNotes.insert(nCol, nRow - nSize, pPostIt); -maNotes.ReleaseNote(nCol, nRow); +if(nRow - nStartRow static_castSCROW(nSize)) +{ +aNotes.insert(nCol, nRow - nSize, pPostIt); +maNotes.ReleaseNote(nCol, nRow); +} +else +maNotes.erase(nCol, nRow); } } @@ -486,8 +491,13 @@ void ScTable::DeleteCol( SCCOL nStartCol, SCROW nStartRow, SCROW nEndRow, SCSIZE if (nCol = nStartCol) { -aNotes.insert(nCol - nSize, nRow, pPostIt); -maNotes.ReleaseNote(nCol, nRow); +if(nCol - nStartCol static_castSCCOL(nSize)) +{ +aNotes.insert(nCol - nSize, nRow, pPostIt); +maNotes.ReleaseNote(nCol, nRow); +} +else +maNotes.erase(nCol, nRow); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED 3-6][PUSHED 3-6-3] fix for fdo#55885, don't insert notes to deleted cells
On Mon, 2012-10-15 at 20:58 +0100, Noel Power wrote: On 15/10/12 14:15, Eike Rathke wrote: Hi, On Saturday, 2012-10-13 13:38:07 -0400, Kohei Yoshida wrote: On Sat, Oct 13, 2012 at 1:22 AM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Yeap, my mistake. It misses the -nStartRow or -nStartCol that makes the nRow/nCol relative to the deleted column/row. I attached a patch that squashs both necessary commits into one. Yup. That looks more like it. Pushed it to 3-6 with my sign-off. We'll need to work on adding a test case for this later (on master)... Two more sign-off's needed to push this change to 3-6-3. Here's mine, one more needed. here's one more, I've struggled for hours to get a connection here, no chance I can push it so if someone can do the honours that would be great done; pushed Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Daily builds for Debian
On 16/10/12 11:06, Lior Kaplan wrote: Hi, I was looking to test a daily build for Debian, and it seems that we only have RPM daily builds. http://dev-builds.libreoffice.org/daily/Linux-Fedora17-x86_64@4-gcc-4.7-dbgutil/master/current/ (other Linux build servers work on 3.5 and 3.6, but not master) Am I missing something or is that really the case? no idea if that is the case, but it's not usually a problem, because you can just install the RPMs in any directory on a Debian system as well, you just don't get system integration (desktop menus, mimetypes) that way. use the script attached here: http://lists.freedesktop.org/archives/libreoffice-qa/2011-November/000393.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
On 10/16/2012 11:59 AM, David Tardon wrote: On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote: On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.mk. I understand that the other David is doing that. Maybe not the easiest, but the most correct :-) Oh, I had assumed that diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk index 91f1be3..eb45785 100644 --- a/solenv/gbuild/ExtensionTarget.mk +++ b/solenv/gbuild/ExtensionTarget.mk @@ -112,7 +112,7 @@ $(call gb_ExtensionTarget_get_target,%) : \ $(call gb_ExtensionTarget__subst_platform,$(call gb_ExtensionTarget_get_workdir,$*)/description.xml,$(call gb_ExtensionTar $(call gb_ExtensionTarget__subst_platform,$(LOCATION)/manifest.xml,$(call gb_ExtensionTarget_get_rootdir,$*)/META-INF/mani $(if $(LICENSE),cp -f $(LICENSE) $(call gb_ExtensionTarget_get_rootdir,$*)/registration ) \ - $(if $(and $(gb_WITH_LANG),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb_ExtensionTarget_g + $(if $(and $(gb_ExtensionTarget_TRANS_LANGS),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb cd $(call gb_ExtensionTarget_get_rootdir,$*) \ $(gb_ExtensionTarget_ZIPCOMMAND) -rX --filesync \ $(call gb_ExtensionTarget_get_target,$*) \ would be all that's needed? But I'm likely missing something. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Hi, Quoting David Tardon dtar...@redhat.com: Hi, On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote: On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.mk. I understand that the other David is doing that. Maybe not the easiest, but the most correct :-) ;-) ah, well, if we are talking about the correct way ... then we shouldn't play these games with such a construct MODULE_FOO_LANGS := en-US $(filter-out en-US,$(gb_WITH_LANG)) any more but introduce a new variable gb_WITH_LANG_OR_DEFAULT and use it in all places instead. I mentioned it already in comment in readlicense_oo module during gbuildification ... but didn't do it myself ;-) http://cgit.freedesktop.org/libreoffice/core/tree/readlicense_oo/CustomTarget_readme.mk#n15 Regards David ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error on rebuild in Windows cp: missing destination file operand after
Hi, On Tue, Oct 16, 2012 at 12:35:06PM +0200, Stephan Bergmann wrote: On 10/16/2012 11:59 AM, David Tardon wrote: On Tue, Oct 16, 2012 at 11:38:28AM +0200, Stephan Bergmann wrote: On 10/16/2012 11:14 AM, d.ostrov...@idaia.de wrote: Quoting David Tardon dtar...@redhat.com: Basically it seems that in the command: cp $W/Extension/report-builder/root it's missing the first operand It is a use case that nobody has ever tried before, because en-US is the default language. The line comes from solenv/gbuild/ExtensionTarget.mk and the missing argument(s) is a list of files based on $(gb_WITH_LANG), but _without_ en-US. Since $(gb_WITH_LANG) contains _nothing but_ en-US in your case, there are no files to copy... the easiest way to sort this out would be to add a check in configure.in for that: if --with-lang=en-US then fail or unset WITH_LANG, right? No, the easiest thing should be to fix solenv/gbuild/ExtensionTarget.mk. I understand that the other David is doing that. Maybe not the easiest, but the most correct :-) Oh, I had assumed that diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk index 91f1be3..eb45785 100644 --- a/solenv/gbuild/ExtensionTarget.mk +++ b/solenv/gbuild/ExtensionTarget.mk @@ -112,7 +112,7 @@ $(call gb_ExtensionTarget_get_target,%) : \ $(call gb_ExtensionTarget__subst_platform,$(call gb_ExtensionTarget_get_workdir,$*)/description.xml,$(call gb_ExtensionTar $(call gb_ExtensionTarget__subst_platform,$(LOCATION)/manifest.xml,$(call gb_ExtensionTarget_get_rootdir,$*)/META-INF/mani $(if $(LICENSE),cp -f $(LICENSE) $(call gb_ExtensionTarget_get_rootdir,$*)/registration ) \ - $(if $(and $(gb_WITH_LANG),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb_ExtensionTarget_g + $(if $(and $(gb_ExtensionTarget_TRANS_LANGS),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb cd $(call gb_ExtensionTarget_get_rootdir,$*) \ $(gb_ExtensionTarget_ZIPCOMMAND) -rX --filesync \ $(call gb_ExtensionTarget_get_target,$*) \ would be all that's needed? But I'm likely missing something. Yes, that is all what is needed for this particular problem. I just assumed that there might be further problems :-) And I was right, because we handle such situation differently in different places. gbuild classes generally expect that WITH_LANG is empty in en-US-only build and add deps on localize.sdf's if it is not. But translations are not built if WITH_LANG=en-US, so the build fails anyway. So there are two possibilities: 1. let --with-lang=en-US behave in the same way as if --with-lang was not used at all 2. let it behave as if any other single language was used--build translations, even if they are not needed, etc. I could probably invent arguments for both ways, if I cared enough. Because I do not, I am going to push option 1 (i.e., unset WITH_LANG, as David suggested). If anyone disagrees, feel free to revert and change configure.in and translations/Module_translations.mk the other way. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - configure.in solenv/gbuild
configure.in |3 ++- solenv/gbuild/ExtensionTarget.mk |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit b49e97e29431e9f7248b9cd75d5a5c8fb88dfc4d Author: David Tardon dtar...@redhat.com Date: Tue Oct 16 13:20:25 2012 +0200 --with-lang=en-US is already the default Change-Id: I906e025e1b7eb8ecda028eef89ac5667cd2aac13 diff --git a/configure.in b/configure.in index 3326751..9906ead 100644 --- a/configure.in +++ b/configure.in @@ -12204,7 +12204,8 @@ WITH_LANG_LIST=`echo $WITH_LANG | sed s/ALL/$ALL_LANGS/` # this variable is used only by bin/distro-install-* helper scripts # they need a real list of languages test -z $WITH_LANG_LIST WITH_LANG_LIST=en-US -test -z $WITH_LANG -o $WITH_LANG = en-US || BUILD_TYPE=$BUILD_TYPE TRANSLATIONS +test $WITH_LANG = en-US WITH_LANG= +test -z $WITH_LANG || BUILD_TYPE=$BUILD_TYPE TRANSLATIONS AC_SUBST(ALL_LANGS) AC_SUBST(WITH_LANG) AC_SUBST(WITH_LANG_LIST) commit 24f9ae3720870b61568f7034f7bc74531b1077cd Author: David Tardon dtar...@redhat.com Date: Tue Oct 16 13:17:53 2012 +0200 avoid potential build failure Change-Id: Idc83831569c8fcb08d28ed4c0b991e185008 diff --git a/solenv/gbuild/ExtensionTarget.mk b/solenv/gbuild/ExtensionTarget.mk index 91f1be3..eb45785 100644 --- a/solenv/gbuild/ExtensionTarget.mk +++ b/solenv/gbuild/ExtensionTarget.mk @@ -112,7 +112,7 @@ $(call gb_ExtensionTarget_get_target,%) : \ $(call gb_ExtensionTarget__subst_platform,$(call gb_ExtensionTarget_get_workdir,$*)/description.xml,$(call gb_ExtensionTarget_get_rootdir,$*)/description.xml) \ $(call gb_ExtensionTarget__subst_platform,$(LOCATION)/manifest.xml,$(call gb_ExtensionTarget_get_rootdir,$*)/META-INF/manifest.xml) \ $(if $(LICENSE),cp -f $(LICENSE) $(call gb_ExtensionTarget_get_rootdir,$*)/registration ) \ - $(if $(and $(gb_WITH_LANG),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb_ExtensionTarget_get_workdir,$*)/description-$(lang).txt) $(call gb_ExtensionTarget_get_rootdir,$*) ) \ + $(if $(and $(gb_ExtensionTarget_TRANS_LANGS),$(DESCRIPTION)),cp $(foreach lang,$(gb_ExtensionTarget_TRANS_LANGS),$(call gb_ExtensionTarget_get_workdir,$*)/description-$(lang).txt) $(call gb_ExtensionTarget_get_rootdir,$*) ) \ cd $(call gb_ExtensionTarget_get_rootdir,$*) \ $(gb_ExtensionTarget_ZIPCOMMAND) -rX --filesync \ $(call gb_ExtensionTarget_get_target,$*) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Error on rebuild in Windows cp: missing destination file operand after
On 10/16/2012 01:16 PM, David Tardon wrote: Yes, that is all what is needed for this particular problem. I just assumed that there might be further problems :-) And I was right, because we handle such situation differently in different places. gbuild classes generally expect that WITH_LANG is empty in en-US-only build and add deps on localize.sdf's if it is not. But translations are not built if WITH_LANG=en-US, so the build fails anyway. So there are two possibilities: 1. let --with-lang=en-US behave in the same way as if --with-lang was not used at all 2. let it behave as if any other single language was used--build translations, even if they are not needed, etc. I could probably invent arguments for both ways, if I cared enough. Because I do not, I am going to push option 1 (i.e., unset WITH_LANG, as David suggested). If anyone disagrees, feel free to revert and change configure.in and translations/Module_translations.mk the other way. Ah, yes, I missed the bigger picture. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 5 commits - bridges/CustomTarget_gcc3_ios_arm.mk cli_ure/CustomTarget_cli_ure_assemblies.mk cli_ure/Library_cli_cppuhelper_native.mk librsvg/config.h librsvg/ExternalPackage_l
bridges/CustomTarget_gcc3_ios_arm.mk |7 +++ cli_ure/CustomTarget_cli_ure_assemblies.mk |6 +++--- cli_ure/Library_cli_cppuhelper_native.mk |2 +- librsvg/ExternalPackage_librsvg.mk | 25 + librsvg/Module_librsvg.mk |1 + solenv/gbuild/platform/WNT_INTEL_MSC.mk|7 +++ 6 files changed, 40 insertions(+), 8 deletions(-) New commits: commit 40a4c469dff783736ba69ec4134e3c23e78b2769 Author: David Tardon dtar...@redhat.com Date: Mon Oct 15 14:56:34 2012 +0200 fdo#55290 do not use resource file for assembly libs I am not sure this really fixes the problem, but it is the only difference between dmake and gbuild builds I can see. Change-Id: I96fa4120dc2a8221a75e150a62582aebda98f505 diff --git a/cli_ure/Library_cli_cppuhelper_native.mk b/cli_ure/Library_cli_cppuhelper_native.mk index 5582e77..32b9ffd 100644 --- a/cli_ure/Library_cli_cppuhelper_native.mk +++ b/cli_ure/Library_cli_cppuhelper_native.mk @@ -7,7 +7,7 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_Library_Library,cli_cppuhelper_native)) +$(eval $(call gb_Library_Assembly,cli_cppuhelper_native)) # When compiling for CLR, disable warning C4339: use of undefined type detected # in CLR meta-data - use of this type may lead to a runtime exception: diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk b/solenv/gbuild/platform/WNT_INTEL_MSC.mk index 151327e..180cb69 100644 --- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk @@ -449,6 +449,13 @@ gb_Library_DLLFILENAMES :=\ $(foreach lib,$(gb_Library_UNOVERLIBS),$(lib):$(lib)$(gb_Library_UNOVEREXT)) \ $(foreach lib,$(gb_Library_EXTENSIONLIBS),$(lib):$(lib)$(gb_Library_UNOEXT)) \ +# An assembly is a special kind of library for CLI +define gb_Library_Assembly +$(call gb_Library_Library,$(1)) +$(call gb_LinkTarget_get_target,$(call gb_Library_get_linktargetname,$(1))) : NATIVERES := + +endef + define gb_Library_Library_platform $(call gb_LinkTarget_set_dlltarget,$(2),$(3)) commit 2969b1007ae3df1e70c5fa18fab1b41fff6da210 Author: David Tardon dtar...@redhat.com Date: Tue Oct 16 13:25:02 2012 +0200 strip executable flag Change-Id: I13da3924bc8d737d6a1133a0696d45dc463864ef diff --git a/librsvg/ExternalProject_librsvg.mk b/librsvg/ExternalProject_librsvg.mk old mode 100755 new mode 100644 diff --git a/librsvg/UnpackedTarball_rsvg.mk b/librsvg/UnpackedTarball_rsvg.mk old mode 100755 new mode 100644 diff --git a/librsvg/config.h b/librsvg/config.h old mode 100755 new mode 100644 commit 82b7f772ea9d30cd00324e48ef60cc3d28dad414 Author: David Tardon dtar...@redhat.com Date: Tue Oct 16 10:28:45 2012 +0200 deliver librsvg build products Change-Id: If2d528f02a44e6828a26a843106a1005917dcb4e diff --git a/librsvg/ExternalPackage_librsvg.mk b/librsvg/ExternalPackage_librsvg.mk new file mode 100644 index 000..540da01 --- /dev/null +++ b/librsvg/ExternalPackage_librsvg.mk @@ -0,0 +1,25 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_ExternalPackage_ExternalPackage,librsvg,rsvg)) + +$(eval $(call gb_ExternalPackage_use_external_project,librsvg,librsvg)) + +$(eval $(call gb_ExternalPackage_add_files,librsvg,lib,\ +.libs/librsvg-2.2.dylib \ +)) + +$(eval $(call gb_ExternalPackage_add_unpacked_files,librsvg,inc/external/librsvg-2.0/librsvg,\ +rsvg-cairo.h \ +rsvg-enum-types.h \ +rsvg-features.h \ +rsvg.h \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/librsvg/Module_librsvg.mk b/librsvg/Module_librsvg.mk index 3e58b9e..2fe5794 100644 --- a/librsvg/Module_librsvg.mk +++ b/librsvg/Module_librsvg.mk @@ -15,6 +15,7 @@ $(eval $(call gb_Module_add_targets,librsvg,\ )) ifeq ($(OS),MACOSX) $(eval $(call gb_Module_add_targets,librsvg,\ + ExternalPackage_librsvg \ ExternalProject_librsvg \ )) else ifeq ($(OS),WNT) commit 5b4fa31affcb4751552b717cfe5eb72c6a99460d Author: David Tardon dtar...@redhat.com Date: Tue Oct 16 10:11:59 2012 +0200 use key directly from $(SRCDIR) Change-Id: Ib1671e416fa59a46e4936ae75de4e2c20d70997b diff --git a/cli_ure/CustomTarget_cli_ure_assemblies.mk b/cli_ure/CustomTarget_cli_ure_assemblies.mk index da66178..80a8e43 100644 --- a/cli_ure/CustomTarget_cli_ure_assemblies.mk +++ b/cli_ure/CustomTarget_cli_ure_assemblies.mk @@ -43,20 +43,20 @@ $(call gb_CustomTarget_get_workdir,cli_ure/source)/ure/assembly.cs : \ $(call gb_CustomTarget_get_workdir,cli_ure/source)/basetypes/assembly.cs : $(GNUCOPY) $ $@.tmp \ echo '[assembly:System.Reflection.AssemblyVersion( $(CLI_BASETYPES_NEW_VERSION)
Re: Error on rebuild in Windows cp: missing destination file operand after
Option 1 seems fine I understand that my problem was a stupid one... but it happened nevertheless because I had already did a autogen with en-US pt and now I only needed en-US so I just removed the pt... didn't even remember of removing the full option... If it get's fixed all the better so that stupid options like mine are taken care of :-) Cheers -- *Flávio Moringa* Project Leader Caixa Mágica Software Energia Open Source Rua Soeiro Pereira Gomes, Lote 1 - 4.º B, Edifício Espanha, 1600-196 Lisboa - Portugal Tel.: +351 217 921 260 Fax: +351 217 921 261 http://www.caixamagica.pt https://twitter.com/flaviomoringa https://www.facebook.com/flaviomoringahttps://www.facebook.com/flavio.moringa http://pt.linkedin.com/in/flaviomoringa http://people.caixamagica.pt/flaviomoringa 2012/10/16 Stephan Bergmann sberg...@redhat.com On 10/16/2012 01:16 PM, David Tardon wrote: Yes, that is all what is needed for this particular problem. I just assumed that there might be further problems :-) And I was right, because we handle such situation differently in different places. gbuild classes generally expect that WITH_LANG is empty in en-US-only build and add deps on localize.sdf's if it is not. But translations are not built if WITH_LANG=en-US, so the build fails anyway. So there are two possibilities: 1. let --with-lang=en-US behave in the same way as if --with-lang was not used at all 2. let it behave as if any other single language was used--build translations, even if they are not needed, etc. I could probably invent arguments for both ways, if I cared enough. Because I do not, I am going to push option 1 (i.e., unset WITH_LANG, as David suggested). If anyone disagrees, feel free to revert and change configure.in and translations/Module_**translations.mk the other way. Ah, yes, I missed the bigger picture. Stephan __**_ LibreOffice mailing list LibreOffice@lists.freedesktop.**org LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/**mailman/listinfo/libreofficehttp://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sd/source unusedcode.easy
sd/source/ui/framework/module/ResourceManager.cxx| 21 -- sd/source/ui/framework/module/ResourceManager.hxx| 14 -- sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx | 21 -- sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx | 20 - sd/source/ui/view/ViewShellBase.cxx | 14 -- unusedcode.easy |4 - 6 files changed, 94 deletions(-) New commits: commit 6dfbd3324f43ff5b90030462b92ad8c0da3f6dd7 Author: Marcos Paulo de Souza marcos.souza@gmail.com Date: Mon Oct 15 01:06:49 2012 -0300 Remove some unused methods Change-Id: Ia9ed975309c6ed677437c6e1c2d6be4a8bd6f1e9 Signed-off-by: Marcos Paulo de Souza marcos.souza@gmail.com Reviewed-on: https://gerrit.libreoffice.org/875 Reviewed-by: Petr Mladek pmla...@suse.cz Tested-by: Petr Mladek pmla...@suse.cz diff --git a/sd/source/ui/framework/module/ResourceManager.cxx b/sd/source/ui/framework/module/ResourceManager.cxx index 0cf323c..49a40be 100644 --- a/sd/source/ui/framework/module/ResourceManager.cxx +++ b/sd/source/ui/framework/module/ResourceManager.cxx @@ -125,27 +125,6 @@ void SAL_CALL ResourceManager::disposing (void) } } - - - -void ResourceManager::Enable (void) -{ -mbIsEnabled = true; -UpdateForMainViewShell(); -} - - - - -void ResourceManager::Disable (void) -{ -mbIsEnabled = false; -UpdateForMainViewShell(); -} - - - - void SAL_CALL ResourceManager::notifyConfigurationChange ( const ConfigurationChangeEvent rEvent) throw (RuntimeException) diff --git a/sd/source/ui/framework/module/ResourceManager.hxx b/sd/source/ui/framework/module/ResourceManager.hxx index cd69661..c206877 100644 --- a/sd/source/ui/framework/module/ResourceManager.hxx +++ b/sd/source/ui/framework/module/ResourceManager.hxx @@ -67,20 +67,6 @@ public: virtual void SAL_CALL disposing (void); -/** Allow the ResourceManager to make resource activation or -deactivation requests. -*/ -void Enable (void); - -/** Disable the resource management. When called, the ResourceManager -requests the resource to be deactivated. Until enabled again it -does not make any further requests for resource activation or -deactivation. - -Call this for example to hide resources in read-only mode. -*/ -void Disable (void); - // XConfigurationChangeListener virtual void SAL_CALL notifyConfigurationChange ( diff --git a/sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx b/sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx index c703d64..eaefe02 100644 --- a/sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx +++ b/sd/source/ui/slidesorter/controller/SlsAnimationFunction.cxx @@ -36,27 +36,6 @@ namespace sd { namespace slidesorter { namespace controller { - -double AnimationFunction::Linear (const double nTime) -{ -OSL_ASSERT(nTime=0.0 nTime=1.0); -return nTime; -} - - - - -double AnimationFunction::Blend ( -const double nStartValue, -const double nEndValue, -const double nTime) -{ -return nStartValue*(1-nTime) + nEndValue*nTime; -} - - - - //= AnimationBezierFunction === AnimationBezierFunction::AnimationBezierFunction ( diff --git a/sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx b/sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx index 8f11973..b94ac65 100644 --- a/sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx +++ b/sd/source/ui/slidesorter/inc/controller/SlsAnimationFunction.hxx @@ -44,26 +44,6 @@ class SlideSorterView; namespace sd { namespace slidesorter { namespace controller { -/** A collection of functions that are usefull when creating animations. -They are collected here until a better place is found. -*/ -class AnimationFunction -: private ::boost::noncopyable -{ -public: -/** Acceleration function that maps [0,1] to [0,1] linearly, ie it -returns the given time value unaltered. -*/ -static double Linear (const double nTime); - -/** Blend two points together according to the given weight. -*/ -static double Blend (const double nStartValue, const double nEndValue, const double nWeight); -}; - - - - class AnimationBezierFunction { public: diff --git a/sd/source/ui/view/ViewShellBase.cxx b/sd/source/ui/view/ViewShellBase.cxx index d5d1ded..414dc5d 100644 --- a/sd/source/ui/view/ViewShellBase.cxx +++ b/sd/source/ui/view/ViewShellBase.cxx @@ -239,25 +239,11 @@ SfxViewShell* ViewShellBase::CreateInstance ( pBase-LateInit(); return pBase; } -void ViewShellBase::RegisterFactory( sal_uInt16 nPrio ) -{ -pFactory = new SfxViewFactory( CreateInstance,nPrio,Default ); -InitFactory(); -} -void ViewShellBase::InitFactory() -{ -
[Libreoffice-commits] .: filter/source
filter/source/graphicfilter/idxf/dxftblrd.cxx | 208 -- 1 file changed, 131 insertions(+), 77 deletions(-) New commits: commit 1aba513f9092d5b61e9a1da3eb1b7f6c9c9055d2 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sun Oct 14 23:49:56 2012 -0500 coverty: misuses of strncpy Change-Id: I13b3f176fc37b49e1bb7b191e97ef657eafaebe6 Reviewed-on: https://gerrit.libreoffice.org/876 Reviewed-by: David Ostrovsky david.ostrov...@gmx.de Reviewed-by: Eike Rathke er...@redhat.com Reviewed-by: Petr Mladek pmla...@suse.cz Tested-by: Petr Mladek pmla...@suse.cz diff --git a/filter/source/graphicfilter/idxf/dxftblrd.cxx b/filter/source/graphicfilter/idxf/dxftblrd.cxx index 9448cec..f99de87 100644 --- a/filter/source/graphicfilter/idxf/dxftblrd.cxx +++ b/filter/source/graphicfilter/idxf/dxftblrd.cxx @@ -40,28 +40,42 @@ void DXFLType::Read(DXFGroupReader rDGR) { switch (rDGR.GetG()) { -case 2: strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; -case 70: nFlags=rDGR.GetI(); break; -case 3: strncpy( sDescription, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; -case 73: -if (nDashIndex!=-1) { -rDGR.SetError(); -return; -} -nDashCount=rDGR.GetI(); -if (nDashCountDXF_MAX_DASH_COUNT) -nDashCount=DXF_MAX_DASH_COUNT; -nDashIndex=0; -break; -case 40: fPatternLength=rDGR.GetF(); break; -case 49: -if (nDashCount==-1) { -rDGR.SetError(); -return; -} -if (nDashIndexnDashCount) -fDash[nDashIndex++]=rDGR.GetF(); -break; +case 2: +strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN ); +sName[DXF_MAX_STRING_LEN] = 0; +break; +case 3: +strncpy( sDescription, rDGR.GetS(), DXF_MAX_STRING_LEN ); +sDescription[DXF_MAX_STRING_LEN] = 0; +break; +case 70: +nFlags=rDGR.GetI(); +break; +case 73: +if (nDashIndex!=-1) +{ +rDGR.SetError(); +return; +} +nDashCount=rDGR.GetI(); +if (nDashCountDXF_MAX_DASH_COUNT) +{ +nDashCount=DXF_MAX_DASH_COUNT; +} +nDashIndex=0; +break; +case 40: fPatternLength=rDGR.GetF(); break; +case 49: +if (nDashCount==-1) +{ +rDGR.SetError(); +return; +} +if (nDashIndexnDashCount) +{ +fDash[nDashIndex++]=rDGR.GetF(); +} +break; } } } @@ -79,12 +93,24 @@ DXFLayer::DXFLayer() void DXFLayer::Read(DXFGroupReader rDGR) { -while (rDGR.Read()!=0) { -switch(rDGR.GetG()) { -case 2: strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; -case 70: nFlags=rDGR.GetI(); break; -case 62: nColor=rDGR.GetI(); break; -case 6: strncpy( sLineType, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; +while (rDGR.Read()!=0) +{ +switch(rDGR.GetG()) +{ +case 2: +strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN ); +sName[DXF_MAX_STRING_LEN] = 0; +break; +case 6: +strncpy( sLineType, rDGR.GetS(), DXF_MAX_STRING_LEN ); +sLineType[DXF_MAX_STRING_LEN] = 0; +break; +case 70: +nFlags=rDGR.GetI(); +break; +case 62: +nColor=rDGR.GetI(); +break; } } } @@ -107,17 +133,40 @@ DXFStyle::DXFStyle() void DXFStyle::Read(DXFGroupReader rDGR) { -while (rDGR.Read()!=0) { -switch(rDGR.GetG()) { -case 2: strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; -case 70: nFlags=rDGR.GetI(); break; -case 40: fHeight=rDGR.GetF(); break; -case 41: fWidthFak=rDGR.GetF(); break; -case 50: fOblAngle=rDGR.GetF(); break; -case 71: nTextGenFlags=rDGR.GetI(); break; -case 42: fLastHeightUsed=rDGR.GetF(); break; -case 3: strncpy( sPrimFontFile, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; -case 4: strncpy( sBigFontFile, rDGR.GetS(), DXF_MAX_STRING_LEN + 1 ); break; +while (rDGR.Read()!=0) +{ +switch(rDGR.GetG()) +{ +case 2: +strncpy( sName, rDGR.GetS(), DXF_MAX_STRING_LEN ); +sName[DXF_MAX_STRING_LEN] = 0; +break; +case 3: +strncpy( sPrimFontFile, rDGR.GetS(), DXF_MAX_STRING_LEN ); +
[PUSHED] coverty: misuses of strncpy
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/876 Approvals: Petr Mladek: Verified; Looks good to me, approved Eike Rathke: Looks good to me, but someone else must approve David Ostrovsky: Looks good to me, but someone else must approve -- To view, visit https://gerrit.libreoffice.org/876 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13b3f176fc37b49e1bb7b191e97ef657eafaebe6 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Norbert Thiebaud nthieb...@gmail.com Gerrit-Reviewer: David Ostrovsky david.ostrov...@gmx.de Gerrit-Reviewer: Eike Rathke er...@redhat.com Gerrit-Reviewer: Petr Mladek pmla...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Remove some unused methods
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/875 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/875 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9ed975309c6ed677437c6e1c2d6be4a8bd6f1e9 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Marcos Souza marcos.souza@gmail.com Gerrit-Reviewer: Petr Mladek pmla...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: TextSections, DocInfo etc in LO Base Forms
On 10/15/2012 10:59 PM, Arno Teigseth wrote: I had the impression that LO Base Forms are actually writer documents. They behave mostly like that. You mean they are not? If you look at the services supported by the form, what type is it? I don't have time to check now (late for a meeting), but you piqued my interest. But then I tried to access text sections with a macro, and ThisComponent.TextSections throws a Property or method not found: TextSections. Same happens with DocInfo (document variables) I can insert sections with Insert | Section... and hide/show them with Format|Sections... , but how can I access them with Macros? Can I? best Arno ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Andrew Pitonyak My Macro Document: http://www.pitonyak.org/AndrewMacro.odt Info: http://www.pitonyak.org/oo.php ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: big Deps ...
On 10/12/2012 06:57 PM, Michael Meeks wrote: On Thu, 2012-06-21 at 13:47 +0200, Stephan Bergmann wrote: On 06/21/2012 10:57 AM, Michael Meeks wrote: Fair enough; but we could presumably easily tweak that such that a .hdl and .hpp would be updated in lock-step; after all if the .hpp is not changed - it necessarily includes the .hdl - so we didn't really gain anything from not touching the .hpp :-) Yeah, could probably be done. Turns out that gnumake does that anyway so I pushed this to git. We miss a dependency on a single .hdl file - but that one seems so unlikely to change at all that it's worth the win I think. #include com/sun/star/uno/TypeClass.hdl in cppu/inc/com/sun/star/uno/Type.h? (Caused by the broken design of having TypeClass as a UNOIDL entity instead of as a language-binding--specific entity like the C++ Type class.) I'm not really a fan of fast vs. correct. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: basctl/source
basctl/source/basicide/moduldlg.hxx | 10 - basctl/source/basicide/scriptdocument.cxx | 176 ++ 2 files changed, 91 insertions(+), 95 deletions(-) New commits: commit e6b28a09f4bf9cfd30c1851d5ed9fb44c1423881 Author: Ricardo Montania rica...@linuxafundo.com.br Date: Sun Oct 14 19:00:25 2012 -0300 More rtl::OUString cleanup in basctl Change-Id: Ife2754b17e111c0e129670b95bd2e16d81ad906c Reviewed-on: https://gerrit.libreoffice.org/873 Reviewed-by: Petr Mladek pmla...@suse.cz Tested-by: Petr Mladek pmla...@suse.cz diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx index 71f6e66..1179a9c 100644 --- a/basctl/source/basicide/moduldlg.hxx +++ b/basctl/source/basicide/moduldlg.hxx @@ -105,7 +105,7 @@ class ExtTreeListBox : public TreeListBox { protected: virtual sal_BoolEditingEntry( SvLBoxEntry* pEntry, Selection rSel ); -virtual sal_BoolEditedEntry( SvLBoxEntry* pEntry, const rtl::OUString rNewText ); +virtual sal_BoolEditedEntry( SvLBoxEntry* pEntry, const OUString rNewText ); virtual DragDropModeNotifyStartDrag( TransferDataContainer rData, SvLBoxEntry* pEntry ); virtual sal_BoolNotifyAcceptDrop( SvLBoxEntry* pEntry ); @@ -142,7 +142,7 @@ public: virtual voidInitEntry( SvLBoxEntry*, const XubString, const Image, const Image, SvLBoxButtonKind eButtonKind ); virtual sal_BoolEditingEntry( SvLBoxEntry* pEntry, Selection rSel ); -virtual sal_BoolEditedEntry( SvLBoxEntry* pEntry, const rtl::OUString rNewText ); +virtual sal_BoolEditedEntry( SvLBoxEntry* pEntry, const OUString rNewText ); voidSetDocument( const ScriptDocument rDocument ) { m_aDocument = rDocument; } @@ -165,7 +165,7 @@ public: LibDialog( Window* pParent ); ~LibDialog(); -voidSetStorageName( const ::rtl::OUString rName ); +voidSetStorageName( const OUString rName ); CheckBox GetLibBox() { return aLibBox; } boolIsReference() const { return aReferenceBox.IsChecked(); } @@ -205,7 +205,7 @@ protected: DECL_LINK( BasicBoxHighlightHdl, TreeListBox * ); DECL_LINK( ButtonHdl, Button * ); voidCheckButtons(); -boolGetSelection( ScriptDocument rDocument, ::rtl::OUString rLibName ); +boolGetSelection( ScriptDocument rDocument, OUString rLibName ); voidDeleteCurrent(); voidNewModule(); voidNewDialog(); @@ -274,7 +274,7 @@ public: // Helper functions SbModule* createModImpl( Window* pWin, const ScriptDocument rDocument, -TreeListBox rBasicBox, const ::rtl::OUString rLibName, ::rtl::OUString aModName, bool bMain = false ); +TreeListBox rBasicBox, const OUString rLibName, OUString aModName, bool bMain = false ); void createLibImpl( Window* pWin, const ScriptDocument rDocument, CheckBox* pLibBox, TreeListBox* pBasicBox ); diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx index cdf91fb..d61de8f 100644 --- a/basctl/source/basicide/scriptdocument.cxx +++ b/basctl/source/basicide/scriptdocument.cxx @@ -231,7 +231,7 @@ namespace basctl getLibraryContainer( LibraryContainerType _eType ) const; /// determines whether a given library is part of the shared installation -boolisLibraryShared( const ::rtl::OUString _rLibName, LibraryContainerType _eType ); +boolisLibraryShared( const OUString _rLibName, LibraryContainerType _eType ); /** returns the current frame of the document @@ -252,30 +252,28 @@ namespace basctl boolisDocumentModified() const; boolsaveDocument( const Reference XStatusIndicator _rxStatusIndicator ) const; -::rtl::OUString -getTitle() const; -::rtl::OUString -getURL() const; +OUStringgetTitle() const; +OUStringgetURL() const; boolallowMacros() const; Reference XNameContainer -getLibrary( LibraryContainerType _eType, const ::rtl::OUString _rLibName, bool _bLoadLibrary ) const +getLibrary( LibraryContainerType _eType, const OUString _rLibName, bool _bLoadLibrary ) const SAL_THROW((NoSuchElementException)); -boolhasLibrary( LibraryContainerType _eType, const ::rtl::OUString _rLibName ) const; +boolhasLibrary( LibraryContainerType _eType, const OUString _rLibName ) const; Reference XNameContainer -getOrCreateLibrary( LibraryContainerType _eType, const ::rtl::OUString _rLibName ) const; +getOrCreateLibrary(
[PUSHED] More rtl::OUString cleanup in basctl
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/873 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/873 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife2754b17e111c0e129670b95bd2e16d81ad906c Gerrit-PatchSet: 3 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ricardo Montania rica...@linuxafundo.com.br Gerrit-Reviewer: Olivier Hallot olivier.hal...@alta.org.br Gerrit-Reviewer: Petr Mladek pmla...@suse.cz Gerrit-Reviewer: Ricardo Montania rica...@linuxafundo.com.br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: oox/source
oox/source/vml/vmlshape.cxx |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit b0176f6245b996cdfabdce7ca299b95e4b64bb88 Author: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Date: Fri Oct 5 15:30:11 2012 +0200 vml import: only apply width-percent attribute if it's != 0 This fixes an issue with a shape defined with these attributes: mso-width-percent:0;mso-height-percent:0 and mso-width-relative:page;mso-height-relative:page; where all points were then located in (0,0) Change-Id: I51070ad2b2e4e05ab64f16813472ca1d7099fb09 Reviewed-on: https://gerrit.libreoffice.org/775 Reviewed-by: Petr Mladek pmla...@suse.cz Tested-by: Petr Mladek pmla...@suse.cz diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx index fcc0da5..8d84edd 100644 --- a/oox/source/vml/vmlshape.cxx +++ b/oox/source/vml/vmlshape.cxx @@ -463,7 +463,9 @@ Reference XShape SimpleShape::implConvertAndInsert( const Reference XShapes if ( maTypeModel.maWidthRelative.isEmpty() || maTypeModel.maWidthRelative == page ) { sal_Int16 nWidth = maTypeModel.maWidthPercent.toInt32() / 10; -PropertySet( xShape ).setAnyProperty(PROP_RelativeWidth, makeAny( nWidth ) ); +// Only apply if nWidth != 0 +if ( nWidth ) +PropertySet( xShape ).setAnyProperty(PROP_RelativeWidth, makeAny( nWidth ) ); } } if ( !maTypeModel.maHeightPercent.isEmpty( ) ) @@ -472,7 +474,9 @@ Reference XShape SimpleShape::implConvertAndInsert( const Reference XShapes if ( maTypeModel.maHeightRelative.isEmpty() || maTypeModel.maHeightRelative == page ) { sal_Int16 nHeight = maTypeModel.maHeightPercent.toInt32() / 10; -PropertySet( xShape ).setAnyProperty(PROP_RelativeHeight, makeAny( nHeight ) ); +// Only apply if nHeight != 0 +if ( nHeight ) +PropertySet( xShape ).setAnyProperty(PROP_RelativeHeight, makeAny( nHeight ) ); } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED] vml import: only apply width-percent attribute if it's != 0
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/775 Approvals: Petr Mladek: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/775 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51070ad2b2e4e05ab64f16813472ca1d7099fb09 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Gerrit-Reviewer: Petr Mladek pmla...@suse.cz Gerrit-Reviewer: Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com Gerrit-Reviewer: Tomáš Chvátal tchva...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/submodules' - g
g |4 1 file changed, 4 insertions(+) New commits: commit 9a09c3abe571b1c9b4f73539d698e49939aab490 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 16 10:29:28 2012 -0500 try to prevent old tinbuild2 to break with submodules Change-Id: I8beaf4ce41fa12161e9568748f15672c4f67ae1e diff --git a/g b/g index f7fcc78..7c8e9af 100755 --- a/g +++ b/g @@ -323,6 +323,10 @@ case $COMMAND in rc=$? refresh_all_hooks ;; +rev-parse) + echo core:$(git rev-parse $@) + rc=$? + ;; tag) do_git_cmd ${COMMAND} $@ rc=$? ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/submodules' - 2 commits - binfilter dictionaries
binfilter|2 +- dictionaries |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 42dfbe9d4f4e3f60f3a27a560a96ddf1b631e1b7 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 2 13:01:58 2012 -0500 Updated core Project: dictionaries 508deb804294871ff540f669350f093a191d2e8e add a README to the dictionaries module diff --git a/dictionaries b/dictionaries index 5f27567..508deb8 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 5f275675ff472ec6c8147697c4a149e1ce5f968c +Subproject commit 508deb804294871ff540f669350f093a191d2e8e commit 9ec8794b55797e566f08e55082ef508100b485c3 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Sep 25 08:05:24 2012 -0500 Updated core Project: binfilter 45565e1ee1258814b1de7321647c2a7dea8832d5 ignore the right build-dir... now one level up diff --git a/binfilter b/binfilter index 6501eb7..45565e1 16 --- a/binfilter +++ b/binfilter @@ -1 +1 @@ -Subproject commit 6501eb7a7f6ab7dba2223a5b8a721290ef1be627 +Subproject commit 45565e1ee1258814b1de7321647c2a7dea8832d5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[ATTENTION] the merge of the submodules feature has been done... now on master
see http://wiki.documentfoundation.org/Development/Submodules for details Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 9 commits - bin/create_bootstrap_links binfilter config_host.mk.in configure.in dictionaries download g .git-hooks/commit-msg git-hooks/commit-msg .git-hooks/post-merge git-ho
.git-hooks/commit-msg| 173 .git-hooks/post-merge| 12 .git-hooks/pre-commit| 135 ++ .gitignore |6 .gitmodules | 16 bin/create_bootstrap_links | 26 - binfilter|1 config_host.mk.in|1 configure.in |6 dictionaries |1 download | 24 - g| 631 +-- git-hooks/commit-msg | 173 git-hooks/post-merge | 12 git-hooks/pre-commit | 135 -- helpcontent2 |1 translations |1 writerfilter/source/filter/RtfFilter.cxx | 16 18 files changed, 662 insertions(+), 708 deletions(-) New commits: commit 42e965947327583355fe8a743d06da2debc654da Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 16 11:23:24 2012 -0500 rebase submodules Change-Id: I96db9172e46697b372044f1fa73d5abbce9f3fe0 diff --git a/binfilter b/binfilter index 6501eb7..45565e1 16 --- a/binfilter +++ b/binfilter @@ -1 +1 @@ -Subproject commit 6501eb7a7f6ab7dba2223a5b8a721290ef1be627 +Subproject commit 45565e1ee1258814b1de7321647c2a7dea8832d5 diff --git a/dictionaries b/dictionaries index ce1a435..508deb8 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit ce1a4352c1dd4dde7c549eb31d1d40d56704fcbf +Subproject commit 508deb804294871ff540f669350f093a191d2e8e diff --git a/helpcontent2 b/helpcontent2 index 4507e5f..a7d7be2 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4507e5f21836724cf768cf4e3ffbbf4ada6c87c3 +Subproject commit a7d7be20a6379bbd96a41a93f1c0edd55f1eca51 diff --git a/translations b/translations index f83717c..2548be5 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit f83717cf73f4549d9ae09bc557d59316d4165394 +Subproject commit 2548be535019c0a869c5759419c6964db5f82471 commit c58b4fcd35e0772fcc6b457397fcb388deba8dd3 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 2 13:29:01 2012 -0500 missing fi in ./g Change-Id: Ic763d7cd73c2a3df8e5d5146eaf795188d8c79d1 diff --git a/g b/g index f70cac1..aa53015 100755 --- a/g +++ b/g @@ -147,6 +147,7 @@ local repo if [ -n $repo ] ; then cp -r ${repo?} ${module?}/. fi + fi done } commit 3f136b50a9fbc5659170709284871e4a534d573c Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 2 13:24:09 2012 -0500 Updated core Project: translations f83717cf73f4549d9ae09bc557d59316d4165394 null add a README to the translations module Change-Id: Iccfc83d5e9ec87802e88f83da1181493630805ea Reviewed-on: https://gerrit.libreoffice.org/751 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/translations b/translations index 751ae9d..f83717c 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 751ae9de9563da8b26aef8e5c0f80ad502fbfe81 +Subproject commit f83717cf73f4549d9ae09bc557d59316d4165394 commit b4aab8089862a4b140b97c3c1bddde47601a257f Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 2 13:22:42 2012 -0500 gitsubmodule gerrit specific keyword seems to be 'branch' not 'revision' Change-Id: I8dfaa7854755cc8db5cbea9c8f682975dcb31d4f diff --git a/.gitmodules b/.gitmodules index f44a16d..2bba7a2 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,16 +1,16 @@ [submodule binfilter] path = binfilter url = git://gerrit.libreoffice.org/binfilter - revision = . + branch = . [submodule dictionaries] path = dictionaries url = git://gerrit.libreoffice.org/dictionaries - revision = . + branch = . [submodule helpcontent2] path = helpcontent2 url = git://gerrit.libreoffice.org/help - revision = . + branch = . [submodule translations] path = translations url = git://gerrit.libreoffice.org/translations - revision = . + branch = . diff --git a/dictionaries b/dictionaries index 19dba71..ce1a435 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 19dba715c843961a18bbc8871373e33be165c4ab +Subproject commit ce1a4352c1dd4dde7c549eb31d1d40d56704fcbf commit a31714fb759a67a85a6007a70ba58f0530b24311 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 2 12:59:44 2012 -0500 add tag support to ./g, try to optimize pre-post submerge situation Change-Id: I052817865da6df193c0451eccc3b8b6f507845a3 diff --git a/g b/g index 7c6551c..f70cac1 100755 --- a/g +++ b/g @@ -125,6 +125,31 @@ get_configured_submodules() fi }
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
Le 16/10/2012 18:32, Norbert Thiebaud a écrit : see http://wiki.documentfoundation.org/Development/Submodules for details Hi Norbert, I now get this error when building the master : /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk: Aucun fichier ou dossier de ce type /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: *** No target registered while reading /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk!. Arrêt. Is it related to the last changes ? Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
Le 16/10/2012 22:02, Jean-Baptiste Faure a écrit : Le 16/10/2012 18:32, Norbert Thiebaud a écrit : see http://wiki.documentfoundation.org/Development/Submodules for details Hi Norbert, I now get this error when building the master : /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk: Aucun fichier ou dossier de ce type /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: *** No target registered while reading /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk!. Arrêt. Is it related to the last changes ? In .../master/dictionaries/ I renamed Dictionary_pt.mk to Dictionary_pt-BR.mk and Dictionary_pt-pt.mk to Dictionary_pt-PT.mk and it seems to work better (build in progress). Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Daily builds for Debian
On Tue, Oct 16, 2012 at 12:20 PM, Michael Stahl mst...@redhat.com wrote: On 16/10/12 11:06, Lior Kaplan wrote: Hi, I was looking to test a daily build for Debian, and it seems that we only have RPM daily builds. http://dev-builds.libreoffice.org/daily/Linux-Fedora17-x86_64@4-gcc-4.7-dbgutil/master/current/ (other Linux build servers work on 3.5 and 3.6, but not master) Am I missing something or is that really the case? no idea if that is the case, but it's not usually a problem, because you can just install the RPMs in any directory on a Debian system as well, you just don't get system integration (desktop menus, mimetypes) that way. Thanks for the idea, I know it's technically possible, but as I'm also doing packaging for the Debian project, I find this option as non acceptable. I'll be happy to help to whom ever is maintaining the builds servers, so there will be a build for Debian. Kaplan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2330695f0582a270c05fa19d45fc21c0dc6b62d1 Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 17:14:52 2012 -0400 update helpcontent2 Change-Id: Ie77cb97858bd7b55205a98e89d00851079cc4322 diff --git a/helpcontent2 b/helpcontent2 index a7d7be2..98ad8db 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit a7d7be20a6379bbd96a41a93f1c0edd55f1eca51 +Subproject commit 98ad8dbf5ace1048254c534044e207aeec89741a ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - wizards/com
wizards/com/sun/star/wizards/common/Configuration.py | 175 -- wizards/com/sun/star/wizards/common/Desktop.py | 37 -- wizards/com/sun/star/wizards/common/Resource.py|7 wizards/com/sun/star/wizards/common/SystemDialog.py| 22 - wizards/com/sun/star/wizards/fax/FaxWizardDialogImpl.py|1 wizards/com/sun/star/wizards/letter/CGLetter.py|5 wizards/com/sun/star/wizards/letter/CGLetterWizard.py |5 wizards/com/sun/star/wizards/letter/CGPaperElementLocation.py |3 wizards/com/sun/star/wizards/letter/LetterDocument.py |8 wizards/com/sun/star/wizards/letter/LetterWizardDialog.py | 152 +--- wizards/com/sun/star/wizards/letter/LetterWizardDialogConst.py | 116 +++--- wizards/com/sun/star/wizards/letter/LetterWizardDialogImpl.py | 32 + wizards/com/sun/star/wizards/letter/LetterWizardDialogResources.py |2 13 files changed, 190 insertions(+), 375 deletions(-) New commits: commit 09f2d543df57ba049a9968292576f6315a51888d Author: Xisco Fauli aniste...@gmail.com Date: Tue Oct 16 23:39:14 2012 +0200 pywizards: cleanup common code Change-Id: I6e64ec407326b5759664ace286eb67b2c6cd3b04 diff --git a/wizards/com/sun/star/wizards/common/Configuration.py b/wizards/com/sun/star/wizards/common/Configuration.py index 1b6db1f..69e150c 100644 --- a/wizards/com/sun/star/wizards/common/Configuration.py +++ b/wizards/com/sun/star/wizards/common/Configuration.py @@ -20,21 +20,8 @@ import traceback from .PropertyNames import PropertyNames from .Helper import Helper -''' -This class gives access to the OO configuration api. -It contains 4 get and 4 set convenience methods for getting and settings -properties in the configuration. br/ -For the get methods, two parameters must be given: name and parent, where -name is the name of the property, parent is a HierarchyElement -(::com::sun::star::configuration::HierarchyElement)br/ -The get and set methods support hieryrchical property names like -options/gridX. br/ -NOTE: not yet supported, but sometime later, -If you will ommit the parent parameter, then the name parameter must be -in hierarchy form from the root of the registry. -''' - class Configuration(object): +'''This class gives access to the OO configuration api.''' @classmethod def getConfigurationRoot(self, xmsf, sPath, updateable): @@ -59,163 +46,3 @@ class Configuration(object): sView = com.sun.star.configuration.ConfigurationAccess return oConfigProvider.createInstanceWithArguments(sView, tuple(args)) - -@classmethod -def getProductName(self, xMSF): -try: -oProdNameAccess = self.getConfigurationRoot(xMSF, -org.openoffice.Setup/Product, False) -ProductName = Helper.getUnoObjectbyName(oProdNameAccess, ooName) -return ProductName -except Exception: -traceback.print_exc() -return None - -@classmethod -def getOfficeLocaleString(self, xMSF): -sLocale = -try: -aLocLocale = Locale.Locale() -oMasterKey = self.getConfigurationRoot(xMSF, -org.openoffice.Setup/L10N/, False) -sLocale = (String) -Helper.getUnoObjectbyName(oMasterKey, ooLocale) -except Exception, exception: -traceback.print_exc() - -return sLocale - -@classmethod -def getOfficeLocale(self, xMSF): -aLocLocale = Locale.Locale() -sLocale = getOfficeLocaleString(xMSF) -sLocaleList = JavaTools.ArrayoutofString(sLocale, -) -aLocLocale.Language = sLocaleList[0] -if sLocaleList.length 1: -aLocLocale.Country = sLocaleList[1] - -return aLocLocale - -@classmethod -def removeNode(self, configView, name, xmsf=None): -commitChanges = False -if xmsf is not None: -configView = self.getConfigurationRoot(xmsf, path, True) -commit = True - -if configView.hasByName(name): -configView.removeByName(name) - -if commitChanges: -configView.commitChanges() - -@classmethod -def updateConfiguration(self, xmsf, path, name, node, param): -view = self.getConfigurationRoot(xmsf, path, True) -addConfigNode(path, name) -node.writeConfiguration(view, param) -view.commitChanges() - -@classmethod -def getNodeDisplayNames(self, _xNameAccessNode): -snames = None -return getNodeChildNames(_xNameAccessNode, -PropertyNames.PROPERTY_NAME) - -@classmethod -def getNodeChildNames(self, xNameAccessNode, _schildname): -snames = None -try: -snames = xNameAccessNode.getElementNames() -sdisplaynames = range(snames.length) -i = 0 -while i
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dc680471aa6d7121918690671638b7bb21639951 Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 18:06:26 2012 -0400 Updated core Project: help 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 update gitignore diff --git a/helpcontent2 b/helpcontent2 index 98ad8db..6b83924 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 98ad8dbf5ace1048254c534044e207aeec89741a +Subproject commit 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: .gitignore helpcontent2/.gitignore
.gitignore |7 +-- helpcontent2/.gitignore |1 - 2 files changed, 5 insertions(+), 3 deletions(-) New commits: commit 6b8392485c4b81d0a398a8c88a0e1f7ab53365f5 Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 18:06:26 2012 -0400 update gitignore diff --git a/.gitignore b/.gitignore index f54991d..711d138 100644 --- a/.gitignore +++ b/.gitignore @@ -3,9 +3,12 @@ .*.sw[op] .gitattributes +# Wiki +/wikisetup.txt + # Python -helpcontent2/wiki-to-help/*.pyc -helpcontent2/wiki-to-help/mwlib_mods/*.pyc +/wiki-to-help/*.pyc +/wiki-to-help/mwlib_mods/*.pyc # the build directories /unxlng?? diff --git a/helpcontent2/.gitignore b/helpcontent2/.gitignore deleted file mode 100644 index 0ff7b08..000 --- a/helpcontent2/.gitignore +++ /dev/null @@ -1 +0,0 @@ -/wikisetup.txt ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 923d33db64328f955060a837ceeb9f7aac1653cb Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 16 16:32:25 2012 -0500 Updated core Project: dictionaries 2547e9657a49fb43e07a41aadfdd0af34b7ae720 rename mishappe during merge diff --git a/dictionaries b/dictionaries index 508deb8..2547e96 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 508deb804294871ff540f669350f093a191d2e8e +Subproject commit 2547e9657a49fb43e07a41aadfdd0af34b7ae720 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] Translate German comments
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/879 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/879/1 Translate German comments Change-Id: I19850b38bd3cefeb759e152c3af22daf2829ffe7 --- M sw/source/core/docnode/node.cxx 1 file changed, 123 insertions(+), 173 deletions(-) -- To view, visit https://gerrit.libreoffice.org/879 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I19850b38bd3cefeb759e152c3af22daf2829ffe7 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Dictionary_pt-BR.mk Dictionary_pt.mk Dictionary_pt-pt.mk Dictionary_pt-PT.mk .gitignore
.gitignore | 55 Dictionary_pt-BR.mk | 21 +++ Dictionary_pt-PT.mk | 26 Dictionary_pt-pt.mk | 26 Dictionary_pt.mk| 21 --- 5 files changed, 47 insertions(+), 102 deletions(-) New commits: commit 2547e9657a49fb43e07a41aadfdd0af34b7ae720 Author: Norbert Thiebaud nthieb...@gmail.com Date: Tue Oct 16 16:32:25 2012 -0500 rename mishappe during merge diff --git a/.gitignore b/.gitignore deleted file mode 100644 index eb75b8c..000 --- a/.gitignore +++ /dev/null @@ -1,55 +0,0 @@ -# -# Version: MPL 1.1 / GPLv3+ / LGPLv3+ -# -# The contents of this file are subject to the Mozilla Public License Version -# 1.1 (the License); you may not use this file except in compliance with -# the License or as specified alternatively below. You may obtain a copy of -# the License at http://www.mozilla.org/MPL/ -# -# Software distributed under the License is distributed on an AS IS basis, -# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License -# for the specific language governing rights and limitations under the -# License. -# -# Major Contributor(s): -# [ Copyright (C) 2011 Stephan Bergmann, Red Hat Inc. sberg...@redhat.com -# (initial developer) ] -# -# All Rights Reserved. -# -# For minor contributions see the git repository. -# -# Alternatively, the contents of this file may be used under the terms of -# either the GNU General Public License Version 3 or later (the GPLv3+), or -# the GNU Lesser General Public License Version 3 or later (the LGPLv3+), -# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable -# instead of those above. -# - -# Backup files: -*~ - -# Build directories: -/dictionaries/unxlng?? -/dictionaries/unxlng??.pro -/dictionaries/unxlng??? -/dictionaries/unxlng???.pro -/dictionaries/wntmsc??? -/dictionaries/wntmsc???.pro -/dictionaries/wntgcc? -/dictionaries/wntgcc?.pro -/dictionaries/unxmac?? -/dictionaries/unxmac??.pro -/dictionaries/unx?bsd?? -/dictionaries/unx?bsd??.pro -/dictionaries/unxdfly?? -/dictionaries/unxdfly??.pro -/dictionaries/unxso??? -/dictionaries/unxso???.pro -/dictionaries/unxaig?? -/dictionaries/unxaig??.pro -/dictionaries/unxios? -/dictionaries/unxios?.pro -/dictionaries/unxand? -/dictionaries/unxand?.pro - diff --git a/Dictionary_pt-BR.mk b/Dictionary_pt-BR.mk new file mode 100644 index 000..9e0d45f --- /dev/null +++ b/Dictionary_pt-BR.mk @@ -0,0 +1,21 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_Dictionary_Dictionary,dict-pt,dictionaries/pt_BR)) + +$(eval $(call gb_Dictionary_add_root_files,dict-pt,\ + dictionaries/pt_BR/hyph_pt_BR.dic \ + dictionaries/pt_BR/pt_BR.aff \ + dictionaries/pt_BR/pt_BR.dic \ + dictionaries/pt_BR/README_en.txt \ + dictionaries/pt_BR/README_hyph_pt_BR.txt \ + dictionaries/pt_BR/README_pt_BR.txt \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/Dictionary_pt-PT.mk b/Dictionary_pt-PT.mk new file mode 100644 index 000..12c68fe --- /dev/null +++ b/Dictionary_pt-PT.mk @@ -0,0 +1,26 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +$(eval $(call gb_Dictionary_Dictionary,dict-pt-pt,dictionaries/pt_PT)) + +$(eval $(call gb_Dictionary_add_root_files,dict-pt-pt,\ + dictionaries/pt_PT/hyph_pt_PT.dic \ + dictionaries/pt_PT/LICENSES.txt \ + dictionaries/pt_PT/pt_PT.aff \ + dictionaries/pt_PT/pt_PT.dic \ + dictionaries/pt_PT/README_hyph_pt_PT.txt \ + dictionaries/pt_PT/README_pt_PT.txt \ + dictionaries/pt_PT/README_th_pt_PT_v2.txt \ +)) + +$(eval $(call gb_Dictionary_add_thesauri,dict-pt-pt,\ + dictionaries/pt_PT/th_pt_PT_v2.dat \ +)) + +# vim: set noet sw=4 ts=4: diff --git a/Dictionary_pt-pt.mk b/Dictionary_pt-pt.mk deleted file mode 100644 index 12c68fe..000 --- a/Dictionary_pt-pt.mk +++ /dev/null @@ -1,26 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# - -$(eval $(call gb_Dictionary_Dictionary,dict-pt-pt,dictionaries/pt_PT)) - -$(eval $(call gb_Dictionary_add_root_files,dict-pt-pt,\ -
[Libreoffice-commits] .: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 96336f30092a84c8314ee29fd245b71ec24c4a49 Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 18:19:59 2012 -0400 Updated core Project: dictionaries a70847fe89812a53297f06e5c8c5ef9a22146a7f update makefile path diff --git a/dictionaries b/dictionaries index 2547e96..a70847f 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit 2547e9657a49fb43e07a41aadfdd0af34b7ae720 +Subproject commit a70847fe89812a53297f06e5c8c5ef9a22146a7f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Makefile
Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a70847fe89812a53297f06e5c8c5ef9a22146a7f Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 18:19:59 2012 -0400 update makefile path Change-Id: Ia6b912ef6575c6d743a754a10b8844bfefdc7487 diff --git a/Makefile b/Makefile index 6b38ac5..9a3193f 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ module_directory=$(dir $(realpath $(firstword $(MAKEFILE_LIST ifeq ($(origin SRC_ROOT),undefined) -SRC_ROOT=$(module_directory)../../.. +SRC_ROOT=$(module_directory).. endif include $(SRC_ROOT)/solenv/gbuild/partial_build.mk ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [ATTENTION] the merge of the submodules feature has been done... now on master
On Tue, Oct 16, 2012 at 3:25 PM, Jean-Baptiste Faure jbf.fa...@sud-ouest.org wrote: Le 16/10/2012 22:02, Jean-Baptiste Faure a écrit : Le 16/10/2012 18:32, Norbert Thiebaud a écrit : see http://wiki.documentfoundation.org/Development/Submodules for details Hi Norbert, I now get this error when building the master : /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk: Aucun fichier ou dossier de ce type /home/jbf/LibO/master//dictionaries/Module_dictionaries.mk:12: *** No target registered while reading /home/jbf/LibO/master/dictionaries/Dictionary_pt-BR.mk!. Arrêt. Is it related to the last changes ? In .../master/dictionaries/ I renamed Dictionary_pt.mk to Dictionary_pt-BR.mk and Dictionary_pt-pt.mk to Dictionary_pt-PT.mk and it seems to work better (build in progress). yes I'm pushing a patch to that effect Norert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Translate German comments to English
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/880 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/880/1 Translate German comments to English Change-Id: If9483ca830c7902094c0e0d5a15755931ae87c46 --- M sw/source/core/docnode/swbaslnk.cxx 1 file changed, 32 insertions(+), 35 deletions(-) -- To view, visit https://gerrit.libreoffice.org/880 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If9483ca830c7902094c0e0d5a15755931ae87c46 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Philipp Weissenbacher p.weissenbac...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Better senddoc mailto selection for null and default mailer cases
senddoc.sh has separate cases for unknown mailer and for no mailer configured. Both of these cases attempt to find a desktop mailto handler, using different methods. This patch merges these two cases and the strategies for finding the handler. Note that there is ambiguity as to the proper mailto keyword for attachments. I've used 'attachment', per direction in the referenced xdg list email. This builds on https://bugs.freedesktop.org/show_bug.cgi?id=32621 From 72e9d8b49f5896d3afc308236691a882fc87f44f Mon Sep 17 00:00:00 2001 From: David Steele dste...@gmail.com Date: Tue, 16 Oct 2012 19:11:37 -0400 Subject: [PATCH] Combine senddoc null and default cases for better mailer selection. --- shell/source/unix/misc/senddoc.sh | 60 + 1 file changed, 8 insertions(+), 52 deletions(-) diff --git a/shell/source/unix/misc/senddoc.sh b/shell/source/unix/misc/senddoc.sh index 5a755d7..0ff1594 100644 --- a/shell/source/unix/misc/senddoc.sh +++ b/shell/source/unix/misc/senddoc.sh @@ -369,62 +369,18 @@ case `basename $MAILER | sed 's/-.*$//'` in /usr/bin/open -a ${MAILER} ${ATTACH} ;; -) - -# DESKTOP_LAUNCH, see http://freedesktop.org/pipermail/xdg/2004-August/004489.html -if [ -n $DESKTOP_LAUNCH ]; then -while [ $1 != ]; do -case $1 in ---to) -if [ ${TO} != ]; then -MAILTO=${MAILTO:-}${MAILTO:+}to=$2 -else -TO=$2 -fi -shift -;; ---cc) -MAILTO=${MAILTO:-}${MAILTO:+}cc=`echo $2 | ${URI_ENCODE}` -shift -;; ---bcc) -MAILTO=${MAILTO:-}${MAILTO:+}bcc=`echo $2 | ${URI_ENCODE}` -shift -;; ---subject) -MAILTO=${MAILTO:-}${MAILTO:+}subject=`echo $2 | ${URI_ENCODE}` -shift -;; ---body) -MAILTO=${MAILTO:-}${MAILTO:+}body=`echo $2 | ${URI_ENCODE}` -shift -;; ---attach) - MAILTO=${MAILTO:-}${MAILTO:+}attachment=`echo $2 | ${URI_ENCODE}` -shift -;; -*) -;; -esac -shift; -done - -MAILTO=mailto:${TO}?${MAILTO}; -${DESKTOP_LAUNCH} ${MAILTO} -else -echo Could not determine a mail client to use. -exit 2 -fi -;; - *) -# LO is configured to use something we do not recognize. + +# LO is configured to use something we do not recognize, or is not configured. # Try to be smart, and send the mail anyway, if we have the # possibility to do so. -if [ -n $KDE_FULL_SESSION -a -x /usr/bin/kde-open ] ; then +if [ -n $DESKTOP_LAUNCH ]; then +# http://lists.freedesktop.org/pipermail/xdg/2004-August/002873.html +MAILER=${DESKTOP_LAUNCH} +elif [ -n $KDE_FULL_SESSION -a -x /usr/bin/kde-open ] ; then MAILER=/usr/bin/kde-open -elif [ -x /usr/bin/gnome-open ] ; then +elif [ -n $GNOME_DESKTOP_SESSION_ID -a -x /usr/bin/gnome-open ] ; then MAILER=/usr/bin/gnome-open elif [ -x /usr/bin/xdg-open ] ; then MAILER=/usr/bin/xdg-open @@ -460,7 +416,7 @@ case `basename $MAILER | sed 's/-.*$//'` in shift ;; --attach) -MAILTO=${MAILTO:-}${MAILTO:+}attach=`echo file://$2 | ${URI_ENCODE}` +MAILTO=${MAILTO:-}${MAILTO:+}attachment=`echo file://$2 | ${URI_ENCODE}` shift ;; *) -- 1.7.10.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] Better senddoc mailto selection for null and default mailer cases
On Tue, Oct 16, 2012 at 7:41 PM, Dave Steele dste...@gmail.com wrote: senddoc.sh has separate cases for unknown mailer and for no mailer configured. Both of these cases attempt to find a desktop mailto handler, using different methods. This patch merges these two cases and the strategies for finding the handler. ... Patch attached 0001-Combine-senddoc-null-and-default-cases-for-better-ma.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #146 from V Stuart Foote vstuart.fo...@utsa.edu --- Nominate fdo#53474 [Accessibility] Java Accessibility Bridge not mapping UNO Accessibility roles -- no functional Java based Assistive Technology for Windows builds. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: g
g |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 41b5c80add33a59222dab06277fad4ec2e1f7183 Author: Peter Foley pefol...@verizon.net Date: Tue Oct 16 20:43:21 2012 -0400 cleanup ./g output Change-Id: I84a775ceb983ad21d4585a3c3718f99bbac5a282 diff --git a/g b/g index aa53015..9112274 100755 --- a/g +++ b/g @@ -19,7 +19,7 @@ usage() echo echo Usage: g [options] [git (checkout|clone|fetch|grep|pull|push|reset) [git options/args..]] echo -echo -z restaure the git hooks and others sanity checks +echo -z restore the git hooks and do other sanity checks } refresh_submodule_hooks() @@ -323,8 +323,10 @@ case $COMMAND in tag) do_git_cmd ${COMMAND} $@ ;; + ) + ;; *) - echo ./g does not support command:$COMMAND 12 + echo ./g does not support command: $COMMAND 12 exit 1; ;; esac ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date
David, Nominated the fdo#53474 as a most annoying for 3.6. It is a regression from 3.5 and has been with us now for four build/QA reviews. Not sure of the etiquette but are you willing to take assignment of the bug? The Java Accessibility testers (JavaMonkey and JavaFerret) are pretty simplistic, but appear on a par to the Accerciser test tool for Gnome ATK AT-SPI--not sure why they would not have be invoked in QA process. Unfortunately, with both the MSVC and MinGW Tinderbox builds of Master not currently producing usable builds no way to test your patch. Any chance of getting a nod from fellow devs to push down to a 3.6 build and come at it that way? Stuart -- View this message in context: http://nabble.documentfoundation.org/RE-libreoffice-accessibility-Latest-Libo-Won-t-Play-Nice-with-myJRE-tp4012436p4013851.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Bibisect Question
Joel Madero schrieb: I don't see a list aboveam I missing something? Hi I don't remember who added those hints for what reason. I took the opportunity to add some hints http://wiki.documentfoundation.org/QA/HowToBibisect#Bugs_needing_bibisect concerning the whiteboard entry bibisecrequest, what had been introduced some months ago, but there were very few people using bibisect and so I'm afraid I was the only one who used it. And now the only bug with it is a fixed wohe where that whiteboard key word is definitively inappropriate. I think such a whiteboard key word is the most simple way to ask users for bibisecting. If users with bibisect skills subscribe a Bibisect Atom feed in Bugzilla, they will get info automatically when someone added that key word. I will restart adding that key word where appropriate now. Best regards Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Bibisect Question
Hi all, on http://wiki.documentfoundation.org/QA/HowToBibisect#Versions we need reliable info for what LibO Versions bibisecting is possible. CU Rainer ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] LDTP now works for Linux, Win Mac
Terrence Enger wrote: I have played with it a little bit, and it looks really neat. Thoughts arising ... Hi Terrence, thanks a lot for looking into this - (3) That start-and-end, with nothing in between, takes about 28 seconds. My admittedly wimpy machine could do that about 3000 times a day. This does not bode well for heavy use of the tool. That would be probably acceptable - since tasks could be distributed over many people? (4) The usually in point (1) troubles me. One execution can produce 14 levels of stack trace leading from my program statement `ldtp import *` to message socket.error: [Errno 111] Connection refused. Subsequent executions do the expected start-and-end. My newbie instinct shouts timing issue. So, the next part of the learning curve will be steeper. That is a downer indeed - the last thing you want is unreliable tests. Curious how much of that is due to the usage of the accessibility API. Which platform / versions were you using again? Cheers, -- Thorsten pgpLigeU3SpO4.pgp Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] LDTP now works for Linux, Win Mac
On Tue, 2012-10-16 at 09:04 +0200, Thorsten Behrens wrote: Terrence Enger wrote: I have played with it a little bit, and it looks really neat. Thoughts arising ... Hi Terrence, thanks a lot for looking into this - (3) That start-and-end, with nothing in between, takes about 28 seconds. My admittedly wimpy machine could do that about 3000 times a day. This does not bode well for heavy use of the tool. That would be probably acceptable - since tasks could be distributed over many people? Well, there was a message a couple days ago asking about wish lists for funding. One candidate idea would be enough capacity to run through the presumably growing set of tests every few days, where few days means a fraction of the interval between release candidates. ( Although I confess I would put a higher priority on a virtual machine set up for testing Base. Drew Jensen made some efforts toward this end early this year, IIRC. ) (4) The usually in point (1) troubles me. One execution can produce 14 levels of stack trace leading from my program statement `ldtp import *` to message socket.error: [Errno 111] Connection refused. Subsequent executions do the expected start-and-end. My newbie instinct shouts timing issue. So, the next part of the learning curve will be steeper. I read that there is a python mailing list, but it is very active. Can I cope with another hundred messages a day? Only if I am desperate, I fear. That is a downer indeed - the last thing you want is unreliable tests. Curious how much of that is due to the usage of the accessibility API. Which platform / versions were you using again? I am using ubuntu natty (11.04) 32-bit, which gives me ldtp-2.0.6. So, quite old, and it lacks ldtprecord and ldtpeditor. Ubuntu quantal (12.10) should be out in a couple of days. Maybe I will try the 64-bit version. My previous attempt at using a 64-bit version, several years ago, showed it to be notably slow; but since then I have doubled my RAM to 1GB. Hope springs eternal, and all that. Terry. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] QA work with Windows Tinderbox builds -- need help
Hello, By way of introduction to the QA List I need some advice on working with the TinderBox builds for Windows. I am currently looking at the problems with Java Accessibility - Java Access Bridge -- UNO accessibility mappings for the 3.6.x Windows builds ( https://bugs.freedesktop.org/show_bug.cgi?id=53474 ) David Tardon committed a patch that needs to be tested: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=d475a059fc9f07f4d896bd67649c7d800fc66f6f I would like to do so, and I can follow the code base and commenting with Opengrok and gerrit for the most part, but I'm stumped about the TinderBox builds. Assume the patch would be against a Master build, unless noted that it is being pushed down the 3.6 tree--but it looks like the MSVC Windows builds of Master are not running, and that the MinGW builds are suspect. http://wiki.documentfoundation.org/Development/Tinderbox http://tinderbox.libreoffice.org/MASTER/status.html http://dev-builds.libreoffice.org/daily/ Also, it looks like the builds of Master have only been bundling the directory tree as a gzipped tar--no packaging into an MSI. Is there some setup help with steps to overlay an existing LibO installation/profile with an LOdev build to end up with a useable test install? Thanks! Stuart =-=-= V Stuart Foote Senior Systems Analyst Geological Sciences The University or Texas at San Antonio ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] KDE User - Bug 46031 - Crash when opening a document from konqueror in a second LibO instance
Can someone check this one out. It's pretty old and needs to either be closed as NOTOURBUG or investigated/confirmed and addressed as it's a crasher. https://bugs.freedesktop.org/show_bug.cgi?id=46031 I don't use KDE at all, otherwise I'd give it a whirl. Thanks all Regards, Joel -- *Joel Madero* LibO QA Volunteer jmadero@gmail.com ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 56018] New: MAILMERGE: Mailmerge to file crashes when saving to type Microsoft Word 2007/2010 XML
https://bugs.freedesktop.org/show_bug.cgi?id=56018 Priority: medium Bug ID: 56018 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: MAILMERGE: Mailmerge to file crashes when saving to type Microsoft Word 2007/2010 XML Severity: normal Classification: Unclassified OS: All Reporter: tlr...@netzero.net Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.2.2 release Component: Writer Product: LibreOffice Problem description: Mail Merge to file crashes Steps to reproduce: 1. Create a MailMerge Label 2. Set Save options for Text to Microsoft Word 2007/2010 XML 3. File / Print / choose the File radio button and enter a filename. Current behavior: Mailmerge begins to run, dialog box shows record 1, 5, 10, etc and then crashes. Expected behavior: A file should be produced with the labels Platform (if different from the browser): Windows 7 Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/20100101 Firefox/15.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51023] EDITING: Drag-and-drop slide always moves slide to first position, leading to data corruption and sometimes CRASH
https://bugs.freedesktop.org/show_bug.cgi?id=51023 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Whiteboard|BSA |BSA, bibisectrequest --- Comment #35 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Added bibisectrequest, not sure whether that really will help, more for training of bibisecting staff ;-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47291] FILEOPEN: scrambled Vector Graphic (WMF?) in / from MS Word document
https://bugs.freedesktop.org/show_bug.cgi?id=47291 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Whiteboard||bibisectrequest --- Comment #20 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Added bibisectrequest, not sure whether that really will help, more for training of bibisecting staff ;-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55930] Labels of modifier keys in menus all shown as ???
https://bugs.freedesktop.org/show_bug.cgi?id=55930 --- Comment #2 from Rudolf Kollien rudolf.koll...@medas.de --- Hello, the LANG variable is set to de_DE@euro which works with 3.5.x LC variables are not set at all. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39936] Feature: add Insert Cut Cells Insert Copied Cells to Context Menu(s)
https://bugs.freedesktop.org/show_bug.cgi?id=39936 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Priority|medium |low Summary|Feature: add Insert Cut|Feature: add Insert Cut |Cells Insert Copied |Cells Insert Copied |Cells to Right-Click Menus |Cells to Context Menu(s) Keywords||NEEDINFO --- Comment #14 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- The questions are: 1) What existing(?) function? (I do not know anything like Insert Cut Cells) do we want to 2) add to what to what context menu? (Why is Paste in context menu not enough? For me that works fine, I can select whether I want to overwrite or to shift existing contents) Currently we have a Make it look like in EXCEL request, too imprecise for an easy fix and for NEW due to https://wiki.documentfoundation.org/BugTriage#Process item 5 To be honest: I don't understand this request. Can somebody contribute a real life problem with a sample document and clear description what should be improved? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55870] When copying filtered table, which contains subtotals, from calc and pasting as GDI Metafile into writer, wrong values are pasted.
https://bugs.freedesktop.org/show_bug.cgi?id=55870 --- Comment #4 from Nikos gdna7...@hotmail.com --- I also tested, that this is unrelated to enabling experimental features. Please feel free to ask for clarifications if the bug description is not clear enough. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39936] Feature: add Insert Cut Cells Insert Copied Cells to Context Menu(s)
https://bugs.freedesktop.org/show_bug.cgi?id=39936 --- Comment #15 from Gerry gerry.trep...@googlemail.com --- @Rainer: In the context menu, how can you select whether I want to overwrite or to shift existing contents? I have no option there in LibreOffice, but only paste which overwrites the content. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56007] Thumbnail generation slow on network drives
https://bugs.freedesktop.org/show_bug.cgi?id=56007 Mathieu Parent math.par...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Assignee|libreoffice-b...@lists.free |math.par...@gmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #3 from Mathieu Parent math.par...@gmail.com --- Created attachment 68605 -- https://bugs.freedesktop.org/attachment.cgi?id=68605action=edit NCP capture Here is a network capture showing the problem. It seems that there is a problem in the Windows Netware Client : When 1byte is sread, 512 are requested within the protocol. This looks like readahead (which is good), but when requesting the following byte, a new request is made (i.e the previous buffer was not cached). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56020] New: : Open file in explorer with double click
https://bugs.freedesktop.org/show_bug.cgi?id=56020 Priority: medium Bug ID: 56020 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: : Open file in explorer with double click Severity: normal Classification: Unclassified OS: All Reporter: silbermannm...@yahoo.de Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: unspecified Component: Libreoffice Product: LibreOffice Problem description: Steps to reproduce: 1. go to a network drive mapped (Novell Netware example) 2. double click to open 3. error cant open because used from a unknowed user Current behavior: Expected behavior: Platform (if different from the browser): Browser: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1250.0 Iron/22.0.2150.0 Safari/537.4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56007] Thumbnail generation slow on network drives
https://bugs.freedesktop.org/show_bug.cgi?id=56007 Mathieu Parent math.par...@gmail.com changed: What|Removed |Added Assignee|math.par...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39936] Feature: add Insert Cut Cells Insert Copied Cells to Context Menu(s)
https://bugs.freedesktop.org/show_bug.cgi?id=39936 --- Comment #16 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 68612 -- https://bugs.freedesktop.org/attachment.cgi?id=68612action=edit Hwo To Presentation What's so bad with proceeding as shown in the HoTo? @Gerry: I asked for a real life example and got a I don't know how to comment ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52967] Automatic text color is always dark gray in calc, writer
https://bugs.freedesktop.org/show_bug.cgi?id=52967 --- Comment #6 from Jan Roskovec rosko...@etf.cuni.cz --- (In reply to comment #5) Thanks for the update. The version # should be the earliest version you saw the problem, not the latest version you've tested on. For latest version tested on a comment is fine. I'll try to find someone to confirm this today as I'm still not seeing it I can confirm the described behaviour: when font color set to automatic, it is grey on white background as well as black background (cannot tell whether it is the same tone of grey). It is so throughout the suite, i.e. in Writer, Impress... I have noticed this first on version 3.6.0, it persists after upgrade to 3.6.2. It appears only on my comp with ubuntu 12.04, on the other one with ubuntu 10.04 the same version of LO behaves as it should. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56026] New: FORMATTING: page header is abnormal in word format
https://bugs.freedesktop.org/show_bug.cgi?id=56026 Priority: medium Bug ID: 56026 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING: page header is abnormal in word format Severity: normal Classification: Unclassified OS: All Reporter: hhenry@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: unspecified Component: Writer Product: LibreOffice Created attachment 68614 -- https://bugs.freedesktop.org/attachment.cgi?id=68614action=edit from the attached file ,you can check the page header is different in different software. Problem description: page header is abnormal in word format,I can provider sample file for check. Steps to reproduce: 1. 2. 3. Current behavior: Expected behavior: Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56026] FORMATTING: page header is abnormal in word format
https://bugs.freedesktop.org/show_bug.cgi?id=56026 henry cui hhenry@gmail.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) Severity|normal |critical Priority|medium |highest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56028] New: [UI]Zooming makes cell content disappear partly
https://bugs.freedesktop.org/show_bug.cgi?id=56028 Priority: medium Bug ID: 56028 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: [UI]Zooming makes cell content disappear partly Severity: normal Classification: Unclassified OS: Windows (All) Reporter: o...@dci-electronics.nl Hardware: Other Status: NEW Version: 3.6.2.2 release Component: Spreadsheet Product: LibreOffice Created attachment 68616 -- https://bugs.freedesktop.org/attachment.cgi?id=68616action=edit sample (ods) that shows problem. See attachment (sample.ods). Zoomed at 100% the complete contenst is visible. see attachment (100percent.gif) When zooming to e.g. 90% by clicking on the minus left of the zoom-scale in the status bar of the form, the content is partly hidden because it no longer fits in the cell. see attachment (90percent.gif) IMO when zooming the layout should not change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56028] [UI]Zooming makes cell content disappear partly
https://bugs.freedesktop.org/show_bug.cgi?id=56028 --- Comment #1 from Winfried Donkers o...@dci-electronics.nl --- Created attachment 68617 -- https://bugs.freedesktop.org/attachment.cgi?id=68617action=edit sample zoomed at 100% (gif) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56028] [UI]Zooming makes cell content disappear partly
https://bugs.freedesktop.org/show_bug.cgi?id=56028 --- Comment #2 from Winfried Donkers o...@dci-electronics.nl --- Created attachment 68618 -- https://bugs.freedesktop.org/attachment.cgi?id=68618action=edit sample zoomed at 90% (gif) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47291] FILEOPEN: scrambled Vector Graphic (WMF?) in / from MS Word document
https://bugs.freedesktop.org/show_bug.cgi?id=47291 --- Comment #21 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to comment #15) All letters and blue square in the NW corner are made with PolyPolygon WMF records. Missed letters and square (I only looked for BFAV and Bayerischer Facharztv) seem to have one common difference from displayed letters: PolyPolygon has no more than 11 points per polygon. All those polygons seem to be closed paths (last point is the same as the first one). Letter B in BFAV is not visible because it's white on white. You can change BG colour under picture to verify it. First missed records are 21,27,39,51,55,69,76,78 and 80. Not linked to this refactoring by any chance ? commit bcb1c850339c70a841e9a3a9b6eb68d1e031adb1 Author: Marc-Andre Laverdiere marc-an...@atc.tcs.com Date: Tue Sep 20 12:25:01 2011 +0530 Refactoring drawing of polygons and polypolygons in enhwmf.cxx Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56030] New: Nudge distance could change with zoom level
https://bugs.freedesktop.org/show_bug.cgi?id=56030 Priority: medium Bug ID: 56030 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Nudge distance could change with zoom level Severity: enhancement Classification: Unclassified OS: Linux (All) Reporter: ch3...@bath.ac.uk Hardware: Other Status: NEW Version: 3.5.6.2 release Component: Drawing Product: LibreOffice Impact: When doing fine alignment work, it is currently hard to nudge objects using the arrow keys because the movement is too coarse. Reproduction: - Create some small shapes that you want to arrange in a very specific way - Zoom in and try to move them into your desired arrangement using the arrow keys - Note that the shapes move quite a large amount (on the screen) when zoomed right in, and not very much (on the screen) when you zoom right out. - Tear hair out that you can't get fine enough control over the beautiful arrangement of your shapes! Desired behaviour: The distance a shape jumps should be in proportion with the zoom level (i.e. it should jump roughly the same distance on the screen at all times, not the same distance in the document). If this behaviour is already present, its effect is certainly not strong enough! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44990] Grid misalignment in Copy and Paste (regression in 3.5.0 wrt 3.4.x)
https://bugs.freedesktop.org/show_bug.cgi?id=44990 martinsti...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from martinsti...@gmail.com --- I cannot reproduce the bug with LO Version 3.6.2.2 (Windows) anymore. Seems to be fixed at least for 3.6.2.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50103] no way to include/exclude specific users
https://bugs.freedesktop.org/show_bug.cgi?id=50103 Matthias Clasen mcla...@redhat.com changed: What|Removed |Added Assignee|mcla...@redhat.com |libreoffice-b...@lists.free ||desktop.org Product|accountsservice |LibreOffice Component|general |Writer -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on the MacOSX and iOS platform. Or better: outshine other products/platforms.
https://bugs.freedesktop.org/show_bug.cgi?id=42082 --- Comment #6 from Roman Eisele b...@eikota.de --- (In reply to comment #5) at best this is a meta bug, as it is way to broad and unspecific. A good idea! So we should begin to add bugs to “Depends on” here?! Not all bugs specific to LibO on Mac OS X, of course, but bug reports and enhancement requests about * better OS integration (“use more OS/MacOSX/iOS native Cocoa-based core technologies and frameworks”) * and IMHO also UI bugs which make LibO look foreigh/outdated/unprofessional on Mac OS X. I do not know if this will help much (what we *really* need are more *developers* with interest in and knowledge about Mac OS X, to fix these bugs ;-), but at least for us QA guys this meta bug may be useful -- and for the developers, too, if they will come some day ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55958] Watermark cannot display special Slavic, non-ASCII characters
https://bugs.freedesktop.org/show_bug.cgi?id=55958 Roman Eisele b...@eikota.de changed: What|Removed |Added Attachment #68563|text/plain |application/pdf mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55958] Watermark cannot display special Slavic, non-ASCII characters
https://bugs.freedesktop.org/show_bug.cgi?id=55958 Roman Eisele b...@eikota.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||b...@eikota.de Ever confirmed|0 |1 --- Comment #2 from Roman Eisele b...@eikota.de --- Thank you very much for your bug report! Thank you especially for the sample .pdf file. Looking at this file with Adobe Reader (10.1.4, on Mac OS X 10.6.8), I see that the font used for the watermark is “Heveltica”, and that a (Postscript) Type 1 font version of “Helvetica” is used for the display, while the source font was “Helvetica” in TrueType format. So the original font for the watermark is not embedded, but the default (Adobe Reader?!) version of “Helvetica” is used instead. I wonder why this could be a/the reason for the missing characters: automatic font substitution, while a nice feature in theory, often causes headaches like this one. Could you please try: When exporting your file to PDF from LibreOffice, check the “Embed standard fonts” option (in the first pane of the “PDF Options” dialog window, at the bottom right). Does this change the situation, i.e., does the PDF exported now look different? Are the č characters now present, or still missing? Please try this; thank you very much in advance! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56031] New: Accessible Text Interface not updating until word boundary at caret offset
https://bugs.freedesktop.org/show_bug.cgi?id=56031 Priority: medium Bug ID: 56031 Assignee: libreoffice-bugs@lists.freedesktop.org Blocks: 36549 Summary: Accessible Text Interface not updating until word boundary at caret offset Severity: normal Classification: Unclassified OS: Linux (All) Reporter: jdi...@igalia.com Hardware: Other Status: UNCONFIRMED Version: 3.6.3.1 rc Component: Writer Product: LibreOffice Created attachment 68620 -- https://bugs.freedesktop.org/attachment.cgi?id=68620action=edit accessible event listener Steps to reproduce (without the mouse and exactly as follows): 1. Launch the attached accessible event listener in a terminal. 2. Launch writer. 3. Type the string This is a test. and press Return. 4. Press Up Arrow. 5. Press Right Arrow to move the cursor to the word is. 6. Press Delete once (leaving This s a test.) 7. Type the string wa (resulting in This was a test.) 8. Press Down Arrow then Up Arrow. Expected results (short version): After step 8: current line: This was a test. Actual results (short version): After step 8: current line: This s a test. Expected results (long version): Every time the caret moved on screen, the event listener would print out the current line and the current line's contents would be accurate. Actual results: The current line is only printed out when the character at the caret offset is at a word boundary (space, period, etc.). And the line contents are incorrect until a word boundary (space, period, etc.) is typed. At that point the line text is correct. Apparently this is a regression introduced at some point in the 3.6 cycle as per this Orca user's report: https://bugzilla.gnome.org/show_bug.cgi?id=685098#c2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36549] ACCESSIBILITY Metabug: Bugs blocking Orca screen reader support
https://bugs.freedesktop.org/show_bug.cgi?id=36549 Joanmarie Diggs jdi...@igalia.com changed: What|Removed |Added Depends on||56031 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49299] Impress FILEOPEN, FORMATTING: ppt opens with wrong background
https://bugs.freedesktop.org/show_bug.cgi?id=49299 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||bfo.bugm...@spamgourmet.com Ever confirmed|0 |1 --- Comment #4 from bfoman bfo.bugm...@spamgourmet.com --- Confirmed with: LO 3.6.3.1 Build ID: f8fce0b Windows 7 Professional SP1 64 bit NEW as confirmed with both files. In PP 2010 all good. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43008] Calc Editing: With entire column selected, pasting into the column causes hang
https://bugs.freedesktop.org/show_bug.cgi?id=43008 --- Comment #4 from andreas.tropsc...@gmail.com --- I vote to reopen this Feature report. I created a trivial formula in a cell (=A1+B1), copied it, selected the whole column and pasted it. LO hangs 1 core 100% - after 5min Mem fills up (8Gb) - System hangs The mem fillup rate is not linear, it lingers a while at 1 to 1.5 Gb and then goes to 80% in 2 minutes or so. This is problematic. I understand the argument for this do this to a potentially infinite column of this sheet. In these Programs however, pasting something into a column largely means: Please column, behave this way!. Otherwise I'd recommend to disable pasting into columns, because it is almost never what you want it to do. Even Gnumeric is smart enough to catch this by asking Do you really want to paste 65535 copies?(y/n)! And even when I say yes it doesn't die as LO does. As I understand it their infinity is only about 6% of your infinity but, well, at least I can paste into a column without an adrenaline rush. I dare not fiddle with the controls as this is my first bug report here, but please oh please rethink this one. Sysinfo: uname -srvpio Linux 3.2.0-3-amd64 #1 SMP Mon Jul 23 02:45:17 UTC 2012 unknown unknown GNU/Linux (Debian Testing) Package: libreoffice-calc Source: libreoffice Version: 1:3.5.4+dfsg-2 Installed-Size: 23894 Maintainer: Debian LibreOffice Maintainers debian-openoff...@lists.debian.org Architecture: amd64 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49306] FILEOPEN catastrophically bad import of one specific .doc (Microsoft Word) document
https://bugs.freedesktop.org/show_bug.cgi?id=49306 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added CC||bfo.bugm...@spamgourmet.com --- Comment #8 from bfoman bfo.bugm...@spamgourmet.com --- Checked with: LO 3.6.3.1 Build ID: f8fce0b Windows 7 Professional SP1 64 bit The problem with this file are Apsal.NET, Description des modifications and company graphics embedded somehow. When those are deleted, file looks good. BTW: I don't see those objects in Word 2010. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49336] UI: CR added to data copied to clipboard from single cell
https://bugs.freedesktop.org/show_bug.cgi?id=49336 bfoman bfo.bugm...@spamgourmet.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from bfoman bfo.bugm...@spamgourmet.com --- RESOLVED WORKSFORME per comment 3. Do not hesitate to reopen if this bug is reproducible with the latest stable release. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55958] Watermark cannot display special Slavic, non-ASCII characters
https://bugs.freedesktop.org/show_bug.cgi?id=55958 --- Comment #3 from Roman Eisele b...@eikota.de --- I have just tried it myself with LibO 3.6.3.1 on Mac OS X 10.6.8 (Intel); I can CONFIRM [REPRODUCIBLE] that the watermark text (I used “če če”, too) is NOT exported properly by default, but it is exported correctly if I check the “Embed standard fonts” option. So please check if this fixes the issue for you, too; then we can decide if/what further steps are necessary. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50103] no way to include/exclude specific users
https://bugs.freedesktop.org/show_bug.cgi?id=50103 Ray Strode [halfline] rstr...@redhat.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mcla...@redhat.com |desktop.org | Product|LibreOffice |accountsservice Component|Writer |general -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49853] EDITING: Cannot paste into 'find' box (OS X)
https://bugs.freedesktop.org/show_bug.cgi?id=49853 --- Comment #20 from Frantisek Erben frantisek.er...@seznam.cz --- Really annoying bug :( occured in 3.6.2.2 [CzechUI] (3.6.2 release) too. Please fix it as soon as possible. Thanx :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs