[PATCH] OUString cleanup in basctl

[Ricardo Montania (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/892

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/892/1

OUString cleanup in basctl

Change-Id: I9644427f6d3bb4b2f488325eb520b365115a8e82
---
M basctl/source/basicide/baside2b.cxx
M basctl/source/basicide/basides2.cxx
M basctl/source/basicide/tbxctl.cxx
M basctl/source/basicide/unomodel.cxx
M basctl/source/dlged/dlged.cxx
5 files changed, 30 insertions(+), 33 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/892
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9644427f6d3bb4b2f488325eb520b365115a8e82
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - sw/inc sw/source sw/uiconfig sw/UI_swriter.mk vcl/source

[Libreoffice Gerrit user]

 sw/UI_swriter.mk|1 
 sw/inc/helpid.h |9 
 sw/inc/index.hrc|3 
 sw/inc/swabstdlg.hxx|2 
 sw/source/ui/app/app.src|   12 +
 sw/source/ui/dialog/swdlgfact.cxx   |   19 -
 sw/source/ui/dialog/swdlgfact.hxx   |2 
 sw/source/ui/inc/app.hrc|4 
 sw/source/ui/inc/swuiidxmrk.hxx |   45 +---
 sw/source/ui/index/idxmrk.cxx   |2 
 sw/source/ui/index/idxmrk.src   |  144 -
 sw/source/ui/index/swuiidxmrk.cxx   |  231 +
 sw/uiconfig/swriter/ui/bibliographyentry.ui |  304 
 vcl/source/uipreviewer/previewer.cxx|2 
 vcl/source/window/dialog.cxx|4 
 15 files changed, 450 insertions(+), 334 deletions(-)

New commits:
commit 1cdad42cf9cfd868f717ab6b972be201f1f06b70
Author: Caolán McNamara 
Date:   Fri Oct 19 18:20:58 2012 +0100

add bibliography entry ui

Change-Id: I9c442d40ccfbc381c5885fa016da448ce2912b93

diff --git a/sw/UI_swriter.mk b/sw/UI_swriter.mk
index 9e35278..1e99bf4 100644
--- a/sw/UI_swriter.mk
+++ b/sw/UI_swriter.mk
@@ -11,6 +11,7 @@ $(eval $(call gb_UI_UI,modules/swriter))
 
 $(eval $(call gb_UI_add_uifiles,modules/swriter,\
sw/uiconfig/swriter/ui/autoformattable \
+   sw/uiconfig/swriter/ui/bibliographyentry \
sw/uiconfig/swriter/ui/charurlpage \
sw/uiconfig/swriter/ui/columnwidth \
sw/uiconfig/swriter/ui/converttexttable \
diff --git a/sw/inc/helpid.h b/sw/inc/helpid.h
index ca524fc..8f97e7b 100644
--- a/sw/inc/helpid.h
+++ b/sw/inc/helpid.h
@@ -384,8 +384,6 @@
 #define HID_DLG_NEW_USER_IDX
"SW_HID_DLG_NEW_USER_IDX"
 #define HID_INSERT_IDX_MRK_OK   
"SW_HID_INSERT_IDX_MRK_OK"
 #define HID_INSERT_IDX_MRK_CLOSE
"SW_HID_INSERT_IDX_MRK_CLOSE"
-#define HID_INSERT_AUTH_MRK_OK  
"SW_HID_INSERT_AUTH_MRK_OK"
-#define HID_INSERT_AUTH_MRK_CLOSE   
"SW_HID_INSERT_AUTH_MRK_CLOSE"
 #define HID_INSERT_IDX_MRK_DELETE   
"SW_HID_INSERT_IDX_MRK_DELETE"
 #define HID_INSERT_IDX_MRK_NEW  
"SW_HID_INSERT_IDX_MRK_NEW"
 #define HID_INSERT_IDX_MRK_PREV 
"SW_HID_INSERT_IDX_MRK_PREV"
@@ -399,9 +397,6 @@
 #define HID_INSERT_IDX_MRK_LEVEL
"SW_HID_INSERT_IDX_MRK_LEVEL"
 #define HID_INSERT_IDX_MRK_MAIN_ENTRY   
"SW_HID_INSERT_IDX_MRK_MAIN_ENTRY"
 #define HID_INSERT_IDX_MRK_APPLY_ALL
"SW_HID_INSERT_IDX_MRK_APPLY_ALL"
-#define HID_INSERT_AUTH_MRK_ENTRY   
"SW_HID_INSERT_AUTH_MRK_ENTRY"
-#define HID_INSERT_AUTH_MRK_CREATE_ENTRY
"SW_HID_INSERT_AUTH_MRK_CREATE_ENTRY"
-#define HID_INSERT_AUTH_MRK_EDIT_ENTRY  
"SW_HID_INSERT_AUTH_MRK_EDIT_ENTRY"
 #define HID_TOKEN_WINDOW
"SW_HID_TOKEN_WINDOW"
 
 #define HID_AUTH_FIELD_IDENTIFIER   
"SW_HID_AUTH_FIELD_IDENTIFIER"
@@ -436,10 +431,6 @@
 #define HID_AUTH_FIELD_CUSTOM5  
"SW_HID_AUTH_FIELD_CUSTOM5"
 #define HID_AUTH_FIELD_ISBN 
"SW_HID_AUTH_FIELD_ISBN"
 
-#define HID_AUTH_MARK_DLG_FROM_COMP_RB  
"SW_HID_AUTH_MARK_DLG_FROM_COMP_RB"
-#define HID_AUTH_MARK_DLG_FROM_DOC_RB   
"SW_HID_AUTH_MARK_DLG_FROM_DOC_RB"
-#define HID_AUTH_MARK_DLG_ID_LISTBOX
"SW_HID_AUTH_MARK_DLG_ID_LISTBOX"
-
 #define HID_INSERT_INDEX_ENTRY_LEVEL_LB 
"SW_HID_INSERT_INDEX_ENTRY_LEVEL_LB"
 #define HID_INSERT_IDX_MRK_SRCH_CASESENSITIVE   
"SW_HID_INSERT_IDX_MRK_SRCH_CASESENSITIVE"
 #define HID_INSERT_IDX_MRK_SRCH_WORDONLY
"SW_HID_INSERT_IDX_MRK_SRCH_WORDONLY"
diff --git a/sw/inc/index.hrc b/sw/inc/index.hrc
index 6d07ec1..0d23e1d 100644
--- a/sw/inc/index.hrc
+++ b/sw/inc/index.hrc
@@ -32,15 +32,12 @@
 #define  STR_ALPHA  (RC_INDEX_BEGIN + 7)
 #define  STR_LEVEL  (RC_INDEX_BEGIN + 8)
 
-#define  DLG_INSAUTHMARK(RC_INDEX_BEGIN + 9)
 #define  DLG_CREATE_AUTH_ENTRY  (RC_INDEX_BEGIN + 10)
 #define  DLG_EDIT_IDXMARK   (RC_INDEX_BEGIN + 11)
 #define  DLG_EDIT_AUTHMARK  (RC_INDEX_BEGIN + 12)
 
 #define  STR_IDXMRK_INSERT  (RC_INDEX_BEGIN + 13)
 #define  STR_IDXMRK_EDIT(RC_INDEX_BEGIN + 14)
-#define  STR_AUTHMRK_EDIT   (RC_INDEX_BEGIN + 15)
-#define  STR_AUTHMRK_INSERT (RC_INDEX_BEGIN + 16)
 
 #define  DLG_NEW_USER_IDX   (RC_INDEX_BEGIN + 17)
 
diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index 056f3a2..bd499a7 100644
--- a/

[Libreoffice-commits] .: helpers/help_hid.lst source/text

[Libreoffice Gerrit user]

 helpers/help_hid.lst|8 
 source/text/swriter/01/04120300.xhp |   32 
 2 files changed, 16 insertions(+), 24 deletions(-)

New commits:
commit 6e855787c1fa512546f8e72766606fa2f90d0854
Author: Caolán McNamara 
Date:   Fri Oct 19 19:00:30 2012 +0100

update helpids for bibliography entry dialog .ui

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index ef39d93..81a6996 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -776,9 +776,6 @@ HID_AUTH_FIELD_TITLE,54900,
 HID_AUTH_FIELD_URL,54904,
 HID_AUTH_FIELD_VOLUME,54902,
 HID_AUTH_FIELD_YEAR,54903,
-HID_AUTH_MARK_DLG_FROM_COMP_RB,54911,
-HID_AUTH_MARK_DLG_FROM_DOC_RB,54912,
-HID_AUTH_MARK_DLG_ID_LISTBOX,54913,
 HID_AUTOCORR_HELP_ACORSENTWORD,34104,
 HID_AUTOCORR_HELP_ACORSENTWORDENEMDASH,34112,
 HID_AUTOCORR_HELP_ACORWORD,34102,
@@ -2301,11 +2298,6 @@ HID_IMAPDLG_UNDO,33948,
 HID_IMPGRF_CB_PREVIEW,33971,
 HID_INDEX_DIALOG_ACTION_TB,39147,
 HID_INSERT_ABSTRACT,52986,
-HID_INSERT_AUTH_MRK_CLOSE,54862,
-HID_INSERT_AUTH_MRK_CREATE_ENTRY,54877,
-HID_INSERT_AUTH_MRK_EDIT_ENTRY,54878,
-HID_INSERT_AUTH_MRK_ENTRY,54876,
-HID_INSERT_AUTH_MRK_OK,54861,
 HID_INSERT_CHART,52971,
 HID_INSERT_CTRL,52822,
 HID_INSERT_FIELD_CTRL,52824,
diff --git a/source/text/swriter/01/04120300.xhp 
b/source/text/swriter/01/04120300.xhp
index 91f3ea9..0400972 100644
--- a/source/text/swriter/01/04120300.xhp
+++ b/source/text/swriter/01/04120300.xhp
@@ -40,7 +40,7 @@
 
 
 
-
+
 Insert Bibliography 
Entry
 Inserts a bibliography reference.
 
@@ -48,26 +48,26 @@
   
 
 Entry
-From bibliography 
database
-Inserts a reference 
from the bibliography database.
-From document 
content
-Inserts a reference from 
the bibliography records that are stored in the current document. An 
entry that is stored in the document has priority over an entry that is stored 
in the bibliography database.
+From bibliography 
database
+Inserts a reference 
from the bibliography database.
+From document 
content
+Inserts a reference 
from the bibliography records that are stored in the current document. 
An entry that is stored in the document has priority over an entry that is 
stored in the bibliography database.
 
 When you save a document that contains bibliography entries, the 
corresponding records are automatically saved in a hidden field in the 
document.
 
-
-Short name
-Select the short name of 
the bibliography record that you want to insert.
+
+Short name
+Select the 
short name of the bibliography record that you want to 
insert.
 Author, Title
 If available, the author and the full title of the selected short 
name are displayed in this area.
-Insert
-Inserts the bibliographic 
reference into the document. If you created a new record, you must also insert 
it as an entry, otherwise the record is lost when you close the 
document.
-Close
-Closes the 
dialog.
-New
-Opens the Define 
Bibliography Entry dialog, where you can create a new bibliography 
record. This record is only stored in the document. To add a record to the 
bibliography database, choose Tools - Bibliography 
Database.
-Edit
-Opens the Define 
Bibliography Entry dialog where you can edit the selected bibliography 
record.
+Insert
+Inserts 
the bibliographic reference into the document. If you created a new record, you 
must also insert it as an entry, otherwise the record is lost when you close 
the document.
+Close
+Closes the 
dialog.
+New
+Opens the 
Define Bibliography Entry dialog, where you can create a new 
bibliography record. This record is only stored in the document. To add a 
record to the bibliography database, choose Tools - Bibliography 
Database.
+Edit
+Opens the 
Define Bibliography Entry dialog where you can edit the selected 
bibliography record.
 
 Tips for working with bibliography 
entries
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: helpcontent2

[Libreoffice Gerrit user]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 76a1bc49b6c7b9f97cc6591e4d149d16ec7a69ec
Author: Caolán McNamara 
Date:   Fri Oct 19 19:00:30 2012 +0100

Updated core
Project: help  6e855787c1fa512546f8e72766606fa2f90d0854
update helpids for bibliography entry dialog .ui

diff --git a/helpcontent2 b/helpcontent2
index ed848f4..6e85578 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ed848f40ce864a4aadd3a36465e3967cb3ca2afb
+Subproject commit 6e855787c1fa512546f8e72766606fa2f90d0854
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

V.K.  changed:

   What|Removed |Added

 Depends on||47838

--- Comment #150 from V.K.  ---
Add Bug 47838 - Writer causes extra page-crossing (text flow to next page) in
some MS Office documents - related with header/footer and page formatting.
It is very annoying bug: Writer adds footers or headers on pages that do not
have it => length of the document changes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: config_host.mk.in

[Libreoffice Gerrit user]

 config_host.mk.in |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 8e7829a0e88eb2323bffee3eb8dcdc937c12148d
Author: Matúš Kukan 
Date:   Fri Oct 19 23:10:09 2012 +0200

remove unset & unused variables

Change-Id: I565a3110c10eb94945ad08daabe29f0034ed0ddd

diff --git a/config_host.mk.in b/config_host.mk.in
index 2c46a6c..7aca33b 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -81,7 +81,6 @@ export CPUNAME=@CPUNAME@
 export CPUNAME_FOR_BUILD=@CPUNAME_FOR_BUILD@
 export CPU_FOR_BUILD=@CPU_FOR_BUILD@
 export CROSS_COMPILING=@CROSS_COMPILING@
-export CT2N_EXTENSION_PACK=@CT2N_EXTENSION_PACK@
 export CURL_CFLAGS=@CURL_CFLAGS@
 export CURL_LIBS=@CURL_LIBS@
 export CXX=@CXX@
@@ -309,7 +308,6 @@ export LIBEXTTEXTCAT_CFLAGS=@LIBEXTTEXTCAT_CFLAGS@
 export LIBEXTTEXTCAT_LIBS=@LIBEXTTEXTCAT_LIBS@
 export LIBFONTS_JAR=@LIBFONTS_JAR@
 export LIBFORMULA_JAR=@LIBFORMULA_JAR@
-export LIBJSON=@LIBJSON@
 export LIBLAYOUT_JAR=@LIBLAYOUT_JAR@
 export LIBLANGTAG_CFLAGS=@LIBLANGTAG_CFLAGS@
 export LIBLANGTAG_LIBS=@LIBLANGTAG_LIBS@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Errors with Makefile.top for building Windows

[Julien Nabet]

On 19/10/2012 23:00, Matúš Kukan wrote:

On 19 October 2012 22:40, Julien Nabet  wrote:

I attached it and noticed this:
export WORKDIR=D:/compile-libreoffice/libo/workdir/wntmsci12
export WORKDIR_FOR_BUILD=D:/compile-libreoffice/libo/workdir/wntmsci12

Hmm, sorry, no idea. I hope the '-' in compile-libreoffice does not
make problem.
It should be fine to start with D:/ IIRC

On my Linux laptop, I've got this:
/home/julien/compile-libreoffice/libo, no problem. Hope it's not a pb 
with Cygwin or Windows :-)



I put compile-libreoffice in /cygdrive/d because I've got not enough space
for a debug build in C.
Now I could install cygwin + LO sources in D, so I wouldn't need to use
/cygdrive/... ?

I don't understand what do you mean here. It is already in D.
You mean to move it one level up as D:/libo ?
You can try to avoid compile-libreoffice but it should be fine.
I installed Cygwin on my c:, then "home" is located in this directory : 
"c:\cygwin\home\annie" (I retrieved my mother's laptop)
Since I don't have enough space on C: for a debug build (I saw that 
after having installed Cygwin), I put LO sources in D: so I use 
/cygdrive/d/compile-libreoffice to access LO sources


Now, if using /cygdrive/d/compile-libreoffice is a problem, I could 
install Cygwin on my d:, then "home" would be located in this directory 
(or I suppose so) : "d:\cygwin\home\annie"
then I could put LO sources on ~/compile-libreoffice (ie 
"d:\cygwin\home\annie\compile-libreoffice").


Hope it's more clear now

Julien
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Errors with Makefile.top for building Windows

[Matúš Kukan]

On 19 October 2012 22:40, Julien Nabet  wrote:
> I attached it and noticed this:
> export WORKDIR=D:/compile-libreoffice/libo/workdir/wntmsci12
> export WORKDIR_FOR_BUILD=D:/compile-libreoffice/libo/workdir/wntmsci12

Hmm, sorry, no idea. I hope the '-' in compile-libreoffice does not
make problem.
It should be fine to start with D:/ IIRC

> I put compile-libreoffice in /cygdrive/d because I've got not enough space
> for a debug build in C.
> Now I could install cygwin + LO sources in D, so I wouldn't need to use
> /cygdrive/... ?

I don't understand what do you mean here. It is already in D.
You mean to move it one level up as D:/libo ?
You can try to avoid compile-libreoffice but it should be fine.

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Errors with Makefile.top for building Windows

[Julien Nabet]

On 19/10/2012 22:30, Matúš Kukan wrote:

On 18 October 2012 22:28, julien2412  wrote:

Hello,

On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've got
these errors:
/cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't
match the target pattern
/cygdrive/d/compile-libreoffice/libo/Makefile.top:329: target `D' doesn't
match the target pattern
/cygdrive/d/compile-libreoffice/libo/Makefile.top:330: warning: overriding
recipe for target `D'
/cygdrive/d/compile-libreoffice/libo/Makefile.top:326: warning: ignoring old
recipe for target `D'
/cygdrive/d/compile-libreoffice/libo/Makefile.top:396: *** target pattern
contains no '%'. Stop.
make[1]: Leaving directory `cygdrive/d/compile-libreoffice/libo'

I found some old links (2006 until 2008) indicated to downgrade Make from
3.81 to 3.80

I use make 3.82.90  (Build for i686-pc-cygwin) from dev-tools repo

Any idea?

Not really, you can remove lines 324 - 330 and in theory also 396 and
see what happens.

I had commented them but I had a problem with sal module.

But what's wrong with WORKDIR ?
Could you send config_host.mk ?

I attached it and noticed this:
export WORKDIR=D:/compile-libreoffice/libo/workdir/wntmsci12
export WORKDIR_FOR_BUILD=D:/compile-libreoffice/libo/workdir/wntmsci12

I put compile-libreoffice in /cygdrive/d because I've got not enough 
space for a debug build in C.
Now I could install cygwin + LO sources in D, so I wouldn't need to use 
/cygdrive/... ?


Julien
 # config variable for LibreOffice
 # this file is intented to be able to be included in a Makefile
 # and not to be sourced in a shell session
 #
export SRC_ROOT=D:/compile-libreoffice/libo

export ABOUT_BACKGROUND_SVG=
export 
AFMS_TARBALL=1756c4fa6c616ae15973c104cd8cb256-Adobe-Core35_AFMs-314.tar.gz
export ALIGNOF_DOUBLE=8
export ALIGNOF_INT=4
export ALIGNOF_LONG=4
export ALIGNOF_SHORT=2
export ALLOC=
export ALL_LANGS=en-US af am ar as ast be bg bn bn-IN bo br brx bs ca ca-XV cs 
cy da de dgo dz el en-GB en-ZA eo es et eu fa fi fr ga gd gl gu he hi hr hu id 
is it ja ka kk km kn ko kok ks ku lb lo lt lv mai mk ml mn mni mr my nb ne nl 
nn nr nso oc om or pa-IN pl pt pt-BR qtz ro ru rw sa-IN sat sd sh si sk sl sq 
sr ss st sv sw-TZ ta te tg th tn tr ts tt ug uk uz ve vi xh zh-CN zh-TW zu
export ANT=/cygdrive/c/ant/apache-ant-1.8.4-bin/apache-ant-1.8.4//bin/ant
export ANT_HOME=C:/ant/apache-ant-1.8.4-bin/apache-ant-1.8.4
export ANT_LIB=C:/ant/apache-ant-1.8.4-bin/apache-ant-1.8.4/lib
export ANCIENT_BISON=NO
export ANDROID_APP_ABI=
export ANDROID_NDK_HOME=
export ANDROID_NDK_TOOLCHAIN_VERSION_SUBDIR=
export ANDROID_NDK_GDBSERVER=
export ANDROID_SDK_HOME=
export 
APACHE_COMMONS_CODEC_TARBALL=af3c3acf618de6108d65fcdc92b492e1-commons-codec-1.3-src.tar.gz
export 
APACHE_COMMONS_HTTPCLIENT_TARBALL=2c9b0f83ed5890af02c0df1c1776f39b-commons-httpclient-3.1-src.tar.gz
export 
APACHE_COMMONS_LANG_TARBALL=2ae988b339daec234019a7066f96733e-commons-lang-2.3-src.tar.gz
export 
APACHE_COMMONS_LOGGING_TARBALL=3c219630e4302863a9a83d0efde889db-commons-logging-1.1.1-src.tar.gz
export AR=
export ASSERT_ALWAYS_ABORT=FALSE
export ATL_INCLUDE=C:/PROGRA~1/MICROS~1.0/VC/atlmfc/include
export ATL_LIB=C:/PROGRA~1/MICROS~1.0/VC/atlmfc/lib
export AWTLIB=jawt.lib
export BARCODE_EXTENSION_PACK=
export BOOST_CPPFLAGS=
export BOOST_DATE_TIME_LIB=
export BOOST_LDFLAGS=
export BOOST_TARBALL=f02578f5218f217a9f20e9c30e119c6a-boost_1_44_0.tar.bz2
export BSH_JAR=
export BSH_TARBALL=ea570af93c284aa9e5621cd563f54f4d-bsh-2.0b1-src.tar.gz
export BUILD_DMAKE=YES
export BUILD_EPM=NO
export BUILD_MOZAB=
export BUILD_NCPUS=2
export BUILD_PLATFORM=i686-pc-cygwin
export BUILD_POSTGRESQL_SDBC=YES
export BUILD_STAX=YES
export BUILD_TYPE=LibO DESKTOP DBCONNECTIVITY EXTENSIONS SCRIPTING DYNLOADING 
NATIVE CRASHREP HELP DICTIONARIES STLPORT UCPP ODK ZLIB JPEG CLUCENE EXPAT 
LCMS2 CPPUNIT LIBXSLT LIBXML2 PYUNO PYTHON BERKELEYDB HSQLDB POSTGRESQL SAXON 
CURL BOOST NSS SANE ICU GRAPHITE NEON OPENSSL REDLAND HUNSPELL HYPHEN MYTHES 
LPSOLVE LIBEXTTEXTCAT XPDF SDEXT TOMCAT JFREEREPORT APACHE_COMMONS TOMCAT BSH 
RHINO CT2N NLPSOLVER MORE_FONTS AFMS LIBRSVG CAIRO GDK_PIXBUF GLIB LIBLANGTAG 
GETTEXT LIBCROCO PANGO LIBGSF LIBPNG
export BUILD_UNOWINREG=YES
export BUILD_VER_STRING=
export BUILD_X64=
export CAIRO_CFLAGS=
export CAIRO_LIBS=
export CC=/cygdrive/c/PROGRA~1/MICROS~1.0/VC/bin/cl.exe
export CC_FOR_BUILD=/cygdrive/c/PROGRA~1/MICROS~1.0/VC/bin/cl.exe
export CDR_CFLAGS=
export CDR_LIBS=
export CDR_TARBALL=3c0037fb07dea2f0bbae8386fa7c6a9a-libcdr-0.0.9.tar.bz2
export CHECK_PARALLELISM=2
export CLASSPATH=C:/PROGRA~1/Java/JDK17~1.0_0/jre/lib/rt.jar;.
export CLUCENE_CFLAGS=
export CLUCENE_LIBS=
export 
CLUCENE_TARBALL=48d647fbd8ef8889e5a7f422c1bfda94-clucene-core-2.3.3.4.tar.gz
export CMIS_CFLAGS=
export CMIS_LIBS=
export CMIS_TARBALL=b2371dc7cf4811c9d32146eec913d296-libcmis-0.3.0.tar.gz
export COM=MSC
export COM_GCC_IS_CLANG=
export COMEX=12
export COMMONS_CODEC_JAR=
export COMMONS_HTTPCLIENT_JAR=
export COMMONS

Re: Errors with Makefile.top for building Windows

[Matúš Kukan]

On 18 October 2012 22:28, julien2412  wrote:
> Hello,
>
> On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've got
> these errors:
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't
> match the target pattern
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:329: target `D' doesn't
> match the target pattern
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:330: warning: overriding
> recipe for target `D'
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:326: warning: ignoring old
> recipe for target `D'
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:396: *** target pattern
> contains no '%'. Stop.
> make[1]: Leaving directory `cygdrive/d/compile-libreoffice/libo'
>
> I found some old links (2006 until 2008) indicated to downgrade Make from
> 3.81 to 3.80
>
> I use make 3.82.90  (Build for i686-pc-cygwin) from dev-tools repo
>
> Any idea?

Not really, you can remove lines 324 - 330 and in theory also 396 and
see what happens.
But what's wrong with WORKDIR ?
Could you send config_host.mk ?

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: fdo#46669 sw: RTF paste should not change page styles

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/878

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/878
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic163a639fae9de838258b3cca9567a29ab875a35
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Miklos Vajna 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Miklos Vajna 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source writerfilter/inc writerfilter/source

[Libreoffice Gerrit user]

 sw/source/filter/rtf/swparrtf.cxx |4 +++-
 writerfilter/inc/dmapper/DomainMapper.hxx |3 ++-
 writerfilter/source/dmapper/DomainMapper.cxx  |5 +++--
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   11 +--
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |7 ++-
 writerfilter/source/dmapper/PropertyMap.cxx   |6 --
 writerfilter/source/filter/RtfFilter.cxx  |3 ++-
 7 files changed, 29 insertions(+), 10 deletions(-)

New commits:
commit b401b8977df3d9755f6d8999172ce2ecdaef93f0
Author: Miklos Vajna 
Date:   Mon Oct 15 16:42:15 2012 +0200

fdo#46669 sw: RTF paste should not change page styles

(cherry picked from commit 4f1ba0486241bd239e46b71405662db8e10d9b96)

Conflicts:
writerfilter/inc/dmapper/DomainMapper.hxx
writerfilter/source/dmapper/DomainMapper.cxx
writerfilter/source/dmapper/DomainMapper_Impl.cxx
writerfilter/source/dmapper/DomainMapper_Impl.hxx
writerfilter/source/filter/RtfFilter.cxx

Change-Id: Ic163a639fae9de838258b3cca9567a29ab875a35
Reviewed-on: https://gerrit.libreoffice.org/878
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/sw/source/filter/rtf/swparrtf.cxx 
b/sw/source/filter/rtf/swparrtf.cxx
index 95ca3dd..53b460d 100644
--- a/sw/source/filter/rtf/swparrtf.cxx
+++ b/sw/source/filter/rtf/swparrtf.cxx
@@ -151,10 +151,12 @@ sal_uLong SwRTFReader::Read( SwDoc &rDoc, const String& 
/*rBaseURL*/, SwPaM& /*r
 xImporter->setTargetDocument(xDstDoc);
 
 uno::Reference xFilter(xInterface, 
uno::UNO_QUERY_THROW);
-uno::Sequence aDescriptor(1);
+uno::Sequence aDescriptor(2);
 aDescriptor[0].Name = 
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("InputStream"));
 uno::Reference xStream(new utl::OStreamWrapper(*pStrm));
 aDescriptor[0].Value <<= xStream;
+aDescriptor[1].Name = "IsNewDoc";
+aDescriptor[1].Value <<= sal_False;
 xFilter->filter(aDescriptor);
 
 return 0;
diff --git a/writerfilter/inc/dmapper/DomainMapper.hxx 
b/writerfilter/inc/dmapper/DomainMapper.hxx
index 95ddc6f..eaf5e74 100644
--- a/writerfilter/inc/dmapper/DomainMapper.hxx
+++ b/writerfilter/inc/dmapper/DomainMapper.hxx
@@ -89,7 +89,8 @@ public:
 DomainMapper(const ::com::sun::star::uno::Reference< 
::com::sun::star::uno::XComponentContext >& xContext,
 ::com::sun::star::uno::Reference< 
::com::sun::star::io::XInputStream > xInputStream,
 ::com::sun::star::uno::Reference< 
::com::sun::star::lang::XComponent > xModel,
-SourceDocumentType eDocumentType );
+SourceDocumentType eDocumentType,
+bool bIsNewDoc = true);
 virtual ~DomainMapper();
 
 // Stream
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 3eed3cd..37fbfd4 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -97,11 +97,12 @@ struct _PageSz
 DomainMapper::DomainMapper( const uno::Reference< uno::XComponentContext >& 
xContext,
 uno::Reference< io::XInputStream > xInputStream,
 uno::Reference< lang::XComponent > xModel,
-SourceDocumentType eDocumentType) :
+SourceDocumentType eDocumentType,
+bool bIsNewDoc ) :
 LoggedProperties(dmapper_logger, "DomainMapper"),
 LoggedTable(dmapper_logger, "DomainMapper"),
 LoggedStream(dmapper_logger, "DomainMapper"),
-m_pImpl( new DomainMapper_Impl( *this, xContext, xModel, eDocumentType )),
+m_pImpl( new DomainMapper_Impl( *this, xContext, xModel, eDocumentType, 
bIsNewDoc )),
 mnBackgroundColor(0), mbIsHighlightSet(false)
 {
 // #i24363# tab stops relative to indent
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index ee6e291..951d500 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -184,7 +184,8 @@ DomainMapper_Impl::DomainMapper_Impl(
 DomainMapper& rDMapper,
 uno::Reference < uno::XComponentContext >  xContext,
 uno::Reference< lang::XComponent >  xModel,
-SourceDocumentType eDocumentType) :
+SourceDocumentType eDocumentType,
+bool bIsNewDoc) :
 m_eDocumentType( eDocumentType ),
 m_rDMapper( rDMapper ),
 m_xTextDocument( xModel, uno::UNO_QUERY ),
@@ -209,7 +210,8 @@ DomainMapper_Impl::DomainMapper_Impl(
 m_bIsFirstParaInSection( true ),
 m_bIsLastParaInSection( false ),
 m_bParaSectpr( false ),
-m_bUsingEnhancedFields( false )
+m_bUsingEnhancedFields( false ),
+m_bIsNewDoc(bIsNewDoc)
 {
 app

warn free build of dmake(unix), solenv, and silenced lpsolve

[via Code Review]

René Kjellerup has restored this change.

Change subject: warn free build of dmake(unix), solenv, and silenced lpsolve
..


Patch Set 2: Restored

--
To view, visit https://gerrit.libreoffice.org/885
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: Id6f1caa0a086f4036ec9698157f683ddf12228cf
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup 
Gerrit-Reviewer: Petr Mladek 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Errors with Makefile.top for building Windows

[julien2412]

Flavio Moringa wrote
> you have to use another "make" for libreoffice.
> 
> Check this:
> http://wiki.documentfoundation.org/User:Foral/Build_Win#Cygwin

Badfully, I've got exactly the same result as before with this make.

Any other idea?

Julien.



--
View this message in context: 
http://nabble.documentfoundation.org/Errors-with-Makefile-top-for-building-Windows-tp4014152p4014385.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

warn free build of dmake(unix), solenv, and silenced lpsolve

[via Code Review]

René Kjellerup has abandoned this change.

Change subject: warn free build of dmake(unix), solenv, and silenced lpsolve
..


Patch Set 2: Abandoned

redid the commit from scratch, sorry

--
To view, visit https://gerrit.libreoffice.org/885
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Id6f1caa0a086f4036ec9698157f683ddf12228cf
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup 
Gerrit-Reviewer: Petr Mladek 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] warn free build of dmake, concat-deps and lpsolve

[via Code Review]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/891

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/891/1

warn free build of dmake, concat-deps and lpsolve

I've added if test to silence compiler warnings like this:
"warning: ignoring return value of 'fwrite', declared with attribute 
warn_unused_result"
to make the compiler think we care about the return value of those function 
calls.
they work like this:
if( function_call(...) ) ;
meaning if true do a nop false just continue on your marry way.

Also in lpsolve moved from  "fprintf(output, (char* variable))" to 
"fputs((char* variable), output)"
because of a compiler warning that it couldn't varify the format string because 
it wasn't a
string literal.

Change-Id: Ib00b3e93b46bef12dc9019761508a76ceb84319a
---
M dmake/unix/arlib.c
A lpsolve/lp_solve-fixed-warn.patch
M lpsolve/lp_solve_5.5.patch
M lpsolve/makefile.mk
M solenv/bin/concat-deps.c
5 files changed, 79 insertions(+), 14 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/891
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib00b3e93b46bef12dc9019761508a76ceb84319a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: René Kjellerup 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Easy Hacks -- Link for 50+ Proposed

[Joel Madero]

Hi All,

Well it seems like the QA team has listened and we have a solid list of
proposed easy hacks that need developer input. I hope that this helps with
streamlining some of these easier bugs. Please see the link below :-D

https://bugs.freedesktop.org/buglist.cgi?list_id=147895&status_whiteboard_type=anywordssubstr&query_format=advanced&status_whiteboard=ProposedEasyHack&bug_status=NEW&bug_status=REOPENED&product=LibreOffice

Regards,
Joel



-- 
*Joel Madero*
LibO QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: BSA + New Wiki = No Good

[Joel Madero]

That stuff is all way above my knowledge. I'll wait for someone to fix it
and then I'll try again to use it after I update FDO with new version(s).
Thanks for the update, glad it looks like a minor problem


Regards,
Joel

On Fri, Oct 19, 2012 at 6:22 AM, Christian Lohmaier <
lohmaier+libreoff...@googlemail.com> wrote:

> Hi *,
>
> On Fri, Oct 19, 2012 at 12:25 PM, Christian Lohmaier
>  wrote:
> > [...]
> > The additional html tags in the wiki-output on the  tag makes
> > the removal of the xmlns tag that is added by tidy fail.
> >
> > i.e.  perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||'  does
> > nothing, since it is not
> > http://www.w3.org/1999/xhtml"; ..> but
> >
> > 
> > "http://www.w3.org/1999/xhtml";>
> >
> > so remove the xmlns declaration and just run the xslt commands
> > manually or fix the regular expression or something like that.
>
> Or better - instead of trying to search and replace, also use xslt to
> process the xml:
>
> stripnamespace.xsl:
>
> http://www.w3.org/1999/XSL/Transform";>
>  omit-xml-declaration="yes"/>
>
> 
> 
> 
> 
> 
>
> 
> 
> 
> 
>
>
> --- a/bug/Makefile
> +++ b/bug/Makefile
> @@ -18,7 +18,8 @@ all: extract compose
>
>  extract:
> mkdir -p build
> -   curl --silent
> http://wiki.documentfoundation.org/BugReport_Details | tidy
> --numeric-entities yes -asxhtml 2>/dev/null | perl -pe
> 's|xmlns="http://www.w3.org/1999/xhtml";||' >
> build/BugReport_Details.xhtml
> +   curl --silent
> http://wiki.documentfoundation.org/BugReport_Details | tidy
> --numeric-entities yes -asxhtml 2>/dev/null > build/tidyout.xhtml ||
> echo "ignoring tidy error"
> +   xsltproc --encoding UTF-8 --novalid stripnamespace.xsl
> build/tidyout.xhtml > build/BugReport_Details.xhtml
> xsltproc --encoding UTF-8 --novalid component_comments.xsl
> build/BugReport_Details.xhtml > build/component_comments.xhtml
> xsltproc --encoding UTF-8 --novalid subcomponents.xsl
> build/BugReport_Details.xhtml > build/subcomponents.xhtml
> xsltproc --encoding UTF-8 --novalid components.xsl
> build/BugReport_Details.xhtml > build/components.xhtml
>
>
> ciao
> Christian
>



-- 
*Joel Madero*
LibO QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

[Lior Kaplan]

On Fri, Oct 19, 2012 at 5:25 PM, Petr Mladek  wrote:

> On Fri, 2012-10-19 at 15:27 +0200, Lior Kaplan wrote:
> > (replying to the list, as I don't think gerrit is the right platform
> > for discussions about patches)
>
> Yup, it is a bit strange. I think that you could press the "Review"
> button and just leave the comment. Well, you can't do inline comments
> this way.
>

Indeed (:


> > Hi Petr,
> >
> > I've done the patch in https://gerrit.libreoffice.org/883 to be as
> > minimal as possible.
> >
> > I guess that it's indeed an unneeded repetetion, but as it appear
> > about 100 times in the same file (and effect different languages), I
> > would prefer to leave removing the condensed form to another change.
>
> I see the following:
>
> $> grep lucidasansunicode officecfg/registry/data/org/openoffice/VCL.xcu
> | wc -l
> 3
> $> grep "Lucida Sans Unicode"
> officecfg/registry/data/org/openoffice/VCL.xcu | wc -l
> 68
>
> => "Lucida Sans Unicode" is used many times and "lucidasansunicode" only
> 3 times.
>

But "lucidasans" is used 100 times.


> You could see that "lucidasansunicode" is used only in the second part
> of the VCL.xcu file where you define substitutes for particular fonts.
> Only this second part uses the lowercase-condensed font names.
>

And I don't want to lose this part due to the condensed/regular form change
you've suggested without more thorough check.

>
> => I still think that you should use only the normal font name (Lucida
> Sans Unicode) in the first part where you define fonts for each locale.
>
>
> > If someone has any other clean up for
> > officecfg/registry/data/org/openoffice/VCL.xcu let me know, and I'll
> > be happy to do them.
>
> I am not aware of any planed clean up. Well, it would be great to rework
> the code and use the same font names everywhere and avoid the confusion.
>

As you can see, there's place to unify the font's writing, but I would
prefer to leave it to another (larger) patch.

Thanks for the comment...

Kaplan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: vcl/Library_vcl.mk

[Libreoffice Gerrit user]

 vcl/Library_vcl.mk |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 1a6a3a12a9247ad18bc68d77b48229e457c7a9c0
Author: Tor Lillqvist 
Date:   Fri Oct 19 18:42:56 2012 +0300

In the 10.7 SDK CoreText is in the ApplicationServices framework

Although I don't understand why this worked before, huh.

Change-Id: I67ea314330630f331acaabd1c47128de6e340bb2

diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index d1dbad6..1ff3339 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -353,9 +353,15 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\
 vcl/aqua/source/gdi/coretext/salgdi \
 ))
 
+ifeq ($(MACOSX_SDK_VERSION),1070)
+$(eval $(call gb_Library_use_system_darwin_frameworks,vcl,\
+   ApplicationServices \
+))
+else
 $(eval $(call gb_Library_use_system_darwin_frameworks,vcl,\
CoreText \
 ))
+endif
 
 else # ATSUI
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: RuntimeException while building

[Ruslan Kabatsayev]

On Fri, Oct 19, 2012 at 6:26 PM, Stephan Bergmann  wrote:
> On 10/19/2012 04:13 PM, Ruslan Kabatsayev wrote:
>>
>> I'm trying to build current libo master, and build fails with this
>> log: http://pastebin.com/d191HeiH
>> Here's the backtrace: http://pastebin.com/6T7CCAZL .
>>
>> LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID:
>> ecf56e)".
>
>
> This *might* have to do with somewhat recent commit
> dccddcc20b0b873ca182983506d97b500edfe4f1 "make gcc-uno bridge work with both
> gcc-4.7 and clang."  Can you try with that two-line patch reverted?  Also,
> what version of GCC do you use?

With this patch reverted it builds OK. I'm using gcc 4.5.1.

>
> Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

[Petr Mladek]

On Fri, 2012-10-19 at 15:27 +0200, Lior Kaplan wrote:
> (replying to the list, as I don't think gerrit is the right platform
> for discussions about patches)

Yup, it is a bit strange. I think that you could press the "Review"
button and just leave the comment. Well, you can't do inline comments
this way.

> Hi Petr,
> 
> I've done the patch in https://gerrit.libreoffice.org/883 to be as
> minimal as possible.
> 
> I guess that it's indeed an unneeded repetetion, but as it appear
> about 100 times in the same file (and effect different languages), I
> would prefer to leave removing the condensed form to another change.

I see the following:

$> grep lucidasansunicode officecfg/registry/data/org/openoffice/VCL.xcu
| wc -l
3
$> grep "Lucida Sans Unicode"
officecfg/registry/data/org/openoffice/VCL.xcu | wc -l
68

=> "Lucida Sans Unicode" is used many times and "lucidasansunicode" only
3 times.

You could see that "lucidasansunicode" is used only in the second part
of the VCL.xcu file where you define substitutes for particular fonts.
Only this second part uses the lowercase-condensed font names.

=> I still think that you should use only the normal font name (Lucida
Sans Unicode) in the first part where you define fonts for each locale.


> If someone has any other clean up for
> officecfg/registry/data/org/openoffice/VCL.xcu let me know, and I'll
> be happy to do them.

I am not aware of any planed clean up. Well, it would be great to rework
the code and use the same font names everywhere and avoid the confusion.


Best Regards,
Petr


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6-3 1/3] fix fdo#47669: check for started hyperlink before closing

[Petr Mladek]

On Fri, 2012-10-12 at 21:11 +0700, Korrawit Pruegsanusak wrote:
> Hello all,
> 
> I'd like to propose the attached patch fixing fdo#47669 into -3-6 and
> -3-6-3 branches. Explanation is in commit message.
> 
> I've compiled and tested on -3-6 branch at
> 0eee6469304ba15f42bcafb6707cc98bcbff9112, and it worked fine.

It makes sense and works well => pushed into 3-6 branch, see
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=d401dcc51cec798c8c19febcc25c4325ddafa178

Two more approvals are needed for the 3-6-3 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxattributeoutput.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit d401dcc51cec798c8c19febcc25c4325ddafa178
Author: Korrawit Pruegsanusak 
Date:   Fri Oct 12 21:09:42 2012 +0700

Fix fdo#47669: also check if we started the tag before ending it

The problem is we created imbalance end tag  which shouldn't
be there. So, place a check before inserting end tag should help.

Inspired by (read: copied from) c1c2688912e769dfd7654e11e87dae380a8ce1eb ;)

(cherry picked from commit 3b042335208cb2c995f4860bf8ba3bd1e2f2e859)

Change-Id: Ic933f6da44c788cba48bb2fe6fa29658985310b6

Signed-off-by: Petr Mladek 

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 7149e49..78ee6cf 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -550,7 +550,11 @@ void DocxAttributeOutput::EndRun()
 
 if ( m_closeHyperlinkInPreviousRun )
 {
-m_pSerializer->endElementNS( XML_w, XML_hyperlink );
+if ( m_startedHyperlink )
+{
+m_pSerializer->endElementNS( XML_w, XML_hyperlink );
+m_startedHyperlink = false;
+}
 m_closeHyperlinkInPreviousRun = false;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [REVIEW 3-6-3 2/3][ fix for fdo#55712, ignore broadcaster cells to fill autofilter dialog

[Petr Mladek]

On Fri, 2012-10-19 at 10:20 +0200, David Tardon wrote:
> Hi,
> 
> On Wed, Oct 17, 2012 at 04:26:22PM +0200, Markus Mohrhard wrote:
> > Hey,
> > 
> > [1] fixes the problem that cells referenced in a formula where added
> > to the autofilter dialog.
> 
> Pushed with my sign-off.

The commit in the 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=637096b75f2989640967e72aee41e48b07a5a602

It looks quite safe and works well => +1

We need one more approval for 3-6-3 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

[V Stuart Foote]

David,

Grabbed the build, and unfortunately it still has the MSI installer Error
1935   ( fdo#55290 )  
affecting it.

But, in reading the build info and the  Tinderbox Wiki
   the number 16
TB is a minimal build and does not have support for Java--so would not be a
good test platform for the Java Access Bridge -- Accessibility role
mappings.

Looking at the Wiki and the  Tinderbox Status - MASTER
   listing, expect will
need TB 6 (MSVC) or  possibly even the TB 7 (MinGW) back on-line.

Stuart



--
View this message in context: 
http://nabble.documentfoundation.org/RE-libreoffice-accessibility-Latest-Libo-Won-t-Play-Nice-with-myJRE-tp4012436p4014319.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: RuntimeException while building

[Stephan Bergmann]

On 10/19/2012 04:13 PM, Ruslan Kabatsayev wrote:

I'm trying to build current libo master, and build fails with this
log: http://pastebin.com/d191HeiH
Here's the backtrace: http://pastebin.com/6T7CCAZL .

LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID: ecf56e)".


This *might* have to do with somewhat recent commit 
dccddcc20b0b873ca182983506d97b500edfe4f1 "make gcc-uno bridge work with 
both gcc-4.7 and clang."  Can you try with that two-line patch reverted? 
 Also, what version of GCC do you use?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RuntimeException while building

[Ruslan Kabatsayev]

Hello,

I'm trying to build current libo master, and build fails with this
log: http://pastebin.com/d191HeiH
Here's the backtrace: http://pastebin.com/6T7CCAZL .

LibO did build OK at the time of "Version 3.7.0.0.alpha0+ (Build ID: ecf56e)".

Any ideas how to solve this?

Thanks,
Ruslan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6-3 2/3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

[Petr Mladek]

On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote:
> Hi,
> 
> On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:
> > Hey,
> > 
> > [1] fixes the problem that blank cells, like broadcaster, cells are
> > considerend non empty for the "visible" methods.
> 
> Pushed with my sign-off.

The commit in 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=23e6bac62ef6482c287bb0f55c662ac2047ebb33

It looks reasonable and works fine => +1

One more approval is needed for 3-6-3. I would prefer if it is from a
Calc expert :-)

> Correct me if I am mistaken, but shouldn't the same check be used in
> GetFirstVisDataPos and VisibleCount too?

It would make sense.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6-3 2/3] fdo#53870, write sort list information into the item set

[Petr Mladek]

On Fri, 2012-10-19 at 11:06 +0200, David Tardon wrote:
> Hi,
> 
> On Wed, Oct 17, 2012 at 04:30:50PM +0200, Markus Mohrhard wrote:
> > Hey,
> > 
> > [1] writes the custom sort list information into the SfxItemSet.
> > Otherwise the old information is lost and a new default custom sort
> > list information is created.
> 
> Cherry picked.

The commit in 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=07cc274256ebff259e228e7285bc27e6ddc94fdc

It looks fine and works well => +1

We need one more approval for 3-6-3 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build Error

[Stephan Bergmann]

On 10/19/2012 07:07 AM, Joel Madero wrote:
/usr/lib/libuno_sal.so.3: version `LIBO_UDK_3.7' not found (required by 

/data/git/libo/workdir/unxlngx6.pro/LinkTarget/CppunitTest/libtest_sal_osl_file.so)

This means that our code trying to test newly built libraries instead by 
error picks up ones that happen to be available on /usr/lib.  Do you by 
chance have LD_LIBRARY_PATH environment variable set when doing "make"?


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PUSHED 3-6-3] fix for fdo#53482, exchange sort options between tab pages

[Petr Mladek]

On Fri, 2012-10-19 at 13:10 +0200, Kohei Yoshida wrote:
> On Wed, Oct 17, 2012 at 11:16 AM, Markus Mohrhard
>  wrote:
> > Hey,
> >
> > I just reviewed Noel's old patch for the sort problems around the sort
> > dialog. His patch fixes several problems at once where the sort
> > options are not exchanged between the tab pages.
> >
> > I already pushed it to 3-6 but I'd like to see this pushed to 3-6-3 to
> > fix all of these problems in the next release.
> >
> > Regards,
> > Markus
> >
> > [1] 
> > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=1bc15304a3fb44399ebd3861f6ee5fc12197a969
> 
> The change looks good to me.  I'll give my sign-off.  We need one more
> sign-off to cherry-pick this to the 3-6-3 branch.

It seems that it should not cause any harm. It works well => approved
and pushed into 3-6-3.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6-3' - sc/source

[Libreoffice Gerrit user]

 sc/source/ui/dbgui/tpsort.cxx |   12 
 sc/source/ui/inc/tpsort.hxx   |8 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 3f1219d1a659111f35302b6f1305fe7ce281501c
Author: Noel Power 
Date:   Wed Oct 17 11:01:15 2012 +0200

exchange sort settings between the two tab pages, fdo#53482

Change-Id: I540481585bec2479db541025755c2a5a670da9ed
Signed-off-by: Markus Mohrhard 
Signed-off-by: Kohei Yoshida 
Signed-off-by: Petr Mladek 

diff --git a/sc/source/ui/dbgui/tpsort.cxx b/sc/source/ui/dbgui/tpsort.cxx
index 303d6c6..7ebbb47 100644
--- a/sc/source/ui/dbgui/tpsort.cxx
+++ b/sc/source/ui/dbgui/tpsort.cxx
@@ -275,9 +275,11 @@ sal_Bool ScTabPageSortFields::FillItemSet( SfxItemSet& 
rArgSet )
 
 // ---
 
-// for data exchange without dialogue detour: (still TODO!)
-void ScTabPageSortFields::ActivatePage()
+// for data exchange without dialogue detour:
+void ScTabPageSortFields::ActivatePage( const SfxItemSet& rSet )
 {
+// Refresh local copy with shared data
+aSortData = static_cast(rSet.Get( SCITEM_SORTDATA 
)).GetSortData();
 if ( pDlg )
 {
 if ( bHasHeader  != pDlg->GetHeaders()
@@ -744,9 +746,11 @@ sal_Bool ScTabPageSortOptions::FillItemSet( SfxItemSet& 
rArgSet )
 
 // ---
 
-// for data exchange without dialogue detour: (still TODO!)
-void ScTabPageSortOptions::ActivatePage()
+// for data exchange without dialogue detour:
+void ScTabPageSortOptions::ActivatePage( const SfxItemSet& rSet )
 {
+// Refresh local copy with shared data
+aSortData = static_cast(rSet.Get( SCITEM_SORTDATA 
)).GetSortData();
 if ( pDlg )
 {
 if ( aBtnHeader.IsChecked() != pDlg->GetHeaders() )
diff --git a/sc/source/ui/inc/tpsort.hxx b/sc/source/ui/inc/tpsort.hxx
index 14fce4e..7167e2e 100644
--- a/sc/source/ui/inc/tpsort.hxx
+++ b/sc/source/ui/inc/tpsort.hxx
@@ -69,11 +69,9 @@ public:
 virtual voidReset   ( const SfxItemSet& rArgSet );
 
 protected:
-// for data exchange (TODO: should be changed!)
-//  virtual voidActivatePage( const SfxItemSet& rSet );
+virtual voidActivatePage( const SfxItemSet& rSet );
 using SfxTabPage::ActivatePage;
 using SfxTabPage::DeactivatePage;
-virtual voidActivatePage();
 virtual int DeactivatePage  ( SfxItemSet* pSet = 0);
 
 private:
@@ -132,11 +130,9 @@ public:
 virtual voidReset   ( const SfxItemSet& rArgSet );
 
 protected:
-// for data exchange (TODO: should be changed!)
-//  virtual voidActivatePage( const SfxItemSet& rSet );
+virtual voidActivatePage( const SfxItemSet& rSet );
 using SfxTabPage::ActivatePage;
 using SfxTabPage::DeactivatePage;
-virtual voidActivatePage();
 virtual int DeactivatePage  ( SfxItemSet* pSet = 0);
 
 private:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Change in core[master]: fdo#55034 Update default Hebrew font from Lucida Sans to Luc...

[Lior Kaplan]

(replying to the list, as I don't think gerrit is the right platform for
discussions about patches)

Hi Petr,

I've done the patch in https://gerrit.libreoffice.org/883 to be as minimal
as possible.

I guess that it's indeed an unneeded repetetion, but as it appear about 100
times in the same file (and effect different languages), I would prefer to
leave removing the condensed form to another change.

If someone has any other clean up for
officecfg/registry/data/org/openoffice/VCL.xcu let me know, and I'll be
happy to do them.

p.s.
I'm not subscribed to the list, please CC me.

On Fri, Oct 19, 2012 at 2:52 PM, Petr Mladek (via Code Review) <
ger...@gerrit.libreoffice.org> wrote:

> Petr Mladek has posted comments on this change.
>
> Change subject: fdo#55034 Update default Hebrew font from Lucida Sans to
> Lucida Sans Unicode
> ..
>
>
> Patch Set 1: I would prefer that you didn't submit this
>
> Just a small change. Please, do we really need "lucidasansunicode"?
>
> I guess that "Lucida Sans Unicode" is enough. At least, I see only this
> form in the other languages.
>
> I would prefer to use only the correct form. You know, if people see the
> other (lowecase+condesed) form in the VCL file, it might cause confusion ;-)
>
> Or did I miss anything?
>
> --
> To view, visit https://gerrit.libreoffice.org/883
> To unsubscribe, visit https://gerrit.libreoffice.org/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: Ia2204dda0cb452a4ce38a44db61d17d6802b5a38
> Gerrit-PatchSet: 1
> Gerrit-Project: core
> Gerrit-Branch: master
> Gerrit-Owner: Lior Kaplan 
> Gerrit-Reviewer: Petr Mladek 
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: BSA + New Wiki = No Good

[Christian Lohmaier]

Hi *,

On Fri, Oct 19, 2012 at 12:25 PM, Christian Lohmaier
 wrote:
> [...]
> The additional html tags in the wiki-output on the  tag makes
> the removal of the xmlns tag that is added by tidy fail.
>
> i.e.  perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||'  does
> nothing, since it is not
> http://www.w3.org/1999/xhtml"; ..> but
>
> 
> "http://www.w3.org/1999/xhtml";>
>
> so remove the xmlns declaration and just run the xslt commands
> manually or fix the regular expression or something like that.

Or better - instead of trying to search and replace, also use xslt to
process the xml:

stripnamespace.xsl:

http://www.w3.org/1999/XSL/Transform";>














--- a/bug/Makefile
+++ b/bug/Makefile
@@ -18,7 +18,8 @@ all: extract compose

 extract:
mkdir -p build
-   curl --silent
http://wiki.documentfoundation.org/BugReport_Details | tidy
--numeric-entities yes -asxhtml 2>/dev/null | perl -pe
's|xmlns="http://www.w3.org/1999/xhtml";||' >
build/BugReport_Details.xhtml
+   curl --silent
http://wiki.documentfoundation.org/BugReport_Details | tidy
--numeric-entities yes -asxhtml 2>/dev/null > build/tidyout.xhtml ||
echo "ignoring tidy error"
+   xsltproc --encoding UTF-8 --novalid stripnamespace.xsl
build/tidyout.xhtml > build/BugReport_Details.xhtml
xsltproc --encoding UTF-8 --novalid component_comments.xsl
build/BugReport_Details.xhtml > build/component_comments.xhtml
xsltproc --encoding UTF-8 --novalid subcomponents.xsl
build/BugReport_Details.xhtml > build/subcomponents.xhtml
xsltproc --encoding UTF-8 --novalid components.xsl
build/BugReport_Details.xhtml > build/components.xhtml


ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source vcl/source vcl/unx

[Libreoffice Gerrit user]

 sc/source/ui/inc/tabview.hxx |2 -
 sc/source/ui/view/tabview.cxx|   27 +--
 sc/source/ui/view/tabview4.cxx   |   36 +--
 vcl/source/control/scrbar.cxx|   12 +-
 vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |5 ++--
 5 files changed, 27 insertions(+), 55 deletions(-)

New commits:
commit bfa21ce5fa08f2c634ccb6162914be55aef9f3c2
Author: Jan Holesovsky 
Date:   Fri Oct 19 01:21:22 2012 +0200

fdo#44657 Remove hack that "simulates" a mirrored horizontal scrollbar.

We are able to paint mirrored scrolbars with the 'gen' plugin, so just fix 
the
rendering of the scroolbar with the Gtk+ plugin.

Change-Id: I5dbd13420c6290e165ed2f5827769979298abf37

diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index 4d2a540..218c506 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -192,7 +192,7 @@ private:
 voidUpdateVarZoom();
 
 static void SetScrollBar( ScrollBar& rScroll, long nRangeMax, long 
nVisible, long nPos, bool bLayoutRTL );
-static long GetScrollBarPos( ScrollBar& rScroll, bool bLayoutRTL );
+static long GetScrollBarPos( ScrollBar& rScroll );
 
 voidGetPageMoveEndPosition(SCsCOL nMovX, SCsROW nMovY, SCsCOL& 
rPageX, SCsROW& rPageY);
 voidGetAreaMoveEndPosition(SCsCOL nMovX, SCsROW nMovY, 
ScFollowMode eMode,
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index a9e85e3..6752ad2 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -282,6 +282,8 @@ void ScTabView::InitScrollBar( ScrollBar& rScrollBar, long 
nMaxVal )
 
 rScrollBar.SetScrollHdl( LINK(this, ScTabView, ScrollHdl) );
 rScrollBar.SetEndScrollHdl( LINK(this, ScTabView, EndScrollHdl) );
+
+rScrollBar.EnableRTL( aViewData.GetDocument()->IsLayoutRTL( 
aViewData.GetTabNo() ) );
 }
 
 //  Scroll-Timer
@@ -1035,15 +1037,14 @@ IMPL_LINK( ScTabView, EndScrollHdl, ScrollBar*, pScroll 
)
 
 if ( pScroll == &aHScrollLeft || pScroll == &aHScrollRight )
 {
-bool bMirror = aViewData.GetDocument()->IsLayoutRTL( 
aViewData.GetTabNo() ) != Application::GetSettings().GetLayoutRTL();
 ScHSplitPos eWhich = (pScroll == &aHScrollLeft) ? 
SC_SPLIT_LEFT : SC_SPLIT_RIGHT;
-long nDelta = GetScrollBarPos( *pScroll, bMirror ) + 
nScrollMin - aViewData.GetPosX(eWhich);
+long nDelta = GetScrollBarPos( *pScroll ) + nScrollMin - 
aViewData.GetPosX(eWhich);
 if (nDelta) ScrollX( nDelta, eWhich );
 }
 else// VScroll...
 {
 ScVSplitPos eWhich = (pScroll == &aVScrollTop) ? SC_SPLIT_TOP 
: SC_SPLIT_BOTTOM;
-long nDelta = GetScrollBarPos( *pScroll, false ) + nScrollMin 
- aViewData.GetPosY(eWhich);
+long nDelta = GetScrollBarPos( *pScroll ) + nScrollMin - 
aViewData.GetPosY(eWhich);
 if (nDelta) ScrollY( nDelta, eWhich );
 }
 }
@@ -1066,7 +1067,6 @@ IMPL_LINK( ScTabView, ScrollHdl, ScrollBar*, pScroll )
 SC_SPLIT_TOP : SC_SPLIT_BOTTOM );
 
 bool bLayoutRTL = aViewData.GetDocument()->IsLayoutRTL( 
aViewData.GetTabNo() );
-bool bMirror = bHoriz && (bLayoutRTL != 
Application::GetSettings().GetLayoutRTL());
 
 ScrollType eType = pScroll->GetType();
 if ( eType == SCROLL_DRAG )
@@ -1104,7 +1104,7 @@ IMPL_LINK( ScTabView, ScrollHdl, ScrollBar*, pScroll )
 nScrollMin = aViewData.GetFixPosX();
 if ( aViewData.GetVSplitMode()==SC_SPLIT_FIX && pScroll == 
&aVScrollBottom )
 nScrollMin = aViewData.GetFixPosY();
-long nScrollPos = GetScrollBarPos( *pScroll, bMirror ) + 
nScrollMin;
+long nScrollPos = GetScrollBarPos( *pScroll ) + nScrollMin;
 
 String aHelpStr;
 Rectangle aRect;
@@ -1139,21 +1139,6 @@ IMPL_LINK( ScTabView, ScrollHdl, ScrollBar*, pScroll )
 
 if ( bOnlineScroll || eType != SCROLL_DRAG )
 {
-if ( bMirror )
-{
-// change scroll type so visible/previous cells calculation below 
remains the same
-switch ( eType )
-{
-case SCROLL_LINEUP: eType = SCROLL_LINEDOWN;break;
-case SCROLL_LINEDOWN:   eType = SCROLL_LINEUP;  break;
-case SCROLL_PAGEUP: eType = SCROLL_PAGEDOWN;break;
-case SCROLL_PAGEDOWN:   eType = SCROLL_PAGEUP;  break;
-default:
-{
-// added to avoid warnings
-}
-}
-}
 long nDelta = pScroll->GetDelta();
 switch ( eType )
 {
@@ -1188,7 +1173,7 @@ IMPL_LINK( ScTabView, ScrollHdl, ScrollBar*, pScroll )
   

[Libreoffice-commits] .: 2 commits - sd/source tools/inc

[Libreoffice Gerrit user]

 sd/source/ui/framework/module/ResourceManager.cxx |   37 +-
 sd/source/ui/framework/module/ResourceManager.hxx |1 
 tools/inc/tools/poly.hxx  |4 +-
 3 files changed, 18 insertions(+), 24 deletions(-)

New commits:
commit 91e81cd4bd8917ee06cd4fc0f7a56979c72100d6
Author: Matúš Kukan 
Date:   Sun Oct 14 14:41:27 2012 +0200

private field 'eType' is not used [-Werror,-Wunused-private-field]

Change-Id: I0c21a0af88eda56a9ccfeeb9691617c67340b3d2

diff --git a/tools/inc/tools/poly.hxx b/tools/inc/tools/poly.hxx
index e8cdcb5..8eb095e 100644
--- a/tools/inc/tools/poly.hxx
+++ b/tools/inc/tools/poly.hxx
@@ -66,8 +66,8 @@ public:
 PolyOptimizeData( sal_uIntPtr nAbsolut ) : eType( 
DATA_ABSOLUT ), mnAbsolut( nAbsolut ) {}
 PolyOptimizeData( sal_uInt16 nPercent ) : eType( 
DATA_PERCENT ), mnPercent( nPercent ) {}
 
-sal_uIntPtr GetAbsValue() const { DBG_ASSERT( eType == DATA_ABSOLUT, 
"Wrong data type" ); return mnAbsolut; }
-sal_uInt16  GetPercentValue() const { DBG_ASSERT( eType == 
DATA_PERCENT, "Wrong data type" ); return mnPercent; }
+sal_uIntPtr GetAbsValue() const { (void) eType; DBG_ASSERT( eType == 
DATA_ABSOLUT, "Wrong data type" ); return mnAbsolut; }
+sal_uInt16  GetPercentValue() const { (void) eType; DBG_ASSERT( eType 
== DATA_PERCENT, "Wrong data type" ); return mnPercent; }
 };
 
 class SvStream;
commit 891b770e42455ad7c2ea1a4137e67d4e7906a533
Author: Matúš Kukan 
Date:   Sun Oct 14 12:46:28 2012 +0200

mbIsEnabled is always true

Change-Id: I473db13d6df401fffc6e161314202446ad4d1333

diff --git a/sd/source/ui/framework/module/ResourceManager.cxx 
b/sd/source/ui/framework/module/ResourceManager.cxx
index 49a40be..c0b07c7 100644
--- a/sd/source/ui/framework/module/ResourceManager.cxx
+++ b/sd/source/ui/framework/module/ResourceManager.cxx
@@ -65,8 +65,7 @@ ResourceManager::ResourceManager (
   mxResourceId(rxResourceId),
   
mxMainViewAnchorId(FrameworkHelper::Instance(rxController)->CreateResourceId(
   FrameworkHelper::msCenterPaneURL)),
-  msCurrentMainViewURL(),
-  mbIsEnabled(true)
+  msCurrentMainViewURL()
 {
 Reference xControllerManager (rxController, UNO_QUERY);
 if (xControllerManager.is())
@@ -190,8 +189,7 @@ void ResourceManager::UpdateForMainViewShell (void)
 {
 ConfigurationController::Lock aLock (mxConfigurationController);
 
-if (mbIsEnabled
-&& mpActiveMainViewContainer->find(msCurrentMainViewURL)
+if (mpActiveMainViewContainer->find(msCurrentMainViewURL)
!= mpActiveMainViewContainer->end())
 {
 // Activate resource.
@@ -232,25 +230,22 @@ void ResourceManager::HandleResourceRequest(
 bool bActivation,
 const Reference& rxConfiguration)
 {
-if (mbIsEnabled)
+Sequence > aCenterViews = 
rxConfiguration->getResources(
+FrameworkHelper::CreateResourceId(FrameworkHelper::msCenterPaneURL),
+FrameworkHelper::msViewURLPrefix,
+AnchorBindingMode_DIRECT);
+if (aCenterViews.getLength() == 1)
 {
-Sequence > aCenterViews = 
rxConfiguration->getResources(
-
FrameworkHelper::CreateResourceId(FrameworkHelper::msCenterPaneURL),
-FrameworkHelper::msViewURLPrefix,
-AnchorBindingMode_DIRECT);
-if (aCenterViews.getLength() == 1)
+if (bActivation)
 {
-if (bActivation)
-{
-
mpActiveMainViewContainer->insert(aCenterViews[0]->getResourceURL());
-}
-else
-{
-MainViewContainer::iterator iElement (
-
mpActiveMainViewContainer->find(aCenterViews[0]->getResourceURL()));
-if (iElement != mpActiveMainViewContainer->end())
-mpActiveMainViewContainer->erase(iElement);
-}
+
mpActiveMainViewContainer->insert(aCenterViews[0]->getResourceURL());
+}
+else
+{
+MainViewContainer::iterator iElement (
+
mpActiveMainViewContainer->find(aCenterViews[0]->getResourceURL()));
+if (iElement != mpActiveMainViewContainer->end())
+mpActiveMainViewContainer->erase(iElement);
 }
 }
 }
diff --git a/sd/source/ui/framework/module/ResourceManager.hxx 
b/sd/source/ui/framework/module/ResourceManager.hxx
index c206877..60da4dd 100644
--- a/sd/source/ui/framework/module/ResourceManager.hxx
+++ b/sd/source/ui/framework/module/ResourceManager.hxx
@@ -94,7 +94,6 @@ private:
 css::uno::Reference 
mxMainViewAnchorId;
 
 ::rtl::OUString msCurrentMainViewURL;
-bool mbIsEnabled;
 
 void HandleMainViewSwitch (
 const ::rtl::OUString& rsViewURL,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman

[Libreoffice-commits] .: sw/source

[Libreoffice Gerrit user]

 sw/source/core/text/portxt.cxx |   20 ++--
 1 file changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 936ac94d08572fbdcdfb0a18611a387af8b30c5f
Author: gerhard oettl 
Date:   Sat Oct 13 11:31:24 2012 +0200

rtl::OUString to OUString

Change-Id: I75bf4d85103663df2e5a2fb905f39c2024769c5d

diff --git a/sw/source/core/text/portxt.cxx b/sw/source/core/text/portxt.cxx
index 0a8212b..b42f016 100644
--- a/sw/source/core/text/portxt.cxx
+++ b/sw/source/core/text/portxt.cxx
@@ -521,7 +521,7 @@ void SwTxtPortion::FormatEOL( SwTxtFormatInfo &rInf )
 if( nHoleLen == GetLen() )
 nBlankSize = Width();
 else
-nBlankSize = nHoleLen * rInf.GetTxtSize(rtl::OUString(' 
')).Width();
+nBlankSize = nHoleLen * rInf.GetTxtSize(OUString(' ')).Width();
 Width( Width() - nBlankSize );
 rInf.X( rInf.X() - nBlankSize );
 SetLen( GetLen() - nHoleLen );
@@ -559,13 +559,13 @@ void SwTxtPortion::Paint( const SwTxtPaintInfo &rInf ) 
const
 if (rInf.OnWin() && 1==rInf.GetLen() && 
CH_TXT_ATR_FIELDEND==rInf.GetTxt().GetChar(rInf.GetIdx()))
 {
 rInf.DrawBackBrush( *this );
-const rtl::OUString aTxt(CH_TXT_ATR_SUBST_FIELDEND);
+const OUString aTxt(CH_TXT_ATR_SUBST_FIELDEND);
 rInf.DrawText( aTxt, *this, 0, aTxt.getLength(), false );
 }
 else if (rInf.OnWin() && 1==rInf.GetLen() && 
CH_TXT_ATR_FIELDSTART==rInf.GetTxt().GetChar(rInf.GetIdx()))
 {
 rInf.DrawBackBrush( *this );
-const rtl::OUString aTxt(CH_TXT_ATR_SUBST_FIELDSTART);
+const OUString aTxt(CH_TXT_ATR_SUBST_FIELDSTART);
 rInf.DrawText( aTxt, *this, 0, aTxt.getLength(), false );
 }
 else if( GetLen() )
@@ -728,7 +728,7 @@ void SwHolePortion::Paint( const SwTxtPaintInfo &rInf ) 
const
 // #i16816# tagged pdf support
 if( rInf.GetVsh() && rInf.GetVsh()->GetViewOptions()->IsPDFExport() )
 {
-const rtl::OUString aTxt( ' ' );
+const OUString aTxt( ' ' );
 rInf.DrawText( aTxt, *this, 0, 1, false );
 }
 }
@@ -768,19 +768,19 @@ sal_Bool SwFieldMarkPortion::Format( SwTxtFormatInfo & )
 
 namespace {
 static sal_Int32 getCurrentListIndex( IFieldmark* pBM,
-::rtl::OUString* io_pCurrentText = NULL )
+OUString* io_pCurrentText = NULL )
 {
 const IFieldmark::parameter_map_t* const pParameters = 
pBM->GetParameters();
 sal_Int32 nCurrentIdx = 0;
-const IFieldmark::parameter_map_t::const_iterator pResult = 
pParameters->find(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(ODF_FORMDROPDOWN_RESULT)));
+const IFieldmark::parameter_map_t::const_iterator pResult = 
pParameters->find(OUString(RTL_CONSTASCII_USTRINGPARAM(ODF_FORMDROPDOWN_RESULT)));
 if(pResult != pParameters->end())
 pResult->second >>= nCurrentIdx;
 if(io_pCurrentText)
 {
-const IFieldmark::parameter_map_t::const_iterator pListEntries = 
pParameters->find(::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(ODF_FORMDROPDOWN_LISTENTRY)));
+const IFieldmark::parameter_map_t::const_iterator pListEntries = 
pParameters->find(OUString(RTL_CONSTASCII_USTRINGPARAM(ODF_FORMDROPDOWN_LISTENTRY)));
 if(pListEntries != pParameters->end())
 {
-uno::Sequence< ::rtl::OUString > vListEntries;
+uno::Sequence< OUString > vListEntries;
 pListEntries->second >>= vListEntries;
 if(nCurrentIdx < vListEntries.getLength())
 *io_pCurrentText = vListEntries[nCurrentIdx];
@@ -814,7 +814,7 @@ void SwFieldFormPortion::Paint( const SwTxtPaintInfo& rInf 
) const
 }
 else if ( pBM->GetFieldname( ) == ODF_FORMDROPDOWN )
 { // a list...
-rtl::OUString aTxt;
+OUString aTxt;
 getCurrentListIndex( pBM, &aTxt );
 rInf.DrawViewOpt( *this, POR_FLD );
 rInf.DrawText( aTxt, *this, 0, aTxt.getLength(), false );
@@ -845,7 +845,7 @@ sal_Bool SwFieldFormPortion::Format( SwTxtFormatInfo & rInf 
)
 }
 else if ( pBM->GetFieldname( ) == ODF_FORMDROPDOWN )
 {
-::rtl::OUString aTxt;
+OUString aTxt;
 getCurrentListIndex( pBM, &aTxt );
 SwPosSize aPosSize = rInf.GetTxtSize( aTxt );
 Width( aPosSize.Width(  ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [REVIEW 3-6-3] fix for fdo#53482, exchange sort options between tab pages

[Kohei Yoshida]

On Wed, Oct 17, 2012 at 11:16 AM, Markus Mohrhard
 wrote:
> Hey,
>
> I just reviewed Noel's old patch for the sort problems around the sort
> dialog. His patch fixes several problems at once where the sort
> options are not exchanged between the tab pages.
>
> I already pushed it to 3-6 but I'd like to see this pushed to 3-6-3 to
> fix all of these problems in the next release.
>
> Regards,
> Markus
>
> [1] 
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=1bc15304a3fb44399ebd3861f6ee5fc12197a969

The change looks good to me.  I'll give my sign-off.  We need one more
sign-off to cherry-pick this to the 3-6-3 branch.

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] remove unused define

[Norbert Thiebaud (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/890

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/890
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 
Gerrit-Reviewer: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: tools/inc

[Libreoffice Gerrit user]

 tools/inc/tools/solar.h |1 -
 1 file changed, 1 deletion(-)

New commits:
commit e5090510cbc1e6130d0a173f3ceacba880d48ea4
Author: Norbert Thiebaud 
Date:   Fri Oct 19 06:00:44 2012 -0500

remove unused define

Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1
Reviewed-on: https://gerrit.libreoffice.org/890
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/tools/inc/tools/solar.h b/tools/inc/tools/solar.h
index ad903c6..b1f3dac 100644
--- a/tools/inc/tools/solar.h
+++ b/tools/inc/tools/solar.h
@@ -183,7 +183,6 @@ template inline T Abs(T a) { return 
(a>=0?a:-a); }
 
 #define UniString   String
 #define XubString   String
-#define xub_Unicode sal_Unicode
 #define xub_StrLen  sal_uInt16
 
 #define LIBRARY_CONCAT3( s1, s2, s3 ) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] remove unused define

[Norbert Thiebaud (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/890

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/890/1

remove unused define

Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1
---
M tools/inc/tools/solar.h
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/890
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia000af4680ea5a58db52ca0c341b1a454b3de4c1
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] replace sxub_Unicode by sal_Unicode

[Norbert Thiebaud (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/887

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/887
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 
Gerrit-Reviewer: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: binfilter

[Libreoffice Gerrit user]

 binfilter |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bd5921b7371c41267ec42a2784778e7b34641ac5
Author: Norbert Thiebaud 
Date:   Fri Oct 19 05:53:26 2012 -0500

Updated core
Project: binfilter  e9e2d065b33d441ffa8838cc15f70a99155893de
null
Change ucb_Unicode to sal_Unicode

Change-Id: Ia48a9bf27e7495cb86fbbbc4b0edc2ff756075b9
Reviewed-on: https://gerrit.libreoffice.org/889
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/binfilter b/binfilter
index 45565e1..e9e2d06 16
--- a/binfilter
+++ b/binfilter
@@ -1 +1 @@
-Subproject commit 45565e1ee1258814b1de7321647c2a7dea8832d5
+Subproject commit e9e2d065b33d441ffa8838cc15f70a99155893de
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: bf_basic/source bf_starmath/source bf_svx/source bf_sw/source inc/bf_starmath inc/bf_sw

[Libreoffice Gerrit user]

 bf_basic/source/sbx/sbxbool.cxx |4 
 bf_basic/source/sbx/sbxbyte.cxx |4 
 bf_basic/source/sbx/sbxchar.cxx |   24 +-
 bf_basic/source/sbx/sbxcurr.cxx |2 
 bf_basic/source/sbx/sbxdate.cxx |2 
 bf_basic/source/sbx/sbxdbl.cxx  |2 
 bf_basic/source/sbx/sbxexec.cxx |   32 +--
 bf_basic/source/sbx/sbxint.cxx  |4 
 bf_basic/source/sbx/sbxlng.cxx  |2 
 bf_basic/source/sbx/sbxscan.cxx |6 
 bf_basic/source/sbx/sbxsng.cxx  |2 
 bf_basic/source/sbx/sbxuint.cxx |2 
 bf_basic/source/sbx/sbxulng.cxx |2 
 bf_basic/source/sbx/sbxvalue.cxx|6 
 bf_basic/source/sbx/sbxvar.cxx  |4 
 bf_starmath/source/starmath_node.cxx|   14 -
 bf_starmath/source/starmath_rect.cxx|   22 +-
 bf_svx/source/editeng/impedit.hxx   |2 
 bf_svx/source/editeng/svx_editdoc.cxx   |6 
 bf_svx/source/editeng/svx_impedit3.cxx  |2 
 bf_svx/source/form/svx_fmmodel.cxx  |2 
 bf_sw/source/core/bastyp/sw_calc.cxx|4 
 bf_sw/source/core/inc/swfont.hxx|   10 -
 bf_sw/source/core/text/inftxt.hxx   |   14 -
 bf_sw/source/core/text/porexp.hxx   |4 
 bf_sw/source/core/text/porfld.hxx   |2 
 bf_sw/source/core/text/portab.hxx   |   18 +-
 bf_sw/source/core/text/sw_guess.cxx |4 
 bf_sw/source/core/text/sw_inftxt.cxx|4 
 bf_sw/source/core/text/sw_itrform2.cxx  |4 
 bf_sw/source/core/text/sw_porexp.cxx|4 
 bf_sw/source/core/text/sw_porfld.cxx|2 
 bf_sw/source/core/text/sw_porlay.cxx|2 
 bf_sw/source/core/text/sw_txtdrop.cxx   |2 
 bf_sw/source/core/text/sw_txttab.cxx|6 
 bf_sw/source/core/txtnode/sw_ndtxt.cxx  |4 
 bf_sw/source/core/txtnode/sw_txtedt.cxx |4 
 inc/bf_starmath/node.hxx|8 
 inc/bf_starmath/types.hxx   |  278 
 inc/bf_sw/ndtxt.hxx |4 
 40 files changed, 262 insertions(+), 262 deletions(-)

New commits:
commit e9e2d065b33d441ffa8838cc15f70a99155893de
Author: Norbert Thiebaud 
Date:   Fri Oct 19 05:53:26 2012 -0500

Change ucb_Unicode to sal_Unicode

Change-Id: Ia48a9bf27e7495cb86fbbbc4b0edc2ff756075b9
Reviewed-on: https://gerrit.libreoffice.org/889
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/bf_basic/source/sbx/sbxbool.cxx b/bf_basic/source/sbx/sbxbool.cxx
index 6fca8d8..0fc39f3 100644
--- a/bf_basic/source/sbx/sbxbool.cxx
+++ b/bf_basic/source/sbx/sbxbool.cxx
@@ -154,7 +154,7 @@ void ImpPutBool( SbxValues* p, INT16 n )
 switch( +p->eType )
 {
 case SbxCHAR:
-p->nChar = (xub_Unicode) n; break;
+p->nChar = (sal_Unicode) n; break;
 case SbxUINT:
 p->nByte = (BYTE) n; break;
 case SbxINTEGER:
@@ -204,7 +204,7 @@ void ImpPutBool( SbxValues* p, INT16 n )
 break;
 }
 case SbxBYREF | SbxCHAR:
-*p->pChar = (xub_Unicode) n; break;
+*p->pChar = (sal_Unicode) n; break;
 case SbxBYREF | SbxBYTE:
 *p->pByte = (BYTE) n; break;
 case SbxBYREF | SbxINTEGER:
diff --git a/bf_basic/source/sbx/sbxbyte.cxx b/bf_basic/source/sbx/sbxbyte.cxx
index a0ecf99..34397ae 100644
--- a/bf_basic/source/sbx/sbxbyte.cxx
+++ b/bf_basic/source/sbx/sbxbyte.cxx
@@ -266,7 +266,7 @@ void ImpPutByte( SbxValues* p, BYTE n )
 break;
 
 case SbxCHAR:
-p->nChar = (xub_Unicode) n; break;
+p->nChar = (sal_Unicode) n; break;
 
 case SbxBYREF | SbxSTRING:
 case SbxSTRING:
@@ -285,7 +285,7 @@ void ImpPutByte( SbxValues* p, BYTE n )
 break;
 }
 case SbxBYREF | SbxCHAR:
-*p->pChar = (xub_Unicode) n; break;
+*p->pChar = (sal_Unicode) n; break;
 case SbxBYREF | SbxBYTE:
 *p->pByte = n; break;
 case SbxBYREF | SbxINTEGER:
diff --git a/bf_basic/source/sbx/sbxchar.cxx b/bf_basic/source/sbx/sbxchar.cxx
index 866bc45..d0259e5 100644
--- a/bf_basic/source/sbx/sbxchar.cxx
+++ b/bf_basic/source/sbx/sbxchar.cxx
@@ -23,10 +23,10 @@
 
 namespace binfilter {
 
-xub_Unicode ImpGetChar( const SbxValues* p )
+sal_Unicode ImpGetChar( const SbxValues* p )
 {
 SbxValues aTmp;
-xub_Unicode nRes;
+sal_Unicode nRes;
 start:
 switch( +p->eType )
 {
@@ -37,7 +37,7 @@ start:
 case SbxCHAR:
 nRes = p->nChar; break;
 case SbxBYTE:
-nRes = (xub_Unicode) p->nByte;
+nRes = (sal_Unicode) p->nByte;
 break;
 case SbxINTEGER:
 case SbxBOOL:
@@ -46,11 +46,11 @@ start:
 SbxBase::SetError( SbxERR_OVERFLOW ); nRes = SbxMINCHAR;
 }
 else
-nRes = (xub_Unicode) p->nInteger;
+nRes = (sal_Unicode) p->nInteger;
 break;
 case SbxERROR:
 c

[Libreoffice-commits] .: writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit d9ebb89f935a2a8bcbd70deaae9115c3634a90f4
Author: Miklos Vajna 
Date:   Fri Oct 19 12:47:18 2012 +0200

writerfilter: remove unused ctor

Change-Id: I17ec2a253e35f90b4f670bb2981aba3402221e1f

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index a842093..8714542 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -382,7 +382,6 @@ public:
 uno::Reference< lang::XComponent >  xModel,
 SourceDocumentType eDocumentType,
 bool bIsNewDoc );
-DomainMapper_Impl();
 virtual ~DomainMapper_Impl();
 
 SectionPropertyMap* GetLastSectionContext( )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] replace sxub_Unicode by sal_Unicode

[Norbert Thiebaud (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/887

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/887/1

replace sxub_Unicode by sal_Unicode

Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
---
M basic/source/sbx/sbxbool.cxx
M basic/source/sbx/sbxbyte.cxx
M basic/source/sbx/sbxchar.cxx
M basic/source/sbx/sbxdate.cxx
M basic/source/sbx/sbxdbl.cxx
M basic/source/sbx/sbxexec.cxx
M basic/source/sbx/sbxint.cxx
M basic/source/sbx/sbxlng.cxx
M basic/source/sbx/sbxscan.cxx
M basic/source/sbx/sbxsng.cxx
M basic/source/sbx/sbxuint.cxx
M basic/source/sbx/sbxulng.cxx
M basic/source/sbx/sbxvalue.cxx
M basic/source/sbx/sbxvar.cxx
14 files changed, 54 insertions(+), 54 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/887
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change ucb_Unicode to sal_Unicode

[Norbert Thiebaud (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/888

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/888/1

Change ucb_Unicode to sal_Unicode

Change-Id: Ibc933a1a5d1f7b78a360364da75f49765607aa80
---
M sw/source/core/bastyp/calc.cxx
M sw/source/core/edit/edlingu.cxx
M sw/source/core/inc/scriptinfo.hxx
M sw/source/core/inc/swfont.hxx
M sw/source/core/text/frminf.cxx
M sw/source/core/text/guess.cxx
M sw/source/core/text/inftxt.cxx
M sw/source/core/text/inftxt.hxx
M sw/source/core/text/itratr.cxx
M sw/source/core/text/itrform2.cxx
M sw/source/core/text/porexp.cxx
M sw/source/core/text/porexp.hxx
M sw/source/core/text/porfld.cxx
M sw/source/core/text/porfld.hxx
M sw/source/core/text/porglue.cxx
M sw/source/core/text/porlay.cxx
M sw/source/core/text/portab.hxx
M sw/source/core/text/txtdrop.cxx
M sw/source/core/text/txtfrm.cxx
M sw/source/core/text/txttab.cxx
M sw/source/core/txtnode/fntcache.cxx
M sw/source/core/txtnode/ndtxt.cxx
M sw/source/core/txtnode/txtedt.cxx
M sw/source/ui/ribbar/inputwin.cxx
24 files changed, 76 insertions(+), 76 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/888
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc933a1a5d1f7b78a360364da75f49765607aa80
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/qa writerfilter/source

[Libreoffice Gerrit user]

 sw/qa/extras/rtfimport/data/dppolyline.rtf |6 
 sw/qa/extras/rtfimport/rtfimport.cxx   |   11 
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   34 -
 writerfilter/source/rtftok/rtfdocumentimpl.hxx |2 +
 4 files changed, 52 insertions(+), 1 deletion(-)

New commits:
commit 1becc60df9caa9fef5011ae877c832fe8bcefb6c
Author: Miklos Vajna 
Date:   Fri Oct 19 12:06:34 2012 +0200

import RTF_DPPOLYLINE

Change-Id: I65f1ddb9d0d691c126c8e94b2e60c8309b0d33ff

diff --git a/sw/qa/extras/rtfimport/data/dppolyline.rtf 
b/sw/qa/extras/rtfimport/data/dppolyline.rtf
new file mode 100644
index 000..0f6b8ce
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/dppolyline.rtf
@@ -0,0 +1,6 @@
+{\rtf1
+{\*\do\dobxpage\dobypara\dodhgt8192\dppolyline\dppolycount2\dpptx11\dppty11\dpptx11\dppty209\dpx10885\dpy8458\dpxsize22\dpysize221}
+{\*\do\dobxpage\dobypara\dodhgt8192\dppolyline\dppolycount2\dpptx1258\dppty11\dpptx11\dppty11\dpx9637\dpy8657\dpxsize1269\dpysize22}
+{\*\do\dobxpage\dobypara\dodhgt8192\dppolyline\dppolycount2\dpptx11\dppty11\dpptx294\dppty68\dpx9637\dpy8657\dpxsize306\dpysize79}
+{\*\do\dobxpage\dobypara\dodhgt8192\dppolyline\dppolycount2\dpptx11\dppty68\dpptx294\dppty11\dpx9637\dpy8600\dpxsize306\dpysize79}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 1ebadad..9db7579 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -120,6 +120,7 @@ public:
 void testDoDhgt();
 void testDplinehollow();
 void testLeftmarginDefault();
+void testDppolyline();
 
 CPPUNIT_TEST_SUITE(Test);
 #if !defined(MACOSX) && !defined(WNT)
@@ -178,6 +179,7 @@ public:
 CPPUNIT_TEST(testDoDhgt);
 CPPUNIT_TEST(testDplinehollow);
 CPPUNIT_TEST(testLeftmarginDefault);
+CPPUNIT_TEST(testDppolyline);
 #endif
 CPPUNIT_TEST_SUITE_END();
 
@@ -945,6 +947,15 @@ void Test::testLeftmarginDefault()
 CPPUNIT_ASSERT_EQUAL(sal_Int32(2540), 
getProperty(getStyles("PageStyles")->getByName("Default"), 
"LeftMargin"));
 }
 
+void Test::testDppolyline()
+{
+// This was completely ignored, for now, just make sure we have all 4 
lines.
+load("dppolyline.rtf");
+uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xDraws(xDrawPageSupplier->getDrawPage(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xDraws->getCount());
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 19d1465..452c107 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -2273,6 +2273,7 @@ int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 case RTF_DPRECT:
 case RTF_DPELLIPSE:
 case RTF_DPTXBX:
+case RTF_DPPOLYLINE:
 {
 sal_Int32 nType = 0;
 switch (nKeyword)
@@ -2280,6 +2281,10 @@ int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 case RTF_DPLINE:
 
m_aStates.top().aDrawingObject.xShape.set(getModelFactory()->createInstance("com.sun.star.drawing.LineShape"),
 uno::UNO_QUERY);
 break;
+case RTF_DPPOLYLINE:
+// The reason this is not a simple CustomShape is 
that in the old syntax we have no ViewBox info.
+
m_aStates.top().aDrawingObject.xShape.set(getModelFactory()->createInstance("com.sun.star.drawing.PolyLineShape"),
 uno::UNO_QUERY);
+break;
 case RTF_DPRECT:
 nType = ESCHER_ShpInst_Rectangle;
 break;
@@ -3143,6 +3148,32 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 case RTF_DODHGT:
 m_aStates.top().aDrawingObject.nDhgt = nParam;
 break;
+case RTF_DPPOLYCOUNT:
+if (nParam >= 0)
+{
+m_aStates.top().aDrawingObject.nPolyLineCount = nParam;
+m_aStates.top().aDrawingObject.aPolyLinePoints.realloc(nParam);
+}
+break;
+case RTF_DPPTX:
+{
+RTFDrawingObject& rDrawingObject = 
m_aStates.top().aDrawingObject;
+
rDrawingObject.aPolyLinePoints[rDrawingObject.aPolyLinePoints.getLength() - 
rDrawingObject.nPolyLineCount].X = TWIP_TO_MM100(nParam);
+}
+break;
+case RTF_DPPTY:
+{
+RTFDrawingObject& rDrawingObject = 
m_aStates.top().aDrawingObject;
+
rDrawingObject.aPolyLinePoints[rDrawingObject.aPolyLinePoints.getLength() - 
rDrawingObject.nPolyLineCount].Y = TWIP_TO_MM100(nParam);
+rDrawingObject.nPolyLineCo

Re: BSA + New Wiki = No Good

[Christian Lohmaier]

Hi Joel, *,

On Fri, Oct 19, 2012 at 7:48 AM, Joel Madero  wrote:
> On 10/18/2012 10:27 PM, Joel Madero wrote:
 Someone else (can't remember who) talked to me earlier in IRC and told me
>> that they had permissions to update BSA site but that make was failing and
>> spitting out errors about the new wiki. I haven't confirmed this as I don't
>> want to break anything but, can someone else with permissions see if they
>> can reproduce?

Reproduced - and it is a rather simple problem:

The additional html tags in the wiki-output on the  tag makes
the removal of the xmlns tag that is added by tidy fail.

i.e.  perl -pe 's|xmlns="http://www.w3.org/1999/xhtml";||'  does
nothing, since it is not
http://www.w3.org/1999/xhtml"; ..> but


"http://www.w3.org/1999/xhtml";>

so remove the xmlns declaration and just run the xslt commands
manually or fix the regular expression or something like that.

ciao
Christian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: deb#690717 fix bashism in /bin/sh script

[Petr Mladek (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/886

Approvals:
  Petr Mladek: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/886
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43b0065e56b234a5aa748ac1593c29a44fdb1647
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Rene Engelhard 
Gerrit-Reviewer: Lionel Elie Mamane 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Petr Mladek 
Gerrit-Reviewer: Rene Engelhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/scripts

[Libreoffice Gerrit user]

 desktop/scripts/soffice.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 68628c7d714110e4474ed61982d6423e936b56aa
Author: Rene Engelhard 
Date:   Thu Oct 18 10:53:03 2012 +0200

deb#690717 fix bashism in /bin/sh script

Change-Id: I43b0065e56b234a5aa748ac1593c29a44fdb1647
Reviewed-on: https://gerrit.libreoffice.org/886
Reviewed-by: Petr Mladek 
Tested-by: Petr Mladek 

diff --git a/desktop/scripts/soffice.sh b/desktop/scripts/soffice.sh
index f35bebb..86c325a 100755
--- a/desktop/scripts/soffice.sh
+++ b/desktop/scripts/soffice.sh
@@ -155,7 +155,7 @@ fi
 # valgrind --log-file=valgrind.log does not work well with --trace-children=yes
 if [ -n "$VALGRINDCHECK" -a -z "$VALGRIND" ] ; then
 echo "redirecting the standard and the error output to valgrind.log"
-exec &>valgrind.log
+exec > valgrind.log 2>&1
 fi
 
 # oosplash does the rest: forcing pages in, javaldx etc. are
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: librsvg/ExternalPackage_librsvg.mk

[Libreoffice Gerrit user]

 librsvg/ExternalPackage_librsvg.mk |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 9e51601833718b529fe2fe5446ec0470d4ee5173
Author: Tor Lillqvist 
Date:   Fri Oct 19 13:10:09 2012 +0300

At least for me these two headers are slightly differently named?!

Change-Id: I8bb933ebfe9782a2a37e11538a9c81723e07dd90

diff --git a/librsvg/ExternalPackage_librsvg.mk 
b/librsvg/ExternalPackage_librsvg.mk
index 540da01..0478e76 100644
--- a/librsvg/ExternalPackage_librsvg.mk
+++ b/librsvg/ExternalPackage_librsvg.mk
@@ -17,8 +17,8 @@ $(eval $(call gb_ExternalPackage_add_files,librsvg,lib,\
 
 $(eval $(call 
gb_ExternalPackage_add_unpacked_files,librsvg,inc/external/librsvg-2.0/librsvg,\
 rsvg-cairo.h \
-rsvg-enum-types.h \
-rsvg-features.h \
+librsvg-enum-types.h \
+librsvg-features.h \
 rsvg.h \
 ))
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: desktop/scripts

[Libreoffice Gerrit user]

 desktop/scripts/soffice.sh |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 293f16bb2d2a6fe3a7c1452474c4c6966547f033
Author: Rene Engelhard 
Date:   Fri Oct 19 12:08:17 2012 +0200

move 2>&1 where it belongs in soffice.sh, thanks mst

Change-Id: I5cc08e3fd88beba70cac61ff4570c02dbad9faa0

diff --git a/desktop/scripts/soffice.sh b/desktop/scripts/soffice.sh
index 0c3ab6d..9afcfdf 100755
--- a/desktop/scripts/soffice.sh
+++ b/desktop/scripts/soffice.sh
@@ -155,7 +155,7 @@ fi
 # valgrind --log-file=valgrind.log does not work well with --trace-children=yes
 if [ -n "$VALGRINDCHECK" -a -z "$VALGRIND" ] ; then
 echo "redirecting the standard and the error output to valgrind.log"
-exec 2>&1 > valgrind.log
+exec > valgrind.log 2>&1
 fi
 
 # oosplash does the rest: forcing pages in, javaldx etc. are
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: BSA + New Wiki = No Good

[Rob Snelders]

Hi All,

I did say that yesterday on the IRC. Since a little while I have been 
working a bit on the BSA.
I seems that with the change of the wiki that the HTML-output of the 
BugReport_Details has been changed.
After the conference I want to look at it. I can run a diff on the old 
and the new output and see what has changed.


For now the BSA on the website still works. But we can't update it at 
the moment so It will have to

be fixed but it can be done a little later.

--
Greetings,
Rob Snelders

Op 19-10-12 07:48, Joel Madero schreef:

On 10/18/2012 10:27 PM, Joel Madero wrote:

Hi All,

Someone else (can't remember who) talked to me earlier in IRC and 
told me that they had permissions to update BSA site but that make 
was failing and spitting out errors about the new wiki. I haven't 
confirmed this as I don't want to break anything but, can someone 
else with permissions see if they can reproduce?


Including Florian on this one since he's in charge of the wiki update.


Regards,
Joel

Now it's confirmed, here is the error:

Current branch master is up to date.
mkdir -p build
curl --silent http://wiki.documentfoundation.org/BugReport_Details | 
tidy --numeric-entities yes -asxhtml 2>/dev/null | perl -pe 
's|xmlns="http://www.w3.org/1999/xhtml";||' > 
build/BugReport_Details.xhtml
xsltproc --encoding UTF-8 --novalid component_comments.xsl 
build/BugReport_Details.xhtml > build/component_comments.xhtml
xsltproc --encoding UTF-8 --novalid subcomponents.xsl 
build/BugReport_Details.xhtml > build/subcomponents.xhtml
xsltproc --encoding UTF-8 --novalid components.xsl 
build/BugReport_Details.xhtml > build/components.xhtml
curl --silent 
'https://bugs.freedesktop.org/query.cgi?product=LibreOffice&query_format=advanced' 
> build/query.xhtml

perl query.pl < build/query.xhtml > build/versions.xhtml
perl sanity.pl build/query.xhtml build/components.xhtml
component Writer found in bugzilla but not in the wiki
component Drawing found in bugzilla but not in the wiki
component UI found in bugzilla but not in the wiki
component Printing and PDF export found in bugzilla but not in the wiki
component Installation found in bugzilla but not in the wiki
component Formula Editor found in bugzilla but not in the wiki
component Extensions found in bugzilla but not in the wiki
component Database found in bugzilla but not in the wiki
component Linguistic found in bugzilla but not in the wiki
component Chart found in bugzilla but not in the wiki
component Localization found in bugzilla but not in the wiki
component Documentation found in bugzilla but not in the wiki
component Presentation found in bugzilla but not in the wiki
component WWW found in bugzilla but not in the wiki
component BASIC found in bugzilla but not in the wiki
component Spreadsheet found in bugzilla but not in the wiki
component Libreoffice found in bugzilla but not in the wiki
wiki URL http://wiki.documentfoundation.org/BugReport_Details
components extracted with components.xsl from the wiki are in 
build/components.xhtml
bugzilla URL 
https://bugassistant.libreoffice.org/enter_bug.cgi?product=LibreOffice

bugzilla information retrieved from build/query.xhtml
make: *** [extract] Error 17


Regards,
Joel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Windows build broken -- multiple target patterns

[Peter Foley]

On windows the build fails with this error:

make -rsC animations
C:/libreoffice/workdir/wntmsci14.pro/Dep/LinkTarget/Library/ianimcore.lib.d:1: 
*** multiple target patterns.  Stop.

I think it is caused by concat-deps.exe being broken by either commit d0bf151 
or 1402818.
I've attached the dep file.
The problem seems to be the lines that contain nothing but a colon.

Thoughts?

Thanks,

Peter Foley
C:/libreoffice/workdir/wntmsci14.pro/CxxObject/animations/source/animcore/animcore.o
 : \
 C:/libreoffice/animations/source/animcore/animcore.cxx \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/util/XCloneable.hpp 
\
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/config.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/systools/win32/snprintf.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Reference.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/alloc.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/saldllapi.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/types.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/macros.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/cppu/macros.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/uno/lbnames.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/ustring.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/diagnose.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/detail/log.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/ustring.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/interlck.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/string.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/textcvt.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/textenc.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/string.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/memory.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/stringutils.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/sal/log.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Any.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/uno/any2.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/cppu/cppudllapi.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/uno/data.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/typelib/typedescription.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/typelib/uik.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/typelib/typeclass.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Type.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/cppu/unotype.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/uno/XInterface.hpp 
\
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/uno/RuntimeException.hpp
 \
 C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/uno/Exception.hpp \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Reference.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/genfunc.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/genfunc.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Any.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Type.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/mutex.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/mutex.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/rtl/instance.hxx \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/doublecheckedlocking.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/osl/getglobalmutex.hxx \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/uno/XComponentContext.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/lang/XMultiComponentFactory.hpp
 \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Sequence.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/uno/sequence2.h \
 C:/libreoffice/solver/wntmsci14.pro/inc/com/sun/star/uno/Sequence.hxx \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/lang/XServiceInfo.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/lang/XTypeProvider.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimateColor.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimate.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/TimeFilterPair.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimationNode.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/beans/NamedValue.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/container/XChild.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/udkapi/com/sun/star/lang/NoSupportException.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimateSet.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimateMotion.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XAnimateTransform.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XTransitionFilter.hpp
 \
 
C:/libreoffice/solver/wntmsci14.pro/inc/offapi/com/sun/star/animations/XTim

Re: GSoC improvement discussion minutes

[Cor Nouws]

Hi Cedric, all,

Cedric Bosdonnat wrote (18-10-12 16:03)


Here are the notes I wrote from our discussion about how to improve our
GSoC processes. I may have missed some bits, feel free to amend it.
[...]


Though I'm not involved, one addition: maybe it's useful to ask 
applicants to tell specific about their relation to LibreOffice, what 
they use it for, or in their environment. Might add a bit to about a 
good picture of the motivation.


For the rest: kudoos to the young developers and the mentors!

--
 - Cor
 - http://nl.libreoffice.org
 - www.librelex.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: fdo#52208 DOCX import: don't always ignore cont sect break a...

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/877

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/877
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6d82c67e068d8dc3ce1edb1a5fe6ad293afd805d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Miklos Vajna 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/source/dmapper/DomainMapper.cxx |   12 ++--
 writerfilter/source/dmapper/PropertyMap.hxx  |1 +
 2 files changed, 11 insertions(+), 2 deletions(-)

New commits:
commit b7cc2a8a22d3723a1efff515eb07669166f158a8
Author: Miklos Vajna 
Date:   Mon Oct 15 12:53:05 2012 +0200

fdo#52208 DOCX import: don't always ignore cont sect break at the doc end

Regression from commit 1fdd61db155cf63d5dd55cc2bfb45af33796e131,
continuous section break does make sense at the end of the doc, if the
previous type was a non-continuous.

(cherry picked from commit abd4ffadf30e02284290ea35e8f45d9ffd8eb5ee)

Change-Id: I6d82c67e068d8dc3ce1edb1a5fe6ad293afd805d
Reviewed-on: https://gerrit.libreoffice.org/877
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index 2068b61..3eed3cd 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2372,9 +2372,17 @@ void DomainMapper::sprmWithProps( Sprm& rSprm, 
PropertyMapPtr rContext, SprmType
 OSL_ENSURE(pSectionContext, "SectionContext unavailable!");
 if(pSectionContext)
 {
-// Ignore continous section break at the end of the document
+// Ignore continous section break at the end of the document, if 
the previous section had the same type as well
 // It makes the importer loose margin settings with no benefit
-if (m_pImpl->GetParaSectpr() || nIntValue != 0)
+SectionPropertyMap* pLastContext = 
m_pImpl->GetLastSectionContext();
+int nPrevBreakType = 0;
+bool bHasPrevSection = false;
+if (pLastContext)
+{
+bHasPrevSection = true;
+nPrevBreakType = pLastContext->GetBreakType();
+}
+if (m_pImpl->GetParaSectpr() || nIntValue != 0 || (bHasPrevSection 
&& nPrevBreakType != nIntValue))
 pSectionContext->SetBreakType( nIntValue );
 }
 break;
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx 
b/writerfilter/source/dmapper/PropertyMap.hxx
index b9a3d5d..7a3b5bd 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -245,6 +245,7 @@ public:
 void SetPageNoRestart( bool bSet ) { m_bPageNoRestart = bSet; }
 void SetPageNumber( sal_Int32 nSet ) { m_nPageNumber = nSet; }
 void SetBreakType( sal_Int32 nSet ) { m_nBreakType = nSet; }
+sal_Int32 GetBreakType( ) { return m_nBreakType; }
 void SetPaperBin( sal_Int32 nSet );
 void SetFirstPaperBin( sal_Int32 nSet );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] Change in core[libreoffice-3-6]: fdo#55493 fix RTF import of specific PNG image

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/860

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/860
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I681e344a042721b99f6cb2e599f9c65156d219a4
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Miklos Vajna 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: BSA + New Wiki = No Good

[Florian Effenberger]

Hi,

I am not subscribed to the FDO list, so please keep me in Cc for your 
replies.


Joel Madero wrote on 2012-10-19 07:48:


Now it's confirmed, here is the error:
I have no idea what the script does, so I probably cannot be of too much 
help here. :( I guess it's a parsing error. All previously installed 
extensions should be available again, but the page template changed a 
bit. Maybe that causes the error and the parser needs some adjustments?


Florian

--
Florian Effenberger, Chairman of the Board (Vorstandsvorsitzender)
Tel: +49 8341 99660880 | Mobile: +49 151 14424108
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/source/rtftok/rtfdocumentimpl.cxx |   18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

New commits:
commit 9a2f97b9539f8101745467758fe03d5e76c0346f
Author: Miklos Vajna 
Date:   Thu Oct 11 16:48:55 2012 +0200

fdo#55493 fix RTF import of specific PNG image

The image was special in that the resulting Graphic's
GetPrefMapMode().GetMapUnit() wasn't MAP_PIXEL.

(cherry picked from commit 5ef0f1dc9a70c20fe6879832b782a0c34724353f)

Conflicts:
writerfilter/source/rtftok/rtfdocumentimpl.cxx

Change-Id: I681e344a042721b99f6cb2e599f9c65156d219a4
Reviewed-on: https://gerrit.libreoffice.org/860
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 45e1920..bf981d9 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -646,12 +646,18 @@ int RTFDocumentImpl::resolvePict(bool bInline)
 // provided by picw and pich.
 OString aURLBS(OUStringToOString(aGraphicUrl, RTL_TEXTENCODING_UTF8));
 const char aURLBegin[] = "vnd.sun.star.GraphicObject:";
-Graphic aGraphic = 
GraphicObject(aURLBS.copy(RTL_CONSTASCII_LENGTH(aURLBegin))).GetTransformedGraphic();
-Size aSize(aGraphic.GetPrefSize());
-MapMode aMap(MAP_100TH_MM);
-aSize = Application::GetDefaultDevice()->PixelToLogic( aSize, aMap );
-m_aStates.top().aPicture.nWidth = aSize.Width();
-m_aStates.top().aPicture.nHeight = aSize.Height();
+if (aURLBS.compareTo(aURLBegin, RTL_CONSTASCII_LENGTH(aURLBegin)) == 0)
+{
+Graphic aGraphic = 
GraphicObject(aURLBS.copy(RTL_CONSTASCII_LENGTH(aURLBegin))).GetTransformedGraphic();
+Size aSize(aGraphic.GetPrefSize());
+MapMode aMap(MAP_100TH_MM);
+if (aGraphic.GetPrefMapMode().GetMapUnit() == MAP_PIXEL)
+aSize = Application::GetDefaultDevice()->PixelToLogic(aSize, 
aMap);
+else
+aSize = OutputDevice::LogicToLogic(aSize, 
aGraphic.GetPrefMapMode(), aMap);
+m_aStates.top().aPicture.nWidth = aSize.Width();
+m_aStates.top().aPicture.nHeight = aSize.Height();
+}
 }
 
 // Wrap it in an XShape.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: fdo#51004: some progress and 10 years old bug pending

[Lionel Elie Mamane]

On Thu, Oct 18, 2012 at 10:26:29PM +0200, David Ostrovsky wrote:
> Am 17.10.2012 13:24, schrieb Lionel Elie Mamane:
>> On Tue, Oct 16, 2012 at 08:07:53AM +0200, David Ostrovsky wrote:

 But take into considreation that on windows old mozab driver
 still used.

>> Sorry, I didn't follow this story closely. Why?

> Because on windows moz driver is also in charge for accessing O and
> OE address book.

That's maybe a reason for keeping mozab around (for O(E) AB support),
but that shouldn't keep us from implementing Mozilla Address Book
support through mork on Windows, too :)

As to accessing Outlook address book, we can access it over ADO (like
we do for Microsoft Access files). It needs Jet 4.0, but it is bundled
with Microsoft Windows since Me/2000. I see several references to
http://msdn.microsoft.com/library/en-us/dnsmart00/html/sa00h12.asp but
it gives me a blank page right now.
Alternative references:
http://support.microsoft.com/kb/275262
http://www.codeproject.com/Questions/192505/Connection-String-for-Outlook-2010
http://www.freevbcode.com/ShowCode.asp?ID=3886
http://vbcity.com/forums/t/6878.aspx


Or we could access Outlook directly over COM/...; there are examples
(for VBA) there:

http://support.microsoft.com/kb/290792
http://support.microsoft.com/kb/290658
http://social.msdn.microsoft.com/forums/en-US/adodotnetdataproviders/thread/812d1fb3-a997-487e-9c4f-75227521d4b8
http://social.msdn.microsoft.com/Forums/en-US/vblanguage/thread/1cf06a86-2a28-4359-8046-6c5b5a5fd934


All these solutions would not require a "new" driver, we just generate
the correct ADO connect URL and hand it off to the ADO driver (as we
do for .mdb / .accdb files).


As to accessing Outlook express address book,
http://forums.devx.com/archive/index.php/t-66624.html
says one can do that through the Windows Address Book (WAB) API. It
seems to be deprecated (see
http://msdn.microsoft.com/en-us/library/ms629361%28v=VS.85%29.aspx
). The replacement is Windows Contacts API
http://msdn.microsoft.com/en-us/library/ms735779%28v=vs.85%29.aspx
that's a venue to explore, too.


This would require an actual driver, that handles the SQL itself, like
mork for Mozilla.


> I see three options here:
> 1/ extract the parser bits from mozilla driver (reverse engineering) or
> 2/ find an alternative parser solution
> and integrate the picked parser implementation in the new mork driver
> or
> 3/ discontinue O and OE address book support (from LO 4?), and wait
> until windows platform
> get non deprecated O/OE native support and then reenable it again.

Or as above use Microsoft's parser :)

-- 
Lionel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Libreoffice Gerrit user]

 sc/source/ui/app/scmod.cxx   |3 +++
 sc/source/ui/optdlg/tpusrlst.cxx |2 ++
 2 files changed, 5 insertions(+)

New commits:
commit 07cc274256ebff259e228e7285bc27e6ddc94fdc
Author: Markus Mohrhard 
Date:   Wed Oct 17 15:45:18 2012 +0200

write the custom sort list info into the item set, fdo#53870

Change-Id: I9c7f62b47f83b7798a8efdbf3896503918929f03
(cherry picked from commit 4302eb0a6c4e28ab675de9d59e73cac345ba30c7)

Signed-off-by: David Tardon 

diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index 845e551..2635cb8 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -2051,7 +2051,10 @@ SfxItemSet*  ScModule::CreateItemSet( sal_uInt16 nId )
 
 // TP_USERLISTS
 if ( pUL )
+{
 aULItem.SetUserList( *pUL );
+pRet->Put(aULItem);
+}
 
 // TP_COMPATIBILITY
 pRet->Put( SfxUInt16Item( SID_SC_OPT_KEY_BINDING_COMPAT,
diff --git a/sc/source/ui/optdlg/tpusrlst.cxx b/sc/source/ui/optdlg/tpusrlst.cxx
index 3eee008..ba6fc9a 100644
--- a/sc/source/ui/optdlg/tpusrlst.cxx
+++ b/sc/source/ui/optdlg/tpusrlst.cxx
@@ -96,6 +96,7 @@ ScTpUserLists::ScTpUserLists( Window*   pParent,
 {
 SetExchangeSupport();
 Init();
+Reset(rCoreAttrs);
 FreeResource();
 }
 
@@ -153,6 +154,7 @@ void ScTpUserLists::Init()
 aFtCopyFrom.Disable();
 aEdCopyFrom.Disable();
 }
+
 }
 
 // ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [REVIEW 3-6-3][REVIEWED 3-6] fdo#53870, write sort list information into the item set

[David Tardon]

Hi,

On Wed, Oct 17, 2012 at 04:30:50PM +0200, Markus Mohrhard wrote:
> Hey,
> 
> [1] writes the custom sort list information into the SfxItemSet.
> Otherwise the old information is lost and a new default custom sort
> list information is created.

Cherry picked.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: unotools/inc unotools/source

[Libreoffice Gerrit user]

 unotools/inc/unotools/textsearch.hxx |   13 +
 unotools/source/i18n/textsearch.cxx  |2 +-
 2 files changed, 2 insertions(+), 13 deletions(-)

New commits:
commit ac60fba3b5a506f6659f268a8b4fa8e1da600603
Author: Markus Mohrhard 
Date:   Thu Oct 18 12:19:04 2012 +0200

delegating a constructor can't work like this, fdo#55033

Change-Id: I6b057ad68054fe5806daec722b3bfe4e33bc3602

diff --git a/unotools/inc/unotools/textsearch.hxx 
b/unotools/inc/unotools/textsearch.hxx
index 42a9e27..2812ee6 100644
--- a/unotools/inc/unotools/textsearch.hxx
+++ b/unotools/inc/unotools/textsearch.hxx
@@ -71,23 +71,12 @@ private:
 long nTransliterationFlags;
 
 public:
-SearchParam( const String &rText,
+SearchParam( const rtl::OUString &rText,
 SearchType eSrchType = SearchParam::SRCH_NORMAL,
 sal_Bool bCaseSensitive = sal_True,
 sal_Bool bWordOnly = sal_False,
 sal_Bool bSearchInSelection = sal_False );
 
-// Wrapper to use OUString as parameter
-SearchParam( const ::rtl::OUString &rText,
-SearchType eSrchType = SearchParam::SRCH_NORMAL,
-sal_Bool bCaseSensitive = sal_True,
-sal_Bool bWordOnly = sal_False,
-sal_Bool bSearchInSelection = sal_False )
-{
-String rText2(rText);
-SearchParam( rText2, eSrchType, bCaseSensitive, bWordOnly, 
bSearchInSelection );
-}
-
 SearchParam( const SearchParam& );
 
 const String&   GetSrchStr() const  { return sSrchStr; }
diff --git a/unotools/source/i18n/textsearch.cxx 
b/unotools/source/i18n/textsearch.cxx
index e0dd061..05eecd8 100644
--- a/unotools/source/i18n/textsearch.cxx
+++ b/unotools/source/i18n/textsearch.cxx
@@ -36,7 +36,7 @@ namespace utl
 {
 // 
 
-SearchParam::SearchParam( const String &rText,
+SearchParam::SearchParam( const rtl::OUString &rText,
 SearchType eType,
 sal_Bool bCaseSensitive,
 sal_Bool bWrdOnly,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [REVIEW 3-6-3][REVIEWED 3-6] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

[David Tardon]

Hi,

On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:
> Hey,
> 
> [1] fixes the problem that blank cells, like broadcaster, cells are
> considerend non empty for the "visible" methods.

Pushed with my sign-off.

Correct me if I am mistaken, but shouldn't the same check be used in
GetFirstVisDataPos and VisibleCount too?

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/column2.cxx |   10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

New commits:
commit 23e6bac62ef6482c287bb0f55c662ac2047ebb33
Author: Markus Mohrhard 
Date:   Wed Oct 17 13:10:09 2012 +0200

only use non blank cells in the visible data methods, fdo#54552

Change-Id: I2a0914fbaff3e3f707a9c06f693079aed2b89ba4
(cherry picked from commit 40377a6e26aa61a1c0788cad1c97a10911d38da8)

Signed-off-by: David Tardon 

diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx
index c28249a..03f7b54 100644
--- a/sc/source/core/data/column2.cxx
+++ b/sc/source/core/data/column2.cxx
@@ -1131,7 +1131,8 @@ bool ScColumn::IsEmptyVisData() const
 SCSIZE i;
 for (i=0; iIsBlank())
+bVisData = true;
 }
 return !bVisData;
 }
@@ -1165,8 +1166,11 @@ SCROW ScColumn::GetLastVisDataPos() const
 for (i=maItems.size(); i>0 && !bFound; )
 {
 --i;
-bFound = true;
-nRet = maItems[i].nRow;
+if(!maItems[i].pCell->IsBlank())
+{
+bFound = true;
+nRet = maItems[i].nRow;
+}
 }
 }
 return nRet;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 8 commits - sc/CppunitTest_sc_subsequent_filters_test.mk sc/Module_sc.mk sc/qa sc/source unotools/source

[Libreoffice Gerrit user]

 sc/CppunitTest_sc_subsequent_filters_test.mk |1 +
 sc/Module_sc.mk  |6 ++
 sc/qa/unit/data/contentCSV/spreadsheet-functions.csv |1 +
 sc/qa/unit/data/ods/formats.ods  |binary
 sc/qa/unit/data/ods/functions.ods|binary
 sc/qa/unit/data/xlsx/formats.xlsx|binary
 sc/source/core/data/documen4.cxx |7 ++-
 sc/source/ui/condformat/condformatdlg.cxx|   10 +-
 sc/source/ui/view/tabvwshc.cxx   |2 +-
 unotools/source/i18n/textsearch.cxx  |   16 +---
 10 files changed, 29 insertions(+), 14 deletions(-)

New commits:
commit 556aa12b84ef6f6d6baf56781925d0868693fe55
Author: Markus Mohrhard 
Date:   Fri Oct 19 10:34:01 2012 +0200

reenable all our unit tests

Change-Id: I9d2ff5f675faa1913dd90e4ce6269efe8bd2646d

diff --git a/sc/Module_sc.mk b/sc/Module_sc.mk
index 2203364..4a53487 100644
--- a/sc/Module_sc.mk
+++ b/sc/Module_sc.mk
@@ -44,6 +44,12 @@ endif
 
 $(eval $(call gb_Module_add_check_targets,sc,\
 CppunitTest_sc_ucalc \
+CppunitTest_sc_filters_test \
+CppunitTest_sc_rangelst_test \
+))
+
+$(eval $(call gb_Module_add_slowcheck_targets,sc, \
+CppunitTest_sc_subsequent_filters_test \
 ))
 
 # Disabled to allow the check tinderbox execute the sd tests
commit cc8949955e58b45a579f3126846541f8b0e4bf64
Author: Markus Mohrhard 
Date:   Fri Oct 19 10:33:17 2012 +0200

add test case for the MATCH function

Change-Id: I627f4b579a5619e788df3726d2bd72a7f4cec964

diff --git a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv 
b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
index 6dbc97a..b8ba298 100644
--- a/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
+++ b/sc/qa/unit/data/contentCSV/spreadsheet-functions.csv
@@ -2,3 +2,4 @@ $C$2,$A$1,Sheet.B$2,Sheet!R2C2
 2,4,4,5,6,15,15,6,9
 1,3,4,4,2,2
 2,4,7,8,4
+4,5,#N/A,8
diff --git a/sc/qa/unit/data/ods/functions.ods 
b/sc/qa/unit/data/ods/functions.ods
index a90a224..6dd969c 100644
Binary files a/sc/qa/unit/data/ods/functions.ods and 
b/sc/qa/unit/data/ods/functions.ods differ
diff --git a/sc/qa/unit/data/xlsx/formats.xlsx 
b/sc/qa/unit/data/xlsx/formats.xlsx
index e579fa5..c75bbc7 100644
Binary files a/sc/qa/unit/data/xlsx/formats.xlsx and 
b/sc/qa/unit/data/xlsx/formats.xlsx differ
commit 4e8d176b4f5e4861a68d582dfbd4c58da4cba3b9
Author: Markus Mohrhard 
Date:   Fri Oct 19 10:29:45 2012 +0200

actually pass the old cond format to the dialog

Change-Id: I78fad788514461fc01100f2b85a668ec2990387d

diff --git a/sc/source/ui/view/tabvwshc.cxx b/sc/source/ui/view/tabvwshc.cxx
index 6ef470a..bb9aa7b 100644
--- a/sc/source/ui/view/tabvwshc.cxx
+++ b/sc/source/ui/view/tabvwshc.cxx
@@ -207,7 +207,7 @@ SfxModelessDialog* ScTabViewShell::CreateRefDialog(
 {
 const ScRangeList& rCondFormatRange = pCondFormat->GetRange();
 if(rCondFormatRange == aRangeList)
-pResult = new ScCondFormatDlg( pB, pCW, pParent, pDoc, 
NULL, rCondFormatRange, aPos, condformat::dialog::NONE );
+pResult = new ScCondFormatDlg( pB, pCW, pParent, pDoc, 
pCondFormat, rCondFormatRange, aPos, condformat::dialog::NONE );
 }
 
 if(!pResult)
commit 0c94072f401d32b6d631423ba98a6b84dc1cc7bd
Author: Markus Mohrhard 
Date:   Fri Oct 19 10:28:37 2012 +0200

differentiate between formula and normal conditions in the dialog

Change-Id: Ie0545b028479fe3de6c642c5f64a1ce8cf7f523b

diff --git a/sc/source/ui/condformat/condformatdlg.cxx 
b/sc/source/ui/condformat/condformatdlg.cxx
index bf4f8b2..fcf7dfc 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -74,7 +74,14 @@ ScCondFormatList::ScCondFormatList(Window* pParent, const 
ResId& rResId, ScDocum
 switch(pEntry->GetType())
 {
 case condformat::CONDITION:
-maEntries.push_back(new ScConditionFrmtEntry( this, mpDoc, 
maPos, static_cast( pEntry ) ) );
+{
+const ScCondFormatEntry* pConditionEntry = 
static_cast( pEntry );
+if(pConditionEntry->GetOperation() != SC_COND_DIRECT)
+maEntries.push_back(new ScConditionFrmtEntry( 
this, mpDoc, maPos, pConditionEntry ) );
+else
+maEntries.push_back(new ScFormulaFrmtEntry( this, 
mpDoc, maPos, pConditionEntry ) );
+
+}
 break;
 case condformat::COLORSCALE:
 maEntries.push_back(new ScColorScale3FrmtEntry( this, 
mpDoc, maPos, static_cast( pEntry ) ) );
@@ -102,6 +109,7 @@ ScCondFormatList::ScCondFormatList(Window* pParent, const 
ResId& rResId, ScDocum
 break;
 }
 }
+RecalcAll();
 if (!m

Re: Errors with Makefile.top for building Windows

[Flavio Moringa]

I,

you have to use another "make" for libreoffice.

Check this:
http://wiki.documentfoundation.org/User:Foral/Build_Win#Cygwin

Cheers
-- 
*Flávio Moringa*
Project Leader



Caixa Mágica Software
Energia Open Source
Rua Soeiro Pereira Gomes, Lote 1 - 4.º B,
Edifício Espanha, 1600-196 Lisboa - Portugal
Tel.: +351 217 921 260 Fax: +351 217 921 261
http://www.caixamagica.pt
https://twitter.com/flaviomoringa
https://www.facebook.com/flaviomoringa
http://pt.linkedin.com/in/flaviomoringa
http://people.caixamagica.pt/flaviomoringa



2012/10/18 julien2412 

> Hello,
>
> On Vista SP2 (32 bits) and with Cygwin 1.7 installed some days ago, I've
> got
> these errors:
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:325: target `D' doesn't
> match the target pattern
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:329: target `D' doesn't
> match the target pattern
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:330: warning: overriding
> recipe for target `D'
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:326: warning: ignoring
> old
> recipe for target `D'
> /cygdrive/d/compile-libreoffice/libo/Makefile.top:396: *** target pattern
> contains no '%'. Stop.
> make[1]: Leaving directory `cygdrive/d/compile-libreoffice/libo'
>
> I found some old links (2006 until 2008) indicated to downgrade Make from
> 3.81 to 3.80
>
> I use make 3.82.90  (Build for i686-pc-cygwin) from dev-tools repo
>
> Any idea?
>
> Julien
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Errors-with-Makefile-top-for-building-Windows-tp4014152.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - compilerplugins/clang solenv/gbuild

[Libreoffice Gerrit user]

 compilerplugins/clang/sallogareas.cxx |8 
 compilerplugins/clang/sallogareas.hxx |1 +
 solenv/gbuild/LinkTarget.mk   |2 +-
 3 files changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 1b3dc82a01a97b917c2cba402ffd8c2d5238910c
Author: Lubos Lunak 
Date:   Thu Oct 18 16:03:44 2012 +0200

use gb_LINKEROPTFLAGS if no explicit LDFLAGS is given

I have no idea why gb_LINKEROPTFLAGS stopped working, it used to be used
and I can't find the commit that removed it.

Change-Id: I537e4e7b686ecc34022f2097fa3e666295294e04

diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index 1d7d66c..870bad1 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -508,7 +508,7 @@ $(call gb_LinkTarget_get_headers_target,$(1)) \
 $(call gb_LinkTarget_get_target,$(1)) : INCLUDE := $$(gb_LinkTarget_INCLUDE)
 $(call gb_LinkTarget_get_headers_target,$(1)) \
 $(call gb_LinkTarget_get_target,$(1)) : INCLUDE_STL := 
$$(gb_LinkTarget_INCLUDE_STL)
-$(call gb_LinkTarget_get_target,$(1)) : T_LDFLAGS := $$(gb_LinkTarget_LDFLAGS) 
$(LDFLAGS)
+$(call gb_LinkTarget_get_target,$(1)) : T_LDFLAGS := $$(gb_LinkTarget_LDFLAGS) 
$(if $(LDFLAGS),$(LDFLAGS),$(gb_LINKEROPTFLAGS))
 $(call gb_LinkTarget_get_target,$(1)) : LINKED_LIBS :=
 $(call gb_LinkTarget_get_target,$(1)) : LINKED_STATIC_LIBS :=
 $(call gb_LinkTarget_get_target,$(1)) : LIBS :=
commit 1a77b93aec7070327a91f21c801d2e951b5a068d
Author: Lubos Lunak 
Date:   Wed Oct 17 19:53:32 2012 +0200

only one warning per one SAL_INFO/SAL_WARN

Change-Id: I5aafe9ed51c86dc31492d205f44fba6b1db137d2

diff --git a/compilerplugins/clang/sallogareas.cxx 
b/compilerplugins/clang/sallogareas.cxx
index 1dd99b9..1a4a8b2 100644
--- a/compilerplugins/clang/sallogareas.cxx
+++ b/compilerplugins/clang/sallogareas.cxx
@@ -31,6 +31,7 @@ SalLogAreas::SalLogAreas( ASTContext& context )
 void SalLogAreas::run()
 {
 inFunction = NULL;
+lastSalDetailLogStreamMacro = SourceLocation();
 TraverseDecl( context.getTranslationUnitDecl());
 }
 
@@ -55,6 +56,13 @@ bool SalLogAreas::VisitCallExpr( CallExpr* call )
 {
 if( const StringLiteral* area = dyn_cast< StringLiteral >( 
call->getArg( 1 )->IgnoreParenImpCasts()))
 {
+// The SAL_DETAIL_LOG_STREAM macro expands to two calls to 
sal::detail::log(),
+// so do not warn repeatedly about the same macro (the 
area->getLocStart() of all the calls
+// from the same macro should be the same).
+SourceLocation expansionLocation = 
context.getSourceManager().getExpansionLoc(area->getLocStart());
+if( expansionLocation == lastSalDetailLogStreamMacro )
+return true;
+lastSalDetailLogStreamMacro = expansionLocation;
 if( area->getKind() == StringLiteral::Ascii )
 checkArea( area->getBytes(), area->getExprLoc());
 else
diff --git a/compilerplugins/clang/sallogareas.hxx 
b/compilerplugins/clang/sallogareas.hxx
index 72f0e75..e83e890 100644
--- a/compilerplugins/clang/sallogareas.hxx
+++ b/compilerplugins/clang/sallogareas.hxx
@@ -31,6 +31,7 @@ class SalLogAreas
 void checkArea( StringRef area, SourceLocation location );
 void readLogAreas();
 const FunctionDecl* inFunction;
+SourceLocation lastSalDetailLogStreamMacro;
 set< string > logAreas;
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/column3.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit 637096b75f2989640967e72aee41e48b07a5a602
Author: Markus Mohrhard 
Date:   Wed Oct 17 12:28:27 2012 +0200

ignore broadcaster cells to fill autofilter dialog, fdo#55712

Change-Id: Iacd3f8cfc26bb147eaf3b6957338be212b448226
(cherry picked from commit 622f7751b78fd8584e34f5fa96a04ed6e8bb98f5)

Signed-off-by: David Tardon 

diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 48d77dc..475299d 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -1501,6 +1501,10 @@ void ScColumn::GetFilterEntries(SCROW nStartRow, SCROW 
nEndRow, std::vectorhttp://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [REVIEW 3-6-3][REVIEWED 3-6] fix for fdo#55712, ignore broadcaster cells to fill autofilter dialog

[David Tardon]

Hi,

On Wed, Oct 17, 2012 at 04:26:22PM +0200, Markus Mohrhard wrote:
> Hey,
> 
> [1] fixes the problem that cells referenced in a formula where added
> to the autofilter dialog.

Pushed with my sign-off.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-3-6]: deb#690717 fix bashism in /bin/sh script

[Rene Engelhard (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/886

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/886/1

deb#690717 fix bashism in /bin/sh script

Change-Id: I43b0065e56b234a5aa748ac1593c29a44fdb1647
---
M desktop/scripts/soffice.sh
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/886
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I43b0065e56b234a5aa748ac1593c29a44fdb1647
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Rene Engelhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

[David Tardon]

Hi,

On Tue, Oct 16, 2012 at 06:23:01PM -0700, V Stuart Foote wrote:
> David,
> 
> Nominated the fdo#53474 as a most annoying for 3.6.  It is a regression from
> 3.5 and has been with us now for four build/QA reviews.
> 
> Not sure of the etiquette but are you willing to take assignment of the bug? 

Provisionally, on the condition that the patch really fixes the problem
:-) I am going to step back immediately if it does not, because I do not
have Windows, so I have no means to debug it.

> 
> The Java Accessibility testers (JavaMonkey and JavaFerret) are pretty
> simplistic, but appear on a par to the Accerciser  test tool for Gnome ATK
> AT-SPI--not sure why they would not have be invoked in QA process.
> 
> Unfortunately, with both the MSVC and MinGW Tinderbox builds of Master not
> currently producing usable builds no way to test your patch.  Any chance of
> getting a nod from fellow devs to push down to a 3.6 build and come at it
> that way?

I guess that would not be a problem (except to actually round someone to
review the patch, because nearly everyone is at the conference).

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 5 commits - sw/source vcl/inc vcl/source

[Libreoffice Gerrit user]

 sw/source/ui/cctrl/actctrl.cxx  |2 -
 vcl/inc/svids.hrc   |2 +
 vcl/inc/vcl/edit.hxx|2 -
 vcl/inc/vcl/fixed.hxx   |3 ++
 vcl/source/control/combobox.cxx |6 ++--
 vcl/source/control/edit.cxx |4 +-
 vcl/source/control/fixed.cxx|   35 +--
 vcl/source/src/btntext.src  |   10 ++
 vcl/source/window/builder.cxx   |   59 ++--
 9 files changed, 81 insertions(+), 42 deletions(-)

New commits:
commit 06b8cdc503e021a644219a064503433482d98d48
Author: Caolán McNamara 
Date:   Fri Oct 19 08:43:02 2012 +0100

SetMaxWidthInChars -> SetMinWidthInChars

Change-Id: Ie7b6f8c07beb5895a1437e3da1cc57084e1da114

diff --git a/sw/source/ui/cctrl/actctrl.cxx b/sw/source/ui/cctrl/actctrl.cxx
index 18c2ac4..6300fee 100644
--- a/sw/source/ui/cctrl/actctrl.cxx
+++ b/sw/source/ui/cctrl/actctrl.cxx
@@ -129,7 +129,7 @@ void ReturnActionEdit::KeyInput( const KeyEvent& rEvt)
 extern "C" SAL_DLLPUBLIC_EXPORT Window* SAL_CALL makeTableNameEdit(Window 
*pParent, VclBuilder::stringmap &)
 {
 TableNameEdit* pTableNameEdit = new TableNameEdit(pParent);
-pTableNameEdit->SetMaxWidthInChars(25);
+pTableNameEdit->SetMinWidthInChars(25);
 return pTableNameEdit;
 }
 
commit e20ebf2653bdd42e90ae97f1e77aa4591907b882
Author: Caolán McNamara 
Date:   Thu Oct 18 22:07:56 2012 +0100

support width-chars property for labels

Change-Id: Iba51f30a5e74d1e486bce10901ccb58f3488ce97

diff --git a/vcl/inc/vcl/fixed.hxx b/vcl/inc/vcl/fixed.hxx
index 397e3cf..1d6f1bf 100644
--- a/vcl/inc/vcl/fixed.hxx
+++ b/vcl/inc/vcl/fixed.hxx
@@ -45,6 +45,7 @@ class VCL_DLLPUBLIC FixedText : public Control
 {
 private:
 sal_Int32 m_nMaxWidthChars;
+sal_Int32 m_nMinWidthChars;
 
 using Control::ImplInitSettings;
 using Window::ImplInit;
@@ -75,6 +76,8 @@ public:
 
 void setMaxWidthChars(sal_Int32 nWidth);
 sal_Int32 getMaxWidthChars() const { return m_nMaxWidthChars; }
+void setMinWidthChars(sal_Int32 nWidth);
+sal_Int32 getMinWidthChars() const { return m_nMinWidthChars; }
 static Size CalcMinimumTextSize(Control const* pControl, long 
nMaxWidth = 0x7fff);
 static Size getTextDimensions(Control const *pControl, const OUString 
&rTxt, long nMaxWidth);
 SizeCalcMinimumSize(long nMaxWidth = 0x7fff) const;
diff --git a/vcl/source/control/fixed.cxx b/vcl/source/control/fixed.cxx
index 9d35c1f..f330d8f 100644
--- a/vcl/source/control/fixed.cxx
+++ b/vcl/source/control/fixed.cxx
@@ -33,7 +33,7 @@
 #include "vcl/dialog.hxx"
 #include "vcl/event.hxx"
 #include "vcl/fixed.hxx"
-
+#include 
 #include "controldata.hxx"
 #include "window.h"
 
@@ -157,6 +157,7 @@ void FixedText::ImplInitSettings( sal_Bool bFont,
 FixedText::FixedText( Window* pParent, WinBits nStyle )
 : Control(WINDOW_FIXEDTEXT)
 , m_nMaxWidthChars(-1)
+, m_nMinWidthChars(-1)
 {
 ImplInit( pParent, nStyle );
 }
@@ -166,6 +167,7 @@ FixedText::FixedText( Window* pParent, WinBits nStyle )
 FixedText::FixedText( Window* pParent, const ResId& rResId )
 : Control(WINDOW_FIXEDTEXT)
 , m_nMaxWidthChars(-1)
+, m_nMinWidthChars(-1)
 {
 rResId.SetRT( RSC_TEXT );
 WinBits nStyle = ImplInitRes( rResId );
@@ -193,6 +195,7 @@ void FixedText::take_properties(Window &rOther)
 FixedText::FixedText( Window* pParent, const ResId& rResId, bool 
bDisableAccessibleLabelForRelation )
 : Control( WINDOW_FIXEDTEXT )
 , m_nMaxWidthChars(-1)
+, m_nMinWidthChars(-1)
 {
 rResId.SetRT( RSC_TEXT );
 WinBits nStyle = ImplInitRes( rResId );
@@ -446,7 +449,17 @@ Size FixedText::GetOptimalSize(WindowSizeType eType) const
 nMaxAvailWidth = getTextDimensions(this,
 rTxt.copy(0, m_nMaxWidthChars), 0x7fff).Width();
 }
-return CalcMinimumSize(nMaxAvailWidth);
+Size aRet = CalcMinimumSize(nMaxAvailWidth);
+if (m_nMinWidthChars != -1)
+{
+OUStringBuffer aBuf;
+comphelper::string::padToLength(aBuf, m_nMinWidthChars, 'x');
+Size aMinAllowed = getTextDimensions(this,
+aBuf.makeStringAndClear(), 0x7fff);
+if (aMinAllowed.Width() > aRet.Width())
+aRet = aMinAllowed;
+}
+return aRet;
 }
 default:
 return Control::GetOptimalSize( eType );
@@ -470,10 +483,21 @@ void FixedText::setMaxWidthChars(sal_Int32 nWidth)
 }
 }
 
+void FixedText::setMinWidthChars(sal_Int32 nWidth)
+{
+if (nWidth != m_nMinWidthChars)
+{
+m_nMinWidthChars = nWidth;
+queue_resize();
+}
+}
+
 bool FixedText::set_property(const rtl::OString &rKey, const rtl::OString 
&rValue)
 {
 if (rKey == "max-width-chars")
 setMaxWidthChars(rValue.toInt32());
+else if (rKey == "width-chars")
+setMinWidthChars(rValue.toInt

Re: Reality Check - Windows Java Accessibility API non-functional for ALL LibreOffice 3.6.x releases to date

[David Tardon]

Hi,

On Mon, Oct 15, 2012 at 08:46:17AM -0700, V Stuart Foote wrote:
> Hope the fix is a simple as that!
> 
> Since I reopened the  FDO#53474
>    bug, I am happy to
> re-test, but I'm not set up to build.
> 
> Assume I would grab the below 3.6 build  on next cycle.  It doesn't look as
> if the Master for Windows Tinderbox  is being routinely built.

It seems that W2008R2 tinderbox is producing builds again: see 
http://dev-builds.libreoffice.org/daily/W2008R2@16-minimal_build/master/2012-10-18_10.09.04/
 . I am not sure the msi is installable, though, because of 
https://bugs.freedesktop.org/show_bug.cgi?id=55290 . The build incorporates my 
attempt to fix the problem, but I have not got a word back yet...

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||51023

--- Comment #149 from Rainer Bielefeld  ---
Shift from 3.5 MAB to here because 3.5 lifecycle has ended: "Bug 51023 -
EDITING: Drag-and-drop slide always moves slide to first position, leading to
data corruption and sometimes CRASH"; dataloss risk for Linux and Mac users

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on|51023   |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice