[PATCH] don't activate magic linking option per default: -Wl,-S

[David Ostrovsky (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/949

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/949/1

don't activate magic linking option per default: -Wl,-S

The build should not be smarter then it should, at least not
in the default case. But if someone want magic, it can be achived
with a new environment variable: BUILD_MAGIC=YES.

So if someone always wants magic, he should export that variable
in his einvironemnt, i. e. export BUILD_MAGIC=YES. If someone wants
magic only sometimes, he can pass it per command line:

make BUILD_MAGIC=YES 

Currently only stripping of symbols during linking is controled with
that option but feel free to add more magic to the build process.

Change-Id: If8e663e37713acd3b30b562352ef304bc901517a
---
M solenv/gbuild/LinkTarget.mk
1 file changed, 6 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/949
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8e663e37713acd3b30b562352ef304bc901517a
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Ostrovsky 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove a unused method from sd

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/948

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/948/1

Remove a unused method from sd

This was a method declared inside a macro. Removed by now.

Change-Id: Iae918397a61f1b08983b666248075feeded8d99b
Signed-off-by: Marcos Paulo de Souza 
---
M sd/source/ui/inc/PaneShells.hxx
M sfx2/inc/sfx2/shell.hxx
2 files changed, 0 insertions(+), 4 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/948
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae918397a61f1b08983b666248075feeded8d99b
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method from test

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/947

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/947/1

Remove unused method from test

Change-Id: Id54d9bd2963573c4b8e77de0dfafe33ea5882d32
Signed-off-by: Marcos Paulo de Souza 
---
M unotest/inc/unotest/bootstrapfixturebase.hxx
M unotest/source/cpp/bootstrapfixturebase.cxx
M unusedcode.easy
3 files changed, 0 insertions(+), 9 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/947
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id54d9bd2963573c4b8e77de0dfafe33ea5882d32
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method in editeng

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/945

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/945/1

Remove unused method in editeng

Change-Id: Ia283f2e70fa623d0155b6de51ad5441163505cc0
Signed-off-by: Marcos Paulo de Souza 
---
M editeng/inc/editeng/svxacorr.hxx
M editeng/source/misc/svxacorr.cxx
2 files changed, 0 insertions(+), 11 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/945
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia283f2e70fa623d0155b6de51ad5441163505cc0
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused method in formula module

[Marcos Souza (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/946

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/946/1

Remove unused method in formula module

Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921
Signed-off-by: Marcos Paulo de Souza 
---
M formula/inc/formula/tokenarray.hxx
M formula/source/core/api/token.cxx
M unusedcode.easy
3 files changed, 0 insertions(+), 9 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/946
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67259c5a3894be406b2d38900368a3f8aac86921
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Norbert Thiebaud]

On Tue, Oct 30, 2012 at 5:11 PM, Michael Stahl  wrote:
> On 30/10/12 22:35, Markus Mohrhard wrote:
>> 2012/10/30 Kohei Yoshida :
>>> Well, the idea is to *just* add -g to the flags without modifying any other
>>> flags, and *just* remove -Wl,-S from LDFLAGS without removing other flags.
>>> Changing other flags will change the generated binaries which may affect
>>> reproducibility of certain bugs and/or performance profile of the
>>> executable, and I'd like to avoid that (if we can).
>>>
>>
>> I have to agree with Kohei. The enable symbol option was the best and
>> only way to get a build that you could use to profile calc.
>>
>> To get useful profile runs it was necessary to compile with
>> optimization because of the heavy template use inside calc (mdds, ...)
>>
>> Are there any plans to provide a similar option again?
>
> the --enable-symbols option and related ENABLE_SYMBOLS variable were
> removed because nobody used or needed them (except for release builders,
> who (it was argued) can just set CXXFLAGS instead).

Actually I used --enable-symbol on the Mac daily build to get better
backtrace in bug report.

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

no functional TinderBox for master/3-7 full Windows builds

[V Stuart Foote]

Looking at http://wiki.documentfoundation.org/Development/Tinderbox and the
http://tinderbox.libreoffice.org/index.html

I know every body's busy, but any chance that one of the three TinderBox's
for Windows master/3-7  can be brought back on line?

TB 16 doesn't build the full Windows bundle.  And TB 9 is not building
master/3-7 (just 3-6 and 3-5).

TB 6 and TB 7 look to have been taken down while fdo#55290 installer error
1935 was open, so can they be turned back on? Or could  a master/3-7 build 
be added to TB 9?

Stuart Foote
LibreOffice QA Volunteer
Windows (and other a11y) accessibility
 



--
View this message in context: 
http://nabble.documentfoundation.org/no-functional-TinderBox-for-master-3-7-full-Windows-builds-tp4016034.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW 3-6] fdo#56325 - Very simple fix for pivot table's database query bug

[Kohei Yoshida]

And of course there is a bug in the Subject.

I meant to type "Very simple fix", not "Every simple fix"...

Sometimes the muscle memory of your fingers can work against you.

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[REVIEW 3-6] fdo#56325 - Every simple fix for pivot table's database query bug

[Kohei Yoshida]

Hi there,

I'd like to have the attached patch pushed to the 3-6 branch in order to fix

https://bugs.freedesktop.org/show_bug.cgi?id=56325

This patch is basically an equivalent of

http://cgit.freedesktop.org/libreoffice/core/commit/?id=acfdd93f31ae59bb688c27d2fd57e1940a6b9370

on master, but due to my earlier indentation fix, it won't simply be
cherry-picked to the 3-6 branch. But the two changes are basically the same
change minus the indentation difference.

The punch line of this fix is that I just forgot to build the tree of
flat_segment_tree before it was searched in isRowActive().  That ended up
filtering out all the records incorrectly for the database data source,
which would end up with an empty table output.

Kohei


0001-fdo-56325-Don-t-forget-to-build_tree-in-fillTable.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] ::rtl::OUString -> OUString in basegfx

[via Code Review]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/929

Approvals:
  Caolán McNamara: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/929
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2e0189135d5f30b20e625b849cedbef2eb639ed9
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Caolán McNamara 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: basegfx/source

[Libreoffice Gerrit user]

 basegfx/source/polygon/b2dsvgpolypolygon.cxx |   54 +--
 basegfx/source/tools/canvastools.cxx |2 -
 basegfx/source/tools/unopolypolygon.cxx  |   18 -
 3 files changed, 36 insertions(+), 38 deletions(-)

New commits:
commit 6bc62f4f43c7458399169ddb2cba30ae4188b1bd
Author: Ricardo Montania 
Date:   Sat Oct 27 15:43:55 2012 -0200

::rtl::OUString -> OUString in basegfx

Change-Id: I2e0189135d5f30b20e625b849cedbef2eb639ed9
Reviewed-on: https://gerrit.libreoffice.org/929
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/basegfx/source/polygon/b2dsvgpolypolygon.cxx 
b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
index 0c9e3bf..22bb1d3 100644
--- a/basegfx/source/polygon/b2dsvgpolypolygon.cxx
+++ b/basegfx/source/polygon/b2dsvgpolypolygon.cxx
@@ -41,9 +41,9 @@ namespace basegfx
 {
 namespace
 {
-void lcl_skipSpaces(sal_Int32&  io_rPos,
-const ::rtl::OUString&  rStr,
-const sal_Int32 nLen)
+void lcl_skipSpaces(sal_Int32&  io_rPos,
+const OUString& rStr,
+const sal_Int32 nLen)
 {
 while( io_rPos < nLen &&
sal_Unicode(' ') == rStr[io_rPos] )
@@ -52,9 +52,9 @@ namespace basegfx
 }
 }
 
-void lcl_skipSpacesAndCommas(sal_Int32& io_rPos,
- const ::rtl::OUString& rStr,
- const sal_Int32nLen)
+void lcl_skipSpacesAndCommas(sal_Int32& io_rPos,
+ const OUString&rStr,
+ const sal_Int32nLen)
 {
 while(io_rPos < nLen
   && (sal_Unicode(' ') == rStr[io_rPos] || 
sal_Unicode(',') == rStr[io_rPos]))
@@ -73,18 +73,18 @@ namespace basegfx
 return bPredicate;
 }
 
-inline bool lcl_isOnNumberChar(const ::rtl::OUString& rStr, const 
sal_Int32 nPos, bool bSignAllowed = true)
+inline bool lcl_isOnNumberChar(const OUString& rStr, const 
sal_Int32 nPos, bool bSignAllowed = true)
 {
 return lcl_isOnNumberChar(rStr[nPos],
   bSignAllowed);
 }
 
-bool lcl_getDoubleChar(double&  o_fRetval,
-   sal_Int32&   io_rPos,
-   const ::rtl::OUString&   rStr)
+bool lcl_getDoubleChar(double&  o_fRetval,
+   sal_Int32&   io_rPos,
+   const OUString&  rStr)
 {
 sal_Unicode aChar( rStr[io_rPos] );
-::rtl::OUStringBuffer sNumberString;
+OUStringBuffer sNumberString;
 bool separator_seen=false;
 
 if(sal_Unicode('+') == aChar || sal_Unicode('-') == aChar)
@@ -133,10 +133,10 @@ namespace basegfx
 return false;
 }
 
-bool lcl_importDoubleAndSpaces( double& o_fRetval,
-sal_Int32&  io_rPos,
-const ::rtl::OUString&  rStr,
-const sal_Int32 nLen )
+bool lcl_importDoubleAndSpaces( double& o_fRetval,
+sal_Int32&  io_rPos,
+const OUString& rStr,
+const sal_Int32 nLen )
 {
 if( !lcl_getDoubleChar(o_fRetval, io_rPos, rStr) )
 return false;
@@ -146,10 +146,10 @@ namespace basegfx
 return true;
 }
 
-bool lcl_importFlagAndSpaces(sal_Int32&   o_nRetval,
- sal_Int32&   io_rPos,
- const ::rtl::OUString&   rStr,
- const sal_Int32  nLen)
+bool lcl_importFlagAndSpaces(sal_Int32& o_nRetval,
+ sal_Int32& io_rPos,
+ const OUString&rStr,
+ const sal_Int32nLen)
 {
 sal_Unicode aChar( rStr[io_rPos] );
 
@@ -171,14 +171,14 @@ namespace basegfx
 return true;
 }
 
-void lcl_putNumberChar( ::rtl::OUStringBuffer& rStr,
-double fValue )
+vo

[PUSHED] ::rtl::OUString -> OUString in basebmp

[via Code Review]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/928

Approvals:
  Caolán McNamara: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/928
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id9cde5559165c61da825938153e92df999233a59
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: Caolán McNamara 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: basebmp/test

[Libreoffice Gerrit user]

 basebmp/test/bmpdemo.cxx |   17 -
 basebmp/test/bmpmasktest.cxx |4 ++--
 basebmp/test/bmptest.cxx |2 +-
 basebmp/test/cliptest.cxx|4 ++--
 basebmp/test/filltest.cxx|2 +-
 basebmp/test/masktest.cxx|2 +-
 basebmp/test/polytest.cxx|   18 +-
 7 files changed, 24 insertions(+), 25 deletions(-)

New commits:
commit 9cb8bef68b67b5f2fba3bee38cd8449ea804b86e
Author: Ricardo Montania 
Date:   Sat Oct 27 15:34:06 2012 -0200

::rtl::OUString -> OUString in basebmp

Change-Id: Id9cde5559165c61da825938153e92df999233a59
Reviewed-on: https://gerrit.libreoffice.org/928
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/basebmp/test/bmpdemo.cxx b/basebmp/test/bmpdemo.cxx
index 18f4cab..a7f39fc 100644
--- a/basebmp/test/bmpdemo.cxx
+++ b/basebmp/test/bmpdemo.cxx
@@ -959,7 +959,7 @@ class TestWindow : public Dialog
 public:
 TestWindow() : Dialog( (Window *) NULL )
 {
-SetText( rtl::OUString( "VIGRA test" ) );
+SetText( OUString( "VIGRA test" ) );
 SetSizePixel( Size( 1024, 1024 ) );
 EnablePaint( true );
 Show();
@@ -1059,16 +1059,15 @@ void TestWindow::Paint( const Rectangle& /*rRect*/ )
  
basebmp::Format::THIRTYTWO_BIT_TC_MASK ));
 
 {
-::rtl::OUString aSvg;
+OUString aSvg;
+
 basegfx::B2DPolyPolygon aPoly;
 
-basegfx::tools::importFromSvgD( aPoly,
-::rtl::OUString( "m0 0 h7 v7 h-7 z" ) 
);
-basegfx::tools::importFromSvgD( aPoly,
-::rtl::OUString( "m2 2 h3 v3 h-3 z" ) 
);
+basegfx::tools::importFromSvgD( aPoly, OUString( "m0 0 h7 v7 h-7 z" ) 
);
+
+basegfx::tools::importFromSvgD( aPoly, OUString( "m2 2 h3 v3 h-3 z" ) 
);
 
-pDevice->fillPolyPolygon(
-aPoly,
+pDevice->fillPolyPolygon( aPoly,
 basebmp::Color(0x),
 basebmp::DrawMode_PAINT );
 }
@@ -1084,7 +1083,7 @@ void TestWindow::Paint( const Rectangle& /*rRect*/ )
 pMask->drawLine( aPt111, aPt222, aCol333, basebmp::DrawMode_PAINT );
 
 
-::rtl::OUString aSvg( "m 0 0 h5 l5 5 v5 h-5 l-5-5 z" );
+OUString aSvg( "m 0 0 h5 l5 5 v5 h-5 l-5-5 z" );
 basegfx::B2DPolyPolygon aPoly;
 basegfx::tools::importFromSvgD( aPoly, aSvg );
 pMask->clear(basebmp::Color(0x));
diff --git a/basebmp/test/bmpmasktest.cxx b/basebmp/test/bmpmasktest.cxx
index f81083f..500ba91 100644
--- a/basebmp/test/bmpmasktest.cxx
+++ b/basebmp/test/bmpmasktest.cxx
@@ -109,7 +109,7 @@ public:
  true,
  Format::THIRTYTWO_BIT_TC_MASK );
 
-::rtl::OUString aSvg( "m 0 0h5v10h5v-5h-10z" );
+OUString aSvg( "m 0 0h5v10h5v-5h-10z" );
 
 basegfx::B2DPolyPolygon aPoly;
 basegfx::tools::importFromSvgD( aPoly, aSvg );
@@ -124,7 +124,7 @@ public:
 aColWhite,
 DrawMode_PAINT );
 
-aSvg = ::rtl::OUString( "m 0 0 h6 v10 h-6z" );
+aSvg = "m 0 0 h6 v10 h-6z" ;
 
 aPoly.clear();
 basegfx::tools::importFromSvgD( aPoly, aSvg );
diff --git a/basebmp/test/bmptest.cxx b/basebmp/test/bmptest.cxx
index e4b0931..571e32e 100644
--- a/basebmp/test/bmptest.cxx
+++ b/basebmp/test/bmptest.cxx
@@ -146,7 +146,7 @@ public:
  true,
  Format::THIRTYTWO_BIT_TC_MASK );
 
-::rtl::OUString aSvg( RTL_CONSTASCII_USTRINGPARAM( "m 0 
0h5v10h5v-5h-10z" ));
+OUString aSvg( "m 0 0h5v10h5v-5h-10z" );
 
 basegfx::B2DPolyPolygon aPoly;
 basegfx::tools::importFromSvgD( aPoly, aSvg );
diff --git a/basebmp/test/cliptest.cxx b/basebmp/test/cliptest.cxx
index ca13ef8..21f94aa 100644
--- a/basebmp/test/cliptest.cxx
+++ b/basebmp/test/cliptest.cxx
@@ -158,7 +158,7 @@ private:
 true,
 Format::EIGHT_BIT_GREY 
));
 
-::rtl::OUString aSvg( RTL_CONSTASCII_USTRINGPARAM( "m 0 
0h5v10h5v-5h-10z" ));
+OUString aSvg( "m 0 0h5v10h5v-5h-10z" );
 
 basegfx::B2DPolyPolygon aPoly;
 basegfx::tools::importFromSvgD( aPoly, aSvg );
@@ -198,7 +198,7 @@ public:
true,
Format::THIRTYTWO_BIT_TC_MASK );
 
-::rtl::OUString aSvg( RTL_CONSTASCII_USTRINGPARAM( "m 0 0 h5 l5 5 v5 
h-5 l-5-5 z" ));
+OUString aSvg( "m 0 0 h5 l5 5 v5 h-5 l-5-5 z" );
 basegfx::B2DPolyPolygon aPoly;
 basegfx::tools::importFromSvgD( aPoly, aSvg );
 mpClipMask->clear(Color(0));
diff --git a/basebmp/test/filltest.cxx b/basebmp/test/filltest.cxx
index 5e7b02

[Libreoffice-commits] .: sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/dpcachetable.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit acfdd93f31ae59bb688c27d2fd57e1940a6b9370
Author: Kohei Yoshida 
Date:   Tue Oct 30 20:38:59 2012 -0400

fdo#56325: Don't forget to build_tree() in fillTable().

Else you'll get the wrong answer in isRowActive(), which always search
flag via tree.

Change-Id: Ic764b08c3fa3e2e24ea656bb03cc9d393e06fb13

diff --git a/sc/source/core/data/dpcachetable.cxx 
b/sc/source/core/data/dpcachetable.cxx
index d877955..a71a8f2 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -143,6 +143,7 @@ void ScDPCacheTable::fillTable(
 
 maShowByFilter.clear();
 maShowByPage.clear();
+maShowByPage.build_tree();
 
 // Process the non-empty data rows.
 for (SCROW nRow = 0; nRow < nDataSize; ++nRow)
@@ -214,9 +215,12 @@ void ScDPCacheTable::fillTable()
 if (nRowCount <= 0 || nColCount <= 0)
 return;
 
-maShowByFilter.clear();
 maShowByPage.clear();
+maShowByPage.build_tree();
+
+maShowByFilter.clear();
 maShowByFilter.insert_front(0, nRowCount, true);
+maShowByFilter.build_tree();
 
 // Initialize field entries container.
 maFieldEntries.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/source

[Libreoffice Gerrit user]

 sc/source/core/data/dpcachetable.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 10844794fcba4a0012d3746194c5be0af7f4799a
Author: Kohei Yoshida 
Date:   Tue Oct 30 20:33:07 2012 -0400

Somehow that comment makes no sense.

Change-Id: Ic6d11b8660048dfc074c6e0bfe6b367aca6baef2

diff --git a/sc/source/core/data/dpcachetable.cxx 
b/sc/source/core/data/dpcachetable.cxx
index 01fab13..d877955 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -454,7 +454,6 @@ void ScDPCacheTable::dump() const
 {
 cout << "--- pivot cache filter dump" << endl;
 
-// Flat segment tree always has at least 2 nodes.
 cout << endl;
 cout << "* show by filter" << endl;
 dumpRowFlag(maShowByFilter);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 3 commits - sc/inc sc/source

[Libreoffice Gerrit user]

 sc/inc/dpcachetable.hxx  |9 ++-
 sc/source/core/data/dpcachetable.cxx |  103 +++
 sc/source/core/data/dpitemdata.cxx   |2 
 3 files changed, 80 insertions(+), 34 deletions(-)

New commits:
commit ad39f5eca2603377baa3b7452218c99daad93ec2
Author: Kohei Yoshida 
Date:   Tue Oct 30 20:31:48 2012 -0400

dump() method for ScDPCacheTable (for debugging only).

Change-Id: I3d4a4dd5efa64d1506562f976d88599c084b25ab

diff --git a/sc/inc/dpcachetable.hxx b/sc/inc/dpcachetable.hxx
index c55ec26..84edf6a 100644
--- a/sc/inc/dpcachetable.hxx
+++ b/sc/inc/dpcachetable.hxx
@@ -33,6 +33,7 @@
 #include "osl/mutex.hxx"
 #include "global.hxx"
 #include "dpitemdata.hxx"
+#include "dpmacros.hxx"
 
 #include 
 #include 
@@ -55,6 +56,8 @@ struct ScQueryParam;
  */
 class SC_DLLPUBLIC ScDPCacheTable
 {
+typedef mdds::flat_segment_tree RowFlagType;
+
 public:
 /** interface class used for filtering of rows. */
 class FilterBase
@@ -155,6 +158,11 @@ public:
 bool empty() const;
 bool hasCache() const;
 
+#if DEBUG_PIVOT_TABLE
+void dumpRowFlag(const RowFlagType& rFlag) const;
+void dump() const;
+#endif
+
 private:
 ScDPCacheTable();
 ScDPCacheTable(const ScDPCacheTable&);
@@ -168,7 +176,6 @@ private:
 bool isRowQualified(sal_Int32 nRow, const ::std::vector& 
rCriteria, const ::boost::unordered_set& rRepeatIfEmptyDims) const;
 
 private:
-typedef mdds::flat_segment_tree RowFlagType;
 
 /** unique field entires for each field (column). */
 ::std::vector< ::std::vector > maFieldEntries;
diff --git a/sc/source/core/data/dpcachetable.cxx 
b/sc/source/core/data/dpcachetable.cxx
index 9cadf1c..01fab13 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -431,4 +431,41 @@ const ScDPCache* ScDPCacheTable::getCache() const
 return mpCache;
 }
 
+#if DEBUG_PIVOT_TABLE
+#include 
+using std::cout;
+using std::endl;
+
+void ScDPCacheTable::dumpRowFlag(const RowFlagType& rFlag) const
+{
+RowFlagType::const_iterator it = rFlag.begin(), itEnd = rFlag.end();
+bool bShow = it->second;
+SCROW nRow1 = it->first;
+for (++it; it != itEnd; ++it)
+{
+SCROW nRow2 = it->first;
+cout << "  * range " << nRow1 << "-" << nRow2 << ": " << (bShow ? "on" 
: "off") << endl;
+bShow = it->second;
+nRow1 = nRow2;
+}
+}
+
+void ScDPCacheTable::dump() const
+{
+cout << "--- pivot cache filter dump" << endl;
+
+// Flat segment tree always has at least 2 nodes.
+cout << endl;
+cout << "* show by filter" << endl;
+dumpRowFlag(maShowByFilter);
+
+cout << endl;
+cout << "* show by page dimensions" << endl;
+dumpRowFlag(maShowByPage);
+
+cout << "---" << endl;
+}
+
+#endif
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit beebcb6b671702952c4bc0fb9794345142a6452c
Author: Kohei Yoshida 
Date:   Tue Oct 30 19:31:18 2012 -0400

Somehow the indentation was messed up in this method.

It was using a 3-space indentation as opposed to 4.

Change-Id: Idfb0e455c5d0afcad0a8b943dee9fd2679e6209d

diff --git a/sc/source/core/data/dpcachetable.cxx 
b/sc/source/core/data/dpcachetable.cxx
index 14f4e8e..9cadf1c 100644
--- a/sc/source/core/data/dpcachetable.cxx
+++ b/sc/source/core/data/dpcachetable.cxx
@@ -209,41 +209,41 @@ void ScDPCacheTable::fillTable(
 
 void ScDPCacheTable::fillTable()
 {
-   SCROW nRowCount = getRowSize();
-   SCCOL nColCount = getColSize();
-   if (nRowCount <= 0 || nColCount <= 0)
+SCROW nRowCount = getRowSize();
+SCCOL nColCount = getColSize();
+if (nRowCount <= 0 || nColCount <= 0)
 return;
 
-   maShowByFilter.clear();
-   maShowByPage.clear();
-   maShowByFilter.insert_front(0, nRowCount, true);
-
-   // Initialize field entries container.
-   maFieldEntries.clear();
-   maFieldEntries.reserve(nColCount);
-
-   // Data rows
-   for (SCCOL nCol = 0; nCol < nColCount; ++nCol)
-   {
-   maFieldEntries.push_back( vector() );
-   SCROW nMemCount = getCache()->GetDimMemberCount( nCol );
-   if (!nMemCount)
-   continue;
-
-   std::vector aAdded(nMemCount, -1);
-
-   for (SCROW nRow = 0; nRow < nRowCount; ++nRow)
-   {
-   SCROW nIndex = getCache()->GetItemDataId(nCol, nRow, false);
-   SCROW nOrder = getOrder(nCol, nIndex);
-   aAdded[nOrder] = nIndex;
-   }
-   for (SCROW nRow = 0; nRow < nMemCount; ++nRow)
-   {
-   if (aAdded[nRow] != -1)
-   maFieldEntries.back().push_back(aAdded[nRow]);
-   }
-   }
+maShowByFilter.clear();
+maShowByPage.clear();
+maShowByFilter.insert_front(0, nRowCount, true);
+
+// Initialize field entries container.
+maFieldEntries.clear();
+maFieldEntries.reserve(nColCount);
+
+// Data rows
+for (SCCOL nCol = 0; nCol < nColCount; ++nCol)
+{
+maFieldEntries.push_back( vector() );
+SCROW nMemCount = getCa

Re: ENABLE_SYMBOLS=true does nothing

[Kohei Yoshida]

On Tue, Oct 30, 2012 at 6:11 PM, Michael Stahl  wrote:

> the --enable-symbols option and related ENABLE_SYMBOLS variable were
> removed because nobody used or needed them (except for release builders,
> who (it was argued) can just set CXXFLAGS instead).
>
> since there is now evidence of actual users of this functionality
> perhaps that removal should be reconsidered.

Speaking for me personally, I could live with the change and use my
wrapper script to add -g manually *if* we can reconsider not adding
the -Wl,-S flag to the linker.

Kohei
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] cppCheck: unusedStructMember

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/943

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/943
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I06a901a5442cacf0f7fa2b0c775fc89709968601
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] cppCheck: avoid obvious 'redundantAssignment'

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/944

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/944
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: desktop/source

[Libreoffice Gerrit user]

 desktop/source/splash/splash.cxx |8 
 1 file changed, 8 deletions(-)

New commits:
commit 41e338a27daf3c6eb882cce832a42070f901fa2e
Author: jailletc36 
Date:   Tue Oct 30 23:09:27 2012 +0100

cppCheck: unusedStructMember

Kill unused class member and struct definition in
desktop/source/splash/splash.cxx


Change-Id: I06a901a5442cacf0f7fa2b0c775fc89709968601
Signed-off-by: jailletc36 
Reviewed-on: https://gerrit.libreoffice.org/943
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/desktop/source/splash/splash.cxx b/desktop/source/splash/splash.cxx
index 1f816cd..2321293 100644
--- a/desktop/source/splash/splash.cxx
+++ b/desktop/source/splash/splash.cxx
@@ -63,13 +63,6 @@ class  SplashScreen
 , public IntroWindow
 {
 private:
-struct FullScreenProgressRatioValue
-{
-double _fXRelPos;
-double _fYRelPos;
-double _fRelWidth;
-double _fRelHeight;
-};
 enum BitmapMode { BM_FULLSCREEN, BM_DEFAULTMODE };
 
 DECL_LINK( AppEventListenerHdl, VclWindowEvent * );
@@ -89,7 +82,6 @@ private:
 bool_bNativeProgress;
 OUString_sAppName;
 OUString_sProgressText;
-std::vector< FullScreenProgressRatioValue > 
_sFullScreenProgressRatioValues;
 
 sal_Int32   _iMax;
 sal_Int32   _iProgress;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: fpicker/source

[Libreoffice Gerrit user]

 fpicker/source/win32/filepicker/filepickerstate.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit bb43dc240c8fb4c09033eda5dac15ea41e7647db
Author: jailletc36 
Date:   Tue Oct 30 23:24:26 2012 +0100

cppCheck: avoid obvious 'redundantAssignment'


Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff
Signed-off-by: jailletc36 
Reviewed-on: https://gerrit.libreoffice.org/944
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/fpicker/source/win32/filepicker/filepickerstate.cxx 
b/fpicker/source/win32/filepicker/filepickerstate.cxx
index f4cac50..3684d4a 100644
--- a/fpicker/source/win32/filepicker/filepickerstate.cxx
+++ b/fpicker/source/win32/filepicker/filepickerstate.cxx
@@ -498,7 +498,6 @@ OUString SAL_CALL CExecuteFilePickerState::getLabel( 
sal_Int16 aControlId )
 OUString ctrlLabel;
 if ( nRet )
 {
-ctrlLabel = OUString( aLabel, rtl_ustr_getLength( aLabel ) );
 ctrlLabel = WindowsToSOfficeLabel( aLabel );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] cppCheck: avoid obvious 'redundantAssignment'

[Christophe JAILLET (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/944

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/944/1

cppCheck: avoid obvious 'redundantAssignment'


Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff
Signed-off-by: jailletc36 
---
M fpicker/source/win32/filepicker/filepickerstate.cxx
1 file changed, 0 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/944
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib819c1664dc1643b0d8bf9f516fc0b328f201bff
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Michael Stahl]

On 30/10/12 22:35, Markus Mohrhard wrote:
> 2012/10/30 Kohei Yoshida :
>> Well, the idea is to *just* add -g to the flags without modifying any other
>> flags, and *just* remove -Wl,-S from LDFLAGS without removing other flags.
>> Changing other flags will change the generated binaries which may affect
>> reproducibility of certain bugs and/or performance profile of the
>> executable, and I'd like to avoid that (if we can).
>>
> 
> I have to agree with Kohei. The enable symbol option was the best and
> only way to get a build that you could use to profile calc.
> 
> To get useful profile runs it was necessary to compile with
> optimization because of the heavy template use inside calc (mdds, ...)
> 
> Are there any plans to provide a similar option again?

the --enable-symbols option and related ENABLE_SYMBOLS variable were
removed because nobody used or needed them (except for release builders,
who (it was argued) can just set CXXFLAGS instead).

since there is now evidence of actual users of this functionality
perhaps that removal should be reconsidered.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[David Ostrovsky]

On 30.10.2012 22:03, Kohei Yoshida wrote:

...

inside a module should just enable debug symbols, and nothing but 
symbols.


So, this script can add -g to the CXXFLAGS, but unfortunately the 
symbols get stripped during linking because of -Wl,-S option passed to 
the linker. 


grep -r LINKERSTRIPDEBUGFLAGS *
LinkTarget.mk:gb_LinkTarget__get_stripldflags=$(if $(call 
gb_LinkTarget__debug_enabled,$(1)),,$(gb_LINKERSTRIPDEBUGFLAGS))

platform/unxgcc.mk:gb_LINKERSTRIPDEBUGFLAGS := -Wl,-S

But why something like that would be needed anyway? If you don't want 
symbols, don't use -g and If you do have symbols don't strip it!
I would recommend to follow the rule of least surprise: no one expects 
the symbols to be stripped.
Would it be an option to remove that magic behaviour or at least turn it 
off per default?


Regards
David



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] cppCheck: unusedStructMember

[Christophe JAILLET (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/943

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/943/1

cppCheck: unusedStructMember

Kill unused class member and struct definition in
desktop/source/splash/splash.cxx


Change-Id: I06a901a5442cacf0f7fa2b0c775fc89709968601
Signed-off-by: jailletc36 
---
M desktop/source/splash/splash.cxx
1 file changed, 0 insertions(+), 8 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/943
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06a901a5442cacf0f7fa2b0c775fc89709968601
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - writerfilter/inc writerfilter/source

[Libreoffice Gerrit user]

 writerfilter/inc/resourcemodel/TableData.hxx |4 ++--
 writerfilter/inc/resourcemodel/TableManager.hxx  |6 +++---
 writerfilter/source/dmapper/DomainMapper.cxx |4 ++--
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |   14 +++---
 writerfilter/source/dmapper/DomainMapperTableManager.cxx |6 +++---
 writerfilter/source/dmapper/DomainMapperTableManager.hxx |8 
 writerfilter/source/dmapper/PropertyMap.cxx  |8 +++-
 writerfilter/source/dmapper/PropertyMap.hxx  |3 +--
 writerfilter/source/dmapper/StyleSheetTable.cxx  |   13 +++--
 writerfilter/source/dmapper/TablePropertiesHandler.cxx   |2 +-
 writerfilter/source/dmapper/TablePropertiesHandler.hxx   |8 
 writerfilter/source/resourcemodel/resourcemodel.cxx  |2 +-
 12 files changed, 38 insertions(+), 40 deletions(-)

New commits:
commit b660210ed809aacfc4095542e93e22c51500c377
Author: Michael Stahl 
Date:   Tue Oct 30 22:39:23 2012 +0100

writerfilter: remove PropertyMap::InsertPropsNoOverwrite again:

Turns out nobody calls that, so the boolean parameter to insert method
was not just ugly but entirely pointless.

Change-Id: Icb928747d51487d6884a16dcc1f4e22b00c7c22b

diff --git a/writerfilter/source/dmapper/PropertyMap.cxx 
b/writerfilter/source/dmapper/PropertyMap.cxx
index 4ea094b..5a90e50 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -223,21 +223,12 @@ template
   }
 };
 
-
 void PropertyMap::InsertProps(const PropertyMapPtr pMap)
 {
 if( pMap.get() )
 {
 ::std::for_each( pMap->begin(), pMap->end(),
 removeExistingElements(*this) );
-InsertPropsNoOverwrite(pMap);
-}
-}
-
-void PropertyMap::InsertPropsNoOverwrite(const PropertyMapPtr pMap)
-{
-if( pMap.get() )
-{
 _PropertyMap::insert(pMap->begin(), pMap->end());
 insertTableProperties(pMap.get());
 
@@ -245,7 +236,6 @@ void PropertyMap::InsertPropsNoOverwrite(const 
PropertyMapPtr pMap)
 }
 }
 
-
 const uno::Reference< text::XFootnote>&  PropertyMap::GetFootnote() const
 {
 return m_xFootnote;
diff --git a/writerfilter/source/dmapper/PropertyMap.hxx 
b/writerfilter/source/dmapper/PropertyMap.hxx
index 90fb5c4..50878e0 100644
--- a/writerfilter/source/dmapper/PropertyMap.hxx
+++ b/writerfilter/source/dmapper/PropertyMap.hxx
@@ -105,7 +105,6 @@ public:
 /** Add property, usually overwrites already available attributes. It 
shouldn't overwrite in case of default attributes
  */
 void Insert( PropertyIds eId, bool bIsTextProperty, const 
::com::sun::star::uno::Any& rAny, bool bOverwrite = true );
-void InsertPropsNoOverwrite(const boost::shared_ptr pMap);
 void InsertProps(const boost::shared_ptr pMap);
 
 const ::com::sun::star::uno::Reference< 
::com::sun::star::text::XFootnote>&  GetFootnote() const;
commit 4d13a68d75bc7e125d57ec34322c54967d12ecbb
Author: Michael Stahl 
Date:   Tue Oct 30 22:33:45 2012 +0100

writerfilter: clean up PropertyMap::insert mess:

Rumor has it that MSVC 2010 has problems choosing the right overload in
PropertyMap::insert call, which is no surprise as that is a ridiculous
piece of garbage.  Special bonus points for having another class
TablePropsRef that must have a call compatible method because it's used
as parameter to the same templates, and for the call with a pointer
converted to boolean implicitly in StyleSheetTable.cxx:163.
Also remove the silly boolean parameter while at it, just have 2 methods
instead.

Change-Id: I022d5dd7008f3e6c510d94e19fbacbf04bcf1986

diff --git a/writerfilter/inc/resourcemodel/TableData.hxx 
b/writerfilter/inc/resourcemodel/TableData.hxx
index d251b8f..61efa41 100644
--- a/writerfilter/inc/resourcemodel/TableData.hxx
+++ b/writerfilter/inc/resourcemodel/TableData.hxx
@@ -90,7 +90,7 @@ public:
 void insertProperties(PropertiesPointer pProps)
 {
 if( mpProps.get() )
-mpProps->insert(pProps);
+mpProps->InsertProps(pProps);
 else
 mpProps = pProps;
 }
@@ -182,7 +182,7 @@ public:
 if( !mpProperties.get() )
 mpProperties = pProperties;
 else
-mpProperties->insert( pProperties );
+mpProperties->InsertProps(pProperties);
 }
 }
 
diff --git a/writerfilter/inc/resourcemodel/TableManager.hxx 
b/writerfilter/inc/resourcemodel/TableManager.hxx
index c601adf..71d9a81 100644
--- a/writerfilter/inc/resourcemodel/TableManager.hxx
+++ b/writerfilter/inc/resourcemodel/TableManager.hxx
@@ -890,7 +890,7 @@ void TableManager::cellProps(PropertiesPointer pProps)
 #endif
 
 if(getCellProps().get())
-getCellProps()->insert( pProps );
+getCellProps()->InsertProps(pProps);
 else
 setCellProps(pProps);
 
@@ -926,7 +926,7 

Re: ENABLE_SYMBOLS=true does nothing

[Markus Mohrhard]

2012/10/30 Kohei Yoshida :
> On 10/30/2012 05:27 PM, Lubos Lunak wrote:
>>
>> On Tuesday 30 of October 2012, Kohei Yoshida wrote:
>>>
>>> So, this script can add -g to the CXXFLAGS, but unfortunately the
>>> symbols get stripped during linking because of -Wl,-S option passed to
>>> the linker.
>>>
>>> To work around this, I need to find a way to not add this -S option to
>>> the linker flag in my wrapper script, but so far I'm a bit lost.  It's
>>> easier to add an additional flag but is very hard to remove flag
>>> manually.
>>>
>>> Any clever ideas?
>>
>>
>>   make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS=''
>>
>>   If that doesn't work then I need to fix it.
>
>
> Well, the idea is to *just* add -g to the flags without modifying any other
> flags, and *just* remove -Wl,-S from LDFLAGS without removing other flags.
> Changing other flags will change the generated binaries which may affect
> reproducibility of certain bugs and/or performance profile of the
> executable, and I'd like to avoid that (if we can).
>

I have to agree with Kohei. The enable symbol option was the best and
only way to get a build that you could use to profile calc.

To get useful profile runs it was necessary to compile with
optimization because of the heavy template use inside calc (mdds, ...)

Are there any plans to provide a similar option again?

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Kohei Yoshida]

On 10/30/2012 05:27 PM, Lubos Lunak wrote:

On Tuesday 30 of October 2012, Kohei Yoshida wrote:

So, this script can add -g to the CXXFLAGS, but unfortunately the
symbols get stripped during linking because of -Wl,-S option passed to
the linker.

To work around this, I need to find a way to not add this -S option to
the linker flag in my wrapper script, but so far I'm a bit lost.  It's
easier to add an additional flag but is very hard to remove flag manually.

Any clever ideas?


  make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS=''

  If that doesn't work then I need to fix it.


Well, the idea is to *just* add -g to the flags without modifying any 
other flags, and *just* remove -Wl,-S from LDFLAGS without removing 
other flags.  Changing other flags will change the generated binaries 
which may affect reproducibility of certain bugs and/or performance 
profile of the executable, and I'd like to avoid that (if we can).


Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Lubos Lunak]

On Tuesday 30 of October 2012, Kohei Yoshida wrote:
> So, this script can add -g to the CXXFLAGS, but unfortunately the
> symbols get stripped during linking because of -Wl,-S option passed to
> the linker.
>
> To work around this, I need to find a way to not add this -S option to
> the linker flag in my wrapper script, but so far I'm a bit lost.  It's
> easier to add an additional flag but is very hard to remove flag manually.
>
> Any clever ideas?

 make CFLAGS='-O -g' CXXFLAGS='-O -g' LDFLAGS=''

 If that doesn't work then I need to fix it.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Ruslan Kabatsayev]

Dirty workaround would be to make a wrapper around ld, which would
filter the command line and call real ld.

On Wed, Oct 31, 2012 at 1:03 AM, Kohei Yoshida  wrote:
> On 10/30/2012 04:07 PM, Kohei Yoshida wrote:
>>
>> On 10/30/2012 03:42 PM, Lubos Lunak wrote:
>>>
>>> On Tuesday 30 of October 2012, Kohei Yoshida wrote:

 Hi there,

 Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't
 seem to turn on symbols.

 Does this ring a bell to anyone?
>>>
>>>
>>>
>>>
>>> http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html
>>>
>>
>> Thanks.  Obviously I missed that that change would eliminate
>> ENABLE_SYMBOLS option altogether.
>>
>> Anyway, sounds like not many people use this option, and I happened to
>> be one of the few that use it (?)  So, I wrote a wrapper to make to
>> revive this use case.
>
>
> ...
>
>
>> inside a module should just enable debug symbols, and nothing but symbols.
>
>
> So, this script can add -g to the CXXFLAGS, but unfortunately the symbols
> get stripped during linking because of -Wl,-S option passed to the linker.
>
> To work around this, I need to find a way to not add this -S option to the
> linker flag in my wrapper script, but so far I'm a bit lost.  It's easier to
> add an additional flag but is very hard to remove flag manually.
>
> Any clever ideas?
>
>
> Kohei
>
> --
> Kohei Yoshida, LibreOffice hacker, Calc
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-commits] .: 4 commits - config_host.mk.in configure.ac epm/ExternalPackage_epm.mk epm/ExternalProject_epm.mk epm/Makefile epm/makefile.mk epm/Module_epm.mk epm/prj epm/UnpackedTarball

[Matúš Kukan]

On 30 October 2012 14:03, Thorsten Behrens  wrote:
> checking for ldap.h... no
> configure: error: header file  is required for LDAP
>
> (though it is clearly there at
> workdir/unxlngx6/UnpackedTarball/openldap/include/ldap.h)

Ops, sorry. It seems, while testing, I forgot to remove
solver/*/inc/openldap delivered by dmake :-(
Should be fixed with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=30e6227c6f31bb9273dc4e3a429033c4069e72ad

I hope it's ok to use include path directly for tarball.

Best,
Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Kohei Yoshida]

On 10/30/2012 04:07 PM, Kohei Yoshida wrote:

On 10/30/2012 03:42 PM, Lubos Lunak wrote:

On Tuesday 30 of October 2012, Kohei Yoshida wrote:

Hi there,

Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't
seem to turn on symbols.

Does this ring a bell to anyone?



http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html



Thanks.  Obviously I missed that that change would eliminate
ENABLE_SYMBOLS option altogether.

Anyway, sounds like not many people use this option, and I happened to
be one of the few that use it (?)  So, I wrote a wrapper to make to
revive this use case.


...


inside a module should just enable debug symbols, and nothing but symbols.


So, this script can add -g to the CXXFLAGS, but unfortunately the 
symbols get stripped during linking because of -Wl,-S option passed to 
the linker.


To work around this, I need to find a way to not add this -S option to 
the linker flag in my wrapper script, but so far I'm a bit lost.  It's 
easier to add an additional flag but is very hard to remove flag manually.


Any clever ideas?

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: postgresql/ExternalProject_postgresql.mk

[Libreoffice Gerrit user]

 postgresql/ExternalProject_postgresql.mk |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 30e6227c6f31bb9273dc4e3a429033c4069e72ad
Author: Matúš Kukan 
Date:   Tue Oct 30 22:01:39 2012 +0100

postgresql: forgot to change include path for openldap

Change-Id: I3ce3906662ff6ce5855e4c20c3d2f927288bec9f

diff --git a/postgresql/ExternalProject_postgresql.mk 
b/postgresql/ExternalProject_postgresql.mk
index afefab1..a023852 100644
--- a/postgresql/ExternalProject_postgresql.mk
+++ b/postgresql/ExternalProject_postgresql.mk
@@ -33,7 +33,11 @@ $(call gb_ExternalProject_get_state_target,postgresql,build) 
:
$(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)) \
$(if $(filter YES,$(WITH_KRB5)),--with-krb5) \
$(if $(filter YES,$(WITH_GSSAPI)),--with-gssapi) \
-   $(if $(filter 
NO,$(SYSTEM_OPENLDAP)),CPPFLAGS="-I$(OUTDIR)/inc/openldap" 
LDFLAGS="-L$(OUTDIR)/lib" EXTRA_LDAP_LIBS="-llber -lssl3 -lsmime3 -lnss3 
-lnssutil3 -lplds4 -lplc4 -lnspr4") \
+   $(if $(filter NO,$(SYSTEM_OPENLDAP)), \
+   CPPFLAGS="-I$(call 
gb_UnpackedTarball_get_dir,openldap/include)" \
+   LDFLAGS="-L$(OUTDIR)/lib" \
+   EXTRA_LDAP_LIBS="-llber -lssl3 -lsmime3 -lnss3 
-lnssutil3 -lplds4 -lplc4 -lnspr4" \
+   ) \
&& cd src/interfaces/libpq \
&& MAKEFLAGS= && $(MAKE) all-static-lib libpq-flags.mk \
&& touch $@
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] fix parallelism variables and let's have only --with-paralle...

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/930

Approvals:
  Christian Lohmaier: Looks good to me, but someone else must approve
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/930
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I501de732d223ce0c935081bd1d73da611d16ee88
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan 
Gerrit-Reviewer: Christian Lohmaier 
Gerrit-Reviewer: David Ostrovsky 
Gerrit-Reviewer: Matúš Kukan 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Tor Lillqvist 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: config_host.mk.in configure.ac cross_toolset/Makefile epm/ExternalProject_epm.mk fontconfig/ExternalProject_fontconfig.mk freetype/ExternalProject_freetype.mk hunspell/Externa

[Libreoffice Gerrit user]

 Makefile.top |   36 +++
 config_host.mk.in|4 
 configure.ac |  145 +++
 cross_toolset/Makefile   |2 
 epm/ExternalProject_epm.mk   |2 
 fontconfig/ExternalProject_fontconfig.mk |2 
 freetype/ExternalProject_freetype.mk |2 
 hunspell/ExternalProject_hunspell.mk |2 
 lcms2/makefile.mk|2 
 libcdr/ExternalProject_libcdr.mk |2 
 liborcus/ExternalProject_liborcus.mk |2 
 librsvg/ExternalProject_librsvg.mk   |2 
 libwpd/ExternalProject_libwpd.mk |2 
 mythes/ExternalProject_mythes.mk |2 
 openldap/ExternalProject_openldap.mk |2 
 postgresql/ExternalProject_postgresql.mk |7 -
 solenv/bin/build.pl  |3 
 solenv/bin/callcatcher.Makefile  |4 
 18 files changed, 90 insertions(+), 133 deletions(-)

New commits:
commit ed0b160041c46d74c81ba849f1f841eb5bdaba1c
Author: Matúš Kukan 
Date:   Sat Oct 27 19:05:33 2012 +0200

fix parallelism variables and let's have only --with-parallelism from now on

Rationale:
- it is advised to use max-jobs and num-cpus with the same value in wiki
- max-jobs was used only for lcms2 and few gbuild
  modules outside of tail_build anyway.

Also fixes:
- really use CHECK_PARALLELISM when meant to
- EXTMAXPROCESS is not defined in gbuild;
  use parent's jobservers in sub-make where possible

Change-Id: I501de732d223ce0c935081bd1d73da611d16ee88
Reviewed-on: https://gerrit.libreoffice.org/930
Reviewed-by: Christian Lohmaier 
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/Makefile.top b/Makefile.top
index 715a7a8..47df97a 100644
--- a/Makefile.top
+++ b/Makefile.top
@@ -255,7 +255,7 @@ define gbuild_module_rules
 .PHONY: $(1) $(1).all $(1).build $(1).check $(1).clean $(1).subsequentcheck 
$(1).deliver
 
 $(1): bootstrap fetch
-   cd $(1) && $(GNUMAKE) -j $(GMAKE_PARALLELISM) $(GMAKE_OPTIONS) 
gb_PARTIALBUILD=T
+   cd $(1) && $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) 
gb_PARTIALBUILD=T
 
 $(1).all: bootstrap fetch
$$(if $$(filter $(1),$$(shell $(GNUMAKE) -r -f 
$(SRCDIR)/tail_build/Makefile showmodules)), \
@@ -264,16 +264,16 @@ $(1).all: bootstrap fetch
, \
cd $(1) && unset MAKEFLAGS && \
) \
-   $(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) --all -- 
-P$(GMAKE_PARALLELISM)
+   $(SOLARENV)/bin/build.pl -P$(PARALLELISM) --all -- -P$(PARALLELISM)
 
 $(1).build:
-   cd $(1) && $(GNUMAKE) -j $(CHECK_PARALLELISM) $(GMAKE_OPTIONS) build 
gb_PARTIALBUILD=T
+   cd $(1) && $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) build 
gb_PARTIALBUILD=T
 
 $(1).check:
-   cd $(1) && $(GNUMAKE) -j $(CHECK_PARALLELISM) $(GMAKE_OPTIONS) check 
gb_PARTIALBUILD=T
+   cd $(1) && $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) check 
gb_PARTIALBUILD=T
 
 $(1).clean:
-   cd $(1) && $(GNUMAKE) -j $(GMAKE_PARALLELISM) $(GMAKE_OPTIONS) clean 
gb_PARTIALBUILD=T
+   cd $(1) && $(GNUMAKE) -j $(PARALLELISM) $(GMAKE_OPTIONS) clean 
gb_PARTIALBUILD=T
 
 $(1).subsequentcheck:
cd $(1) && $(GNUMAKE) -j $(CHECK_PARALLELISM) $(GMAKE_OPTIONS) 
subsequentcheck gb_PARTIALBUILD=T
@@ -292,11 +292,11 @@ define dmake_module_rules
 
 $(1): bootstrap fetch
cd $(1) && unset MAKEFLAGS && \
-$(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) -- -P$(GMAKE_PARALLELISM)
+$(SOLARENV)/bin/build.pl -P$(PARALLELISM) -- -P$(PARALLELISM)
 
 $(1).all: bootstrap fetch
cd $(1) && unset MAKEFLAGS && \
-$(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) --all -- 
-P$(GMAKE_PARALLELISM)
+$(SOLARENV)/bin/build.pl -P$(PARALLELISM) --all -- -P$(PARALLELISM)
 
 $(1).deliver: $(1)
cd $(1) && $(SOLARENV)/bin/deliver.pl
@@ -333,7 +333,7 @@ clean: clean-host clean-build
 
 clean-host:
 ifeq ($(BUILD_DMAKE),YES)
-   if [ -f dmake/Makefile ] ; then $(GNUMAKE) -j $(GMAKE_PARALLELISM) -C 
dmake clean; fi
+   if [ -f dmake/Makefile ] ; then $(GNUMAKE) -j $(PARALLELISM) -C dmake 
clean; fi
 endif
rm -fr $(DEVINSTALLDIR)
rm -fr $(OUTDIR)
@@ -355,7 +355,7 @@ include $(SRCDIR)/compilerplugins/Makefile.mk
 #
 distclean : clean compilerplugins-clean
 ifeq ($(BUILD_DMAKE),YES)
-   (if [ -f dmake/Makefile ] ; then $(GNUMAKE) -j $(GMAKE_PARALLELISM) -C 
dmake distclean; fi) && \
+   (if [ -f dmake/Makefile ] ; then $(GNUMAKE) -j $(PARALLELISM) -C dmake 
distclean; fi) && \
rm -f solenv/*/bin/dmake*
 endif
rm -fr config_host.mk config_build.mk aclocal.m4 autom4te.cache \
@@ -413,25 +413,25 @@ ifeq ($(DISABLE_DBCONNECTIVITY),TRUE)
cd connectivity && sed -e 's/^\(export [A-Z0-9_]*=\)\(.*\)$$/\1"\2"/' 
<../config_host.mk >conftmp.sh && . conftmp.sh && rm conftmp.sh && 
$(SOLARENV)/bin/deliver.pl
 endif
cd packimages && unse

[Libreoffice-commits] .: svtools/inc svtools/source

[Libreoffice Gerrit user]

 svtools/inc/svtools/treelist.hxx   |2 --
 svtools/source/contnr/treelist.cxx |   35 +--
 2 files changed, 1 insertion(+), 36 deletions(-)

New commits:
commit 036f86db553494c781f58cbb5cbb567774217ec4
Author: Kohei Yoshida 
Date:   Tue Oct 30 16:32:33 2012 -0400

Apparently CheckIntegrity() was only declared but never defined.

Let's remove it.

Change-Id: Idbc6c58fb6ce71c80534396111c4d5b17a9764c7

diff --git a/svtools/inc/svtools/treelist.hxx b/svtools/inc/svtools/treelist.hxx
index b971a64..9b96506 100644
--- a/svtools/inc/svtools/treelist.hxx
+++ b/svtools/inc/svtools/treelist.hxx
@@ -297,8 +297,6 @@ public:
 voidSetCompareHdl( const Link& rLink ) { aCompareLink = 
rLink; }
 const Link& GetCompareHdl() const { return aCompareLink; }
 voidResort();
-
-voidCheckIntegrity() const;
 };
 
 class SVT_DLLPUBLIC SvListView
diff --git a/svtools/source/contnr/treelist.cxx 
b/svtools/source/contnr/treelist.cxx
index f3bf0bc..2ec20bd 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -322,10 +322,6 @@ sal_uLong SvTreeList::Move(SvTreeListEntry* 
pSrcEntry,SvTreeListEntry* pTargetPa
 if (!bSameParent)
 SetListPositions(rSrc);
 
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
-
 sal_uLong nRetVal = findEntryPosition(rDst, pSrcEntry);
 OSL_ENSURE(nRetVal == pSrcEntry->GetChildListPos(), "ListPos not valid");
 Broadcast( LISTACTION_MOVED,pSrcEntry,pTargetParent,nRetVal);
@@ -360,9 +356,6 @@ sal_uLong SvTreeList::Copy(SvTreeListEntry* 
pSrcEntry,SvTreeListEntry* pTargetPa
 
 SetListPositions(rDst); // correct list position in target list
 
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 Broadcast( LISTACTION_INSERTED_TREE, pClonedEntry );
 sal_uLong nRetVal = findEntryPosition(rDst, pClonedEntry);
 return nRetVal;
@@ -426,9 +419,6 @@ void SvTreeList::InsertTree(SvTreeListEntry* pSrcEntry,
 nEntryCount += GetChildCount( pSrcEntry );
 nEntryCount++; // the parent is new, too
 
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 Broadcast(LISTACTION_INSERTED_TREE, pSrcEntry );
 }
 
@@ -1100,9 +1090,6 @@ sal_uLong SvTreeList::Insert( SvTreeListEntry* 
pEntry,SvTreeListEntry* pParent,s
 else
 pEntry->nListPos = rList.size()-1;
 
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 Broadcast( LISTACTION_INSERTED, pEntry );
 return nPos; // pEntry->nListPos;
 }
@@ -1136,10 +1123,7 @@ void SvTreeList::SetAbsolutePositions()
 nPos++;
 pEntry = Next( pEntry );
 }
-bAbsPositionsValid = sal_True;
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
+bAbsPositionsValid = true;
 }
 
 
@@ -1166,9 +1150,6 @@ void SvTreeList::Expand( SvListView* pView, 
SvTreeListEntry* pEntry )
 pView->bVisPositionsValid = sal_False;
 pView->nVisibleCount = 0;
 }
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 }
 
 /*
@@ -1194,9 +1175,6 @@ void SvTreeList::Collapse( SvListView* pView, 
SvTreeListEntry* pEntry )
 pView->nVisibleCount = 0;
 pView->bVisPositionsValid = sal_False;
 }
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 }
 
 
@@ -1230,9 +1208,6 @@ sal_Bool SvTreeList::Select( SvListView* pView, 
SvTreeListEntry* pEntry, sal_Boo
 pView->nSelectionCount--;
 }
 }
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 return sal_True;
 }
 
@@ -1281,11 +1256,6 @@ bool SvTreeList::Remove( const SvTreeListEntry* pEntry )
 SetListPositions(rList);
 
 nEntryCount -= nRemoved;
-
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
-
 return true;
 }
 
@@ -1313,9 +1283,6 @@ void SvTreeList::SelectAll( SvListView* pView, sal_Bool 
bSelect )
 pView->nSelectionCount = nEntryCount;
 else
 pView->nSelectionCount = 0;
-#ifdef CHECK_INTEGRITY
-CheckIntegrity();
-#endif
 }
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: svtools/source

[Libreoffice Gerrit user]

 svtools/source/contnr/treelist.cxx |5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 9106fc3aa811002bf66b69951a754daccff98d67
Author: Kohei Yoshida 
Date:   Tue Oct 30 16:24:18 2012 -0400

Avoiding deleting the removed entry.

The tree list entries are now stored in ptr_vector. We no longer
have to manually call delete on it whenever it gets removed from the
list.

Change-Id: Id183aadbdc3b1565d1c702dc0fc099df9dcb6e2c

diff --git a/svtools/source/contnr/treelist.cxx 
b/svtools/source/contnr/treelist.cxx
index 1716e27..f3bf0bc 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1257,6 +1257,8 @@ bool SvTreeList::Remove( const SvTreeListEntry* pEntry )
 SvTreeListEntries& rList = pParent->maChildren;
 bool bLastEntry = false;
 
+Broadcast(LISTACTION_REMOVED, const_cast(pEntry));
+
 if ( pEntry->HasChildListPos() )
 {
 size_t nListPos = pEntry->GetChildListPos();
@@ -1273,7 +1275,6 @@ bool SvTreeList::Remove( const SvTreeListEntry* pEntry )
 rList.erase(it);
 }
 
-
 // moved to end of method because it is used later with Broadcast
 
 if (!rList.empty() && !bLastEntry)
@@ -1284,9 +1285,7 @@ bool SvTreeList::Remove( const SvTreeListEntry* pEntry )
 #ifdef CHECK_INTEGRITY
 CheckIntegrity();
 #endif
-Broadcast(LISTACTION_REMOVED, const_cast(pEntry));
 
-delete pEntry; // deletes any children as well
 return true;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/rb7' - vcl/win

[Libreoffice Gerrit user]

 vcl/win/source/gdi/salgdi_gdiplus.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit d0ea30f8ea40c0e0824d07d16cf64f51b481f8e4
Author: Andras Timar 
Date:   Tue Oct 30 21:10:57 2012 +0100

Use the flat GdiPlus API for LineCaps calls, too

Change-Id: I264df7f0e9f07aba2e37e887bb13ca6d7a1674f9

diff --git a/vcl/win/source/gdi/salgdi_gdiplus.cxx 
b/vcl/win/source/gdi/salgdi_gdiplus.cxx
index 54ee560..a6aa5ce 100644
--- a/vcl/win/source/gdi/salgdi_gdiplus.cxx
+++ b/vcl/win/source/gdi/salgdi_gdiplus.cxx
@@ -242,14 +242,14 @@ bool WinSalGraphics::drawPolyLine(
 }
 case com::sun::star::drawing::LineCap_ROUND:
 {
-aTestPen.SetStartCap(Gdiplus::LineCapRound);
-aTestPen.SetEndCap(Gdiplus::LineCapRound);
+Gdiplus::DllExports::GdipSetPenStartCap(pTestPen, 
Gdiplus::LineCapRound);
+Gdiplus::DllExports::GdipSetPenEndCap(pTestPen, 
Gdiplus::LineCapRound);
 break;
 }
 case com::sun::star::drawing::LineCap_SQUARE:
 {
-aTestPen.SetStartCap(Gdiplus::LineCapSquare);
-aTestPen.SetEndCap(Gdiplus::LineCapSquare);
+Gdiplus::DllExports::GdipSetPenStartCap(pTestPen, 
Gdiplus::LineCapSquare);
+Gdiplus::DllExports::GdipSetPenEndCap(pTestPen, 
Gdiplus::LineCapSquare);
 break;
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: source/text

[Libreoffice Gerrit user]

 source/text/swriter/01/0610.xhp |   72 ++--
 1 file changed, 36 insertions(+), 36 deletions(-)

New commits:
commit d8b9fe2b21d1a3e0fdd7ca0ce41b7c136d7fcf76
Author: Caolán McNamara 
Date:   Tue Oct 30 20:13:04 2012 +

typo sw->swriter

diff --git a/source/text/swriter/01/0610.xhp 
b/source/text/swriter/01/0610.xhp
index 4757281..e4279f9 100644
--- a/source/text/swriter/01/0610.xhp
+++ b/source/text/swriter/01/0610.xhp
@@ -47,7 +47,7 @@
 
 
 
-
+
 Sort
   Sorts 
the selected paragraphs or table rows alphabetically or numerically. 
You can define up to three sort keys as well as combine alphanumeric and 
numeric sort keys.
 
@@ -55,68 +55,68 @@
  
   
   Sort criteria
-
-
-
+
+
+
 Keys 1 to 3
-  Specifies additional 
sorting criteria. You can also combine sort keys.
-
-
-
+  Specifies additional 
sorting criteria. You can also combine sort keys.
+
+
+
 Column 1 to 3
-  Enter the 
number of the table column that you want to use as a basis for 
sorting.removed a para
-
-
-
+  Enter 
the number of the table column that you want to use as a basis for 
sorting.removed a para
+
+
+
 Key type 1 to 3
-  Select the sorting 
option that you want to use.
+  Select the 
sorting option that you want to use.
   Order
   Ascending
-
-
-
-Sorts in ascending order, 
(for example, 1, 2, 3 or a, b, c).
-
-
-
+
+
+
+Sorts in ascending 
order, (for example, 1, 2, 3 or a, b, c).
+
+
+
 Descending
-  Sorts in descending 
order (for example, 9, 8, 7 or z, y, x).
+  Sorts in 
descending order (for example, 9, 8, 7 or z, y, x).
   Direction
-
+
 Columns
-  Sorts the columns in 
the table according to the current sort options.
-
+  Sorts the 
columns in the table according to the current sort options.
+
 Rows
-  Sorts the rows in the 
table or the paragraphs in the selection according to the current sort 
options.
+  Sorts the rows in 
the table or the paragraphs in the selection according to the current sort 
options.
   Separator
   Paragraphs are separated by nonprinting paragraph marks. You can 
also specify that tabs or a character act as separators when you sort 
paragraphs.
-
+
 Tabs
-  If the selected 
paragraphs correspond to a list separated by tabs, select this 
option.
-
-
+  If the selected 
paragraphs correspond to a list separated by tabs, select this 
option.
+
+
 Character
-  Enter the character 
that you want to use as a separator in the selected area. By using the 
separator, $[officename] can determine the position of the sorting key in the 
selected paragraph.
-
+  Enter the 
character that you want to use as a separator in the selected area. By 
using the separator, $[officename] can determine the position of the sorting 
key in the selected paragraph.
+
 ...
-  Opens the 
Special Characters dialog, where you can select the character that 
you want to use as a separator.
-
+  Opens the 
Special Characters dialog, where you can select the character that 
you want to use as a separator.
+
 Language
-  Select the language 
that defines the sorting rules. Some languages sort special characters 
differently than other languages.
-
+  Select the 
language that defines the sorting rules. Some languages sort special 
characters differently than other languages.
+
 Match case
-  Distinguishes between uppercase and 
lowercase letters when you sort a table. For Asian languages special handling 
applies.
+  Distinguishes between uppercase 
and lowercase letters when you sort a table. For Asian languages special 
handling applies.
   For 
Asian languages, select Match case to apply multi-level collation. 
In the multi-level collation, the primitive forms of the entries are first 
compared with the cases of the forms and diacritics ignored. If the forms are 
the same, the diacritics of the forms are compared. If the forms are still the 
same, the cases, character widths, and Japanese Kana differences of the forms 
are compared.UFI: see #112590# and #112507#

 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: helpcontent2

[Libreoffice Gerrit user]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2f6dcb048c3acd60099ca316082e284fb69ef55d
Author: Caolán McNamara 
Date:   Tue Oct 30 20:13:04 2012 +

Updated core
Project: help  d8b9fe2b21d1a3e0fdd7ca0ce41b7c136d7fcf76
typo sw->swriter

diff --git a/helpcontent2 b/helpcontent2
index c532aed..d8b9fe2 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit c532aed5026dbdef6992b3aa1e2714de02781b4a
+Subproject commit d8b9fe2b21d1a3e0fdd7ca0ce41b7c136d7fcf76
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: want to contribute

[Khunshan Shabbir]

rizwan, you can contribute in localization, its own type of contribution.

On Wed, Oct 31, 2012 at 1:02 AM, Khunshan Shabbir
wrote:

> hey rizwan. are yo from pakistan?
>
> On Wed, Oct 31, 2012 at 12:53 AM, Rizwan Alam wrote:
>
>> Hi,
>> I want to contribute to libreoffice how ever i do not have experience. I
>> am a bit confused. I was thinking about doing testing can any one help me
>> out.
>>
>> thanking you
>> Rizwan Alam
>>
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>>
>
>
> --
> *
>   - Khunshan S. Ahmad*
>
>


-- 
*
- Khunshan S. Ahmad*
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Kohei Yoshida]

On 10/30/2012 03:42 PM, Lubos Lunak wrote:

On Tuesday 30 of October 2012, Kohei Yoshida wrote:

Hi there,

Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't
seem to turn on symbols.

Does this ring a bell to anyone?


  http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html


Thanks.  Obviously I missed that that change would eliminate 
ENABLE_SYMBOLS option altogether.


Anyway, sounds like not many people use this option, and I happened to 
be one of the few that use it (?)  So, I wrote a wrapper to make to 
revive this use case.  Here is the script:


---
#!/usr/bin/env bash

if [ "$1" == "-g" ]; then
echo "Enabling symbols..."
shift 1
make CXXFLAGS='$(call gb_LinkTarget__get_debugcxxflags,$(1)) -g' "$@"
exit 0
fi

make "$@"
---

I save it as lo-make and put it under ~/bin.  With this, running

lo-make -g -sr -j8

inside a module should just enable debug symbols, and nothing but symbols.

I hope others like me find that useful.

Best,

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: want to contribute

[Khunshan Shabbir]

hey rizwan. are yo from pakistan?

On Wed, Oct 31, 2012 at 12:53 AM, Rizwan Alam wrote:

> Hi,
> I want to contribute to libreoffice how ever i do not have experience. I
> am a bit confused. I was thinking about doing testing can any one help me
> out.
>
> thanking you
> Rizwan Alam
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>


-- 
*
- Khunshan S. Ahmad*
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

want to contribute

[Rizwan Alam]

Hi,
I want to contribute to libreoffice how ever i do not have experience. I am
a bit confused. I was thinking about doing testing can any one help me out.

thanking you
Rizwan Alam
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: ENABLE_SYMBOLS=true does nothing

[Lubos Lunak]

On Tuesday 30 of October 2012, Kohei Yoshida wrote:
> Hi there,
>
> Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't
> seem to turn on symbols.
>
> Does this ring a bell to anyone?

 http://lists.freedesktop.org/archives/libreoffice/2012-October/040051.html

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

ENABLE_SYMBOLS=true does nothing

[Kohei Yoshida]

Hi there,

Just noticed this today that, on master, the ENABLE_SYMBOLS=true doesn't 
seem to turn on symbols.


Does this ring a bell to anyone?

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - sc/qa

[Libreoffice Gerrit user]

 sc/qa/unit/ucalc.cxx |  165 ++-
 1 file changed, 149 insertions(+), 16 deletions(-)

New commits:
commit 1a8b6a61447f1ba7fa7dc626a7563fae57f856d1
Author: Kohei Yoshida 
Date:   Tue Oct 30 14:27:11 2012 -0400

Intentionally add a formula cell in column 1.

Column 1 only consisted of static values prior to this. Inserting a
formula cell will break the range-based formula sharing and dependency
tracking but it should still continue to work.

Change-Id: I5187ccf15ec1dffe4b6b10086f815b18c21e17c1

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 45d84ff..74c7205 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1199,6 +1199,13 @@ void Test::testFormulaDepTracking()
 CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", 
m_pDoc->GetValue(2, nRow, 0) == val*2.0);
 }
 
+// Intentionally insert a formula in column 1. This will break column 1's
+// uniformity of consisting only of static value cells.
+m_pDoc->SetString(0, 4, 0, "=R2C3");
+CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", m_pDoc->GetValue(0, 4, 
0) == 2.0);
+CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", m_pDoc->GetValue(1, 4, 
0) == 2.0);
+CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", m_pDoc->GetValue(2, 4, 
0) == 4.0);
+
 m_pDoc->DeleteTab(0);
 }
 
commit 08dee0ce8d5d49b3ff2e993bfa44cf49c0c643e0
Author: Kohei Yoshida 
Date:   Tue Oct 30 14:21:36 2012 -0400

Another test case for column formula arrays.

We will later handle this use case using shared formulas.

Change-Id: I6403ae4adddc865d0418290e1549a91ef4eeb318

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 890c6bf..45d84ff 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -334,6 +334,9 @@ ScRange insertRangeData(ScDocument* pDoc, const ScAddress& 
rPos, const char* aDa
 return aRange;
 }
 
+/**
+ * Temporarily switch on/off auto calculation mode.
+ */
 class AutoCalcSwitch
 {
 ScDocument* mpDoc;
@@ -350,6 +353,26 @@ public:
 }
 };
 
+/**
+ * Temporarily set formula grammar.
+ */
+class FormulaGrammarSwitch
+{
+ScDocument* mpDoc;
+formula::FormulaGrammar::Grammar meOldGrammar;
+public:
+FormulaGrammarSwitch(ScDocument* pDoc, formula::FormulaGrammar::Grammar 
eGrammar) :
+mpDoc(pDoc), meOldGrammar(pDoc->GetGrammar())
+{
+mpDoc->SetGrammar(eGrammar);
+}
+
+~FormulaGrammarSwitch()
+{
+mpDoc->SetGrammar(meOldGrammar);
+}
+};
+
 Test::Test()
 : m_pDoc(0)
 {
@@ -1147,6 +1170,35 @@ void Test::testFormulaDepTracking()
 m_pDoc->GetValue(1, 1, 0, val);
 CPPUNIT_ASSERT_MESSAGE("Failed to recalculate on single value change.", 
rtl::math::approxEqual(val, 12.0));
 
+clearRange(m_pDoc, ScRange(0, 0, 0, 10, 10, 0));
+
+// Now, column-based dependency tracking.  We now switch to the R1C1
+// syntax which is easier to use for repeated relative references.
+
+FormulaGrammarSwitch aFGSwitch(m_pDoc, 
formula::FormulaGrammar::GRAM_ENGLISH_XL_R1C1);
+
+val = 0.0;
+for (SCROW nRow = 1; nRow <= 9; ++nRow)
+{
+// Static value in column 1.
+m_pDoc->SetValue(0, nRow, 0, ++val);
+
+// Formula in column 2 that references cell to the left.
+m_pDoc->SetString(1, nRow, 0, "=RC[-1]");
+
+// Formula in column 3 that references cell to the left.
+m_pDoc->SetString(2, nRow, 0, "=RC[-1]*2");
+}
+
+// Check formula values.
+val = 0.0;
+for (SCROW nRow = 1; nRow <= 9; ++nRow)
+{
+++val;
+CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", 
m_pDoc->GetValue(1, nRow, 0) == val);
+CPPUNIT_ASSERT_MESSAGE("Unexpected formula value.", 
m_pDoc->GetValue(2, nRow, 0) == val*2.0);
+}
+
 m_pDoc->DeleteTab(0);
 }
 
commit 8cd13f7e04e920e3d6e1fddf88f61dac08894e06
Author: Kohei Yoshida 
Date:   Tue Oct 30 12:38:32 2012 -0400

New unit test for formula dependency tracking.

Change-Id: I5dad87cd67f8644509087394faa7c4880deb8ee6

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index a5e3a07..890c6bf 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -118,6 +118,7 @@ public:
  */
 void testSheetsFunc();
 void testVolatileFunc();
+void testFormulaDepTracking();
 void testFuncParam();
 void testNamedRange();
 void testCSV();
@@ -235,6 +236,7 @@ public:
 CPPUNIT_TEST(testCellFunctions);
 CPPUNIT_TEST(testSheetsFunc);
 CPPUNIT_TEST(testVolatileFunc);
+CPPUNIT_TEST(testFormulaDepTracking);
 CPPUNIT_TEST(testFuncParam);
 CPPUNIT_TEST(testNamedRange);
 CPPUNIT_TEST(testCSV);
@@ -332,6 +334,22 @@ ScRange insertRangeData(ScDocument* pDoc, const ScAddress& 
rPos, const char* aDa
 return aRange;
 }
 
+class AutoCalcSwitch
+{
+ScDocument* mpDoc;
+bool mbOldValue;
+public:
+AutoCalcSwitch(ScDocument* pDoc, bool bAutoCalc) : mpDoc(pDoc), 
mbOldValue(pDoc->G

[PATCH] unusedcode.easy cleanup

[Ricardo Montania (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/942

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/942/1

unusedcode.easy cleanup

Change-Id: Ia16a0571f253faa0364eec78bb29e4f13485a584
---
M vcl/inc/outfont.hxx
M vcl/source/gdi/outdev3.cxx
2 files changed, 0 insertions(+), 10 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/942
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia16a0571f253faa0364eec78bb29e4f13485a584
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] desktop: tweak xmlCleanupParser hack: disable on return from...

[Michael Stahl (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/941


--
To view, visit https://gerrit.libreoffice.org/941
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50d2e92e5078016943f71a62070743ab8d6628bb
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: desktop/source

[Libreoffice Gerrit user]

 desktop/source/app/main.c |   28 ++--
 1 file changed, 22 insertions(+), 6 deletions(-)

New commits:
commit 16e72215c96ee734e2cf6d15a465577d289a1549
Author: Michael Stahl 
Date:   Tue Oct 30 18:18:40 2012 +0100

desktop: tweak xmlCleanupParser hack: disable on return from main

Lubos has apparently a case of xmlCleanupParser run as an atexit
handler, from KDE's Strigi library; hopefully this should help
to avoid the abort then.

Change-Id: I50d2e92e5078016943f71a62070743ab8d6628bb

diff --git a/desktop/source/app/main.c b/desktop/source/app/main.c
index c18fabd..663c35e 100644
--- a/desktop/source/app/main.c
+++ b/desktop/source/app/main.c
@@ -21,22 +21,38 @@
 
 #include "sofficemain.h"
 
-SAL_IMPLEMENT_MAIN() {
-return soffice_main();
-}
-
 #ifdef DBG_UTIL
 #ifdef __gnu_linux__
 #include 
 #include 
 
+int g_Exiting = 0;
+
 /* HACK: detect calls to xmlCleanupParser, which causes hard to debug crashes 
*/
 __attribute__ ((visibility("default"))) void xmlCleanupParser(void)
 {
-fprintf(stderr, "\n*** ERROR: DO NOT call xmlCleanupParser()\n\n");
-abort();
+/* there are libraries that register xmlCleanupParser as an atexit handler,
+   which is not entirely sound (another atexit handler could want to
+   use libxml), but not enough of a problem to complain.
+   (example found by llunak: KDE's Strigi library) */
+if (!g_Exiting)
+{
+fprintf(stderr, "\n*** ERROR: DO NOT call xmlCleanupParser()\n\n");
+abort();
+}
 }
 #endif
 #endif
 
+SAL_IMPLEMENT_MAIN() {
+int ret = soffice_main();
+#ifdef DBG_UTIL
+#ifdef __gnu_linux__
+g_Exiting = 1;
+#endif
+#endif
+return ret;
+}
+
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] desktop: tweak xmlCleanupParser hack: disable atexit

[Michael Stahl (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/941

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/941/1

desktop: tweak xmlCleanupParser hack: disable atexit

Lubos has apparently a case of xmlCleanupParser run as an atexit
handler, hopefully this should help...

Change-Id: I50d2e92e5078016943f71a62070743ab8d6628bb
---
M desktop/source/app/main.c
1 file changed, 18 insertions(+), 6 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/941
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I50d2e92e5078016943f71a62070743ab8d6628bb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] detect even more memory mismanagement on glibc

[Lionel Elie Mamane (via Code Review)]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/940

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/40/940/1

detect even more memory mismanagement on glibc

Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
---
M solenv/bin/linkoo
1 file changed, 13 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/940
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idba21b12582e9ae7d240d9d3527f9ac5893252f7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Lionel Elie Mamane 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

--- Comment #160 from Joel Madero  ---
Nomiting: Bug 42899 - Macro changes not saved on document Close/Save

Huge problem for people who frequently use macros and save document as xls. I
have personally lost hours of work due to this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=6

Joel Madero  changed:

   What|Removed |Added

 Depends on||42899

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/qa

[Libreoffice Gerrit user]

 sw/qa/extras/ww8export/ww8export.cxx |   11 ---
 1 file changed, 8 insertions(+), 3 deletions(-)

New commits:
commit a7339737f4bab4daf0c5843e36e2988919e6691f
Author: Miklos Vajna 
Date:   Tue Oct 30 18:05:46 2012 +0100

sw: work around random crashes in ww8export

Change-Id: If11bff5804770976f069a49a1c508744d6e1987b

diff --git a/sw/qa/extras/ww8export/ww8export.cxx 
b/sw/qa/extras/ww8export/ww8export.cxx
index de2c80d..7a205f1 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -98,12 +98,17 @@ void Test::testN325936()
 
 void Test::testFdo45724()
 {
+// The text and background color of the control shape was not correct.
 uno::Reference xDrawPageSupplier(mxComponent, 
uno::UNO_QUERY);
 uno::Reference 
xDraws(xDrawPageSupplier->getDrawPage(), uno::UNO_QUERY);
 uno::Reference 
xControlShape(xDraws->getByIndex(0), uno::UNO_QUERY);
-uno::Reference 
xComponent(xControlShape->getControl(), uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(COL_WHITE, getProperty(xComponent, 
"BackgroundColor"));
-CPPUNIT_ASSERT_EQUAL(OUString("xxx"), 
xComponent->getCurrentValue().get());
+// This should not happen (the shape was there before the fix as well), 
but let's avoid a segfault in some random cases...
+if (xControlShape.is())
+{
+uno::Reference 
xComponent(xControlShape->getControl(), uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(COL_WHITE, getProperty(xComponent, 
"BackgroundColor"));
+CPPUNIT_ASSERT_EQUAL(OUString("xxx"), 
xComponent->getCurrentValue().get());
+}
 }
 
 void Test::testFdo46020()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] cppCheck: Remove some 'redundantAssignment'

[via Code Review]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/938

Approvals:
  Caolán McNamara: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/938
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4051db7599824cf407af9ec91ef8f6633467ea36
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Christophe JAILLET 
Gerrit-Reviewer: Caolán McNamara 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: chart2/source

[Libreoffice Gerrit user]

 chart2/source/view/charttypes/AreaChart.cxx|1 -
 chart2/source/view/charttypes/BarChart.cxx |2 --
 chart2/source/view/charttypes/BubbleChart.cxx  |2 --
 chart2/source/view/charttypes/CandleStickChart.cxx |1 -
 4 files changed, 6 deletions(-)

New commits:
commit 4ece397f21fdb97841a0d355e2d62d446e2c89ac
Author: jailletc36 
Date:   Tue Oct 30 05:09:28 2012 +0100

cppCheck: Remove some 'redundantAssignment'

These iterators are already assigned with the same value a few lines above.

Change-Id: I4051db7599824cf407af9ec91ef8f6633467ea36
Signed-off-by: jailletc36 
Reviewed-on: https://gerrit.libreoffice.org/938
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/chart2/source/view/charttypes/AreaChart.cxx 
b/chart2/source/view/charttypes/AreaChart.cxx
index b088d72..fa0ec3d 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -660,7 +660,6 @@ void AreaChart::createShapes()
 
 //for the area chart there should be at most one x slot (no side 
by side stacking available)
 //attention different: xSlots are always interpreted as 
independent areas one behind the other: @todo this doesn't work why not???
-aXSlotIter = aZSlotIter->begin();
 for( sal_Int32 nX=0; aXSlotIter != aXSlotEnd; ++aXSlotIter, ++nX )
 {
 std::vector& rSeriesList = 
aXSlotIter->m_aSeriesVector;
diff --git a/chart2/source/view/charttypes/BarChart.cxx 
b/chart2/source/view/charttypes/BarChart.cxx
index 37b23ca..5058bc6 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -553,7 +553,6 @@ void BarChart::createShapes()
 
 ::std::vector< VDataSeries* >::const_iterator   
aSeriesIter = pSeriesList->begin();
 const ::std::vector< VDataSeries* >::const_iterator aSeriesEnd 
 = pSeriesList->end();
-aSeriesIter = pSeriesList->begin();
 
//=
 //iterate through all series in this x slot
 for( ; aSeriesIter != aSeriesEnd; ++aSeriesIter )
@@ -882,7 +881,6 @@ void BarChart::createShapes()
 
 ::std::vector< VDataSeries* >::const_iterator   
aSeriesIter = pSeriesList->begin();
 const ::std::vector< VDataSeries* >::const_iterator aSeriesEnd 
 = pSeriesList->end();
-aSeriesIter = pSeriesList->begin();
 //=
 //iterate through all series in this x slot
 for( ; aSeriesIter != aSeriesEnd; ++aSeriesIter )
diff --git a/chart2/source/view/charttypes/BubbleChart.cxx 
b/chart2/source/view/charttypes/BubbleChart.cxx
index ad84a15..9177bab 100644
--- a/chart2/source/view/charttypes/BubbleChart.cxx
+++ b/chart2/source/view/charttypes/BubbleChart.cxx
@@ -238,13 +238,11 @@ void BubbleChart::createShapes()
 ::std::vector< ::std::vector< VDataSeriesGroup > >::iterator   
  aZSlotIter = m_aZSlots.begin();
 const ::std::vector< ::std::vector< VDataSeriesGroup > 
>::const_iterator  aZSlotEnd = m_aZSlots.end();
 
-aZSlotIter = m_aZSlots.begin();
 for( sal_Int32 nZ=1; aZSlotIter != aZSlotEnd; ++aZSlotIter, nZ++ )
 {
 ::std::vector< VDataSeriesGroup >::iterator aXSlotIter 
= aZSlotIter->begin();
 const ::std::vector< VDataSeriesGroup >::const_iterator aXSlotEnd 
= aZSlotIter->end();
 
-aXSlotIter = aZSlotIter->begin();
 for( sal_Int32 nX=0; aXSlotIter != aXSlotEnd; ++aXSlotIter, ++nX )
 {
 ::std::vector< VDataSeries* >* pSeriesList = 
&(aXSlotIter->m_aSeriesVector);
diff --git a/chart2/source/view/charttypes/CandleStickChart.cxx 
b/chart2/source/view/charttypes/CandleStickChart.cxx
index 7fa8a47..5a9787f 100644
--- a/chart2/source/view/charttypes/CandleStickChart.cxx
+++ b/chart2/source/view/charttypes/CandleStickChart.cxx
@@ -187,7 +187,6 @@ void CandleStickChart::createShapes()
 
 ::std::vector< VDataSeries* >::const_iterator   
aSeriesIter = pSeriesList->begin();
 const ::std::vector< VDataSeries* >::const_iterator aSeriesEnd 
 = pSeriesList->end();
-aSeriesIter = pSeriesList->begin();
 
//=
 //iterate through all series in this x slot
 for( ; aSeriesIter != aSeriesEnd; ++aSeriesIter )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - sw/qa writerfilter/source

[Libreoffice Gerrit user]

 sw/qa/extras/rtfimport/data/fdo56512.rtf   |5 +
 sw/qa/extras/rtfimport/rtfimport.cxx   |   11 +++
 writerfilter/source/rtftok/rtfdocumentimpl.cxx |6 +-
 3 files changed, 21 insertions(+), 1 deletion(-)

New commits:
commit 2f6097e677dbb7e5387599f3bed4aa2d40755c88
Author: Miklos Vajna 
Date:   Tue Oct 30 17:39:31 2012 +0100

fdo#56512 testcase

Change-Id: Ib075209a2b61041ed40685093bc277243a0bef04

diff --git a/sw/qa/extras/rtfimport/data/fdo56512.rtf 
b/sw/qa/extras/rtfimport/data/fdo56512.rtf
new file mode 100644
index 000..bc400cf
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo56512.rtf
@@ -0,0 +1,5 @@
+{\rtf1\ansi\ansicpg1255
+{\*\do\dobxpage\dobypara\dodhgt8192\dptxbx\dptxbxmar0
+{\dptxbxtext\ltrpar\f0\fs20\cf1\vertalc\qr\rtlch òåñ÷ îåøùä \par}
+\dpx929\dpy1700\dpxsize10556\dpysize221\dplinehollow0}
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index ba09889..4da71c6 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -121,6 +121,7 @@ public:
 void testDplinehollow();
 void testLeftmarginDefault();
 void testDppolyline();
+void testFdo56512();
 
 CPPUNIT_TEST_SUITE(Test);
 #if !defined(MACOSX) && !defined(WNT)
@@ -193,6 +194,7 @@ void Test::run()
 {"dplinehollow.rtf", &Test::testDplinehollow},
 {"leftmargin-default.rtf", &Test::testLeftmarginDefault},
 {"dppolyline.rtf", &Test::testDppolyline},
+{"fdo56512.rtf", &Test::testFdo56512},
 };
 for (unsigned int i = 0; i < SAL_N_ELEMENTS(aMethods); ++i)
 {
@@ -884,6 +886,15 @@ void Test::testDppolyline()
 CPPUNIT_ASSERT_EQUAL(sal_Int32(4), xDraws->getCount());
 }
 
+void Test::testFdo56512()
+{
+uno::Reference xTextFramesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xIndexAccess(xTextFramesSupplier->getTextFrames(), uno::UNO_QUERY);
+uno::Reference xTextRange(xIndexAccess->getByIndex(0), 
uno::UNO_QUERY);
+OUString aExpected("עוסק מורשה ", 20, RTL_TEXTENCODING_UTF8);
+CPPUNIT_ASSERT_EQUAL(aExpected, xTextRange->getString());
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
commit b99b91763f96dcd5ff24c2d4cd9233a493b58aa0
Author: Miklos Vajna 
Date:   Tue Oct 30 16:41:24 2012 +0100

fdo#56512 fix RTF import of non-unicode Hebrew text

The trick here is that we can't just fall back to Hebrew encoding for
the whole document, as that would mirror shapes as well. Instead, check
where \rtlch is used, and there fall back to the default encoding.

Change-Id: Iaf155912fab6a559ed165870b8524c23cabcb86d

diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx 
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index f350a7f..2333f52 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -2064,8 +2064,11 @@ int RTFDocumentImpl::dispatchFlag(RTFKeyword nKeyword)
 }
 break;
 case RTF_LTRCH:
+// dmapper does not support this.
+break;
 case RTF_RTLCH:
-// dmapper does not support these.
+if (m_aDefaultState.nCurrentEncoding == RTL_TEXTENCODING_MS_1255)
+m_aStates.top().nCurrentEncoding = 
m_aDefaultState.nCurrentEncoding;
 break;
 case RTF_ULNONE:
 {
@@ -2587,6 +2590,7 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, 
int nParam)
 }
 break;
 case RTF_ANSICPG:
+m_aDefaultState.nCurrentEncoding = 
rtl_getTextEncodingFromWindowsCodePage(nParam);
 m_aStates.top().nCurrentEncoding = 
rtl_getTextEncodingFromWindowsCodePage(nParam);
 break;
 case RTF_CPG:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] Bug 51309 - Names of DatabaseRanges should not be case sensitive

[Kohei Yoshida]

Hi Mathieu,

On 10/30/2012 12:06 PM, Mathieu D. wrote:

HI,

You will find the patch with the correct license statement attached.


Looks like we are having a mis-communication here.

What we need from you is another email sent to this list, with the body 
of the message containing your license statement which can be just as 
follows:


All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+ dual license.

You keep including the license statement in the commit message of your 
patch, which is NOT what we need.  We need it in the body of an email.


I hope this clarifies our requirement. Sorry about the confusion, and 
thanks for the patch. :-)


Best,

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: svtools/source

[Libreoffice Gerrit user]

 svtools/source/contnr/treelist.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b72fca4ec4ad00786192bad68eba245cdeb6a692
Author: Miklos Vajna 
Date:   Tue Oct 30 17:24:59 2012 +0100

SvTreeList::GetEntry: detect an out-of-bound and return NULL in that case

That's how this worked prior to stlification.

Change-Id: I4b1a9735c92efc181a2d1f47cafb04d2855fdfe2

diff --git a/svtools/source/contnr/treelist.cxx 
b/svtools/source/contnr/treelist.cxx
index 895ef97..1716e27 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1862,7 +1862,7 @@ SvTreeListEntry* SvTreeList::GetEntry( SvTreeListEntry* 
pParent, sal_uLong nPos
 SvTreeListEntry* SvTreeList::GetEntry( sal_uLong nRootPos ) const
 {
 SvTreeListEntry* pRet = 0;
-if ( nEntryCount )
+if ( nEntryCount && nRootPos < pRootItem->maChildren.size())
 pRet = &pRootItem->maChildren[nRootPos];
 return pRet;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: desktop/source

[Libreoffice Gerrit user]

 desktop/source/deployment/gui/dp_gui_service.cxx |   11 ++
 desktop/source/deployment/inc/dp_misc.h  |8 
 desktop/source/deployment/misc/dp_misc.cxx   |   22 +
 desktop/source/pkgchk/unopkg/unopkg_app.cxx  |   37 ++-
 desktop/source/pkgchk/unopkg/unopkg_misc.cxx |   12 +--
 desktop/source/pkgchk/unopkg/unopkg_shared.h |   22 -
 6 files changed, 49 insertions(+), 63 deletions(-)

New commits:
commit 37cc83e594fa8ca131fc5fb98506287b7daedffd
Author: Stephan Bergmann 
Date:   Tue Oct 30 17:11:59 2012 +0100

In "unopkg gui" dispose component context from DeInitVCL

...the same way it is done in soffice.bin.  framework's Desktop::dispose()
requires the solar mutex to be still alive, which is destroyed in 
DeInitVCL, so
if the component context/service manager is only disposed afterwards, the 
solar
mutex is already gone.

This required moving disposeBridges() around, but it allowed to get rid of
DisposeGuard.

Change-Id: Ibec3d19040fdae23f492cd1e29084e673403e00b

diff --git a/desktop/source/deployment/gui/dp_gui_service.cxx 
b/desktop/source/deployment/gui/dp_gui_service.cxx
index 71c6ccd..7c83aab 100644
--- a/desktop/source/deployment/gui/dp_gui_service.cxx
+++ b/desktop/source/deployment/gui/dp_gui_service.cxx
@@ -33,6 +33,7 @@
 #include "cppuhelper/implbase2.hxx"
 #include "cppuhelper/implementationentry.hxx"
 #include "unotools/configmgr.hxx"
+#include "comphelper/processfactory.hxx"
 #include "comphelper/servicedecl.hxx"
 #include "comphelper/unwrapargs.hxx"
 #include 
@@ -66,6 +67,7 @@ public:
 
 // Application
 virtual int Main();
+virtual void DeInit();
 };
 
 
//__
@@ -84,6 +86,15 @@ int MyApp::Main()
 return EXIT_SUCCESS;
 }
 
+void MyApp::DeInit()
+{
+css::uno::Reference< css::uno::XComponentContext > context(
+comphelper::getProcessComponentContext());
+dp_misc::disposeBridges(context);
+css::uno::Reference< css::lang::XComponent >(
+context, css::uno::UNO_QUERY_THROW)->dispose();
+comphelper::setProcessServiceFactory(0);
+}
 
 namespace
 {
diff --git a/desktop/source/deployment/inc/dp_misc.h 
b/desktop/source/deployment/inc/dp_misc.h
index 248b81f..cf17cb5 100644
--- a/desktop/source/deployment/inc/dp_misc.h
+++ b/desktop/source/deployment/inc/dp_misc.h
@@ -159,6 +159,14 @@ void syncRepositories(
 ::com::sun::star::uno::Reference<
 ::com::sun::star::ucb::XCommandEnvironment> const & xCmdEnv);
 
+/** workaround: for some reason the bridge threads which communicate with the
+uno.exe process are not released on time
+*/
+DESKTOP_DEPLOYMENTMISC_DLLPUBLIC
+void disposeBridges(
+com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >
+const & ctx);
+
 }
 
 #endif
diff --git a/desktop/source/deployment/misc/dp_misc.cxx 
b/desktop/source/deployment/misc/dp_misc.cxx
index 31cb38c..55d3724 100644
--- a/desktop/source/deployment/misc/dp_misc.cxx
+++ b/desktop/source/deployment/misc/dp_misc.cxx
@@ -41,6 +41,7 @@
 #include "osl/mutex.hxx"
 #include "com/sun/star/ucb/CommandAbortedException.hpp"
 #include "com/sun/star/task/XInteractionHandler.hpp"
+#include "com/sun/star/bridge/BridgeFactory.hpp"
 #include "com/sun/star/bridge/UnoUrlResolver.hpp"
 #include "com/sun/star/bridge/XUnoUrlResolver.hpp"
 #include "com/sun/star/deployment/ExtensionManager.hpp"
@@ -586,7 +587,28 @@ void syncRepositories(
  }
 }
 
+void disposeBridges(Reference const & ctx)
+{
+if (!ctx.is())
+return;
 
+Reference bridgeFac( 
css::bridge::BridgeFactory::create(ctx) );
+
+const Sequence< Reference >seqBridges = 
bridgeFac->getExistingBridges();
+for (sal_Int32 i = 0; i < seqBridges.getLength(); i++)
+{
+Reference comp(seqBridges[i], UNO_QUERY);
+if (comp.is())
+{
+try {
+comp->dispose();
+}
+catch ( const css::lang::DisposedException& )
+{
+}
+}
+}
+}
 
 }
 
diff --git a/desktop/source/pkgchk/unopkg/unopkg_app.cxx 
b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
index c3387f0..db3f658 100644
--- a/desktop/source/pkgchk/unopkg/unopkg_app.cxx
+++ b/desktop/source/pkgchk/unopkg/unopkg_app.cxx
@@ -48,11 +48,9 @@
 
 #include "com/sun/star/deployment/ui/PackageManagerDialog.hpp"
 #include "com/sun/star/ui/dialogs/XExecutableDialog.hpp"
-#include "com/sun/star/lang/DisposedException.hpp"
 #include "boost/scoped_array.hpp"
 #include "com/sun/star/ui/dialogs/XDialogClosedListener.hpp"
 #include "com/sun/star/bridge/BridgeFactory.hpp"
-#include "com/sun/star/bridge/XBridgeFactory.hpp"
 #include 
 #include 
 
@@ -190,36 +188,9 @@ Reference findPackage(
 
 } // anon namespace
 
-
-//workaround for some reason the bridge threads which communicate with the 
uno.exe
-//process are not releases on time
-void disposeBridges

Re: Tinderbox MacOSX failures

[Michael Stahl]

On 30/10/12 16:46, Lior Kaplan wrote:
> Hi,
> 
> log for /Volumes/TBRAM/core/tail_
> build/prj
> /Volumes/TBRAM/core/Module_tail_build.mk:27:
> /Volumes/TBRAM/core//dictionaries/Module_dictionaries.mk: No such
> file or directory
> Makefile:17: *** Corrupted module target stack! .  Stop.
> ERROR: error 512 occurred while making
> /Volumes/TBRAM/core/tail_build/prj
> 
> 
> I'm quite annoyed from these tinderbox failures (meaning the system does
> its job well), can someone take a look at the error ? The commits are
> piling up.

you are not the only one who is annoyed :)

the error is simply that the tinderbox has not been adapted to the
newfangled git submodules.

unfortunately the owner of that tinderbox is on vacation, and can't
access it until he returns, so we will probably have to live with the
spam a bit longer :(



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Tinderbox MacOSX failures

[Caolán McNamara]

On Tue, 2012-10-30 at 17:46 +0200, Lior Kaplan wrote:
> Hi,
> 
> log for /Volumes/TBRAM/core/tail_
> build/prj
> /Volumes/TBRAM/core/Module_tail_build.mk:27: 
> /Volumes/TBRAM/core//dictionaries/Module_dictionaries.mk: No such file or 
> directory
> Makefile:17: *** Corrupted module target stack! .  Stop.
> ERROR: error 512 occurred while
> making /Volumes/TBRAM/core/tail_build/prj
> 
> I'm quite annoyed from these tinderbox failures (meaning the system
> does its job well), can someone take a look at the error ? The commits
> are piling up.

My understanding is that Norbert needs to log in physically to fix that
tinderbox, so whenever he gets back to the US :-)

C.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Bug 51309 - Names of DatabaseRanges should not be case sensitive

[Mathieu D.]

HI,

You will find the patch with the correct license statement attached.

Regards,
Mat'

On 10/29/2012 07:22 PM, Markus Mohrhard wrote:

Hey Mathieu,

2012/10/26 Mathieu D.:

Hi,

I submitted a patch for the bug 51309 - Names of DatabaseRanges should not
be case sensitive :
https://bugs.freedesktop.org/show_bug.cgi?id=51309

You will the diff file attached and on the bug's page.
https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=51309&attachment=69115

Changes :

- ScDBData::less::operator() is modified to compare upper strings

- All the calls to NamedDBs::findByName() are now
NamedDBs::findByUpperName().

- In case of a call to findByUpperName by an argument, the function
ScGlobal::pCharClass->uppercase(aName) was used to ensure upper case.

- The definitions of FindByName() are deleted.



The patch looks good. Could you please create the patch with git
commit -a&&  git format-patch HEAD~1 so that it includes you correctly
as author.

And please could you send a licence statement like:

All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+
dual license.

to the Mailing so list so that we can keep track of it at
http://wiki.documentfoundation.org/Development/Developers

Thanks a lot for your great contribution. Are there any areas that
interest you? Are you interested in more calc hacking?

Regards,
Markus



--
Mathieu D.

>From 34f1ab3baaf4c7cccf96a00a16998828933fcb4c Mon Sep 17 00:00:00 2001
From: Mathieu D. 
Date: Tue, 30 Oct 2012 11:58:44 -0400
Subject: [PATCH] Patch for bug 51309, Names of DatabaseRanges should not be case-sensitive. All of my past and future contributions to LibreOffice may be licensed
under the MPL/LGPLv3+
dual license..
 case sensitive

---
 sc/inc/dbdata.hxx  |1 -
 sc/qa/unit/subsequent_filters-test.cxx |4 ++--
 sc/source/core/data/cell.cxx   |4 ++--
 sc/source/core/data/documen3.cxx   |2 +-
 sc/source/core/tool/dbdata.cxx |   20 +---
 sc/source/core/tool/rangeutl.cxx   |2 +-
 sc/source/ui/dbgui/dbnamdlg.cxx|4 ++--
 sc/source/ui/docshell/arealink.cxx |4 ++--
 sc/source/ui/docshell/dbdocfun.cxx |   12 ++--
 sc/source/ui/docshell/docsh4.cxx   |2 +-
 sc/source/ui/docshell/docsh5.cxx   |2 +-
 sc/source/ui/navipi/content.cxx|2 +-
 sc/source/ui/undo/undodat.cxx  |4 ++--
 sc/source/ui/unoobj/datauno.cxx|4 ++--
 sc/source/ui/view/dbfunc.cxx   |2 +-
 15 files changed, 25 insertions(+), 44 deletions(-)

diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index d607b4e..5f7133f 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -185,7 +185,6 @@ public:
 const_iterator begin() const;
 const_iterator end() const;
 ScDBData* findByIndex(sal_uInt16 nIndex);
-ScDBData* findByName(const ::rtl::OUString& rName);
 ScDBData* findByUpperName(const ::rtl::OUString& rName);
 bool insert(ScDBData* p);
 void erase(iterator itr);
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index 10db9ae..89e5d0b 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -948,11 +948,11 @@ void ScFiltersTest::testBugFixesODS()
 
 {
 // fdo#40426
-ScDBData* pDBData = pDoc->GetDBCollection()->getNamedDBs().findByName("DBRange1");
+ScDBData* pDBData = pDoc->GetDBCollection()->getNamedDBs().findByUpperName("DBRANGE1");
 CPPUNIT_ASSERT(pDBData);
 CPPUNIT_ASSERT(pDBData->HasHeader());
 // no header
-pDBData = pDoc->GetDBCollection()->getNamedDBs().findByName("DBRange2");
+pDBData = pDoc->GetDBCollection()->getNamedDBs().findByUpperName("DBRANGE2");
 CPPUNIT_ASSERT(pDBData);
 CPPUNIT_ASSERT(!pDBData->HasHeader());
 }
diff --git a/sc/source/core/data/cell.cxx b/sc/source/core/data/cell.cxx
index e27339e..4c0bd4b 100644
--- a/sc/source/core/data/cell.cxx
+++ b/sc/source/core/data/cell.cxx
@@ -203,7 +203,7 @@ void adjustDBRange(ScToken* pToken, ScDocument& rNewDoc, const ScDocument* pOldD
 ScDBData* pDBData = aOldNamedDBs.findByIndex(pToken->GetIndex());
 if (!pDBData)
 return; //invalid index
-rtl::OUString aDBName = pDBData->GetName();
+rtl::OUString aDBName = pDBData->GetUpperName();
 
 //search in new document
 ScDBCollection* pNewDBCollection = rNewDoc.GetDBCollection();
@@ -212,7 +212,7 @@ void adjustDBRange(ScToken* pToken, ScDocument& rNewDoc, const ScDocument* pOldD
 pNewDBCollection = new ScDBCollection(&rNewDoc);
 }
 ScDBCollection::NamedDBs& aNewNamedDBs = pNewDBCollection->getNamedDBs();
-ScDBData* pNewDBData = aNewNamedDBs.findByName(aDBName);
+ScDBData* pNewDBData = aNewNamedDBs.findByUpperName(aDBName);
 if (!pNewDBData)
 {
 pNewDBData = new ScDBData(*pDBData);
diff --git a/sc/source/core

[Libreoffice-commits] .: helpers/help_hid.lst source/text

[Libreoffice Gerrit user]

 helpers/help_hid.lst|   26 
 source/text/swriter/01/06080100.xhp |   56 ++--
 source/text/swriter/01/06080200.xhp |   34 ++---
 3 files changed, 45 insertions(+), 71 deletions(-)

New commits:
commit c532aed5026dbdef6992b3aa1e2714de02781b4a
Author: Caolán McNamara 
Date:   Tue Oct 30 15:56:57 2012 +

update endnote and footnote help ids for .ui format

diff --git a/helpers/help_hid.lst b/helpers/help_hid.lst
index 03fa69f..f3187d3 100644
--- a/helpers/help_hid.lst
+++ b/helpers/help_hid.lst
@@ -9158,10 +9158,6 @@ sw_Edit_TP_BUSINESS_DATA_ED_STREET,879233060,
 sw_Edit_TP_BUSINESS_DATA_ED_WWW,879233075,
 sw_Edit_TP_BUSINESS_DATA_ED_ZIP,879233062,
 sw_Edit_TP_DROPCAPS_EDT_TEXT,877824009,
-sw_Edit_TP_ENDNOTEOPTION_ED_CONT,881149993,
-sw_Edit_TP_ENDNOTEOPTION_ED_CONT_FROM,881149995,
-sw_Edit_TP_ENDNOTEOPTION_ED_PREFIX,881149998,
-sw_Edit_TP_ENDNOTEOPTION_ED_SUFFIX,88115,
 sw_Edit_TP_FLD_DB_ED_DBCONDITION,878708744,
 sw_Edit_TP_FLD_DB_ED_DBSETNUMBER,878708745,
 sw_Edit_TP_FLD_DOK_ED_DOKVALUE,878757943,
@@ -9176,10 +9172,6 @@ sw_Edit_TP_FLD_REF_ED_REFVALUE,878790746,
 sw_Edit_TP_FLD_VAR_ED_VARNAME,878741535,
 sw_Edit_TP_FLD_VAR_ED_VARSEPARATOR,878741546,
 sw_Edit_TP_FLD_VAR_ED_VARVALUE,878741537,
-sw_Edit_TP_FOOTNOTEOPTION_ED_CONT,881133609,
-sw_Edit_TP_FOOTNOTEOPTION_ED_CONT_FROM,881133611,
-sw_Edit_TP_FOOTNOTEOPTION_ED_PREFIX,881133614,
-sw_Edit_TP_FOOTNOTEOPTION_ED_SUFFIX,881133616,
 sw_Edit_TP_FORMAT_TABLE_ED_NAME,878217319,
 sw_Edit_TP_FRM_ADD_ED_ALT_NAME,878495857,
 sw_Edit_TP_FRM_ADD_ED_NAME,878495855,
@@ -9308,12 +9300,6 @@ sw_ListBox_TP_CONTENT_OPT_LB_HMETRIC,878399064,
 sw_ListBox_TP_CONTENT_OPT_LB_METRIC,878399003,
 sw_ListBox_TP_CONTENT_OPT_LB_VMETRIC,878399065,
 sw_ListBox_TP_DROPCAPS_BOX_TEMPLATE,877825547,
-sw_ListBox_TP_ENDNOTEOPTION_LB_ANCHR_CHARFMT,881151541,
-sw_ListBox_TP_ENDNOTEOPTION_LB_NUMCOUNT,881151499,
-sw_ListBox_TP_ENDNOTEOPTION_LB_NUMVIEW,881151498,
-sw_ListBox_TP_ENDNOTEOPTION_LB_PAGE_TEMPL,881151519,
-sw_ListBox_TP_ENDNOTEOPTION_LB_PARA_TEMPL,881151518,
-sw_ListBox_TP_ENDNOTEOPTION_LB_TEXT_CHARFMT,881151538,
 sw_ListBox_TP_ENV_ENV_LB_DATABASE,909643268,
 sw_ListBox_TP_ENV_ENV_LB_DBFIELD,909643273,
 sw_ListBox_TP_ENV_ENV_LB_TABLE,909643270,
@@ -9339,12 +9325,6 @@ sw_ListBox_TP_FLD_VAR_LB_VARFORMAT,878743076,
 sw_ListBox_TP_FLD_VAR_LB_VARNUMFORMAT,878743075,
 sw_ListBox_TP_FLD_VAR_LB_VARSELECTION,878743069,
 sw_ListBox_TP_FLD_VAR_LB_VARTYPE,878743067,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_ANCHR_CHARFMT,881135157,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_NUMCOUNT,881135115,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_NUMVIEW,881135114,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_PAGE_TEMPL,881135135,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_PARA_TEMPL,881135134,
-sw_ListBox_TP_FOOTNOTEOPTION_LB_TEXT_CHARFMT,881135154,
 sw_ListBox_TP_FOOTNOTE_PAGE_DLB_LINEPOS,877956631,
 sw_ListBox_TP_FOOTNOTE_PAGE_DLB_LINETYPE,877956629,
 sw_ListBox_TP_FORMAT_TABLE_LB_TEXTORIENTATION,878218796,
@@ -9526,10 +9506,8 @@ sw_NumericField_DLG_PAGEPREVIEW_ZOOM_ED_ROW,1411274757,
 sw_NumericField_TP_COLUMN_ED_NUMBER,877877250,
 sw_NumericField_TP_DROPCAPS_FLD_DROPCAPS,877828098,
 sw_NumericField_TP_DROPCAPS_FLD_LINES,877828100,
-sw_NumericField_TP_ENDNOTEOPTION_FLD_OFFSET,881154060,
 sw_NumericField_TP_FLD_DOK_ED_DOKDATEOFF,878762041,
 sw_NumericField_TP_FLD_DOK_ED_DOKLEVEL,878762040,
-sw_NumericField_TP_FOOTNOTEOPTION_FLD_OFFSET,881137676,
 sw_NumericField_TP_LAB_FMT_FLD_COLUMNS,909711375,
 sw_NumericField_TP_LAB_FMT_FLD_ROWS,909711377,
 sw_NumericField_TP_LAB_PRT_FLD_COL,909727749,
@@ -9714,14 +9692,10 @@ 
sw_RadioButton_DLG_MM_SERVERAUTHENTICATION_RB_SEP_AUTHENTICATION,1427145267,
 sw_RadioButton_DLG_MM_SERVERAUTHENTICATION_RB_SMPTAFTERPOP,1427145268,
 sw_RadioButton_DLG_PAGEPREVIEW_PRINTOPTIONS_RB_LANDSCAPE,1411285528,
 sw_RadioButton_DLG_PAGEPREVIEW_PRINTOPTIONS_RB_PORTRAIT,1411285529,
-sw_RadioButton_TP_ENDNOTEOPTION_RB_POS_CHAPTER,881148418,
-sw_RadioButton_TP_ENDNOTEOPTION_RB_POS_PAGE,881148417,
 sw_RadioButton_TP_ENV_PRT_BTN_BOTTOM,909672968,
 sw_RadioButton_TP_ENV_PRT_BTN_TOP,909672967,
 sw_RadioButton_TP_FLD_DB_RB_DBFORMAT,878707212,
 sw_RadioButton_TP_FLD_DB_RB_DBOWNFORMAT,878707213,
-sw_RadioButton_TP_FOOTNOTEOPTION_RB_POS_CHAPTER,881132034,
-sw_RadioButton_TP_FOOTNOTEOPTION_RB_POS_PAGE,881132033,
 sw_RadioButton_TP_FOOTNOTE_PAGE_RB_MAXHEIGHT,877953538,
 sw_RadioButton_TP_FOOTNOTE_PAGE_RB_MAXHEIGHT_PAGE,877953537,
 sw_RadioButton_TP_FORMAT_TABLE_RB_CENTER,878215692,
diff --git a/source/text/swriter/01/06080100.xhp 
b/source/text/swriter/01/06080100.xhp
index 9859578..8e402cb 100644
--- a/source/text/swriter/01/06080100.xhp
+++ b/source/text/swriter/01/06080100.xhp
@@ -41,19 +41,19 @@
 
 
 
-
+
 Footnotes
-Specifies the formatting for 
footnotes and endnotes.
+Specifies 
the formatting for footnotes and endnotes.
 
 
   
 
 To set additional option for footnotes and endnotes, choose 
Format - Page, and then click the Footnote tab.
 AutoNumbering
-

[Libreoffice-commits] .: helpcontent2

[Libreoffice Gerrit user]

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 25db3f9d3605fd1ab5b8dee86d2d13b6cb80c9b1
Author: Caolán McNamara 
Date:   Tue Oct 30 15:56:57 2012 +

Updated core
Project: help  c532aed5026dbdef6992b3aa1e2714de02781b4a
update endnote and footnote help ids for .ui format

diff --git a/helpcontent2 b/helpcontent2
index 23d7515..c532aed 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 23d7515757534fca7d50e1201745586adde4b8f6
+Subproject commit c532aed5026dbdef6992b3aa1e2714de02781b4a
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/unitymenus-quantal' - 5 commits - vcl/inc vcl/Library_vclplug_gtk3.mk vcl/Library_vclplug_gtk.mk vcl/unx

[Libreoffice Gerrit user]

 vcl/Library_vclplug_gtk.mk   |1 
 vcl/Library_vclplug_gtk3.mk  |1 
 vcl/inc/unx/gtk/gtkframe.hxx |1 
 vcl/inc/unx/gtk/hudawareness.h   |   45 +++
 vcl/unx/gtk/window/gtkframe.cxx  |   28 +-
 vcl/unx/gtk/window/gtksalmenu.cxx|   51 +---
 vcl/unx/gtk/window/hudawareness.cxx  |  126 +++
 vcl/unx/gtk3/window/gtk3hudawareness.cxx |1 
 8 files changed, 222 insertions(+), 32 deletions(-)

New commits:
commit 6831d028d77ee073983c30db5b78afa720d7a428
Author: Antonio Fernandez 
Date:   Fri Oct 26 12:58:56 2012 +0100

Menu is fully updated when receiving a HUD activation event.

Change-Id: I4d275bc01ac0baa265d22dcd849020e8f51fc447

diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index 124f149..a97b376 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -524,7 +524,14 @@ static void ObjectDestroyedNotify( gpointer data )
 
 static void hud_activated( gboolean hud_active, gpointer user_data )
 {
-printf("HUD active state: %d\n", hud_active);
+if ( hud_activated )
+{
+GtkSalFrame* pSalFrame = reinterpret_cast< GtkSalFrame* >( user_data );
+GtkSalMenu* pSalMenu = reinterpret_cast< GtkSalMenu* >( 
pSalFrame->GetMenu() );
+
+if ( pSalMenu )
+pSalMenu->UpdateFull();
+}
 }
 
 gboolean ensure_dbus_setup( gpointer data )
commit 8d8335176631f6fbf01692472cff5fbc32c80349
Author: Antonio Fernandez 
Date:   Wed Oct 24 17:36:59 2012 +0100

Menu is now subscribed to HUD awareness protocol events.

Change-Id: I0649ac50a93b3b6379642fac4d5d532d46251d72

diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 8c3f76e..a07cd94 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -226,7 +226,6 @@ class GtkSalFrame : public SalFrame
 friend void on_registrar_available (GDBusConnection*, const gchar*, const 
gchar*, gpointer);
 friend void on_registrar_unavailable (GDBusConnection*, const gchar*, 
gpointer);
 guint   m_nWatcherId;
-guint   m_nHudAwarenessId;
 
 void Init( SalFrame* pParent, sal_uLong nStyle );
 void Init( SystemParentData* pSysData );
@@ -313,6 +312,7 @@ public:
 
 guint   m_nMenuExportId;
 guint   m_nActionGroupExportId;
+guint   m_nHudAwarenessId;
 
 // dispatches an event, returns true if dispatched
 // and false else; if true was returned the event should
diff --git a/vcl/unx/gtk/window/gtkframe.cxx b/vcl/unx/gtk/window/gtkframe.cxx
index ebf1010..124f149 100644
--- a/vcl/unx/gtk/window/gtkframe.cxx
+++ b/vcl/unx/gtk/window/gtkframe.cxx
@@ -522,6 +522,11 @@ static void ObjectDestroyedNotify( gpointer data )
 }
 }
 
+static void hud_activated( gboolean hud_active, gpointer user_data )
+{
+printf("HUD active state: %d\n", hud_active);
+}
+
 gboolean ensure_dbus_setup( gpointer data )
 {
 GtkSalFrame* pSalFrame = reinterpret_cast< GtkSalFrame* >( data );
@@ -558,6 +563,7 @@ gboolean ensure_dbus_setup( gpointer data )
 SAL_INFO("vcl.unity", "exporting menu model at " << pMenuModel << " 
for window " << windowId);
 pSalFrame->m_nMenuExportId = g_dbus_connection_export_menu_model 
(pSessionBus, aDBusMenubarPath, pMenuModel, NULL);
 pSalFrame->m_nActionGroupExportId = 
g_dbus_connection_export_action_group( pSessionBus, aDBusPath, pActionGroup, 
NULL);
+pSalFrame->m_nHudAwarenessId = hud_awareness_register( pSessionBus, 
aDBusMenubarPath, hud_activated, pSalFrame, NULL, NULL );
 
 g_free( aDBusPath );
 g_free( aDBusWindowPath );
@@ -683,10 +689,12 @@ GtkSalFrame::~GtkSalFrame()
 
 if ( pSessionBus )
 {
-if(m_nMenuExportId)
-g_dbus_connection_unexport_menu_model(pSessionBus, 
m_nMenuExportId);
-if(m_nActionGroupExportId)
-g_dbus_connection_unexport_action_group(pSessionBus, 
m_nActionGroupExportId);
+if ( m_nHudAwarenessId )
+hud_awareness_unregister( pSessionBus, m_nHudAwarenessId );
+if ( m_nMenuExportId )
+g_dbus_connection_unexport_menu_model( pSessionBus, 
m_nMenuExportId );
+if ( m_nActionGroupExportId )
+g_dbus_connection_unexport_action_group( pSessionBus, 
m_nActionGroupExportId );
 }
 gtk_widget_destroy( m_pWindow );
 }
@@ -804,6 +812,9 @@ void GtkSalFrame::InitCommon()
 m_bSetFocusOnMap= false;
 m_pSalMenu  = NULL;
 m_nWatcherId= 0;
+m_nMenuExportId = 0;
+m_nActionGroupExportId = 0;
+m_nHudAwarenessId   = 0;
 
 gtk_widget_set_app_paintable( m_pWindow, TRUE );
 gtk_widget_set_double_buffered( m_pWin

[Libreoffice-commits] Changes to 'feature/rb7'

[Libreoffice Gerrit user]

New branch 'feature/rb7' available with the following commits:
commit 0fef02b35ae915ff550bc416b329a7b4dc2d6210
Author: Michael Meeks 
Date:   Tue Oct 9 12:22:23 2012 +0100

re-base on ALv2 code. Includes (at least) relevant parts of:

linecap: Reintegrating finished LineCap feature
Patch contributed by Regina Henschel
http://svn.apache.org/viewvc?view=revision&revision=1232507

Patches contributed by Sven Jacobi
impress212: #i81610# fixed animation export
http://svn.apache.org/viewvc?view=revision&revision=1167620
impress212: drawinglayer gbuild environment changes
http://svn.apache.org/viewvc?view=revision&revision=1167627
http://svn.apache.org/viewvc?view=revision&revision=1167628

Patches contributed by Armin Le Grand
Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement
http://svn.apache.org/viewvc?view=revision&revision=1220836
#118728# changed indentifying definitions for Svg file detection
http://svn.apache.org/viewvc?view=revision&revision=1229961
#118838# LineGeometry creation for complicated cases optimized to
create single Polygons
http://svn.apache.org/viewvc?view=revision&revision=1236232
#119176# corrected file type detection for SVG for svg files
without xml header
http://svn.apache.org/viewvc?view=revision&revision=1309445
#118728# Extended Svg file detection
http://svn.apache.org/viewvc?view=revision&revision=1230531
#118529# solve break converters and convert commands for OLEs and images
http://svn.apache.org/viewvc?view=revision&revision=1186168
svg: added WaE changes from branch svgreplacement to trunc
http://svn.apache.org/viewvc?view=revision&revision=1222974
svg: corrected missing member initialization
http://svn.apache.org/viewvc?view=revision&revision=1226134
fix for #118525#: Using primitives for chart sub-geometry visualisation
http://svn.apache.org/viewvc?view=revision&revision=1226879
#118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert
metafiles to bitmapEx ...
http://svn.apache.org/viewvc?view=revision&revision=1293316
fix for #118525#: removed no longer used variable maOriginalMapMode, one
more exception eliminated
http://svn.apache.org/viewvc?view=revision&revision=1227097
#16758# Added buffering to the VDev usages of the VclProcessor2D 
derivates...
http://svn.apache.org/viewvc?view=revision&revision=1229521
#116758# Secured VDev buffer device to Vcl deinit
http://svn.apache.org/viewvc?view=revision&revision=1230574
#116758# added remembering allocated VDevs for VDevBuffer to be able to 
also
delete these when vcl goes down; it should never happen, but You never 
know
http://svn.apache.org/viewvc?view=revision&revision=1230927
#118730# Changed SvgClipPathNode to use MaskPrimitive2D for primitive
representation instead of TransparencePrimitive2D
http://svn.apache.org/viewvc?view=revision&revision=1231198
#118822# secured 3D geometry creation (slices) by subdividing the 2D
source polyPolygon early
http://svn.apache.org/viewvc?view=revision&revision=1234749
#118829# enhanced Svg gradient quality, obstacles avoided
http://svn.apache.org/viewvc?view=revision&revision=1235361
#118834# Unified usage of TextBreakupHelper as single tooling class
for i18n text primitive breakup
http://svn.apache.org/viewvc?view=revision&revision=1236110
#118853# added square pixel size limit to conversion of
TransparencePrimitive2D to Metafile action
http://svn.apache.org/viewvc?view=revision&revision=1237656
#118824# coreccted mirroring and boundrect when the graphicmanager
is used for bitmap output
http://svn.apache.org/viewvc?view=revision&revision=1240097
#115092# Corrected VclProcessor2D::RenderPolygonStrokePrimitive2D for
various optimization scenarios
http://svn.apache.org/viewvc?view=revision&revision=1241434
#118783# Corrected errors in ID strings, corrected Svg line/fill export,
corrected polygon close state
http://svn.apache.org/viewvc?view=revision&revision=1232006
#118796# corrected null-pointer usage in SVG text exporter
http://svn.apache.org/viewvc?view=revision&revision=1240262
#118729# Use GraphicStreamUrl and GraphicUrl to allow multi image
import with linked graphics, too
http://svn.apache.org/viewvc?view=revision&revision=1229962
#118898# corrected error in GDIMetaFile::GetBoundRect in handling
MetaFloatTransparentAction
http://svn.apache.org/viewvc?view=revision&revision=1293349
#118855# Corrected handling of possibly created empty clipRegions
  

[Libreoffice-commits] .: libxmlsec/makefile.mk

[Libreoffice Gerrit user]

 libxmlsec/makefile.mk |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit d34c069e699faf6e81c514091f4c812ca1063abb
Author: Caolán McNamara 
Date:   Tue Oct 30 15:23:47 2012 +

make that mingw suffix patch mingw only

Change-Id: I5a8dc6ddc620bf4a4bdccfb17ffbf1155fa53987

diff --git a/libxmlsec/makefile.mk b/libxmlsec/makefile.mk
index ed86834..0945f2d 100644
--- a/libxmlsec/makefile.mk
+++ b/libxmlsec/makefile.mk
@@ -70,13 +70,16 @@ PATCH_FILES=\
xmlsec1-customkeymanage.patch \
xmlsec1-nssmangleciphers.patch \
xmlsec1-noverify.patch \
-   xmlsec1-mingw32.patch \
xmlsec1-mingw-keymgr-mscrypto.patch \
xmlsec1-vc10.patch \
xmlsec1-1.2.14_fix_extern_c.patch \
xmlsec1-android.patch \
xmlsec1-1.2.14-ansi.patch
 
+.IF "$(GUI)$(COM)"=="WNTGCC"
+   PATCH_FILES+=xmlsec1-mingw32.patch
+.ENDIF
+
 .IF "$(OS)$(CPU)"=="MACOSXP"
 PATCH_FILES+=xmlsec1-1.2.14_old_automake.patch
 
EXTRA_LINKFLAGS+=-Wl,-dylib_file,@executable_path/libnssutil3.dylib:$(SOLARLIBDIR)/libnssutil3.dylib
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - extras/ExternalPackage_extra_fonts.mk extras/Module_extras.mk extras/Package_extra_fonts.mk more_fonts/ExternalPackage_dejavu.mk more_fonts/ExternalPackage_gentium

[Libreoffice Gerrit user]

 extras/ExternalPackage_extra_fonts.mk   |  187 
 extras/Module_extras.mk |2 
 extras/Package_extra_fonts.mk   |  187 
 more_fonts/ExternalPackage_dejavu.mk|   38 
 more_fonts/ExternalPackage_gentium.mk   |   25 +++
 more_fonts/ExternalPackage_liberation.mk|   29 +++
 more_fonts/ExternalPackage_liberation_narrow.mk |   21 ++
 more_fonts/ExternalPackage_libertineg.mk|   27 +++
 more_fonts/Module_more_fonts.mk |   10 -
 more_fonts/Package_dejavu.mk|   38 
 more_fonts/Package_gentium.mk   |   25 ---
 more_fonts/Package_liberation.mk|   31 ---
 more_fonts/Package_liberation_narrow.mk |   21 --
 more_fonts/Package_libertineg.mk|   28 ---
 14 files changed, 333 insertions(+), 336 deletions(-)

New commits:
commit 41946925ee87808e31956ee2cf5a92c1e5d3613a
Author: Michael Stahl 
Date:   Tue Oct 30 14:26:00 2012 +0100

more_fonts: convert to ExternalPackage for incremental builds

Change-Id: Id24975e0bc9a28f6c66599c4b58c01471dd2d8ef

diff --git a/more_fonts/ExternalPackage_dejavu.mk 
b/more_fonts/ExternalPackage_dejavu.mk
new file mode 100644
index 000..c1209ec
--- /dev/null
+++ b/more_fonts/ExternalPackage_dejavu.mk
@@ -0,0 +1,38 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,font_dejavu_inc,font_dejavu))
+
+$(eval $(call gb_ExternalPackage_add_unpacked_files,font_dejavu_inc,pck,\
+   ttf/DejaVuSans-Bold.ttf \
+   ttf/DejaVuSans-BoldOblique.ttf \
+   ttf/DejaVuSans-ExtraLight.ttf \
+   ttf/DejaVuSans-Oblique.ttf \
+   ttf/DejaVuSans.ttf \
+   ttf/DejaVuSansCondensed-Bold.ttf \
+   ttf/DejaVuSansCondensed-BoldOblique.ttf \
+   ttf/DejaVuSansCondensed-Oblique.ttf \
+   ttf/DejaVuSansCondensed.ttf \
+   ttf/DejaVuSansMono-Bold.ttf \
+   ttf/DejaVuSansMono-BoldOblique.ttf \
+   ttf/DejaVuSansMono-Oblique.ttf \
+   ttf/DejaVuSansMono.ttf \
+   ttf/DejaVuSerif-Bold.ttf \
+   ttf/DejaVuSerif-BoldItalic.ttf \
+   ttf/DejaVuSerif-Italic.ttf \
+   ttf/DejaVuSerif.ttf \
+   ttf/DejaVuSerifCondensed-Bold.ttf \
+   ttf/DejaVuSerifCondensed-BoldItalic.ttf \
+   ttf/DejaVuSerifCondensed-Italic.ttf \
+   ttf/DejaVuSerifCondensed.ttf \
+))
+
+$(eval $(call 
gb_ExternalPackage_add_unpacked_file,font_dejavu_lic,pck/License_dejavu.txt,LICENSE))
+
+# vim: set noet sw=4 ts=4:
diff --git a/more_fonts/ExternalPackage_gentium.mk 
b/more_fonts/ExternalPackage_gentium.mk
new file mode 100644
index 000..3992d2b
--- /dev/null
+++ b/more_fonts/ExternalPackage_gentium.mk
@@ -0,0 +1,25 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_ExternalPackage_ExternalPackage,font_gentium_inc,font_gentium))
+
+$(eval $(call gb_ExternalPackage_add_unpacked_files,font_gentium_inc,pck,\
+   GenBasB.ttf \
+   GenBasBI.ttf \
+   GenBasI.ttf \
+   GenBasR.ttf \
+   GenBkBasB.ttf \
+   GenBkBasBI.ttf \
+   GenBkBasI.ttf \
+   GenBkBasR.ttf \
+))
+
+$(eval $(call 
gb_ExternalPackage_add_unpacked_file,font_gentium_inc,pck/License_gentium.txt,OFL.txt))
+
+# vim: set noet sw=4 ts=4:
diff --git a/more_fonts/ExternalPackage_liberation.mk 
b/more_fonts/ExternalPackage_liberation.mk
new file mode 100644
index 000..a0aae9a
--- /dev/null
+++ b/more_fonts/ExternalPackage_liberation.mk
@@ -0,0 +1,29 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call 
gb_ExternalPackage_ExternalPackage,font_liberation_inc,font_liberation))
+
+$(eval $(call gb_ExternalPackage_add_unpacked_files,font_liberation_inc,pck,\
+   LiberationMono-Bold.ttf \
+   LiberationMono-BoldItalic.ttf \
+   LiberationMono-Italic.ttf \
+   LiberationMono-Regular.ttf \
+   LiberationSans-Bold.ttf \
+   LiberationSans-BoldItalic.ttf \
+   LiberationSans-Italic.ttf \
+   LiberationSans-Regular.ttf \
+   LiberationSerif-Bold.ttf \
+   LiberationSerif-BoldItalic.ttf \
+   LiberationSerif-Ital

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - svtools/source

[Libreoffice Gerrit user]

 svtools/source/filter/wmf/winmtf.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 3acaae5bd924898c7f5ed0ce438288774b401885
Author: Radek Doulik 
Date:   Tue Oct 30 15:26:43 2012 +0100

fix character positions translation (partial fix for n#757387)

Change-Id: I042d6de9533f0f33e1fb64c3b92dc1bafaa6149f

diff --git a/svtools/source/filter/wmf/winmtf.cxx 
b/svtools/source/filter/wmf/winmtf.cxx
index 2968ec1..60c0859 100644
--- a/svtools/source/filter/wmf/winmtf.cxx
+++ b/svtools/source/filter/wmf/winmtf.cxx
@@ -1461,9 +1461,10 @@ void WinMtfOutput::DrawText( Point& rPosition, String& 
rText, sal_Int32* pDXArry
 
 for( i = 0, nSum = 0; i < nLen; i++ )
 {
-sal_Int32 nTemp = ImplMap( Size( pDXArry[ i ], 0 ) ).Width();
-nSum += nTemp;
-pDXArry[ i ] = nSum;
+if ( i ) {
+pDXArry[ i - 1 ] = ImplMap( Size( nSum, 0 ) ).Width();
+}
+nSum += pDXArry[ i ];
 }
 }
 if ( mnLatestTextLayoutMode != mnTextLayoutMode )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: svtools/source

[Libreoffice Gerrit user]

 svtools/source/filter/wmf/winmtf.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit d941d4d723afbc0b9e88bd19cb50ad711158e3a5
Author: Radek Doulik 
Date:   Tue Oct 30 15:26:43 2012 +0100

fix character positions translation (partial fix for n#757387)

Change-Id: I042d6de9533f0f33e1fb64c3b92dc1bafaa6149f

diff --git a/svtools/source/filter/wmf/winmtf.cxx 
b/svtools/source/filter/wmf/winmtf.cxx
index 3cc3ef9..23a8c90 100644
--- a/svtools/source/filter/wmf/winmtf.cxx
+++ b/svtools/source/filter/wmf/winmtf.cxx
@@ -1459,9 +1459,10 @@ void WinMtfOutput::DrawText( Point& rPosition, String& 
rText, sal_Int32* pDXArry
 
 for( i = 0, nSum = 0; i < nLen; i++ )
 {
-sal_Int32 nTemp = ImplMap( Size( pDXArry[ i ], 0 ) ).Width();
-nSum += nTemp;
-pDXArry[ i ] = nSum;
+if ( i ) {
+pDXArry[ i - 1 ] = ImplMap( Size( nSum, 0 ) ).Width();
+}
+nSum += pDXArry[ i ];
 }
 }
 if ( mnLatestTextLayoutMode != mnTextLayoutMode )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 5 commits - config_host.mk.in configure.ac external/mingw-dlls libxmlsec/makefile.mk libxmlsec/xmlsec1-mingw32.patch nss/makefile.mk nss/nsinstall.py nss/nspr-4.9-build.patch

[Libreoffice Gerrit user]

 config_host.mk.in   |2 
 configure.ac|   88 ++--
 external/mingw-dlls/makefile.mk |2 
 libxmlsec/makefile.mk   |   19 +-
 libxmlsec/xmlsec1-mingw32.patch |9 +
 nss/makefile.mk |   34 ++--
 nss/nsinstall.py|  163 ++
 nss/nspr-4.9-build.patch|  284 
 nss/nss-3.13.3-build.patch  |  259 
 nss/nss.patch.mingw |  279 ---
 scp2/InstallModule_ooo.mk   |2 
 scp2/source/ooo/mingw_dlls.scp  |   12 +
 12 files changed, 928 insertions(+), 225 deletions(-)

New commits:
commit 0afd117a2598c1cdc4efd7952fefbfbceee67dd3
Author: David Tardon 
Date:   Tue Oct 30 15:17:40 2012 +0100

fix mingw cross-compilation of libxmlsec

It works on Fedora 17 with internal nss, at least :-)

It would be nice to clean up the patch and throw away all the crack
related to cross-compilation on Windows, but I am really not much
interested in that. Also, I am lazy .-)

Change-Id: I008e13b0c4eef9cef361af058e1f32deada8e2aa

diff --git a/libxmlsec/makefile.mk b/libxmlsec/makefile.mk
index 2a8ac0f..ed86834 100644
--- a/libxmlsec/makefile.mk
+++ b/libxmlsec/makefile.mk
@@ -116,23 +116,18 @@ CONF_ILIB=-L$(ILIB:s/;/ -L/)
 CONFIGURE_DIR=
 CONFIGURE_ACTION=autoreconf ; ./configure
 
-.IF "$(CROSS_COMPILING)"=="YES"
 BUILD_AND_HOST=--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) 
MINGW_SYSROOT=$(MINGW_SYSROOT) OBJDUMP="$(OBJDUMP)"
-.ELSE
-BUILD_AND_HOST=--build=i586-pc-mingw32 --host=i586-pc-mingw32 
--with-mozilla_ver=1.7.5 --enable-mscrypto OBJDUMP="$(WRAPCMD) objdump"
-.ENDIF
-
-# Note that this is obsolete crack for building *locally* on Windows with 
MinGW,
-# something we don't see the point in here in LibreOffice
 
 CONFIGURE_FLAGS=--with-libxslt=no --with-openssl=no --with-gnutls=no 
--disable-crypto-dl $(BUILD_AND_HOST) CC="$(xmlsec_CC)" 
LDFLAGS="-Wl,--no-undefined $(CONF_ILIB)" LIBS="$(xmlsec_LIBS)" 
LIBXML2LIB="$(LIBXML2LIB)" ZLIB3RDLIB=$(ZLIB3RDLIB)
 
 .IF "$(SYSTEM_NSS)" != "YES"
 CONFIGURE_FLAGS+=--enable-pkgconfig=no
 .ENDIF
-BUILD_ACTION=$(GNUMAKE) -j$(EXTMAXPROCESS)
+BUILD_ACTION=$(GNUMAKE) -j$(GMAKE_MODULE_PARALLELISM)
 BUILD_DIR=$(CONFIGURE_DIR)
-.ELSE
+
+.ELSE # "$(COM)"!="GCC"
+
 CONFIGURE_DIR=win32
 CONFIGURE_ACTION=cscript configure.js
 .IF "$(product)"!="full" && "$(CCNUMVER)" >= "0013"
@@ -142,8 +137,10 @@ CONFIGURE_FLAGS=crypto=$(CRYPTOLIB) xslt=no iconv=no 
static=no include=$(BASEINC
 .ENDIF
 BUILD_ACTION=nmake
 BUILD_DIR=$(CONFIGURE_DIR)
-.ENDIF
-.ELSE
+.ENDIF # "$(COM)"=="GCC"
+
+.ELSE # "$(OS)"!="WNT"
+
 .IF "$(GUI)"=="UNX"
 
 .IF "$(COM)"=="C52" && "$(CPU)"=="U"
diff --git a/libxmlsec/xmlsec1-mingw32.patch b/libxmlsec/xmlsec1-mingw32.patch
index a5012ca..8aa8644 100644
--- a/libxmlsec/xmlsec1-mingw32.patch
+++ b/libxmlsec/xmlsec1-mingw32.patch
@@ -1,5 +1,14 @@
 --- misc/xmlsec1-1.2.14/configure.in   2009-09-29 15:55:33.282288142 +0200
 +++ misc/build/xmlsec1-1.2.14/configure.in 2009-09-29 15:49:39.614223428 
+0200
+@@ -33,6 +33,8 @@
+ AC_HEADER_STDC
+ 
+ LT_INIT
++dnl force the right implib extension for mingw
++libext=dll.a
+ 
+ dnl
+ dnl Find programs
 @@ -671,7 +671,9 @@
done

commit 5644397e44833ec43362c2d36d308c80bce8116f
Author: David Tardon 
Date:   Tue Oct 30 14:19:08 2012 +0100

fdo#55514 put liblangtag dll to install set

Change-Id: Ia2df651604358c70c0af129b5d60b149d2f1629e

diff --git a/config_host.mk.in b/config_host.mk.in
index f8566af..31f40b1 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -367,6 +367,7 @@ export MINGW_FONTCONFIG_DLL=@MINGW_FONTCONFIG_DLL@
 export MINGW_FREETYPE_DLL=@MINGW_FREETYPE_DLL@
 export MINGW_GCCDLL=@MINGW_GCCDLL@
 export MINGW_GCRYPT_DLL=@MINGW_GCRYPT_DLL@
+export MINGW_GLIB_DLL=@MINGW_GLIB_DLL@
 export MINGW_GNUTLS_DLL=@MINGW_GNUTLS_DLL@
 export MINGW_GPG_ERROR_DLL=@MINGW_GPG_ERROR_DLL@
 export MINGW_GRAPHITE2_DLL=@MINGW_GRAPHITE2_DLL@
@@ -382,6 +383,7 @@ export MINGW_INTL_DLL=@MINGW_INTL_DLL@
 export MINGW_JPEG_DLL=@MINGW_JPEG_DLL@
 export MINGW_LCMS2_DLL=@MINGW_LCMS2_DLL@
 export MINGW_LIBEXSLT_DLL=@MINGW_LIBEXSLT_DLL@
+export MINGW_LIBLANGTAG_DLL=@MINGW_LIBLANGTAG_DLL@
 export MINGW_LIBXML_DLL=@MINGW_LIBXML_DLL@
 export MINGW_LIBXSLT_DLL=@MINGW_LIBXSLT_DLL@
 export MINGW_LPSOLVE_DLL=@MINGW_LPSOLVE_DLL@
diff --git a/configure.ac b/configure.ac
index 78c2e3f..978f3b8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -11589,6 +11589,8 @@ if test "$enable_liblangtag" = "yes" -o \( 
"$enable_liblangtag" = "" -a $_os !=
 SYSTEM_LIBLANGTAG=YES
 AC_MSG_RESULT([yes])
 PKG_CHECK_MODULES( LIBLANGTAG, liblangtag >= 0.3)
+libo_MINGW_CHECK_DLL([LIBLANGTAG], [liblangtag])
+libo_MINGW_TRY_DLL([GLIB], [libglib-2.0])
 else
 SYSTEM_LIBLANGTAG=NO
 AC_MSG_RESULT([no])
@@ -11602,6 +11604,8 @@ AC_SUBST(EN

[Bug 37361] LibreOffice 3.5 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 46393, which changed state.

Bug 46393 Summary: PRINTING result for cell borders of particular document.xls 
unsatisfying
https://bugs.freedesktop.org/show_bug.cgi?id=46393

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: configure.ac

[Libreoffice Gerrit user]

 configure.ac |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 562c486349ed679802ca334b71b74c7a0f91987f
Author: Tor Lillqvist 
Date:   Tue Oct 30 15:43:25 2012 +0200

Build platform configure needs solenv/bin/getcompver.awk now

diff --git a/configure.ac b/configure.ac
index 55bfb90..a63eb7a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4078,6 +4078,7 @@ if test "$cross_compiling" = "yes"; then
 ooo.lst.in \
 oowintool \
 post_download.in \
+solenv/bin/getcompver.awk \
 solenv/inc/langlist.mk \
 solenv/inc/postset.mk \
 | (cd CONF-FOR-BUILD && tar xf -)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-commits] .: 4 commits - config_host.mk.in configure.ac epm/ExternalPackage_epm.mk epm/ExternalProject_epm.mk epm/Makefile epm/makefile.mk epm/Module_epm.mk epm/prj epm/UnpackedTarball

[Thorsten Behrens]

Libreoffice Gerrit user wrote:
> commit c3a586a716424a0f22858823622328ce92cb9640
> Author: Mat Kukan 
> Date:   Sun Oct 28 12:35:07 2012 +0100
> 
> openldap: convert to gbuild
> 
> Change-Id: Ic1c4c58a09fd41bce78731e61349baa129f5e935
> 
> diff --git a/postgresql/ExternalProject_postgresql.mk 
> b/postgresql/ExternalProject_postgresql.mk
> index 283b11b..c11cdb4 100644
> --- a/postgresql/ExternalProject_postgresql.mk
> +++ b/postgresql/ExternalProject_postgresql.mk
> @@ -11,6 +11,8 @@ $(eval $(call 
> gb_ExternalProject_ExternalProject,postgresql))
>  
>  $(eval $(call gb_ExternalProject_use_unpacked,postgresql,postgresql))
>  
> +$(eval $(call gb_ExternalProject_use_package,postgresql,openldap))
> +
>  $(eval $(call gb_ExternalProject_register_targets,postgresql,\
>   build \
>  ))
>
This seems to break postgres with internal ldap here - configure
errors out with

checking for ldap.h... no
configure: error: header file  is required for LDAP

(though it is clearly there at
workdir/unxlngx6/UnpackedTarball/openldap/include/ldap.h)

Cheers,

-- Thorsten


pgpJxscgvpMzV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: curl/ExternalProject_curl.mk

[Libreoffice Gerrit user]

 curl/ExternalProject_curl.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5d95db97b8004ab557fe9a86082927d85bb0b053
Author: Tor Lillqvist 
Date:   Tue Oct 30 14:50:44 2012 +0200

Fix MSVC build: LIB is not in environment so set it for the nmake command

Change-Id: Ic2f43692f003f6d3a88681d61fe21f52276b0b7b

diff --git a/curl/ExternalProject_curl.mk b/curl/ExternalProject_curl.mk
index 1005094..7baca05 100644
--- a/curl/ExternalProject_curl.mk
+++ b/curl/ExternalProject_curl.mk
@@ -48,7 +48,7 @@ else ifeq ($(COM),MSC)
 
 $(call gb_ExternalProject_get_state_target,curl,build):
cd $(EXTERNAL_WORKDIR)/lib \
-   && MAKEFLAGS= && LIB="$(ILIB)" && nmake -f Makefile.vc9 cfg=release-dll 
\
+   && MAKEFLAGS= LIB="$(ILIB)" nmake -f Makefile.vc9 cfg=release-dll \
EXCFLAGS="/EHa /Zc:wchar_t- /D_CRT_SECURE_NO_DEPRECATE 
$(SOLARINC)" $(if $(filter X86_64,$(CPUNAME)),MACHINE=X64) \
&& touch $@
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] Change in core[libreoffice-3-6]: Related: fdo#47250 fdo#56430 catch harder

[Tor Lillqvist (via Code Review)]

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/939

Approvals:
  Tor Lillqvist: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/939
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6b26670a6809fc07b344660111be44cb3e6a011
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara 
Gerrit-Reviewer: Tor Lillqvist 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sfx2/source

[Libreoffice Gerrit user]

 sfx2/source/view/viewsh.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 83be8c5b81feaf7e843898f4f6a1387c7ade183a
Author: Caolán McNamara 
Date:   Sun Oct 14 14:33:21 2012 +0100

Related: fdo#47250 fdo#56430 catch harder

so duden extension doesn't blow us up

Change-Id: Ie6b26670a6809fc07b344660111be44cb3e6a011
Reviewed-on: https://gerrit.libreoffice.org/939
Reviewed-by: Tor Lillqvist 
Tested-by: Tor Lillqvist 

diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx
index 31f421f..d04e4db 100644
--- a/sfx2/source/view/viewsh.cxx
+++ b/sfx2/source/view/viewsh.cxx
@@ -2044,7 +2044,7 @@ sal_Bool SfxViewShell::TryContextMenuInterception( Menu& 
rIn, const ::rtl::OUStr
 continue;
 }
 }
-catch (const uno::RuntimeException&)
+catch (...)
 {
 aIt.remove();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: fontconfig/ExternalProject_fontconfig.mk

[Libreoffice Gerrit user]

 fontconfig/ExternalProject_fontconfig.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1f2c5dc6be09e372bc39757d786d32a326732c59
Author: Tor Lillqvist 
Date:   Tue Oct 30 14:03:42 2012 +0200

Try to fix Android tinderbox build

For some reason $(LIBS) seems to contain a bunch of unneeded libraries
including -llo-bootstrap when we get here. Those won't be found by the
basic configury as there are no -L switches included, causing the
lovely "C compiler cannot create executables" problem.

Change-Id: Id7cfba191bd16649c7948194eb7ebdbfbfb74f3e

diff --git a/fontconfig/ExternalProject_fontconfig.mk 
b/fontconfig/ExternalProject_fontconfig.mk
index 90107a1..294c6b2 100644
--- a/fontconfig/ExternalProject_fontconfig.mk
+++ b/fontconfig/ExternalProject_fontconfig.mk
@@ -21,7 +21,7 @@ $(eval $(call gb_ExternalProject_register_targets,fontconfig,\
 
 $(call gb_ExternalProject_get_state_target,fontconfig,build) :
cd $(EXTERNAL_WORKDIR) \
-   && $(if $(debug),CFLAGS=-g) $(if $(filter ANDROID,$(OS)),LIBS="-lm 
$(LIBS)") ./configure \
+   && $(if $(debug),CFLAGS=-g) $(if $(filter ANDROID,$(OS)),LIBS="-lm") 
./configure \
--disable-shared \
--with-arch=arm \
--with-expat-includes=$(OUTDIR)/inc/external \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Change in core[libreoffice-3-6]: Related: fdo#47250 fdo#56430 catch harder

[via Code Review]

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/939

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/39/939/1

Related: fdo#47250 fdo#56430 catch harder

so duden extension doesn't blow us up

Change-Id: Ie6b26670a6809fc07b344660111be44cb3e6a011
---
M sfx2/source/view/viewsh.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/939
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6b26670a6809fc07b344660111be44cb3e6a011
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Caolán McNamara 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sfx2/source

[Libreoffice Gerrit user]

 sfx2/source/dialog/tabdlg.cxx |   17 ++---
 1 file changed, 6 insertions(+), 11 deletions(-)

New commits:
commit bd2c14ec78a7549d4a19738154cdd5ea890f61c4
Author: Caolán McNamara 
Date:   Tue Oct 30 12:00:01 2012 +

we have to have all tabpages in all modes now

Change-Id: I05a587d4b0556cb9eda49583441b3f57d923a800

diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index b137cee..eda2375 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -727,19 +727,14 @@ sal_Bool SfxTabDialog::IsApplyButtonEnabled() const
 
 void SfxTabDialog::Start_Impl()
 {
-//If we're layout enabled, we need to force all tabs to
-//exist to get overall optimal size for dialog
-if (isLayoutEnabled())
+//We need to force all tabs to exist to get overall optimal size for dialog
+for (sal_uInt16 n=0; n < m_pTabCtrl->GetPageCount(); ++n)
 {
-for ( sal_uInt16 n=0; n < m_pTabCtrl->GetPageCount(); ++n)
+sal_uInt16 nPageId = m_pTabCtrl->GetPageId(n);
+if (!m_pTabCtrl->GetTabPage(nPageId))
 {
-sal_uInt16 nPageId = m_pTabCtrl->GetPageId(n);
-TabPage* pTabPage = m_pTabCtrl->GetTabPage(nPageId);
-if (!pTabPage)
-{
-m_pTabCtrl->SetCurPageId(nPageId);
-ActivatePageHdl(m_pTabCtrl);
-}
+m_pTabCtrl->SetCurPageId(nPageId);
+ActivatePageHdl(m_pTabCtrl);
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - scripting/source sw/source

[Libreoffice Gerrit user]

 scripting/source/provider/ProviderCache.cxx |2 +-
 sw/source/ui/shells/textsh.cxx  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b6b71d74fddca5e260ab2a3d6307603f5b469108
Author: Caolán McNamara 
Date:   Tue Oct 30 09:55:11 2012 +

squeeze all Exceptions through RuntimeException for exception sig

Change-Id: I50377a12c2baadf48767e1d4c265417d3c8ab765

diff --git a/scripting/source/provider/ProviderCache.cxx 
b/scripting/source/provider/ProviderCache.cxx
index 48abd56..0b65ffa 100644
--- a/scripting/source/provider/ProviderCache.cxx
+++ b/scripting/source/provider/ProviderCache.cxx
@@ -189,7 +189,7 @@ ProviderCache::createProvider( ProviderDetails& details ) 
throw ( RuntimeExcepti
 details.provider.set(
 details.factory->createInstanceWithArgumentsAndContext( m_Sctx, 
m_xContext ), UNO_QUERY_THROW );
 }
-catch ( const RuntimeException& e )
+catch ( const Exception& e )
 {
 ::rtl::OUString temp("ProviderCache::createProvider() Error creating 
provider from factory!!!\n");
 throw RuntimeException( temp.concat( e.Message ), Reference< 
XInterface >() );
commit ce3d66c29da891eee999a2e702c05ecd6babf5ff
Author: Caolán McNamara 
Date:   Tue Oct 30 09:54:32 2012 +

cancel on insert frame was inserting a frame

Change-Id: Ie95947935b5891642f22c81a15ae1d9ed24fd3f2

diff --git a/sw/source/ui/shells/textsh.cxx b/sw/source/ui/shells/textsh.cxx
index f282e5f..1fdaf20 100644
--- a/sw/source/ui/shells/textsh.cxx
+++ b/sw/source/ui/shells/textsh.cxx
@@ -597,7 +597,7 @@ void SwTextShell::ExecInsert(SfxRequest &rReq)
 SfxAbstractTabDialog* pDlg = pFact->CreateFrmTabDialog( 
DLG_FRM_STD,
 GetView().GetViewFrame(), 
&GetView().GetViewFrame()->GetWindow(), aSet, sal_True);
 OSL_ENSURE(pDlg, "Dialogdiet fail!");
-if(pDlg->Execute() && pDlg->GetOutputItemSet())
+if(pDlg->Execute() == RET_OK && pDlg->GetOutputItemSet())
 {
 //local variable necessary at least after call of 
.AutoCaption() because this could be deleted at this point
 SwWrtShell& rShell = GetShell();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: RepositoryExternal.mk

[Libreoffice Gerrit user]

 RepositoryExternal.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 23a324d282865d2a95142e0c758d266f1a0dc080
Author: Tor Lillqvist 
Date:   Tue Oct 30 13:18:40 2012 +0200

Try to fix a highly parallel build of libcmis with a non-system curl

The problem us that gb_LinkTarget__use_curl only declared a dependency
on an *unpacked* curl tarball, but the curlbuild.h file is *generated*
during curl configury. So something that depends on a (non-system)
curl needs to depend on curl having been configured at least. Let's
try like this.

Change-Id: I87b2a3292807d9bb873c3656caf58c4d98d8f622

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 23f14ad..ca87908 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -1624,7 +1624,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, 
\
 ))
 
 define gb_LinkTarget__use_curl
-$(call gb_LinkTarget_use_unpacked,$(1),curl)
+$(call gb_LinkTarget_use_external_project,$(1),curl)
 $(call gb_LinkTarget_set_include,$(1),\
-I$(call gb_UnpackedTarball_get_dir,curl/include) \
$$(INCLUDE) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - sc/source

[Libreoffice Gerrit user]

 sc/source/filter/oox/defnamesbuffer.cxx |4 
 1 file changed, 4 insertions(+)

New commits:
commit f80277948fc36eddc46ab841aa9eb654bad8a183
Author: Markus Mohrhard 
Date:   Fri Sep 28 21:01:14 2012 +0200

vba procedures and macro names will result in crash, fdo#55174

Change-Id: I23073ecc56482670d185b39452a7d8b9d6eb38c8

diff --git a/sc/source/filter/oox/defnamesbuffer.cxx 
b/sc/source/filter/oox/defnamesbuffer.cxx
index 2cf0c00..8cdbcc4 100644
--- a/sc/source/filter/oox/defnamesbuffer.cxx
+++ b/sc/source/filter/oox/defnamesbuffer.cxx
@@ -426,6 +426,10 @@ DefinedName::getTokens()
 
 void DefinedName::convertFormula()
 {
+// macro function or vba procedure
+if(!mpScRangeData)
+return;
+
 // convert and set formula of the defined name
 if ( getFilterType() == FILTER_OOXML )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - cui/source editeng/inc editeng/source lingucomponent/source linguistic/inc linguistic/source offapi/com offapi/type_reference offapi/UnoApi_offapi.mk qadevOOo/objd

[Libreoffice Gerrit user]

 cui/source/dialogs/thesdlg.cxx|2 
 cui/source/options/optlingu.cxx   |  257 ++
 editeng/inc/editeng/unolingu.hxx  |6 
 editeng/source/misc/unolingu.cxx  |   32 -
 lingucomponent/source/thesaurus/libnth/nthesimp.cxx   |   16 
 linguistic/inc/linguistic/misc.hxx|1 
 linguistic/source/lngsvcmgr.cxx   |2 
 linguistic/source/lngsvcmgr.hxx   |   12 
 offapi/UnoApi_offapi.mk   |3 
 offapi/com/sun/star/linguistic2/LinguServiceManager.idl   |   13 
 offapi/com/sun/star/linguistic2/XLinguServiceManager2.idl |   46 ++
 offapi/type_reference/types.rdb   |binary
 qadevOOo/objdsc/lng/com.sun.star.lingu2.LngSvcMgr.csv |   16 
 sc/CppunitTest_sc_filters_test.mk |1 
 sc/CppunitTest_sc_macros_test.mk  |1 
 sc/CppunitTest_sc_subsequent_filters_test.mk  |1 
 sd/CppunitTest_sd_filters_test.mk |1 
 sd/CppunitTest_sd_regression_test.mk  |1 
 sd/CppunitTest_sd_uimpress.mk |1 
 sfx2/source/menu/thessubmenu.cxx  |   35 -
 sfx2/source/menu/thessubmenu.hxx  |4 
 svx/source/dialog/langbox.cxx |1 
 svx/source/unodraw/unoshtxt.cxx   |   18 
 sw/CppunitTest_sw_subsequent_odfexport.mk |1 
 sw/CppunitTest_sw_subsequent_odfimport.mk |1 
 sw/CppunitTest_sw_subsequent_ooxmlexport.mk   |1 
 sw/CppunitTest_sw_subsequent_ooxmlimport.mk   |1 
 sw/CppunitTest_sw_subsequent_rtfexport.mk |1 
 sw/CppunitTest_sw_subsequent_rtfimport.mk |1 
 sw/CppunitTest_sw_subsequent_ww8export.mk |1 
 sw/CppunitTest_sw_subsequent_ww8import.mk |1 
 sw/inc/dlelstnr.hxx   |4 
 sw/source/ui/uno/dlelstnr.cxx |   48 +-
 vcl/source/gdi/outdev3.cxx|   16 
 34 files changed, 275 insertions(+), 271 deletions(-)

New commits:
commit ddcf2363bad1d84874dfe4e31e4783ffd761d5bb
Author: Stephan Bergmann 
Date:   Tue Oct 30 11:40:18 2012 +0100

fdo#46808: Improve previous commit

* Removing m_xLngMgr.is() check from SfxThesSubMenuHelper::GetThesImplName 
was
  unsound with SfxThesSubMenuHelper ctor swallowing Exception; best fix 
appears
  to be to remove the swallowing.

* Prefer forward declarations over #includes.

Change-Id: Ie4e7dcd6cdb14046516d119605bbf78e81359768

diff --git a/sfx2/source/menu/thessubmenu.cxx b/sfx2/source/menu/thessubmenu.cxx
index 1a64588..f4c5f47 100644
--- a/sfx2/source/menu/thessubmenu.cxx
+++ b/sfx2/source/menu/thessubmenu.cxx
@@ -64,18 +64,12 @@ void SfxThesSubMenuHelper::GetLocale(
 }
 
 
-SfxThesSubMenuHelper::SfxThesSubMenuHelper()
+SfxThesSubMenuHelper::SfxThesSubMenuHelper():
+m_xLngMgr(
+linguistic2::LinguServiceManager::create(
+comphelper::getProcessComponentContext())),
+m_xThesarus(m_xLngMgr->getThesaurus())
 {
-try
-{
-uno::Reference< uno::XComponentContext >  xContext( 
::comphelper::getProcessComponentContext() );
-m_xLngMgr = linguistic2::LinguServiceManager::create(xContext);
-m_xThesarus = m_xLngMgr->getThesaurus();
-}
-catch (const uno::Exception &)
-{
-DBG_ASSERT( 0, "failed to get thesaurus" );
-}
 }
 
 
diff --git a/sw/inc/dlelstnr.hxx b/sw/inc/dlelstnr.hxx
index 918ebf7..88ee1cc 100644
--- a/sw/inc/dlelstnr.hxx
+++ b/sw/inc/dlelstnr.hxx
@@ -23,7 +23,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include  // helper for implementations
@@ -32,6 +31,7 @@
 namespace com { namespace sun { namespace star {
 namespace linguistic2 {
 class XDictionaryList;
+class XLinguServiceManager2;
 class XProofreadingIterator;
 }
 namespace frame {
commit 43d9f35c2665e55cfb5ee911a554ef71933ad4d1
Author: Noel Grandin 
Date:   Fri Oct 26 14:24:46 2012 +0200

fdo#46808, Adapt linguistic2::LinguServiceManager UNO service to new style

Create a merged XLinguServiceManager2 interface for this service to 
implement.
Which is backwards-compatible, but does not require creating a new service.

Change-Id: I297bada1066cd74809108641b56ee4d5898112ec

diff --git a/cui/source/dialogs/thesdlg.cxx b/cui/source/dialogs/thesdlg.cxx
index 3763f68..590dda3 100644
--- a/cui/source/dialogs/thesdlg.cxx
+++ b/cui/source/dialogs/thesdlg.cxx
@@ -48,7 +48,7 @@
 
 #include 
 #include 
-#include 
+#include 
 
 using namespace ::com::sun::star;
 using ::rtl::OUString;
diff --git a/cui/source/options/optlingu.cx

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - sc/source

[Libreoffice Gerrit user]

 sc/source/filter/excel/xetable.cxx |   22 +-
 1 file changed, 17 insertions(+), 5 deletions(-)

New commits:
commit caf8899d6e3f06332104cdf21cba23daca17d56e
Author: Noel Power 
Date:   Wed Jul 25 18:23:38 2012 +0100

hopefully more successful attempt to solve fdo#50304

Change-Id: I86dfff571c14bce97d0851b4093dbc376d8b6ea4

diff --git a/sc/source/filter/excel/xetable.cxx 
b/sc/source/filter/excel/xetable.cxx
index e3967f2..d611077 100644
--- a/sc/source/filter/excel/xetable.cxx
+++ b/sc/source/filter/excel/xetable.cxx
@@ -2146,14 +2146,26 @@ XclExpDimensions* XclExpRowBuffer::GetDimensions()
 
 XclExpRow& XclExpRowBuffer::GetOrCreateRow( sal_uInt32 nXclRow, bool 
bRowAlwaysEmpty )
 {
-RowMap::iterator itr = maRowMap.find(nXclRow);
-if (itr == maRowMap.end())
+RowMap::iterator itr = maRowMap.begin();
+ScDocument& rDoc = GetRoot().GetDoc();
+SCTAB nScTab = GetRoot().GetCurrScTab();
+for ( size_t nFrom = maRowMap.size(); nFrom <= nXclRow; ++nFrom )
 {
-RowRef p(new XclExpRow(GetRoot(), nXclRow, maOutlineBfr, 
bRowAlwaysEmpty));
-::std::pair r = 
maRowMap.insert(RowMap::value_type(nXclRow, p));
-itr = r.first;
+itr = maRowMap.find(nFrom);
+if ( itr == maRowMap.end() )
+{
+// only create RowMap entries for rows that differ from previous,
+// or if it is the desired row
+if ( !nFrom || ( nFrom == nXclRow ) || ( nFrom && ( 
rDoc.GetRowHeight(nFrom, nScTab, false) != rDoc.GetRowHeight(nFrom-1, nScTab, 
false) ) ) )
+{
+RowRef p(new XclExpRow(GetRoot(), nFrom, maOutlineBfr, 
bRowAlwaysEmpty));
+maRowMap.insert(RowMap::value_type(nFrom, p));
+}
+}
 }
+itr = maRowMap.find(nXclRow);
 return *itr->second;
+
 }
 
 // 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: How do I prepare and upload spell check dictionaries for biodiversity in South Africa?

[Andras Timar]

Hi Leslie,

On Mon, Oct 29, 2012 at 8:19 AM, Leslie Powrie wrote:

>  I have prepared spell check dictionaries for use in MS Office for South
> African botanical (48011 names), zoological (30884), and physical feature
> (107428) names.
>
> **
>

Great!


>
>
> It seems as though LibreOffice probably has a similar limit. It appears as
> though the limit may be 3 names.
>
> **
>

It is a sal_Int16, so 32768 is the limit. See
http://opengrok.libreoffice.org/xref/core/linguistic/source/dicimp.hxx#56


>  **
>
> But another problem is with accented characters. Many of our place names
> have ö, ô, é and so forth. So although the dictionary has the name
> Aasvoëlkranskloof
>

Custom dictionaries are plain text files with LF (0x0a) line endings and
encoded in UTF-8.

OpenOffice.org=
>
> OpenDocument=
>
> AppArmor
>
> **
>

= at the end of the word means that it must not be hyphenated.


> ** **
>
> Once ready, how do I upload them?
>
>
>
AFAIK it is not possible to create extension (.oxt) for user defined
dictionaries. Alternatively you can create normal Hunspell dictionaries,
which do not have size limitation and can handle affixes, too. It's been
planned for a long time that auxiliary dictionaries can extend main
dictionary, so users can use e.g. main en-US Hunspell dictionary and a
special en-US Hunspell dictionary on the top of that at the same time. I'm
not sure, if it is ready. Laszlo Nemeth can tell us more.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: ucb/README

[Libreoffice Gerrit user]

 ucb/README |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 273ee9838cb87d6cf910a92969592709eba650f9
Author: Stephan Bergmann 
Date:   Tue Oct 30 10:59:35 2012 +0100

Rationale for webdav-neon vs. webdav

...regarding 03ded70913f957460f90608465e4d0a182879074 "rename
ucb/source/ucp/webdav to webdav-neon" followed by
015b29b74aaf16f5bdf6a90f6e7d5c1d210fe281 "re-base on ALv2 code," copied from
libreoffice-dev IRC.

Change-Id: I7388007f5f8cfd34aa19cb68ee3bc59b2905153b

diff --git a/ucb/README b/ucb/README
index d3d1ed0..d364a09 100644
--- a/ucb/README
+++ b/ucb/README
@@ -1 +1,7 @@
 Universal Content Broker (has ucp) which do things like convert files to 
strings in content broker world.
+
+mmeeks: so - I renamed the old LGPLv3 webdav code to webdav-neon, and imported
+the (not built) surf webdav ucp into the old space. so that in future, we can
+merge changes more easily - and still choose which to use. cbosdonnat kindly
+volunteered to do some comparitive analysis of the two codebases to decide 
which
+is best for what etc.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: dbaccess/JunitTest_dbaccess_complex.mk dbaccess/JunitTest_dbaccess_unoapi.mk

[Libreoffice Gerrit user]

 dbaccess/JunitTest_dbaccess_complex.mk |   10 +-
 dbaccess/JunitTest_dbaccess_unoapi.mk  |8 
 2 files changed, 9 insertions(+), 9 deletions(-)

New commits:
commit 5bce80add81dea7b241e8593fee8bf25cb80c4e1
Author: Stephan Bergmann 
Date:   Tue Oct 30 10:52:36 2012 +0100

Properly spell out "dbaccess"

...so that these tests also work from a toplevel make.

Change-Id: I82899ce6f1760b34b365ee5cfacbadb1f40de766

diff --git a/dbaccess/JunitTest_dbaccess_complex.mk 
b/dbaccess/JunitTest_dbaccess_complex.mk
index fd1511e..bd8358e 100644
--- a/dbaccess/JunitTest_dbaccess_complex.mk
+++ b/dbaccess/JunitTest_dbaccess_complex.mk
@@ -7,9 +7,9 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-$(eval $(call gb_JunitTest_JunitTest,dba_ju_complex))
+$(eval $(call gb_JunitTest_JunitTest,dbaccess_ju_complex))
 
-$(eval $(call gb_JunitTest_use_jars,dba_ju_complex,\
+$(eval $(call gb_JunitTest_use_jars,dbaccess_ju_complex,\
 ConnectivityTools \
 OOoRunner \
 jurt \
@@ -18,17 +18,17 @@ $(eval $(call gb_JunitTest_use_jars,dba_ju_complex,\
 unoil \
 ))
 
-$(eval $(call gb_JunitTest_set_defs,dba_ju_complex,\
+$(eval $(call gb_JunitTest_set_defs,dbaccess_ju_complex,\
 $$(DEFS) \
 -Dorg.openoffice.test.arg.tdoc=$(SRCDIR)/dbaccess/qa/dbaccess \
 ))
 
-$(eval $(call gb_JunitTest_add_classes,dba_ju_complex,\
+$(eval $(call gb_JunitTest_add_classes,dbaccess_ju_complex,\
 complex.dbaccess.Beamer \
 complex.dbaccess.PropertyBag \
 ))
 
-$(eval $(call gb_JunitTest_add_sourcefiles,dba_ju_complex,\
+$(eval $(call gb_JunitTest_add_sourcefiles,dbaccess_ju_complex,\
 dbaccess/qa/complex/dbaccess/ApplicationController \
 dbaccess/qa/complex/dbaccess/Beamer \
 dbaccess/qa/complex/dbaccess/CRMBasedTestCase \
diff --git a/dbaccess/JunitTest_dbaccess_unoapi.mk 
b/dbaccess/JunitTest_dbaccess_unoapi.mk
index 5897697..f948229 100644
--- a/dbaccess/JunitTest_dbaccess_unoapi.mk
+++ b/dbaccess/JunitTest_dbaccess_unoapi.mk
@@ -26,16 +26,16 @@
 # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
 # instead of those above.
 
-$(eval $(call gb_JunitTest_JunitTest,dba_ju_unoapi))
+$(eval $(call gb_JunitTest_JunitTest,dbaccess_ju_unoapi))
 
-$(eval $(call gb_JunitTest_set_defs,dba_ju_unoapi,\
+$(eval $(call gb_JunitTest_set_defs,dbaccess_ju_unoapi,\
 $$(DEFS) \
 -Dorg.openoffice.test.arg.sce=$(SRCDIR)/dbaccess/qa/unoapi/dbaccess.sce \
 -Dorg.openoffice.test.arg.xcl=$(SRCDIR)/dbaccess/qa/unoapi/knownissues.xcl 
\
 -Dorg.openoffice.test.arg.tdoc=$(SRCDIR)/dbaccess/qa/unoapi/testdocuments \
 ))
 
-$(eval $(call gb_JunitTest_use_jars,dba_ju_unoapi,\
+$(eval $(call gb_JunitTest_use_jars,dbaccess_ju_unoapi,\
 OOoRunner \
 jurt \
 ridl \
@@ -43,7 +43,7 @@ $(eval $(call gb_JunitTest_use_jars,dba_ju_unoapi,\
 unoil \
 ))
 
-$(eval $(call gb_JunitTest_add_classes,dba_ju_unoapi,\
+$(eval $(call gb_JunitTest_add_classes,dbaccess_ju_unoapi,\
 org.openoffice.test.UnoApiTest \
 ))
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: ucb/source

[Libreoffice Gerrit user]

 ucb/source/ucp/webdav-neon/NeonSession.cxx |7 ++-
 ucb/source/ucp/webdav/SerfSession.cxx  |7 ++-
 2 files changed, 4 insertions(+), 10 deletions(-)

New commits:
commit e6abcd4fe7eb7cc12df372a298d06b57f822251f
Author: Noel Grandin 
Date:   Thu Oct 25 17:31:23 2012 +0200

fdo#46808, use service constructor for security::CertificateContainer

Change-Id: Ia8bcd2efd8137922024fb2ed2f2e4197f4ee25e1

diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx 
b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index b3a737f..d05973f 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -49,6 +49,7 @@ extern "C" {
 
 #include "libxml/parser.h"
 #include "rtl/ustrbuf.hxx"
+#include "comphelper/processfactory.hxx"
 #include "comphelper/sequence.hxx"
 #include 
 #include "ucbhelper/simplecertificatevalidationrequest.hxx"
@@ -406,11 +407,7 @@ extern "C" int NeonSession_CertificationNotify( void 
*userdata,
 uno::Reference< security::XCertificateContainer > xCertificateContainer;
 try
 {
-xCertificateContainer
-= uno::Reference< security::XCertificateContainer >(
-pSession->getMSF()->createInstance(
-rtl::OUString( 
"com.sun.star.security.CertificateContainer" ) ),
-uno::UNO_QUERY );
+xCertificateContainer = security::CertificateContainer::create( 
comphelper::getComponentContext( pSession->getMSF() ) );
 }
 catch ( uno::Exception const & )
 {
diff --git a/ucb/source/ucp/webdav/SerfSession.cxx 
b/ucb/source/ucp/webdav/SerfSession.cxx
index 0030c21..bd858b4 100644
--- a/ucb/source/ucp/webdav/SerfSession.cxx
+++ b/ucb/source/ucp/webdav/SerfSession.cxx
@@ -24,6 +24,7 @@
 #include 
 #include 
 #include 
+#include "comphelper/processfactory.hxx"
 #include "comphelper/sequence.hxx"
 #include "ucbhelper/simplecertificatevalidationrequest.hxx"
 
@@ -385,11 +386,7 @@ apr_status_t SerfSession::verifySerfCertificateChain (
 try
 {
 // Create a certificate container.
-xCertificateContainer = uno::Reference< 
security::XCertificateContainer >(
-getMSF()->createInstance(
-rtl::OUString::createFromAscii(
-"com.sun.star.security.CertificateContainer" ) ),
-uno::UNO_QUERY_THROW);
+xCertificateContainer = security::CertificateContainer::create( 
comphelper::getComponentContext(getMSF()) );
 
 xSEInitializer = uno::Reference< xml::crypto::XSEInitializer >(
 getMSF()->createInstance(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: curl/ExternalPackage_curl.mk

[Libreoffice Gerrit user]

 curl/ExternalPackage_curl.mk |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 685852d89235c58df32c4cae4069cbaa24caf62f
Author: Tor Lillqvist 
Date:   Tue Oct 30 11:09:38 2012 +0200

Correct location of the libtool-built libcurl

Change-Id: I0b997cdd3c133fa2212d519a136fa17f08a68730

diff --git a/curl/ExternalPackage_curl.mk b/curl/ExternalPackage_curl.mk
index e8e7e65..edd410a 100644
--- a/curl/ExternalPackage_curl.mk
+++ b/curl/ExternalPackage_curl.mk
@@ -18,17 +18,17 @@ $(eval $(call 
gb_ExternalPackage_add_file,curl,lib/pkgconfig/libcurl.pc,libcurl.
 endif
 
 ifeq ($(DISABLE_DYNLOADING),TRUE)
-$(eval $(call gb_ExternalPackage_add_file,curl,lib/libcurl.a,.libs/libcurl.a))
+$(eval $(call 
gb_ExternalPackage_add_file,curl,lib/libcurl.a,lib/.libs/libcurl.a))
 else ifeq ($(OS),ANDROID)
-$(eval $(call 
gb_ExternalPackage_add_file,curl,lib/libcurl.so,.libs/libcurl.so))
+$(eval $(call 
gb_ExternalPackage_add_file,curl,lib/libcurl.so,lib/.libs/libcurl.so))
 else
 $(eval $(call 
gb_ExternalPackage_add_file,curl,lib/libcurl.so,lib/.libs/libcurl.so.4.2.0))
 endif
 
 else ifeq ($(OS)$(COM),WNTGCC)
 
-$(eval $(call gb_ExternalPackage_add_file,curl,lib/libcurl.a,.libs/libcurl.a))
-$(eval $(call 
gb_ExternalPackage_add_file,curl,bin/libcurl.dll,.libs/libcurl.dll))
+$(eval $(call 
gb_ExternalPackage_add_file,curl,lib/libcurl.a,lib/.libs/libcurl.a))
+$(eval $(call 
gb_ExternalPackage_add_file,curl,bin/libcurl.dll,lib/.libs/libcurl.dll))
 
 else ifeq ($(COM),MSC)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - 2 commits - sw/source writerfilter/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxattributeoutput.cxx |  145 +++
 sw/source/filter/ww8/docxattributeoutput.hxx |4 
 writerfilter/source/dmapper/DomainMapperTableHandler.cxx |   27 +-
 3 files changed, 126 insertions(+), 50 deletions(-)

New commits:
commit 47d9a8a3397ed2f4ff7e7ec1bba392da34d8519e
Author: Pierre-Eric Pelloux-Prayer 
Date:   Thu Sep 27 10:15:58 2012 +0200

n#780645 docx import: properly import table position

This a follow up of commit 53b7f7df0617bcbd7bbef9a34ef53e5097eb16dc

Reviewed-on: https://gerrit.libreoffice.org/714
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
(cherry picked from commit 3cb619bd15a6017f253891f4c377fc790d8aae82)

Change-Id: Ia0f79ca24418636af14162e9f339237d847dc221

diff --git a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx 
b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
index 91d652d..f44e93c 100644
--- a/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableHandler.cxx
@@ -403,7 +403,7 @@ TableStyleSheetEntry * 
DomainMapperTableHandler::endTableGetTableStyle(TableInfo
 
 //table border settings
 table::TableBorder aTableBorder;
-table::BorderLine2 aBorderLine;
+table::BorderLine2 aBorderLine, aLeftBorder;
 
 if (lcl_extractTableBorderProperty(m_aTableProperties, 
PROP_TOP_BORDER, rInfo, aBorderLine))
 {
@@ -415,10 +415,11 @@ TableStyleSheetEntry * 
DomainMapperTableHandler::endTableGetTableStyle(TableInfo
 aTableBorder.BottomLine = aBorderLine;
 aTableBorder.IsBottomLineValid = sal_True;
 }
-if (lcl_extractTableBorderProperty(m_aTableProperties, 
PROP_LEFT_BORDER, rInfo, aBorderLine))
+if (lcl_extractTableBorderProperty(m_aTableProperties, 
PROP_LEFT_BORDER, rInfo, aLeftBorder))
 {
-aTableBorder.LeftLine = aBorderLine;
+aTableBorder.LeftLine = aLeftBorder;
 aTableBorder.IsLeftLineValid = sal_True;
+rInfo.nLeftBorderDistance += aLeftBorder.LineWidth * 0.5;
 }
 if (lcl_extractTableBorderProperty(m_aTableProperties, 
PROP_RIGHT_BORDER, rInfo, aBorderLine))
 {
@@ -445,23 +446,17 @@ TableStyleSheetEntry * 
DomainMapperTableHandler::endTableGetTableStyle(TableInfo
 lcl_debug_TableBorder(aTableBorder);
 #endif
 
-// Mimic Office behavior : if tlbInd is defined, use it place table.
-// Otherwise, top-level table's position depends w:tblCellMar 
attribute (but not nested tables)
-if (nLeftMargin)
+// Table position in Office is computed in 2 different ways :
+// - top level tables: the goal is to have in-cell text starting at 
table indent pos (tblInd),
+//   so table's position depends on table's cells margin
+// - nested tables: the goal is to have left-most border starting at 
table_indent pos
+if (rInfo.nNestLevel > 1)
 {
-m_aTableProperties->Insert( PROP_LEFT_MARGIN, false, uno::makeAny( 
nLeftMargin - nGapHalf));
+m_aTableProperties->Insert( PROP_LEFT_MARGIN, false, uno::makeAny( 
nLeftMargin - nGapHalf ));
 }
 else
 {
-// TODO: top-level position depends on w:tblCellMar attribute, not 
w:cellMar
-if (rInfo.nNestLevel > 1)
-{
-m_aTableProperties->Insert( PROP_LEFT_MARGIN, false, 
uno::makeAny( - nGapHalf));
-}
-else
-{
-m_aTableProperties->Insert( PROP_LEFT_MARGIN, false, 
uno::makeAny( - nGapHalf - rInfo.nLeftBorderDistance));
-}
+m_aTableProperties->Insert( PROP_LEFT_MARGIN, false, uno::makeAny( 
nLeftMargin - nGapHalf - rInfo.nLeftBorderDistance ));
 }
 
 m_aTableProperties->getValue( TablePropertyMap::TABLE_WIDTH, 
nTableWidth );
commit 2cefbc6622e8838e049542376ea76c4c4179fbb3
Author: Pierre-Eric Pelloux-Prayer 
Date:   Thu Sep 27 17:00:08 2012 +0200

n#780645 docx export: export default table cell margins, based on 1st cell

Reviewed-on: https://gerrit.libreoffice.org/716
Reviewed-by: Miklos Vajna 
Tested-by: Miklos Vajna 
(cherry picked from commit 9751056ba806ba9614392f3c70ada3cbd1251814)

Change-Id: I1a697c2a60c7979774242fb6c9b0f66baa3bb72e

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index 179c2f6..b9f2295 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -1503,7 +1503,7 @@ static void impl_borderLine( FSHelperPtr pSerializer, 
sal_Int32 elementToken, co
 pSerializer->singleElementNS( XML_w, elementToken, xAttrs );
 }
 
-static void impl_pageBorders( FSHelperPtr pSerializer, const SvxBoxItem& rBox, 
bool bUseStartEnd = false )
+static void impl_pageBorders( FSHelperPtr pSerializer, const SvxBoxItem& rBox, 
sal

Re: .: config_host.mk.in configure.ac curl/curl-7.26.0_mingw.patch

[Miklos Vajna]

Hi Peter,

[ Re-sending with a shorter subject. ]

On Mon, Oct 29, 2012 at 09:28:40AM -0700, Libreoffice Gerrit user 
 wrote:
>  Makefile.top |2 -
>  Module_tail_build.mk |1 
>  RepositoryModule_ooo.mk  |1 
>  config_host.mk.in|1 
>  configure.ac |2 +
>  curl/ExternalPackage_curl.mk |   39 +
>  curl/ExternalProject_curl.mk |   56 
> +++
>  curl/Makefile|7 +
>  curl/Module_curl.mk  |   20 +++
>  curl/UnpackedTarball_curl.mk |   32 
>  curl/curl-7.26.0_mingw.patch |2 -
>  curl/curl-7.26.0_win.patch   |   20 ++-
>  curl/prj/d.lst   |   18 -
>  ooo.lst.in   |2 -
>  tail_build/prj/build.lst |2 -
>  15 files changed, 182 insertions(+), 23 deletions(-)
> 
> New commits:
> commit 0f075129c95f7aee782bf08b2edbe7c71db1c7b2
> Author: Peter Foley 
> Date:   Mon Oct 29 10:50:32 2012 -0400
> 
> convert curl to gbuild

make dev-install failed here due to this. Now I pushed
fd443f82bc7b59e97e9a49c54fe72ec18517d627 to get it working, but
ucpcmis1.uno.so and libucpftp1.so still links to libcurl.so.4 instead of
libcurl.so, you probably want to fix that. :-)

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: svtools/source

[Libreoffice Gerrit user]

 svtools/source/contnr/treelist.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit c38d460d8112079c83c6a5175bdc8cc019328c1c
Author: Stephan Bergmann 
Date:   Tue Oct 30 10:02:58 2012 +0100

Reapply eda255b38d871bb7d20432e5730cc8c68b3e2942

... "SvTreeList: fix singular iterator compare assertions" after commits 
that
broke it again.

Change-Id: I527fe37e2a0a9f6fbba468261892379920f02c10

diff --git a/svtools/source/contnr/treelist.cxx 
b/svtools/source/contnr/treelist.cxx
index e489c7c..895ef97 100644
--- a/svtools/source/contnr/treelist.cxx
+++ b/svtools/source/contnr/treelist.cxx
@@ -1378,7 +1378,8 @@ SvTreeList::GetChildIterators(const SvTreeListEntry* 
pParent) const
 {
 typedef std::pair IteratorPair;
 
-IteratorPair aRet;
+static const SvTreeListEntries dummy; // prevent singular iterator asserts
+IteratorPair aRet(dummy.begin(), dummy.end());
 
 if (!pParent)
 pParent = pRootItem;
@@ -1398,7 +1399,8 @@ std::pair
 {
 typedef std::pair IteratorPair;
 
-IteratorPair aRet;
+static SvTreeListEntries dummy; // prevent singular iterator asserts
+IteratorPair aRet(dummy.begin(), dummy.end());
 
 if (!pParent)
 pParent = pRootItem;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: .: config_host.mk.in configure.ac curl/curl-7.26.0_mingw.patch curl/curl-7.26.0_win.patch curl/ExternalPackage_curl.mk curl/ExternalProject_curl.mk curl/Makefile curl/Module_curl.mk curl/prj curl/

[Miklos Vajna]

Hi Peter,

On Mon, Oct 29, 2012 at 09:28:40AM -0700, Libreoffice Gerrit user 
 wrote:
>  Makefile.top |2 -
>  Module_tail_build.mk |1 
>  RepositoryModule_ooo.mk  |1 
>  config_host.mk.in|1 
>  configure.ac |2 +
>  curl/ExternalPackage_curl.mk |   39 +
>  curl/ExternalProject_curl.mk |   56 
> +++
>  curl/Makefile|7 +
>  curl/Module_curl.mk  |   20 +++
>  curl/UnpackedTarball_curl.mk |   32 
>  curl/curl-7.26.0_mingw.patch |2 -
>  curl/curl-7.26.0_win.patch   |   20 ++-
>  curl/prj/d.lst   |   18 -
>  ooo.lst.in   |2 -
>  tail_build/prj/build.lst |2 -
>  15 files changed, 182 insertions(+), 23 deletions(-)
> 
> New commits:
> commit 0f075129c95f7aee782bf08b2edbe7c71db1c7b2
> Author: Peter Foley 
> Date:   Mon Oct 29 10:50:32 2012 -0400
> 
> convert curl to gbuild

make dev-install failed here due to this. Now I pushed
fd443f82bc7b59e97e9a49c54fe72ec18517d627 to get it working, but
ucpcmis1.uno.so and libucpftp1.so still links to libcurl.so.4 instead of
libcurl.so, you probably want to fix that. :-)

Miklos
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: scp2/source

[Libreoffice Gerrit user]

 scp2/source/ooo/file_library_ooo.scp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fd443f82bc7b59e97e9a49c54fe72ec18517d627
Author: Miklos Vajna 
Date:   Tue Oct 30 09:31:20 2012 +0100

scp2: adapt to curl gbuildification

Change-Id: I51cd4e315f99099b9ee62761f404dbb640bc3106

diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index d1c8b48..48fab43 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -186,7 +186,7 @@ File gid_File_Lib_Curl
 #ifdef MACOSX
Name = STRING(CONCAT2(libcurl.4,UNXSUFFIX));
 #else
-   Name = STRING(CONCAT3(libcurl,UNXSUFFIX,.4));
+   Name = STRING(CONCAT2(libcurl,UNXSUFFIX));
 #endif
   #else
#ifdef _gcc3
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: version 3.6.3RC2 installation on Windows

[Andras Timar]

10/29/2012 12:44 PM keltezéssel, Michael Meeks írta:
> 
> On Thu, 2012-10-25 at 15:24 +0200, Joop Kiefte wrote:
>> I suppose it is because both use GTK, and LibreOffice has to touch GTK files.
> 
>   We don't use gtk+ on windows at all; though we had some problems around
> MSI / packing related to erroneously having gtk+ enabled for windows
> build in the recent past that may be related.
> 
>   Any ideas Andras ? :-)

I could not reproduce it. I could install LibreOffice while GVim was
running.

The packaging issue was different, the gtk+ feature was empty on
Windows, it did not install anything, just displayed the feature name in
the tree.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Register for the Hackfest in Munich

[Florian Effenberger]

Hello,

soon, we will have the LibreOffice Hackfest in the city of Munich, from 
November 23 to 25.


In order to help us with planning, please don't forget to register for 
participation in our wiki at


http://wiki.documentfoundation.org/Hackfest/Munich2012#Participants

Looking forward to meeting you in Munich!

Florian

--
Florian Effenberger, Chairman of the Board (Vorstandsvorsitzender)
Tel: +49 8341 99660880 | Mobile: +49 151 14424108
The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Gemeinnützige rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

How do I prepare and upload spell check dictionaries for biodiversity in South Africa?

[Leslie Powrie]

I have prepared spell check dictionaries for use in MS Office for South African 
botanical (48011 names), zoological (30884), and physical feature (107428) 
names.

I see that, although Office 2007 and later handle these in a single .dic file 
(although I have separated them into three files (SANBI_Spell_Bot.dic, 
SANBI_Spell_Zoo.dic, SANBI_Spell_Phys.dic), it seems as though LibreOffice has 
a limit on dic file size. In Word 2003 I had to limit the file size and so had 
four files (ae_precis.dic, fl_precis.dic, lp_precis.dic, qz_precis.dic).

It seems as though LibreOffice probably has a similar limit. It appears as 
though the limit may be 3 names.

But another problem is with accented characters. Many of our place names have 
ö, ô, é and so forth. So although the dictionary has the name Aasvoëlkranskloof
In it,
[cid:image002.png@01CDADEC.437F8490]
the encoding means that it does not recognise the name. It seems as though the 
dictionary might need to be UTF-8, or Unicode, but cannot make out which. I 
tried creating a dictionary in LibreOffice and it seems as though it is a UTF-8 
file, but I think I tried it yesterday and it was Unisys. It seems as though 
the standard.dic is ANSI.

What do you suggest for getting the spell checkers ready? Will you guide me in 
preparing .dic files, or is the extension .oxt the way to go?

I downloaded the technical.dic, and it appears to be ANSI, although it did not 
open in NotePad with the line breaks. I opened in in Excel, then copied it to 
technical.dic in NotePad, closed it in Excel, then closed it in NotePad and now 
it has the line breaks. But is there a reason that it was saved like that? I am 
also intrigued by what appear to be synonyms LibreOffice=
OpenOffice.org=
OpenDocument=
AppArmor

Is this something I need to consider?

Once ready, how do I upload them?

Kind regards

Les

--
Les Powrie MSc (Mr.)
Deputy Director: Information Technology Advisory Services
Applied Biodiversity Research Directorate (and National Vegetation Map 
Committee)
South African National Biodiversity Institute
Kirstenbosch Research Centre, office B28
Private Bag X7, Claremont, 7735
Phone: +27 21 799 8600 (switchboard), +27 21 799 8703 (direct)
Fax: +27 86 555 9367, Mobile: 084 707 6297 (try landline first during office 
hours)
E-mail: l.pow...@sanbi.org.za
[cid:image001.png@01CDADEA.00A44310]
URL: http://www.sanbi.org
http://www.plantzafrica.com




Please visit our website www.sanbi.org for more information about the South 
African National Biodiversity Institute .

Think before you print. Please consider the environment before printing this 
email.

NOTE: This e-mail message and any attachments are intended for the addressee 
only, and contain confidential information that may be legally privileged 
and/or the subject of copyright that is protected by law. Any unauthorised 
usage, disclosure, alteration or dissemination is prohibited. SANBI accepts no 
responsibility for loss, data corruption or mail that fails to reach its 
intended destination. Furthermore, SANBI cannot assure the integrity of this 
communication nor guarantee that it is free of errors, viruses, interception or 
interference. No liability, whether direct or indirect, is accepted by SANBI or 
the sender. Any view or opinion expressed in this message may not necessarily 
be that of SANBI or SANBI Management. SANBI reserves the right to monitor all 
e-mail communication.

The disclaimer is located at http://www.sanbi.org/node/5672
<><>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice