date:20121206

 cppunit/ExternalProject_cppunit.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b66e034904c7d5b0aa60170240deebc84811aa16
Author: Stephan Bergmann 
Date:   Fri Dec 7 08:15:58 2012 +0100

cppunit is PLAINLIBS_NONE

Change-Id: Id6401999d20069f17133a765195cd49b50ff532f

diff --git a/cppunit/ExternalProject_cppunit.mk 
b/cppunit/ExternalProject_cppunit.mk
index b52bb4e..b5abe41 100644
--- a/cppunit/ExternalProject_cppunit.mk
+++ b/cppunit/ExternalProject_cppunit.mk
@@ -44,7 +44,7 @@ $(call gb_ExternalProject_get_state_target,cppunit,build) :
--disable-html-docs \
--disable-latex-docs \
$(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)) \
-   $(if $(filter 
MACOSX,$(OS)),--prefix=/@.__OOO)
 \
+   $(if $(filter 
MACOSX,$(OS)),--prefix=/@.__NONE)
 \
$(if $(filter-out WNT,$(OS)),,CXXFLAGS="-mthreads" 
LDFLAGS="-Wl,--enable-runtime-pseudo-reloc-v2") \
$(if $(filter SOLARIS,$(OS)),LIBS="-lm") \
$(if $(filter ANDROID,$(OS)),LIBS="-lgnustl_shared -lm") \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 2 commits - cppunit/ExternalPackage_cppunit.mk RepositoryExternal.mk

 RepositoryExternal.mk  |2 +-
 cppunit/ExternalPackage_cppunit.mk |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 39a6e45bfd60db59321ecbfc406a942b346bb0ff
Author: Stephan Bergmann 
Date:   Fri Dec 7 08:11:16 2012 +0100

cppunit is PLAINLIBS_NONE

Change-Id: I98765698773f9b349d6aac200ee2e55c25e7a47a

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index f59c69a..e22d219 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -144,7 +144,7 @@ endef
 
 else
 
-$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO,\
+$(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE,\
 cppunit \
 ))
 
commit b5b316ad7f5f5b77abe1e9e2e93f6aee62d2373b
Author: Stephan Bergmann 
Date:   Fri Dec 7 08:10:48 2012 +0100

One more typo

Change-Id: Ie08b5ebf76f22a42c99729a284bf1931a7cf9bc9

diff --git a/cppunit/ExternalPackage_cppunit.mk 
b/cppunit/ExternalPackage_cppunit.mk
index dfcc659..4c430e8 100644
--- a/cppunit/ExternalPackage_cppunit.mk
+++ b/cppunit/ExternalPackage_cppunit.mk
@@ -23,7 +23,7 @@ endif
 else
 $(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/DllPlugInTester,src/DllPlugInTester/.libs/DllPlugInTester))
 ifeq ($(OS),MACOSX)
-$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/libcppunit-1.13.0.dylib,src/cppunit/.libs/libcppunit-1.13.0.dylib))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.0.dylib,src/cppunit/.libs/libcppunit-1.13.0.dylib))
 else ifeq ($(OS),AIX)
 $(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.a,src/cppunit/.libs/libcppunit-1.13.a))
 else ifeq ($(OS),OPENBSD)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 4 commits - cppunit/ExternalPackage_cppunit.mk xmlsecurity/Library_xsec_xmlsec.mk xmlsecurity/source xmlsecurity/util

 cppunit/ExternalPackage_cppunit.mk  |2 
 xmlsecurity/Library_xsec_xmlsec.mk  |1 
 xmlsecurity/source/helper/xmlsignaturehelper.cxx|1 
 xmlsecurity/source/xmlsec/serialnumberadapter.cxx   |   99 
 xmlsecurity/source/xmlsec/serialnumberadapter.hxx   |   49 +
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx |3 
 xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx |6 
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx  |3 
 xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx  |6 
 xmlsecurity/source/xmlsec/xsec_xmlsec.cxx   |   70 +---
 xmlsecurity/util/xsec_xmlsec.component  |2 
 xmlsecurity/util/xsec_xmlsec.windows.component  |2 
 12 files changed, 175 insertions(+), 69 deletions(-)

New commits:
commit 6f067655b316f3e06bad8f786d31369e1174ea23
Author: Stephan Bergmann 
Date:   Fri Dec 7 07:53:15 2012 +0100

Typo

Change-Id: Iff8315535293613423199aaffeac904e721928bf

diff --git a/cppunit/ExternalPackage_cppunit.mk 
b/cppunit/ExternalPackage_cppunit.mk
index 3d8ab3f..dfcc659 100644
--- a/cppunit/ExternalPackage_cppunit.mk
+++ b/cppunit/ExternalPackage_cppunit.mk
@@ -23,7 +23,7 @@ endif
 else
 $(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/DllPlugInTester,src/DllPlugInTester/.libs/DllPlugInTester))
 ifeq ($(OS),MACOSX)
-$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/libcppunit-1.13.0.dylib,src/cppunit/.libs/libcppunit-1.1.3.0.dylib))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/libcppunit-1.13.0.dylib,src/cppunit/.libs/libcppunit-1.13.0.dylib))
 else ifeq ($(OS),AIX)
 $(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.a,src/cppunit/.libs/libcppunit-1.13.a))
 else ifeq ($(OS),OPENBSD)
commit 973a16f9e6a6da4f975413af253265618d1b0b67
Author: Stephan Bergmann 
Date:   Thu Dec 6 23:40:13 2012 +0100

Adapt to XComponentContext

Change-Id: I2f2c745245722f90b8101995367c55878d568703

diff --git a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx 
b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
index c09d112..fbbb16a 100644
--- a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
+++ b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.cxx
@@ -19,7 +19,6 @@
 
 
 #include "xmldocumentwrapper_xmlsecimpl.hxx"
-#include 
 
 #include 
 #include "xmlelementwrapper_xmlsecimpl.hxx"
@@ -1076,7 +1075,7 @@ cssu::Sequence< rtl::OUString > SAL_CALL 
XMLDocumentWrapper_XmlSecImpl_getSuppor
 #undef SERVICE_NAME
 
 cssu::Reference< cssu::XInterface > SAL_CALL 
XMLDocumentWrapper_XmlSecImpl_createInstance(
-const cssu::Reference< cssl::XMultiServiceFactory > &)
+const cssu::Reference< cssu::XComponentContext > &)
 throw( cssu::Exception )
 {
 return (cppu::OWeakObject*) new XMLDocumentWrapper_XmlSecImpl( );
diff --git a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx 
b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx
index c519107..1394fa6 100644
--- a/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx
+++ b/xmlsecurity/source/xmlsec/xmldocumentwrapper_xmlsecimpl.hxx
@@ -34,6 +34,10 @@
 
 #include 
 
+namespace com { namespace sun { namespace star { namespace uno {
+class XComponentContext;
+} } } }
+
 class XMLDocumentWrapper_XmlSecImpl : public cppu::WeakImplHelper4
 <
 com::sun::star::xml::wrapper::XXMLDocumentWrapper,
@@ -262,7 +266,7 @@ com::sun::star::uno::Sequence< rtl::OUString > SAL_CALL
 
 com::sun::star::uno::Reference< com::sun::star::uno::XInterface >
 SAL_CALL XMLDocumentWrapper_XmlSecImpl_createInstance(
-const com::sun::star::uno::Reference< 
com::sun::star::lang::XMultiServiceFactory > & rSMgr)
+const com::sun::star::uno::Reference< 
com::sun::star::uno::XComponentContext > &)
 throw ( com::sun::star::uno::Exception );
 
 #endif
diff --git a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx 
b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
index 57c90a6..d0363b3 100644
--- a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
+++ b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx
@@ -23,7 +23,6 @@
 #include 
 
 namespace cssu = com::sun::star::uno;
-namespace cssl = com::sun::star::lang;
 
 #define SERVICE_NAME "com.sun.star.xml.wrapper.XMLElementWrapper"
 #define IMPLEMENTATION_NAME 
"com.sun.star.xml.security.bridge.xmlsec.XMLElementWrapper_XmlSecImpl"
@@ -95,7 +94,7 @@ cssu::Sequence< rtl::OUString > SAL_CALL 
XMLElementWrapper_XmlSecImpl_getSupport
 
 cssu::Reference< cssu::XInterface > SAL_CALL
 XMLElementWrapper_XmlSecImpl_createInstance(
-const cssu::Reference< cssl::XMultiServiceFactory > &)
+const cssu::Reference< cssu::XComponentContext > &)
 throw( cssu::Exception )
 {
 return (cppu::OWeakObject*) new XMLElementWrapper_XmlSecImpl(NULL);
diff --git a/xmlsecur

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Eugene Kin  changed:

   What|Removed |Added

 CC||eugene.kinya...@gmail.com

--- Comment #400 from Eugene Kin  ---
Nominate https://bugs.freedesktop.org/show_bug.cgi?id=37814 (FILESAVE Save/Save
As dialogs use last save folder (not original) with non-ascii path)
Really annoying issue causing documents loss.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - oox/source

 oox/source/drawingml/chart/titlecontext.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 4ec7c5e494a09863bdd3f347a205323859ee7bae
Author: Kohei Yoshida 
Date:   Thu Dec 6 23:30:42 2012 -0500

bnc#792528: Play it safe for non-Excel documents.

Excel is not the only one that use charts. Let's also store the static
label value to maData in case it is used for non-Excel documents.

Change-Id: I1faed76e2ff396873039bccb3e1b7dcf27aba8c6

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index ea42cb8..7067ef5 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -69,10 +69,13 @@ void TextContext::onCharacters( const OUString& rChars )
 {
 if( isCurrentElement( C_TOKEN( v ) ) )
 {
-// Static text is stored as a single string formula token.
+// Static text is stored as a single string formula token for Excel 
document.
 OUStringBuffer aBuf;
 aBuf.append('"').append(rChars).append('"');
 mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+
+// Also store it as a single element type for non-Excel document.
+mrModel.mxDataSeq->maData[0] <<= rChars;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - oox/source

 oox/source/drawingml/chart/titlecontext.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit efee17ce9ce538cffac38651a290ead1a832dbe0
Author: Kohei Yoshida 
Date:   Thu Dec 6 23:30:42 2012 -0500

bnc#792528: Play it safe for non-Excel documents.

Excel is not the only one that use charts. Let's also store the static
label value to maData in case it is used for non-Excel documents.

Change-Id: I1faed76e2ff396873039bccb3e1b7dcf27aba8c6

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index 4b921da..1fcb3cc 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -79,10 +79,13 @@ void TextContext::onCharacters( const OUString& rChars )
 {
 if( isCurrentElement( C_TOKEN( v ) ) )
 {
-// Static text is stored as a single string formula token.
+// Static text is stored as a single string formula token for Excel 
document.
 OUStringBuffer aBuf;
 aBuf.append('"').append(rChars).append('"');
 mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+
+// Also store it as a single element type for non-Excel document.
+mrModel.mxDataSeq->maData[0] <<= rChars;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: oox/source

 oox/source/drawingml/chart/titlecontext.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit f0b22ccfdd94e557b4c3db5e0aea570341d8830c
Author: Kohei Yoshida 
Date:   Thu Dec 6 23:30:42 2012 -0500

bnc#792528: Play it safe for non-Excel documents.

Excel is not the only one that use charts. Let's also store the static
label value to maData in case it is used for non-Excel documents.

Change-Id: I1faed76e2ff396873039bccb3e1b7dcf27aba8c6

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index ea42cb8..7067ef5 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -69,10 +69,13 @@ void TextContext::onCharacters( const OUString& rChars )
 {
 if( isCurrentElement( C_TOKEN( v ) ) )
 {
-// Static text is stored as a single string formula token.
+// Static text is stored as a single string formula token for Excel 
document.
 OUStringBuffer aBuf;
 aBuf.append('"').append(rChars).append('"');
 mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+
+// Also store it as a single element type for non-Excel document.
+mrModel.mxDataSeq->maData[0] <<= rChars;
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - oox/source sc/source

 oox/source/drawingml/chart/titlecontext.cxx |   10 ++-
 sc/source/core/tool/reftokenhelper.cxx  |   91 
 sc/source/ui/unoobj/chart2uno.cxx   |1 
 3 files changed, 48 insertions(+), 54 deletions(-)

New commits:
commit 65dad3684c609e89b92714e51c914e9b1afa16a3
Author: Kohei Yoshida 
Date:   Thu Dec 6 14:36:50 2012 -0500

bnc#792528: Import static data series labels from xlsx correctly.

Static data series label is a data series label whose value is a
string value rather than a cell reference.

Also, when inputting static string label in the UI, we don't have
to manually check for quotes; the formula compiler will take care
of that later.

Change-Id: I1657fc9879a7f652bba84898e308c3a5d5ba87a3

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index 100235d..4b921da 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -33,6 +33,8 @@
 #include "oox/drawingml/chart/datasourcecontext.hxx"
 #include "oox/drawingml/chart/titlemodel.hxx"
 
+#include "rtl/ustrbuf.hxx"
+
 namespace oox {
 namespace drawingml {
 namespace chart {
@@ -75,9 +77,13 @@ ContextHandlerRef TextContext::onCreateContext( sal_Int32 
nElement, const Attrib
 
 void TextContext::onCharacters( const OUString& rChars )
 {
-// store as single string sequence element
 if( isCurrentElement( C_TOKEN( v ) ) )
-mrModel.mxDataSeq.create().maData[ 0 ] <<= rChars;
+{
+// Static text is stored as a single string formula token.
+OUStringBuffer aBuf;
+aBuf.append('"').append(rChars).append('"');
+mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+}
 }
 
 // 
diff --git a/sc/source/core/tool/reftokenhelper.cxx 
b/sc/source/core/tool/reftokenhelper.cxx
index 2a32e12..1508df7 100644
--- a/sc/source/core/tool/reftokenhelper.cxx
+++ b/sc/source/core/tool/reftokenhelper.cxx
@@ -44,25 +44,11 @@ using ::std::vector;
 using ::std::auto_ptr;
 using ::rtl::OUString;
 
-static bool lcl_mayBeRangeConstString( const OUString &aRangeStr )
-{
-if( aRangeStr.getLength() >= 3 && aRangeStr.endsWithAsciiL( "\"", 1 ) )
-{
-if( aRangeStr[0] == '"' )
-return true;
-else if( aRangeStr[0] == '=' && aRangeStr[1] == '"' )
-return true;
-}
-
-return false;
-}
-
 void ScRefTokenHelper::compileRangeRepresentation(
 vector& rRefTokens, const OUString& rRangeStr, ScDocument* 
pDoc,
 const sal_Unicode cSep, FormulaGrammar::Grammar eGrammar)
 {
 const sal_Unicode cQuote = '\'';
-bool bMayBeConstString = lcl_mayBeRangeConstString( rRangeStr );
 
 // #i107275# ignore parentheses
 OUString aRangeStr = rRangeStr;
@@ -88,48 +74,49 @@ void ScRefTokenHelper::compileRangeRepresentation(
 if (!nLen)
 continue;   // Should a missing range really be allowed?
 if (nLen != 1)
+{
 bFailure = true;
-else
+break;
+}
+
+pArray->Reset();
+const FormulaToken* p = pArray->Next();
+if (!p)
 {
-pArray->Reset();
-const FormulaToken* p = pArray->Next();
-if (!p)
+bFailure = true;
+break;
+}
+
+const ScToken* pT = static_cast(p);
+switch (pT->GetType())
+{
+case svSingleRef:
+if (!pT->GetSingleRef().Valid())
+bFailure = true;
+break;
+case svDoubleRef:
+if (!pT->GetDoubleRef().Valid())
+bFailure = true;
+break;
+case svExternalSingleRef:
+if (!pT->GetSingleRef().ValidExternal())
+bFailure = true;
+break;
+case svExternalDoubleRef:
+if (!pT->GetDoubleRef().ValidExternal())
+bFailure = true;
+break;
+case svString:
+if (!pT->GetString().Len())
+bFailure = true;
+break;
+default:
 bFailure = true;
-else
-{
-const ScToken* pT = static_cast(p);
-switch (pT->GetType())
-{
-case svSingleRef:
-if (!pT->GetSingleRef().Valid())
-bFailure = true;
-break;
-case svDoubleRef:
-if (!pT->GetDoubleRef().Valid())
-bFailure = true;
-break;
-case svExternalSingleRef:
-if (!pT->GetSingleRef().ValidExternal())
-bFailure = true;
-break;

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - oox/source sc/source

 oox/source/drawingml/chart/titlecontext.cxx |   10 ++-
 sc/source/core/tool/reftokenhelper.cxx  |   91 
 sc/source/ui/unoobj/chart2uno.cxx   |1 
 3 files changed, 48 insertions(+), 54 deletions(-)

New commits:
commit 6cf3d295d8955058dc1128ecf46b09d88926a0db
Author: Kohei Yoshida 
Date:   Thu Dec 6 14:36:50 2012 -0500

bnc#792528: Import static data series labels from xlsx correctly.

Static data series label is a data series label whose value is a
string value rather than a cell reference.

Also, when inputting static string label in the UI, we don't have
to manually check for quotes; the formula compiler will take care
of that later.

Change-Id: I1657fc9879a7f652bba84898e308c3a5d5ba87a3

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index c05532f..ea42cb8 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -24,6 +24,8 @@
 #include "oox/drawingml/chart/datasourcecontext.hxx"
 #include "oox/drawingml/chart/titlemodel.hxx"
 
+#include "rtl/ustrbuf.hxx"
+
 namespace oox {
 namespace drawingml {
 namespace chart {
@@ -65,9 +67,13 @@ ContextHandlerRef TextContext::onCreateContext( sal_Int32 
nElement, const Attrib
 
 void TextContext::onCharacters( const OUString& rChars )
 {
-// store as single string sequence element
 if( isCurrentElement( C_TOKEN( v ) ) )
-mrModel.mxDataSeq.create().maData[ 0 ] <<= rChars;
+{
+// Static text is stored as a single string formula token.
+OUStringBuffer aBuf;
+aBuf.append('"').append(rChars).append('"');
+mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+}
 }
 
 // 
diff --git a/sc/source/core/tool/reftokenhelper.cxx 
b/sc/source/core/tool/reftokenhelper.cxx
index 92002f4..b59d140 100644
--- a/sc/source/core/tool/reftokenhelper.cxx
+++ b/sc/source/core/tool/reftokenhelper.cxx
@@ -33,25 +33,11 @@ using ::std::vector;
 using ::std::auto_ptr;
 using ::rtl::OUString;
 
-static bool lcl_mayBeRangeConstString( const OUString &aRangeStr )
-{
-if( aRangeStr.getLength() >= 3 && aRangeStr.endsWithAsciiL( "\"", 1 ) )
-{
-if( aRangeStr[0] == '"' )
-return true;
-else if( aRangeStr[0] == '=' && aRangeStr[1] == '"' )
-return true;
-}
-
-return false;
-}
-
 void ScRefTokenHelper::compileRangeRepresentation(
 vector& rRefTokens, const OUString& rRangeStr, ScDocument* 
pDoc,
 const sal_Unicode cSep, FormulaGrammar::Grammar eGrammar)
 {
 const sal_Unicode cQuote = '\'';
-bool bMayBeConstString = lcl_mayBeRangeConstString( rRangeStr );
 
 // #i107275# ignore parentheses
 OUString aRangeStr = rRangeStr;
@@ -77,48 +63,49 @@ void ScRefTokenHelper::compileRangeRepresentation(
 if (!nLen)
 continue;   // Should a missing range really be allowed?
 if (nLen != 1)
+{
 bFailure = true;
-else
+break;
+}
+
+pArray->Reset();
+const FormulaToken* p = pArray->Next();
+if (!p)
 {
-pArray->Reset();
-const FormulaToken* p = pArray->Next();
-if (!p)
+bFailure = true;
+break;
+}
+
+const ScToken* pT = static_cast(p);
+switch (pT->GetType())
+{
+case svSingleRef:
+if (!pT->GetSingleRef().Valid())
+bFailure = true;
+break;
+case svDoubleRef:
+if (!pT->GetDoubleRef().Valid())
+bFailure = true;
+break;
+case svExternalSingleRef:
+if (!pT->GetSingleRef().ValidExternal())
+bFailure = true;
+break;
+case svExternalDoubleRef:
+if (!pT->GetDoubleRef().ValidExternal())
+bFailure = true;
+break;
+case svString:
+if (!pT->GetString().Len())
+bFailure = true;
+break;
+default:
 bFailure = true;
-else
-{
-const ScToken* pT = static_cast(p);
-switch (pT->GetType())
-{
-case svSingleRef:
-if (!pT->GetSingleRef().Valid())
-bFailure = true;
-break;
-case svDoubleRef:
-if (!pT->GetDoubleRef().Valid())
-bFailure = true;
-break;
-case svExternalSingleRef:
-if (!pT->GetSingleRef().ValidExternal())
-bFailure = true;
-break;

[Libreoffice-commits] .: oox/source sc/source

 oox/source/drawingml/chart/titlecontext.cxx |   10 ++-
 sc/source/core/tool/reftokenhelper.cxx  |   91 
 sc/source/ui/unoobj/chart2uno.cxx   |1 
 3 files changed, 48 insertions(+), 54 deletions(-)

New commits:
commit 3a5c3dc392f451f9718ef2fe2076d41bdd9b87ee
Author: Kohei Yoshida 
Date:   Thu Dec 6 14:36:50 2012 -0500

bnc#792528: Import static data series labels from xlsx correctly.

Static data series label is a data series label whose value is a
string value rather than a cell reference.

Also, when inputting static string label in the UI, we don't have
to manually check for quotes; the formula compiler will take care
of that later.

Change-Id: I1657fc9879a7f652bba84898e308c3a5d5ba87a3

diff --git a/oox/source/drawingml/chart/titlecontext.cxx 
b/oox/source/drawingml/chart/titlecontext.cxx
index c05532f..ea42cb8 100644
--- a/oox/source/drawingml/chart/titlecontext.cxx
+++ b/oox/source/drawingml/chart/titlecontext.cxx
@@ -24,6 +24,8 @@
 #include "oox/drawingml/chart/datasourcecontext.hxx"
 #include "oox/drawingml/chart/titlemodel.hxx"
 
+#include "rtl/ustrbuf.hxx"
+
 namespace oox {
 namespace drawingml {
 namespace chart {
@@ -65,9 +67,13 @@ ContextHandlerRef TextContext::onCreateContext( sal_Int32 
nElement, const Attrib
 
 void TextContext::onCharacters( const OUString& rChars )
 {
-// store as single string sequence element
 if( isCurrentElement( C_TOKEN( v ) ) )
-mrModel.mxDataSeq.create().maData[ 0 ] <<= rChars;
+{
+// Static text is stored as a single string formula token.
+OUStringBuffer aBuf;
+aBuf.append('"').append(rChars).append('"');
+mrModel.mxDataSeq.create().maFormula = aBuf.makeStringAndClear();
+}
 }
 
 // 
diff --git a/sc/source/core/tool/reftokenhelper.cxx 
b/sc/source/core/tool/reftokenhelper.cxx
index 92002f4..b59d140 100644
--- a/sc/source/core/tool/reftokenhelper.cxx
+++ b/sc/source/core/tool/reftokenhelper.cxx
@@ -33,25 +33,11 @@ using ::std::vector;
 using ::std::auto_ptr;
 using ::rtl::OUString;
 
-static bool lcl_mayBeRangeConstString( const OUString &aRangeStr )
-{
-if( aRangeStr.getLength() >= 3 && aRangeStr.endsWithAsciiL( "\"", 1 ) )
-{
-if( aRangeStr[0] == '"' )
-return true;
-else if( aRangeStr[0] == '=' && aRangeStr[1] == '"' )
-return true;
-}
-
-return false;
-}
-
 void ScRefTokenHelper::compileRangeRepresentation(
 vector& rRefTokens, const OUString& rRangeStr, ScDocument* 
pDoc,
 const sal_Unicode cSep, FormulaGrammar::Grammar eGrammar)
 {
 const sal_Unicode cQuote = '\'';
-bool bMayBeConstString = lcl_mayBeRangeConstString( rRangeStr );
 
 // #i107275# ignore parentheses
 OUString aRangeStr = rRangeStr;
@@ -77,48 +63,49 @@ void ScRefTokenHelper::compileRangeRepresentation(
 if (!nLen)
 continue;   // Should a missing range really be allowed?
 if (nLen != 1)
+{
 bFailure = true;
-else
+break;
+}
+
+pArray->Reset();
+const FormulaToken* p = pArray->Next();
+if (!p)
 {
-pArray->Reset();
-const FormulaToken* p = pArray->Next();
-if (!p)
+bFailure = true;
+break;
+}
+
+const ScToken* pT = static_cast(p);
+switch (pT->GetType())
+{
+case svSingleRef:
+if (!pT->GetSingleRef().Valid())
+bFailure = true;
+break;
+case svDoubleRef:
+if (!pT->GetDoubleRef().Valid())
+bFailure = true;
+break;
+case svExternalSingleRef:
+if (!pT->GetSingleRef().ValidExternal())
+bFailure = true;
+break;
+case svExternalDoubleRef:
+if (!pT->GetDoubleRef().ValidExternal())
+bFailure = true;
+break;
+case svString:
+if (!pT->GetString().Len())
+bFailure = true;
+break;
+default:
 bFailure = true;
-else
-{
-const ScToken* pT = static_cast(p);
-switch (pT->GetType())
-{
-case svSingleRef:
-if (!pT->GetSingleRef().Valid())
-bFailure = true;
-break;
-case svDoubleRef:
-if (!pT->GetDoubleRef().Valid())
-bFailure = true;
-break;
-case svExternalSingleRef:
-if (!pT->GetSingleRef().ValidExternal())
-bFailure = true;
-break;

[PATCH] performance tuning of helpex

2012-12-06 Thread Norbert Thiebaud (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1262

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/62/1262/1

performance tuning of helpex

callgrind (on text/swriter/guide translated in 'fr')

before Ir = 889,687,925
after Ir = 406,372,177 (405,668,292 w/o the 'native' memory allocator)

time confirms:
before 0.288/0.272/0.016
after  0.146/0.131/0.015

the output before and after were diff-ed and every generated xhp files
are identical.

All improvements where done still using 'normal' sal and c++ API.

There are still some low-hanging fruits, like XMLUtil:QuoteHTML
(probably 20-30 millions Ir to shave there)

The destruction of XMLElements is also singularly high
(11% of the remaining Ir count)

But the bulk of what is left is OString management (alloc/acquire/release/
free/copy), and I/O using streams

Change-Id: Ia316c953cd4bd46fc33a58a0c10f26b0ffa042c2
---
M l10ntools/inc/xmlparse.hxx
M l10ntools/source/common.hxx
M l10ntools/source/helpex.cxx
M l10ntools/source/helpmerge.cxx
M l10ntools/source/merge.cxx
M l10ntools/source/po.cxx
M l10ntools/source/xmlparse.cxx
7 files changed, 657 insertions(+), 287 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1262
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia316c953cd4bd46fc33a58a0c10f26b0ffa042c2
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: download.lst

 download.lst |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9c46411ebd5ba696347dc9025c3b045f65f74205
Author: Markus Mohrhard 
Date:   Fri Dec 7 04:04:06 2012 +0100

also with cppunit_dll.vcxproj

diff --git a/download.lst b/download.lst
index 2336ede..bbca618 100644
--- a/download.lst
+++ b/download.lst
@@ -15,7 +15,7 @@ export BSH_TARBALL := 
ea570af93c284aa9e5621cd563f54f4d-bsh-2.0b1-src.tar.gz
 export CAIRO_TARBALL := f101a9e88b783337b20b2e26dfd26d5f-cairo-1.10.2.tar.gz
 export CLUCENE_TARBALL := 
48d647fbd8ef8889e5a7f422c1bfda94-clucene-core-2.3.3.4.tar.gz
 export CMIS_TARBALL := b2371dc7cf4811c9d32146eec913d296-libcmis-0.3.0.tar.gz
-export CPPUNIT_TARBALL := 
b91b66bb05eb7f754917086f7f5241a2-cppunit-1.13.1.tar.gz
+export CPPUNIT_TARBALL := 
ac4781e01619be13461bb2d562b94a7b-cppunit-1.13.1.tar.gz
 export CT2N_TARBALL := 
451ccf439a36a568653b024534669971-ConvertTextToNumber-1.3.2.oxt
 export CURL_TARBALL := 3fa4d5236f2a36ca5c3af6715e837691-curl-7.26.0.tar.gz
 export EPM_TARBALL := 3ade8cfe7e59ca8e65052644fed9fca4-epm-3.7.tar.gz
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] ::rtl:: prefixes removal in oox

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1261

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/1261/1

::rtl:: prefixes removal in oox

This commit removes some ::rtl:: prefixes and some macros in OOX

Change-Id: I0c5ad9805ec2e8ed1092c56fe32e6901fdbd2b67
Signed-off-by: José Guilherme Vanz 
---
M oox/source/drawingml/color.cxx
M oox/source/drawingml/connectorshapecontext.cxx
M oox/source/drawingml/customshapegeometry.cxx
M oox/source/drawingml/customshapepresets1.cxx
M oox/source/drawingml/customshapepresets2.cxx
M oox/source/drawingml/customshapepresets3.cxx
M oox/source/drawingml/customshapepresets4.cxx
M oox/source/drawingml/customshapepresets5.cxx
M oox/source/drawingml/customshapepresets6.cxx
M oox/source/drawingml/customshapeproperties.cxx
M oox/source/drawingml/drawingmltypes.cxx
M oox/source/drawingml/effectpropertiescontext.cxx
M oox/source/drawingml/embeddedwavaudiofile.cxx
M oox/source/drawingml/fillproperties.cxx
M oox/source/drawingml/fillpropertiesgroupcontext.cxx
M oox/source/drawingml/graphicshapecontext.cxx
M oox/source/drawingml/guidcontext.cxx
M oox/source/drawingml/hyperlinkcontext.cxx
M oox/source/drawingml/lineproperties.cxx
M oox/source/drawingml/linepropertiescontext.cxx
M oox/source/drawingml/objectdefaultcontext.cxx
M oox/source/drawingml/scene3dcontext.cxx
M oox/source/drawingml/shape.cxx
M oox/source/drawingml/shape3dproperties.cxx
M oox/source/drawingml/shapecontext.cxx
M oox/source/drawingml/shapegroupcontext.cxx
M oox/source/drawingml/shapepropertiescontext.cxx
M oox/source/drawingml/shapepropertymap.cxx
M oox/source/drawingml/shapestylecontext.cxx
M oox/source/drawingml/spdefcontext.cxx
M oox/source/drawingml/textbody.cxx
M oox/source/drawingml/textbodycontext.cxx
M oox/source/drawingml/textbodypropertiescontext.cxx
M oox/source/drawingml/textcharacterproperties.cxx
M oox/source/drawingml/textcharacterpropertiescontext.cxx
M oox/source/drawingml/textfield.cxx
M oox/source/drawingml/textfieldcontext.cxx
M oox/source/drawingml/textfont.cxx
M oox/source/drawingml/textliststylecontext.cxx
M oox/source/drawingml/textparagraph.cxx
M oox/source/drawingml/textparagraphproperties.cxx
M oox/source/drawingml/textparagraphpropertiescontext.cxx
M oox/source/drawingml/textrun.cxx
M oox/source/drawingml/texttabstoplistcontext.cxx
M oox/source/drawingml/theme.cxx
M oox/source/drawingml/themeelementscontext.cxx
M oox/source/drawingml/themefragmenthandler.cxx
47 files changed, 213 insertions(+), 265 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1261
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c5ad9805ec2e8ed1092c56fe32e6901fdbd2b67
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] ::rtl:: prefixes removal

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1260

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/1260/1

::rtl:: prefixes removal

This commit removes some ::rtl:: prefixes on oox

Change-Id: Iae9a89f8a869934b6273a1b97c0a9243b0504fb3
Signed-off-by: José Guilherme Vanz 
---
M oox/source/drawingml/table/tablebackgroundstylecontext.cxx
M oox/source/drawingml/table/tablecell.cxx
M oox/source/drawingml/table/tablecellcontext.cxx
M oox/source/drawingml/table/tablecontext.cxx
M oox/source/drawingml/table/tablepartstylecontext.cxx
M oox/source/drawingml/table/tableproperties.cxx
M oox/source/drawingml/table/tablerow.cxx
M oox/source/drawingml/table/tablerowcontext.cxx
M oox/source/drawingml/table/tablestylecellstylecontext.cxx
M oox/source/drawingml/table/tablestylecontext.cxx
M oox/source/drawingml/table/tablestylelistfragmenthandler.cxx
M oox/source/drawingml/table/tablestylepart.cxx
M oox/source/drawingml/table/tablestyletextstylecontext.cxx
13 files changed, 9 insertions(+), 24 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1260
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae9a89f8a869934b6273a1b97c0a9243b0504fb3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] ::rtl:: removal in oox

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1259

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1259/1

::rtl:: removal in oox

This commit removes some ::rtl:: prefixes on oox

Change-Id: Ibb3be70695c48eb0a02fdf285a0c049e244d613e
Signed-off-by: José Guilherme Vanz 
---
M oox/source/drawingml/diagram/constraintlistcontext.cxx
M oox/source/drawingml/diagram/datamodelcontext.cxx
M oox/source/drawingml/diagram/diagram.cxx
M oox/source/drawingml/diagram/diagram.hxx
M oox/source/drawingml/diagram/diagramdefinitioncontext.cxx
M oox/source/drawingml/diagram/diagramfragmenthandler.cxx
M oox/source/drawingml/diagram/diagramfragmenthandler.hxx
M oox/source/drawingml/diagram/diagramlayoutatoms.cxx
M oox/source/drawingml/diagram/diagramlayoutatoms.hxx
M oox/source/drawingml/diagram/layoutnodecontext.cxx
10 files changed, 72 insertions(+), 78 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1259
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb3be70695c48eb0a02fdf285a0c049e244d613e
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: José Guilherme Vanz 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

>
>
>  Is there any plan to make a wiki page or something about the event?
>>
>
> Sure. Examples from some of the earlier events:
>   
> http://wiki.**documentfoundation.org/QA/**BugHunting_Session_3.5.0.-1
>   
> http://wiki.**documentfoundation.org/QA/**BugHunting_Session_3.6.0


Want me to do this?


>
>
>  As always thanks to everyone from the developers to the organizers of
>> this event, it takes a lot of work to keep a project like this so alive
>> and thriving:)
>>
>
> Pleasure to read.
> Let's continue to make a success of it.
> I'll (try to) draft an announcement now and do the rest of the
> preparations tomorrow.
>

Just a note, I went through every unconfirmed bug against 4+ releases
(master & alpha) and was able to get a lot of them done. The ones that
remain are a bit trickier for the most part, takes a bit of the workload
off of us for next week although I'm sure that there will be new bugs
reported against 4 in the coming days.


Regards,
Joel


-- 
*Joel Madero*
LibO QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-06 Thread Cor Nouws


Hi Joel, all,

Joel Madero wrote (06-12-12 16:09)


I think that testing from Thursday 13 to Wednesday 19th is perfectly
fine and beta1 state looks promising for it.


OK, I'll go for the 14-19th - something in me says that's better.
I've checked and there is no real / important doubling with the Calendar.

http://www.libreoffice.org/about-us/libreoffice-international-events-calendar/
Coincidence: 14th there is a big OSCon in Amsterdam, from one of our 
larger sponsors. Maybe we can make some extra attention out of that.



Maybe we should announce this on the user list and there's a chance we
can get a few more volunteers for QA work??


Yes, that is one of the things to do.


Is there any plan to make a wiki page or something about the event?


Sure. Examples from some of the earlier events:
  http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1
  http://wiki.documentfoundation.org/QA/BugHunting_Session_3.6.0


As always thanks to everyone from the developers to the organizers of
this event, it takes a lot of work to keep a project like this so alive
and thriving:)


Pleasure to read.
Let's continue to make a success of it.
I'll (try to) draft an announcement now and do the rest of the 
preparations tomorrow.


Cheers,
Cor


--
 - Cor
 - http://nl.libreoffice.org
 - www.librelex.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sal/inc svl/source xmloff/source

 sal/inc/rtl/ustrbuf.hxx  |4 ++--
 svl/source/numbers/zformat.cxx   |   14 +++---
 xmloff/source/style/xmlnumfi.cxx |2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit 4cdda4670684f567287bc434af0c69fbddd54d26
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Thu Dec 6 18:48:15 2012 +0100

OUStringBuffer::remove( int ) -> truncate( int )

Although this may seem consistent with remove( int, int ), it is
in fact rather misleading API. The biggest offender is most probably
buffer.remove( 'a' ) , which definitely does not do what it suggests
to do.

Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Reviewed-on: https://gerrit.libreoffice.org/1256
Reviewed-by: Michael Stahl 
Tested-by: Norbert Thiebaud 
Reviewed-by: Norbert Thiebaud 

diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx
index b8f2d05..76b68dd 100644
--- a/sal/inc/rtl/ustrbuf.hxx
+++ b/sal/inc/rtl/ustrbuf.hxx
@@ -965,7 +965,7 @@ public:
 
 @since LibreOffice 4.0
  */
-OUStringBuffer & remove( sal_Int32 start = 0)
+OUStringBuffer & truncate( sal_Int32 start = 0 )
 {
 rtl_uStringbuffer_remove( &pData, start, getLength() - start );
 return *this;
@@ -1219,7 +1219,7 @@ public:
 }
 if(index < getLength())
 {
-remove(index);
+truncate(index);
 }
 return result - getLength();
 }
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 1d86c92..3f47265 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -2625,7 +2625,7 @@ bool SvNumberformat::ImpGetScientificOutput(double 
fNumber,
 break;
 }
 ExpStr = sStr.toString().copy( nExpStart );// part following the 
"E+"
-sStr.remove( nExPos );
+sStr.truncate( nExPos );
 // cut any decimal delimiter
 sal_Int32 index = 0;
 
@@ -2692,7 +2692,7 @@ bool SvNumberformat::ImpGetScientificOutput(double 
fNumber,
 // weiter Hauptzahl:
 if ( !bCont )
 {
-sStr.remove();
+sStr.truncate();
 }
 else
 {
@@ -2739,7 +2739,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 if (rInfo.nCntExp == 0)
 {
 SAL_WARN( "svl.numbers", "SvNumberformat:: Bruch, nCntExp == 0");
-sBuff.remove();
+sBuff.truncate();
 return false;
 }
 
@@ -2944,7 +2944,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 }
 if (rInfo.nCntPre > 0 && nFrac == 0)
 {
-sDiv.remove();
+sDiv.truncate();
 }
 else
 {
@@ -2980,7 +2980,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 // weiter Zaehler:
 if ( !bCont )
 {
-sFrac.remove();
+sFrac.truncate();
 }
 else
 {
@@ -3001,7 +3001,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 // weiter Hauptzahl
 if ( !bCont )
 {
-sStr.remove();
+sStr.truncate();
 }
 else
 {
@@ -4376,7 +4376,7 @@ bool SvNumberformat::ImpGetNumberOutput(double fNumber,
 sal_Int32 nLen = rDecSep.getLength();
 if ( sStr.getLength() > nLen && ( sStr.indexOf( rDecSep, 
sStr.getLength() - nLen) == sStr.getLength() - nLen) )
 {
-sStr.remove( sStr.getLength() - nLen );// no decimals => 
strip DecSep
+sStr.truncate( sStr.getLength() - nLen );// no decimals => 
strip DecSep
 }
 }
 if (bSign)
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index d53e004..28a4ec6 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -906,7 +906,7 @@ static void lcl_EnquoteIfNecessary( rtl::OUStringBuffer& 
rContent, const SvXMLNu
  rContent[nLen - 1] == (sal_Unicode) '"' &&
  rContent[nLen - 2] == (sal_Unicode) '"' )
 {
-rContent.remove(nLen - 2);
+rContent.truncate(nLen - 2);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: configure.ac

 configure.ac |  340 ++-
 1 file changed, 174 insertions(+), 166 deletions(-)

New commits:
commit 987d991ecd25b295f9694920b84823f148e6c8b5
Author: Peter Foley 
Date:   Thu Dec 6 17:27:27 2012 -0500

formating cleanup

Change-Id: I851f4f82caa8483a296da3c8337ccbedccf7c5de

diff --git a/configure.ac b/configure.ac
index 149ebbb..add8364 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2823,12 +2823,12 @@ dnl 
===
 
 reg_get_value()
 {
-   unset regvalue
-   _regvalue=`cat "/proc/registry/$1" 2> /dev/null`
+unset regvalue
+_regvalue=`cat "/proc/registry/$1" 2> /dev/null`
 
-   if test $? -eq 0; then
-   regvalue=$_regvalue
-   fi
+if test $? -eq 0; then
+regvalue=$_regvalue
+fi
 }
 
 
@@ -3032,36 +3032,38 @@ AC_SUBST(HAVE_LD_BSYMBOLIC_FUNCTIONS)
 dnl ===
 dnl  Check which Microsoft C/C++ or MinGW compiler is used for WINNT
 dnl ===
-find_msvs() {
-# find Visual Studio 2012/2010/2008
-for ver in 11.0 10.0 9.0; do
-   reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VisualStudio/$ver/Setup/VS/ProductDir
-   if test -n "$regvalue"; then
-   vstest=$regvalue
-   break
-   fi
-   reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress/$ver/Setup/VS/ProductDir
-   if test -n "$regvalue"; then
-   vstest=$regvalue
-   break
-   fi
-done
+find_msvs()
+{
+# find Visual Studio 2012/2010/2008
+for ver in 11.0 10.0 9.0; do
+reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VisualStudio/$ver/Setup/VS/ProductDir
+if test -n "$regvalue"; then
+vstest=$regvalue
+break
+fi
+reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress/$ver/Setup/VS/ProductDir
+if test -n "$regvalue"; then
+vstest=$regvalue
+break
+fi
+done
 }
 
-find_msvc() {
-# find Visual Studio 2012/2010/2008
-for ver in 11.0 10.0 9.0; do
-   reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VisualStudio/$ver/Setup/VC/ProductDir
-   if test -n "$regvalue"; then
-   vctest=$regvalue
-   break
-   fi
-   reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress/$ver/Setup/VC/ProductDir
-   if test -n "$regvalue"; then
-   vctest=$regvalue
-   break
-   fi
-done
+find_msvc()
+{
+# find Visual Studio 2012/2010/2008
+for ver in 11.0 10.0 9.0; do
+reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VisualStudio/$ver/Setup/VC/ProductDir
+if test -n "$regvalue"; then
+vctest=$regvalue
+break
+fi
+reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/VCExpress/$ver/Setup/VC/ProductDir
+if test -n "$regvalue"; then
+vctest=$regvalue
+break
+fi
+done
 }
 
 SHOWINCLUDES_PREFIX=
@@ -3069,7 +3071,7 @@ if test "$_os" = "WINNT"; then
 if test "$WITH_MINGW" != "yes"; then
 AC_MSG_CHECKING([for a friendly Microsoft C/C++ compiler installation 
path])
 if test -z "$with_cl_home"; then
-   find_msvc
+find_msvc
 if test "$BITNESS_OVERRIDE" = ""; then
 if test -x "$vctest/bin/cl.exe"; then
 with_cl_home=$vctest
@@ -4731,145 +4733,151 @@ dnl that to mean Visual Studio .NET 2003 ? And does 
this also
 dnl in fact apply equally to what we actually support, i.e.
 dnl Visual Studio 2008 and 2010?)
 dnl ===
-find_csc() {
-if test $VCVER -eq 90; then
-   reg_get_value "HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/NET Framework 
Setup/NDP/v3.5/InstallPath"
-   if test -n "$regvalue"; then
-   csctest=$regvalue
-   return
-   fi
-   reg_get_value 
HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/.NETFramework/InstallRoot
-   if test -n "$regvalue"; then
-   csctest=${regvalue}"v2.0.50727"
-   fi
-else
-   reg_get_value "HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/NET Framework 
Setup/NDP/v4/Client/InstallPath"
-   if test -n "$regvalue"; then
-   csctest=$regvalue
-   break
-   fi
-fi
+find_csc()
+{
+if test $VCVER -eq 90; then
+reg_get_value "HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/NET Framework 
Setup/NDP/v3.5/InstallPath"
+if test -n "$regvalue"; then
+csctest=$regvalue
+

Re: About numbertext

Hi,

Many thanks for your help. Best regards, László

PS. I have published the source distribution, too:
http://numbertext.org/dist/numbertext-0.9.5.tar.gz.


2012/12/6 Andras Timar 

> Hi,
>
> On Thu, Dec 6, 2012 at 4:30 PM, Németh László 
> wrote:
> > Hi,
> >
> > Final release:
> >
> http://numbertext.org/dist/b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext-0.9.5.oxt
> >
>
> I pushed the changes to master and libreoffice-4-0.
>
> Best regards,
> Andras
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

aufeng audio与您共享了照片

2012-12-06 Thread aufeng audio


Hello,sir

Aufeng audio factory mainly produce high quality  microphone, mixers,  
speakers. we have own brand" AUFENG brand, we also produce some high  
quality  for shure, yamaha and allen ...
attached is our some factory prices, if you are interest, please contact  
with us soonest


brent Su
Aufeng Audio manufactory co.ltd
www.aufeng-audio.com
no.103-108,huanan industrial area,jiangmen city, guangdong
province,china
Tel: 008613652910766   +8615118708051
Email: sa...@aufeng-audio.com
<>___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Add "document chooser" and "quit" to DocumentLoader in andro...

2012-12-06 Thread Naser Sharifi (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1258

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1258/1

Add "document chooser" and "quit" to DocumentLoader in android/experimental

Both features have been added to the DocumentLoader menu.
By "document chooser", files are selected from the device SDCard.
This enhances the current state in which a single document (hard-coded in
the android application assets/ directory) is loaded.
The "quit" feature is just a menu item that exits the running DocumentLoader 
activity.
Changes were built (under Fedora17-i686) and tested (on Samsung GS3, 
Android-4.0)

Change-Id: I4d0e192b9fc7a3c5751f007cf99a9991bd70e719
---
M android/experimental/DocumentLoader/AndroidManifest.xml
A android/experimental/DocumentLoader/res/drawable-mdpi/file.png
A android/experimental/DocumentLoader/res/drawable-mdpi/fileopen.png
A android/experimental/DocumentLoader/res/drawable-mdpi/folder.png
A android/experimental/DocumentLoader/res/layout/select_document.xml
M android/experimental/DocumentLoader/res/menu/option.xml
M android/experimental/DocumentLoader/res/values/string.xml
A 
android/experimental/DocumentLoader/src/org/libreoffice/android/SelectDocumentAdapter.java
M 
android/experimental/DocumentLoader/src/org/libreoffice/android/examples/DocumentLoader.java
A 
android/experimental/DocumentLoader/src/org/libreoffice/android/examples/SelectDocumentActivity.java
10 files changed, 180 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1258
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d0e192b9fc7a3c5751f007cf99a9991bd70e719
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Naser Sharifi 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Building LibreOffice for Android

2012-12-06 Thread Naser Sharifi

Hi Tor, All,

Firstly, Thank you for the response and the useful pointers.

What we really need is more people who are able to build the code and
> work on improving it (especially the Android-specific Java layer)
> themselves. You need to be running Linux or Mac OS X as Windows is not
> suited for building LibreOffice for Android. Clone our "core" git
> repository and learn how to build LibreOffice for your native platform
> first. And then build for Android: Read README.cross and
> README.Android. Join our development IRC channel and ask for advice;
> best during European working hours and evenings.
>
> I just submitted a patch (https://gerrit.libreoffice.org/1258) with just
a little feature. I noticed that there is a lot to do both in terms of
improving the current code and adding features/functionality. I am very
eager to continue working on it. While I explore the LibreOffice
infrastructure and code base, things become clearer to me and I will
hopefully contribute something substantial eventually. Meanwhile, I would
appreciate if there is anything (android-wise) I should be aware while I
explore the code base particularly.

Thanks,
Naser
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012-12-06 Thread Andras Timar

Hi,

On Thu, Dec 6, 2012 at 4:30 PM, Németh László  wrote:
> Hi,
>
> Final release:
> http://numbertext.org/dist/b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext-0.9.5.oxt
>

I pushed the changes to master and libreoffice-4-0.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - config_host.mk.in configure.ac distro-configs/OxygenOfficeLinux.conf distro-configs/OxygenOfficeWin32.conf extras/Package_extensions.mk

 Makefile.fetch   |3 --
 config_host.mk.in|1 
 configure.ac |   23 ---
 distro-configs/OxygenOfficeLinux.conf|1 
 distro-configs/OxygenOfficeWin32.conf|1 
 extras/Package_extensions.mk |3 --
 scp2/source/extensions/directory_extensions.scp  |   11 -
 scp2/source/extensions/file_extensions.scp   |   13 --
 scp2/source/extensions/module_extensions.scp |   15 
 scp2/source/extensions/module_extensions.ulf |6 
 setup_native/source/packinfo/packinfo_extensions.txt |   15 
 11 files changed, 2 insertions(+), 90 deletions(-)

New commits:
commit b8edade716c60d9d614f773da519ec1a7739a332
Author: Andras Timar 
Date:   Thu Dec 6 22:07:53 2012 +0100

Numbertext 0.9.5 (Python 3 fixes)

Change-Id: Ic5d8f8a975861c63354d28f5043abb5ead29192b

diff --git a/Makefile.fetch b/Makefile.fetch
index 12f3750..0cc0e32 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -142,6 +142,7 @@ $(WORKDIR)/download: $(SRCDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)/M
$(call fetch_Optional,MYTHES,$(MYTHES_TARBALL)) \
$(call fetch_Optional,NEON,$(NEON_TARBALL)) \
$(call fetch_Optional,NSS,$(NSS_TARBALL)) \
+   $(NUMBERTEXT_EXTENSION_PACK) \
$(call fetch_Optional,OPENLDAP,$(OPENLDAP_TARBALL)) \
$(call fetch_Optional,OPENSSL,$(OPENSSL_TARBALL)) \
$(call fetch_Optional,ORCUS,$(ORCUS_TARBALL)) \
@@ -172,7 +173,6 @@ $(WORKDIR)/download: $(SRCDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)/M
$(BARCODE_EXTENSION_PACK) \
$(DIAGRAM_EXTENSION_PACK) \
$(HUNART_EXTENSION_PACK) \
-   $(NUMBERTEXT_EXTENSION_PACK) \
$(OOOP_FONTS_PACK) \
$(OOOP_GALLERY_PACK) \
$(OOOP_SAMPLES_PACK) \
diff --git a/configure.ac b/configure.ac
index da662b6..b8b38a7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10713,7 +10713,7 @@ AC_MSG_CHECKING([for Numbertext extension integration])
 NUMBERTEXT_EXTENSION_PACK=
 if test "x$enable_ext_numbertext" = "xyes" -a "x$enable_extension_integration" 
!= "xno"; then
 SCPDEFS="$SCPDEFS -DWITH_EXTENSION_NUMBERTEXT"
-
NUMBERTEXT_EXTENSION_PACK="b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt"
+
NUMBERTEXT_EXTENSION_PACK="b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt"
 WITH_EXTRA_EXTENSIONS=YES
 AC_MSG_RESULT([yes])
 else
commit d4d50693cf3f58ae04180443331b0b102179c509
Author: Noel Grandin 
Date:   Thu Dec 6 11:12:46 2012 +0200

Bug 57917 - --enable-ext-oooblogger does not work with Python 3

Remove the oooblogger extension. It is unmaintained and the original
author (caolan) wants it dead.

Change-Id: Iff89f5badbb74f465c57e068a9e1acbbc13bc235

diff --git a/Makefile.fetch b/Makefile.fetch
index 455ab99..12f3750 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -173,7 +173,6 @@ $(WORKDIR)/download: $(SRCDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)/M
$(DIAGRAM_EXTENSION_PACK) \
$(HUNART_EXTENSION_PACK) \
$(NUMBERTEXT_EXTENSION_PACK) \
-   $(OOOBLOGGER_EXTENSION_PACK) \
$(OOOP_FONTS_PACK) \
$(OOOP_GALLERY_PACK) \
$(OOOP_SAMPLES_PACK) \
diff --git a/config_host.mk.in b/config_host.mk.in
index 0397212..04b1575 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -408,7 +408,6 @@ export NUMBERTEXT_EXTENSION_PACK=@NUMBERTEXT_EXTENSION_PACK@
 @x_OBJCFLAGS@ export OBJCFLAGS=@OBJCFLAGS@
 @x_OBJCXXFLAGS@ export OBJCXXFLAGS=@OBJCXXFLAGS@
 export OBJDUMP=@OBJDUMP@
-export OOOBLOGGER_EXTENSION_PACK=@OOOBLOGGER_EXTENSION_PACK@
 export OOODMAKEMODE=YES
 export OOOP_FONTS_PACK=@OOOP_FONTS_PACK@
 export OOOP_GALLERY_PACK=@OOOP_GALLERY_PACK@
diff --git a/configure.ac b/configure.ac
index 9af58c7..da662b6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -618,11 +618,6 @@ AC_ARG_ENABLE(ext-numbertext,
 [Enable the Numbertext extension.])
 )
 
-AC_ARG_ENABLE(ext-oooblogger,
-AS_HELP_STRING([--enable-ext-oooblogger],
-[Enable the OOo Blogger extension.])
-)
-
 AC_ARG_ENABLE(ext-presenter-minimizer,
 AS_HELP_STRING([--disable-ext-presenter-minimizer],
 [Disable the Presentation Minimizer extension.])
@@ -10796,22 +10791,6 @@ else
 fi
 
 dnl ===
-dnl Test whether to include oooblogger extension
-dnl ===
-AC_MSG_CHECKING([for oooblogger extension integration])
-OOOBLOGGER_EXTENSION_PACK=
-if test "x$enable_ext_oooblogger" = "xyes" -a "x$enable_extension_integration" 
!= "xno"; then
-SCPDEFS="$SCPDEFS -DWITH_EXTENS

[Libreoffice-commits] .: configure.ac Makefile.fetch

 Makefile.fetch |2 +-
 configure.ac   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 56da3f2a9fbf9e8787c8bc14d171fc77eb53d876
Author: Andras Timar 
Date:   Thu Dec 6 22:07:53 2012 +0100

Numbertext 0.9.5 (Python 3 fixes)

Change-Id: Ic5d8f8a975861c63354d28f5043abb5ead29192b

diff --git a/Makefile.fetch b/Makefile.fetch
index 12f3750..0cc0e32 100644
--- a/Makefile.fetch
+++ b/Makefile.fetch
@@ -142,6 +142,7 @@ $(WORKDIR)/download: $(SRCDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)/M
$(call fetch_Optional,MYTHES,$(MYTHES_TARBALL)) \
$(call fetch_Optional,NEON,$(NEON_TARBALL)) \
$(call fetch_Optional,NSS,$(NSS_TARBALL)) \
+   $(NUMBERTEXT_EXTENSION_PACK) \
$(call fetch_Optional,OPENLDAP,$(OPENLDAP_TARBALL)) \
$(call fetch_Optional,OPENSSL,$(OPENSSL_TARBALL)) \
$(call fetch_Optional,ORCUS,$(ORCUS_TARBALL)) \
@@ -172,7 +173,6 @@ $(WORKDIR)/download: $(SRCDIR)/config_host.mk 
$(SRCDIR)/download.lst $(SRCDIR)/M
$(BARCODE_EXTENSION_PACK) \
$(DIAGRAM_EXTENSION_PACK) \
$(HUNART_EXTENSION_PACK) \
-   $(NUMBERTEXT_EXTENSION_PACK) \
$(OOOP_FONTS_PACK) \
$(OOOP_GALLERY_PACK) \
$(OOOP_SAMPLES_PACK) \
diff --git a/configure.ac b/configure.ac
index 1e80d4f..149ebbb 100644
--- a/configure.ac
+++ b/configure.ac
@@ -10909,7 +10909,7 @@ AC_MSG_CHECKING([for Numbertext extension integration])
 NUMBERTEXT_EXTENSION_PACK=
 if test "x$enable_ext_numbertext" = "xyes" -a "x$enable_extension_integration" 
!= "xno"; then
 SCPDEFS="$SCPDEFS -DWITH_EXTENSION_NUMBERTEXT"
-
NUMBERTEXT_EXTENSION_PACK="b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt"
+
NUMBERTEXT_EXTENSION_PACK="b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext_0.9.5.oxt"
 WITH_EXTRA_EXTENSIONS=YES
 AC_MSG_RESULT([yes])
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [API] Some more cleanup ideas

2012-12-06 Thread Thorsten Behrens

Lubos Lunak wrote:
> > -   rtl::OUString
> > +   OUString
> 
>  You cannot compare these with exception specifications. The examples above, 
> barring very corner cases, are only about readability and nothing else, while 
> exception specifications are not. Arguing that we should remove exception 
> specifications is more like arguing that we should remove all asserts.
> 
While I'm not standing in the way of keeping them, I still consider
them useless in 99% of all cases (quite in contrast to asserts).
That might be coloured by personal experience, frequency of finding
bugs with it (~zero), and the general unspecificity (or should I 
say, thoughtlessness) of their use throughout the API.

For large parts of UNO, making one not violate the exception
specification, would look like this:

 try {
   
 } catch(...) {
   throw uno::RuntimeException("Arrgh! General $FOO error!!1!");
 }

That is not what I would call error handling.

Mixing ivory-tower musing about ES usefulness & hand-waving
arguments about developers paying attention to their
self-documenting presence, and the real, actual benefits they bring
(or don't bring) to our UNO API implementation is at least not
getting us the ideal solution. ;)

My 2 cents,

-- Thorsten


pgp6pgOc2V7xV.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Current Master Version?

On Thu, Dec 6, 2012 at 12:42 PM, Norbert Thiebaud wrote:

> On Thu, Dec 6, 2012 at 2:15 PM, Joel Madero  wrote:
> > Hi All,
> >
> > Is current master 4.1.0.0.alpha...? I was surprised after my build today
> > that I saw 4.1 vs. 4.0just curious. Thanks all
>
> we branched 4.0 ... so now master is for vnext : 4.1
>

That explains it. Now I'm debating if I should be triaging with 4.1 or
not...

Regards,
Joel

>
> Norbert
>



-- 
*Joel Madero*
LibO QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] OUStringBuffer::remove( int ) -> truncate( int )

2012-12-06 Thread Norbert Thiebaud (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1256

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved
  Michael Stahl: Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1256
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luboš Luňák 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Current Master Version?

2012-12-06 Thread Norbert Thiebaud

On Thu, Dec 6, 2012 at 2:15 PM, Joel Madero  wrote:
> Hi All,
>
> Is current master 4.1.0.0.alpha...? I was surprised after my build today
> that I saw 4.1 vs. 4.0just curious. Thanks all

we branched 4.0 ... so now master is for vnext : 4.1

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sal/inc svl/source xmloff/source

 sal/inc/rtl/ustrbuf.hxx  |4 ++--
 svl/source/numbers/zformat.cxx   |   14 +++---
 xmloff/source/style/xmlnumfi.cxx |2 +-
 3 files changed, 10 insertions(+), 10 deletions(-)

New commits:
commit eafb82821386e4c14f4a072e4b541dc60f4d7af2
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Thu Dec 6 18:48:15 2012 +0100

OUStringBuffer::remove( int ) -> truncate( int )

Although this may seem consistent with remove( int, int ), it is
in fact rather misleading API. The biggest offender is most probably
buffer.remove( 'a' ) , which definitely does not do what it suggests
to do.

Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Reviewed-on: https://gerrit.libreoffice.org/1256
Reviewed-by: Michael Stahl 
Tested-by: Norbert Thiebaud 
Reviewed-by: Norbert Thiebaud 

diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx
index c5c6f5d..1397a18 100644
--- a/sal/inc/rtl/ustrbuf.hxx
+++ b/sal/inc/rtl/ustrbuf.hxx
@@ -986,7 +986,7 @@ public:
 
 @since LibreOffice 4.0
  */
-OUStringBuffer & remove( sal_Int32 start = 0)
+OUStringBuffer & truncate( sal_Int32 start = 0 )
 {
 rtl_uStringbuffer_remove( &pData, start, getLength() - start );
 return *this;
@@ -1240,7 +1240,7 @@ public:
 }
 if(index < getLength())
 {
-remove(index);
+truncate(index);
 }
 return result - getLength();
 }
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index 1d86c92..3f47265 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -2625,7 +2625,7 @@ bool SvNumberformat::ImpGetScientificOutput(double 
fNumber,
 break;
 }
 ExpStr = sStr.toString().copy( nExpStart );// part following the 
"E+"
-sStr.remove( nExPos );
+sStr.truncate( nExPos );
 // cut any decimal delimiter
 sal_Int32 index = 0;
 
@@ -2692,7 +2692,7 @@ bool SvNumberformat::ImpGetScientificOutput(double 
fNumber,
 // weiter Hauptzahl:
 if ( !bCont )
 {
-sStr.remove();
+sStr.truncate();
 }
 else
 {
@@ -2739,7 +2739,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 if (rInfo.nCntExp == 0)
 {
 SAL_WARN( "svl.numbers", "SvNumberformat:: Bruch, nCntExp == 0");
-sBuff.remove();
+sBuff.truncate();
 return false;
 }
 
@@ -2944,7 +2944,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 }
 if (rInfo.nCntPre > 0 && nFrac == 0)
 {
-sDiv.remove();
+sDiv.truncate();
 }
 else
 {
@@ -2980,7 +2980,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 // weiter Zaehler:
 if ( !bCont )
 {
-sFrac.remove();
+sFrac.truncate();
 }
 else
 {
@@ -3001,7 +3001,7 @@ bool SvNumberformat::ImpGetFractionOutput(double fNumber,
 // weiter Hauptzahl
 if ( !bCont )
 {
-sStr.remove();
+sStr.truncate();
 }
 else
 {
@@ -4376,7 +4376,7 @@ bool SvNumberformat::ImpGetNumberOutput(double fNumber,
 sal_Int32 nLen = rDecSep.getLength();
 if ( sStr.getLength() > nLen && ( sStr.indexOf( rDecSep, 
sStr.getLength() - nLen) == sStr.getLength() - nLen) )
 {
-sStr.remove( sStr.getLength() - nLen );// no decimals => 
strip DecSep
+sStr.truncate( sStr.getLength() - nLen );// no decimals => 
strip DecSep
 }
 }
 if (bSign)
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index d53e004..28a4ec6 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -906,7 +906,7 @@ static void lcl_EnquoteIfNecessary( rtl::OUStringBuffer& 
rContent, const SvXMLNu
  rContent[nLen - 1] == (sal_Unicode) '"' &&
  rContent[nLen - 2] == (sal_Unicode) '"' )
 {
-rContent.remove(nLen - 2);
+rContent.truncate(nLen - 2);
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Current Master Version?

Hi All,

Is current master 4.1.0.0.alpha...? I was surprised after my build today
that I saw 4.1 vs. 4.0just curious. Thanks all


Regards,
Joel

-- 
*Joel Madero*
LibO QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-3-6]: fdo#57927: Clarify msi installer only installs subset of dic...

2012-12-06 Thread Andras Timar (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1254

Approvals:
  Andras Timar: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1254
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann 
Gerrit-Reviewer: Andras Timar 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - starmath/source

 starmath/source/document.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2e682ba972f193cf22c7103c5bafb83ee0efc65b
Author: CaolÃ¡n McNamara 
Date:   Thu Dec 6 20:10:19 2012 +

SID_SAVE_ONLY_USED_SYMBOLS missing from starmath print options itemset

Change-Id: I91a39db4d967009ca8fa5ee2fe910a660a556fd2
(cherry picked from commit cf543d8a78170f4fa3c2ca340f21e61d913a90eb)

Signed-off-by: CaolÃ¡n McNamara 

diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index 6dc19f5..632ce0e 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -614,6 +614,7 @@ Printer* SmDocShell::GetPrt()
SID_PRINTTEXT,   SID_PRINTTEXT,
SID_PRINTFRAME,  SID_PRINTFRAME,
SID_NO_RIGHT_SPACES, SID_NO_RIGHT_SPACES,
+   SID_SAVE_ONLY_USED_SYMBOLS, 
SID_SAVE_ONLY_USED_SYMBOLS,
0);
 
 SmModule *pp = SM_MOD();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: starmath/source

 starmath/source/document.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit cf543d8a78170f4fa3c2ca340f21e61d913a90eb
Author: CaolÃ¡n McNamara 
Date:   Thu Dec 6 20:10:19 2012 +

SID_SAVE_ONLY_USED_SYMBOLS missing from starmath print options itemset

Change-Id: I91a39db4d967009ca8fa5ee2fe910a660a556fd2

diff --git a/starmath/source/document.cxx b/starmath/source/document.cxx
index 6dc19f5..632ce0e 100644
--- a/starmath/source/document.cxx
+++ b/starmath/source/document.cxx
@@ -614,6 +614,7 @@ Printer* SmDocShell::GetPrt()
SID_PRINTTEXT,   SID_PRINTTEXT,
SID_PRINTFRAME,  SID_PRINTFRAME,
SID_NO_RIGHT_SPACES, SID_NO_RIGHT_SPACES,
+   SID_SAVE_ONLY_USED_SYMBOLS, 
SID_SAVE_ONLY_USED_SYMBOLS,
0);
 
 SmModule *pp = SM_MOD();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - instsetoo_native/inc_openoffice

 instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a2876a7ff78f4d3d48c444ca285a7c1280018257
Author: Stephan Bergmann 
Date:   Thu Dec 6 16:54:07 2012 +0100

fdo#57927: Clarify msi installer only installs subset of dicts by default

...since this was changed with fdo#53009 in LO 3.6.3.

Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
(cherry picked from commit d35849b6f718990869b01209865bb70cb7343ceb)
Reviewed-on: https://gerrit.libreoffice.org/1254
Reviewed-by: Andras Timar 
Tested-by: Andras Timar 

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
index d240ff7..bd682f4 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
@@ -575,10 +575,10 @@ en-US = "< &Back"
 en-US = "Cancel"
 
 [OOO_CONTROL_255]
-en-US = "[ProductName] will be installed with the default components, 
including spelling dictionaries in all available languages."
+en-US = "[ProductName] will be installed with the default components, 
including user interface languages and spelling dictionaries matching your 
current language settings."
 
 [OOO_CONTROL_256]
-en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages or deselect unwanted dictionaries."
+en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages and spelling dictionaries."
 
 [OOO_CONTROL_257]
 en-US = "Choose the setup type that best suits your needs."
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: disabling built-in rules in makefile

2012-12-06 Thread Matúš Kukan

On 5 December 2012 05:58, David Tardon  wrote:

>> makes even bigger difference for me. Then it's the ~same as using make -r.
>
> It is not the same thing. The .SUFFIXES special rule only deletes
> defined (i.e., built-in) suffix rules, but it does not affect built-in
> pattern rules. The -r flag disables both.

I meant it's almost the same.
At least in my simple time measurements there was no visible difference.

pushed something in
https://gerrit.libreoffice.org/#/c/1257/

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] let's have plain 'make' without '-r' even faster

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1257

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/1257/1

let's have plain 'make' without '-r' even faster

Change-Id: I8338a6be0afbad456d1c5ca5d5a1b8a26ffca8ad
---
M solenv/gbuild/gbuild.mk
1 file changed, 2 insertions(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1257
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8338a6be0afbad456d1c5ca5d5a1b8a26ffca8ad
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 44446] LibreOffice 3.6 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=6

Bug 6 depends on bug 51976, which changed state.

Bug 51976 Summary: EDITING: Base embedded HSQLDB needs minutes for first "Go to 
last record in the Table"
https://bugs.freedesktop.org/show_bug.cgi?id=51976

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 53281, which changed state.

Bug 53281 Summary: A double-plus-more extremely slow search/browse table in 
embedded HSQLDB since 3.5.5/3.6.0.beta
https://bugs.freedesktop.org/show_bug.cgi?id=53281

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] OUStringBuffer::remove( int ) -> truncate( int )

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1256

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1256/1

OUStringBuffer::remove( int ) -> truncate( int )

Although this may seem consistent with remove( int, int ), it is
in fact rather misleading API. The biggest offender is most probably
buffer.remove( 'a' ) , which definitely does not do what it suggests
to do.

Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
---
M sal/inc/rtl/ustrbuf.hxx
M svl/source/numbers/zformat.cxx
M xmloff/source/style/xmlnumfi.cxx
3 files changed, 10 insertions(+), 10 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1256
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I287619cd4b953228b93fa68fb381d66c344c3865
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luboš Luňák 
Gerrit-Reviewer: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] -Werror,-Wtautological-constant-out-of-range-compare

2012-12-06 Thread Stephan Bergmann (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1255

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1255/1

-Werror,-Wtautological-constant-out-of-range-compare

...so assuming this was meant instead?

Change-Id: I1c9cf55e2a0ca9d725ce65d8f0a0748e4ca13886
---
M sw/source/ui/shells/txtattr.cxx
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://gerrit.libreoffice.org/1255
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c9cf55e2a0ca9d725ce65d8f0a0748e4ca13886
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Stephan Bergmann 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

 sc/source/ui/condformat/condformatdlg.cxx |4 +---
 sc/source/ui/condformat/condformatmgr.cxx |   11 +--
 sc/source/ui/dbgui/sortkeydlg.cxx |1 -
 sc/source/ui/inc/condformatdlg.hxx|4 
 sc/source/ui/inc/condformatmgr.hxx|5 ++---
 sc/source/ui/inc/sortkeydlg.hxx   |3 ---
 6 files changed, 8 insertions(+), 20 deletions(-)

New commits:
commit 4ee829af622a2932ffad8f9712e2563579746cf0
Author: Stephan Bergmann 
Date:   Thu Dec 6 18:15:33 2012 +0100

-Werror,-Wunused-private-field

Change-Id: I1866be3b7feb42f0b1a24bf214a1276b76f883b5

diff --git a/sc/source/ui/condformat/condformatdlg.cxx 
b/sc/source/ui/condformat/condformatdlg.cxx
index 3398188..6236432 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -368,9 +368,7 @@ ScCondFormatDlg::ScCondFormatDlg(Window* pParent, 
ScDocument* pDoc, const ScCond
 maCondFormList( this, ScResId( CTRL_LIST ), pDoc, pFormat, rRange, rPos, 
eType ),
 maPos(rPos),
 mpDoc(pDoc),
-mpFormat(pFormat),
-mpLastEdit(NULL),
-meType(eType)
+mpLastEdit(NULL)
 {
 rtl::OUStringBuffer aTitle( GetText() );
 aTitle.append(rtl::OUString(" "));
diff --git a/sc/source/ui/condformat/condformatmgr.cxx 
b/sc/source/ui/condformat/condformatmgr.cxx
index 5a5ea1b..af9e383 100644
--- a/sc/source/ui/condformat/condformatmgr.cxx
+++ b/sc/source/ui/condformat/condformatmgr.cxx
@@ -37,12 +37,11 @@
 #define ITEMID_CONDITION 2
 
 
-ScCondFormatManagerWindow::ScCondFormatManagerWindow(Window* pParent, 
ScDocument* pDoc, ScConditionalFormatList* pFormatList, const ScAddress& rPos):
+ScCondFormatManagerWindow::ScCondFormatManagerWindow(Window* pParent, 
ScDocument* pDoc, ScConditionalFormatList* pFormatList):
 SvTabListBox(pParent, WB_SORT | WB_HSCROLL | WB_CLIPCHILDREN | WB_TABSTOP),
 maHeaderBar( pParent, WB_BUTTONSTYLE | WB_BOTTOMBORDER ),
 mpDoc(pDoc),
-mpFormatList(pFormatList),
-mrPos(rPos)
+mpFormatList(pFormatList)
 {
 Size aBoxSize( pParent->GetOutputSizePixel() );
 
@@ -142,9 +141,9 @@ IMPL_LINK_NOARG(ScCondFormatManagerWindow, HeaderEndDragHdl)
 return 0;
 }
 
-ScCondFormatManagerCtrl::ScCondFormatManagerCtrl(Window* pParent, ScDocument* 
pDoc, ScConditionalFormatList* pFormatList, const ScAddress& rPos):
+ScCondFormatManagerCtrl::ScCondFormatManagerCtrl(Window* pParent, ScDocument* 
pDoc, ScConditionalFormatList* pFormatList):
 Control(pParent, ScResId(CTRL_TABLE)),
-maWdManager(this, pDoc, pFormatList, rPos)
+maWdManager(this, pDoc, pFormatList)
 {
 }
 
@@ -172,7 +171,7 @@ ScCondFormatManagerDlg::ScCondFormatManagerDlg(Window* 
pParent, ScDocument* pDoc
 maBtnCancel(this, ScResId(BTN_CANCEL)),
 maFlLine(this, ScResId(FL_LINE)),
 mpFormatList( pFormatList ? new ScConditionalFormatList(*pFormatList) : 
NULL),
-maCtrlManager(this, pDoc, mpFormatList, rPos),
+maCtrlManager(this, pDoc, mpFormatList),
 mpDoc(pDoc),
 maPos(rPos),
 mbModified(false)
diff --git a/sc/source/ui/dbgui/sortkeydlg.cxx 
b/sc/source/ui/dbgui/sortkeydlg.cxx
index 45d65ca..76a8747 100644
--- a/sc/source/ui/dbgui/sortkeydlg.cxx
+++ b/sc/source/ui/dbgui/sortkeydlg.cxx
@@ -109,7 +109,6 @@ ScSortKeyCtrl::ScSortKeyCtrl(SfxTabPage* pParent, 
ScSortKeyItems& rItems)
 : m_aSortWin(pParent, rItems)
 , m_rScrolledWindow(*pParent->get("SortCriteriaPage"))
 , m_rVertScroll(m_rScrolledWindow.getVertScrollBar())
-, nThumbPos(0)
 {
 m_rVertScroll.EnableDrag();
 m_rVertScroll.Show();
diff --git a/sc/source/ui/inc/condformatdlg.hxx 
b/sc/source/ui/inc/condformatdlg.hxx
index 588d04d..5541c49 100644
--- a/sc/source/ui/inc/condformatdlg.hxx
+++ b/sc/source/ui/inc/condformatdlg.hxx
@@ -112,12 +112,8 @@ private:
 ScAddress maPos;
 ScDocument* mpDoc;
 
-const ScConditionalFormat* mpFormat;
-
 formula::RefEdit* mpLastEdit;
 
-condformat::dialog::ScCondFormatDialogType meType;
-
 DECL_LINK( EdRangeModifyHdl, Edit* );
 protected:
 
diff --git a/sc/source/ui/inc/condformatmgr.hxx 
b/sc/source/ui/inc/condformatmgr.hxx
index c13ff6b..d3c9099 100644
--- a/sc/source/ui/inc/condformatmgr.hxx
+++ b/sc/source/ui/inc/condformatmgr.hxx
@@ -50,13 +50,12 @@ private:
 HeaderBar maHeaderBar;
 ScDocument* mpDoc;
 ScConditionalFormatList* mpFormatList;
-const ScAddress& mrPos;
 std::map maMapLBoxEntryToCondIndex;
 
 DECL_LINK( HeaderEndDragHdl, void* );
 
 public:
-ScCondFormatManagerWindow( Window* pParent, ScDocument* pDoc, 
ScConditionalFormatList* pFormatList, const ScAddress& rPos );
+ScCondFormatManagerWindow( Window* pParent, ScDocument* pDoc, 
ScConditionalFormatList* pFormatList );
 
 void DeleteSelection();
 ScConditionalFormat* GetSelection();
@@ -66,7 +65,7 @@ public:
 class ScCondFormatManagerCtrl : Control
 {
 public:
-ScCondFormatManagerCtrl(Window* pParent, ScDocument* pDoc, 
ScConditionalFormatList* pFormatList, const ScAddress&

[Libreoffice-commits] .: writerfilter/source

 writerfilter/source/dmapper/DomainMapper_Impl.cxx |1 -
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |1 -
 2 files changed, 2 deletions(-)

New commits:
commit 1fd91ad2c94e80ebbc121b1f3b6bc76ad2257500
Author: Stephan Bergmann 
Date:   Thu Dec 6 17:55:47 2012 +0100

-Werror,-Wunused-private-field

Change-Id: Ic4c805079529f13b6cabe78f0c7d33b76c0b7ce6

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 9381f73..3b8e2d8 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -163,7 +163,6 @@ DomainMapper_Impl::DomainMapper_Impl(
 m_xTextDocument( xModel, uno::UNO_QUERY ),
 m_xTextFactory( xModel, uno::UNO_QUERY ),
 m_xComponentContext( xContext ),
-m_bFieldMode( false ),
 m_bSetUserFieldContent( false ),
 m_bIsFirstSection( true ),
 m_bIsColumnBreakDeferred( false ),
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 5857455..311485f 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
@@ -302,7 +302,6 @@ private:
 TextContentStack   
 m_aAnchoredStack;
 
 FieldStack 
 m_aFieldStack;
-bool   
 m_bFieldMode;
 bool   
 m_bSetUserFieldContent;
 bool   
 m_bIsFirstSection;
 bool   
 m_bIsColumnBreakDeferred;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: svgio/source

 svgio/source/svgreader/svgtextpathnode.cxx |5 -
 1 file changed, 5 deletions(-)

New commits:
commit a1f85dd9db88c157d8943f7bf2a101bf8e281023
Author: Stephan Bergmann 
Date:   Thu Dec 6 17:32:45 2012 +0100

-Werror,-Wunused-private-field

Change-Id: Ifa4d44865873bfee8a95c5287e3d8b4f13fa534b

diff --git a/svgio/source/svgreader/svgtextpathnode.cxx 
b/svgio/source/svgreader/svgtextpathnode.cxx
index c06b6b7..4fb8e09 100644
--- a/svgio/source/svgreader/svgtextpathnode.cxx
+++ b/svgio/source/svgreader/svgtextpathnode.cxx
@@ -40,7 +40,6 @@ namespace svgio
 private:
 const basegfx::B2DPolygon&  mrPolygon;
 const doublemfBasegfxPathLength;
-const doublemfUserToBasegfx;
 double  mfPosition;
 const basegfx::B2DPoint&mrTextStart;
 
@@ -65,7 +64,6 @@ namespace svgio
 const drawinglayer::primitive2d::TextSimplePortionPrimitive2D& 
rSource,
 const basegfx::B2DPolygon& rPolygon,
 const double fBasegfxPathLength,
-const double fUserToBasegfx,
 double fPosition,
 const basegfx::B2DPoint& rTextStart);
 virtual ~pathTextBreakupHelper();
@@ -118,13 +116,11 @@ namespace svgio
 const drawinglayer::primitive2d::TextSimplePortionPrimitive2D& 
rSource,
 const basegfx::B2DPolygon& rPolygon,
 const double fBasegfxPathLength,
-const double fUserToBasegfx,
 double fPosition,
 const basegfx::B2DPoint& rTextStart)
 :   drawinglayer::primitive2d::TextBreakupHelper(rSource),
 mrPolygon(rPolygon),
 mfBasegfxPathLength(fBasegfxPathLength),
-mfUserToBasegfx(fUserToBasegfx),
 mfPosition(0.0),
 mrTextStart(rTextStart),
 mnMaxIndex(rPolygon.isClosed() ? rPolygon.count() : 
rPolygon.count() - 1),
@@ -462,7 +458,6 @@ namespace svgio
 *pCandidate,
 aPolygon,
 fBasegfxPathLength,
-fUserToBasegfx,
 fPosition,
 rTextStart);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Grammar checking] Using LanguageTool lexicons with Lightproof new possible

Hi Olivier,

Thanks, I have tested it, quite fast the dictionary lookup!

Best regards,
László



2012/12/6 Olivier R. 

> Hi László,
>
> In fsa_builder.py, in class DAWG, you can replace :
>
> self.minimizedNodes = collections.OrderedDict()
>
> by
>
> self.minimizedNodes = {}
>
> Creating the DAWG is much quicker with a simple dictionary than with an
> ordered dictionary.
> I only used the latest to test compression with a sorted DAWG, but it’s
> unuseful with this version of the script.
>
>
> Regards,
> Olivier
>
>
>
> --
> View this message in context:
> http://nabble.documentfoundation.org/Grammar-checking-Using-LanguageTool-lexicons-with-Lightproof-new-possible-tp4022489p4022817.html
> Sent from the Dev mailing list archive at Nabble.com.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: connectivity/source

 connectivity/source/drivers/evoab2/NStatement.cxx |2 --
 connectivity/source/drivers/evoab2/NStatement.hxx |4 
 2 files changed, 6 deletions(-)

New commits:
commit 24d7831da52dbb0fdc2f1aa2a5f25f3fa4477acf
Author: Stephan Bergmann 
Date:   Thu Dec 6 17:13:51 2012 +0100

-Werror,-Wunused-private-field

Change-Id: I1440856b2a54302f3d95ed1d915fb64523f0db3b

diff --git a/connectivity/source/drivers/evoab2/NStatement.cxx 
b/connectivity/source/drivers/evoab2/NStatement.cxx
index bd377e5..949a4e6 100644
--- a/connectivity/source/drivers/evoab2/NStatement.cxx
+++ b/connectivity/source/drivers/evoab2/NStatement.cxx
@@ -53,7 +53,6 @@ OCommonStatement::OCommonStatement(OEvoabConnection* 
_pConnection)
 , ::comphelper::OPropertyContainer(OCommonStatement_IBase::rBHelper)
 , OStatement_CBase( (::cppu::OWeakObject*)_pConnection, this )
 , m_xResultSet(NULL)
-, m_pResultSet(NULL)
 , m_pConnection(_pConnection)
 , m_aParser(_pConnection->getDriver().getComponentContext())
 , m_aSQLIterator( _pConnection, 
_pConnection->createCatalog()->getTables(), m_aParser, NULL )
@@ -66,7 +65,6 @@ OCommonStatement::OCommonStatement(OEvoabConnection* 
_pConnection)
 , m_nFetchDirection(FetchDirection::FORWARD)
 , m_nResultSetConcurrency(ResultSetConcurrency::UPDATABLE)
 , m_bEscapeProcessing(sal_True)
-, rBHelper(OCommonStatement_IBase::rBHelper)
 {
 m_pConnection->acquire();
 
diff --git a/connectivity/source/drivers/evoab2/NStatement.hxx 
b/connectivity/source/drivers/evoab2/NStatement.hxx
index 2036199..187b1fd 100644
--- a/connectivity/source/drivers/evoab2/NStatement.hxx
+++ b/connectivity/source/drivers/evoab2/NStatement.hxx
@@ -47,7 +47,6 @@ namespace connectivity
 {
 namespace evoab
 {
-class OEvoabResultSet;
 class OEvoabConnection;
 typedef ::cppu::WeakComponentImplHelper2<   
::com::sun::star::sdbc::XWarningsSupplier
 ,   
::com::sun::star::sdbc::XCloseable
@@ -148,7 +147,6 @@ namespace connectivity
 
 private:
 ::com::sun::star::uno::WeakReference< 
::com::sun::star::sdbc::XResultSet>m_xResultSet;   // The last ResultSet 
created
-OEvoabResultSet  *m_pResultSet;
 OEvoabConnection *m_pConnection;
 connectivity::OSQLParser  m_aParser;
 connectivity::OSQLParseTreeIterator   m_aSQLIterator;
@@ -166,8 +164,6 @@ namespace connectivity
 sal_Boolm_bEscapeProcessing;
 // 
 
-::cppu::OBroadcastHelper& rBHelper;
-
 protected:
 
 void disposeResultSet();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Change in core[libreoffice-3-6]: fdo#57927: Clarify msi installer only installs subset of dic...

2012-12-06 Thread Stephan Bergmann (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1254

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1254/1

fdo#57927: Clarify msi installer only installs subset of dicts by default

...since this was changed with fdo#53009 in LO 3.6.3.

Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
(cherry picked from commit d35849b6f718990869b01209865bb70cb7343ceb)
---
M instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
1 file changed, 2 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1254
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] userfriendly make targets for build and clean

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1253

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1253/1

userfriendly make targets for build and clean

So that now it's possible to do just
'make CppunitTest_sw_macros_test'
instead of
'make 
/home/llunak/build/src/l2/workdir/unxlngx6/CppunitTest/sw_macros_test.test'

Change-Id: Ibd1e9ef4fc825043a71bd669b2f5c37ffec68e33
---
M solenv/gbuild/AllLangResTarget.mk
M solenv/gbuild/AllLangZip.mk
M solenv/gbuild/CliLibrary.mk
M solenv/gbuild/CliNativeLibrary.mk
M solenv/gbuild/CliUnoApi.mk
M solenv/gbuild/Configuration.mk
M solenv/gbuild/CppunitTest.mk
M solenv/gbuild/CustomTarget.mk
M solenv/gbuild/Dictionary.mk
M solenv/gbuild/Executable.mk
M solenv/gbuild/Extension.mk
M solenv/gbuild/ExternalPackage.mk
M solenv/gbuild/ExternalProject.mk
M solenv/gbuild/Helper.mk
M solenv/gbuild/InstallModule.mk
M solenv/gbuild/InstallScript.mk
M solenv/gbuild/InternalUnoApi.mk
M solenv/gbuild/Jar.mk
M solenv/gbuild/JunitTest.mk
M solenv/gbuild/Library.mk
M solenv/gbuild/Package.mk
M solenv/gbuild/Pagein.mk
M solenv/gbuild/Pyuno.mk
M solenv/gbuild/Rdb.mk
M solenv/gbuild/StaticLibrary.mk
M solenv/gbuild/UI.mk
M solenv/gbuild/UnoApi.mk
M solenv/gbuild/UnoApiMerge.mk
M solenv/gbuild/UnpackedTarball.mk
M solenv/gbuild/WinResTarget.mk
M solenv/gbuild/Zip.mk
31 files changed, 42 insertions(+), 0 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1253
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd1e9ef4fc825043a71bd669b2f5c37ffec68e33
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Luboš Luňák 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - instsetoo_native/inc_openoffice

 instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a0f70009e805ebc37493fb3afefb443b64fa4108
Author: Stephan Bergmann 
Date:   Thu Dec 6 16:54:07 2012 +0100

fdo#57927: Clarify msi installer only installs subset of dicts by default

...since this was changed with fdo#53009 in LO 3.6.3.

Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227
(cherry picked from commit d35849b6f718990869b01209865bb70cb7343ceb)

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
index 57bd434..f2b6917 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
@@ -593,10 +593,10 @@ en-US = "< &Back"
 en-US = "Cancel"
 
 [OOO_CONTROL_255]
-en-US = "[ProductName] will be installed with the default components, 
including spelling dictionaries in all available languages."
+en-US = "[ProductName] will be installed with the default components, 
including user interface languages and spelling dictionaries matching your 
current language settings."
 
 [OOO_CONTROL_256]
-en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages or deselect unwanted dictionaries."
+en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages and spelling dictionaries."
 
 [OOO_CONTROL_257]
 en-US = "Choose the setup type that best suits your needs."
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: instsetoo_native/inc_openoffice

 instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d35849b6f718990869b01209865bb70cb7343ceb
Author: Stephan Bergmann 
Date:   Thu Dec 6 16:54:07 2012 +0100

fdo#57927: Clarify msi installer only installs subset of dicts by default

...since this was changed with fdo#53009 in LO 3.6.3.

Change-Id: I95b8da1311c666945e9bbe15d22da59add6b6227

diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf 
b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
index 57bd434..f2b6917 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
+++ b/instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf
@@ -593,10 +593,10 @@ en-US = "< &Back"
 en-US = "Cancel"
 
 [OOO_CONTROL_255]
-en-US = "[ProductName] will be installed with the default components, 
including spelling dictionaries in all available languages."
+en-US = "[ProductName] will be installed with the default components, 
including user interface languages and spelling dictionaries matching your 
current language settings."
 
 [OOO_CONTROL_256]
-en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages or deselect unwanted dictionaries."
+en-US = "Choose which program features you want installed and where they will 
be installed. For example here you can select additional user interface 
languages and spelling dictionaries."
 
 [OOO_CONTROL_257]
 en-US = "Choose the setup type that best suits your needs."
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: filter/source

 filter/source/svg/svgwriter.cxx |5 ++---
 filter/source/svg/svgwriter.hxx |3 +--
 2 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit d96c0ee8e9ad0f777bed009e87401e6f684af446
Author: Stephan Bergmann 
Date:   Thu Dec 6 16:43:16 2012 +0100

-Werror,-Wunused-private-field

Change-Id: Ia567a2e7f8089ad193af98443e5d662e744fcff7

diff --git a/filter/source/svg/svgwriter.cxx b/filter/source/svg/svgwriter.cxx
index 2f269ba..332ff7e 100644
--- a/filter/source/svg/svgwriter.cxx
+++ b/filter/source/svg/svgwriter.cxx
@@ -440,9 +440,8 @@ void SVGAttributeWriter::setFontFamily()
 // - SVGTextWriter -
 // ---
 
-SVGTextWriter::SVGTextWriter( SVGExport& rExport, SVGFontExport& rFontExport )
+SVGTextWriter::SVGTextWriter( SVGExport& rExport )
 :   mrExport( rExport ),
-mrFontExport( rFontExport ),
 mpContext( NULL ),
 mpVDev( NULL ),
 mbIsTextShapeStarted( sal_False ),
@@ -1941,7 +1940,7 @@ SVGActionWriter::SVGActionWriter( SVGExport& rExport, 
SVGFontExport& rFontExport
 mrExport( rExport ),
 mrFontExport( rFontExport ),
 mpContext( NULL ),
-maTextWriter( rExport, rFontExport ),
+maTextWriter( rExport ),
 mnInnerMtfCount( 0 ),
 mbClipAttrChanged( sal_False )
 {
diff --git a/filter/source/svg/svgwriter.hxx b/filter/source/svg/svgwriter.hxx
index ebffda9..ce2e441 100644
--- a/filter/source/svg/svgwriter.hxx
+++ b/filter/source/svg/svgwriter.hxx
@@ -196,7 +196,6 @@ class SVGTextWriter
 
   private:
 SVGExport&  mrExport;
-SVGFontExport&  mrFontExport;
 SVGAttributeWriter* mpContext;
 VirtualDevice*  mpVDev;
 sal_BoolmbIsTextShapeStarted;
@@ -230,7 +229,7 @@ class SVGTextWriter
 FontmaParentFont;
 
   public:
-SVGTextWriter( SVGExport& rExport, SVGFontExport& rFontExport );
+SVGTextWriter( SVGExport& rExport );
 virtual ~SVGTextWriter();
 
 sal_Int32 setTextPosition( const GDIMetaFile& rMtf, sal_uLong& nCurAction 
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Default Styles in Writer

2012-12-06 Thread Samuel Mehrbrodt

Hi Niklas,

Somehow I missed your post on UX-Advise. Anyway, thanks for the
information, that's helpful to me.

I'll have a look at it when I've got some time.

Thanks
Samuel

Am 06.12.2012 12:55, schrieb Niklas Johansson:

Hi Samuel

This is pretty much the issue I tried to raise in the UX-discussion.
- Applied styles are shown in the ComboBox (a good thing)
- A style that is the basis for another style is seen as Applied
and is thus shown in the ComboBox (what I questioned)
- The Default Style is the basis for all other styles (not a bad thing)
and thus it is *always* shown in the ComboBox (not so nice)

An important point, I believe, is that, if in fact the Default Style
is explicitly used in the document it should be shown in the
ComboBox.
So, for this to work I believe the logic behind what is added in the
ComboBox at run time needs to changed. I wouldn't mind being
proven wrong though. ;)

Nice job with the default set of styles though.
Regards,
Niklas Johansson
Samuel Mehrbrodt skrev 2012-12-06 09:33:

Hi,

I have submitted a patch changing the list of default Styles in the
Toolbar in Writer [1].

Now, we [2] also wanted to remove the entry "Default Style" from the
list, but removing "Standard" in the code didn't do that.
Can anyone point me in the right direction where this is added?

Thanks,
Samuel

[1]https://gerrit.libreoffice.org/1248
[2]
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Default-Styles-in-Writer-td4020441.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

Hi,

Final release:
http://numbertext.org/dist/b7cae45ad2c23551fd6ccb8ae2c1f59e-numbertext-0.9.5.oxt

Unfortunately, I don't know the exact status of this extension in
LibreOffice. I will publish it on the LibreOffice Extensions site, too
(also the other ones mentioned in my previous letter).

Thanks,
László


2012/12/6 Stephan Bergmann 

> On 12/06/2012 03:23 PM, Matúš Kukan wrote:
>
>> On 6 December 2012 14:40, Stephan Bergmann  wrote:
>>
>>> LO wants to download the prebuilt oxt from
>>> >> 510117359dc91181ea06b4aa8582ed**2c-numbertext-0.9.5.oxt
>>> >
>>> (see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that
>>> would be the easiest.  I can adapt the single line setting
>>> NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.
>>>
>>
>> Can't we just change this and use 
>> http://dev-www.libreoffice.**org/src/?
>>
>
> My understanding is that Kami/OxygenOffice/ooo.itc.hu (whether and
> however they are actually connected) are the only "real" consumers to
> include that prebuilt numbertext oxt as a bundled extension in installation
> sets.  As such, I think it is best to keep the sources hosted at
> ooo.itc.hu or, if that does not work well, drop --enable-ext-numbertext
> support from LO.
>
> My stake in this is merely that I like to "misuse" the various
> --enable-ext-* switches that appear to be there for the benefit of
> OxygenOffice, to easily have some "real extensions as seen in the wild"
> installed in the local builds I do, to see there are any problems with
> them.  So if there is a cheap way to keep those --enable-ext-* switches
> alive, I do not mind getting involved in some simple maintenance work
> around them occasionally.  But, on the other hand, I would not cry if they
> were gone for good, either.
>
> Stephan
>
> __**_
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.**org 
> http://lists.freedesktop.org/**mailman/listinfo/libreoffice
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: extensions/source

 extensions/source/plugin/unx/mediator.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b13abba277397464a2cde3604aaca780191e5d97
Author: Stephan Bergmann 
Date:   Thu Dec 6 16:26:52 2012 +0100

-Werror,-Wsometimes-uninitialized

Change-Id: I8996a06a19e7500b212acf863c44231214427f79

diff --git a/extensions/source/plugin/unx/mediator.cxx 
b/extensions/source/plugin/unx/mediator.cxx
index 9cb11fc..a4eea38 100644
--- a/extensions/source/plugin/unx/mediator.cxx
+++ b/extensions/source/plugin/unx/mediator.cxx
@@ -202,7 +202,7 @@ void MediatorListener::run()
 sal_uLong nHeader[ 3 ];
 int nBytes;
 
-if( m_pMediator && ( nBytes = read( m_pMediator->m_nSocket, nHeader, 
sizeof( nHeader ) ) ) == sizeof( nHeader ) && nHeader[2] == MEDIATOR_MAGIC)
+if( ( nBytes = read( m_pMediator->m_nSocket, nHeader, sizeof( nHeader 
) ) ) == sizeof( nHeader ) && nHeader[2] == MEDIATOR_MAGIC)
 {
 if( nHeader[ 0 ] == 0 && nHeader[ 1 ] == 0 )
 return;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=54157

Bug 54157 depends on bug 57946, which changed state.

Bug 57946 Summary: EDITING CRASH in menu 'Format - Conditional Formatting - 
Contition - Condition'
https://bugs.freedesktop.org/show_bug.cgi?id=57946

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012-12-06 Thread Stephan Bergmann


On 12/06/2012 03:47 PM, Andras Timar wrote:

On Thu, Dec 6, 2012 at 3:31 PM, Stephan Bergmann  wrote:

My understanding is that Kami/OxygenOffice/ooo.itc.hu (whether and however
they are actually connected) are the only "real" consumers to include that
prebuilt numbertext oxt as a bundled extension in installation sets.  As
such, I think it is best to keep the sources hosted at ooo.itc.hu or, if
that does not work well, drop --enable-ext-numbertext support from LO.


SUSE build uses it as well, probably it was requested by a customer.


...in which case please just ignore me here.

Stephan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?



I think that testing from Thursday 13 to Wednesday 19th is perfectly fine and
beta1 state looks promising for it.

Maybe we should announce this on the user list and there's a chance we 
can get a few more volunteers for QA work??


Is there any plan to make a wiki page or something about the event?

As always thanks to everyone from the developers to the organizers of 
this event, it takes a lot of work to keep a project like this so alive 
and thriving:)



Regards,
Joel
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: dbaccess/source

 dbaccess/source/ui/inc/unosqlmessage.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4b90e055067a829f504b53d59aadc2e97138a79b
Author: Noel Grandin 
Date:   Thu Dec 6 17:00:48 2012 +0200

fix missing SAL_CALL attribute on method

Change-Id: Idd0581d104c5a3e1286763c2deb8d385e04e207b

diff --git a/dbaccess/source/ui/inc/unosqlmessage.hxx 
b/dbaccess/source/ui/inc/unosqlmessage.hxx
index c738b73..f8b4bf2 100644
--- a/dbaccess/source/ui/inc/unosqlmessage.hxx
+++ b/dbaccess/source/ui/inc/unosqlmessage.hxx
@@ -64,7 +64,7 @@ public:
 virtual ::cppu::IPropertyArrayHelper* createArrayHelper( ) const;
 
 protected:
-virtual void initialize(com::sun::star::uno::Sequence< 
::com::sun::star::uno::Any > const & args) throw 
(com::sun::star::uno::Exception, com::sun::star::uno::RuntimeException);
+virtual void SAL_CALL initialize(com::sun::star::uno::Sequence< 
::com::sun::star::uno::Any > const & args) throw 
(com::sun::star::uno::Exception, com::sun::star::uno::RuntimeException);
 
 // OPropertySetHelper overridables
 // (overwrittin these three, because we have some special handling for our 
property)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: About numbertext

2012-12-06 Thread Andras Timar

Hi,

On Thu, Dec 6, 2012 at 3:31 PM, Stephan Bergmann  wrote:
>
> My understanding is that Kami/OxygenOffice/ooo.itc.hu (whether and however
> they are actually connected) are the only "real" consumers to include that
> prebuilt numbertext oxt as a bundled extension in installation sets.  As
> such, I think it is best to keep the sources hosted at ooo.itc.hu or, if
> that does not work well, drop --enable-ext-numbertext support from LO.

SUSE build uses it as well, probably it was requested by a customer.

Best regards,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012/12/6 Matúš Kukan 

> On 6 December 2012 14:40, Stephan Bergmann  wrote:
> > LO wants to download the prebuilt oxt from
> > <
> http://ooo.itc.hu/oxygenoffice/download/libreoffice/510117359dc91181ea06b4aa8582ed2c-numbertext-0.9.5.oxt
> >
> > (see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that
> > would be the easiest.  I can adapt the single line setting
> > NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.
>
> Can't we just change this and use http://dev-www.libreoffice.org/src/ ?
>

Yes, it would be fine, also with the hunart and the typography toolbar
extensions.

Laszlo



>
> Matus
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012-12-06 Thread Stephan Bergmann


On 12/06/2012 03:23 PM, Matúš Kukan wrote:

On 6 December 2012 14:40, Stephan Bergmann  wrote:

LO wants to download the prebuilt oxt from

(see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that
would be the easiest.  I can adapt the single line setting
NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.


Can't we just change this and use http://dev-www.libreoffice.org/src/ ?


My understanding is that Kami/OxygenOffice/ooo.itc.hu (whether and 
however they are actually connected) are the only "real" consumers to 
include that prebuilt numbertext oxt as a bundled extension in 
installation sets.  As such, I think it is best to keep the sources 
hosted at ooo.itc.hu or, if that does not work well, drop 
--enable-ext-numbertext support from LO.


My stake in this is merely that I like to "misuse" the various 
--enable-ext-* switches that appear to be there for the benefit of 
OxygenOffice, to easily have some "real extensions as seen in the wild" 
installed in the local builds I do, to see there are any problems with 
them.  So if there is a cheap way to keep those --enable-ext-* switches 
alive, I do not mind getting involved in some simple maintenance work 
around them occasionally.  But, on the other hand, I would not cry if 
they were gone for good, either.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: random number generators for calc

2012-12-06 Thread tino

> > just happened to reimplement RAND() with a B.A Wichmann
> > and I.D Hill generator.. see
> 
>   As they are entitled to. No doubt we'll come up with a comprehensive,
> nicely architected and beautiful solution of our own :-)

Ok, I'll go ahead with a suggestion then. :)

Attached patch is just a simple wrapper around boost, to be used like

sc::rng::seed() to replace libc srand()
sc::rng::rand() to replace libc rand()

and a few more distributions.

I've also modified ScInterpreter::ScRandom()
to simply call sc::rng::uniform()
which should solve bug 33365.

I've not modified RANDBETWEEN(a,b) yet but this could simply call
sc::rng::uniform_int(a,b).

Also, the rand in Basic could be changed in the future.

Small problems:
 - compiler warnings from within boost
 - few asserts might need to be replaced

>From 569a0e05f1c2320041786be051842a552aca885c Mon Sep 17 00:00:00 2001
From: tino 
Date: Thu, 6 Dec 2012 14:05:11 +
Subject: [PATCH] fdo#33365 added wrapper for boost random, use that in RAND()

Change-Id: Iafc524d12c76423f74dc16b42595e52fbc5a1e54
---
 sc/Library_sc.mk |   1 +
 sc/source/core/data/global.cxx   |   2 +
 sc/source/core/inc/random.hxx|  35 ++
 sc/source/core/tool/interpr1.cxx |   4 +-
 sc/source/core/tool/random.cxx   | 255 +++
 5 files changed, 296 insertions(+), 1 deletion(-)
 create mode 100644 sc/source/core/inc/random.hxx
 create mode 100644 sc/source/core/tool/random.cxx

diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 348300f..10918e4 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -213,6 +213,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\
 	sc/source/core/tool/progress \
 	sc/source/core/tool/queryentry \
 	sc/source/core/tool/queryparam \
+	sc/source/core/tool/random \
 	sc/source/core/tool/rangelst \
 	sc/source/core/tool/rangenam \
 	sc/source/core/tool/rangeseq \
diff --git a/sc/source/core/data/global.cxx b/sc/source/core/data/global.cxx
index 4e449c5..e18d241 100644
--- a/sc/source/core/data/global.cxx
+++ b/sc/source/core/data/global.cxx
@@ -75,6 +75,7 @@
 #include "sc.hrc"
 #include "scmod.hxx"
 #include "appoptio.hxx"
+#include "random.hxx"
 
 // ---
 
@@ -557,6 +558,7 @@ void ScGlobal::Init()
 // names from the compiler.
 ScParameterClassification::Init();
 srand( (unsigned) time( NULL ) );   // Random Seed Init fuer Interpreter
+sc::rng::seed( time( NULL ) );  // seed for libc rand() replacement
 
 InitAddIns();
 
diff --git a/sc/source/core/inc/random.hxx b/sc/source/core/inc/random.hxx
new file mode 100644
index 000..dc068b1
--- /dev/null
+++ b/sc/source/core/inc/random.hxx
@@ -0,0 +1,35 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#ifndef SC_RANDOM_HXX
+#define SC_RANDOM_HXX
+
+namespace sc
+{
+namespace rng
+{
+
+void seed(int i);   // set initial seed (equivalent of libc srand())
+uint32_t max(); // max number by rand() (equivalent of RAND_MAX)
+uint32_t min(); // min number by rand() (most likely 0)
+uint32_t rand();// replacement for libc's rand()
+
+int uniform_int(int from, int to);  // uniform distribution given int range
+double uniform();   // uniform distribution in [0,1)
+double normal();// normal distribution N(0,1)
+double normal(double mu, double sigma); // N(mu, sigma^2)
+double lognormal(); // lognormal distribution: exp(N(0,1))
+double lognormal(double mu, double sigma);
+
+} // namespace
+} // namespace
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 43a21eb..adecc75 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -44,6 +44,7 @@
 #include "globstr.hrc"
 #include "attrib.hxx"
 #include "jumpmatrix.hxx"
+#include "random.hxx"
 
 #include 
 #include 
@@ -1711,7 +1712,8 @@ void ScInterpreter::ScPi()
 void ScInterpreter::ScRandom()
 {
 RTL_LOGFILE_CONTEXT_AUTHOR( aLogger, "sc", "er", "ScInterpreter::ScRandom" );
-PushDouble((double)rand() / ((double)RAND_MAX+1.0));
+//PushDouble((double)rand() / ((double)RAND_MAX+1.0));
+PushDouble(sc::rng::uniform());
 }
 
 
diff --git a/sc/source/core/tool/random.cxx b/sc/source/core/tool/random.cxx
new file mode 100644
index 000..4195e26
--- /dev/null
+++ b/sc/source/core/tool/random.cxx
@@ -0,0 +1,255 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the

[PUSHED] Change in core[libreoffice-3-6]: fdo#40339: line style toolbar dropdown list not updated

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1238

Approvals:
  Caolán McNamara: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1238
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ed6f6219f2b31fb02c24c70f3fef4f0efcb
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Ivan Timofeev 
Gerrit-Reviewer: Caolán McNamara 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012-12-06 Thread Matúš Kukan

On 6 December 2012 14:40, Stephan Bergmann  wrote:
> LO wants to download the prebuilt oxt from
> 
> (see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that
> would be the easiest.  I can adapt the single line setting
> NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.

Can't we just change this and use http://dev-www.libreoffice.org/src/ ?

Matus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - svx/source

 svx/source/tbxctrls/linectrl.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit ee1d26740fbd8e9c9d6c1ee7e493f136c25b038c
Author: Ivan Timofeev 
Date:   Tue Dec 4 18:19:07 2012 +0400

fdo#40339: line style toolbar dropdown list not updated

... because XLineDashItem::GetName returns the so-called "api name"
(from RID_SVXSTR_DASH_DEF_START..RID_SVXSTR_DASH_DEF_END range), while
the listbox is filled with corresponding translated names.

Change-Id: I9ed6f6219f2b31fb02c24c70f3fef4f0efcb
(cherry picked from commit 44ee3ce747058eaf7ca241fe482f4aab54c9bc92)
Reviewed-on: https://gerrit.libreoffice.org/1238
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/svx/source/tbxctrls/linectrl.cxx b/svx/source/tbxctrls/linectrl.cxx
index 0b75ce7..e1c7670 100644
--- a/svx/source/tbxctrls/linectrl.cxx
+++ b/svx/source/tbxctrls/linectrl.cxx
@@ -45,6 +45,7 @@
 #include "svx/linectrl.hxx"
 #include 
 #include 
+#include 
 
 using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::beans;
@@ -169,7 +170,9 @@ void SvxLineStyleToolBoxControl::Update( const SfxPoolItem* 
pState )
 {
 if( pDashItem )
 {
-String aString( pDashItem->GetName() );
+String aString;
+SvxUnogetInternalNameForItem(
+XATTR_LINEDASH, pDashItem->GetName(), aString );
 pBox->SelectEntry( aString );
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - 2 commits - sc/inc sc/qa sc/source

 sc/inc/dpsave.hxx|2 +
 sc/qa/unit/ucalc.cxx |   29 ++
 sc/source/core/data/dpobject.cxx |   12 +-
 sc/source/core/data/dpsave.cxx   |   37 +
 sc/source/ui/inc/gridwin.hxx |4 ++-
 sc/source/ui/view/dbfunc3.cxx|   43 ++-
 sc/source/ui/view/gridwin.cxx|   39 ---
 7 files changed, 112 insertions(+), 54 deletions(-)

New commits:
commit 28daebdf085844b8e611a90ece376ac3b19b8b9b
Author: Kohei Yoshida 
Date:   Thu Dec 6 00:32:22 2012 -0500

Avoid activating window pane when launching popup window.

Else, activating another window pane where the cursor is not would cause
the pivot table field popup to immediately get dismissed after launch 
because
ClickExtern() gets called from ActivatePart().

For example, imagine a field popup button is on C2, the cell cursor is
on E5, and the window is frozen between rows 2 and 3.  Clicking the popup
button in C2 would launch it for a brief second and dismiss it immediately
afterward.  Conceptually, launching a popup in another pane shouldn't
activate that pane anyway. So it makes sense not to activate it for that
scenario.

Change-Id: Ib970cb898fb9c79d254411e2519cfce74c60b72f

diff --git a/sc/source/ui/inc/gridwin.hxx b/sc/source/ui/inc/gridwin.hxx
index 8a64de9..4f84d43 100644
--- a/sc/source/ui/inc/gridwin.hxx
+++ b/sc/source/ui/inc/gridwin.hxx
@@ -115,6 +115,8 @@ private:
 
 boost::scoped_ptr mpAutoFillRect;
 
+struct MouseEventState;
+
 /**
  * Stores current visible column and row ranges, used to avoid expensive
  * operations on objects that are outside visible area.
@@ -250,7 +252,7 @@ private:
 sal_Int8DropTransferObj( ScTransferObj* pTransObj, SCCOL 
nDestPosX, SCROW nDestPosY,
  const Point& rLogicPos, sal_Int8 
nDndAction );
 
-voidHandleMouseButtonDown( const MouseEvent& rMEvt );
+voidHandleMouseButtonDown( const MouseEvent& rMEvt, 
MouseEventState& rState );
 
 boolDrawMouseButtonDown(const MouseEvent& rMEvt);
 boolDrawMouseButtonUp(const MouseEvent& rMEvt);
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 64555e6..e7f82b8 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -167,6 +167,13 @@ extern SfxViewShell* pScActiveViewShell;// 
global.cxx
 extern sal_uInt16 nScClickMouseModifier;// global.cxx
 extern sal_uInt16 nScFillModeMouseModifier; // global.cxx
 
+struct ScGridWindow::MouseEventState
+{
+bool mbActivatePart;
+
+MouseEventState() : mbActivatePart(false) {}
+};
+
 #define SC_FILTERLISTBOX_LINES  12
 
 // 
@@ -1734,7 +1741,10 @@ void ScGridWindow::MouseButtonDown( const MouseEvent& 
rMEvt )
 {
 nNestedButtonState = SC_NESTEDBUTTON_DOWN;
 
-HandleMouseButtonDown( rMEvt );
+MouseEventState aState;
+HandleMouseButtonDown(rMEvt, aState);
+if (aState.mbActivatePart)
+pViewData->GetView()->ActivatePart(eWhich);
 
 if ( nNestedButtonState == SC_NESTEDBUTTON_UP )
 {
@@ -1751,7 +1761,7 @@ void ScGridWindow::MouseButtonDown( const MouseEvent& 
rMEvt )
 nNestedButtonState = SC_NESTEDBUTTON_NONE;
 }
 
-void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt )
+void ScGridWindow::HandleMouseButtonDown( const MouseEvent& rMEvt, 
MouseEventState& rState )
 {
 // We have to check if a context menu is shown and we have an UI
 // active inplace client. In that case we have to ignore the event.
@@ -1835,12 +1845,9 @@ void ScGridWindow::HandleMouseButtonDown( const 
MouseEvent& rMEvt )
 if (!bDouble)
 nMouseStatus = SC_GM_NONE;
 
-if (!bFormulaMode)
-{
-if ( pViewData->GetActivePart() != eWhich )
-pViewData->GetView()->ActivatePart( eWhich );
-}
-else
+rState.mbActivatePart = !bFormulaMode; // Don't activate when in formula 
mode.
+
+if (bFormulaMode)
 {
 ScViewSelectionEngine* pSelEng = pViewData->GetView()->GetSelEngine();
 pSelEng->SetWindow(this);
@@ -1896,9 +1903,7 @@ void ScGridWindow::HandleMouseButtonDown( const 
MouseEvent& rMEvt )
 {
 bRFMouse = true;// die anderen Variablen sind oben 
initialisiert
 
-if ( pViewData->GetActivePart() != eWhich )
-pViewData->GetView()->ActivatePart( eWhich );   //! schon oben 
immer ???
-
+rState.mbActivatePart = true; // always activate ?
 StartTracking();
 return;
 }
@@ -1909,7 +1914,7 @@ void ScGridWindow::HandleMouseButtonDown( const 
MouseEvent& rMEvt )
 if ( bDouble )
 pViewData->GetView()->FillCrossDblClick();
 else
-pScMod->InputEnterHandler();

[PUSHED] Manual conversion printeroption widget

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1242


--
To view, visit https://gerrit.libreoffice.org/1242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fa6144c242519d57a6ce92ea8dfe776bc12d765
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: gokul s 
Gerrit-Reviewer: Caolán McNamara 
Gerrit-Reviewer: gokul s 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: loader.loadComponentFromURL works slow when we are restoring CALC sheet from byte array | loader.loadComponentFromURL

2012-12-06 Thread William Beltrán



El 06/12/12 08:50, Michael Meeks escribió:

On Wed, 2012-12-05 at 11:27 -0500, William Beltrán wrote:

Ok, I try to be more specific

Warning: Any further replies that ignore my request to CC (this means
carbon-copy - it is usually the 2nd field down in your mailer after the
To: field) the public developers list - will be ignored. You need to
enter: libreoffice@lists.freedesktop.org into that CC field when you
reply: why ? I don't want to burn my time answering the same questions
again and again to lots of different users :-)


Ok.



I am usign aeroo_reports(aerolib) to generate a ods report, this
report is vey complex and it takes arround 20secs to work and generate
it in .ods type, I can configure the report_aeroo module to
automatically convert the result of my process to xls file but the
times grows up to 15 minutes!!! only in transformation process, so I
analize the module code and i found that this function is the problem:

Fine.


  def putDocument(self, data):
 try:
 desktop =
self._context.ServiceManager.createInstanceWithContext("com.sun.star.frame.Desktop",
 self._context)
 except UnknownPropertyException:
 self._context = self._resolver.resolve("uno:socket,host=%
s,port=%s;urp;StarOffice.ComponentContext" % (self._host, self._port))
 desktop =
self._context.ServiceManager.createInstanceWithContext("com.sun.star.frame.Desktop",
 self._context)
 inputStream =
self.serviceManager.createInstanceWithContext("com.sun.star.io.SequenceInputStream",
 self.localContext)
 inputStream.initialize((uno.ByteSequence(data),))

Looks like you convert some huge string into a byte sequence. I guess,
that should be reasonably quick. What does your huge string contain ?
zipped ODF ? flat-ODF ? what ?
Is the contain of the file (bytesequence), just like another odf file 
that really is a zip file as you knows.



 self.document = desktop.loadComponentFromURL('private:stream',
"_blank", 0,  self._toProperties(InputStream = inputStream))
 inputStream.closeInput()

That takes the time ? if so - we'd need a profile of what is going on
to be able to point you at the slow bit so you can help fix it.


Where var data is an inputsream containing the bytes of the ods
file,but there is no problem until the line:

self.document = desktop.loadComponentFromURL('private:stream',
"_blank", 0,  self._toProperties(InputStream = inputStream))

This line is the "devil" so I have to waint until 15 minutes to be
done and excecute next line(inputStream.closeInput())
The reports has maybe has 4230 rows so its a big report

4000 rows is not that many; there must be something unusual about them,
or about the SequenceInputStream: which looks like it should be really
fast. If you have a non-confidential example of the file-data there -
can you dump that to a file and try loading that standalone ?

ATB,

Michael.

If I open the file in LibreOffice and saves it as xls file that is very 
fast.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: cli_ure/util cli_ure/workbench curl/makefile.mk dbaccess/util idl/util slideshow/util

 cli_ure/util/target.pmk   |   35 --
 cli_ure/workbench/dynload/dynload.cs  |   53 -
 cli_ure/workbench/dynload/makefile.mk |   59 --
 cli_ure/workbench/dynload/readme.txt  |2 
 curl/makefile.mk  |  190 --
 dbaccess/util/dba.pmk |   20 ---
 dbaccess/util/makefile.pmk|   22 ---
 idl/util/makefile.mk  |   59 --
 slideshow/util/makefile.pmk   |   38 --
 9 files changed, 478 deletions(-)

New commits:
commit 42db3c8036947142771577fd301894e9aa9a995b
Author: CaolÃ¡n McNamara 
Date:   Thu Dec 6 13:49:34 2012 +

commit delete various unused makefile.mks

Change-Id: I382423164fd65679d3b893ea0d9729508813b425

diff --git a/cli_ure/util/target.pmk b/cli_ure/util/target.pmk
deleted file mode 100644
index b463e52..000
--- a/cli_ure/util/target.pmk
+++ /dev/null
@@ -1,35 +0,0 @@
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-# This file incorporates work covered by the following license notice:
-#
-#   Licensed to the Apache Software Foundation (ASF) under one or more
-#   contributor license agreements. See the NOTICE file distributed
-#   with this work for additional information regarding copyright
-#   ownership. The ASF licenses this file to you under the Apache
-#   License, Version 2.0 (the "License"); you may not use this file
-#   except in compliance with the License. You may obtain a copy of
-#   the License at http://www.apache.org/licenses/LICENSE-2.0 .
-#
-
-## C# ##
-
-CSCFLAGS = -warnaserror+ -noconfig
-
-.IF "$(debug)" == ""
-
-.IF "$(product)" == ""
-CSCFLAGS += -checked+ -define:DEBUG -define:TRACE
-.ELSE
-CSCFLAGS += -o
-.ENDIF
-
-.ELSE # debug
-
-CSCFLAGS += -debug+ -checked+ -define:DEBUG -define:TRACE
-
-.ENDIF
diff --git a/cli_ure/workbench/dynload/dynload.cs 
b/cli_ure/workbench/dynload/dynload.cs
deleted file mode 100644
index 36c3e02..000
--- a/cli_ure/workbench/dynload/dynload.cs
+++ /dev/null
@@ -1,53 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-using System;
-using unoidl.com.sun.star.lang;
-using unoidl.com.sun.star.uno;
-using unoidl.com.sun.star.bridge;
-using unoidl.com.sun.star.frame;
-
-class DynLoad
-{
-
-static void Main(string[] args)
-{
-connect(args);
-}
-
-/** Connect to a running office that is accepting connections.
-@return  The ServiceManager to instantiate office components. */
-static private XMultiServiceFactory connect( string[] args )
-{
-if (args.Length == 0)
-Console.WriteLine("You need to provide a file URL to the office" +
-  " program folder\n");
-System.Collections.Hashtable ht = new System.Collections.Hashtable();
-ht.Add( "SYSBINDIR", args[ 0 ] );
-XComponentContext xContext =
-uno.util.Bootstrap.defaultBootstrap_InitialComponentContext(
- args[ 0 ] + "/uno.ini", ht.GetEnumerator() );
-
-if (xContext != null)
-Console.WriteLine("Successfully created XComponentContext\n");
-else
-Console.WriteLine("Could not create XComponentContext\n");
-   
-   return null;
-}
-}
diff --git a/cli_ure/workbench/dynload/makefile.mk 
b/cli_ure/workbench/dynload/makefile.mk
deleted file mode 100644
index e20fdcb..000
--- a/cli_ure/workbench/dynload/makefile.mk
+++ /dev/null
@@ -1,59 +0,0 @@
-#
-# This file is part of the LibreOffice project.
-#
-# This Source Code Form is subject to the terms of the Mozilla Public
-# License, v. 2.0. If a copy of the MPL was not distributed with this
-# file, You can obtain one at http://mozilla.org/MPL/2.0/.
-#
-# This file incorporates work covered by the following license notice:
-#
-#   Licensed to the Apache Software Foundation (ASF) under one or more
-#   contributor license agreements. See the NOTICE file distributed
-#   with this work for additional information rega

Re: About numbertext

Hi Stephan, hi Kami,

I'm sorry, the first link was a not public link of the of the extension
with pending approval at LibreOffice Extensions site, and the target of the
second one wasn't updated yet. Here is the right link (extended with the
md5sum):

http://numbertext.org/dist/92973266240813c7bdb44a4b7d85af04-numbertext-0.9.5.oxt

Kami, could you help to copy this extension to the itc.hu?

Many thanks for your help.
Best regards,
Laszlo





2012/12/6 Stephan Bergmann 

> On 12/06/2012 02:02 PM, Németh László wrote:
>
>> I have made the complete port, tested with LibreOffice 4.0 and 3.6:
>> http://extensions.libreoffice.**org/extension-center/**
>> numbertext-1/pscreleasefolder.**2012-10-09.7591543982/0.9.5/**
>> numbertext-0.9.5.oxt
>> or
>> http://www.numbertext.org/**dist/numbertext-0.9.5.oxt
>> Could you update the numbertext src package of the LibreOffice? Thanks
>> in advance,
>>
>
> LO wants to download the prebuilt oxt from  oxygenoffice/download/**libreoffice/**510117359dc91181ea06b4aa8582ed**
> 2c-numbertext-0.9.5.oxt>
> (see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that
> would be the easiest.  I can adapt the single line setting
> NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.
>
> The first link above leads to a broken oxt, so I assume the second link
> points to what we want (and the md5sum I give above is for that one).
>
> Stephan
>
>
>  2012/12/6 Németh László > **>
>>
>>
>> Hello,
>>
>> I will check your fixes, and make a new release from the Numbertext
>> extension (with fixes and the new Latvian and Lithuanian modules of
>> the version 0.9.5). Many thanks for your work and mail!
>>
>> Best regards,
>> Laszlo
>>
>>
>>
>>
>> 2012/12/5 julien2412 mailto:serval2...@yahoo.fr
>> >>
>>
>>
>> Hello,
>>
>> By trying to reproduce an fdo, I got a lot of these on console:
>> Python exception: : inconsistent use of tabs
>> and spaces in
>> indentation (__init__.py, line 70), traceback follows
>>
>> /home/julien/compile-**libreoffice/libo/solver/**
>> unxlngx6/installation/opt/**program/uno.py:265
>> in function _uno_import() [return _g_delegatee( name, *optargs,
>> **kwargs )]
>>
>> /home/julien/compile-**libreoffice/libo/solver/**
>> unxlngx6/installation/opt/**share/extensions/numbertext/re**g.uno.py:7
>> 
>>
>> in function createInstance() [import org.Numbertext]
>>
>> /home/julien/compile-**libreoffice/libo/solver/**
>> unxlngx6/installation/opt/**program/unohelper.py:292
>> in function createInstanceWithContext() [return self.clazz(
>> context )
>>
>> So I unzipped
>> src/**b8cbca7b3363e6ca2d02bc0ba2b639**04-numbertext_0.9.4.oxt and
>> runned pep8 (1.3.3 version) on it. Except "E501 lines too long",
>> I fixed all
>> the pep8 warnings. I put all the changes files here:
>> changes.tar.bz2
>> > n4022762/changes.tar.bz2
>> >
>>
>> pylint gives warnings too but I don't know really how to fix them.
>>
>> If it's ok, does it worth it to create a new version of
>> numbertext?
>>
>> Julien
>>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - boost/boost.6397.warnings.patch connectivity/source slideshow/source

 boost/boost.6397.warnings.patch  |  168 
+-
 connectivity/source/drivers/evoab2/NStatement.hxx|2 
 slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionImpl.cxx |   16 
 3 files changed, 166 insertions(+), 20 deletions(-)

New commits:
commit 4689f1c4cf96b43bf7470e31f05614c2a1c16f2d
Author: Stephan Bergmann 
Date:   Thu Dec 6 11:14:54 2012 +0100

-Werror,-Wunused-function

Change-Id: Ida1f703b4552d891f8fe3defd373ec45697ae5b5

diff --git a/slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionImpl.cxx 
b/slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionImpl.cxx
index efdf7be..dda9154 100644
--- a/slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionImpl.cxx
+++ b/slideshow/source/engine/OGLTrans/unx/OGLTrans_TransitionImpl.cxx
@@ -1674,20 +1674,4 @@ boost::shared_ptr makeNewsflash()
 return makeSimpleTransition(aLeavingSlide, aEnteringSlide, 
aOverallOperations);
 }
 
-namespace
-{
-
-/** various transitions helper methods
- */
-void prepareDiamond( double nTime, double SlideWidth, double 
SlideHeight,double DispWidth, double DispHeight );
-void displaySlidesFadeSmoothly( double nTime, ::sal_Int32 glLeavingSlideTex, 
::sal_Int32 glEnteringSlideTex, double SlideWidthScale, double SlideHeightScale 
);
-void displaySlidesFadeThroughBlack( double nTime, ::sal_Int32 
glLeavingSlideTex, ::sal_Int32 glEnteringSlideTex, double SlideWidthScale, 
double SlideHeightScale );
-void displaySlidesRochade( double nTime, ::sal_Int32 glLeavingSlideTex, 
::sal_Int32 glEnteringSlideTex, double SlideWidthScale, double SlideHeightScale 
);
-void displaySlidesShaders( double nTime, ::sal_Int32 glLeavingSlideTex, 
::sal_Int32 glEnteringSlideTex, double SlideWidthScale, double SlideHeightScale 
);
-void prepareStatic( ::sal_Int32 glLeavingSlideTex, ::sal_Int32 
glEnteringSlideTex );
-void prepareDissolve( ::sal_Int32 glLeavingSlideTex, ::sal_Int32 
glEnteringSlideTex );
-void preparePermShader();
-
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 150a965248da361440b5cc195c810751ab11e92e
Author: Stephan Bergmann 
Date:   Thu Dec 6 10:32:34 2012 +0100

-Werror,-Wuninitialized

Change-Id: I885851dd3121e34a3f860a449d4d23d185a4d278

diff --git a/connectivity/source/drivers/evoab2/NStatement.hxx 
b/connectivity/source/drivers/evoab2/NStatement.hxx
index 52f86f4..2036199 100644
--- a/connectivity/source/drivers/evoab2/NStatement.hxx
+++ b/connectivity/source/drivers/evoab2/NStatement.hxx
@@ -93,7 +93,7 @@ namespace connectivity
 QueryData( const QueryData& _rhs )
 :pQuery( NULL )
 ,sTable()
-,eFilterType( eFilterType )
+,eFilterType( eFilterOther )
 ,xSelectColumns()
 ,aSortOrder()
 {
commit 23451f2a65527a8e525a6964cb9f6a30f9e2858b
Author: Stephan Bergmann 
Date:   Thu Dec 6 10:28:41 2012 +0100

-Werror,-Wshadow

Change-Id: Idd8404cd882181e571da5fd5c02890a0bf4d1a0a

diff --git a/boost/boost.6397.warnings.patch b/boost/boost.6397.warnings.patch
index cf24c9e..383945e 100644
--- a/boost/boost.6397.warnings.patch
+++ b/boost/boost.6397.warnings.patch
@@ -153,6 +153,35 @@
  static index_range all() 
 --- misc/boost_1_44_0/boost/multi_array/multi_array_ref.hpp2012-01-12 
20:21:29.790009198 +
 +++ misc/build/boost_1_44_0/boost/multi_array/multi_array_ref.hpp  
2012-01-12 20:25:49.280492556 +
+@@ -86,24 +86,24 @@
+   num_elements_(other.num_elements_)  {  }
+ 
+   template 
+-  explicit const_multi_array_ref(TPtr base, const ExtentList& extents) :
++  explicit const_multi_array_ref(TPtr base, const ExtentList& extents_) :
+ base_(base), storage_(c_storage_order()) {
+ boost::function_requires<
+   detail::multi_array::CollectionConcept >();
+ 
+ index_base_list_.assign(0);
+-init_multi_array_ref(extents.begin());
++init_multi_array_ref(extents_.begin());
+   }
+   
+   template 
+-  explicit const_multi_array_ref(TPtr base, const ExtentList& extents,
++  explicit const_multi_array_ref(TPtr base, const ExtentList& extents_,
+const general_storage_order& so) : 
+ base_(base), storage_(so) {
+ boost::function_requires<
+   detail::multi_array::CollectionConcept >();
+ 
+ index_base_list_.assign(0);
+-init_multi_array_ref(extents.begin());
++init_multi_array_ref(extents_.begin());
+   }
+   
+   explicit const_multi_array_ref(TPtr base,
 @@ -124,13 +124,13 @@
}

@@ -170,17 +199,65 @@
*out_iter++ = *in_iter++;
copy_count++;  
  }
-@@ -327,15 +327,15 @@
+@@ -161,14 +161,14 @@
+   }
+ 
+   template 
+-  void reshape(const SizeList& extents) {
++  void reshape(const SizeList& extents_) {
+ boost::function_requires<
+   detail::multi_array::CollectionConcept >();
+ BOOST_ASSERT(num_elements_ ==
+- std::accumulate(extents.begin(),extents.end(),
++

[Libreoffice-commits] .: configure.ac .gitignore

 .gitignore   |1 -
 configure.ac |6 --
 2 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit de2c6007fc584150210eb29d15044fca0d8321f7
Author: Stephan Bergmann 
Date:   Thu Dec 6 14:59:42 2012 +0100

Do not accumulate warnings across configure runs

...and remove temporary file again.

Change-Id: I199b054d8e7b87d1c9268abbe628393d480e42f7

diff --git a/.gitignore b/.gitignore
index ddb84f7..4431992 100644
--- a/.gitignore
+++ b/.gitignore
@@ -74,7 +74,6 @@
 # misc
 /file-lists
 /cross-build-toolset.built
-/warn
 /build.log
 /build_error.log
 /install
diff --git a/configure.ac b/configure.ac
index eb2389d..1e80d4f 100644
--- a/configure.ac
+++ b/configure.ac
@@ -49,11 +49,12 @@ PathFormat()
 fi
 }
 
+rm -f warn
 have_WARNINGS="no"
 add_warning()
 {
 if test "$have_WARNINGS" = "no"; then
-echo "*" >> warn
+echo "*" > warn
 have_WARNINGS="yes"
 if which tput >/dev/null 2>/dev/null && test `tput colors` -ge 8; then
 dnl  as actual byte (U+1b), [ escaped using quadrigraph @<:@
@@ -12492,7 +12493,8 @@ _EOF
 fi
 
 if test -f warn; then
-   cat warn
+cat warn
+rm warn
 fi
 
 dnl vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: random number generators for calc

2012-12-06 Thread Michael Meeks


On Wed, 2012-12-05 at 17:12 +0100, Eike Rathke wrote:
> just happened to reimplement RAND() with a B.A Wichmann
> and I.D Hill generator.. see

As they are entitled to. No doubt we'll come up with a comprehensive,
nicely architected and beautiful solution of our own :-)

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

2012-12-06 Thread Stephan Bergmann


On 12/06/2012 02:02 PM, Németh László wrote:

I have made the complete port, tested with LibreOffice 4.0 and 3.6:
http://extensions.libreoffice.org/extension-center/numbertext-1/pscreleasefolder.2012-10-09.7591543982/0.9.5/numbertext-0.9.5.oxt
or
http://www.numbertext.org/dist/numbertext-0.9.5.oxt
Could you update the numbertext src package of the LibreOffice? Thanks
in advance,


LO wants to download the prebuilt oxt from 
 
(see LO's Makefile.fetch), so if somebody (Kami?) can put it there, that 
would be the easiest.  I can adapt the single line setting 
NUMBERTEXT_EXTENSION_PACK in LO's configure.ac then.


The first link above leads to a broken oxt, so I assume the second link 
points to what we want (and the md5sum I give above is for that one).


Stephan



2012/12/6 Németh László mailto:nem...@numbertext.org>>

Hello,

I will check your fixes, and make a new release from the Numbertext
extension (with fixes and the new Latvian and Lithuanian modules of
the version 0.9.5). Many thanks for your work and mail!

Best regards,
Laszlo




2012/12/5 julien2412 mailto:serval2...@yahoo.fr>>

Hello,

By trying to reproduce an fdo, I got a lot of these on console:
Python exception: : inconsistent use of tabs
and spaces in
indentation (__init__.py, line 70), traceback follows


/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265
in function _uno_import() [return _g_delegatee( name, *optargs,
**kwargs )]


/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/share/extensions/numbertext/reg.uno.py:7

in function createInstance() [import org.Numbertext]


/home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/unohelper.py:292
in function createInstanceWithContext() [return self.clazz(
context )

So I unzipped
src/b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt and
runned pep8 (1.3.3 version) on it. Except "E501 lines too long",
I fixed all
the pep8 warnings. I put all the changes files here:
changes.tar.bz2


pylint gives warnings too but I don't know really how to fix them.

If it's ok, does it worth it to create a new version of numbertext?

Julien

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: About numbertext

Hello,

I have made the complete port, tested with LibreOffice 4.0 and 3.6:
http://extensions.libreoffice.org/extension-center/numbertext-1/pscreleasefolder.2012-10-09.7591543982/0.9.5/numbertext-0.9.5.oxt
or
http://www.numbertext.org/dist/numbertext-0.9.5.oxt
Could you help to update the numbertext src package of the LibreOffice?
Thanks in advance,
Best regards,
Laszlo

2012/12/6 Németh László 

> Hello,
>
> I will check your fixes, and make a new release from the Numbertext
> extension (with fixes and the new Latvian and Lithuanian modules of the
> version 0.9.5). Many thanks for your work and mail!
>
> Best regards,
> Laszlo
>
>
>
>
> 2012/12/5 julien2412 
>
>> Hello,
>>
>> By trying to reproduce an fdo, I got a lot of these on console:
>> Python exception: : inconsistent use of tabs and spaces
>> in
>> indentation (__init__.py, line 70), traceback follows
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265
>> in function _uno_import() [return _g_delegatee( name, *optargs, **kwargs
>> )]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/share/extensions/numbertext/
>> reg.uno.py:7
>> in function createInstance() [import org.Numbertext]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/unohelper.py:292
>> in function createInstanceWithContext() [return self.clazz( context )
>>
>> So I unzipped src/b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt
>> and
>> runned pep8 (1.3.3 version) on it. Except "E501 lines too long", I fixed
>> all
>> the pep8 warnings. I put all the changes files here:
>> changes.tar.bz2
>> 
>>
>> pylint gives warnings too but I don't know really how to fix them.
>>
>> If it's ok, does it worth it to create a new version of numbertext?
>>
>> Julien
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://nabble.documentfoundation.org/About-numbertext-tp4022762.html
>> Sent from the Dev mailing list archive at Nabble.com.
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>



2012/12/6 Németh László 

> Hello,
>
> I will check your fixes, and make a new release from the Numbertext
> extension (with fixes and the new Latvian and Lithuanian modules of the
> version 0.9.5). Many thanks for your work and mail!
>
> Best regards,
> Laszlo
>
>
>
>
> 2012/12/5 julien2412 
>
>> Hello,
>>
>> By trying to reproduce an fdo, I got a lot of these on console:
>> Python exception: : inconsistent use of tabs and spaces
>> in
>> indentation (__init__.py, line 70), traceback follows
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265
>> in function _uno_import() [return _g_delegatee( name, *optargs, **kwargs
>> )]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/share/extensions/numbertext/
>> reg.uno.py:7
>> in function createInstance() [import org.Numbertext]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/unohelper.py:292
>> in function createInstanceWithContext() [return self.clazz( context )
>>
>> So I unzipped src/b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt
>> and
>> runned pep8 (1.3.3 version) on it. Except "E501 lines too long", I fixed
>> all
>> the pep8 warnings. I put all the changes files here:
>> changes.tar.bz2
>> 
>>
>> pylint gives warnings too but I don't know really how to fix them.
>>
>> If it's ok, does it worth it to create a new version of numbertext?
>>
>> Julien
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://nabble.documentfoundation.org/About-numbertext-tp4022762.html
>> Sent from the Dev mailing list archive at Nabble.com.
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-06 Thread Michael Meeks


On Thu, 2012-12-06 at 12:16 +0100, Petr Mladek wrote:
> Why was I so careful? If you look at
> http://dev-builds.libreoffice.org/pre-releases/src/commits-libreoffice-4-0-release-4.0.0.0-alpha1-to-beta1.log
> there were about 1350 commits between alpha1 and beta1.

We normally have around 1500 commits per month; to have 1350 in two
weeks is rather encouraging ;-)

> In fact, I want to say a big thank you to all developers. Of course,
> there was some pain. But after all this has been the easiest beta1 from
> my point of view in compare with older releases.

I'm glad it's looking reasonably test-able :-)

Nice work Petr !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: jurt/CustomTarget_test_urp.mk

 jurt/CustomTarget_test_urp.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5b567649c166c88116733f416bade285acd14f35
Author: David Tardon 
Date:   Thu Dec 6 13:59:29 2012 +0100

udkapi.rdb is enough

Change-Id: Ia9919b2d85264ba3c0bf12a66646821e5c6badb4

diff --git a/jurt/CustomTarget_test_urp.mk b/jurt/CustomTarget_test_urp.mk
index 10db4f7..9707d54 100644
--- a/jurt/CustomTarget_test_urp.mk
+++ b/jurt/CustomTarget_test_urp.mk
@@ -37,7 +37,7 @@ $(jurt_TESTURP)/done : \
$(call gb_Executable_get_target_for_build,javamaker)
$(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),JVM,1)
rm -rf $(jurt_TESTURP) && \
-   $(call gb_Helper_execute,javamaker -BUCR -O$(jurt_TESTURP) -nD $< 
-X$(OUTDIR)/bin/types.rdb) && \
+   $(call gb_Helper_execute,javamaker -BUCR -O$(jurt_TESTURP) -nD $< 
-X$(OUTDIR)/bin/udkapi.rdb) && \
touch $@
 
 # vim:set shiftwidth=4 tabstop=4 noexpandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: About numbertext

Hello,

I have made the complete port, tested with LibreOffice 4.0 and 3.6:
http://extensions.libreoffice.org/extension-center/numbertext-1/pscreleasefolder.2012-10-09.7591543982/0.9.5/numbertext-0.9.5.oxt
or
http://www.numbertext.org/dist/numbertext-0.9.5.oxt
Could you update the numbertext src package of the LibreOffice? Thanks in
advance,
Best regards,
Laszlo


2012/12/6 Németh László 

> Hello,
>
> I will check your fixes, and make a new release from the Numbertext
> extension (with fixes and the new Latvian and Lithuanian modules of the
> version 0.9.5). Many thanks for your work and mail!
>
> Best regards,
> Laszlo
>
>
>
>
> 2012/12/5 julien2412 
>
>> Hello,
>>
>> By trying to reproduce an fdo, I got a lot of these on console:
>> Python exception: : inconsistent use of tabs and spaces
>> in
>> indentation (__init__.py, line 70), traceback follows
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/uno.py:265
>> in function _uno_import() [return _g_delegatee( name, *optargs, **kwargs
>> )]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/share/extensions/numbertext/
>> reg.uno.py:7
>> in function createInstance() [import org.Numbertext]
>>
>>
>> /home/julien/compile-libreoffice/libo/solver/unxlngx6/installation/opt/program/unohelper.py:292
>> in function createInstanceWithContext() [return self.clazz( context )
>>
>> So I unzipped src/b8cbca7b3363e6ca2d02bc0ba2b63904-numbertext_0.9.4.oxt
>> and
>> runned pep8 (1.3.3 version) on it. Except "E501 lines too long", I fixed
>> all
>> the pep8 warnings. I put all the changes files here:
>> changes.tar.bz2
>> 
>>
>> pylint gives warnings too but I don't know really how to fix them.
>>
>> If it's ok, does it worth it to create a new version of numbertext?
>>
>> Julien
>>
>>
>>
>>
>> --
>> View this message in context:
>> http://nabble.documentfoundation.org/About-numbertext-tp4022762.html
>> Sent from the Dev mailing list archive at Nabble.com.
>> ___
>> LibreOffice mailing list
>> LibreOffice@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>>
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] convert cppunit to gbuild

2012-12-06 Thread David Tardon (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1183


--
To view, visit https://gerrit.libreoffice.org/1183
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idcba54973940b9f197f2fd84a906b50468d1b166
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley 
Gerrit-Reviewer: David Tardon 
Gerrit-Reviewer: Markus Mohrhard 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Peter Foley 
Gerrit-Reviewer: Peter Foley 
Gerrit-Reviewer: Tomáš Chvátal 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: cppunit/ExternalPackage_cppunit.mk cppunit/ExternalProject_cppunit.mk cppunit/Makefile cppunit/makefile.mk cppunit/Module_cppunit.mk cppunit/ooo-cppunit_dll.mk cppunit/ooo-Dll

 Module_tail_build.mk   |1 
 RepositoryExternal.mk  |6 +
 RepositoryModule_ooo.mk|1 
 cppunit/ExternalPackage_cppunit.mk |   43 
 cppunit/ExternalProject_cppunit.mk |   58 +++
 cppunit/Makefile   |7 +
 cppunit/Module_cppunit.mk  |   20 +++
 cppunit/UnpackedTarball_cppunit.mk |   33 ++
 cppunit/makefile.mk|  192 -
 cppunit/ooo-DllPlugInTester.mk |   50 -
 cppunit/ooo-cppunit_dll.mk |  100 ---
 cppunit/prj/d.lst  |   44 
 tail_build/prj/build.lst   |2 
 13 files changed, 170 insertions(+), 387 deletions(-)

New commits:
commit 143835b928d00b922c29471bbeca4772237b4df9
Author: Peter Foley 
Date:   Sun Nov 25 16:37:40 2012 -0500

convert cppunit to gbuild

Change-Id: Idcba54973940b9f197f2fd84a906b50468d1b166

diff --git a/Module_tail_build.mk b/Module_tail_build.mk
index 58eb4f5..ed471b8 100644
--- a/Module_tail_build.mk
+++ b/Module_tail_build.mk
@@ -55,6 +55,7 @@ $(eval $(call gb_Module_add_moduledirs,tail_build,\
cppcanvas \
cppu \
cppuhelper \
+   $(call gb_Helper_optional,CPPUNIT,cppunit) \
cpputools \
$(call gb_Helper_optional,CT2N,ct2n) \
cui \
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index fc307e3..f59c69a 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -149,9 +149,15 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO,\
 ))
 
 define gb_LinkTarget__use_cppunit
+$(call gb_LinkTarget_use_package,$(1),cppunit)
+
 $(call gb_LinkTarget_use_libraries,$(1),\
 cppunit \
 )
+$(call gb_LinkTarget_set_include,$(1),\
+   -I$(call gb_UnpackedTarball_get_dir,cppunit/include)\
+   $$(INCLUDE) \
+)
 
 endef
 
diff --git a/RepositoryModule_ooo.mk b/RepositoryModule_ooo.mk
index f860317..83347d2 100644
--- a/RepositoryModule_ooo.mk
+++ b/RepositoryModule_ooo.mk
@@ -59,6 +59,7 @@ $(eval $(call gb_Module_add_moduledirs,ooo,\
cppcanvas \
cppu \
cppuhelper \
+   $(call gb_Helper_optional,CPPUNIT,cppunit) \
cpputools \
$(call gb_Helper_optional,CT2N,ct2n) \
cui \
diff --git a/cppunit/ExternalPackage_cppunit.mk 
b/cppunit/ExternalPackage_cppunit.mk
new file mode 100644
index 000..3d8ab3f
--- /dev/null
+++ b/cppunit/ExternalPackage_cppunit.mk
@@ -0,0 +1,43 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+#
+
+$(eval $(call gb_ExternalPackage_ExternalPackage,cppunit,cppunit))
+$(eval $(call gb_ExternalPackage_use_external_project,cppunit,cppunit))
+
+ifeq ($(OS),WNT)
+ifeq ($(COM),MSC)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/cppunit_dll.dll,src/cppunit/ReleaseDll/cppunit_dll.dll))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/icppunit_dll.lib,src/cppunit/ReleaseDll/cppunit_dll.lib))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/DllPlugInTester_dll.exe,src/DllPlugInTester/ReleaseDll/DllPlugInTester_dll.exe))
+else
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/libcppunit-1-13-0.dll,src/cppunit/.libs/libcppunit-1-13-0.dll))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/cppunit.dll.a,src/cppunit/.libs/cppunit.dll.a))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/DllPlugInTester.exe,src/DllPlugInTester/.libs/DllPlugInTester.exe))
+endif
+else
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/DllPlugInTester,src/DllPlugInTester/.libs/DllPlugInTester))
+ifeq ($(OS),MACOSX)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,bin/libcppunit-1.13.0.dylib,src/cppunit/.libs/libcppunit-1.1.3.0.dylib))
+else ifeq ($(OS),AIX)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.a,src/cppunit/.libs/libcppunit-1.13.a))
+else ifeq ($(OS),OPENBSD)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.so.0.0,src/cppunit/.libs/libcppunit-1.13.so.0.0))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit.so,src/cppunit/.libs/libcppunit-1.13.so.0.0))
+else ifeq ($(DISABLE_DYNLOADING),TRUE)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit.a,src/cppunit/.libs/libcppunit.a))
+else ifeq ($(OS),ANDROID)
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.so,src/cppunit/.libs/libcppunit-1.13.so))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit.so,src/cppunit/.libs/libcppunit-1.13.so))
+else
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit-1.13.so.0,src/cppunit/.libs/libcppunit-1.13.so.0.0.1))
+$(eval $(call 
gb_ExternalPackage_add_file,cppunit,lib/libcppunit.so,src/cppunit/.libs/libcppunit-1.13.so.0.

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-06 Thread Cor Nouws


Hi Petr, *,

Petr Mladek wrote (06-12-12 12:16)

Cor Nouws píše v St 05. 12. 2012 v 10:53 +0100:



Beta1 build is in progress. Linux and MAC packages are even already
available at http://dev-builds.libreoffice.org/pre-releases/

I did some very basic testing yesterday and did not find any problem, so
I am much more optimistic now ;-)


Top!


Still the natural behaviour of devs to do a lot of work, push late
and take some risks, should be closely watched ;-)


I am afraid that we could not do much about this. We could encourage
but this is natural behavior for most people.


Yes, natural behaviour of people is a known problem ;-)


In fact, I want to say a big thank you to all developers. Of course,
there was some pain. But after all this has been the easiest beta1 from
my point of view in compare with older releases.


Great - thanks to all!


I think that testing from Thursday 13 to Wednesday 19th is perfectly fine and
beta1 state looks promising for it.


OK, will jump to it this evening.


Know that, but fail to read when freeze for RC1 is - or is that the
range Jan 7 - Jan 13, 2013 ?
That doesn't help much with strict planning of a QA event..


Heh, it describes real life. We used exact dates in the past but there
were delays of few days from time time. The typical proceeding is
described at http://wiki.documentfoundation.org/ReleasePlan#Dates. We
are one day behind with beta1 so far.


I understand the process and why it works as it does
Luckily we know now we will do the test with Beta1 and do not run into 
problems with waiting for RC2.



I am looking forward to see the test week/marathon happen. Thanks a lot
for organizing it.


You and we all deserve that attention. So I'm glad that I can contribute 
a little here.


Cheers,

--
--
 - Cor
 - http://nl.libreoffice.org
 - www.librelex.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: Change in core[master]: fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

2012-12-06 Thread Winfried Donkers

This time to the ML as well...



Winfried


> -Oorspronkelijk bericht-
> Van: Winfried Donkers
> Verzonden: donderdag 6 december 2012 12:52
> Aan: 'er...@redhat.com'
> Onderwerp: RE: Change in core[master]: fdo#56124 add calc functions
> IFERROR and IFNA as in ODFF1.2
> 
> Hi Eike,
> 
> > Van: Eike Rathke (via Code Review) wrote: donderdag 22 november 2012
> > 23:31
> 
> > I suggest you take a look at the implementation of ocIf and use a
> > similar approach with only one conditional path instead of two, for
> > which the condition is calculated from the expression's result whether
> > it is an error or not and then a jump is executed or not. There is
> > some special code in the compiler to calculate jump paths (lookout for
> > ocIf), and handling is different from normal functions in the
> > interpreter. Feel free to ask for details and pointers on the mailing list.
> 
> I agree that my submitted patch is inefficient when it always calculates both
> arguments.
> The simple examples of the function disfunctioning (I tested lots of
> arguments, but never tried direct calculations as an argument) could be
> remedied, but it would stay an inefficient function (sometimes even less
> efficient than IF(X;X;Y)).
> 
> So I followed your suggestion to work along the lines of ScIfJump/ocIf.
> These last 2 weeks I have not been able to get that working properly.
> To finally find out what goes wrong, I copied the contents of SCIfJump() into
> ScIfError(), made ocIfError do the same as ocIf (except in lotus/excel filter
> files) and gave IFERROR() 3 arguments (just as IF()).
> It still doesn't work: IFERROR(X;Y;Z) always returns Y, regardless of the 
> value
> of X. That is, if X produces an error (or Y, or Z), the error is returned.
> 
> What am I missing/messing up?
> I can upload the diff file to the bug, but possibly you can give some pointers
> without them.
> 
> Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 2 commits - sw/source

 sw/source/core/text/frmform.cxx  |2 -
 sw/source/core/text/itrtxt.cxx   |2 -
 sw/source/core/text/itrtxt.hxx   |8 +++
 sw/source/core/text/porfld.cxx   |   14 ++--
 sw/source/core/text/porfld.hxx   |6 ++---
 sw/source/core/text/porglue.cxx  |2 -
 sw/source/core/text/porlay.cxx   |   22 +--
 sw/source/core/text/porlay.hxx   |8 +++
 sw/source/core/text/porlin.cxx   |   14 ++--
 sw/source/core/text/porlin.hxx   |4 +--
 sw/source/core/text/pormulti.cxx |   43 +++
 sw/source/core/text/pormulti.hxx |   12 --
 sw/source/core/text/txtfrm.cxx   |2 -
 sw/source/core/text/widorp.cxx   |2 -
 14 files changed, 69 insertions(+), 72 deletions(-)

New commits:
commit 8909b2c384154baa2174aa53b433b12b02871e75
Author: Takeshi Abe 
Date:   Thu Dec 6 21:00:22 2012 +0900

Drop unused declaration

Change-Id: I8673787aac659acfc638b3040a6178e6c21a51f7

diff --git a/sw/source/core/text/pormulti.cxx b/sw/source/core/text/pormulti.cxx
index 7180f77..c392c78 100644
--- a/sw/source/core/text/pormulti.cxx
+++ b/sw/source/core/text/pormulti.cxx
@@ -49,7 +49,6 @@
 #include 
 
 using namespace ::com::sun::star;
-extern sal_Bool IsUnderlineBreak( const SwLinePortion& rPor, const SwFont& 
rFnt );
 
 /*--
  *  class SwMultiPortion
commit 6488d6941dd25f49aa3254f38a5f3185f2fd3e5e
Author: Takeshi Abe 
Date:   Thu Dec 6 20:59:29 2012 +0900

sal_Bool to bool

Change-Id: I942cad6ec0e06d4f98fdf8e2557e11603b951e7f

diff --git a/sw/source/core/text/frmform.cxx b/sw/source/core/text/frmform.cxx
index 16641e7..698cf95 100644
--- a/sw/source/core/text/frmform.cxx
+++ b/sw/source/core/text/frmform.cxx
@@ -984,7 +984,7 @@ void SwTxtFrm::FormatAdjust( SwTxtFormatter &rLine,
 
 if( rLine.IsStop() )
 {
-rLine.TruncLines( sal_True );
+rLine.TruncLines( true );
 nNew = 1;
 }
 
diff --git a/sw/source/core/text/itrtxt.cxx b/sw/source/core/text/itrtxt.cxx
index a091b2c..59e916a 100644
--- a/sw/source/core/text/itrtxt.cxx
+++ b/sw/source/core/text/itrtxt.cxx
@@ -386,7 +386,7 @@ static sal_Bool lcl_NeedsFieldRest( const SwLineLayout* 
pCurr )
  *  SwTxtIter::TruncLines()
  */
 
-void SwTxtIter::TruncLines( sal_Bool bNoteFollow )
+void SwTxtIter::TruncLines( bool bNoteFollow )
 {
 SwLineLayout *pDel = pCurr->GetNext();
 const xub_StrLen nEnd = nStart + pCurr->GetLen();
diff --git a/sw/source/core/text/itrtxt.hxx b/sw/source/core/text/itrtxt.hxx
index 1f8cdcf..cd56e8e 100644
--- a/sw/source/core/text/itrtxt.hxx
+++ b/sw/source/core/text/itrtxt.hxx
@@ -98,18 +98,18 @@ public:
 const SwLineLayout *TwipsToLine(const SwTwips);
 
 // Truncates all after pCurr
-void TruncLines( sal_Bool bNoteFollow = sal_False );
+void TruncLines( bool bNoteFollow = false );
 
 inline KSHORT GetLineHeight() const { return pCurr->GetRealHeight(); }
 void CalcAscentAndHeight( KSHORT &rAscent, KSHORT &rHeight ) const;
 
 // Lots of trouble for querying pCurr == pPara
-inline sal_Bool IsFirstTxtLine() const
+inline bool IsFirstTxtLine() const
 { return nStart == GetInfo().GetTxtStart() &&
 !( pCurr->IsDummy() && GetNextLine() ); }
 
 // Replacement for the old IsFirstLine()
-inline sal_Bool IsParaLine() const
+inline bool IsParaLine() const
 { return pCurr == pInf->GetParaPortion(); }
 
 const SwLineInfo &GetLineInfo() const { return aLineInf; }
@@ -169,7 +169,7 @@ public:
 inline KSHORT GetLineWidth() const
{ return KSHORT( Right() - GetLeftMargin() + 1 ); }
 inline SwTwips GetLeftMin() const { return nFirst < nLeft ? nFirst : 
nLeft; }
-inline sal_Bool HasNegFirst() const { return nFirst < nLeft; }
+inline bool HasNegFirst() const { return nFirst < nLeft; }
 
 // #i91133#
 inline SwTwips GetTabLeft() const
diff --git a/sw/source/core/text/porfld.cxx b/sw/source/core/text/porfld.cxx
index b018ca8..94d3986 100644
--- a/sw/source/core/text/porfld.cxx
+++ b/sw/source/core/text/porfld.cxx
@@ -299,7 +299,7 @@ sal_Bool SwFldPortion::Format( SwTxtFormatInfo &rInf )
 // Scope wegen aDiffTxt::DTOR!
 xub_StrLen nRest;
 sal_Bool bFull;
-sal_Bool bEOL = sal_False;
+bool bEOL = false;
 long nTxtRest = rInf.GetTxt().Len() - rInf.GetIdx();
 {
 SwFldSlot aDiffTxt( &rInf, this );
@@ -618,7 +618,7 @@ sal_Bool SwNumberPortion::Format( SwTxtFormatInfo &rInf )
 // fieser Sonderfall: FlyFrm liegt in dem Bereich,
 // den wir uns gerade unter den Nagel reissen wollen.
 // Die NumberPortion wird als verborgen markiert.
-const sal_Bool bFly = rInf.GetFly() ||
+const bool bFly = rInf.GetFly() ||
 ( rInf.GetLast() && rInf.GetLast()->IsFlyPortion() );
 if( nDiff > rInf.Width() )
 {
@@ -704,7

Personas in LibreOffice

2012-12-06 Thread Marcos Souza

Hi list,

After take a look in some commits in LO about the FFox Personas, I saw that
this is only for Windows until now...

There is a reason for that?

There is something that we can do for extend this for Linux users?

I belvei that's a nice feature for LO! Congrats to the authors!

Thanks a lot!

-- 
Att,

Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
Github: https://github.com/marcosps/
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Default Styles in Writer

2012-12-06 Thread Niklas Johansson


Hi Samuel

This is pretty much the issue I tried to raise in the UX-discussion.
- Applied styles are shown in the ComboBox (a good thing)
- A style that is the basis for another style is seen as Applied
  and is thus shown in the ComboBox (what I questioned)
- The Default Style is the basis for all other styles (not a bad thing)
  and thus it is *always* shown in the ComboBox (not so nice)

An important point, I believe, is that, if in fact the Default Style
is explicitly used in the document it should be shown in the
ComboBox.
So, for this to work I believe the logic behind what is added in the
ComboBox at run time needs to changed. I wouldn't mind being
proven wrong though. ;)

Nice job with the default set of styles though.

Regards,
Niklas Johansson

Samuel Mehrbrodt skrev 2012-12-06 09:33:

Hi,

I have submitted a patch changing the list of default Styles in the
Toolbar in Writer [1].

Now, we [2] also wanted to remove the entry "Default Style" from the
list, but removing "Standard" in the code didn't do that.
Can anyone point me in the right direction where this is added?

Thanks,
Samuel

[1] https://gerrit.libreoffice.org/1248
[2]
http://nabble.documentfoundation.org/Libreoffice-ux-advise-Default-Styles-in-Writer-td4020441.html
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=54157

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||57946

--- Comment #42 from Rainer Bielefeld  ---
I add "Bug 57946 - EDITING CRASH in menu 'Format - Conditional Formatting -
Contition - Condition'", looks like a blocker

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sw/source

 sw/source/filter/ww8/docxattributeoutput.cxx |   14 ++--
 sw/source/filter/ww8/rtfexport.cxx   |3 
 sw/source/filter/ww8/writerwordglue.cxx  |2 
 sw/source/filter/ww8/wrtw8esh.cxx|4 -
 sw/source/filter/ww8/wrtw8nds.cxx|   28 
 sw/source/filter/ww8/wrtww8gr.cxx|4 -
 sw/source/filter/ww8/ww8atr.cxx  |   92 +--
 sw/source/filter/ww8/ww8par5.cxx |8 +-
 sw/source/filter/ww8/ww8scan.cxx |2 
 sw/source/filter/ww8/ww8scan.hxx |7 --
 10 files changed, 78 insertions(+), 86 deletions(-)

New commits:
commit 4839c0ab201fd4dd7b32a5d6c9f6e202a88ad09d
Author: Miklos Vajna 
Date:   Thu Dec 6 12:41:46 2012 +0100

sw: kill RTL_CONSTASCII_STRINGPARAM and friends in ww8 filters

diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx 
b/sw/source/filter/ww8/docxattributeoutput.cxx
index b4dbee9..8414e60 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -847,9 +847,9 @@ void DocxAttributeOutput::EndField_Impl( FieldInfos& rInfos 
)
 m_pSerializer->endElementNS( XML_w, XML_r );
 
 rInfos.sCmd = FieldString( ww::eREF );
-rInfos.sCmd.APPEND_CONST_ASC( "\"" );
+rInfos.sCmd.AppendAscii( "\"" );
 rInfos.sCmd += m_sFieldBkm;
-rInfos.sCmd.APPEND_CONST_ASC( "\" " );
+rInfos.sCmd.AppendAscii( "\" " );
 
 // Clean the field bookmark data to avoid infinite loop
 m_sFieldBkm = String( );
@@ -1166,16 +1166,16 @@ bool DocxAttributeOutput::AnalyzeURL( const String& 
rUrl, const String& rTarget,
 else
 {
 String sFld( FieldString( ww::eHYPERLINK ) );
-sFld.APPEND_CONST_ASC( "\"" );
+sFld.AppendAscii( "\"" );
 sURL.Insert( sFld, 0 );
 sURL += '\"';
 }
 
 if ( sMark.Len() )
-( ( sURL.APPEND_CONST_ASC( " \\l \"" ) ) += sMark ) += '\"';
+( ( sURL.AppendAscii( " \\l \"" ) ) += sMark ) += '\"';
 
 if ( rTarget.Len() )
-( sURL.APPEND_CONST_ASC( " \\n " ) ) += rTarget;
+( sURL.AppendAscii( " \\n " ) ) += rTarget;
 }
 
 *pLinkURL = sURL;
@@ -3545,9 +3545,9 @@ void DocxAttributeOutput::RefField( const SwField&  rFld, 
const String& rRef )
 if ( nType == RES_GETEXPFLD )
 {
 String sCmd = FieldString( ww::eREF );
-sCmd.APPEND_CONST_ASC( "\"" );
+sCmd.AppendAscii( "\"" );
 sCmd += rRef;
-sCmd.APPEND_CONST_ASC( "\" " );
+sCmd.AppendAscii( "\" " );
 
 m_rExport.OutputField( &rFld, ww::eREF, sCmd );
 }
diff --git a/sw/source/filter/ww8/rtfexport.cxx 
b/sw/source/filter/ww8/rtfexport.cxx
index 8259d59..0d874d8 100644
--- a/sw/source/filter/ww8/rtfexport.cxx
+++ b/sw/source/filter/ww8/rtfexport.cxx
@@ -245,8 +245,7 @@ void RtfExport::WriteRevTab()
 return;
 
 // RTF always seems to use Unknown as the default first entry
-String sUnknown(RTL_CONSTASCII_USTRINGPARAM("Unknown"));
-GetRedline(sUnknown);
+GetRedline(OUString("Unknown"));
 
 for( sal_uInt16 i = 0; i < pDoc->GetRedlineTbl().size(); ++i )
 {
diff --git a/sw/source/filter/ww8/writerwordglue.cxx 
b/sw/source/filter/ww8/writerwordglue.cxx
index 9a843dd..3ae8a1c 100644
--- a/sw/source/filter/ww8/writerwordglue.cxx
+++ b/sw/source/filter/ww8/writerwordglue.cxx
@@ -46,7 +46,7 @@
 #include//pBreakIt
 #include 
 
-#define ASSIGN_CONST_ASC(s) AssignAscii(RTL_CONSTASCII_STRINGPARAM(s))
+#define ASSIGN_CONST_ASC(s) AssignAscii(s)
 
 namespace myImplHelpers
 {
diff --git a/sw/source/filter/ww8/wrtw8esh.cxx 
b/sw/source/filter/ww8/wrtw8esh.cxx
index 6262238..719d8e6 100644
--- a/sw/source/filter/ww8/wrtw8esh.cxx
+++ b/sw/source/filter/ww8/wrtw8esh.cxx
@@ -2844,9 +2844,9 @@ bool SwMSConvertControls::ExportControl(WW8Export 
&rWW8Wrt, const SdrObject *pOb
 Set_UInt32(pData,nObjId );
 
 String sFld(FieldString(ww::eCONTROL));
-sFld.APPEND_CONST_ASC("Forms.");
+sFld.AppendAscii("Forms.");
 sFld += sName;
-sFld.APPEND_CONST_ASC(".1 \\s ");
+sFld.AppendAscii(".1 \\s ");
 
 rWW8Wrt.OutputField(0, ww::eCONTROL, sFld,
 WRITEFIELD_START|WRITEFIELD_CMD_START|WRITEFIELD_CMD_END);
diff --git a/sw/source/filter/ww8/wrtw8nds.cxx 
b/sw/source/filter/ww8/wrtw8nds.cxx
index 9320e70..aabd3f3 100644
--- a/sw/source/filter/ww8/wrtw8nds.cxx
+++ b/sw/source/filter/ww8/wrtw8nds.cxx
@@ -627,7 +627,7 @@ const SfxPoolItem& SwWW8AttrIter::GetItem(sal_uInt16 
nWhich) const
 void WW8AttributeOutput::StartRuby( const SwTxtNode& rNode, xub_StrLen 
/*nPos*/, const SwFmtRuby& rRuby )
 {
 String aStr( FieldString( ww::eEQ ) );
-aStr.APPEND_CONST_ASC( "\\* jc" );
+aStr.AppendAscii( "\\* jc" );
 sal_Int32 nJC = 0;
 sal_Char cDirective = 0;
 switch ( rRuby.GetAdjustment() )
@@ -701,17 +701,17 @@ void

[Libreoffice-commits] .: dbaccess/source extensions/source svtools/source

 dbaccess/source/core/dataaccess/databasecontext.cxx  |2 -
 dbaccess/source/inc/stringconstants.hrc  |1 
 dbaccess/source/inc/stringconstants.inc  |1 
 dbaccess/source/ui/browser/genericcontroller.cxx |8 ++-
 dbaccess/source/ui/dlg/DbAdminImpl.cxx   |8 +--
 extensions/source/propctrlr/formcomponenthandler.cxx |   20 +++
 extensions/source/propctrlr/formstrings.hxx  |1 
 svtools/source/dialogs/addresstemplate.cxx   |3 --
 8 files changed, 15 insertions(+), 29 deletions(-)

New commits:
commit 495111b249e1ef17be96dbdfbc5a13de6d5dd5f9
Author: Noel Grandin 
Date:   Mon Dec 3 11:10:46 2012 +0200

fdo#46808, use service constructor for sdb::DatabaseContext

Change-Id: I4d845f289f324912b0fc4d8e26a2947e2d2f889e

diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx 
b/dbaccess/source/core/dataaccess/databasecontext.cxx
index 798262f..c4c625f 100644
--- a/dbaccess/source/core/dataaccess/databasecontext.cxx
+++ b/dbaccess/source/core/dataaccess/databasecontext.cxx
@@ -218,7 +218,7 @@ Reference< XInterface > ODatabaseContext::Create(const 
Reference< XComponentCont
 Sequence< rtl::OUString > 
ODatabaseContext::getSupportedServiceNames_static(void) throw( RuntimeException 
)
 {
 Sequence< ::rtl::OUString > aSNS( 1 );
-aSNS[0] = SERVICE_SDB_DATABASECONTEXT;
+aSNS[0] = "com.sun.star.sdb.DatabaseContext";
 return aSNS;
 }
 
diff --git a/dbaccess/source/inc/stringconstants.hrc 
b/dbaccess/source/inc/stringconstants.hrc
index d8a9ceb..6926f60 100644
--- a/dbaccess/source/inc/stringconstants.hrc
+++ b/dbaccess/source/inc/stringconstants.hrc
@@ -355,7 +355,6 @@ DECLARE_CONSTASCII_USTRING(SERVICE_SDB_COLUMNSETTINGS);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_RESULTCOLUMN);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_DATACOLUMN);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_DATAACCESSCONNECTION);
-DECLARE_CONSTASCII_USTRING(SERVICE_SDB_DATABASECONTEXT);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_DATASOURCE);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_ROWSET);
 DECLARE_CONSTASCII_USTRING(SERVICE_SDB_RESULTSET);
diff --git a/dbaccess/source/inc/stringconstants.inc 
b/dbaccess/source/inc/stringconstants.inc
index 9d6e79e..010fd63 100644
--- a/dbaccess/source/inc/stringconstants.inc
+++ b/dbaccess/source/inc/stringconstants.inc
@@ -193,7 +193,6 @@ 
IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDBCX_COLUMNDESCRIPTOR, "com.sun.star.sdbcx
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_COLUMNSETTINGS, 
"com.sun.star.sdb.ColumnSettings");
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_RESULTCOLUMN, 
"com.sun.star.sdb.ResultColumn");
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_DATACOLUMN, 
"com.sun.star.sdb.DataColumn");
-IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_DATABASECONTEXT, 
"com.sun.star.sdb.DatabaseContext");
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_DATASOURCE, 
"com.sun.star.sdb.DataSource");
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_RESULTSET, 
"com.sun.star.sdb.ResultSet");
 IMPLEMENT_CONSTASCII_USTRING(SERVICE_SDB_ROWSET, "com.sun.star.sdb.RowSet");
diff --git a/dbaccess/source/ui/browser/genericcontroller.cxx 
b/dbaccess/source/ui/browser/genericcontroller.cxx
index 58345e6..76df18a 100644
--- a/dbaccess/source/ui/browser/genericcontroller.cxx
+++ b/dbaccess/source/ui/browser/genericcontroller.cxx
@@ -258,15 +258,13 @@ sal_Bool OGenericUnoController::Construct(Window* 
/*pParent*/)
 {
 m_xDatabaseContext = 
DatabaseContext::create(comphelper::getComponentContext(getORB()));
 }
-catch(Exception&)
+catch(const Exception&)
 {
 OSL_FAIL("OGenericUnoController::Construct: could not create (or start 
listening at) the database context!");
+// at least notify the user. Though the whole component does not make 
any sense without the database context ...
+ShowServiceNotAvailableError(getView(), 
String("com.sun.star.sdb.DatabaseContext"), sal_True);
 }
 
-if (!m_xDatabaseContext.is())
-{   // at least notify the user. Though the whole component does not 
make any sense without the database context ...
-ShowServiceNotAvailableError(getView(), 
String(SERVICE_SDB_DATABASECONTEXT), sal_True);
-}
 return sal_True;
 }
 
//--
diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx 
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index 9082417..2b5cbfe 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -210,13 +210,9 @@ 
ODbDataSourceAdministrationHelper::ODbDataSourceAdministrationHelper(const Refer
 {
 m_xDatabaseContext = 
DatabaseContext::create(comphelper::getComponentContext(m_xORB));
 }
-catch(Exception&)
-{
-}
-
-if ( !m_xDatabaseContext.is() )
+catch(const Exception&)
 {
-ShowServiceNotAvailableError(_pParent->GetParent(), 
String(SERVICE_SDB_DATABASECONTEXT), sal_True);
+S

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - instsetoo_native/util solenv/inc

 instsetoo_native/util/openoffice.lst |   40 +--
 solenv/inc/minor.mk  |4 +--
 2 files changed, 22 insertions(+), 22 deletions(-)

New commits:
commit 97b53a963938ddb6b8ddf31c05ebd6e8978e8610
Author: Petr Mladek 
Date:   Thu Dec 6 12:35:37 2012 +0100

bump product version to 4.0.0.0.beta1+, release number to 11

Change-Id: If808aa6a21d81cee563ac07b83f3446e5d488f88

diff --git a/instsetoo_native/util/openoffice.lst 
b/instsetoo_native/util/openoffice.lst
index 2f1ccf8..db88de9 100644
--- a/instsetoo_native/util/openoffice.lst
+++ b/instsetoo_native/util/openoffice.lst
@@ -4,7 +4,7 @@ Globals
 {
 variables
 {
-UREPACKAGEVERSION 4.0.0.0.alpha1
+UREPACKAGEVERSION 4.0.0.0.beta1
 URELAYERVERSION 1
 REFERENCEOOOMAJORMINOR 3.4
 UNIXBASISROOTNAME libreoffice4.0
@@ -50,12 +50,12 @@ LibreOffice
 PRODUCTVERSION 4.0
 PRODUCTEXTENSION
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 POSTVERSIONEXTENSION
 POSTVERSIONEXTENSIONUNIX
 BRANDPACKAGEVERSION 4.0
 USERDIRPRODUCTVERSION 4
-ABOUTBOXPRODUCTVERSION 4.0.0.0.alpha1
+ABOUTBOXPRODUCTVERSION 4.0.0.0.beta1
 ABOUTBOXPRODUCTVERSIONSUFFIX +
 BASEPRODUCTVERSION 4.0
 PCPFILENAME libreoffice.pcp
@@ -65,7 +65,7 @@ LibreOffice
 FILEFORMATNAME OpenOffice.org
 FILEFORMATVERSION 1.0
 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION {buildid}
 LICENSENAME LGPL
 GLOBALFILEGID gid_File_Lib_Vcl
@@ -102,13 +102,13 @@ LibreOffice_Dev
 PRODUCTVERSION 4.0
 PRODUCTEXTENSION
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 UNIXBASISROOTNAME lodev4.0
 POSTVERSIONEXTENSION
 POSTVERSIONEXTENSIONUNIX
 BRANDPACKAGEVERSION 4.0
 USERDIRPRODUCTVERSION 4
-ABOUTBOXPRODUCTVERSION 4.0.0.0.alpha1
+ABOUTBOXPRODUCTVERSION 4.0.0.0.beta1
 ABOUTBOXPRODUCTVERSIONSUFFIX +
 BASEPRODUCTVERSION 4.0
 DEVELOPMENTPRODUCT 1
@@ -123,7 +123,7 @@ LibreOffice_Dev
 FILEFORMATNAME OpenOffice.org
 FILEFORMATVERSION 1.0
 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION {buildid}
 LICENSENAME LGPL
 GLOBALFILEGID gid_File_Lib_Vcl
@@ -161,12 +161,12 @@ URE
 {
 PRODUCTNAME URE
 PRODUCTVERSION 4.0
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION 1
 PRODUCTEXTENSION
 BRANDPACKAGEVERSION 4.0
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 LICENSENAME LGPL
 NOVERSIONINDIRNAME 1
 PCPFILENAME ure.pcp
@@ -198,11 +198,11 @@ LibreOffice_SDK
 PRODUCTVERSION 4.0
 PRODUCTEXTENSION
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 POSTVERSIONEXTENSION SDK
 POSTVERSIONEXTENSIONUNIX sdk
 BRANDPACKAGEVERSION 4.0
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION {buildid}
 PACK_INSTALLED 1
 DMG_VOLUMEEXTENSION SDK
@@ -239,12 +239,12 @@ LibreOffice_Dev_SDK
 PRODUCTVERSION 4.0
 PRODUCTEXTENSION
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 UNIXBASISROOTNAME lodev4.0
 POSTVERSIONEXTENSION SDK
 POSTVERSIONEXTENSIONUNIX sdk
 BRANDPACKAGEVERSION 4.0
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION {buildid}
 BASISPACKAGEPREFIX lodevbasis
 UREPACKAGEPREFIX lodev
@@ -286,11 +286,11 @@ LibreOffice_Test
 PRODUCTVERSION 4.0
 PRODUCTEXTENSION
 LONG_PRODUCTEXTENSION
-SHORT_PRODUCTEXTENSION .0.0.alpha1
+SHORT_PRODUCTEXTENSION .0.0.beta1
 POSTVERSIONEXTENSION TEST
 POSTVERSIONEXTENSIONUNIX test
 BRANDPACKAGEVERSION 4.0
-PACKAGEVERSION 4.0.0.0.alpha1
+PACKAGEVERSION 4.0.0.0.beta1
 PACKAGEREVISION {buildid}

[PUSHED] Translate German comments in tbcontrl.cxx

2012-12-06 Thread Michael Stahl (via Code Review)

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1249

Approvals:
  Michael Stahl: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/1249
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I071feef9c7df4ad5ab72cd9caef5cbcbec1ae53d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Samuel Mehrbrodt 
Gerrit-Reviewer: Michael Stahl 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: svx/source

 svx/source/tbxctrls/tbcontrl.cxx |   67 +--
 1 file changed, 30 insertions(+), 37 deletions(-)

New commits:
commit 1faac45905a2dc28b36f7957cb008e8c0e7fa3c1
Author: Samuel Mehrbrodt 
Date:   Wed Dec 5 21:37:32 2012 +0100

Translate German comments in tbcontrl.cxx

Change-Id: I071feef9c7df4ad5ab72cd9caef5cbcbec1ae53d
Reviewed-on: https://gerrit.libreoffice.org/1249
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 05f2b08..8c7d0d2 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -133,7 +133,7 @@ public:
 ~SvxStyleBox_Impl();
 
 voidSetFamily( SfxStyleFamily eNewFamily );
-inline sal_Bool IsVisible() { return bVisible; }
+inline sal_Bool IsVisible() { return bVisible; }
 
 virtual longPreNotify( NotifyEvent& rNEvt );
 virtual longNotify( NotifyEvent& rNEvt );
@@ -153,18 +153,18 @@ protected:
 
 private:
 SfxStyleFamily  eStyleFamily;
-sal_uInt16  nCurSel;
-sal_BoolbRelease;
+sal_uInt16  nCurSel;
+sal_BoolbRelease;
 SizeaLogicalSize;
 LinkaVisibilityListener;
-sal_BoolbVisible;
+sal_BoolbVisible;
 Reference< XDispatchProvider >  m_xDispatchProvider;
 Reference< XFrame > m_xFrame;
 OUStringm_aCommand;
 String  aClearFormatKey;
 String  aMoreKey;
 String  sDefaultStyle;
-sal_BoolbInSpecialMode;
+sal_BoolbInSpecialMode;
 
 voidReleaseFocus();
 };
@@ -184,8 +184,8 @@ private:
 Font   aCurFont;
 Size   aLogicalSize;
 String aCurText;
-sal_uInt16 nFtCount;
-sal_Bool   bRelease;
+sal_uInt16 nFtCount;
+sal_Bool   bRelease;
 Reference< XDispatchProvider > m_xDispatchProvider;
 Reference< XFrame >m_xFrame;
 
@@ -203,7 +203,7 @@ public:
 
 voidFillList();
 voidUpdate( const SvxFontItem* pFontItem );
-sal_uInt16  GetListCount() { return nFtCount; }
+sal_uInt16  GetListCount() { return nFtCount; }
 voidClear() { FontNameBox::Clear(); nFtCount = 0; }
 voidFill( const FontList* pList )
 { FontNameBox::Fill( pList );
@@ -220,8 +220,7 @@ public:
 // class SvxFrameWindow_Impl --
 //
 
-// fuer den SelectHdl werden die Modifier gebraucht, also
-// muss man sie im MouseButtonUp besorgen
+// SelectHdl needs the Modifiers, get them in MouseButtonUp
 
 class SvxFrmValueSet_Impl : public ValueSet
 {
@@ -292,7 +291,7 @@ public:
 };
 
 //
-// Hilfsklassen:
+// Helper classes:
 //
 // class SfxStyleControllerItem --
 //
@@ -705,23 +704,23 @@ sal_Bool GetDocFontList_Impl( const FontList** 
ppFontList, SvxFontNameBox_Impl*
 const FontList* pNewFontList = pFontListItem->GetFontList();
 DBG_ASSERT( pNewFontList, "Doc-FontList not available!" );
 
-// keine alte Liste, aber neue Liste
+// No old list, but a new list
 if ( !*ppFontList && pNewFontList )
 {
-// => "ubernehmen
+// => take over
 *ppFontList = pNewFontList;
 bChanged = sal_True;
 }
 else
 {
-// Vergleich der Fontlisten ist nicht vollkommen
-// wird die Fontliste am Doc geaendert, kann man hier
-// nur ueber die Listbox Aenderungen feststellen, weil
-// ppFontList dabei schon upgedatet wurde
+// Comparing the font lists is not perfect.
+// When you change the font list in the Doc, you can track
+// changes here only on the Listbox, because ppFontList
+// has already been updated.
 bChanged =
 ( ( *ppFontList != pNewFontList ) ||
   pBox->GetListCount() != pNewFontList->GetFontNameCount() );
-// HACK(vergleich ist unvollstaendig) ???
+// HACK: Comparing is incomplete
 
 if ( bChanged )
 *ppFontList = pNewF

Re: [ANNOUNCE] libreoffice-4.0.0.0.beta1 tag created

2012-12-06 Thread Petr Mladek

Petr Mladek píše v St 05. 12. 2012 v 18:31 +0100:
> Hi,
> 
> there have been created the libreoffice-4.0.0.0.beta1 tag. The
> corresponding official builds will be available within next few days.
> 
> See the attached list of changes against 4.0.0.0.alpha1[*]
> See also http://wiki.documentfoundation.org/ReleaseNotes/4.0

> [*] I am going to upload the list of changes against 3.6.4.3 tomorrow. It is a
> long list and it takes quite some time to filter cherry-picked commits
> and get list of bugzilla entries even by a script :-)

You might find the list of commits and fixed bugs against 4.6.4.3 is at
http://dev-builds.libreoffice.org/pre-releases/src/commits-libreoffice-4-0-release-4.0.0.0.beta1.log
http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-4-0-release-4.0.0.0.beta1.log

The script used "git cherry" to filer cherry-picked commits. I hope that
it did it correctly ;-)

Anyway, much more interesting are the releases notes at 
http://wiki.documentfoundation.org/ReleaseNotes/4.0 at this point.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-06 Thread Petr Mladek

Cor Nouws píše v St 05. 12. 2012 v 10:53 +0100:
> Hi Michael,
> 
> Michael Meeks wrote (05-12-12 10:34)
> 
> > So - my hope would be that our Beta1 would be of a better quality than
> > previous betas out of the door :-) but lets see.
> 
> Yep - fully agree with even such an expectation.

Beta1 build is in progress. Linux and MAC packages are even already
available at http://dev-builds.libreoffice.org/pre-releases/

I did some very basic testing yesterday and did not find any problem, so
I am much more optimistic now ;-)

Why was I so careful? If you look at
http://dev-builds.libreoffice.org/pre-releases/src/commits-libreoffice-4-0-release-4.0.0.0-alpha1-to-beta1.log
there were about 1350 commits between alpha1 and beta1. Master was
hardly buidable entire Monday and big part of Tuesday. I wanted to be
rather careful with any promises and estimations.

> Still the natural behaviour of devs to do a lot of work, push late
> and take some risks, should be closely watched ;-)

I am afraid that we could not do much about this. We could encourage
but this is natural behavior for most people.

In fact, I want to say a big thank you to all developers. Of course,
there was some pain. But after all this has been the easiest beta1 from
my point of view in compare with older releases.

I think that testing from Thursday 13 to Wednesday 19th is perfectly fine and
beta1 state looks promising for it.


> >> When is the freeze for RC1 planned? It would be useful to have testing
> >> done so that the devs that are available, could do something with the
> >> result before the RC1?
> >
> > Quite; I think the details you want are all in the wiki:
> > http://wiki.documentfoundation.org/ReleasePlan/4.0
> 
> Know that, but fail to read when freeze for RC1 is - or is that the 
> range Jan 7 - Jan 13, 2013 ?
> That doesn't help much with strict planning of a QA event..

Heh, it describes real life. We used exact dates in the past but there
were delays of few days from time time. The typical proceeding is
described at http://wiki.documentfoundation.org/ReleasePlan#Dates. We
are one day behind with beta1 so far.

I am looking forward to see the test week/marathon happen. Thanks a lot
for organizing it.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Default Styles in Writer

2012-12-06 Thread Samuel Mehrbrodt

Hi Cedric,

I don't want to remove "Default Style" completely, I just want to remove it
from the "Styles" ComboBox in the toolbar in Writer.
Sorry for being unclear.

Samuel


2012/12/6 Cedric Bosdonnat 

> Hello Samuel,
>
> On Thu, 2012-12-06 at 09:33 +0100, Samuel Mehrbrodt wrote:
> > I have submitted a patch changing the list of default Styles in the
> > Toolbar in Writer [1].
> >
> > Now, we [2] also wanted to remove the entry "Default Style" from the
> > list, but removing "Standard" in the code didn't do that.
> > Can anyone point me in the right direction where this is added?
>
> Removing that style is pretty tricky as it holds quite some things on
> its shoulders. Why not start by hiding it by default now that we can
> hide styles?
>
> There are several concerns with this removal:
>   * Display name of pooled styles is tightly bound with the display of
> the style in the "Styles & Formatting" dialog. You can't just remove it
> plainly as it would prevent to show the style when editing existing
> documents.
>   * This particular styles holds the styles configuration (See Tools >
> Options... dialog, LibreOffice Writer > Basic Fonts items.
>   * Almost all other paragraph styles are inheriting from this one
>
> What is so bad with this style? If you really want to remove pooled
> styles, start with the ListXXX paragraph styles.
>
> Regards,
>
> --
> Cedric
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sd/source

 sd/source/ui/remotecontrol/BluetoothServer.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 584cd8d1c23d47becb776e382f853ffe77ce9fc2
Author: Noel Grandin 
Date:   Thu Dec 6 13:00:22 2012 +0200

Fix:  needs to be included under Linux

Change-Id: I00cbeaa3d00b6001b1b9adf00059f27d7affb08f

diff --git a/sd/source/ui/remotecontrol/BluetoothServer.cxx 
b/sd/source/ui/remotecontrol/BluetoothServer.cxx
index 6ec590d..32e5bca 100644
--- a/sd/source/ui/remotecontrol/BluetoothServer.cxx
+++ b/sd/source/ui/remotecontrol/BluetoothServer.cxx
@@ -14,6 +14,7 @@
 #if (defined(LINUX) && !defined(__FreeBSD_kernel__)) && defined(ENABLE_DBUS)
   #include 
   #include 
+  #include 
   #include 
   #include 
   #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Default Styles in Writer

2012-12-06 Thread Cedric Bosdonnat

Hello Samuel,

On Thu, 2012-12-06 at 09:33 +0100, Samuel Mehrbrodt wrote:
> I have submitted a patch changing the list of default Styles in the
> Toolbar in Writer [1].
> 
> Now, we [2] also wanted to remove the entry "Default Style" from the
> list, but removing "Standard" in the code didn't do that.
> Can anyone point me in the right direction where this is added?

Removing that style is pretty tricky as it holds quite some things on
its shoulders. Why not start by hiding it by default now that we can
hide styles?

There are several concerns with this removal:
  * Display name of pooled styles is tightly bound with the display of
the style in the "Styles & Formatting" dialog. You can't just remove it
plainly as it would prevent to show the style when editing existing
documents.
  * This particular styles holds the styles configuration (See Tools >
Options... dialog, LibreOffice Writer > Basic Fonts items.
  * Almost all other paragraph styles are inheriting from this one

What is so bad with this style? If you really want to remove pooled
styles, start with the ListXXX paragraph styles.

Regards,

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sd/source

 sd/source/ui/remotecontrol/BluetoothServer.cxx |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit ec530530b7c4afbc7b521aaf05ac4e3d527fdf7e
Author: Stephan Bergmann 
Date:   Thu Dec 6 11:38:03 2012 +0100

Fix Linux-specific code

Change-Id: I36971b78dcc2fb0ab8570c8b80feb51bf6043e54

diff --git a/sd/source/ui/remotecontrol/BluetoothServer.cxx 
b/sd/source/ui/remotecontrol/BluetoothServer.cxx
index 2559417..6ec590d 100644
--- a/sd/source/ui/remotecontrol/BluetoothServer.cxx
+++ b/sd/source/ui/remotecontrol/BluetoothServer.cxx
@@ -316,16 +316,17 @@ void SAL_CALL BluetoothServer::run()
 socklen_t  aRemoteAddrLen = sizeof(aRemoteAddr);
 while ( true )
 {
-SOCKET socket;
+int bSocket;
 SAL_INFO( "sdremote.bluetooth", "waiting on accept" );
-if ( (socket = accept(aSocket, (sockaddr*) &aRemoteAddr, 
&aRemoteAddrLen)) == INVALID_SOCKET )
+if ( (bSocket = accept(aSocket, (sockaddr*) &aRemoteAddr, 
&aRemoteAddrLen)) < 0 )
 {
-SAL_WARN( "sdremote.bluetooth", "accept failed with error " << 
WSAGetLastError() );
+int err = errno;
+SAL_WARN( "sdremote.bluetooth", "accept failed with errno " << err 
);
 close( aSocket );
 return;
 } else {
 SAL_INFO( "sdremote.bluetooth", "connection accepted" );
-Communicator* pCommunicator = new Communicator( new 
BufferedStreamSocket( socket ) );
+Communicator* pCommunicator = new Communicator( new 
BufferedStreamSocket( bSocket ) );
 mpCommunicators->push_back( pCommunicator );
 pCommunicator->launch();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: cui/source cui/uiconfig