[PATCH] default to --without-help and --without-myspell-dicts

2013-01-20 Thread Norbert Thiebaud (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1791

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1791/1

default to --without-help and --without-myspell-dicts

Updated the distro-configs so that the default change
does not impact build based on distro profile

The intent is that with this change of defaults
the build does only rely on core and does not need
any submodules. Making a initial build simpler
for new dev, since they won't be exposed to submodules
unless they really need them.

Change-Id: I446e912d607ce7358fd11f54a3de025dc3f25144
---
M configure.ac
M distro-configs/LibreOfficeAndroid.conf
M distro-configs/LibreOfficeAndroidX86.conf
M distro-configs/LibreOfficeLinux.conf
M distro-configs/LibreOfficeMacOSX.conf
M distro-configs/LibreOfficeMinGW.conf
M distro-configs/LibreOfficeOpenBSD.conf
M distro-configs/LibreOfficeWin32.conf
M distro-configs/LibreOfficeWin64.conf
M distro-configs/LibreOfficeiOS.conf
10 files changed, 17 insertions(+), 2 deletions(-)



diff --git a/configure.ac b/configure.ac
index 7f001a6..23ebf23 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4503,7 +4503,7 @@
 AC_SUBST(DO_FETCH_TARBALLS)
 
 AC_MSG_CHECKING([whether to build help])
-if test "$with_help" != "no" -a $_os != iOS -a $_os != Android; then
+if test "$with_help" = "yes" -a $_os != iOS -a $_os != Android; then
 AC_MSG_RESULT([yes])
 BUILD_TYPE="$BUILD_TYPE HELP"
 SCPDEFS="$SCPDEFS -DWITH_HELP"
@@ -4515,7 +4515,7 @@
 dnl Test whether to include MySpell dictionaries
 dnl ===
 AC_MSG_CHECKING([whether to include MySpell dictionaries])
-if test -z "$with_myspell_dicts" -o "$with_myspell_dicts" = "yes"; then
+if test "$with_myspell_dicts" = "yes"; then
 AC_MSG_RESULT([yes])
 WITH_MYSPELL_DICTS=YES
 BUILD_TYPE="$BUILD_TYPE DICTIONARIES"
diff --git a/distro-configs/LibreOfficeAndroid.conf 
b/distro-configs/LibreOfficeAndroid.conf
index b07359a..6280c87 100644
--- a/distro-configs/LibreOfficeAndroid.conf
+++ b/distro-configs/LibreOfficeAndroid.conf
@@ -21,3 +21,4 @@
 --without-helppack-integration
 --without-myspell-dicts
 --with-build-platform-configure-options=--disable-liblangtag
+--with-help
diff --git a/distro-configs/LibreOfficeAndroidX86.conf 
b/distro-configs/LibreOfficeAndroidX86.conf
index 590d069..e4fdf4c 100644
--- a/distro-configs/LibreOfficeAndroidX86.conf
+++ b/distro-configs/LibreOfficeAndroidX86.conf
@@ -21,3 +21,4 @@
 --without-helppack-integration
 --without-myspell-dicts
 --with-build-platform-configure-options=--disable-liblangtag
+--with-help
diff --git a/distro-configs/LibreOfficeLinux.conf 
b/distro-configs/LibreOfficeLinux.conf
index 4ed55ee..1934c1c 100644
--- a/distro-configs/LibreOfficeLinux.conf
+++ b/distro-configs/LibreOfficeLinux.conf
@@ -1,5 +1,6 @@
 --with-vendor=The Document Foundation
 --with-system-dicts
+--with-myspell-dicts
 --without-unix-wrapper
 --without-system-zlib
 --without-system-stdlibs
@@ -14,6 +15,7 @@
 --without-system-cairo
 --without-system-postgresql
 --without-junit
+--with-help
 --without-helppack-integration
 --with-linker-hash-style=both
 --with-fonts
diff --git a/distro-configs/LibreOfficeMacOSX.conf 
b/distro-configs/LibreOfficeMacOSX.conf
index 2ca1070..23ff683 100644
--- a/distro-configs/LibreOfficeMacOSX.conf
+++ b/distro-configs/LibreOfficeMacOSX.conf
@@ -10,3 +10,5 @@
 --enable-online-update
 --without-system-postgresql
 --disable-gtk
+--with-help
+--with-myspell-dicts
diff --git a/distro-configs/LibreOfficeMinGW.conf 
b/distro-configs/LibreOfficeMinGW.conf
index e14e993..e44899a 100644
--- a/distro-configs/LibreOfficeMinGW.conf
+++ b/distro-configs/LibreOfficeMinGW.conf
@@ -29,3 +29,5 @@
 --disable-mozilla
 --disable-postgresql-sdbc
 --disable-gtk
+--with-help
+--with-myspell-dicts
diff --git a/distro-configs/LibreOfficeOpenBSD.conf 
b/distro-configs/LibreOfficeOpenBSD.conf
index a56c097..f149adc 100644
--- a/distro-configs/LibreOfficeOpenBSD.conf
+++ b/distro-configs/LibreOfficeOpenBSD.conf
@@ -45,3 +45,4 @@
 --without-system-mozilla
 --without-unix-wrapper
 --without-system-libwpd
+--with-help
diff --git a/distro-configs/LibreOfficeWin32.conf 
b/distro-configs/LibreOfficeWin32.conf
index 19364be..0fc5940 100644
--- a/distro-configs/LibreOfficeWin32.conf
+++ b/distro-configs/LibreOfficeWin32.conf
@@ -15,3 +15,5 @@
 --enable-online-update
 --enable-win-mozab-driver
 --disable-build-mozab
+--with-help
+--with-myspell-dicts
diff --git a/distro-configs/LibreOfficeWin64.conf 
b/distro-configs/LibreOfficeWin64.conf
index 35ca061..ee6386e 100644
--- a/distro-configs/LibreOfficeWin64.conf
+++ b/distro-configs/LibreOfficeWin64.conf
@@ -4,3 +4,5 @@
 --disable-gtk
 --enable-scripting-beanshell
 --enable-scripting-javascript
+--with-help
+--with-myspell-dicts
diff --git a/distro-configs/LibreOfficeiOS.conf 
b/distro-configs/LibreOfficeiOS.conf
index f552e94..0c1404bc5 100644
--- a/distro-configs/LibreOff

[PATCH] disable odk if not explicitly requested and doxygen not in P...

2013-01-20 Thread Norbert Thiebaud (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1789

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/1789/1

disable odk if not explicitly requested and doxygen not in PATH

if odk is not explicitly requested by --enable-odk
and --with-doxygen is "yes" , i.e not a specific location
and doxygen could not be found in the PATH
then enable_odk is set to "no" as a default value
rather than an implicit 'yes'

Change-Id: I4f04ecc8dbe959001f6dfdccf0c97b61f79faff6
---
M configure.ac
1 file changed, 27 insertions(+), 22 deletions(-)



diff --git a/configure.ac b/configure.ac
index 7f001a6..559f6a0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6944,6 +6944,33 @@
 dnl ===
 dnl Check for building ODK
 dnl ===
+if test "$enable_odk" = no; then
+unset DOXYGEN
+else
+if test "$with_doxygen" = no; then
+AC_MSG_CHECKING([for doxygen])
+unset DOXYGEN
+AC_MSG_RESULT([no])
+else
+if test "$with_doxygen" = yes; then
+AC_PATH_PROG([DOXYGEN], [doxygen])
+if test -z "$DOXYGEN"; then
+AC_MSG_RESULT([no])
+if test "$enable_odk" = "" ; then
+enable_odk="no"
+else
+AC_MSG_ERROR([doxygen not found in \$PATH; specify its 
pathname via --with-doxygen=..., or disable its use via --without-doxygen])
+fi
+fi
+else
+AC_MSG_CHECKING([for doxygen])
+DOXYGEN=$with_doxygen
+AC_MSG_RESULT([$DOXYGEN])
+fi
+fi
+fi
+AC_SUBST([DOXYGEN])
+
 AC_MSG_CHECKING([whether to build the ODK])
 if test "$enable_odk" = "" -o "$enable_odk" != "no"; then
 AC_MSG_RESULT([yes])
@@ -11655,28 +11682,6 @@
 fi
 AC_SUBST(OOO_JUNIT_JAR)
 
-if test "$enable_odk" = no; then
-unset DOXYGEN
-else
-if test "$with_doxygen" = no; then
-AC_MSG_CHECKING([for doxygen])
-unset DOXYGEN
-AC_MSG_RESULT([no])
-else
-if test "$with_doxygen" = yes; then
-AC_PATH_PROG([DOXYGEN], [doxygen])
-if test -z "$DOXYGEN"; then
-AC_MSG_RESULT([no])
-AC_MSG_ERROR([doxygen not found in \$PATH; specify its 
pathname via --with-doxygen=..., or disable its use via --without-doxygen])
-fi
-else
-AC_MSG_CHECKING([for doxygen])
-DOXYGEN=$with_doxygen
-AC_MSG_RESULT([$DOXYGEN])
-fi
-fi
-fi
-AC_SUBST([DOXYGEN])
 
 AC_SUBST(SCPDEFS)
 

-- 
To view, visit https://gerrit.libreoffice.org/1789
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f04ecc8dbe959001f6dfdccf0c97b61f79faff6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Norbert Thiebaud 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice Development [ Comments in .pptx ] (Annotations Issue)

2013-01-20 Thread Vinaya Mandke 
Hi,

I am a trainee and have been assigned a project to debug and correct one
bug of LiBo. I am assigned this
bug.
As of now I have identified this much:-

   - Comments folder with comment1.xml , CommentAuthors are getting created
   in the PPTx So this is an FileOpen issue
   - I have also identified that pptx opens and is handled from
   ../oox/source/ppt/presentationfragmenthandler.cxx (finalizeimport)
   - There are handlers for Notes, Layouts etc but none for Annotations.
   - Furthermore I have also identified that Annotations are considered as
   smarttags and are not exactly treated as part of the Presentation and hence
   have no data structures in the SlidePersistPtr

As of now I can identify whether a slide has a comment in it or not using
following in presentationfragmenthandler.cxx (finalizeimport) :-
OUString aCommentFragmentPath =
xSlideFragmentHandler->getFragmentPathFromFirstType(
CREATE_OFFICEDOC_RELATION_TYPE( "comment" ) );
 if ( !aCommentFragmentPath.isEmpty() ) { ... //comment present }

Furthermore:-

   - ../sd/source/core/annotations have a few incomplete implementations
   for the Annotations (Annotations.cxx AnnotationAccess.cxx etc)
   - In presentationfragmenthandler there needs to another handler for
   comments but I am stuck on how this can be implemented.


So can you please guide how should I go about solving this issue ?

Eagerly waiting for your reply...
Regards,
Vinaya Mandke
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Resolves: fdo#49784 CRASH when FILEOPEN particular doc conta...

2013-01-20 Thread Julien Nabet (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1788

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/1788/1

Resolves: fdo#49784 CRASH when FILEOPEN particular doc containing .svm

Change-Id: Ia86ec2f32259180a29857eee53d6d5c082e05bf7
---
M drawinglayer/source/primitive2d/metafileprimitive2d.cxx
1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx 
b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
index f4337aa..cef6500 100644
--- a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
@@ -524,8 +524,9 @@
 
 TargetHolder& Current()
 {
+static TargetHolder aDummy;
 OSL_ENSURE(maTargetHolders.size(), "TargetHolders: CURRENT with no 
property holders (!)");
-return *maTargetHolders.back();
+return maTargetHolders.empty() ? aDummy : *maTargetHolders.back();
 }
 
 ~TargetHolders()

-- 
To view, visit https://gerrit.libreoffice.org/1788
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia86ec2f32259180a29857eee53d6d5c082e05bf7
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Julien Nabet 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Restore menu File > Template

2013-01-20 Thread Cor Nouws 

Hi all,

Would love to see this picked for 4.0.0 - therefore the whole discussion 
was started.


Latest message:

http://lists.freedesktop.org/archives/libreoffice-ux-advise/2013-January/001753.html

The patch compiles and works in Master. The menu File > Template > Edit 
brings up the new nice Template Manager dialog.
There are no folders present in my build - I guess that's due to 
differences between 4.0 and master branch...


As for Localisation: only one label changed
'Template Manager' to 'Edit'

Cheers,
Cor

Cor Nouws (via Code Review) wrote (20-01-13 23:10)

Hi,

I have submitted a patch for review:

 https://gerrit.libreoffice.org/1787

To pull it, you can do:

 git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/1787/1

Restore menu File > Template

Brings back menu File > Template … Save as Template and .. Edit – see list
http://lists.freedesktop.org/archives/libreoffice-ux-advise/2013-January/001743.html
The menu 'Address book source' is not restored – that moved to the Tools menu 
already
File > Template is placed directly below File > Wizards;
File > Save As Template is removed

Change-Id: I4843b653fdda2c0b6f074a7a981213f95782ae26



--
 - Cor
 - http://nl.libreoffice.org
 - www.librelex.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Restore menu File > Template

2013-01-20 Thread Cor Nouws (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1787

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/1787/1

Restore menu File > Template

Brings back menu File > Template … Save as Template and .. Edit – see list
http://lists.freedesktop.org/archives/libreoffice-ux-advise/2013-January/001743.html
The menu 'Address book source' is not restored – that moved to the Tools menu 
already
File > Template is placed directly below File > Wizards;
File > Save As Template is removed

Change-Id: I4843b653fdda2c0b6f074a7a981213f95782ae26
---
M basctl/uiconfig/basicide/menubar/menubar.xml
M framework/uiconfig/startmodule/menubar/menubar.xml
M officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
M sc/uiconfig/scalc/menubar/menubar.xml
M sd/uiconfig/sdraw/menubar/menubar.xml
M sd/uiconfig/simpress/menubar/menubar.xml
M sfx2/inc/sfx2/sfxcommands.h
M sw/uiconfig/sglobal/menubar/menubar.xml
M sw/uiconfig/sweb/menubar/menubar.xml
M sw/uiconfig/swform/menubar/menubar.xml
M sw/uiconfig/swreport/menubar/menubar.xml
M sw/uiconfig/swriter/menubar/menubar.xml
M sw/uiconfig/swxform/menubar/menubar.xml
13 files changed, 85 insertions(+), 10 deletions(-)



diff --git a/basctl/uiconfig/basicide/menubar/menubar.xml 
b/basctl/uiconfig/basicide/menubar/menubar.xml
index 2c12262..dc008ce 100644
--- a/basctl/uiconfig/basicide/menubar/menubar.xml
+++ b/basctl/uiconfig/basicide/menubar/menubar.xml
@@ -25,6 +25,13 @@
 
 
 
+
+
+
+
+ 
+
+
 
 
 
diff --git a/framework/uiconfig/startmodule/menubar/menubar.xml 
b/framework/uiconfig/startmodule/menubar/menubar.xml
index c9f9622..14653dd 100644
--- a/framework/uiconfig/startmodule/menubar/menubar.xml
+++ b/framework/uiconfig/startmodule/menubar/menubar.xml
@@ -25,6 +25,13 @@
 
 
 
+
+
+
+
+ 
+
+
 
 
 
diff --git 
a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu 
b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
index ac67696..eab81f0 100644
--- a/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu
@@ -5326,6 +5326,11 @@
 ~Tools
 
 
+
+
+~Templates
+
+   
 
 
 ~Spellcheck
@@ -5503,7 +5508,7 @@
 
 
 
-Template Manager
+Edit
 
 
 
diff --git a/sc/uiconfig/scalc/menubar/menubar.xml 
b/sc/uiconfig/scalc/menubar/menubar.xml
index 0544210..1df65bd 100644
--- a/sc/uiconfig/scalc/menubar/menubar.xml
+++ b/sc/uiconfig/scalc/menubar/menubar.xml
@@ -25,10 +25,16 @@
 
 
 
+
+
+
+
+ 
+
+
 
 
 
-
 
 
 
diff --git a/sd/uiconfig/sdraw/menubar/menubar.xml 
b/sd/uiconfig/sdraw/menubar/menubar.xml
index 85ea0e0..f856796 100644
--- a/sd/uiconfig/sdraw/menubar/menubar.xml
+++ b/sd/uiconfig/sdraw/menubar/menubar.xml
@@ -25,10 +25,16 @@
   
   
   
+  
+   
+   
+   
+
+  
+  
   
   
   
-  
   
   
   
diff --git a/sd/uiconfig/simpress/menubar/menubar.xml 
b/sd/uiconfig/simpress/menubar/menubar.xml
index 9fd07b1..d7b9f5f 100644
--- a/sd/uiconfig/simpress/menubar/menubar.xml
+++ b/sd/uiconfig/simpress/menubar/menubar.xml
@@ -25,15 +25,22 @@
 
 
 
+
+
+
+
+ 
+
+
 
 
 
-
 
 
 
 
 
+
 
 
 
diff --git a/sfx2/inc/sfx2/sfxcommands.h b/sfx2/inc/sfx2/sfxcommands.h
index 3f4df5c..330dcf2 100644
--- a/sfx2/inc/sfx2/sfxcommands.h
+++ b/sfx2/inc/sfx2/sfxcommands.h
@@ -48,6 +48,7 @@
 #define CMD_SID_CANCELCHECKOUT  ".uno:CancelCheckOut"
 #define CMD_SID_CHECKIN ".uno:CheckIn"
 #define CMD_SID_OPENURL ".uno:OpenUrl"
+#define CMD_SID_TEMPLATE_MANAGER".uno:TemplateManager"
 #define CMD_SID_OPTIONS ".uno:Options"
 #define CMD_SID_ORGANIZER

Install/package : going to internals

2013-01-20 Thread Mat M 

Hello

When playing with fdo#39632 [1], I faced a strange issue: the file  
finals_instsetoo.txt was not found by the installer.
The error raise from installer.pm, line 513, with the call to  
installer::windows::update::readdatabase.


The reference is defined by openoffice.lst, in the Globals. The reference  
file is stored in setup_native\source\packinfo.
My expectation is that finals_instsetoo.txt would be a dependency of  
instsetoo_native, but I found no link between both and git grep found  
nothing more, so I have no clue about which process should do the copy.


I think the searched version should be in solver\wntmsci13.pro\bin (as I  
see it from another clone).


Thank you for any enlightenment provided.



[1] https://bugs.freedesktop.org/show_bug.cgi?id=39632

--
Mat M
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: drawinglayer/source

2013-01-20 Thread Libreoffice Gerrit user 
 drawinglayer/source/primitive2d/metafileprimitive2d.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit af1d3c83a372b096b4c425a2bc976e7ef0cd7ed9
Author: Julien Nabet 
Date:   Sun Jan 20 22:22:11 2013 +0100

Another typo

Change-Id: Ic2e9328d29593bbea7d54e5aed1b6a63a97434a3

diff --git a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx 
b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
index 8466788..f4337aa 100644
--- a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
@@ -2131,7 +2131,7 @@ namespace
 
 if(aGDIMetaFile.GetActionSize())
 {
-// cerate sub-content
+// create sub-content
 drawinglayer::primitive2d::Primitive2DSequence 
xSubContent;
 {
 rTargetHolders.Push();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: translations

2013-01-20 Thread Libreoffice Gerrit user 
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0e57b184b21f50917372d311f11591ce3f18acb7
Author: Andras Timar 
Date:   Sun Jan 20 21:17:23 2013 +0100

Updated core
Project: translations  15bb868bbc35ef3de6919317bec0e70883fafeea

diff --git a/translations b/translations
index 620e5cb..15bb868 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit 620e5cb6954b4fdb1be1cf38b83844ae319600d8
+Subproject commit 15bb868bbc35ef3de6919317bec0e70883fafeea
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: drawinglayer/source

2013-01-20 Thread Libreoffice Gerrit user 
 drawinglayer/source/primitive2d/metafileprimitive2d.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6978ddbf4738b4c53b9d2edbe6d5ad6a061d0d0f
Author: Julien Nabet 
Date:   Sun Jan 20 22:05:44 2013 +0100

Typo

Change-Id: I94fb3020057fb1fb370ffdffee82e40da44bf35b

diff --git a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx 
b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
index d168bef..8466788 100644
--- a/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/metafileprimitive2d.cxx
@@ -3162,7 +3162,7 @@ namespace drawinglayer
 // interpret the Metafile
 interpretMetafile(getMetaFile(), aTargetHolders, aPropertyHolders, 
rViewInformation);
 
-// get the content. There should be ony one target, as in the 
start condition,
+// get the content. There should be only one target, as in the 
start condition,
 // but iterating will be the right thing to do when some push/pop 
is not closed
 Primitive2DSequence xRetval;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: stoc/source svtools/source

2013-01-20 Thread Libreoffice Gerrit user 
 stoc/source/inspect/introspection.cxx|1 -
 svtools/source/dialogs/ServerDetailsControls.cxx |4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

New commits:
commit 6172a95bb077fd43595e02084b5394516738844b
Author: Julien Nabet 
Date:   Sun Jan 20 21:51:16 2013 +0100

Some cppcheck cleaning

Change-Id: Ie975903daa84ddafb2ba7d58e18b8ef20b331596

diff --git a/stoc/source/inspect/introspection.cxx 
b/stoc/source/inspect/introspection.cxx
index 5956088..ea62d4d 100644
--- a/stoc/source/inspect/introspection.cxx
+++ b/stoc/source/inspect/introspection.cxx
@@ -313,7 +313,6 @@ sal_Int32 IntrospectionAccessStatic_Impl::getMethodIndex( 
const ::rtl::OUString&
 else
 {
 sal_Int32 nSearchFrom = aMethodName.getLength();
-nSearchFrom = aMethodName.getLength();
 while( true )
 {
 // Strategy: Search back until the first '_' is found
diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx 
b/svtools/source/dialogs/ServerDetailsControls.cxx
index 8b10c10..3bdae1b 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -134,9 +134,7 @@ INetURLObject HostDetailsContainer::getUrl( )
 
 bool HostDetailsContainer::setUrl( const INetURLObject& rUrl )
 {
-bool bSuccess = false;
-
-bSuccess = verifyScheme( INetURLObject::GetScheme( rUrl.GetProtocol( ) ) );
+bool bSuccess = verifyScheme( INetURLObject::GetScheme( rUrl.GetProtocol( 
) ) );
 
 if ( bSuccess )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - translations

2013-01-20 Thread Libreoffice Gerrit user 
 translations |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 75b9b28e62494346aa119dbab424cb3d843ae694
Author: Andras Timar 
Date:   Sun Jan 20 21:17:23 2013 +0100

Updated core
Project: translations  3497b6298b4c12e017bb77e9ac70513df9820401

diff --git a/translations b/translations
index df288c0..3497b62 16
--- a/translations
+++ b/translations
@@ -1 +1 @@
-Subproject commit df288c090b86e7eeab5cada7b812089fc47d3ac5
+Subproject commit 3497b6298b4c12e017bb77e9ac70513df9820401
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Cppcheck: false positive in pptx-text.cxx ?

2013-01-20 Thread Markus Mohrhard 
Hey Julien,

2013/1/20 julien2412 :
> Hello,
>
> Cppcheck reported this:
> sd/source/filter/eppt/pptx-text.cxx
> 1235copyCtorPointerCopying  style   Value of pointer 'mpImplTextObj', 
> which
> points to allocated memory, is copied in copy constructor instead of
> allocating new memory.
>
>1233 TextObj::TextObj( const TextObj& rTextObj )
>1234 {
>1235 mpImplTextObj =
> const_cast(rTextObj).mpImplTextObj;
>1236 mpImplTextObj->mnRefCount++;
>1237 }
>
> I must recognize I don't know what to think about this since I know too
> little about C++.
> Something is wrong here or just a false positive?
>

While the comment is correct it is not really an error in this case.
Someone implemented here manualy ref counting. If you want to remove
the warning you can replace the raw pointer + the ref counting
variable with a  boost::shared_ptr.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Cppcheck: false positive in pptx-text.cxx ?

2013-01-20 Thread julien2412 
Hello,

Cppcheck reported this:
sd/source/filter/eppt/pptx-text.cxx
1235copyCtorPointerCopying  style   Value of pointer 'mpImplTextObj', which
points to allocated memory, is copied in copy constructor instead of
allocating new memory.

   1233 TextObj::TextObj( const TextObj& rTextObj )
   1234 {
   1235 mpImplTextObj =
const_cast(rTextObj).mpImplTextObj;
   1236 mpImplTextObj->mnRefCount++;
   1237 }

I must recognize I don't know what to think about this since I know too
little about C++.
Something is wrong here or just a false positive?

Julien 



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-false-positive-in-pptx-text-cxx-tp4030662.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: "Need help for "Bug 59397 - UI: Use more precise wording at 'Find & Replace - More Options - Styles' "

2013-01-20 Thread Vishv Brahmbhatt 
Hi,
I need help for this bug
https://bugs.freedesktop.org/show_bug.cgi?id=59397. I am slightly
confused with my approach in solving this bug, so I need
help for it.

I am using this approach for solving the bug:

I am planning to create a separate CheckBox(with modified Text) for "calc"
,similar to which is defined in the* src *file and  then create a function
similiar to *aLayoutBtn* in this* cxx *file and make necessary changes at
the *change *line mentioned below.Is this the correct approach or some
other approach possible?

*src* file -
http://opengrok.libreoffice.org/xref/core/svx/source/dialog/srchdlg.src#284

*cxx *file -
http://opengrok.libreoffice.org/xref/core/svx/source/dialog/srchdlg.cxx#282

*change* line-
http://opengrok.libreoffice.org/xref/core/svx/source/dialog/srchdlg.cxx#728

Hoping for the needed guidance in this matter.

Regards,
Vishv

On Fri, Jan 18, 2013 at 12:11 AM, Joren wrote:

>
>  Op 17-01-13 19:14, Vishv Brahmbhatt schreef:
>
> Hi,
>
>  I need help for this bug
> https://bugs.freedesktop.org/show_bug.cgi?id=59397 .
>
>  Can someone help me in suggesting the good starting point/code pointer
> for this hack?
>
>  Also where can I find the layout file for *Edit->Find & Replace* in
> Writer & Calc (i.e in which module is it defined)?
>
> I think you can find it here
> http://opengrok.libreoffice.org/xref/core/svx/source/dialog/srchdlg.src#284
>
> Kind regards,
> Joren
>
>
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Cppcheck: Same expression in testzipimpl.cxx

2013-01-20 Thread julien2412 
Hello,

Cppcheck reported this:
shell/qa/zip/testimpl/testzipimpl.cxx
57  duplicateExpression style   Same expression on both sides of '=='.

 52 bool TestZipImpl::test_directory()
 53 {
 54 ZipFile::DirectoryPtr_t contents = zipFile.GetDirectory();
 55 vector &stringVector = *contents.get();
 56 sort(stringVector.begin(), stringVector.end());
 57 return expectedContents == expectedContents;
 58 }

Shouldn't it be
return expectedContents == stringVector;
?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Cppcheck-Same-expression-in-testzipimpl-cxx-tp4030658.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Grammar checker] Undocumented change in the API for LO 4

2013-01-20 Thread Olivier R. 
Hi *,

It seems that there is a change in the grammar checker behavior which seems
undocumented anywhere.

The change is in this function:
http://api.libreoffice.org/docs/common/ref/com/sun/star/linguistic2/XProofreader.html#doProofreading

With LibreOffice 3, each paragraph of a text is passed once to this function
in the parameter aText, and the parameters nStartOfSentencePosition and
nSuggestedBehindEndOfSentencePosition are the beginning and the end of the
paragraph to check.

With LibreOffice 4, each paragraph of a text is passed several times to this
function in the parameter aText, and the parameters nStartOfSentencePosition
and nSuggestedBehindEndOfSentencePosition are the beginning and the end of
each sentence of this paragraph.

Is this a bug ? a feature ? an undocumented change ?

This change provokes unexpected errors with the French grammar checker.

Imho, the previous way to parse texts was better than the new one, as it’s
up to each grammar checker to decide what to do with the paragraph, how to
split it if necessary, etc.

Regards,
Olivier R.



--
View this message in context: 
http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Added Few more sub widgets under options->LibreOffice

2013-01-20 Thread gokul s (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1786

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/1786/1

Added Few more sub widgets under options->LibreOffice

Change-Id: Ifcf1d5e4c02b72fecc3d91ac85f96d5683bae6c3
---
A sw/uiconfig/swriter/ui/entermasterpassword.ui
A sw/uiconfig/swriter/ui/libaccessibility.ui
A sw/uiconfig/swriter/ui/libappearance.ui
A sw/uiconfig/swriter/ui/libcolors.ui
A sw/uiconfig/swriter/ui/libfonts.ui
A sw/uiconfig/swriter/ui/libjava.ui
A sw/uiconfig/swriter/ui/libpaths.ui
A sw/uiconfig/swriter/ui/libprint.ui
A sw/uiconfig/swriter/ui/libsecurity.ui
A sw/uiconfig/swriter/ui/macrosecurity.ui
A sw/uiconfig/swriter/ui/securityoptandwarn.ui
A sw/uiconfig/swriter/ui/setmasterpassword.ui
A sw/uiconfig/swriter/ui/storedwebconnectioninfo.ui
13 files changed, 3,707 insertions(+), 0 deletions(-)




-- 
To view, visit https://gerrit.libreoffice.org/1786
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifcf1d5e4c02b72fecc3d91ac85f96d5683bae6c3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: gokul s 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Initial/partial implementation of comment control on Writer ...

2013-01-20 Thread Rodolfo Ribeiro Gomes (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1785

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/1785/1

Initial/partial implementation of comment control on Writer ruler fdo#38246

Lots of incompleted things. But I need feedback and directions.
Mainly how to make it appears without need a first mouse-over event...
How can I vertically align text forcing a base line?
Is the license section of those two new files correct?

Change-Id: Ib065043d05fe56fbfe6d00e0bb654966f046129b
Signed-off-by: Rodolfo Ribeiro Gomes 
---
M svtools/inc/svtools/ruler.hxx
M svtools/source/control/ruler.cxx
M sw/Library_sw.mk
A sw/source/ui/inc/swruler.hxx
A sw/source/ui/misc/swruler.cxx
M sw/source/ui/uiview/view.cxx
6 files changed, 288 insertions(+), 11 deletions(-)



diff --git a/svtools/inc/svtools/ruler.hxx b/svtools/inc/svtools/ruler.hxx
index 3156044..2b19bc3 100644
--- a/svtools/inc/svtools/ruler.hxx
+++ b/svtools/inc/svtools/ruler.hxx
@@ -681,6 +681,9 @@
 Ruler (const Ruler &);
 Ruler & operator= (const Ruler &);
 
+protected:
+long GetRulerVirHeight() const;
+
 public:
 Ruler( Window* pParent, WinBits nWinStyle = 
WB_STDRULER );
 virtual ~Ruler();
@@ -712,6 +715,9 @@
 voidSetBorderPos( long nOff = 0 );
 longGetBorderOffset() const { return mnBorderOff; }
 Rectangle   GetExtraRect() const { return maExtraRect; }
+longGetWidth() const { return mnWidth; }
+longGetHeight() const { return mnHeight; }
+longGetRulerWidth() const;
 
 voidSetUnit( FieldUnit eNewUnit );
 FieldUnit   GetUnit() const { return meUnit; }
diff --git a/svtools/source/control/ruler.cxx b/svtools/source/control/ruler.cxx
index 153e915..ecf337b 100644
--- a/svtools/source/control/ruler.cxx
+++ b/svtools/source/control/ruler.cxx
@@ -2777,9 +2777,11 @@
 
 }
 long Ruler::GetPageOffset() const { return mpData->nPageOff; }
-longRuler::GetNullOffset() const { return mpData->nNullOff; }
-longRuler::GetMargin1() const { return mpData->nMargin1; }
-longRuler::GetMargin2() const { return mpData->nMargin2; }
+long Ruler::GetNullOffset() const { return mpData->nNullOff; }
+longRuler::GetMargin1() const { return mpData->nMargin1; }
+longRuler::GetMargin2() const { return mpData->nMargin2; }
+long Ruler::GetRulerWidth() const { return mpData->nRulWidth; }
+long Ruler::GetRulerVirHeight() const { return mnVirHeight; }
 
 void Ruler::DrawTicks()
 {
diff --git a/sw/Library_sw.mk b/sw/Library_sw.mk
index c66cb26..6e62489 100644
--- a/sw/Library_sw.mk
+++ b/sw/Library_sw.mk
@@ -600,6 +600,7 @@
 sw/source/ui/misc/glshell \
 sw/source/ui/misc/numberingtypelistbox \
 sw/source/ui/misc/redlndlg \
+sw/source/ui/misc/swruler \
 sw/source/ui/ribbar/conarc \
 sw/source/ui/ribbar/concustomshape \
 sw/source/ui/ribbar/conform \
diff --git a/sw/source/ui/inc/swruler.hxx b/sw/source/ui/inc/swruler.hxx
new file mode 100644
index 000..6700df8
--- /dev/null
+++ b/sw/source/ui/inc/swruler.hxx
@@ -0,0 +1,63 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#ifndef SW_COMMENT_RULER_HXX
+#define SW_COMMENT_RULER_HXX
+
+#include 
+
+class ViewShell;
+class View;
+class Window;
+class SwEditWin;
+
+class SwCommentRuler
+: public SvxRuler
+{
+public:
+SwCommentRuler (
+ViewShell* pViewSh,
+Window* pParent,
+SwEditWin* pWin,
+sal_uInt16 nRulerFlags,
+SfxBindings& rBindings,
+WinBits nWinStyle);
+virtual ~SwCommentRuler ();
+
+virtual void Paint( const Rectangle& rRect );
+
+protected:
+ViewShell * mpViewShell;
+SwEditWin * mpSwWin;
+boolmbHighlighted;
+VirtualDevice maVirDev;
+
+virtual void MouseButtonDown( const MouseEvent& rMEvt );
+virtual void MouseMove(const MouseEvent& rMEvt);
+virtual void Command( const CommandEvent& rCEvt );
+
+RectangleGetCommentControlRegion();
+
+

[Libreoffice-commits] .: bridges/source slideshow/test

2013-01-20 Thread Libreoffice Gerrit user 
 bridges/source/cpp_uno/cc5_solaris_sparc64/exceptions.cxx |2 +-
 slideshow/test/demoshow.cxx   |3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 3207c85fc957a347aaf78e7328a52d85edab0f72
Author: Julien Nabet 
Date:   Sun Jan 20 15:23:12 2013 +0100

Another lacking parenthesis

Change-Id: If5944101688b0219d2476e5c3b29f704634c3bcc

diff --git a/bridges/source/cpp_uno/cc5_solaris_sparc64/exceptions.cxx 
b/bridges/source/cpp_uno/cc5_solaris_sparc64/exceptions.cxx
index d192036..f8bfc92 100644
--- a/bridges/source/cpp_uno/cc5_solaris_sparc64/exceptions.cxx
+++ b/bridges/source/cpp_uno/cc5_solaris_sparc64/exceptions.cxx
@@ -431,7 +431,7 @@ void fillUnoException(
 }
 if (type == NULL || type->eTypeClass != typelib_TypeClass_EXCEPTION) {
 css::uno::RuntimeException exc(
-"Not a UNO exception type: " + name),
+"Not a UNO exception type: " + name,
 css::uno::Reference< css::uno::XInterface >());
 uno_type_any_constructAndConvert(
 unoException, &exc, getCppuType(&exc).getTypeLibType(), cppToUno);
diff --git a/slideshow/test/demoshow.cxx b/slideshow/test/demoshow.cxx
index 8a2b073..86f861c 100644
--- a/slideshow/test/demoshow.cxx
+++ b/slideshow/test/demoshow.cxx
@@ -430,8 +430,7 @@ void DemoWindow::init()
 {
 if( !mxShow.is() )
 {
-uno::Reference< uno::XComponentContext > xContext =(
-::comphelper::getProcessComponentContext());
+uno::Reference< uno::XComponentContext > xContext = 
::comphelper::getProcessComponentContext();
 
 mxShow.set( presentation::SlideShow::create(xContext),
 uno::UNO_QUERY_THROW );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

ES user thanking the developers

2013-01-20 Thread Marc Paré 
Sorry for the noise regarding this, but I thought it would be nice to 
post here to the people it was addressed to:


From Daniel Rodriguez (our LibreOffice ES community lead) who let's us 
know of a user on the ES list:


==

I want to share with you the transcript of a message sent to the spanish
user list by a writer who describes his charm using LibreOffice Writer.

"I want to witness that LibreOffice Writer was a real finding. I've 
simplified the most book editing and its presentation in PDF and ePub 
formats.


And the receivers of these versions are delighted. Congratulations to 
the technicians who developed this great product and correspondents who 
helped me to enter this unsuspected world.


Best regards and happy year for everyone.

Jorge Frosa, Buenos Aires, Argentina"

|| Original Mesage
http://listarchives.libreoffice.org/es/users/msg01572.html

==

Cheers and thanks to the devs for all of your work from the many of us 
who use LibreOffice.


Marc
Marketing/Website team member

--
Marc Paré
m...@marcpare.com
http://www.parEntreprise.com
parEntreprise.com Supports OpenDocument Formats (ODF)
parEntreprise.com Supports http://www.LibreOffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: resolve fdo#59619 Spelling error - heigth

2013-01-20 Thread Joren De Cuyper (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1783

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/1783/1

resolve fdo#59619 Spelling error - heigth

Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6
---
M svx/uiconfig/ui/compressgraphicdialog.ui
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svx/uiconfig/ui/compressgraphicdialog.ui 
b/svx/uiconfig/ui/compressgraphicdialog.ui
index 59b85b5..aff8431 100644
--- a/svx/uiconfig/ui/compressgraphicdialog.ui
+++ b/svx/uiconfig/ui/compressgraphicdialog.ui
@@ -322,7 +322,7 @@
 False
 20
 0
-Heigth:
+Height:
 15
   
   

-- 
To view, visit https://gerrit.libreoffice.org/1783
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Joren De Cuyper 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] resolve fdo#59619 Spelling error - heigth

2013-01-20 Thread Joren De Cuyper (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1782

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1782/1

resolve fdo#59619 Spelling error - heigth

Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6
---
M svx/uiconfig/ui/compressgraphicdialog.ui
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/svx/uiconfig/ui/compressgraphicdialog.ui 
b/svx/uiconfig/ui/compressgraphicdialog.ui
index 59b85b5..aff8431 100644
--- a/svx/uiconfig/ui/compressgraphicdialog.ui
+++ b/svx/uiconfig/ui/compressgraphicdialog.ui
@@ -322,7 +322,7 @@
 False
 20
 0
-Heigth:
+Height:
 15
   
   

-- 
To view, visit https://gerrit.libreoffice.org/1782
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice59129d20c6b7e3aa0dbabfefabd14bad8199b6
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Joren De Cuyper 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: 3 commits - slideshow/test ucb/workben xmlsecurity/workben

2013-01-20 Thread Libreoffice Gerrit user 
 slideshow/test/demoshow.cxx   |2 
 ucb/workben/ucb/ucbdemo.cxx   |   80 +-
 xmlsecurity/workben/signaturetest.cxx |2 
 3 files changed, 42 insertions(+), 42 deletions(-)

New commits:
commit 15e0f6d5931d78a6a994e6e81d891ca3e0a7cf0e
Author: Julien Nabet 
Date:   Sat Jan 19 18:20:25 2013 +0100

Fix missing parenthesis

Change-Id: I65d54513bf6ff9ec62edcb3388302a8352f48898

diff --git a/slideshow/test/demoshow.cxx b/slideshow/test/demoshow.cxx
index 8c9907c..8a2b073 100644
--- a/slideshow/test/demoshow.cxx
+++ b/slideshow/test/demoshow.cxx
@@ -431,7 +431,7 @@ void DemoWindow::init()
 if( !mxShow.is() )
 {
 uno::Reference< uno::XComponentContext > xContext =(
-::comphelper::getProcessComponentContext();
+::comphelper::getProcessComponentContext());
 
 mxShow.set( presentation::SlideShow::create(xContext),
 uno::UNO_QUERY_THROW );
commit 3f3770235e7ee8a8eb53b3fa6bb10bc1456cf42f
Author: Julien Nabet 
Date:   Sat Jan 19 18:20:01 2013 +0100

Fix missing parenthesis

Change-Id: Id372cde73af484d2d03149d7bbb9f23132cdabf8

diff --git a/xmlsecurity/workben/signaturetest.cxx 
b/xmlsecurity/workben/signaturetest.cxx
index 59f7f3b..be7c395 100644
--- a/xmlsecurity/workben/signaturetest.cxx
+++ b/xmlsecurity/workben/signaturetest.cxx
@@ -288,7 +288,7 @@ IMPL_LINK_NOARG(MyWin, DigitalSignaturesWithServiceHdl)
 aDocFileName, embed::ElementModes::READWRITE, 
comphelper::getProcessServiceFactory() );
 
 uno::Reference< security::XDocumentDigitalSignatures > xD(
-
security::DocumentDigitalSignatures::createDefault(comphelper::getProcessComponentContext()
 );
+
security::DocumentDigitalSignatures::createDefault(comphelper::getProcessComponentContext())
 );
 xD->signDocumentContent( xStore, NULL );
 
 
commit 3e654a9a092682f79d52816d18ad41d2fd6231c3
Author: Julien Nabet 
Date:   Sat Jan 19 18:04:35 2013 +0100

Fix missing parenthesis

Change-Id: I9b8b42465fc9246b9a85b5779a3073992ac82379

diff --git a/ucb/workben/ucb/ucbdemo.cxx b/ucb/workben/ucb/ucbdemo.cxx
index 09b9368..fdba04b 100644
--- a/ucb/workben/ucb/ucbdemo.cxx
+++ b/ucb/workben/ucb/ucbdemo.cxx
@@ -1726,30 +1726,30 @@ MyWin::MyWin( Window *pParent, WinBits nWinStyle,
 m_pTool = new ToolBox( this, WB_3DLOOK | WB_BORDER  | WB_SCROLL );
 
 m_pTool->InsertItem ( MYWIN_ITEMID_CLEAR,
-  OUString( "Clear" );
+  OUString("Clear"));
 m_pTool->SetHelpText( MYWIN_ITEMID_CLEAR,
-  OUString( "Clear the Output Window" );
+  OUString("Clear the Output Window"));
 m_pTool->InsertSeparator();
 m_pTool->InsertItem ( MYWIN_ITEMID_CREATE,
-  OUString( "Create" );
+  OUString("Create") );
 m_pTool->SetHelpText( MYWIN_ITEMID_CREATE,
-  OUString( "Create a content" );
+  OUString("Create a content") );
 m_pTool->InsertItem ( MYWIN_ITEMID_RELEASE,
-  OUString( "Release" ) );
+  OUString("Release") );
 m_pTool->SetHelpText( MYWIN_ITEMID_RELEASE,
-  OUString( "Release current content" );
+  OUString("Release current content") );
 m_pTool->InsertSeparator();
 m_pTool->InsertItem ( MYWIN_ITEMID_COMMANDS,
-  OUString( "Commands" );
+  OUString("Commands") );
 m_pTool->SetHelpText( MYWIN_ITEMID_COMMANDS,
-  OUString( "Get Commands supported by the content" ) 
);
+  OUString("Get Commands supported by the content") );
 m_pTool->InsertItem ( MYWIN_ITEMID_PROPS,
-  OUString( "Properties" ) ) );
+  OUString("Properties") );
 m_pTool->SetHelpText( MYWIN_ITEMID_PROPS,
-  OUString( "Get Properties supported by the content" 
) );
+  OUString("Get Properties supported by the content") 
);
 m_pTool->InsertSeparator();
 m_pTool->InsertItem ( MYWIN_ITEMID_ADD_PROP,
-  OUString( "addProperty" );
+  OUString("addProperty") );
 m_pTool->SetHelpText( MYWIN_ITEMID_ADD_PROP,
   OUString(
   "Add a new string(!) property to the 
content. "
@@ -1757,21 +1757,21 @@ MyWin::MyWin( Window *pParent, WinBits nWinStyle,
   "push this button. The default value for the 
"
   "property will be set to the string 
'DefaultValue'" ) );
 m_pTool->InsertItem ( MYWIN_ITEMID_REMOVE_PROP,
-  OUString( "removeProperty" ) );
+  OUString("removeProperty") );
 m_pTool-

[Libreoffice-commits] .: 3 commits - svx/inc svx/Package_inc.mk sw/inc sw/source

2013-01-20 Thread Libreoffice Gerrit user 
 svx/Package_inc.mk   |1 
 svx/inc/svx/splitcelldlg.hxx |   55 --
 sw/inc/swabstdlg.hxx |8 -
 sw/source/ui/inc/split.hxx   |   62 ---
 4 files changed, 126 deletions(-)

New commits:
commit eef7932dce56a736f9c122bc792382e1acdd63b3
Author: Caolán McNamara 
Date:   Sun Jan 20 03:10:36 2013 +

SwSplitTableDlg also unused

Change-Id: I0eef94907586ecae8213da6f322366ddc8e0c686

diff --git a/sw/source/ui/inc/split.hxx b/sw/source/ui/inc/split.hxx
deleted file mode 100644
index 0563b92..000
--- a/sw/source/ui/inc/split.hxx
+++ /dev/null
@@ -1,62 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef _TAB_SPLIT_HXX
-#define _TAB_SPLIT_HXX
-
-#include 
-
-#include 
-
-#include 
-
-#include 
-
-#include 
-
-class SwWrtShell;
-
-class SwSplitTableDlg : public SvxStandardDialog
-{
-FixedLineaCountFL;
-FixedText   aCountLbl;
-NumericFieldaCountEdit;
-FixedLineaDirFL;
-ImageRadioButtonaHorzBox;
-ImageRadioButtonaVertBox;
-CheckBoxaPropCB;
-OKButtonaOKBtn;
-CancelButtonaCancelBtn;
-HelpButton  aHelpBtn;
-SwWrtShell& rSh;
-
-protected:
-virtual void Apply();
-
-public:
-SwSplitTableDlg(Window *pParent, SwWrtShell& rShell );
-DECL_LINK( ClickHdl, Button * );
-
-sal_BoolIsHorizontal() const { return 
aHorzBox.IsChecked(); }
-sal_BoolIsProportional() const { return 
aPropCB.IsChecked() && aHorzBox.IsChecked(); }
-longGetCount() const { return sal::static_int_cast< long 
>(aCountEdit.GetValue()); }
-};
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 8f1e22eb149ac91da02ad3f0e8869be11d400525
Author: Caolán McNamara 
Date:   Sun Jan 20 03:09:42 2013 +

AbstractSwSplitTableDlg never used

Change-Id: I8b3fa5a513d31002655af479ba41a85b713509bd

diff --git a/sw/inc/swabstdlg.hxx b/sw/inc/swabstdlg.hxx
index b672f66..f2cc338 100644
--- a/sw/inc/swabstdlg.hxx
+++ b/sw/inc/swabstdlg.hxx
@@ -267,14 +267,6 @@ public:
 virtual void SelectEntryPos(sal_uInt16 nIdx) = 0;   // inline
 };
 
-class AbstractSwSplitTableDlg :public VclAbstractDialog //add for 
SwSplitTableDlg
-{
-public:
-virtual sal_BoolIsHorizontal() const = 0;
-virtual sal_BoolIsProportional() const = 0;
-virtual longGetCount() const = 0;
-};
-
 class AbstractSwAutoFormatDlg : public VclAbstractDialog //add for 
SwAutoFormatDlg
 {
 public:
commit 7b3862a5122d404845cc7dc227badb1cdfc92ac2
Author: Caolán McNamara 
Date:   Sun Jan 20 03:07:16 2013 +

splitcelldlg.hxx moved into cui long ago, this copy should be removed

Change-Id: Id019b80e12eaaed1d181af2eb2599cc1db26ee25

diff --git a/svx/Package_inc.mk b/svx/Package_inc.mk
index 3eac094..e1deeab 100644
--- a/svx/Package_inc.mk
+++ b/svx/Package_inc.mk
@@ -136,7 +136,6 @@ $(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/unoshtxt.hxx,svx/unoshtxt.hxx)
 $(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/svdopage.hxx,svx/svdopage.hxx))
 $(eval $(call gb_Package_add_file,svx_inc,inc/svx/xftadit.hxx,svx/xftadit.hxx))
 $(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/xlnstcit.hxx,svx/xlnstcit.hxx))
-$(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/splitcelldlg.hxx,svx/splitcelldlg.hxx))
 $(eval $(call gb_Package_add_file,svx_inc,inc/svx/sdynitm.hxx,svx/sdynitm.hxx))
 $(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/rulritem.hxx,svx/rulritem.hxx))
 $(eval $(call 
gb_Package_add_file,svx_inc,inc/svx/fillctrl.hxx,svx/fillctrl.hxx))
diff --git a/svx/inc/svx/splitcelldlg.hxx b/svx/inc/svx/splitcelldlg.hxx
deleted file mode 100644
index 39a124d..000
--- a/svx/inc/svx/splitcelldlg.hxx
+++ /dev/null
@@ -1,55 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public

[PATCH] Change in core[libreoffice-4-0]: copy styles from cond format between different docs, fdo#591...

2013-01-20 Thread Markus Mohrhard (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1779

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/1779/1

copy styles from cond format between different docs, fdo#59159

Change-Id: I5472ab648b248d925f1f07cd4194c1201230ff20
---
M sc/source/core/data/table2.cxx
1 file changed, 26 insertions(+), 0 deletions(-)



diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 073f726..07ab79e 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -658,6 +658,7 @@
 {
 ScRange aOldRange( nCol1 - nDx, nRow1 - nDy, pTable->nTab, nCol2 - nDx, 
nRow2 - nDy, pTable->nTab);
 ScRange aNewRange( nCol1, nRow1, nTab, nCol2, nRow2, nTab );
+bool bSameDoc = pDocument == pTable->pDocument;
 
 for(ScConditionalFormatList::const_iterator itr = 
pTable->mpCondFormatList->begin(),
 itrEnd = pTable->mpCondFormatList->end(); itr != itrEnd; ++itr)
@@ -681,6 +682,29 @@
 }
 pNewFormat->SetKey(nMax + 1);
 mpCondFormatList->InsertNew(pNewFormat);
+
+if(!bSameDoc)
+{
+for(size_t i = 0, n = pNewFormat->size();
+i < n; ++i)
+{
+OUString aStyleName;
+const ScFormatEntry* pEntry = pNewFormat->GetEntry(i);
+if(pEntry->GetType() == condformat::CONDITION)
+aStyleName = static_cast(pEntry)->GetStyle();
+else if(pEntry->GetType() == condformat::DATE)
+aStyleName = static_cast(pEntry)->GetStyleName();
+
+if(!aStyleName.isEmpty())
+{
+if(pDocument->GetStyleSheetPool()->Find(aStyleName, 
SFX_STYLE_FAMILY_PARA))
+continue;
+
+pDocument->GetStyleSheetPool()->CopyStyleFrom(
+pTable->pDocument->GetStyleSheetPool(), 
aStyleName, SFX_STYLE_FAMILY_PARA );
+}
+}
+}
 
 pDocument->AddCondFormatData( pNewFormat->GetRange(), nTab, 
pNewFormat->GetKey() );
 }
@@ -967,7 +991,9 @@
 }
 
 if(pDestTab->pDocument->IsUndo() && (nFlags & IDF_ATTRIB))
+{
 pDestTab->mpCondFormatList.reset(new 
ScConditionalFormatList(pDestTab->pDocument, *mpCondFormatList));
+}
 
 if (pDBDataNoName)
 {

-- 
To view, visit https://gerrit.libreoffice.org/1779
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5472ab648b248d925f1f07cd4194c1201230ff20
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: add missing data bar axis import, fdo#59578

2013-01-20 Thread Markus Mohrhard (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1781

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/1781/1

add missing data bar axis import, fdo#59578

Change-Id: Id035741b2372c76f9afe54f59f2203c5edfbb0ae
---
M sc/source/filter/xml/xmlcondformat.cxx
1 file changed, 8 insertions(+), 0 deletions(-)



diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index 8b97a78..ae0c2d7 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -254,6 +254,14 @@
 else
 mpFormatData->mbNeg = false;
 
+if(!sAxisPosition.isEmpty())
+{
+if(sAxisPosition == "middle")
+mpFormatData->meAxisPosition = databar::MIDDLE;
+else if (sAxisPosition == "none")
+mpFormatData->meAxisPosition = databar::NONE;
+}
+
 if(!sAxisColor.isEmpty())
 {
 sal_Int32 nColor = 0;

-- 
To view, visit https://gerrit.libreoffice.org/1781
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id035741b2372c76f9afe54f59f2203c5edfbb0ae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: prevent to create cond formats with empty range, fdo#58778

2013-01-20 Thread Markus Mohrhard (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1780

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1780/1

prevent to create cond formats with empty range, fdo#58778

Change-Id: I54bac843dc60c419c23c6d3f22c8d2f4b5805327
---
M sc/source/ui/condformat/condformatdlg.cxx
M sc/source/ui/condformat/condformatmgr.cxx
M sc/source/ui/view/cellsh1.cxx
3 files changed, 19 insertions(+), 8 deletions(-)



diff --git a/sc/source/ui/condformat/condformatdlg.cxx 
b/sc/source/ui/condformat/condformatdlg.cxx
index 9a7be09..1af8118 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -463,12 +463,20 @@
 ScConditionalFormat* ScCondFormatDlg::GetConditionalFormat() const
 {
 rtl::OUString aRangeStr = maEdRange.GetText();
+if(aRangeStr.isEmpty())
+return NULL;
+
 ScRangeList aRange;
 sal_uInt16 nFlags = aRange.Parse(aRangeStr, mpDoc, SCA_VALID, 
mpDoc->GetAddressConvention(), maPos.Tab());
 ScConditionalFormat* pFormat = maCondFormList.GetConditionalFormat();
 
 if(nFlags & SCA_VALID && !aRange.empty() && pFormat)
 pFormat->AddRange(aRange);
+else
+{
+delete pFormat;
+pFormat = NULL;
+}
 
 return pFormat;
 }
diff --git a/sc/source/ui/condformat/condformatmgr.cxx 
b/sc/source/ui/condformat/condformatmgr.cxx
index 5a5ea1b..e9278a0 100644
--- a/sc/source/ui/condformat/condformatmgr.cxx
+++ b/sc/source/ui/condformat/condformatmgr.cxx
@@ -276,14 +276,14 @@
 if(pDlg->Execute() == RET_OK)
 {
 ScConditionalFormat* pNewFormat = pDlg->GetConditionalFormat();
-if(!pNewFormat)
-return 0;
+if(pNewFormat)
+{
+mpFormatList->InsertNew(pNewFormat);
+pNewFormat->SetKey(FindKey(mpFormatList));
+maCtrlManager.Update();
 
-mpFormatList->InsertNew(pNewFormat);
-pNewFormat->SetKey(FindKey(mpFormatList));
-maCtrlManager.Update();
-
-mbModified = true;
+mbModified = true;
+}
 }
 Show(true, 0);
 pScMod->SetRefDialog( nId, false );
diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 2227c19..f67717d 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1879,7 +1879,10 @@
 if( pCondFormatDlg->Execute() == RET_OK )
 {
 ScConditionalFormat* pFormat = 
pCondFormatDlg->GetConditionalFormat();
-
pData->GetDocShell()->GetDocFunc().ReplaceConditionalFormat(nKey, pFormat, 
aPos.Tab(), pFormat->GetRange());
+if(pFormat)
+
pData->GetDocShell()->GetDocFunc().ReplaceConditionalFormat(nKey, pFormat, 
aPos.Tab(), pFormat->GetRange());
+else
+
pData->GetDocShell()->GetDocFunc().ReplaceConditionalFormat(nKey, NULL, 
aPos.Tab(), ScRangeList());
 }
 
 pScMod->SetRefDialog( nId, false );

-- 
To view, visit https://gerrit.libreoffice.org/1780
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I54bac843dc60c419c23c6d3f22c8d2f4b5805327
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Change in core[libreoffice-4-0]: don't create multiple dialogs in the loop, fdo#59314

2013-01-20 Thread Markus Mohrhard (via Code Review) 
Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/1778

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/78/1778/1

don't create multiple dialogs in the loop, fdo#59314

Change-Id: Ia48262cdf8b07caf6622f2d4a48f366f3f26c0fd
---
M sc/source/ui/view/cellsh1.cxx
1 file changed, 1 insertion(+), 0 deletions(-)



diff --git a/sc/source/ui/view/cellsh1.cxx b/sc/source/ui/view/cellsh1.cxx
index 68be16dd..2227c19 100644
--- a/sc/source/ui/view/cellsh1.cxx
+++ b/sc/source/ui/view/cellsh1.cxx
@@ -1805,6 +1805,7 @@
 // found a matching range, edit this conditional 
format
 nKey = pCondFormat->GetKey();
 pCondFormatDlg.reset( new ScCondFormatDlg( 
pTabViewShell->GetDialogParent(), pDoc, pCondFormat, rCondFormatRange, aPos, 
condformat::dialog::NONE ) );
+break;
 }
 }
 

-- 
To view, visit https://gerrit.libreoffice.org/1778
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia48262cdf8b07caf6622f2d4a48f366f3f26c0fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-4-0
Gerrit-Owner: Markus Mohrhard 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: sc/source

2013-01-20 Thread Libreoffice Gerrit user 
 sc/source/filter/xml/xmlcondformat.cxx |8 
 1 file changed, 8 insertions(+)

New commits:
commit d7728bb63086a73594fb59d6b0d55cf4975f0fc1
Author: Markus Mohrhard 
Date:   Sun Jan 20 10:56:10 2013 +0100

add missing data bar axis import, fdo#59578

Change-Id: Id035741b2372c76f9afe54f59f2203c5edfbb0ae

diff --git a/sc/source/filter/xml/xmlcondformat.cxx 
b/sc/source/filter/xml/xmlcondformat.cxx
index e3f3903..1f0a31b 100644
--- a/sc/source/filter/xml/xmlcondformat.cxx
+++ b/sc/source/filter/xml/xmlcondformat.cxx
@@ -254,6 +254,14 @@ ScXMLDataBarFormatContext::ScXMLDataBarFormatContext( 
ScXMLImport& rImport, sal_
 else
 mpFormatData->mbNeg = false;
 
+if(!sAxisPosition.isEmpty())
+{
+if(sAxisPosition == "middle")
+mpFormatData->meAxisPosition = databar::MIDDLE;
+else if (sAxisPosition == "none")
+mpFormatData->meAxisPosition = databar::NONE;
+}
+
 if(!sAxisColor.isEmpty())
 {
 sal_Int32 nColor = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Ganhe Dinheiro Sem Precisar Vender Nada, vale a pena dar uma olhada

2013-01-20 Thread Alfa Divulgaçoes 

Seu cliente de e-mail não pode ler este e-mail.
Para visualizá-lo on-line, por favor, clique aqui:
http://www.ofertacelularesnews.com/display.php?M=2470733&C=afb220d87c8c8380c3dd4643ef47abb9&S=24&L=15&N=1


Para parar de receber nossos
Emails:http://www.ofertacelularesnews.com/unsubscribe.php?M=2470733&C=afb220d87c8c8380c3dd4643ef47abb9&L=15&N=24
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-20 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=54157

Rainer Bielefeld  changed:

   What|Removed |Added

 Depends on||59613

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-20 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=54157

--- Comment #84 from Rainer Bielefeld  ---
I add "Bug 59613 - RTL VIEWING: Increasing size of dialogs to right or bottom
causes artifacts": very fixible and makes new "resizable dialogs" feature more
or less unusable for RTL UI

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice