[Libreoffice-commits] .: Branch 'libreoffice-4-0' - vcl/inc vcl/source
vcl/inc/sallayout.hxx|1 - vcl/source/gdi/sallayout.cxx | 26 -- 2 files changed, 27 deletions(-) New commits: commit 9b70bf62e6b5319e282cd3533c90216aabccfe53 Author: Caolán McNamara caol...@redhat.com Date: Wed Jan 23 14:33:38 2013 + fdo#54629 MultiSalLayout::GetBoundRect always uses level 0 fallback font ...in X11SalGraphics::GetGlyphBoundRect In MultiSalLayout::GetBoundRect we loop through each fallback font and union each level's GetBoundRect to get the result, which seems reasonable, except that for each level that means a call to SalLayout::GetBoundRect which calls X11SalGraphics::GetGlyphBoundRect. Those sublevel SalLayouts don't know that they are sublevels so they never set the level bits on their glyphs. Which results in X11SalGraphics::GetGlyphBoundRect always searching for that glyph in the level 0 font, so there's a mismatch between the font the SalLayout's are created to use and the font that gets used. Now, SalLayout::GetBoundRect is a fairly simple thing, it just calls GetNextGlyphs 1 by 1 and X11SalGraphics::GetGlyphBoundRect on the result of that. So I *think* that if we remove the specialized MultiSalLayout::GetBoundRect in favour of the default implementation, then because MultiSalLayout::GetNextGlyphs is specialized to do-the-right-thing and set up the glyph ids correctly, then we bubble the ids down to X11SalGraphics::GetGlyphBoundRect correctly to get it to use the right font and we get the correct bounding size. defb4d60a2d22fd36a0ff3f077faa6a0932b45a4 defb4d60a2d22fd36a0ff3f077faa6a0932b45a4 Change-Id: Idefb4d60a2d22fd36a0ff3f077faa6a0932b45a4 Reviewed-on: https://gerrit.libreoffice.org/1907 Tested-by: Lior Kaplan kaplanl...@gmail.com Reviewed-by: Miklos Vajna vmik...@suse.cz diff --git a/vcl/inc/sallayout.hxx b/vcl/inc/sallayout.hxx index bef64af..b45d122 100644 --- a/vcl/inc/sallayout.hxx +++ b/vcl/inc/sallayout.hxx @@ -253,7 +253,6 @@ public: virtual int GetNextGlyphs( int nLen, sal_GlyphId* pGlyphIdxAry, Point rPos, int, sal_Int32* pGlyphAdvAry, int* pCharPosAry ) const; virtual boolGetOutline( SalGraphics, ::basegfx::B2DPolyPolygonVector ) const; -virtual boolGetBoundRect( SalGraphics, Rectangle ) const; // used only by OutputDevice::ImplLayout, TODO: make friend explicitMultiSalLayout( SalLayout rBaseLayout, diff --git a/vcl/source/gdi/sallayout.cxx b/vcl/source/gdi/sallayout.cxx index 140037d..fe5cf8b 100644 --- a/vcl/source/gdi/sallayout.cxx +++ b/vcl/source/gdi/sallayout.cxx @@ -2080,30 +2080,4 @@ bool MultiSalLayout::GetOutline( SalGraphics rGraphics, return bRet; } -// --- - -bool MultiSalLayout::GetBoundRect( SalGraphics rGraphics, Rectangle rRect ) const -{ -bool bRet = false; - -Rectangle aRectangle; -for( int i = mnLevel; --i = 0; ) -{ -SalLayout rLayout = *mpLayouts[ i ]; -rLayout.DrawBase() = maDrawBase; -rLayout.DrawOffset() += maDrawOffset; -rLayout.InitFont(); -if( rLayout.GetBoundRect( rGraphics, aRectangle ) ) -{ -rRect.Union( aRectangle ); -bRet = true; -} -rLayout.DrawOffset() -= maDrawOffset; -} - -return bRet; -} - -// === - /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 choffardet pierre.choffar...@free.fr changed: What|Removed |Added Depends on||60065 --- Comment #100 from choffardet pierre.choffar...@free.fr --- Adding bug 60065 (BASIC: Can't set an object to NamedValue structure) because it's a regression and there is no workaround many macros are broken -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - registry/tools
registry/tools/reg2bin.cxx | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit 8517b6162e5531e733a0b2ffe8106873d8e0d082 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 3 10:31:33 2013 +0100 Typo Change-Id: I8e4f7c5a44bc300913efb68f901b794d8fb385fe diff --git a/registry/tools/reg2bin.cxx b/registry/tools/reg2bin.cxx index 862289a..7e5001e 100644 --- a/registry/tools/reg2bin.cxx +++ b/registry/tools/reg2bin.cxx @@ -975,7 +975,7 @@ sal_uInt64 writeNameNul(osl::File file, rtl::OUString const name) { void writeNameLen(osl::File file, rtl::OUString const name) { rtl::OString ascii(toAscii(name)); -write32(file, name.getLength()); +write32(file, ascii.getLength()); write(file, ascii.getStr(), ascii.getLength()); } commit 027b5e48329b508bd88616fe9dee8646e354480f Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 3 10:29:51 2013 +0100 reg2bin: truncate pre-existing output files Change-Id: If74cccf8657c1b81467ee9c0dea29a749ca07455 diff --git a/registry/tools/reg2bin.cxx b/registry/tools/reg2bin.cxx index 959f25d..862289a 100644 --- a/registry/tools/reg2bin.cxx +++ b/registry/tools/reg2bin.cxx @@ -1395,6 +1395,14 @@ SAL_IMPLEMENT_MAIN() { write32(f, 0); // root map offset write32(f, 0); // root map size sal_uInt64 off = writeMap(f, map, true); +e2 = f.setSize(getOffset(f)); // truncate in case it already existed +if (e2 != osl::FileBase::E_None) { +std::cerr + Cannot set size of \ f.getURL() \, error code + +e2 \n; +std::exit(EXIT_FAILURE); +} + e2 = f.setPos(osl_Pos_Absolut, 8); if (e2 != osl::FileBase::E_None) { std::cerr ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug
bug/bug/bug.js |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0e672d57daf34ce519abba13cac6f35d0124 Author: Rob Snelders programm...@ertai.nl Date: Sun Feb 3 10:39:00 2013 +0100 setting the correct variable diff --git a/bug/bug/bug.js b/bug/bug/bug.js index 0c96417..40a2bbe 100644 --- a/bug/bug/bug.js +++ b/bug/bug/bug.js @@ -170,7 +170,7 @@ $('.active_subcomponent .select', element).select(); $('.active_subcomponent .select .choice', element).click(function() { $.bug.refresh_related_bugs(); -$.bug.subcomponent = $('.state_details .active_subcomponent .chosen').attr('data'); +$.bug.sub_component = $('.state_details .active_subcomponent .chosen').attr('data'); if ($.bug.lo_version != '' $.bug.op_sys != '' $.bug.regression != '') { $.bug.state_description(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: configure.ac lo.xcent.in Makefile.in
Makefile.in | 14 -- configure.ac |2 +- lo.xcent.in | 15 +++ 3 files changed, 28 insertions(+), 3 deletions(-) New commits: commit 4783eea7269010910879ed3584b229d9492a2ddc Author: Tor Lillqvist t...@iki.fi Date: Sat Feb 2 23:25:56 2013 +0200 Experiment with sandboxing Change-Id: If491917069ef7c474c27190c4759dd75f025f032 diff --git a/Makefile.in b/Makefile.in index c0425f8..6565ab8 100644 --- a/Makefile.in +++ b/Makefile.in @@ -324,7 +324,13 @@ install-strip: echo Installation finished, you can now execute: \ echo $(INSTALLDIR)/program/soffice -dev-install: build +ifeq ($(ENABLE_MACOSX_SANDBOX),YES) +entitlements:=--entitlements $(SRC_ROOT)/lo.xcent +endif + +dev-install: build do-dev-install + +do-dev-install: @rm -rf $(DEVINSTALLDIR) @mkdir $(DEVINSTALLDIR) ifeq ($(OS_FOR_BUILD),WNT) @@ -363,6 +369,7 @@ ifneq ($(MACOSX_CODESIGNING_IDENTITY),) # Yeah, we don't bundle any other framework than our Python one, and # it has just one version, so this generic search is mostly for # completeness. +# for framework in `find $(DEVINSTALLDIR)/opt/LibreOffice.app -name '*.framework' -type d`; do \ for version in $$framework/Versions/*; do \ test -d $$version codesign --force --verbose --prefix=$(MACOSX_BUNDLE_IDENTIFIER). --sign $(MACOSX_CODESIGNING_IDENTITY) $$version; \ @@ -374,7 +381,10 @@ ifneq ($(MACOSX_CODESIGNING_IDENTITY),) # The soffice binary will have been signed after linking but it needs # to be re-signed as it has been renamed, or modified, or something # after linking. - codesign --force --verbose --sign $(MACOSX_CODESIGNING_IDENTITY) $(DEVINSTALLDIR)/opt/LibreOffice.app +# +# At this stage we also attach the entitlements in the sandboxing case +# + codesign --force --verbose --sign $(MACOSX_CODESIGNING_IDENTITY) $(entitlements) $(DEVINSTALLDIR)/opt/LibreOffice.app # endif @install-gdb-printers -L diff --git a/configure.ac b/configure.ac index 2a72b40..d5d6857 100644 --- a/configure.ac +++ b/configure.ac @@ -12381,7 +12381,7 @@ else echo config_host.mk.last fi -AC_CONFIG_FILES([config_host.mk Makefile solenv/inc/minor.mk instsetoo_native/util/openoffice.lst]) +AC_CONFIG_FILES([config_host.mk Makefile lo.xcent solenv/inc/minor.mk instsetoo_native/util/openoffice.lst]) AC_CONFIG_HEADERS([config_host/config_clang.h]) AC_CONFIG_HEADERS([config_host/config_global.h]) AC_CONFIG_HEADERS([config_host/config_graphite.h]) diff --git a/lo.xcent.in b/lo.xcent.in new file mode 100644 index 000..5ed76f1 --- /dev/null +++ b/lo.xcent.in @@ -0,0 +1,15 @@ +?xml version=1.0 encoding=UTF-8? +!DOCTYPE plist PUBLIC -//Apple//DTD PLIST 1.0//EN http://www.apple.com/DTDs/PropertyList-1.0.dtd; +plist version=1.0 +dict + keycom.apple.application-identifier/key + string@MACOSX_BUNDLE_IDENTIFIER@/string + keycom.apple.security.app-sandbox/key + true/ + keycom.apple.security.files.user-selected.read-write/key + true/ + !-- usb needed for the apple_remote thingie... -- + keycom.apple.security.device.usb/key + true/ +/dict +/plist ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: cppuhelper/source registry/tools
cppuhelper/source/typedescriptionprovider.cxx | 96 +++--- registry/tools/reg2bin.cxx| 16 +++- 2 files changed, 70 insertions(+), 42 deletions(-) New commits: commit 02b9e755f71227d91fc93bf940699da6772c5b33 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 3 10:40:46 2013 +0100 reg2bin: Shrink output by reusing common strings ...all the Offset of Idx-Name in the data format can likely be further shrunk by getting rid of the newly added level of indirection again. Change-Id: I322f4869a4d6f2e63802406f998e22beea30db41 diff --git a/cppuhelper/source/typedescriptionprovider.cxx b/cppuhelper/source/typedescriptionprovider.cxx index 35db672..b45cb39 100644 --- a/cppuhelper/source/typedescriptionprovider.cxx +++ b/cppuhelper/source/typedescriptionprovider.cxx @@ -70,7 +70,10 @@ // * UInt64: 8-byte value, LSB first // * Offset: UInt32 value, counting bytes from start of file // * NUL-Name: zero or more non-NUL US-ASCII bytes followed by a NUL byte -// * Len-Name: UInt32 number of characters followed by that many US-ASCII bytes +// * Len-Name: UInt32 number of characters, with 0x8000 bit 1, followed by +//that many (- 0x8000) US-ASCII bytes +// * Idx-Name: either an Offset (with 0x8000 bit 0) of a Len-Name, or a +//Len-Name // * Entry: Offset of NUL-Name followed by Offset of payload // * Map: zero or more Entries // @@ -90,62 +93,62 @@ // * followed by: // ** UInt32 number N1 of members // ** N1 * tuple of: -// *** Offset of Len-Name +// *** Offset of Idx-Name // *** UInt32 // 2: plain struct type (with base if flag is 1) // * followed by: -// ** if with base: Offset of Len-Name +// ** if with base: Offset of Idx-Name // ** UInt32 number N1 of direct members // ** N1 * tuple of: -// *** Offset of Len-Name name -// *** Offset of Len-Name type +// *** Offset of Idx-Name name +// *** Offset of Idx-Name type // 3: polymorphic struct type template // * followed by: // ** UInt32 number N1 of type parameters -// ** N1 * Offset of Len-Name +// ** N1 * Offset of Idx-Name // ** UInt32 number N2 of members // ** N2 * tuple of: // *** kind byte: 0x01 bit is 1 if parameterized type -// *** Offset of Len-Name name -// *** Offset of Len-Name type +// *** Offset of Idx-Name name +// *** Offset of Idx-Name type // 4: exception type (with base if flag is 1) // * followed by: -// ** if with base: Offset of Len-Name +// ** if with base: Offset of Idx-Name // ** UInt32 number N1 of direct members // ** N1 * tuple of: -// *** Offset of Len-Name name -// *** Offset of Len-Name type +// *** Offset of Idx-Name name +// *** Offset of Idx-Name type // 5: interface type // * followed by: // ** UInt32 number N1 of direct mandatory bases -// ** N1 * Offset of Len-Name +// ** N1 * Offset of Idx-Name // ** UInt32 number N2 of direct optional bases -// ** N2 * Offset of Len-Name +// ** N2 * Offset of Idx-Name // ** UInt32 number N3 of direct attributes // ** N3 * tuple of: // *** kind byte: // 0x02 bit: 1 if read-only // 0x01 bit: 1 if bound -// *** Offset of Len-Name name -// *** Offset of Len-Name type +// *** Offset of Idx-Name name +// *** Offset of Idx-Name type // *** UInt32 number N4 of get exceptions -// *** N4 * Offset of Len-Name +// *** N4 * Offset of Idx-Name // *** UInt32 number N5 of set exceptions -// *** N5 * Offset of Len-Name +// *** N5 * Offset of Idx-Name // ** UInt32 number N6 of direct methods // ** N6 * tuple of: -// *** Offset of Len-Name name -// *** Offset of Len-Name return type +// *** Offset of Idx-Name name +// *** Offset of Idx-Name return type // *** UInt32 number N7 of parameters // *** N7 * tuple of: // direction byte: 0 for in, 1 for out, 2 for in-out -// Offset of Len-Name name -// Offset of Len-Name type +// Offset of Idx-Name name +// Offset of Idx-Name type // *** UInt32 number N8 of exceptions -// *** N8 * Offset of Len-Name +// *** N8 * Offset of Idx-Name // 6: typedef // * followed by: -// ** Offset of Len-Name +// ** Offset of Idx-Name // 7: constant group // * followed by: // ** UInt32 number N1 of entries of Map @@ -153,28 +156,28 @@ // 8: single-interface--based service (with default constructor if flag is // 1) // * followed by: -// ** Offset of Len-Name +// ** Offset of Idx-Name // ** if not with default constructor: // *** UInt32 number N1 of constructors // *** N1 * tuple of: -// Offset of Len-Name +// Offset of Idx-Name // UInt32 number N2 of parameters // N2 * tuple of // * kind byte:
[Libreoffice-commits] .: Makefile.in
Makefile.in |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) New commits: commit 24a29a1348357ed055c4ec04b7f19873e60909ac Author: Tor Lillqvist t...@iki.fi Date: Sun Feb 3 11:52:13 2013 +0200 Undo temporary change accidentally committed Change-Id: Iec24cb165009d4769ee3068739c6edc222799017 diff --git a/Makefile.in b/Makefile.in index 6565ab8..52df78f 100644 --- a/Makefile.in +++ b/Makefile.in @@ -328,9 +328,7 @@ ifeq ($(ENABLE_MACOSX_SANDBOX),YES) entitlements:=--entitlements $(SRC_ROOT)/lo.xcent endif -dev-install: build do-dev-install - -do-dev-install: +dev-install: build @rm -rf $(DEVINSTALLDIR) @mkdir $(DEVINSTALLDIR) ifeq ($(OS_FOR_BUILD),WNT) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Crash during Traditional Chinese - Simplified Chinese conversion
Hi Matteo, On Fri, 2013-01-04 at 14:58 +0100, Matteo Casalin wrote: Obviously, this would not work since we will get the same issue on the second loop. Instead we can push PaM information (on which to SetFontAndLanguage) in a queue and then iterate on it after the main loop is completed. I'll start working on a patch and see what happens with the Chinese document I have available. If that works, I'll submit the patch to gerrit, hoping that someone could also apply broader tests on the results (I don't have any knowledge of Chinese). I can help you test if you need, my limited knowledge of chinese may be OK to check the conversions ;) -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: CMIS + LibreOffice integration video with EN voice over
Hello Marc, Leif, On Sat, 2013-02-02 at 21:47 -0500, Marc Paré wrote: Leif Lodahl has just uploaded a video with steps to CMIS + LibreOffice integration with EN voice over.[1] Thanks Leif! Thanks a lot for the video. I would have added one more thing at the beginning: * Show how to get the file picker (as this is not the default) * Show how to add the server to the file picker places. Otherwise, it's a great demonstration of the feature! -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2802c4eea953430538471454d2853f792f70b081 Author: Stanislav Horacek stanislav.hora...@gmail.com Date: Sat Feb 2 21:15:06 2013 +0100 Updated core Project: help 5df11836790b705261ba5cc72f3e52a4569472a4 diff --git a/helpcontent2 b/helpcontent2 index c725b25..5df11836 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit c725b25af49aa5292a88eb0fd53eb322861567d1 +Subproject commit 5df11836790b705261ba5cc72f3e52a4569472a4 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 4 commits - source/text
source/text/scalc/01/04060103.xhp |2 +- source/text/scalc/guide/text_wrap.xhp |2 +- source/text/shared/00/0406.xhp |2 +- source/text/shared/00/00040502.xhp |6 +++--- source/text/shared/01/0101.xhp |4 ++-- source/text/shared/autopi/0105.xhp |2 +- 6 files changed, 9 insertions(+), 9 deletions(-) New commits: commit 5df11836790b705261ba5cc72f3e52a4569472a4 Author: Stanislav Horacek stanislav.hora...@gmail.com Date: Sat Feb 2 21:15:06 2013 +0100 input line in Calc can be expanded to the multi-line diff --git a/source/text/scalc/guide/text_wrap.xhp b/source/text/scalc/guide/text_wrap.xhp index e032557..7633e23 100644 --- a/source/text/scalc/guide/text_wrap.xhp +++ b/source/text/scalc/guide/text_wrap.xhp @@ -38,7 +38,7 @@ section id=wraptext list type=ordered listitem -paragraph role=listitem id=par_id3156280 xml-lang=en-US l10n=U oldref=41Pressing the switchinline select=syscaseinline select=MACCommand/caseinlinedefaultinlineCtrl/defaultinline/switchinline+Enter keys inserts a manual line break. This shortcut only works directly in the cell, not in the input line./paragraph +paragraph role=listitem id=par_id3156280 xml-lang=en-US l10n=U oldref=41Pressing the switchinline select=syscaseinline select=MACCommand/caseinlinedefaultinlineCtrl/defaultinline/switchinline+Enter keys inserts a manual line break. This shortcut works directly in the cell or in the input line. The input line can be expaneded to the multi-line by the Down arrow button on the right./paragraph /listitem /list paragraph role=paragraph id=par_id3153142 xml-lang=en-US l10n=U oldref=43If you want the text to automatically break at the right border of the cell, proceed as follows:/paragraph commit bf7defabfd44aa46fe2b439ff4e154f8050c20eb Author: Stanislav Horacek stanislav.hora...@gmail.com Date: Sat Feb 2 20:54:54 2013 +0100 fix some items in menu navigation diff --git a/source/text/shared/00/0406.xhp b/source/text/shared/00/0406.xhp index 557134c..9c27258 100644 --- a/source/text/shared/00/0406.xhp +++ b/source/text/shared/00/0406.xhp @@ -125,7 +125,7 @@ /variable/paragraph paragraph xml-lang=en-US id=par_id3157895 role=paragraph l10n=U oldref=50variable id=autokorrChoose emphTools - AutoCorrect Options/emph /variable/paragraph - paragraph xml-lang=en-US id=par_id3153768 role=paragraph l10n=U oldref=51variable id=autokooptionenChoose emphTools - AutoCorrect Options/emph tab + paragraph xml-lang=en-US id=par_id3153768 role=paragraph l10n=U oldref=51variable id=autokooptionenChoose emphTools - AutoCorrect Options - Options/emph tab /variable/paragraph paragraph xml-lang=en-US id=par_id1978514 role=paragraph l10n=NEWvariable id=autokosmarttagsChoose emphTools - AutoCorrect Options - Smart Tags/emph tab /variable/paragraph diff --git a/source/text/shared/00/00040502.xhp b/source/text/shared/00/00040502.xhp index 2835e98..a51cb25 100644 --- a/source/text/shared/00/00040502.xhp +++ b/source/text/shared/00/00040502.xhp @@ -141,15 +141,15 @@ /caseinlinecaseinline select=CALCemphGraphic - /emph /caseinline/switchinlineemphArea - Bitmaps/emph tab /variable/paragraph - paragraph xml-lang=en-US id=par_id3145251 role=paragraph l10n=CHG oldref=34variable id=formattextChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text - Text Attributes/emph + paragraph xml-lang=en-US id=par_id3145251 role=paragraph l10n=CHG oldref=34variable id=formattextChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text Attributes/emph /caseinlinecaseinline select=CALCemphGraphic - Define Text Attributes/emph /caseinlinedefaultinlineemphText/emph/defaultinline/switchinline /variable/paragraph - paragraph xml-lang=en-US id=par_id3152810 role=paragraph l10n=CHG oldref=35variable id=textChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text - Text Attributes/emph + paragraph xml-lang=en-US id=par_id3152810 role=paragraph l10n=CHG oldref=35variable id=textChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text Attributes/emph /caseinlinecaseinline select=CALCemphGraphic - Define Text Attributes/emph /caseinlinedefaultinlineemphText/emph/defaultinline/switchinlineemph - Text/emph tab /variable/paragraph - paragraph xml-lang=en-US id=par_id3151060 role=paragraph l10n=CHG oldref=36variable id=laufextChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text - Text Attributes/emph + paragraph xml-lang=en-US id=par_id3151060 role=paragraph l10n=CHG oldref=36variable id=laufextChoose emphFormat - /emphswitchinline select=applcaseinline select=WRITERemphObject - Text Attributes/emph /caseinlinecaseinline select=CALCemphGraphic - Define Text Attributes/emph
Re: [PUSHED] Corrections to local help
On Sat, Feb 2, 2013 at 9:34 PM, Stanislav Horáček stanislav.hora...@gmail.com wrote: Hello, as usually, I send a set of various small corrections to the LO local help. Pushed, thanks. Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] sw/source
sw/source/core/layout/frmtool.cxx | 14 -- 1 file changed, 14 deletions(-) New commits: commit cb33714517c3302da6c765aed977341b603c1017 Author: Miklos Vajna vmik...@suse.cz Date: Sun Feb 3 12:23:40 2013 +0100 sw: unused includes in frmtool Change-Id: Iddd1c24211597822f6dd480c76f841607bc13364 diff --git a/sw/source/core/layout/frmtool.cxx b/sw/source/core/layout/frmtool.cxx index 9a60553..db4ef96 100644 --- a/sw/source/core/layout/frmtool.cxx +++ b/sw/source/core/layout/frmtool.cxx @@ -17,23 +17,17 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include hintids.hxx #include tools/bigint.hxx #include svx/svdmodel.hxx #include svx/svdpage.hxx #include editeng/brshitem.hxx -#include editeng/keepitem.hxx #include editeng/shaditem.hxx #include editeng/ulspitem.hxx -#include editeng/lrspitem.hxx #include editeng/boxitem.hxx -#include sfx2/printer.hxx #include editeng/lspcitem.hxx #include fmtornt.hxx -#include fmtanchr.hxx #include fmthdft.hxx -#include fmtcntnt.hxx #include fmtfsize.hxx #include fmtsrnd.hxx #include docary.hxx @@ -41,15 +35,12 @@ #include swmodule.hxx #include pagefrm.hxx #include colfrm.hxx -#include doc.hxx #include fesh.hxx #include viewimp.hxx #include viewopt.hxx -#include pam.hxx #include dflyobj.hxx #include dcontact.hxx #include frmtool.hxx -#include docsh.hxx #include tabfrm.hxx #include rowfrm.hxx #include ftnfrm.hxx @@ -62,14 +53,10 @@ #include sectfrm.hxx #include node2lay.hxx #include ndole.hxx -#include ndtxt.hxx -#include swtable.hxx #include hints.hxx #include layhelp.hxx #include laycache.hxx #include rootfrm.hxx -#include mdiexp.hxx -#include statstr.hrc #include paratr.hxx #include sortedobjs.hxx #include objectformatter.hxx @@ -3359,7 +3346,6 @@ const SwFrm* FindPage( const SwRect rRect, const SwFrm *pPage ) return pPage; } -#include svl/smplhint.hxx class SwFrmHolder : private SfxListener { SwFrm* pFrm; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: bug/bug
bug/bug/bug.js |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2cd4a48ea76094e5867ca87fbd5b3c390ec8f49e Author: Rob Snelders programm...@ertai.nl Date: Sun Feb 3 13:25:19 2013 +0100 fill in the subcomponent diff --git a/bug/bug/bug.js b/bug/bug/bug.js index 40a2bbe..d52d9da 100644 --- a/bug/bug/bug.js +++ b/bug/bug/bug.js @@ -274,7 +274,7 @@ } $.bug.error_clear(); var component = $('.state_component .chosen').attr('data').replace('_',' '); -var short_desc = $.bug.subcomponent + ': ' + $('.state_description .short').val(); +var short_desc = $.bug.sub_component + ': ' + $('.state_description .short').val(); //Add Operating System var op_sys = $('.state_op_sys .chosen').attr('data'); var comment = $('.state_description .long').val(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fix logic to get L/R direction
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1972 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/72/1972/1 fix logic to get L/R direction Change-Id: I481f9ea57f8c5b71eb849df3f71c75f8b9b0f1fa --- M editeng/source/editeng/impedit3.cxx 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx index 4458937..8108770 100644 --- a/editeng/source/editeng/impedit3.cxx +++ b/editeng/source/editeng/impedit3.cxx @@ -4287,7 +4287,7 @@ short nScriptType = GetScriptType( EditPaM( pNode, nIndex+1 ) ); bCTL = nScriptType == i18n::ScriptType::COMPLEX; // this change was discussed in issue 37190 -bR2L = GetRightToLeft( nPara, nIndex + 1) == 1 /*RTL*/ ? true : false; +bR2L = GetRightToLeft( nPara, nIndex + 1) % 2 ? sal_True : sal_False; // it also works for issue 55927 } -- To view, visit https://gerrit.libreoffice.org/1972 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I481f9ea57f8c5b71eb849df3f71c75f8b9b0f1fa Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: navin patidar pati...@kacst.edu.sa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED libreoffice-4-0] fdo#54629 MultiSalLayout::GetBoundRect always uses level 0 f...
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1907 Approvals: Lior Kaplan: Verified Miklos Vajna: Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1907 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idefb4d60a2d22fd36a0ff3f077faa6a0932b45a4 Gerrit-PatchSet: 2 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Caolán McNamara caol...@redhat.com Gerrit-Reviewer: Lior Kaplan kaplanl...@gmail.com Gerrit-Reviewer: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/rtfimport/data/fdo59419.rtf |5 + sw/qa/extras/rtfimport/rtfimport.cxx | 10 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |8 3 files changed, 23 insertions(+) New commits: commit f593a2e4179b05ae1019372cde612cb242d1d27f Author: Miklos Vajna vmik...@suse.cz Date: Sun Feb 3 14:37:38 2013 +0100 fdo#59419 fix RTF import of hex form of \r and \n Change-Id: Ic700cdc67f756cafc454c326b73f680a8a47a6e8 diff --git a/sw/qa/extras/rtfimport/data/fdo59419.rtf b/sw/qa/extras/rtfimport/data/fdo59419.rtf new file mode 100644 index 000..ec52508 --- /dev/null +++ b/sw/qa/extras/rtfimport/data/fdo59419.rtf @@ -0,0 +1,5 @@ +{\rtf1 +\trowd\cellx3000\pard\plain\intbl the next cell will be empty\cell\row +\pard\trowd\cellx3000\pard\plain\intbl\'0d\cell\row +\pard\par +} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index ab8ac50..c321ba6 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -139,6 +139,7 @@ public: void testFdo44053(); void testFdo48440(); void testFdo58646(); +void testFdo59419(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -249,6 +250,7 @@ void Test::run() {fdo44053.rtf, Test::testFdo44053}, {fdo48440.rtf, Test::testFdo48440}, {fdo58646.rtf, Test::testFdo58646}, +{fdo59419.rtf, Test::testFdo59419}, }; header(); for (unsigned int i = 0; i SAL_N_ELEMENTS(aMethods); ++i) @@ -1078,6 +1080,14 @@ void Test::testFdo58646() CPPUNIT_ASSERT_EQUAL(2, getPages()); } +void Test::testFdo59419() +{ +// Junk to be ignored broke import of the table. +uno::Referencetext::XTextTablesSupplier xTablesSupplier(mxComponent, uno::UNO_QUERY); +uno::Referencecontainer::XIndexAccess xTables(xTablesSupplier-getTextTables(), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTables-getCount()); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index 3aed3b4..bc15702 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -945,6 +945,14 @@ void RTFDocumentImpl::singleChar(sal_uInt8 nValue, bool bRunProps) void RTFDocumentImpl::text(OUString rString) { +if (rString.getLength() == 1) +{ +// No cheating! Tokenizer ignores bare \r and \n, their hex \'0d / \'0a form doesn't count, either. +char ch = rString.getStr()[0]; +if (ch == 0x0d || ch == 0x0a) +return; +} + bool bRet = true; switch (m_aStates.top().nDestinationState) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3b147851a5b1d73e77223e6101bd381d40fd97bb Author: Miklos Vajna vmik...@suse.cz Date: Sun Feb 3 15:45:28 2013 +0100 fix failing testcase Change-Id: I191f7bb6286998222877db863e45b24e0e7618b8 diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index bc15702..9e2ce72 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -945,10 +945,10 @@ void RTFDocumentImpl::singleChar(sal_uInt8 nValue, bool bRunProps) void RTFDocumentImpl::text(OUString rString) { -if (rString.getLength() == 1) +if (rString.getLength() == 1 m_aStates.top().nDestinationState != DESTINATION_DOCCOMM) { // No cheating! Tokenizer ignores bare \r and \n, their hex \'0d / \'0a form doesn't count, either. -char ch = rString.getStr()[0]; +sal_Unicode ch = rString.getStr()[0]; if (ch == 0x0d || ch == 0x0a) return; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
A little info about ligatures and e.g. Calibri
FWIW, as it came up as a question in the main track FOSDEM LibreOffice talk, in vcl/generic/glyphs/gcach_layout.cxx see IcuLayoutEngine::layout and... if (rArgs.mnFlags SAL_LAYOUT_ENABLE_LIGATURES) nLayoutFlags |= LayoutEngine::kTypoFlagLiga; so ligatures are disabled by default unless SAL_LAYOUT_ENABLE_LIGATURES is enabled, and SAL_LAYOUT_ENABLE_LIGATURES is only set if TEXT_LAYOUT_ENABLE_LIGATURES is set on the outputdevice, and that doesn't happen anywhere as of yet :-( It would be no major problem to e.g. bubble up allowing those ligatures to be set explicitly via the UI, or e.g. defaulted on via a new compatibility flag for new docs, but the last time I played around with it I ran into the snag that with our current Linux rendering stack via cairo we get the unfortunate visual effect that ligatures appear bold in Calibri, etc. Here's a screenshot of gedit which renders for me today like we would do if we enabled ligatures in above code. https://bugzilla.redhat.com/attachment.cgi?id=613610 from https://bugzilla.redhat.com/show_bug.cgi?id=857860 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: A little info about ligatures and e.g. Calibri
On Sun, Feb 03, 2013 at 03:39:36PM +, Caolán McNamara wrote: FWIW, as it came up as a question in the main track FOSDEM LibreOffice talk, in vcl/generic/glyphs/gcach_layout.cxx see IcuLayoutEngine::layout and... if (rArgs.mnFlags SAL_LAYOUT_ENABLE_LIGATURES) nLayoutFlags |= LayoutEngine::kTypoFlagLiga; so ligatures are disabled by default unless SAL_LAYOUT_ENABLE_LIGATURES is enabled, and SAL_LAYOUT_ENABLE_LIGATURES is only set if TEXT_LAYOUT_ENABLE_LIGATURES is set on the outputdevice, and that doesn't happen anywhere as of yet :-( I was wondering about this a while ago, but thought it was just me not finding where the magic is. It would be no major problem to e.g. bubble up allowing those ligatures to be set explicitly via the UI, or e.g. defaulted on via a new compatibility flag for new docs, but the last time I played around with it I ran into the snag that with our current Linux rendering stack via cairo we get the unfortunate visual effect that ligatures appear bold in Calibri, etc. I see Calibri only, no etc's :), so blocking ligature support (which is so 80s, even MS Office now supports OpenType features for Latin) because is of a bug in a single font in certain configurations is overreacting IMHO. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: A little info about ligatures and e.g. Calibri
On Sun, 2013-02-03 at 17:58 +0200, Khaled Hosny wrote: I see Calibri only, no etc's :), so blocking ligature support (which is so 80s, even MS Office now supports OpenType features for Latin) because is of a bug in a single font in certain configurations is overreacting IMHO. *shrug*, its why I wasn't motivated to go and figure out a UI to enable/disable ligatures or see if a compatibility option was a better idea etc because I'd just get a slew of bugs that my text is bold. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: A little info about ligatures and e.g. Calibri
On Sun, Feb 03, 2013 at 04:15:00PM +, Caolán McNamara wrote: On Sun, 2013-02-03 at 17:58 +0200, Khaled Hosny wrote: I see Calibri only, no etc's :), so blocking ligature support (which is so 80s, even MS Office now supports OpenType features for Latin) because is of a bug in a single font in certain configurations is overreacting IMHO. *shrug*, its why I wasn't motivated to go and figure out a UI to enable/disable ligatures or see if a compatibility option was a better idea etc because I'd just get a slew of bugs that my text is bold. GTK have been enabling ligatures and other default OpenType features since ages (since before I started using computers :p), so probably the situation is not that bad. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] 2 commits - tb/tb tb/tb_internals.sh
tb/tb |4 ++-- tb/tb_internals.sh | 16 2 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 1159f7063be1cc5e3d20db65fc9a6e1dbb345718 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sun Feb 3 10:28:25 2013 -0600 tb: --id is implicitely the user used to talk to gerrit diff --git a/tb/tb_internals.sh b/tb/tb_internals.sh index 27ad879..519cb1b 100644 --- a/tb/tb_internals.sh +++ b/tb/tb_internals.sh @@ -993,7 +993,7 @@ local gzlog= log_msgs Report Cancellation for gerrit ref ${GERRIT_TASK_TICKET?} status=canceled fi -cat ${gzlog} | ssh ${TB_GERRIT_HOST?} buildbot put --id ${TB_ID?} --ticket ${GERRIT_TASK_TICKET?} --status $status --log - +cat ${gzlog} | ssh ${TB_GERRIT_HOST?} buildbot put --ticket ${GERRIT_TASK_TICKET?} --status $status --log - } @@ -1311,7 +1311,7 @@ select_next_gerrit_task() GERRIT_TASK_BRANCH= GERRIT_TASK_REF= GERRIT_TASK_FEATURE= -result=$(ssh ${TB_GERRIT_HOST?} buildbot get -p core --id ${TB_ID?} -a ${tb_GERRIT_PLATFORM?} --format BASH ${tb_GERRIT_BRANCHES?}) +result=$(ssh ${TB_GERRIT_HOST?} buildbot get -p core -a ${tb_GERRIT_PLATFORM?} --format BASH ${tb_GERRIT_BRANCHES?}) [ $V ] echo Get task result:${result} has_task=$(echo $result | grep ^GERRIT_TASK_) commit fa33b58aa70e85590f02d02820c3338ebd2e7da5 Author: Norbert Thiebaud nthieb...@gmail.com Date: Sun Jan 27 12:23:08 2013 -0600 tb: cahnge the stop semaphore location to ~/.tb/stop diff --git a/tb/tb b/tb/tb index 69c7f88..683c062 100755 --- a/tb/tb +++ b/tb/tb @@ -238,7 +238,7 @@ case $1 in exit $? ;; stop) -touch ~/.tb/meta/stop +touch ~/.tb/stop exit $? ;; esac @@ -397,7 +397,7 @@ setup_profile_defaults verify_command # remove lingering stop semaphore file -rm -f ~/.tb/meta/stop +rm -f ~/.tb/stop case ${tb_MODE?} in dual) diff --git a/tb/tb_internals.sh b/tb/tb_internals.sh index 861de7a..27ad879 100644 --- a/tb/tb_internals.sh +++ b/tb/tb_internals.sh @@ -609,7 +609,7 @@ interupted_build() fi fi # propagate the stop request to the main loop -touch ${TB_METADATA_DIR?}/stop +touch ${tb_CONFIG_DIR?}/stop exit 4 } @@ -669,7 +669,7 @@ load_profile() fi else if [ -n ${old_ccache_dir} ] ; then -CCACHE=${old_ccache_dir?} +CCACHE_DIR=${old_ccache_dir?} fi fi fi @@ -1093,7 +1093,7 @@ local s=0 while true; do # Check for stop request -if [ -f ${TB_METADATA_DIR?}/stop ] ; then +if [ -f ${tb_CONFIG_DIR?}/stop ] ; then break; else sleep ${s?} @@ -1128,9 +1128,9 @@ local s=0 # if we were stopped by request, let's log that # clean the semaphore file -if [ -f ${TB_METADATA_DIR?}/stop ] ; then +if [ -f ${tb_CONFIG_DIR?}/stop ] ; then log_msgs Stoped by request -rm ${TB_METADATA_DIR?}/stop +rm ${tb_CONFIG_DIR?}/stop fi } @@ -1278,7 +1278,7 @@ run_one_tb() # run_primer() { -check_branch_profiles +check_branches_profile # as a special case the select_next_task # if tb_ONE_SHOT=1 return the first branch ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Bug #47065
Hi! I am interested to try to resolve the bug #47065https://bugs.freedesktop.org/show_bug.cgi?id=47065. It is assigned to Benoit, but I don't see any news since it was assigned. Can I try solve it? If Benoit give us a news, I won't do nothing. Thank you! -- Att. José Guilherme Vanz br.linkedin.com/pub/josé-guilherme-vanz/51/b27/58b/http://br.linkedin.com/pub/jos%C3%A9-guilherme-vanz/51/b27/58b/ http://blog.pt-br.libreoffice.org/ https://groups.google.com/d/forum/openqg ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - wizards/com
wizards/com/sun/star/wizards/agenda/TopicsControl.py | 292 --- wizards/com/sun/star/wizards/fax/CallWizard.py |4 wizards/com/sun/star/wizards/ui/ControlScroller.py | 72 +--- 3 files changed, 168 insertions(+), 200 deletions(-) New commits: commit 8b346fe023b1bc9b85155dfe00a73042945c6067 Author: Xisco Fauli aniste...@gmail.com Date: Sun Feb 3 21:42:06 2013 +0100 pyagenda: use local variables Change-Id: Ie308e7c01103def987272f1df6c691d25ce4a6a8 diff --git a/wizards/com/sun/star/wizards/agenda/TopicsControl.py b/wizards/com/sun/star/wizards/agenda/TopicsControl.py index b8a11e0..e06e13b 100644 --- a/wizards/com/sun/star/wizards/agenda/TopicsControl.py +++ b/wizards/com/sun/star/wizards/agenda/TopicsControl.py @@ -89,7 +89,6 @@ class TopicsControl(ControlScroller): TOPIC = txtTopicTopic_ RESP = cbTopicResp_ TIME = txtTopicTime_ -nscrollvalue = 0 LABEL_PROPS = (PropertyNames.PROPERTY_HEIGHT, PropertyNames.PROPERTY_LABEL, PropertyNames.PROPERTY_POSITION_X, PropertyNames.PROPERTY_POSITION_Y, PropertyNames.PROPERTY_STEP, PropertyNames.PROPERTY_TABINDEX, @@ -98,8 +97,6 @@ class TopicsControl(ControlScroller): PropertyNames.PROPERTY_POSITION_X, PropertyNames.PROPERTY_POSITION_Y, PropertyNames.PROPERTY_STEP, PropertyNames.PROPERTY_TABINDEX, PropertyNames.PROPERTY_WIDTH) -lastFocusRow = 0 -lastFocusControl = None def __init__(self, dialog, xmsf, agenda): try: @@ -107,6 +104,9 @@ class TopicsControl(ControlScroller): dialog, xmsf, 5, 92, 38, 212, 5, 18, HID + 32) self.dialog = dialog self.initializeScrollFields(agenda) +self.nscrollvalue = 0 +self.lastFocusRow = 0 +self.lastFocusControl = None # set some focus listeners for TAB scroll down and up... # prepare scroll down on tab press... self.lastTime = \ @@ -144,34 +144,32 @@ class TopicsControl(ControlScroller): end, which enables the user to enter data... ''' -@classmethod def insertRowAtEnd(self): -l = len(ControlScroller.scrollfields) +l = len(self.scrollfields) self.registerControlGroup(self.newRow(l), l) self.setTotalFieldCount(l + 1) # if the new row is visible, it must have been disabled # so it should be now enabled... -if l - ControlScroller.nscrollvalue self.nblockincrement: -self.ControlGroupVector[l - ControlScroller.nscrollvalue].\ +if l - self.nscrollvalue self.nblockincrement: +self.ControlGroupVector[l - self.nscrollvalue].\ setEnabled(True) ''' remove the last row ''' -@classmethod def removeLastRow(self): -l = len(ControlScroller.scrollfields) +l = len(self.scrollfields) # if we should scroll up... -if (l - ControlScroller.nscrollvalue) = 1 \ -and (l - ControlScroller.nscrollvalue) = self.nblockincrement \ -and ControlScroller.nscrollvalue 0: -while (l - ControlScroller.nscrollvalue = 1) \ -and l - ControlScroller.nscrollvalue = self.nblockincrement \ -and ControlScroller.nscrollvalue 0: -self.setScrollValue(ControlScroller.nscrollvalue - 1) +if (l - self.nscrollvalue) = 1 \ +and (l - self.nscrollvalue) = self.nblockincrement \ +and self.nscrollvalue 0: +while (l - self.nscrollvalue = 1) \ +and l - self.nscrollvalue = self.nblockincrement \ +and self.nscrollvalue 0: +self.setScrollValue(self.nscrollvalue - 1) # if we should disable a row... -elif ControlScroller.nscrollvalue == 0 and l - 1 self.nblockincrement: +elif self.nscrollvalue == 0 and l - 1 self.nblockincrement: self.ControlGroupVector[l - 1].setEnabled(False) self.unregisterControlGroup(l - 1) @@ -184,7 +182,6 @@ class TopicsControl(ControlScroller): @param fe ''' -@classmethod def focusGained(self, fe): xc = fe.Source self.focusGained2(xc) @@ -199,14 +196,13 @@ class TopicsControl(ControlScroller): @param control ''' -@classmethod def focusGained2(self, control): try: #calculate in which row we are... name = control.Model.Name num = name[name.index(_) + 1:] -TopicsControl.lastFocusRow = int(num) + ControlScroller.nscrollvalue -TopicsControl.lastFocusControl = control +self.lastFocusRow = int(num) + self.nscrollvalue +self.lastFocusControl = control # enable/disable the buttons... self.enableButtons() except Exception: @@ -217,25 +213,24 @@ class TopicsControl(ControlScroller): current
[Libreoffice-commits] core.git: wizards/com
wizards/com/sun/star/wizards/fax/CallWizard.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b60af08691215c8603d80f33434cab4dfc1d9e3d Author: Xisco Fauli aniste...@gmail.com Date: Sun Feb 3 21:47:46 2013 +0100 upps, I shouldn't have committed it Change-Id: Id5b17c0fbad9e16277a892b1b89e109ea420c41c diff --git a/wizards/com/sun/star/wizards/fax/CallWizard.py b/wizards/com/sun/star/wizards/fax/CallWizard.py index 9c0205a..b779885 100644 --- a/wizards/com/sun/star/wizards/fax/CallWizard.py +++ b/wizards/com/sun/star/wizards/fax/CallWizard.py @@ -18,7 +18,7 @@ import unohelper import traceback -from ..agenda.AgendaWizardDialogImpl import AgendaWizardDialogImpl +from .FaxWizardDialogImpl import FaxWizardDialogImpl from com.sun.star.task import XJobExecutor @@ -31,7 +31,7 @@ class CallWizard(unohelper.Base, XJobExecutor): def trigger(self, args): try: -fw = AgendaWizardDialogImpl(self.ctx.ServiceManager) +fw = FaxWizardDialogImpl(self.ctx.ServiceManager) fw.startWizard(self.ctx.ServiceManager) except Exception as e: print (Wizard failure exception + str(type(e)) + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] tb/tb_internals.sh
tb/tb_internals.sh |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 21c4db017f59a768ce4982c7dfa4103ec27d41a9 Author: David Ostrovsky da...@ostrovsky.org Date: Sun Feb 3 21:55:25 2013 +0100 adjust platform names: Linux, MacOSX and Windows diff --git a/tb/tb_internals.sh b/tb/tb_internals.sh index 519cb1b..fc8c9c7 100644 --- a/tb/tb_internals.sh +++ b/tb/tb_internals.sh @@ -1485,13 +1485,13 @@ setup_profile_defaults() os=$(uname) case $os in *Linux*) -tb_GERRIT_PLATFORM=LINUX +tb_GERRIT_PLATFORM=Linux ;; Darwin) -tb_GERRIT_PLATFORM=MAC +tb_GERRIT_PLATFORM=MacOSX ;; CYGWIN*) -tb_GERRIT_PLATFORM=WINDOWS +tb_GERRIT_PLATFORM=Windows ;; esac fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |1 + 1 file changed, 1 insertion(+) New commits: commit e1347c650e4d1d11f37be3121189e0fdeb1f1290 Author: Tor Lillqvist t...@iki.fi Date: Sun Feb 3 23:02:04 2013 +0200 Copy also lo.xcent.in to CONF-FOR-BUILD Change-Id: I77b3e7afdcb034f48acbedfdc7b7372ee81f958a diff --git a/configure.ac b/configure.ac index d5d6857..fd8f10b 100644 --- a/configure.ac +++ b/configure.ac @@ -4182,6 +4182,7 @@ if test $cross_compiling = yes; then config_host.mk.in \ configure \ Makefile.in \ +lo.xcent.in \ config_host/config_*.h.in \ bin/get_config_variables \ solenv/bin/getcompver.awk \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cppuhelper/source registry/tools
cppuhelper/source/typedescriptionprovider.cxx |6 +++--- registry/tools/reg2bin.cxx|2 +- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 7b235eec105c963173282e1e3f392c64b069902b Author: Stephan Bergmann sberg...@redhat.com Date: Sun Feb 3 23:07:30 2013 +0100 More typos Change-Id: I7b1bd08d9e5157c4eacb8ee5005c76e93eb32e63 diff --git a/cppuhelper/source/typedescriptionprovider.cxx b/cppuhelper/source/typedescriptionprovider.cxx index b45cb39..2d19518 100644 --- a/cppuhelper/source/typedescriptionprovider.cxx +++ b/cppuhelper/source/typedescriptionprovider.cxx @@ -1025,7 +1025,7 @@ struct Attribute { rtl::OUString type; bool bound; bool readOnly; -std::vector rtl::OUString getExceptions; +std::vector rtl::OUString getExceptions; std::vector rtl::OUString setExceptions; }; @@ -2501,7 +2501,7 @@ css::uno::Any Provider::getByHierarchicalName(rtl::OUString const aName) for (sal_uInt32 i = 0; i != n; ++i) { params.push_back(file_-readNameLen(off, off)); } -n = file_-read32(off + 1); +n = file_-read32(off); if (n SAL_MAX_INT32) { throw css::uno::DeploymentException( (broken UNOIDL file: too many members of polymorphic @@ -2628,7 +2628,7 @@ css::uno::Any Provider::getByHierarchicalName(rtl::OUString const aName) getExcs.push_back(file_-readNameLen(off, off)); } std::vector rtl::OUString setExcs; -if ((v 0x02) != 0) { +if ((v 0x02) == 0) { m = file_-read32(off); if (m SAL_MAX_INT32) { throw css::uno::DeploymentException( diff --git a/registry/tools/reg2bin.cxx b/registry/tools/reg2bin.cxx index d10ad2a..b45580947 100644 --- a/registry/tools/reg2bin.cxx +++ b/registry/tools/reg2bin.cxx @@ -1092,7 +1092,7 @@ sal_uInt64 writeMap( if (j-bound) { f |= 0x01; } -if (!j-readOnly) { +if (j-readOnly) { f |= 0x02; } write8(file, f); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH libreoffice-4-0] implement spread button layout
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1973 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/1973/1 implement spread button layout Change-Id: Ia17d3f4d14319adec6b0b20dced5daf5b8018c36 (cherry picked from commit 5dc0c03f797e53aef7411c26782b6d39b7e93d0c) Resolves: fdo#59767 detect outlier widths and exclude from size normalization For non-homogeneous (the default) button boxes we want in general to give all buttons the same width as the max button width. But if we detect that certain buttons are 1.5 the average button width, then leave those outliers at their natural size and set the rest of the buttons to the max width of the remainder. (cherry picked from commit 6e81082dbb2d16f0e61527c5ad13f91d49828125) Conflicts: vcl/source/window/layout.cxx Change-Id: Ice514e741e3a7725d69e150e5752158a1c267141 --- M vcl/inc/vcl/layout.hxx M vcl/source/window/layout.cxx 2 files changed, 155 insertions(+), 54 deletions(-) diff --git a/vcl/inc/vcl/layout.hxx b/vcl/inc/vcl/layout.hxx index d9c5e63..3caae71 100644 --- a/vcl/inc/vcl/layout.hxx +++ b/vcl/inc/vcl/layout.hxx @@ -201,9 +201,8 @@ { public: VclButtonBox(Window *pParent, int nSpacing) -: VclBox(pParent, true, nSpacing) +: VclBox(pParent, false, nSpacing) , m_eLayoutStyle(VCL_BUTTONBOX_DEFAULT_STYLE) -, m_bHomogeneousGroups(false) { } void set_layout(VclButtonBoxStyle eStyle) @@ -218,20 +217,15 @@ protected: virtual Size calculateRequisition() const; virtual void setAllocation(const Size rAllocation); +Size addSpacing(const Size rSize, sal_uInt16 nVisibleChildren) const; private: VclButtonBoxStyle m_eLayoutStyle; -bool m_bHomogeneousGroups; struct Requisition { -sal_uInt16 m_nMainGroupChildren; -sal_uInt16 m_nSubGroupChildren; +std::vectorlong m_aMainGroupDimensions; +std::vectorlong m_aSubGroupDimensions; Size m_aMainGroupSize; Size m_aSubGroupSize; -Requisition() -: m_nMainGroupChildren(0) -, m_nSubGroupChildren(0) -{ -} }; Requisition calculatePrimarySecondaryRequisitions() const; Size addReqGroups(const VclButtonBox::Requisition rReq) const; diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx index 91017d5..ad19914 100644 --- a/vcl/source/window/layout.cxx +++ b/vcl/source/window/layout.cxx @@ -324,23 +324,47 @@ long nMainGroupDimension = getPrimaryDimension(rReq.m_aMainGroupSize); long nSubGroupDimension = getPrimaryDimension(rReq.m_aSubGroupSize); -assert(m_bHomogeneous); - -if (m_bHomogeneousGroups) -setPrimaryDimension(aRet, std::max(nMainGroupDimension, nSubGroupDimension)); -else -{ -setPrimaryDimension(aRet, -(rReq.m_nMainGroupChildren * nMainGroupDimension -+ rReq.m_nSubGroupChildren * nSubGroupDimension) / -(rReq.m_nMainGroupChildren + rReq.m_nSubGroupChildren)); -} +setPrimaryDimension(aRet, nMainGroupDimension + nSubGroupDimension); setSecondaryDimension(aRet, std::max(getSecondaryDimension(rReq.m_aMainGroupSize), getSecondaryDimension(rReq.m_aSubGroupSize))); return aRet; +} + +static long getMaxNonOutlier(const std::vectorlong rG, long nAvgDimension) +{ +long nMaxDimensionNonOutlier = 0; +for (std::vectorlong::const_iterator aI = rG.begin(), +aEnd = rG.end(); aI != aEnd; ++aI) +{ +long nPrimaryChildDimension = *aI; +if (nPrimaryChildDimension = nAvgDimension * 1.5) +{ +nMaxDimensionNonOutlier = std::max(nPrimaryChildDimension, +nMaxDimensionNonOutlier); +} +} +return nMaxDimensionNonOutlier; +} + +static std::vectorlong setButtonSizes(const std::vectorlong rG, +long nAvgDimension, long nMaxNonOutlier) +{ +std::vectorlong aVec; +//set everything 1.5 times the average to the same width, leave the +//outliers un-touched +for (std::vectorlong::const_iterator aI = rG.begin(), aEnd = rG.end(); +aI != aEnd; ++aI) +{ +long nPrimaryChildDimension = *aI; +if (nPrimaryChildDimension = nAvgDimension * 1.5) +aVec.push_back(nMaxNonOutlier); +else +aVec.push_back(nPrimaryChildDimension); +} +return aVec; } VclButtonBox::Requisition VclButtonBox::calculatePrimarySecondaryRequisitions() const @@ -350,36 +374,110 @@ Size aMainGroupSize(DEFAULT_CHILD_MIN_WIDTH, DEFAULT_CHILD_MIN_HEIGHT); //to-do, pull from theme Size aSubGroupSize(DEFAULT_CHILD_MIN_WIDTH, DEFAULT_CHILD_MIN_HEIGHT); //to-do, pull from theme +long nMinMainGroupPrimary = getPrimaryDimension(aMainGroupSize); +long nMinSubGroupPrimary = getPrimaryDimension(aSubGroupSize); +long nMainGroupSecondary = getSecondaryDimension(aMainGroupSize); +long
[PATCH libreoffice-4-0] fdo#59419 fix RTF import of hex form of \r and \n
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1974 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/74/1974/1 fdo#59419 fix RTF import of hex form of \r and \n (cherry picked from commits a5e885df24eb11c028a94ac709966b3ce2976db9 and 927de8786850936bb42c5595c41a4353c076fdea) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: Ic700cdc67f756cafc454c326b73f680a8a47a6e8 --- M writerfilter/source/rtftok/rtfdocumentimpl.cxx 1 file changed, 8 insertions(+), 0 deletions(-) diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index c961c7d..37d0376 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -944,6 +944,14 @@ void RTFDocumentImpl::text(OUString rString) { +if (rString.getLength() == 1 m_aStates.top().nDestinationState != DESTINATION_DOCCOMM) +{ +// No cheating! Tokenizer ignores bare \r and \n, their hex \'0d / \'0a form doesn't count, either. +sal_Unicode ch = rString.getStr()[0]; +if (ch == 0x0d || ch == 0x0a) +return; +} + bool bRet = true; switch (m_aStates.top().nDestinationState) { -- To view, visit https://gerrit.libreoffice.org/1974 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic700cdc67f756cafc454c326b73f680a8a47a6e8 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: libreoffice-4-0 Gerrit-Owner: Miklos Vajna vmik...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Remove specific socket code for Linux
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1975 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/75/1975/1 Remove specific socket code for Linux Change-Id: I8b51f7027a6c55544ebbbcc9c76bea0913856cc6 --- M sal/osl/unx/pipe.c M sal/osl/unx/socket.c M sal/osl/unx/sockimpl.h 3 files changed, 0 insertions(+), 134 deletions(-) diff --git a/sal/osl/unx/pipe.c b/sal/osl/unx/pipe.c index f0720ec..a61a022 100644 --- a/sal/osl/unx/pipe.c +++ b/sal/osl/unx/pipe.c @@ -109,10 +109,6 @@ pPipeImpl = (oslPipe)calloc(1, sizeof(struct oslPipeImpl)); pPipeImpl-m_nRefCount =1; pPipeImpl-m_bClosed = sal_False; -#if defined(LINUX) -pPipeImpl-m_bIsInShutdown = sal_False; -pPipeImpl-m_bIsAccepting = sal_False; -#endif return pPipeImpl; } @@ -366,11 +362,6 @@ void SAL_CALL osl_closePipe( oslPipe pPipe ) { int nRet; -#if defined(LINUX) -size_t len; -struct sockaddr_un addr; -int fd; -#endif int ConnFD; if( ! pPipe ) @@ -384,34 +375,6 @@ } ConnFD = pPipe-m_Socket; - -/* - Thread does not return from accept on linux, so - connect to the accepting pipe - */ -#if defined(LINUX) -if ( pPipe-m_bIsAccepting ) -{ -pPipe-m_bIsInShutdown = sal_True; -pPipe-m_Socket = -1; -fd = socket(AF_UNIX, SOCK_STREAM, 0); -memset(addr, 0, sizeof(addr)); - -OSL_TRACE(osl_destroyPipe : Pipe Name '%s',pPipe-m_Name); - -addr.sun_family = AF_UNIX; -strncpy(addr.sun_path, pPipe-m_Name, sizeof(addr.sun_path) - 1); -len = sizeof(addr); - -nRet = connect( fd, (struct sockaddr *)addr, len); -if ( nRet 0 ) -{ -OSL_TRACE(connect in osl_destroyPipe failed with error: %s, strerror(errno)); -} -close(fd); -} -#endif /* LINUX */ - nRet = shutdown(ConnFD, 2); if ( nRet 0 ) @@ -451,15 +414,8 @@ OSL_ASSERT(strlen(pPipe-m_Name) 0); -#if defined(LINUX) -pPipe-m_bIsAccepting = sal_True; -#endif - s = accept(pPipe-m_Socket, NULL, NULL); -#if defined(LINUX) -pPipe-m_bIsAccepting = sal_False; -#endif if (s 0) { @@ -467,13 +423,6 @@ return NULL; } -#if defined(LINUX) -if ( pPipe-m_bIsInShutdown ) -{ -close(s); -return NULL; -} -#endif /* LINUX */ else { /* alloc memory */ diff --git a/sal/osl/unx/socket.c b/sal/osl/unx/socket.c index a9f3fc0..9e75710 100644 --- a/sal/osl/unx/socket.c +++ b/sal/osl/unx/socket.c @@ -471,10 +471,6 @@ pSocket-m_nLastError = 0; pSocket-m_nRefCount = 1; -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_False; -#endif - #if OSL_DEBUG_LEVEL 1 g_nSocketImpl ++; #endif @@ -1478,13 +1474,6 @@ { if( pSocket 0 == osl_atomic_decrement( (pSocket-m_nRefCount) ) ) { -#if defined(LINUX) -if ( pSocket-m_bIsAccepting == sal_True ) -{ -OSL_FAIL(osl_destroySocket : attempt to destroy socket while accepting\n); -return; -} -#endif /* LINUX */ osl_closeSocket( pSocket ); __osl_destroySocketImpl( pSocket ); } @@ -1511,48 +1500,6 @@ return; pSocket-m_Socket = OSL_INVALID_SOCKET; - -#if defined(LINUX) -pSocket-m_bIsInShutdown = sal_True; - -if ( pSocket-m_bIsAccepting == sal_True ) -{ -int nConnFD; -union { -struct sockaddr aSockAddr; -struct sockaddr_in aSockAddrIn; -} s; -socklen_t nSockLen = sizeof(s.aSockAddr); - -nRet = getsockname(nFD, s.aSockAddr, nSockLen); -if ( nRet 0 ) -{ -OSL_TRACE(getsockname call failed with error: %s, strerror(errno)); -} - -if ( s.aSockAddr.sa_family == AF_INET ) -{ -if ( s.aSockAddrIn.sin_addr.s_addr == htonl(INADDR_ANY) ) -{ -s.aSockAddrIn.sin_addr.s_addr = htonl(INADDR_LOOPBACK); -} - -nConnFD = socket(AF_INET, SOCK_STREAM, 0); -if ( nConnFD 0 ) -{ -OSL_TRACE(socket call failed with error: %s, strerror(errno)); -} - -nRet = connect(nConnFD, s.aSockAddr, sizeof(s.aSockAddr)); -if ( nRet 0 ) -{ -OSL_TRACE(connect call failed with error: %s, strerror(errno)); -} -close(nConnFD); -} -pSocket-m_bIsAccepting = sal_False; -} -#endif /* LINUX */ nRet=close(nFD); if ( nRet != 0 ) @@ -1827,9 +1774,6 @@ } pSocket-m_nLastError=0; -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_True; -#endif /* LINUX */ if( ppAddr *ppAddr ) { @@ -1850,24 +1794,10 @@ pSocket-m_nLastError=errno; OSL_TRACE(osl_acceptConnectionOnSocket : accept error '%s',strerror(errno)); -#if defined(LINUX) -pSocket-m_bIsAccepting = sal_False; -#endif /*
[PATCH] Drag main window by using the menubar on Gtk
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1976 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/76/1976/1 Drag main window by using the menubar on Gtk Change-Id: I04a5864120f44cf987312bb41b9cbb1f9c71b248 --- M vcl/headless/svpframe.cxx M vcl/inc/headless/svpframe.hxx M vcl/inc/salframe.hxx M vcl/inc/unx/gtk/gtkframe.hxx M vcl/inc/unx/salframe.h M vcl/inc/vcl/window.hxx M vcl/inc/win/salframe.h M vcl/source/window/menu.cxx M vcl/source/window/window.cxx M vcl/unx/generic/window/salframe.cxx M vcl/unx/gtk/window/gtkframe.cxx M vcl/unx/kde4/KDESalFrame.cxx M vcl/unx/kde4/KDESalFrame.hxx M vcl/win/source/window/salframe.cxx 14 files changed, 67 insertions(+), 3 deletions(-) diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx index 0d4e466..c9dc95c 100644 --- a/vcl/headless/svpframe.cxx +++ b/vcl/headless/svpframe.cxx @@ -470,4 +470,8 @@ { } +void SvpSalFrame::StartDragFrame (long /*x*/, long /*y*/, sal_uInt16 /*button*/, sal_uLong /*nTime*/) +{ +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/vcl/inc/headless/svpframe.hxx b/vcl/inc/headless/svpframe.hxx index c48d602..c96116c 100644 --- a/vcl/inc/headless/svpframe.hxx +++ b/vcl/inc/headless/svpframe.hxx @@ -127,7 +127,7 @@ bool IsVisible() { return m_bVisible; } static SvpSalFrame* GetFocusFrame() { return s_pFocusFrame; } - +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; }; #endif // _SVP_SVPFRAME_HXX diff --git a/vcl/inc/salframe.hxx b/vcl/inc/salframe.hxx index 63096e0..fbbd9a2 100644 --- a/vcl/inc/salframe.hxx +++ b/vcl/inc/salframe.hxx @@ -22,6 +22,7 @@ #include tools/solar.h #include vcl/dllapi.h +#include vcl/event.hxx #ifdef __cplusplus @@ -248,6 +249,9 @@ // done setting up the clipregion virtual voidEndSetClipRegion() = 0; +// start dragging the frame on the desktop +virtual void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) = 0; + // Callbacks (indepent part in vcl/source/window/winproc.cxx) // for default message handling return 0 voidSetCallback( Window* pWindow, SALFRAMEPROC pProc ) diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index a33a558..8f454df 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -328,6 +328,7 @@ SalX11Screen getXScreenNumber() const { return m_nXScreen; } int GetDisplayScreen() const { return maGeometry.nDisplayScreenNumber; } void updateScreenNumber(); +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime); #if GTK_CHECK_VERSION(3,0,0) // only for gtk3 ... diff --git a/vcl/inc/unx/salframe.h b/vcl/inc/unx/salframe.h index c6a8cc3..541d75e 100644 --- a/vcl/inc/unx/salframe.h +++ b/vcl/inc/unx/salframe.h @@ -251,6 +251,8 @@ virtual voidSetScreenNumber( unsigned int ); virtual voidSetApplicationID( const rtl::OUString rWMClass ); +void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; + // shaped system windows // set clip region to none (- rectangular windows, normal state) virtual voidResetClipRegion(); @@ -265,6 +267,7 @@ /// @internal void setPendingSizeEvent(); + }; #ifdef _SV_SALDISP_HXX diff --git a/vcl/inc/vcl/window.hxx b/vcl/inc/vcl/window.hxx index ccd599a..811a8ee 100644 --- a/vcl/inc/vcl/window.hxx +++ b/vcl/inc/vcl/window.hxx @@ -980,6 +980,8 @@ voidStartAutoScroll( sal_uInt16 nFlags ); voidEndAutoScroll(); +voidStartDragWindow( const MouseEvent rMouseEvent ); + sal_BoolHandleScrollCommand( const CommandEvent rCmd, ScrollBar* pHScrl = NULL, ScrollBar* pVScrl = NULL ); diff --git a/vcl/inc/win/salframe.h b/vcl/inc/win/salframe.h index 54e10bd..d48563d 100644 --- a/vcl/inc/win/salframe.h +++ b/vcl/inc/win/salframe.h @@ -133,6 +133,7 @@ virtual voidBeginSetClipRegion( sal_uIntPtr nRects ); virtual voidUnionClipRegion( long nX, long nY, long nWidth, long nHeight ); virtual voidEndSetClipRegion(); +virtual void StartDragFrame (long x, long y, sal_uInt16 button, sal_uLong nTime) ; }; void ImplSalGetWorkArea( HWND hWnd, RECT *pRect, const RECT *pParentRect ); diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index a163041..1a4c45e 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -5395,11 +5395,15 @@ { ChangeHighlightItem( nEntry, sal_False ); } -else +else if (pActivePopup) { KillActivePopup(); ChangeHighlightItem( ITEMPOS_INVALID, sal_False ); } +
[PATCH] String cleanup in oox
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1977 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/77/1977/1 String cleanup in oox Change-Id: Ica69f655f3777fe37a51e313218ae12aa7d012a2 Signed-off-by: José Guilherme Vanz guilherme@gmail.com --- M oox/source/ppt/extdrawingfragmenthandler.hxx M oox/source/ppt/pptfilterhelpers.hxx M oox/source/shape/ShapeContextHandler.cxx M oox/source/shape/ShapeContextHandler.hxx M oox/source/shape/ShapeDrawingFragmentHandler.cxx M oox/source/shape/ShapeDrawingFragmentHandler.hxx M oox/source/shape/ShapeFilterBase.cxx M oox/source/shape/ShapeFilterBase.hxx M oox/source/token/namespacemap.cxx M oox/source/token/propertynames.cxx M oox/source/token/tokenmap.cxx M oox/source/vml/vmldrawing.cxx M oox/source/vml/vmldrawingfragment.cxx M oox/source/vml/vmlformatting.cxx M oox/source/vml/vmlinputstream.cxx M oox/source/vml/vmlshape.cxx M oox/source/vml/vmlshapecontainer.cxx M oox/source/vml/vmlshapecontext.cxx M oox/source/vml/vmltextbox.cxx M oox/source/vml/vmltextboxcontext.cxx 20 files changed, 47 insertions(+), 67 deletions(-) diff --git a/oox/source/ppt/extdrawingfragmenthandler.hxx b/oox/source/ppt/extdrawingfragmenthandler.hxx index 3751e4d..9236f93 100644 --- a/oox/source/ppt/extdrawingfragmenthandler.hxx +++ b/oox/source/ppt/extdrawingfragmenthandler.hxx @@ -43,7 +43,7 @@ class ExtDrawingFragmentHandler : public ::oox::core::FragmentHandler { public: -ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const ::rtl::OUString rFragmentPath, +ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const OUString rFragmentPath, const oox::ppt::SlidePersistPtr pSlidePersistPtr, const oox::ppt::ShapeLocation eShapeLocation, oox::drawingml::ShapePtr pMasterShapePtr, diff --git a/oox/source/ppt/pptfilterhelpers.hxx b/oox/source/ppt/pptfilterhelpers.hxx index 3924b2d..67efbbf 100644 --- a/oox/source/ppt/pptfilterhelpers.hxx +++ b/oox/source/ppt/pptfilterhelpers.hxx @@ -86,7 +86,7 @@ // BEGIN CUTPASTE from sd pptinanimation.cxx -bool convertMeasure( ::rtl::OUString rString ); +bool convertMeasure( OUString rString ); // END CUTPASTE from sd pptinanimation.cxx diff --git a/oox/source/shape/ShapeContextHandler.cxx b/oox/source/shape/ShapeContextHandler.cxx index 11bab21..6b62396 100644 --- a/oox/source/shape/ShapeContextHandler.cxx +++ b/oox/source/shape/ShapeContextHandler.cxx @@ -31,15 +31,15 @@ using namespace core; using namespace drawingml; -::rtl::OUString SAL_CALL ShapeContextHandler_getImplementationName() +OUString SAL_CALL ShapeContextHandler_getImplementationName() { return OUString( com.sun.star.comp.oox.ShapeContextHandler ); } -uno::Sequence ::rtl::OUString SAL_CALL +uno::Sequence OUString SAL_CALL ShapeContextHandler_getSupportedServiceNames() { -uno::Sequence ::rtl::OUString s(1); +uno::Sequence OUString s(1); s[0] = com.sun.star.xml.sax.FastShapeContextHandler; return s; } @@ -154,8 +154,8 @@ const uno::Reference xml::sax::XFastAttributeList Attribs) throw (uno::RuntimeException, xml::sax::SAXException) { -static const ::rtl::OUString sInputStream -(RTL_CONSTASCII_USTRINGPARAM (InputStream)); +static const OUString sInputStream +(InputStream); uno::Sequencebeans::PropertyValue aSeq(1); aSeq[0].Name = sInputStream; @@ -170,7 +170,7 @@ if (!msRelationFragmentPath.isEmpty()) { FragmentHandlerRef rFragmentHandler(new ShapeFragmentHandler(*mxFilterBase, msRelationFragmentPath)); -rtl::OUString aThemeFragmentPath = rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE( theme ) ); +OUString aThemeFragmentPath = rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE( theme ) ); uno::Referencexml::sax::XFastSAXSerializable xDoc(mxFilterBase-importFragment(aThemeFragmentPath), uno::UNO_QUERY_THROW); mxFilterBase-importFragment(new ThemeFragmentHandler(*mxFilterBase, aThemeFragmentPath, *mpThemePtr ), xDoc); ShapeFilterBase* pShapeFilterBase(dynamic_castShapeFilterBase*(mxFilterBase.get())); @@ -193,7 +193,7 @@ } void SAL_CALL ShapeContextHandler::startUnknownElement -(const ::rtl::OUString Namespace, const ::rtl::OUString Name, +(const OUString Namespace, const OUString Name, const uno::Reference xml::sax::XFastAttributeList Attribs) throw (uno::RuntimeException, xml::sax::SAXException) { @@ -216,8 +216,8 @@ } void SAL_CALL ShapeContextHandler::endUnknownElement -(const ::rtl::OUString Namespace, - const ::rtl::OUString Name) +(const OUString Namespace, + const OUString Name) throw (uno::RuntimeException, xml::sax::SAXException) { uno::ReferenceXFastContextHandler xContextHandler(getContextHandler()); @@ -244,8 +244,8 @@ uno::Reference
[Libreoffice-commits] core.git: Branch 'feature/bplustree' - 2 commits - sw/inc
sw/inc/densebplustree.cxx | 121 -- sw/inc/densebplustree.hxx |7 ++ 2 files changed, 124 insertions(+), 4 deletions(-) New commits: commit 971cd290e50ed411e699a97c06ebb5407a7e27f2 Author: Jan Holesovsky ke...@suse.cz Date: Mon Feb 4 00:10:01 2013 +0100 Dense B+ tree: Implement Remove(). So far this is missing the implementation of joining nodes that are not enough filled (contain less than sMinFill values or children). Change-Id: I0cb855dc7b1fcbcc3d0145e7612a04956df8298e diff --git a/sw/inc/densebplustree.cxx b/sw/inc/densebplustree.cxx index 825ae52..68af75d 100644 --- a/sw/inc/densebplustree.cxx +++ b/sw/inc/densebplustree.cxx @@ -27,6 +27,12 @@ between fragmentation (too low value) and not being too flat (too high value). */ static const int sOrder = 50; +/** Minimum fill of a node. + +Nodes except the rightmost ones will never have less than this number. +*/ +static const int sMinFill = ( sOrder / 2 ) - 1; + /** B+ tree node implementation. It has to be able to act as an internal node, as well as the leaf node. @@ -103,6 +109,30 @@ struct DBPTreeNode ++m_nUsed; } +/// Remove the given amount of content (regardless of the node type). +void remove( int nWhere, int nCount ) +{ +assert( nWhere m_nUsed ); +assert( nCount 0 ); +assert( nWhere + nCount = m_nUsed ); + +if ( m_bIsInternal ) +{ +for ( int i = nWhere; i m_nUsed - nCount; ++i ) +m_pChildren[ i ] = m_pChildren[ i + nCount ]; + +for ( int i = nWhere - 1; i m_nUsed - nCount - 1; ++i ) +m_pKeys[ i ] = m_pKeys[ i + nCount ]; +} +else +{ +for ( int i = nWhere; i m_nUsed - nCount; ++i ) +m_pValues[ i ] = m_pValues[ i + nCount ]; +} + +m_nUsed -= nCount; +} + /** Split node, and make the original one smaller. @return relative key shift of the node. @@ -158,6 +188,7 @@ DenseBPlusTree Key, Value ::DenseBPlusTree() m_nCount( 0 ), m_nDepth( 1 ) { +assert( sMinFill 0 ); // just to be sure ;-) } template class Key, class Value @@ -206,7 +237,45 @@ void DenseBPlusTree Key, Value ::Insert( const Value rValue, Key nPos ) template class Key, class Value void DenseBPlusTree Key, Value ::Remove( Key nPos, Key nNumber ) { -// TODO +assert( nNumber 0 ); +assert( nPos + nNumber = m_nCount ); + +NodeWithIndex pParents[ m_nDepth ]; +int nParentsLength = 0; +NodeWithIndex aLeaf = findLeaf( nPos, pParents, nParentsLength ); + +if ( aLeaf.pNode-m_nUsed - nNumber = sMinFill ) +{ +aLeaf.pNode-remove( aLeaf.nIndex, nNumber ); +shiftNodes( pParents, nParentsLength, -nNumber ); +} +else +{ +// let's find the first node that we are not removing, and use the +// m_pNext chains to delete everything in between on every level +NodeWithIndex pAfterParents[ m_nDepth ]; +int nAfterParentsLength = 0; +NodeWithIndex aAfter = findLeaf( nPos + nNumber, pAfterParents, nAfterParentsLength ); + +// we do the operation the same way on every level, regardless it is a +// leaf, or an internal node +pParents[ nParentsLength ] = aLeaf; +pAfterParents[ nAfterParentsLength ] = aAfter; + +// remove it +assert( nParentsLength == nAfterParentsLength ); +removeBetween( pParents, pAfterParents, nParentsLength + 1 ); + +// update indexes +shiftNodes( pParents, nParentsLength, aAfter.nIndex - nNumber ); +if ( pParents[ nParentsLength - 1 ].nIndex pParents[ nParentsLength - 1 ].pNode-m_nUsed - 1 ) +++pParents[ nParentsLength - 1 ].nIndex; +shiftNodes( pParents, nParentsLength, -aAfter.nIndex ); + +// FIXME now make sure every node contains at least sMinFill data +} + +m_nCount -= nNumber; } template class Key, class Value @@ -220,7 +289,7 @@ void DenseBPlusTree Key, Value ::Replace( Key nPos, const Value rValue ) { assert( m_pRoot-m_nUsed 0 ); -NodeWithIndex aLeaf = findLeaf( nPos, NULL ); +NodeWithIndex aLeaf = findLeaf( nPos ); aLeaf.pNode-m_pValues[ aLeaf.nIndex ] = rValue; } @@ -230,7 +299,7 @@ const Value DenseBPlusTree Key, Value ::operator[]( Key nPos ) const { assert( m_pRoot-m_nUsed 0 ); -NodeWithIndex aLeaf = findLeaf( nPos, NULL ); +NodeWithIndex aLeaf = findLeaf( nPos ); return aLeaf.pNode-m_pValues[ aLeaf.nIndex ]; } @@ -396,4 +465,48 @@ DBPTreeNode Key, Value * DenseBPlusTree Key, Value ::splitNode( DBPTreeNode return pNewNode; } +template class Key, class Value +void DenseBPlusTree Key, Value ::removeBetween( const NodeWithIndex pFrom[], const NodeWithIndex pTo[], int nLength ) +{ +for ( int p = 0; p nLength; ++p ) +{ +const NodeWithIndex rLeaf = pFrom[ p ];
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - writerfilter/source
writerfilter/source/rtftok/rtfdocumentimpl.cxx |8 1 file changed, 8 insertions(+) New commits: commit 285c71000aece675f982e8c637f202e606522daf Author: Miklos Vajna vmik...@suse.cz Date: Sun Feb 3 14:37:38 2013 +0100 fdo#59419 fix RTF import of hex form of \r and \n (cherry picked from commits a5e885df24eb11c028a94ac709966b3ce2976db9 and 927de8786850936bb42c5595c41a4353c076fdea) Conflicts: sw/qa/extras/rtfimport/rtfimport.cxx Change-Id: Ic700cdc67f756cafc454c326b73f680a8a47a6e8 Reviewed-on: https://gerrit.libreoffice.org/1974 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index c961c7d..37d0376 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -944,6 +944,14 @@ void RTFDocumentImpl::singleChar(sal_uInt8 nValue, bool bRunProps) void RTFDocumentImpl::text(OUString rString) { +if (rString.getLength() == 1 m_aStates.top().nDestinationState != DESTINATION_DOCCOMM) +{ +// No cheating! Tokenizer ignores bare \r and \n, their hex \'0d / \'0a form doesn't count, either. +sal_Unicode ch = rString.getStr()[0]; +if (ch == 0x0d || ch == 0x0a) +return; +} + bool bRet = true; switch (m_aStates.top().nDestinationState) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/toolpanel/LayoutMenu.cxx | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) New commits: commit 35a45a4508ca4156ebaa4f17df776a971084160d Author: Faisal M. Al-Otaibi fmalota...@kacst.edu.sa Date: Sun Feb 3 08:17:01 2013 +0300 fdo#60213- fix the right-click misbehavior Change-Id: Iea44c9e70efeb84482aefc70b311f1781241b030 Reviewed-on: https://gerrit.libreoffice.org/1971 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/sd/source/ui/toolpanel/LayoutMenu.cxx b/sd/source/ui/toolpanel/LayoutMenu.cxx index b602b2f..24bcdc1 100644 --- a/sd/source/ui/toolpanel/LayoutMenu.cxx +++ b/sd/source/ui/toolpanel/LayoutMenu.cxx @@ -857,13 +857,15 @@ void LayoutMenu::Command (const CommandEvent rEvent) { if (GetShellManager() != NULL) GetShellManager()-MoveToTop(this); +Point aPosition (0,0); if (rEvent.IsMouseEvent()) { // Do not show the context menu when the mouse was not // pressed over an item. +// We have to explicitly specify the location of the menu +// when the LayoutMenu is undocked if (GetItemId(rEvent.GetMousePosPixel()) 0) -mrBase.GetViewFrame()-GetDispatcher()-ExecutePopup( -SdResId(RID_TASKPANE_LAYOUTMENU_POPUP)); +aPosition = rEvent.GetMousePosPixel(); } else { @@ -873,13 +875,13 @@ void LayoutMenu::Command (const CommandEvent rEvent) if (GetSelectItemId() != (sal_uInt16)-1) { Rectangle aBBox (GetItemRect(GetSelectItemId())); -Point aPosition (aBBox.Center()); -mrBase.GetViewFrame()-GetDispatcher()-ExecutePopup( +aPosition = aBBox.Center(); +} +} +mrBase.GetViewFrame()-GetDispatcher()-ExecutePopup( SdResId(RID_TASKPANE_LAYOUTMENU_POPUP), this, aPosition); -} -} } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - extensions/Library_ldapbe2.mk svtools/source
extensions/Library_ldapbe2.mk | 13 +++-- svtools/source/contnr/svimpbox.cxx | 12 2 files changed, 15 insertions(+), 10 deletions(-) New commits: commit 423079fd4db3163f66ab38d053f60eeec1afc2e7 Author: David Tardon dtar...@redhat.com Date: Mon Feb 4 08:09:16 2013 +0100 fdo#60115 build of ldapbe2 breaks if nss is in nonstd. location Change-Id: I32a0495edffbe13734457c230a3a1735aa254198 diff --git a/extensions/Library_ldapbe2.mk b/extensions/Library_ldapbe2.mk index f0c053d..3e6d6b4 100644 --- a/extensions/Library_ldapbe2.mk +++ b/extensions/Library_ldapbe2.mk @@ -58,16 +58,9 @@ $(eval $(call gb_Library_use_system_win32_libs,ldapbe2,\ wldap32 \ )) else # 0S!=WNT -$(eval $(call gb_Library_use_externals,ldapbe2,openldap)) - -$(eval $(call gb_Library_add_libs,ldapbe2,\ - -lssl3 \ - -lsmime3 \ - -lnss3 \ - -lnssutil3 \ - -lplds4 \ - -lplc4 \ - -lnspr4 \ +$(eval $(call gb_Library_use_externals,ldapbe2,\ + nss3 \ + openldap \ )) endif commit adec665d2ca5265f8cad5fcd0063678909b160c9 Author: David Tardon dtar...@redhat.com Date: Fri Jan 25 11:57:01 2013 +0100 rhbz#903615 avoid null ptr dereference Change-Id: I336e3fffaaa42605b5fab2821c85c473635fbf27 diff --git a/svtools/source/contnr/svimpbox.cxx b/svtools/source/contnr/svimpbox.cxx index 6e60207..5d4dd02 100644 --- a/svtools/source/contnr/svimpbox.cxx +++ b/svtools/source/contnr/svimpbox.cxx @@ -348,6 +348,9 @@ IMPL_LINK( SvImpLBox, ScrollUpDownHdl, ScrollBar *, pScrollBar ) void SvImpLBox::CursorDown() { +if (!pStartEntry) +return; + SvTreeListEntry* pNextFirstToDraw = pView-NextVisible(pStartEntry); if( pNextFirstToDraw ) { @@ -366,6 +369,9 @@ void SvImpLBox::CursorDown() void SvImpLBox::CursorUp() { +if (!pStartEntry) +return; + SvTreeListEntry* pPrevFirstToDraw = pView-PrevVisible(pStartEntry); if( pPrevFirstToDraw ) { @@ -391,6 +397,9 @@ void SvImpLBox::PageDown( sal_uInt16 nDelta ) if( !nDelta ) return; +if (!pStartEntry) +return; + SvTreeListEntry* pNext = pView-NextVisible(pStartEntry, nRealDelta); if( (sal_uLong)pNext == (sal_uLong)pStartEntry ) return; @@ -428,6 +437,9 @@ void SvImpLBox::PageUp( sal_uInt16 nDelta ) if( !nDelta ) return; +if (!pStartEntry) +return; + SvTreeListEntry* pPrev = pView-PrevVisible(pStartEntry, nRealDelta); if( (sal_uLong)pPrev == (sal_uLong)pStartEntry ) return; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/mathml/importutils.cxx | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) New commits: commit 1749eac1d0e7983a39c32ace9da429a74f95695d Author: José Guilherme Vanz guilherme@gmail.com Date: Sat Feb 2 18:23:45 2013 -0200 String cleanup in oox Change-Id: Ib06b6defdb82c5d62be9cbd59f02827c07a320d8 Signed-off-by: José Guilherme Vanz guilherme@gmail.com Reviewed-on: https://gerrit.libreoffice.org/1969 Reviewed-by: Norbert Thiebaud nthieb...@gmail.com Tested-by: LibreOffice gerrit bot ger...@libreoffice.org diff --git a/oox/source/mathml/importutils.cxx b/oox/source/mathml/importutils.cxx index d3c4782..5350d58 100644 --- a/oox/source/mathml/importutils.cxx +++ b/oox/source/mathml/importutils.cxx @@ -41,7 +41,6 @@ #define CLOSING( token ) XML_STREAM_CLOSING( token ) using namespace com::sun::star; -using rtl::OUString; namespace oox { @@ -117,7 +116,7 @@ OUString XmlStream::AttributeList::operator[] (int token) rtl::OUString XmlStream::AttributeList::attribute( int token, const rtl::OUString def ) const { -std::map int, rtl::OUString ::const_iterator find = attrs.find( token ); +std::map int, OUString ::const_iterator find = attrs.find( token ); if( find != attrs.end()) return find-second; return def; @@ -125,19 +124,19 @@ rtl::OUString XmlStream::AttributeList::attribute( int token, const rtl::OUStrin bool XmlStream::AttributeList::attribute( int token, bool def ) const { -std::map int, rtl::OUString ::const_iterator find = attrs.find( token ); +std::map int, OUString ::const_iterator find = attrs.find( token ); if( find != attrs.end()) { -const rtl::OUString sValue = find-second; -if( sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(true)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(on)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(t)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(1)) ) +const OUString sValue = find-second; +if( sValue.equalsIgnoreAsciiCaseAscii(true) || +sValue.equalsIgnoreAsciiCaseAscii(on) || +sValue.equalsIgnoreAsciiCaseAscii(t) || +sValue.equalsIgnoreAsciiCaseAscii(1) ) return true; -if( sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(false)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(off)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(f)) || - sValue.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM(0)) ) +if( sValue.equalsIgnoreAsciiCaseAscii(false) || +sValue.equalsIgnoreAsciiCaseAscii(off) || +sValue.equalsIgnoreAsciiCaseAscii(f) || +sValue.equalsIgnoreAsciiCaseAscii(0) ) return false; SAL_WARN( oox.xmlstream, Cannot convert \' sValue \' to bool. ); } @@ -146,7 +145,7 @@ bool XmlStream::AttributeList::attribute( int token, bool def ) const sal_Unicode XmlStream::AttributeList::attribute( int token, sal_Unicode def ) const { -std::map int, rtl::OUString ::const_iterator find = attrs.find( token ); +std::map int, OUString ::const_iterator find = attrs.find( token ); if( find != attrs.end()) { if( !find-second.isEmpty() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Makefile.in
Makefile.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 353e177095ad772673ffac8020c823309588656f Author: Stephan Bergmann sberg...@redhat.com Date: Mon Feb 4 08:39:08 2013 +0100 Adapt distclean to moved config_host/*.h.in Change-Id: I214274d4d843cefc8dbabb83e28fb4e1766b9111 diff --git a/Makefile.in b/Makefile.in index 52df78f..ee60c22 100644 --- a/Makefile.in +++ b/Makefile.in @@ -190,11 +190,11 @@ endif $(BUILDDIR)/autom4te.cache \ $(BUILDDIR)/config.log \ $(BUILDDIR)/config.status \ -$(BUILDDIR)/config/*.h \ $(BUILDDIR)/config_build.mk \ $(BUILDDIR)/config_host.mk \ $(BUILDDIR)/config_host.mk.last \ $(BUILDDIR)/config_host.mk.stamp \ +$(BUILDDIR)/config_host/*.h \ $(BUILDDIR)/configure \ $(BUILDDIR)/instsetoo_native/util/openoffice.lst \ $(BUILDDIR)/solenv/inc/minor.mk \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Makefile.in
Makefile.in |1 + 1 file changed, 1 insertion(+) New commits: commit 396630ac2f03360a04773e9f1cc12517749de58c Author: Stephan Bergmann sberg...@redhat.com Date: Mon Feb 4 08:48:25 2013 +0100 Handle new lo.xcent in distclean Change-Id: Ie5906be1efe637e833288345299a0308236a99b5 diff --git a/Makefile.in b/Makefile.in index ee60c22..4d7f120 100644 --- a/Makefile.in +++ b/Makefile.in @@ -197,6 +197,7 @@ endif $(BUILDDIR)/config_host/*.h \ $(BUILDDIR)/configure \ $(BUILDDIR)/instsetoo_native/util/openoffice.lst \ +$(BUILDDIR)/lo.xcent \ $(BUILDDIR)/solenv/inc/minor.mk \ $(BUILDDIR)/warn find $(SOLARENV)/gdb -name *.pyc -exec rm {} \; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/ppt/extdrawingfragmenthandler.hxx |2 - oox/source/ppt/pptfilterhelpers.hxx |2 - oox/source/shape/ShapeContextHandler.cxx | 40 +++ oox/source/shape/ShapeContextHandler.hxx | 28 oox/source/shape/ShapeDrawingFragmentHandler.cxx |1 oox/source/shape/ShapeDrawingFragmentHandler.hxx |2 - oox/source/shape/ShapeFilterBase.cxx |4 +- oox/source/shape/ShapeFilterBase.hxx |2 - oox/source/token/namespacemap.cxx|2 - oox/source/token/propertynames.cxx |2 - oox/source/token/tokenmap.cxx|5 -- oox/source/vml/vmldrawing.cxx|1 oox/source/vml/vmldrawingfragment.cxx|2 - oox/source/vml/vmlformatting.cxx |2 - oox/source/vml/vmlinputstream.cxx|3 - oox/source/vml/vmlshape.cxx |4 -- oox/source/vml/vmlshapecontainer.cxx |2 - oox/source/vml/vmlshapecontext.cxx |7 +--- oox/source/vml/vmltextbox.cxx|2 - oox/source/vml/vmltextboxcontext.cxx |1 20 files changed, 47 insertions(+), 67 deletions(-) New commits: commit b48948201486c5367b5ff313cf49b56b4fa366ed Author: José Guilherme Vanz guilherme@gmail.com Date: Sun Feb 3 18:18:37 2013 -0200 String cleanup in oox Change-Id: Ica69f655f3777fe37a51e313218ae12aa7d012a2 Signed-off-by: José Guilherme Vanz guilherme@gmail.com Reviewed-on: https://gerrit.libreoffice.org/1977 Tested-by: LibreOffice gerrit bot ger...@libreoffice.org Reviewed-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/oox/source/ppt/extdrawingfragmenthandler.hxx b/oox/source/ppt/extdrawingfragmenthandler.hxx index 3751e4d..9236f93 100644 --- a/oox/source/ppt/extdrawingfragmenthandler.hxx +++ b/oox/source/ppt/extdrawingfragmenthandler.hxx @@ -43,7 +43,7 @@ namespace oox { namespace ppt { class ExtDrawingFragmentHandler : public ::oox::core::FragmentHandler { public: -ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const ::rtl::OUString rFragmentPath, +ExtDrawingFragmentHandler( oox::core::XmlFilterBase rFilter, const OUString rFragmentPath, const oox::ppt::SlidePersistPtr pSlidePersistPtr, const oox::ppt::ShapeLocation eShapeLocation, oox::drawingml::ShapePtr pMasterShapePtr, diff --git a/oox/source/ppt/pptfilterhelpers.hxx b/oox/source/ppt/pptfilterhelpers.hxx index 3924b2d..67efbbf 100644 --- a/oox/source/ppt/pptfilterhelpers.hxx +++ b/oox/source/ppt/pptfilterhelpers.hxx @@ -86,7 +86,7 @@ namespace oox { namespace ppt { // BEGIN CUTPASTE from sd pptinanimation.cxx -bool convertMeasure( ::rtl::OUString rString ); +bool convertMeasure( OUString rString ); // END CUTPASTE from sd pptinanimation.cxx diff --git a/oox/source/shape/ShapeContextHandler.cxx b/oox/source/shape/ShapeContextHandler.cxx index 11bab21..6b62396 100644 --- a/oox/source/shape/ShapeContextHandler.cxx +++ b/oox/source/shape/ShapeContextHandler.cxx @@ -31,15 +31,15 @@ using namespace ::com::sun::star; using namespace core; using namespace drawingml; -::rtl::OUString SAL_CALL ShapeContextHandler_getImplementationName() +OUString SAL_CALL ShapeContextHandler_getImplementationName() { return OUString( com.sun.star.comp.oox.ShapeContextHandler ); } -uno::Sequence ::rtl::OUString SAL_CALL +uno::Sequence OUString SAL_CALL ShapeContextHandler_getSupportedServiceNames() { -uno::Sequence ::rtl::OUString s(1); +uno::Sequence OUString s(1); s[0] = com.sun.star.xml.sax.FastShapeContextHandler; return s; } @@ -154,8 +154,8 @@ void SAL_CALL ShapeContextHandler::startFastElement const uno::Reference xml::sax::XFastAttributeList Attribs) throw (uno::RuntimeException, xml::sax::SAXException) { -static const ::rtl::OUString sInputStream -(RTL_CONSTASCII_USTRINGPARAM (InputStream)); +static const OUString sInputStream +(InputStream); uno::Sequencebeans::PropertyValue aSeq(1); aSeq[0].Name = sInputStream; @@ -170,7 +170,7 @@ void SAL_CALL ShapeContextHandler::startFastElement if (!msRelationFragmentPath.isEmpty()) { FragmentHandlerRef rFragmentHandler(new ShapeFragmentHandler(*mxFilterBase, msRelationFragmentPath)); -rtl::OUString aThemeFragmentPath = rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE( theme ) ); +OUString aThemeFragmentPath = rFragmentHandler-getFragmentPathFromFirstType( CREATE_OFFICEDOC_RELATION_TYPE( theme ) ); uno::Referencexml::sax::XFastSAXSerializable xDoc(mxFilterBase-importFragment(aThemeFragmentPath), uno::UNO_QUERY_THROW); mxFilterBase-importFragment(new ThemeFragmentHandler(*mxFilterBase, aThemeFragmentPath, *mpThemePtr ), xDoc);
[Libreoffice-qa] Windows OS tracking bug Accessibility and AT - fdo#60251
I've created a new Bugzilla tracking metabug, fdo#60251, for Accessibility and Assistive Technology issues on Window OS. Hope this will help to track all accessibility issues across the LibreOffice projects. So, we now have three that are active, one for each major OS branch with some cross listing. May have to do something similar for the mobile OS as they evolve. https://bugs.freedesktop.org/show_bug.cgi?id=36549 for Linux GNOME Orca and AT-SPI2/ATK https://bugs.freedesktop.org/show_bug.cgi?id=55571 for Apple OSX Apple Accessibility API https://bugs.freedesktop.org/show_bug.cgi?id=60251 for Windows OS Accessibility and the JAVA Access Bridge Folks should review these and please submit known issues as new bugs or enhancement requests. And of course I hope it will help in all aspects of making Accessibility and AT support with LibreOffice the preferred choice for all operating systems and platforms. Also, I apologize to those Devs QA folks that I buried today with email updates as I sorted through the existing bugs and metatagged with an ACCESSIBILITY: value in the title. Stuart ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 60215] FILEOPEN: Currency format lost on close and open
https://bugs.freedesktop.org/show_bug.cgi?id=60215 --- Comment #1 from Markus Mohrhard markus.mohrh...@googlemail.com --- No, it is not a regression between RC2 and RC3. We simply can't handle it right now. The cached value import will loose colors of number formats at the moment. We might need to think about a solution for the lost format color. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51694] vector presentations crash LibreOffice on load when --enable-rsvg=no
https://bugs.freedesktop.org/show_bug.cgi?id=51694 Michael Meeks michael.me...@novell.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Michael Meeks michael.me...@novell.com --- We dropped librsvg in 4.0 - so closing this easy hack ;-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60215] FILEOPEN: Complete Currency FORMATTING VIEWING needs recalculation
https://bugs.freedesktop.org/show_bug.cgi?id=60215 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS|All |Windows (All) Status|UNCONFIRMED |NEW CC||LibreOffice@bielefeldundbus ||s.de Summary|FILEOPEN: Currency format |FILEOPEN: Complete Currency |lost on close and open |FORMATTING VIEWING needs ||recalculation Ever confirmed|0 |1 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Effect [Reproducible] with LibO 4.0.0.3 rc - GERMAN UI / German Locale [Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89)] {tinderbox: @6, pull time 2013-01-31 11:30(?)} on German WIN7 Home Premium (64bit) with User Profile updated from 4.0.0.2; but I doubt that it is a format loss problem. Easy to reproduce: create new blank document, Type formula =-1-1 into A1 and apply Currency formatting. That should show -2,00 € in red color because negative (#.##0,00 [$€-407];[ROT]-#.##0,00 [$€-407]). Save, close and reopen, A1 still is -2,00 €, but now in black color, althougg formatting string still is correct. control+shift+f9 indeed heals the problem, so I agree that it seems to be a recalculation problem. I already stumbled upon similar, may be more serious related currency problems last days, I will check that. Can easily be reproduced, simply open attached sample document. If you see A1 contents black your version is affected @mike.hall: I think you also tested with WIN? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60215] FILEOPEN: Complete Currency FORMATTING VIEWING needs recalculation
https://bugs.freedesktop.org/show_bug.cgi?id=60215 --- Comment #3 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Created attachment 74123 -- https://bugs.freedesktop.org/attachment.cgi?id=74123action=edit Sample Document Your version is affected if it shows A1 in black after FILEOPEN -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60211] EDITING: Spell check
https://bugs.freedesktop.org/show_bug.cgi?id=60211 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID CC||LibreOffice@bielefeldundbus ||s.de Component|Writer |Linguistic --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Not a valid bug report. @andreipora: Thank you for your report – unfortunately any useful information is missing. If you want to reopen this bug because the problem still appears with a current LibO version (3.6.4 or later) please consider hints on http://wiki.documentfoundation.org/BugReport, what will help you to find out what information will be useful to reproduce your problem. Please add all information requested in following: - Write a meaningful Summary describing exactly what the problem is - Attach a sample document (not only screenshot) or refer to an existing sample document in an other Bug with a link; to attach a file to this bug report, just click on Add an attachment right on this page. - Attach screenshots with comments if you believe that that might explain the problem better than a text comment. Best way is to insert your screenshots into a DRAW document and to add comments that explain what you want to show (attachment 68877, attachment 68490) – if possible contribute an instruction how to create a sample document from the scratch - add information -- what EXACTLY is unexpected -- and WHY do you believe it's unexpected (cite Help or Documentation!) -- concerning your OS (Version, Distribution, Language) -- concerning your LibO version (with Build ID if it's not a public release) and localization (UI language, Locale setting) –- Libo settings that might be related to your problems -- how you launch LibO and how you opened the sample document –- Whether your problem persists when you renamed your user profile before you launch LibO and installed the Extension (please see https://wiki.documentfoundation.org/UserProfile#User_profile_location) -- everything else crossing your mind after you read linked texts -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60215] FILEOPEN: Complete Currency FORMATTING VIEWING needs recalculation
https://bugs.freedesktop.org/show_bug.cgi?id=60215 mike.h...@onepoyle.net changed: What|Removed |Added Keywords||regression --- Comment #4 from mike.h...@onepoyle.net --- @Rainer Yes, I test only with Win Regression from both RC1 and 3.6.4 (saved files from each and opened in RC3 - problem occurs. Regret it probably needs to be fixed before release of 4.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60207] BUGZILLAASSISTANT will not launch step 4
https://bugs.freedesktop.org/show_bug.cgi?id=60207 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS|All |Windows (All) Status|UNCONFIRMED |NEW CC||LibreOffice@bielefeldundbus ||s.de, programm...@ertai.nl Summary|Cannot submit a bug |BUGZILLAASSISTANT will not ||launch step 4 Ever confirmed|0 |1 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- Reproducible with Seamonkey version 2.15 and start of bug report due to reporter's screenshot. Expected after those inputs: Summary input pand and Long description pane appear for Step 4 Actual: only 2 related bugs shown, no progress FF showed an inappropriate It seems there is a problem to connect with Bugzilla. Please try again later. (No Bugzilla problems at all) I tried from https://www.libreoffice.org/get-help/bug/?LOversion=4.0.0.3LOlocale=deLOmodule=SpreadsheetDocument with 'Writer - Editing - 4.0.0.3 - Windows 7', Step 4 did not launch Switched to 'Presentation - Editing': Now step 4 Launched Same strange behavior from https://www.libreoffice.org/get-help/bug/?LOversion=4.0.0.3LOlocale=deLOmodule=SpreadsheetDocument with 'Presentation - Editing - 4.0.0.3 - Windows 7', Step 4 did not launch Switched to 'Writer - Editing': Now step 4 Launched A More simple workaround is to modify the selected Sub Component if BSA does not change to Step 4 @Rob: Can you please check? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60215] FILEOPEN: Complete Currency FORMATTING VIEWING needs recalculation
https://bugs.freedesktop.org/show_bug.cgi?id=60215 --- Comment #5 from Markus Mohrhard markus.mohrh...@googlemail.com --- Regret it probably needs to be fixed before release of 4.0 Far from it. It is not even close to a blocker. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60132] FILEOPEN: Error reading file after inserting comment
https://bugs.freedesktop.org/show_bug.cgi?id=60132 --- Comment #8 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hello Reproduced with Windows 7 64bits Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60203] UNDO in LibreOffice Draw
https://bugs.freedesktop.org/show_bug.cgi?id=60203 --- Comment #1 from headsup u982t5hg5...@outlook.com --- I tried several times to replicate this with Libreoffice 4.0.0.3 on W8 pro 32 bit, x86 but Undo worked OK every time. This may be specific to Linux so one of my QA colleagues who has Linux will check this also. If you can provide the specific steps that replicate the issue that would be helpful (e.g. does it only happen with specific items?). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54157] LibreOffice 3.7/4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 choffardet pierre.choffar...@free.fr changed: What|Removed |Added Depends on||60065 --- Comment #100 from choffardet pierre.choffar...@free.fr --- Adding bug 60065 (BASIC: Can't set an object to NamedValue structure) because it's a regression and there is no workaround many macros are broken -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60065] BASIC: Can't set an object to NamedValue structure
https://bugs.freedesktop.org/show_bug.cgi?id=60065 choffardet pierre.choffar...@free.fr changed: What|Removed |Added Blocks||54157 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60065] BASIC: Can't set an object to NamedValue structure
https://bugs.freedesktop.org/show_bug.cgi?id=60065 --- Comment #3 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hello Reproduced with Windows 7 64bits Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48775] CRASH when opening biblio.odb via tools menu without Base module installed
https://bugs.freedesktop.org/show_bug.cgi?id=48775 --- Comment #15 from Josh manwesulimo2...@yahoo.co.uk --- I can reproduce this with 3.6.5.2 on Windows 8. Is it being worked on? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60022] EDITING: Sub form data entry causes crash
https://bugs.freedesktop.org/show_bug.cgi?id=60022 --- Comment #14 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to comment #13) There is not a mysql database. I used the mysql-odbc connection to attach to the access database file I supplied. I understand now. Thank you for the clarification. You used MySQL (ODBC) for the Database type setting in LibreOffice, but then gave it an ODBC DSN that uses a non-MySQL driver. When using a non-MySQL ODBC driver, the intention is that one uses ODBC for the Database type setting. The MySQL (ODBC) setting sets a couple of other settings internally meant for the MySQL ODBC driver and that may or may not work well with other ODBC drivers. (With ODBC, one can set or unset these settings manually in Advanced Settings). Ken, since you attached a reproduction example with native (actually under the hood, ADO) MS Access for Database type setting, could you please confirm whether you get the bug with MS Acces for Database type, too, or not? Since you said you tested only with ODBC... Thanks in advance for this information. Ken, could you please proof-check my instructions below and correct them if they need to be? Thanks. Headsup, since you tested with MS Access for Database type, could you please test with ODBC, as per instructions below? Thanks. If some QA person can reproduce and give me backtrace from a debug version, that would be *very* useful. Here are detailed instructions: Download attachment 73934. Unzip, e.g. to c:\some\path On a 64 bit OS, use C:\Windows\SysWOW64\odbcad32.exe; on a 32-bit OS, use C:\Windows\system\odbcad32.exe (or is it system32 instead of system?). Go to User DSN tab, click Add... button. Choose the Microsoft Access Driver (*.mdb), and point it to c:\some\path\the file you created by unzipping.mdb. Name the DSN Call Report 2. Open c:\some\path\the file you created by unzipping.odb (in LibreOffice) Menu Edit / Database / Connection Type. Choose ODBC, Next. Browse, select Call Report 2, OK. Finish. In the main window, Database pane (left), click on Forms. In the forms pane (lower right), double-click on Murdock Call Report. A new window opens. In the grid area where one of the columns is Comments on Call, go to bottom (empty line), enter some data, go again to the new empty line. You have just added new data. If you don't get a crash, report it here. If you get a crash, report it here and if possible attach a backtrace from a debugger. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60065] BASIC: Can't set an object to NamedValue structure
https://bugs.freedesktop.org/show_bug.cgi?id=60065 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added CC||lio...@mamane.lu, ||nopo...@novell.com, ||uray.ja...@gmail.com --- Comment #4 from Lionel Elie Mamane lio...@mamane.lu --- Adding our Basic experts in CC. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60207] BUGZILLAASSISTANT will not launch step 4
https://bugs.freedesktop.org/show_bug.cgi?id=60207 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Rob Snelders programm...@ertai.nl --- I found the problem now also. It works again here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56035] : Indexing for Search not working
https://bugs.freedesktop.org/show_bug.cgi?id=56035 --- Comment #14 from Joachim Wiesel joachim.wie...@gmail.com --- LO 4.0RC3: Same result - LibreOffice 4.0RC3 does NOT fix the indexing bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59958] Not existing Arial Narrow Arrow character shown as rectangle instead of being replaced
https://bugs.freedesktop.org/show_bug.cgi?id=59958 --- Comment #2 from headsup u982t5hg5...@outlook.com --- Created attachment 74124 -- https://bugs.freedesktop.org/attachment.cgi?id=74124action=edit pdf 4002 ok Tested on 4.0.0.2 English-UK UI, Win 8 Pro 32bit, x86. Exported to PDF as per your specs and read in Microsoft PDF Reader. Was not able to replicate issue. Will test on 4.0.0.3 also. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57915] Impress - Setting Ruler Visible reset Unit of Measurement to Default.
https://bugs.freedesktop.org/show_bug.cgi?id=57915 --- Comment #9 from Stephen stephenletter...@gmail.com --- Tested on Windows 7 Home Basic 64-bit English version: - Ruler showed correct unit of measurement. - Settings won't be reset again. @Jorendc Thankyou for your kind invitation. I may not be available recently, but I will consider and figure out what suit me most. I will keep the link you gave me. Thankyou. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60114] EDITING: Function COMBINA for number_2 number_1
https://bugs.freedesktop.org/show_bug.cgi?id=60114 GerardF gerard.farg...@orange.fr changed: What|Removed |Added Severity|blocker |enhancement CC||gerard.farg...@orange.fr --- Comment #3 from GerardF gerard.farg...@orange.fr --- Why a normal result of a function should be a blocker ? COMBINA(N,M) have constraints N=0 , M=0 and N=M It is defined like this in the ODF specification : http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#__RefHeading__1018494_715980110 and have the same constraints in other spreadsheets tools like Excel. May be this could be an enhancement (in this case, ODF specs need to change) but surely not a blocker. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59958] Not existing Arial Narrow Arrow character shown as rectangle instead of being replaced
https://bugs.freedesktop.org/show_bug.cgi?id=59958 --- Comment #3 from headsup u982t5hg5...@outlook.com --- Created attachment 74126 -- https://bugs.freedesktop.org/attachment.cgi?id=74126action=edit sample pdf export from LO 4.0.0.3 Here is the export from Libreoffice Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89). Again on Win 8 Pro 32 bit. As you can see it looks OK. By the way in two different PDF readers I tested with I can see the problems in your test pdf's that you are referring to (So it's not a PDF reader issue). My pdf export options in the general tab are Range - All, jpeg compression - quality 90%, Reduce Image resolution 600dpi, create pdf form, submit format fdf, export bookmarks. I tried playing around with those settings but couldn't reproduce the issue. The other key differences in testing environment that I can see are 1) x32 vs x64 2) English vs. German Locale I'll see if someone else can test on x64. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60217] New: error message limited to a dot when mysql native connector is used
https://bugs.freedesktop.org/show_bug.cgi?id=60217 Priority: medium Bug ID: 60217 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: error message limited to a dot when mysql native connector is used Severity: normal Classification: Unclassified OS: Linux (All) Reporter: t.ba...@orange.fr Hardware: x86 (IA32) Status: NEW Version: 3.5.4 release Component: Database Product: LibreOffice When using executeQuery macro instead of executeUpdate when the SQL string manipulates data, the error message is not explicit (limited to a dot). This error message should be cannot issue data manipulation statements with executequery as it is when using JDBC connector for example. The exact version of libreoffice is the LibreOffice 3.5.4.2 Version ID : 350m1(Build:2) on UBUNTU 12.04 generic. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60218] New: undefined: Insert Movie and Sound...: cannot save text Wrap settings.
https://bugs.freedesktop.org/show_bug.cgi?id=60218 Priority: medium Bug ID: 60218 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: undefined: Insert Movie and Sound...: cannot save text Wrap settings. Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: declan_moria...@yahoo.co.uk Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.5.2 rc Component: Writer Product: LibreOffice Created attachment 74127 -- https://bugs.freedesktop.org/attachment.cgi?id=74127action=edit Test document wth a WAV sound file inserted. The icon has Page Wrap Text Wrap properties. If this is changed to Through Wrap this is reflected in the file. When saved and re-opened the icon reverts back to Page Wrap. Problem description: After inserting Sound or Movie in Insert Movie and Sound... you get an icon on the screen that is a graphic. It is impossible to save the Text Wrap settings. Steps to reproduce: 1. Insert Sound or Movie using Insert Movie and Sound... in the Insert menu. 2. change the Text Wrap setting from the default Page Wrap by selecting the icon graphic by clicking it so the handles appear. Right click the icon to get the context menu. Change the Text Wrap option to Through Wrap. Save the file. 3. Open the file again. The text Wrapping will be set to Page Wrap not Through Wrap. Current behavior: Text Wrap is set to Page Wrap by default. When changed to Through Wrap and saved, when re-opened the Through Wrap setting is not saved and the graphic has Page Wrap again. Expected behavior: Text Wrap setting of Movie or Sound icon should be saved. If changed to Through Wrap this should be the same when re-opened i.e. Through Wrap. Operating System: Mac OS X Version: 3.6.5.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60218] FILESAVE: Insert Movie and Sound...: cannot save text Wrap settings.
https://bugs.freedesktop.org/show_bug.cgi?id=60218 declan_moria...@yahoo.co.uk changed: What|Removed |Added Summary|undefined: Insert Movie|FILESAVE: Insert Movie and |and Sound...: cannot save |Sound...: cannot save text |text Wrap settings. |Wrap settings. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54813] Font Descriptor Flags are not set correctly
https://bugs.freedesktop.org/show_bug.cgi?id=54813 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever confirmed|0 |1 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- @Dominic Tubach Thank you for your report. Please explain due to http://wiki.documentfoundation.org/BugReport wo that also a non-PDF-expert can understand and reproduce the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60220] New: Sheets
https://bugs.freedesktop.org/show_bug.cgi?id=60220 Priority: medium Bug ID: 60220 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Sheets Severity: normal Classification: Unclassified OS: Windows (All) Reporter: rogerseif...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 3.6.4.3 release Component: Spreadsheet Product: LibreOffice Hi there... I have a problem, that in one calc-doc is no possibility to chance the sheets on the bottom (Pic: LibreOffice Calc-2).. at a other calc-doc (where i dont need) i have the possibilty (Pic: LibreOffice Calc-1). Where can i change, that i also have the possibily to switch to other sheets? Link to the Pics: https://docs.google.com/folder/d/0Bzz2zekafYaCZjRicU8wTGgtMU0/edit?usp=sharing P.S.: Here i only can add one attachment! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60221] New: BUGZILLAASSISTANT: sent me to the CC list
https://bugs.freedesktop.org/show_bug.cgi?id=60221 Priority: medium Bug ID: 60221 CC: webs...@global.libreoffice.org Assignee: libreoffice-bugs@lists.freedesktop.org Summary: BUGZILLAASSISTANT: sent me to the CC list Severity: normal Classification: Unclassified OS: All Reporter: john.pr...@cantab.net Hardware: Other Status: UNCONFIRMED Version: unspecified Component: WWW Product: LibreOffice When entering a bug using BSA it would be useful to be CC'd at the same time (I would prefer automatically, but an option to be CC'd would also be OK). It is very useful when people want to ask me a question as the bug reporter; currently I often miss that I have been asked to supply more information as I am not CC'd by default. Suggested solution: when reporting via BSA automatically CC the reporter. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60222] New: Customize toolbar UI Description crash
https://bugs.freedesktop.org/show_bug.cgi?id=60222 Priority: medium Bug ID: 60222 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Customize toolbar UI Description crash Severity: normal Classification: Unclassified OS: Linux (All) Reporter: rosli...@gmail.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: 3.6.4.3 release Component: UI Product: LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60220] Sheets
https://bugs.freedesktop.org/show_bug.cgi?id=60220 Roger Seifert rogerseif...@gmail.com changed: What|Removed |Added Priority|medium |high URL||https://docs.google.com/fol ||der/d/0Bzz2zekafYaCZjRicU8w ||TGgtMU0/edit?usp=sharing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60223] New: BUGZILLAASSISTANT: list of related bugs no related
https://bugs.freedesktop.org/show_bug.cgi?id=60223 Priority: medium Bug ID: 60223 CC: webs...@global.libreoffice.org Assignee: libreoffice-bugs@lists.freedesktop.org Summary: BUGZILLAASSISTANT: list of related bugs no related Severity: normal Classification: Unclassified OS: All Reporter: john.pr...@cantab.net Hardware: Other Status: UNCONFIRMED Version: unspecified Component: WWW Product: LibreOffice Created attachment 74128 -- https://bugs.freedesktop.org/attachment.cgi?id=74128action=edit screenshot showing related bugs with 'FORMATTING' selected When the list of related bugs appears it is not normally related to what I have entered. It seems to ignore my choice of the keyword 'FORMATTING' for example and present a list of bugs which do not have a keyword 'undefined'. The related bugs should be bugs which start with the same keyword. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60222] Customize toolbar UI Description crash
https://bugs.freedesktop.org/show_bug.cgi?id=60222 --- Comment #1 from rosli...@gmail.com --- Created attachment 74129 -- https://bugs.freedesktop.org/attachment.cgi?id=74129action=edit customize toolbar description Customize toolbar description UI crash on my netbook (1024x600) resolution. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54382] EDITING: Sort using autofilter doesn't work with blank column header
https://bugs.freedesktop.org/show_bug.cgi?id=54382 --- Comment #3 from john.pr...@cantab.net --- Also reproducible with Version 4.1.0.0.alpha0+ (Build ID: 28b7359e00fec9fd3bfab3c9105cf250c4320a2) TinderBox: Win-x86@6, Branch:master, Time: 2013-02-02_00:14:06 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57176] EDITING: CONDITIONAL FORMATTING not restored by UNDO
https://bugs.freedesktop.org/show_bug.cgi?id=57176 --- Comment #17 from john.pr...@cantab.net --- Not reproducible in Version 4.1.0.0.alpha0+ (Build ID: 28b7359e00fec9fd3bfab3c9105cf250c4320a2) TinderBox: Win-x86@6, Branch:master, Time: 2013-02-02_00:14:06 using either of Rainer Bielefeld's methods. Can this be marked as resolved? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60225] New: Extensionname: test
https://bugs.freedesktop.org/show_bug.cgi?id=60225 Priority: medium Bug ID: 60225 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Extensionname: test Severity: normal Classification: Unclassified OS: Windows (All) Reporter: programm...@ertai.nl Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.0.0.3 rc Component: Extensions Product: LibreOffice Problem description: test Steps to reproduce: 1. 2. 3. Current behavior: Expected behavior: Operating System: Windows XP Version: 4.0.0.3 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60225] Extensionname: test
https://bugs.freedesktop.org/show_bug.cgi?id=60225 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60225] Extensionname: test
https://bugs.freedesktop.org/show_bug.cgi?id=60225 Rob Snelders programm...@ertai.nl changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60226] New: Check for ALLEXTENSIONS update causes error message
https://bugs.freedesktop.org/show_bug.cgi?id=60226 Priority: medium Bug ID: 60226 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Check for ALLEXTENSIONS update causes error message Severity: normal Classification: Unclassified OS: All Reporter: libreoff...@bielefeldundbuss.de Hardware: Other Status: NEW Version: 4.0.0.3 rc Component: Extensions Product: LibreOffice User Thomas Hackert reported this problem on disc...@de.libreoffice.org Steps how to reproduce [Reproducible] with parallel Dev. Installation of LODev 4.0.1.0+ - English UI / German Locale [Build ID: 693217465486667d38c3b7cd6d654136fe1efc8)] {tinderbox: @6, pull time 2013-02-03 09:04:55} on German WIN7 Home Premium (64bit) with newly created user profile ….\LODev\401\ 1. Install at least 1 unlokced Extension 2. Menu 'Tools - Options - Extensions - Check for Updates - Show all Updates=checked' Expected: Useful messages Actual: Error Message: An error occurred: Premature end of data in tag html line 1 Line: 9 Column: 1 OS = all and NEW due to results on Mailing list. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60226] Check for ALL EXTENSIONS update causes error message
https://bugs.freedesktop.org/show_bug.cgi?id=60226 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|Check for ALLEXTENSIONS |Check for ALL EXTENSIONS |update causes error message |update causes error message Version|4.0.0.3 rc |4.0.0.0.alpha0+ Master --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de --- For My Tests I install GeoMap 3.0.0 Already [Reproducible] with unzipped installation of LOdev 4.0.0.0.alpha1+ - ENGLISH UI / German Locale [Build ID: af60316514f3ae3d4c475819bf86f2af837171e)] {tinderbox: Win-x86@6, pull time 2012-11-23 22:10:31} on German WIN7 Home Premium (64bit) with own separate User Profile . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60225] Extensionname: test
https://bugs.freedesktop.org/show_bug.cgi?id=60225 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |LibreOffice@bielefeldundbus |desktop.org |s.de CC||LibreOffice@bielefeldundbus ||s.de Component|Extensions |deletionrequest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60228] New: VIEWING: Inserted videos don't play in Mac OS X - produce big question mark and when played audeo plays not video.
https://bugs.freedesktop.org/show_bug.cgi?id=60228 Priority: medium Bug ID: 60228 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: VIEWING: Inserted videos don't play in Mac OS X - produce big question mark and when played audeo plays not video. Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: declan_moria...@yahoo.co.uk Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.5.2 rc Component: Writer Product: LibreOffice Problem description: Videos inserted into a .odt document won't play in Mac OS X. The video shows as a grey oblong with a question mark in it. When played using the media player Audio plays. Steps to reproduce: 1. Insert video into .odt document in Writer using the insert Movie and Sound... option in the insert menu (.mov or .avi) or any that are compatible it doesn't matter. 2. Video shows as grey box with question mark inside. 3. play video in media player. Audio plays but video remains blank. The box is white with no video playing. Current behavior: Video does not play, video box remains blank and audio plays. Expected behavior: Videos play normally. When videos play normally should there be a grey box with a question mark in the middle after insertion? This works in LibreOffice 3.3.2. In 3.3.2 you still get the Question Mark when the video is first inserted. Operating System: Mac OS X Version: 3.6.5.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60228] VIEWING: Inserted videos don't play in Mac OS X - produce big question mark and when played audeo plays not video.
https://bugs.freedesktop.org/show_bug.cgi?id=60228 declan_moria...@yahoo.co.uk changed: What|Removed |Added CC||declan_moria...@yahoo.co.uk --- Comment #1 from declan_moria...@yahoo.co.uk --- Note this also happens to Impress. I think this happens to all components including Spreadsheet. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60094] Text converted to upper index when saved into DOC.
https://bugs.freedesktop.org/show_bug.cgi?id=60094 CZEpersi czepe...@email.cz changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #8 from CZEpersi czepe...@email.cz --- Hi! I have tried it on 3.6.5. and it seems, I owe you an apology. I was abroad for couple of weeks and since then, a lot of progress has been made! On 3.6.5. it seems to be working fine. I still have to test the exported DOC files on M$ Office and I will test it on 4.0 RC as well, but for now, it seems to be working properly. Whatever you guys did between 3.5.6. and 3.6.5., you have fixed this annoying issue as well. I will also test if other similar issues were fixed, like improper application of bold format or hyperlinks to other parts of the text during DOC save. It was also an issue in the older version. I propose to change the status to RESOLVED Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56935] : Crash on tab switching
https://bugs.freedesktop.org/show_bug.cgi?id=56935 --- Comment #2 from ostiax...@gmail.com --- (In reply to comment #1) As 3.5.x is EOL, is this still an issue in the latest stable release? Yes, still crashing when i change between tabs as described earlier LibreOffice 3.5.4.2 - build: 350m1(Build:2) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59055] : Font names in English, not target language (regression)
https://bugs.freedesktop.org/show_bug.cgi?id=59055 --- Comment #4 from webofht-libreofficebugs...@yahoo.com.hk --- Created attachment 74132 -- https://bugs.freedesktop.org/attachment.cgi?id=74132action=edit Screenshots in LibreOffice 4.0.0.3 and 3.6.4.3 The screenshots are taken on Debian Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60229] New: BUGZILLAASSISTANT: BUGZILLAASSISTANT doesn't work using Safari! You get message saying Bugzilla is uaavailabe pease try later.
https://bugs.freedesktop.org/show_bug.cgi?id=60229 Priority: medium Bug ID: 60229 CC: webs...@global.libreoffice.org Assignee: libreoffice-bugs@lists.freedesktop.org Summary: BUGZILLAASSISTANT: BUGZILLAASSISTANT doesn't work using Safari! You get message saying Bugzilla is uaavailabe pease try later. Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: declan_moria...@yahoo.co.uk Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.5.2 rc Component: WWW Product: LibreOffice Problem description: Using BUGZILLAASSISTANT from the Bug heading on the LibreOffice website in Safari 5.1.7 produces a cursor with a blue ball and a message in red saying the Bugzilla is unavailable please try later Steps to reproduce: 1. Open Safari and go to LibreOffice website. 2. go to Get Help- Bug 3. You get a cursor with a blue ball and the message that Bugzilla is unavailable please try later This works in Firefox on the mac. Current behavior: Accessing the bug submission assistant using Safari on a mac produces the message that Bugzilla is unavailable please try later. Doing the same thing in Firefox works and you get no message and the sign in screen as normal. Expected behavior: Using Safari should produce the sign in screen as normal when accessing the bug submission assistant. I am using MAC OS X 10.6.8 Snow Leopard. Operating System: Mac OS X Version: 3.6.5.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60219] Replacement fro not existing characters in font set broken.
https://bugs.freedesktop.org/show_bug.cgi?id=60219 --- Comment #1 from headsup u982t5hg5...@outlook.com --- Rainer, There is no attached sample document. Could you pls attach it and I'll have a look. Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60230] New: Wrong function displayed when using Function list.
https://bugs.freedesktop.org/show_bug.cgi?id=60230 Priority: medium Bug ID: 60230 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Wrong function displayed when using Function list. Severity: major Classification: Unclassified OS: All Reporter: gautier.sop...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.0.0.3 rc Component: Spreadsheet Product: LibreOffice When double clicking on a function name in the Function list under The last used Category, the function displayed in the sheet doesn't mach. To reproduce : - display The Last used in the Function list - double click on the third last used function - if you have the list for example AVERAGE, SUM, IF, double click on IF - the function displayed in the sheet is AVERAGE(test). Note the argument is the one of the IF function. I'm using Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) under debian. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60231] New: List of functions doubled each time one is double clicked in the Function list The last used Category
https://bugs.freedesktop.org/show_bug.cgi?id=60231 Priority: medium Bug ID: 60231 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: List of functions doubled each time one is double clicked in the Function list The last used Category Severity: normal Classification: Unclassified OS: All Reporter: gautier.sop...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.0.0.3 rc Component: Spreadsheet Product: LibreOffice To reproduce : - Choose The Last Used Category in the Function list - double click on one of them -- each time the list is doubled, ending with a very looong list. I'm using Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) under debian. It has been confirmed under Windows 7 64bits Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60230] Wrong function displayed when using Function list.
https://bugs.freedesktop.org/show_bug.cgi?id=60230 pierre-yves samyn pierre-yves.sa...@laposte.net changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hello I reproduce with Windows 7 64bits Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60232] New: undefined: bibliography database update
https://bugs.freedesktop.org/show_bug.cgi?id=60232 Priority: medium Bug ID: 60232 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: undefined: bibliography database update Severity: normal Classification: Unclassified OS: Linux (All) Reporter: ko...@post.cz Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 3.6.4.3 release Component: Writer Product: LibreOffice Problem description: TABLE OF BIBLIOGRAPHY (isert indexes and tables indexes and tables type: bibliography) is not updated properly after you fill the new ITEM (eg. Author(s) or Chapter or any other) in already inserted BIBLIOGRAPHY RECORD of the BIBLIOGRAPHY DATABASE (tools bibliography database). Steps to reproduce (to clarify description): 1. open libreoffice writer and write some text 2. insert the new RECORD into the BIBLIOGRAPHY DATABASE (tools bibliography database add new record into the biblio: fill short name eg. test, select type (eg. book), year, and title. DO NOT fill field eg. Author(s). For example you forget (or skip) to fill Author(s) by mistake. 3. Close BIBLIOGRAPHY DATABASE window 4. go into the text and insert BIBLIOGRAPHY ENTRY from the BIBLIOGRAPHY DATABASE (insert indexes and tables bibliography entry choose from bibliography database select the name of the bibliography entry test in the Short name box press Insert) 5. Insert TABLE OF BIBLIOGRAPHY into the end of the document (insert indexes and tables indexes and tables type: bibliography click OK 6. Now you discover your mistake (author name is missing in the inserted BIBLIOGRAPHY TABLE). 7. add item Author(s) in the BIBLIOGRAPHY RECORD (tools bibliography database select your RECORD test fill item Author(s). 8. Close BIBLIOGRAPHY DATABASE window 9. Update TABLE OF BIBLIOGRAPHY in the document: right click on the TABLE OF BIBLIOGRAPHY Update Index/Table 10. After that author name is NOT shown (updated) in the TABLE OF BIBLIOGRAPHY (although you added Author(s) name into the BIBLIOGRAPHY RECORD) 11. To be shown the Author name in the updated BIBLIOGRAPHY TABLE, you need to go into the text, delete the BIBLIOGRAPHY ENTRY from the text and insert it once more (repeat step 4). And then repeat step 9. Neither updating BIBLIOGRAPHY ENTRY in the document (by pressing key F9), nor closing and opening the whole document helps. BIBLIOGRAPHY ENTRY has to be deleted and inserted once more to perform changes. Current behavior: NO NEW filled item in the BIBLIOGRAPHY RECORD is SHOWN in the TABLE OF BIBLIOGRAPHY after its update. Expected behavior: Filling a new item in the BIBLIOGRAPHY RECORD caused change in the TABLE OF BIBLIOGRAPHY after update. I am not sure if it is a real bug (maybe it is just a feature) but it is really user UNfriendly mainly in huge document. Operating System: Ubuntu Version: 3.6.4.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57176] EDITING: CONDITIONAL FORMATTING not restored by UNDO
https://bugs.freedesktop.org/show_bug.cgi?id=57176 --- Comment #18 from Christopher M. Penalver christopher.m.penal...@gmail.com --- Reproducible in: Microsoft Windows Vista Business x86 6.0.6002 Service Pack 2 Build 6002 Version 4.0.0.3 (Build ID: 7545bee9c2a0782548772a21bc84a9dcc583b89) Using original reporter's attachment https://bugs.freedesktop.org/attachment.cgi?id=70378 highlight cells K4:K5 - click Delete - Undo and the Background Color of cells K4:K5 are not restored. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60233] New: SLIDESHOW: Vector graphics that looks fine in editing is very very bad in slideshow
https://bugs.freedesktop.org/show_bug.cgi?id=60233 Priority: medium Bug ID: 60233 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: SLIDESHOW: Vector graphics that looks fine in editing is very very bad in slideshow Severity: normal Classification: Unclassified OS: Linux (All) Reporter: sergio.calleg...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.0.0.3 rc Component: Presentation Product: LibreOffice Created attachment 74133 -- https://bugs.freedesktop.org/attachment.cgi?id=74133action=edit image in editing Problem description: Making presentations, you would like to use vector graphics, since this should in principle scale nicely to any resolution of the projector. Unfortunately, with libreoffice and openoffice, vector graphics may be rendered very very badly in slideshow. Which is strange, since they look perfect at any scale factor while editing the presentation. This is a true issue: you should not need to apologize for the picture quality when delivering presentations with libreoffice. Whenever you do, you are implicitly passing to all your audience the message that using libreoffice was a bad choice. Maybe this has to do with antialiasing in presentations. However, things, at least with reference to svg, have very much worsened with 4.0. Steps to reproduce: 1. open an empty presentation 2. insert an svg image 3. look at the image while editing the presentation. It is OK. 4. start the slideshow 5. look at the image now and get depressed Current behavior: svg, or anyway vector image may look very bad in slideshow Expected behavior: svg and vector graphics should be shiny good in slideshow As an example, look at the two attachments. Image in editing and in slideshow. The latter is very bad. Operating System: Ubuntu Version: 4.0.0.3 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60234] New: EDITING: embedded bmp object not shown
https://bugs.freedesktop.org/show_bug.cgi?id=60234 Priority: medium Bug ID: 60234 Keywords: regression Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: embedded bmp object not shown Severity: normal Classification: Unclassified OS: Windows (All) Reporter: walburg.fr...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.0.0.3 rc Component: Writer Product: LibreOffice Created attachment 74134 -- https://bugs.freedesktop.org/attachment.cgi?id=74134action=edit Testdocument with bmp and gif objects Problem description: Steps to reproduce: 1. in LibO 3.5.6 I inserted a bmp and a gif object into the document 2. when opening with LibO starting from version 4.0.0.1 to 4.0.0.3, the git object was shown correctly, the bmp object was just shown using a symbol Current behavior: wrong display of bmp objects Expected behavior: bmp objects should be shown correcly Operating System: Windows 8 Version: 4.0.0.3 rc Last worked in: 3.6.5.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60233] SLIDESHOW: Vector graphics that looks fine in editing is very very bad in slideshow
https://bugs.freedesktop.org/show_bug.cgi?id=60233 --- Comment #1 from sergio.calleg...@gmail.com --- Created attachment 74135 -- https://bugs.freedesktop.org/attachment.cgi?id=74135action=edit image in slideshow -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60233] SLIDESHOW: Vector graphics that looks fine in editing is very very bad in slideshow
https://bugs.freedesktop.org/show_bug.cgi?id=60233 --- Comment #2 from sergio.calleg...@gmail.com --- Quality appears to be similarly bad in openoffice 3.4.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60234] EDITING: embedded bmp object not shown
https://bugs.freedesktop.org/show_bug.cgi?id=60234 --- Comment #1 from walburg.fr...@gmail.com --- Created attachment 74137 -- https://bugs.freedesktop.org/attachment.cgi?id=74137action=edit used bmp object -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs