date:20130222

Re: Easyhack: Removing some unused functions

2013-02-22 Thread Tor Lillqvist

> I'm a new contributor.

Welcome!

> I've attached the patch file which was based
> off of master in the git repo.

Thanks. I am verifying it but it looks fine.

One small detail: Please keep the commit comment lines under 80
columns. Not sure if there is any technical reason for this, but it's
our convention.

> there were an obscene amount of warnings (Mac OSX 10.8.2).

Were those in the bundled 3rd-party libraries (like icu, nss, etc) or
in LibreOffice's own code? Our own code is supposed to be warning-free
with most current compilers (except a few separately handled places,
where we use #pragmas or options to make warnings non-fatal, or go
away). It is a good idea to configure your build with --enable-werror;
then the -Werror flag will be used when compiling LO's own code, and
any warnings will cause the build to stop.

> code is contributed under the LGPLv3+ / MPL

Ah OK. It might be easiest to give a blanket statement about past and
future contributions instead of remembering to say this with each
change,

Also, nowadays it is easier (we hope) to submit and review/accept
changes through gerrit instead of email. See
https://wiki.documentfoundation.org/Development/gerrit . (I hope that
is the relevant wiki page...)

Cheers,
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need help regarding GSOC...

2013-02-22 Thread Daniel Bankston


On 02/22/2013 06:35 AM, Sujay m wrote:
I want to contribute to open source software world through GSOC - 2013 
and want to contribute to libreoffice... I am not an amazing 
programmer but want learn more in this field... I am having an idea 
but not sure where or with whom i must discuss it with... I would like 
to discuss it with the libreoffice mentors but not sure which is right 
portal..so if you could guide me it'll be really helpfull..Thank you.. 


Hi, Sujay,

Read the LibreOffice GSOC page if you haven't already (link below). I 
recommend hanging around on #libreoffice-dev on irc.freenode.net and 
browsing the mailing list traffic to help get a feel for the community.  
Don't be afraid to ask questions on #libreoffice-dev or mailing list.  
(Just be patient and polite.)

https://wiki.documentfoundation.org/Development/GSoc
http://freenode.net

Like Fridrich said, check out the EasyHacks and submit a patch. This 
will help get you familiar with things like obtaining, building, and 
navigating the source code and also with using git.

https://wiki.documentfoundation.org/Development/Easy_Hacks
https://wiki.documentfoundation.org/Development/Native_Build
https://wiki.documentfoundation.org/Development

There are some GSOC project ideas along with associated mentor(s) on the 
GSOC ideas page.  Find an area that interests you and contact that mentor.

https://wiki.documentfoundation.org/Development/Gsoc/Ideas

I was a GSOC student last summer and had a great experience.  The 
community is very welcoming and helpful to newcomers who seriously want 
to contribute.  While working on LibreOffice, I learned a lot of 
relevant software development lessons, met some great people, and had fun.


Good luck!
--Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Easyhack: Removing some unused functions

2013-02-22 Thread Martin Brown

Hi,

I'm a new contributor.  I elected to do a small portion of the easy hack of
eliminating unused functions.  I've attached the patch file which was based
off of master in the git repo.  I think I was able to successfully build
(the longest build of my life..) the project, although over the course of
the build there were an obscene amount of warnings (Mac OSX 10.8.2).  I may
start looking into those next.

Thanks,
Martin

code is contributed under the LGPLv3+ / MPL


0001-Removing-unused-preprocessor-defined-functions-in-th.patch
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/source

2013-02-22 Thread Eike Rathke

 sc/source/ui/dbgui/scuiasciiopt.cxx |2 ++
 sc/source/ui/docshell/impex.cxx |   19 +++
 sc/source/ui/inc/impex.hxx  |2 ++
 3 files changed, 23 insertions(+)

New commits:
commit 4a2b187503de7425150528faab568e520bd2474f
Author: Eike Rathke 
Date:   Fri Feb 22 00:27:26 2013 +0100

resolved fdo#57841 ignore embedded NULL characters in CSV import

Change-Id: Ib0eb044f009227c0aa6e1bc520905d605323c3db
(cherry picked from commit 8970e14d7494859c6079ef2a976416598823ba50)
Reviewed-on: https://gerrit.libreoffice.org/2336
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx 
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index d39c258..54d5e92 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -540,6 +540,8 @@ bool ScImportAsciiDlg::GetLine( sal_uLong nLine, 
rtl::OUString &rText )
 if ( mpDatStream->GetError() == ERRCODE_IO_CANTSEEK )
 mpDatStream->ResetError();
 
+ScImportExport::EmbeddedNullTreatment( rText);
+
 return bRet;
 }
 
diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 09ec1cd..9734f72 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -1335,6 +1335,8 @@ bool ScImportExport::ExtText2Doc( SvStream& rStrm )
 if ( rStrm.IsEof() && aLine.isEmpty() )
 break;
 
+EmbeddedNullTreatment( aLine);
+
 sal_Int32 nLineLen = aLine.getLength();
 SCCOL nCol = nStartCol;
 bool bMultiLine = false;
@@ -1478,6 +1480,23 @@ bool ScImportExport::ExtText2Doc( SvStream& rStrm )
 }
 
 
+void ScImportExport::EmbeddedNullTreatment( OUString & rStr )
+{
+// A nasty workaround for data with embedded NULL characters. As long as we
+// can't handle them properly as cell content (things assume 0-terminated
+// strings at too many places) simply strip all NULL characters from raw
+// data. Excel does the same. See fdo#57841 for sample data.
+
+// The normal case is no embedded NULL, check first before de-/allocating
+// ustring stuff.
+sal_Unicode cNull = 0;
+if (rStr.indexOf( cNull) >= 0)
+{
+rStr = rStr.replaceAll( OUString( &cNull, 1), OUString());
+}
+}
+
+
 const sal_Unicode* ScImportExport::ScanNextFieldFromString( const sal_Unicode* 
p,
 String& rField, sal_Unicode cStr, const sal_Unicode* pSeps, bool 
bMergeSeps, bool& rbIsQuoted,
 bool& rbOverflowCell )
diff --git a/sc/source/ui/inc/impex.hxx b/sc/source/ui/inc/impex.hxx
index c427206..8c7e36b 100644
--- a/sc/source/ui/inc/impex.hxx
+++ b/sc/source/ui/inc/impex.hxx
@@ -102,6 +102,8 @@ public:
 bool IsUndo() const  { return bUndo; }
 void SetUndo( bool b )   { bUndo = b;}
 
+SC_DLLPUBLIC static void EmbeddedNullTreatment( OUString & rStr );
+
 static bool  IsFormatSupported( sal_uLong nFormat );
 static const sal_Unicode* ScanNextFieldFromString( const sal_Unicode* p,
 String& rField, sal_Unicode cStr, const sal_Unicode* pSeps,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

hello and introduction

2013-02-22 Thread Jonathan Nadeau

Hello list,

My name is Jonathan Nadeau and I'm the executive director of the
Accessible Computing Foundation located here

http://www.accessiblecomputingfoundation.org

I'm looking to fund some developers to fix some accessibility bugs with
Libreoffice and the Orca screen reader. I was hoping either someone on
the list would be interested in fixing some bugs or that the list might
know of some people that would like to earn some money to fix some bugs.
Please let me know if this is not the right place to look for help or if
there are any other suggestions. Thanks for your time and help. 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 2 commits - connectivity/source default_images/framework default_images/introabout odk/docs ooo_custom_images/dev ooo_custom_images/dev_nologo ooo_

2013-02-22 Thread Yuri Dario

 connectivity/source/drivers/mysql/makefile.mk  |4 
 connectivity/source/drivers/odbc/makefile.mk   |4 
 default_images/framework/res/backing.png   |binary
 default_images/framework/res/backing_hc.png|binary
 default_images/introabout/about.png|binary
 default_images/introabout/intro.png|binary
 odk/docs/images/sdk_head-1.png |binary
 ooo_custom_images/dev/introabout/intro.png |binary
 ooo_custom_images/dev_nologo/introabout/intro.png  |binary
 ooo_custom_images/nologo/introabout/intro.png  |binary
 scp2/source/ooo/file_library_ooo.scp   |5 +
 scp2/source/sdkoo/sdkoo.scp|2 +-
 setup_native/source/mac/ooo/DS_Store   |binary
 setup_native/source/mac/ooo/DS_Store_Dev   |binary
 setup_native/source/mac/ooo/DS_Store_Langpack  |binary
 setup_native/source/mac/ooo/osxdndinstall.png  |binary
 setup_native/source/mac/ooo/osxdndinstall_lang.png |binary
 setup_native/source/mac/sdk/DS_Store_SDK   |binary
 setup_native/source/mac/sdk/osxdndinstall_sdk.png  |binary
 setup_native/source/win32/nsis/ooobitmap.bmp   |binary
 20 files changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 94d5f922c421c4def290dbdbcc16cc842ac510f0
Author: Yuri Dario 
Date:   Fri Feb 22 17:12:01 2013 +

i118923 - OS/2 port: use short names for mysql&odbc libraries.

diff --git a/connectivity/source/drivers/mysql/makefile.mk 
b/connectivity/source/drivers/mysql/makefile.mk
index e6509b9..1664bbb 100644
--- a/connectivity/source/drivers/mysql/makefile.mk
+++ b/connectivity/source/drivers/mysql/makefile.mk
@@ -55,7 +55,11 @@ SHL1VERSIONMAP=$(SOLARENV)/src/component.map
 
 # --- Library ---
 
+.IF "$(GUI)" == "OS2"
+REALNAME:=$(MYSQL_TARGET)
+.ELSE
 REALNAME:=$(MYSQL_TARGET).uno
+.ENDIF
 SHL1TARGET=$(REALNAME)$(DLLPOSTFIX)
 SHL1OBJS=$(SLOFILES)
 SHL1STDLIBS=\
diff --git a/connectivity/source/drivers/odbc/makefile.mk 
b/connectivity/source/drivers/odbc/makefile.mk
index dca329e..b03859b 100644
--- a/connectivity/source/drivers/odbc/makefile.mk
+++ b/connectivity/source/drivers/odbc/makefile.mk
@@ -55,7 +55,11 @@ SLOFILES=\
 # --- ODBC Library ---
 
 
+.IF "$(GUI)" == "OS2"
+REALNAME:=$(ODBC_TARGET)
+.ELSE
 REALNAME:=$(ODBC_TARGET).uno
+.ENDIF
 SHL1TARGET=$(REALNAME)$(DLLPOSTFIX)
 SHL1OBJS=$(SLOFILES)
 SHL1STDLIBS=\
diff --git a/scp2/source/ooo/file_library_ooo.scp 
b/scp2/source/ooo/file_library_ooo.scp
index 97374ee..0299e35 100644
--- a/scp2/source/ooo/file_library_ooo.scp
+++ b/scp2/source/ooo/file_library_ooo.scp
@@ -1058,8 +1058,13 @@ End
 #endif
 #endif
 
+#if defined(OS2)
+STD_LIB_FILE(gid_File_Lib_Mysql,mysql)
+STD_LIB_FILE(gid_File_Lib_Odbc,odbc)
+#else
 STD_LIB_FILE(gid_File_Lib_Mysql,mysql.uno)
 STD_LIB_FILE(gid_File_Lib_Odbc,odbc.uno)
+#endif
 
 // STD_LIB_FILE( gid_File_Lib_Ofa , ofa)
 
commit b2980674b683a426a019ba475276f1fa4f52aa15
Author: JÃ¼rgen Schmidt 
Date:   Fri Feb 22 15:24:18 2013 +

#121388# add temporary adapted images for installer, intro, about

diff --git a/default_images/framework/res/backing.png 
b/default_images/framework/res/backing.png
index 44b6490..0f118ba 100644
Binary files a/default_images/framework/res/backing.png and 
b/default_images/framework/res/backing.png differ
diff --git a/default_images/framework/res/backing_hc.png 
b/default_images/framework/res/backing_hc.png
index cff04e5..1a4b8d0 100644
Binary files a/default_images/framework/res/backing_hc.png and 
b/default_images/framework/res/backing_hc.png differ
diff --git a/default_images/introabout/about.png 
b/default_images/introabout/about.png
index 12f9582..fb8f41c 100755
Binary files a/default_images/introabout/about.png and 
b/default_images/introabout/about.png differ
diff --git a/default_images/introabout/intro.png 
b/default_images/introabout/intro.png
index b635cc8..db31876 100755
Binary files a/default_images/introabout/intro.png and 
b/default_images/introabout/intro.png differ
diff --git a/odk/docs/images/sdk_head-1.png b/odk/docs/images/sdk_head-1.png
index 91f65b5..3dd9b1d 100644
Binary files a/odk/docs/images/sdk_head-1.png and 
b/odk/docs/images/sdk_head-1.png differ
diff --git a/ooo_custom_images/dev/introabout/intro.png 
b/ooo_custom_images/dev/introabout/intro.png
index 33c8ccb..c2975f0 100755
Binary files a/ooo_custom_images/dev/introabout/intro.png and 
b/ooo_custom_images/dev/introabout/intro.png differ
diff --git a/ooo_custom_images/dev_nologo/introabout/intro.png 
b/ooo_custom_images/dev_nologo/introabout/intro.png
index 33c8ccb..5b5 100755
Binary files a/ooo_custom_images/dev_nologo/introabout/intro.png and 
b/ooo_custom_images/dev_nologo/introabout/intro.png differ
diff --git a/ooo_custom_images/nologo/introabout/intro.png 
b/ooo_custom_images/nologo/introabout/intro.png
index b635cc8..36f34bb 100755
Binary files a/ooo_custom_images/nologo/introabout/i

[ANN] LibreOffice 4.0.1 RC1 available

2013-02-22 Thread Thorsten Behrens

Dear Community,

The Document Foundation is pleased to announce the first release
candidate of our upcoming LibreOffice 4.0.1. This will be the first in
a series of frequent updates to our feature-packed 4.0 branch. Please
be aware that LibreOffice 4.0.1 RC1 is not ready for production use,
you should continue to use LibreOffice 4.0.0 for that.

The release is available for Windows, Linux and Mac OS X from our QA
builds download page at

  http://www.libreoffice.org/download/pre-releases/

Should you find bugs, please report them to the FreeDesktop Bugzilla:

  https://bugs.freedesktop.org

A good way to assess the release candidate quality is to run some
specific manual tests on it, our TCM wiki page has more details:

 
http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test

  - or checkout our manual test database for starting right away -

 http://manual-test.libreoffice.org/runtests/

With this release candidate, the Android Impress Remote should work on
all platforms - if you would like to test, an updated Android package
is available here:

 
http://downloadarchive.documentfoundation.org/libreoffice/old/sdremote-1.0.3/playstore/ImpressRemote.apk
 
 (and note https://wiki.documentfoundation.org/Development/Impress/RemoteHowTo)

For other ways to get involved with this exciting project - you can
e.g. contribute code:

  http://www.libreoffice.org/get-involved/developers/

translate LibreOffice to your language:

  http://wiki.documentfoundation.org/LibreOffice_Localization_Guide

or help with funding our operations:

  http://donate.libreoffice.org/

A list of known issues and fixed bugs with 4.0.1 RC1 is available
from our wiki:

  http://wiki.documentfoundation.org/Releases/4.0.1/RC1

Let us close again with a BIG Thank You! to all of you having
contributed to the LibreOffice project - this release would not have
been possible without your help.

Yours,

The Document Foundation Board of Directors

The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany
Rechtsfähige Stiftung des bürgerlichen Rechts
Legal details: http://www.documentfoundation.org/imprint


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] instsetoo_native: convert to gbuild

2013-02-22 Thread Peter Foley (via Code Review)

Hello LibreOffice gerrit bot, Matúš Kukan,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2242

to look at the new patch set (#7).

Change subject: instsetoo_native: convert to gbuild
..

instsetoo_native: convert to gbuild

Removes:
 * instsetoo_native/util/update.xml
  - gen_update_info.pl can be removed ?

  On Windows the binary artifacts are created now in:
  workdir/*/installation/LibreOffice_Dev/native/install/en-US/*.msi

Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
---
M Makefile.in
A instsetoo_native/CustomTarget_install.mk
A instsetoo_native/Makefile
A instsetoo_native/Module_instsetoo_native.mk
M instsetoo_native/README
R instsetoo_native/inc_common/windows/msi_templates/Binary/Banner.bmp
R instsetoo_native/inc_common/windows/msi_templates/Binary/Image.bmp
D instsetoo_native/inc_openoffice/unix/makefile.mk
D instsetoo_native/inc_openoffice/windows/msi_languages/makefile.mk
D instsetoo_native/prj/build.lst
D instsetoo_native/prj/d.lst
D instsetoo_native/prj/dmake
D instsetoo_native/util/makefile.mk
D instsetoo_native/util/update.xml
M scp2/source/python/file_python.scp
15 files changed, 161 insertions(+), 513 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/2242/7
-- 
To view, visit https://gerrit.libreoffice.org/2242
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1c82ea9cb9d297cdd0e4f4b9b44606259d49
Gerrit-PatchSet: 7
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Matúš Kukan 
Gerrit-Reviewer: David Ostrovsky 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Matúš Kukan 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Peter Foley 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sal/android sal/inc sal/Package_inc.mk vcl/android vcl/inc vcl/source

2013-02-22 Thread Tor Lillqvist

 sal/Package_inc.mk   |1 
 sal/android/android_native_app_glue.c|  460 ---
 sal/android/lo-bootstrap.c   |  124 ---
 sal/inc/osl/detail/android-bootstrap.h   |2 
 sal/inc/osl/detail/android_native_app_glue.h |  351 
 vcl/android/androidinst.cxx  |   64 ++-
 vcl/inc/android/androidinst.hxx  |1 
 vcl/source/window/dialog.cxx |8 
 8 files changed, 47 insertions(+), 964 deletions(-)

New commits:
commit d372af0897f528a6f5a687e4872dee91df95fec5
Author: Tor Lillqvist 
Date:   Sat Feb 23 00:28:36 2013 +0200

No NativeActivity, so native_app_glue and struct android_app are meaningless

Leave the NativeActivity-related code in androidinst.cxx for reference for
now.

Change-Id: I760c02ea361361be2d2b69c4cad1e38311f51247

diff --git a/sal/Package_inc.mk b/sal/Package_inc.mk
index 0b78afd..15fb477 100644
--- a/sal/Package_inc.mk
+++ b/sal/Package_inc.mk
@@ -61,7 +61,6 @@ $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/thread.hxx,osl/thread.hxx))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/time.h,osl/time.h))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/util.h,osl/util.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/file.h,osl/detail/file.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android_native_app_glue.h,osl/detail/android_native_app_glue.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android-bootstrap.h,osl/detail/android-bootstrap.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/ios-bootstrap.h,osl/detail/ios-bootstrap.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/component-mapping.h,osl/detail/component-mapping.h))
diff --git a/sal/android/android_native_app_glue.c 
b/sal/android/android_native_app_glue.c
deleted file mode 100644
index e419c3d..000
--- a/sal/android/android_native_app_glue.c
+++ /dev/null
@@ -1,460 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Copyright (C) 2010 The Android Open Source Project
- *
- *   Licensed under the Apache License, Version 2.0 (the "License");
- *   you may not use this file except in compliance with the License.
- *   You may obtain a copy of the License at
- *  http://www.apache.org/licenses/LICENSE-2.0
- */
-
-#include 
-
-#include 
-#include 
-#include 
-#include 
-
-#include "osl/detail/android-bootstrap.h"
-#include "osl/detail/android_native_app_glue.h"
-#include 
-
-#define LOGI(...) ((void)__android_log_print(ANDROID_LOG_INFO, "lo-bootstrap", 
__VA_ARGS__))
-
-static void free_saved_state(struct android_app* android_app) {
-pthread_mutex_lock(&android_app->mutex);
-if (android_app->savedState != NULL) {
-free(android_app->savedState);
-android_app->savedState = NULL;
-android_app->savedStateSize = 0;
-}
-pthread_mutex_unlock(&android_app->mutex);
-}
-
-int8_t android_app_read_cmd(struct android_app* android_app) {
-int8_t cmd;
-if (read(android_app->msgread, &cmd, sizeof(cmd)) == sizeof(cmd)) {
-switch (cmd) {
-case APP_CMD_SAVE_STATE:
-free_saved_state(android_app);
-break;
-}
-return cmd;
-} else {
-LOGI("No data on command pipe!");
-}
-return -1;
-}
-
-static void print_cur_config(struct android_app* android_app) {
-char lang[2], country[2];
-AConfiguration_getLanguage(android_app->config, lang);
-AConfiguration_getCountry(android_app->config, country);
-
-LOGI("Config: mcc=%d mnc=%d lang=%c%c cnt=%c%c orien=%d touch=%d dens=%d "
-"keys=%d nav=%d keysHid=%d navHid=%d sdk=%d size=%d long=%d "
-"modetype=%d modenight=%d",
-AConfiguration_getMcc(android_app->config),
-AConfiguration_getMnc(android_app->config),
-lang[0], lang[1], country[0], country[1],
-AConfiguration_getOrientation(android_app->config),
-AConfiguration_getTouchscreen(android_app->config),
-AConfiguration_getDensity(android_app->config),
-AConfiguration_getKeyboard(android_app->config),
-AConfiguration_getNavigation(android_app->config),
-AConfiguration_getKeysHidden(android_app->config),
-AConfiguration_getNavHidden(android_app->config),
-AConfiguration_getSdkVersion(android_app->config),
-AConfiguration_getScreenSize(android_app->config),
-AConfiguration_getScreenLong(android_app->config),
-AConfiguration_getUiModeType(android_app->config),
-AConfiguration_g

Re: [libreoffice-accessibility] introduction

2013-02-22 Thread Jonathan Nadeau

Thank you can you give me a link to join the developers list? Thanks


On 02/22/2013 03:29 AM, Sophie Gautier wrote:
> Hi Jonathan,
>
> Thanks a lot for your proposal. I'm sending your mail to the developers
> list so we are sure they are aware of it.
>
> Kind regards
> Sophie
> On 21/02/2013 23:33, Jonathan Nadeau wrote:
>> Hello list,
>>
>> My name is Jonathan Nadeau and I'm the executive director of the
>> Accessible Computing Foundation located here
>>
>> http://www.accessiblecomputingfoundation.org
>>
>> I'm looking to fund some developers to fix some accessibility bugs with
>> Libreoffice and the Orca screen reader. I was hoping either someone on
>> the list would be interested in fixing some bugs or that the list might
>> know of some people that would like to earn some money to fix some bugs.
>> Please let me know if this is not the right place to look for help or if
>> there are any other suggestions. Thanks for your time and help.
>>
>

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: desktop/Library_sofficeapp.mk sal/inc sal/Library_sal.mk sal/Module_sal.mk sal/osl vcl/Module_vcl.mk

2013-02-22 Thread Tor Lillqvist

 desktop/Library_sofficeapp.mk |9 -
 sal/Library_sal.mk|2 +-
 sal/Module_sal.mk |8 ++--
 sal/inc/sal/main.h|   20 +---
 sal/osl/unx/process_impl.cxx  |   24 
 vcl/Module_vcl.mk |5 +++--
 6 files changed, 15 insertions(+), 53 deletions(-)

New commits:
commit fd56eb98e63b4aac12c9633d5847a3fb964f326d
Author: Tor Lillqvist 
Date:   Fri Feb 22 23:19:22 2013 +0200

Not using NativeActivity means no lo_main() stuff used either

Hopefully also fixes build for iOS by re-introducing checks for DESKTOP.

Also this commit partially reverts 52a8744afee2cd589813f0377d93f821fce7aedd.

Change-Id: Ie94c771b72ba138bb0481b054285916618baf6eb

diff --git a/desktop/Library_sofficeapp.mk b/desktop/Library_sofficeapp.mk
index 4687b5d..2a635b5 100644
--- a/desktop/Library_sofficeapp.mk
+++ b/desktop/Library_sofficeapp.mk
@@ -94,13 +94,4 @@ ifeq ($(ENABLE_TELEPATHY),TRUE)
 $(eval $(call gb_Library_use_libraries,sofficeapp,tubes))
 endif
 
-#
-# We need the lo_main symbol for our boostrap loader
-#
-ifeq ($(OS),ANDROID)
-$(eval $(call gb_Library_add_cobjects,sofficeapp,\
-desktop/source/app/main \
-))
-endif
-
 # vim: set ts=4 sw=4 et:
diff --git a/sal/Library_sal.mk b/sal/Library_sal.mk
index 1d88460..62f9ce3 100644
--- a/sal/Library_sal.mk
+++ b/sal/Library_sal.mk
@@ -181,7 +181,7 @@ $(eval $(call gb_Library_add_exception_objects,sal,\
sal/osl/unx/module \
sal/osl/unx/process \
sal/osl/unx/process_impl \
-   sal/osl/unx/salinit \
+$(if $(filter DESKTOP,$(BUILD_TYPE)), sal/osl/unx/salinit) \
sal/osl/unx/uunxapi \
 ))
 $(eval $(call gb_Library_add_cobjects,sal,\
diff --git a/sal/Module_sal.mk b/sal/Module_sal.mk
index af97e48..7d20fa3 100644
--- a/sal/Module_sal.mk
+++ b/sal/Module_sal.mk
@@ -31,7 +31,8 @@ $(eval $(call gb_Module_Module,sal))
 $(eval $(call gb_Module_add_targets,sal,\
CustomTarget_generated \
CustomTarget_sal_allheaders \
-   Executable_cppunittester \
+   $(if $(filter DESKTOP,$(BUILD_TYPE)), \
+   Executable_cppunittester) \
$(if $(filter $(OS),ANDROID), \
Library_lo-bootstrap) \
Library_sal \
@@ -45,13 +46,14 @@ $(eval $(call gb_Module_add_targets,sal,\
 ))
 
 ifneq (,$(filter DESKTOP,$(BUILD_TYPE)))
+
 $(eval $(call gb_Module_add_targets,sal,\
Executable_osl_process_child \
 ))
+
 $(eval $(call gb_Module_add_check_targets,sal,\
CppunitTest_sal_osl_process \
 ))
-endif
 
 $(eval $(call gb_Module_add_check_targets,sal,\
$(if $(filter TRUE,$(DISABLE_DYNLOADING)),,CppunitTest_Module_DLL) \
@@ -88,6 +90,8 @@ $(eval $(call gb_Module_add_check_targets,sal,\
CppunitTest_sal_rtl_math \
 ))
 
+endif
+
 # CppunitTest_sal_osl_pipe has circular dependency on unotest
 # $(eval $(call gb_Module_add_subsequentcheck_targets,sal,\
CppunitTest_sal_osl_pipe \
diff --git a/sal/inc/sal/main.h b/sal/inc/sal/main.h
index 7cdc9bc..8648e38 100644
--- a/sal/inc/sal/main.h
+++ b/sal/inc/sal/main.h
@@ -38,25 +38,7 @@ SAL_DLLPUBLIC void SAL_CALL sal_detail_deinitialize();
 
 #if defined IOS || defined ANDROID
 
-#ifdef __cplusplus
-extern "C" SAL_DLLPUBLIC_EXPORT void lo_main(int argc, char **argv);
-#endif
-
-#define SAL_MAIN_WITH_ARGS_IMPL \
-SAL_DLLPUBLIC_EXPORT void lo_main(int argc, char **argv) \
-{ \
-sal_detail_initialize(argc, argv); \
-sal_main_with_args(argc, argv); \
-sal_detail_deinitialize(); \
-}
-
-#define SAL_MAIN_IMPL \
-SAL_DLLPUBLIC_EXPORT void lo_main(int argc, char **argv) \
-{ \
-sal_detail_initialize(argc, argv); \
-sal_main(); \
-sal_detail_deinitialize(); \
-}
+#error No code that includes this should be built for iOS or Android
 
 #else
 
diff --git a/sal/osl/unx/process_impl.cxx b/sal/osl/unx/process_impl.cxx
index 4a10af5..723d10b 100644
--- a/sal/osl/unx/process_impl.cxx
+++ b/sal/osl/unx/process_impl.cxx
@@ -104,26 +104,10 @@ oslProcessError SAL_CALL 
osl_bootstrap_getExecutableFile_Impl (
 {
 oslProcessError result = osl_Process_E_NotFound;
 
-#if defined(ANDROID) && !defined(DISABLE_DYNLOADING)
-/* On Android we in theory want the address of the "lo_main()"
- * function, as that is what corresponds to "main()" in
- * LibreOffice programs on normal desktop OSes.
- *
- * But that is true only for apps with a "native activity", using
- *  and the org.libreoffice.android.Bootstrap
- * mechanism. For more normal (?) Android apps that just use
- * LibreOffice libraries (components) where the main program is in
- * Java, that just use LibreOffice libraries, there is no
- * lo_main(). (Note that we don't know for sure yet how
- * complicated it might be to write such Android apps...)
- *
- * Maybe best to just pick some function in liblo-bootstrap.so
- * which also such Java apps *must* load as the very first
- * LibreO

[PATCH] convert odk to gbuild and add to tail_build

2013-02-22 Thread Peter Foley (via Code Review)

Hello LibreOffice gerrit bot, David Ostrovsky,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/2288

to look at the new rebased patch set (#11).

Change subject: convert odk to gbuild and add to tail_build
..

convert odk to gbuild and add to tail_build

Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
---
M Module_tail_build.mk
M Repository.mk
M RepositoryModule_ooo.mk
A odk/CustomTarget_autodoc.mk
A odk/CustomTarget_bin.mk
A odk/CustomTarget_check.mk
A odk/CustomTarget_classes.mk
A odk/CustomTarget_cli.mk
A odk/CustomTarget_doxygen.mk
A odk/CustomTarget_idl.mk
A odk/CustomTarget_include.mk
A odk/CustomTarget_javadoc.mk
A odk/CustomTarget_lib.mk
A odk/CustomTarget_odkcommon.mk
A odk/CustomTarget_settings.mk
A odk/CustomTarget_unowinreg.mk
A odk/Executable_unoapploader.mk
A odk/Library_unowinreg.mk
A odk/Makefile
A odk/Module_odk.mk
A odk/Zip_odkcommon.mk
A odk/Zip_odkexamples.mk
A odk/Zip_uno_loader_classes.mk
R odk/config/cfgWin.js
R odk/config/configure.pl
R odk/config/setsdkenv_unix
R odk/config/setsdkenv_unix.csh.in
R odk/config/setsdkenv_unix.sh.in
R odk/config/setsdkenv_windows.bat
R odk/config/setsdkenv_windows.template
R odk/config/setsdkname.bat
D odk/inc/makefile.mk
D odk/pack/checkbin/makefile.mk
D odk/pack/checkidl/makefile.mk
D odk/pack/checkinc/makefile.mk
D odk/pack/checkinc2/makefile.mk
D odk/pack/copying/makefile.mk
D odk/pack/gendocu/makefile.mk
D odk/pack/unzip_udk/deltree.txt
D odk/pack/unzip_udk/makefile.mk
M odk/prj/build.lst
M odk/prj/d.lst
D odk/prj/dmake
D odk/source/com/sun/star/lib/loader/makefile.mk
D odk/source/unoapploader/unx/makefile.mk
D odk/source/unoapploader/win/makefile.mk
D odk/source/unowinreg/win/makefile.mk
A odk/source/unowinreg/win/unowinreg.def
D odk/source/unowinreg/win/unowinreg.dxp
D odk/util/delzip
D odk/util/makefile.mk
D odk/util/makefile.pmk
D odk/util/odk_rules.pmk
M postprocess/prj/build.lst
M solenv/gbuild/Zip.mk
55 files changed, 980 insertions(+), 1,468 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2288/11
-- 
To view, visit https://gerrit.libreoffice.org/2288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
Gerrit-PatchSet: 11
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley 
Gerrit-Reviewer: David Ostrovsky 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Peter Foley 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] convert odk to gbuild and add to tail_build

2013-02-22 Thread Peter Foley (via Code Review)

Hello LibreOffice gerrit bot, David Ostrovsky,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/2288

to look at the new patch set (#10).

Change subject: convert odk to gbuild and add to tail_build
..

convert odk to gbuild and add to tail_build

Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
---
M Module_tail_build.mk
M Repository.mk
M RepositoryModule_ooo.mk
A odk/CustomTarget_autodoc.mk
A odk/CustomTarget_bin.mk
A odk/CustomTarget_check.mk
A odk/CustomTarget_classes.mk
A odk/CustomTarget_cli.mk
A odk/CustomTarget_doxygen.mk
A odk/CustomTarget_idl.mk
A odk/CustomTarget_include.mk
A odk/CustomTarget_javadoc.mk
A odk/CustomTarget_lib.mk
A odk/CustomTarget_odkcommon.mk
A odk/CustomTarget_settings.mk
A odk/CustomTarget_unowinreg.mk
A odk/Executable_unoapploader.mk
A odk/Library_unowinreg.mk
A odk/Makefile
A odk/Module_odk.mk
A odk/Zip_odkcommon.mk
A odk/Zip_odkexamples.mk
A odk/Zip_uno_loader_classes.mk
R odk/config/cfgWin.js
R odk/config/configure.pl
R odk/config/setsdkenv_unix
R odk/config/setsdkenv_unix.csh.in
R odk/config/setsdkenv_unix.sh.in
R odk/config/setsdkenv_windows.bat
R odk/config/setsdkenv_windows.template
R odk/config/setsdkname.bat
D odk/inc/makefile.mk
D odk/pack/checkbin/makefile.mk
D odk/pack/checkidl/makefile.mk
D odk/pack/checkinc/makefile.mk
D odk/pack/checkinc2/makefile.mk
D odk/pack/copying/makefile.mk
D odk/pack/gendocu/makefile.mk
D odk/pack/unzip_udk/deltree.txt
D odk/pack/unzip_udk/makefile.mk
M odk/prj/build.lst
M odk/prj/d.lst
D odk/prj/dmake
D odk/source/com/sun/star/lib/loader/makefile.mk
D odk/source/unoapploader/unx/makefile.mk
D odk/source/unoapploader/win/makefile.mk
D odk/source/unowinreg/win/makefile.mk
A odk/source/unowinreg/win/unowinreg.def
D odk/source/unowinreg/win/unowinreg.dxp
D odk/util/delzip
D odk/util/makefile.mk
D odk/util/makefile.pmk
D odk/util/odk_rules.pmk
M postprocess/prj/build.lst
M solenv/gbuild/Zip.mk
55 files changed, 980 insertions(+), 1,468 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/2288/10
-- 
To view, visit https://gerrit.libreoffice.org/2288
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e8de7f2bb87cce7916c7c2df24c1b0ddaea55c0
Gerrit-PatchSet: 10
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Peter Foley 
Gerrit-Reviewer: David Ostrovsky 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Michael Stahl 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Peter Foley 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - sal/inc sdext/source

2013-02-22 Thread Miklos Vajna

 sal/inc/sal/log-areas.dox  |1 +
 sdext/source/minimizer/optimizerdialog.cxx |1 -
 sdext/source/minimizer/pppoptimizerdialog.cxx  |2 +-
 sdext/source/pdfimport/tree/drawtreevisiting.cxx   |4 
 sdext/source/pdfimport/tree/pdfiprocessor.cxx  |2 --
 sdext/source/pdfimport/tree/writertreevisiting.cxx |1 -
 sdext/source/pdfimport/wrapper/wrapper.cxx |2 +-
 sdext/source/presenter/PresenterSlideShowView.cxx  |2 +-
 8 files changed, 4 insertions(+), 11 deletions(-)

New commits:
commit 3eaa536ae457391c3826be50b0361f8d0c13cdd3
Author: Miklos Vajna 
Date:   Fri Feb 22 21:42:13 2013 +0100

sdext: fix loplugin warnings

Change-Id: I4bca280b352f1df40fe75658e418f2e0cb2430e8

diff --git a/sdext/source/minimizer/optimizerdialog.cxx 
b/sdext/source/minimizer/optimizerdialog.cxx
index 711134f..9dcaf29 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -158,7 +158,6 @@ void OptimizerDialog::InsertRoadmapItem( const sal_Int32 
nIndex, const sal_Bool
 void OptimizerDialog::UpdateConfiguration()
 {
 sal_Int16   nInt16 = 0;
-OUStringaString;
 Any aAny;
 
 Sequence< sal_Int16 > aSelectedItems;
diff --git a/sdext/source/minimizer/pppoptimizerdialog.cxx 
b/sdext/source/minimizer/pppoptimizerdialog.cxx
index 79c8745..2f91c57 100644
--- a/sdext/source/minimizer/pppoptimizerdialog.cxx
+++ b/sdext/source/minimizer/pppoptimizerdialog.cxx
@@ -147,7 +147,7 @@ void SAL_CALL PPPOptimizerDialog::dispatch( const URL& rURL,
 sBuf.append( rtl::OUString("KB to ") );
 sBuf.append( rtl::OUString::valueOf( nFileSizeDest >> 10 ) 
);
 sBuf.append( rtl::OUString("KB.") );
-OUString sResult( sBuf.makeStringAndClear() );
+sBuf.makeStringAndClear();
 //  mpOptimizerDialog->showMessageBox( sResult, sResult, 
sal_False );
 }
 delete mpOptimizerDialog, mpOptimizerDialog = NULL;
diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx 
b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
index 9a38e3d..7207e43 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
@@ -1014,7 +1014,6 @@ void DrawXmlFinalizer::visit( PageElement& elem, const 
std::list< Element* >::co
 // get styles for paragraphs
 PropertyMap aPageProps;
 PropertyMap aPageLayoutProps;
-rtl::OUStringBuffer aBuf( 64 );
 aPageLayoutProps[ "fo:margin-top" ] =  unitMMString( top_margin );
 aPageLayoutProps[ "fo:margin-bottom" ]  =  unitMMString( bottom_margin );
 aPageLayoutProps[ "fo:margin-left" ]=  unitMMString( left_margin );
@@ -1040,9 +1039,6 @@ void DrawXmlFinalizer::visit( PageElement& elem, const 
std::list< Element* >::co
 
 elem.StyleId = m_rStyleContainer.impl_getStyleId( aMPStyle,false );
 
-
-rtl::OUString aMasterPageName = m_rStyleContainer.getStyleName( 
elem.StyleId );
-
 // create styles for children
 elem.applyToChildren(*this);
 }
diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx 
b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
index a457d47..56e29c0 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
@@ -466,8 +466,6 @@ GraphicsContext& PDFIProcessor::getTransformGlyphContext( 
CharGlyph& rGlyph )
 geometry::RealRectangle2D   rRect = rGlyph.getRect();
 geometry::Matrix2D  rFontMatrix = rGlyph.getFontMatrix();
 
-rtl::OUString tempStr( 32 );
-
 basegfx::B2DHomMatrix aFontMatrix;
 basegfx::unotools::homMatrixFromMatrix(
 aFontMatrix,
diff --git a/sdext/source/pdfimport/tree/writertreevisiting.cxx 
b/sdext/source/pdfimport/tree/writertreevisiting.cxx
index 7eaabe8..d907629 100644
--- a/sdext/source/pdfimport/tree/writertreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/writertreevisiting.cxx
@@ -1145,7 +1145,6 @@ void WriterXmlFinalizer::visit( PageElement& elem, const 
std::list< Element* >::
 // get styles for paragraphs
 PropertyMap aPageProps;
 PropertyMap aPageLayoutProps;
-rtl::OUStringBuffer aBuf( 64 );
 aPageLayoutProps[ "fo:page-width" ] = unitMMString( page_width );
 aPageLayoutProps[ "fo:page-height" ]= unitMMString( page_height );
 aPageLayoutProps[ "style:print-orientation" ]
diff --git a/sdext/source/pdfimport/wrapper/wrapper.cxx 
b/sdext/source/pdfimport/wrapper/wrapper.cxx
index a90ba8d..5485511 100644
--- a/sdext/source/pdfimport/wrapper/wrapper.cxx
+++ b/sdext/source/pdfimport/wrapper/wrapper.cxx
@@ -484,7 +484,7 @@ int Parser::parseFontRemoveSuffix( const sal_Unicode* 
pCopy, const char* s, sal_
 for (int i = 0; i < l; i++)
 if ( pCopy[nLen - l + i] != s[i] )
 return 0;
-nLen -= l;
+nLen -= l;
 return l;
 }
 
diff --git a/sdext/source/presenter/Pr

Re: C++ extensions requiring LIBO_UDK_4.1

2013-02-22 Thread Michael Stahl

On 22/02/13 16:41, Alex Thurgood wrote:
> Le 22/02/2013 16:30, Michael Stahl a écrit :
>>
>> it's possible that this is because it requires functions that were added
>> after the 4.0 release on master (i suspect this happens automatically
>> due to some OUString changes); for example here i'm getting a dependency
>> on LIBO_UDK_4.1 symbol version, which none of the current releases supply.
>>
> 
> Two questions, both of which may be dumb, because I don't really know 
> what is going on here, but :
> 
> Shouldn't it default to the lowest common denominator, i.e. 3.6 ?

well it's based on the symbols that are actually required but not
defined in the mysql extension library, i.e. LO/URE functions called and
misc. typeinfo/RTTI stuff.

i suspect (but haven't checked) that due to changes to the OUString
class the existing code now implicitly calls and requires different
functions that did not exist in older versions.

> Is this only a problem with symbol-enabled builds ?

the term "symbol" is quite overloaded; this is about linker symbols in
shared libraries, which may be "exported" from library A and "imported"
in library B.  has nothing to do with --enable-symbols or --enable-debug
configure options.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: android/Bootstrap

2013-02-22 Thread Tor Lillqvist

 android/Bootstrap/src/org/libreoffice/android/Bootstrap.java |  114 ---
 1 file changed, 10 insertions(+), 104 deletions(-)

New commits:
commit 388b72742ae6f93650b9a64e41a30c451dce3708
Author: Tor Lillqvist 
Date:   Fri Feb 22 22:12:43 2013 +0200

We are not using NativeActivity, nor do we plan to, IIUC

Partially revert 52a8744afee2cd589813f0377d93f821fce7aedd, i.e. once again
start to remove stuff related only to using NativeActivity... (Because it is
confusing and misleading to keep it around.) Let's do it in small pieces 
this
time.

Change-Id: Ifdc52eb0ae32c7c510418611cbf01a857a8bc697

diff --git a/android/Bootstrap/src/org/libreoffice/android/Bootstrap.java 
b/android/Bootstrap/src/org/libreoffice/android/Bootstrap.java
index 3db5844..d0f844f 100644
--- a/android/Bootstrap/src/org/libreoffice/android/Bootstrap.java
+++ b/android/Bootstrap/src/org/libreoffice/android/Bootstrap.java
@@ -29,28 +29,22 @@
 package org.libreoffice.android;
 
 import android.app.Activity;
-import android.app.NativeActivity;
 import android.content.pm.ApplicationInfo;
-import android.content.pm.PackageManager;
-import android.os.Bundle;
 import android.util.Log;
 
-import fi.iki.tml.CommandLine;
-
 import java.io.File;
 import java.io.InputStream;
 import java.nio.ByteBuffer;
 import java.util.Arrays;
-import java.util.Scanner;
-
-// We extend NativeActivity so that we can get at the intent of the
-// activity and its extra parameters, that we use to tell us what
-// actual LibreOffice "program" to run. I.e. something that on desktop
-// OSes would be a program, but for Android is actually built as a
-// shared object, with a "lo_main" function.
 
-public class Bootstrap extends NativeActivity
+// final because subclassing would be meaningless.
+public final class Bootstrap
 {
+// private constructor because instantiating would be meaningless
+private Bootstrap()
+{
+}
+
 private static String TAG = "lo-bootstrap";
 
 // Native methods in this class are all implemented in
@@ -62,9 +56,6 @@ public class Bootstrap extends NativeActivity
 String cacheDir,
 String apkFile);
 
-public static native boolean setup(Object lo_main_argument,
-   int lo_main_delay);
-
 // Extracts files in the .apk that need to be extraced into the app's tree
 static native void extract_files();
 
@@ -110,8 +101,8 @@ public class Bootstrap extends NativeActivity
 
 static boolean setup_done = false;
 
-// This setup() method is called 1) in apps that use *this* class as their 
activity from onCreate(),
-// and 2) should be called from other kinds of LO code using apps.
+// This setup() method should be called from the upper Java level of
+// LO-based apps.
 public static synchronized void setup(Activity activity)
 {
 if (setup_done)
@@ -152,92 +143,6 @@ public class Bootstrap extends NativeActivity
 putenv("TMPDIR=" + activity.getCacheDir().getAbsolutePath());
 }
 
-@Override
-protected void onCreate(Bundle savedInstanceState)
-{
-setup(this);
-
-String mainLibrary = getIntent().getStringExtra("lo-main-library");
-
-if (mainLibrary == null)
-mainLibrary = "libcppunittester";
-
-mainLibrary += ".so";
-
-Log.i(TAG, String.format("mainLibrary=%s", mainLibrary));
-
-// Get "command line" to pass to the LO "program"
-String cmdLine = getIntent().getStringExtra("lo-main-cmdline");
-
-if (cmdLine == null) {
-String indirectFile = 
getIntent().getStringExtra("lo-main-indirect-cmdline");
-if (indirectFile != null) {
-try {
-// Somewhat stupid but short way to read a file into a 
string
-cmdLine = new Scanner(new File(indirectFile), 
"UTF-8").useDelimiter("\\A").next().trim();
-}
-catch (java.io.FileNotFoundException e) {
-Log.i(TAG, String.format("Could not read %s: 
%s",indirectFile, e.toString()));
-}
-}
-
-if (cmdLine == null)
-cmdLine = "";
-}
-
-Log.i(TAG, String.format("cmdLine=%s", cmdLine));
-
-String[] argv = CommandLine.split(cmdLine);
-
-// Handle env var assignments in the command line.
-while (argv.length > 0 &&
-   argv[0].matches("[A-Z_]+=.*")) {
-putenv(argv[0]);
-argv = Arrays.copyOfRange(argv, 1, argv.length);
-}
-
-// argv[0] will be replaced by android_main() in lo-bootstrap.c by the
-// pathname of the mainLibrary.
-String[] newargv = new String[argv.length + 1];
-newargv[0] = "dummy-program-name";
-System.arraycopy(argv, 0, newargv, 1, argv.length);
-argv = newargv;
-
-// Load the LO "program"

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - drawinglayer/source

2013-02-22 Thread Caolán McNamara

 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 654f6c7b1b666fa8bfb32dc74740721824eaf0ae
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 20:06:48 2013 +

WaE: unused bInterpretAbsolute

Change-Id: I5f16d42fbb53efd6ee6e0cce48d99c2b74d99944

diff --git a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx 
b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
index 98dc1ca..ef1c7ba 100644
--- a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
@@ -392,7 +392,6 @@ namespace drawinglayer
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
 basegfx::B2DHomMatrix aUnitGradientToObject;
-static bool bInterpretAbsolute(true);
 
 if(getUseUnitCoordinates())
 {
@@ -720,7 +719,6 @@ namespace drawinglayer
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
 basegfx::B2DHomMatrix aUnitGradientToObject;
-static bool bInterpretAbsolute(true);
 
 if(getUseUnitCoordinates())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

2013-02-22 Thread Ivan Timofeev

 sd/source/filter/ppt/pptin.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5aa1307df6da9f8c17fa01d54be4d4184a31b299
Author: Ivan Timofeev 
Date:   Fri Feb 22 23:57:57 2013 +0400

fix Search->indexOf change

Change-Id: I64eb8128c5719a5e7601f15367342e98140e0789

diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 9226f01..0925969 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -115,7 +115,7 @@ SdPPTImport::SdPPTImport( SdDrawDocument* pDocument, 
SvStream& rDocStream, SvSto
 {
 OUString aComment;
 aPropItem.Read( aComment );
-if ( aComment.indexOf( "Applixware", 0 ) != STRING_NOTFOUND )
+if ( aComment.indexOf( "Applixware" ) >= 0 )
 {
 nImportFlags |= PPT_IMPORTFLAGS_NO_TEXT_ASSERT;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: framework/source

2013-02-22 Thread Ivan Timofeev

 framework/source/services/backingwindow.hxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit ecd8b349015ef43bc2407f6ebf2053cb7b3b6c6f
Author: Ivan Timofeev 
Date:   Fri Feb 22 23:04:18 2013 +0400

Start Center: update hardcoded borders to match the new images

Change-Id: Ib3dae9b06bcd2cfe5e73b723d9ea2e5856073651

diff --git a/framework/source/services/backingwindow.hxx 
b/framework/source/services/backingwindow.hxx
index 94c16dd..6d98722 100644
--- a/framework/source/services/backingwindow.hxx
+++ b/framework/source/services/backingwindow.hxx
@@ -119,10 +119,10 @@ namespace framework
 static const int nItemId_Extensions = 1;
 static const int nItemId_Info = 3;
 static const int nItemId_TplRep = 4;
-static const int nShadowTop = 37;
-static const int nShadowLeft = 38;
-static const int nShadowRight = 38;
-static const int nShadowBottom = 38;
+static const int nShadowTop = 31;
+static const int nShadowLeft = 35;
+static const int nShadowRight = 45;
+static const int nShadowBottom = 40;
 
 void loadImage( const ResId& i_rId, PushButton& i_rButton );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: filter/source

2013-02-22 Thread Tor Lillqvist

 filter/source/msfilter/svdfppt.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit fb1991e7c1b17bd4e3b5e0f9aa572d958eb243f4
Author: Tor Lillqvist 
Date:   Fri Feb 22 21:04:29 2013 +0200

WaE: Â´nLenÂ´ may be used uninitialized in this function

Looking at the change to this line in 
e904749eb8e1109f9a884b309fad6de5f78ad623
, I think this line was changed incorrectly. So I won't simply "fix" the
warninig by initialising nLen to some value like zero, but instead reinstate
the use of the nCharCount2 here instead of nLen.

Change-Id: Ice4a5cb751a244c38b3cfc4e05e3206cb939484a

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index 373e909..99f662c 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -5195,7 +5195,7 @@ void PPTStyleTextPropReader::Init( SvStream& rIn, 
SdrPowerPointImport& rMan, con
 }
 else
 {
-aCharPropSet.maString = aString.copy(nCharAnzRead, nLen);
+aCharPropSet.maString = aString.copy(nCharAnzRead, 
nCharCount);
 aCharPropList.push_back( new PPTCharPropSet( aCharPropSet, 
nCurrentPara ) );
 nCharAnzRead += nCharCount;
 bEmptyParaPossible = sal_False;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: android/experimental

2013-02-22 Thread Tor Lillqvist

 
android/experimental/desktop/src/org/libreoffice/android/experimental/desktop/Desktop.java
 |   13 +++---
 1 file changed, 5 insertions(+), 8 deletions(-)

New commits:
commit 754bd309dd346f9930a6ede418ab01fcfa5f74f9
Author: Tor Lillqvist 
Date:   Fri Feb 22 20:46:27 2013 +0200

BitmapView can be a member class

Change-Id: I172cfc0bcad780e99469ac01c9ba7467befe53de

diff --git 
a/android/experimental/desktop/src/org/libreoffice/android/experimental/desktop/Desktop.java
 
b/android/experimental/desktop/src/org/libreoffice/android/experimental/desktop/Desktop.java
index 6087528..3bf2da9 100644
--- 
a/android/experimental/desktop/src/org/libreoffice/android/experimental/desktop/Desktop.java
+++ 
b/android/experimental/desktop/src/org/libreoffice/android/experimental/desktop/Desktop.java
@@ -287,31 +287,28 @@ public class Desktop
 }
 
 Log.i(TAG, "onCreate - set content view\n");
-setContentView(new BitmapView(this, this));
+setContentView(new BitmapView());
 }
-}
 
 class BitmapView extends android.view.View
 {
-Desktop mDesktop;
 Bitmap mBitmap;
 
-public BitmapView(Context context, Desktop desktop)
+public BitmapView()
 {
-super(context);
-mDesktop = desktop;
+super(Desktop.this);
 mBitmap = Bitmap.createBitmap(1000, 600, Bitmap.Config.ARGB_);
 }
 
 @Override protected void onDraw(Canvas canvas) {
 //canvas.drawColor(0xFF1ABCDD);
 
-mDesktop.renderVCL(mBitmap);
+renderVCL(mBitmap);
 canvas.drawBitmap(mBitmap, 0, 0, null);
 
 // re-call ourselves a bit later ...
 invalidate();
 }
 }
-
+}
 // vim:set shiftwidth=4 softtabstop=4 expandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/source

2013-02-22 Thread Matthias Freund

 sw/source/core/draw/dflyobj.cxx  |   87 ---
 sw/source/core/draw/dview.cxx|  108 ++-
 sw/source/core/edit/edatmisc.cxx |   26 -
 3 files changed, 67 insertions(+), 154 deletions(-)

New commits:
commit 1fd796f036b0062d79960c153f06da42f75ac1ec
Author: Matthias Freund 
Date:   Sat Feb 16 22:44:17 2013 +0100

Comment translation german-english

Change-Id: I39ad80b9a952462e178be87ca5e53785036cdaf6
Reviewed-on: https://gerrit.libreoffice.org/2190
Reviewed-by: Thomas Arnhold 
Tested-by: Thomas Arnhold 

diff --git a/sw/source/core/draw/dflyobj.cxx b/sw/source/core/draw/dflyobj.cxx
index 4ca8244..016b1cd 100644
--- a/sw/source/core/draw/dflyobj.cxx
+++ b/sw/source/core/draw/dflyobj.cxx
@@ -68,13 +68,7 @@ static bool bInResize = false;
 TYPEINIT1( SwFlyDrawObj, SdrObject )
 TYPEINIT1( SwVirtFlyDrawObj, SdrVirtObj )
 
-/*
-|*
-|*  SwFlyDrawObj::Ctor
-|*
-*/
-
-
+// SwFlyDrawObj::Ctor
 
 namespace sdr
 {
@@ -112,7 +106,6 @@ namespace sdr
 } // end of namespace contact
 } // end of namespace sdr
 
-
 
 sdr::properties::BaseProperties* SwFlyDrawObj::CreateObjectSpecificProperties()
 {
@@ -135,11 +128,7 @@ SwFlyDrawObj::~SwFlyDrawObj()
 {
 }
 
-/*
-|*
-|*  SwFlyDrawObj::Factory-Methoden
-|*
-*/
+// SwFlyDrawObj - Factory-Methods
 
 sal_uInt32 SwFlyDrawObj::GetObjInventor() const
 {
@@ -158,13 +147,8 @@ sal_uInt16 SwFlyDrawObj::GetObjVersion() const
 return SwDrawFirst;
 }
 
-/*
-|*
-|*  SwVirtFlyDrawObj::CToren, Dtor
-|*
-*/
+// SwVirtFlyDrawObj::CToren, Dtor
 
-//
 // AW: Need own primitive to get the FlyFrame paint working
 
 namespace drawinglayer
@@ -274,7 +258,6 @@ namespace drawinglayer
 } // end of namespace primitive2d
 } // end of namespace drawinglayer
 
-//
 // AW: own sdr::contact::ViewContact (VC) sdr::contact::ViewObjectContact 
(VOC) needed
 // since offset is defined different from SdrVirtObj's 
sdr::contact::ViewContactOfVirtObj.
 // For paint, that offset is used by setting at the OutputDevice; for 
primitives this is
@@ -343,7 +326,6 @@ namespace sdr
 } // end of namespace contact
 } // end of namespace sdr
 
-//
 
 basegfx::B2DRange SwVirtFlyDrawObj::getOuterBound() const
 {
@@ -418,15 +400,12 @@ SwVirtFlyDrawObj::SwVirtFlyDrawObj(SdrObject& rNew, 
SwFlyFrm* pFly) :
 
 SwVirtFlyDrawObj::~SwVirtFlyDrawObj()
 {
-if ( GetPage() )//Der SdrPage die Verantwortung entziehen.
+if ( GetPage() )//Withdraw SdrPage the responsibility.
 GetPage()->RemoveObject( GetOrdNum() );
 }
 
-/*
-|*
-|*  SwVirtFlyDrawObj::GetFmt()
-|*
-*/
+// SwVirtFlyDrawObj::GetFmt()
+
 
 const SwFrmFmt *SwVirtFlyDrawObj::GetFmt() const
 {
@@ -439,11 +418,7 @@ SwFrmFmt *SwVirtFlyDrawObj::GetFmt()
 return GetFlyFrm()->GetFmt();
 }
 
-/*
-|*
-|*  SwVirtFlyDrawObj::Paint()
-|*
-*/
+// SwVirtFlyDrawObj::Paint()
 
 // --> OD #i102707#
 namespace
@@ -527,11 +502,7 @@ void SwVirtFlyDrawObj::wrap_DoPaintObject() const
 }
 }
 
-/*
-|*
-|*  SwVirtFlyDrawObj::TakeObjInfo()
-|*
-*/
+// SwVirtFlyDrawObj::TakeObjInfo()
 
 void SwVirtFlyDrawObj::TakeObjInfo( SdrObjTransformInfoRec& rInfo ) const
 {
@@ -545,12 +516,7 @@ void SwVirtFlyDrawObj::TakeObjInfo( 
SdrObjTransformInfoRec& rInfo ) const
 rInfo.bCanConvToPathLineToArea = rInfo.bCanConvToPolyLineToArea = 
sal_False;
 }
 
-
-/*
-|*
-|*  SwVirtFlyDrawObj::Groessenermittlung
-|*
-*/
+// SwVirtFlyDrawObj - Size Determination
 
 void SwVirtFlyDrawObj::SetRect() const
 {
@@ -644,11 +610,7 @@ void SwVirtFlyDrawObj::NbcSetLo

Re: Looking for PyUno Contributor(s)

2013-02-22 Thread Joel Madero

Several developers have told me that python and uno will be needed to
extract the data from FDO, create a spreadsheet from this data and then
create the graphs/summaries that I am hoping we can create automagically.

If I'm incorrect, please let me know what is correct - but I'm pretty sure
that someone with some PyUno skills will be needed.

Best.
Joel

On Fri, Feb 22, 2013 at 8:03 AM, Stephan Bergmann wrote:

> On 02/20/2013 04:11 PM, Joel Madero wrote:
>
>> I am one of the members of the Quality Assurance team with LibreOffice
>> and we are looking for a volunteer to work with myself designing (and
>> coding) the framework to start automating our stats. It's been on my
>> list for much too long and I just don't have the technical know how to
>> do it. If there are are users or developers who can slowly get this
>> accomplished it would greatly help QA as well as Marketing as our stats
>> are done almost completely manually at this point, not only is this time
>> consuming but it's also likely that there could be mistakes or missing
>> data.
>>
>
> How is the above related to PyUno (i.e., the Python-UNO bridge)?
>
> Stephan
>
>

-- 
*Joel Madero*
LibreOffice QA Volunteer
jmadero@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Gdb support for exceptions (Re: using backtrace() in exception throwing?)

2013-02-22 Thread Tom Tromey

> "Michael" == Michael Meeks  writes:

Michael> The basic debugging experience in these "an exception broke
Michael> something" flows is that we get an exception thrown that
Michael> ultimately ends up in a pathalogical situation - an abort, or
Michael> some similar horrible badness. At that point the most
Michael> interesting thing is not the catcher - which usually ends up
Michael> being utterly random - but the last guy that threw the
Michael> exception. So then as Lubos says comes the knotty job of trying
Michael> to put a breakpoint on the -one- exception that ends up being
Michael> caught where we are now [ and that of course requires
Michael> re-running, and inevitably we throw dozens of exceptions in the
Michael> normal case ].

Thanks.  This kind of discussion is very helpful to me.

This problem is a bit tricky.

The various low-level exception-related functions, like __cxa_throw,
treat the exception object as a "void *".  However, the value of this
seems to change depending on the "throw" point.  It's clear that this
can't always be the argument to throw, due to scalar and object throws.
So I wonder what exactly it refers to.  I'll have to dig a bit deeper to
see how all this code really works.

Anyway, this makes tracking backward from std::terminate to the original
throw point more difficult.


It helps a bit to install the libstdc++ debuginfo.  Then at least you
can dig into some of the details.  However, due to optimization, even
with the improvements in newer version of gcc, this turns out to be less
than perfect.


I tried this out to see what it was like.  It is kind of awful!  At
least, I had to dig around through several frames of libstdc++ to find
the object that lead to std::terminate being called:

terminate called after throwing an instance of 'char const*'

Program received signal SIGABRT, Aborted.
0x003be3036285 in __GI_raise (sig=6)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
64return INLINE_SYSCALL (tgkill, 3, pid, selftid, sig);
(gdb) up
#1  0x003be3037b9b in __GI_abort () at abort.c:91
91raise (SIGABRT);
(gdb) up
#2  0x003be80bbc5d in __gnu_cxx::__verbose_terminate_handler ()
at ../../../../libstdc++-v3/libsupc++/vterminate.cc:95
95  abort();
(gdb) up
#3  0x003be80b9e16 in __cxxabiv1::__terminate (handler=)
at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:40
40handler ();
(gdb) up
#4  0x003be80b9e43 in std::terminate ()
at ../../../../libstdc++-v3/libsupc++/eh_terminate.cc:50
50__terminate (__terminate_handler);
(gdb) up
#5  0x003be80b9f3e in __cxxabiv1::__cxa_throw (obj=0x601090, 
tinfo=, dest=)
at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:83
83std::terminate ();


At this point I can do:

(gdb) catch throw
Catchpoint 1 (throw)
(gdb) cond 1 obj == 0x601090
(gdb) r
The program being debugged has been started already.
Start it from the beginning? (y or n) y
[Inferior 25299 exited]
Starting program: /tmp/r 
warning: failed to reevaluate condition for breakpoint 1: No symbol "obj" in 
current context.
warning: failed to reevaluate condition for breakpoint 1: No symbol "obj" in 
current context.
warning: failed to reevaluate condition for breakpoint 1: No symbol "obj" in 
current context.
Catchpoint 1 (exception thrown), __cxxabiv1::__cxa_throw (obj=0x601090, tinfo=
0x600a60, dest=0) at ../../../../libstdc++-v3/libsupc++/eh_throw.cc:70
70header->exc.unexpectedHandler = __unexpected_handler;


Ignore the warnings; I'm not sure what they are about, but I will file a
bug.

... but all this still fails if you insert a "manual re-throw" like
"throw x;" into the call chain.  At that point it gets really messy :(


Michael> Really nice ! though of course - having a full stack trace
Michael> would make that very substantially more useful.

This is reasonably easy to implement.  It may be expensive.  I've
appended a version that does this... well, it lists file name and line
number for all the frames.  If you want to get a really full stack
trace, capturing the arguments and locals, then you would have to do
more work.

Michael> Even better than this would (perhaps) be a "break inside thrower that
Michael> is caught here" type breakpoint - that we could invoke to land us in
Michael> whatever code is going to throw as it does that [ and before it started
Michael> all the magic cleanup / unwinding work ]. That is - assuming that it's
Michael> possible for the code to know (at that point) where it will ultimately
Michael> end up (? ;-)

I think it isn't possible in general.  When an exception is thrown, I
think all that can really be determined is the next catch point.

What this means is that if you have a series of throws and re-throws,
winding up at some "catch", then the best you could do is stop at the
re-throw that leads to that catch.

Does that make sense?

Like:

void doit()
{
  throw "hi";
}

void dd2()
{
  try {
doit

[Libreoffice-commits] core.git: sc/source

2013-02-22 Thread Michael Stahl

 sc/source/ui/view/colrowba.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad830cacb72ef0a2062706dc80c253f0bcf65cb7
Author: Michael Stahl 
Date:   Fri Feb 22 18:55:56 2013 +0100

sc: insert a temporary String conversion until ScColToAlpha is converted

Change-Id: I35494ccfeba77b173a2d227d1bd2235e81aa2d9b

diff --git a/sc/source/ui/view/colrowba.cxx b/sc/source/ui/view/colrowba.cxx
index b4ca85e..fda9c55 100644
--- a/sc/source/ui/view/colrowba.cxx
+++ b/sc/source/ui/view/colrowba.cxx
@@ -92,7 +92,7 @@ sal_uInt16 ScColBar::GetEntrySize( SCCOLROW nEntryNo )
 String ScColBar::GetEntryText( SCCOLROW nEntryNo )
 {
 return UseNumericHeader()
-? OUString::number( nEntryNo + 1 )
+? String(OUString::number(nEntryNo + 1)) //FIXME remove String again
 : ScColToAlpha( static_cast(nEntryNo) );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/suse/suse-3.6' - oox/inc writerfilter/source

2013-02-22 Thread Cédric Bosdonnat

 oox/inc/oox/vml/vmltextbox.hxx   |2 +-
 writerfilter/source/dmapper/DomainMapperTableManager.hxx |1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 6c6c6c3e876a831fcd954fc3fedb7d21bc142fe8
Author: CÃ©dric Bosdonnat 
Date:   Fri Feb 22 18:48:51 2013 +0100

Fixed conflict resolution problems

Change-Id: Icfe653b3a5f307d21a8c99ce4c133234aa36378b

diff --git a/oox/inc/oox/vml/vmltextbox.hxx b/oox/inc/oox/vml/vmltextbox.hxx
index 427bb79..754ec21 100644
--- a/oox/inc/oox/vml/vmltextbox.hxx
+++ b/oox/inc/oox/vml/vmltextbox.hxx
@@ -95,7 +95,7 @@ public:
 /// Text distance from the border (inset attribute of v:textbox), valid 
only if set.
 bool borderDistanceSet;
 int borderDistanceLeft, borderDistanceTop, borderDistanceRight, 
borderDistanceBottom;
-OUString maLayoutFlow;
+::rtl::OUString maLayoutFlow;
 
 private:
 typedef ::std::vector< TextPortionModel > PortionVector;
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.hxx 
b/writerfilter/source/dmapper/DomainMapperTableManager.hxx
index 97866b0..424c108 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.hxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.hxx
@@ -92,7 +92,6 @@ public:
 IntVectorPtr getCurrentCellWidths( );
 
 const ::rtl::OUString& getTableStyleName() const { return 
m_sTableStyleName; }
-const com::sun::star::uno::Sequence 
getTablePosition() { return m_aTablePosition; }
 const com::sun::star::uno::Sequence 
getCurrentTablePosition();
 
 /// copy the text properties of the table style and its parent into 
pContext
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: oox/source

2013-02-22 Thread Norbert Thiebaud

 oox/source/docprop/docprophandler.cxx |  508 +-
 1 file changed, 254 insertions(+), 254 deletions(-)

New commits:
commit 0041d05b560e878ccd28d05268ba73394f681b59
Author: Norbert Thiebaud 
Date:   Thu Feb 21 21:25:08 2013 -0600

cosmetic clean-ups

Change-Id: I951d0f52b12bde4df8cb444a654e6f45c66c5f57
Reviewed-on: https://gerrit.libreoffice.org/2324
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/oox/source/docprop/docprophandler.cxx 
b/oox/source/docprop/docprophandler.cxx
index 8ae78a7..d0aa157 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -33,13 +33,14 @@ namespace oox {
 namespace docprop {
 
 // 
-OOXMLDocPropHandler::OOXMLDocPropHandler( const uno::Reference< 
uno::XComponentContext >& xContext, const uno::Reference< 
document::XDocumentProperties > xDocProp )
-: m_xContext( xContext )
-, m_xDocProp( xDocProp )
-, m_nState( 0 )
-, m_nBlock( 0 )
-, m_nType( 0 )
-, m_nInBlock( 0 )
+OOXMLDocPropHandler::OOXMLDocPropHandler( const uno::Reference< 
uno::XComponentContext >& xContext,
+  const uno::Reference< 
document::XDocumentProperties > xDocProp )
+: m_xContext( xContext )
+, m_xDocProp( xDocProp )
+, m_nState( 0 )
+, m_nBlock( 0 )
+, m_nType( 0 )
+, m_nInBlock( 0 )
 {
 if ( !xContext.is() || !xDocProp.is() )
 throw uno::RuntimeException();
@@ -55,7 +56,7 @@ void OOXMLDocPropHandler::InitNew()
 {
 m_nState = 0;
 m_nBlock = 0;
-m_aCustomPropertyName = ::rtl::OUString();
+m_aCustomPropertyName = "";
 m_nType = 0;
 m_nInBlock = 0;
 }
@@ -87,7 +88,7 @@ void OOXMLDocPropHandler::AddCustomProperty( const uno::Any& 
aAny )
 }
 
 // 
-util::DateTime OOXMLDocPropHandler::GetDateTimeFromW3CDTF( const 
::rtl::OUString& aChars )
+util::DateTime OOXMLDocPropHandler::GetDateTimeFromW3CDTF( const OUString& 
aChars )
 {
 oslDateTime aOslDTime = { 0, 0, 0, 0, 0, 0, 0, 0 };
 sal_Int32 nLen = aChars.getLength();
@@ -153,11 +154,11 @@ util::DateTime 
OOXMLDocPropHandler::GetDateTimeFromW3CDTF( const ::rtl::OUString
 }
 
 // 
-uno::Sequence< ::rtl::OUString > OOXMLDocPropHandler::GetKeywordsSet( const 
::rtl::OUString& aChars )
+uno::Sequence< OUString > OOXMLDocPropHandler::GetKeywordsSet( const OUString& 
aChars )
 {
 if ( !aChars.isEmpty() )
 {
-uno::Sequence< ::rtl::OUString > aResult( 20 );
+uno::Sequence< OUString > aResult( 20 );
 sal_Int32 nCounter = 0;
 
 const sal_Unicode* pStr = aChars.getStr();
@@ -165,24 +166,24 @@ uno::Sequence< ::rtl::OUString > 
OOXMLDocPropHandler::GetKeywordsSet( const ::rt
 {
 switch( pStr[nInd] )
 {
-case (sal_Unicode)' ':
-case (sal_Unicode)',':
-case (sal_Unicode)';':
-case (sal_Unicode)':':
-case (sal_Unicode)'\t':
-// this is a delimiter
-// unfortunately I did not find any specification for the 
possible delimiters
-if ( !aResult[nCounter].isEmpty() )
-{
-if ( nCounter >= aResult.getLength() )
-aResult.realloc( nCounter + 10 );
-nCounter++;
-}
-break;
+case (sal_Unicode)' ':
+case (sal_Unicode)',':
+case (sal_Unicode)';':
+case (sal_Unicode)':':
+case (sal_Unicode)'\t':
+// this is a delimiter
+// unfortunately I did not find any specification for the 
possible delimiters
+if ( !aResult[nCounter].isEmpty() )
+{
+if ( nCounter >= aResult.getLength() )
+aResult.realloc( nCounter + 10 );
+nCounter++;
+}
+break;
 
-default:
-// this should be a part of keyword
-aResult[nCounter] += ::rtl::OUString( 
(sal_Unicode)pStr[nInd] );
+default:
+// this should be a part of keyword
+aResult[nCounter] += OUString( (sal_Unicode)pStr[nInd] );
 }
 }
 
@@ -190,10 +191,10 @@ uno::Sequence< ::rtl::OUString > 
OOXMLDocPropHandler::GetKeywordsSet( const ::rt
 return aResult;
 }
 
-return uno::Sequence< ::rtl::OUString >();
+return uno::Sequence< OUString >();
 }
 // 
-lang::Locale OOXMLDocPropHandler::GetLanguage( const ::rtl::OUString& aChars )
+lang::Locale OOXMLDocPropHandler::GetLanguage( const OUString& aChars )
 {
 lang::Locale aResult;
 if ( aChars.getLength() >= 2 )
@@

[Libreoffice-commits] core.git: oox/source

2013-02-22 Thread Norbert Thiebaud

 oox/source/docprop/docprophandler.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f9ec3b34774c0f5822b42a49a28447c5e888de41
Author: Norbert Thiebaud 
Date:   Thu Feb 21 21:10:05 2013 -0600

coverity#736043 Missing break in switch

Change-Id: Ia75cc63035119f243e8145e982d1f5267078c1e8
Reviewed-on: https://gerrit.libreoffice.org/2323
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/oox/source/docprop/docprophandler.cxx 
b/oox/source/docprop/docprophandler.cxx
index 1067315..8ae78a7 100644
--- a/oox/source/docprop/docprophandler.cxx
+++ b/oox/source/docprop/docprophandler.cxx
@@ -614,7 +614,7 @@ void SAL_CALL OOXMLDocPropHandler::characters( const 
::rtl::OUString& aChars )
 case VT_TOKEN( date ):
 case VT_TOKEN( filetime ):
 AddCustomProperty( uno::makeAny( 
GetDateTimeFromW3CDTF( aChars ) ) );
-
+break;
 case VT_TOKEN( i1 ):
 case VT_TOKEN( i2 ):
 AddCustomProperty( uno::makeAny( 
(sal_Int16)aChars.toInt32() ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: oox/inc

2013-02-22 Thread Norbert Thiebaud

 oox/inc/oox/ole/axbinarywriter.hxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit c522001687676327b6f04d0d72a1d45fe3f2b110
Author: Norbert Thiebaud 
Date:   Thu Feb 21 20:43:13 2013 -0600

coverity#738777 Uninitialized scalar field => unused member

Change-Id: Id4ddd4d4581aa35abfab0251737607d794a944f3
Reviewed-on: https://gerrit.libreoffice.org/2321
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/oox/inc/oox/ole/axbinarywriter.hxx 
b/oox/inc/oox/ole/axbinarywriter.hxx
index fbd0921..c344285 100644
--- a/oox/inc/oox/ole/axbinarywriter.hxx
+++ b/oox/inc/oox/ole/axbinarywriter.hxx
@@ -181,7 +181,6 @@ private:
 sal_Int64   mnPropFlagsStart; ///< pos of Prop flags
 sal_Int64   mnPropFlags;///< Flags specifying existing 
properties.
 sal_Int64   mnNextProp; ///< Next property to read.
-sal_Int64   mnPropsEnd; ///< End position of simple/large 
properties.
 boolmbValid;///< True = stream still valid.
 boolmb64BitPropFlags;
 };
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: oox/source

2013-02-22 Thread Norbert Thiebaud

 oox/source/export/vmlexport.cxx |   17 +
 1 file changed, 9 insertions(+), 8 deletions(-)

New commits:
commit 685c6dadaad760169749c62cdefb4b3ae5a8ddf9
Author: Norbert Thiebaud 
Date:   Thu Feb 21 20:50:05 2013 -0600

coverity#738776 Uninitialized scalar field

Change-Id: I98770ba5cf3179a743d1f3fe0684f12adc65c29b
Reviewed-on: https://gerrit.libreoffice.org/2322
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/oox/source/export/vmlexport.cxx b/oox/source/export/vmlexport.cxx
index a69b607..d865f91 100644
--- a/oox/source/export/vmlexport.cxx
+++ b/oox/source/export/vmlexport.cxx
@@ -35,14 +35,15 @@ using namespace sax_fastparser;
 using namespace oox::vml;
 
 VMLExport::VMLExport( ::sax_fastparser::FSHelperPtr pSerializer, 
VMLTextExport* pTextExport )
-: EscherEx( EscherExGlobalRef(new EscherExGlobal(0)), 0 ),
-  m_pSerializer( pSerializer ),
-  m_pTextExport( pTextExport ),
-  m_pSdrObject( 0 ),
-  m_pShapeAttrList( NULL ),
-  m_nShapeType( ESCHER_ShpInst_Nil ),
-  m_pShapeStyle( new OStringBuffer( 200 ) ),
-  m_pShapeTypeWritten( new bool[ ESCHER_ShpInst_COUNT ] )
+: EscherEx( EscherExGlobalRef(new EscherExGlobal(0)), 0 )
+, m_pSerializer( pSerializer )
+, m_pTextExport( pTextExport )
+, m_pSdrObject( 0 )
+, m_pShapeAttrList( NULL )
+, m_nShapeType( ESCHER_ShpInst_Nil )
+, m_nShapeFlags(0)
+, m_pShapeStyle( new OStringBuffer( 200 ) )
+, m_pShapeTypeWritten( new bool[ ESCHER_ShpInst_COUNT ] )
 {
 mnGroupLevel = 1;
 memset( m_pShapeTypeWritten, 0, ESCHER_ShpInst_COUNT * sizeof( bool ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0-1' - sd/source

2013-02-22 Thread Tor Lillqvist

 sd/source/ui/remotecontrol/BufferedStreamSocket.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 86edaa34e8ac4c67543941ce290aa7a472d4e525
Author: Tor Lillqvist 
Date:   Tue Feb 19 19:57:12 2013 +0200

Avoid infinite recursion

(cherry picked from commit 0d05957cf0c38abab45030ba172025e4ef318f43)

Change-Id: I3085b82a80228211951b5230b7e8d3bcf535e052
Reviewed-on: https://gerrit.libreoffice.org/2269
Reviewed-by: Eike Rathke 
Reviewed-by: Michael Stahl 
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/sd/source/ui/remotecontrol/BufferedStreamSocket.cxx 
b/sd/source/ui/remotecontrol/BufferedStreamSocket.cxx
index e2c7a4a..dcec4e3 100644
--- a/sd/source/ui/remotecontrol/BufferedStreamSocket.cxx
+++ b/sd/source/ui/remotecontrol/BufferedStreamSocket.cxx
@@ -67,7 +67,7 @@ void BufferedStreamSocket::close()
 mSocket = -1;
 }
 else
-close();
+::osl::StreamSocket::close();
 }
 
 sal_Int32 BufferedStreamSocket::readLine( OString& aLine )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] [PUSHED] String cleanup in filter

2013-02-22 Thread Norbert Thiebaud (via Code Review)

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/1970

Approvals:
  Norbert Thiebaud: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/1970
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9fac2f277550cc786baffe4f89c7181b2d10dfd
Gerrit-PatchSet: 9
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] String cleanup in filter

2013-02-22 Thread Norbert Thiebaud (via Code Review)

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/1970

to look at the new patch set (#8).

Change subject: String cleanup in filter
..

String cleanup in filter

Change-Id: If9fac2f277550cc786baffe4f89c7181b2d10dfd
---
M filter/inc/filter/msfilter/svdfppt.hxx
M filter/source/msfilter/svdfppt.cxx
M sd/source/filter/ppt/pptin.cxx
M sd/source/filter/ppt/propread.cxx
M sd/source/filter/ppt/propread.hxx
5 files changed, 117 insertions(+), 117 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/70/1970/8
-- 
To view, visit https://gerrit.libreoffice.org/1970
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9fac2f277550cc786baffe4f89c7181b2d10dfd
Gerrit-PatchSet: 8
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: filter/inc filter/source sd/source

2013-02-22 Thread Ricardo Montania

 filter/inc/filter/msfilter/svdfppt.hxx |   28 +++---
 filter/source/msfilter/svdfppt.cxx |  138 -
 sd/source/filter/ppt/pptin.cxx |   48 +--
 sd/source/filter/ppt/propread.cxx  |   18 ++--
 sd/source/filter/ppt/propread.hxx  |2 
 5 files changed, 117 insertions(+), 117 deletions(-)

New commits:
commit e904749eb8e1109f9a884b309fad6de5f78ad623
Author: Ricardo Montania 
Date:   Sun Feb 3 00:02:38 2013 -0200

String cleanup in filter

Change-Id: If9fac2f277550cc786baffe4f89c7181b2d10dfd
Reviewed-on: https://gerrit.libreoffice.org/1970
Reviewed-by: Norbert Thiebaud 
Tested-by: Norbert Thiebaud 

diff --git a/filter/inc/filter/msfilter/svdfppt.hxx 
b/filter/inc/filter/msfilter/svdfppt.hxx
index 79272f5..fcc704f 100644
--- a/filter/inc/filter/msfilter/svdfppt.hxx
+++ b/filter/inc/filter/msfilter/svdfppt.hxx
@@ -63,7 +63,7 @@ struct MSFILTER_DLLPUBLIC PptCurrentUserAtom
 sal_uInt16  nDocFileVersion;
 sal_uInt8   nMajorVersion;
 sal_uInt8   nMinorVersion;
-String  aCurrentUser;
+OUStringaCurrentUser;
 
 public:
 
@@ -92,13 +92,13 @@ struct SdHyperlinkEntry
 sal_Int32   nPrivate2;
 sal_Int32   nPrivate3;
 sal_Int32   nInfo;
-String  aTarget;
-String  aSubAdress;
+OUStringaTarget;
+OUStringaSubAdress;
 
 sal_Int32   nStartPos;
 sal_Int32   nEndPos;
 
-String  aConvSubString;
+OUStringaConvSubString;
 ESelection  aESelection;
 sal_BoolbSelection;
 };
@@ -260,7 +260,7 @@ public:
 
 struct PptFontEntityAtom
 {
-String  aName;
+OUStringaName;
 double  fScaling;
 sal_uInt8   lfClipPrecision;
 sal_uInt8   lfQuality;
@@ -416,7 +416,7 @@ protected:
 sal_BoolbTimesNewRomanChecked   : 1;
 sal_BoolbTimesNewRomanAvailable : 1;
 
-sal_BoolReadString( rtl::OUString& rStr ) const;
+sal_BoolReadString( OUString& rStr ) const;
 // nur fuer PowerPoint-Filter:
 virtual const PptSlideLayoutAtom* GetSlideLayoutAtom() const;
 
@@ -425,7 +425,7 @@ public:
 
 PowerPointImportParam& rImportParam;
 
-SdrEscherImport( PowerPointImportParam&, const String& 
rBaseURL );
+SdrEscherImport( PowerPointImportParam&, const 
OUString& rBaseURL );
 virtual ~SdrEscherImport();
 virtual boolGetColorFromPalette( sal_uInt16 nNum, Color& rColor ) 
const;
 virtual sal_BoolSeekToShape( SvStream& rSt, void* pClientData, 
sal_uInt32 nId ) const;
@@ -453,7 +453,7 @@ struct MSFILTER_DLLPUBLIC PPTFieldEntry
 sal_uInt16  nTextRangeEnd;
 SvxFieldItem*   pField1;
 SvxFieldItem*   pField2;
-String* pString;
+OUString*   pString;
 
 PPTFieldEntry() : nPos( 0 ), nTextRangeEnd( 0 ), pField1( NULL ), pField2( 
NULL ), pString( NULL ) {};
 ~PPTFieldEntry();
@@ -471,7 +471,7 @@ struct MSFILTER_DLLPUBLIC PPTFieldEntry
 struct MSFILTER_DLLPUBLIC HeaderFooterEntry
 {
 const PptSlidePersistEntry* pMasterPersist;
-String  pPlaceholder[ 4 ];
+OUStringpPlaceholder[ 4 ];
 sal_uInt32  nAtom;
 
 sal_uInt32  GetMaskForInstance( sal_uInt32 nInstance );
@@ -575,7 +575,7 @@ protected:
 voidSeekOle( SfxObjectShell* pShell, sal_uInt32 
nFilterOptions );
 
 public:
-SdrPowerPointImport( PowerPointImportParam&, const 
String& rBaseURL );
+SdrPowerPointImport( PowerPointImportParam&, const 
OUString& rBaseURL );
 virtual ~SdrPowerPointImport();
 sal_uInt16  GetPageCount( PptPageKind eKind = PPT_SLIDEPAGE ) 
const;
 voidSetPageNum( sal_uInt16 nPageNum, PptPageKind = 
PPT_SLIDEPAGE );
@@ -916,7 +916,7 @@ struct PPTCharPropSet
 
 sal_uInt32  mnOriginalTextPos;
 sal_uInt32  mnParagraph;
-String  maString;
+OUStringmaString;
 SvxFieldItem*   mpFieldItem;
 sal_uInt16  mnLanguage[ 3 ];
 
@@ -1049,7 +1049,7 @@ struct PPTStyleTextPropReader
 SvStream& rIn,
 SdrPowerPointImport& rMan,
 const DffRecordHeader& rTextHeader,
-const String& aString,
+const OUString& aString,
 PPTTextRulerInterpreter& rRuler,
 sal_uInt32& nCharCount,
 sal_Bool& bTextPropAtom
@@ -1057,7 +1057,7 @@ struct PPTStyleTextPropReader
 voidReadCharProps(
 SvStream& rIn,
 PPTCharPropSet& aCharPropSet,
-const String& aString,
+const OUString& aString,
 sal_uInt32& nCharCount,
 sal_uInt32 nCharAnzRead,
 sal_Bool& bTextPropAtom,
@@ -1107,7

[Libreoffice-commits] core.git: sc/source

2013-02-22 Thread Jean-Noël Rouvignac

 sc/source/core/data/docpool.cxx |4 +-
 sc/source/core/data/dpdimsave.cxx   |2 -
 sc/source/core/data/dputil.cxx  |2 -
 sc/source/core/data/drwlayer.cxx|2 -
 sc/source/core/data/global.cxx  |4 +-
 sc/source/core/data/stlpool.cxx |2 -
 sc/source/core/data/table4.cxx  |4 +-
 sc/source/core/tool/address.cxx |   12 +++
 sc/source/core/tool/compiler.cxx|8 ++--
 sc/source/filter/excel/excdoc.cxx   |2 -
 sc/source/filter/excel/excform.cxx  |2 -
 sc/source/filter/excel/excform8.cxx |2 -
 sc/source/filter/excel/namebuff.cxx |   10 ++---
 sc/source/filter/excel/xehelper.cxx |2 -
 sc/source/filter/excel/xename.cxx   |2 -
 sc/source/filter/excel/xistyle.cxx  |2 -
 sc/source/filter/ftools/ftools.cxx  |4 +-
 sc/source/filter/html/htmlexp.cxx   |2 -
 sc/source/filter/starcalc/scflt.cxx |2 -
 sc/source/filter/xml/xmlwrap.cxx|4 +-
 sc/source/ui/Accessibility/AccessibleCsvControl.cxx |2 -
 sc/source/ui/dbgui/asciiopt.cxx |   12 +++
 sc/source/ui/dbgui/csvgrid.cxx  |2 -
 sc/source/ui/dbgui/csvruler.cxx |4 +-
 sc/source/ui/dbgui/imoptdlg.cxx |4 +-
 sc/source/ui/dbgui/sortkeydlg.cxx   |2 -
 sc/source/ui/docshell/dbdocimp.cxx  |2 -
 sc/source/ui/docshell/docsh5.cxx|2 -
 sc/source/ui/docshell/docsh8.cxx|   16 -
 sc/source/ui/docshell/impex.cxx |   16 -
 sc/source/ui/docshell/tpstat.cxx|6 +--
 sc/source/ui/formdlg/dwfunctr.cxx   |4 +-
 sc/source/ui/miscdlgs/acredlin.cxx  |4 +-
 sc/source/ui/miscdlgs/instbdlg.cxx  |2 -
 sc/source/ui/miscdlgs/optsolver.cxx |2 -
 sc/source/ui/miscdlgs/sharedocdlg.cxx   |2 -
 sc/source/ui/navipi/content.cxx |2 -
 sc/source/ui/unoobj/chart2uno.cxx   |6 +--
 sc/source/ui/unoobj/filtuno.cxx |2 -
 sc/source/ui/vba/vbaworksheet.cxx   |4 +-
 sc/source/ui/vba/vbaworksheets.cxx  |4 +-
 sc/source/ui/view/cellsh.cxx|4 +-
 sc/source/ui/view/cellsh3.cxx   |2 -
 sc/source/ui/view/colrowba.cxx  |4 +-
 sc/source/ui/view/dbfunc3.cxx   |2 -
 sc/source/ui/view/gridwin4.cxx  |2 -
 sc/source/ui/view/preview.cxx   |4 +-
 sc/source/ui/view/prevwsh.cxx   |   12 +++
 sc/source/ui/view/printfun.cxx  |2 -
 sc/source/ui/view/tabview.cxx   |2 -
 sc/source/ui/view/tabview4.cxx  |8 ++--
 sc/source/ui/view/viewdata.cxx  |   34 ++--
 52 files changed, 125 insertions(+), 125 deletions(-)

New commits:
commit bb5fa449378d6535932d39f2357c06e181647346
Author: Jean-NoÃ«l Rouvignac 
Date:   Wed Feb 20 00:17:30 2013 +0100

fdo#38838 search replace for String::CreateFromInt32().

I ran the following code replace:
s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/

Change-Id: I45edaec4de2481ad45f9bcae2e280d5aca487714
Reviewed-on: https://gerrit.libreoffice.org/2281
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/sc/source/core/data/docpool.cxx b/sc/source/core/data/docpool.cxx
index 535a480..e7f008c 100644
--- a/sc/source/core/data/docpool.cxx
+++ b/sc/source/core/data/docpool.cxx
@@ -917,7 +917,7 @@ SfxItemPresentation ScDocumentPool::GetPresentation(
 case SFX_ITEM_PRESENTATION_NAMELESS:
 {
 String aPages( ScGlobal::GetRscString( 
STR_SCATTR_PAGE_SCALE_PAGES ) );
-aPages.SearchAndReplaceAscii( "%1", 
String::CreateFromInt32( nPagNo ) );
+aPages.SearchAndReplaceAscii( "%1", OUString::number( 
nPagNo ) );
 rText += aPages;
 }
 break;
@@ -946,7 +946,7 @@ SfxItemPresentation ScDocumentPool::GetPresentation(
 rText = 
ScGlobal::GetRscString(STR_SCATTR_PAGE_FIRSTPAGENO) + aStrSep;
 //  break; // DURCHFALLEN!!!
 case SFX_ITEM_PRESENTATION_NAMELESS:
-rText += String::CreateFromInt32( nPagNo );
+rText += OUString::number( nPagNo );
 break;

[MERGE FAILED] String cleanup in filter

2013-02-22 Thread Norbert Thiebaud (via Code Review)

Norbert Thiebaud has submitted this change and it FAILED to merge.

Change subject: String cleanup in filter
..


Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for 
review.

-- 
To view, visit https://gerrit.libreoffice.org/1970
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merge-failed
Gerrit-Change-Id: If9fac2f277550cc786baffe4f89c7181b2d10dfd
Gerrit-PatchSet: 7
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Ricardo Montania 
Gerrit-Reviewer: LibreOffice gerrit bot 
Gerrit-Reviewer: Norbert Thiebaud 
Gerrit-Reviewer: Ricardo Montania 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - sfx2/source svl/source xmloff/source

2013-02-22 Thread Radek Doulik

 sfx2/source/appl/sfxhelp.cxx |   43 ++-
 sfx2/source/bastyp/helper.cxx|   10 
 sfx2/source/inc/helper.hxx   |4 +--
 svl/source/items/custritm.cxx|   16 ++---
 xmloff/source/draw/sdxmlimp.cxx  |   11 
 xmloff/source/draw/sdxmlimp_impl.hxx |1 
 6 files changed, 45 insertions(+), 40 deletions(-)

New commits:
commit eb451cbc1aa2f96b1a913d85823ef27275ad367b
Author: Radek Doulik 
Date:   Fri Feb 22 18:15:22 2013 +0100

set document settings / embed fonts when importing odp

Change-Id: Ib7160c3b00399e704cd02a41735b0ff4f13d8554

diff --git a/xmloff/source/draw/sdxmlimp.cxx b/xmloff/source/draw/sdxmlimp.cxx
index 6797c73..3c86883 100644
--- a/xmloff/source/draw/sdxmlimp.cxx
+++ b/xmloff/source/draw/sdxmlimp.cxx
@@ -1068,4 +1068,15 @@ void SdXMLImport::AddDateTimeDecl( const 
::rtl::OUString& rName, const ::rtl::OU
 return aDecl.maStrText;
 }
 
+void SdXMLImport::NotifyEmbeddedFontRead()
+{
+uno::Reference< lang::XMultiServiceFactory > xFac( GetModel(), 
uno::UNO_QUERY );
+if( xFac.is() )
+{
+uno::Reference< beans::XPropertySet > xProps( xFac->createInstance( 
OUString( RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.document.Settings" ) ) ), 
uno::UNO_QUERY );
+if( xProps.is() )
+xProps->setPropertyValue("EmbedFonts", uno::makeAny( true ) );
+}
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/sdxmlimp_impl.hxx 
b/xmloff/source/draw/sdxmlimp_impl.hxx
index dbede52..43ba353 100644
--- a/xmloff/source/draw/sdxmlimp_impl.hxx
+++ b/xmloff/source/draw/sdxmlimp_impl.hxx
@@ -310,6 +310,7 @@ public:
 ::rtl::OUString GetFooterDecl( const ::rtl::OUString& rName ) const;
 ::rtl::OUString GetDateTimeDecl( const ::rtl::OUString& rName, sal_Bool& 
rbFixed, ::rtl::OUString& rDateTimeFormat );
 
+virtual void NotifyEmbeddedFontRead() SAL_OVERRIDE;
 };
 
 #endif  //  _SDXMLIMP_HXX
commit 046ad9ffad7b4647fcc66291dec73bbb67a7fe85
Author: Ivan Timofeev 
Date:   Fri Feb 22 21:09:12 2013 +0400

fix string conversion in 1da3af5f1eb6a32fd0ab10da7cf2f8ddb298a3a1

Change-Id: I683002c12f9bb8f053dafea70c889a2881a70b99

diff --git a/svl/source/items/custritm.cxx b/svl/source/items/custritm.cxx
index 3b3128d..d44b43c 100644
--- a/svl/source/items/custritm.cxx
+++ b/svl/source/items/custritm.cxx
@@ -54,19 +54,9 @@ int CntUnencodedStringItem::Compare(SfxPoolItem const & 
rWith) const
 DBG_CHKTHIS(CntUnencodedStringItem, 0);
 DBG_ASSERT(rWith.ISA(CntUnencodedStringItem),
 "CntUnencodedStringItem::Compare(): Bad type");
-switch (m_aValue.compareTo(static_cast< CntUnencodedStringItem const * >(
-   &rWith)->
-   m_aValue))
-{
-case COMPARE_LESS:
-return -1;
-
-case COMPARE_EQUAL:
-return 0;
-
-default: // COMPARE_GREATER
-return 1;
-}
+sal_Int32 nCmp = m_aValue.compareTo(
+static_cast< CntUnencodedStringItem const * >(&rWith)->m_aValue);
+return (nCmp == 0) ? 0 : (nCmp < 0) ? -1 : 1;
 }
 
 //
commit 3a5ae29f0d2f4467ec75803d6e3b5b461672428a
Author: Ivan Timofeev 
Date:   Fri Feb 22 15:19:38 2013 +0400

String -> OUString

Change-Id: I5b577a8e0675d7849ca22e24bb99ee2d8602ae6a

diff --git a/sfx2/source/appl/sfxhelp.cxx b/sfx2/source/appl/sfxhelp.cxx
index fa346a8..6b6aeea 100644
--- a/sfx2/source/appl/sfxhelp.cxx
+++ b/sfx2/source/appl/sfxhelp.cxx
@@ -126,12 +126,12 @@ static OUString HelpLocaleString()
 if (!osl::DirectoryItem::get(sHelpPath, aDirItem) == 
osl::FileBase::E_None)
 {
 bOk = false;
-String sLang(aLocaleStr);
-xub_StrLen nSepPos = sLang.Search( '-' );
-if (nSepPos != STRING_NOTFOUND)
+OUString sLang(aLocaleStr);
+sal_Int32 nSepPos = sLang.indexOf( '-' );
+if (nSepPos != -1)
 {
 bOk = true;
-sLang = sLang.Copy( 0, nSepPos );
+sLang = sLang.copy( 0, nSepPos );
 sHelpPath = aBaseInstallPath +
 OUString::createFromAscii(szHelpPath) + sLang;
 if (!osl::DirectoryItem::get(sHelpPath, aDirItem) == 
osl::FileBase::E_None)
@@ -185,7 +185,7 @@ sal_Bool GetHelpAnchor_Impl( const OUString& _rURL, 
OUString& _rAnchor )
 
 if ( !sAnchor.isEmpty() )
 {
-_rAnchor = String( sAnchor );
+_rAnchor = sAnchor;
 bRet = sal_True;
 }
 }
@@ -307,7 +307,7 @@ public:
 ~SfxHelp_Impl();
 
 SfxHelpOptions_Impl*GetOptions();
-static String   GetHelpText( const OUString& aCommandURL, const 
String& rModule );

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - reportdesign/source

2013-02-22 Thread Lionel Elie Mamane

 reportdesign/source/ui/inspection/GeometryHandler.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 211a4d041933a85364c4693cc741fc3a601f821c
Author: Lionel Elie Mamane 
Date:   Fri Feb 22 16:30:03 2013 +0100

Compare strings with proper length

Change-Id: If88f79a7f63edb254ad5356e9a0fccc5573af106
Reviewed-on: https://gerrit.libreoffice.org/2338
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/reportdesign/source/ui/inspection/GeometryHandler.cxx 
b/reportdesign/source/ui/inspection/GeometryHandler.cxx
index cfb5cba..923bf49 100644
--- a/reportdesign/source/ui/inspection/GeometryHandler.cxx
+++ b/reportdesign/source/ui/inspection/GeometryHandler.cxx
@@ -1430,7 +1430,7 @@ inspection::InteractiveSelectionResult SAL_CALL 
GeometryHandler::onInteractivePr
 }
 else if (  PropertyName.equalsAsciiL(PROPERTY_FORMULA.ascii, 
PROPERTY_FORMULA.length)
 || PropertyName.equalsAsciiL(PROPERTY_INITIALFORMULA.ascii, 
PROPERTY_INITIALFORMULA.length)
-|| PropertyName.equalsAsciiL(PROPERTY_DATAFIELD.ascii, 
PROPERTY_INITIALFORMULA.length)
+|| PropertyName.equalsAsciiL(PROPERTY_DATAFIELD.ascii, 
PROPERTY_DATAFIELD.length)
 || 
PropertyName.equalsAsciiL(PROPERTY_CONDITIONALPRINTEXPRESSION.ascii, 
PROPERTY_CONDITIONALPRINTEXPRESSION.length))
 {
 ::osl::ClearableMutexGuard aGuard( m_aMutex );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: xmloff/source

2013-02-22 Thread Radek Doulik

 xmloff/source/draw/sdxmlexp.cxx  |   13 +
 xmloff/source/draw/sdxmlexp_impl.hxx |1 +
 2 files changed, 14 insertions(+)

New commits:
commit f0cd6fe9075cd0aa00162474784ad804a07ed138
Author: Radek Doulik 
Date:   Fri Feb 22 18:06:18 2013 +0100

use document settings / embed fonts when exporting odp

Change-Id: I9e8db1ae08b570f093b13d50bfde823c85cdba95

diff --git a/xmloff/source/draw/sdxmlexp.cxx b/xmloff/source/draw/sdxmlexp.cxx
index d33db72..441dbf0 100644
--- a/xmloff/source/draw/sdxmlexp.cxx
+++ b/xmloff/source/draw/sdxmlexp.cxx
@@ -2901,4 +2901,17 @@ OUString SAL_CALL SdXMLExport::getImplementationName() 
throw( uno::RuntimeExcept
 }
 }
 
+XMLFontAutoStylePool* SdXMLExport::CreateFontAutoStylePool()
+{
+bool bEmbedFonts = false;
+Reference< lang::XMultiServiceFactory > xFac( GetModel(), UNO_QUERY );
+if( xFac.is() )
+{
+Reference< beans::XPropertySet > xProps( xFac->createInstance( 
OUString( RTL_CONSTASCII_USTRINGPARAM( "com.sun.star.document.Settings" ) ) ), 
UNO_QUERY );
+if( xProps.is() )
+xProps->getPropertyValue("EmbedFonts") >>= bEmbedFonts;
+}
+return new XMLFontAutoStylePool( *this, bEmbedFonts );
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/draw/sdxmlexp_impl.hxx 
b/xmloff/source/draw/sdxmlexp_impl.hxx
index 166f573..cc5a5ed 100644
--- a/xmloff/source/draw/sdxmlexp_impl.hxx
+++ b/xmloff/source/draw/sdxmlexp_impl.hxx
@@ -174,6 +174,7 @@ class SdXMLExport : public SvXMLExport
 protected:
 virtual void 
GetViewSettings(com::sun::star::uno::Sequence&
 aProps);
 virtual void 
GetConfigurationSettings(com::sun::star::uno::Sequence&
 aProps);
+virtual XMLFontAutoStylePool* CreateFontAutoStylePool();
 
 public:
 SdXMLExport(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - extras/source sc/uiconfig vcl/inc vcl/source

2013-02-22 Thread Caolán McNamara

 extras/source/glade/libreoffice-catalog.xml |   15 +++
 sc/uiconfig/scalc/ui/sortoptionspage.ui |3 ++-
 vcl/inc/vcl/combobox.hxx|4 
 vcl/inc/vcl/lstbox.hxx  |4 
 vcl/source/control/combobox.cxx |   17 +
 vcl/source/control/lstbox.cxx   |   21 +
 vcl/source/window/builder.cxx   |2 +-
 7 files changed, 64 insertions(+), 2 deletions(-)

New commits:
commit 6c68f2c8edb47d8165521ce97799092ab449a9b7
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 16:54:59 2013 +

wrap max-width-chars in a custom widget to avoid it getting dropped silently

Change-Id: I7ccbd4b2e1aebc84a59bb9000e7322c8aa62ffd7

diff --git a/extras/source/glade/libreoffice-catalog.xml 
b/extras/source/glade/libreoffice-catalog.xml
index 0612baa..93f4dc6 100644
--- a/extras/source/glade/libreoffice-catalog.xml
+++ b/extras/source/glade/libreoffice-catalog.xml
@@ -57,5 +57,20 @@
 
+
+
+  
+
+  
+GParamInt
+-1
+  
+  The desired maximum width of the ComboBox, in 
characters
+
+  
+
+
   
 
diff --git a/sc/uiconfig/scalc/ui/sortoptionspage.ui 
b/sc/uiconfig/scalc/ui/sortoptionspage.ui
index 2b0a9cc..0fc7eeb 100644
--- a/sc/uiconfig/scalc/ui/sortoptionspage.ui
+++ b/sc/uiconfig/scalc/ui/sortoptionspage.ui
@@ -164,7 +164,7 @@
   
 
 
-  
+  
 True
 False
 20
diff --git a/vcl/source/window/builder.cxx b/vcl/source/window/builder.cxx
index 264bf92..facb2e5 100644
--- a/vcl/source/window/builder.cxx
+++ b/vcl/source/window/builder.cxx
@@ -1060,7 +1060,7 @@ Window *VclBuilder::makeObject(Window *pParent, const 
OString &name, const OStri
 }
 else if (name == "GtkLinkButton")
 pWindow = new FixedHyperlink(pParent, 
WB_CENTER|WB_VCENTER|WB_3DLOOK|WB_NOLABEL);
-else if ((name == "GtkComboBox") || (name == "GtkComboBoxText"))
+else if ((name == "GtkComboBox") || (name == "GtkComboBoxText") || (name 
== "VclComboBoxText"))
 {
 extractModel(id, rMap);
 if (extractEntry(rMap))
commit 7c760f34a00462d5904d0e2eed4132761c2e51c5
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 15:41:00 2013 +

Resolves: fdo#60764 sort options can grow too wide to fit on screen

Change-Id: Id3aed9ef251f61710b43ceda1a28c6895e91872f

diff --git a/sc/uiconfig/scalc/ui/sortoptionspage.ui 
b/sc/uiconfig/scalc/ui/sortoptionspage.ui
index 805e0cc..2b0a9cc 100644
--- a/sc/uiconfig/scalc/ui/sortoptionspage.ui
+++ b/sc/uiconfig/scalc/ui/sortoptionspage.ui
@@ -168,6 +168,7 @@
 True
 False
 20
+72
 
   
 
diff --git a/vcl/inc/vcl/combobox.hxx b/vcl/inc/vcl/combobox.hxx
index 33a4382..1a73983 100644
--- a/vcl/inc/vcl/combobox.hxx
+++ b/vcl/inc/vcl/combobox.hxx
@@ -47,6 +47,7 @@ private:
 sal_BoolmbDDAutoSize: 1;
 sal_BoolmbSyntheticModify   : 1;
 sal_BoolmbMatchCase : 1;
+sal_Int32 m_nMaxWidthChars;
 LinkmaSelectHdl;
 LinkmaDoubleClickHdl;
 
@@ -214,6 +215,9 @@ public:
  */
 using Control::GetIndexForPoint;
 long GetIndexForPoint( const Point& rPoint, sal_uInt16& rPos ) const;
+
+sal_Int32 getMaxWidthChars() const { return m_nMaxWidthChars; }
+void setMaxWidthChars(sal_Int32 nWidth);
 };
 
 #endif  // _COMBOBOX_HXX
diff --git a/vcl/inc/vcl/lstbox.hxx b/vcl/inc/vcl/lstbox.hxx
index 694f45c..74dc854 100644
--- a/vcl/inc/vcl/lstbox.hxx
+++ b/vcl/inc/vcl/lstbox.hxx
@@ -44,6 +44,7 @@ private:
 sal_uInt16  mnDDHeight;
 sal_uInt16  mnSaveValue;
 sal_BoolmbDDAutoSize;
+sal_Int32 m_nMaxWidthChars;
 LinkmaSelectHdl;
 LinkmaDoubleClickHdl;
 sal_uInt16 mnLineCount;
@@ -219,6 +220,9 @@ public:
 using Control::GetIndexForPoint;
 long GetIndexForPoint( const Point& rPoint, sal_uInt16& rPos ) const;
 
+sal_Int32 getMaxWidthChars() const { return m_nMaxWidthChars; }
+void setMaxWidthChars(sal_Int32 nWidth);
+
 virtual bool set_property(const rtl::OString &rKey, const rtl::OString 
&rValue);
 };
 
diff --git a/vcl/source/control/combobox.cxx b/vcl/source/control/combobox.cxx
index 673001d..e74d024 100644
--- a/vcl/source/control/combobox.cxx
+++ b/vcl/source/control/combobox.cxx
@@ -110,6 +110,7 @@ void ComboBox::ImplInitComboBoxData()
 mbSyntheticModify   = sal_False;
 mbMatchCase = sal_False;
 mcMultiSep  = ';';
+m_nMaxWidthChars= -1;
 }
 
 // -

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2013-02-22 Thread Miklos Vajna

 sw/qa/extras/ooxmlimport/data/tblr-height.docx   |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |   13 +
 writerfilter/source/dmapper/DomainMapperTableManager.cxx |   10 ++
 writerfilter/source/dmapper/DomainMapperTableManager.hxx |7 +++
 writerfilter/source/dmapper/TablePropertiesHandler.cxx   |8 +++-
 5 files changed, 37 insertions(+), 1 deletion(-)

New commits:
commit 0208ead70a9412ccd554fcef3e9308f8ca17037b
Author: Miklos Vajna 
Date:   Fri Feb 22 17:08:39 2013 +0100

DOCX import: improve btLr table cell support

The problem was that in case the contents didn't fit into a single line,
multiple lines were created, which is not what btLr wants. Set the size
type to fixed in this case.

Change-Id: Ibab1313f95dc16dd0366d21a00109a6f38fa3526

diff --git a/sw/qa/extras/ooxmlimport/data/tblr-height.docx 
b/sw/qa/extras/ooxmlimport/data/tblr-height.docx
new file mode 100755
index 000..6a16c81
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tblr-height.docx 
differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index eec5e70..f6eb0ef 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -51,6 +51,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include 
 
@@ -115,6 +116,7 @@ public:
 void testN793998();
 void testGroupshapeLine();
 void testN779642();
+void testTbLrHeight();
 
 CPPUNIT_TEST_SUITE(Test);
 #if !defined(MACOSX) && !defined(WNT)
@@ -182,6 +184,7 @@ void Test::run()
 {"n793998.docx", &Test::testN793998},
 {"groupshape-line.docx", &Test::testGroupshapeLine},
 {"n779642.docx", &Test::testN779642},
+{"tblr-height.docx", &Test::testTbLrHeight},
 };
 header();
 for (unsigned int i = 0; i < SAL_N_ELEMENTS(aMethods); ++i)
@@ -1183,6 +1186,16 @@ void Test::testN779642()
 CPPUNIT_ASSERT_EQUAL_MESSAGE("Wrong vertical orientation relation", 
nValue, text::RelOrientation::PAGE_PRINT_AREA);
 }
 
+void Test::testTbLrHeight()
+{
+uno::Reference xTextTablesSupplier(mxComponent, 
uno::UNO_QUERY);
+uno::Reference 
xTables(xTextTablesSupplier->getTextTables(), uno::UNO_QUERY);
+uno::Reference xTable(xTables->getByIndex(0), 
uno::UNO_QUERY);
+uno::Reference xTableRows(xTable->getRows(), 
uno::UNO_QUERY);
+// btLr text direction was imported as MIN, it should be FIX to avoid 
incorrectly large height in case of too much content.
+CPPUNIT_ASSERT_EQUAL(text::SizeType::FIX, 
getProperty(xTableRows->getByIndex(0), "SizeType"));
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(Test);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx 
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index d3ddf82..1f9853b 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -52,6 +52,7 @@ DomainMapperTableManager::DomainMapperTableManager(bool 
bOOXML) :
 m_nTableWidth(0),
 m_bOOXML( bOOXML ),
 m_bPushCurrentWidth(false),
+m_bRowSizeTypeInserted(false),
 m_pTablePropsHandler( new TablePropertiesHandler( bOOXML ) )
 {
 m_pTablePropsHandler->SetTableManager( this );
@@ -261,10 +262,18 @@ bool DomainMapperTableManager::sprm(Sprm & rSprm)
 SAL_INFO( "writerfilter", "Have inserted textDirection 
" << nIntValue );
 break;
 case 3:  // btLr
+{
 // We have to fake this text direction
  pPropMap->Insert( PROP_FRM_DIRECTION, false, 
uno::makeAny( text::WritingMode2::LR_TB ));
  pPropMap->Insert( PROP_CHAR_ROTATION, false, 
uno::makeAny( sal_Int16( 900 ) ));
 SAL_INFO( "writerfilter", "Have inserted textDirection 
" << nIntValue );
+
+// We're faking a text direction, so don't allow 
multiple lines.
+TablePropertyMapPtr pRowPropMap( new TablePropertyMap 
);
+pRowPropMap->Insert(PROP_SIZE_TYPE, false, 
uno::makeAny(text::SizeType::FIX));
+m_bRowSizeTypeInserted = true;
+insertRowProps(pRowPropMap);
+}
 break;
 case 4: // lrTbV
 pPropMap->Insert( PROP_FRM_DIRECTION, false, 
uno::makeAny( text::WritingMode2::LR_TB ));
@@ -583,6 +592,7 @@ void DomainMapperTableManager::endOfRowAction()
 pCellWidths->clear();
 
 m_nGridBefore = m_nGridAfter = 0;
+m_bRowSizeTypeInserted = false;
 
 #ifdef DEBUG_DOMAINMAPPER
 dmapper_logger->endElement();
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.hxx 
b/writerfilter/source/dmapper/DomainMapperTableManager.hxx
index d3164ea..6ae6b1c 100644
---

[Libreoffice-commits] core.git: vcl/inc vcl/source

2013-02-22 Thread Chr . Rossmanith

 vcl/inc/toolbox.h  |3 +
 vcl/source/window/toolbox2.cxx |   69 -
 2 files changed, 18 insertions(+), 54 deletions(-)

New commits:
commit 5dff2d0822bb299c134a05a64747ce1bb42ad7cd
Author: Chr. Rossmanith 
Date:   Thu Feb 21 22:56:21 2013 +0100

Replace duplicate code from ImplToolItem constructors with init method

Change-Id: I2e2950045d8970eec3d1e04269bfe2ecbc9c3e6f
Reviewed-on: https://gerrit.libreoffice.org/2267
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/vcl/inc/toolbox.h b/vcl/inc/toolbox.h
index 0547e57..7fa82d9 100644
--- a/vcl/inc/toolbox.h
+++ b/vcl/inc/toolbox.h
@@ -107,6 +107,9 @@ struct ImplToolItem
 
 // returns sal_True if the toolbar item is currently clipped, which can 
happen for docked toolbars
 sal_Bool IsClipped() const;
+
+private:
+void init(sal_uInt16 nItemId, ToolBoxItemBits nItemBits, sal_Bool 
bEmptyBtn);
 };
 
 namespace vcl
diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index 081f524..85f7ca9 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -86,24 +86,30 @@ ImplToolBoxPrivateData::~ImplToolBoxPrivateData()
 }
 
 // ---
-ImplToolItem::ImplToolItem()
+void ImplToolItem::init(sal_uInt16 nItemId, ToolBoxItemBits nItemBits,
+sal_Bool bEmptyBtn)
 {
-mnId= 0;
+mnId= nItemId;
 mpWindow= NULL;
 mpUserData  = NULL;
 meType  = TOOLBOXITEM_BUTTON;
-mnBits  = 0;
+mnBits  = nItemBits;
 meState = STATE_NOCHECK;
 mbEnabled   = sal_True;
 mbVisible   = sal_True;
-mbEmptyBtn  = sal_True;
+mbEmptyBtn  = bEmptyBtn;
 mbShowWindow= sal_False;
 mbBreak = sal_False;
 mnSepSize   = TB_SEP_SIZE;
 mnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH;
 mnImageAngle= 0;
-mbMirrorMode= sal_False;
-mbVisibleText   = sal_False;
+mbMirrorMode= false;
+mbVisibleText   = false;
+}
+
+ImplToolItem::ImplToolItem()
+{
+init(0, 0, sal_True);
 }
 
 // ---
@@ -112,22 +118,7 @@ ImplToolItem::ImplToolItem( sal_uInt16 nItemId, const 
Image& rImage,
 ToolBoxItemBits nItemBits ) :
 maImage( rImage )
 {
-mnId= nItemId;
-mpWindow= NULL;
-mpUserData  = NULL;
-meType  = TOOLBOXITEM_BUTTON;
-mnBits  = nItemBits;
-meState = STATE_NOCHECK;
-mbEnabled   = sal_True;
-mbVisible   = sal_True;
-mbEmptyBtn  = sal_False;
-mbShowWindow= sal_False;
-mbBreak = sal_False;
-mnSepSize   = TB_SEP_SIZE;
-mnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH;
-mnImageAngle= 0;
-mbMirrorMode= false;
-mbVisibleText   = false;
+init(nItemId, nItemBits, sal_False);
 }
 
 // ---
@@ -136,22 +127,7 @@ ImplToolItem::ImplToolItem( sal_uInt16 nItemId, const 
XubString& rText,
 ToolBoxItemBits nItemBits ) :
 maText( rText )
 {
-mnId= nItemId;
-mpWindow= NULL;
-mpUserData  = NULL;
-meType  = TOOLBOXITEM_BUTTON;
-mnBits  = nItemBits;
-meState = STATE_NOCHECK;
-mbEnabled   = sal_True;
-mbVisible   = sal_True;
-mbEmptyBtn  = sal_False;
-mbShowWindow= sal_False;
-mbBreak = sal_False;
-mnSepSize   = TB_SEP_SIZE;
-mnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH;
-mnImageAngle= 0;
-mbMirrorMode= false;
-mbVisibleText   = false;
+init(nItemId, nItemBits, sal_False);
 }
 
 // ---
@@ -161,22 +137,7 @@ ImplToolItem::ImplToolItem( sal_uInt16 nItemId, const 
Image& rImage,
 maImage( rImage ),
 maText( rText )
 {
-mnId= nItemId;
-mpWindow= NULL;
-mpUserData  = NULL;
-meType  = TOOLBOXITEM_BUTTON;
-mnBits  = nItemBits;
-meState = STATE_NOCHECK;
-mbEnabled   = sal_True;
-mbVisible   = sal_True;
-mbEmptyBtn  = sal_False;
-mbShowWindow= sal_False;
-mbBreak = sal_False;
-mnSepSize   = TB_SEP_SIZE;
-mnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH;
-mnImageAngle= 0;
-mbMirrorMode= false;
-mbVisibleText   = false;
+init(nItemId, nItemBits, sal_False);
 }
 
 // ---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: drawinglayer/source

2013-02-22 Thread Tor Lillqvist

 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx |2 --
 1 file changed, 2 deletions(-)

New commits:
commit 6b59ccd5d4edb981496122a2d78cedaa052f0c70
Author: Tor Lillqvist 
Date:   Fri Feb 22 18:25:44 2013 +0200

WaE: unused variable

Change-Id: I108ea85db7904e31cbeb1cd2dec89cb1cdf6275b

diff --git a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx 
b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
index 98dc1ca..ef1c7ba 100644
--- a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
@@ -392,7 +392,6 @@ namespace drawinglayer
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
 basegfx::B2DHomMatrix aUnitGradientToObject;
-static bool bInterpretAbsolute(true);
 
 if(getUseUnitCoordinates())
 {
@@ -720,7 +719,6 @@ namespace drawinglayer
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
 basegfx::B2DHomMatrix aUnitGradientToObject;
-static bool bInterpretAbsolute(true);
 
 if(getUseUnitCoordinates())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source

2013-02-22 Thread Michael Stahl

 dbaccess/source/core/misc/dsntypes.cxx |   26 ++
 1 file changed, 14 insertions(+), 12 deletions(-)

New commits:
commit 5677e3f2514d5b797c239d99edce0189d5cf364b
Author: Michael Stahl 
Date:   Fri Feb 22 17:15:16 2013 +0100

fix strings more in 1da3af5f1eb6a32fd0ab10da7cf2f8ddb298a3a1

Change-Id: I7d4cf698721fcf972bf35babb6d53369719eed18

diff --git a/dbaccess/source/core/misc/dsntypes.cxx 
b/dbaccess/source/core/misc/dsntypes.cxx
index 29ac584..e9c48e2 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -337,19 +337,21 @@ ODsnTypeCollection::TypeIterator 
ODsnTypeCollection::end() const
 DATASOURCE_TYPE ODsnTypeCollection::determineType(const OUString& _rDsn) const
 {
 OUString sDsn(comphelper::string::stripEnd(_rDsn, '*'));
-sal_uInt16 nSeparator = sDsn.indexOf((sal_Unicode)':');
-if (STRING_NOTFOUND == nSeparator)
+sal_Int32 nSeparator = sDsn.indexOf(static_cast(':'));
+if (-1 == nSeparator)
 {
 // there should be at least one such separator
 OSL_FAIL("ODsnTypeCollection::implDetermineType : missing the colon 
!");
 return DST_UNKNOWN;
 }
 // find first :
-sal_uInt16 nOracleSeparator = sDsn.indexOf((sal_Unicode)':', nSeparator + 
1);
-if ( nOracleSeparator != STRING_NOTFOUND )
+sal_Int32 nOracleSeparator =
+sDsn.indexOf(static_cast(':'), nSeparator + 1);
+if (-1 != nOracleSeparator)
 {
-nOracleSeparator = sDsn.indexOf((sal_Unicode)':', nOracleSeparator + 
1);
-if (nOracleSeparator != STRING_NOTFOUND && 
sDsn.equalsIgnoreAsciiCaseAsciiL("jdbc:oracle:thin", nOracleSeparator))
+nOracleSeparator =
+sDsn.indexOf(static_cast(':'), nOracleSeparator + 1);
+if (-1 != nOracleSeparator && 
sDsn.equalsIgnoreAsciiCaseAsciiL("jdbc:oracle:thin", nOracleSeparator))
 return DST_ORACLE_JDBC;
 }
 
@@ -360,8 +362,8 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString& _rDsn) const
 return DST_EMBEDDED_HSQLDB;
 
 // find second :
-nSeparator = sDsn.indexOf((sal_Unicode)':', nSeparator + 1);
-if (STRING_NOTFOUND == nSeparator)
+nSeparator = sDsn.indexOf(static_cast(':'), nSeparator + 1);
+if (-1 == nSeparator)
 {
 // at the moment only jdbc is allowed to have just one separator
 OSL_FAIL("ODsnTypeCollection::implDetermineType : missing the second 
colon !");
@@ -370,11 +372,11 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const 
OUString& _rDsn) const
 
 if (sDsn.equalsIgnoreAsciiCaseAsciiL("sdbc:ado:", nSeparator))
 {
-nSeparator = sDsn.indexOf((sal_Unicode)':', nSeparator + 1);
-if (STRING_NOTFOUND != nSeparator && 
sDsn.equalsIgnoreAsciiCaseAsciiL("sdbc:ado:access", nSeparator) )
+nSeparator = sDsn.indexOf(static_cast(':'), nSeparator + 
1);
+if (-1 != nSeparator && 
sDsn.equalsIgnoreAsciiCaseAsciiL("sdbc:ado:access", nSeparator) )
 {
-nSeparator = sDsn.indexOf((sal_Unicode)';', nSeparator + 1);
-if (STRING_NOTFOUND != nSeparator && 
sDsn.equalsIgnoreAsciiCaseAsciiL("sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0",
 nSeparator) )
+nSeparator = sDsn.indexOf(static_cast(';'), 
nSeparator + 1);
+if (-1 != nSeparator && 
sDsn.equalsIgnoreAsciiCaseAsciiL("sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0",
 nSeparator) )
 return DST_MSACCESS_2007;
 
 return DST_MSACCESS;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Looking for PyUno Contributor(s)

2013-02-22 Thread Stephan Bergmann


On 02/20/2013 04:11 PM, Joel Madero wrote:

I am one of the members of the Quality Assurance team with LibreOffice
and we are looking for a volunteer to work with myself designing (and
coding) the framework to start automating our stats. It's been on my
list for much too long and I just don't have the technical know how to
do it. If there are are users or developers who can slowly get this
accomplished it would greatly help QA as well as Marketing as our stats
are done almost completely manually at this point, not only is this time
consuming but it's also likely that there could be mistakes or missing
data.


How is the above related to PyUno (i.e., the Python-UNO bridge)?

Stephan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Help update - Hyperlink Bar removal

2013-02-22 Thread Stanislav Horáček

I'll try to explain it:

The patch should remove all the stuff related to this page:
https://help.libreoffice.org/Common/Hyperlink_Bar - which should be
completely obsolete. The page itself was removed by the patch you
mentioned, but subpages describing buttons of the bar still remains. If
there is some of the buttons in UI the help must be kept, but I think they
are gone.

Insert->hyperlink is still covered by the page
https://help.libreoffice.org/Common/Inserting_Hyperlinks

Regards,
Stan


2013/2/22 Caolán McNamara 

> On Sun, 2013-02-10 at 17:41 +0100, Stanislav Horáček wrote:
> > Hi,
> >
> > this patch for help removes the pages related to the Hyperlink Bar which
> was - if I understand it
> > correctly - removed from LO completely.
>
> Your patch seems to remove the help for e.g. insert->hyperlink which we
> still have, so we don't want to remove that. What we removed, IIRC, was
> the hyperlink bar which was a different thing.
>
> http://cgit.freedesktop.org/libreoffice/help/commit/?id=54108f6fd3f8355d12db0217d21fbab9dccf5ed8
> removed the help for that, or at least most of it. I don't see any
> existing references in our help to that removed bar, or is there some
> still left ?
>
> https://bugs.freedesktop.org/show_bug.cgi?id=43915 suggests that it was
> still mentioned in the help at one stage in 3.4, but that it got fixed
> for 3.5
>
> C.
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - drawinglayer/inc drawinglayer/source svgio/source

2013-02-22 Thread Armin Le Grand

 drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx |9 +
 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx   |   83 
+++---
 svgio/source/svgreader/svgstyleattributes.cxx|2 
 3 files changed, 71 insertions(+), 23 deletions(-)

New commits:
commit 708a937a2bcd7ab70e55466ab263b9b94b5cd638
Author: Armin Le Grand 
Date:   Thu Feb 21 17:51:40 2013 +0100

#120616# Corrected SVG gradient primitive and it's decomposition

Signed-off-by: Petr Mladek 

Conflicts:

drawinglayer/source/primitive2d/svggradientprimitive2d.cxx

Change-Id: I04c148303e7153a5376eae79803c540f6eba0b00
Signed-off-by: Petr Mladek 

diff --git 
a/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx 
b/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
index 39115a7..2c9e34f 100644
--- a/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
+++ b/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
@@ -111,6 +111,11 @@ namespace drawinglayer
 boolmbSingleEntry : 1;
 boolmbFullyOpaque : 1;
 
+// true = interpret in unit coordinate system -> object aspect 
ratio will scale result
+// false = interpret in object coordinate system -> object aspect 
ratio will not scale result
+// (related to SVG's gradientUnits 
(userSpaceOnUse|objectBoundingBox)
+boolmbUseUnitCoordinates : 1;
+
 protected:
 /// local helpers
 Primitive2DSequence createSingleGradientEntryFill() const;
@@ -145,6 +150,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& rPolyPolygon,
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad);
virtual ~SvgGradientHelper() {}
 
@@ -152,6 +158,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& getPolyPolygon() const { return 
maPolyPolygon; }
 const SvgGradientEntryVector& getGradientEntries() const { return 
maGradientEntries; }
 const basegfx::B2DPoint& getStart() const { return maStart; }
+bool getUseUnitCoordinates() const { return mbUseUnitCoordinates; }
 SpreadMethod getSpreadMethod() const { return maSpreadMethod; }
 
 /// compare operator
@@ -194,6 +201,7 @@ namespace drawinglayer
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
 const basegfx::B2DPoint& rEnd,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad);
 virtual ~SvgLinearGradientPrimitive2D() {}
 
@@ -261,6 +269,7 @@ namespace drawinglayer
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
 double fRadius,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad,
 const basegfx::B2DPoint* pFocal = 0);
 
diff --git a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx 
b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
index a8c60da..98dc1ca 100644
--- a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
@@ -283,6 +283,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& rPolyPolygon,
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod)
 :   maPolyPolygon(rPolyPolygon),
 maGradientEntries(rGradientEntries),
@@ -291,7 +292,8 @@ namespace drawinglayer
 mbPreconditionsChecked(false),
 mbCreatesContent(false),
 mbSingleEntry(false),
-mbFullyOpaque(true)
+mbFullyOpaque(true),
+mbUseUnitCoordinates(bUseUnitCoordinates)
 {
 }
 
@@ -302,6 +304,7 @@ namespace drawinglayer
 return (getPolyPolygon() == rCompare.getPolyPolygon()
 && getGradientEntries() == rCompare.getGradientEntries()
 && getStart() == rCompare.getStart()
+&& getUseUnitCoordinates() == rCompare.getUseUnitCoordinates()
 && getSpreadMethod() == rCompare.getSpreadMethod());
 }
 
@@ -388,20 +391,37 @@ namespace drawinglayer
 basegfx::tools::createScaleTranslateB2DHomMatrix(
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
+basegfx::B2DHomMatrix aUnitGradientToObject;
+static bo

[Libreoffice-commits] core.git: drawinglayer/inc drawinglayer/source svgio/source

2013-02-22 Thread Armin Le Grand

 drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx |9 +
 drawinglayer/source/primitive2d/svggradientprimitive2d.cxx   |   83 
+++---
 svgio/source/svgreader/svgstyleattributes.cxx|2 
 3 files changed, 71 insertions(+), 23 deletions(-)

New commits:
commit 99501a839f6d777c24bc9210787fd14dc3aad67d
Author: Armin Le Grand 
Date:   Thu Feb 21 17:51:40 2013 +0100

#120616# Corrected SVG gradient primitive and it's decomposition

Conflicts:

drawinglayer/source/primitive2d/svggradientprimitive2d.cxx

Change-Id: I04c148303e7153a5376eae79803c540f6eba0b00

diff --git 
a/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx 
b/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
index 39115a7..2c9e34f 100644
--- a/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
+++ b/drawinglayer/inc/drawinglayer/primitive2d/svggradientprimitive2d.hxx
@@ -111,6 +111,11 @@ namespace drawinglayer
 boolmbSingleEntry : 1;
 boolmbFullyOpaque : 1;
 
+// true = interpret in unit coordinate system -> object aspect 
ratio will scale result
+// false = interpret in object coordinate system -> object aspect 
ratio will not scale result
+// (related to SVG's gradientUnits 
(userSpaceOnUse|objectBoundingBox)
+boolmbUseUnitCoordinates : 1;
+
 protected:
 /// local helpers
 Primitive2DSequence createSingleGradientEntryFill() const;
@@ -145,6 +150,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& rPolyPolygon,
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad);
virtual ~SvgGradientHelper() {}
 
@@ -152,6 +158,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& getPolyPolygon() const { return 
maPolyPolygon; }
 const SvgGradientEntryVector& getGradientEntries() const { return 
maGradientEntries; }
 const basegfx::B2DPoint& getStart() const { return maStart; }
+bool getUseUnitCoordinates() const { return mbUseUnitCoordinates; }
 SpreadMethod getSpreadMethod() const { return maSpreadMethod; }
 
 /// compare operator
@@ -194,6 +201,7 @@ namespace drawinglayer
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
 const basegfx::B2DPoint& rEnd,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad);
 virtual ~SvgLinearGradientPrimitive2D() {}
 
@@ -261,6 +269,7 @@ namespace drawinglayer
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
 double fRadius,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod = Spread_pad,
 const basegfx::B2DPoint* pFocal = 0);
 
diff --git a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx 
b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
index a8c60da..98dc1ca 100644
--- a/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
+++ b/drawinglayer/source/primitive2d/svggradientprimitive2d.cxx
@@ -283,6 +283,7 @@ namespace drawinglayer
 const basegfx::B2DPolyPolygon& rPolyPolygon,
 const SvgGradientEntryVector& rGradientEntries,
 const basegfx::B2DPoint& rStart,
+bool bUseUnitCoordinates,
 SpreadMethod aSpreadMethod)
 :   maPolyPolygon(rPolyPolygon),
 maGradientEntries(rGradientEntries),
@@ -291,7 +292,8 @@ namespace drawinglayer
 mbPreconditionsChecked(false),
 mbCreatesContent(false),
 mbSingleEntry(false),
-mbFullyOpaque(true)
+mbFullyOpaque(true),
+mbUseUnitCoordinates(bUseUnitCoordinates)
 {
 }
 
@@ -302,6 +304,7 @@ namespace drawinglayer
 return (getPolyPolygon() == rCompare.getPolyPolygon()
 && getGradientEntries() == rCompare.getGradientEntries()
 && getStart() == rCompare.getStart()
+&& getUseUnitCoordinates() == rCompare.getUseUnitCoordinates()
 && getSpreadMethod() == rCompare.getSpreadMethod());
 }
 
@@ -388,20 +391,37 @@ namespace drawinglayer
 basegfx::tools::createScaleTranslateB2DHomMatrix(
 fPolyWidth, fPolyHeight,
 aPolyRange.getMinX(), aPolyRange.getMinY()));
+basegfx::B2DHomMatrix aUnitGradientToObject;
+static bool bInterpretAbsolute(true);
 
-// create unit transf

Re: C++ extensions requiring LIBO_UDK_4.1

2013-02-22 Thread Alex Thurgood


Le 22/02/2013 16:30, Michael Stahl a écrit :





it's possible that this is because it requires functions that were added
after the 4.0 release on master (i suspect this happens automatically
due to some OUString changes); for example here i'm getting a dependency
on LIBO_UDK_4.1 symbol version, which none of the current releases supply.



Two questions, both of which may be dumb, because I don't really know 
what is going on here, but :


Shouldn't it default to the lowest common denominator, i.e. 3.6 ?

Is this only a problem with symbol-enabled builds ?

Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: dbaccess/source

2013-02-22 Thread Michael Stahl

 dbaccess/source/ui/dlg/DbAdminImpl.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 03a381eaa58d77cf26dfa8d916d1ecda865c1937
Author: Michael Stahl 
Date:   Fri Feb 22 16:38:00 2013 +0100

fix string conversion 1da3af5f1eb6a32fd0ab10da7cf2f8ddb298a3a1

Change-Id: I18f80b5fd6aa11ed78fe2b1bee3cb9f843cf203e

diff --git a/dbaccess/source/ui/dlg/DbAdminImpl.cxx 
b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
index 9962d6f..e79538a 100644
--- a/dbaccess/source/ui/dlg/DbAdminImpl.cxx
+++ b/dbaccess/source/ui/dlg/DbAdminImpl.cxx
@@ -260,11 +260,12 @@ sal_Bool 
ODbDataSourceAdministrationHelper::getCurrentSettings(Sequence< Propert
 OUString sTemp = sName;
 sName = ::dbaui::getStrippedDatabaseName(NULL,sTemp);
 if ( sName.getLength() )
-sLoginRequest.replaceAll("$name$", sName);
+sLoginRequest = sLoginRequest.replaceAll("$name$", sName);
 else
 {
-sLoginRequest.replaceAll("\"$name$\"", OUString());
-sLoginRequest.replaceAll("$name$", OUString()); // just to be 
sure that in other languages the string will be deleted
+sLoginRequest = sLoginRequest.replaceAll("\"$name$\"", 
OUString());
+// ensure that in other languages the string will be deleted
+sLoginRequest = sLoginRequest.replaceAll("$name$", OUString());
 }
 
 // the request
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: officecfg/registry

2013-02-22 Thread Petr Mladek

 officecfg/registry/data/org/openoffice/Setup.xcu |   15 ++-
 1 file changed, 14 insertions(+), 1 deletion(-)

New commits:
commit 48bf145cf4f84703b9920e2cffafbba448ae7ae1
Author: Petr Mladek 
Date:   Fri Feb 22 14:38:08 2013 +0100

migrate even more configuration setting (fdo#57061)

+ application windows size
+ I was afraid to migrate any /org.openoffice.Setup stuff
  because there seemed to be many hardcoded values;
  But the parts mentioned in registrymodifications.xcu
  should be configurable and thus safe to migrate
+ âEnable macro recordingâ and âEnable experimental featuresâ 
options
+ sigh, we do not want to migrate
  /org.openoffice.Office.Common/Misc/FirstRun; thus we need to
  explicitely mention all the other items which is error prone
+ Tools/Options/LibreOffice/Paths/My documents
+ ah, the paths are handled on two locations: 
/org.openoffice.Office.Paths
  and /org.openoffice.Office.Common/Path
+ Macros
+ I was afraid to copy user/basic because there were some content
  out of box. I though that it might be version specific. In fact,
  the default content is just empty templates that look the same
  even in old releases => it should be secure to copy it after all

Change-Id: Ie1c04e9df36f6b6961bbaaeb922e29d64128ade4

diff --git a/officecfg/registry/data/org/openoffice/Setup.xcu 
b/officecfg/registry/data/org/openoffice/Setup.xcu
index b4e5e7c..6bca381 100644
--- a/officecfg/registry/data/org/openoffice/Setup.xcu
+++ b/officecfg/registry/data/org/openoffice/Setup.xcu
@@ -824,6 +824,7 @@
   
 .*/autotext/.*
 .*/autocorr/.*
+.*/basic/.*
 .*/config/.*\.so[bcdegh]
 .*/config/soffice.cfg/modules/.*/menubar/.*\.xml
 .*/config/soffice.cfg/modules/.*/statusbar/.*\.xml
@@ -860,16 +861,23 @@
 /org.openoffice.Office.Common/I18N
 /org.openoffice.Office.Common/InternalMSExport
 /org.openoffice.Office.Common/Load
+/org.openoffice.Office.Common/Misc/AlwaysAllowSave
+
/org.openoffice.Office.Common/Misc/DisableUICustomization
+/org.openoffice.Office.Common/Misc/ExperimentalMode
 
/org.openoffice.Office.Common/Misc/FormControlPilotsEnabled
+/org.openoffice.Office.Common/Misc/MacroRecorderMode
 /org.openoffice.Office.Common/Misc/PluginsEnabled
+
/org.openoffice.Office.Common/Misc/ShowLinkWarningDialog
 /org.openoffice.Office.Common/Misc/SymbolSet
+/org.openoffice.Office.Common/Misc/SymbolStyle
+/org.openoffice.Office.Common/Misc/ToolboxStyle
 /org.openoffice.Office.Common/Misc/UseSystemFileDialog
 
/org.openoffice.Office.Common/Misc/UseSystemPrintDialog
-/org.openoffice.Office.Common/Misc/SymbolStyle
 
/org.openoffice.Office.Common/Misc/FilePickerPlacesNames
 
/org.openoffice.Office.Common/Misc/FilePickerPlacesUrls
 /org.openoffice.Office.Common/ODF
 /org.openoffice.Office.Common/Passwords
+/org.openoffice.Office.Common/Path
 
/org.openoffice.Office.Common/Print/PrintingModifiesDocument
 /org.openoffice.Office.Common/Print/Warning
 /org.openoffice.Office.Common/Vectorize
@@ -937,6 +945,11 @@
   /org.openoffice.Office.Security
 
   
+  
+
+  /org.openoffice.Setup/Office/Factories
+
+  
   
 
   /org.openoffice.Office.UI/ColorScheme
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

C++ extensions requiring LIBO_UDK_4.1 (was: Re: Mysql Connector Extension Size Confusion)

2013-02-22 Thread Michael Stahl

On 22/02/13 15:53, Alexander Thurgood wrote:
> Le 22/02/2013 15:42, Fridrich Strba a écrit :
> 
> Hi Fridrich,
> 
> 
>> Did you try whether it works? Maybe the question is only moot. Just 
>> saying. F. 
> 
> 
> All I know is that the "new gbuild" one doesn't work on other people's 
> systems, as I have made the connector available for download from my 
> Dropbox account (both 32bit and 64bit Linux versions) for testing 
> purposes. It works on my own dev-install build.

it's possible that this is because it requires functions that were added
after the 4.0 release on master (i suspect this happens automatically
due to some OUString changes); for example here i'm getting a dependency
on LIBO_UDK_4.1 symbol version, which none of the current releases supply.

>  > readelf --version-info /work/lo/master/solver/unxlngx6/lib/mysqlc.uno.so  
> | grep LIBO_UDK
>   01c:   a (LIBO_UDK_3.6)   4 (UDK_3_0_0) 2 (UDK_3_0_0) 4 (UDK_3_0_0) 
>  
>   08c:  12 (LIBO_UDK_4.1)   7 (UDK_3_0_0) 4 (UDK_3_0_0) b 
> (CXXABI_1.3) 
>   0x0030:   Name: LIBO_UDK_4.1  Flags: none  Version: 18
>   0x0060:   Name: LIBO_UDK_3.6  Flags: none  Version: 10

i'm not sure if this affects only extensions built with LO build system
or also those build with ODK.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Implementing alternate "compatibility" functions (such as 0^0 = ERROR)

2013-02-22 Thread Andrew Douglas Pitonyak



On 02/22/2013 04:51 AM, Michael Meeks wrote:

On Thu, 2013-02-21 at 21:50 -0600, Norbert Thiebaud wrote:

The issue is purely academic, but if it _has_ to be resolved then yes
a compatibility mode has a much better value that creating an
'alternate' function.

True - though clearly there is some residual benefit in importing ODF
files with this sort of function in them - luckily there is a ~zero
deployed-base of that so far.

As a general yard-stick, we take function compatibility with Excel
extremely seriously - it is clearly imperative to our users to have
confidence that their spreadsheets continue to work as they move to the
world of ODF implementations.

Having said that - when it comes to corner-cases we have much bigger
problems in this area than this issue. One example would be the absence
of a true 'boolean' type in our core; such that when you run the
gnumeric test sheet here:

http://git.gnome.org/browse/gnumeric/plain/samples/excel/operator.xls

you can ponder at length whether: '=TRUE() > "Liz"' should be true or
false for example ;-)

So - IMHO there is little value at all in further discussion on this
topic, and backwards-compatibility with ODF + numeric sanity trumps the
corner-case at least until we have a much more consistent set of
corner-case solutions.

But of course, I would defer to the calc team; and as Tor and Norbert
says - -strongly- discourage an endless bike-shed on this from those
outside the set of people who have already contributed code to calc.

All the best :-)

Michael.

My opinion is that it is probably useful to document any known issues, 
especially issues that may be considered for implementation. If we are 
able to identify issues, especially issues with "easy" solutions, then 
those can be added to the list of easy things to do in LO for new 
contributors.


Norbert, along this same line, you stated:


I think there are many more interop problems with much more visible
and real-life effect that would be a better use of one's time.


Do you consider any of these "visible" issues as something that can be posed as 
"easy things for a developer new to LO to attempt"?


--
Andrew Pitonyak
My Macro Document: http://www.pitonyak.org/AndrewMacro.odt
Info:  http://www.pitonyak.org/oo.php

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sfx2/source

2013-02-22 Thread Stephan Bergmann

 sfx2/source/doc/guisaveas.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 555d09b57892389fb0c34510da780f31912e47ef
Author: Stephan Bergmann 
Date:   Fri Feb 22 16:12:25 2013 +0100

Better debugging messages

Change-Id: I7c10329f87edfe5d6f801c0aa70e1f6860780c8b

diff --git a/sfx2/source/doc/guisaveas.cxx b/sfx2/source/doc/guisaveas.cxx
index d603ce5..e6fd041 100644
--- a/sfx2/source/doc/guisaveas.cxx
+++ b/sfx2/source/doc/guisaveas.cxx
@@ -595,8 +595,9 @@ sal_Bool ModelData_Impl::ExecuteFilterDialog_Impl( const 
::rtl::OUString& aFilte
 {
 throw;
 }
-catch( const uno::Exception& )
+catch( const uno::Exception& e )
 {
+SAL_WARN("sfx2.doc", "ignoring UNO exception " << e.Message);
 }
 
 return bDialogUsed;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Mysql Connector Extension Size Confusion

2013-02-22 Thread Alexander Thurgood


Le 22/02/2013 15:42, Fridrich Strba a écrit :

Hi Fridrich,


Did you try whether it works? Maybe the question is only moot. Just 
saying. F. 



All I know is that the "new gbuild" one doesn't work on other people's 
systems, as I have made the connector available for download from my 
Dropbox account (both 32bit and 64bit Linux versions) for testing 
purposes. It works on my own dev-install build.



Alex
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - writerperfect/source

2013-02-22 Thread Fridrich Štrba

 writerperfect/source/filter/OdgGenerator.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 4c0e53e6530c5590f7123f506a1a58bcbd04e13d
Author: Fridrich Å trba 
Date:   Tue Feb 19 16:44:51 2013 +0100

Allow specifying of page names

Allow specifying of page names
(cherry picked from commit bee8ed6772f420f9eefc57fee01da29ff466a8e9)

We need to escape special characters in slide names
(cherry picked from commit ea4581a914cb1aad29f16b73e35350f05f8adc1c)

Change-Id: I5f523642b980469afa46e1895cfd39aa08b9941d
Reviewed-on: https://gerrit.libreoffice.org/2333
Reviewed-by: Bosdonnat Cedric 
Tested-by: Bosdonnat Cedric 

diff --git a/writerperfect/source/filter/OdgGenerator.cxx 
b/writerperfect/source/filter/OdgGenerator.cxx
index 8661138..1caebdd 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -664,7 +664,10 @@ void OdgGenerator::startGraphics(const ::WPXPropertyList 
&propList)
 TagOpenElement *pStylePageLayoutOpenElement = new 
TagOpenElement("style:page-layout");
 
 WPXString sValue;
-sValue.sprintf("page%i", mpImpl->miPageIndex);
+if (propList["draw:name"])
+sValue = WPXString(propList["draw:name"]->getStr(), true); // escape 
special xml characters
+else
+sValue.sprintf("page%i", mpImpl->miPageIndex);
 pDrawPageOpenElement->addAttribute("draw:name", sValue);
 #ifdef MULTIPAGE_WORKAROUND
 pStyleMasterPageOpenElement->addAttribute("style:page-layout-name", "PM0");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Mysql Connector Extension Size Confusion

2013-02-22 Thread Fridrich Strba

Alex,

On 22/02/13 15:35, Alex Thurgood wrote:
> So, here are the differences :
> 
> Both contain libmysqlcppconn and mysqlc.uno.so, but again have different
> file sizes (less of a difference in mysqlc.uno.so, but nonetheless a
> small difference). The libmysqlcppconn.so in the new build system is
> nearly 6 times a big - I'm trying to understand why that might be ?

Did you try whether it works? Maybe the question is only moot. Just saying.

F.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Mysql Connector Extension Size Confusion

2013-02-22 Thread Alex Thurgood


So, here are the differences :


unzip -l
Archive: 
/home/alex/Development/libo/core/workdir/unxlngx6.pro/ExtensionTarget/mysql-connector-ooo.oxt

  Length  DateTimeName
-  -- -   
0  2013-01-30 14:46   META-INF/
 1391  2013-02-13 12:20   META-INF/manifest.xml
  255  2013-01-30 11:41   description-en-US.txt
 1743  2013-02-13 12:20   description.xml
  838  2013-01-30 11:41   images/extension_32.png
  4722905  2013-02-10 11:51   libmysqlcppconn.so
  4180182  2013-02-13 12:19   mysqlc.uno.so
0  2013-01-30 14:46   registration/
   436392  2013-02-13 12:20   registration/LICENSE
 3561  2013-01-30 11:44 
registry/data/org/openoffice/Office/DataAccess/Drivers.xcu

  311  2013-02-10 14:26   components.rdb
- ---
  9347578 11 files




unzip -l
Archive: 
/home/alex/Development/libo/core/mysqlc/unxlngx6.pro/bin/mysql-connector-ooo.oxt

  Length  DateTimeName
-  -- -   
0  2013-01-03 03:44   META-INF/
 1392  2013-01-03 03:44   META-INF/manifest.xml
  255  2013-01-03 03:44   description-en-US.txt
 1743  2013-01-03 03:44   description.xml
0  2013-01-03 03:44   images/
  838  2013-01-03 03:44   images/extension_32.png
   739047  2013-01-03 03:44   libmysqlcppconn.so
  4186992  2013-01-03 03:44   mysqlc.uno.so
0  2013-01-03 03:44   registration/
   442492  2013-01-03 03:44   registration/LICENSE
0  2013-01-03 03:44   registry/
0  2013-01-03 03:44   registry/data/
0  2013-01-03 03:44   registry/data/org/
0  2013-01-03 03:44   registry/data/org/openoffice/
0  2013-01-03 03:44   registry/data/org/openoffice/Office/
0  2013-01-03 03:44 
registry/data/org/openoffice/Office/DataAccess/
 3561  2013-01-03 03:44 
registry/data/org/openoffice/Office/DataAccess/Drivers.xcu

- ---
  5376320 17 files


Both contain libmysqlcppconn and mysqlc.uno.so, but again have different 
file sizes (less of a difference in mysqlc.uno.so, but nonetheless a 
small difference). The libmysqlcppconn.so in the new build system is 
nearly 6 times a big - I'm trying to understand why that might be ?


Alex


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [libreoffice-accessibility] introduction

2013-02-22 Thread Sophie Gautier

Hi Jonathan,
On 22/02/2013 15:30, Jonathan Nadeau wrote:
> Thank you can you give me a link to join the developers list? Thanks
here is the link to subscribe
http://lists.freedesktop.org/mailman/listinfo/libreoffice

and the link to the archive with Caolan answer this morning
http://lists.freedesktop.org/archives/libreoffice/2013-February/046323.html

Kind regards
Sophie
> 
> 
> On 02/22/2013 03:29 AM, Sophie Gautier wrote:
>> Hi Jonathan,
>>
>> Thanks a lot for your proposal. I'm sending your mail to the developers
>> list so we are sure they are aware of it.
>>
>> Kind regards
>> Sophie
>> On 21/02/2013 23:33, Jonathan Nadeau wrote:
>>> Hello list,
>>>
>>> My name is Jonathan Nadeau and I'm the executive director of the
>>> Accessible Computing Foundation located here
>>>
>>> http://www.accessiblecomputingfoundation.org
>>>
>>> I'm looking to fund some developers to fix some accessibility bugs with
>>> Libreoffice and the Orca screen reader. I was hoping either someone on
>>> the list would be interested in fixing some bugs or that the list might
>>> know of some people that would like to earn some money to fix some bugs.
>>> Please let me know if this is not the right place to look for help or if
>>> there are any other suggestions. Thanks for your time and help.
>>>
>>
> 


-- 
Sophie Gautier 
Tel:+33683901545
Membership & Certification Committee Member - Co-founder
The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: src/lib

2013-02-22 Thread Libreoffice Gerrit user

 src/lib/VSD5Parser.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2cca79df4c7a46e54c40ab19a2afd779b059667e
Author: Fridrich Å trba 
Date:   Fri Feb 22 15:27:39 2013 +0100

Fix an error in order of variables

diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index 447dea7..1ccb7d8 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -431,8 +431,8 @@ void libvisio::VSD5Parser::readNameIDX(WPXInputStream 
*input)
   unsigned recordCount = readU16(input);
   for (unsigned i = 0; i < recordCount; ++i)
   {
-unsigned elementId = readU16(input);
 unsigned nameId = readU16(input);
+unsigned elementId = readU16(input);
 std::map::const_iterator iter = m_names.find(nameId);
 if (iter != m_names.end())
   names[elementId] = iter->second;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Mysql Connector Extension Size Confusion

2013-02-22 Thread Alex Thurgood


Le 22/02/2013 14:42, Michael Stahl a écrit :


-rw-rw-r-- 1 1000 1000 5379260 janv.  3 03:44
/home/alex/Development/libo/core/mysqlc/unxlngx6.pro/bin/mysql-connector-ooo.oxt


this is created by the old build system.


Ah, ok, so a "make clean" and rebuild might be in order here then.




-rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20
/home/alex/Development/libo/core/solver/unxlngx6.pro/bin/mysql-connector-ooo.oxt


-rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20
/home/alex/Development/libo/core/workdir/unxlngx6.pro/ExtensionTarget/mysql-connector-ooo.oxt


this is created by the new build system, to which mysqlc was migrated
earlier this year.



Hmm, that's what I thought, and that file size corresponds to those of 
previous connectors I had built and made available in the past on the 
extensions website.




you could check if there are any files missing in the oxt or anything
looks obviously wrong; last i checked it looked fine here but there are
apparently several different configure options that affect the extension
so YMMV.


Almost certainly will be something missing, am investigating now.


Alex



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: src/lib

2013-02-22 Thread Libreoffice Gerrit user

 src/lib/VSD5Parser.cpp |   18 +-
 src/lib/VSD5Parser.h   |2 +-
 src/lib/VSDDocumentStructure.h |1 +
 src/lib/VSDParser.cpp  |   24 +---
 src/lib/VSDParser.h|1 +
 5 files changed, 41 insertions(+), 5 deletions(-)

New commits:
commit d9358fa7e6eeaf9075042b0cc98909f5866aea8a
Author: Fridrich Å trba 
Date:   Fri Feb 22 15:14:47 2013 +0100

More page names for versions <= 5

diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index f49fafa..447dea7 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -381,7 +381,7 @@ void libvisio::VSD5Parser::readShape(WPXInputStream *input)
 void libvisio::VSD5Parser::readPage(WPXInputStream *input)
 {
   unsigned backgroundPageID = getUInt(input);
-  m_collector->collectPage(m_header.id, m_header.level, backgroundPageID, 
m_isBackgroundPage, VSDName());
+  m_collector->collectPage(m_header.id, m_header.level, backgroundPageID, 
m_isBackgroundPage, m_currentPageName);
 }
 
 void libvisio::VSD5Parser::readTextBlock(WPXInputStream *input)
@@ -424,6 +424,22 @@ void libvisio::VSD5Parser::readTextField(WPXInputStream 
*input)
   }
 }
 
+void libvisio::VSD5Parser::readNameIDX(WPXInputStream *input)
+{
+  VSD_DEBUG_MSG(("VSD5Parser::readNameIDX\n"));
+  std::map names;
+  unsigned recordCount = readU16(input);
+  for (unsigned i = 0; i < recordCount; ++i)
+  {
+unsigned elementId = readU16(input);
+unsigned nameId = readU16(input);
+std::map::const_iterator iter = m_names.find(nameId);
+if (iter != m_names.end())
+  names[elementId] = iter->second;
+  }
+  m_namesMapMap[m_header.level] = names;
+}
+
 
 unsigned libvisio::VSD5Parser::getUInt(WPXInputStream *input)
 {
diff --git a/src/lib/VSD5Parser.h b/src/lib/VSD5Parser.h
index d6cf0ae..64f4c6c 100644
--- a/src/lib/VSD5Parser.h
+++ b/src/lib/VSD5Parser.h
@@ -73,7 +73,7 @@ protected:
 
   virtual void readStyleSheet(WPXInputStream *input);
 
-  virtual void readNameIDX(WPXInputStream *) {}
+  virtual void readNameIDX(WPXInputStream *input);
 
   virtual unsigned getUInt(WPXInputStream *input);
   virtual int getInt(WPXInputStream *input);
diff --git a/src/lib/VSDDocumentStructure.h b/src/lib/VSDDocumentStructure.h
index b6a2c98..69fee18 100644
--- a/src/lib/VSDDocumentStructure.h
+++ b/src/lib/VSDDocumentStructure.h
@@ -52,6 +52,7 @@
 
 #define VSD_NAME_LIST2 0x32
 #define VSD_NAME2 0x33
+#define VSD_NAMEIDX123 0x34
 
 #define VSD_PAGE_SHEET 0x46
 #define VSD_SHAPE_GROUP 0x47
diff --git a/src/lib/VSDParser.cpp b/src/lib/VSDParser.cpp
index 84c2124..605f102 100644
--- a/src/lib/VSDParser.cpp
+++ b/src/lib/VSDParser.cpp
@@ -226,7 +226,7 @@ void libvisio::VSDParser::handleStreams(WPXInputStream 
*input, unsigned ptrType,
 FontFaces[i] = ptr;
   else if (ptr.Type == VSD_NAME_LIST2)
 NameList[i] = ptr;
-  else if (ptr.Type == VSD_NAMEIDX)
+  else if (ptr.Type == VSD_NAMEIDX || ptr.Type == VSD_NAMEIDX123)
 NameIDX[i] = ptr;
   else if (ptr.Type != 0)
 PtrList[i] = ptr;
@@ -337,8 +337,7 @@ void libvisio::VSDParser::handleStream(const Pointer &ptr, 
unsigned idx, unsigne
 
   if ((ptr.Format >> 4) == 0x4 || (ptr.Format >> 4) == 0x5 || (ptr.Format >> 
4) == 0x0)
   {
-if (ptr.Length > 4)
-  handleBlob(&tmpInput, shift, level+1);
+handleBlob(&tmpInput, shift, level+1);
 if ((ptr.Format >> 4) == 0x5 && ptr.Type != VSD_COLORS)
   handleStreams(&tmpInput, ptr.Type, shift, level+1);
   }
@@ -504,6 +503,9 @@ void libvisio::VSDParser::handleChunk(WPXInputStream *input)
   case VSD_NAMEIDX:
 readNameIDX(input);
 break;
+  case VSD_NAMEIDX123:
+readNameIDX123(input);
+break;
   case VSD_PAGE_PROPS:
 readPageProps(input);
 break;
@@ -745,6 +747,22 @@ void libvisio::VSDParser::readNameIDX(WPXInputStream 
*input)
   m_namesMapMap[m_header.level] = names;
 }
 
+void libvisio::VSDParser::readNameIDX123(WPXInputStream *input)
+{
+  std::map names;
+  long endPosition = input->tell() + m_header.dataLength;
+  while (!input->atEOS() && input->tell() < endPosition)
+  {
+unsigned nameId = getUInt(input);
+unsigned elementId = getUInt(input);
+std::map::const_iterator iter = m_names.find(nameId);
+if (iter != m_names.end())
+  names[elementId] = iter->second;
+  }
+  m_namesMapMap[m_header.level] = names;
+
+}
+
 void libvisio::VSDParser::readEllipse(WPXInputStream *input)
 {
   input->seek(1, WPX_SEEK_CUR);
diff --git a/src/lib/VSDParser.h b/src/lib/VSDParser.h
index 351b681..4e89631 100644
--- a/src/lib/VSDParser.h
+++ b/src/lib/VSDParser.h
@@ -129,6 +129,7 @@ protected:
   void readOLEData(WPXInputStream *input);
 
   virtual void readNameIDX(WPXInputStream *input);
+  virtual void readNameIDX123(WPXInputStream *input);
 
   // parser of one pass
   bool parseDocument(WPXInputStream *input, unsigned shift);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.free

Re: Cppcheck reports an 2 assignments which isn't used in drawinglayer module

2013-02-22 Thread Caolán McNamara

On Fri, 2012-12-28 at 09:28 -0800, julien2412 wrote:
> Hello,
> 
> Cppcheck reported these:
> [drawinglayer/source/primitive2d/sceneprimitive2d.cxx:196]: (style) Variable
> 'fViewSizeX' is assigned a value that is never used.
> [drawinglayer/source/primitive2d/sceneprimitive2d.cxx:197]: (style) Variable
> 'fViewSizeY' is assigned a value that is never used.
...

> Indeed, fViewSizeX and fViewSizeY. this time I don't think they should be
> removed, I rather think something is lacking.
> 
> Any idea?

So taking fViewSizeX lets have a look at what the history of these lines
is.

git log --follow -S fViewSizeX
drawinglayer/source/primitive2d/sceneprimitive2d.cxx

gives

commit 2a0a3168f4354285e59dd79d4477a4199c2f773b
Author: Armin Weiss 
Date:   Tue Oct 20 15:36:32 2009 +

#i105065# speedup 3D/FontWork

commit 407f7ae14844d0e55b9f0f87a19a7208762b05ed
Author: Armin Le Grand 
Date:   Wed Oct 7 14:25:40 2009 +0200

#i105323# added FastPath for 3D scene HitTest for 3d CustomShapes by
re-using the buffered last render result 

commit 2d634e6084547875a170d8350850110238b9e55c
Author: Armin Le Grand 
Date:   Tue Sep 29 15:35:35 2009 +0200

#i105323# speedup of 3D handling mostly for CustomShapes; HitTest
and interactions optimized

commit 57cc1366165559c8a958486c12af08790e6995f9
Author: Armin Weiss 
Date:   Tue Feb 26 07:28:52 2008 +

removals, OLE, optimizations for primitives

commit 821e3b2b3026f21e396a8da3e152781a546ef5f5
Author: Armin Weiss 
Date:   Thu Oct 19 09:40:02 2006 +

#i39532# primitive

To see what the file actually looked like at a given revision...

git show
57cc1366165559c8a958486c12af08790e6995f9:drawinglayer/source/primitive2d/sceneprimitive2d.cxx

git show
821e3b2b3026f21e396a8da3e152781a546ef5f5:drawinglayer/source/primitive2d/sceneprimitive2d.cxx

So looking through those fViewSizeX became assigned a value that is
never used with 57cc1366165559c8a958486c12af08790e6995f9 and every other
commit just moved it around or adapted it to later changes. Seeing as
this commit happened in 2008 and the rest of that commit looks
reasonable I think you should go ahead and remove those never used
variables.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Mysql Connector Extension Size Confusion

2013-02-22 Thread Michael Stahl

On 22/02/13 14:37, Alexander Thurgood wrote:
> Hi all,
> 
> On my 64bit Linux build of master, I'm seeing the following in my tree 
> after a successful build of the mysql connector extension :
> 
> Hmm, some strange things going on somewhere :
> 
> -rw-rw-r-- 1 1000 1000 5379260 janv.  3 03:44 
> /home/alex/Development/libo/core/mysqlc/unxlngx6.pro/bin/mysql-connector-ooo.oxt

this is created by the old build system.
> 
> -rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20 
> /home/alex/Development/libo/core/solver/unxlngx6.pro/bin/mysql-connector-ooo.oxt
> 
> 
> -rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20 
> /home/alex/Development/libo/core/workdir/unxlngx6.pro/ExtensionTarget/mysql-connector-ooo.oxt

this is created by the new build system, to which mysqlc was migrated
earlier this year.

> I have no idea why the /ExtensionTarget and /solver copies of the OXT 
> are only half the size of the unxlngx6.pro/bin copy.
> 
> Any ideas ?

you could check if there are any files missing in the oxt or anything
looks obviously wrong; last i checked it looked fine here but there are
apparently several different configure options that affect the extension
so YMMV.

> Since I always thought that it was the file in solver that got 
> registered in the final build product, I am a bit confused as to which 
> is the correct file that should be used to make available for downloads, 
> and this may also explain why my 2Mb files that I have made available in 
> the past didn't work for many users that tried it.

AFAIK the extension always requires some mysql library or other
installed on the system.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Mysql Connector Extension Size Confusion

2013-02-22 Thread Alexander Thurgood


Hi all,

On my 64bit Linux build of master, I'm seeing the following in my tree 
after a successful build of the mysql connector extension :


Hmm, some strange things going on somewhere :

-rw-rw-r-- 1 1000 1000 5379260 janv.  3 03:44 
/home/alex/Development/libo/core/mysqlc/unxlngx6.pro/bin/mysql-connector-ooo.oxt



-rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20 
/home/alex/Development/libo/core/solver/unxlngx6.pro/bin/mysql-connector-ooo.oxt



-rw-rw-r-- 1 1000 1000 2575973 févr. 13 12:20 
/home/alex/Development/libo/core/workdir/unxlngx6.pro/ExtensionTarget/mysql-connector-ooo.oxt



I have no idea why the /ExtensionTarget and /solver copies of the OXT 
are only half the size of the unxlngx6.pro/bin copy.


Any ideas ?

Since I always thought that it was the file in solver that got 
registered in the final build product, I am a bit confused as to which 
is the correct file that should be used to make available for downloads, 
and this may also explain why my 2Mb files that I have made available in 
the past didn't work for many users that tried it.


On Mac OSX, when the connector does successfully build, it has a size of 
about 4Mb.



Alex




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: MS Word import: bug-to-bug or "correct"

2013-02-22 Thread Caolán McNamara

On Tue, 2012-12-18 at 14:51 +0100, Lionel Elie Mamane wrote:
> Hi,
> 
> What is our policy about MS Word import? Should it give the same
> result as in MS Word, or where MS Word is buggy it should give a
> "correct" result?

The ideal is that we get the same results as in MS Word. Where there is
a conflict between fidelity and correctness (or our own legacy
behaviour) then add new compatibility options. We've a few of those
already, (tools->options->writer->compatibility) plenty of them are
MSWord compatibility options, and MSWord itself has a load of such
options, like "layout asian text like word 6" and "line break like
wordperfect 2" (well options *like* that if not exactly those ones). In
theory we should have every compatibility option that MSWord has plus a
bunch more.

That's the general idea anyway, gets tricky in practice of course to
identify and isolate what's going on to identify if there's a specific
compatibility tweak required and its exact required behaviour

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: storing chart doc on load ?

2013-02-22 Thread Caolán McNamara

On Sat, 2012-12-22 at 22:05 +, Michael Meeks wrote:
>   Either way, our whole approach to loading and converting-to-native all
> embedded OLE2 streams for charts etc. on load always seemed to me to be
> extremely curious / slow ;-) but probably I mis-understood something
> quite profoundly: I always wanted to have some time to dig through that
> to see what could be safely deferred: 

It was a super quick hack done in an afternoon IIRC. We should in theory
really be able to disable all that convert on load stuff completely and
render the preview as is normal, but on ole object activation if there's
no actual application registered to load them then have an attempt at
loading it ourself. Like, disable it, load an example, double click on
it and track down from where the error about not being able to handle it
comes from and see what happens if we hack in ourselves as a fallback
there and fix things up on that route.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Grammar checker] Undocumented change in the API for LO 4

2013-02-22 Thread Caolán McNamara

On Sun, 2013-01-20 at 08:25 -0800, Olivier R. wrote:
> With LibreOffice 4, each paragraph of a text is passed several times to this
> function in the parameter aText, and the parameters nStartOfSentencePosition
> and nSuggestedBehindEndOfSentencePosition are the beginning and the end of
> each sentence of this paragraph.
> 
> Is this a bug ? a feature ? an undocumented change ?

No idea, IMO it would be worth bibisecting this to find where it changed
to re-examine if it was intentional or not. Would then likely be a good
candidate for a unit test to lock in whichever is the right behaviour.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: desktop/source vcl/unx

2013-02-22 Thread Caolán McNamara

 desktop/source/app/app.cxx  |4 
 vcl/unx/gtk/app/gtkinst.cxx |1 -
 2 files changed, 5 deletions(-)

New commits:
commit 1a4bcd1b0d05f7dcafd7aebeaa0e0e91f6b102ea
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 12:58:07 2013 +

these stray fprintfs drive people demented

Change-Id: Ifee5c39423957bcc4708a7933c760d9467e2ac27

diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index 5f544ef..a07f2bb 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -562,8 +562,6 @@ Desktop::~Desktop()
 
 void Desktop::Init()
 {
-fprintf (stderr, "Desktop::Init()\n");
-
 RTL_LOGFILE_CONTEXT( aLog, "desktop (cd13) ::Desktop::Init" );
 SetBootstrapStatus(BS_OK);
 
@@ -595,8 +593,6 @@ void Desktop::Init()
 }
 }
 
-fprintf( stderr, "OfficeIPCThread %d ...\n", m_aBootstrapError == BE_OK );
-
 if ( 1 )
 {
 const CommandLineArgs& rCmdLineArgs = GetCommandLineArgs();
diff --git a/vcl/unx/gtk/app/gtkinst.cxx b/vcl/unx/gtk/app/gtkinst.cxx
index 294fd1a..cc69ccb 100644
--- a/vcl/unx/gtk/app/gtkinst.cxx
+++ b/vcl/unx/gtk/app/gtkinst.cxx
@@ -341,7 +341,6 @@ SalPrinter* GtkInstance::CreatePrinter( SalInfoPrinter* 
pInfoPrinter )
 {
 #if defined ENABLE_GTK_PRINT || GTK_CHECK_VERSION(3,0,0)
 mbPrinterInit = true;
-fprintf(stderr, "gtk printer\n");
 return new GtkSalPrinter( pInfoPrinter );
 #else
 return Superclass_t::CreatePrinter( pInfoPrinter );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2013-02-22 Thread Eike Rathke

 sc/source/ui/dbgui/scuiasciiopt.cxx |2 ++
 sc/source/ui/docshell/impex.cxx |   19 +++
 sc/source/ui/inc/impex.hxx  |2 ++
 3 files changed, 23 insertions(+)

New commits:
commit 8970e14d7494859c6079ef2a976416598823ba50
Author: Eike Rathke 
Date:   Fri Feb 22 00:27:26 2013 +0100

resolved fdo#57841 ignore embedded NULL characters in CSV import

Change-Id: Ib0eb044f009227c0aa6e1bc520905d605323c3db

diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx 
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index cfa4d4e..9624fde 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -540,6 +540,8 @@ bool ScImportAsciiDlg::GetLine( sal_uLong nLine, 
rtl::OUString &rText )
 if ( mpDatStream->GetError() == ERRCODE_IO_CANTSEEK )
 mpDatStream->ResetError();
 
+ScImportExport::EmbeddedNullTreatment( rText);
+
 return bRet;
 }
 
diff --git a/sc/source/ui/docshell/impex.cxx b/sc/source/ui/docshell/impex.cxx
index 6e7e16c..8cff0c9 100644
--- a/sc/source/ui/docshell/impex.cxx
+++ b/sc/source/ui/docshell/impex.cxx
@@ -1335,6 +1335,8 @@ bool ScImportExport::ExtText2Doc( SvStream& rStrm )
 if ( rStrm.IsEof() && aLine.isEmpty() )
 break;
 
+EmbeddedNullTreatment( aLine);
+
 sal_Int32 nLineLen = aLine.getLength();
 SCCOL nCol = nStartCol;
 bool bMultiLine = false;
@@ -1473,6 +1475,23 @@ bool ScImportExport::ExtText2Doc( SvStream& rStrm )
 }
 
 
+void ScImportExport::EmbeddedNullTreatment( OUString & rStr )
+{
+// A nasty workaround for data with embedded NULL characters. As long as we
+// can't handle them properly as cell content (things assume 0-terminated
+// strings at too many places) simply strip all NULL characters from raw
+// data. Excel does the same. See fdo#57841 for sample data.
+
+// The normal case is no embedded NULL, check first before de-/allocating
+// ustring stuff.
+sal_Unicode cNull = 0;
+if (rStr.indexOf( cNull) >= 0)
+{
+rStr = rStr.replaceAll( OUString( &cNull, 1), OUString());
+}
+}
+
+
 const sal_Unicode* ScImportExport::ScanNextFieldFromString( const sal_Unicode* 
p,
 String& rField, sal_Unicode cStr, const sal_Unicode* pSeps, bool 
bMergeSeps, bool& rbIsQuoted,
 bool& rbOverflowCell )
diff --git a/sc/source/ui/inc/impex.hxx b/sc/source/ui/inc/impex.hxx
index c427206..8c7e36b 100644
--- a/sc/source/ui/inc/impex.hxx
+++ b/sc/source/ui/inc/impex.hxx
@@ -102,6 +102,8 @@ public:
 bool IsUndo() const  { return bUndo; }
 void SetUndo( bool b )   { bUndo = b;}
 
+SC_DLLPUBLIC static void EmbeddedNullTreatment( OUString & rStr );
+
 static bool  IsFormatSupported( sal_uLong nFormat );
 static const sal_Unicode* ScanNextFieldFromString( const sal_Unicode* p,
 String& rField, sal_Unicode cStr, const sal_Unicode* pSeps,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [PATCH] Help update - Hyperlink Bar removal

2013-02-22 Thread Caolán McNamara

On Sun, 2013-02-10 at 17:41 +0100, Stanislav Horáček wrote:
> Hi,
> 
> this patch for help removes the pages related to the Hyperlink Bar which was 
> - if I understand it 
> correctly - removed from LO completely.

Your patch seems to remove the help for e.g. insert->hyperlink which we
still have, so we don't want to remove that. What we removed, IIRC, was
the hyperlink bar which was a different thing.
http://cgit.freedesktop.org/libreoffice/help/commit/?id=54108f6fd3f8355d12db0217d21fbab9dccf5ed8
removed the help for that, or at least most of it. I don't see any
existing references in our help to that removed bar, or is there some
still left ?

https://bugs.freedesktop.org/show_bug.cgi?id=43915 suggests that it was
still mentioned in the help at one stage in 3.4, but that it got fixed
for 3.5

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - sd/source sw/source

2013-02-22 Thread Luboš Luňák

 sd/source/ui/docshell/docshel2.cxx |2 +-
 sw/source/core/txtnode/ndtxt.cxx   |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 30fee57e6c8d5d71e744ad61aec8b240a81909b8
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Fri Feb 22 13:49:13 2013 +0100

fix build in debug code

Change-Id: I829699340525b6a1c5840e1162028bd593d2b96e

diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index a0bc301..9c271c2 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -4307,7 +4307,7 @@ namespace {
 {
 const SfxStringItem& pListIdItem =
 dynamic_cast(pItem);
-OSL_ENSURE( pListIdItem.GetValue().Len() > 0,
+OSL_ENSURE( pListIdItem.GetValue().getLength() > 0,
 " - empty list id 
attribute not excepted. Serious defect -> please inform OD." );
 const String sListIdOfTxtNode = rTxtNode.GetListId();
 if ( pListIdItem.GetValue() != sListIdOfTxtNode )
commit 55b00473eb09796ff66dcab2d33c67782dcb5230
Author: LuboÅ¡ LuÅÃ¡k 
Date:   Fri Feb 22 13:48:54 2013 +0100

fix incorrect code alignment

Change-Id: I80f181966f0e47ec0030eeab7762a6b7fb0095cb

diff --git a/sd/source/ui/docshell/docshel2.cxx 
b/sd/source/ui/docshell/docshel2.cxx
index 72b0ef6..f56c4a4 100644
--- a/sd/source/ui/docshell/docshel2.cxx
+++ b/sd/source/ui/docshell/docshel2.cxx
@@ -283,7 +283,7 @@ Bitmap DrawDocShell::GetPagePreviewBitmap(SdPage* pPage, 
sal_uInt16 nMaxEdgePixe
 if ( pPageView->GetLockedLayers() != pFrameView->GetLockedLayers() 
)
 pPageView->SetLockedLayers( pFrameView->GetLockedLayers() );
 
-pPageView->SetHelpLines( pFrameView->GetStandardHelpLines() );
+pPageView->SetHelpLines( pFrameView->GetStandardHelpLines() );
 }
 
 if ( pView->GetActiveLayer() != pFrameView->GetActiveLayer() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Gdb support for exceptions (Re: using backtrace() in exception throwing?)

2013-02-22 Thread Michael Meeks

Hi Tom,

On Wed, 2013-02-20 at 14:28 -0700, Tom Tromey wrote:
> FWIW we have the same problem in reverse: the gdb group at Red Hat is,
> among other things, tasked with improving the C++ debugging experience.
> However, most of us don't actually debug C++ programs on a regular
> basis.  We do know some issues, via bugzilla and other discussions, but
> I feel sure we are also missing things.

Oh wow :-) so Lubos' feedback here is really great; personally I feel
like rather an inadequate gdb user myself ;-)

> Solving this in general looks tricky to me.  I am not really sure how to
> do it, but I will think about it some more.

The basic debugging experience in these "an exception broke something"
flows is that we get an exception thrown that ultimately ends up in a
pathalogical situation - an abort, or some similar horrible badness. At
that point the most interesting thing is not the catcher - which usually
ends up being utterly random - but the last guy that threw the
exception. So then as Lubos says comes the knotty job of trying to put a
breakpoint on the -one- exception that ends up being caught where we are
now [ and that of course requires re-running, and inevitably we throw
dozens of exceptions in the normal case ].

> Meanwhile, I did whip up a quick-and-dirty Python-based approach.  It
> adds a new "track-throws" command.  This command installs a breakpoint
> that records the point of the most recent "throw".  Then you can examine
> the result with "info last-throw".

This of course goes a huge way to solving the above problem :-)

Really nice ! though of course - having a full stack trace would make
that very substantially more useful.

Even better than this would (perhaps) be a "break inside thrower that
is caught here" type breakpoint - that we could invoke to land us in
whatever code is going to throw as it does that [ and before it started
all the magic cleanup / unwinding work ]. That is - assuming that it's
possible for the code to know (at that point) where it will ultimately
end up (? ;-)

Anyhow - it's great to have some python help here; I guess we could
bundle that into our existing grab-bag of nice python fixes today :-)

Thanks !

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Need help regarding GSOC...

2013-02-22 Thread Fridrich Strba

A student has much higher chance to be considered as a viable GSoC
candidate if (s)he is part of the community. The canonical way to start
to contribute to LibreOffice is to pick some of the easy and not-so-easy
hacks referenced on this page
https://wiki.documentfoundation.org/Development/Easy_Hacks and start to
work on them. It does not mean that you will be automatically chosen for
GSoC, but it is a great way to start to contribute to LibreOffice.

Fridrich

On 22/02/13 13:35, Sujay m wrote:
> I want to contribute to open source software world through GSOC - 2013
> and want to contribute to libreoffice... I am not an amazing programmer
> but want learn more in this field... I am having an idea but not sure
> where or with whom i must discuss it with... I would like to discuss it
> with the libreoffice mentors but not sure which is right portal..so if
> you could guide me it'll be really helpfull..Thank you..
> 
> 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
> 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Need help regarding GSOC...

2013-02-22 Thread Sujay m

I want to contribute to open source software world through GSOC - 2013 and
want to contribute to libreoffice... I am not an amazing programmer but
want learn more in this field... I am having an idea but not sure where or
with whom i must discuss it with... I would like to discuss it with the
libreoffice mentors but not sure which is right portal..so if you could
guide me it'll be really helpfull..Thank you..
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH]

2013-02-22 Thread Caolán McNamara

On Mon, 2013-02-11 at 19:40 +0530, Janit Anjaria wrote:
> I am hereby attaching the patch for the bug#57950 where the
> replacement of .append() calls had to be done with a "+" operator.

Wrong patch, you attached Robert's patch for converting a dialog to the
new format. Possibly you didn't commit your work before getting the top
commit of your tree so got whatever happened to be at the top of your
tree.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sal/qa

2013-02-22 Thread Michael Meeks

 sal/qa/rtl/textenc/rtl_textcvt.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 294d7afb66503af554850c64f4d195f727fa2371
Author: Michael Meeks 
Date:   Fri Feb 22 12:16:26 2013 +

silence warning.

Change-Id: Ibf82038c15c9ecf6de502bae1dd21e2393cafe09

diff --git a/sal/qa/rtl/textenc/rtl_textcvt.cxx 
b/sal/qa/rtl/textenc/rtl_textcvt.cxx
index ba7074f..5c957f6 100644
--- a/sal/qa/rtl/textenc/rtl_textcvt.cxx
+++ b/sal/qa/rtl/textenc/rtl_textcvt.cxx
@@ -252,7 +252,7 @@ void doComplexCharSetTest(ComplexCharSetTest const & rTest) 
{
 rtl_destroyTextToUnicodeConverter(aConverter);
 }
 if (rTest.m_bNoContext && rTest.m_bForward) {
-sal_Unicode aUnicode[TEST_STRING_SIZE];
+sal_Unicode aUnicode[TEST_STRING_SIZE] = { 0, };
 int nSize = 0;
 rtl_TextToUnicodeConverter aConverter
 = rtl_createTextToUnicodeConverter(rTest.m_nEncoding);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

pending gbuild patches

2013-02-22 Thread d . ostrovsky


these pending gbuild patches [1], [2] move the location of main targets.
Which actions should be taken (other then making it compile on windows ;-)
prior to merging it, like uploading nightly build, odk publishing, etc.?

[1] https://gerrit.libreoffice.org/#/c/2242/
[2] https://gerrit.libreoffice.org/#/c/2288/

David
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

2013-02-22 Thread Caolán McNamara

 sw/source/core/doc/docfmt.cxx|2 +-
 sw/source/core/doc/docnum.cxx|2 +-
 sw/source/core/docnode/node.cxx  |4 ++--
 sw/source/core/txtnode/ndtxt.cxx |8 
 sw/source/filter/ww8/wrtww8.cxx  |8 +---
 sw/source/filter/ww8/ww8atr.cxx  |4 ++--
 sw/source/filter/xml/swxml.cxx   |2 +-
 sw/source/ui/dialog/regionsw.cxx |6 --
 sw/source/ui/shells/textsh1.cxx  |4 ++--
 sw/source/ui/shells/txtattr.cxx  |2 +-
 sw/source/ui/uiview/view2.cxx|2 +-
 sw/source/ui/utlui/attrdesc.cxx  |2 +-
 12 files changed, 25 insertions(+), 21 deletions(-)

New commits:
commit 753628eec23f4b4ba037953f05c1430b5108bf15
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 11:49:40 2013 +

fix sw build

Change-Id: I2d42420307f359b30cce5422629689bdc964ebd9

diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx
index 6355ec2..1a90245 100644
--- a/sw/source/core/doc/docfmt.cxx
+++ b/sw/source/core/doc/docfmt.cxx
@@ -226,7 +226,7 @@ static bool lcl_RstAttr( const SwNodePtr& rpNd, void* pArgs 
)
 break;
 case RES_PARATR_NUMRULE:
 {
-bSave = 0 != ((SwNumRuleItem*)pItem)->GetValue().Len();
+bSave = !((SwNumRuleItem*)pItem)->GetValue().isEmpty();
 }
 break;
 case RES_PARATR_OUTLINELEVEL:   //#outline 
level,add by zhaojianwei
diff --git a/sw/source/core/doc/docnum.cxx b/sw/source/core/doc/docnum.cxx
index 5b16808..c4a3c1f 100644
--- a/sw/source/core/doc/docnum.cxx
+++ b/sw/source/core/doc/docnum.cxx
@@ -159,7 +159,7 @@ void SwDoc::PropagateOutlineRule()
 const SwNumRuleItem & rCollRuleItem = pColl->GetNumRule( sal_False 
);
 
 // Check on document setting OUTLINE_LEVEL_YIELDS_OUTLINE_RULE no 
longer needed.
-if ( rCollRuleItem.GetValue().Len() == 0 )
+if ( rCollRuleItem.GetValue().isEmpty() )
 {
 SwNumRule * pMyOutlineRule = GetOutlineNumRule();
 
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index 3c77fbb..cca5729 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -1041,7 +1041,7 @@ sal_Bool SwCntntNode::InvalidateNumRule()
 const SfxPoolItem* pItem;
 if( GetNodes().IsDocNodes() &&
 0 != ( pItem = GetNoCondAttr( RES_PARATR_NUMRULE, sal_True )) &&
-((SwNumRuleItem*)pItem)->GetValue().Len() &&
+!((SwNumRuleItem*)pItem)->GetValue().isEmpty() &&
 0 != (pRule = GetDoc()->FindNumRulePtr(
 ((SwNumRuleItem*)pItem)->GetValue() ) ) )
 {
@@ -1405,7 +1405,7 @@ sal_Bool SwCntntNode::SetAttr( const SfxItemSet& rSet )
 const SfxPoolItem* pNameItem = 0;
 if ( 0 != GetCondFmtColl() ||
  SFX_ITEM_SET != mpAttrSet->GetItemState( 
RES_FRMATR_STYLE_NAME, sal_False, &pNameItem ) ||
- 0 == static_cast(pNameItem)->GetValue().Len() )
+ static_cast(pNameItem)->GetValue().isEmpty() )
 AttrSetHandleHelper::SetParent( mpAttrSet, *this, 
&GetAnyFmtColl(), GetFmtColl() );
 else
 const_cast(mpAttrSet.get())->SetParent( 
&GetFmtColl()->GetAttrSet() );
diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 9866117..a0bc301 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -2358,7 +2358,7 @@ SwNumRule* SwTxtNode::_GetNumRule(sal_Bool bInParent) 
const
 if ( pColl )
 {
 const SwNumRuleItem& rDirectItem = pColl->GetNumRule( 
sal_False );
-if ( rDirectItem.GetValue().Len() == 0 )
+if ( rDirectItem.GetValue().isEmpty() )
 {
 pRet = 0L;
 }
@@ -3465,7 +3465,7 @@ namespace {
 if ( rTxtNode.IsEmptyListStyleDueToSetOutlineLevelAttr() )
 {
 const SwNumRuleItem& rNumRuleItem = 
rTxtNode.GetTxtColl()->GetNumRule();
-if ( rNumRuleItem.GetValue().Len() > 0 )
+if ( !rNumRuleItem.GetValue().isEmpty() )
 {
 
rTxtNode.ResetEmptyListStyleDueToResetOutlineLevelAttr();
 }
@@ -4292,7 +4292,7 @@ namespace {
 
 const SwNumRuleItem& pNumRuleItem =
 dynamic_cast(pItem);
-if ( pNumRuleItem.GetValue().Len() > 0 )
+if ( !pNumRuleItem.GetValue().isEmpty() )
 {
 mbAddTxtNodeToList = true;
 // #i105562#
@@ -4406,7 +4406,7 @@ namespace {
 
 const SwNumRuleItem* pNumRuleItem =
 dynamic_cast(pItem);
-if ( pNumRuleItem->GetValue().Len() > 0 )
+

[Libreoffice-commits] core.git: embeddedobj/source sc/source toolkit/inc toolkit/source vcl/inc vcl/source vcl/win

2013-02-22 Thread Thomas Arnhold

 embeddedobj/source/general/docholder.cxx |8 
 embeddedobj/source/inc/docholder.hxx |4 ++--
 sc/source/ui/inc/gridwin.hxx |2 +-
 sc/source/ui/view/gridwin.cxx|4 ++--
 toolkit/inc/toolkit/awt/vclxmenu.hxx |2 +-
 toolkit/source/awt/vclxmenu.cxx  |   12 ++--
 vcl/inc/vcl/settings.hxx |   10 +-
 vcl/source/app/settings.cxx  |6 +++---
 vcl/source/window/decoview.cxx   |2 +-
 vcl/win/source/window/salframe.cxx   |   10 +-
 10 files changed, 30 insertions(+), 30 deletions(-)

New commits:
commit 5c89214a80f0284eafaf4eba23243dfe3c9f7193
Author: Thomas Arnhold 
Date:   Thu Feb 21 12:32:16 2013 +0100

fdo#39674: Rename menues to menu

Change-Id: Idc22167d1a0dc518b3f9e96884213140d07b565b
Reviewed-on: https://gerrit.libreoffice.org/2316
Reviewed-by: Thomas Arnhold 
Tested-by: Thomas Arnhold 

diff --git a/embeddedobj/source/general/docholder.cxx 
b/embeddedobj/source/general/docholder.cxx
index 6a81290..79e4897 100644
--- a/embeddedobj/source/general/docholder.cxx
+++ b/embeddedobj/source/general/docholder.cxx
@@ -601,7 +601,7 @@ void DocumentHolder::FindConnectPoints(
 }
 
 //---
-uno::Reference< container::XIndexAccess > 
DocumentHolder::MergeMenuesForInplace(
+uno::Reference< container::XIndexAccess > DocumentHolder::MergeMenusForInplace(
 const uno::Reference< container::XIndexAccess >& xContMenu,
 const uno::Reference< frame::XDispatchProvider >& xContDisp,
 const ::rtl::OUString& aContModuleName,
@@ -648,7 +648,7 @@ uno::Reference< container::XIndexAccess > 
DocumentHolder::MergeMenuesForInplace(
 }
 
 //---
-sal_Bool DocumentHolder::MergeMenues_Impl( const uno::Reference< 
::com::sun::star::frame::XLayoutManager >& xOwnLM,
+sal_Bool DocumentHolder::MergeMenus_Impl( const uno::Reference< 
::com::sun::star::frame::XLayoutManager >& xOwnLM,
const uno::Reference< 
::com::sun::star::frame::XLayoutManager >& xContLM,
 const uno::Reference< 
frame::XDispatchProvider >& xContDisp,
 const ::rtl::OUString& 
aContModuleName )
@@ -667,7 +667,7 @@ sal_Bool DocumentHolder::MergeMenues_Impl( const 
uno::Reference< ::com::sun::sta
 uno::Reference< container::XIndexAccess > xOwnMenu = 
RetrieveOwnMenu_Impl();
 uno::Reference< frame::XDispatchProvider > xOwnDisp( m_xFrame, 
uno::UNO_QUERY_THROW );
 
-uno::Reference< container::XIndexAccess > xMergedMenu = 
MergeMenuesForInplace( xContMenu, xContDisp, aContModuleName, xOwnMenu, 
xOwnDisp );
+uno::Reference< container::XIndexAccess > xMergedMenu = 
MergeMenusForInplace( xContMenu, xContDisp, aContModuleName, xOwnMenu, xOwnDisp 
);
 uno::Reference< ::com::sun::star::frame::XMenuBarMergingAcceptor > 
xMerge( xOwnLM,

  uno::UNO_QUERY_THROW );
 bMenuMerged = xMerge->setMergedMenuBar( xMergedMenu );
@@ -709,7 +709,7 @@ sal_Bool DocumentHolder::ShowUI( const uno::Reference< 
::com::sun::star::frame::
 xOwnLM->setDockingAreaAcceptor( xDocAreaAcc );
 
 // try to merge menus; don't do anything else if it fails
-if ( MergeMenues_Impl( xOwnLM, xContainerLM, xContainerDP, 
aContModuleName ) )
+if ( MergeMenus_Impl( xOwnLM, xContainerLM, xContainerDP, 
aContModuleName ) )
 {
 // make sure that the container LM does not control the 
size of the containers window anymore
 // this must be done after merging menus as we won't get 
the container menu otherwise
diff --git a/embeddedobj/source/inc/docholder.hxx 
b/embeddedobj/source/inc/docholder.hxx
index a76faae..a04dbb6 100644
--- a/embeddedobj/source/inc/docholder.hxx
+++ b/embeddedobj/source/inc/docholder.hxx
@@ -93,7 +93,7 @@ private:
 void ResizeWindows_Impl( const ::com::sun::star::awt::Rectangle& 
aHatchRect );
 
 ::com::sun::star::uno::Reference< 
::com::sun::star::container::XIndexAccess > RetrieveOwnMenu_Impl();
-sal_Bool MergeMenues_Impl(
+sal_Bool MergeMenus_Impl(
 const ::com::sun::star::uno::Reference< 
::com::sun::star::frame::XLayoutManager >& xOwnLM,
const ::com::sun::star::uno::Reference< 
::com::sun::star::frame::XLayoutManager >& xContLM,
 const ::com::sun::star::uno::Reference< 
::com::sun::star::frame::XDispatchProvider >& xContDisp,
@@ -106,7 +106,7 @@ public:
 sal_Int32 nConnectPoints[2] )
 throw ( ::com::sun::star::uno::Exception );
 
-static ::com::sun::star::uno::Reference< 
::com::sun::star::container::XIndexAccess > Me

Re: New feature in Calc: Stepped Lines graphs

2013-02-22 Thread Thorsten Behrens

Regina Henschel wrote:
> Where do I find that information?
> 
In the JIRA issue you quoted -
https://tools.oasis-open.org/issues/browse/OFFICE-3662 :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [libreoffice-accessibility] introduction

2013-02-22 Thread Caolán McNamara

On Fri, 2013-02-22 at 09:29 +0100, Sophie Gautier wrote:
> Hi Jonathan,
> 
> Thanks a lot for your proposal. I'm sending your mail to the developers
> list so we are sure they are aware of it.
> 
> Kind regards
> Sophie
> On 21/02/2013 23:33, Jonathan Nadeau wrote:
> > Hello list,
> > 
> > My name is Jonathan Nadeau and I'm the executive director of the
> > Accessible Computing Foundation located here
> > 
> > http://www.accessiblecomputingfoundation.org
> > 
> > I'm looking to fund some developers to fix some accessibility bugs with
> > Libreoffice and the Orca screen reader.

Nadeau isn't cc'ed on Sophie's original email and I don't know if he's
subscribed to any of these email lists, but I think it's worth
mentioning that the work in progress of moving our dialogs to the gtk
builder file format now makes it super super easy to: 
a) set that a label is the right mnemonic widget for something else,
which sets up the default a11y label for, label by relationships between
them
b) add a11y descriptions, a11y names, explicit label-for, label-by and
member-of etc relations

I'm not particularly a11y experienced, but I fired up orca a few weeks
ago and tweaked our a11y support a bit until it read out the
"format->title page" dialog the same way as it would read it if it was a
native gtk dialog.

Obviously there's a lot more a11y-wise to just our dialogs, but at least
for those new-format dialogs anyone with experience in tweaking gtk a11y
issues via glade can directly apply that experience to our new dialogs.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2013-02-22 Thread Caolán McNamara

 sc/source/filter/excel/xeroot.cxx |2 +-
 sc/source/ui/docshell/docfunc.cxx |2 +-
 sc/source/ui/docshell/docsh.cxx   |6 +++---
 sc/source/ui/docshell/docsh4.cxx  |6 +++---
 sc/source/ui/formdlg/formula.cxx  |2 +-
 sc/source/ui/inc/docfunc.hxx  |2 +-
 sc/source/ui/inc/viewfunc.hxx |2 +-
 sc/source/ui/view/gridwin.cxx |2 +-
 sc/source/ui/view/viewfunc.cxx|2 +-
 9 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit def619581f3a833c4c476548c6d17a76d204dd28
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 11:13:35 2013 +

fix sc build

Change-Id: I2c5ad65863a516516f8a944fb1344753e08d6c9e

diff --git a/sc/source/filter/excel/xeroot.cxx 
b/sc/source/filter/excel/xeroot.cxx
index 6016d7d..475a0c2 100644
--- a/sc/source/filter/excel/xeroot.cxx
+++ b/sc/source/filter/excel/xeroot.cxx
@@ -341,7 +341,7 @@ uno::Sequence< beans::NamedValue > 
XclExpRoot::GetEncryptionData() const
 {
 // try to get the encryption data from the password
 SFX_ITEMSET_ARG( GetMedium().GetItemSet(), pPasswordItem, 
SfxStringItem, SID_PASSWORD, false );
-if ( pPasswordItem && pPasswordItem->GetValue().Len() )
+if ( pPasswordItem && !pPasswordItem->GetValue().isEmpty() )
 aEncryptionData = GenerateEncryptionData( 
pPasswordItem->GetValue() );
 }
 
diff --git a/sc/source/ui/docshell/docfunc.cxx 
b/sc/source/ui/docshell/docfunc.cxx
index cc73064..d9d0646 100644
--- a/sc/source/ui/docshell/docfunc.cxx
+++ b/sc/source/ui/docshell/docfunc.cxx
@@ -1154,7 +1154,7 @@ bool ScDocFunc::SetNoteText( const ScAddress& rPos, const 
String& rText, sal_Boo
 
 //
 
-bool ScDocFunc::ReplaceNote( const ScAddress& rPos, const String& rNoteText, 
const String* pAuthor, const String* pDate, sal_Bool bApi )
+bool ScDocFunc::ReplaceNote( const ScAddress& rPos, const OUString& rNoteText, 
const OUString* pAuthor, const OUString* pDate, sal_Bool bApi )
 {
 bool bDone = false;
 
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index 917c88b..24e4c82 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -803,11 +803,11 @@ void ScDocShell::Notify( SfxBroadcaster&, const SfxHint& 
rHint )
 aValues[0].Value <<= 
::rtl::OUString( GetMedium()->GetFilter()->GetFilterName() );
 
 SFX_ITEMSET_ARG( 
GetMedium()->GetItemSet(), pPasswordItem, SfxStringItem, SID_PASSWORD, false);
-if ( pPasswordItem && 
pPasswordItem->GetValue().Len() )
+if ( pPasswordItem && 
!pPasswordItem->GetValue().isEmpty() )
 {
 aValues.realloc( 2 );
-aValues[1].Name = 
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( "Password") );
-aValues[1].Value <<= 
::rtl::OUString( pPasswordItem->GetValue() );
+aValues[1].Name = 
OUString("Password");
+aValues[1].Value <<= 
pPasswordItem->GetValue();
 }
 
 SC_MOD()->SetInSharedDocSaving( 
true );
diff --git a/sc/source/ui/docshell/docsh4.cxx b/sc/source/ui/docshell/docsh4.cxx
index 4509c11..5591d60 100644
--- a/sc/source/ui/docshell/docsh4.cxx
+++ b/sc/source/ui/docshell/docsh4.cxx
@@ -2345,11 +2345,11 @@ uno::Reference< frame::XModel > 
ScDocShell::LoadSharedDocument()
 if ( GetMedium() )
 {
 SFX_ITEMSET_ARG( GetMedium()->GetItemSet(), pPasswordItem, 
SfxStringItem, SID_PASSWORD, false);
-if ( pPasswordItem && pPasswordItem->GetValue().Len() )
+if ( pPasswordItem && !pPasswordItem->GetValue().isEmpty() )
 {
 aArgs.realloc( 2 );
-aArgs[1].Name = ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM( 
"Password" ));
-aArgs[1].Value <<= ::rtl::OUString( pPasswordItem->GetValue() 
);
+aArgs[1].Name = OUString("Password");
+aArgs[1].Value <<= pPasswordItem->GetValue();
 }
 }
 
diff --git a/sc/source/ui/formdlg/formula.cxx b/sc/source/ui/formdlg/formula.cxx
index a5db312..10dbb17 100644
--- a/sc/source/ui/formdlg/formula.cxx
+++ b/sc/source/ui/formdlg/formula.cxx
@@ -546,7 +546,7 @@ void ScFormulaDlg::dispatch(sal_Bool _bOK,sal_Bool 
_bMartixChecked)
 
 // Wenn durch Dokument-Umschalterei die Eingabezeile weg war/ist,
 // ist der String leer. Dann nicht die alte Formel loeschen.
-if ( !aStrItem.GetValue().Len() )
+if ( aStrItem.GetValue().isEmpty() )
 aRetItem.SetValue( false ); // sal_False = Ca

[Libreoffice-commits] core.git: configure.ac

2013-02-22 Thread Andras Timar

 configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b4a89972cb6a6370224d5de3b88f9e642f93624a
Author: Andras Timar 
Date:   Fri Feb 22 12:19:06 2013 +0100

fdo#54087 build npsoplugin on Windows, it does not depend on GTK+ there

Change-Id: I033ee2316337dab549f1beddbfb7919a35d73c8e

diff --git a/configure.ac b/configure.ac
index 59e17a8..ffecd10 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8590,7 +8590,7 @@ dnl 
===
 dnl Check for NPAPI interface to plug LibreOffice into browser windows
 dnl ===
 AC_MSG_CHECKING([whether to plug LibreOffice into browser windows])
-if test "$_os" != Android -a "$_os" != Darwin -a "$_os" != iOS -a \
+if test "$_os" == WINNT -o "$_os" != Android -a "$_os" != Darwin -a "$_os" != 
iOS -a \
 "$enable_headless" != yes -a "$enable_gtk" != no
 then
 AC_MSG_RESULT([yes])
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/inc sd/source

2013-02-22 Thread Radek Doulik

 sd/inc/drawdoc.hxx  |5 +
 sd/source/core/drawdoc.cxx  |1 +
 sd/source/ui/docshell/docshel4.cxx  |   13 +
 sd/source/ui/inc/DrawDocShell.hxx   |2 ++
 sd/source/ui/unoidl/UnoDocumentSettings.cxx |   21 -
 5 files changed, 41 insertions(+), 1 deletion(-)

New commits:
commit 64cdf8072a79491903c5d1b107c6486b33da04d3
Author: Radek Doulik 
Date:   Fri Feb 22 12:03:54 2013 +0100

added EmbedFonts property, added File/Properties/Font tab

Change-Id: Id2a812c4b5347e2851149a1bd46eaec4b40d0f12

diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 2ab95ab..56bab28 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -188,6 +188,8 @@ private:
 
 std::vector< rtl::OUString > maAnnotationAuthors;
 
+boolmbUseEmbedFonts;
+
 protected:
 
 virtual ::com::sun::star::uno::Reference< 
::com::sun::star::uno::XInterface > createUnoModel();
@@ -557,6 +559,9 @@ public:
 
 sal_uInt16 GetAnnotationAuthorIndex( const rtl::OUString& rAuthor );
 
+bool IsUsingEmbededFonts() { return mbUseEmbedFonts; }
+void SetIsUsingEmbededFonts( bool bUse ) { mbUseEmbedFonts = bUse; }
+
 private:
 /** This member stores the printer independent layout mode.  Please
 refer to SetPrinterIndependentLayout() for its
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 18a04bd..5b7d3e4 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -163,6 +163,7 @@ SdDrawDocument::SdDrawDocument(DocumentType eType, 
SfxObjectShell* pDrDocSh)
 , mpLocale(NULL)
 , mpDrawPageListWatcher(0)
 , mpMasterPageListWatcher(0)
+, mbUseEmbedFonts(false)
 {
 mpDrawPageListWatcher = ::std::auto_ptr(
 new ImpDrawPageListWatcher(*this));
diff --git a/sd/source/ui/docshell/docshel4.cxx 
b/sd/source/ui/docshell/docshel4.cxx
index 936e86e..195ca1c 100644
--- a/sd/source/ui/docshell/docshel4.cxx
+++ b/sd/source/ui/docshell/docshel4.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -997,6 +998,18 @@ void DrawDocShell::OpenBookmark( const String& 
rBookmarkURL )
 ( mpViewShell ? mpViewShell->GetViewFrame() : SfxViewFrame::Current() 
)->GetBindings().Execute( SID_OPENHYPERLINK, ppArgs );
 }
 
+SfxDocumentInfoDialog* DrawDocShell::CreateDocumentInfoDialog( ::Window 
*pParent, const SfxItemSet &rSet )
+{
+SfxDocumentInfoDialog* pDlg   = new SfxDocumentInfoDialog( pParent, rSet );
+DrawDocShell*  pDocSh = 
PTR_CAST(DrawDocShell,SfxObjectShell::Current());
+
+if( pDocSh == this )
+{
+pDlg->AddFontTabPage();
+}
+return pDlg;
+}
+
 } // end of namespace sd
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/inc/DrawDocShell.hxx 
b/sd/source/ui/inc/DrawDocShell.hxx
index bcf7d4a..eb75a3c 100644
--- a/sd/source/ui/inc/DrawDocShell.hxx
+++ b/sd/source/ui/inc/DrawDocShell.hxx
@@ -98,6 +98,8 @@ public:
 virtual SizeGetFirstPageSize();
 virtual voidFillClass(SvGlobalName* pClassName, sal_uInt32*  
pFormat, String* pAppName, String* pFullTypeName, String* pShortTypeName, 
sal_Int32 nFileFormat, sal_Bool bTemplate = sal_False ) const;
 virtual voidSetModified( sal_Bool = sal_True );
+virtual SfxDocumentInfoDialog*  CreateDocumentInfoDialog( ::Window 
*pParent,
+  const SfxItemSet 
&rSet );
 
 using SotObject::GetInterface;
 using SfxObjectShell::GetVisArea;
diff --git a/sd/source/ui/unoidl/UnoDocumentSettings.cxx 
b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
index c83a3f8..7c3ba84 100644
--- a/sd/source/ui/unoidl/UnoDocumentSettings.cxx
+++ b/sd/source/ui/unoidl/UnoDocumentSettings.cxx
@@ -141,7 +141,7 @@ enum SdDocumentSettingsPropertyHandles
 HANDLE_PRINTER_INDEPENDENT_LAYOUT
 // #i33095#
 ,HANDLE_LOAD_READONLY, HANDLE_SAVE_VERSION
-,HANDLE_SLIDESPERHANDOUT, HANDLE_HANDOUTHORIZONTAL
+,HANDLE_SLIDESPERHANDOUT, HANDLE_HANDOUTHORIZONTAL, HANDLE_EMBED_FONTS
 };
 
 #define MID_PRINTER 1
@@ -202,6 +202,7 @@ enum SdDocumentSettingsPropertyHandles
 // --> #i33095#
 { MAP_LEN("LoadReadonly"),  HANDLE_LOAD_READONLY,   
&::getBooleanCppuType(),0,  0 },
 { MAP_LEN("SaveVersionOnClose"),HANDLE_SAVE_VERSION,
&::getBooleanCppuType(),0,  0 },
+{ MAP_LEN("EmbedFonts"),HANDLE_EMBED_FONTS, 
&::getBooleanCppuType(),0,  0 },
 { NULL, 0, 0, NULL, 0, 0 }
 };
 
@@ -902,6 +903,18 @@ void DocumentSettings::_setPropertyValues( const 
PropertyMapEntry** ppEntries, c
 }
 break;
 
+case HANDLE_EMBED_FONTS:
+{
+sal_Bool bNewValue = sal_False;
+if ( *pValues >>= bNewValue )
+{
+

[Libreoffice-commits] core.git: 2 commits - basctl/source editeng/source vcl/source

2013-02-22 Thread Caolán McNamara

 basctl/source/basicide/basicbox.cxx |2 +-
 editeng/source/items/paraitem.cxx   |2 +-
 vcl/source/app/svmain.cxx   |3 ---
 3 files changed, 2 insertions(+), 5 deletions(-)

New commits:
commit 805f1ed598ef18157710cf3655d329b09a735389
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 10:13:44 2013 +

fix editeng and basctl build

Change-Id: I0d70449ad9b42219969c82e2054694c4a5830dcf

diff --git a/basctl/source/basicide/basicbox.cxx 
b/basctl/source/basicide/basicbox.cxx
index 5b6b399..0d869ab 100644
--- a/basctl/source/basicide/basicbox.cxx
+++ b/basctl/source/basicide/basicbox.cxx
@@ -510,7 +510,7 @@ void LanguageBox::Update( const SfxStringItem* pItem )
 {
 FillBox();
 
-if ( pItem && pItem->GetValue().Len() > 0 )
+if ( pItem && !pItem->GetValue().isEmpty() )
 {
 m_sCurrentText = pItem->GetValue();
 if ( GetSelectEntry() != m_sCurrentText )
diff --git a/editeng/source/items/paraitem.cxx 
b/editeng/source/items/paraitem.cxx
index d247bb83..7962c1d 100644
--- a/editeng/source/items/paraitem.cxx
+++ b/editeng/source/items/paraitem.cxx
@@ -1357,7 +1357,7 @@ SfxItemPresentation SvxPageModelItem::GetPresentation
 )   const
 {
 rText = OUString();
-bool bSet = ( GetValue().Len() > 0 );
+bool bSet = !GetValue().isEmpty();
 
 switch ( ePres )
 {
commit 92ea45dc5d84360b69322194b31390860b4c5414
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 10:11:12 2013 +

drop someones stray debugging fprintfs

Change-Id: I4423ea0952282ea2b64c72e4cc73e42f0afe4649

diff --git a/vcl/source/app/svmain.cxx b/vcl/source/app/svmain.cxx
index 9d08192..9b83c6d 100644
--- a/vcl/source/app/svmain.cxx
+++ b/vcl/source/app/svmain.cxx
@@ -156,13 +156,10 @@ int ImplSVMain()
 
 sal_Bool bInit = InitVCL();
 
-fprintf (stderr, "init vcl %d\n", bInit);
-
 if( bInit )
 {
 // call application main
 pSVData->maAppData.mbInAppMain = sal_True;
-fprintf(stderr, "call app  main from vcl!\n");
 nReturn = pSVData->mpApp->Main();
 pSVData->maAppData.mbInAppMain = sal_False;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: minutes of ESC call ...

2013-02-22 Thread Michael Meeks


On Thu, 2013-02-21 at 20:56 +0100, Michael Stahl wrote:
> On 21/02/13 17:00, Michael Meeks wrote:
> > + full-word selection / editing ergonomics cf. UX-advise
> >   https://bugs.freedesktop.org/show_bug.cgi?id=46517
> > + pending input from Caolan / Cedric / Michael S
> 
> so i have finally looked at this bug and added a comment, which
> basically says "meh. how the heck did this get on the ESC agenda?"

UX team asked for some input there :-)

ATB,

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] .: src/lib

2013-02-22 Thread Libreoffice Gerrit user

 src/lib/VSD5Parser.cpp  |2 -
 src/lib/VSD5Parser.h|2 +
 src/lib/VSDCollector.h  |2 -
 src/lib/VSDContentCollector.cpp |6 ++--
 src/lib/VSDContentCollector.h   |2 -
 src/lib/VSDDocumentStructure.h  |1 
 src/lib/VSDPages.cpp|4 ++
 src/lib/VSDPages.h  |1 
 src/lib/VSDParser.cpp   |   54 
 src/lib/VSDParser.h |6 
 src/lib/VSDStylesCollector.cpp  |2 -
 src/lib/VSDStylesCollector.h|2 -
 src/lib/VSDTypes.h  |4 ++
 src/lib/VSDXMLParserBase.cpp|2 -
 14 files changed, 77 insertions(+), 13 deletions(-)

New commits:
commit cb055a1b99ba51a6dc9aa407c18e7ea2ffc746f9
Author: Fridrich Å trba 
Date:   Fri Feb 22 11:24:18 2013 +0100

Read and push to the api the names of the pages if they exist

diff --git a/src/lib/VSD5Parser.cpp b/src/lib/VSD5Parser.cpp
index 9d7c164..f49fafa 100644
--- a/src/lib/VSD5Parser.cpp
+++ b/src/lib/VSD5Parser.cpp
@@ -381,7 +381,7 @@ void libvisio::VSD5Parser::readShape(WPXInputStream *input)
 void libvisio::VSD5Parser::readPage(WPXInputStream *input)
 {
   unsigned backgroundPageID = getUInt(input);
-  m_collector->collectPage(m_header.id, m_header.level, backgroundPageID, 
m_isBackgroundPage, WPXString());
+  m_collector->collectPage(m_header.id, m_header.level, backgroundPageID, 
m_isBackgroundPage, VSDName());
 }
 
 void libvisio::VSD5Parser::readTextBlock(WPXInputStream *input)
diff --git a/src/lib/VSD5Parser.h b/src/lib/VSD5Parser.h
index 4430e1c..d6cf0ae 100644
--- a/src/lib/VSD5Parser.h
+++ b/src/lib/VSD5Parser.h
@@ -73,6 +73,8 @@ protected:
 
   virtual void readStyleSheet(WPXInputStream *input);
 
+  virtual void readNameIDX(WPXInputStream *) {}
+
   virtual unsigned getUInt(WPXInputStream *input);
   virtual int getInt(WPXInputStream *input);
 
diff --git a/src/lib/VSDCollector.h b/src/lib/VSDCollector.h
index 1633726..f53545b 100644
--- a/src/lib/VSDCollector.h
+++ b/src/lib/VSDCollector.h
@@ -79,7 +79,7 @@ public:
   virtual void collectShapesOrder(unsigned id, unsigned level, const 
std::vector &shapeIds) = 0;
   virtual void collectForeignDataType(unsigned level, unsigned foreignType, 
unsigned foreignFormat, double offsetX, double offsetY, double width, double 
height) = 0;
   virtual void collectPageProps(unsigned id, unsigned level, double pageWidth, 
double pageHeight, double shadowOffsetX, double shadowOffsetY, double scale) = 
0;
-  virtual void collectPage(unsigned id, unsigned level, unsigned 
backgroundPageID, bool isBackgroundPage, const WPXString &pageName) = 0;
+  virtual void collectPage(unsigned id, unsigned level, unsigned 
backgroundPageID, bool isBackgroundPage, const VSDName &pageName) = 0;
   virtual void collectShape(unsigned id, unsigned level, unsigned parent, 
unsigned masterPage, unsigned masterShape, unsigned lineStyle, unsigned 
fillStyle, unsigned textStyle) = 0;
   virtual void collectSplineStart(unsigned id, unsigned level, double x, 
double y, double secondKnot, double firstKnot, double lastKnot, unsigned 
degree) = 0;
   virtual void collectSplineKnot(unsigned id, unsigned level, double x, double 
y, double knot) = 0;
diff --git a/src/lib/VSDContentCollector.cpp b/src/lib/VSDContentCollector.cpp
index 09b268b..8901fa1 100644
--- a/src/lib/VSDContentCollector.cpp
+++ b/src/lib/VSDContentCollector.cpp
@@ -1699,11 +1699,13 @@ void 
libvisio::VSDContentCollector::collectPageProps(unsigned /* id */, unsigned
   m_currentPage.m_pageHeight = m_scale*m_pageHeight;
 }
 
-void libvisio::VSDContentCollector::collectPage(unsigned /* id */, unsigned 
level, unsigned backgroundPageID, bool isBackgroundPage, const WPXString 
&pageName)
+void libvisio::VSDContentCollector::collectPage(unsigned /* id */, unsigned 
level, unsigned backgroundPageID, bool isBackgroundPage, const VSDName 
&pageName)
 {
   _handleLevelChange(level);
   m_currentPage.m_backgroundPageID = backgroundPageID;
-  m_currentPage.m_pageName = pageName;
+  m_currentPage.m_pageName.clear();
+  if (!pageName.empty())
+_convertDataToString(m_currentPage.m_pageName, pageName.m_data, 
pageName.m_format);
   m_isBackgroundPage = isBackgroundPage;
 }
 
diff --git a/src/lib/VSDContentCollector.h b/src/lib/VSDContentCollector.h
index 0c273c2..25ec85b 100644
--- a/src/lib/VSDContentCollector.h
+++ b/src/lib/VSDContentCollector.h
@@ -100,7 +100,7 @@ public:
   void collectShapesOrder(unsigned id, unsigned level, const 
std::vector &shapeIds);
   void collectForeignDataType(unsigned level, unsigned foreignType, unsigned 
foreignFormat, double offsetX, double offsetY, double width, double height);
   void collectPageProps(unsigned id, unsigned level, double pageWidth, double 
pageHeight, double shadowOffsetX, double shadowOffsetY, double scale);
-  void collectPage(unsigned id, unsigned level, unsigned backgroundPageID, 
bool isBackgroundPage, const WPXString &pageName);
+  void collectPage(unsigned id, unsigned level,

license statement

2013-02-22 Thread Prashant Pandey

Hello,

All of my past & future contributions to LibreOffice may be licensed under
the MPL/LGPLv3+ dual license.

Regards
Prashant Pandey
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] Looking for PyUno Contributor(s)

2013-02-22 Thread Petr Mladek

Joel Madero píše v St 20. 02. 2013 v 07:11 -0800:
> Hi All!
> 
> I am one of the members of the Quality Assurance team with LibreOffice 
> and we are looking for a volunteer to work with myself designing (and 
> coding) the framework to start automating our stats. It's been on my 
> list for much too long and I just don't have the technical know how to 
> do it. If there are are users or developers who can slowly get this 
> accomplished it would greatly help QA as well as Marketing as our stats 
> are done almost completely manually at this point, not only is this time 
> consuming but it's also likely that there could be mistakes or missing 
> data.
> 
> If there are any takers, again this would be a great help, I have a 
> general idea of what I'd like to do, just trying to find people who are 
> capable of implementation.

This a good candidate for an easy hack. Please, create a bug in bugzilla
and add the needed flags. I think that many new volunteers might have
scripting skills and it might be a good starter for them.

Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: minutes of ESC call ...

2013-02-22 Thread Michael Stahl

On 21/02/13 17:00, Michael Meeks wrote:
>   + issues with libunordflo loading in dbgutil builds
> AI:   + look into it before publishing updated stats (Michael S)

the problem was that the rpath of several external libraries contained
not $ORIGIN but some random PID.  after several hours of cursing heavily
at arcane tools the proper quoting to preserve the $ was found.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - extras/source sfx2/source

2013-02-22 Thread Caolán McNamara

 extras/source/glade/libreoffice-catalog.xml |8 +++-
 sfx2/source/bastyp/fltfnc.cxx   |2 +-
 sfx2/source/doc/docfile.cxx |   10 +-
 3 files changed, 13 insertions(+), 7 deletions(-)

New commits:
commit 45739fad0b1d55e72cc1ed508b8ea33a74219290
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 10:00:42 2013 +

fix sfx2 build

Change-Id: I17b8ab426e7aabeb5db9d49391e0c1be99e63a51

diff --git a/sfx2/source/bastyp/fltfnc.cxx b/sfx2/source/bastyp/fltfnc.cxx
index 049823b..97dbaec 100644
--- a/sfx2/source/bastyp/fltfnc.cxx
+++ b/sfx2/source/bastyp/fltfnc.cxx
@@ -551,7 +551,7 @@ sal_uInt32 SfxFilterMatcher::DetectFilter( SfxMedium& 
rMedium, const SfxFilter**
 
 sal_Bool bPreview = rMedium.IsPreview_Impl();
 SFX_ITEMSET_ARG(rMedium.GetItemSet(), pReferer, SfxStringItem, 
SID_REFERER, sal_False);
-if ( bPreview && rMedium.IsRemote() && ( !pReferer || 
pReferer->GetValue().CompareToAscii("private:searchfolder:",21 ) != 
COMPARE_EQUAL ) )
+if ( bPreview && rMedium.IsRemote() && ( !pReferer || 
!pReferer->GetValue().match("private:searchfolder:") ) )
 return ERRCODE_ABORT;
 
 ErrCode nErr = GuessFilter( rMedium, &pFilter );
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index d2f6164..0fc15a8 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -1721,12 +1721,12 @@ sal_Bool SfxMedium::TryDirectTransfer( const 
::rtl::OUString& aURL, SfxItemSet&
 SFX_ITEMSET_ARG( &aTargetSet, pNewPassItem, SfxStringItem, SID_PASSWORD, 
false );
 SFX_ITEMSET_ARG( GetItemSet(), pOldPassItem, SfxStringItem, SID_PASSWORD, 
false );
 if ( ( !pNewPassItem && !pOldPassItem )
-  || ( pNewPassItem && pOldPassItem && pNewPassItem->GetValue().Equals( 
pOldPassItem->GetValue() ) ) )
+  || ( pNewPassItem && pOldPassItem && pNewPassItem->GetValue() == 
pOldPassItem->GetValue() ) )
 {
 // the filter must be the same
 SFX_ITEMSET_ARG( &aTargetSet, pNewFilterItem, SfxStringItem, 
SID_FILTER_NAME, false );
 SFX_ITEMSET_ARG( GetItemSet(), pOldFilterItem, SfxStringItem, 
SID_FILTER_NAME, false );
-if ( pNewFilterItem && pOldFilterItem && 
pNewFilterItem->GetValue().Equals( pOldFilterItem->GetValue() ) )
+if ( pNewFilterItem && pOldFilterItem && pNewFilterItem->GetValue() == 
pOldFilterItem->GetValue() )
 {
 // get the input stream and copy it
 // in case of success return true
@@ -2459,7 +2459,7 @@ void SfxMedium::Init_Impl()
 pImp->bDisposeStorage = false;
 
 SFX_ITEMSET_ARG( pImp->m_pSet, pSalvageItem, SfxStringItem, 
SID_DOC_SALVAGE, false);
-if ( pSalvageItem && !pSalvageItem->GetValue().Len() )
+if ( pSalvageItem && pSalvageItem->GetValue().isEmpty() )
 {
 pSalvageItem = NULL;
 pImp->m_pSet->ClearItem( SID_DOC_SALVAGE );
@@ -2492,7 +2492,7 @@ void SfxMedium::Init_Impl()
 }
 }
 
-if ( pSalvageItem && pSalvageItem->GetValue().Len() )
+if ( pSalvageItem && !pSalvageItem->GetValue().isEmpty() )
 {
 pImp->m_aLogicName = pSalvageItem->GetValue();
 DELETEZ( pImp->m_pURLObj );
@@ -2894,7 +2894,7 @@ SfxMedium::SfxMedium( const 
::com::sun::star::uno::Sequence< ::com::sun::star::b
 if( pSalvageItem )
 {
 // QUESTION: there is some treatment of Salvage in Init_Impl; align!
-if ( pSalvageItem->GetValue().Len() )
+if ( !pSalvageItem->GetValue().isEmpty() )
 {
 // if an URL is provided in SalvageItem that means that the 
FileName refers to a temporary file
 // that must be copied here
commit 321bd3a06e3aa78f3223ef1aa7a0baac9176f83d
Author: CaolÃ¡n McNamara 
Date:   Fri Feb 22 09:15:44 2013 +

more custom widgets for glade catalog

Change-Id: I9637244a7f117496feeb879618a28ba55ced84f4

diff --git a/extras/source/glade/libreoffice-catalog.xml 
b/extras/source/glade/libreoffice-catalog.xml
index e028f73..0612baa 100644
--- a/extras/source/glade/libreoffice-catalog.xml
+++ b/extras/source/glade/libreoffice-catalog.xml
@@ -30,8 +30,14 @@
 
+
+
 
 ___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - chart2/source

2013-02-22 Thread Eike Rathke

 chart2/source/tools/ExplicitCategoriesProvider.cxx |   24 +
 1 file changed, 15 insertions(+), 9 deletions(-)

New commits:
commit 74d1466914547aaa5369f18727c228db9ce88121
Author: Eike Rathke 
Date:   Tue Feb 19 19:22:27 2013 +0100

do not access vector elements beyond size, rhbz#847519 related

The actual bug (crash) is not triggered anymore because the categories
are assembled differently, nevertheless the code in question could
expose the same behavior under different preconditions.

Change-Id: Ic37f6b34effaf4e5252e80aab46b021547b36efb
(cherry picked from commit d1ba2cd612a4c39976e2980c7dc4e3fa38c88470)
Reviewed-on: https://gerrit.libreoffice.org/2272
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx 
b/chart2/source/tools/ExplicitCategoriesProvider.cxx
index e3d800f..00b481c 100644
--- a/chart2/source/tools/ExplicitCategoriesProvider.cxx
+++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx
@@ -353,11 +353,14 @@ Sequence< OUString > lcl_getExplicitSimpleCategories(
 }
 for( aOuterIt=rComplexCats.begin(); aOuterIt != aOuterEnd; ++aOuterIt )
 {
-sal_Int32 nCurrentCount = lcl_getCategoryCount( *aOuterIt );
-if( nCurrentCount< nMaxCategoryCount )
+if ( !aOuterIt->empty() )
 {
-ComplexCategory& rComplexCategory = aOuterIt->back();
-rComplexCategory.Count += (nMaxCategoryCount-nCurrentCount);
+sal_Int32 nCurrentCount = lcl_getCategoryCount( *aOuterIt );
+if( nCurrentCount< nMaxCategoryCount )
+{
+ComplexCategory& rComplexCategory = aOuterIt->back();
+rComplexCategory.Count += 
(nMaxCategoryCount-nCurrentCount);
+}
 }
 }
 }
@@ -389,12 +392,15 @@ Sequence< OUString > lcl_getExplicitSimpleCategories(
 OUString aText;
 for( aOuterIt=aComplexCatsPerIndex.begin() ; aOuterIt != 
aOuterEnd; ++aOuterIt )
 {
-OUString aAddText = (*aOuterIt)[nN].Text;
-if( !aAddText.isEmpty() )
+if ( static_cast(nN) < aOuterIt->size() )
 {
-if(!aText.isEmpty())
-aText += aSpace;
-aText += aAddText;
+OUString aAddText = (*aOuterIt)[nN].Text;
+if( !aAddText.isEmpty() )
+{
+if(!aText.isEmpty())
+aText += aSpace;
+aText += aAddText;
+}
 }
 }
 aRet[nN]=aText;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: dbaccess/source

2013-02-22 Thread Andras Timar

 dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4ad4e50763c0f04a286f7ff784e3cd70835ca077
Author: Andras Timar 
Date:   Fri Feb 22 10:59:25 2013 +0100

unused local variable

Change-Id: I8d8019b6947c1f989d897389379f2b6bb396cfbb

diff --git a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx 
b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
index 0eb325a..60fa166 100644
--- a/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
+++ b/dbaccess/source/ui/dlg/DBSetupConnectionPages.cxx
@@ -856,7 +856,6 @@ DBG_NAME(OFinalDBPageSetup)
 {
 DBG_CTOR(OFinalDBPageSetup,NULL);
 
-OUString stext = m_aFTFinalHeader.GetText();
 SetControlFontWeight(&m_aFTFinalHeader);
 m_aCBOpenAfterwards.SetClickHdl(LINK(this, OFinalDBPageSetup, 
OnOpenSelected));
 m_aCBStartTableWizard.SetClickHdl(getControlModifiedLink());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Implementing alternate "compatibility" functions (such as 0^0 = ERROR)

2013-02-22 Thread Xisco Faulí

I'm sorry, I didn't know about that discussion.
You're right, it's pointless to do the same here, so it's better just to
stop the discussion.

Please accept my apologies
Xisco


2013/2/22 Tor Lillqvist 

> > I've seen this was implemented in Apache Openoffice recently. Probably we
> > can just merge it into Libreoffice.
>
> And you did not notice the flood of useless discussion that ensued on
> the AOO list, with one contributor (partially) leaving AOO?
>
> PLEASE STOP THIS DISCUSSION NOW! ;)
>
> --tml
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-3-6' - extras/source

2013-02-22 Thread Andras Timar

 extras/source/autotext/lang/tr/crdbus50.bau |binary
 extras/source/autotext/lang/tr/template.bau |binary
 2 files changed

New commits:
commit 94c54d373443b7f9fe667b7d1f2ca009fd792164
Author: Andras Timar 
Date:   Thu Feb 21 15:16:24 2013 +0100

convert Turkish AutoText files from old binary to zipped XML

I wonder when the support of old binary format was discontinued, but
at least in LibreOffice 3.6 it did not work. I converted the files with
OpenOffice.org 1.0.3.

Change-Id: Ie68371b613ab0464eefe909d083dbb8567623a2b
Reviewed-on: https://gerrit.libreoffice.org/2314
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/extras/source/autotext/lang/tr/crdbus50.bau 
b/extras/source/autotext/lang/tr/crdbus50.bau
index cd8ca31..a9eb8dc 100644
Binary files a/extras/source/autotext/lang/tr/crdbus50.bau and 
b/extras/source/autotext/lang/tr/crdbus50.bau differ
diff --git a/extras/source/autotext/lang/tr/template.bau 
b/extras/source/autotext/lang/tr/template.bau
index 60d51dc..b1b2b63 100644
Binary files a/extras/source/autotext/lang/tr/template.bau and 
b/extras/source/autotext/lang/tr/template.bau differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - extras/source

2013-02-22 Thread Andras Timar

 extras/source/autotext/lang/tr/crdbus50.bau |binary
 extras/source/autotext/lang/tr/template.bau |binary
 2 files changed

New commits:
commit e5144e5f49ac04c769accb4e796edfbd6973e137
Author: Andras Timar 
Date:   Thu Feb 21 15:16:24 2013 +0100

convert Turkish AutoText files from old binary to zipped XML

I wonder when the support of old binary format was discontinued, but
at least in LibreOffice 3.6 it did not work. I converted the files with
OpenOffice.org 1.0.3.

Change-Id: Ie68371b613ab0464eefe909d083dbb8567623a2b
Reviewed-on: https://gerrit.libreoffice.org/2313
Tested-by: CaolÃ¡n McNamara 
Reviewed-by: CaolÃ¡n McNamara 

diff --git a/extras/source/autotext/lang/tr/crdbus50.bau 
b/extras/source/autotext/lang/tr/crdbus50.bau
index cd8ca31..a9eb8dc 100644
Binary files a/extras/source/autotext/lang/tr/crdbus50.bau and 
b/extras/source/autotext/lang/tr/crdbus50.bau differ
diff --git a/extras/source/autotext/lang/tr/template.bau 
b/extras/source/autotext/lang/tr/template.bau
index 60d51dc..b1b2b63 100644
Binary files a/extras/source/autotext/lang/tr/template.bau and 
b/extras/source/autotext/lang/tr/template.bau differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Implementing alternate "compatibility" functions (such as 0^0 = ERROR)

2013-02-22 Thread Michael Meeks

On Thu, 2013-02-21 at 21:50 -0600, Norbert Thiebaud wrote:
> The issue is purely academic, but if it _has_ to be resolved then yes
> a compatibility mode has a much better value that creating an
> 'alternate' function.

True - though clearly there is some residual benefit in importing ODF
files with this sort of function in them - luckily there is a ~zero
deployed-base of that so far.

As a general yard-stick, we take function compatibility with Excel
extremely seriously - it is clearly imperative to our users to have
confidence that their spreadsheets continue to work as they move to the
world of ODF implementations.

Having said that - when it comes to corner-cases we have much bigger
problems in this area than this issue. One example would be the absence
of a true 'boolean' type in our core; such that when you run the
gnumeric test sheet here:

http://git.gnome.org/browse/gnumeric/plain/samples/excel/operator.xls

you can ponder at length whether: '=TRUE() > "Liz"' should be true or
false for example ;-)

So - IMHO there is little value at all in further discussion on this
topic, and backwards-compatibility with ODF + numeric sanity trumps the
corner-case at least until we have a much more consistent set of
corner-case solutions.

But of course, I would defer to the calc team; and as Tor and Norbert
says - -strongly- discourage an endless bike-shed on this from those
outside the set of people who have already contributed code to calc.

All the best :-)

Michael.

-- 
michael.me...@suse.com  <><, Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - extras/CustomTarget_autocorr.mk extras/Zip_autocorr.mk

2013-02-22 Thread Andras Timar

 extras/CustomTarget_autocorr.mk |7 +++
 extras/Zip_autocorr.mk  |1 +
 2 files changed, 8 insertions(+)

New commits:
commit ffc603cb1b5cc5a4a2098e1d9057f52aa6bdc392
Author: Andras Timar 
Date:   Fri Feb 22 09:24:26 2013 +0100

fdo#61138 add Catalan autocorrection data to makefiles

Change-Id: I88dabffc98825d6e7df14165d448302697cebe21
Reviewed-on: https://gerrit.libreoffice.org/2329
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/extras/CustomTarget_autocorr.mk b/extras/CustomTarget_autocorr.mk
index bb40d73..b04bebf 100644
--- a/extras/CustomTarget_autocorr.mk
+++ b/extras/CustomTarget_autocorr.mk
@@ -12,6 +12,7 @@ $(eval $(call 
gb_CustomTarget_CustomTarget,extras/source/autotext))
 extras_AUTOCORR_LANGS := \
af-ZA:af-ZA \
bg:bg-BG \
+   ca:ca \
cs:cs-CZ \
da:da-DK \
de:de-DE \
@@ -61,6 +62,11 @@ extras_AUTOCORR_XMLFILES := \
bg/acor/META-INF/manifest.xml \
bg/acor/SentenceExceptList.xml \
bg/acor/WordExceptList.xml \
+   ca/acor/BlockList.xml \
+   ca/acor/DocumentList.xml \
+   ca/acor/META-INF/manifest.xml \
+   ca/acor/SentenceExceptList.xml \
+   ca/acor/WordExceptList.xml \
cs/acor/BlockList.xml \
cs/acor/DocumentList.xml \
cs/acor/META-INF/manifest.xml \
@@ -228,6 +234,7 @@ extras_AUTOCORR_XMLFILES := \
 extras_AUTOCORR_MIMETYPEFILES := \
af-ZA/acor/mimetype \
bg/acor/mimetype \
+   ca/acor/mimetype \
cs/acor/mimetype \
da/acor/mimetype \
de/acor/mimetype \
diff --git a/extras/Zip_autocorr.mk b/extras/Zip_autocorr.mk
index 8decc51..adf5651 100644
--- a/extras/Zip_autocorr.mk
+++ b/extras/Zip_autocorr.mk
@@ -13,6 +13,7 @@ $(eval $(call gb_Zip_add_files,autocorr,\
acor_af-ZA.dat \
acor_bg-BG.dat \
acor_cs-CZ.dat \
+   acor_ca.dat \
acor_da-DK.dat \
acor_de-DE.dat \
acor_en-AU.dat \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - extras/source

2013-02-22 Thread Joan Montane

 extras/source/autotext/lang/ca/acor/BlockList.xml  |   17 
 extras/source/autotext/lang/ca/acor/DocumentList.xml   |  355 +
 extras/source/autotext/lang/ca/acor/META-INF/manifest.xml  |   17 
 extras/source/autotext/lang/ca/acor/SentenceExceptList.xml |  173 ++
 extras/source/autotext/lang/ca/acor/WordExceptList.xml |   15 
 5 files changed, 577 insertions(+)

New commits:
commit 4bed5266e90d1741894acf2521c0219a1925105c
Author: Joan Montane 
Date:   Fri Feb 22 09:11:54 2013 +0100

fdo#61138 add Catalan autocorrection data

Change-Id: I5f28e8968bc993c2f5b545919f1a26929038f882
Reviewed-on: https://gerrit.libreoffice.org/2328
Reviewed-by: CaolÃ¡n McNamara 
Tested-by: CaolÃ¡n McNamara 

diff --git a/extras/source/autotext/lang/ca/acor/BlockList.xml 
b/extras/source/autotext/lang/ca/acor/BlockList.xml
new file mode 100644
index 000..9344bf7
--- /dev/null
+++ b/extras/source/autotext/lang/ca/acor/BlockList.xml
@@ -0,0 +1,17 @@
+
+
+http://openoffice.org/2001/block-list"; 
block-list:list-name="acor_ca">
+  
+  
+  
+  
+  
+  
+
diff --git a/extras/source/autotext/lang/ca/acor/DocumentList.xml 
b/extras/source/autotext/lang/ca/acor/DocumentList.xml
new file mode 100644
index 000..826fc46
--- /dev/null
+++ b/extras/source/autotext/lang/ca/acor/DocumentList.xml
@@ -0,0 +1,355 @@
+
+
+
+http://openoffice.org/2001/block-list";>
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
diff --git a/extras/source/autotext/lang/ca/acor/META-INF/manifest.xml 
b/extras/source/autotext/lang/ca/acor/META-INF/manifest.xml
new file mode 100644
index 000..dcdf3fa
--- /dev/null
+++ b/extras/source/autotext/lang/ca/acor/META-INF/manifest.xml
@@ -0,0 +1,17 @@
+
+
+
+  
+  
+  
+  
+  
+  
+
diff --git a/extras/source/autotext/lang/ca/acor/SentenceExceptList.xml 
b/extras/source/autotext/lang/ca/acor/SentenceExceptList.xml
new file mode 100644
index 000..e44da0f
--- /dev/null
+++ b/extras/source/autotext/lang/ca/acor/SentenceExceptList.xml
@@ -0,0 +1,173 @@
+
+
+
+http://openoffice.org/2001/block-list";>
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
diff --git a/extras/source/autotext/lang/ca/acor/WordExceptList.xml 
b/extras/source/autotext/lang/ca/acor/WordExceptList.xml
new file mode 100644
index 000..faeb6a8
--- /dev/null
+++ b/extras/source/autotext/lang/ca/acor/WordExceptList.xml
@@ -0,0 +1,15 @@
+
+
+http://openoffice.org/2001/block-list";>
+  
+  
+  
+  
+
diff --git a/extras/source/autotext/lang/ca/acor/mimetype 
b/extras/source/autotext/lang/ca/acor/mimetype
new file mode 100644
index 000..e69de29
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

1 2 >

1 - 100 of 120 matches

Mail list logo