date:20130420

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3484

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3484
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I566602028556aa954bcbd116c375b9b61cc3df6f
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[MERGE FAILED] fdo#63154: Change macros Min/Max for std::min/max

David Tardon has submitted this change and it FAILED to merge.

Change subject: fdo#63154: Change macros Min/Max for std::min/max
..


Your change could not be merged due to a path conflict.

Please merge (or rebase) the change locally and upload the resolution for 
review.

-- 
To view, visit https://gerrit.libreoffice.org/3326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merge-failed
Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63154: Change Min/Max/Abs for std::min/max/abs

Hello LibreOffice gerrit bot,

I'd like you to reexamine a change.  Please visit

https://gerrit.libreoffice.org/3326

to look at the new patch set (#4).

Change subject: fdo#63154: Change Min/Max/Abs for std::min/max/abs
..

fdo#63154: Change Min/Max/Abs for std::min/max/abs

Now all these usages were removed from LO.

Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
---
M UnoControls/source/controls/progressmonitor.cxx
M accessibility/source/standard/vclxaccessiblelist.cxx
M basctl/source/basicide/baside2.cxx
M basic/source/runtime/methods.cxx
M chart2/source/tools/CommonConverters.cxx
M connectivity/source/drivers/dbase/DTable.cxx
M connectivity/source/drivers/file/FNoException.cxx
M connectivity/source/drivers/file/FResultSet.cxx
M cui/source/customize/cfg.cxx
M cui/source/dialogs/cuigrfflt.cxx
M cui/source/options/fontsubs.cxx
M cui/source/tabpages/page.cxx
M cui/source/tabpages/swpossizetabpage.cxx
M cui/source/tabpages/tpcolor.cxx
M dbaccess/source/ui/querydesign/ConnectionLine.cxx
M editeng/source/editeng/editdoc.cxx
M editeng/source/editeng/impedit.cxx
M editeng/source/editeng/impedit2.cxx
M editeng/source/editeng/impedit3.cxx
M editeng/source/editeng/impedit4.cxx
M editeng/source/items/svxfont.cxx
M editeng/source/items/textitem.cxx
M editeng/source/outliner/outliner.cxx
M filter/source/flash/swfwriter1.cxx
M filter/source/graphicfilter/itiff/itiff.cxx
M filter/source/svg/svgwriter.cxx
M forms/source/component/GroupManager.cxx
M fpicker/source/office/iodlg.cxx
M linguistic/source/dicimp.cxx
M linguistic/source/spelldta.cxx
M reportdesign/source/ui/report/dlgedfunc.cxx
M sc/inc/attarray.hxx
M sc/inc/bigrange.hxx
M sc/source/core/data/attarray.cxx
M sc/source/core/data/column.cxx
M sc/source/core/data/column3.cxx
M sc/source/core/data/dociter.cxx
M sc/source/core/data/documen2.cxx
M sc/source/core/data/documen4.cxx
M sc/source/core/data/document.cxx
M sc/source/core/data/dptabsrc.cxx
M sc/source/core/data/drwlayer.cxx
M sc/source/core/data/funcdesc.cxx
M sc/source/core/data/olinetab.cxx
M sc/source/core/data/table1.cxx
M sc/source/core/data/table2.cxx
M sc/source/core/data/table3.cxx
M sc/source/core/data/table4.cxx
M sc/source/core/data/table6.cxx
M sc/source/core/tool/address.cxx
M sc/source/core/tool/compiler.cxx
M sc/source/core/tool/consoli.cxx
M sc/source/core/tool/interpr1.cxx
M sc/source/core/tool/interpr2.cxx
M sc/source/filter/excel/excdoc.cxx
M sc/source/filter/excel/excform8.cxx
M sc/source/filter/excel/excrecds.cxx
M sc/source/filter/excel/xetable.cxx
M sc/source/filter/excel/xlpage.cxx
M sc/source/filter/html/htmlexp.cxx
M sc/source/filter/html/htmlpars.cxx
M sc/source/filter/starcalc/scflt.cxx
M sc/source/filter/xml/XMLCellRangeSourceContext.cxx
M sc/source/filter/xml/XMLConsolidationContext.cxx
M sc/source/filter/xml/XMLTableSourceContext.cxx
M sc/source/filter/xml/xmldrani.cxx
M sc/source/ui/app/inputwin.cxx
M sc/source/ui/app/scmod.cxx
M sc/source/ui/cctrl/tbzoomsliderctrl.cxx
M sc/source/ui/dbgui/csvcontrol.cxx
M sc/source/ui/dbgui/csvgrid.cxx
M sc/source/ui/dbgui/csvruler.cxx
M sc/source/ui/dbgui/csvtablebox.cxx
M sc/source/ui/docshell/arealink.cxx
M sc/source/ui/docshell/dbdocimp.cxx
M sc/source/ui/docshell/docsh4.cxx
M sc/source/ui/docshell/docsh5.cxx
M sc/source/ui/docshell/docsh6.cxx
M sc/source/ui/drawfunc/fuconstr.cxx
M sc/source/ui/drawfunc/fusel.cxx
M sc/source/ui/drawfunc/futext.cxx
M sc/source/ui/inc/csvtablebox.hxx
M sc/source/ui/miscdlgs/crnrdlg.cxx
M sc/source/ui/navipi/navipi.cxx
M sc/source/ui/undo/undoblk.cxx
M sc/source/ui/undo/undoblk3.cxx
M sc/source/ui/unoobj/appluno.cxx
M sc/source/ui/unoobj/cellsuno.cxx
M sc/source/ui/vba/vbaapplication.cxx
M sc/source/ui/view/cellsh3.cxx
M sc/source/ui/view/gridwin4.cxx
M sc/source/ui/view/hdrcont.cxx
M sc/source/ui/view/hintwin.cxx
M sc/source/ui/view/olinewin.cxx
M sc/source/ui/view/output.cxx
M sc/source/ui/view/output2.cxx
M sc/source/ui/view/prevwsh.cxx
M sc/source/ui/view/printfun.cxx
M sc/source/ui/view/tabcont.cxx
M sc/source/ui/view/tabview.cxx
M sc/source/ui/view/tabview4.cxx
M sc/source/ui/view/viewdata.cxx
M sc/source/ui/view/viewfunc.cxx
M sc/source/ui/view/viewutil.cxx
M scaddins/source/analysis/analysishelper.cxx
M sd/source/core/drawdoc2.cxx
M sd/source/filter/ppt/pptin.cxx
M sd/source/ui/dlg/animobjs.cxx
M sd/source/ui/docshell/docshel2.cxx
M sd/source/ui/docshell/sdclient.cxx
M sd/source/ui/func/fuconstr.cxx
M sd/source/ui/func/fucopy.cxx
M sd/source/ui/func/fuediglu.cxx
M sd/source/ui/func/fuinsfil.cxx
M sd/source/ui/func/fusel.cxx
M sd/source/ui/func/futext.cxx
M sd/source/ui/slideshow/showwin.cxx
M sd/source/ui/slidesorter/view/SlsInsertionIndicatorOverlay.cxx
M sd/source/ui/unoidl/unomodel.cxx
M sd/source/ui/view/drtxtob.cxx
M sd/source/ui/view/drtxtob1.cxx
M sd/source/ui/view/drviews1.cxx
M sd/source/ui/view/drviews3.cxx
M sd/source/ui/view/drviewsb.cxx
M sd/source/ui/view/drviewse.cxx
M sd/source/ui/view/grviewsh.cxx
M

[PUSHED] fdo#63154: Change Min/Max/Abs for std::min/max/abs

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3326

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3326
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Gerrit-PatchSet: 5
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Chris Sherlock chris.sherloc...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Eike Rathke er...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: Michael Meeks michael.me...@suse.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svx/inc

2013-04-20 Thread Thomas Arnhold

 svx/inc/galtheme.hrc|4 
 svx/inc/svx/gallery.hxx |1 +
 2 files changed, 5 insertions(+)

New commits:
commit be3bf9c62d9928fc67a5eb8609c06087d5c1fd22
Author: Thomas Arnhold tho...@arnhold.org
Date:   Sat Apr 20 13:12:50 2013 +0200

gallery: add some hints

Change-Id: Idfc9a2de615e9e2fa3bd161d74f805defc5107e7

diff --git a/svx/inc/galtheme.hrc b/svx/inc/galtheme.hrc
index 60b4aeb..7eda727 100644
--- a/svx/inc/galtheme.hrc
+++ b/svx/inc/galtheme.hrc
@@ -21,6 +21,10 @@
 
 #define RID_GALLERYSTR_THEME_START  (6000)
 
+// ATTENTION: This list has to be in sync with
+//  * svx/inc/svx/gallery.hxx
+//  * share/gallery (theme files are identified by id)
+
 #define RID_GALLERYSTR_THEME_3D (RID_GALLERYSTR_THEME_START + 1)
 #define RID_GALLERYSTR_THEME_ANIMATIONS 
(RID_GALLERYSTR_THEME_START + 2)
 #define RID_GALLERYSTR_THEME_BULLETS
(RID_GALLERYSTR_THEME_START + 3)
diff --git a/svx/inc/svx/gallery.hxx b/svx/inc/svx/gallery.hxx
index 102a6de..f7b7b56 100644
--- a/svx/inc/svx/gallery.hxx
+++ b/svx/inc/svx/gallery.hxx
@@ -37,6 +37,7 @@
 #define SVX_GALLERY() (GalleryExplorer::GetGallery())
 
 // Defines for preinstalled themes
+// Has to be in sync with svx/inc/galtheme.hrc
 #define GALLERY_THEME_3D1
 #define GALLERY_THEME_BULLETS   3
 #define GALLERY_THEME_HOMEPAGE  10
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] fdo#55432 fix the context menu position for RTL sheet

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3497

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/3497/1

fdo#55432  fix the context menu position for RTL sheet

Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
---
M sc/source/ui/view/gridwin.cxx
1 file changed, 5 insertions(+), 1 deletion(-)



diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 145b887e..1a66c97 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2995,6 +2995,9 @@
 else if ( !bMouse )
 {
 //  non-edit menu by keyboard - use lower right of cell cursor 
position
+ScDocument* aDoc = pViewData-GetDocument();
+SCTAB nTabNo = pViewData-GetTabNo();
+sal_Bool bLayoutIsRTL = aDoc-IsLayoutRTL(nTabNo);
 
 SCCOL nCurX = pViewData-GetCurX();
 SCROW nCurY = pViewData-GetCurY();
@@ -3002,7 +3005,8 @@
 long nSizeXPix;
 long nSizeYPix;
 pViewData-GetMergeSizePixel( nCurX, nCurY, nSizeXPix, nSizeYPix );
-aMenuPos.X() += nSizeXPix;
+// fdo#55432 take the correct position for RTL sheet
+aMenuPos.X() += bLayoutIsRTL ? -nSizeXPix : nSizeXPix;
 aMenuPos.Y() += nSizeYPix;
 
 if (pViewData)

-- 
To view, visit https://gerrit.libreoffice.org/3497
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Abdulaziz A Alayed aala...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#55432 fix the context menu position for RTL sheet

David Tardon has abandoned this change.

Change subject: fdo#55432  fix the context menu position for RTL sheet
..


Patch Set 1: Abandoned

-- 
To view, visit https://gerrit.libreoffice.org/3497
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Abdulaziz A Alayed aala...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Patch for postgresql driver

2013-04-20 Thread Wols Lists

Hi Lionel,

Okay, I'll sort out that patch and re-apply it for you. You should have
a licence email on record - sent to the list 2012-05-18 Wol's grant of
licence.

I hope it was PGP signed ... :-)

Cheers,
Wol

On 19/04/13 17:26, Lionel Elie Mamane wrote:
 On Wed, Apr 17, 2013 at 09:39:59PM +0100, Wols Lists wrote:
 I've now got the patch done.
 
 Could someone with a postgresql implementation please test and push?
 
 Thank you for your patch. From looking at it, it looks good to go to
 me, but technically I wasn't able to apply it and we have some
 administrivia to go through. Sorry for the administrivia, but we'll
 need it only once.
 
 
 I don't see a link to a license statement in
 https://wiki.documentfoundation.org/Development/Developers
 Could you please confirm that this patch (and, to make things easier,
 all your future contributions to LibreOffice) are licensed by you
 under the MPLv2/LGPLv3+ dual license? Thank you in advance.
 
 
 When I try to apply it with patch -p1, it says:
 
 patching file connectivity/source/drivers/postgresql/pq_connection.cxx
 patch:  malformed patch at line 71: @@ -527,6 +515,11 @@ static void 
 properties2arrays( const Sequence PropertyValue   args,
 
 When I try to apply it with git am it says:
 
 Patch format detection failed.
 
 git apply says:
 
 fatal: corrupt patch at line 71
 
 
 It looks to me like you created the patch with git format-patch and
 then modified the resulting file (or email template), and somehow the
 patch got corrupted in the process.
 
 In general, the best is to either:
 
 1) Use gerrit
 
 2) Generate the patch with git format-patch and then attach the
*whole* file to your mail (not just the patch as you did).
 
 Both of these methods allow to use git natively to apply the patch,
 and (assuming your git is setup properly) to automatically get your
 suggested commit message and the information of authorship recorded
 into git. For example, now I don't know whether the git authorship
 email should be wolslists at youngmanorg.uk (like the wiki Developers
 page says), antlists at youngman.org.uk (the address that sent this
 mail) or the more personal address you used to correspond with me by
 email in the past. Please advise. I'm also not sure whether you'd like
 the authorship name to be Anthony W. Youngman or Anthony Youngman.
 
 
 Could you please regenerate the patch so that I can apply and test?
 Thank you in advance.
 
 Since you have to regenerate the patch anyway, a rather minor nitpick:
 I'd prefer C++-style cast rather then C-style cast:
  static_castint (SAL_N_ELEMENTS( keyword_list ))
 rather than
  (int) SAL_N_ELEMENTS( keyword_list )
 
 An even better solution would be to make the j variable of type
 size_t instead of int (that is, the same type as SAL_N_ELEMENTS(
 keyword_list ).
 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[RESTORED] fdo#55432 fix the context menu position for RTL sheet

David Tardon has restored this change.

Change subject: fdo#55432  fix the context menu position for RTL sheet
..


Patch Set 1: Restored

-- 
To view, visit https://gerrit.libreoffice.org/3497
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: restore
Gerrit-Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Abdulaziz A Alayed aala...@kacst.edu.sa

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2013-04-20 Thread Abdulaziz A Alayed

 sc/source/ui/view/gridwin.cxx |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 89feda6bfdeacb647d44cb432d5ebc2678c44c89
Author: Abdulaziz A Alayed aala...@kacst.edu.sa
Date:   Mon Apr 8 10:59:16 2013 +0300

fdo#55432 fix the context menu position for RTL sheet

Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
Reviewed-on: https://gerrit.libreoffice.org/3497
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 145b887e..1a66c97 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2995,6 +2995,9 @@ void ScGridWindow::Command( const CommandEvent rCEvt )
 else if ( !bMouse )
 {
 //  non-edit menu by keyboard - use lower right of cell cursor 
position
+ScDocument* aDoc = pViewData-GetDocument();
+SCTAB nTabNo = pViewData-GetTabNo();
+sal_Bool bLayoutIsRTL = aDoc-IsLayoutRTL(nTabNo);
 
 SCCOL nCurX = pViewData-GetCurX();
 SCROW nCurY = pViewData-GetCurY();
@@ -3002,7 +3005,8 @@ void ScGridWindow::Command( const CommandEvent rCEvt )
 long nSizeXPix;
 long nSizeYPix;
 pViewData-GetMergeSizePixel( nCurX, nCurY, nSizeXPix, nSizeYPix );
-aMenuPos.X() += nSizeXPix;
+// fdo#55432 take the correct position for RTL sheet
+aMenuPos.X() += bLayoutIsRTL ? -nSizeXPix : nSizeXPix;
 aMenuPos.Y() += nSizeYPix;
 
 if (pViewData)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] fdo#55432 fix the context menu position for RTL sheet

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3497

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3497
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I023215646b9aeadb4909c9f90f84f9e8b0dbd173
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Abdulaziz A Alayed aala...@kacst.edu.sa
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#55432 fix the context menu position for RTL sheet

David Tardon has abandoned this change.

Change subject: fdo#55432  fix the context menu position for RTL sheet
..


Patch Set 2: Abandoned

Replaced by https://gerrit.libreoffice.org/#/c/3497/ (because gerrit submitted 
my change as a new review, even if the Change-ID remained the same).

-- 
To view, visit https://gerrit.libreoffice.org/3271
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I7961f7e47cabef6b06e66e5495a231b7b8b5f24b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Abdulaziz A Alayed aala...@kacst.edu.sa
Gerrit-Reviewer: Ahmad Harthi aalhar...@kacst.edu.sa
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: Fridrich Strba fridr...@documentfoundation.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

GSOC 2013 Candidate

2013-04-20 Thread Alex Ivan

Greetings,

My name is Ivan Alexandru, I am a second year undergraduate at Politehnica
University of Bucharest, and I am very much interested in working on
LibreOffice during this year's Summer of Code. I have a good understanding
of C/C++ and have used them in the two years at the university but never to
work on such a large project. In addition, I am familiar with Java, and also
have basic to medium understanding of Python and functional languages like
Scheme and Haskell.

I have already cloned the repo and built LO under linux. Moreover, I have
worked on this easyhack https://bugs.freedesktop.org/show_bug.cgi?id=60700
and submitted a patch. This, being a first for me, I mistakenly submitted it
to the wrong branch https://gerrit.libreoffice.org/#/c/3400/  but realized
my error and resubmitted to master https://gerrit.libreoffice.org/#/c/3401/
. As you can probably see, it ended up not being much to do, although the
bug is almost fixed, at least for the examples at hand.
I would like to know if this counts towards being eligible, as mentioned in
the application guide, or should I begin working on another easyhack to be
sure?

Also, I have taken a look through the ideas page. Two of them have captured
my interest, namely the one regarding Table Styles in Writer and the one
concerning ODF Formulas.  I have a couple of questions about these:
Which of these do you consider more important? (and if neither are on the
priority list, please point me to one that is) 
Are there any other resources I should be aware of in order to get
accustomed with the project, aside from the given code pointers?

Thank you for your time,
Alex Ivan



--
View this message in context: 
http://nabble.documentfoundation.org/GSOC-2013-Candidate-tp4051245.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fix fdo#63619 no need for RTL mark

2013-04-20 Thread Faisal al-otaibi (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3498

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/3498/1

fix fdo#63619 no need for RTL mark

Change-Id: I88588be252455bbb353c757a75f2ec9ea2d17e9e
---
M i18npool/source/localedata/data/ar_DZ.xml
M i18npool/source/localedata/data/ar_EG.xml
M i18npool/source/localedata/data/ar_LB.xml
M i18npool/source/localedata/data/ar_OM.xml
M i18npool/source/localedata/data/ar_SA.xml
M i18npool/source/localedata/data/ar_TN.xml
6 files changed, 12 insertions(+), 12 deletions(-)



diff --git a/i18npool/source/localedata/data/ar_DZ.xml 
b/i18npool/source/localedata/data/ar_DZ.xml
index 7c2649a..a96ab94 100644
--- a/i18npool/source/localedata/data/ar_DZ.xml
+++ b/i18npool/source/localedata/data/ar_DZ.xml
@@ -51,7 +51,7 @@
 TimePMم/TimePM
 MeasurementSystemmetric/MeasurementSystem
   /LC_CTYPE
-  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$د.ج.‏-1401]
+  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$ د.ج.-1401]
 DateAcceptancePatternD/M/DateAcceptancePattern
 FormatElement msgid=FixedFormatskey1 default=true type=medium 
usage=FIXED_NUMBER formatindex=0
   FormatCodeGeneral/FormatCode
@@ -444,7 +444,7 @@
   LC_CURRENCY
 Currency default=true usedInCompatibleFormatCodes=true
   CurrencyIDDZD/CurrencyID
-  CurrencySymbolد.ج.‏/CurrencySymbol
+  CurrencySymbol د.ج./CurrencySymbol
   BankSymbolDZD/BankSymbol
   CurrencyNameدينار جزائري/CurrencyName
   DecimalPlaces2/DecimalPlaces
diff --git a/i18npool/source/localedata/data/ar_EG.xml 
b/i18npool/source/localedata/data/ar_EG.xml
index 09ce368..f608ccb 100644
--- a/i18npool/source/localedata/data/ar_EG.xml
+++ b/i18npool/source/localedata/data/ar_EG.xml
@@ -51,7 +51,7 @@
 TimePMم/TimePM
 MeasurementSystemmetric/MeasurementSystem
   /LC_CTYPE
-  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$ج.م.‏-C01]
+  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$ ج.م.-C01]
 DateAcceptancePatternD/M/DateAcceptancePattern
 FormatElement msgid=FixedFormatskey1 default=true type=medium 
usage=FIXED_NUMBER formatindex=0
   FormatCodeGeneral/FormatCode
@@ -449,7 +449,7 @@
   LC_CURRENCY
 Currency default=true usedInCompatibleFormatCodes=true
   CurrencyIDEGP/CurrencyID
-  CurrencySymbolج.م.‏/CurrencySymbol
+  CurrencySymbol ج.م./CurrencySymbol
   BankSymbolEGP/BankSymbol
   CurrencyNameEGP/CurrencyName
   DecimalPlaces2/DecimalPlaces
diff --git a/i18npool/source/localedata/data/ar_LB.xml 
b/i18npool/source/localedata/data/ar_LB.xml
index 86aba61..0a058a5 100644
--- a/i18npool/source/localedata/data/ar_LB.xml
+++ b/i18npool/source/localedata/data/ar_LB.xml
@@ -51,7 +51,7 @@
 TimePMم/TimePM
 MeasurementSystemmetric/MeasurementSystem
   /LC_CTYPE
-  LC_FORMAT ref=ar_EG replaceFrom=[CURRENCY] replaceTo=[$ل.ل.‏-3001]/
+  LC_FORMAT ref=ar_EG replaceFrom=[CURRENCY] replaceTo=[$ ل.ل.-3001]/
   LC_COLLATION ref=en_US /
   LC_SEARCH ref=en_US/
   LC_INDEX ref=ar_EG/
@@ -294,7 +294,7 @@
   LC_CURRENCY
 Currency default=true usedInCompatibleFormatCodes=true
   CurrencyIDLBP/CurrencyID
-  CurrencySymbolل.ل.‏/CurrencySymbol
+  CurrencySymbol ل.ل./CurrencySymbol
   BankSymbolLBP/BankSymbol
   CurrencyNameLBP/CurrencyName
   DecimalPlaces2/DecimalPlaces
diff --git a/i18npool/source/localedata/data/ar_OM.xml 
b/i18npool/source/localedata/data/ar_OM.xml
index a31b967..e6b56d4 100644
--- a/i18npool/source/localedata/data/ar_OM.xml
+++ b/i18npool/source/localedata/data/ar_OM.xml
@@ -51,7 +51,7 @@
 TimePMم/TimePM
 MeasurementSystemmetric/MeasurementSystem
   /LC_CTYPE
-  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$ر.ع-2001]
+  LC_FORMAT replaceFrom=[CURRENCY] replaceTo=[$ ر.ع-2001]
 DateAcceptancePatternD/M/DateAcceptancePattern
 FormatElement msgid=FixedFormatskey1 default=true type=medium 
usage=FIXED_NUMBER formatindex=0
   FormatCodeGeneral/FormatCode
@@ -332,7 +332,7 @@
   LC_CURRENCY
 Currency default=true usedInCompatibleFormatCodes=true
   CurrencyIDOMR/CurrencyID
-  CurrencySymbolر.ع/CurrencySymbol
+  CurrencySymbol ر.ع/CurrencySymbol
   BankSymbolOMR/BankSymbol
   CurrencyNameريال عماني/CurrencyName
   DecimalPlaces2/DecimalPlaces
diff --git a/i18npool/source/localedata/data/ar_SA.xml 
b/i18npool/source/localedata/data/ar_SA.xml
index 01b596c..52aea03 100644
--- a/i18npool/source/localedata/data/ar_SA.xml
+++ b/i18npool/source/localedata/data/ar_SA.xml
@@ -51,7 +51,7 @@
 TimePMم/TimePM
 MeasurementSystemmetric/MeasurementSystem
   /LC_CTYPE
-  LC_FORMAT ref=ar_EG replaceFrom=[CURRENCY] replaceTo=[$ر.س.‏-401]/
+  LC_FORMAT ref=ar_EG replaceFrom=[CURRENCY] replaceTo=[$ ر.س.-401]/
   LC_COLLATION ref=en_US /
   LC_SEARCH ref=en_US/
   LC_INDEX ref=ar_EG/
@@ -294,7 +294,7 @@
   LC_CURRENCY
 Currency default=true usedInCompatibleFormatCodes=true
   CurrencyIDSAR/CurrencyID
-

[Libreoffice-commits] core.git: sd/inc sd/source

 sd/inc/app.hxx |   21 -
 sd/inc/eetext.hxx  |   27 ---
 sd/source/core/drawdoc.cxx |4 ++--
 sd/source/core/drawdoc2.cxx|2 +-
 sd/source/core/drawdoc4.cxx|1 -
 sd/source/core/sdobjfac.cxx|2 +-
 sd/source/core/sdpage.cxx  |2 +-
 sd/source/core/stlpool.cxx |2 +-
 sd/source/core/stlsheet.cxx|2 +-
 sd/source/core/typemap.cxx |2 +-
 sd/source/ui/app/optsitem.cxx  |2 +-
 sd/source/ui/app/sddll2.cxx|2 +-
 sd/source/ui/app/tbxww.cxx |2 +-
 sd/source/ui/dlg/LayerTabBar.cxx   |2 +-
 sd/source/ui/dlg/custsdlg.cxx  |2 +-
 sd/source/ui/dlg/paragr.cxx|2 +-
 sd/source/ui/dlg/prltempl.cxx  |2 +-
 sd/source/ui/docshell/docshel3.cxx |2 +-
 sd/source/ui/docshell/docshel4.cxx |2 +-
 sd/source/ui/docshell/docshell.cxx |2 +-
 sd/source/ui/func/fudraw.cxx   |2 +-
 sd/source/ui/func/fuinsert.cxx |2 +-
 sd/source/ui/func/fuprlout.cxx |2 +-
 sd/source/ui/func/fusearch.cxx |2 +-
 sd/source/ui/func/fusel.cxx|2 +-
 sd/source/ui/func/futempl.cxx  |2 +-
 sd/source/ui/func/futhes.cxx   |2 +-
 sd/source/ui/view/Outliner.cxx |4 ++--
 sd/source/ui/view/drtxtob.cxx  |2 +-
 sd/source/ui/view/drtxtob1.cxx |2 +-
 sd/source/ui/view/drviews1.cxx |2 +-
 sd/source/ui/view/drviews3.cxx |2 +-
 sd/source/ui/view/drviews4.cxx |2 +-
 sd/source/ui/view/drviews5.cxx |2 +-
 sd/source/ui/view/drviews6.cxx |2 +-
 sd/source/ui/view/drviewsb.cxx |2 +-
 sd/source/ui/view/drviewsf.cxx |2 +-
 sd/source/ui/view/frmview.cxx  |2 +-
 sd/source/ui/view/outlview.cxx |2 +-
 sd/source/ui/view/sdview.cxx   |2 +-
 sd/source/ui/view/tabcontr.cxx |2 +-
 41 files changed, 40 insertions(+), 89 deletions(-)

New commits:
commit 3af6366dee15674b8e74c084ddc111bc93c5c1c2
Author: Michael Dunphy michael.w.dun...@gmail.com
Date:   Fri Apr 19 15:49:58 2013 -0400

Remove pass-through header files sd/inc/eetext.hxx and sd/inc/app.hxx

Change-Id: Iaccc7c9d81b55ef3a039cb90c4e089ebfc7fe337
Reviewed-on: https://gerrit.libreoffice.org/3487
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/sd/inc/app.hxx b/sd/inc/app.hxx
deleted file mode 100644
index 13eab06..000
--- a/sd/inc/app.hxx
+++ /dev/null
@@ -1,21 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#include sdmod.hxx
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/inc/eetext.hxx b/sd/inc/eetext.hxx
deleted file mode 100644
index f623b38..000
--- a/sd/inc/eetext.hxx
+++ /dev/null
@@ -1,27 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-#ifndef _EETEXT_HXX
-#define _EETEXT_HXX
-
-#include editeng/outliner.hxx
-
-#endif  // EETEXT_HXX
-
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 6a283d4..2d294eb 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -36,7 +36,7 @@
 #include sfx2/linkmgr.hxx

[PATCH] Remove pass-through header files sd/inc/eetext.hxx and sd/in...

Hello LibreOffice gerrit bot,

I'd like you to reexamine a rebased change.  Please visit

https://gerrit.libreoffice.org/3487

to look at the new rebased patch set (#2).

Change subject: Remove pass-through header files sd/inc/eetext.hxx and 
sd/inc/app.hxx
..

Remove pass-through header files sd/inc/eetext.hxx and sd/inc/app.hxx

Change-Id: Iaccc7c9d81b55ef3a039cb90c4e089ebfc7fe337
---
D sd/inc/app.hxx
D sd/inc/eetext.hxx
M sd/source/core/drawdoc.cxx
M sd/source/core/drawdoc2.cxx
M sd/source/core/drawdoc4.cxx
M sd/source/core/sdobjfac.cxx
M sd/source/core/sdpage.cxx
M sd/source/core/stlpool.cxx
M sd/source/core/stlsheet.cxx
M sd/source/core/typemap.cxx
M sd/source/ui/app/optsitem.cxx
M sd/source/ui/app/sddll2.cxx
M sd/source/ui/app/tbxww.cxx
M sd/source/ui/dlg/LayerTabBar.cxx
M sd/source/ui/dlg/custsdlg.cxx
M sd/source/ui/dlg/paragr.cxx
M sd/source/ui/dlg/prltempl.cxx
M sd/source/ui/docshell/docshel3.cxx
M sd/source/ui/docshell/docshel4.cxx
M sd/source/ui/docshell/docshell.cxx
M sd/source/ui/func/fudraw.cxx
M sd/source/ui/func/fuinsert.cxx
M sd/source/ui/func/fuprlout.cxx
M sd/source/ui/func/fusearch.cxx
M sd/source/ui/func/fusel.cxx
M sd/source/ui/func/futempl.cxx
M sd/source/ui/func/futhes.cxx
M sd/source/ui/view/Outliner.cxx
M sd/source/ui/view/drtxtob.cxx
M sd/source/ui/view/drtxtob1.cxx
M sd/source/ui/view/drviews1.cxx
M sd/source/ui/view/drviews3.cxx
M sd/source/ui/view/drviews4.cxx
M sd/source/ui/view/drviews5.cxx
M sd/source/ui/view/drviews6.cxx
M sd/source/ui/view/drviewsb.cxx
M sd/source/ui/view/drviewsf.cxx
M sd/source/ui/view/frmview.cxx
M sd/source/ui/view/outlview.cxx
M sd/source/ui/view/sdview.cxx
M sd/source/ui/view/tabcontr.cxx
41 files changed, 40 insertions(+), 89 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/3487/2
-- 
To view, visit https://gerrit.libreoffice.org/3487
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaccc7c9d81b55ef3a039cb90c4e089ebfc7fe337
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Remove pass-through header files sd/inc/eetext.hxx and sd/in...

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3487

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3487
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaccc7c9d81b55ef3a039cb90c4e089ebfc7fe337
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: tools/inc

2013-04-20 Thread Tor Lillqvist

 tools/inc/tools/gen.hxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 699a22fd492a45a376735e6e9c5f9d474671264f
Author: Tor Lillqvist t...@iki.fi
Date:   Sat Apr 20 16:09:14 2013 +0300

Include cmath for std::abs()

Change-Id: Id94260d41e821386e2c0aef67075658bee7fd49f

diff --git a/tools/inc/tools/gen.hxx b/tools/inc/tools/gen.hxx
index 19d10bd..65f4f8c 100644
--- a/tools/inc/tools/gen.hxx
+++ b/tools/inc/tools/gen.hxx
@@ -24,6 +24,7 @@
 
 #include limits.h
 #include ostream
+#include cmath
 
 class SvStream;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Revert add extra inc. dir for URE headers

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3500

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/3500/1

Revert add extra inc. dir for URE headers

Not needed anymore after moving the headers to $(SRCDIR)/include .

This reverts commit ea09e0352a82dabc26c713adc1825d89ff824178.

Conflicts:
configure.ac

Change-Id: I96c86152d3eff66ccadc9fd76131c0b57763afae
---
M configure.ac
1 file changed, 9 insertions(+), 11 deletions(-)



diff --git a/configure.ac b/configure.ac
index 518c24b..21ee63a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3383,20 +3383,11 @@
 AC_SUBST(x_OBJCXXFLAGS)
 AC_SUBST(x_LDFLAGS)
 
-dnl ===
-dnl Product version
-dnl ===
-AC_MSG_CHECKING([for product version])
-PRODUCTVERSION=AC_PACKAGE_VERSION
-AC_MSG_RESULT([$PRODUCTVERSION])
-AC_SUBST(PRODUCTVERSION)
-
 #
 # determine CPU, CPUNAME, GUI, GUIBASE, ...
 #
 LIB64=lib
 SOLARINC=-I${SRC_ROOT}/include
-SDKDIR=sdk
 
 case $host_os in
 
@@ -3455,7 +3446,6 @@
 OS=MACOSX
 RTL_OS=MacOSX
 P_SEP=:
-SDKDIR=LibreOffice${PRODUCTVERSION}_SDK
 
 case $host_cpu in
 arm*)
@@ -3940,7 +3930,7 @@
 INSTDIR=${BUILDDIR}/instdir/${INPATH}
 fi
 OUTDIR=${SOLARVER}/${INPATH}
-SOLARINC=-I. -I$SRC_ROOT/include -I${SOLARVER}/$INPATH/inc/external 
-I${SOLARVER}/$INPATH/inc -I${INSTDIR}/${SDKDIR}/include $SOLARINC
+SOLARINC=-I. -I$SRC_ROOT/include -I${SOLARVER}/$INPATH/inc/external 
-I${SOLARVER}/$INPATH/inc $SOLARINC
 AC_SUBST(COM)
 AC_SUBST(CPU)
 AC_SUBST(CPUNAME)
@@ -11333,6 +11323,14 @@
 AC_SUBST(MD5SUM)
 
 dnl ===
+dnl Product version
+dnl ===
+AC_MSG_CHECKING([for product version])
+PRODUCTVERSION=AC_PACKAGE_VERSION
+AC_MSG_RESULT([$PRODUCTVERSION])
+AC_SUBST(PRODUCTVERSION)
+
+dnl ===
 dnl Dealing with l10n options
 dnl ===
 AC_MSG_CHECKING([which languages to be built])

-- 
To view, visit https://gerrit.libreoffice.org/3500
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I96c86152d3eff66ccadc9fd76131c0b57763afae
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] move sal_inc headers to include/

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3501

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/3501/1

move sal_inc headers to include/

Change-Id: I840c681b7c500640d3983e05e9895f3fa8bb1313
---
R include/cppunittester/protectorfactory.hxx
R include/osl/detail/android-bootstrap.h
R include/osl/detail/component-mapping.h
R include/osl/detail/file.h
R include/osl/detail/ios-bootstrap.h
R include/systools/win32/comptr.hxx
R include/systools/win32/comtools.hxx
R include/systools/win32/qswin32.h
R include/systools/win32/uwinapi.h
M sal/Module_sal.mk
D sal/Package_inc.mk
M unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx
M unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx
13 files changed, 2 insertions(+), 43 deletions(-)



diff --git a/sal/inc/cppunittester/protectorfactory.hxx 
b/include/cppunittester/protectorfactory.hxx
similarity index 100%
rename from sal/inc/cppunittester/protectorfactory.hxx
rename to include/cppunittester/protectorfactory.hxx
diff --git a/sal/inc/osl/detail/android-bootstrap.h 
b/include/osl/detail/android-bootstrap.h
similarity index 100%
rename from sal/inc/osl/detail/android-bootstrap.h
rename to include/osl/detail/android-bootstrap.h
diff --git a/sal/inc/osl/detail/component-mapping.h 
b/include/osl/detail/component-mapping.h
similarity index 100%
rename from sal/inc/osl/detail/component-mapping.h
rename to include/osl/detail/component-mapping.h
diff --git a/sal/inc/osl/detail/file.h b/include/osl/detail/file.h
similarity index 100%
rename from sal/inc/osl/detail/file.h
rename to include/osl/detail/file.h
diff --git a/sal/inc/osl/detail/ios-bootstrap.h 
b/include/osl/detail/ios-bootstrap.h
similarity index 100%
rename from sal/inc/osl/detail/ios-bootstrap.h
rename to include/osl/detail/ios-bootstrap.h
diff --git a/sal/inc/systools/win32/comptr.hxx 
b/include/systools/win32/comptr.hxx
similarity index 100%
rename from sal/inc/systools/win32/comptr.hxx
rename to include/systools/win32/comptr.hxx
diff --git a/sal/inc/systools/win32/comtools.hxx 
b/include/systools/win32/comtools.hxx
similarity index 100%
rename from sal/inc/systools/win32/comtools.hxx
rename to include/systools/win32/comtools.hxx
diff --git a/sal/inc/systools/win32/qswin32.h b/include/systools/win32/qswin32.h
similarity index 100%
rename from sal/inc/systools/win32/qswin32.h
rename to include/systools/win32/qswin32.h
diff --git a/sal/inc/systools/win32/uwinapi.h b/include/systools/win32/uwinapi.h
similarity index 100%
rename from sal/inc/systools/win32/uwinapi.h
rename to include/systools/win32/uwinapi.h
diff --git a/sal/Module_sal.mk b/sal/Module_sal.mk
index fdfbfc6..a8ed0f5 100644
--- a/sal/Module_sal.mk
+++ b/sal/Module_sal.mk
@@ -38,7 +38,6 @@
Library_sal_textenc) \
$(if $(filter $(OS),WNT), \
Library_uwinapi) \
-   Package_inc \
StaticLibrary_salcpprt \
 ))
 
diff --git a/sal/Package_inc.mk b/sal/Package_inc.mk
deleted file mode 100644
index 98281d1..000
--- a/sal/Package_inc.mk
+++ /dev/null
@@ -1,40 +0,0 @@
-# -*- Mode: makefile; tab-width: 4; indent-tabs-mode: t -*-
-#
-# Version: MPL 1.1 / GPLv3+ / LGPLv3+
-#
-# The contents of this file are subject to the Mozilla Public License Version
-# 1.1 (the License); you may not use this file except in compliance with
-# the License or as specified alternatively below. You may obtain a copy of
-# the License at http://www.mozilla.org/MPL/
-#
-# Software distributed under the License is distributed on an AS IS basis,
-# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
-# for the specific language governing rights and limitations under the
-# License.
-#
-# Major Contributor(s):
-# Copyright (C) 2011 Matúš Kukan matus.ku...@gmail.com (initial developer)
-#
-# All Rights Reserved.
-#
-# For minor contributions see the git repository.
-#
-# Alternatively, the contents of this file may be used under the terms of
-# either the GNU General Public License Version 3 or later (the GPLv3+), or
-# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
-# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
-# instead of those above.
-
-$(eval $(call gb_Package_Package,sal_inc,$(SRCDIR)/sal/inc))
-
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/protectorfactory.hxx,cppunittester/protectorfactory.hxx))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/file.h,osl/detail/file.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android-bootstrap.h,osl/detail/android-bootstrap.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/ios-bootstrap.h,osl/detail/ios-bootstrap.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/component-mapping.h,osl/detail/component-mapping.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/systools/win32/comptr.hxx,systools/win32/comptr.hxx))
-$(eval $(call

[PATCH] gbuild: drop empty use_packages calls

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3503

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/3503/1

gbuild: drop empty use_packages calls

Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f
---
M animations/Library_animcore.mk
M basegfx/Library_basegfx.mk
M basic/AllLangResTarget_sb.mk
M bean/Library_officebean.mk
M canvas/Library_canvasfactory.mk
M chart2/AllLangResTarget_chartcontroller.mk
M codemaker/StaticLibrary_codemaker.mk
M codemaker/StaticLibrary_codemaker_cpp.mk
M codemaker/StaticLibrary_codemaker_java.mk
M connectivity/CppunitTest_connectivity_commontools.mk
M connectivity/Library_dbtools.mk
M connectivity/Library_kabdrv1.mk
M connectivity/Library_tdeab1.mk
M connectivity/Library_tdeabdrv1.mk
M cosv/StaticLibrary_cosv.mk
M cppuhelper/StaticLibrary_findsofficepath.mk
M cui/AllLangResTarget_cui.mk
M dbaccess/AllLangResTarget_dba.mk
M dbaccess/AllLangResTarget_dbmm.mk
M dbaccess/AllLangResTarget_sdbt.mk
M desktop/AllLangResTarget_deploymentgui.mk
M desktop/AllLangResTarget_dkt.mk
M desktop/Executable_unopkg.com.mk
M desktop/Executable_unopkg.mk
M desktop/Library_libreoffice.mk
M desktop/StaticLibrary_winextendloaderenv.mk
M dtrans/StaticLibrary_dtobj.mk
M editeng/AllLangResTarget_editeng.mk
M embeddedobj/Library_embobj.mk
M embedserv/Library_inprocserv.mk
M extensions/AllLangResTarget_abp.mk
M extensions/AllLangResTarget_bib.mk
M extensions/AllLangResTarget_dbp.mk
M extensions/Executable_nsplugin.mk
M extensions/Library_bib.mk
M extensions/Library_log.mk
M extensions/Library_updatecheckui.mk
M extensions/Library_updchk.mk
M extensions/StaticLibrary_npsoenv.mk
M filter/AllLangResTarget_pdffilter.mk
M filter/AllLangResTarget_xsltdlg.mk
M forms/AllLangResTarget_frm.mk
M formula/AllLangResTarget_for.mk
M formula/AllLangResTarget_forui.mk
M formula/Library_for.mk
M fpicker/AllLangResTarget_fps_office.mk
M fpicker/Library_fps.mk
M fpicker/Library_fps_aqua.mk
M framework/AllLangResTarget_fwe.mk
M i18nlangtag/Library_i18nlangtag.mk
M jurt/Library_jpipe.mk
M jvmaccess/Library_jvmaccess.mk
M jvmfwk/Library_jvmfwk.mk
M jvmfwk/Library_sunjavaplugin.mk
M l10ntools/StaticLibrary_transex.mk
M lingucomponent/StaticLibrary_ulingu.mk
M mysqlcppconn/Library_mysqlcppconn.mk
M np_sdk/StaticLibrary_nputils.mk
M odk/Executable_unoapploader.mk
M pyuno/Library_pyuno_wrapper.mk
M registry/Library_reg.mk
M registry/StaticLibrary_registry_helper.mk
M sal/Library_sal.mk
M sal/Library_uwinapi.mk
M sal/StaticLibrary_salcpprt.mk
M sax/Library_sax.mk
M sax/StaticLibrary_sax_shared.mk
M sc/Library_sc.mk
M sdext/Executable_xpdfimport.mk
M sdext/StaticLibrary_pdfimport_s.mk
M sfx2/AllLangResTarget_sfx2.mk
M shell/Library_kdebe.mk
M shell/Library_tdebe.mk
M slideshow/Library_slideshow.mk
M starmath/Library_smd.mk
M store/Library_store.mk
M svl/AllLangResTarget_svl.mk
M svl/Library_svl.mk
M svtools/AllLangResTarget_svt.mk
M svx/AllLangResTarget_gal.mk
M svx/AllLangResTarget_ofa.mk
M svx/AllLangResTarget_svx.mk
M svx/AllLangResTarget_textconversiondlgs.mk
M svx/Library_textconversiondlgs.mk
M sw/Library_sw.mk
M testtools/StaticLibrary_bridgetest.mk
M tools/StaticLibrary_ooopathutils.mk
M ucb/Library_srtrs1.mk
M ucb/Library_ucpext.mk
M udm/StaticLibrary_udm.mk
M uui/AllLangResTarget_uui.mk
M vcl/AllLangResTarget_vcl.mk
M vcl/Library_vcl.mk
M vcl/Library_vclplug_kde.mk
M vcl/Library_vclplug_tde.mk
M vcl/StaticLibrary_headless.mk
M vcl/StaticLibrary_vclmain.mk
M writerperfect/StaticLibrary_writerperfect.mk
M xmlscript/Library_xmlscript.mk
M xmlsecurity/AllLangResTarget_xsec.mk
100 files changed, 0 insertions(+), 300 deletions(-)



diff --git a/animations/Library_animcore.mk b/animations/Library_animcore.mk
index cbab833..d0eb763 100644
--- a/animations/Library_animcore.mk
+++ b/animations/Library_animcore.mk
@@ -30,9 +30,6 @@
 
 $(eval $(call gb_Library_use_external,animcore,boost_headers))
 
-$(eval $(call gb_Library_use_packages,animcore,\
-))
-
 $(eval $(call 
gb_Library_set_componentfile,animcore,animations/source/animcore/animcore))
 
 $(eval $(call gb_Library_use_sdk_api,animcore))
diff --git a/basegfx/Library_basegfx.mk b/basegfx/Library_basegfx.mk
index 8605b1cc..532cc74 100644
--- a/basegfx/Library_basegfx.mk
+++ b/basegfx/Library_basegfx.mk
@@ -11,9 +11,6 @@
 
 $(eval $(call gb_Library_use_external,basegfx,boost_headers))
 
-$(eval $(call gb_Library_use_packages,basegfx,\
-))
-
 $(eval $(call gb_Library_use_sdk_api,basegfx))
 
 $(eval $(call gb_Library_use_libraries,basegfx,\
diff --git a/basic/AllLangResTarget_sb.mk b/basic/AllLangResTarget_sb.mk
index fffe07b..fa79228 100644
--- a/basic/AllLangResTarget_sb.mk
+++ b/basic/AllLangResTarget_sb.mk
@@ -26,9 +26,6 @@
 
 $(eval $(call gb_SrsTarget_SrsTarget,sb/res))
 
-$(eval $(call gb_SrsTarget_use_packages,sb/res,\
-))
-
 $(eval $(call gb_SrsTarget_set_include,sb/res,\
$$(INCLUDE) \
 -I$(SRCDIR)/basic/inc \
diff --git a/bean/Library_officebean.mk b/bean/Library_officebean.mk
index

[PATCH] gbuild: drop unneeded package

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3504

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/3504/1

gbuild: drop unneeded package

Change-Id: I9d0fa82302f07b2ae3820d416556d2c4e40f70df
---
M sd/Module_sd.mk
D sd/Package_inc.mk
2 files changed, 0 insertions(+), 33 deletions(-)



diff --git a/sd/Module_sd.mk b/sd/Module_sd.mk
index b2df89a..d759df0 100644
--- a/sd/Module_sd.mk
+++ b/sd/Module_sd.mk
@@ -34,7 +34,6 @@
 Library_sdd \
 Library_sdfilt \
 Library_sdui \
-Package_inc \
 Package_web \
 Package_xml \
 UIConfig_sdraw \
diff --git a/sd/Package_inc.mk b/sd/Package_inc.mk
deleted file mode 100644
index 6c981cd..000
--- a/sd/Package_inc.mk
+++ /dev/null
@@ -1,32 +0,0 @@
-# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
-# Version: MPL 1.1 / GPLv3+ / LGPLv3+
-#
-# The contents of this file are subject to the Mozilla Public License Version
-# 1.1 (the License); you may not use this file except in compliance with
-# the License or as specified alternatively below. You may obtain a copy of
-# the License at http://www.mozilla.org/MPL/
-#
-# Software distributed under the License is distributed on an AS IS basis,
-# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
-# for the specific language governing rights and limitations under the
-# License.
-#
-# Major Contributor(s):
-# Copyright (C) 2010 Red Hat, Inc., David Tardon dtar...@redhat.com
-#  (initial developer)
-#
-# All Rights Reserved.
-#
-# For minor contributions see the git repository.
-#
-# Alternatively, the contents of this file may be used under the terms of
-# either the GNU General Public License Version 3 or later (the GPLv3+), or
-# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
-# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
-# instead of those above.
-
-$(eval $(call gb_Package_Package,sd_inc,$(SRCDIR)/sd/inc))
-
-$(eval $(call gb_Package_add_file,sd_inc,inc/sd/sddll.hxx,sddll.hxx))
-
-# vim: set noet sw=4 ts=4:

-- 
To view, visit https://gerrit.libreoffice.org/3504
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d0fa82302f07b2ae3820d416556d2c4e40f70df
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] gbuild: do not deliver UNO API headers

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3505

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/3505/1

gbuild: do not deliver UNO API headers

There is no reason to copy 1000s of files to $(OUTDIR)/inc when we can
easily include them from $(WORKDIR).

Change-Id: I133ab6506ba76af132143b982f056e652c09d8f5
---
M solenv/gbuild/LinkTarget.mk
M solenv/gbuild/UnoApi.mk
M svx/Executable_gengal.bin.mk
3 files changed, 4 insertions(+), 10 deletions(-)



diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index e8ce7f0..3a11f30 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -758,8 +758,7 @@
 
 define gb_LinkTarget__use_api
 $(call gb_LinkTarget_get_target,$(1)) :| $(call gb_UnoApi_get_target,$(2))
-$(call gb_LinkTarget_use_package,$(1),$(2)_inc)
-$(call gb_LinkTarget__add_include,$(1),$(OUTDIR)/inc/$(2))
+$(call gb_LinkTarget__add_include,$(1),$(call 
gb_UnoApiHeadersTarget_get_dir,$(2)))
 
 endef
 
diff --git a/solenv/gbuild/UnoApi.mk b/solenv/gbuild/UnoApi.mk
index a7a6a15..7e8b9d9 100644
--- a/solenv/gbuild/UnoApi.mk
+++ b/solenv/gbuild/UnoApi.mk
@@ -35,19 +35,16 @@
 $(call gb_UnoApiHeadersTarget_UnoApiHeadersTarget,$(1))
 $(call gb_Package_Package_internal,$(1)_idl,$(SRCDIR))
 $(call gb_Package_set_outdir,$(1)_idl,$(INSTDIR))
-$(call gb_Package_Package_internal,$(1)_inc,$(call 
gb_UnoApiHeadersTarget_get_dir,$(1)))
 
 $(call gb_UnoApiTarget_set_root,$(1),UCR)
 
 $(call gb_UnoApi_get_target,$(1)) :| $(dir $(call 
gb_UnoApi_get_target,$(1))).dir
 $(call gb_UnoApi_get_target,$(1)) : $(call gb_UnoApiTarget_get_target,$(1))
-$(call gb_UnoApi_get_target,$(1)) :| $(call gb_Package_get_target,$(1)_inc)
+$(call gb_UnoApi_get_target,$(1)) : $(call 
gb_UnoApiHeadersTarget_get_target,$(1))
 $(call gb_UnoApi_get_clean_target,$(1)) : $(call 
gb_UnoApiTarget_get_clean_target,$(1))
 $(call gb_UnoApi_get_clean_target,$(1)) : $(call 
gb_UnoApiHeadersTarget_get_clean_target,$(1))
-$(call gb_UnoApi_get_clean_target,$(1)) : $(call 
gb_Package_get_clean_target,$(1)_inc)
 
 $(call gb_UnoApiTarget_get_headers_target,$(1)) : $(call 
gb_Package_get_target,$(1)_idl)
-$(call gb_Package_get_preparation_target,$(1)_inc) : $(call 
gb_UnoApiHeadersTarget_get_target,$(1))
 
 $(call gb_Deliver_add_deliverable,$(call gb_UnoApi_get_target,$(1)),$(call 
gb_UnoApiTarget_get_target,$(1)),$(1))
 
@@ -71,7 +68,6 @@
 endef
 
 define gb_UnoApi__add_headerfile_impl
-$(call gb_Package_add_file,$(1)_inc,inc/$(2),$(3))
 $(call gb_UnoApiHeadersTarget_add_headerfile,$(1),$(2),$(3))
 
 endef
diff --git a/svx/Executable_gengal.bin.mk b/svx/Executable_gengal.bin.mk
index 74c8278..7be4ace 100644
--- a/svx/Executable_gengal.bin.mk
+++ b/svx/Executable_gengal.bin.mk
@@ -30,13 +30,12 @@
 $$(INCLUDE) \
 -I$(SRCDIR)/svx/inc/ \
 -I$(SRCDIR)/svx/inc/pch \
--I$(OUTDIR)/inc/offuh \
--I$(OUTDIR)/inc/udkapi \
--I$(OUTDIR)/inc/offapi \
 ))
 
 $(eval $(call gb_Executable_use_external,$(svx_GENGALBIN),boost_headers))
 
+$(eval $(call gb_Executable_use_sdk_api,$(svx_GENGALBIN)))
+
 $(eval $(call gb_Executable_use_libraries,$(svx_GENGALBIN),\
 basegfx \
 sal \

-- 
To view, visit https://gerrit.libreoffice.org/3505
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I133ab6506ba76af132143b982f056e652c09d8f5
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] gbuild: fix generated deps for API headers

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3506

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/3506/1

gbuild: fix generated deps for API headers

This should be reverted after some time, as it solves a one-time
problem.

Change-Id: Iaa4bc17267a24bd744573e56108b8d207936629c
---
M solenv/gbuild/UnoApi.mk
1 file changed, 11 insertions(+), 0 deletions(-)



diff --git a/solenv/gbuild/UnoApi.mk b/solenv/gbuild/UnoApi.mk
index 7e8b9d9..bb690cf 100644
--- a/solenv/gbuild/UnoApi.mk
+++ b/solenv/gbuild/UnoApi.mk
@@ -25,6 +25,15 @@
 # in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
 # instead of those above.
 
+# NOTE: This is needed temporarily to force rebuild with API files from
+# $(WORKDIR), thus fixing generated deps. Otherwise, a change of an .idl
+# file would not rebuild a .cxx if it still depended on the $(OUTDIR)
+# version of the header.
+define gb_UnoApi__make_outdir_headers_rule
+$(OUTDIR)/inc/$(1)/%.hdl $(OUTDIR)/inc/$(1)/%.hpp :
+   @true
+endef
+
 .PHONY : $(call gb_UnoApi_get_clean_target,%)
 $(call gb_UnoApi_get_clean_target,%) :
$(call gb_Helper_abbreviate_dirs,\
@@ -46,6 +55,8 @@
 
 $(call gb_UnoApiTarget_get_headers_target,$(1)) : $(call 
gb_Package_get_target,$(1)_idl)
 
+$(call gb_UnoApi__make_outdir_headers_rule,$(1))
+
 $(call gb_Deliver_add_deliverable,$(call gb_UnoApi_get_target,$(1)),$(call 
gb_UnoApiTarget_get_target,$(1)),$(1))
 
 $$(eval $$(call gb_Module_register_target,$(call 
gb_UnoApi_get_target,$(1)),$(call gb_UnoApi_get_clean_target,$(1

-- 
To view, visit https://gerrit.libreoffice.org/3506
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa4bc17267a24bd744573e56108b8d207936629c
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#63749: #118845# corrected missing ressource for gallery ...

2013-04-20 Thread Thomas Arnhold (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3507

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/3507/1

fdo#63749: #118845# corrected missing ressource for gallery theme htmlexpo

(cherry picked from commit fee688fd96329f628f83623ea91c32e10eeb134b)

Conflicts:
svx/inc/svx/gallery.hxx

Change-Id: I263bc8bcd4232d8e9b4a971fd611b451840618a3
---
D extras/source/gallery/gallery_system/sg25.sdg
D extras/source/gallery/gallery_system/sg25.sdv
D extras/source/gallery/gallery_system/sg25.thm
M svx/inc/galtheme.hrc
M svx/inc/svx/gallery.hxx
M svx/source/gallery2/galtheme.src
6 files changed, 10 insertions(+), 1 deletion(-)



diff --git a/extras/source/gallery/gallery_system/sg25.sdg 
b/extras/source/gallery/gallery_system/sg25.sdg
deleted file mode 100644
index af78e56..000
--- a/extras/source/gallery/gallery_system/sg25.sdg
+++ /dev/null
Binary files differ
diff --git a/extras/source/gallery/gallery_system/sg25.sdv 
b/extras/source/gallery/gallery_system/sg25.sdv
deleted file mode 100644
index 4449591..000
--- a/extras/source/gallery/gallery_system/sg25.sdv
+++ /dev/null
Binary files differ
diff --git a/extras/source/gallery/gallery_system/sg25.thm 
b/extras/source/gallery/gallery_system/sg25.thm
deleted file mode 100644
index e7b0a49..000
--- a/extras/source/gallery/gallery_system/sg25.thm
+++ /dev/null
Binary files differ
diff --git a/svx/inc/galtheme.hrc b/svx/inc/galtheme.hrc
index 7eda727..52b9fdd 100644
--- a/svx/inc/galtheme.hrc
+++ b/svx/inc/galtheme.hrc
@@ -39,7 +39,7 @@
 #define RID_GALLERYSTR_THEME_MAPS   (RID_GALLERYSTR_THEME_START + 12)
 #define RID_GALLERYSTR_THEME_PEOPLE 
(RID_GALLERYSTR_THEME_START + 13)
 #define RID_GALLERYSTR_THEME_SURFACES   
(RID_GALLERYSTR_THEME_START + 14)
-// free
+#define RID_GALLERYSTR_THEME_HTMLBUTTONS
(RID_GALLERYSTR_THEME_START + 15)
 #define RID_GALLERYSTR_THEME_POWERPOINT 
(RID_GALLERYSTR_THEME_START + 16)
 #define RID_GALLERYSTR_THEME_SOUNDS (RID_GALLERYSTR_THEME_START + 18)
 #define RID_GALLERYSTR_THEME_SYMBOLS
(RID_GALLERYSTR_THEME_START + 19)
diff --git a/svx/inc/svx/gallery.hxx b/svx/inc/svx/gallery.hxx
index f7b7b56..a2b010b 100644
--- a/svx/inc/svx/gallery.hxx
+++ b/svx/inc/svx/gallery.hxx
@@ -41,6 +41,7 @@
 #define GALLERY_THEME_3D1
 #define GALLERY_THEME_BULLETS   3
 #define GALLERY_THEME_HOMEPAGE  10
+#define GALLERY_THEME_HTMLBUTTONS   15
 #define GALLERY_THEME_POWERPOINT16
 #define GALLERY_THEME_SOUNDS18
 #define GALLERY_THEME_USERSOUNDS21
diff --git a/svx/source/gallery2/galtheme.src b/svx/source/gallery2/galtheme.src
index 34650c5..4b63b82 100644
--- a/svx/source/gallery2/galtheme.src
+++ b/svx/source/gallery2/galtheme.src
@@ -119,6 +119,14 @@
 
 // 
-
 
+String RID_GALLERYSTR_THEME_HTMLBUTTONS
+{
+// !!! Don't translate, please !!!
+Text = private://gallery/hidden/HtmlExportButtons;
+};
+
+// 
-
+
 String RID_GALLERYSTR_THEME_POWERPOINT
 {
 // !!! Don't translate, please !!!

-- 
To view, visit https://gerrit.libreoffice.org/3507
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I263bc8bcd4232d8e9b4a971fd611b451840618a3
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Thomas Arnhold tho...@arnhold.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 2 commits - fpicker/Library_fps_office.mk solenv/gbuild

 fpicker/Library_fps_office.mk |5 -
 solenv/gbuild/LinkTarget.mk   |8 
 2 files changed, 8 insertions(+), 5 deletions(-)

New commits:
commit 1a02fb9e70fca278be1dbef03e6b73394ffe8397
Author: David Tardon dtar...@redhat.com
Date:   Sat Apr 20 15:30:04 2013 +0200

drop -I of nonexistent dir

Change-Id: Ife9d8f758fa5a46e2ab29d43eec0a5112495ed5f

diff --git a/fpicker/Library_fps_office.mk b/fpicker/Library_fps_office.mk
index f94453e..d01870f 100644
--- a/fpicker/Library_fps_office.mk
+++ b/fpicker/Library_fps_office.mk
@@ -33,11 +33,6 @@ $(eval $(call 
gb_Library_use_external,fps_office,boost_headers))
 
 $(eval $(call gb_Library_use_sdk_api,fps_office))
 
-$(eval $(call gb_Library_set_include,fps_office,\
-$$(INCLUDE) \
--I$(SRCDIR)/fpicker/inc \
-))
-
 $(eval $(call gb_Library_use_libraries,fps_office,\
comphelper \
cppu \
commit cd0d9485972bdb27a993ef4d9d612b61ba71
Author: David Tardon dtar...@redhat.com
Date:   Sat Apr 20 15:24:30 2013 +0200

warn if using nonexist. dirs in include path

Change-Id: If3c44175a20b7c1720c7200c9bb06372740f95fe

diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index 44e41f2..720a23d 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -718,7 +718,15 @@ endif
 
 endef
 
+define gb_LinkTarget__check_srcdir_paths
+$(if $(filter-out $(wildcard $(2)),$(2)),\
+$(call gb_Output_warn,gb_LinkTarget_set_include: include paths 
$(filter-out $(wildcard $(2)),$(2)) do not exist) \
+)
+endef
+
 define gb_LinkTarget_set_include
+$(call gb_LinkTarget__check_srcdir_paths,$(1),\
+$(patsubst -I%,%,$(filter -I$(SRCDIR)/%,$(filter-out -I$(OUTDIR)/% 
-I$(WORKDIR)/%,$(2)
 $(call gb_LinkTarget_get_headers_target,$(1)) \
 $(call gb_LinkTarget_get_target,$(1)) : INCLUDE := $(2)
 ifeq ($(gb_FULLDEPS),$(true))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: minutes of ESC call ...

Hi,

On Thu, Apr 18, 2013 at 03:54:19PM +0100, Michael Meeks wrote:
 * Header rename script (Bjoern)
   + https://gerrit.libreoffice.org/#/c/3367/
   + if run the script, everything succeeds, and it builds.
   + at this stage - it ignores sal - which is magic somehow
   + use it as-is  move ahead.
   + do the remaining cleanup afterwards.

I pushed a sequence of follow-up reviews that move cppu, cppuhelper, sal
and salhelper headers, stop copying generated UNO API headers to
$(OUTDIR) and do several more assorted cleanups.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Python extension not working on Mac (LibreOffice 4.0.2.2)

2013-04-20 Thread Norbert Thiebaud

On Fri, Apr 19, 2013 at 7:37 PM, Carles Pina i Estany car...@pina.cat wrote:

 Oh I see. I've just seen Stephan Bergmann other message in the mailing
 list. If you have a link to the git commit feel free to send - just out
 of curiosity.

That was not a code issue, but a build environment issue.
so there is no commit associated, just a rebuild of the release package.

 Cool, I'll download the 4.0.3.1 version from
 http://www.libreoffice.org/download/pre-releases/ and report here. I
 guess that the date at least will change from 2013-04-18 to a newer one.

yep

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: tools/inc

 tools/inc/tools/gen.hxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 609cb4b332e4b2ddb1f449ba059fd33c3d49dc84
Author: David Tardon dtar...@redhat.com
Date:   Sat Apr 20 16:27:19 2013 +0200

we want the int. overloads of abs() here

Change-Id: Ie82c51f65a2a0e13d6d30c85a23286574fd50b90

diff --git a/tools/inc/tools/gen.hxx b/tools/inc/tools/gen.hxx
index 65f4f8c..c1a1e35 100644
--- a/tools/inc/tools/gen.hxx
+++ b/tools/inc/tools/gen.hxx
@@ -24,7 +24,7 @@
 
 #include limits.h
 #include ostream
-#include cmath
+#include cstdlib
 
 class SvStream;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/v2'

2013-04-20 Thread Libreoffice Gerrit user

New branch 'feature/v2' available with the following commits:
commit 8a53478152d3edb190b650db75fd8a248ce20249
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sat Apr 20 09:49:46 2013 -0500

tb: major rework to simplify things

We drop the notin of 'branches'
expand the role of profile... particularely most
variables are now profiles levels and we can have an
instance of tb that monitor multiple profiles

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: chart2/source cui/source filter/source sc/inc sc/source sd/inc sd/source sfx2/source sot/inc sot/Package_inc.mk sot/source starmath/inc starmath/source svtools/inc svto

 chart2/source/view/main/ChartView.cxx |2 -
 cui/source/dialogs/insdlg.cxx |2 -
 filter/source/msfilter/msdffimp.cxx   |2 -
 filter/source/msfilter/msoleexp.cxx   |2 -
 sc/inc/pch/precompiled_sc.hxx |2 -
 sc/source/filter/starcalc/scfobj.cxx  |2 -
 sc/source/ui/app/scdll.cxx|2 -
 sc/source/ui/docshell/docsh.cxx   |2 -
 sc/source/ui/drawfunc/fuins2.cxx  |2 -
 sc/source/ui/unoobj/chartuno.cxx  |2 -
 sc/source/ui/view/gridwin.cxx |2 -
 sc/source/ui/view/viewfun3.cxx|2 -
 sc/source/ui/view/viewfun5.cxx|2 -
 sd/inc/pch/precompiled_sd.hxx |2 -
 sd/source/filter/eppt/epptso.cxx  |2 -
 sd/source/ui/docshell/docshel4.cxx|2 -
 sd/source/ui/docshell/docshell.cxx|2 -
 sd/source/ui/docshell/grdocsh.cxx |2 -
 sd/source/ui/func/fuinsert.cxx|2 -
 sd/source/ui/view/sdview3.cxx |2 -
 sd/source/ui/view/viewshe2.cxx|2 -
 sfx2/source/doc/objxtor.cxx   |2 -
 sfx2/source/doc/sfxbasemodel.cxx  |2 -
 sot/Package_inc.mk|1 
 sot/inc/sot/clsids.hxx|   27 --
 sot/source/base/exchange.cxx  |2 -
 sot/source/base/factory.cxx   |2 -
 sot/source/base/formats.cxx   |2 -
 sot/source/sdstor/ucbstorage.cxx  |2 -
 starmath/inc/pch/precompiled_sm.hxx   |2 -
 starmath/source/document.cxx  |2 -
 svtools/inc/pch/precompiled_svt.hxx   |2 -
 svtools/source/dialogs/insdlg.cxx |2 -
 svtools/source/misc/embedhlp.cxx  |2 -
 svtools/source/misc/imagemgr.cxx  |2 -
 svx/inc/pch/precompiled_svxcore.hxx   |2 -
 svx/source/svdraw/charthelper.cxx |2 -
 svx/source/svdraw/svdoole2.cxx|2 -
 svx/source/svdraw/svdpage.cxx |2 -
 svx/source/unodraw/unopage.cxx|2 -
 svx/source/unodraw/unoshap4.cxx   |2 -
 svx/source/xml/xmleohlp.cxx   |2 -
 sw/inc/pch/precompiled_sw.hxx |2 -
 sw/source/core/doc/doctxm.cxx |2 -
 sw/source/filter/basflt/fltini.cxx|2 -
 sw/source/filter/html/SwAppletImpl.cxx|2 -
 sw/source/filter/html/htmlplug.cxx|2 -
 sw/source/filter/xml/xmltexte.cxx |2 -
 sw/source/filter/xml/xmltexti.cxx |2 -
 sw/source/ui/app/docsh.cxx|2 -
 sw/source/ui/app/docsh2.cxx   |2 -
 sw/source/ui/config/modcfg.cxx|2 -
 sw/source/ui/config/optload.cxx   |2 -
 sw/source/ui/frmdlg/frmpage.cxx   |2 -
 sw/source/ui/globdoc/globdoc.cxx  |2 -
 sw/source/ui/shells/textsh.cxx|2 -
 sw/source/ui/table/chartins.cxx   |2 -
 sw/source/ui/table/tablemgr.cxx   |2 -
 sw/source/ui/uno/swdet2.cxx   |2 -
 sw/source/ui/web/wdocsh.cxx   |2 -
 xmloff/inc/pch/precompiled_xo.hxx |2 -
 xmloff/source/chart/SchXMLExport.cxx  |2 -
 xmloff/source/core/XMLEmbeddedObjectImportContext.cxx |2 -
 xmloff/source/draw/shapeexport.cxx|2 -
 64 files changed, 62 insertions(+), 90 deletions(-)

New commits:
commit 8546c324ff8bd69d5730935f68247a995489671a
Author: Michael Dunphy michael.w.dun...@gmail.com
Date:   Fri Apr 19 18:08:13 2013 -0400

Remove pass-through header file sot/inc/sot/clsids.hxx

Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Reviewed-on: https://gerrit.libreoffice.org/3490
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/chart2/source/view/main/ChartView.cxx 
b/chart2/source/view/main/ChartView.cxx
index 620558b..e5ae969 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -101,7 +101,7 @@
 #include com/sun/star/text/XTextEmbeddedObjectsSupplier.hpp
 #include com/sun/star/view/XSelectionSupplier.hpp

[PUSHED] Remove pass-through header file sot/inc/sot/clsids.hxx

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3490

Approvals:
  LibreOffice gerrit bot: Verified
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3490
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I122669d4ffaf72fb1d5f6fccc98e8a648f31aa23
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: openssl/ExternalProject_openssl.mk

2013-04-20 Thread Markus Mohrhard

 openssl/ExternalProject_openssl.mk |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 6912b8e0c51bcac956c2c05b2fafdf84df7ae8ee
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Fri Apr 19 22:35:31 2013 +0200

enable symbols and disable optimization in openssl for a dbgutil build

Change-Id: I2100d40264c067b22548025ab3a3be32a23835a6
Reviewed-on: https://gerrit.libreoffice.org/3489
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/openssl/ExternalProject_openssl.mk 
b/openssl/ExternalProject_openssl.mk
index 97cd10f..2666965 100644
--- a/openssl/ExternalProject_openssl.mk
+++ b/openssl/ExternalProject_openssl.mk
@@ -19,8 +19,9 @@ OPENSSL_PLATFORM := $(if $(filter LINUX FREEBSD 
ANDROID,$(OS)),\
$(if $(filter I,$(CPU)),\
  $(if $(filter GNU/kFreeBSD,$(shell 
uname)),debian-kfreebsd-i386,linux-elf),\
  $(if $(filter X,$(CPU)),\
-   $(if $(filter GNU/kFreeBSD,$(shell 
uname)),debian-kfreebsd-amd64,linux-generic64),\
-   linux-generic32)),\
+   $(if $(filter GNU/kFreeBSD,$(shell uname)),debian-kfreebsd-amd64,\
+   $(if $(filter TRUE, $(ENABLE_DBGUTIL)), debug-linux-generic64, 
linux-generic64)),\
+   $(if $(filter TRUE, $(ENABLE_DBGUTIL)), debug-linux-generic32, 
linux-generic32))),\
$(if $(filter SOLARIS,$(OS)),\
$(if $(filter INTEL,$(CPUNAME)),\
$(if $(filter X,$(CPU)),\
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PUSHED] enable symbols and disable optimization in openssl for a dbg...

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3489

Approvals:
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3489
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2100d40264c067b22548025ab3a3be32a23835a6
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Markus Mohrhard markus.mohrh...@googlemail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Empty Advanced options page on Windows

2013-04-20 Thread Thomas Arnhold


Hi Kohei,

I tried it with the latest daily build but can't confirm your problem.

Version: 4.1.0.0.alpha0+
Build ID: fa72fc3eddbfabb82193452a4ba993b11d1584d
TinderBox: Win-x86@6, Branch:master, Time: 2013-04-18_23:11:53

Thomas


On 17.04.2013 15:19, Thomas Arnhold wrote:

Hi Kohei,

seems to be my fault (7c48a2a83f4a92200c7f2b0f259bf1684d253436).

I'll investigate it.

Thomas

On 17.04.2013 14:49, Kohei Yoshida wrote:

Hi there,

I just completed my Windows build of the master branch and noticed that,
the Advanced options page is for some reason totally blank.  If my
attachment goes through, you can see it in the attached screenshot.

Does this ring any bell to anyone?

Kohei


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Remove unused headers from three modules

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3508

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/3508/1

Remove unused headers from three modules

Change-Id: Ie02f99f42dbcbd613bb819da234e37dbfb3b0d89
---
M cpputools/source/sp2bv/sp2bv.cxx
M cpputools/source/unoexe/unoexe.cxx
M fileaccess/source/FileAccess.cxx
M sccomp/source/solver/solver.cxx
4 files changed, 0 insertions(+), 30 deletions(-)



diff --git a/cpputools/source/sp2bv/sp2bv.cxx b/cpputools/source/sp2bv/sp2bv.cxx
index a4147df..53ee08e 100644
--- a/cpputools/source/sp2bv/sp2bv.cxx
+++ b/cpputools/source/sp2bv/sp2bv.cxx
@@ -17,11 +17,9 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 #include stdio.h
-#include stdlib.h
 #include string.h
 #include osl/thread.h
 #include osl/file.h
-#include rtl/ustring.hxx
 #include rtl/ustrbuf.h
 
 static sal_Bool hasOption(char const * szOption, int argc, char** argv);
diff --git a/cpputools/source/unoexe/unoexe.cxx 
b/cpputools/source/unoexe/unoexe.cxx
index 7343aae..8123cf1 100644
--- a/cpputools/source/unoexe/unoexe.cxx
+++ b/cpputools/source/unoexe/unoexe.cxx
@@ -20,13 +20,9 @@
 #include stdio.h
 
 #include sal/main.h
-#include osl/diagnose.h
-#include osl/mutex.hxx
 #include osl/conditn.hxx
 
 #include rtl/process.h
-#include rtl/string.h
-#include rtl/strbuf.hxx
 #include rtl/ustrbuf.hxx
 
 #include cppuhelper/bootstrap.hxx
@@ -38,15 +34,10 @@
 #include com/sun/star/lang/XComponent.hpp
 #include com/sun/star/lang/XSingleComponentFactory.hpp
 #include com/sun/star/lang/XSingleServiceFactory.hpp
-#include com/sun/star/lang/XMultiServiceFactory.hpp
-#include com/sun/star/lang/XEventListener.hpp
 #include com/sun/star/container/XSet.hpp
 #include com/sun/star/loader/XImplementationLoader.hpp
-#include com/sun/star/registry/XRegistryKey.hpp
 #include com/sun/star/connection/XAcceptor.hpp
-#include com/sun/star/connection/XConnection.hpp
 #include com/sun/star/bridge/XBridgeFactory.hpp
-#include com/sun/star/bridge/XBridge.hpp
 
 using namespace std;
 using namespace osl;
diff --git a/fileaccess/source/FileAccess.cxx b/fileaccess/source/FileAccess.cxx
index 00327b4..665f61f 100644
--- a/fileaccess/source/FileAccess.cxx
+++ b/fileaccess/source/FileAccess.cxx
@@ -17,23 +17,17 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include osl/mutex.hxx
-#include osl/diagnose.h
 
-#include uno/mapping.hxx
 #include comphelper/processfactory.hxx
 #include cppuhelper/factory.hxx
-#include cppuhelper/implbase1.hxx
 
 #include tools/urlobj.hxx
 #include ucbhelper/content.hxx
 #include unotools/streamwrap.hxx
 #include tools/stream.hxx
 
-#include com/sun/star/beans/Property.hpp
 #include com/sun/star/container/XChild.hpp
 #include com/sun/star/io/XActiveDataSink.hpp
-#include com/sun/star/io/XActiveDataSource.hpp
 #include com/sun/star/io/XActiveDataStreamer.hpp
 #include com/sun/star/sdbc/XResultSet.hpp
 #include com/sun/star/ucb/CommandFailedException.hpp
@@ -42,16 +36,13 @@
 #include com/sun/star/ucb/InsertCommandArgument.hpp
 #include com/sun/star/ucb/InteractiveIOException.hpp
 #include com/sun/star/ucb/NameClash.hpp
-#include com/sun/star/ucb/NameClashException.hpp
 #include com/sun/star/ucb/OpenCommandArgument2.hpp
 #include com/sun/star/ucb/OpenMode.hpp
 #include com/sun/star/ucb/XCommandEnvironment.hpp
-#include com/sun/star/ucb/XContent.hpp
 #include com/sun/star/ucb/XContentAccess.hpp
 #include com/sun/star/ucb/XSimpleFileAccess3.hpp
 #include com/sun/star/util/theMacroExpander.hpp
 
-#include vector
 
 #define IMPLEMENTATION_NAME com.sun.star.comp.ucb.SimpleFileAccess
 #define SERVICE_NAME com.sun.star.ucb.SimpleFileAccess
diff --git a/sccomp/source/solver/solver.cxx b/sccomp/source/solver/solver.cxx
index c5b1c27..dcd18b0 100644
--- a/sccomp/source/solver/solver.cxx
+++ b/sccomp/source/solver/solver.cxx
@@ -26,7 +26,6 @@
  *
  /
 
-#include sal/config.h
 
 #undef LANGUAGE_NONE
 #if defined SAL_W32
@@ -44,20 +43,11 @@
 #include solver.hxx
 #include solver.hrc
 
-#include com/sun/star/beans/XPropertySet.hpp
-#include com/sun/star/container/XIndexAccess.hpp
 #include com/sun/star/frame/XModel.hpp
-#include com/sun/star/lang/XMultiServiceFactory.hpp
-#include com/sun/star/sheet/XSpreadsheetDocument.hpp
 #include com/sun/star/sheet/XSpreadsheet.hpp
-#include com/sun/star/table/CellAddress.hpp
-#include com/sun/star/table/CellRangeAddress.hpp
-#include com/sun/star/text/XTextRange.hpp
 
 #include rtl/math.hxx
-#include rtl/ustrbuf.hxx
 #include cppuhelper/factory.hxx
-#include vector
 #include boost/unordered_map.hpp
 
 #include tools/resmgr.hxx

-- 
To view, visit https://gerrit.libreoffice.org/3508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie02f99f42dbcbd613bb819da234e37dbfb3b0d89
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master

[PATCH] fdo#62096: Replaced some compareTo with ==

2013-04-20 Thread Sameer Deshmukh (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3509

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/09/3509/1

fdo#62096: Replaced some compareTo with ==

Change-Id: I1151dafcef91abdb2ce08abe3547a49fe3f4a67c
---
M sal/inc/rtl/string.hxx
M sal/qa/rtl_strings/rtl_OString.cxx
A wizards/com/sun/star/wizards/table/.#CallTableWizard.java
M writerfilter/source/ooxml/OOXMLStreamImpl.cxx
M xmlhelp/source/cxxhelp/provider/databases.hxx
M xmlhelp/source/cxxhelp/provider/db.hxx
6 files changed, 18 insertions(+), 17 deletions(-)



diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index e3d5afb..8151262 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -782,25 +782,25 @@
 template typename T 
 friend typename internal::CharPtrDetector T, bool ::Type operator==( 
const OString rStr1, const T value ) SAL_THROW(())
 {
-return rStr1.compareTo( value ) == 0;
+return (rStr1 == value);
 }
 
 template typename T 
 friend typename internal::NonConstCharArrayDetector T, bool ::Type 
operator==( const OString rStr1, T value ) SAL_THROW(())
 {
-return rStr1.compareTo( value ) == 0;
+return (rStr1 == value);
 }
 
 template typename T 
 friend typename internal::CharPtrDetector T, bool ::Type operator==( 
const T value, const OString rStr2 ) SAL_THROW(())
 {
-return rStr2.compareTo( value ) == 0;
+return (rStr2 == value);
 }
 
 template typename T 
 friend typename internal::NonConstCharArrayDetector T, bool ::Type 
operator==( T value, const OString rStr2 ) SAL_THROW(())
 {
-return rStr2.compareTo( value ) == 0;
+return (rStr2 == value);
 }
 
 /**
diff --git a/sal/qa/rtl_strings/rtl_OString.cxx 
b/sal/qa/rtl_strings/rtl_OString.cxx
index 1934f06..293381c 100644
--- a/sal/qa/rtl_strings/rtl_OString.cxx
+++ b/sal/qa/rtl_strings/rtl_OString.cxx
@@ -1929,7 +1929,7 @@
 bRes = c_rtl_tres_state
 (
 hRtlTestResult,
-aStr2.compareTo(aStr1) == 0,
+aStr2 == aStr1,
 (sal_Char*)resArray[i],
 createName( pMeth, valueOf, i )
 );
@@ -2163,7 +2163,7 @@
 bRes = c_rtl_tres_state
 (
 hRtlTestResult,
-aStr2.compareTo( aStr1 ) == 0,
+aStr2 ==  aStr1,
 if radix not valid then radix must be 10,
 valueOf(sal_Int32, sal_Int32 radix): radix = -5
 );
@@ -2411,7 +2411,7 @@
 bRes = c_rtl_tres_state
 (
 hRtlTestResult,
-aStr2.compareTo(aStr1) == 0,
+aStr2 == aStr1,
 if radix not valid then radix must be 10,
 valueOf(sal_Int64, sal_Int32 radix): radix = -5
 );
diff --git a/wizards/com/sun/star/wizards/table/.\043CallTableWizard.java 
b/wizards/com/sun/star/wizards/table/.\043CallTableWizard.java
new file mode 12
index 000..d41e7eb07
--- /dev/null
+++ b/wizards/com/sun/star/wizards/table/.\043CallTableWizard.java
@@ -0,0 +1 @@
+sameer@sameer-HP-630-NoteBook-PC.23744:1366461591
\ No newline at end of file
diff --git a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx 
b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
index 96f37bd..3305e7c 100644
--- a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
@@ -169,16 +169,16 @@
 {
 beans::StringPair aPair = aSeq[i];
 
-if (aPair.First.compareTo(sType) == 0 
-aPair.Second.compareTo(sStreamType) == 0)
+if (aPair.First == sType 
+aPair.Second == sStreamType)
 bFound = true;
-else if (aPair.First.compareTo(sId) == 0 
- aPair.Second.compareTo(rId) == 0)
+else if (aPair.First == sId 
+ aPair.Second == rId)
 bFound = true;
-else if (aPair.First.compareTo(sTarget) == 0)
+else if (aPair.First == sTarget)
 sMyTarget = aPair.Second;
-else if (aPair.First.compareTo(sTargetMode) == 0 
- aPair.Second.compareTo(sExternal) == 0)
+else if (aPair.First == sTargetMode 
+ aPair.Second == sExternal)
 bExternalTarget = true;
 
 }
diff --git a/xmlhelp/source/cxxhelp/provider/databases.hxx 
b/xmlhelp/source/cxxhelp/provider/databases.hxx
index 905c86c..8585700 100644
--- a/xmlhelp/source/cxxhelp/provider/databases.hxx
+++ b/xmlhelp/source/cxxhelp/provider/databases.hxx
@@ -156,7 +156,7 @@
 {
 bool operator()( const OUString rKey1, const OUString rKey2 ) 
const
 {
-return rKey1.compareTo(

[Libreoffice-commits] core.git: cui/source svx/inc svx/Package_inc.mk svx/source sw/inc sw/source

 cui/source/options/optinet2.cxx  |2 -
 cui/source/tabpages/backgrnd.cxx |2 -
 cui/source/tabpages/border.cxx   |2 -
 cui/source/tabpages/chardlg.cxx  |2 -
 cui/source/tabpages/numpages.cxx |2 -
 cui/source/tabpages/page.cxx |2 -
 cui/source/tabpages/paragrph.cxx |2 -
 cui/source/tabpages/swpossizetabpage.cxx |2 -
 svx/Package_inc.mk   |2 -
 svx/inc/svx/htmlmode.hxx |   44 ---
 svx/inc/svx/obj3d.hxx|2 -
 svx/inc/svx/volume3d.hxx |   27 ---
 svx/source/dialog/hdft.cxx   |2 -
 svx/source/dialog/svxbmpnumvalueset.cxx  |2 -
 svx/source/engine3d/viewpt3d2.cxx|2 -
 svx/source/tbxctrls/tbcontrl.cxx |2 -
 sw/inc/pch/precompiled_sw.hxx|2 -
 sw/source/filter/html/css1atr.cxx|2 -
 sw/source/filter/html/htmlatr.cxx|2 -
 sw/source/filter/html/wrthtml.cxx|2 -
 sw/source/ui/app/appopt.cxx  |2 -
 sw/source/ui/app/docsh.cxx   |2 -
 sw/source/ui/app/docst.cxx   |2 -
 sw/source/ui/chrdlg/chardlg.cxx  |2 -
 sw/source/ui/chrdlg/drpcps.cxx   |2 -
 sw/source/ui/chrdlg/numpara.cxx  |2 -
 sw/source/ui/chrdlg/pardlg.cxx   |2 -
 sw/source/ui/config/optload.cxx  |2 -
 sw/source/ui/config/optpage.cxx  |2 -
 sw/source/ui/config/viewopt.cxx  |2 -
 sw/source/ui/dbui/dbinsdlg.cxx   |2 -
 sw/source/ui/dialog/macassgn.cxx |2 -
 sw/source/ui/dialog/regionsw.cxx |2 -
 sw/source/ui/dialog/uiregionsw.cxx   |2 -
 sw/source/ui/docvw/edtwin.cxx|2 -
 sw/source/ui/fldui/fldpage.cxx   |2 -
 sw/source/ui/fldui/fldtdlg.cxx   |2 -
 sw/source/ui/fldui/fldwrap.cxx   |2 -
 sw/source/ui/fmtui/tmpdlg.cxx|2 -
 sw/source/ui/frmdlg/column.cxx   |2 -
 sw/source/ui/frmdlg/frmdlg.cxx   |2 -
 sw/source/ui/frmdlg/frmpage.cxx  |2 -
 sw/source/ui/frmdlg/wrap.cxx |2 -
 sw/source/ui/ribbar/concustomshape.cxx   |2 -
 sw/source/ui/ribbar/conrect.cxx  |2 -
 sw/source/ui/ribbar/tbxanchr.cxx |2 -
 sw/source/ui/ribbar/workctrl.cxx |2 -
 sw/source/ui/shells/annotsh.cxx  |2 -
 sw/source/ui/shells/basesh.cxx   |2 -
 sw/source/ui/shells/drformsh.cxx |2 -
 sw/source/ui/shells/drwbassh.cxx |2 -
 sw/source/ui/shells/drwtxtex.cxx |2 -
 sw/source/ui/shells/grfsh.cxx|2 -
 sw/source/ui/shells/grfshex.cxx  |2 -
 sw/source/ui/shells/mediash.cxx  |2 -
 sw/source/ui/shells/textsh.cxx   |2 -
 sw/source/ui/shells/textsh1.cxx  |2 -
 sw/source/ui/shells/txtattr.cxx  |2 -
 sw/source/ui/table/convert.cxx   |2 -
 sw/source/ui/table/instable.cxx  |2 -
 sw/source/ui/table/swtablerep.cxx|2 -
 sw/source/ui/table/tabledlg.cxx  |2 -
 sw/source/ui/uiview/view2.cxx|2 -
 sw/source/ui/uiview/viewstat.cxx |2 -
 sw/source/ui/wrtsh/wrtsh3.cxx|2 -
 65 files changed, 62 insertions(+), 135 deletions(-)

New commits:
commit 13dcaae519920b0f8a3ad11308117a8f19144580
Author: Michael Dunphy michael.w.dun...@gmail.com
Date:   Fri Apr 19 18:21:26 2013 -0400

fdo#62699 Remove pass-through headers

Change-Id: I84a88238f6cdc485530ffb76f9444179a22abb92
Reviewed-on: https://gerrit.libreoffice.org/3491
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 4769db0..3039d21 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -51,7 +51,7 @@
 #include optinet2.hrc
 #include helpid.hrc
 #include svx/ofaitem.hxx
-#include svx/htmlmode.hxx
+#include sfx2/htmlmode.hxx
 #include svx/svxids.hrc // slot ids, mostly for changetracking
 
 // for security TP
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index 8f134be..3cc1f45 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -46,7 +46,7 @@
 #include svx/svxerr.hxx
 #include svx/drawitem.hxx
 #include dialmgr.hxx
-#include svx/htmlmode.hxx
+#include sfx2/htmlmode.hxx
 #include svtools/controldims.hrc
 #include svx/flagsdef.hxx
 #include svx/xfillit0.hxx
diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx
index 0772e5d..26f3a0c 100644
--- a/cui/source/tabpages/border.cxx
+++ b/cui/source/tabpages/border.cxx
@@ -34,7 +34,7 @@
 #include border.hxx
 #include svx/dlgutil.hxx
 #include dialmgr.hxx

[PUSHED] fdo#62699 Remove pass-through headers

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3491

Approvals:
  LibreOffice gerrit bot: Verified
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3491
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84a88238f6cdc485530ffb76f9444179a22abb92
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: touch/Package_inc.mk

2013-04-20 Thread Tor Lillqvist

 touch/Package_inc.mk |1 -
 1 file changed, 1 deletion(-)

New commits:
commit ec2b98f4bcbe3b8a47b3b2b7127ac608d83ac6ec
Author: Tor Lillqvist t...@iki.fi
Date:   Sat Apr 20 16:33:21 2013 +0300

Don't bother with for now unused libotouch.hxx

Change-Id: I9e5396b52be2cbd0a95ef4dd08d1766a8f6d6ac6

diff --git a/touch/Package_inc.mk b/touch/Package_inc.mk
index d55ab5d..f1c81a0 100644
--- a/touch/Package_inc.mk
+++ b/touch/Package_inc.mk
@@ -9,6 +9,5 @@
 $(eval $(call gb_Package_Package,touch_inc,$(SRCDIR)/touch/inc))
 
 $(eval $(call gb_Package_add_file,touch_inc,inc/touch/touch.h,touch/touch.h))
-$(eval $(call 
gb_Package_add_file,touch_inc,inc/touch/libotouch.hxx,touch/libotouch.hxx))
 
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[PATCH] Remove unused headers from modules remotebridges, udm and an...

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3510

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/10/3510/1

Remove unused headers from modules remotebridges, udm and animations

Change-Id: I6d2fb5e88e66a1e45977c5e4a7530f28ec844720
---
M animations/source/animcore/animcore.cxx
M animations/source/animcore/factreg.cxx
M animations/source/animcore/targetpropertiescreator.cxx
M remotebridges/source/unourl_resolver/unourl_resolver.cxx
M udm/source/xml/xmlitem.cxx
5 files changed, 0 insertions(+), 26 deletions(-)



diff --git a/animations/source/animcore/animcore.cxx 
b/animations/source/animcore/animcore.cxx
index a503097..966f17a 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -18,15 +18,12 @@
  */
 
 #include com/sun/star/util/XCloneable.hpp
-#include com/sun/star/uno/XComponentContext.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
-#include com/sun/star/lang/XTypeProvider.hpp
 #include com/sun/star/animations/XAnimateColor.hpp
 #include com/sun/star/animations/XAnimateSet.hpp
 #include com/sun/star/animations/XAnimateMotion.hpp
 #include com/sun/star/animations/XAnimateTransform.hpp
 #include com/sun/star/animations/XTransitionFilter.hpp
-#include com/sun/star/animations/XTimeContainer.hpp
 #include com/sun/star/animations/XIterateContainer.hpp
 #include com/sun/star/animations/XAudio.hpp
 #include com/sun/star/animations/XCommand.hpp
@@ -41,17 +38,13 @@
 #include com/sun/star/animations/TransitionSubType.hpp
 #include com/sun/star/presentation/ShapeAnimationSubType.hpp
 #include com/sun/star/container/XEnumerationAccess.hpp
-#include com/sun/star/beans/NamedValue.hpp
 #include com/sun/star/util/XChangesNotifier.hpp
 #include com/sun/star/lang/XUnoTunnel.hpp
 #include comphelper/servicehelper.hxx
 #include cppuhelper/interfacecontainer.hxx
-#include cppuhelper/weakref.hxx
 
 #include cppuhelper/implbase1.hxx
-#include rtl/uuid.h
 
-#include osl/mutex.hxx
 #include list
 #include algorithm
 #include string.h
diff --git a/animations/source/animcore/factreg.cxx 
b/animations/source/animcore/factreg.cxx
index 4f5b078..c02f21d 100644
--- a/animations/source/animcore/factreg.cxx
+++ b/animations/source/animcore/factreg.cxx
@@ -17,11 +17,8 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include osl/diagnose.h
-#include cppuhelper/factory.hxx
 #include cppuhelper/implementationentry.hxx
 
-#include com/sun/star/registry/XRegistryKey.hpp
 
 using namespace ::rtl;
 using namespace ::cppu;
diff --git a/animations/source/animcore/targetpropertiescreator.cxx 
b/animations/source/animcore/targetpropertiescreator.cxx
index 9e9fd27..2dce17a 100644
--- a/animations/source/animcore/targetpropertiescreator.cxx
+++ b/animations/source/animcore/targetpropertiescreator.cxx
@@ -19,27 +19,18 @@
 
 #include com/sun/star/uno/XComponentContext.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
-#include com/sun/star/lang/XTypeProvider.hpp
 #include com/sun/star/animations/XTargetPropertiesCreator.hpp
 #include com/sun/star/animations/XIterateContainer.hpp
-#include com/sun/star/animations/TargetProperties.hpp
 #include com/sun/star/presentation/ParagraphTarget.hpp
-#include com/sun/star/registry/XRegistryKey.hpp
-#include com/sun/star/lang/XInitialization.hpp
 #include com/sun/star/lang/XServiceName.hpp
-#include com/sun/star/lang/XSingleServiceFactory.hpp
-#include com/sun/star/drawing/XShape.hpp
 #include com/sun/star/animations/AnimationNodeType.hpp
 #include com/sun/star/animations/XAnimate.hpp
 #include cppuhelper/compbase3.hxx
-#include cppuhelper/factory.hxx
-#include cppuhelper/implementationentry.hxx
 #include comphelper/broadcasthelper.hxx
 #include comphelper/sequence.hxx
 
 #include animations/animationnodehelper.hxx
 
-#include vector
 #include boost/unordered_map.hpp
 
 
diff --git a/remotebridges/source/unourl_resolver/unourl_resolver.cxx 
b/remotebridges/source/unourl_resolver/unourl_resolver.cxx
index 87421f0..55ec2e1 100644
--- a/remotebridges/source/unourl_resolver/unourl_resolver.cxx
+++ b/remotebridges/source/unourl_resolver/unourl_resolver.cxx
@@ -17,20 +17,14 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include osl/diagnose.h
-#include osl/mutex.hxx
-#include cppuhelper/factory.hxx
 #include cppuhelper/implbase2.hxx
 #include cppuhelper/implementationentry.hxx
 #include cppuhelper/unourl.hxx
 #include rtl/malformeduriexception.hxx
 
 #include com/sun/star/lang/XServiceInfo.hpp
-#include com/sun/star/lang/XComponent.hpp
-#include com/sun/star/registry/XRegistryKey.hpp
 #include com/sun/star/connection/XConnector.hpp
 #include com/sun/star/bridge/BridgeFactory.hpp
-#include com/sun/star/bridge/XBridgeFactory.hpp
 #include com/sun/star/bridge/XUnoUrlResolver.hpp
 
 using namespace cppu;
diff --git a/udm/source/xml/xmlitem.cxx b/udm/source/xml/xmlitem.cxx
index 2725d3d..dd6cb8c 100644
--- a/udm/source/xml/xmlitem.cxx
+++

Re: Trouble creating logerrit account

2013-04-20 Thread Wols Lists

On 18/04/13 17:47, Norbert Thiebaud wrote:
 either way you did not indicate a username at all to gerrt (last time I 
 checked)

Spot on :-)

I've just put in my user name, and the test says it's successful. Great :-)

What I *think* happened is I filled in the details and just carried on,
with the result that gerrit remembered most of my details. But it seems
to need an explicit save on the user name to remember that, which I
didn't spot, so it didn't remember that ...

(this is just what I think happened, I could be wrong ... :-)

Cheers,
Wol
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Python extension not working on Mac (LibreOffice 4.0.2.2)

2013-04-20 Thread Carles Pina i Estany


On Apr/20/2013, Norbert Thiebaud wrote:
 On Fri, Apr 19, 2013 at 7:37 PM, Carles Pina i Estany car...@pina.cat wrote:
 
  Oh I see. I've just seen Stephan Bergmann other message in the mailing
  list. If you have a link to the git commit feel free to send - just out
  of curiosity.
 
 That was not a code issue, but a build environment issue.
 so there is no commit associated, just a rebuild of the release package.

I thought that maybe the build environment is built or deployed using
Puppet or similar with the config in a git repo. No problem at all :-)
I'll test on Monday.

-- 
Carles Pina i Estany
Web: http://pinux.info || Blog: http://pintant.cat
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[GSoC] Enhanced database ranges, some clarification needed.

2013-04-20 Thread Akash Shetye

Hello Kohei,

Since you are the mentor for the enhanced database ranges task, I am
writing to you some questions and outlines I wanted to discuss. (keeping
them as brief as possible)

*Alternate row coloring in database ranges:*

   - Currently if I want to do that I'll need to highlight the range and go
   to Format-Conditional Formatting-Condition and then use a formula
   =MOD(ROW()-1,1*2)+11 which will color alternate rows.
   - Many such twisted formulas exist for various styles we see in the
   Format as Table option in MS Excel. The user selects a style through a
   dialog to select First row stripe, Xth row stripe etc. see
this.http://www.techonthenet.com/excel/questions/cond_format6_2010.phpMany
styles could be brought together as well by simply ORing the
   corresponding formulas of these selections.
   - Since formulas for each of these styles are available, we can redirect
   the user to the Format-Conditional Formatting-Condition dialog, with the
   formula field filled with the corresponding formula and the field being set
   un-editable.
   - The user can now select whatever style or formatting he wants to apply
   to the condition.
   - Tell me what do you think about this approach.

*New reference syntax in formula expressions:*

   - I an guessing field names means the same thing as column labels in
   MicroSoft lingo which is the Text in the first row of the column? I haven't
   yet went ahead and explored this, will do that soon.

On a different note, I wanted to know if the bug I have fixed
#51296https://bugs.freedesktop.org/show_bug.cgi?id=51296qualifies as
an easy hack, that I have cleared the prerequisite of fixing a
bug off the easy hacks page. Also do tell me the timings you usually hang
out at the IRC. Again thanks for all the help with my first bug on LO and
hope to hear from you.


Akash. Shetye.

(she1991)
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#60949: Move more libs to OOOLIBS

2013-04-20 Thread Marcos Souza (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3511

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/3511/1

fdo#60949: Move more libs to OOOLIBS

Change-Id: Ibd45f7004f8eaa151b9a60d7369d396411f60a2b
---
M Repository.mk
M scp2/source/gnome/file_gnome.scp
M scp2/source/impress/file_impress.scp
M scp2/source/kde/file_kde.scp
M scp2/source/python/file_python.scp
M scp2/source/tde/file_tde.scp
6 files changed, 16 insertions(+), 64 deletions(-)



diff --git a/Repository.mk b/Repository.mk
index 314ca61d..0afc24b 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -559,20 +559,28 @@
 ))
 
 $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
+PresenterScreen \
 basprov \
 cairocanvas \
 dlgprov \
 expwrap \
 fastsax \
+gconfbe1 \
 i18nsearch \
+kdebe1 \
+kde4be1 \
 ldapbe2 \
 migrationoo2 \
 migrationoo3 \
 msforms \
 mtfrenderer \
 OGLTrans \
+pythonloader \
 slideshow \
 stringresource \
+tdebe1 \
+ucpgio1 \
+ucpgvfs1 \
 vbaevents \
 vbaobj \
 vbaswobj \
@@ -587,33 +595,25 @@
ucpexpand1 \
 ))
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
-PresenterScreen \
 canvasfactory \
 cmdmail \
 directx5canvas \
 directx9canvas \
 fpicker \
 fps_office \
-gconfbe1 \
 gdipluscanvas \
 hatchwindowfactory \
-kdebe1 \
-kde4be1 \
 losessioninstall \
 macbe1 \
 nullcanvas \
 passwordcontainer \
 pdfimport \
-pythonloader \
 postgresql-sdbc \
 postgresql-sdbc-impl \
 simplecanvas \
 syssh \
-tdebe1 \
 ucpcmis1 \
 ucpext \
-ucpgio1 \
-ucpgvfs1 \
 ucptdoc1 \
 updatefeed \
 vclcanvas \
diff --git a/scp2/source/gnome/file_gnome.scp b/scp2/source/gnome/file_gnome.scp
index 9672965..cf9a498 100644
--- a/scp2/source/gnome/file_gnome.scp
+++ b/scp2/source/gnome/file_gnome.scp
@@ -27,23 +27,13 @@
 #include macros.inc
 
 #ifdef ENABLE_GIO
-File gid_File_Lib_GIO
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(ucpgio1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_GIO, ucpgio1 )
 
 SPECIAL_COMPONENT_LIB_FILE(gid_File_Lib_Losessioninstall, losessioninstall.uno)
 #endif
 
 #ifdef ENABLE_GNOMEVFS
-File gid_File_Lib_Gnomevfs
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(ucpgvfs1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Gnomevfs, ucpgvfs1 )
 #endif
 
 #if (defined ENABLE_GCONF  defined ENABLE_LOCKDOWN) || defined ENABLE_GIO
@@ -56,12 +46,7 @@
 #endif
 
 #ifdef ENABLE_GCONF
-File gid_File_Lib_Gconfbe
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(gconfbe1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Gconfbe, gconfbe1 )
 #endif
 
 #ifdef ENABLE_SYSTRAY_GTK
diff --git a/scp2/source/impress/file_impress.scp 
b/scp2/source/impress/file_impress.scp
index f2eebf0..7753335 100644
--- a/scp2/source/impress/file_impress.scp
+++ b/scp2/source/impress/file_impress.scp
@@ -37,16 +37,7 @@
PACKED_LIB_FILE_BODY;
 End
 
-File gid_File_Lib_PresenterScreen
-LIB_FILE_BODY;
-Dir = SCP2_OOO_BIN_DIR;
-#if defined UNX
-Name = STRING(CONCAT2(PresenterScreen.uno,UNXSUFFIX));
-#else
-Name = PresenterScreen.uno.dll;
-#endif
-Styles = (PACKED);
-End
+STD_LIB_FILE( gid_File_Lib_PresenterScreen, PresenterScreen )
 
 File gid_File_Share_Registry_Impress_Xcd
 TXT_FILE_BODY;
diff --git a/scp2/source/kde/file_kde.scp b/scp2/source/kde/file_kde.scp
index 1614f69..2f0320a 100644
--- a/scp2/source/kde/file_kde.scp
+++ b/scp2/source/kde/file_kde.scp
@@ -27,19 +27,9 @@
 #include macros.inc
 
 #ifdef ENABLE_KDE
-File gid_File_Lib_Kdebe
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(kdebe1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Kdebe, kdebe1 )
 #endif
 
 #ifdef ENABLE_KDE4
-File gid_File_Lib_Kde4be
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(kde4be1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Kde4be, kde4be1 )
 #endif
diff --git a/scp2/source/python/file_python.scp 
b/scp2/source/python/file_python.scp
index 614c732..c502986 100644
--- a/scp2/source/python/file_python.scp
+++ b/scp2/source/python/file_python.scp
@@ -54,16 +54,7 @@
 Styles = (PACKED);
 End
 
-File gid_File_Lib_Pythonloader
-LIB_FILE_BODY;
-Dir = gid_Brand_Dir_Program;
-  #ifdef UNX
-Name = STRING(CONCAT2(pythonloader.uno,UNXSUFFIX));
-  #else
-Name = pythonloader.uno.dll;
-  #endif
-Styles = (PACKED);
-End
+STD_LIB_FILE( gid_File_Lib_Pythonloader, pythonloader )
 
 File gid_File_Py_Unohelper
 TXT_FILE_BODY;
diff --git a/scp2/source/tde/file_tde.scp b/scp2/source/tde/file_tde.scp
index 0a767d7..945b0de 100644
--- a/scp2/source/tde/file_tde.scp
+++

Re: Value of a ListBox, FMC paradigm for Form elements (controls)

2013-04-20 Thread Lionel Elie Mamane

On Thu, Apr 18, 2013 at 08:12:43AM +0200, Lionel Elie Mamane wrote:

Context: (Data)Forms and their elements (controls).

PROBLEM 2: Frame-Controller-Model paradigm as applied to Form elements
==

Frame elements seem to have a b0rken implementation of the
Frame-Controller-Model paradigm.

I now understand the system, more or less. Actually, they implement a
*different* paradigm, the Model / View paradigm, described at
http://wiki.openoffice.org/wiki/Documentation/DevGuide/Forms/Models_and_Views_for_Form_Controls

But the code (and some of the documentation) confusingly calls the
View only Control.

It has a getModel() that returns a frm::OListBoxModel. That in itself
makes sense, *but*:

1) frm::OListBoxModel has no method/API to get back the corresponding
frm::OListBoxControl

The model does not know its views, *but* the upper level document (the
SwXTextView) has an API that takes a model and returns the
corresponding view (control); see
http://wiki.openoffice.org/wiki/Documentation/DevGuide/Forms/Form_Layer_Views#Locating_Controls

So, well, it is workable after all. The link was not where I was
looking for it (in an interface of the model), but there is a path. So
let's say nothing to fix there.

The funny thing is that the same property in the view and in the
model has different values (index within the list vs display value),
but that sort of makes sense...

When I bind a macro to an event of a ListBox, Event.Source is a
frm::OListBoxControl (see forms/source/component/ListBox.hxx).

Actually, it depends what event. The pattern seems that data-related
events have the Model as source, and interaction-related events have
the view (control) as source. Which makes sense.

PROBLEM 1: value of a ListBox
=

Currently, the CurrentValue pseudo-property (getCurrentValue()
method) of a ListBox returns the current *display* value, not the
*storage* value. To me, this is a bug or (serious) misdesign.

I have a patch ready to change it, but... incompatible behaviour
change... Basically, my question to you is: what should I do? Just
change it, or introduce a new getCurrentBoundValue() to disambiguate,
and leave getCurrentValue() alone?

More generally, the *storage* values are *not* exposed at all by the
UNO API. IMO this needs to change.

I was wrong... The property ValueItemList contains the storage
values... but in some cases (which cover my test cases...) it was not
populated (which explains why I did not find it...). I'm fixing that
bug.

Which makes it even *more* weird that getCurrentValue is not an item
of ValueItemList, but of StringItemList (the property that contains
the display values).

So, we discussed the just correct it or leave getCurrentValue alone
question during the ESC call. Some more data, some more issues and
what I plan to do.

I've now read
http://wiki.openoffice.org/wiki/Documentation/DevGuide/Forms/Validation

getCurrentValue is part of interface
com.sun.star.form.validation.XValidatableFormComponent
(that is, it was introduced for the use of validators, callback
procedures that say accept this input from the user or reject
it).

It is described as retrieves the current value of the component and
Again, this is a convenience method. I understand convenience
method as:
It is equivalent to retrieving the 'content property' of the
control.
This is exemplified by this text in the documentation:

For example, for a ::com::sun::star::form::component::FormattedField,
calling this method is equivalent to retrieving the
::com::sun::star::awt::UnoControlFormattedFieldModel::EffectiveValue.

(http://wiki.openoffice.org/wiki/Documentation/DevGuide/Forms/Control_Models_as_Bound_Components
introduces the notion of content property.)

For a ListBox, the 'content property', which the code calls Value
Property (!) is currently SelectedItems, which is the array of
*indexes* of the selected items in the list, and not the values in the
bound column.

Up to now, it is coherent. Where it is not coherent anymore, is that
the *same* content property is supposed to be the one that is written
to the database:

A data-aware control model bound to a data column uses its content
property to exchange data with this column. As soon as the column
value changes, the model forwards the new value to its content
property, and notifies its listeners. One of these listeners is the
control that updates its display

So, the natural idea would be to change the content property to one
that contains the *storage* values corresponding to what is currently
selected in the list. On the one hand, this would make everything
coherent and improve our similarity to / compatibility with Microsoft
Office, *but*:

On the other hand, it introduces a difference with all other controls,
and implementation-wise it is much easier / faster to have the value
or content of the ListBox (as in the property that code can

install-gdb-printers exec perms ?

2013-04-20 Thread Michael Meeks

Hi there,

I just built master from clean and got a non-executable
solenv/bin/install-gdb-printers which apparently caused a build failure.

Too late to fix it for me just now - hope it helps; chmod +x might fix
it I hope ;-)

HTH,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Patch for postgresql driver

2013-04-20 Thread Lionel Elie Mamane

On Sat, Apr 20, 2013 at 12:50:05PM +0100, Wols Lists wrote:

Okay, I'll sort out that patch and re-apply it for you. You should have
a licence email on record - sent to the list 2012-05-18 Wol's grant of
licence.

It seems we had two entries for you in the developer's list. I merged
the two. The second (which I had not seen) contains the link to your
license statement indeed.

See
https://wiki.documentfoundation.org/index.php?title=Development%2FDevelopersdiff=67562oldid=67548

On 19/04/13 17:26, Lionel Elie Mamane wrote:
On Wed, Apr 17, 2013 at 09:39:59PM +0100, Wols Lists wrote:
I've now got the patch done.

Could someone with a postgresql implementation please test and push?

Thank you for your patch. From looking at it, it looks good to go to
me, but technically I wasn't able to apply it and we have some
administrivia to go through. Sorry for the administrivia, but we'll
need it only once.

I don't see a link to a license statement in
https://wiki.documentfoundation.org/Development/Developers
Could you please confirm that this patch (and, to make things easier,
all your future contributions to LibreOffice) are licensed by you
under the MPLv2/LGPLv3+ dual license? Thank you in advance.

When I try to apply it with patch -p1, it says:

patching file connectivity/source/drivers/postgresql/pq_connection.cxx
patch: malformed patch at line 71: @@ -527,6 +515,11 @@ static void
properties2arrays( const Sequence PropertyValue args,

When I try to apply it with git am it says:

Patch format detection failed.

git apply says:

fatal: corrupt patch at line 71

It looks to me like you created the patch with git format-patch and
then modified the resulting file (or email template), and somehow the
patch got corrupted in the process.

In general, the best is to either:

1) Use gerrit

2) Generate the patch with git format-patch and then attach the
*whole* file to your mail (not just the patch as you did).

Both of these methods allow to use git natively to apply the patch,
and (assuming your git is setup properly) to automatically get your
suggested commit message and the information of authorship recorded
into git. For example, now I don't know whether the git authorship
email should be wolslists at youngmanorg.uk (like the wiki Developers
page says), antlists at youngman.org.uk (the address that sent this
mail) or the more personal address you used to correspond with me by
email in the past. Please advise. I'm also not sure whether you'd like
the authorship name to be Anthony W. Youngman or Anthony Youngman.

Could you please regenerate the patch so that I can apply and test?
Thank you in advance.

Since you have to regenerate the patch anyway, a rather minor nitpick:
I'd prefer C++-style cast rather then C-style cast:
static_castint (SAL_N_ELEMENTS( keyword_list ))
rather than
(int) SAL_N_ELEMENTS( keyword_list )

An even better solution would be to make the j variable of type
size_t instead of int (that is, the same type as SAL_N_ELEMENTS(
keyword_list ).

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - solenv/gbuild sw/Module_sw.mk sw/PythonTest_sw_unoapi.mk

2013-04-20 Thread Michael Stahl

 solenv/gbuild/PythonTest.mk |   39 +++-
 solenv/gbuild/platform/com_MSC_class.mk |1 
 solenv/gbuild/platform/macosx.mk|3 ++
 solenv/gbuild/platform/solaris.mk   |3 ++
 solenv/gbuild/platform/unxgcc.mk|5 +++-
 sw/Module_sw.mk |2 +
 sw/PythonTest_sw_unoapi.mk  |6 ++--
 7 files changed, 40 insertions(+), 19 deletions(-)

New commits:
commit 80885bf2c371d697c2719cc53975771ff36524de
Author: Michael Stahl mst...@redhat.com
Date:   Sat Apr 20 20:51:11 2013 +0200

gbuild: PythonTest: automatic GDB backtrace on failures

This requires changing the interface a bit to pass the directory
containing the test modules separately, because strangely the unittest
thingy cannot load the test modules by their absolute path when changing
the current working dir to where the core dump should happen.
So put the directory onto the PYTHONPATH to work around that;
arguably it's even nicer for clients this way.

Change-Id: I0d1d39f33d0c086c6c3014d2f9ba93f0a3dc0128

diff --git a/solenv/gbuild/PythonTest.mk b/solenv/gbuild/PythonTest.mk
index 141dc2d..d6570f3 100644
--- a/solenv/gbuild/PythonTest.mk
+++ b/solenv/gbuild/PythonTest.mk
@@ -26,12 +26,17 @@ $(call gb_PythonTest_get_clean_target,%) :
 
 ifneq ($(DISABLE_PYTHON),TRUE)
 
+# pass a hard-coded 139 to the gdb postprocess script to match soffice.bin
+# signal exit values (assumption: non-0 exit value here means it crashed)
 .PHONY : $(call gb_PythonTest_get_target,%)
 $(call gb_PythonTest_get_target,%) :
$(call gb_Output_announce,$*,$(true),PYT,2)
$(call gb_Helper_abbreviate_dirs,\
mkdir -p $(dir $(call gb_PythonTest_get_target,$*))  \
-   
(PYTHONPATH=$(SRCDIR)/unotest/source/python:$(DEVINSTALLDIR)/opt/program \
+   $(if $(gb_CppunitTest__interactive),, \
+   $(if $(value gb_CppunitTest_postprocess), \
+   rm -fr $@.core  mkdir $@.core  cd $@.core 
)) \
+   (PYTHONPATH=$(PYPATH):$(DEVINSTALLDIR)/opt/program \
UserInstallation=$(call 
gb_Helper_make_url,$(OUTDIR)/unittest) \
BRAND_BASE_DIR=$(call 
gb_Helper_make_url,$(OUTDIR)/unittest/install) \
CONFIGURATION_LAYERS=$(strip $(CONFIGURATION_LAYERS)) \
@@ -40,18 +45,18 @@ $(call gb_PythonTest_get_target,%) :
$(foreach dir,URE_INTERNAL_LIB_DIR LO_LIB_DIR,\
$(dir)=$(call 
gb_Helper_make_url,$(gb_CppunitTest_LIBDIR))) \
$(gb_CppunitTest_GDBTRACE) $(gb_CppunitTest_VALGRINDTOOL) 
$(gb_PythonTest_COMMAND) \
-   $(CLASSES) \
+   $(MODULES) \
$(if $(gb_CppunitTest__interactive),, \
 $@.log 21 \
|| (cat $@.log  $(UNIT_FAILED_MSG) \
$(if $(value gb_CppunitTest_postprocess), \
-$(call 
gb_CppunitTest_postprocess,$(gb_PythonTest_EXECUTABLE_GDB),$@.core)) \
+$(call 
gb_CppunitTest_postprocess,$(gb_PythonTest_EXECUTABLE_GDB),$@.core,139)) \
 false
 
 # always use udkapi and URE services
 define gb_PythonTest_PythonTest
-$(call gb_PythonTest_get_target,$(1)) : T_CP :=
-$(call gb_PythonTest_get_target,$(1)) : CLASSES :=
+$(call gb_PythonTest_get_target,$(1)) : PYPATH := 
$(SRCDIR)/unotest/source/python
+$(call gb_PythonTest_get_target,$(1)) : MODULES :=
 $(call gb_PythonTest_get_target,$(1)) : CONFIGURATION_LAYERS :=
 $(call gb_PythonTest_get_target,$(1)) : UNO_TYPES :=
 $(call gb_PythonTest_get_target,$(1)) : UNO_SERVICES :=
@@ -107,13 +112,15 @@ $(foreach component,$(call 
gb_CppunitTest__filter_not_built_components,$(2)),$(c
 
 endef
 
-define gb_PythonTest_add_classes
-$(call gb_PythonTest_get_target,$(1)) : CLASSES += $(2)
-
-endef
-
-define gb_PythonTest_add_class
-$(call gb_PythonTest_add_classes,$(1),$(2))
+# put the directory on the PYTHONPATH because the unittest loader
+# mysteriously fails to load modules given as absolute path unless the $PWD is
+# a prefix of the absolute path, which it is not when we go into a certain
+# dir to get a core dump there
+#
+# gb_PythonTest_add_modules directory module(s)
+define gb_PythonTest_add_modules
+$(call gb_PythonTest_get_target,$(1)) : PYPATH := $$(PYPATH):$(2)
+$(call gb_PythonTest_get_target,$(1)) : MODULES += $(3)
 
 endef
 
diff --git a/sw/PythonTest_sw_unoapi.mk b/sw/PythonTest_sw_unoapi.mk
index 20c6549..a78f1c5 100644
--- a/sw/PythonTest_sw_unoapi.mk
+++ b/sw/PythonTest_sw_unoapi.mk
@@ -48,9 +48,9 @@ $(eval $(call gb_PythonTest_use_components,sw_unoapi,\
 unoxml/source/service/unoxml \
 ))
 
-$(eval $(call gb_PythonTest_add_classes,sw_unoapi,\
-$(SRCDIR)/sw/qa/python/set_expression.py \
-$(SRCDIR)/sw/qa/python/get_expression.py \
+$(eval $(call

[PATCH] fdo#39468 Comment translation GER-ENG in sw/source/ui/shells...

2013-04-20 Thread Matthias Freund (via Code Review)

Hi,

I have submitted a patch for review:

https://gerrit.libreoffice.org/3512

To pull it, you can do:

git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/3512/1

fdo#39468 Comment translation GER-ENG in sw/source/ui/shells/ (Part 1)

basesh.cxx line 112: Needs to be revised
As german native speaker I don't know what the sentence means.
It looks like an automatic translation into german.
Unfortunely I don't know what the code really do.
I need a hint to translate this line.

Thank you.

Change-Id: I98af528c011a7d63b07b3aa71271d6816c11f7ab
---
M sw/source/ui/shells/annotsh.cxx
M sw/source/ui/shells/basesh.cxx
2 files changed, 103 insertions(+), 117 deletions(-)



diff --git a/sw/source/ui/shells/annotsh.cxx b/sw/source/ui/shells/annotsh.cxx
index 8dd405e..dde82ba 100644
--- a/sw/source/ui/shells/annotsh.cxx
+++ b/sw/source/ui/shells/annotsh.cxx
@@ -311,7 +311,7 @@
 
 if (pFieldItem  pFieldItem-GetField()-ISA(SvxURLField))
 {
-// Feld selektieren, so dass es beim Insert geloescht wird
+// Select the field so that it will be deleted during 
insert
 ESelection aSel = pOLV-GetSelection();
 aSel.nEndPos++;
 pOLV-SetSelection(aSel);
@@ -425,7 +425,7 @@
 */
 SfxItemSet aDlgAttr(GetPool(), EE_ITEMS_START, EE_ITEMS_END);
 
-// util::Language gibts an der EditEngine nicht! Daher nicht 
im Set.
+// util::Language does not exist in the EditEngine! Therefore 
not included in the set.
 
 aDlgAttr.Put( aEditAttr );
 aDlgAttr.Put( SvxKerningItem(0, RES_CHRATR_KERNING) );
@@ -1580,7 +1580,7 @@
 else
 aAllSet.Put( SfxStringItem( SID_FONT_NAME, 
aSetDlgFont.GetFamilyName() ) );
 
-// Wenn Zeichen selektiert ist kann es angezeigt werden
+// If character is selected then it can be shown.
 SfxAbstractDialog* pDlg = pFact-CreateSfxDialog( rView.GetWindow(), 
aAllSet,
 rView.GetViewFrame()-GetFrame().GetFrameInterface(), 
RID_SVXDLG_CHARMAP );
 
@@ -1610,7 +1610,7 @@
 
 if( sSym.Len() )
 {
-// nicht flackern
+// do not flicker
 pOLV-HideCursor();
 Outliner * pOutliner = pOLV-GetOutliner();
 pOutliner-SetUpdateMode(sal_False);
@@ -1623,10 +1623,10 @@
 0 );
 aFontSet.Set( aOldSet );
 
-// String einfuegen
+// Insert string
 pOLV-InsertText( sSym);
 
-// attributieren (Font setzen)
+// Attributing (set font)
 SfxItemSet aSetFont( *aFontSet.GetPool(), aFontSet.GetRanges() );
 SvxFontItem aFontItem (aFont.GetFamily(),aFont.GetName(),
 aFont.GetStyleName(), aFont.GetPitch(),
@@ -1641,16 +1641,16 @@
 aSetFont.Put( aFontItem, EE_CHAR_FONTINFO_CTL );
 pOLV-SetAttribs(aSetFont);
 
-// Selektion loeschen
+// Erase selection
 ESelection aSel(pOLV-GetSelection());
 aSel.nStartPara = aSel.nEndPara;
 aSel.nStartPos = aSel.nEndPos;
 pOLV-SetSelection(aSel);
 
-// Alten Font restaurieren
+// Restore old font
 pOLV-SetAttribs( aFontSet );
 
-// ab jetzt wieder anzeigen
+// From now on show it again
 pOutliner-SetUpdateMode(sal_True);
 pOLV-ShowCursor();
 
diff --git a/sw/source/ui/shells/basesh.cxx b/sw/source/ui/shells/basesh.cxx
index 2f200e0..328996c 100644
--- a/sw/source/ui/shells/basesh.cxx
+++ b/sw/source/ui/shells/basesh.cxx
@@ -109,8 +109,14 @@
 
 FlyMode SwBaseShell::eFrameMode = FLY_DRAG_END;
 
-//Fuer die Erkennung der Id, die variable von Gallery mit SID_GALLERY_BG_BRUSH
-//ankommt.
+// For the detection of the Id, the variable of gallery with 
SID_GALLERY_BG_BRUSH arrives.
+//
+// Original german text: Fuer die Erkennung der Id, die variable von Gallery 
mit
+// SID_GALLERY_BG_BRUSH ankommt. 
+//
+// I'm a native german translator, but I don't know what this mean. It looks 
like a
+// machine translation.
+
 static sal_uInt8 nParagraphPos;
 static sal_uInt8 nGraphicPos;
 static sal_uInt8 nOlePos;
@@ -148,9 +154,8 @@
 
 TYPEINIT1(SwBaseShell,SfxShell)
 
-/*
-Beschreibung:   statics
- */
+// statics
+
 static void lcl_UpdateIMapDlg( SwWrtShell rSh )
 {
 Graphic aGrf( rSh.GetIMapGraphic() );
@@ -189,9 +194,8 @@
 return bRet;
 }
 
-/*
-Beschreibung:   loeschen
- */
+// Delete
+
 void SwBaseShell::ExecDelete(SfxRequest rReq)
 {
 SwWrtShell rSh = GetShell();
@@ -213,16 +217,16 @@
 rSh.DelLeft();
 }
 else
-

[Libreoffice-commits] dev-tools.git: scripts/qawrangler-stats.py

2013-04-20 Thread Rainer Bielefeld

 scripts/qawrangler-stats.py |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1bf495fea2c8d5592e2ebdce15e262ad42789049
Author: Rainer Bielefeld libreoff...@bielefeldundbuss.de
Date:   Sun Apr 21 01:58:02 2013 +0200

fdo#56185: fixup for Bugzilla 4

diff --git a/scripts/qawrangler-stats.py b/scripts/qawrangler-stats.py
old mode 100755
new mode 100644
index 35a1354..f73c38e
--- a/scripts/qawrangler-stats.py
+++ b/scripts/qawrangler-stats.py
@@ -21,7 +21,7 @@ try:
 txt = gz.read().decode('us-ascii')
 gz.close()
 
-reportedby = re.compile(r'^.*ReportedBy:.(.*)$', re.MULTILINE)
+reportedby = re.compile(r'^.*Reporter:.(.*)$', re.MULTILINE)
 reporters = re.findall(reportedby, txt)
 
 wrangledby = re.compile(r'^.*(.*) changed:$', re.MULTILINE)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dev-tools.git: scripts/qawrangler-stats.py

2013-04-20 Thread Bjoern Michaelsen

 0 files changed

New commits:
commit 2923b2db229201d4f6c16ff287c2227caab48d71
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Sun Apr 21 02:02:42 2013 +0200

fixing executable bit, my bad

diff --git a/scripts/qawrangler-stats.py b/scripts/qawrangler-stats.py
old mode 100644
new mode 100755
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2013-04-20 Thread Markus Mohrhard

 vcl/source/control/field.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit a049c87ba59e3dde2ce1178e088530469e3d381b
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Sun Apr 21 02:10:13 2013 +0200

fix access to invalid string position

Change-Id: If811f256dc2a0cbdc25fe2a56e949736191aa002

diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 1ee47e1..f1a683d 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -154,7 +154,7 @@ static sal_Bool ImplNumericGetValue( const OUString rStr, 
sal_Int64 rValue,
 }
 else
 {
-if ( aStr1[0] == '-')
+if ( !aStr1.isEmpty()  aStr1[0] == '-')
 bNegative = sal_True;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - configure.ac connectivity/source python3/ExternalProject_python3.mk

2013-04-20 Thread Norbert Thiebaud

 configure.ac |4 ++--
 connectivity/source/commontools/dbconversion.cxx |4 ++--
 python3/ExternalProject_python3.mk   |2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit fd179c5f308a0a611bc2b5a479e28ff3ced79647
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sat Apr 20 17:44:51 2013 -0500

missing  around identity in check for code signng key on Mac

Change-Id: I421b72dd58d1216c1f68731332bc6a41d3c0071e

diff --git a/configure.ac b/configure.ac
index 639a1f1..2152487 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2586,12 +2586,12 @@ if test $_os = Darwin; then
 identity=`security find-identity -p codesigning -v 2/dev/null | grep 
'Developer ID Application:' | awk '{print $2}' |head -1`
 if test -n $identity; then
 MACOSX_CODESIGNING_IDENTITY=$identity
-pretty_name=`security find-identity -p codesigning -v | grep 
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
+pretty_name=`security find-identity -p codesigning -v | grep 
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
 AC_MSG_RESULT([yes, using the identity 
$MACOSX_CODESIGNING_IDENTITY for $pretty_name])
 fi
 elif test -n $enable_macosx_code_signing; then
 MACOSX_CODESIGNING_IDENTITY=$enable_macosx_code_signing
-pretty_name=`security find-identity -p codesigning -v | grep 
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
+pretty_name=`security find-identity -p codesigning -v | grep 
$MACOSX_CODESIGNING_IDENTITY | sed -e 's/^[[^]]*//' -e 's///'`
 AC_MSG_RESULT([yes, using the identity $MACOSX_CODESIGNING_IDENTITY 
for $pretty_name])
 else
 AC_MSG_RESULT([no])
commit 292af048ace2d4b455b2da3a22c784cb05db1d09
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sat Apr 20 17:41:34 2013 -0500

python3: --with-system-expat seems to mess up mac build

Change-Id: I2227c5c715bb656878dd97b71d59c149e7e5320a

diff --git a/python3/ExternalProject_python3.mk 
b/python3/ExternalProject_python3.mk
index f030afd..a01e115 100644
--- a/python3/ExternalProject_python3.mk
+++ b/python3/ExternalProject_python3.mk
@@ -72,9 +72,9 @@ $(call gb_ExternalProject_get_state_target,python3,build) :
$(call gb_ExternalProject_run,build,\
./configure \
$(if $(filter YES,$(CROSS_COMPILING)),--build=$(BUILD_PLATFORM) 
--host=$(HOST_PLATFORM)) \
-   --with-system-expat \
$(if $(filter TRUE,$(ENABLE_VALGRIND)),--with-valgrind) \
--prefix=/python-inst \
+   $(if $(filter MACOSX,$(OS)),,--with-system-expat) \
$(if $(filter AIX,$(OS)),--disable-ipv6 --with-threads \
OPT=-g0 -fwrapv -O3 -Wall) \
$(if $(filter WNT-GCC,$(OS)-$(COM)),--with-threads 
ac_cv_printf_zd_format=no) \
commit 693d25f8a601ee3738a396fbd8a9b838f19e39c9
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sat Apr 20 17:31:26 2013 -0500

connectivity: use LL qualifier for int64 contants

Change-Id: Iaafbd62920c2b695c5810766d143a01c288e813f

diff --git a/connectivity/source/commontools/dbconversion.cxx 
b/connectivity/source/commontools/dbconversion.cxx
index b23cd3b..0150cdd 100644
--- a/connectivity/source/commontools/dbconversion.cxx
+++ b/connectivity/source/commontools/dbconversion.cxx
@@ -39,8 +39,8 @@ namespace
 const sal_Int16 minInHour = 60;
 
 const sal_Int64 secMask  = 10;
-const sal_Int64 minMask  = 1000;
-const sal_Int64 hourMask = 10;
+const sal_Int64 minMask  = 1000LL;
+const sal_Int64 hourMask = 10LL;
 
 const double fNanoSecondsPerDay = nanoSecInSec * secInMin * minInHour * 
24.0;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[ABANDONED] Remove unused headers from modules remotebridges, udm and an...

Michael Dunphy has abandoned this change.

Change subject: Remove unused headers from modules remotebridges, udm and 
animations
..


Patch Set 1: Abandoned

Reworking my approach, will resubmit in the future

-- 
To view, visit https://gerrit.libreoffice.org/3510
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6d2fb5e88e66a1e45977c5e4a7530f28ec844720
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org
Gerrit-Reviewer: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: Tor Lillqvist t...@iki.fi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] fdo#42949 Remove unused headers in module eventattacher

Michael Dunphy has abandoned this change.

Change subject: fdo#42949 Remove unused headers in module eventattacher
..


Patch Set 1: Abandoned

Reworking my approach, will resubmit in the future

-- 
To view, visit https://gerrit.libreoffice.org/3494
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Idbb483733a00d3b23561519f911182f8316867fd
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[ABANDONED] Remove unused headers from three modules

Michael Dunphy has abandoned this change.

Change subject: Remove unused headers from three modules
..


Patch Set 1: Abandoned

Reworking my approach, will resubmit in the future

-- 
To view, visit https://gerrit.libreoffice.org/3508
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie02f99f42dbcbd613bb819da234e37dbfb3b0d89
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: filter/source sfx2/inc sfx2/Package_inc.mk sfx2/source vcl/inc vcl/Package_inc.mk vcl/source

 filter/source/xsltdialog/xmlfiltertabdialog.cxx |2 -
 filter/source/xsltdialog/xmlfiltertabdialog.hrc |   27 ---
 filter/source/xsltdialog/xmlfiltertabdialog.src |2 -
 sfx2/Package_inc.mk |1 
 sfx2/inc/sfx2/basmgr.hxx|   28 
 sfx2/source/appl/appbas.cxx |3 +-
 sfx2/source/doc/objcont.cxx |3 +-
 sfx2/source/doc/objxtor.cxx |3 +-
 sfx2/source/doc/sfxbasemodel.cxx|3 +-
 vcl/Package_inc.mk  |1 
 vcl/inc/vcl/button.hxx  |2 -
 vcl/inc/vcl/decoview.hxx|2 -
 vcl/inc/vcl/symbol.hxx  |   28 
 vcl/source/window/splitwin.cxx  |4 ++-
 14 files changed, 15 insertions(+), 94 deletions(-)

New commits:
commit 8f4fc74c34df6efd6b74aacc610bf6f52b615aa5
Author: Michael Dunphy michael.w.dun...@gmail.com
Date:   Fri Apr 19 19:10:54 2013 -0400

fdo#62699 Remove a few more pass-through headers

Change-Id: I4cc2dc7f1da3bc15921939e3bd5908a3f7049eab
Reviewed-on: https://gerrit.libreoffice.org/3492
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/filter/source/xsltdialog/xmlfiltertabdialog.cxx 
b/filter/source/xsltdialog/xmlfiltertabdialog.cxx
index 2808375..78a1505 100644
--- a/filter/source/xsltdialog/xmlfiltertabdialog.cxx
+++ b/filter/source/xsltdialog/xmlfiltertabdialog.cxx
@@ -25,7 +25,7 @@
 
 #include xmlfilterdialogstrings.hrc
 #include xmlfiltertabdialog.hxx
-#include xmlfiltertabdialog.hrc
+#include xmlfiltercommon.hrc
 #include xmlfiltertabpagebasic.hrc
 #include xmlfiltertabpagexslt.hrc
 #include xmlfiltertabpagebasic.hxx
diff --git a/filter/source/xsltdialog/xmlfiltertabdialog.hrc 
b/filter/source/xsltdialog/xmlfiltertabdialog.hrc
deleted file mode 100644
index b731ade..000
--- a/filter/source/xsltdialog/xmlfiltertabdialog.hrc
+++ /dev/null
@@ -1,27 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef _XMLFILTERTABDIALOG_HRC_
-#define _XMLFILTERTABDIALOG_HRC_
-
-#include xmlfiltercommon.hrc
-
-#endif
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/filter/source/xsltdialog/xmlfiltertabdialog.src 
b/filter/source/xsltdialog/xmlfiltertabdialog.src
index d2220ae..4f4f9b1 100644
--- a/filter/source/xsltdialog/xmlfiltertabdialog.src
+++ b/filter/source/xsltdialog/xmlfiltertabdialog.src
@@ -17,7 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#include xmlfiltertabdialog.hrc
+#include xmlfiltercommon.hrc
 #include xmlfiltertabpagebasic.hrc
 #include xmlfiltertabpagexslt.hrc
 #include xmlfilterhelpids.hrc
diff --git a/sfx2/Package_inc.mk b/sfx2/Package_inc.mk
index 0e22e48..23b051a 100644
--- a/sfx2/Package_inc.mk
+++ b/sfx2/Package_inc.mk
@@ -26,7 +26,6 @@ $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/app.hxx,sfx2/app.hxx))
 $(eval $(call gb_Package_add_file,sfx2_inc,inc/sfx2/app.hxx,sfx2/app.hxx))
 $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/appuno.hxx,sfx2/appuno.hxx))
 $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/basedlgs.hxx,sfx2/basedlgs.hxx))
-$(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/basmgr.hxx,sfx2/basmgr.hxx))
 $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/bindings.hxx,sfx2/bindings.hxx))
 $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/brokenpackageint.hxx,sfx2/brokenpackageint.hxx))
 $(eval $(call 
gb_Package_add_file,sfx2_inc,inc/sfx2/chalign.hxx,sfx2/chalign.hxx))
diff --git a/sfx2/inc/sfx2/basmgr.hxx b/sfx2/inc/sfx2/basmgr.hxx
deleted file mode 100644
index c22dd4d..000
--- a/sfx2/inc/sfx2/basmgr.hxx
+++ /dev/null
@@ -1,28 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0.

[Libreoffice-commits] core.git: Repository.mk scp2/source

2013-04-20 Thread Marcos Paulo de Souza

 Repository.mk|   16 
 scp2/source/gnome/file_gnome.scp |   21 +++--
 scp2/source/impress/file_impress.scp |   11 +--
 scp2/source/kde/file_kde.scp |   14 ++
 scp2/source/python/file_python.scp   |   11 +--
 scp2/source/tde/file_tde.scp |7 +--
 6 files changed, 16 insertions(+), 64 deletions(-)

New commits:
commit 03a36ed0fb81088358d7cfc3068a7be9878f2f8b
Author: Marcos Paulo de Souza marcos.souza@gmail.com
Date:   Sat Apr 20 17:46:19 2013 -0300

fdo#60949: Move more libs to OOOLIBS

Change-Id: Ibd45f7004f8eaa151b9a60d7369d396411f60a2b
Reviewed-on: https://gerrit.libreoffice.org/3511
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com

diff --git a/Repository.mk b/Repository.mk
index 314ca61d..0afc24b 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -559,20 +559,28 @@ $(eval $(call gb_Helper_register_libraries,RTVERLIBS, \
 ))
 
 $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
+PresenterScreen \
 basprov \
 cairocanvas \
 dlgprov \
 expwrap \
 fastsax \
+gconfbe1 \
 i18nsearch \
+kdebe1 \
+kde4be1 \
 ldapbe2 \
 migrationoo2 \
 migrationoo3 \
 msforms \
 mtfrenderer \
 OGLTrans \
+pythonloader \
 slideshow \
 stringresource \
+tdebe1 \
+ucpgio1 \
+ucpgvfs1 \
 vbaevents \
 vbaobj \
 vbaswobj \
@@ -587,33 +595,25 @@ $(eval $(call 
gb_Helper_register_libraries_for_install,UNOLIBS_OOO,OOO, \
ucpexpand1 \
 ))
 $(eval $(call gb_Helper_register_libraries,UNOLIBS_OOO, \
-PresenterScreen \
 canvasfactory \
 cmdmail \
 directx5canvas \
 directx9canvas \
 fpicker \
 fps_office \
-gconfbe1 \
 gdipluscanvas \
 hatchwindowfactory \
-kdebe1 \
-kde4be1 \
 losessioninstall \
 macbe1 \
 nullcanvas \
 passwordcontainer \
 pdfimport \
-pythonloader \
 postgresql-sdbc \
 postgresql-sdbc-impl \
 simplecanvas \
 syssh \
-tdebe1 \
 ucpcmis1 \
 ucpext \
-ucpgio1 \
-ucpgvfs1 \
 ucptdoc1 \
 updatefeed \
 vclcanvas \
diff --git a/scp2/source/gnome/file_gnome.scp b/scp2/source/gnome/file_gnome.scp
index 9672965..cf9a498 100644
--- a/scp2/source/gnome/file_gnome.scp
+++ b/scp2/source/gnome/file_gnome.scp
@@ -27,23 +27,13 @@
 #include macros.inc
 
 #ifdef ENABLE_GIO
-File gid_File_Lib_GIO
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(ucpgio1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_GIO, ucpgio1 )
 
 SPECIAL_COMPONENT_LIB_FILE(gid_File_Lib_Losessioninstall, losessioninstall.uno)
 #endif
 
 #ifdef ENABLE_GNOMEVFS
-File gid_File_Lib_Gnomevfs
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(ucpgvfs1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Gnomevfs, ucpgvfs1 )
 #endif
 
 #if (defined ENABLE_GCONF  defined ENABLE_LOCKDOWN) || defined ENABLE_GIO
@@ -56,12 +46,7 @@ End
 #endif
 
 #ifdef ENABLE_GCONF
-File gid_File_Lib_Gconfbe
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(gconfbe1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Gconfbe, gconfbe1 )
 #endif
 
 #ifdef ENABLE_SYSTRAY_GTK
diff --git a/scp2/source/impress/file_impress.scp 
b/scp2/source/impress/file_impress.scp
index f2eebf0..7753335 100644
--- a/scp2/source/impress/file_impress.scp
+++ b/scp2/source/impress/file_impress.scp
@@ -37,16 +37,7 @@ File gid_File_Lib_Animcore
PACKED_LIB_FILE_BODY;
 End
 
-File gid_File_Lib_PresenterScreen
-LIB_FILE_BODY;
-Dir = SCP2_OOO_BIN_DIR;
-#if defined UNX
-Name = STRING(CONCAT2(PresenterScreen.uno,UNXSUFFIX));
-#else
-Name = PresenterScreen.uno.dll;
-#endif
-Styles = (PACKED);
-End
+STD_LIB_FILE( gid_File_Lib_PresenterScreen, PresenterScreen )
 
 File gid_File_Share_Registry_Impress_Xcd
 TXT_FILE_BODY;
diff --git a/scp2/source/kde/file_kde.scp b/scp2/source/kde/file_kde.scp
index 1614f69..2f0320a 100644
--- a/scp2/source/kde/file_kde.scp
+++ b/scp2/source/kde/file_kde.scp
@@ -27,19 +27,9 @@
 #include macros.inc
 
 #ifdef ENABLE_KDE
-File gid_File_Lib_Kdebe
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(kdebe1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Kdebe, kdebe1 )
 #endif
 
 #ifdef ENABLE_KDE4
-File gid_File_Lib_Kde4be
-LIB_FILE_BODY;
-Styles = (PACKED);
-Dir = SCP2_OOO_BIN_DIR;
-Name = STRING(CONCAT2(kde4be1.uno,UNXSUFFIX));
-End
+STD_LIB_FILE( gid_File_Lib_Kde4be, kde4be1 )
 #endif
diff --git a/scp2/source/python/file_python.scp 
b/scp2/source/python/file_python.scp
index 614c732..c502986 100644
--- a/scp2/source/python/file_python.scp
+++ b/scp2/source/python/file_python.scp
@@ -54,16 +54,7 @@ File

[PUSHED] fdo#62699 Remove a few more pass-through headers

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3492

Approvals:
  LibreOffice gerrit bot: Verified
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3492
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4cc2dc7f1da3bc15921939e3bd5908a3f7049eab
Gerrit-PatchSet: 3
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Dunphy michael.w.dun...@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] fdo#60949: Move more libs to OOOLIBS

Hi,

Thank you for your patch!  It has been merged to LibreOffice.

If you are interested in details, please visit

https://gerrit.libreoffice.org/3511

Approvals:
  LibreOffice gerrit bot: Verified
  David Tardon: Verified; Looks good to me, approved


-- 
To view, visit https://gerrit.libreoffice.org/3511
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd45f7004f8eaa151b9a60d7369d396411f60a2b
Gerrit-PatchSet: 2
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Marcos Souza marcos.souza@gmail.com
Gerrit-Reviewer: David Tardon dtar...@redhat.com
Gerrit-Reviewer: LibreOffice gerrit bot ger...@libreoffice.org

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice-qa] [LibreOffice-QA] Conference Call 2013-04-19 - Agenda Minutes

2013-04-20 Thread Rainer Bielefeld


Sophie Gautier schrieb:


please consider that we (FR group) are acting as a community and not as
individuals,



Concerning this process
https://wiki.documentfoundation.org/QA/BSA/Localization
it seems a bit bureaucratic to me.


Hi Sophie,

I agree. Currently I see a tendency that the QA calls generate decisions 
and want to change proceedings without knowing enough concerning 
existing proceedings. The advisable way would be to ask the French QA 
team via mailing list to leave some notes in the Wiki how they proceed 
(or how they plan to proceed). If then someone has ideas for 
improvements he can start a discussion with the team within the team (as 
a newbee there). And only with very good urgent reasons (coordinations 
needs between such sub-communities or whatever) a discussion may be 
started on international level.


What's more or less the same what Sophie said more friendly.

BTW, @Sophie:
Is the BSA-Fr already working or at least is there some concrete goal 
when it should work [2]? If the problems still will need some time for a 
solution, and also may be for bug reports in French language what will 
find their way into Bugzilla also in future, I can offer a Bugzilla 
solution. The qa@fr mailing list will get exactly 1 mail if the list 
will be added as QA-contact or similar. If the 10 key bug wranglers [1] 
know how to proceed that should work nearby 100% perfect. Precondition 
is that the list has a Bugzilla account, the rest are some smart e-mail 
settings for the account.


I prefer such a solution to the current proceeding to add French 
language users to CC.


If you are interested please simply discuss on the fr-qa list and send a 
ping to me if I can help.



Best regards



Rainer



Addendum:
[1]
--- Top 10 wranglers March 2013 ---
LibreOffice at bielefeldundbuss.de306
joren.libreoffice at telenet.be   271
jmadero.dev at gmail.com  197
bfo.bugmail at spamgourmet.com180
stgohi-lobugs at yahoo.de 152
serval2412 at yahoo.fr 99
cno at nouenoff.nl 81
vstuart.foote at utsa.edu  59
michael.meeks at novell.com58
lionel at mamane.lu57


Hyperlinks
[2] 
https://wiki.documentfoundation.org/QA/BSA/Localization#Who_is_in_charge_of_a_localized_BSA.3F


___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [LibreOffice-QA] Conference Call 2013-04-19 - Agenda Minutes

2013-04-20 Thread Sophie Gautier

Hi Rainer, all,
On 20/04/2013 11:29, Rainer Bielefeld wrote:
 Sophie Gautier schrieb:
 
 please consider that we (FR group) are acting as a community and not as
 individuals,
 
 Concerning this process
 https://wiki.documentfoundation.org/QA/BSA/Localization
 it seems a bit bureaucratic to me.
 
 Hi Sophie,
 
 I agree. Currently I see a tendency that the QA calls generate decisions
 and want to change proceedings without knowing enough concerning
 existing proceedings. The advisable way would be to ask the French QA
 team via mailing list to leave some notes in the Wiki how they proceed
 (or how they plan to proceed). If then someone has ideas for
 improvements he can start a discussion with the team within the team (as
 a newbee there). And only with very good urgent reasons (coordinations
 needs between such sub-communities or whatever) a discussion may be
 started on international level.
 
 What's more or less the same what Sophie said more friendly.

On one hand I understand that the QA team would like more communication
between subgroups and their team, but the same happens for marketing or
communication. So it's not dedicated to QA, NL projects are always shy
about what they are doing. On the other hand each NL project has his on
way to build his community, sometimes only online, sometimes more during
live meetings, and this is one thing that should be taken into account
when setting general processes.

 
 BTW, @Sophie:
 Is the BSA-Fr already working or at least is there some concrete goal
 when it should work [2]? 

It's not working yet, I think that the e-mail issue is still not solved
and I didn't get news from Rob about it.

If the problems still will need some time for a
 solution, and also may be for bug reports in French language what will
 find their way into Bugzilla also in future, I can offer a Bugzilla
 solution. The qa@fr mailing list will get exactly 1 mail if the list
 will be added as QA-contact or similar. If the 10 key bug wranglers [1]
 know how to proceed that should work nearby 100% perfect. Precondition
 is that the list has a Bugzilla account, the rest are some smart e-mail
 settings for the account.
 
 I prefer such a solution to the current proceeding to add French
 language users to CC.

yes, that's a good solution.
 
 If you are interested please simply discuss on the fr-qa list and send a
 ping to me if I can help.

We have already discussed this on the fr-qa list, so members are aware that:
- we may receive mails in English asking to translate the bug (currently
the bug is translated and should be also checked)
- we should soon receive mail from BSA that will report issues in French
and will need to be checked, searched for duplicates, and reported in
Bugzilla if needed.
As I said I'll document the BSA process in our team when it will work in
French for our members and in English for the other groups who would
like to join. BTW, I think that almost all the QA pages are translated
into French now.

Kind regards
Sophie
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] minutes of ESC call ...

Hi,

On Thu, Apr 18, 2013 at 03:54:19PM +0100, Michael Meeks wrote:
 * Header rename script (Bjoern)
   + https://gerrit.libreoffice.org/#/c/3367/
   + if run the script, everything succeeds, and it builds.
   + at this stage - it ignores sal - which is magic somehow
   + use it as-is  move ahead.
   + do the remaining cleanup afterwards.

I pushed a sequence of follow-up reviews that move cppu, cppuhelper, sal
and salhelper headers, stop copying generated UNO API headers to
$(OUTDIR) and do several more assorted cleanups.

D.
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] After EOL has been reached...

2013-04-20 Thread Rainer Bielefeld


Robinson Tryon schrieb:

Per discussion at the meeting today, we generally agreed to the following:


Hi,

I left some hints and thoughts on 
https://wiki.documentfoundation.org/Talk:QA/Meetings/2013/April_19.


CU

Rainer
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

Re: [Libreoffice-qa] [LibreOffice-QA] Conference Call 2013-04-19 - Agenda Minutes

2013-04-20 Thread Bjoern Michaelsen

Hi,

On Sat, Apr 20, 2013 at 11:29:59AM +0200, Rainer Bielefeld wrote:
 Currently I see a tendency that the QA calls generate
 decisions and want to change proceedings without knowing enough
 concerning existing proceedings

You are kindly invited to join the call to improve the situation. AFAIK we even
changed the timeslot of the call already multiple times trying to accomodate 
more
participants.

 The advisable way would be to ask the French QA team via mailing list to
 leave some notes in the Wiki how they proceed (or how they plan to proceed).
 If then someone has ideas for improvements he can start a discussion with the
 team within the team (as a newbee there). And only with very good urgent
 reasons (coordinations needs between such sub-communities or whatever) a
 discussion may be started on international level.

This project was started out of the needs of the NL project -- in that case it
has to ensure in some way to stay reasonably responsive. Note also that a
mailing list is precisely _NOT_ what is needed here, as then there is nobody
feeling responsible for it. I would be happy with either Sophie or Charles
naming one or two people as the contact persons to the NL community in this
case if they are overloaded themselves (which they are), but not with a mailing
list -- esp. not one of a community that Sophie describes as NL projects are
always shy about what they are doing.

Best,

Bjoern
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 63627] MinGW: Windows (All apps) slowing down due to excessive disk access

https://bugs.freedesktop.org/show_bug.cgi?id=63627

--- Comment #2 from Hans Lodder hans.lod...@results2match.com ---
Some more info. The Mozilla products Firefox and Thunderbird (TB) suffer from
the same thing: Firefox a little, and only when flash-like software is fired
through the container functionality. TB suffers more, but by far not as much as
LibreOffice.

The short term solution for Mozilla products is to clear all history. After
that they behave themselves for some time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63746] FILEOPEN: Very slow to open .xlsx file

https://bugs.freedesktop.org/show_bug.cgi?id=63746

--- Comment #1 from Thomas van der Meulen pje...@hotmail.com ---
Hello David, I can confirm that the file doesn't open, but I think the file is
damaged because wen I open it with Excel it frezes and needs to repair it. I
also tested it with Apple Numbers 4.2 and it says the file was damaged. 

version:
Pages: 4.2 
LibreOfffice: 4.0.3.1 and 4.1 master 
Excel: 2007

OS: 
Windows7 (Excel)
Mac osx 10.8.3  (LibreOffice  Numbers)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57431] Calc: Empty and Not Empty in the autofilter list behave inconsistently

https://bugs.freedesktop.org/show_bug.cgi?id=57431

--- Comment #4 from alister.h...@gmail.com ---
 The approach in Excel is consistent and logical - the only issue with it is 
 that there is no way to know whether (blanks) means cells that are blank or 
 cells that contain the string Contains)

Oops - I meant to say the string blanks, not the string Contains.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63749] New: Gallery is missing entries resource id 6015 not found

https://bugs.freedesktop.org/show_bug.cgi?id=63749

  Priority: medium
Bug ID: 63749
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: Gallery is missing entries resource id 6015 not
found
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: tho...@arnhold.org
  Hardware: Other
Status: UNCONFIRMED
   Version: 4.1.0.0.alpha0+ Master
 Component: UI
   Product: LibreOffice

Created attachment 78266
  -- https://bugs.freedesktop.org/attachment.cgi?id=78266action=edit
missing RID

Steps to reproduce:

1. Open LibreOffice writer
2. Go to Tools - Gallery
3. The first entry will have resource id 6015 not found

Moreover the entire list is very short. There are galleries which are present
in the installation, but not shown in this list (eg. Fontwork).

The attached image shows the error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63749] Gallery is missing entries resource id 6015 not found

https://bugs.freedesktop.org/show_bug.cgi?id=63749

Thomas Arnhold tho...@arnhold.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63750] New: logical AND involving empty cells

https://bugs.freedesktop.org/show_bug.cgi?id=63750

  Priority: medium
Bug ID: 63750
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: logical AND involving empty cells
  Severity: normal
Classification: Unclassified
OS: All
  Reporter: muhavu...@gmail.com
  Hardware: x86 (IA32)
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

Created attachment 78267
  -- https://bugs.freedesktop.org/attachment.cgi?id=78267action=edit
AND function with one empty cell as argument

A AND function where one of the arguments is TRUE and the second is empty
returns TRUE.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63336] CRASH EDITING comment with rightclick

https://bugs.freedesktop.org/show_bug.cgi?id=63336

Michael Gasperl mich...@gasperl.at changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Michael Gasperl mich...@gasperl.at ---
Dear Joren co!

Thank you for your hint, Joren! I renamed my user-profile (during update from
LiO 3 the installer made a new folder in ~/Library/Application
Support/LibreOffice/
Now there is 3 and 4, but the settings where transferred to 4)
After renaming user LiO doesn't crash and I get the menu, when I click on a
note -- problem solved!
System: also OSX Mountain Lion 10.8.3

Thanks for your help!!
Michael

PS: With former versions of LibreOffice (v3) I often had crashes (also after
fresh install) and so I had to use alternatives like NeoOffice. As far as I can
evaluate 4.0.2.2 runs completely stable and I'm glad I can use it now as a
standard!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56185] Bug Wrangler statistics script does not work with new Bugzilla 4.2.

https://bugs.freedesktop.org/show_bug.cgi?id=56185

--- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
Created attachment 78268
  -- https://bugs.freedesktop.org/attachment.cgi?id=78268action=edit
Works for Statsitics October 2012 and later

I simply repaced old code line
reportedby = re.compile(r'^.*ReportedBy:.(.*)$', re.MULTILINE)
by
reportedby = re.compile(r'^.*Reporter:.(.*)$', re.MULTILINE)

Attachment is the complete python script based on Attachment 66244 Details for
Bug 54110

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57529] FORMATTING: Brush-formatting/the 'undo' of brush isn't working properly

https://bugs.freedesktop.org/show_bug.cgi?id=57529

Daniel Rohde-Kage daniel.rohde-k...@tu-dortmund.de changed:

   What|Removed |Added

Version|3.6.0.2 rc  |4.0.2.2 release

--- Comment #2 from Daniel Rohde-Kage daniel.rohde-k...@tu-dortmund.de ---
The described bug appears in a different way on LO 4.022, but the brush still
doesn't do the job properly:

- It copies fonttype and -size, but e.g. the fontweight is ignored.

I didn't test it out extremely, but I suppose, there IS an issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 56185] Bug Wrangler statistics script does not work with new Bugzilla 4.2.

https://bugs.freedesktop.org/show_bug.cgi?id=56185

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |LibreOffice@bielefeldundbus
   |desktop.org |s.de
 CC||bjoern.michaelsen@canonical
   ||.com,
   ||LibreOffice@bielefeldundbus
   ||s.de
 Ever confirmed|0   |1

--- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de ---
The patch adapts the script to the new Reporter identification in Bugzilla 4,
so that reporter statistic will work again.

@Björn:
No idea how to push that to git (and whether that is necessary), I will add a
link in the Wiki QA area with a short instruction how to use

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63751] New: The error of a beam pause display of 1000

https://bugs.freedesktop.org/show_bug.cgi?id=63751

  Priority: medium
Bug ID: 63751
  Assignee: libreoffice-bugs@lists.freedesktop.org
   Summary: The error of a beam pause display of 1000
  Severity: normal
Classification: Unclassified
OS: Windows (All)
  Reporter: tetsu_ma...@nifty.com
  Hardware: x86 (IA32)
Status: UNCONFIRMED
   Version: 4.0.2.2 release
 Component: Spreadsheet
   Product: LibreOffice

I use Calc ver.4.0.2 on Windows XP. 
Even if range specification is carried out and it chooses a beam pause of a
display form, the cell which does not display the comma of a beam pause comes
out. 
It display correctly that I chosed line insertion and selected undo. 
Isn't it the error of formatting or a format function?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63538] Zero Width Space (U+200B) always visible, even when not viewing Nonprinting Characters

https://bugs.freedesktop.org/show_bug.cgi?id=63538

--- Comment #2 from Andras Timar tima...@gmail.com ---
You can turn off field shading. View - Field Shading (Ctrl+F8)

It is an interesting question, why these formatting marks (zero with space,
optional hyphen, etc.) have field shading.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63750] logical AND involving empty cells

https://bugs.freedesktop.org/show_bug.cgi?id=63750

GerardF gerard.farg...@orange.fr changed:

   What|Removed |Added

  Attachment #78267|text/plain  |application/vnd.oasis.opend
  mime type||ocument.spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62057] : Copying of diagram: categories and y axis interchanged in Calc

https://bugs.freedesktop.org/show_bug.cgi?id=62057

Aurimas Fišeras auri...@members.fsf.org changed:

   What|Removed |Added

 Whiteboard|BSA, bibisectrequest|BSA bibisected40
 CC||auri...@members.fsf.org

--- Comment #7 from Aurimas Fišeras auri...@members.fsf.org ---
9a5620ca6473969359f262802c76daf35cbcbb5d is the first bad commit
commit 9a5620ca6473969359f262802c76daf35cbcbb5d
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Tue Dec 11 01:59:31 2012 +

source-hash-ae4e4a11d4300f7448cb6bd170fcb034542caddc

# bad: [5b4b36d87517a6ea96ff8c84c46b12f462fc9a1a]
source-hash-8450a99c744e9005f19173e4df35d65640bcf5c4
# good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00]
source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932
git bisect start 'latest' 'oldest'
# good: [16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9]
source-hash-099198a4224778fe6e43f5dc13b5b9b1b4dc828c
git bisect good 16b0b88cbd4ef0f51816e97277e40c5cf78f7bf9
# good: [f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a]
source-hash-a581d31b227623e09d2970a91214fda398f98eda
git bisect good f28b8f9a6c47fa59bf98fffe937a2f2db7a2445a
# good: [114fd3b76bcba890e6d702d00cef910f1493c262]
source-hash-64ab96cd15e52da88781e720d6f031dbcd0ba902
git bisect good 114fd3b76bcba890e6d702d00cef910f1493c262
# bad: [47498a36f7af8f54e6e3dda89cd4708802a409e6]
source-hash-19f4ebd8a54da0ae03b9cc8481613e5cd20ee1e7
git bisect bad 47498a36f7af8f54e6e3dda89cd4708802a409e6
# good: [f4e2d84db194943180f3e7ed4adce5f8e377d9bc]
source-hash-806d18ae7b8c241fe90e49d3d370306769c50a10
git bisect good f4e2d84db194943180f3e7ed4adce5f8e377d9bc
# bad: [fb4214f9d134b556582a4a5280e5458de5f8eebd]
source-hash-683758efb22d08a4cf211a6d985148f513da2a90
git bisect bad fb4214f9d134b556582a4a5280e5458de5f8eebd
# good: [e2e46267c18c2706de771a08472ebfce19f68520]
source-hash-4316e643ef345b0f673b4a03a80a4b7cb3185588
git bisect good e2e46267c18c2706de771a08472ebfce19f68520
# bad: [9a5620ca6473969359f262802c76daf35cbcbb5d]
source-hash-ae4e4a11d4300f7448cb6bd170fcb034542caddc
git bisect bad 9a5620ca6473969359f262802c76daf35cbcbb5d

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 42560] Make Insert Special Character dialog non-modal

https://bugs.freedesktop.org/show_bug.cgi?id=42560

--- Comment #11 from Jean Spiteri beimaginativeegr...@gmail.com ---
Good idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63749] Gallery is missing entries resource id 6015 not found

https://bugs.freedesktop.org/show_bug.cgi?id=63749

Thomas Arnhold tho...@arnhold.org changed:

   What|Removed |Added

  Attachment #78266|text/plain  |image/png
  mime type||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 38880] Precision in CSV import

https://bugs.freedesktop.org/show_bug.cgi?id=38880

--- Comment #5 from Anurag Kanungo anuragkanu...@gmail.com ---
I would like to work on it , as stated it ignores the precision of the import
cells , basically it removes the zeros only that exist in end after the
decimal, like , it will reduce 100. to 100 only , but if we use 100.0234 it
will remain as it is 100.0234 on import in cell . So, here we have to remove
the code which removes the end zeroes . 

Can i have the path to the file , which contains the code of removing end
zeroes , such as i can edit to secure precision .

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 50699] Template Changer: Allow ability to change a document's associated template

https://bugs.freedesktop.org/show_bug.cgi?id=50699

--- Comment #5 from David djrei...@gmail.com ---
Does https://bugs.freedesktop.org/show_bug.cgi?id=60660 duplicate this
bug/feature request?

See comment #3 in that #60660 comment thread for what is *needed*.

Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57296] EDITING: Text selection, 'Adding selection' mode

https://bugs.freedesktop.org/show_bug.cgi?id=57296

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from A stgohi-lob...@yahoo.de ---
reproducible with LO 4.0.2.2 (Win7 Home, 64bit)

Remark: Everything is fine if you select only single words (without ever using
Shift+Ctrl+Arrow).  This problem only occurs if you use Shift+Ctrl+Arrow.  For
instance if you select a word and then use Shift+Ctrl+Arrow left or right to
select the word to the left/right of the cursor, then I could always reproduce
that this section keeps to be selected (even if you delete the whole text!). 
But sometimes I could even reproduce it for single selected words (but only
after using Shift+Ctrl+Arrow), but where I could not figure out under which
reproducible circumstances this happens, but it has something to do with the
Shift+Ctrl+Arrow combination.

Note: If you press Shift+F8 you get no system feedback.  To see in which mode
you are right now, you have to go to the middle of the toolbar at the bottom of
WRITER.  There you have a grey square on which you would have to make a left
mouse click.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57085] FILEOPEN: Some doc files takes minutes to be opened (problem seems to be picture-related)

https://bugs.freedesktop.org/show_bug.cgi?id=57085

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #3 from A stgohi-lob...@yahoo.de ---
not reproducible with LO 4.0.2.2 (Win7 Home, 64bit, i5), it takes around 7
seconds to open the file

Does this issue still persist for you with the latest release of LO?  If not,
then I would propose to close this bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57274] EDITING: Paste Special Link Checkbox fails to insert cell references when the source cell is blank

https://bugs.freedesktop.org/show_bug.cgi?id=57274

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from A stgohi-lob...@yahoo.de ---
reproducible with LO 4.0.2.2 (Win7 Home, 64bit), I would agree

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57210] : Feature Request:: Better interpretation of formulas including numbers containing commas.

https://bugs.freedesktop.org/show_bug.cgi?id=57210

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Severity|normal  |enhancement
 Ever confirmed|0   |1

--- Comment #2 from A stgohi-lob...@yahoo.de ---
reproducible with LO 4.0.2.2 (Win7 Home, 64bit)
If you have English settings then type in a cell for instance =9,5*2 and with
non-English settings type =9.5*2.  In these cases you would get an error
message (#REF!), but no hint message to correct your formula.

marked as enhancement request

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57205] FILEOPEN Opening WordPerfect file aborts with error

https://bugs.freedesktop.org/show_bug.cgi?id=57205

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from A stgohi-lob...@yahoo.de ---
not reproducible with LO 4.0.2.2 (Win7 Home, 64bit)

Does this issue still persist for you with the latest release of LO or is it a
Linux issue only?  If it does not persit, then I would propose to close this
bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57150] Calc FORMATTING: Optimal column width works incorrectly when column includes a merged cell

https://bugs.freedesktop.org/show_bug.cgi?id=57150

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #4 from A stgohi-lob...@yahoo.de ---
reproducible with LO 4.0.2.2 (Win7 Home, 64bit), I would agree with Sasha

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 57183] : Top Bar (File/Edit/View/Insert etc) randomly disappears

https://bugs.freedesktop.org/show_bug.cgi?id=57183

A stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from A stgohi-lob...@yahoo.de ---
Does this issue still persist for you with the latest release of LO?  If not,
then I would propose to close this bug report and to reopen it if it occurs
again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 60949] move libraries from UNOLIBS_OOO to OOOLIBS in build system

https://bugs.freedesktop.org/show_bug.cgi?id=60949

--- Comment #2 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Marcos Paulo de Souza committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5414a3eecdb09be928313477792acfe1d3534645

fdo#60949: Move more libs to OOOLIBS



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58886] Since 2 weeks now we can't store or safe letters under LibreOffice 3.6 in odt. under Win XP.