[Libreoffice-commits] core.git: l10ntools/Executable_helpex.mk
l10ntools/Executable_helpex.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 4e2e1ca76f772d4644a21b82f79dfb4412a9c99f Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 09:23:50 2013 +0300 Seems that on the Android tinderboxes, icudata is needed by helpex But it built fine locally for me, huh. Oh well. Change-Id: Icef376a26eb8069eff002b2112a25363b5e18cb3 diff --git a/l10ntools/Executable_helpex.mk b/l10ntools/Executable_helpex.mk index c7f5cce..0118671 100644 --- a/l10ntools/Executable_helpex.mk +++ b/l10ntools/Executable_helpex.mk @@ -23,6 +23,7 @@ $(eval $(call gb_Executable_use_externals,helpex,\ boost_headers \ icu_headers \ libxml2 \ + icudata \ icuuc \ icui18n \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Gerrit News 2013-09-23
Moin! * Open changes on master for project core changed in the last 25 hours: + Remove Java unit tests migrated to Python in https://gerrit.libreoffice.org/6017 from David Ostrovsky + fdo#54686 Treat hard blank as soft blank in number in https://gerrit.libreoffice.org/6015 from Laurent BP + General cleanup in sal module for all and unix. in https://gerrit.libreoffice.org/6016 from Arnaud Versini * Merged changes on master for project core changed in the last 25 hours: + fdo#60889: FILEOPEN: Incorrect opening XLSX file (sharedStrings.xml) in https://gerrit.libreoffice.org/5763 from Thomas Arnhold + fdo#39881 change Find All behaviour in Calc in https://gerrit.libreoffice.org/5886 from Matúš Kukan + PoC: no libs in solver in https://gerrit.libreoffice.org/5715 from Björn Michaelsen * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + Remove more unusedcode in https://gerrit.libreoffice.org/5937 from Marcos Souza + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + improve performance of copyArea in Ios in https://gerrit.libreoffice.org/5707 from Tsahi Glik @ CloudOn + Fix for IOS scroll by pixels, and pinch to zoom Change-Id: Ied6087a264f1c in https://gerrit.libreoffice.org/5742 from Ptyl + fix polygon rendering with clip area of one line only in https://gerrit.libreoffice.org/5709 from Tsahi Glik @ CloudOn + fix for text watermark in https://gerrit.libreoffice.org/5568 from Adam CloudOn + fdo#39468: Translate German comments (first part) in include/svl/filerec. in https://gerrit.libreoffice.org/5793 from Philipp Riemer + fdo#44689: fix for specific case restart value 0 in https://gerrit.libreoffice.org/5681 from Adam CloudOn + Dynamically align toolbars in LibreOffice in https://gerrit.libreoffice.org/5655 from Prashant Pandey + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + fdo#66401: fix for combined characters in https://gerrit.libreoffice.org/5018 from Adam CloudOn + more debug logs, extra debug layer, file is not used in p3k in https://gerrit.libreoffice.org/5267 from James Michael Dupont + Remove old outdated gallery images and sounds in https://gerrit.libreoffice.org/4993 from Samuel Mehrbrodt + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn + fdo#64817 : fix for rectangle with image fill in https://gerrit.libreoffice.org/4718 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [ANN] --disable-orcus
On Thu, Sep 19, 2013 at 11:33:38AM -0400, Kohei Yoshida wrote: On Thu, 2013-09-19 at 17:23 +0200, Stephan Bergmann wrote: But is it intentional that with http://cgit.freedesktop.org/libreoffice/core/commit/?id=02346aa4663055e1adf7c52ede89871a493f4513 Add the configure bits to support --disable-orcus's AC_MSG_CHECKING([whether to enable orcus]) if test $_os != Darwin -a $_os != Android -a $_os != iOS -a \( -z $enable_orcus -o $enable_orcus != no \); then an explicit --enable-orcus on e.g. Mac OS X is now silently ignored completely? Not intentional. I just copied whatever the graphite option was doing, so it's possible that it's broken on OS X. Since Graphite is disabled on Mac, this shouldn't be surprising. Regards, Khaled ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: l10ntools/Executable_xrmex.mk
l10ntools/Executable_xrmex.mk |1 + 1 file changed, 1 insertion(+) New commits: commit 30d7729586a60bef061261e9e59bf44768cc0196 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 10:17:37 2013 +0300 Add icudata here, too Change-Id: I4bf39d3f4f21a0eb78e064c74ff47a47c9d0558c diff --git a/l10ntools/Executable_xrmex.mk b/l10ntools/Executable_xrmex.mk index 109198d..d4dc6a2 100644 --- a/l10ntools/Executable_xrmex.mk +++ b/l10ntools/Executable_xrmex.mk @@ -33,6 +33,7 @@ $(eval $(call gb_Executable_add_exception_objects,xrmex,\ $(eval $(call gb_Executable_use_externals,xrmex,\ boost_headers \ libxml2 \ +icudata \ icuuc \ icui18n \ icu_headers \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
HSQLDB / Unit tests
Hi all, I'm trying to get HSQLDB unit tests to run in a CppunitTest -- whilst still in solver I added some paths locally to solver's unorc (which worked fine, but not a great solution) -- now that we're running unit tests in instdir I'd like some sort of permanent solution. (The reason I want to use a CppUnitTest is that ideally we want to run exactly the same tests on Firebird and HSQLDB, and since that also allows for performance comparisons.) HSQLDB's classpath is hardcoded in HDriver.cxx as: vnd.sun.star.expand:$BRAND_BASE_DIR/ LIBO_SHARE_JAVA_FOLDER /hsqldb.jar As a first step I'd like to make this: vnd.sun.star.expand:$LO_JAVA_DIR/hsqldb.jar Either of these work when running LO normally, the latter is cleaner and seems much more correct. (Patch is in gerrit, but outdated commit comment now that we're in instdir -- https://gerrit.libreoffice.org/#/c/5953/ ). However neither of these work for unit tests: BRAND_BASE_DIR and LO_JAVA_DIR are both set in fundamentalrc, which doesn't seem to be used when running unit tests. It also looks like when running unit tests only the ure/lib/unorc is used -- I'm not entirely sure how to procede here -- using LO_JAVA_DIR within HSQLDB setting LO_JAVA_DIR=${ORIGIN}/../../program/classes works, but is that the desired way of doing things (adjusted by using scp2 I guess to work on all systems)? Cheers, Andrzej ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/sc-notes-storage' - sc/qa
sc/qa/unit/ucalc.cxx | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) New commits: commit c64570164e3c8161fa28368d609b7b7bdc039811 Author: Laurent Godard lgodard.li...@laposte.net Date: Mon Sep 23 10:17:42 2013 +0200 enhance transposed copy/paste unit test Change-Id: Ie0819a2af45e658430f8bb35bbbe7138582dafab diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index d34d2c9..e5ef868 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -3000,7 +3000,7 @@ void Test::testCopyPasteTranspose() m_pDoc-InsertTab(1, OUString(Sheet2)); m_pDoc-SetValue(0, 0, 0, 1); -m_pDoc-SetValue(1, 0, 0, 2); +m_pDoc-SetString(1, 0, 0, OUString(=A1+1)); m_pDoc-SetString(2, 0, 0, OUString(test)); // add notes to A1:C1 @@ -3031,27 +3031,30 @@ void Test::testCopyPasteTranspose() ScRange aDestRange = ScRange(3,1,1,3,3,1);//target: Sheet2.D2:D4 ScMarkData aMark; -aMark.SetMarkArea(aSrcRange); +aMark.SetMarkArea(aDestRange); m_pDoc-CopyFromClip(aDestRange, aMark, IDF_ALL, NULL, pTransposedClip); -//check values after transposed copy/paste -/* +//check cell content after transposed copy/paste OUString aString = m_pDoc-GetString(3, 3, 1); -CPPUNIT_ASSERT_MESSAGE(Cell Sheet3.D4 should contain: test, aString.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(test))); +CPPUNIT_ASSERT_MESSAGE(Cell Sheet2.D4 should contain: test, aString.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(test))); +double fValue = m_pDoc-GetValue(ScAddress(3,1,1)); +ASSERT_DOUBLES_EQUAL_MESSAGE(transposed copied cell should return 1, fValue, 1); +fValue = m_pDoc-GetValue(ScAddress(3,2,1)); +ASSERT_DOUBLES_EQUAL_MESSAGE(transposed copied formula should return 2, fValue, 2); +m_pDoc-GetFormula(3, 2, 1, aString); +CPPUNIT_ASSERT_MESSAGE(transposed formula should point on Sheet2.D2, aString.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(=D2+1))); // check notes after transposed copy/paste CPPUNIT_ASSERT_MESSAGE(There should be a note on Sheet2.D2, m_pDoc-HasNote(ScAddress(3, 1, 1))); CPPUNIT_ASSERT_MESSAGE(There should be a note on Sheet2.D3, m_pDoc-HasNote(ScAddress(3, 2, 1))); CPPUNIT_ASSERT_MESSAGE(There should be a note on Sheet2.D4, m_pDoc-HasNote(ScAddress(3, 3, 1))); +CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D2, +m_pDoc-GetNote(ScAddress(3, 1, 1))-GetText() == m_pDoc-GetNote(ScAddress(0, 0, 0))-GetText()); +CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D3, +m_pDoc-GetNote(ScAddress(3, 2, 1))-GetText() == m_pDoc-GetNote(ScAddress(1, 0, 0))-GetText()); +CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D2, +m_pDoc-GetNote(ScAddress(3, 3, 1))-GetText() == m_pDoc-GetNote(ScAddress(2, 0, 0))-GetText()); - -double fValue = m_pDoc-GetValue(ScAddress(3,1,1)); -m_pDoc-GetFormula(3,1,1, aString); -ASSERT_DOUBLES_EQUAL_MESSAGE(transposed copied formula should return 2, fValue, 2); - // CPPUNIT_ASSERT_MESSAGE(transposed formula string was not copied correctly, aString == aFormulaString); -fValue = m_pDoc-GetValue(ScAddress(3,2,1)); -CPPUNIT_ASSERT_MESSAGE(transposed copied value should be 1, fValue == 1); -*/ m_pDoc-DeleteTab(1); m_pDoc-DeleteTab(0); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/sc-notes-storage' - sc/qa
sc/qa/unit/ucalc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d2a8d41c702213d6b4a6b11c05f06572191245fd Author: Laurent Godard lgodard.li...@laposte.net Date: Mon Sep 23 10:20:10 2013 +0200 minor typo in transpose clipboard unit test Change-Id: If042fc3f72f5afe50b7d91d274b77f4b5dc53fab diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index e5ef868..4ae5732 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -3052,7 +3052,7 @@ void Test::testCopyPasteTranspose() m_pDoc-GetNote(ScAddress(3, 1, 1))-GetText() == m_pDoc-GetNote(ScAddress(0, 0, 0))-GetText()); CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D3, m_pDoc-GetNote(ScAddress(3, 2, 1))-GetText() == m_pDoc-GetNote(ScAddress(1, 0, 0))-GetText()); -CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D2, +CPPUNIT_ASSERT_MESSAGE(Content of cell note on Sheet2.D4, m_pDoc-GetNote(ScAddress(3, 3, 1))-GetText() == m_pDoc-GetNote(ScAddress(2, 0, 0))-GetText()); m_pDoc-DeleteTab(1); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: About SwTable::CheckConsistency() (sw module)
Hi Julien, julien2412 píše v So 21. 09. 2013 v 03:55 -0700: I noticed some weird things in SwTable::CheckConsistency(), eg: 2102 std::list RowSpanCheck aRowSpanCells; 2103 std::list RowSpanCheck ::iterator aIter = aRowSpanCells.end(); then I see ++aIter several times some lines later. How can it work since: aRowSpanCells isn't initialized aIter is at the end of aRowSpanCells ? The code is curious, so I'll just quickly answer without studying it deeply :-) - I guess during the first pass the ++aIter is not accessed at all. Then at the end of the 1st pass, it is initialized (aIter = aRowSpanCells.begin(); at the end), and the we can do ++aIter as we want... Just nitpicking but I think that this part: 2128 std::list RowSpanCheck ::iterator aEraseIter = aIter; 2129 ++aIter; 2130 aRowSpanCells.erase( aEraseIter ); could be replaced by: aIter = aRowSpanCells.erase(aIter); since erase returns an iterator even before C++11 standard (see http://www.cplusplus.com/reference/list/list/erase/) Could work - but as I did not look well enough at this code, please don't take it as 'go ahead clean it up' :-) - some checking of the history of that file could give you more clues about that I guess. Thanks for looking into this! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: idl/Executable_svidl.mk rsc/Executable_rsc.mk
idl/Executable_svidl.mk |5 + rsc/Executable_rsc.mk |6 ++ 2 files changed, 11 insertions(+) New commits: commit 4dd261e526f43a364c645e7022c49b61c8001a39 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 11:25:00 2013 +0300 More ICU dependencies that are now dragged in Change-Id: Iec214399f0cd8d5af198ad9080c55e5ee51a353d diff --git a/idl/Executable_svidl.mk b/idl/Executable_svidl.mk index b2b3ecd..c3c52a4 100644 --- a/idl/Executable_svidl.mk +++ b/idl/Executable_svidl.mk @@ -34,6 +34,11 @@ $(eval $(call gb_Executable_use_libraries,svidl,\ $(gb_UWINAPI) \ )) +$(eval $(call gb_Executable_use_externals,svidl,\ +icudata \ +icuuc \ +icui18n \ +)) $(eval $(call gb_Executable_add_exception_objects,svidl,\ idl/source/cmptools/hash \ idl/source/cmptools/lex \ diff --git a/rsc/Executable_rsc.mk b/rsc/Executable_rsc.mk index ed779e6..aab0322 100644 --- a/rsc/Executable_rsc.mk +++ b/rsc/Executable_rsc.mk @@ -30,6 +30,12 @@ $(eval $(call gb_Executable_use_libraries,rsc,\ $(gb_UWINAPI) \ )) +$(eval $(call gb_Executable_use_externals,rsc,\ +icudata \ +icuuc \ +icui18n \ +)) + $(eval $(call gb_Executable_add_grammars,rsc,\ rsc/source/parser/rscyacc \ )) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/rtfexport/data/fdo66743.rtf |5 + sw/qa/extras/rtfexport/rtfexport.cxx | 10 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |4 ++-- 3 files changed, 17 insertions(+), 2 deletions(-) New commits: commit 21e07d473d1ce995ca0f1d0ac0edb03e75a7dfc1 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Sep 23 10:05:53 2013 +0200 fdo#66743 fix import of some RTF_CLSHDNG values This should be in sync with model.xml, got broken when the somewhat random values got fixed to be the same as the ones which are in the ww8 spec. (Regression from 26d40686128e70916a636e20f5ccc5763bbb6cc8.) Change-Id: Id62047e0b2d5d8402a7c8bce95de487afe627e32 diff --git a/sw/qa/extras/rtfexport/data/fdo66743.rtf b/sw/qa/extras/rtfexport/data/fdo66743.rtf new file mode 100644 index 000..81ffc77 --- /dev/null +++ b/sw/qa/extras/rtfexport/data/fdo66743.rtf @@ -0,0 +1,5 @@ +{\rtf1 +\trowd \clshdng1500\cellx4000 +\pard\plain A1\cell\row +\pard\par +} diff --git a/sw/qa/extras/rtfexport/rtfexport.cxx b/sw/qa/extras/rtfexport/rtfexport.cxx index 64eb1be..1951ddb 100644 --- a/sw/qa/extras/rtfexport/rtfexport.cxx +++ b/sw/qa/extras/rtfexport/rtfexport.cxx @@ -69,6 +69,7 @@ public: void testFdo66682(); void testParaShadow(); void testCharacterBorder(); +void testFdo66743(); CPPUNIT_TEST_SUITE(Test); #if !defined(MACOSX) !defined(WNT) @@ -127,6 +128,7 @@ void Test::run() {fdo66682.rtf, Test::testFdo66682}, {para-shadow.rtf, Test::testParaShadow}, {charborder.odt, Test::testCharacterBorder}, +{fdo66743.rtf, Test::testFdo66743}, }; // Don't test the first import of these, for some reason those tests fail const char* aBlacklist[] = { @@ -673,6 +675,14 @@ void Test::testCharacterBorder() } } +void Test::testFdo66743() +{ +uno::Referencetext::XTextTable xTable(getParagraphOrTable(1), uno::UNO_QUERY); +uno::Referencetable::XCell xCell = xTable-getCellByName(A1); +// This was too dark, 0x7f7f7f. +CPPUNIT_ASSERT_EQUAL(sal_Int32(0xd8d8d8), getPropertysal_Int32(xCell, BackColor)); +} + CPPUNIT_TEST_SUITE_REGISTRATION(Test); CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx index d73c5bd..d3614b9 100644 --- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx +++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx @@ -3564,8 +3564,8 @@ int RTFDocumentImpl::dispatchValue(RTFKeyword nKeyword, int nParam) { case 500: nValue = 2; break; case 1000: nValue = 3; break; -case 1200: nValue = 27; break; -case 1500: nValue = 28; break; +case 1200: nValue = 37; break; +case 1500: nValue = 38; break; case 2000: nValue = 4; break; case 2500: nValue = 5; break; case 3000: nValue = 6; break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5da2821ccbfbbe2c3486ca8571c4298adc439364 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 12:11:07 2013 +0300 Thinko Change-Id: I31e1c7a7f0017abe6d4e45f32ea4aad6545cffe1 diff --git a/configure.ac b/configure.ac index c9aa112..13f4e69 100644 --- a/configure.ac +++ b/configure.ac @@ -492,7 +492,7 @@ darwin*) # Mac OS X or iOS test_cups=no else _os=Darwin -INSTROOTSUFFIX=/$(PRODUCTNAME).app/Contents +INSTROOTSUFFIX=/$PRODUCTNAME.app/Contents fi enable_systray=no # See comment above the case $host_os ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/solaris.mk |2 +- solenv/gbuild/platform/unxgcc.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 2292b3cd8d9a06b2f073b945b228dd7894955b09 Author: Michael Stahl mst...@redhat.com Date: Mon Sep 23 12:09:51 2013 +0200 gbuild: try to fix linking with default --as-needed As reported by Jbfaure, linking npsoplugin library fails on Ubuntu because of unresolved libdl symbols from a StaticLibrary. It turns out that --start-group/--end-group only affects static libraries, so reorder the link command again to put the StaticLibrary first. (regression from f861ae6acdbde8acc9560366d344852391d17b8d) Change-Id: Icd31faace8bf7764fee97cd93c3ecd0caad85947 diff --git a/solenv/gbuild/platform/solaris.mk b/solenv/gbuild/platform/solaris.mk index 7603be4..b9ad99d 100644 --- a/solenv/gbuild/platform/solaris.mk +++ b/solenv/gbuild/platform/solaris.mk @@ -179,9 +179,9 @@ $(call gb_Helper_abbreviate_dirs,\ $(foreach object,$(GENCXXOBJECTS),$(call gb_GenCxxObject_get_target,$(object))) \ $(foreach extraobjectlist,$(EXTRAOBJECTLISTS),`cat $(extraobjectlist)`) \ -Wl$(COMMA)--start-group \ - $(T_LIBS) \ $(foreach lib,$(LINKED_STATIC_LIBS),\ $(call gb_StaticLibrary_get_target,$(lib))) \ + $(T_LIBS) \ -Wl$(COMMA)--end-group \ -Wl$(COMMA)--no-as-needed \ $(patsubst lib%.a,-l%,$(patsubst lib%.so,-l%,$(patsubst %.$(gb_Library_UDK_MAJORVER),%,$(foreach lib,$(LINKED_LIBS),$(call gb_Library_get_filename,$(lib)) \ diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index 54ef904..bda7cfa 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -181,9 +181,9 @@ $(call gb_Helper_abbreviate_dirs,\ $(foreach object,$(GENCXXOBJECTS),$(call gb_GenCxxObject_get_target,$(object))) \ $(foreach extraobjectlist,$(EXTRAOBJECTLISTS),`cat $(extraobjectlist)`) \ -Wl$(COMMA)--start-group \ - $(T_LIBS) \ $(foreach lib,$(LINKED_STATIC_LIBS),\ $(call gb_StaticLibrary_get_target,$(lib))) \ + $(T_LIBS) \ -Wl$(COMMA)--end-group \ -Wl$(COMMA)--no-as-needed \ $(patsubst lib%.a,-l%,$(patsubst lib%.so,-l%,$(patsubst %.$(gb_Library_UDK_MAJORVER),%,$(foreach lib,$(LINKED_LIBS),$(call gb_Library_get_filename,$(lib)) \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Deployment exception and how to solve them.
Hi guys, Just now I'm working in a unit test for sw/CppunitTest_sw_ooxmlimport.mk in which I'm adding the request for a GraphicExportFilter which results in the Deployment Exception: component context fails to supply service com.sun.star.drawing.GraphicExportFilter of type com.sun.star.drawing.XGraphicExportFilter I've added graphicfilter to the _use_library section and also the following component to the _use_component section: filter/source/graphic/graphicfilter But the Deployment Exception has not disappeared. Any tip on how to solve this problem? Br. -- Andres Gomez Computer Science Engineer mailto:ago...@igalia.com http://blogs.igalia.com/agomez/category/igaliacom/ IGALIA, S.L. http://www.igalia.com signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Deployment exception and how to solve them.
On 09/23/2013 12:48 PM, Andres Gomez wrote: Just now I'm working in a unit test for sw/CppunitTest_sw_ooxmlimport.mk in which I'm adding the request for a GraphicExportFilter which results in the Deployment Exception: component context fails to supply service com.sun.star.drawing.GraphicExportFilter of type com.sun.star.drawing.XGraphicExportFilter I've added graphicfilter to the _use_library section and also the following component to the _use_component section: filter/source/graphic/graphicfilter But the Deployment Exception has not disappeared. Any tip on how to solve this problem? git grep -Flw com.sun.star.drawing.GraphicExportFilter -- \*.component shows that that service is registered in svx/util/svx.component, so you need to add svx/util/svx to the gb_CppunitTest_use_components list. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Deployment exception and how to solve them.
Hey, 2013/9/23 Andres Gomez ago...@igalia.com Hi guys, Just now I'm working in a unit test for sw/CppunitTest_sw_ooxmlimport.mk in which I'm adding the request for a GraphicExportFilter which results in the Deployment Exception: component context fails to supply service com.sun.star.drawing.GraphicExportFilter of type com.sun.star.drawing.XGraphicExportFilter I've added graphicfilter to the _use_library section and also the following component to the _use_component section: filter/source/graphic/graphicfilter You should replace this entry in the _use_component section with: svx/util/ http://opengrok.libreoffice.org/xref/core/svx/util/svx \ Finding out which entry to add for the use_components is quite easy. Go to opengrok/git grep and search for the service name and add the *.component file that mentions the service. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/hsqldb/HDriver.cxx |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) New commits: commit 85d1ee4f1c5a47105fc3a447c7f8a45cbd147ec0 Author: Andrzej J.R. Hunt andr...@ahunt.org Date: Mon Sep 16 11:07:36 2013 +0100 Use LO_JAVA_DIR for HSQLDB classpath. This is needed to allow usage of HSQLDB in a unit test in solver (in conjunction with the following patch which adds LO_JAVA_DIR to solver's unorc). Change-Id: Ia3757b61d4ba0b2353e0d33290938cea40551d3a Signed-off-by: Stephan Bergmann sberg...@redhat.com diff --git a/connectivity/source/drivers/hsqldb/HDriver.cxx b/connectivity/source/drivers/hsqldb/HDriver.cxx index f916658..f0ca4ef 100644 --- a/connectivity/source/drivers/hsqldb/HDriver.cxx +++ b/connectivity/source/drivers/hsqldb/HDriver.cxx @@ -235,11 +235,10 @@ namespace connectivity OUString( #ifdef SYSTEM_HSQLDB HSQLDB_JAR - vnd.sun.star.expand:$BRAND_BASE_DIR/ LIBO_SHARE_JAVA_FOLDER /sdbc_hsqldb.jar #else -vnd.sun.star.expand:$BRAND_BASE_DIR/ LIBO_SHARE_JAVA_FOLDER /hsqldb.jar - vnd.sun.star.expand:$BRAND_BASE_DIR/ LIBO_SHARE_JAVA_FOLDER /sdbc_hsqldb.jar +vnd.sun.star.expand:$LO_JAVA_DIR/hsqldb.jar #endif + vnd.sun.star.expand:$LO_JAVA_DIR/sdbc_hsqldb.jar ) ); // auto increment handling ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Deployment exception and how to solve them.
Ouch! So I added the wrong component assuming it would be in the same source tree instead of checking that it was actually providing the service. Thanks guys, it works like a charm! Br. On Mon, 2013-09-23 at 13:59 +0200, Markus Mohrhard wrote: Hey, 2013/9/23 Andres Gomez ago...@igalia.com Hi guys, Just now I'm working in a unit test for sw/CppunitTest_sw_ooxmlimport.mk in which I'm adding the request for a GraphicExportFilter which results in the Deployment Exception: component context fails to supply service com.sun.star.drawing.GraphicExportFilter of type com.sun.star.drawing.XGraphicExportFilter I've added graphicfilter to the _use_library section and also the following component to the _use_component section: filter/source/graphic/graphicfilter You should replace this entry in the _use_component section with: svx/util/ http://opengrok.libreoffice.org/xref/core/svx/util/svx \ Finding out which entry to add for the use_components is quite easy. Go to opengrok/git grep and search for the service name and add the *.component file that mentions the service. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Andres Gomez Computer Science Engineer mailto:ago...@igalia.com http://blogs.igalia.com/agomez/category/igaliacom/ IGALIA, S.L. http://www.igalia.com signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dictionaries.git: sr/dictionaries.xcu
sr/dictionaries.xcu |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit fb0e2de0bafbac018f65bddcbcd23481af959156 Author: Eike Rathke er...@redhat.com Date: Mon Sep 23 14:32:54 2013 +0200 removed *-ME and *-BA not supported by the dictionary As requested per mail from Goran Rakic: It may be better to remove sr-*-ME and sr-*-BA from libreoffice/dictionaries/sr/dictionaries.xcu as they are not supported by the dictionary/hyphenation. This dictionary standardizes on ekavian dialect, as it is commonly spoken in Serbia, while speakers of Serbian language in Bosnia or Montenegro would use the ijekavian dialect. Change-Id: If1cff670beb79b75318ad52e05b77a1fde3d5d74 diff --git a/sr/dictionaries.xcu b/sr/dictionaries.xcu index d05980f..b01ebd0 100644 --- a/sr/dictionaries.xcu +++ b/sr/dictionaries.xcu @@ -10,7 +10,7 @@ valueDICT_SPELL/value /prop prop oor:name=Locales oor:type=oor:string-list -valuesr-RS sr-ME sr-BA sr-CS/value +valuesr-RS sr-CS/value /prop /node node oor:name=HunSpellDic_sr_Latn oor:op=fuse @@ -21,7 +21,7 @@ valueDICT_SPELL/value /prop prop oor:name=Locales oor:type=oor:string-list -valuesr-Latn-RS sr-Latn-ME sr-Latn-BA sr-Latn-CS/value +valuesr-Latn-RS sr-Latn-CS/value /prop /node node oor:name=HyphDic_sr oor:op=fuse @@ -32,7 +32,7 @@ valueDICT_HYPH/value /prop prop oor:name=Locales oor:type=oor:string-list -valuesr-RS sr-ME sr-BA sr-CS/value +valuesr-RS sr-CS/value /prop /node node oor:name=HyphDic_sr_Latn oor:op=fuse @@ -43,7 +43,7 @@ valueDICT_HYPH/value /prop prop oor:name=Locales oor:type=oor:string-list -valuesr-Latn-RS sr-Latn-ME sr-Latn-BA sr-Latn-CS/value +valuesr-Latn-RS sr-Latn-CS/value /prop /node /node ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3f516cc112599c7e55672a178a62081b70fa91ef Author: Eike Rathke er...@redhat.com Date: Mon Sep 23 14:32:54 2013 +0200 Updated core Project: dictionaries fb0e2de0bafbac018f65bddcbcd23481af959156 diff --git a/dictionaries b/dictionaries index a32a341..fb0e2de 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit a32a341efdbb9e53a7b832262a41f6fb6454bedf +Subproject commit fb0e2de0bafbac018f65bddcbcd23481af959156 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cli_ure/Package_cli_basetypes_copy.mk config_host.mk.in configure.ac odk/CustomTarget_allheaders.mk odk/CustomTarget_check.mk odk/CustomTarget_doxygen.mk odk/GeneratedP
cli_ure/Package_cli_basetypes_copy.mk |2 config_host.mk.in |2 configure.ac | 112 +++-- odk/CustomTarget_allheaders.mk |2 odk/CustomTarget_check.mk |2 odk/CustomTarget_doxygen.mk|2 odk/GeneratedPackage_odk_doxygen.mk|4 - odk/GeneratedPackage_uno_loader_classes.mk |2 odk/Package_cli.mk |2 odk/Package_config.mk |4 - odk/Package_config_notwin.mk |2 odk/Package_config_win.mk |2 odk/Package_docs.mk|2 odk/Package_examples.mk|2 odk/Package_html.mk|2 odk/Package_javadoc.mk |2 odk/Package_lib.mk |2 odk/Package_odk_headers.mk |2 odk/Package_odk_headers_generated.mk |2 odk/Package_settings.mk|2 odk/Package_settings_generated.mk |2 odk/Package_share_readme.mk|2 odk/Package_unowinreg.mk |2 solenv/gbuild/Executable.mk|4 - solenv/gbuild/Library.mk |2 solenv/gbuild/Package.mk |3 solenv/gbuild/TargetLocations.mk |2 solenv/gbuild/UnoApi.mk|2 solenv/gbuild/platform/IOS_ARM_GCC.mk |9 -- solenv/gbuild/platform/com_GCC_class.mk|2 solenv/gbuild/platform/com_MSC_class.mk|5 - solenv/gbuild/platform/macosx.mk |3 solenv/gbuild/platform/mingw.mk|3 solenv/gbuild/platform/solaris.mk |3 solenv/gbuild/platform/unxgcc.mk |3 35 files changed, 94 insertions(+), 107 deletions(-) New commits: commit 0618b35ebda29b911058254cd34620e8b24ab8f7 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 15:34:26 2013 +0300 Fixes for cross-compilation on OS X (to iOS) Introduce SDKDIRNAME as a configury variable and use it instead of the gbuild gb_Package_SDKDIRNAME. Then we can easily construct the SDKDIRNAME_FOR_BUILD variant that is needed to find the specially named SDK in instdir on OS X when cross-compiling. Move the version number section in configure.ac earlier. Change-Id: Iee3db1a50ad4c7a9f91bbc5e0d0b01d76a76f701 diff --git a/cli_ure/Package_cli_basetypes_copy.mk b/cli_ure/Package_cli_basetypes_copy.mk index fdb76be..b0824e3 100644 --- a/cli_ure/Package_cli_basetypes_copy.mk +++ b/cli_ure/Package_cli_basetypes_copy.mk @@ -13,7 +13,7 @@ $(eval $(call gb_Package_Package,cli_basetypes_copy,$(WORKDIR))) $(eval $(call gb_Package_set_outdir,cli_basetypes_copy,$(INSTDIR))) # duplicate copy to work around CLR DLL finding brain damage -$(eval $(call gb_Package_add_files,cli_basetypes_copy,$(gb_Package_SDKDIRNAME)/bin,\ +$(eval $(call gb_Package_add_files,cli_basetypes_copy,$(SDKDIRNAME)/bin,\ CliLibraryTarget/cli_basetypes.dll \ )) diff --git a/config_host.mk.in b/config_host.mk.in index 567c8b1..3b58d66 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -463,6 +463,8 @@ export RTL_OS=@RTL_OS@ export SAC_JAR=@SAC_JAR@ export SAL_ENABLE_FILE_LOCKING=1 export SCPDEFS=@SCPDEFS@ +export SDKDIRNAME=@SDKDIRNAME@ +export SDKDIRNAME_FOR_BUILD=@SDKDIRNAME_FOR_BUILD@ export SERVLETAPI_JAR=@SERVLETAPI_JAR@ export SHOWINCLUDES_PREFIX=@SHOWINCLUDES_PREFIX@ export SOLARENV=@SRC_ROOT@/solenv diff --git a/configure.ac b/configure.ac index 13f4e69..1f3ea9b 100644 --- a/configure.ac +++ b/configure.ac @@ -99,6 +99,57 @@ fi AC_MSG_RESULT([$PRODUCTNAME]) AC_SUBST(PRODUCTNAME) +dnl === +dnl Our version is defined by the AC_INIT() at the top of this script. +dnl === + +set `echo AC_PACKAGE_VERSION | sed s/\./ /g` + +LIBO_VERSION_MAJOR=$1 +LIBO_VERSION_MINOR=$2 +LIBO_VERSION_MICRO=$3 +LIBO_VERSION_PATCH=$4 + +LIBO_VERSION_SUFFIX=$5 +# Split out LIBO_VERSION_SUFFIX_SUFFIX... horrible crack. But apparently wanted separately in +# openoffice.lst as ABOUTBOXPRODUCTVERSIONSUFFIX. Note that the double brackets are for m4's sake, +# they get undoubled before actually passed to sed. +LIBO_VERSION_SUFFIX_SUFFIX=`echo $LIBO_VERSION_SUFFIX | sed -e 's/.*[[a-zA-Z0-9]]\([[^a-zA-Z0-9]]*\)$/\1/'` +test -n $LIBO_VERSION_SUFFIX_SUFFIX LIBO_VERSION_SUFFIX=${LIBO_VERSION_SUFFIX%${LIBO_VERSION_SUFFIX_SUFFIX}} +# LIBO_VERSION_SUFFIX, if non-empty, should include the period separator +test -n $LIBO_VERSION_SUFFIX LIBO_VERSION_SUFFIX=.$LIBO_VERSION_SUFFIX + +AC_SUBST(LIBO_VERSION_MAJOR) +AC_SUBST(LIBO_VERSION_MINOR) +AC_SUBST(LIBO_VERSION_MICRO) +AC_SUBST(LIBO_VERSION_PATCH) +AC_SUBST(LIBO_VERSION_SUFFIX) +AC_SUBST(LIBO_VERSION_SUFFIX_SUFFIX) +
[Libreoffice-commits] core.git: include/sfx2 offapi/com offapi/UnoApi_offapi.mk sfx2/source sfx2/uiconfig sfx2/UIConfig_sfx.mk ucb/source
include/sfx2/objsh.hxx |2 include/sfx2/sfxbasemodel.hxx |4 offapi/UnoApi_offapi.mk|1 offapi/com/sun/star/document/CmisVersion.idl | 52 +++ offapi/com/sun/star/document/XCmisDocument.idl |3 sfx2/UIConfig_sfx.mk |1 sfx2/source/dialog/versdlg.cxx | 111 sfx2/source/doc/objserv.cxx| 15 + sfx2/source/doc/sfxbasemodel.cxx | 23 + sfx2/source/inc/versdlg.hxx| 24 + sfx2/uiconfig/ui/versionscmis.ui | 340 + sfx2/uiconfig/ui/versionsofdialog.ui | 16 + ucb/source/ucp/cmis/cmis_content.cxx | 47 +++ ucb/source/ucp/cmis/cmis_content.hxx |5 14 files changed, 642 insertions(+), 2 deletions(-) New commits: commit b61970cfbe12722efd6218db6489980381b8783d Author: Cao Cuong Ngo cao.cuong@gmail.com Date: Thu Sep 12 15:27:37 2013 +0200 Cmis Versions dialog Change-Id: Ie863282062a6932a55543143e841917c54223ac9 Reviewed-on: https://gerrit.libreoffice.org/5925 Reviewed-by: Bosdonnat Cedric cedric.bosdon...@free.fr Tested-by: Bosdonnat Cedric cedric.bosdon...@free.fr diff --git a/include/sfx2/objsh.hxx b/include/sfx2/objsh.hxx index 4d530d9..ee2ff12 100644 --- a/include/sfx2/objsh.hxx +++ b/include/sfx2/objsh.hxx @@ -37,6 +37,7 @@ #include com/sun/star/security/XDocumentDigitalSignatures.hpp #include com/sun/star/task/XInteractionHandler.hpp #include com/sun/star/beans/XPropertySet.hpp +#include com/sun/star/document/CmisVersion.hpp #include boost/shared_ptr.hpp // @@ -714,6 +715,7 @@ public: SAL_DLLPRIVATE void CheckOut( ); SAL_DLLPRIVATE void CancelCheckOut( ); SAL_DLLPRIVATE void CheckIn( ); +SAL_DLLPRIVATE ::com::sun::star::uno::Sequence ::com::sun::star::document::CmisVersion GetCmisVersions(); }; #define SFX_GLOBAL_CLASSID \ diff --git a/include/sfx2/sfxbasemodel.hxx b/include/sfx2/sfxbasemodel.hxx index 084a0f3..fde9aa0 100644 --- a/include/sfx2/sfxbasemodel.hxx +++ b/include/sfx2/sfxbasemodel.hxx @@ -33,6 +33,7 @@ #include com/sun/star/container/XNameReplace.hpp #include com/sun/star/frame/XController2.hpp #include com/sun/star/document/XCmisDocument.hpp +#include com/sun/star/document/CmisVersion.hpp #include com/sun/star/document/XDocumentPropertiesSupplier.hpp #include com/sun/star/document/XDocumentRecovery.hpp #include com/sun/star/document/XUndoManagerSupplier.hpp @@ -1321,6 +1322,9 @@ public: css::document::CmisProperty _cmisproperties ) throw (css::uno::RuntimeException); +virtual css::uno::Sequence css::document::CmisVersion SAL_CALL getAllVersions ( ) +throw (css::uno::RuntimeException ); + virtual void SAL_CALL checkOut( ) throw ( css::uno::RuntimeException ); virtual void SAL_CALL cancelCheckOut( ) throw ( css::uno::RuntimeException ); virtual void SAL_CALL checkIn( sal_Bool bIsMajor, const OUString rMessage ) diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk index be91841..c97bf41 100644 --- a/offapi/UnoApi_offapi.mk +++ b/offapi/UnoApi_offapi.mk @@ -2160,6 +2160,7 @@ $(eval $(call gb_UnoApi_add_idlfiles,offapi,com/sun/star/document,\ BrokenPackageRequest \ ChangedByOthersRequest \ CmisProperty \ + CmisVersion \ CorruptedFilterConfigurationException \ DocumentEvent \ EmptyUndoStackException \ diff --git a/offapi/com/sun/star/document/CmisVersion.idl b/offapi/com/sun/star/document/CmisVersion.idl new file mode 100644 index 000..8171283 --- /dev/null +++ b/offapi/com/sun/star/document/CmisVersion.idl @@ -0,0 +1,52 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ +#ifndef __com_sun_star_document_CmisVersion_idl__ +#define __com_sun_star_document_CmisVersion_idl__ + +#include com/sun/star/util/DateTime.idl + +module com { module sun { module star { module
[Libreoffice-commits] core.git: i18nlangtag/README
i18nlangtag/README |9 + 1 file changed, 9 insertions(+) New commits: commit 77caa26a3a3101b4aa55523c2322e58f842755d1 Author: Eike Rathke er...@redhat.com Date: Mon Sep 23 15:03:19 2013 +0200 added scp2/**/*.ulf to description of replacements Change-Id: I841e3df0900735bc7b6de78bca3a5dbbb3902af5 diff --git a/i18nlangtag/README b/i18nlangtag/README index 7ae0de4..fd5cda5 100644 --- a/i18nlangtag/README +++ b/i18nlangtag/README @@ -88,3 +88,12 @@ If helpcontent exists: * helpcontent2/source/auxiliary/*/* for example helpcontent2/source/auxiliary/sh/* ** change Language=..., for example Language=sh to Language=sr-Latn in helpcontent2/source/auxiliary/sh/*.cfg ** rename helpcontent2/source/auxiliary/sh/ git mv sh sr-Latn + +For language packs: + +* scp2/source/ooo/module_langpack.ulf +* scp2/source/accessories/module_templates_accessories.ulf +* scp2/source/accessories/module_samples_accessories.ulf +* scp2/source/extensions/module_extensions_sun_templates.ulf + +** If the upper-cased tag appears in any of these, replace it, for example STR_NAME_MODULE_LANGPACK_SH to STR_NAME_MODULE_LANGPACK_SR_LATN ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: scp2/source
scp2/source/accessories/module_samples_accessories.ulf |8 scp2/source/accessories/module_templates_accessories.ulf |8 scp2/source/ooo/module_langpack.ulf |8 3 files changed, 12 insertions(+), 12 deletions(-) New commits: commit 0ba0491e9aff8037772d3115d874d0950c2256a3 Author: Eike Rathke er...@redhat.com Date: Mon Sep 23 15:12:46 2013 +0200 ca-valencia and sr-Latn replacements Change-Id: Ifd0ede6d06ff979175ab3a7193c34d6248f41f7b diff --git a/scp2/source/accessories/module_samples_accessories.ulf b/scp2/source/accessories/module_samples_accessories.ulf index dd1a504..36811b1 100644 --- a/scp2/source/accessories/module_samples_accessories.ulf +++ b/scp2/source/accessories/module_samples_accessories.ulf @@ -474,16 +474,16 @@ en-US = Galician [STR_DESC_MODULE_LANGPACK_GL] en-US = Installs Galician support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SH_YU] +[STR_NAME_MODULE_LANGPACK_SR_LATN_CS] en-US = Serbian (Latin) -[STR_DESC_MODULE_LANGPACK_SH_YU] +[STR_DESC_MODULE_LANGPACK_SR_LATN_CS] en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SH] +[STR_NAME_MODULE_LANGPACK_SR_LATN] en-US = Serbian (Latin) -[STR_DESC_MODULE_LANGPACK_SH] +[STR_DESC_MODULE_LANGPACK_SR_LATN] en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION [STR_NAME_MODULE_LANGPACK_GA] diff --git a/scp2/source/accessories/module_templates_accessories.ulf b/scp2/source/accessories/module_templates_accessories.ulf index 44635cd..ae0803a 100644 --- a/scp2/source/accessories/module_templates_accessories.ulf +++ b/scp2/source/accessories/module_templates_accessories.ulf @@ -469,16 +469,16 @@ en-US = Galician [STR_DESC_MODULE_LANGPACK_GL] en-US = Installs Galician support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SH_YU] +[STR_NAME_MODULE_LANGPACK_SR_LATN_CS] en-US = Serbian (Latin) -[STR_DESC_MODULE_LANGPACK_SH_YU] +[STR_DESC_MODULE_LANGPACK_SR_LATN_CS] en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SH] +[STR_NAME_MODULE_LANGPACK_SR_LATN] en-US = Serbian (Latin) -[STR_DESC_MODULE_LANGPACK_SH] +[STR_DESC_MODULE_LANGPACK_SR_LATN] en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION [STR_NAME_MODULE_LANGPACK_GA] diff --git a/scp2/source/ooo/module_langpack.ulf b/scp2/source/ooo/module_langpack.ulf index d190031..cbe6a93 100644 --- a/scp2/source/ooo/module_langpack.ulf +++ b/scp2/source/ooo/module_langpack.ulf @@ -292,10 +292,10 @@ en-US = Catalan [STR_DESC_MODULE_LANGPACK_CA] en-US = Installs the Catalan user interface -[STR_NAME_MODULE_LANGPACK_CA_XV] +[STR_NAME_MODULE_LANGPACK_CA_VALENCIA] en-US = Catalan (Valencian) -[STR_DESC_MODULE_LANGPACK_CA_XV] +[STR_DESC_MODULE_LANGPACK_CA_VALENCIA] en-US = Installs the Catalan (Valencian) user interface [STR_NAME_MODULE_LANGPACK_DA] @@ -406,10 +406,10 @@ en-US = Galician [STR_DESC_MODULE_LANGPACK_GL] en-US = Installs the Galician user interface -[STR_NAME_MODULE_LANGPACK_SH] +[STR_NAME_MODULE_LANGPACK_SR_LATN] en-US = Serbian (Latin) -[STR_DESC_MODULE_LANGPACK_SH] +[STR_DESC_MODULE_LANGPACK_SR_LATN] en-US = Installs the Serbian (Latin) user interface [STR_NAME_MODULE_LANGPACK_GA] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: HSQLDB / Unit tests
On 09/23/2013 09:19 AM, Andrzej Hunt wrote: I'm trying to get HSQLDB unit tests to run in a CppunitTest -- whilst still in solver I added some paths locally to solver's unorc (which worked fine, but not a great solution) -- now that we're running unit tests in instdir I'd like some sort of permanent solution. (The reason I want to use a CppUnitTest is that ideally we want to run exactly the same tests on Firebird and HSQLDB, and since that also allows for performance comparisons.) HSQLDB's classpath is hardcoded in HDriver.cxx as: vnd.sun.star.expand:$BRAND_BASE_DIR/ LIBO_SHARE_JAVA_FOLDER /hsqldb.jar As a first step I'd like to make this: vnd.sun.star.expand:$LO_JAVA_DIR/hsqldb.jar Either of these work when running LO normally, the latter is cleaner and seems much more correct. (Patch is in gerrit, but outdated commit comment now that we're in instdir -- https://gerrit.libreoffice.org/#/c/5953/ ). The patch is just fine in itself anyway, so I pushed it now. However neither of these work for unit tests: BRAND_BASE_DIR and LO_JAVA_DIR are both set in fundamentalrc, which doesn't seem to be used when running unit tests. It also looks like when running unit tests only the ure/lib/unorc is used -- I'm not entirely sure how to procede here -- using LO_JAVA_DIR within HSQLDB setting LO_JAVA_DIR=${ORIGIN}/../../program/classes works, but is that the desired way of doing things (adjusted by using scp2 I guess to work on all systems)? There are two things that tie all the bootstrap variables together: The first is the uno{.ini,rc} file next to the cppuhelper dynamic library, automatically read by the default, no-argument cppu::defaultBootstrap_InitialComponentContext (cppuhelper/source/defaultbootstrap.cxx) to bootstrap URE in any application process. It sets those bootstrap variables necessary for URE itself (and independent of any specific application like LO's soffice). Historically, there are two instances of the cppuhelper dynamic library, and consequently two instances of accompanying uno{.ini,rc} (with different content): one in solver for the tools run during the build---which in the past used to include cppunittester that runs the CppunitTests---and one in instdir and installation sets---which is now used also by cppunittester, which might be a change not thought-through enough yet (see below). The other is the URE_BOOTSTRAP bootstrap variable, normally set via tools::extendApplicationEnvironment (tools/source/misc/extendapplicationenvironment.cxx; called from application start-up code like soffice_main, desktop/source/app/sofficemain.cxx, and unopkg_main, desktop/source/pkgchk/unopkg/unopkg_app.cxx) to point to the fundamental{.ini,rc} next to the application's executable. The program/fundamental{.ini,rc} in turn contains most bootstrap variables you'll ever encounter (incl. LO_JAVA_DIR; for mostly historic reasons, it offloads some variables to an additional uno{.ini,rc} next to itself that can content-wise be considered an ini-file on of the above URE uno ini-file). The ideal with the recent move to instdir would of course be to run CppunitTests against instdir (as the---premature?---move of cppunittester to instdir manifests). However, one caveat I already mentioned elsewhere that comes to mind with running tests against instdir instead of solver is that the [old] setup makes sure that any JRE used by the tests is the one configured --with-jdk-home (by making use of jvmfwk's 'direct mode'), not one found via the jvmfwk search mechanisms. Another caveat is that should any of those tests 'accidentally' make use of bootstrap{rc,.ini}s UserInstallation, we should override that to make sure those tests do not interfere with the user's configuration. Yet another caveat is that those CppunitTests can run against varyingly filled instdirs, and thus behave subtly differently should they ever start to pick up the various bootstrap variables defined across instdir (which reference stuff in instdir that might or might not yet be there). Therefore, it is a good thing that solenv/gbuild/CppunitTest.mk still defines the relevant bootstrap variables manually. So, all that might be necessary for you now is diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk index 1f9390f..154841f 100644 --- a/solenv/gbuild/CppunitTest.mk +++ b/solenv/gbuild/CppunitTest.mk @@ -61,6 +61,7 @@ $(if $(URE),\ -env:UNO_SERVICES=$(foreach item,$(UNO_SERVICES),$(call gb_Helper_make_url,$(item \ -env:URE_INTERNAL_LIB_DIR=$(call gb_Helper_make_url,$(INSTROOT)/$(LIBO_URE_LIB_FOLDER)) \ -env:LO_LIB_DIR=$(call gb_Helper_make_url,$(INSTROOT)/$(gb_PROGRAMDIRNAME)) \ + -env:LO_JAVA_DIR=$(call gb_Helper_make_url,$(INSTROOT)/$(LIBO_SHARE_JAVA_FOLDER)) \ --protector $(call gb_Library_get_target,unoexceptionprotector) unoexceptionprotector \ --protector $(call gb_Library_get_target,unobootstrapprotector)
[Libreoffice-commits] core.git: writerperfect/Library_wpftdraw.mk
writerperfect/Library_wpftdraw.mk | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit de063d7a628b920da8c3da76f10d41cf0c63205d Author: Michael Stahl mst...@redhat.com Date: Mon Sep 23 15:20:48 2013 +0200 re-order externals in Library_wpftdraw for ld with --as-needed Change-Id: I52e14ead53fe0af0b13919869a5f646586251cca diff --git a/writerperfect/Library_wpftdraw.mk b/writerperfect/Library_wpftdraw.mk index 2033ca0..566b77b 100644 --- a/writerperfect/Library_wpftdraw.mk +++ b/writerperfect/Library_wpftdraw.mk @@ -46,17 +46,17 @@ $(eval $(call gb_Library_use_static_libraries,wpftdraw,\ $(eval $(call gb_Library_use_externals,wpftdraw,\ cdr \ - icui18n \ - icuuc \ - icudata \ - lcms2 \ - libxml2 \ -mspub \ + mspub \ odfgen \ visio \ wpg \ wpd \ zlib \ + lcms2 \ + libxml2 \ + icui18n \ + icuuc \ + icudata \ )) $(eval $(call gb_Library_add_exception_objects,wpftdraw,\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/sc-notes-storage' - sc/inc sc/qa sc/source
sc/inc/column.hxx |7 ++- sc/qa/unit/ucalc.cxx| 12 - sc/source/core/data/column.cxx |5 ++ sc/source/core/data/column2.cxx | 81 4 files changed, 101 insertions(+), 4 deletions(-) New commits: commit 10ec9481234014749328f760a1f066a15ab23477 Author: Laurent Godard lgodard.li...@laposte.net Date: Mon Sep 23 15:23:44 2013 +0200 notes transport on copying sheet to another document Change-Id: If38b25fc384414eb905b9c9d7b6b7562b462b338 diff --git a/sc/inc/column.hxx b/sc/inc/column.hxx index 6c01bb2..55cd4cd 100644 --- a/sc/inc/column.hxx +++ b/sc/inc/column.hxx @@ -495,7 +495,6 @@ public: void DeleteCellNote( SCROW nRow ); bool HasCellNotes() const; void SetCellNote( SCROW nRow, ScPostIt* pNote); -void SwapCellNotes( SCROW nRow1, SCROW nRow2 ); void InterpretDirtyCells( SCROW nRow1, SCROW nRow2 ); @@ -542,8 +541,12 @@ private: void CellStorageModified(); void CopyCellTextAttrsToDocument(SCROW nRow1, SCROW nRow2, ScColumn rDestCol) const; - void SwapCellTextAttrs( SCROW nRow1, SCROW nRow2 ); + +// cell notes +void CopyCellNotesToDocument(SCROW nRow1, SCROW nRow2, ScColumn rDestCol) const; +void SwapCellNotes( SCROW nRow1, SCROW nRow2 ); + }; #endif diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 4ae5732..fb0d07f 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -513,7 +513,10 @@ void Test::testCopyToDocument() m_pDoc-SetString(0, 4, 0, =4/2); m_pDoc-CalcAll(); -//TODO : notes +//note on A1 +ScAddress aAdrA1 (0, 0, 0); // numerical cell content +OUString aHelloA1(Hello world in A1); +m_pDoc-GetOrCreateNote(aAdrA1); // Copy statically to another document. @@ -529,6 +532,11 @@ void Test::testCopyToDocument() CPPUNIT_ASSERT_EQUAL(m_pDoc-GetString(0,3,0), aDestDoc.GetString(0,3,0)); CPPUNIT_ASSERT_EQUAL(m_pDoc-GetString(0,4,0), aDestDoc.GetString(0,4,0)); +// verify note +CPPUNIT_ASSERT_MESSAGE(There should be a note in A1 destDocument, aDestDoc.HasNote(ScAddress(0, 0, 0))); +CPPUNIT_ASSERT_MESSAGE(The notes content should be the same on both documents, +aDestDoc.GetNote(ScAddress(0, 0, 0))-GetText() == m_pDoc-GetNote(ScAddress(0, 0, 0))-GetText()); + m_pDoc-DeleteTab(0); } @@ -3004,7 +3012,7 @@ void Test::testCopyPasteTranspose() m_pDoc-SetString(2, 0, 0, OUString(test)); // add notes to A1:C1 -ScAddress aAdrA1 (0, 0, 0); // empty cell content +ScAddress aAdrA1 (0, 0, 0); // numerical cell content OUString aHelloA1(Hello world in A1); ScPostIt *pNoteA1 = m_pDoc-GetOrCreateNote(aAdrA1); pNoteA1-SetText(aAdrA1, aHelloA1); diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index aea68e0..193c8d3 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -1454,6 +1454,7 @@ void ScColumn::CopyStaticToDocument(SCROW nRow1, SCROW nRow2, ScColumn rDestCol sc::ColumnBlockPosition aDestPos; CopyCellTextAttrsToDocument(nRow1, nRow2, rDestCol); +CopyCellNotesToDocument(nRow1, nRow2, rDestCol); // First, clear the destination column for the specified row range. rDestCol.maCells.set_empty(nRow1, nRow2); @@ -1597,10 +1598,14 @@ void ScColumn::CopyCellToDocument( SCROW nSrcRow, SCROW nDestRow, ScColumn rDes if (bSet) { rDestCol.maCellTextAttrs.set(nDestRow, maCellTextAttrs.getsc::CellTextAttr(nSrcRow)); +ScPostIt* pNote = maCellNotes.getScPostIt*(nSrcRow); +rDestCol.maCellNotes.set(nDestRow, pNote); +pNote-UpdateCaptionPos(ScAddress(rDestCol.nCol, nDestRow, rDestCol.nTab)); } else { rDestCol.maCellTextAttrs.set_empty(nDestRow, nDestRow); +rDestCol.maCellNotes.set_empty(nDestRow, nDestRow); } rDestCol.CellStorageModified(); diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index f38ce5a..eab3076 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -1657,6 +1657,87 @@ void ScColumn::CopyCellTextAttrsToDocument(SCROW nRow1, SCROW nRow2, ScColumn r } } +void ScColumn::CopyCellNotesToDocument(SCROW nRow1, SCROW nRow2, ScColumn rDestCol) const +{ +rDestCol.maCellNotes.set_empty(nRow1, nRow2); // Empty the destination range first. + +sc::CellNoteStoreType::const_iterator itBlk = maCellNotes.begin(), itBlkEnd = maCellNotes.end(); + +// Locate the top row position. +size_t nOffsetInBlock = 0; +size_t nBlockStart = 0, nBlockEnd = 0, nRowPos = static_castsize_t(nRow1); +for (; itBlk != itBlkEnd; ++itBlk) +{ +nBlockEnd = nBlockStart + itBlk-size; +if (nBlockStart = nRowPos nRowPos nBlockEnd) +{ +// Found. +nOffsetInBlock = nRowPos - nBlockStart; +break; +} +} + +if (itBlk == itBlkEnd)
inter-sheet formulas don't automatically update any more?
It seems like since the release of 4.1 inter-sheet formulas (formulas that span multiple sheets in the spreadsheet) don't automatically update themselves anymore. Is this a bug or a feature? Cheers, Yi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: HSQLDB / Unit tests
On 23/09/13 15:22, Stephan Bergmann wrote: The ideal with the recent move to instdir would of course be to run CppunitTests against instdir (as the---premature?---move of cppunittester to instdir manifests). the only reason why that (and a bunch of test libraries) is in instdir is the LibreOffice_Test installation set actually packages it. i don't know if anybody needs that. Yet another caveat is that those CppunitTests can run against varyingly filled instdirs, and thus behave subtly differently should they ever start to pick up the various bootstrap variables defined across instdir (which reference stuff in instdir that might or might not yet be there). how is that different from running against a partially filled solver? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: HSQLDB / Unit tests
On 09/23/2013 03:32 PM, Michael Stahl wrote: On 23/09/13 15:22, Stephan Bergmann wrote: The ideal with the recent move to instdir would of course be to run CppunitTests against instdir (as the---premature?---move of cppunittester to instdir manifests). the only reason why that (and a bunch of test libraries) is in instdir is the LibreOffice_Test installation set actually packages it. i don't know if anybody needs that. I'd thought we'd come to the conclusion on IRC to remove LibreOffice_Test: Sep 19 11:34:23 pmladek mst__, sberg: I have created the LibreOffice_Test package for one QA guy. He does not longer work on LO. I am not sure if anyone else started to use it. So, I think that it can be killed. Yet another caveat is that those CppunitTests can run against varyingly filled instdirs, and thus behave subtly differently should they ever start to pick up the various bootstrap variables defined across instdir (which reference stuff in instdir that might or might not yet be there). how is that different from running against a partially filled solver? The start to pick up the various bootstrap variables defined [in ini-files] across instdir is the part that makes it different (as most of those ini filese were either not present at all in solver, or present in a form specifically suited for built-time use). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: scp2/source
scp2/source/accessories/module_samples_accessories.ulf | 12 scp2/source/accessories/module_templates_accessories.ulf | 12 2 files changed, 24 deletions(-) New commits: commit f236dd2916f487e52853bedd1688448f128fe3ab Author: Eike Rathke er...@redhat.com Date: Mon Sep 23 16:19:17 2013 +0200 sr*-CS language packs are history, ditch'em Change-Id: I457b446409487b1ea9386339c3e2b261f60e6516 diff --git a/scp2/source/accessories/module_samples_accessories.ulf b/scp2/source/accessories/module_samples_accessories.ulf index 36811b1..3893c92 100644 --- a/scp2/source/accessories/module_samples_accessories.ulf +++ b/scp2/source/accessories/module_samples_accessories.ulf @@ -474,12 +474,6 @@ en-US = Galician [STR_DESC_MODULE_LANGPACK_GL] en-US = Installs Galician support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SR_LATN_CS] -en-US = Serbian (Latin) - -[STR_DESC_MODULE_LANGPACK_SR_LATN_CS] -en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION - [STR_NAME_MODULE_LANGPACK_SR_LATN] en-US = Serbian (Latin) @@ -492,12 +486,6 @@ en-US = Irish [STR_DESC_MODULE_LANGPACK_GA] en-US = Installs Irish support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SR_CS] -en-US = Serbian (Cyrillic) - -[STR_DESC_MODULE_LANGPACK_SR_CS] -en-US = Installs Serbian (Cyrillic) support in %PRODUCTNAME %PRODUCTVERSION - [STR_NAME_MODULE_LANGPACK_SR] en-US = Serbian (Cyrillic) diff --git a/scp2/source/accessories/module_templates_accessories.ulf b/scp2/source/accessories/module_templates_accessories.ulf index ae0803a..caf880e 100644 --- a/scp2/source/accessories/module_templates_accessories.ulf +++ b/scp2/source/accessories/module_templates_accessories.ulf @@ -469,12 +469,6 @@ en-US = Galician [STR_DESC_MODULE_LANGPACK_GL] en-US = Installs Galician support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SR_LATN_CS] -en-US = Serbian (Latin) - -[STR_DESC_MODULE_LANGPACK_SR_LATN_CS] -en-US = Installs Serbian (Latin) support in %PRODUCTNAME %PRODUCTVERSION - [STR_NAME_MODULE_LANGPACK_SR_LATN] en-US = Serbian (Latin) @@ -487,12 +481,6 @@ en-US = Irish [STR_DESC_MODULE_LANGPACK_GA] en-US = Installs Irish support in %PRODUCTNAME %PRODUCTVERSION -[STR_NAME_MODULE_LANGPACK_SR_CS] -en-US = Serbian (Cyrillic) - -[STR_DESC_MODULE_LANGPACK_SR_CS] -en-US = Installs Serbian (Cyrillic) support in %PRODUCTNAME %PRODUCTVERSION - [STR_NAME_MODULE_LANGPACK_SR] en-US = Serbian (Cyrillic) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/CppunitTest_writerfilter_doctok.mk writerfilter/Module_writerfilter.mk writerfilter/qa
writerfilter/CppunitTest_writerfilter_doctok.mk| 44 --- writerfilter/Module_writerfilter.mk|2 writerfilter/qa/cppunittests/doctok/doctok.job |1 writerfilter/qa/cppunittests/doctok/export.map | 25 -- writerfilter/qa/cppunittests/doctok/testdoctok.cxx | 238 - 5 files changed, 310 deletions(-) New commits: commit d3c70e68c652bbdeeaea20200e003b6c5f92a62f Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Sep 23 16:59:51 2013 +0200 writerfilter: remove dead doctok unit test Change-Id: I4d223611df92a7e348dc31e38bd45849fe0eb028 diff --git a/writerfilter/CppunitTest_writerfilter_doctok.mk b/writerfilter/CppunitTest_writerfilter_doctok.mk deleted file mode 100644 index 1be6085..000 --- a/writerfilter/CppunitTest_writerfilter_doctok.mk +++ /dev/null @@ -1,44 +0,0 @@ -# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the License); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -$(eval $(call gb_CppunitTest_CppunitTest,writerfilter_doctok)) - -$(eval $(call gb_CppunitTest_use_external,writerfilter_doctok,boost_headers)) - -$(eval $(call gb_CppunitTest_add_exception_objects,writerfilter_doctok, \ - writerfilter/qa/cppunittests/doctok/testdoctok \ -)) - -$(eval $(call gb_CppunitTest_use_libraries,writerfilter_doctok, \ - cppu \ - cppuhelper \ - sal \ - writerfilter \ - $(gb_UWINAPI) \ -)) - -$(eval $(call gb_CppunitTest_set_include,writerfilter_doctok,\ - $$(INCLUDE) \ - -I$(SRCDIR)/writerfilter/inc \ -)) - -$(eval $(call gb_CppunitTest_use_sdk_api,writerfilter_doctok)) -$(eval $(call gb_CppunitTest_use_udk_api,writerfilter_doctok)) - -# vim: set noet sw=4 ts=4: diff --git a/writerfilter/Module_writerfilter.mk b/writerfilter/Module_writerfilter.mk index d6a1dc0..783b6ca 100644 --- a/writerfilter/Module_writerfilter.mk +++ b/writerfilter/Module_writerfilter.mk @@ -18,6 +18,4 @@ $(eval $(call gb_Module_add_slowcheck_targets,writerfilter,\ CppunitTest_writerfilter_rtftok \ )) -#CppunitTest_writerfilter_doctok \ - # vim: set noet sw=4 ts=4: diff --git a/writerfilter/qa/cppunittests/doctok/doctok.job b/writerfilter/qa/cppunittests/doctok/doctok.job deleted file mode 100644 index c99341d..000 --- a/writerfilter/qa/cppunittests/doctok/doctok.job +++ /dev/null @@ -1 +0,0 @@ -doctok.test.openFile \ No newline at end of file diff --git a/writerfilter/qa/cppunittests/doctok/export.map b/writerfilter/qa/cppunittests/doctok/export.map deleted file mode 100644 index 06b6a4a..000 --- a/writerfilter/qa/cppunittests/doctok/export.map +++ /dev/null @@ -1,25 +0,0 @@ -# -# This file is part of the LibreOffice project. -# -# This Source Code Form is subject to the terms of the Mozilla Public -# License, v. 2.0. If a copy of the MPL was not distributed with this -# file, You can obtain one at http://mozilla.org/MPL/2.0/. -# -# This file incorporates work covered by the following license notice: -# -# Licensed to the Apache Software Foundation (ASF) under one or more -# contributor license agreements. See the NOTICE file distributed -# with this work for additional information regarding copyright -# ownership. The ASF licenses this file to you under the Apache -# License, Version 2.0 (the License); you may not use this file -# except in compliance with the License. You may obtain a copy of -# the License at http://www.apache.org/licenses/LICENSE-2.0 . -# - -UDK_3_0_0 { -global: -registerAllTestFunction; - -local: -*; -}; diff --git a/writerfilter/qa/cppunittests/doctok/testdoctok.cxx b/writerfilter/qa/cppunittests/doctok/testdoctok.cxx deleted file mode 100644 index e4a04f7..000 --- a/writerfilter/qa/cppunittests/doctok/testdoctok.cxx +++ /dev/null @@ -1,238 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice:
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/platform/unxgcc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76a5c65f097f3d68e9eee16b13f6a740893a94d2 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Sep 23 18:02:30 2013 +0200 Duplicate -Wl,-rpath-link, typo Change-Id: I4d1feb61db753b150ec112579f5c493f9d1c1140 diff --git a/solenv/gbuild/platform/unxgcc.mk b/solenv/gbuild/platform/unxgcc.mk index f77fd99..f6063be 100644 --- a/solenv/gbuild/platform/unxgcc.mk +++ b/solenv/gbuild/platform/unxgcc.mk @@ -284,7 +284,7 @@ gb_Executable_LAYER := \ define gb_Executable__get_rpath -$(strip -Wl,-z,origin $(if $(1),'-Wl$(COMMA)-rpath$(COMMA)$(1)') -Wl,-rpath-link,-Wl,-rpath-link,$(INSTDIR)/ure/lib -Wl,-rpath-link,$(INSTDIR)/program) +$(strip -Wl,-z,origin $(if $(1),'-Wl$(COMMA)-rpath$(COMMA)$(1)') -Wl,-rpath-link,$(INSTDIR)/ure/lib -Wl,-rpath-link,$(INSTDIR)/program) endef define gb_Executable_get_rpath ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/sc-notes-storage' - sc/qa sc/source
sc/qa/unit/ucalc.cxx | 53 ++ sc/qa/unit/ucalc.hxx |2 + sc/source/core/data/column.cxx|9 -- sc/source/ui/docshell/docfunc.cxx | 18 +--- 4 files changed, 68 insertions(+), 14 deletions(-) New commits: commit 6ce4e50fe452ded99dac075eeaacc7ac03daf383 Author: Laurent Godard lgodard.li...@laposte.net Date: Mon Sep 23 18:08:42 2013 +0200 transport attached notes when moving a block of cell Change-Id: I608be1197cf4177aa67870ff34b61cf1fd67204c diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index fb0d07f..de928da 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -3067,6 +3067,59 @@ void Test::testCopyPasteTranspose() m_pDoc-DeleteTab(0); } +void Test::testMoveBlock() +{ +m_pDoc-InsertTab(0, Sheet1); + +m_pDoc-SetValue(0, 0, 0, 1); +m_pDoc-SetString(1, 0, 0, OUString(=A1+1)); +m_pDoc-SetString(2, 0, 0, OUString(test)); + +// add notes to A1:C1 +ScAddress aAdrA1 (0, 0, 0); // numerical cell content +OUString aHelloA1(Hello world in A1); +ScPostIt *pNoteA1 = m_pDoc-GetOrCreateNote(aAdrA1); +pNoteA1-SetText(aAdrA1, aHelloA1); +ScAddress aAdrB1 (1, 0, 0); // formula cell content +OUString aHelloB1(Hello world in B1); +ScPostIt *pNoteB1 = m_pDoc-GetOrCreateNote(aAdrB1); +pNoteB1-SetText(aAdrB1, aHelloB1); +ScAddress aAdrC1 (2, 0, 0); // string cell content +OUString aHelloC1(Hello world in C1); +ScPostIt *pNoteC1 = m_pDoc-GetOrCreateNote(aAdrC1); +pNoteC1-SetText(aAdrC1, aHelloC1); + +// move notes to B1:D1 +bool bCut = true; +ScDocFunc rDocFunc = getDocShell().GetDocFunc(); +bool bMoveDone = rDocFunc.MoveBlock(ScRange(0,0,0,2,0,0), ScAddress( 1, 0, 0), bCut, false, false, false); + +CPPUNIT_ASSERT_MESSAGE(Cells not moved, bMoveDone); + +//check cell content +OUString aString = m_pDoc-GetString(3, 0, 0); +CPPUNIT_ASSERT_MESSAGE(Cell D1 should contain: test, aString.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(test))); +m_pDoc-GetFormula(2, 0, 0, aString); +CPPUNIT_ASSERT_MESSAGE(Cell C1 should contain an updated formula, aString.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(=B1+1))); +double fValue = m_pDoc-GetValue(ScAddress(1, 0, 0)); +ASSERT_DOUBLES_EQUAL_MESSAGE(Cell B1 should contain 1, fValue, 1); + +// cell notes has been moved 1 cell right (event when overlapping) +CPPUNIT_ASSERT_MESSAGE(There should be NO note on A1, !m_pDoc-HasNote(ScAddress(0, 0, 0))); +CPPUNIT_ASSERT_MESSAGE(There should be a note on B1, m_pDoc-HasNote(ScAddress(1, 0, 0))); +CPPUNIT_ASSERT_MESSAGE(There should be a note on C1, m_pDoc-HasNote(ScAddress(2, 0, 0))); +CPPUNIT_ASSERT_MESSAGE(There should be a note on D1, m_pDoc-HasNote(ScAddress(3, 0, 0))); +/* still failing, wrong content ??? +OUString sNoteText; +sNoteText = m_pDoc-GetNote(ScAddress(1, 0, 0))-GetText(); +CPPUNIT_ASSERT_MESSAGE(Note content in B1, sNoteText == aHelloA1); +sNoteText = m_pDoc-GetNote(ScAddress(2, 0, 0))-GetText(); +CPPUNIT_ASSERT_MESSAGE(Note content in C1, sNoteText == aHelloB1); +sNoteText = m_pDoc-GetNote(ScAddress(3, 0, 0))-GetText(); +CPPUNIT_ASSERT_MESSAGE(Note content in D1, sNoteText == aHelloC1); +*/ +m_pDoc-DeleteTab(0); +} void Test::testCopyPasteRelativeFormula() { diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 1273241..0a141a3 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -215,6 +215,7 @@ public: void testAutofilter(); void testCopyPaste(); void testCopyPasteTranspose(); +void testMoveBlock(); void testCopyPasteRelativeFormula(); void testMergedCells(); void testUpdateReference(); @@ -348,6 +349,7 @@ public: CPPUNIT_TEST(testAutofilter); CPPUNIT_TEST(testCopyPaste); CPPUNIT_TEST(testCopyPasteTranspose); +CPPUNIT_TEST(testMoveBlock); CPPUNIT_TEST(testCopyPasteRelativeFormula); CPPUNIT_TEST(testMergedCells); CPPUNIT_TEST(testUpdateReference); diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 193c8d3..70df4d0 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -1670,7 +1670,7 @@ class CopyAsLinkHandler void duplicateNotes(SCROW nStartRow, size_t nDataSize ) // TODO : notes suboptimal { -// the link status is only for cell content as it is not possible to un-link a note +// the link status is only for cell content as it is not possible to un-link a note -- the note is copied sc::CellNoteStoreType maSrcCellNotes = mrSrcCol.GetCellNoteStore(); SCROW nRowMax = nStartRow + nDataSize; @@ -1885,6 +1885,7 @@ class CopyByCloneHandler aDestPos, true ); mrDestCol.GetDoc().ReleaseNote(aDestPos); mrDestCol.GetDoc().SetNote(aDestPos, pClonedNote); +
Re: inter-sheet formulas don't automatically update any more?
Hey, 2013/9/23 Yi Ding yi.s.d...@gmail.com It seems like since the release of 4.1 inter-sheet formulas (formulas that span multiple sheets in the spreadsheet) don't automatically update themselves anymore. Is this a bug or a feature? It is a bug and can be fixed with a CTRL+SHIFT+F9. Somehow the formula tree is not built during import right now. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - RepositoryExternal.mk solenv/bin
RepositoryExternal.mk|3 --- solenv/bin/concat-deps.c |6 +- 2 files changed, 5 insertions(+), 4 deletions(-) New commits: commit 1133c6568d17d9f9a2e4bf2054d89d77b065 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 20:23:33 2013 +0300 Make the Android cross-compilation get a bit further along Change-Id: Idf91e95afad9b89e39d7234622f4a37f18b5ca6c diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index b036b66..0756b41 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -1634,9 +1634,6 @@ $(call gb_LinkTarget_set_include,$(1),\ -I$(call gb_UnpackedTarball_get_dir,lcms2/include) \ $$(INCLUDE) \ ) -$(call gb_LinkTarget_use_static_libraries,$(1),\ - lcms2 \ -) endef commit c03124eb1cd2f9c1624978edcf2c4b04cd2f87f0 Author: Tor Lillqvist t...@collabora.com Date: Mon Sep 23 19:25:48 2013 +0300 Print a helpful error message if we are going to fail Change-Id: I0685c9d2d857a9e994c616acb6d7ce106c7a7dad diff --git a/solenv/bin/concat-deps.c b/solenv/bin/concat-deps.c index ebabdd0..87b6f32 100644 --- a/solenv/bin/concat-deps.c +++ b/solenv/bin/concat-deps.c @@ -871,7 +871,11 @@ static inline int generate_phony_file(char* fn, char* content) { FILE* depfile; depfile = fopen(fn, w); -if(depfile) +if(!depfile) +{ +fprintf(stderr, Could not open '%s' for writing: %s\n, fn, strerror(errno)); +} +else { fputs(content, depfile); fclose(depfile); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/viewer/mediawindow_impl.cxx |2 +- avmedia/source/vlc/vlcframegrabber.cxx |2 +- avmedia/source/vlc/vlcmanager.cxx |2 +- avmedia/source/vlc/wrapper/SymbolLoader.hxx |3 ++- 4 files changed, 5 insertions(+), 4 deletions(-) New commits: commit ba0d1fc481c524bb87c9a9e0f434d43927428f75 Author: Minh Ngo nlmin...@gmail.com Date: Mon Sep 23 21:55:02 2013 +0300 Avmedia/VLC: Adding more debug info Change-Id: I484050575da7e09e89a10f3a4e8d5fbe95f88044 diff --git a/avmedia/source/viewer/mediawindow_impl.cxx b/avmedia/source/viewer/mediawindow_impl.cxx index 062710c..adfe1cd 100644 --- a/avmedia/source/viewer/mediawindow_impl.cxx +++ b/avmedia/source/viewer/mediawindow_impl.cxx @@ -16,7 +16,7 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ - +#include iostream #include mediawindow_impl.hxx #include mediaevent_impl.hxx #include mediamisc.hxx diff --git a/avmedia/source/vlc/vlcframegrabber.cxx b/avmedia/source/vlc/vlcframegrabber.cxx index 8b348f4..f5b7091 100644 --- a/avmedia/source/vlc/vlcframegrabber.cxx +++ b/avmedia/source/vlc/vlcframegrabber.cxx @@ -30,7 +30,7 @@ namespace -Vdummy, --snapshot-format=png, --ffmpeg-threads, ---verbose=-1, +--verbose=2, --no-audio }; } diff --git a/avmedia/source/vlc/vlcmanager.cxx b/avmedia/source/vlc/vlcmanager.cxx index 085f3c8..e86302d 100644 --- a/avmedia/source/vlc/vlcmanager.cxx +++ b/avmedia/source/vlc/vlcmanager.cxx @@ -30,7 +30,7 @@ namespace const char * const VLC_ARGS[] = { -Vdummy, ---verbose=-1 +--verbose=2 }; } diff --git a/avmedia/source/vlc/wrapper/SymbolLoader.hxx b/avmedia/source/vlc/wrapper/SymbolLoader.hxx index 6bda7bd..7d89339 100644 --- a/avmedia/source/vlc/wrapper/SymbolLoader.hxx +++ b/avmedia/source/vlc/wrapper/SymbolLoader.hxx @@ -47,7 +47,7 @@ namespace wchar_t arCurrent[MAX_PATH]; DWORD dwType, dwCurrentSize = sizeof( arCurrent ); -if ( ::RegOpenKeyExW( HKEY_LOCAL_MACHINE, LSoftware\\VideoLAN\\VLC, +if ( ::RegOpenKeyExW( HKEY_LOCAL_MACHINE, LSOFTWARE\\VideoLAN\\VLC, 0, KEY_READ, hKey ) == ERROR_SUCCESS ) { if ( ::RegQueryValueExW( hKey, LInstallDir, NULL, dwType, (LPBYTE) arCurrent, dwCurrentSize ) == ERROR_SUCCESS @@ -95,6 +95,7 @@ namespace #elif defined( WNT ) const OUString fullPath = GetVLCPath() + OUString::createFromAscii(LibName); #endif +SAL_INFO(avmedia, fullPath); oslModule aModule = osl_loadModule( fullPath.pData, SAL_LOADMODULE_DEFAULT ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: avmedia/source
avmedia/source/vlc/vlcmanager.cxx |2 ++ avmedia/source/vlc/wrapper/SymbolLoader.hxx |1 + 2 files changed, 3 insertions(+) New commits: commit df58558769bb2286393db3b6e2ff1604cca92fea Author: Minh Ngo nlmin...@gmail.com Date: Mon Sep 23 22:09:41 2013 +0300 Avmedia/VLC: Debug info Change-Id: Id36e189dc4666b1e17bd998f290a212070f0aede diff --git a/avmedia/source/vlc/vlcmanager.cxx b/avmedia/source/vlc/vlcmanager.cxx index e86302d..8453bb4 100644 --- a/avmedia/source/vlc/vlcmanager.cxx +++ b/avmedia/source/vlc/vlcmanager.cxx @@ -65,6 +65,8 @@ Manager::Manager( const uno::Reference lang::XMultiServiceFactory rxMgr ) else SAL_INFO(avmedia, VLC version ' str ' is acceptable); } +else +SAL_WARN(avmedia, Cannot load symbols); if (m_is_vlc_found) mEventHandler.create(); diff --git a/avmedia/source/vlc/wrapper/SymbolLoader.hxx b/avmedia/source/vlc/wrapper/SymbolLoader.hxx index 7d89339..ec38d1b 100644 --- a/avmedia/source/vlc/wrapper/SymbolLoader.hxx +++ b/avmedia/source/vlc/wrapper/SymbolLoader.hxx @@ -111,6 +111,7 @@ namespace return true; } +SAL_WARN(avmedia, Cannot load libvlc); osl_unloadModule( aModule ); return false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: postgresql/ExternalProject_postgresql.mk
postgresql/ExternalProject_postgresql.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ab74f61f80beffee9aecf622d476205c13e8c245 Author: Michael Stahl mst...@redhat.com Date: Mon Sep 23 19:31:05 2013 +0200 postgresql: find libldap_r again ... so that's what the ldap_r was for that i removed in f33c8644c052bf9d69157224500ca7887075c7da. Change-Id: I8b913880fa32b2bf8566727af954a0ce0da4bba0 diff --git a/postgresql/ExternalProject_postgresql.mk b/postgresql/ExternalProject_postgresql.mk index 1cbaed0..9f495c5 100644 --- a/postgresql/ExternalProject_postgresql.mk +++ b/postgresql/ExternalProject_postgresql.mk @@ -42,7 +42,7 @@ $(call gb_ExternalProject_get_state_target,postgresql,build) : $(if $(and $(filter NO,$(SYSTEM_OPENSSL)), $(filter-out YES,$(DISABLE_OPENSSL))),\ -I$(call gb_UnpackedTarball_get_dir,openssl/include)) \ $(if $(filter NO,$(SYSTEM_OPENLDAP)), \ - LDFLAGS=-L$(call gb_UnpackedTarball_get_dir,openldap)/libraries/libldap/.libs -L$(call gb_UnpackedTarball_get_dir,openldap)/libraries/liblber/.libs -L$(OUTDIR)/lib \ + LDFLAGS=-L$(call gb_UnpackedTarball_get_dir,openldap)/libraries/libldap_r/.libs -L$(call gb_UnpackedTarball_get_dir,openldap)/libraries/libldap/.libs -L$(call gb_UnpackedTarball_get_dir,openldap)/libraries/liblber/.libs -L$(OUTDIR)/lib \ EXTRA_LDAP_LIBS=-llber -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 \ ) \ cd src/interfaces/libpq \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source svl/source
editeng/source/misc/svxacorr.cxx | 17 - svl/source/numbers/zforfind.cxx |4 +++- 2 files changed, 11 insertions(+), 10 deletions(-) New commits: commit 2f4d7eacabd62db35777682bcca353e142e024bf Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net Date: Sun Sep 22 00:19:12 2013 +0200 fdo#54686 Treat hard blank as soft blank in number AutoCorrect option Add non-breaking space in French... insert non-breaking space (hard blank) and avoid recognition of percent number and time number. This patch treats hard blanks as soft blank in number format recognition Rev.#1: change #define to const variable. Same change in svxaccor Rev.#2: improvements Change-Id: I30c2c36778cb53a0238a0829043dad4d709f97d2 Reviewed-on: https://gerrit.libreoffice.org/6015 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 1c65aea..3176db9 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -61,8 +61,6 @@ #include xmloff/xmltoken.hxx #include vcl/help.hxx -#define CHAR_HARDBLANK ((sal_Unicode)0x00A0) - using namespace ::com::sun::star::ucb; using namespace ::com::sun::star::uno; using namespace ::com::sun::star; @@ -75,6 +73,7 @@ static const int C_FULL_STOP= 0x01; static const int C_EXCLAMATION_MARK = 0x02; static const int C_QUESTION_MARK= 0x04; static const int C_ASTERISK = 0x2A; +static const sal_Unicode cNonBreakingSpace = 0xA0; static const sal_Char pImplAutocorr_ListStr[] = DocumentList; static const sal_Char pXMLImplWrdStt_ExcptLstStr[] = WordExceptList.xml; @@ -99,7 +98,7 @@ typedef SvxAutoCorrectLanguageLists* SvxAutoCorrectLanguageListsPtr; static inline int IsWordDelim( const sal_Unicode c ) { return ' ' == c || '\t' == c || 0x0a == c || -0xA0 == c || 0x2011 == c || 0x1 == c; +cNonBreakingSpace == c || 0x2011 == c || 0x1 == c; } static inline int IsLowerLetter( sal_Int32 nCharType ) @@ -662,7 +661,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( { // Remove any previous normal space xub_StrLen nPos = nEndPos - 1; -while ( cPrevChar == ' ' || cPrevChar == CHAR_HARDBLANK ) +while ( cPrevChar == ' ' || cPrevChar == cNonBreakingSpace ) { if ( nPos == 0 ) break; nPos--; @@ -675,7 +674,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Add the non-breaking space at the end pos if ( bHasSpace ) -rDoc.Insert( nPos, OUString(CHAR_HARDBLANK) ); +rDoc.Insert( nPos, OUString(cNonBreakingSpace) ); bRunNext = true; bRet = true; } @@ -688,7 +687,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Remove the hardspace right before to avoid formatting URLs sal_Unicode cPrevChar = rTxt[ nEndPos - 1 ]; sal_Unicode cMaybeSpaceChar = rTxt[ nEndPos - 2 ]; -if ( cPrevChar == ':' cMaybeSpaceChar == CHAR_HARDBLANK ) +if ( cPrevChar == ':' cMaybeSpaceChar == cNonBreakingSpace ) { rDoc.Delete( nEndPos - 2, nEndPos - 1 ); bRet = true; @@ -1184,7 +1183,7 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc rDoc, xub_StrLen nInsPos, case LANGUAGE_FRENCH_SWISS: case LANGUAGE_FRENCH_LUXEMBOURG: { -OUString s( static_cast sal_Unicode (0xA0) ); +OUString s( cNonBreakingSpace ); // UNICODE code for no break space if( rDoc.Insert( bSttQuote ? nInsPos+1 : nInsPos, s )) { @@ -1284,7 +1283,7 @@ SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc rDoc, const OUString rTxt, { // Remove the NBSP if it wasn't an autocorrection if ( nInsPos != 0 NeedsHardspaceAutocorr( rTxt[ nInsPos - 1 ] ) -cChar != ' ' cChar != '\t' cChar != CHAR_HARDBLANK ) +cChar != ' ' cChar != '\t' cChar != cNonBreakingSpace ) { // Look for the last HARD_SPACE sal_Int32 nPos = nInsPos - 1; @@ -1292,7 +1291,7 @@ SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc rDoc, const OUString rTxt, while ( bContinue ) { const sal_Unicode cTmpChar = rTxt[ nPos ]; -if ( cTmpChar == CHAR_HARDBLANK ) +if ( cTmpChar == cNonBreakingSpace ) { rDoc.Delete( nPos, nPos + 1
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - editeng/source svl/source
editeng/source/misc/svxacorr.cxx | 17 - svl/source/numbers/zforfind.cxx |4 +++- 2 files changed, 11 insertions(+), 10 deletions(-) New commits: commit 1ca4b1bae11704a1119a9c680c6ae5b85ea1b31e Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net Date: Sun Sep 22 00:19:12 2013 +0200 fdo#54686 Treat hard blank as soft blank in number AutoCorrect option Add non-breaking space in French... insert non-breaking space (hard blank) and avoid recognition of percent number and time number. This patch treats hard blanks as soft blank in number format recognition Rev.#1: change #define to const variable. Same change in svxaccor Rev.#2: improvements Reviewed-on: https://gerrit.libreoffice.org/6015 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com (cherry picked from commit 2f4d7eacabd62db35777682bcca353e142e024bf) Signed-off-by: Eike Rathke er...@redhat.com Conflicts: editeng/source/misc/svxacorr.cxx svl/source/numbers/zforfind.cxx Change-Id: I30c2c36778cb53a0238a0829043dad4d709f97d2 diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 7be7da1..9e3b325 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -63,8 +63,6 @@ #include vcl/help.hxx #include rtl/logfile.hxx -#define CHAR_HARDBLANK ((sal_Unicode)0x00A0) - using namespace ::com::sun::star::ucb; using namespace ::com::sun::star::uno; using namespace ::com::sun::star; @@ -76,6 +74,7 @@ static const int C_NONE = 0x00; static const int C_FULL_STOP= 0x01; static const int C_EXCLAMATION_MARK = 0x02; static const int C_QUESTION_MARK= 0x04; +static const sal_Unicode cNonBreakingSpace = 0xA0; static const sal_Char pImplAutocorr_ListStr[] = DocumentList; static const sal_Char pXMLImplWrdStt_ExcptLstStr[] = WordExceptList.xml; @@ -100,7 +99,7 @@ typedef SvxAutoCorrectLanguageLists* SvxAutoCorrectLanguageListsPtr; static inline int IsWordDelim( const sal_Unicode c ) { return ' ' == c || '\t' == c || 0x0a == c || -0xA0 == c || 0x2011 == c || 0x1 == c; +cNonBreakingSpace == c || 0x2011 == c || 0x1 == c; } static inline int IsLowerLetter( sal_Int32 nCharType ) @@ -659,7 +658,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( { // Remove any previous normal space xub_StrLen nPos = nEndPos - 1; -while ( cPrevChar == ' ' || cPrevChar == CHAR_HARDBLANK ) +while ( cPrevChar == ' ' || cPrevChar == cNonBreakingSpace ) { if ( nPos == 0 ) break; nPos--; @@ -672,7 +671,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Add the non-breaking space at the end pos if ( bHasSpace ) -rDoc.Insert( nPos, OUString(CHAR_HARDBLANK) ); +rDoc.Insert( nPos, OUString(cNonBreakingSpace) ); bRunNext = true; bRet = true; } @@ -685,7 +684,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Remove the hardspace right before to avoid formatting URLs sal_Unicode cPrevChar = rTxt.GetChar( nEndPos - 1 ); sal_Unicode cMaybeSpaceChar = rTxt.GetChar( nEndPos - 2 ); -if ( cPrevChar == ':' cMaybeSpaceChar == CHAR_HARDBLANK ) +if ( cPrevChar == ':' cMaybeSpaceChar == cNonBreakingSpace ) { rDoc.Delete( nEndPos - 2, nEndPos - 1 ); bRet = true; @@ -1166,7 +1165,7 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc rDoc, xub_StrLen nInsPos, case LANGUAGE_FRENCH_SWISS: case LANGUAGE_FRENCH_LUXEMBOURG: { -OUString s( static_cast sal_Unicode (0xA0) ); +OUString s( cNonBreakingSpace ); // UNICODE code for no break space if( rDoc.Insert( bSttQuote ? nInsPos+1 : nInsPos, s )) { @@ -1266,7 +1265,7 @@ SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc rDoc, const String rTxt, { // Remove the NBSP if it wasn't an autocorrection if ( nInsPos != 0 NeedsHardspaceAutocorr( rTxt.GetChar( nInsPos - 1 ) ) -cChar != ' ' cChar != '\t' cChar != CHAR_HARDBLANK ) +cChar != ' ' cChar != '\t' cChar != cNonBreakingSpace ) { // Look for the last HARD_SPACE xub_StrLen nPos = nInsPos - 1; @@ -1274,7 +1273,7 @@ SvxAutoCorrect::DoAutoCorrect( SvxAutoCorrDoc rDoc, const String rTxt, while ( bContinue ) { const
[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - editeng/source svl/source
editeng/source/misc/svxacorr.cxx | 17 - svl/source/numbers/zforfind.cxx |4 +++- 2 files changed, 11 insertions(+), 10 deletions(-) New commits: commit d6f90b9ec323b1871ff5a23e30bd090b124cf006 Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net Date: Sun Sep 22 00:19:12 2013 +0200 fdo#54686 Treat hard blank as soft blank in number AutoCorrect option Add non-breaking space in French... insert non-breaking space (hard blank) and avoid recognition of percent number and time number. This patch treats hard blanks as soft blank in number format recognition Rev.#1: change #define to const variable. Same change in svxaccor Rev.#2: improvements Reviewed-on: https://gerrit.libreoffice.org/6015 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com (cherry picked from commit 2f4d7eacabd62db35777682bcca353e142e024bf) Conflicts: editeng/source/misc/svxacorr.cxx svl/source/numbers/zforfind.cxx (cherry picked from commit 1ca4b1bae11704a1119a9c680c6ae5b85ea1b31e) Signed-off-by: Eike Rathke er...@redhat.com Conflicts: editeng/source/misc/svxacorr.cxx Change-Id: I30c2c36778cb53a0238a0829043dad4d709f97d2 diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 046c4b3..9887540 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -63,8 +63,6 @@ #include vcl/help.hxx #include rtl/logfile.hxx -#define CHAR_HARDBLANK ((sal_Unicode)0x00A0) - using namespace ::com::sun::star::ucb; using namespace ::com::sun::star::uno; using namespace ::com::sun::star; @@ -76,6 +74,7 @@ static const int C_NONE = 0x00; static const int C_FULL_STOP= 0x01; static const int C_EXCLAMATION_MARK = 0x02; static const int C_QUESTION_MARK= 0x04; +static const sal_Unicode cNonBreakingSpace = 0xA0; static const sal_Char pImplWrdStt_ExcptLstStr[]= WordExceptList; static const sal_Char pImplCplStt_ExcptLstStr[]= SentenceExceptList; @@ -102,7 +101,7 @@ typedef SvxAutoCorrectLanguageLists* SvxAutoCorrectLanguageListsPtr; static inline int IsWordDelim( const sal_Unicode c ) { return ' ' == c || '\t' == c || 0x0a == c || -0xA0 == c || 0x2011 == c || 0x1 == c; +cNonBreakingSpace == c || 0x2011 == c || 0x1 == c; } static inline int IsLowerLetter( sal_Int32 nCharType ) @@ -628,7 +627,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( { // Remove any previous normal space xub_StrLen nPos = nEndPos - 1; -while ( cPrevChar == ' ' || cPrevChar == CHAR_HARDBLANK ) +while ( cPrevChar == ' ' || cPrevChar == cNonBreakingSpace ) { if ( nPos == 0 ) break; nPos--; @@ -641,7 +640,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Add the non-breaking space at the end pos if ( bHasSpace ) -rDoc.Insert( nPos, rtl::OUString(CHAR_HARDBLANK) ); +rDoc.Insert( nPos, rtl::OUString(cNonBreakingSpace) ); bRunNext = true; bRet = true; } @@ -654,7 +653,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace( // Remove the hardspace right before to avoid formatting URLs sal_Unicode cPrevChar = rTxt.GetChar( nEndPos - 1 ); sal_Unicode cMaybeSpaceChar = rTxt.GetChar( nEndPos - 2 ); -if ( cPrevChar == ':' cMaybeSpaceChar == CHAR_HARDBLANK ) +if ( cPrevChar == ':' cMaybeSpaceChar == cNonBreakingSpace ) { rDoc.Delete( nEndPos - 2, nEndPos - 1 ); bRet = true; @@ -1126,7 +1125,7 @@ void SvxAutoCorrect::InsertQuote( SvxAutoCorrDoc rDoc, xub_StrLen nInsPos, case LANGUAGE_FRENCH_SWISS: case LANGUAGE_FRENCH_LUXEMBOURG: { -rtl::OUString s( static_cast sal_Unicode (0xA0) ); +rtl::OUString s( cNonBreakingSpace ); // UNICODE code for no break space if( rDoc.Insert( bSttQuote ? nInsPos+1 : nInsPos, s )) { @@ -1225,7 +1224,7 @@ sal_uLong SvxAutoCorrect::AutoCorrect( SvxAutoCorrDoc rDoc, const String rTxt, { // Remove the NBSP if it wasn't an autocorrection if ( nInsPos != 0 NeedsHardspaceAutocorr( rTxt.GetChar( nInsPos - 1 ) ) -cChar != ' ' cChar != '\t' cChar != CHAR_HARDBLANK ) +cChar != ' ' cChar != '\t' cChar != cNonBreakingSpace ) { // Look for the last HARD_SPACE xub_StrLen nPos = nInsPos - 1; @@ -1233,7 +1232,7 @@ sal_uLong
Looking for the solution for Bug 43340
Hi all, When I used the previous libreoffice(3.3, 3.4, etc.) I found the caret disappeared when inserting a new slide via slide button in the toolbar. But after I used LO from the version 4.0.1.2 I found the bug did not appear any more. This bug only exists on Windows platform and it doesn't exist on Linux platform. I also found its number(43340) on LO Bugzilla. I'm interested in the solution code for the bug. So is there anybody who knows the patch for this bug or knows where the corresponding code is? Thanks in advance. Bug 43340 - EDITING: cursor position invisible after adding a new slide via icon command https://bugs.freedesktop.org/show_bug.cgi?id=43340 Regards, Liang Weike___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
solution for 43340
Hi all, When I used the previous libreoffice(3.3, 3.4, etc.) I found the caret disappeared when inserting a new slide via slide button in the toolbar. But after I used LO from the version 4.0.1.2 I found the bug did not appear any more. This bug only exists on Windows platform and it doesn't exist on Linux platform. I also found its number(43340) on LO Bugzilla. I'm interested in the solution code for the bug. So is there anybody who knows the patch for this bug or knows where the corresponding code is? Thanks in advance. Bug 43340 - EDITING: cursor position invisible after adding a new slide via icon command https://bugs.freedesktop.org/show_bug.cgi?id=43340 Regards, Liang Weike___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: sobre libreOffice
Hi, On Thu, 2013-09-19 at 18:30 +0200, Juan Carlos wrote: ... Hi, I need to know if there is a system that lets the LibreOffice packaging, automatically and is not by console commands, something like a tool that will provide all those commands that have to pull off the console for packaging LibreOffice. GreetingsJuan Carlos. ... better in English :) Do you mean a packaging system like OBS[1] or Launchpad[2]? I'm certainly not totally understanding your question. Br. [1] https://build.opensuse.org/ [2] https://launchpad.net/ -- Andres Gomez Computer Science Engineer mailto:ago...@igalia.com http://blogs.igalia.com/agomez/category/igaliacom/ IGALIA, S.L. http://www.igalia.com signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: configure.ac instsetoo_native/util officecfg/registry postprocess/CustomTarget_registry.mk solenv/bin sysui/CustomTarget_infoplist.mk sysui/desktop
configure.ac | 12 instsetoo_native/util/openoffice.lst.in |5 officecfg/registry/data/org/openoffice/Setup.xcu |4 postprocess/CustomTarget_registry.mk |2 solenv/bin/modules/installer/ziplist.pm |3 sysui/CustomTarget_infoplist.mk |5 sysui/desktop/macosx/Info.plist | 1427 --- sysui/desktop/macosx/Info.plist.in | 1427 +++ 8 files changed, 1443 insertions(+), 1442 deletions(-) New commits: commit bbbc51e931c3a7018f2f19f61fa823190ee6fbb1 Author: Tor Lillqvist t...@collabora.com Date: Tue Sep 24 01:49:59 2013 +0300 Create a proper Info.plist for the OS X app bundle already in configure After recent instdir changes the SCPZIP_REPLACE thing was not used any more for Info.plist, so all the ${FOO} things were left in Info.plist unexpanded with predictably wonky results, a non-working app. Instead just expand it from the configure script. While at it, use a correct CFBundleShortVersionString: only three integers should be in that. Also, hardcode FILEFORMATNAME as OpenOffice.org and FILEFORMATVERSION as 1.0, and drop the variables, as that is what those variables *means*. They were used to refer to the OOo 1.0 formats. (It would have been utterly wrong to define them as something else, like another product name and a newer version number, in openoffice.lst, so pointless to have them there.) Drop the meaningless BUILDIDCWS. Change-Id: I4030aa060b78e8b3fb812a6362869996e8db7d3d diff --git a/configure.ac b/configure.ac index 1f3ea9b..0bcbfae 100644 --- a/configure.ac +++ b/configure.ac @@ -110,6 +110,11 @@ LIBO_VERSION_MINOR=$2 LIBO_VERSION_MICRO=$3 LIBO_VERSION_PATCH=$4 +# The CFBundleShortVersionString in Info.plist consists of three integers, so encode the third +# as the micro version times 1000 plus the patch number. Unfortunately the LIBO_VERSION_SUFFIX can be anything so +# no way to encode that into an integer in general. +MACOSX_BUNDLE_SHORTVERSION=$LIBO_VERSION_MAJOR.$LIBO_VERSION_MINOR.`expr $LIBO_VERSION_MICRO '*' 1000 + $LIBO_VERSION_PATCH` + LIBO_VERSION_SUFFIX=$5 # Split out LIBO_VERSION_SUFFIX_SUFFIX... horrible crack. But apparently wanted separately in # openoffice.lst as ABOUTBOXPRODUCTVERSIONSUFFIX. Note that the double brackets are for m4's sake, @@ -123,6 +128,7 @@ AC_SUBST(LIBO_VERSION_MAJOR) AC_SUBST(LIBO_VERSION_MINOR) AC_SUBST(LIBO_VERSION_MICRO) AC_SUBST(LIBO_VERSION_PATCH) +AC_SUBST(MACOSX_BUNDLE_SHORTVERSION) AC_SUBST(LIBO_VERSION_SUFFIX) AC_SUBST(LIBO_VERSION_SUFFIX_SUFFIX) @@ -12595,7 +12601,11 @@ if test -f config_host.mk; then config_md5=`$MD5SUM config_host.mk | sed s/ .*//` fi -AC_CONFIG_FILES([config_host.mk Makefile lo.xcent instsetoo_native/util/openoffice.lst]) +AC_CONFIG_FILES([config_host.mk + Makefile + lo.xcent + instsetoo_native/util/openoffice.lst + sysui/desktop/macosx/Info.plist]) AC_CONFIG_HEADERS([config_host/config_buildid.h]) AC_CONFIG_HEADERS([config_host/config_clang.h]) AC_CONFIG_HEADERS([config_host/config_features.h]) diff --git a/instsetoo_native/util/openoffice.lst.in b/instsetoo_native/util/openoffice.lst.in index 8c995cb..b526ec2 100644 --- a/instsetoo_native/util/openoffice.lst.in +++ b/instsetoo_native/util/openoffice.lst.in @@ -32,7 +32,6 @@ Globals WINDOWSPATCHLEVEL 8 OOOVENDOR The Document Foundation OOODOWNLOADNAME 1 -BUILDIDCWS {buildidcws} STARTCENTER_HIDE_EXTERNAL_LINKS 0 } } @@ -58,8 +57,6 @@ LibreOffice UPDATEURL http://update.libreoffice.org/check.php ADD_INCLUDE_FILES cliureversion.mk,clioootypesversion.mk ADDSYSTEMINTEGRATION 1 -FILEFORMATNAME OpenOffice.org -FILEFORMATVERSION 1.0 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1 PACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ PACKAGEREVISION {buildid} @@ -112,8 +109,6 @@ LibreOffice_Dev UPDATEURL http://update.libreoffice.org/check.php ADD_INCLUDE_FILES cliureversion.mk,clioootypesversion.mk ADDSYSTEMINTEGRATION 1 -FILEFORMATNAME OpenOffice.org -FILEFORMATVERSION 1.0 WRITERCOMPATIBILITYVERSIONOOO11 OpenOffice.org 1.1 PACKAGEVERSION @LIBO_VERSION_MAJOR@.@LIBO_VERSION_MINOR@.@LIBO_VERSION_MICRO@.@LIBO_VERSION_PATCH@@LIBO_VERSION_SUFFIX@ PACKAGEREVISION {buildid} diff --git a/officecfg/registry/data/org/openoffice/Setup.xcu b/officecfg/registry/data/org/openoffice/Setup.xcu index 50bdb21..75649f0 100644 --- a/officecfg/registry/data/org/openoffice/Setup.xcu +++
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/ucalc.cxx |6 +++--- sc/source/ui/src/scfuncs.src |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) New commits: commit d269c92a74516081f277d427ab44dbe4ece00598 Author: Joel Madero jmadero@gmail.com Date: Mon Sep 23 15:54:58 2013 -0700 fdo#69685 - move count functions Moved Count functions (countif, countifs and countblank to statistical instead of mathematical group) Change-Id: If8faeabb8f43810a96d919b59116157ae107c12c Reviewed-on: https://gerrit.libreoffice.org/6022 Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index ad98b7d..324400b 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -2134,9 +2134,6 @@ void Test::testFunctionLists() COSH, COT, COTH, -COUNTBLANK, -COUNTIF, -COUNTIFS, CSC, CSCH, DEGREES, @@ -2215,6 +2212,9 @@ void Test::testFunctionLists() CORREL, COUNT, COUNTA, +COUNTBLANK, +COUNTIF, +COUNTIFS, COVAR, CRITBINOM, DEVSQ, diff --git a/sc/source/ui/src/scfuncs.src b/sc/source/ui/src/scfuncs.src index 64ef65c..7c3922e 100644 --- a/sc/source/ui/src/scfuncs.src +++ b/sc/source/ui/src/scfuncs.src @@ -2854,7 +2854,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS1 ExtraData = { 0; -ID_FUNCTION_GRP_MATH; +ID_FUNCTION_GRP_STATISTIC; U2S( HID_FUNC_ANZAHLLEEREZELLEN ); 1; 0; 0; @@ -3129,7 +3129,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS1 ExtraData = { 0; -ID_FUNCTION_GRP_MATH; +ID_FUNCTION_GRP_STATISTIC; U2S( HID_FUNC_COUNTIFS ); PAIRED_VAR_ARGS;0; 0; 0; @@ -3162,7 +3162,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS1 ExtraData = { 0; -ID_FUNCTION_GRP_MATH; +ID_FUNCTION_GRP_STATISTIC; U2S( HID_FUNC_ZAEHLENWENN ); 2; 0; 0; 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sc/source
sc/qa/unit/ucalc.cxx |4 ++-- sc/source/ui/src/scfuncs.src |4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 4547d8c42e5b0bb456ac02fbea67059a8a1cadd7 Author: Joel Madero jmadero@gmail.com Date: Thu Sep 19 22:37:39 2013 -0700 fdo#69536 - Moved Averageif(s) Moved averageif and averageifs to statistical category instead of mathematical Change-Id: Ibcf7f5a5e12b528c4877232e4c56d5167b1df40a Reviewed-on: https://gerrit.libreoffice.org/6010 Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 324400b..e5e6198 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -2119,8 +2119,6 @@ void Test::testFunctionLists() ATAN, ATAN2, ATANH, -AVERAGEIF, -AVERAGEIFS, BITAND, BITLSHIFT, BITOR, @@ -2199,6 +2197,8 @@ void Test::testFunctionLists() AVEDEV, AVERAGE, AVERAGEA, +AVERAGEIF, +AVERAGEIFS, B, BETADIST, BETAINV, diff --git a/sc/source/ui/src/scfuncs.src b/sc/source/ui/src/scfuncs.src index 7c3922e..b054a6d 100644 --- a/sc/source/ui/src/scfuncs.src +++ b/sc/source/ui/src/scfuncs.src @@ -3007,7 +3007,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS1 ExtraData = { 0; -ID_FUNCTION_GRP_MATH; +ID_FUNCTION_GRP_STATISTIC; U2S( HID_FUNC_AVERAGEIF ); 3; 0; 0; 1; 0; @@ -3088,7 +3088,7 @@ Resource RID_SC_FUNCTION_DESCRIPTIONS1 ExtraData = { 0; -ID_FUNCTION_GRP_MATH; +ID_FUNCTION_GRP_STATISTIC; U2S( HID_FUNC_AVERAGEIFS ); PAIRED_VAR_ARGS+1; 0; 0; 0; 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Automatic Cleanup
Hi All, Just a heads up that shortly I will be doing a mass response for needinfo bugs as well as closing old ones that haven't been touched despite getting a request to add additional info. Apologies for any clutter. All the Best, Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] Microsoft Installer Error 1937 with TB 39 Windows builds of master for failing assembly signature(s) -- fdo 69601
Hi ape ape wrote Look the log file on the page: http://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTERfull-log=1379905201.19567 . Rows 169, 170 and 171 show that Kendy builds TB#39 MSI package for The Vista OS, Windows-7 and Windows-8: 169 checking for Windows SDK... found Windows SDK 8.0 (/cygdrive/c/PROGRA~2/WI3CF2~1/8.0) 170 configure: WARNING: If a build created with VS 2012 should run on Windows XP, 171 configure: WARNING: use --with-windows-sdk=7.1A (requires VS 2012 Update 1 or newer). Ok. The question is why? What is the point of disabling XP suport? Is TDF going to drop support for XP before Microsoft? Are the major changes being carried out (like OpenCL) incompatible with Windows XP? ape wrote Windows XP users have a rest from the tests. Yep. No problem ;) Pedro -- View this message in context: http://nabble.documentfoundation.org/Microsoft-Installer-Error-1937-with-TB-39-Windows-builds-of-master-for-failing-assembly-signature-s-1-tp4075051p4075101.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Microsoft Installer Error 1937 with TB 39 Windows builds of master for failing assembly signature(s) -- fdo 69601
Hi Pedro, *, Am 23.09.2013 12:16 schrieb Pedro pedl...@gmail.com: ape wrote 170 configure: WARNING: If a build created with VS 2012 should run on Windows XP, 171 configure: WARNING: use --with-windows-sdk=7.1A (requires VS 2012 Update 1 or newer). Ok. The question is why? What is the point of disabling XP suport It is the contrary - before the change that added the warning, you couldn't target XP when using current version of visual studio. Visual studio is what didn't support XP, the LibreOffice code does. Only since Visual Studio Update it is possible to compile for XP. It is a build system thing, just like you cannot run distro built versions of LO on other distros that are older (or even the older release of the same distro) One of the goals of tinderboxes is to check compilation on many different build configurations after all. Ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Microsoft Installer Error 1937 with TB 39 Windows builds of master for failing assembly signature(s) -- fdo 69601
Hi Christian Christian Lohmaier-3 wrote Ok. The question is why? What is the point of disabling XP suport It is the contrary - before the change that added the warning, you couldn't target XP when using current version of visual studio. Visual studio is what didn't support XP, the LibreOffice code does. Only since Visual Studio Update it is possible to compile for XP. It is a build system thing, just like you cannot run distro built versions of LO on other distros that are older (or even the older release of the same distro) One of the goals of tinderboxes is to check compilation on many different build configurations after all. Thank you for the clarification. Looking forward to new builds that work under XP ;) Best regards, Pedro -- View this message in context: http://nabble.documentfoundation.org/Microsoft-Installer-Error-1937-with-TB-39-Windows-builds-of-master-for-failing-assembly-signature-s-1-tp4075051p4075110.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Microsoft Installer Error 1937 with TB 39 Windows builds of master for failing assembly signature(s) -- fdo 69601
Michael Stahl-2 wrote where do you get the idea that support for XP would be dropped from release builds now? clearly the problem is just a badly configured tinderbox, perhaps it has the non-updated release VS 2012 installed that only has the 8.0 sdk. Let's see: in August there were 3 tinderboxes producing binaries for Windows. Only one produced binaries that worked under XP. Since September 9th that tinderbox stopped producing any binaries and yet the other two continued to produce Win7+ binaries. So, it is not a single badly configured tinderbox... In fact from a user perspective it was the opposite: it was a single properly configured tinderbox :) Andras explained there were some problems http://nabble.documentfoundation.org/Why-no-daily-master-builds-tp4073881.html but Christian finally provided a clear explanation http://nabble.documentfoundation.org/Microsoft-Installer-Error-1937-with-TB-39-Windows-builds-of-master-for-failing-assembly-signature-s-1-tt4075051.html#a4075107 Thanks! -- View this message in context: http://nabble.documentfoundation.org/Microsoft-Installer-Error-1937-with-TB-39-Windows-builds-of-master-for-failing-assembly-signature-s-1-tp4075051p4075114.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Microsoft Installer Error 1937 with TB 39 Windows builds of master for failing assembly signature(s) -- fdo 69601
Michael, My experiences related to the fact that changes have been made to the code. These changes improve The LibO-4.2 interact with Windows Explorer 7 and 8. I would like to make sure that this does not disrupt Windows XP Explorer. But I can't do it. I think that comprehensive verification is needed before the master-libreoffice-dev code will be freeze. Computers of Luboš Lunak and Fridrich Strba have the necessary configuration. But these two respected person, I think, now suspended by the employer (SuSE). Work on the project was only a hobby for them. This conclusion I did, when I saw the changes in mailing addresses of many members of The Community to “collabora”. Sincerely Yours, ape -- View this message in context: http://nabble.documentfoundation.org/Microsoft-Installer-Error-1937-with-TB-39-Windows-builds-of-master-for-failing-assembly-signature-s-1-tp4075051p4075115.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 68742] FILEOPEN: XML Calc import ignore leading spaces the same way as MSO2003
https://bugs.freedesktop.org/show_bug.cgi?id=68742 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Severity|normal |enhancement Priority|medium |lowest --- Comment #2 from Mike Kaganski mikekagan...@hotmail.com --- According to current XML 1.0 specs (http://www.w3.org/standards/techs/xml), no white space is allowed before the XML declaration. Microsoft agrees with that, too: see http://msdn.microsoft.com/en-us/library/ms256097.aspx The fact that LO follows the standard more strictly then a MS product is not a bug. At most, this issue may be a feature request to relax this a bit, but it may be WONTFIX (personally I would vote for this). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69678] TABLE: Wrong text position after rotating it in tables
https://bugs.freedesktop.org/show_bug.cgi?id=69678 --- Comment #3 from ign_christian ign_christ...@yahoo.com --- Comment 1 = Bug 34436 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63996] EDITING: Grammer checker
https://bugs.freedesktop.org/show_bug.cgi?id=63996 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #3 from Kumāra kumara.bhik...@gmail.com --- Try LanguageTool (www.languagetool.org) extension. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68467] Other: Font (Frutiger family) is displayed wrong on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=68467 --- Comment #3 from whoever bugzi...@ruben-online.ch --- (In reply to comment #1) It is probably obvious, but to be sure I prefer to ask: are you sure that this fonts are installed on your system? You can check that in LibreOffice: select some text that is formated with this font and click on the menu Format Character then select the Font tab -- It should say that the same font will be used for printing and screen viewing. Best regards. JBF It is written there, that the same font will be used - thus, this could not fix my problem -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68467] Other: Font (Frutiger family) is displayed wrong on Mac OS X
https://bugs.freedesktop.org/show_bug.cgi?id=68467 --- Comment #4 from whoever bugzi...@ruben-online.ch --- (In reply to comment #2) Using OS X 10.8.5 I cannot find any Frutiger Font on my system. Regarding the cursor issue. I remember this bug when the transition was made to CoreText. But it's been resolved for me with the latest LO releases. Could you please check if this problem persists when using Version: 4.1.1.2? http://www.libreoffice.org/download/ I've tested it with 4.1.1.2 - and the problem was still existing. I've tested now the same with 4.1.2.2 (RC), and the problem was still existing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50528] AutoCorrect Options does not take over formatting of text into replace with field
https://bugs.freedesktop.org/show_bug.cgi?id=50528 daniel.ma...@umb.no changed: What|Removed |Added Summary|AutoCorrect Options does|AutoCorrect Options does |not take over marked text |not take over formatting of |into replace with field |text into replace with ||field -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61177] EXTENSION: LightProof Grammar Checker: Spell check don't correct reversed space and punctuation
https://bugs.freedesktop.org/show_bug.cgi?id=61177 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #4 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #3) I can't find any recent version of LightProof Grammar Checker. All seems quite 'old' (3 years not updated). It's not likely this extension will be updated anymore. Therefore I recommend to try the LanguageTool (http://extensions.libreoffice.org/extension-center/languagetool). This is also a great grammar extension which will probably be as good as the LightProof, or even better. Because I'm not that familiar with both tools, can you give us feedback this extension is sufficient and cover all features of LightProof? Having used, LanguageTools (www.languagetool.org) for some time, I can vouch that it is better than LightProof (which does very little). LT is also improving. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 63716] Problems in spelling and grammar checking, completeness of dictionary, accuracy of wordforms recognition, hyphenation, etc.
https://bugs.freedesktop.org/show_bug.cgi?id=63716 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #8 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #7) It worth noting that the dictionary was not updated since 1990s and lack elementary features introduced after ispell: compounding, profanity filtering, Ye/Yo control, etc. The best course of action in this situation would be dropping the bundled dictionary as unmaintainable and delegate the Russian spellcheck functions to 3rd party extensions. For grammar, the LanguageTool (www.languagetool.org) extension currently has 217 rules for Russian. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69658] FILEOPEN: DOCX Import of vertical text-box turns to horizontal text-box
https://bugs.freedesktop.org/show_bug.cgi?id=69658 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | --- Comment #3 from Miklos Vajna vmik...@collabora.co.uk --- I'll have a look later this week. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50528] AutoCorrect Options does not take over formatting of text into replace with field
https://bugs.freedesktop.org/show_bug.cgi?id=50528 daniel.ma...@umb.no changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- Version|unspecified |4.1.2.2 rc Ever confirmed|0 |1 --- Comment #3 from daniel.ma...@umb.no --- @Mike: Thank you for introducing unnecessary bureaucracy. Please tell me how I can file an enhancement request in a bug report system. I edited the title of the bug to reflect on the actual issue. For some reason, Writer does not copy formatting into AutoCorrect any more (v4.1.2.2). Since AutoCorrect offers an option to only replace text, and not text with formatting, I assume this to be an actual bug. In Calc, Impres, ... the Text only option is grayed out, so I cannot claim the loss of formatting to be a bug. Instead, I would like to request this as a feature! (And again, I _hate_ that different parts of LibreOffice show different behavior! It is very confusing to the user...) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53861] libXinerama.so.1 Needed with --headless
https://bugs.freedesktop.org/show_bug.cgi?id=53861 --- Comment #3 from Riccardo Magliocchetti riccardo.magliocche...@gmail.com --- --headless is a runtime option so you should not make any assumption on which libraries your libo was linked against. Missing dependency could possibly have been a packaging issue so please give a try to a modern version to see if it has been fixed in the meantime. If you don't want to link to X libraries you should give a try building 4.1 with --enable-headless. Am not aware of any distribution providing packages that don't link to X / cairo / toolkits. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69415] Connector lines losing format on save and re-open
https://bugs.freedesktop.org/show_bug.cgi?id=69415 --- Comment #1 from ralf.kr...@bluewin.ch --- I can confirm this bug on Win7 V4.1.1.2. This is really an annoying bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56478] EDITING: Applying of a style does not have an effect
https://bugs.freedesktop.org/show_bug.cgi?id=56478 --- Comment #18 from hae...@cosifan.de --- maybe this is related, even though I have a completety different system (openSuSE 12.3, XFCE 4.10, LO 4.0) as I am using X11 I am using its copy/paste via middle mouse only How to reproduce: - copy/paste per X11 method from a website opened in Firefox (middle mouse key inserts) - mark the inserted paragraph or part of it and select another paragraph style (e.g. 'standard' which for me is courier 8) - right click = 'clear direct formatting' does not change anything (as well as CtrlM does not) when using a simple text editor like vi or geany in between there is of course no external formatting possible and I am able to modify the style of the pasted content at will -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43729] EDITING: Cannot write accented characters after entering full screen
https://bugs.freedesktop.org/show_bug.cgi?id=43729 --- Comment #11 from Foss f...@openmailbox.org --- Thanks for testing and updating this bug. Should it re-appear you can re-open this bug. Glad things are working now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69415] Connector lines losing format on save and re-open
https://bugs.freedesktop.org/show_bug.cgi?id=69415 Derek Keats de...@dkeats.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35746] Spelling and grammar mistakes prevent right-clicking on changes
https://bugs.freedesktop.org/show_bug.cgi?id=35746 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #7 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #6) Confirmed. I reopen this issue. Why not just disable the checker temporarily? I have the autochecker icon on the toolbar for my convenience. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69665] Wrong start-up icon opening ODF files (ODS, ODT, ODB)
https://bugs.freedesktop.org/show_bug.cgi?id=69665 --- Comment #8 from Foss f...@openmailbox.org --- Thanks for updating this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45860] *.docx documets produces General Input/Output error
https://bugs.freedesktop.org/show_bug.cgi?id=45860 Foss f...@openmailbox.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Foss f...@openmailbox.org --- Tested on Ubuntu 13.04 LO 4.1.0.3. Document opens fine. Setting to WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36540] Striketrough is ignored by LanguageTool
https://bugs.freedesktop.org/show_bug.cgi?id=36540 --- Comment #16 from Kumāra kumara.bhik...@gmail.com --- Created attachment 86340 -- https://bugs.freedesktop.org/attachment.cgi?id=86340action=edit Snapshot showing bug Attaching examples that might clarify the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36540] Striketrough is ignored by LanguageTool
https://bugs.freedesktop.org/show_bug.cgi?id=36540 --- Comment #17 from Kumāra kumara.bhik...@gmail.com --- Created attachment 86342 -- https://bugs.freedesktop.org/attachment.cgi?id=86342action=edit The dog is is running -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47690] Built-in Grammar Checker Does Not Complain About I can understanding English.
https://bugs.freedesktop.org/show_bug.cgi?id=47690 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #3 from Kumāra kumara.bhik...@gmail.com --- XiaoJun, I'm happy to report to you that with the LanguageTool (www.languagetool.org) extension, you would get a blue wavy line for understanding! (In current inbuilt LightProof doesn't do much.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50012] FILEOPEN: Input/output error
https://bugs.freedesktop.org/show_bug.cgi?id=50012 Foss f...@openmailbox.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Foss f...@openmailbox.org --- Document opens fine on OS X 10.8.5, LO 4.1.1.2. Also Ubuntu 13.04, LO 4.1.0.3 works great. Pavel could you check the latest LO 4.1.x release and see if that works for you? Which windows are you on? Maybe windows only? And you might want to update your Java. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53329] FILESAVE: After I resave an xlsm file, it become corrupt
https://bugs.freedesktop.org/show_bug.cgi?id=53329 --- Comment #3 from Ákos nagy.a...@libreoffice.ro --- I try it with LibreOffice 4.1.2 RC2, after modify the file, I can open it in LibreOffice 4.1.2 RC2 but I can't open it in Microsoft Excel 2013. I got the error: Excel cannot open the file '...' because the file format or the file extension is not valid. Verify that the file has not been corrupted and that the file extension matches the format of the file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50012] FILEOPEN: Input/output error
https://bugs.freedesktop.org/show_bug.cgi?id=50012 Foss f...@openmailbox.org changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Foss f...@openmailbox.org --- Setting to WORKSFORME. Please re-open if you still run into the input/output error. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42935] Ease to open spelling options while editing a document with no misspelled words.
https://bugs.freedesktop.org/show_bug.cgi?id=42935 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #7 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #4) I believe a second button in the Spellcheck conmplete message might do the job? Currently we only have ok, when you click it the Spellcheck dialog disappears. A second Button Settings or similar that opens a spellcheck options dialog would ease handling. Agree. Alternately: Add Tools - Spelling and Grammar Options... It's so deep in Options that people may not find it. If they do, it's indeed annoying for people who need to access it frequently. Typing a non-word to get at it is much faster! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35748] spelling and grammar checker uses deleted characters when showing changes
https://bugs.freedesktop.org/show_bug.cgi?id=35748 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #8 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #7) Confirmed. I reopen this issue. Deleted text shouldn’t be sent to the grammar checker. Is this bug still valid for you? Can you check if Bug 36540 is describing the same issue? If so, please mark this as duplicate of that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36540] Striketrough is ignored by LanguageTool
https://bugs.freedesktop.org/show_bug.cgi?id=36540 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #18 from Kumāra kumara.bhik...@gmail.com --- (In reply to comment #0) LanguageTool for correcting grammar is ignoring strikethrough and because of that doesn't work properly when recording and showing changes is turned on. By strikethrough, do you mean the kind created by record changes, or a character attribute (e.g. bold, underline, strikethrough)? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69695] New: Not able to fill forms in doc file
https://bugs.freedesktop.org/show_bug.cgi?id=69695 Priority: medium Bug ID: 69695 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Not able to fill forms in doc file Severity: normal Classification: Unclassified OS: All Reporter: suokunl...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.1.2.2 rc Component: Writer Product: LibreOffice Description: Some forms in certern *.doc file can not be filled when open with L.O. Steps to re-produce: 1. Download and open the doc file from the following link: http://www.usitc.gov/trade_remedy/731_ad_701_cvd/investigations/2013/msg/preliminary/DOC/MSG_Foreign%20Producer%20Questionnaire.doc You will see the file can just be open read-only. 2. Try to fill the text forms (type in some text in the grayed parts) Current behavior: The forms can not be filled (Check boxes seems OK). If you right-click - Edit, it asks for password, while in MS Office and Kingsoft Office you can input text directly. Expected: The forms should be filled as we can in MS Office and other office suites. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45505] FILESAVE: Gradients corrupted on export to PDF
https://bugs.freedesktop.org/show_bug.cgi?id=45505 --- Comment #5 from Pierre-Eric Pelloux-Prayer pierre-e...@lanedo.com --- @Richard Corner: this problem should be fixed in the next LibreOffice version (at least for linear and axial gradients). You can also help by testing daily versions (http://dev-builds.libreoffice.org/daily/master/) to make sure your problem is properly fixed. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56723] : Problem with sumproduct between 3.5 vs 3.6
https://bugs.freedesktop.org/show_bug.cgi?id=56723 Jens S j...@tdcspace.dk changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jens S j...@tdcspace.dk --- SUMPRODUCT is not the problem. It is the way you use the function DATEVALUE you will find the problem. DATEVALUE now need a localized text-string like 1-1 or what else you have defined under Function - Options - Language - Dateinput pattern (which should be something like this for most EU-countries: D-;D-M;D-M-Y). Furthermore you should know that DATEVALUE(1-1) only refer to the current year (2013) and your table is from 2012. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57968] Not able to open XML spreadhseet
https://bugs.freedesktop.org/show_bug.cgi?id=57968 Foss f...@openmailbox.org changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Foss f...@openmailbox.org --- Hi, could you try the latest LO release? http://www.libreoffice.org/download/ Does that work? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69690] EDITING: Frame Gradient
https://bugs.freedesktop.org/show_bug.cgi?id=69690 --- Comment #1 from Foss f...@openmailbox.org --- Can you post exact steps to reproduce with exact menu entries please. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61961] PDF export: Radio buttons created in the same group in LibreOffice aren't exported as a group in PDF
https://bugs.freedesktop.org/show_bug.cgi?id=61961 --- Comment #5 from subscr...@gmail.com --- In libreoffice 4.0.4 (writer) I have the same problem, however I found a way to make it work. The group property must be empty, the name of the radios must be the same, preferably the standard name for radio buttons (in Italian: Pulsante di scelta #) as a different name seemed not to work. Honestly I didn't spend much time debugging or trying to determine if this is intended but I thought it was worth adding this report here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69696] borders of a text frame are not displayed in normal view, but are displayed in page preview
https://bugs.freedesktop.org/show_bug.cgi?id=69696 --- Comment #1 from bordfe...@web.de --- Created attachment 86345 -- https://bugs.freedesktop.org/attachment.cgi?id=86345action=edit screenshot of normal view -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69696] borders of a text frame are not displayed in normal view, but are displayed in page preview
https://bugs.freedesktop.org/show_bug.cgi?id=69696 bordfe...@web.de changed: What|Removed |Added Attachment #86344|text/plain |text/odt mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69696] borders of a text frame are not displayed in normal view, but are displayed in page preview
https://bugs.freedesktop.org/show_bug.cgi?id=69696 --- Comment #2 from bordfe...@web.de --- Created attachment 86346 -- https://bugs.freedesktop.org/attachment.cgi?id=86346action=edit screenshot of page preview -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60530] Allow user to disable spellchecker and grammar in current document only (not global settings)
https://bugs.freedesktop.org/show_bug.cgi?id=60530 --- Comment #3 from Kumāra kumara.bhik...@gmail.com --- If you set the language of the paragraph style as [None] (instead of English while you use the English spellchecker), the spellchecker will ignore the words. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69696] New: borders of a text frame are not displayed in normal view, but are displayed in page preview
https://bugs.freedesktop.org/show_bug.cgi?id=69696 Priority: medium Bug ID: 69696 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: borders of a text frame are not displayed in normal view, but are displayed in page preview Severity: normal Classification: Unclassified OS: Linux (All) Reporter: bordfe...@web.de Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.1.1.2 release Component: Writer Product: LibreOffice Created attachment 86344 -- https://bugs.freedesktop.org/attachment.cgi?id=86344action=edit the document with the text frame LO 4.1.1.2 on Ubuntu 12.04 I have a document with a text frame. This text frame has a border. In normal view this border is not displayed. In page preview the border is displayed correctly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59886] FILESAVE as .docx: Date (fixed), Time (fixed) fields become static field name text
https://bugs.freedesktop.org/show_bug.cgi?id=59886 --- Comment #4 from suokunl...@gmail.com --- Created attachment 86347 -- https://bugs.freedesktop.org/attachment.cgi?id=86347action=edit the ODT file with data and time field -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49151] PDF export of Empty sheet causes error message, PRINTING fails silently
https://bugs.freedesktop.org/show_bug.cgi?id=49151 Marc m...@blocstac.com changed: What|Removed |Added See Also||https://www.libreoffice.org ||/bugzilla/show_bug.cgi?id=4 ||2166 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50528] AutoCorrect Options does not take over formatting of text into replace with field
https://bugs.freedesktop.org/show_bug.cgi?id=50528 --- Comment #4 from Mike Kaganski mikekagan...@hotmail.com --- (In reply to comment #3) @Mike: Thank you for introducing unnecessary bureaucracy. You are welcome. But aside the sarcasm, you should know that the bug tracker is a tool that enables developers to fix bugs that users report. And in order to be efficient, this tool needs some rules to follow. One of them is one issue per one report. If it is ignored, the report having multiple problems mixed up is practically impossible to track if it is fixed or not, and in which stage the work on it. It doesn't make life better (neither user's nor developers) to bring the report to unusable state by cluttering it with different problems. Please tell me how I can file an enhancement request in a bug report system. You just need to set the severity field (in this particular issue it is currently set to normal) to enhancement. I edited the title of the bug to reflect on the actual issue. As I tried to describe a few lines above, this step is useless. You experience a number of issues, and each one should be tracked separately (or otherwise you risk to be unable to attract any developers to fix them). If I understand it, in some earlier versions, the selected text wasn't copied to replace field at all. If this is true, and this works now, then this issue should be closed as WORKSFORME (this means that this issue was fixed by an unknown commit), and should not be reused for other, however related, issues. Only if I misunderstood the initial report, and the problem was the lack of formatting in copied autocorrect item, then this issue could be rightfully reopened. For some reason, Writer does not copy formatting into AutoCorrect any more (v4.1.2.2). Since AutoCorrect offers an option to only replace text, and not text with formatting, I assume this to be an actual bug. As I said in comment 2, this specific problem was already fixed. The fix should be available in 4.1.3. In Calc, Impres, ... the Text only option is grayed out, so I cannot claim the loss of formatting to be a bug. Instead, I would like to request this as a feature! (And again, I _hate_ that different parts of LibreOffice show different behavior! It is very confusing to the user...) I agree with you. This is very annoying for me, too, and creates troubles to my co-workers (we use LO at work for quite some time). Although we don't encounter problems in this specific area, this seems to be a valid enhancement request, that I urge you to file as a separate report. I don't close this bug, but please do it yourself if this sounds reasonable. Thank you for your time reporting problems! This really makes the software better. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59886] FILESAVE as .docx: Date (fixed), Time (fixed) fields become static field name text
https://bugs.freedesktop.org/show_bug.cgi?id=59886 --- Comment #5 from suokunl...@gmail.com --- Created attachment 86348 -- https://bugs.freedesktop.org/attachment.cgi?id=86348action=edit the same file saved as .DOCX (MS OFFICE 2007/2010) Date and time fields become Date (fixed) and Time (Fixed) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69697] New: Background color messed with numbered paragraphs
https://bugs.freedesktop.org/show_bug.cgi?id=69697 Priority: medium Bug ID: 69697 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Background color messed with numbered paragraphs Severity: normal Classification: Unclassified OS: Linux (All) Reporter: kaese...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.1.2.1 rc Component: Writer Product: LibreOffice Created attachment 86349 -- https://bugs.freedesktop.org/attachment.cgi?id=86349action=edit example with screenshots This is how to recreate the bug: 1) open attached document and go to page 1 2) move the mouse pointer between 1.1 and 1.1 XXX of 1.1 and click left mouse button 3) move the mouse pointer down to directly behind XXX of 2.2.1 and release mouse button 4) click backround color button for yellow background. The result is shown in the upper screenshot on page 2 when what one would want to see is on the lower screenshot. That result can only be obtained with a second highlighting etc. process that does NOT begin in a numbered paragraph. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49151] PDF export of Empty sheet causes error message, PRINTING fails silently
https://bugs.freedesktop.org/show_bug.cgi?id=49151 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from ign_christian ign_christ...@yahoo.com --- *** This bug has been marked as a duplicate of bug 42166 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42166] PDF export of an empty Calc document gives an error
https://bugs.freedesktop.org/show_bug.cgi?id=42166 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #8 from ign_christian ign_christ...@yahoo.com --- *** Bug 49151 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56306] Add an option in the Grammar checker to allow double spaces at end of sentences
https://bugs.freedesktop.org/show_bug.cgi?id=56306 Kumāra kumara.bhik...@gmail.com changed: What|Removed |Added CC||kumara.bhik...@gmail.com --- Comment #2 from Kumāra kumara.bhik...@gmail.com --- Perhaps you'd like to use the LanguageTool (www.languagetool.org) extension for grammar checking instead. It only complains when you have 3 spaces after a full stop. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69698] New: Some format settings in charts are not saved
https://bugs.freedesktop.org/show_bug.cgi?id=69698 Priority: medium Bug ID: 69698 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Some format settings in charts are not saved Severity: normal Classification: Unclassified OS: Linux (All) Reporter: nefil...@yahoo.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.0.4.2 release Component: Chart Product: LibreOffice Created attachment 86351 -- https://bugs.freedesktop.org/attachment.cgi?id=86351action=edit Compare the 3 charts on the left-hand side and the images on the right-hand side : it is impossible to save the charts with these formattings. Hello. I have been working on compilling some scientific data and making some charts to present them as stock charts. I edited them to format the data series (changing the line widths and colours of the stock charts). When I save and re-open the file, all these hand-made formating is gone. I tried several times, only repeating the problem every time. I have attached the file. By luck, I had exported the charts as images (to import them in LO Writer) before closing the file. I have included the images side by side to the charts in the spreadsheet so you can compare and see what are the changes that are impossible to save. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs