LibreOffice Gerrit News for core on 2013-11-02
Moin! * Open changes on master for project core changed in the last 25 hours: + fdo#71081 add Excel 2010 functions BINOM.DIST and BINOM.INV in https://gerrit.libreoffice.org/6521 from Winfried Donkers + [docx] CustomXml saved in InteropGrabBag and exported customxml when savi in https://gerrit.libreoffice.org/6519 from Sushil Shinde + windows: check for _WIN32 and _WIN64 in https://gerrit.libreoffice.org/6490 from Thomas Arnhold + Windows: Set minimum Windows SDK to 0x0502 (Windows XP SP2) in https://gerrit.libreoffice.org/6496 from Thomas Arnhold + fdo#63819 Ctrl+Backspace also deletes the space before the word in https://gerrit.libreoffice.org/6518 from Samuel Mehrbrodt * Merged changes on master for project core changed in the last 25 hours: + Unit test for Docx Chart Series Name in https://gerrit.libreoffice.org/6502 from Vinaya Mandke + Better approach for fdo#40077: Characters cropped in GTK-Combobox in https://gerrit.libreoffice.org/6478 from Samuel Mehrbrodt + i#118517# - Update twain to version 2.1 with support for Apple and UNIX. in https://gerrit.libreoffice.org/6508 from Thomas Arnhold + remove nonsense FOLD comments in https://gerrit.libreoffice.org/6491 from Thomas Arnhold + fdo#70998 Termchange: Graphics-Image in https://gerrit.libreoffice.org/6483 from Samuel Mehrbrodt + fdo#68414: SIDEBAR: property's Text named incorrectly in https://gerrit.libreoffice.org/6480 from Julien Nabet * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + Make ./autogen.sh --help work again in https://gerrit.libreoffice.org/6100 from Arnaud Versini + Make libatomic_ops buildable and enable on non-X86. in https://gerrit.libreoffice.org/5812 from Andrzej J.R. Hunt + Increase number of remembered recent documents from 10 to 25 in https://gerrit.libreoffice.org/6101 from Krisztian Pinter + startcenter: Make SC open faster by timeouting thumbnails in https://gerrit.libreoffice.org/6102 from Krisztian Pinter + Remove old outdated gallery images and sounds in https://gerrit.libreoffice.org/4993 from Samuel Mehrbrodt + Remove more unusedcode in https://gerrit.libreoffice.org/5937 from Marcos Souza + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + Dynamically align toolbars in LibreOffice in https://gerrit.libreoffice.org/5655 from Prashant Pandey + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + more debug logs, extra debug layer, file is not used in p3k in https://gerrit.libreoffice.org/5267 from James Michael Dupont + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn + fdo#64817 : fix for rectangle with image fill in https://gerrit.libreoffice.org/4718 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 63154] replace tools/solar.h macros with osl versions
https://bugs.freedesktop.org/show_bug.cgi?id=63154 --- Comment #31 from Marcos Souza marcos.souza@gmail.com --- Can I removed finally the DELETEZ macro too? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #2 from José Guilherme Vanz v...@libreoffice.org --- Created attachment 88526 -- https://bugs.freedesktop.org/attachment.cgi?id=88526action=edit stack_result This is the results after ran stack on libreoffice code. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #3 from José Guilherme Vanz v...@libreoffice.org --- Can we start change the code where stack warned us? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #4 from Tor Lillqvist t...@iki.fi --- Great! But give people a chance to look in detail at the results first. Actually, the developer mailing list would be best for discussion about this, I think? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043
--- Comment #5 from Tor Lillqvist t...@iki.fi ---
Whee, yes, the results looks indeed quite interesting, even if it takes a
(short) while to understand what they are trying to say. Just look at the first
thing reported, in sal/osl/unx/pipe.c:
in __osl_createPipeImpl():
pPipeImpl = (oslPipe)calloc(1, sizeof(struct oslPipeImpl));
pPipeImpl-m_nRefCount =1;
...
return pPipeImpl;
Note that there is no check whether calloc() fails. The code immediately
dereferences the returned pointer (which might in theory be NULL, in which case
the dereferencing will cause a crash of course). The pointer is returned as the
function value.
So let's look at the reported call site of __osl_createPipeImpl():
pAcceptedPipe= __osl_createPipeImpl();
OSL_ASSERT(pAcceptedPipe);
if(pAcceptedPipe==NULL)
{
close(s);
return NULL;
}
Ha! The checks whether pAcceptedPipe is NULL are totally pointless as we have
already dereferenced it inside __osl_createPipeImpl(), so it can't be NULL, and
the whole if statement will be optimised away by a modern compiler.
Now, what to do in this particular case then is a question of taste, more or
less.
Personally I think that if a memory allocation (of a small amount of memory)
fails at this place in the code, which as far as I know is invoked mainly
(only?) very early when LO is starting, something is very wrong and there is no
point in even trying to recover gracefully from the memory allocation failure.
So let __osl_createPipeImpl() be as is and remove the pointless checks for NULL
return after the calls to it.
But I assume there is an opposite opinion, too, that each and every memory
allocation should be checked and the code should do its utmost to fail
gracefully... In that case, the check for memory allocation failure should be
moved inside __osl_createPipeImpl() right after the call to calloc(), and in
case of failure, NULL should be returned immediately. Hopefully then the return
value of __osl_createPipeImpl() is checked in each case.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #6 from Tor Lillqvist t...@iki.fi --- Reading more of the report, it seems truncated and/or a bit useless? Everything else in it is related to external (bundled) sources, not sure if we want to bother with fixing those? And then there are thousands of repeated LLVM ERROR: Bad DataLayout ctor used. Tool did not specify a DataLayout to use? lines at the end. Is our C++ code somehow too pathological for this tool? (That would not be surprising of course... this codebase has been breaking toolchains for a quarter of a century I think;) Anyway, yay, this is a great start, but for the majority of our codebase it seems that the tool fails, so that needs to be investigated in detail. (By looking at what happens when just one single source file is run through the tool, and either sending a bug report to the STACK maintainers and hoping they can fix it, or figure out what we need to to do work around the problem.) -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 1db25c330abdc5f3c3b27a6b4029f306ab497af1
Author: Eike Rathke er...@redhat.com
Date: Fri Nov 1 12:47:49 2013 +0100
fixed out-of-bounds string access when backspacing in a formula
Change-Id: Ic586ce857574e1d28e0e4d754bea0d5251d0efdf
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index de88da3..eaa05a1 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -967,7 +967,7 @@ void ScInputHandler::ShowTipCursor()
findText(*pFormulaDataPara, pFormulaDataPara-end(),
aText, aNew, false);
if (it != pFormulaDataPara-end())
{
-if( aFormula[ nPosition ] =='(' )
+if( nPosition aFormula.getLength() aFormula[
nPosition ] =='(' )
{
ShowTipBelow( aNew );
bFound = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/fake_pom.xml bin/mvn.py
bin/fake_pom.xml |6 +
bin/mvn.py | 60 +++
2 files changed, 66 insertions(+)
New commits:
commit 78e4b97a18a18f84c228de64fc48cee48138fbfe
Author: David Ostrovsky da...@ostrovsky.org
Date: Sun Oct 27 20:32:40 2013 +0100
Set up tool chain to install LO artifacts in Maven repositories
Add path_to_libo/bin to your path.
After full LO compile, the LO Java artifacts can be installed in the local
Maven repository:
mvn.py -a install -v 4.2.0 -s juh:jar:path_to/juh.jar
mvn.py -a install -v 4.2.0 -s jurt:jar:path_to/jurt.jar
mvn.py -a install -v 4.2.0 -s ridl:jar:path_to/ridl.jar
mvn.py -a install -v 4.2.0 -s unoil:jar:path_to/unoil.jar
With the artifacts installed this way, it is now possible
to consume LO artifacts from custom pom.xml:
[...]
properties
LibreOffice-Version4.2.0/LibreOffice-Version
/properties
[...]
dependencies
dependency
groupIdorg.libreoffice/groupId
artifactIdjuh/artifactId
version${LibreOffice-Version}/version
scopeprovided/scope
/dependency
dependency
groupIdorg.libreoffice/groupId
artifactIdjurt/artifactId
version${LibreOffice-Version}/version
scopeprovided/scope
/dependency
dependency
groupIdorg.libreoffice/groupId
artifactIdridl/artifactId
version${LibreOffice-Version}/version
scopeprovided/scope
/dependency
dependency
groupIdorg.libreoffice/groupId
artifactIdunoil/artifactId
version${LibreOffice-Version}/version
scopeprovided/scope
/dependency
/dependencies
Change-Id: I2ad982ae23c78242ed8f1ac4c88c6be424cc7a0d
Reviewed-on: https://gerrit.libreoffice.org/6453
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/bin/fake_pom.xml b/bin/fake_pom.xml
new file mode 100644
index 000..50599f3
--- /dev/null
+++ b/bin/fake_pom.xml
@@ -0,0 +1,6 @@
+project xmlns=http://maven.apache.org/POM/4.0.0;
+ modelVersion4.0.0/modelVersion
+ groupIdorg.libreoffice/groupId
+ artifactIdLibreOffice-Maven/artifactId
+ version1/version
+/project
diff --git a/bin/mvn.py b/bin/mvn.py
new file mode 100755
index 000..d5a1c9a
--- /dev/null
+++ b/bin/mvn.py
@@ -0,0 +1,60 @@
+#!/usr/bin/python
+# This file is part of the LibreOffice project.
+#
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+
+from __future__ import print_function
+from optparse import OptionParser
+from os import path
+from sys import stderr
+try:
+ from subprocess import check_output
+except ImportError:
+ from subprocess import Popen, PIPE
+ def check_output(*cmd):
+return Popen(*cmd, stdout=PIPE).communicate()[0]
+opts = OptionParser()
+opts.add_option('--repository', help='maven repository id')
+opts.add_option('--url', help='maven repository url')
+opts.add_option('-a', help='action (valid actions are: install,deploy)')
+opts.add_option('-v', help='libreoffice version')
+opts.add_option('-s', action='append', help='triplet of artifactId:type:path')
+
+args, ctx = opts.parse_args()
+if not args.v:
+ print('version is empty', file=stderr)
+ exit(1)
+
+common = [
+ '-DgroupId=org.libreoffice',
+ '-Dversion=%s' % args.v,
+]
+
+self = path.dirname(path.abspath(__file__))
+mvn = ['mvn', '--file', path.join(self, 'fake_pom.xml')]
+
+if 'install' == args.a:
+ cmd = mvn + ['install:install-file'] + common
+elif 'deploy' == args.a:
+ cmd = mvn + [
+'deploy:deploy-file',
+'-DrepositoryId=%s' % args.repository,
+'-Durl=%s' % args.url,
+ ] + common
+else:
+ print(unknown action -a %s % args.a, file=stderr)
+ exit(1)
+
+for spec in args.s:
+ artifact, packaging_type, src = spec.split(':')
+ try:
+check_output(cmd + [
+ '-DartifactId=%s' % artifact,
+ '-Dpackaging=%s' % packaging_type,
+ '-Dfile=%s' % src,
+])
+ except Exception as e:
+print('%s command failed: %s' % (args.a, e), file=stderr)
+exit(1)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Problems compiling LO with Visual Studio 2008
Hi Pavel, 2013/11/1 Pavel Laštovička pavel.lastovi...@blue-point.cz Hi Michael, Dne 31.10.2013 22:58, Michael Stahl napsal(a): perhaps you will run into other issues too; since 2008 support was removed completely on master due to the high maintenace effort (uses different project files than newer versions etc.), there is probably little interest in getting the 4-1 branch to build; better to just use a newer MSVC. is it safe to use Express edition of Visual Studio or is Professional edition needed? I recommend you using the Professional Edition if you intend to distribute your build. For development, the Express Edition is fine. Please read carefully the section Getting ATL work with Visual Studio Express here to use ATL in your build: https://wiki.documentfoundation.org/Development/BuildingOnWindows Cheers, -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #7 from José Guilherme Vanz v...@libreoffice.org --- Yeap, analyzing the file more calm I saw what you are saying. Actually, I was a little exciting with the stack, so I posted right after ran the tool. =P About external source I don't know if a good ideia to try fix it. Maybe, send a report for their developers... It's a possibility. And about LLVM ERROR, I have already send a e-mail for stack maintainers. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: config_host.mk.in configure.ac download.lst external/apache-commons RepositoryExternal.mk RepositoryModule_host.mk tomcat/build.xml tomcat/ExternalProject_tomcat.mk tom
RepositoryExternal.mk | 12 ---
RepositoryModule_host.mk |1
config_host.mk.in |2
configure.ac | 33
--
download.lst |1
external/apache-commons/ExternalProject_apache_commons_logging.mk |8 --
external/apache-commons/patches/logging.patch | 24
++-
tomcat/ExternalProject_tomcat.mk | 30
-
tomcat/Makefile |7 --
tomcat/Module_tomcat.mk | 21 --
tomcat/README |1
tomcat/UnpackedTarball_tomcat.mk | 17 -
tomcat/build.xml | 21 --
13 files changed, 22 insertions(+), 156 deletions(-)
New commits:
commit 2c92030ff07aff9b10e49844343390925b81545c
Author: David Ostrovsky da...@ostrovsky.org
Date: Sun Oct 27 23:12:14 2013 +0100
Kill servlet-api and tomcat
Change-Id: I630da3fa37144b2e5fb5117017f43841ba89c42a
Reviewed-on: https://gerrit.libreoffice.org/6454
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index d1b0b08..d3b8dc5 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2873,18 +2873,6 @@ endef
endif # SYSTEM_RHINO
-ifeq ($(SYSTEM_TOMCAT),YES)
-
-gb_ExternalProject__use_servlet_api :=
-
-else # !SYSTEM_TOMCAT
-
-define gb_ExternalProject__use_servlet_api
-$(eval $(call gb_ExternalProject_use_external_project,$(1),tomcat))
-endef
-
-endif # SYSTEM_TOMCAT
-
ifeq ($(SYSTEM_APACHE_COMMONS),YES)
define gb_Jar__use_commons-codec
diff --git a/RepositoryModule_host.mk b/RepositoryModule_host.mk
index 5caf81a..15468c5 100644
--- a/RepositoryModule_host.mk
+++ b/RepositoryModule_host.mk
@@ -136,7 +136,6 @@ $(eval $(call gb_Module_add_moduledirs,libreoffice,\
sysui \
test \
testtools \
- $(call gb_Helper_optional,TOMCAT,tomcat) \
toolkit \
tools \
touch \
diff --git a/config_host.mk.in b/config_host.mk.in
index 7c59597..ddb234a 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -468,7 +468,6 @@ export SAL_ENABLE_FILE_LOCKING=1
export SCPDEFS=@SCPDEFS@
export SDKDIRNAME=@SDKDIRNAME@
export SDKDIRNAME_FOR_BUILD=@SDKDIRNAME_FOR_BUILD@
-export SERVLETAPI_JAR=@SERVLETAPI_JAR@
export SHOWINCLUDES_PREFIX=@SHOWINCLUDES_PREFIX@
export SOLARENV=@SRC_ROOT@/solenv
export SOLARINC=@SOLARINC@
@@ -542,7 +541,6 @@ export SYSTEM_POSTGRESQL=@SYSTEM_POSTGRESQL@
export SYSTEM_PYTHON=@SYSTEM_PYTHON@
export SYSTEM_REDLAND=@SYSTEM_REDLAND@
export SYSTEM_RHINO=@SYSTEM_RHINO@
-export SYSTEM_SERVLETAPI=@SYSTEM_SERVLETAPI@
export SYSTEM_UCPP=@SYSTEM_UCPP@
export SYSTEM_VIGRA=@SYSTEM_VIGRA@
export SYSTEM_VISIO=@SYSTEM_VISIO@
diff --git a/configure.ac b/configure.ac
index e7f7812f..6c1dd73 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1611,16 +1611,6 @@ AC_ARG_WITH(commons-logging-jar,
[Specify path to jarfile manually.]),
COMMONS_LOGGING_JAR=$withval)
-AC_ARG_WITH(system-servlet-api,
-AS_HELP_STRING([--with-system-servlet-api],
-[Use servlet-api already on system.]),,
-[with_system_servlet_api=$with_system_jars])
-
-AC_ARG_WITH(servlet-api-jar,
-AS_HELP_STRING([--with-servlet-api-jar=JARFILE],
-[Specify path to jarfile manually.]),
-SERVLETAPI_JAR=$withval)
-
AC_ARG_WITH(system-jfreereport,
AS_HELP_STRING([--with-system-jfreereport],
[Use JFreeReport already on system.]),,
@@ -10410,29 +10400,6 @@ else
fi
AC_SUBST(ENABLE_MEDIAWIKI)
-if test $ENABLE_MEDIAWIKI = TRUE; then
-AC_MSG_CHECKING([which Servlet API Jar to use])
-if test $with_system_servlet_api = yes; then
-AC_MSG_RESULT([external])
-SYSTEM_SERVLETAPI=YES
-if test -z $SERVLETAPI_JAR; then
-for version in '' -3.3 -3.2 -3.1 -3.0 -2.5 -2.4; do
-if test -r /usr/share/java/servlet-api${version}.jar; then
-SERVLETAPI_JAR=/usr/share/java/servlet-api${version}.jar
-fi
-done
-fi
-AC_CHECK_FILE($SERVLETAPI_JAR, [],
- [AC_MSG_ERROR(servlet-api.jar not found.)], [])
-else
-AC_MSG_RESULT([internal])
-SYSTEM_SERVLETAPI=NO
-BUILD_TYPE=$BUILD_TYPE TOMCAT
-fi
-fi
-AC_SUBST(SYSTEM_SERVLETAPI)
-AC_SUBST(SERVLETAPI_JAR)
-
AC_MSG_CHECKING([whether to build the Report Builder])
if test $enable_report_builder != no -a $with_java != no; then
AC_MSG_RESULT([yes])
diff --git a/download.lst b/download.lst
index ca0c9d0..9d21fed 100644
--- a/download.lst
[Bug 70998] Termchange: Graphic/Picture - Image
https://bugs.freedesktop.org/show_bug.cgi?id=70998 --- Comment #9 from Samuel M. s.mehrbr...@gmail.com --- You are right, I meant Header Case. Thanks for the Link btw, I'll give more attention to that with the coming patches. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Accessible labels in alerts claim to be ROLE_PASSWORD_TEXT
I've been trying to get a grip on bug fdo#70588 Accessible labels in alerts claim to be ROLE_PASSWORD_TEXT instead of ROLE_LABEL. In short this bug makes text inside message dialogs unreadable to screen readers (on all platforms). I've followed the code around a bit and it seems to be an issue with different WinBits that has the same value, more exactly WB_WORDBREAK and WB_PASSWORD has the same value and indirectly set the AccessibleRole to PASSWORD_TEXT. In newer message dialogs here is were the WB_WORDBREAK gets added: http://opengrok.libreoffice.org/xref/core/vcl/source/window/layout.cxx#2046 Here is were the AccessibleRole gets set to PASSWORD_TEXT (due to the fact that WB_WORDBREAK is set) http://opengrok.libreoffice.org/xref/core/accessibility/source/standard/vclxaccessibleedit.cxx#226 I should probably mention that WB_READONLY and WB_NOLABEL has the same value, but that has only positive effects in the above mentioned case because labels in messageboxes should of course be read only. * **Does it make sense to change the values of WinBits or how does one deal with a problem like this?* For quick reference to WinBits: http://opengrok.libreoffice.org/xref/core/include/tools/wintypes.hxx#211 -- Regards Niklas Johansson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/sheetdatabuffer.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 512a14438c4098ca2e30d0b10b6e18506c8475f1
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 17:04:34 2013 +0100
remember column style during XLSX import, fdo#70315
WE overwrote the column style that was set earlier with the default
style.
Change-Id: I4c02e1cdd3e72f27d75b8153e2af45b5658ff456
diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx
b/sc/source/filter/oox/sheetdatabuffer.cxx
index 7f9c8e4..f55d365 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -50,6 +50,7 @@
#include document.hxx
#include scitems.hxx
#include formulacell.hxx
+#include docpool.hxx
namespace oox {
namespace xls {
@@ -463,7 +464,8 @@ void SheetDataBuffer::finalizeImport()
{
ScAttrEntry aEntry;
aEntry.nRow = MAXROW;
-aEntry.pPattern = rDoc.GetDefPattern();
+aEntry.pPattern = rDoc.GetPattern(nScCol, 0, getSheetIndex());
+rDoc.GetPool()-Put(*aEntry.pPattern);
aAttrs.push_back(aEntry);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xeformula.cxx | 16 +---
sc/source/filter/excel/xlformula.cxx | 24 +++-
sc/source/filter/inc/xlformula.hxx | 13 +++--
3 files changed, 47 insertions(+), 6 deletions(-)
New commits:
commit 06a5b1ecc39bb50dadc0bcb7378455500943ece3
Author: Eike Rathke er...@redhat.com
Date: Sat Nov 2 16:25:42 2013 +0100
resolved fdo#67536 export internal equivalents as add-in to .xls
For BIFF .xls export the internal functions that are equivalents of
known add-in functions as those add-in functions.
Change-Id: If37f616a34fdabb3fa971fddad01da3dc1f28ee9
diff --git a/sc/source/filter/excel/xeformula.cxx
b/sc/source/filter/excel/xeformula.cxx
index a11c3b2..ba02aef 100644
--- a/sc/source/filter/excel/xeformula.cxx
+++ b/sc/source/filter/excel/xeformula.cxx
@@ -140,6 +140,7 @@ public:
inline sal_uInt16 GetXclFuncIdx() const { return mrFuncInfo.mnXclFunc; }
inline bool IsVolatile() const { return mrFuncInfo.IsVolatile(); }
inline bool IsFixedParamCount() const { return
mrFuncInfo.IsFixedParamCount(); }
+inline bool IsAddInEquivalent() const { return
mrFuncInfo.IsAddInEquivalent(); }
inline bool IsMacroFunc() const { return mrFuncInfo.IsMacroFunc();
}
inline sal_uInt8GetSpaces() const { return mrTokData.mnSpaces; }
inline const XclExpExtFuncData GetExtFuncData() const { return
maExtFuncData; }
@@ -1361,8 +1362,11 @@ void XclExpFmlaCompImpl::ProcessFunction( const
XclExpScToken rTokData )
mxData-mbOk = pFuncInfo != 0;
if( !mxData-mbOk ) return;
+// internal functions equivalent to an existing add-in
+if( pFuncInfo-IsAddInEquivalent() )
+aExtFuncData.Set( pFuncInfo-GetAddInEquivalentFuncName(), true, false
);
// functions simulated by a macro call in file format
-if( pFuncInfo-IsMacroFunc() )
+else if( pFuncInfo-IsMacroFunc() )
aExtFuncData.Set( pFuncInfo-GetMacroFuncName(), false, true );
XclExpFuncData aFuncData( rTokData, *pFuncInfo, aExtFuncData );
@@ -1644,8 +1648,11 @@ void XclExpFmlaCompImpl::AppendDefaultParam(
XclExpFuncData rFuncData )
break;
default:
{
-OSL_ENSURE( rFuncData.IsMacroFunc(),
XclExpFmlaCompImpl::AppendDefaultParam - unknown opcode );
-if( rFuncData.IsMacroFunc() )
+if( rFuncData.IsAddInEquivalent() )
+{
+AppendAddInCallToken( rFuncData.GetExtFuncData() );
+}
+else if( rFuncData.IsMacroFunc() )
{
// Do not write the OOXML definedName element for new _xlfn.
// prefixed functions.
@@ -1655,7 +1662,10 @@ void XclExpFmlaCompImpl::AppendDefaultParam(
XclExpFuncData rFuncData )
AppendMacroCallToken( rFuncData.GetExtFuncData() );
}
else
+{
+SAL_WARN( sc.filter, XclExpFmlaCompImpl::AppendDefaultParam
- unknown opcode );
AppendMissingToken(); // to keep parameter count valid
+}
}
}
diff --git a/sc/source/filter/excel/xlformula.cxx
b/sc/source/filter/excel/xlformula.cxx
index 064d1ab..78c4438 100644
--- a/sc/source/filter/excel/xlformula.cxx
+++ b/sc/source/filter/excel/xlformula.cxx
@@ -40,6 +40,13 @@ OUString XclFunctionInfo::GetMacroFuncName() const
return OUString();
}
+OUString XclFunctionInfo::GetAddInEquivalentFuncName() const
+{
+if( IsAddInEquivalent() )
+return OUString( mpcMacroName, strlen(mpcMacroName),
RTL_TEXTENCODING_UTF8 );
+return OUString();
+}
+
// abbreviations for function return token class
const sal_uInt8 R = EXC_TOKCLASS_REF;
const sal_uInt8 V = EXC_TOKCLASS_VAL;
@@ -64,6 +71,7 @@ const sal_uInt8 MX= 30; /// Maximum
parameter count.
#define EXC_FUNCNAME( ascii ) _xlfn. ascii
#define EXC_FUNCNAME_ODF( ascii ) _xlfnodf. ascii
+#define EXC_FUNCNAME_ADDIN( ascii ) com.sun.star.sheet.addin. ascii
/** Functions new in BIFF2. */
static const XclFunctionInfo saFuncTable_2[] =
@@ -313,7 +321,21 @@ static const XclFunctionInfo saFuncTable_4[] =
{ ocPercentrank,329,2, 3, V, { RX, VR, VR_E }, 0, 0 },
{ ocModalValue, 330,1, MX, V, { VA }, 0, 0 },
{ ocTrimMean, 331,2, 2, V, { RX, VR }, 0, 0 },
-{ ocTInv, 332,2, 2, V, { VR }, 0, 0 }
+{ ocTInv, 332,2, 2, V, { VR }, 0, 0 },
+// Functions equivalent to add-in functions, use same parameters as
+// ocExternal but add programmatical function name (here without
+// com.sun.star.sheet.addin.) so it can be looked up and stored as
+// add-in, as older Excel versions only know them as add-in.
+// These are the functions flagged as AddInMap::bMapDupToInternal=true in
+// sc/source/core/tool/odffmap.cxx
+{ ocIsEven, 255,1, MX, R, { RO_E,
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/outdev3.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit c5701117b4ba30f46f26fa2c15c4eb252a44e9f7
Author: Marcos Paulo de Souza marcos.souza@gmail.com
Date: Sat Nov 2 14:14:36 2013 -0200
Fix invalid string access
Change-Id: Ic83af0549a88b8debfdf945853fa42e1d28e5869
diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx
index d8ec0e6..cc30966 100644
--- a/vcl/source/gdi/outdev3.cxx
+++ b/vcl/source/gdi/outdev3.cxx
@@ -6858,6 +6858,9 @@ OUString OutputDevice::GetNonMnemonicString( const
OUString rStr, sal_Int32 rM
{
if ( aStr[ i ] == '~' )
{
+if ( nLen = i+1 )
+break;
+
if ( aStr[ i+1 ] != '~' )
{
if ( rMnemonicPos == -1 )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sysui/desktop
sysui/desktop/menus/base.desktop| 11 +
sysui/desktop/menus/calc.desktop| 11 +
sysui/desktop/menus/draw.desktop| 11 +
sysui/desktop/menus/impress.desktop | 11 +
sysui/desktop/menus/math.desktop| 13 ++-
sysui/desktop/menus/startcenter.desktop | 37 +++-
sysui/desktop/menus/writer.desktop | 11 +
7 files changed, 73 insertions(+), 32 deletions(-)
New commits:
commit 78e4c8a925f4735a7e9a4c32a29b19fd2b77670d
Author: Jean-Baptiste Faure jbf.fa...@sud-ouest.org
Date: Sat Nov 2 18:09:28 2013 +0100
fdo#70553: Fix Unity Quicklists
Change-Id: I4bf29d0021c1342cd529a7c6cbd86eceb467a9b5
diff --git a/sysui/desktop/menus/base.desktop b/sysui/desktop/menus/base.desktop
index 2f3005c..62626d4 100755
--- a/sysui/desktop/menus/base.desktop
+++ b/sysui/desktop/menus/base.desktop
@@ -30,10 +30,11 @@ StartupNotify=true
X-GIO-NoFuse=true
Keywords=Data;SQL;
InitialPreference=5
-X-Ayatana-Desktop-Shortcuts=X-New
StartupWMClass=libreoffice-base
X-KDE-Protocols=file,http,smb,ftp,webdav
-[X-New Shortcut Group]
-UnityQuicklist=New Database
-Exec=${UNIXBASISROOTNAME} --base %%FILE%%
-TargetEnvironment=Unity
+
+Actions=NewDocument;
+[Desktop Action NewDocument]
+Name=New Database
+Exec=${UNIXBASISROOTNAME} --base
+OnlyShowIn=Unity;
diff --git a/sysui/desktop/menus/calc.desktop b/sysui/desktop/menus/calc.desktop
index 1c3f955..e50de65 100755
--- a/sysui/desktop/menus/calc.desktop
+++ b/sysui/desktop/menus/calc.desktop
@@ -30,10 +30,11 @@ StartupNotify=true
X-GIO-NoFuse=true
Keywords=Accounting;Stats;OpenDocument Spreadsheet;Chart;Microsoft
Excel;Microsoft Works;OpenOffice Calc;ods;xls;xlsx;
InitialPreference=5
-X-Ayatana-Desktop-Shortcuts=X-New
StartupWMClass=libreoffice-calc
X-KDE-Protocols=file,http,smb,ftp,webdav
-[X-New Shortcut Group]
-UnityQuicklist=New Spreadsheet
-Exec=${UNIXBASISROOTNAME} --calc %%FILE%%
-TargetEnvironment=Unity
+
+Actions=NewDocument;
+[Desktop Action NewDocument]
+Name=New Spreadsheet
+Exec=${UNIXBASISROOTNAME} --calc
+OnlyShowIn=Unity;
diff --git a/sysui/desktop/menus/draw.desktop b/sysui/desktop/menus/draw.desktop
index 9691841..3483331 100755
--- a/sysui/desktop/menus/draw.desktop
+++ b/sysui/desktop/menus/draw.desktop
@@ -30,10 +30,11 @@ StartupNotify=true
X-GIO-NoFuse=true
Keywords=Vector;Schema;Diagram;Layout;OpenDocument Graphics;Microsoft
Publisher;Corel Draw;cdr;odg;svg;
InitialPreference=5
-X-Ayatana-Desktop-Shortcuts=X-New
StartupWMClass=libreoffice-draw
X-KDE-Protocols=file,http,smb,ftp,webdav
-[X-New Shortcut Group]
-UnityQuicklist=New Drawing
-Exec=${UNIXBASISROOTNAME} --draw %%FILE%%
-TargetEnvironment=Unity
+
+Actions=NewDocument;
+[Desktop Action NewDocument]
+Name=New Drawing
+Exec=${UNIXBASISROOTNAME} --draw
+OnlyShowIn=Unity;
diff --git a/sysui/desktop/menus/impress.desktop
b/sysui/desktop/menus/impress.desktop
index 082b2f6..7efe610 100755
--- a/sysui/desktop/menus/impress.desktop
+++ b/sysui/desktop/menus/impress.desktop
@@ -30,10 +30,11 @@ StartupNotify=true
X-GIO-NoFuse=true
Keywords=Slideshow;Slides;OpenDocument Presentation;Microsoft
PowerPoint;Microsoft Works;OpenOffice Impress;odp;ppt;pptx;
InitialPreference=5
-X-Ayatana-Desktop-Shortcuts=X-New
StartupWMClass=libreoffice-impress
X-KDE-Protocols=file,http,smb,ftp,webdav
-[X-New Shortcut Group]
-UnityQuicklist=New Presentation
-Exec=${UNIXBASISROOTNAME} --impress %%FILE%%
-TargetEnvironment=Unity
+
+Actions=NewDocument;
+[Desktop Action NewDocument]
+Name=New Presentation
+Exec=${UNIXBASISROOTNAME} --impress
+OnlyShowIn=Unity;
diff --git a/sysui/desktop/menus/math.desktop b/sysui/desktop/menus/math.desktop
index 132c5c3..e13f466 100755
--- a/sysui/desktop/menus/math.desktop
+++ b/sysui/desktop/menus/math.desktop
@@ -18,7 +18,7 @@
[Desktop Entry]
Version=1.0
Terminal=false
-NoDisplay=true
+NoDisplay=false
Icon=math
Type=Application
Categories=Office;Education;Science;Math;X-Red-Hat-Base;X-MandrivaLinux-Office-Other;
@@ -31,10 +31,11 @@ StartupNotify=true
X-GIO-NoFuse=true
Keywords=Equation;OpenDocument Formula;Formula;odf;MathML
InitialPreference=5
-X-Ayatana-Desktop-Shortcuts=X-New
StartupWMClass=libreoffice-math
X-KDE-Protocols=file,http,smb,ftp,webdav
-[X-New Shortcut Group]
-UnityQuicklist=New Formula
-Exec=${UNIXBASISROOTNAME} --math %%FILE%%
-TargetEnvironment=Unity
+
+Actions=NewDocument;
+[Desktop Action NewDocument]
+Name=New Formula
+Exec=${UNIXBASISROOTNAME} --math
+OnlyShowIn=Unity;
diff --git a/sysui/desktop/menus/startcenter.desktop
b/sysui/desktop/menus/startcenter.desktop
index 8a25b57..dabe887 100755
--- a/sysui/desktop/menus/startcenter.desktop
+++ b/sysui/desktop/menus/startcenter.desktop
@@ -18,7 +18,7 @@
[Desktop Entry]
Version=1.0
Terminal=false
-NoDisplay=true
+NoDisplay=false
Icon=startcenter
Type=Application
Categories=Office;X-Red-Hat-Base;X-SuSE-Core-Office;X-MandrivaLinux-Office-Other;
@@ -31,3 +31,38 @@
[Bug 70553] Update .desktop files to use freedesktop actions
https://bugs.freedesktop.org/show_bug.cgi?id=70553 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED --- Comment #6 from Björn Michaelsen bjoern.michael...@canonical.com --- Pushed, Thanks Jean-Baptiste! -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70553] Update .desktop files to use freedesktop actions
https://bugs.freedesktop.org/show_bug.cgi?id=70553 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack DifficultyBeginner |EasyHack DifficultyBeginner |SkillScript |SkillScript target:4.2.0 --- Comment #7 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Jean-Baptiste Faure committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=78e4c8a925f4735a7e9a4c32a29b19fd2b77670d fdo#70553: Fix Unity Quicklists The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xlsx/column-style.xlsx |binary
sc/qa/unit/subsequent_filters-test.cxx | 24
2 files changed, 24 insertions(+)
New commits:
commit 5c18b9dfe4319bc27aa245c58d4f0dfc6cb689ef
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 19:54:12 2013 +0100
add test case for fdo#70315
Change-Id: Ia442916ae29b8531ba2ef67eb4809267aca775b4
diff --git a/sc/qa/unit/data/xlsx/column-style.xlsx
b/sc/qa/unit/data/xlsx/column-style.xlsx
new file mode 100644
index 000..57afe3e
Binary files /dev/null and b/sc/qa/unit/data/xlsx/column-style.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index 853187c..08b57eb 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -44,6 +44,7 @@
#include docsh.hxx
#include editutil.hxx
#include cellvalue.hxx
+#include attrib.hxx
#include com/sun/star/drawing/XDrawPageSupplier.hpp
#include com/sun/star/drawing/XControlShape.hpp
@@ -144,6 +145,8 @@ public:
void testPrintRangeODS();
void testOutlineODS();
+void testColumnStyleXLSX();
+
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testBasicCellContentODS);
CPPUNIT_TEST(testRangeNameXLS);
@@ -210,6 +213,7 @@ public:
CPPUNIT_TEST(testOptimalHeightReset);
CPPUNIT_TEST(testPrintRangeODS);
CPPUNIT_TEST(testOutlineODS);
+CPPUNIT_TEST(testColumnStyleXLSX);
CPPUNIT_TEST_SUITE_END();
private:
@@ -1991,6 +1995,26 @@ void ScFiltersTest::testOutlineODS()
}
}
+void ScFiltersTest::testColumnStyleXLSX()
+{
+ScDocShellRef xDocSh = loadDoc(column-style., XLSX);
+CPPUNIT_ASSERT(xDocSh.Is());
+ScDocument* pDoc = xDocSh-GetDocument();
+CPPUNIT_ASSERT(pDoc);
+
+const ScPatternAttr* pPattern = pDoc-GetPattern(0,0,0);
+CPPUNIT_ASSERT(pPattern);
+
+const ScProtectionAttr rAttr = static_castconst
ScProtectionAttr(pPattern-GetItem(ATTR_PROTECTION));
+CPPUNIT_ASSERT(rAttr.GetProtection());
+
+pPattern = pDoc-GetPattern(0,1,0);
+CPPUNIT_ASSERT(pPattern);
+
+const ScProtectionAttr rAttrNew = static_castconst
ScProtectionAttr(pPattern-GetItem(ATTR_PROTECTION));
+CPPUNIT_ASSERT(!rAttrNew.GetProtection());
+}
+
ScFiltersTest::ScFiltersTest()
: ScBootstrapFixture( /sc/qa/unit/data )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 70998] Termchange: Graphic/Picture - Image
https://bugs.freedesktop.org/show_bug.cgi?id=70998 --- Comment #10 from Christina Rossmanith chrrossman...@web.de --- Using Insert-Image-From File shows a dialog with title Insert picture. I guess that should be image as well. Version: 4.2.0.0.alpha0+ Build ID: 2c92030ff07aff9b10e49844343390925b81545c -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/output2.cxx |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 045e037b7acde9d8e63fbb977c28b167e8815278
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 20:30:14 2013 +0100
no default LTR mode does not mean RTL, fdo#68097
Change-Id: Ice4957077e7eda5f7bb93042d6e2ba745935ef8b
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 63e0fad..cf0a829 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -1690,8 +1690,13 @@ void ScOutputData::DrawStrings( sal_Bool bPixelToLogic )
{
const SfxPoolItem* pItem = mpDoc-GetAttr( nCellX,
nCellY, nTab, ATTR_WRITINGDIR );
const SvxFrameDirectionItem* pCurrentWritingMode =
(const SvxFrameDirectionItem*) pItem;
-if (pCurrentWritingMode-GetValue() ==
FRMDIR_HORI_LEFT_TOP)
+sal_uInt16 aDirection =
pCurrentWritingMode-GetValue();
+if ( aDirection == FRMDIR_HORI_LEFT_TOP || aDirection
== FRMDIR_VERT_TOP_LEFT )
eOutHorJust = SVX_HOR_JUSTIFY_LEFT;
+else if ( aDirection == FRMDIR_ENVIRONMENT )
+{
+eOutHorJust = mpDoc-IsLayoutRTL(nTab) ?
SVX_HOR_JUSTIFY_RIGHT : SVX_HOR_JUSTIFY_LEFT;
+}
else
eOutHorJust = SVX_HOR_JUSTIFY_RIGHT;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/chart/SchXMLChartContext.cxx |4 +--
xmloff/source/chart/SchXMLTableContext.cxx | 33 +
xmloff/source/chart/SchXMLTableContext.hxx |5 +---
3 files changed, 6 insertions(+), 36 deletions(-)
New commits:
commit 68e39b840d6fbfc7cd9c12791d1c1a64cf60ec96
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 20:44:38 2013 +0100
Revert transpose data in rows ranges for internal data provider,
fdo#62057
This reverts commit 14fa5488a829936275f79a7693b13da55114220e.
Conflicts:
xmloff/source/chart/SchXMLTableContext.cxx
diff --git a/xmloff/source/chart/SchXMLChartContext.cxx
b/xmloff/source/chart/SchXMLChartContext.cxx
index 02fea26..dd0a125 100644
--- a/xmloff/source/chart/SchXMLChartContext.cxx
+++ b/xmloff/source/chart/SchXMLChartContext.cxx
@@ -781,7 +781,7 @@ void SchXMLChartContext::EndElement()
//own data or only rectangular range available
if( xNewDoc-hasInternalDataProvider() )
-SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc );
bool bOlderThan2_3 =
SchXMLTools::isDocumentGeneratedWithOpenOfficeOlderThan2_3( Reference
frame::XModel ( xNewDoc, uno::UNO_QUERY ));
bool bOldFileWithOwnDataFromRows = (bOlderThan2_3 bHasOwnData
(meDataRowSource==chart::ChartDataRowSource_ROWS)); // in this case there are
range addresses that are simply wrong.
@@ -818,7 +818,7 @@ void SchXMLChartContext::EndElement()
if( !xNewDoc-hasInternalDataProvider() )
{
xNewDoc-createInternalDataProvider( sal_False /*
bCloneExistingData */ );
-SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc );
try
{
lcl_ApplyDataFromRectangularRangeToDiagram(
xNewDoc, msChartAddress, meDataRowSource, mbRowHasLabels, mbColHasLabels,
bHasOwnData, msColTrans, msRowTrans );
diff --git a/xmloff/source/chart/SchXMLTableContext.cxx
b/xmloff/source/chart/SchXMLTableContext.cxx
index ad0b7cd..d1a0466 100644
--- a/xmloff/source/chart/SchXMLTableContext.cxx
+++ b/xmloff/source/chart/SchXMLTableContext.cxx
@@ -738,35 +738,9 @@ static void lcl_ApplyCellToComplexLabel( const SchXMLCell
rCell, Sequence uno:
}
}
-namespace {
-
-void transposeTable(SchXMLTable rTable)
-{
-std::vectorstd::vectorSchXMLCell aNewData;
-sal_Int32 nRows = rTable.aData.size();
-aNewData.resize(rTable.nMaxColumnIndex+1);
-for(sal_Int32 i = 0; i nRows; ++i)
-{
-sal_Int32 nCols = rTable.aData[i].size();
-for(sal_Int32 j = 0; j nCols; ++j)
-{
-SchXMLCell rCell = rTable.aData[i][j];
-aNewData[j].push_back(rCell);
-}
-}
-bool bHasRowHeader = rTable.bHasHeaderRow;
-bool bHasColHeader = rTable.bHasHeaderColumn;
-rTable.bHasHeaderColumn = bHasRowHeader;
-rTable.bHasHeaderRow = bHasColHeader;
-rTable.nMaxColumnIndex = nRows;
-rTable.aData = aNewData;
-}
-
-}
-
void SchXMLTableHelper::applyTableToInternalDataProvider(
-SchXMLTable rTable,
-uno::Reference chart2::XChartDocument xChartDoc,
chart::ChartDataRowSource eDataRowSource )
+const SchXMLTable rTable,
+uno::Reference chart2::XChartDocument xChartDoc )
{
// apply all data read from the local table to the internal data provider
if( !xChartDoc.is() || !xChartDoc-hasInternalDataProvider() )
@@ -775,9 +749,6 @@ void SchXMLTableHelper::applyTableToInternalDataProvider(
if( !xDataProv.is() )
return;
-if(eDataRowSource == chart::ChartDataRowSource_ROWS)
-transposeTable(rTable);
-
//prepare the read local table data
sal_Int32 nNumRows( static_cast sal_Int32 ( rTable.aData.size()));
sal_Int32 nRowOffset = 0;
diff --git a/xmloff/source/chart/SchXMLTableContext.hxx
b/xmloff/source/chart/SchXMLTableContext.hxx
index 19993cb..6919dcc 100644
--- a/xmloff/source/chart/SchXMLTableContext.hxx
+++ b/xmloff/source/chart/SchXMLTableContext.hxx
@@ -73,9 +73,8 @@ private:
sal_Int32 nRows, sal_Int32 nColumns );
public:
-static void applyTableToInternalDataProvider( SchXMLTable rTable,
-com::sun::star::uno::Reference
com::sun::star::chart2::XChartDocument xChartDoc,
-com::sun::star::chart::ChartDataRowSource
eDataRowSource );
+static void applyTableToInternalDataProvider( const SchXMLTable rTable,
+com::sun::star::uno::Reference
com::sun::star::chart2::XChartDocument xChartDoc );
/** This function reorders local data to fit the correct data structure.
Call
[Bug 60270] LibreOffice 4.1 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 71075, which changed state. Bug 71075 Summary: chart mangling on paste https://bugs.freedesktop.org/show_bug.cgi?id=71075 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/ui/inc/olmenu.hxx | 30 ++---
sw/source/ui/lingu/olmenu.cxx | 230 +-
2 files changed, 130 insertions(+), 130 deletions(-)
New commits:
commit 7c1e28eaaf73567f9fbfbb01e777208bb026b2de
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Nov 2 20:03:24 2013 +0100
SwSpellPopup: rename member variables missing their prefixes
Change-Id: Iea3acea6b080a0236a6a5dfce8a855df16b74231
diff --git a/sw/source/ui/inc/olmenu.hxx b/sw/source/ui/inc/olmenu.hxx
index b21e0f4..08b63c8 100644
--- a/sw/source/ui/inc/olmenu.hxx
+++ b/sw/source/ui/inc/olmenu.hxx
@@ -36,30 +36,30 @@ class SwWrtShell;
class SW_DLLPUBLIC SwSpellPopup : public PopupMenu
{
-SwWrtShell* pSh;
+SwWrtShell* m_pSh;
::com::sun::star::uno::Sequence ::com::sun::star::uno::Reference
-::com::sun::star::linguistic2::XDictionaryaDics;
+::com::sun::star::linguistic2::XDictionarym_aDics;
::com::sun::star::uno::Reference
-::com::sun::star::linguistic2::XSpellAlternatives xSpellAlt;
+::com::sun::star::linguistic2::XSpellAlternatives m_xSpellAlt;
-::com::sun::star::linguistic2::ProofreadingResult xGrammarResult;
-sal_Int32 nGrammarError;
+::com::sun::star::linguistic2::ProofreadingResult m_xGrammarResult;
+sal_Int32 m_nGrammarError;
-::com::sun::star::uno::Sequence OUString aSuggestions;
-OUString sExplanationLink;
+::com::sun::star::uno::Sequence OUString m_aSuggestions;
+OUString m_sExplanationLink;
-LanguageTypenCheckedLanguage;
-LanguageTypenGuessLangWord;
-LanguageTypenGuessLangPara;
+LanguageTypem_nCheckedLanguage;
+LanguageTypem_nGuessLangWord;
+LanguageTypem_nGuessLangPara;
-std::map sal_Int16, OUString aLangTable_Text;
-std::map sal_Int16, OUString aLangTable_Paragraph;
+std::map sal_Int16, OUString m_aLangTable_Text;
+std::map sal_Int16, OUString m_aLangTable_Paragraph;
//std::map sal_Int16, OUString aLangTable_Document;
-OUString aDicNameSingle;
-bool bGrammarResults;// show grammar results? Or show spellcheck
results?
+OUString m_aDicNameSingle;
+bool m_bGrammarResults;// show grammar results? Or show
spellcheck results?
-Image aInfo16;
+Image m_aInfo16;
void fillLangPopupMenu( PopupMenu *pPopupMenu, sal_uInt16 nLangStart,
::com::sun::star::uno::Sequence OUString aSeq, SwWrtShell*
pWrtSh,
diff --git a/sw/source/ui/lingu/olmenu.cxx b/sw/source/ui/lingu/olmenu.cxx
index 687d9a2..528d45f 100644
--- a/sw/source/ui/lingu/olmenu.cxx
+++ b/sw/source/ui/lingu/olmenu.cxx
@@ -273,22 +273,22 @@ SwSpellPopup::SwSpellPopup(
const uno::Reference linguistic2::XSpellAlternatives xAlt,
const OUString rParaText
) : PopupMenu( SW_RES(MN_SPELL_POPUP) )
-, pSh( pWrtSh )
-, xSpellAlt(xAlt)
-, bGrammarResults(false)
+, m_pSh( pWrtSh )
+, m_xSpellAlt(xAlt)
+, m_bGrammarResults(false)
{
-OSL_ENSURE(xSpellAlt.is(), no spelling alternatives available);
+OSL_ENSURE(m_xSpellAlt.is(), no spelling alternatives available);
SetMenuFlags(MENU_FLAG_NOAUTOMNEMONICS);
bool bUseImagesInMenus =
Application::GetSettings().GetStyleSettings().GetUseImagesInMenus();
-nCheckedLanguage = LANGUAGE_NONE;
-if (xSpellAlt.is())
+m_nCheckedLanguage = LANGUAGE_NONE;
+if (m_xSpellAlt.is())
{
-nCheckedLanguage = LanguageTag( xSpellAlt-getLocale()
).getLanguageType();
-aSuggestions = xSpellAlt-getAlternatives();
+m_nCheckedLanguage = LanguageTag( m_xSpellAlt-getLocale()
).getLanguageType();
+m_aSuggestions = m_xSpellAlt-getAlternatives();
}
-sal_Int16 nStringCount = static_cast sal_Int16 (
aSuggestions.getLength() );
+sal_Int16 nStringCount = static_cast sal_Int16 (
m_aSuggestions.getLength() );
SvtLinguConfig aCfg;
@@ -302,7 +302,7 @@ SwSpellPopup::SwSpellPopup(
if (bUseImagesInMenus)
{
-uno::Reference container::XNamed xNamed( xSpellAlt,
uno::UNO_QUERY );
+uno::Reference container::XNamed xNamed( m_xSpellAlt,
uno::UNO_QUERY );
if (xNamed.is())
{
aSuggestionImageUrl =
aCfg.GetSpellAndGrammarContextSuggestionImage( xNamed-getName() );
@@ -316,7 +316,7 @@ SwSpellPopup::SwSpellPopup(
sal_uInt16 nItemId = MN_SUGGESTION_START;
for (sal_uInt16 i = 0; i nStringCount; ++i)
{
-const OUString aEntry = aSuggestions[ i ];
+const OUString aEntry = m_aSuggestions[ i ];
InsertItem(nItemId, aEntry, 0, OString(), i);
SetHelpId( nItemId, HID_LINGU_REPLACE);
if (!aSuggestionImageUrl.isEmpty())
@@ -340,20 +340,20 @@ SwSpellPopup::SwSpellPopup(
EnableItem( MN_AUTOCORR, bEnable
[Libreoffice-commits] core.git: sd/source sw/source
sd/source/core/sdiocmpt.cxx |4 ++--
sw/source/filter/ww8/ww8par6.cxx |8
2 files changed, 6 insertions(+), 6 deletions(-)
New commits:
commit be2f8b889ed04e8cf3a6e8a0d73f300754588557
Author: Henning Diedler henning.died...@gmx.de
Date: Sat Nov 2 16:43:27 2013 +0100
fdo#39468 Translate German strings.
Quality translation by certified German/English teacher.
Change-Id: I4684630004ad2846b6a5ba76e18d30831d20bc26
diff --git a/sd/source/core/sdiocmpt.cxx b/sd/source/core/sdiocmpt.cxx
index 0f49112..3fc5a73 100644
--- a/sd/source/core/sdiocmpt.cxx
+++ b/sd/source/core/sdiocmpt.cxx
@@ -106,13 +106,13 @@ SdIOCompat::SdIOCompat(SvStream rNewStream, sal_uInt16
nNewMode, sal_uInt16 nVe
if (nNewMode == STREAM_WRITE)
{
DBG_ASSERT(nVer != SDIOCOMPAT_VERSIONDONTKNOW,
- kann unbekannte Version nicht schreiben);
+ can´t write unknown version);
rNewStream nVersion;
}
else if (nNewMode == STREAM_READ)
{
DBG_ASSERT(nVer == SDIOCOMPAT_VERSIONDONTKNOW,
- Lesen mit Angabe der Version ist Quatsch!);
+ referring to the version while reading is silly!);
rNewStream nVersion;
}
}
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 14e9cdf..ee7c9c0 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -2461,10 +2461,10 @@ void SwWW8ImplReader::StopApo()
DeleteAnchorStk();
pAnchorStck = pSFlyPara-pOldAnchorStck;
-// Ist die Fly-Breite durch eine innenliegende Grafik vergroessert
-// worden ( bei automatischer Breite des Flys ), dann muss die Breite
-// des SW-Flys entsprechend umgesetzt werden, da der SW keine
-// automatische Breite kennt.
+// When inserting a graphic into the fly frame using the auto
+// function, the extension of the SW-fly has to be set
+// manually as the SW fly has no auto function to adjust the
+// frame´s size.
if( pSFlyPara-nNewNettoWidth MINFLY )// BoxUpWidth ?
{
long nW = pSFlyPara-nNewNettoWidth;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 39468] translate German comments, removing redundant ones
https://bugs.freedesktop.org/show_bug.cgi?id=39468 --- Comment #92 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Henning Diedler committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=be2f8b889ed04e8cf3a6e8a0d73f300754588557 fdo#39468 Translate German strings. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - xmloff/source
xmloff/source/chart/SchXMLChartContext.cxx |4 +--
xmloff/source/chart/SchXMLTableContext.cxx | 33 +
xmloff/source/chart/SchXMLTableContext.hxx |5 +---
3 files changed, 6 insertions(+), 36 deletions(-)
New commits:
commit cc502dadd01658e80a4f36fe43ac16c46e819b30
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 20:44:38 2013 +0100
Revert transpose data in rows ranges for internal data provider,
fdo#62057
This reverts commit 14fa5488a829936275f79a7693b13da55114220e.
Signed-off-by: Michael Meeks michael.me...@collabora.com
Conflicts:
xmloff/source/chart/SchXMLTableContext.cxx
Signed-off-by: Michael Meeks michael.me...@collabora.com
diff --git a/xmloff/source/chart/SchXMLChartContext.cxx
b/xmloff/source/chart/SchXMLChartContext.cxx
index 69410a5..5aeb93b 100644
--- a/xmloff/source/chart/SchXMLChartContext.cxx
+++ b/xmloff/source/chart/SchXMLChartContext.cxx
@@ -788,7 +788,7 @@ void SchXMLChartContext::EndElement()
//own data or only rectangular range available
if( xNewDoc-hasInternalDataProvider() )
-SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc );
bool bOlderThan2_3 =
SchXMLTools::isDocumentGeneratedWithOpenOfficeOlderThan2_3( Reference
frame::XModel ( xNewDoc, uno::UNO_QUERY ));
bool bOldFileWithOwnDataFromRows = (bOlderThan2_3 bHasOwnData
(meDataRowSource==chart::ChartDataRowSource_ROWS)); // in this case there are
range addresses that are simply wrong.
@@ -825,7 +825,7 @@ void SchXMLChartContext::EndElement()
if( !xNewDoc-hasInternalDataProvider() )
{
xNewDoc-createInternalDataProvider( sal_False /*
bCloneExistingData */ );
-SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc );
try
{
lcl_ApplyDataFromRectangularRangeToDiagram(
xNewDoc, msChartAddress, meDataRowSource, mbRowHasLabels, mbColHasLabels,
bHasOwnData, msColTrans, msRowTrans );
diff --git a/xmloff/source/chart/SchXMLTableContext.cxx
b/xmloff/source/chart/SchXMLTableContext.cxx
index ea877d6..206e5e8 100644
--- a/xmloff/source/chart/SchXMLTableContext.cxx
+++ b/xmloff/source/chart/SchXMLTableContext.cxx
@@ -775,35 +775,9 @@ static void lcl_ApplyCellToComplexLabel( const SchXMLCell
rCell, Sequence uno:
}
}
-namespace {
-
-void transposeTable(SchXMLTable rTable)
-{
-std::vectorstd::vectorSchXMLCell aNewData;
-sal_Int32 nRows = rTable.aData.size();
-aNewData.resize(rTable.nMaxColumnIndex+1);
-for(sal_Int32 i = 0; i nRows; ++i)
-{
-sal_Int32 nCols = rTable.aData[i].size();
-for(sal_Int32 j = 0; j nCols; ++j)
-{
-SchXMLCell rCell = rTable.aData[i][j];
-aNewData[j].push_back(rCell);
-}
-}
-bool bHasRowHeader = rTable.bHasHeaderRow;
-bool bHasColHeader = rTable.bHasHeaderColumn;
-rTable.bHasHeaderColumn = bHasRowHeader;
-rTable.bHasHeaderRow = bHasColHeader;
-rTable.nMaxColumnIndex = nRows;
-rTable.aData = aNewData;
-}
-
-}
-
void SchXMLTableHelper::applyTableToInternalDataProvider(
-SchXMLTable rTable,
-uno::Reference chart2::XChartDocument xChartDoc,
chart::ChartDataRowSource eDataRowSource )
+const SchXMLTable rTable,
+uno::Reference chart2::XChartDocument xChartDoc )
{
// apply all data read from the local table to the internal data provider
if( !xChartDoc.is() || !xChartDoc-hasInternalDataProvider() )
@@ -812,9 +786,6 @@ void SchXMLTableHelper::applyTableToInternalDataProvider(
if( !xDataProv.is() )
return;
-if(eDataRowSource == chart::ChartDataRowSource_ROWS)
-transposeTable(rTable);
-
//prepare the read local table data
sal_Int32 nNumRows( static_cast sal_Int32 ( rTable.aData.size()));
sal_Int32 nRowOffset = 0;
diff --git a/xmloff/source/chart/SchXMLTableContext.hxx
b/xmloff/source/chart/SchXMLTableContext.hxx
index 811e921..1d06dd5 100644
--- a/xmloff/source/chart/SchXMLTableContext.hxx
+++ b/xmloff/source/chart/SchXMLTableContext.hxx
@@ -82,9 +82,8 @@ private:
sal_Int32 nRows, sal_Int32 nColumns );
public:
-static void applyTableToInternalDataProvider( SchXMLTable rTable,
-com::sun::star::uno::Reference
com::sun::star::chart2::XChartDocument xChartDoc,
-com::sun::star::chart::ChartDataRowSource
eDataRowSource );
+static void applyTableToInternalDataProvider( const SchXMLTable rTable,
+com::sun::star::uno::Reference
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.1' - xmloff/source
xmloff/source/chart/SchXMLChartContext.cxx |4 +--
xmloff/source/chart/SchXMLTableContext.cxx | 33 +
xmloff/source/chart/SchXMLTableContext.hxx |5 +---
3 files changed, 6 insertions(+), 36 deletions(-)
New commits:
commit fb1ed0901dc2156a7ef7094cee153a6e9da2ecde
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 20:44:38 2013 +0100
Revert transpose data in rows ranges for internal data provider,
fdo#62057
This reverts commit 14fa5488a829936275f79a7693b13da55114220e.
Signed-off-by: Michael Meeks michael.me...@collabora.com
Conflicts:
xmloff/source/chart/SchXMLTableContext.cxx
Signed-off-by: Michael Meeks michael.me...@collabora.com
diff --git a/xmloff/source/chart/SchXMLChartContext.cxx
b/xmloff/source/chart/SchXMLChartContext.cxx
index 69410a5..5aeb93b 100644
--- a/xmloff/source/chart/SchXMLChartContext.cxx
+++ b/xmloff/source/chart/SchXMLChartContext.cxx
@@ -788,7 +788,7 @@ void SchXMLChartContext::EndElement()
//own data or only rectangular range available
if( xNewDoc-hasInternalDataProvider() )
-SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider( maTable,
xNewDoc );
bool bOlderThan2_3 =
SchXMLTools::isDocumentGeneratedWithOpenOfficeOlderThan2_3( Reference
frame::XModel ( xNewDoc, uno::UNO_QUERY ));
bool bOldFileWithOwnDataFromRows = (bOlderThan2_3 bHasOwnData
(meDataRowSource==chart::ChartDataRowSource_ROWS)); // in this case there are
range addresses that are simply wrong.
@@ -825,7 +825,7 @@ void SchXMLChartContext::EndElement()
if( !xNewDoc-hasInternalDataProvider() )
{
xNewDoc-createInternalDataProvider( sal_False /*
bCloneExistingData */ );
-SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc, meDataRowSource );
+SchXMLTableHelper::applyTableToInternalDataProvider(
maTable, xNewDoc );
try
{
lcl_ApplyDataFromRectangularRangeToDiagram(
xNewDoc, msChartAddress, meDataRowSource, mbRowHasLabels, mbColHasLabels,
bHasOwnData, msColTrans, msRowTrans );
diff --git a/xmloff/source/chart/SchXMLTableContext.cxx
b/xmloff/source/chart/SchXMLTableContext.cxx
index ea877d6..206e5e8 100644
--- a/xmloff/source/chart/SchXMLTableContext.cxx
+++ b/xmloff/source/chart/SchXMLTableContext.cxx
@@ -775,35 +775,9 @@ static void lcl_ApplyCellToComplexLabel( const SchXMLCell
rCell, Sequence uno:
}
}
-namespace {
-
-void transposeTable(SchXMLTable rTable)
-{
-std::vectorstd::vectorSchXMLCell aNewData;
-sal_Int32 nRows = rTable.aData.size();
-aNewData.resize(rTable.nMaxColumnIndex+1);
-for(sal_Int32 i = 0; i nRows; ++i)
-{
-sal_Int32 nCols = rTable.aData[i].size();
-for(sal_Int32 j = 0; j nCols; ++j)
-{
-SchXMLCell rCell = rTable.aData[i][j];
-aNewData[j].push_back(rCell);
-}
-}
-bool bHasRowHeader = rTable.bHasHeaderRow;
-bool bHasColHeader = rTable.bHasHeaderColumn;
-rTable.bHasHeaderColumn = bHasRowHeader;
-rTable.bHasHeaderRow = bHasColHeader;
-rTable.nMaxColumnIndex = nRows;
-rTable.aData = aNewData;
-}
-
-}
-
void SchXMLTableHelper::applyTableToInternalDataProvider(
-SchXMLTable rTable,
-uno::Reference chart2::XChartDocument xChartDoc,
chart::ChartDataRowSource eDataRowSource )
+const SchXMLTable rTable,
+uno::Reference chart2::XChartDocument xChartDoc )
{
// apply all data read from the local table to the internal data provider
if( !xChartDoc.is() || !xChartDoc-hasInternalDataProvider() )
@@ -812,9 +786,6 @@ void SchXMLTableHelper::applyTableToInternalDataProvider(
if( !xDataProv.is() )
return;
-if(eDataRowSource == chart::ChartDataRowSource_ROWS)
-transposeTable(rTable);
-
//prepare the read local table data
sal_Int32 nNumRows( static_cast sal_Int32 ( rTable.aData.size()));
sal_Int32 nRowOffset = 0;
diff --git a/xmloff/source/chart/SchXMLTableContext.hxx
b/xmloff/source/chart/SchXMLTableContext.hxx
index 811e921..1d06dd5 100644
--- a/xmloff/source/chart/SchXMLTableContext.hxx
+++ b/xmloff/source/chart/SchXMLTableContext.hxx
@@ -82,9 +82,8 @@ private:
sal_Int32 nRows, sal_Int32 nColumns );
public:
-static void applyTableToInternalDataProvider( SchXMLTable rTable,
-com::sun::star::uno::Reference
com::sun::star::chart2::XChartDocument xChartDoc,
-com::sun::star::chart::ChartDataRowSource
eDataRowSource );
+static void applyTableToInternalDataProvider( const SchXMLTable rTable,
+com::sun::star::uno::Reference
[Bug 63154] replace tools/solar.h macros with osl versions
https://bugs.freedesktop.org/show_bug.cgi?id=63154
--- Comment #32 from Michael Meeks michael.me...@collabora.com ---
There are 600 or so hits of DELETEZ, in each case we'd need to work out whether
the memory could be re-used inadvertently and I guess add a manual NULL as/when
we think it could be; that my be somewhat hard to verify of course.
I'm not against that, clearly any usage of DELETEZ of a member in a destructor
is bogus eg.
accessibility/source/extended/accessibletabbarbase.cxx-
AccessibleTabBarBase::~AccessibleTabBarBase()
{
ClearTabBarPointer();
DELETEZ( m_pExternalLock );
}
or
cui/source/tabpages/macroass.cxx
_SfxMacroTabPage::~_SfxMacroTabPage()
{
DELETEZ( mpImpl );
}
And those can be removed safely. I guess we should consult some C++ guru - who
(no doubt) would recommend one of the bewildering array of templatized smart
pointers of varying efficiency that can magically do something similar :-)
--
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: writerfilter/Library_writerfilter.mk writerfilter/source
writerfilter/Library_writerfilter.mk|1
writerfilter/source/doctok/WW8ListTable.cxx | 42
writerfilter/source/doctok/resources.xmi|6
3 files changed, 49 deletions(-)
New commits:
commit 5730ff36a17fcb7fc4613d3887e7e6b5017db275
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Nov 2 21:04:59 2013 +0100
writerfilter: remove unused WW8List class in doctok
Change-Id: Ie295fda55747995f4e4a4fd877e1bc3f8c194521
diff --git a/writerfilter/Library_writerfilter.mk
b/writerfilter/Library_writerfilter.mk
index 3334b4e..4f04de5 100644
--- a/writerfilter/Library_writerfilter.mk
+++ b/writerfilter/Library_writerfilter.mk
@@ -127,7 +127,6 @@ $(eval $(call
gb_Library_add_exception_objects,writerfilter,\
writerfilter/source/doctok/WW8CpAndFc \
writerfilter/source/doctok/WW8FKPImpl \
writerfilter/source/doctok/WW8FontTable \
-writerfilter/source/doctok/WW8ListTable \
writerfilter/source/doctok/WW8Picture \
writerfilter/source/doctok/WW8PropertySetImpl \
writerfilter/source/doctok/WW8ResourceModelImpl \
diff --git a/writerfilter/source/doctok/WW8ListTable.cxx
b/writerfilter/source/doctok/WW8ListTable.cxx
deleted file mode 100644
index 45d0f1e..000
--- a/writerfilter/source/doctok/WW8ListTable.cxx
+++ /dev/null
@@ -1,42 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include doctok/resources.hxx
-#include WW8ResourceModelImpl.hxx
-
-namespace writerfilter {
-namespace doctok {
-
-sal_uInt32 WW8List::get_listlevel_count()
-{
-if (get_fSimpleList())
-return 1;
-
-return 9;
-}
-
-writerfilter::ReferenceProperties::Pointer_t
-WW8List::get_listlevel(sal_uInt32 /*nIndex*/)
-{
-return writerfilter::ReferenceProperties::Pointer_t();
-}
-
-}}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/doctok/resources.xmi
b/writerfilter/source/doctok/resources.xmi
index 21f0060..605b756 100644
--- a/writerfilter/source/doctok/resources.xmi
+++ b/writerfilter/source/doctok/resources.xmi
@@ -1573,12 +1573,6 @@
!--Class ListLevel--
!--Class List--
UML:Class xmi.id=List name=List
- UML:ModelElement.stereotype
-UML:Stereotype xmi.idref=ww8resource/
- /UML:ModelElement.stereotype
- UML:ModelElement.stereotype
-UML:Stereotype xmi.idref=withindex/
- /UML:ModelElement.stereotype
UML:ModelElement.taggedValue
UML:TaggedValue
UML:TaggedValue.dataValue28/UML:TaggedValue.dataValue
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 60270] LibreOffice 4.1 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 67572, which changed state. Bug 67572 Summary: Functions with *_ADD don't work correct on xslx export https://bugs.freedesktop.org/show_bug.cgi?id=67572 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/formulabase.hxx |1 +
sc/source/filter/oox/formulabase.cxx | 27 ---
2 files changed, 17 insertions(+), 11 deletions(-)
New commits:
commit da7c6092a644dc22f90fb8eef0c4f0df06ec204a
Author: Eike Rathke er...@redhat.com
Date: Sat Nov 2 21:03:17 2013 +0100
resolved fdo#67572 export add-in equivalents as internal to .xlsx
For OOXML .xlsx export the add-in functions that are equivalents of
known internal functions as those internal functions.
Change-Id: Ic41f32b67902effa07c3d4db137be08dc5af7265
diff --git a/sc/source/filter/inc/formulabase.hxx
b/sc/source/filter/inc/formulabase.hxx
index cb2785e..50948f7 100644
--- a/sc/source/filter/inc/formulabase.hxx
+++ b/sc/source/filter/inc/formulabase.hxx
@@ -499,6 +499,7 @@ struct FunctionInfo
boolmbParamPairs; /// True = optional parameters are
expected to appear in pairs.
boolmbVolatile; /// True = volatile function.
boolmbExternal; /// True = external function in
Calc.
+boolmbInternal; /// True = internal function in
Calc. (Both can be true!)
boolmbMacroFunc;/// True = macro sheet function or
command.
boolmbVarParam; /// True = use a tFuncVar token,
also if min/max are equal.
};
diff --git a/sc/source/filter/oox/formulabase.cxx
b/sc/source/filter/oox/formulabase.cxx
index 420c1a2..146f332 100644
--- a/sc/source/filter/oox/formulabase.cxx
+++ b/sc/source/filter/oox/formulabase.cxx
@@ -212,6 +212,7 @@ const sal_uInt16 FUNCFLAG_MACROCALL_NEW =
FUNCFLAG_MACROCALL | FUNCFLAG_MACR
must exist. */
const sal_uInt16 FUNCFLAG_BIFFIMPORTONLY= 0x0800; /// Only used in BIFF
binary import filter.
const sal_uInt16 FUNCFLAG_BIFFEXPORTONLY= 0x1000; /// Only used in BIFF
binary export filter.
+const sal_uInt16 FUNCFLAG_INTERNAL = 0x2000; /// Function is
internal in Calc.
/// Converts a function library index (value of enum FunctionLibraryType) to
function flags.
#define FUNCLIB_TO_FUNCFLAGS( funclib_index ) static_cast sal_uInt16 (
static_cast sal_uInt8 ( funclib_index ) 12 )
@@ -584,8 +585,8 @@ static const FunctionData saFuncTableBiff4[] =
{ QUOTIENT, QUOTIENT, 417,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
{ DELTA, DELTA,418,NOID, 1, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
{ GESTEP, GESTEP, 419,NOID, 1, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
-{ ISEVEN, ISEVEN, 420,NOID, 1, 1,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
-{ ISODD, ISODD,421,NOID, 1, 1,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
+{ ISEVEN, ISEVEN, 420,NOID, 1, 1,
V, { RR }, FUNCFLAG_EXTERNAL | FUNCFLAG_INTERNAL }, // Calc: builtin and add-in
+{ ISODD, ISODD,421,NOID, 1, 1,
V, { RR }, FUNCFLAG_EXTERNAL | FUNCFLAG_INTERNAL }, // Calc: builtin and add-in
{ MROUND, MROUND, 422,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
{ ERF,ERF, 423,NOID, 1, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
{ ERFC, ERFC, 424,NOID, 1, 1,
V, { RR }, FUNCFLAG_EXTERNAL },
@@ -609,10 +610,10 @@ static const FunctionData saFuncTableBiff4[] =
{ YIELD, YIELD,442,NOID, 6, 7,
V, { RR }, FUNCFLAG_EXTERNAL },
{ DOLLARDE, DOLLARDE, 443,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
{ DOLLARFR, DOLLARFR, 444,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL },
-{ NOMINAL,NOMINAL, 445,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
-{ EFFECT, EFFECT, 446,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
-{ CUMPRINC, CUMPRINC, 447,NOID, 6, 6,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
-{ CUMIPMT,CUMIPMT, 448,NOID, 6, 6,
V, { RR }, FUNCFLAG_EXTERNAL }, // Calc: builtin and add-in
+{ NOMINAL,NOMINAL, 445,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL | FUNCFLAG_INTERNAL }, // Calc: builtin and add-in
+{ EFFECT, EFFECT, 446,NOID, 2, 2,
V, { RR }, FUNCFLAG_EXTERNAL | FUNCFLAG_INTERNAL }, // Calc: builtin and add-in
+{ CUMPRINC, CUMPRINC, 447,NOID, 6, 6,
V, {
[Libreoffice-commits] core.git: 10 commits - compilerplugins/Makefile config_host.mk.in configure.ac external/firebird external/icu instsetoo_native/CustomTarget_install.mk Makefile.gbuild Makefile.in
Makefile.gbuild|2 Makefile.in|6 - compilerplugins/Makefile |2 config_host.mk.in |1 configure.ac |9 +- external/firebird/ExternalProject_firebird.mk |2 external/icu/ExternalProject_icu.mk|2 instsetoo_native/CustomTarget_install.mk |2 nss/ExternalProject_nss.mk |2 postprocess/CustomTarget_images.mk |7 +- postprocess/CustomTarget_registry.mk |4 - redland/ExternalProject_rasqal.mk |2 redland/ExternalProject_redland.mk |2 solenv/bin/callcatcher.Makefile|2 solenv/bin/install-gdb-printers|2 solenv/bin/make_installer.pl |2 solenv/bin/modules/installer/parameter.pm |2 solenv/bin/ooinstall |4 - solenv/bin/par2script.pl |2 solenv/bin/pre2par.pl |2 solenv/gbuild/AllLangResTarget.mk |2 solenv/gbuild/CliAssembly.mk |2 solenv/gbuild/ComponentTarget.mk |2 solenv/gbuild/CppunitTest.mk |2 solenv/gbuild/Executable.mk|2 solenv/gbuild/Gallery.mk |2 solenv/gbuild/InstallModuleTarget.mk |2 solenv/gbuild/InstallScript.mk |2 solenv/gbuild/Library.mk | 21 +- solenv/gbuild/LinkTarget.mk| 81 - solenv/gbuild/Rdb.mk |3 solenv/gbuild/TargetLocations.mk | 43 - solenv/gbuild/UnoApiTarget.mk |6 - solenv/gbuild/extensions/pre_SharedLangList.mk |2 solenv/gbuild/partial_build.mk |4 - solenv/gbuild/platform/macosx.mk |4 - sysui/CustomTarget_share.mk|2 37 files changed, 73 insertions(+), 168 deletions(-) New commits: commit d800a25568643fd1c7fb634cc9fbfcbd255d6162 Author: Michael Stahl mst...@redhat.com Date: Fri Nov 1 14:17:17 2013 +0100 gbuild: Library: remove gb_Library__get_final_target ... use gb_Library_get_exports_target instead, which is already a final target for Library. Change-Id: I5b8a708ba97e351ef383dcc64ead4ab9ea8705c7 diff --git a/solenv/gbuild/Library.mk b/solenv/gbuild/Library.mk index 71ed8b5..a0c3e70 100644 --- a/solenv/gbuild/Library.mk +++ b/solenv/gbuild/Library.mk @@ -35,13 +35,6 @@ gb_Library_LAYER_DIRS := \ OXT:$(WORKDIR)/LinkTarget/ExtensionLibrary \ NONE:$(gb_Library_DLLDIR) \ -$(dir $(call gb_Library__get_final_target,%)).dir : - $(if $(wildcard $(dir $@)),,mkdir -p $(dir $@)) - -# doesn't do anything, just used for hooking up component target -$(call gb_Library__get_final_target,%) : - touch $@ - # EVIL: gb_StaticLibrary and gb_Library need the same deliver rule because they are indistinguishable on windows .PHONY : $(WORKDIR)/Clean/Library/% $(WORKDIR)/Clean/Library/% : @@ -91,8 +84,6 @@ $(call gb_LinkTarget_add_libs,$(2),$(gb_STDLIBS)) $(call gb_LinkTarget_add_defs,$(2),\ $(gb_Library_DEFS) \ ) -$(call gb_Library__get_final_target,$(1)) : $(call gb_Library_get_target,$(1)) -$(call gb_Library__get_final_target,$(1)) :| $(dir $(call gb_Library__get_final_target,$(1))).dir $(call gb_Library_get_exports_target,$(1)) : $(call gb_Library_get_target,$(1)) $(call gb_LinkTarget_get_headers_target,$(2)) : \ | $(dir $(call gb_Library_get_ilib_target,$(1))).dir @@ -100,9 +91,9 @@ $(call gb_Library_get_clean_target,$(1)) : $(call gb_LinkTarget_get_clean_target $(call gb_Library_get_clean_target,$(1)) : AUXTARGETS := $(call gb_Library_Library_platform,$(1),$(2),$(call gb_Library_get_ilib_target,$(1))) -$$(eval $$(call gb_Module_register_target,$(call gb_Library__get_final_target,$(1)),$(call gb_Library_get_clean_target,$(1 +$$(eval $$(call gb_Module_register_target,$(call gb_Library_get_exports_target,$(1)),$(call gb_Library_get_clean_target,$(1 -$(call gb_Helper_make_userfriendly_targets,$(1),Library,$(call gb_Library__get_final_target,$(1))) +$(call gb_Helper_make_userfriendly_targets,$(1),Library,$(call gb_Library_get_exports_target,$(1))) endef @@ -138,8 +129,9 @@ endef # The dependency from workdir component target to outdir library should ensure # that gb_CppunitTest_use_component can transitively depend on the library. -# But the component target also must be delivered, so a new phony target -# gb_Library__get_final_target has been invented for that purpose... +# But the component target also must be delivered; use the target +# gb_Library_get_exports_target for that purpose, since it is already +# the final target of the
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sw/source
sw/source/core/layout/wsfrm.cxx | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
New commits:
commit c5112b0ab7c97a092981fe0d1a6c8bf37931b53e
Author: Caolán McNamara caol...@redhat.com
Date: Thu Oct 31 10:08:46 2013 +
Resolves: fdo#70358 crash when deleting tables
Change-Id: I87282e363425a1bb6d9ab92e07717f66ee56a6c5
(cherry picked from commit e8e12b32ae23ee9b1613ef7794b83adbde27e9f8)
Reviewed-on: https://gerrit.libreoffice.org/6509
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sw/source/core/layout/wsfrm.cxx b/sw/source/core/layout/wsfrm.cxx
index de45f50..007de68 100644
--- a/sw/source/core/layout/wsfrm.cxx
+++ b/sw/source/core/layout/wsfrm.cxx
@@ -2650,8 +2650,15 @@ SwTwips SwLayoutFrm::ShrinkFrm( SwTwips nDist, sal_Bool
bTst, sal_Bool bInfo )
{
_InvalidateAll();
InvalidatePage( pPage );
-const SvxGraphicPosition ePos =
GetFmt()-GetBackground().GetGraphicPos();
-if ( GPOS_NONE != ePos GPOS_TILED != ePos )
+bool bCompletePaint = true;
+const SwFrmFmt* pFmt = GetFmt();
+if (pFmt)
+{
+const SvxGraphicPosition ePos =
pFmt-GetBackground().GetGraphicPos();
+if ( GPOS_NONE == ePos || GPOS_TILED == ePos )
+bCompletePaint = false;
+}
+if (bCompletePaint)
SetCompletePaint();
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/LinkTarget.mk | 19 +++ 1 file changed, 19 insertions(+) New commits: commit 35210e2272081cef47ec63cca933e0c55424e6cb Author: Michael Stahl mst...@redhat.com Date: Sat Nov 2 16:16:21 2013 +0100 gbuild: LinkTarget: improve gb_LinkTarget__get_headers_check Can actually error out early in some cases of partial build with missing deps from other modules; probably better than trying to build (Static)Library with bogus vars. Change-Id: I4e2cbd42d3c84b9bc87607d263f3d80ba7914302 diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk index d804824..8e7e002 100644 --- a/solenv/gbuild/LinkTarget.mk +++ b/solenv/gbuild/LinkTarget.mk @@ -815,6 +815,14 @@ define gb_PrintDeps_info $(info LibraryDep: $(1) links against $(2)) endef +# avoid problem when a module is built partially but other modules that define +# needed libraries is not yet built: prevent invocation of pattern rule +# for library with invalid parameters by depending on the header target +define gb_LinkTarget__lib_dummy_depend +$(call gb_Library_get_target,$(1)) :| $(call gb_Library_get_headers_target,$(1)) + +endef + # call gb_LinkTarget__use_libraries,linktarget,requestedlibs,actuallibs,linktargetmakefilename define gb_LinkTarget__use_libraries @@ -834,6 +842,7 @@ $(call gb_LinkTarget_get_target,$(1)) : \ $(foreach lib,$(3),$(call gb_Library_get_exports_target,$(lib))) $(call gb_LinkTarget_get_headers_target,$(1)) : \ $(foreach lib,$(2),$(call gb_Library_get_headers_target,$(lib))) +$(foreach lib,$(2),$(call gb_LinkTarget__lib_dummy_depend,$(lib))) endef @@ -894,6 +903,15 @@ $$(call gb_Output_error,\ gb_LinkTarget_add_linked_static_libs: use gb_LinkTarget_use_static_libraries instead.) endef +# avoid problem when a module is built partially but other modules that define +# needed static libraries is not yet built: prevent invocation of pattern rule +# for static library with invalid parameters by depending on the header target +define gb_LinkTarget__static_lib_dummy_depend +$(call gb_StaticLibrary_get_target,$(1)) :| \ + $(call gb_StaticLibrary_get_headers_target,$(1)) + +endef + # for a StaticLibrary, dependent libraries are not actually linked in # call gb_LinkTarget_use_static_libraries,linktarget,staticlibs define gb_LinkTarget_use_static_libraries @@ -902,6 +920,7 @@ $(call gb_LinkTarget_get_target,$(1)) : LINKED_STATIC_LIBS += $$(if $$(filter-ou $(call gb_LinkTarget_get_target,$(1)) : $(foreach lib,$(2),$(call gb_StaticLibrary_get_target,$(lib))) $(call gb_LinkTarget_get_headers_target,$(1)) : \ $(foreach lib,$(2),$(call gb_StaticLibrary_get_headers_target,$(lib))) +$(foreach lib,$(2),$(call gb_LinkTarget__static_lib_dummy_depend,$(lib))) endef ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/docmacromode.cxx | 29 ++---
1 file changed, 14 insertions(+), 15 deletions(-)
New commits:
commit 2e803712c4c2b844dab1fefdfbda12058a5f1ab7
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 23:29:27 2013 +0100
don't warn for empty VBA structure, fdo#61059
Change-Id: I0d0f7fa216fcea7ca893120ad183dc3758ca51d4
diff --git a/sfx2/source/doc/docmacromode.cxx b/sfx2/source/doc/docmacromode.cxx
index 3969b1c..fac3a7b 100644
--- a/sfx2/source/doc/docmacromode.cxx
+++ b/sfx2/source/doc/docmacromode.cxx
@@ -331,25 +331,24 @@ namespace sfx2
else
{
OUString aStdLibName( Standard );
+OUString aVBAProject( VBAProject );
Sequence OUString aElements =
xContainer-getElementNames();
if ( aElements.getLength() )
{
-if ( aElements.getLength() 1 ||
!aElements[0].equals( aStdLibName ) )
-bHasMacroLib = sal_True;
-else
+sal_Int32 nElements = aElements.getLength();
+for( sal_Int32 i = 0; i nElements; ++i )
{
-// usually a Standard library is always present
(design)
-// for this reason we must check if it's empty
-//
-// Note: Since #i73229#, this is not true anymore.
There's no default
-// Standard lib anymore. Wouldn't it be time to
get completely
-// rid of the Standard thingie - this shouldn't
be necessary
-// anymore, should it?
-Reference XNameAccess xLib;
-Any aAny = xContainer-getByName( aStdLibName );
-aAny = xLib;
-if ( xLib.is() )
-bHasMacroLib = xLib-hasElements();
+OUString aElement = aElements[i];
+if( aElement == aStdLibName || aElement ==
aVBAProject )
+{
+Reference XNameAccess xLib;
+Any aAny = xContainer-getByName( aStdLibName
);
+aAny = xLib;
+if ( xLib.is() xLib-hasElements() )
+return sal_True;
+}
+else
+return sal_True;
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sc/source
sc/source/ui/view/output2.cxx |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
New commits:
commit de67c6d6159c0801b0959d77c2c8a8b7fb148b03
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 20:30:14 2013 +0100
no default LTR mode does not mean RTL, fdo#68097
Change-Id: Ice4957077e7eda5f7bb93042d6e2ba745935ef8b
(cherry picked from commit 045e037b7acde9d8e63fbb977c28b167e8815278)
Reviewed-on: https://gerrit.libreoffice.org/6527
Tested-by: Eike Rathke er...@redhat.com
Reviewed-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 8c64393..cf7be64 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -1666,8 +1666,13 @@ void ScOutputData::DrawStrings( sal_Bool bPixelToLogic )
{
const SfxPoolItem* pItem = mpDoc-GetAttr( nCellX,
nCellY, nTab, ATTR_WRITINGDIR );
const SvxFrameDirectionItem* pCurrentWritingMode =
(const SvxFrameDirectionItem*) pItem;
-if (pCurrentWritingMode-GetValue() ==
FRMDIR_HORI_LEFT_TOP)
+sal_uInt16 aDirection =
pCurrentWritingMode-GetValue();
+if ( aDirection == FRMDIR_HORI_LEFT_TOP || aDirection
== FRMDIR_VERT_TOP_LEFT )
eOutHorJust = SVX_HOR_JUSTIFY_LEFT;
+else if ( aDirection == FRMDIR_ENVIRONMENT )
+{
+eOutHorJust = mpDoc-IsLayoutRTL(nTab) ?
SVX_HOR_JUSTIFY_RIGHT : SVX_HOR_JUSTIFY_LEFT;
+}
else
eOutHorJust = SVX_HOR_JUSTIFY_RIGHT;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sc/source
sc/source/filter/oox/sheetdatabuffer.cxx |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 8c4f9aff76e931613c3e6a99879c2b5353231853
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sat Nov 2 17:04:34 2013 +0100
remember column style during XLSX import, fdo#70315
WE overwrote the column style that was set earlier with the default
style.
Change-Id: I4c02e1cdd3e72f27d75b8153e2af45b5658ff456
(cherry picked from commit 512a14438c4098ca2e30d0b10b6e18506c8475f1)
Reviewed-on: https://gerrit.libreoffice.org/6528
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sc/source/filter/oox/sheetdatabuffer.cxx
b/sc/source/filter/oox/sheetdatabuffer.cxx
index 174842a..2b9f4ce 100644
--- a/sc/source/filter/oox/sheetdatabuffer.cxx
+++ b/sc/source/filter/oox/sheetdatabuffer.cxx
@@ -50,6 +50,7 @@
#include document.hxx
#include scitems.hxx
#include formulacell.hxx
+#include docpool.hxx
namespace oox {
namespace xls {
@@ -468,7 +469,8 @@ void SheetDataBuffer::finalizeImport()
{
ScAttrEntry aEntry;
aEntry.nRow = MAXROW;
-aEntry.pPattern = rDoc.GetDefPattern();
+aEntry.pPattern = rDoc.GetPattern(nScCol, 0, getSheetIndex());
+rDoc.GetPool()-Put(*aEntry.pPattern);
aAttrs.push_back(aEntry);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/ia2' - 6 commits - accessibility/Module_accessibility.mk config_host.mk.in configure.ac include/vcl postprocess/Rdb_services.mk Repository.mk solenv/gbu
Repository.mk |4 accessibility/Module_accessibility.mk |2 config_host.mk.in |1 configure.ac | 20 include/vcl/svapp.hxx |2 postprocess/Rdb_services.mk |7 solenv/gbuild/platform/windows.mk |3 winaccessibility/CustomTarget_ia2_idl.mk | 56 winaccessibility/Library_uacccom.mk | 87 winaccessibility/Library_winaccessibility.mk | 81 winaccessibility/Makefile | 14 winaccessibility/Module_winaccessibility.mk | 25 winaccessibility/WinResTarget_uacccom.mk | 31 winaccessibility/inc/AccEventListener.hxx |4 winaccessibility/inc/AccObjectWinManager.hxx |8 winaccessibility/source/UAccCOM/AccAction.cpp | 120 winaccessibility/source/UAccCOM/AccAction.cxx | 120 winaccessibility/source/UAccCOM/AccActionBase.cpp | 416 - winaccessibility/source/UAccCOM/AccActionBase.cxx | 416 + winaccessibility/source/UAccCOM/AccActionBase.h |2 winaccessibility/source/UAccCOM/AccComponent.cpp | 72 winaccessibility/source/UAccCOM/AccComponent.cxx | 72 winaccessibility/source/UAccCOM/AccComponentBase.cpp | 213 winaccessibility/source/UAccCOM/AccComponentBase.cxx | 213 winaccessibility/source/UAccCOM/AccComponentBase.h|2 winaccessibility/source/UAccCOM/AccEditableText.cpp | 508 -- winaccessibility/source/UAccCOM/AccEditableText.cxx | 508 ++ winaccessibility/source/UAccCOM/AccHyperLink.cpp | 296 - winaccessibility/source/UAccCOM/AccHyperLink.cxx | 296 + winaccessibility/source/UAccCOM/AccHypertext.cpp | 406 - winaccessibility/source/UAccCOM/AccHypertext.cxx | 406 + winaccessibility/source/UAccCOM/AccImage.cpp | 102 winaccessibility/source/UAccCOM/AccImage.cxx | 102 winaccessibility/source/UAccCOM/AccRelation.cpp | 214 winaccessibility/source/UAccCOM/AccRelation.cxx | 214 winaccessibility/source/UAccCOM/AccTable.cpp | 1064 winaccessibility/source/UAccCOM/AccTable.cxx | 1064 winaccessibility/source/UAccCOM/AccText.cpp | 282 - winaccessibility/source/UAccCOM/AccText.cxx | 282 + winaccessibility/source/UAccCOM/AccTextBase.cpp | 995 winaccessibility/source/UAccCOM/AccTextBase.cxx | 994 winaccessibility/source/UAccCOM/AccTextBase.h |2 winaccessibility/source/UAccCOM/AccValue.cpp | 224 winaccessibility/source/UAccCOM/AccValue.cxx | 224 winaccessibility/source/UAccCOM/CheckEnableAccessible.cpp | 35 winaccessibility/source/UAccCOM/CheckEnableAccessible.cxx | 34 winaccessibility/source/UAccCOM/EnumVariant.cpp | 224 winaccessibility/source/UAccCOM/EnumVariant.cxx | 224 winaccessibility/source/UAccCOM/EnumVariant.h |2 winaccessibility/source/UAccCOM/MAccessible.cpp | 3262 -- winaccessibility/source/UAccCOM/MAccessible.cxx | 3262 ++ winaccessibility/source/UAccCOM/Resource.h|1 winaccessibility/source/UAccCOM/StdAfx.cpp| 29 winaccessibility/source/UAccCOM/StdAfx.cxx| 29 winaccessibility/source/UAccCOM/UAccCOM.cpp | 119 winaccessibility/source/UAccCOM/UAccCOM.cxx | 119 winaccessibility/source/UAccCOM/UAccCOM.def |7 winaccessibility/source/UAccCOM/UNOXWrapper.cpp | 27 winaccessibility/source/UAccCOM/UNOXWrapper.cxx | 27 winaccessibility/source/UAccCOM/UNOXWrapper.h |2 winaccessibility/source/service/AccEventListener.cxx |8 winaccessibility/source/service/AccFrameEventListener.cxx | 10 winaccessibility/source/service/AccObjectWinManager.cxx | 12 winaccessibility/source/service/AccTopWindowListener.cxx | 11 winaccessibility/source/service/checkmt.cxx |5 winaccessibility/source/service/checkmt.hxx |5 winaccessibility/source/service/msaaservice_impl.cxx | 14 67 files changed, 8984 insertions(+), 8658 deletions(-) New commits: commit 903ab3e93ecded38b4ff0e0a85db16226545b750 Author: David Ostrovsky da...@ostrovsky.org Date: Sat Nov 2 20:40:47 2013 +0100 Gbuildify winaccessibility service Change-Id: Ia66872bee7c70c840c1bd5caa626bf63eac9ef7c diff --git a/Repository.mk b/Repository.mk index d032943..90840bf 100755 --- a/Repository.mk +++ b/Repository.mk @@ -564,7 +564,10 @@ $(eval $(call
[Libreoffice-commits] core.git: RepositoryExternal.mk RepositoryFixes.mk Repository.mk
Repository.mk | 15 - RepositoryExternal.mk | 78 +- RepositoryFixes.mk| 52 - 3 files changed, 3 insertions(+), 142 deletions(-) New commits: commit 5f9cda2dc5e6d217328ff4f7da27a6f0e6fcf5de Author: Michael Stahl mst...@redhat.com Date: Fri Nov 1 15:43:47 2013 +0100 Repository*: no need to register libraries built via ExternalProject Only libraries (and similar for executables) built as Library need to be registered; those built via ExternalProject are delivered by Project and used via gb_LinkTarget_add_libs. This also means there is no need to mangle the names in RepositoryFixes.mk. Change-Id: Ib0b67f54e2eb6efdb0c454c9e2dd599ada229676 Reviewed-on: https://gerrit.libreoffice.org/6533 Tested-by: LibreOffice gerrit bot ger...@libreoffice.org Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/Repository.mk b/Repository.mk index b3e21fe..c490c6b 100644 --- a/Repository.mk +++ b/Repository.mk @@ -646,21 +646,6 @@ $(eval $(call gb_Helper_register_libraries,EXTENSIONLIBS, \ passive_native \ )) -ifeq ($(OS),WNT) -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - xmlsec1 \ -)) -ifeq ($(COM),MSC) -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - xmlsec1-mscrypto \ -)) -else -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - xmlsec1-nss \ -)) -endif -endif - $(eval $(call gb_Helper_register_jars,URE, \ java_uno \ juh \ diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index d3b8dc5..568d2ac 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -192,10 +192,6 @@ endef else -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE,\ -cppunit \ -)) - define gb_LinkTarget__use_cppunit $(call gb_LinkTarget_use_external_project,$(1),cppunit) @@ -767,10 +763,6 @@ gb_ExternalProject__use_libxml2:= else # !SYSTEM_LIBXML -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_URE, \ - xml2 \ -)) - define gb_LinkTarget__use_libxml2 $(call gb_LinkTarget_use_package,$(1),xml2) $(call gb_LinkTarget_set_include,$(1),\ @@ -820,11 +812,6 @@ endef else # !SYSTEM_LIBXSLT -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - exslt \ - xslt \ -)) - define gb_LinkTarget__use_libxslt $(call gb_LinkTarget_use_package,$(1),xslt) $(call gb_LinkTarget_set_include,$(1),\ @@ -990,11 +977,13 @@ endef ifneq ($(OS),ANDROID) +ifeq ($(COM),MSC) $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ raptor2 \ rasqal \ rdf \ )) +endif define gb_LinkTarget__use_librdf $(call gb_LinkTarget_use_packages,$(1),raptor rasqal redland) @@ -1039,13 +1028,6 @@ endef else ifeq ($(SYSTEM_CAIRO),NO) -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - cairo \ - $(if $(filter-out MACOSX WNT,$(OS)), \ - pixman-1 \ - ) \ -)) - define gb_LinkTarget__use_cairo $(call gb_LinkTarget_use_package,$(1),cairo) $(call gb_LinkTarget_use_package,$(1),pixman) @@ -1206,21 +1188,6 @@ $(call gb_ExternalProject_use_package,$(1),icu) endef # icudata and icui18n is called icudt and icuin when built with MSVC :-/ -ifeq ($(OS)$(COM),WNTMSC) -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - icudt \ - icuin \ -)) -else -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - icudata$(gb_ICU_suffix) \ - icui18n$(gb_ICU_suffix) \ -)) -endif -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - icuuc$(gb_ICU_suffix) \ -)) - define gb_LinkTarget__use_icudata $(call gb_LinkTarget_use_package,$(1),icu) @@ -1323,13 +1290,6 @@ endef else # !SYSTEM_OPENSSL -ifeq ($(OS),WNT) -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ -crypto \ -ssl \ -)) -endif - define gb_ExternalProject__use_openssl $(call gb_ExternalProject_use_package,$(1),openssl) @@ -1745,10 +1705,6 @@ endef else -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - lcms2 \ -)) - define gb_LinkTarget__use_lcms2 $(call gb_LinkTarget_use_package,$(1),lcms2) $(call gb_LinkTarget_set_include,$(1),\ @@ -1775,10 +1731,6 @@ endef else # !SYSTEM_LPSOLVE -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - lpsolve55 \ -)) - define gb_LinkTarget__use_lpsolve $(call gb_LinkTarget_use_unpacked,$(1),lpsolve) ifeq ($(COM),MSC) @@ -2020,10 +1972,6 @@ endef else # !SYSTEM_CURL -$(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \ - curl \ -)) - define gb_LinkTarget__use_curl $(call gb_LinkTarget_use_package,$(1),curl) $(call gb_LinkTarget_set_include,$(1),\ @@ -2248,10 +2196,6 @@ else # !SYSTEM_FIREBIRD #$(call gb_LinkTarget__use_libatomic_ops,$(1)) -$(eval $(call
[Bug 71043] Use STACK lint tool to clean code ...
https://bugs.freedesktop.org/show_bug.cgi?id=71043 --- Comment #8 from José Guilherme Vanz v...@libreoffice.org --- I was looking for the reason the STACK does not works well in our dabatase. Well, STACK use clang compiler to does its job. So, if we compile libo with clang we can see this error message: clang: error: unknown argument: '-fno-enforce-eh-specs' How can I solve the problem? How can I remove the argument when compile if clang? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: starmath/qa
starmath/qa/cppunit/test_nodetotextvisitors.cxx | 40
1 file changed, 8 insertions(+), 32 deletions(-)
New commits:
commit bd69146cdf28cc7c359974de97cad8202fc45e48
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Sun Nov 3 04:10:10 2013 +0100
improve starmath test code
Change-Id: Ife7e1306ce65dc1d935181553803fbc9266b628c
diff --git a/starmath/qa/cppunit/test_nodetotextvisitors.cxx
b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
index e2da017..3d4b08f 100644
--- a/starmath/qa/cppunit/test_nodetotextvisitors.cxx
+++ b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
@@ -18,24 +18,6 @@
#include visitors.hxx
#include cursor.hxx
-namespace CppUnit {
-template
-struct assertion_traitsOUString
-{
-static bool equal(const OUString x, const OUString y)
-{
-return x == y;
-}
-
-static std::string toString(const OUString x)
-{
-OStringStream ost;
-ost OUStringToOString(x, RTL_TEXTENCODING_UTF8).getStr();
-return ost.str();
-}
-};
-}
-
SV_DECL_REF(SmDocShell)
SV_IMPL_REF(SmDocShell)
@@ -578,12 +560,10 @@ void Test::testBinVerInUnary()
void Test::testBinHorInSubSup()
{
-OUString sInput, sExpected;
-SmNode* pTree;
+OUString sInput;
// set up a blank formula
-sInput += ;
-pTree = SmParser().Parse(sInput);
+SmNode* pTree = SmParser().Parse(sInput);
pTree-Prepare(xDocShRef-GetFormat(), *xDocShRef);
SmCursor aCursor(pTree, xDocShRef);
@@ -601,7 +581,7 @@ void Test::testBinHorInSubSup()
aCursor.InsertElement(PlusElement);
aCursor.InsertText(d);
-sExpected += { a rsup { b + c } + d } ;
+OUString sExpected = { a rsup { b + c } + d } ;
//FIXMECPPUNIT_ASSERT_EQUAL_MESSAGE(BinHor in SubSup, sExpected,
xDocShRef-GetText());
delete pTree;
@@ -609,20 +589,16 @@ void Test::testBinHorInSubSup()
void Test::testUnaryInMixedNumberAsNumerator()
{
-OUString sInput, sExpected;
-SmNode* pTree;
-
// set up a unary operator
-sInput += - 1;
-pTree = SmParser().Parse(sInput);
+OUString sInput = - 1;
+SmNode* pTree = SmParser().Parse(sInput);
pTree-Prepare(xDocShRef-GetFormat(), *xDocShRef);
SmCursor aCursor(pTree, xDocShRef);
TestOutputDevice aOutputDevice;
// move forward (more than) enough places to be at the end
-int i;
-for (i = 0; i 3; ++i)
+for (size_t i = 0; i 3; ++i)
aCursor.Move(aOutputDevice, MoveRight);
// Select the whole Unary Horizontal Node
@@ -641,14 +617,14 @@ void Test::testUnaryInMixedNumberAsNumerator()
aCursor.InsertText(2);
// move forward (more than) enough places to be at the end
-for (i = 0; i 8; ++i)
+for (size_t i = 0; i 8; ++i)
aCursor.Move(aOutputDevice, MoveRight);
// add 4 to the end
aCursor.InsertElement(PlusElement);
aCursor.InsertText(4);
-sExpected += { 2 { - 1 over 2 } + 4 } ;
+OUString sExpected = { 2 { - 1 over 2 } + 4 } ;
CPPUNIT_ASSERT_EQUAL_MESSAGE(Unary in mixed number as Numerator,
sExpected, xDocShRef-GetText());
delete pTree;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] PENDING ITEM: Updates to the BSA
Hi All, I think we should just collapse to a 3.x series and have that tell you that it is too old. But what I also noticed was that we are asing for: - Version the bug appeared - Latest known-working version It seems to me that the 1st one is always the 2nd version + 1. If somebody looks at it. Shouldn't one of those be the version people are working in, as that needs to be checked by BSA to see if it needs to give this warning. -- Greetings, Rob Snelders Robinson Tryon schreef op 02-11-2013 01:04: On Fri, Nov 1, 2013 at 5:13 PM, Rob Snelders libreoff...@ertai.nl wrote: Hi All, Looking at the action-items open on [1]. I found this one: PENDING ITEM: Updates to the BSA ACTION: Remove EOL versions from the BSA and implement 'please update' message (Rob) But that has already been implemented back in July by Robinson[2]. So that action-item can be closed It's still possible to file bugs against EOL versions using the BSA. For example: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=71150 I think we can remove all of the versions from unsupported-versions.txt and blacklist all of the EOL releases by adding them to in version-blacklist.txt. My thinking would be to add a single version Older to the drop-down list and use that as the trigger for when the please update message appears. Or perhaps we can just tweak the code so that whenever anything in unsupported-versions.txt is selected, we not only show the please update message, but we also hide the text-entry boxes and submit button? --R ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Florian Reisinger hat Sie zu QA Call 4/11/13 eingeladen
Hi Florian I know that LO is Germany based but many of us do not understand German ;) Your post is obviously related to a QA call on Nov 4th... Cheers, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-Florian-Reisinger-hat-Sie-zu-QA-Call-4-11-13-eingeladen-tp4080945p4080961.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Florian Reisinger hat Sie zu QA Call 4/11/13 eingeladen
Hi Pedro, You are so right - I gambled I tried to send via Google+ an invite to the QA call on Monday Now I know, that it is in German... (Next time I am going to clarify better, that this is the QA call... (Like If you want to join click Something Am 02.11.2013 13:02, schrieb Pedro: Hi Florian I know that LO is Germany based but many of us do not understand German ;) Your post is obviously related to a QA call on Nov 4th... Cheers, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-Florian-Reisinger-hat-Sie-zu-QA-Call-4-11-13-eingeladen-tp4080945p4080961.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Liebe Grüße, / Yours, Florian Reisinger ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] PENDING ITEM: Updates to the BSA
On Sat, Nov 2, 2013 at 3:28 AM, libreoffice-ertai.nl libreoff...@ertai.nl wrote: Hi All, I think we should just collapse to a 3.x series and have that tell you that it is too old. That sounds fine for 3.x builds. Per the ReleasePlan page, 4.0 will reach EOL before the end of this month, so we should have a solution that can include those builds as well. But what I also noticed was that we are asing for: - Version the bug appeared - Latest known-working version It seems to me that the 1st one is always the 2nd version + 1. If somebody looks at it. Sure, that's the ideal state it should be in after triage and bibisecting*, but I think that most users won't fill in the Latest-known-working-version field, and for those who do, there may be a gap of 2 or more versions, depending upon when they upgraded LibreOffice. Shouldn't one of those be the version people are working in, as that needs to be checked by BSA to see if it needs to give this warning. Personally, I'd be fine if someone said I see this bug in 4.x but I remember that it worked in 3.3. Are we going to have to test to confirm that? Sure. Do we have to do a bit of sleuthing to track down when the bug was introduced? Sure. But this additional information gives us at least a hint that this is a regression, which is useful. So Version-bug-appeared should be pre-EOL, but Latest-known-working-version can be EOL. --R * technically speaking, bibisecting will let us drill-down more precisely than just our released builds, but we all get the general point ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] White bar at the bottom of Tools - Options - LibreOffice - Appearance
Hi Thomas Thomas Hackert wrote In LO Version: 4.1.2.3 Build ID: 40b2d7fde7e8d2d7bc5a449dc65df4d08a7dd38 with installed Germanophone lang- as well as helppack, it does not evident, as the background of this dialog is white as well. It only seems to be a little more space than needed there ... ;) But if you have a look at LO Version: 4.2.0.0.alpha0+ Build ID: aeb29afa11b7be87153f048044a2d4af9a87b50c TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2013-10-29_20:58:33 with installed en-US lang- as well as helppack, the background of this dialog is grey, so the space below is visible ... :( Is this a bug or a feature? Is it only on my system, or can someone with another OS/architecture/graphics chip or card/something else can confirm it? Confirmed that there is extra white space under the last item and also confirmed that it looks worse under 4.2 Alpha. I'm using Windows XP Pro x86 SP3 and tested both on ATI Radeon and Nvidia ION (same as Geforce 9400M) so this is not related to graphics chip or card. In both systems resolution is at 1280x1024. I wouldn't call this a bug (definitely not a feature :) )... maybe a small quirk? Hope this helps... Cheers, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-White-bar-at-the-bottom-of-Tools-Options-LibreOffice-Appearance-tp4080642p4081012.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] OpenCL?
Hi all Can anyone tell me if GPU calculation through OpenCL is already working in the Master releases? Is it enabled by default? If not, how is it enabled? In the Advanced Enable Experimental Features? What kind of operations is this expected to enhance? File loading? Thanks, Pedro -- View this message in context: http://nabble.documentfoundation.org/OpenCL-tp4081026.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] OpenCL?
El 02/11/13 20:14, Pedro [via Document Foundation Mail Archive] escribió: Hi all Can anyone tell me if GPU calculation through OpenCL is already working in the Master releases? Is it enabled by default? If not, how is it enabled? In the Advanced Enable Experimental Features? What kind of operations is this expected to enhance? File loading? Thanks, Pedro Hi Pedro, take a look in: Menu/Tools/Options/LibreOffice calc/Formula - Detailed calculation settings - Custom. Miguel ángel. -- View this message in context: http://nabble.documentfoundation.org/OpenCL-tp4081026p4081038.html Sent from the QA mailing list archive at Nabble.com.___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] OpenCL?
Hola Miguel Ángel mariosv wrote take a look in: Menu/Tools/Options/LibreOffice calc/Formula - Detailed calculation settings - Custom. Thank you for the directions ;) Can you (or anyone else) tell me which sorts of simple formula expressions are affected by this setting? -- View this message in context: http://nabble.documentfoundation.org/OpenCL-tp4081026p4081064.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] OpenCL?
El 03/11/13 1:11, Pedro [via Document Foundation Mail Archive] escribió: Hola Miguel Ángel mariosv wrote take a look in: Menu/Tools/Options/LibreOffice calc/Formula - Detailed calculation settings - Custom. Thank you for the directions ;) Can you (or anyone else) tell me which sorts of simple formula expressions are affected by this setting? I have read about it in the Kohei Yoshida's Webspace: http://kohei.us/2013/09/27/slides-for-my-talk-at-libreoffice-conference/#comments where to enjoy about calc. Miguel Ángel. -- View this message in context: http://nabble.documentfoundation.org/OpenCL-tp4081026p4081069.html Sent from the QA mailing list archive at Nabble.com.___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 71158] Writer Search+Replace cannot find and replace strings spanning multiple paragraphs
https://bugs.freedesktop.org/show_bug.cgi?id=71158 Leo H leo.h.hildebra...@gmail.com changed: What|Removed |Added Priority|high|medium Summary|Writer Search and |Writer Search+Replace |Search+Replace cannot |cannot find and replace |handle the pilcrow sign |strings spanning multiple |(Unicode 00B6) |paragraphs --- Comment #1 from Leo H leo.h.hildebra...@gmail.com --- I have been very sloppy indeed, apologies for that. LibreOffice Search and Search+Replace can, of course, find the pilcrow sign within paragraphs, but – and that is the usability issue here – not where used as an end-of-paragraph marker. Thus, in effect only issue 2/ remains. Once more apologies for my mistake. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70775] VIEWING: Arabic font rendering has problems from as little as subtle artifacts all the way to unusability, depending on the font
https://bugs.freedesktop.org/show_bug.cgi?id=70775 Mohammed Arabiat tanjo...@gmail.com changed: What|Removed |Added Version|4.1.1.2 release |4.1.2.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70775] VIEWING: Arabic font rendering has problems from as little as subtle artifacts all the way to unusability, depending on the font
https://bugs.freedesktop.org/show_bug.cgi?id=70775 --- Comment #2 from Mohammed Arabiat tanjo...@gmail.com --- Updated version to 4.1.2.3 release, as it still exists there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41776] Change StartCenter to feature Recent Documents and make new documents a secondary option
https://bugs.freedesktop.org/show_bug.cgi?id=41776 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||jbf.fa...@sud-ouest.org --- Comment #6 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- It is the behavior of the StartCenter in the future LibreOffice 4.2. So closing as Fixed. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41776] Change StartCenter to feature Recent Documents and make new documents a secondary option
https://bugs.freedesktop.org/show_bug.cgi?id=41776 --- Comment #7 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- *** Bug 41774 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41776] Change StartCenter to feature Recent Documents and make new documents a secondary option
https://bugs.freedesktop.org/show_bug.cgi?id=41776 Bug 41776 depends on bug 41774, which changed state. Bug 41774 Summary: Option to not open anything when LibreOffice is launched - neither StartCenter nor any document https://bugs.freedesktop.org/show_bug.cgi?id=41774 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41774] Option to not open anything when LibreOffice is launched - neither StartCenter nor any document
https://bugs.freedesktop.org/show_bug.cgi?id=41774 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||jbf.fa...@sud-ouest.org --- Comment #5 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Please, make your choice in command line options for libreoffice. In a terminal type libreoffice4.1 --help Closing as duplicate of bug 41776. Best regards. JBF *** This bug has been marked as a duplicate of bug 41776 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67401] Help - About LibreOffice Logo not smooth
https://bugs.freedesktop.org/show_bug.cgi?id=67401 --- Comment #15 from tommy27 ba...@quipo.it --- Created attachment 88527 -- https://bugs.freedesktop.org/attachment.cgi?id=88527action=edit LibO 4.2 alpha 2013-11-01 logo logo still abnormal under Win7 64bit using yesterday night daily build. see my screenshot. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53268] VIEWING: Filenames are not displayed in dropdown list in StartCenter when long UNC paths are used
https://bugs.freedesktop.org/show_bug.cgi?id=53268 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||jbf.fa...@sud-ouest.org --- Comment #7 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Seems to be fixed in LibreOffice 4.1. Please feel free to reopen if it not the case for you. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55753] CRASH - new template manager dialog from StartCenter
https://bugs.freedesktop.org/show_bug.cgi?id=55753 --- Comment #12 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Hi Alex, Do you still reproduce this crash with current 4.1 version on MacOS? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71158] Writer Search+Replace cannot find and replace strings spanning multiple paragraphs
https://bugs.freedesktop.org/show_bug.cgi?id=71158 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG CC||jbf.fa...@sud-ouest.org --- Comment #2 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- There is no end-of-paragraph character in OpenDocument files in which paragraphs are defined by xml tags. To find/remplace end-of-paragraph marks you need to use regular expressions in the search/replace dialog. Please read the help and, if needed, ask for help on users mailing-list or on http://ask.libreoffice.org Closing as NotABug. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60268] FORMATTING: Square root and cdot are not correct displayed under Windows 8
https://bugs.freedesktop.org/show_bug.cgi?id=60268 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #9 from tommy27 ba...@quipo.it --- hi, have u tried installing brand new 4.1.3 release? is the bug still there in Win8? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71135] Crash at formula 'KGRÖSSTE'
https://bugs.freedesktop.org/show_bug.cgi?id=71135 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||l.lu...@suse.cz, ||michael.me...@collabora.com Ever confirmed|0 |1 --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- Thank you Daniel for your feedback. I put it at NEW since there's a bt attached. By looking at the bt, it seems the pb is there: http://opengrok.libreoffice.org/xref/core/vcl/unx/kde4/KDE4FilePicker.cxx#197 Lubos/Michael: one for you? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71112] EDITING: Writer crashes every time i press tab
https://bugs.freedesktop.org/show_bug.cgi?id=71112 --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- You may also try to retrieve more information by following this link: https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70210] FILEOPEN, REGRESSION: draw and impress do not load connector skew properly and consequently break documents on saving again
https://bugs.freedesktop.org/show_bug.cgi?id=70210 --- Comment #17 from Tim t...@timveldhuizen.nl --- I can confirm, this does not seem to be an issue on 4.0.6. However, on that version there seems to be a bug where a connector with 2 skew lines initially doesn't show all handles after loading (and the one handle it does show is moving in the wrong direction). When I try to make a change to such a connector, the routing is reset and then works as expected after that. I also noticed that the connector dialog for such a connector has the line skew settings disabled. A connector with 1 skew line seems to have no problems at all on 4.0.6. I have not tested connectors with 3 skew lines. So it's not perfect on 4.0.6, but I would call it an annoyance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71155] Document Compare in Writer mishandles paragraphs split in two by hitting the Enter key
https://bugs.freedesktop.org/show_bug.cgi?id=71155 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added CC||jbf.fa...@sud-ouest.org --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- If I compare both documents with By word option, it works as expected: - the first paragraph in the new doc (the one with two paragraphs) is not marked modified - the second paragraph is marked modified. Note: as specified in the help, you must open the modified file et compare it to the old. Tested on LibreOffice 4.1.4.0.0+ under Ubuntu 13.10 x86-64. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71154] In Tools Options Witer Comparison, the option Use RSID is undefined and unclear
https://bugs.freedesktop.org/show_bug.cgi?id=71154 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Indeed, related help is missing. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71153] In Tools Options Writer, the user selection for Compare documents does not stick
https://bugs.freedesktop.org/show_bug.cgi?id=71153 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Indeed, confirmed with LibreOffice 4.1.4.0.0+ under Ubuntu 13.10 x86-64 Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71112] EDITING: Writer crashes every time i press tab
https://bugs.freedesktop.org/show_bug.cgi?id=71112 --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- Sorry, I forgot to ask these: - did you install any LO extensions (eg: dictionaries)? - could you rename your LO directory profile (see https://wiki.documentfoundation.org/Documentation/UserProfile) and give it a new try? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71152] Document Compare in Writer should not ignore footnotes, endnotes, fields etc
https://bugs.freedesktop.org/show_bug.cgi?id=71152 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Hardware|x86 (IA32) |All OS|Linux (All) |All Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- This is not a bug as this behavior is specified in the help of the compare function. Set as enhancement. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70805] chart mangling
https://bugs.freedesktop.org/show_bug.cgi?id=70805 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=71075 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71075] chart mangling on paste
https://bugs.freedesktop.org/show_bug.cgi?id=71075 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=70805 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71149] SPELL: Objects inline with text ignored by spellchecks, leading to double space warnings
https://bugs.freedesktop.org/show_bug.cgi?id=71149 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added CC||dicolle...@free.fr, ||jbf.fa...@sud-ouest.org --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- I have the same problem with the grammar checker for French Grammalecte. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54871] Unnecessary flicker in the text cursor
https://bugs.freedesktop.org/show_bug.cgi?id=54871 ign_christian ign_christ...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from ign_christian ign_christ...@yahoo.com --- Worksforme per comment 3. Also confirm not reproducible with LO 4.0.6.2 (Win7 32bit) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70995] Update Code to Latest ICU 52.1
https://bugs.freedesktop.org/show_bug.cgi?id=70995 --- Comment #15 from Eike Rathke er...@redhat.com --- The file locations in the diff header may be different, as long as the number of subdirectories (should be one) before icu/... in the paths match, you can edit them to suit the needs. Something like misc/icu/... should do. The patches applied during build are not generated using git, just plain diff of original and modified source. As for the diff format we use unified diffs, diff -u -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71129] Unable to find working email
https://bugs.freedesktop.org/show_bug.cgi?id=71129 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jbf.fa...@sud-ouest.org Ever confirmed|0 |1 --- Comment #1 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Please could you describe step by step what you do to reproduce the problem? Did you set the email client in menu Tools Options Internet E-mail ? Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71123] Other: inline arrays computing error
https://bugs.freedesktop.org/show_bug.cgi?id=71123 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Attachment #88520|application/xml |application/vnd.oasis.opend mime type||ocument.speadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71149] SPELL: Objects inline with text ignored by spellchecks, leading to double space warnings
https://bugs.freedesktop.org/show_bug.cgi?id=71149 Olivier R. dicolle...@free.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from Olivier R. dicolle...@free.fr --- The grammar checker says: “The is cool. has two spaces” because the grammar checker receives only the sentence “The is cool.” Objects are not sent to grammar checkers. They receive only the text. IMHO, the GC iterator should send to grammar checkers a specific word to replace such objects instead of nothing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67407] Impress Export to .gif doesn't work on Ubuntu
https://bugs.freedesktop.org/show_bug.cgi?id=67407 --- Comment #13 from d...@uwewiest.de d...@uwewiest.de --- Hallo IBF, I got the Libreoffice version 4.1.3.2 ppa for ubuntu 12.04. Now the gif-filter ist o.k. Best regards, Uwe Wiest Hallo JBF, I think you are right. ubuntu 12.04 has not yet a gif-filter. Some Grafik-Programs have an implemented gif-filter: gimp, xnview MP. Thank you. Best regards, Uwe Wiest Am 07.09.2013 22:25, schrieb bugzilla-dae...@freedesktop.org: Jean-Baptiste Faure mailto:jbf.fa...@sud-ouest.org changed bug 67407 https://bugs.freedesktop.org/show_bug.cgi?id=67407 What Removed Added StatusUNCONFIRMED NEEDINFO CCjbf.fa...@sud-ouest.org Ever confirmed1 *Comment # 10 https://bugs.freedesktop.org/show_bug.cgi?id=67407#c10 on bug 67407 https://bugs.freedesktop.org/show_bug.cgi?id=67407 from Jean-Baptiste Faure mailto:jbf.fa...@sud-ouest.org * No answer to several questions that are needed to try to reproduce the problem. - Which Linux distribution ? - sample file ? If LibreOffice says No gif-Filter, this means perhaps that you do not have a gif filter on your distribution. Please check this point. Best regards. JBF You are receiving this mail because: * You reported the bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71027] form wizard: timestamp field does not get style applied
https://bugs.freedesktop.org/show_bug.cgi?id=71027 rob...@familiegrosskopf.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||rob...@familiegrosskopf.de Ever confirmed|0 |1 --- Comment #4 from rob...@familiegrosskopf.de --- Can confirm this bug. But much better this cosmetical bug than a not-working form-wizard with timestamp-fields. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71101] LibreOffice Base closes if you try to open a registered database that does not exist
https://bugs.freedesktop.org/show_bug.cgi?id=71101 rob...@familiegrosskopf.de changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #3 from rob...@familiegrosskopf.de --- (In reply to comment #0) When you try to open a database file that no longer exists, LibreOffice Base closes. LibreOffice Base doesn't open the file, because it doesn't find it. You could connect to any other database, that is correctly registered. Annoyance that I must re-open LibreOffice Why do you have to reopen LibreOffice? I close the database-browser, go to Tools → Options → LibreOffice Base → Databases, mark the registered name and click Edit. I search for the database, then I click OK, open the database-browser and could get contact to the database. I haven't to close LibreOffice at all. My system is OpenSUSE 64bit rpm. Tested with LO 4.1.3.2. Do you wish an enhancement, that the dialog for changing the database-connection should appear - not the warning The file ... does not exist.? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53268] VIEWING: Filenames are not displayed in dropdown list in StartCenter when long UNC paths are used
https://bugs.freedesktop.org/show_bug.cgi?id=53268 Urmas davian...@gmail.com changed: What|Removed |Added Resolution|FIXED |WONTFIX --- Comment #8 from Urmas davian...@gmail.com --- It is not fixed in 4.1, and Starting center will be removed in 4.2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50091] EDITING: Drag and drop images into Impress opens Draw
https://bugs.freedesktop.org/show_bug.cgi?id=50091 --- Comment #14 from cytan...@yahoo.com --- This is still a bug in Mac OSX 10.8.5 (Mountain Lion) running LibreOffice 4.1.3.2. This bug is really annoying. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70998] Termchange: Graphic/Picture - Image
https://bugs.freedesktop.org/show_bug.cgi?id=70998 --- Comment #9 from Samuel M. s.mehrbr...@gmail.com --- You are right, I meant Header Case. Thanks for the Link btw, I'll give more attention to that with the coming patches. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70554] FORMATTING Font not resizing after adding suffix at the end of a line
https://bugs.freedesktop.org/show_bug.cgi?id=70554 Dominique Boutry dominique.bout...@laposte.net changed: What|Removed |Added Summary|FORMATTING Font not |FORMATTING Font not |resizing after adding |resizing after adding |suffix at the end of a |suffix at the end of a line |line, in while using| |bullets/numbering | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71162] New: Cant add Eilidh as a reviewer
https://bugs.freedesktop.org/show_bug.cgi?id=71162 Priority: medium Bug ID: 71162 CC: webs...@global.libreoffice.org Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Cant add Eilidh as a reviewer Severity: normal Classification: Unclassified OS: All Reporter: bjoern.michael...@canonical.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: WWW Product: LibreOffice I would love to add Eilidh McAdam eilidh.mca...@gmail.com as a reviewer, but am cruelly denied with an application error. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71162] Cant add Eilidh as a reviewer
https://bugs.freedesktop.org/show_bug.cgi?id=71162 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||d.ostrov...@gmx.de, ||nthieb...@gmail.com, ||tibbylickle+...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Björn Michaelsen bjoern.michael...@canonical.com --- (also the account shows up twice in the autocomplete popup.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71135] Crash at formula 'KGRÖSSTE'
https://bugs.freedesktop.org/show_bug.cgi?id=71135 --- Comment #5 from Urmas davian...@gmail.com --- Actually crash seems to initiate from here: http://opengrok.libreoffice.org/xref/core/sc/source/core/data/formulacell.cxx#1220 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65606] Paste special not available
https://bugs.freedesktop.org/show_bug.cgi?id=65606 --- Comment #4 from Dominique Boutry dominique.bout...@laposte.net --- I never manage to reproduce it. Lib0 4.1.2.3 on Win7 : difficult to reproduce without a reproducible path. Possible causes : - the pasted text is wrong in some way, - the place (or the document) it is supposed to be pasted in is wrong in some way -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71163] New: Installation Forces Explorer.exe to close before install finishes
https://bugs.freedesktop.org/show_bug.cgi?id=71163 Priority: medium Bug ID: 71163 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Installation Forces Explorer.exe to close before install finishes Severity: major Classification: Unclassified OS: Windows (All) Reporter: chrisgriffini...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.1.2.3 release Component: Installation Product: LibreOffice When I installed the new version of LibreOffice on my Windows 8.1 desktop, it will pop up during the validating install process stating that you have to close explorer.exe to continue. If you tell it to ignore it, it will not proceed until you close it. I had to go to task manager and kill explorer.exe to finish installing. Then, you have to re-launch explorer.exe to be able to use anything in windows 8.1 . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71164] New: ODT file with embedded font has too big size. Font subset needed.
https://bugs.freedesktop.org/show_bug.cgi?id=71164 Priority: medium Bug ID: 71164 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: ODT file with embedded font has too big size. Font subset needed. Severity: normal Classification: Unclassified OS: All Reporter: rpn...@free.fr Hardware: All Status: UNCONFIRMED Version: 4.1.2.3 release Component: Writer Product: LibreOffice To reproduce : 1. Type some words in Writer with one font. 2. Save without embedded font. Here : 7.9 kB. 3. Save with embedded font. Here : 4.6 MB. In the file, eleven (11) ttf fonts file are embedded in instead of one used ! So, it is needed to embedded only a subset of each fonts. Better, the user should have the choice if he wants all fonts embedded (to shared works with other in this file) or only a subset (by default). Exporting to PDF files get subset of fonts, I think that the work perhaps is yet started. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71162] Cant add Eilidh as a reviewer
https://bugs.freedesktop.org/show_bug.cgi?id=71162 --- Comment #2 from Björn Michaelsen bjoern.michael...@canonical.com --- Looks like its solved now. Would be great to have this linking accounts stuff documented somewhere easy to find though (Yes, I _should_ know how this works, but I fail hard on the 'easy to find' part.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71163] Installation Forces Explorer.exe to close before install finishes
https://bugs.freedesktop.org/show_bug.cgi?id=71163 --- Comment #1 from Urmas davian...@gmail.com --- What was your previous version? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71164] ODT file with embedded font has too big size. Font subset needed.
https://bugs.freedesktop.org/show_bug.cgi?id=71164 Rpnpif rpn...@free.fr changed: What|Removed |Added CC||rpn...@free.fr --- Comment #1 from Rpnpif rpn...@free.fr --- Test file are here : File with embedded font : http://rpnpif.free.fr/fichiersDivers/essai-with-font.odt File without embedded font : http://rpnpif.free.fr/fichiersDivers/essai-without-font.odt -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71165] New: VIEWING: Aliased Type
https://bugs.freedesktop.org/show_bug.cgi?id=71165 Priority: medium Bug ID: 71165 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: VIEWING: Aliased Type Severity: normal Classification: Unclassified OS: Windows (All) Reporter: charles.cramm...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.2.3 release Component: Writer Product: LibreOffice Checking the Anti-alias option in Tools Options View has no effect. All page text is aliased. GUI text looks fine, but then again I'm looking at 1920x1080 on a 13.3 screen. Operating System: Windows 8 Version: 4.1.2.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70315] Protected Sheet Problem
https://bugs.freedesktop.org/show_bug.cgi?id=70315 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA bibisected |BSA bibisected target:4.2.0 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Markus Mohrhard committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=512a14438c4098ca2e30d0b10b6e18506c8475f1 remember column style during XLSX import, fdo#70315 The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71128] EDITING: MMULT function arguments have the same name.
https://bugs.freedesktop.org/show_bug.cgi?id=71128 Winfried Donkers winfrieddonk...@libreoffice.org changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice |desktop.org |.org --- Comment #2 from Winfried Donkers winfrieddonk...@libreoffice.org --- (In reply to comment #1) Still the case with master sources updated yesterday. Here's the file (+ line start) which contain the declaration of the parameters: http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/scfuncs.src#4471 Array 1 and Array 2 could be ok or should be considered by UI team? Winfried: any idea? I have changed the names to array_1 and array_2 (similar to array_x and array_y in other array functions) and will submit patch after testing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
