[Libreoffice-commits] core.git: xmloff/source
xmloff/source/draw/shapeimport.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 742d3987319944308a42fcdc19592bc441b761c2 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 9 10:01:00 2014 +0100 cppcheck: Prefer prefix ++/-- operators for non-primitive types Change-Id: I34446102091ef8be72d5aec603740db531fdd14b diff --git a/xmloff/source/draw/shapeimport.cxx b/xmloff/source/draw/shapeimport.cxx index 4dbb85f..acca562 100644 --- a/xmloff/source/draw/shapeimport.cxx +++ b/xmloff/source/draw/shapeimport.cxx @@ -1052,7 +1052,7 @@ sal_Int32 XMLShapeImportHelper::findGluePointMapping( return (*aShapeIdIter).first; } -aShapeIdIter++; +++aShapeIdIter; } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - chart2/source sw/source
chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx |4 ++-- chart2/source/view/axes/VCartesianAxis.cxx |2 +- sw/source/filter/xml/xmltbli.cxx|2 +- 3 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 332fffe3b8cd51576c42762e5e9751464777f2ca Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 9 10:05:33 2014 +0100 Typo: prefere - prefer Change-Id: Ifad9097f933b2821c1168fc317889e66d6419545 diff --git a/chart2/source/view/axes/VCartesianAxis.cxx b/chart2/source/view/axes/VCartesianAxis.cxx index 70269b4..5e8c829 100644 --- a/chart2/source/view/axes/VCartesianAxis.cxx +++ b/chart2/source/view/axes/VCartesianAxis.cxx @@ -1173,7 +1173,7 @@ void VCartesianAxis::get2DAxisMainLine( B2DVector rStart, B2DVector rEnd, doub ScreenPosAndLogicPos aNotSoGoodPos( aPosList[1] ); //choose most bottom positions -if( !::rtl::math::approxEqual( fDeltaX, 0.0 ) ) // prefere left-right alignments +if( !::rtl::math::approxEqual( fDeltaX, 0.0 ) ) // prefer left-right alignments { if( aBestPos.aScreenPos.getX() aNotSoGoodPos.aScreenPos.getX() ) m_aAxisProperties.m_aLabelAlignment = LABEL_ALIGN_RIGHT; diff --git a/sw/source/filter/xml/xmltbli.cxx b/sw/source/filter/xml/xmltbli.cxx index 6ebfa5c..4d06449 100644 --- a/sw/source/filter/xml/xmltbli.cxx +++ b/sw/source/filter/xml/xmltbli.cxx @@ -2757,7 +2757,7 @@ void SwXMLTableContext::MakeTable() { case text::HoriOrientation::FULL: case text::HoriOrientation::NONE: -// For text::HoriOrientation::NONE we would prefere to use the sum +// For text::HoriOrientation::NONE we would prefer to use the sum // of the relative column widths as reference width. // Unfortunately this works only if this sum interpreted as // twip value is larger than the space that is available. commit 95141bfd304ca1c33145c85b383ccb5ddbb98938 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 9 10:02:51 2014 +0100 Typos Change-Id: I8316213889280b8f8622fb5196b6a36e81d8e6f1 diff --git a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx index 0559a18..1c8acea 100644 --- a/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx +++ b/chart2/source/controller/chartapiwrapper/DataSeriesPointWrapper.hxx @@ -137,8 +137,8 @@ private: sal_Boolm_bLinesAllowed; //this should only be used, if the DataSeriesPointWrapper is initialized via the XInitialize interface -//because a big change in the chartmodel may leed to an dataseriespointer thats not connected to the model anymore -//with the indices instead we are can always get the new dataseries +//because a big change in the chartmodel may lead to an dataseriespointer that is not connected to the model anymore +//with the indices instead we can always get the new dataseries ::com::sun::star::uno::Reference ::com::sun::star::chart2::XDataSeries m_xDataSeries; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source fpicker/source framework/inc framework/qa framework/source include/comphelper include/framework odk/examples sd/inc sfx2/source svx/source vcl/source
filter/source/config/cache/contenthandlerfactory.hxx |2 +- filter/source/config/cache/filtercache.hxx |2 +- filter/source/config/cache/filterfactory.hxx |2 +- filter/source/config/cache/frameloaderfactory.hxx |2 +- filter/source/config/cache/typedetection.hxx |2 +- fpicker/source/win32/filepicker/VistaFilePickerEventHandler.hxx |8 fpicker/source/win32/filepicker/VistaFilePickerImpl.hxx |8 fpicker/source/win32/filepicker/asyncrequests.hxx |2 +- framework/inc/dispatch/closedispatcher.hxx |8 framework/inc/dispatch/dispatchprovider.hxx |2 +- framework/inc/dispatch/startmoduledispatcher.hxx |2 +- framework/inc/helper/statusindicatorfactory.hxx |2 +- framework/inc/interaction/quietinteraction.hxx |2 +- framework/inc/recording/dispatchrecordersupplier.hxx |2 +- framework/inc/services/desktop.hxx |2 +- framework/qa/complex/loadAllDocuments/CheckXComponentLoader.java |2 +- framework/source/accelerators/documentacceleratorconfiguration.cxx |2 +- framework/source/accelerators/globalacceleratorconfiguration.cxx |2 +- framework/source/accelerators/moduleacceleratorconfiguration.cxx |2 +- framework/source/dispatch/mailtodispatcher.cxx |2 +- framework/source/fwe/helper/titlehelper.cxx |6 +++--- framework/source/inc/accelerators/acceleratorconfiguration.hxx |2 +- framework/source/inc/accelerators/presethandler.hxx |8 framework/source/inc/loadenv/loadenv.hxx |4 ++-- framework/source/jobs/jobresult.cxx |4 ++-- framework/source/recording/dispatchrecordersupplier.cxx |2 +- framework/source/services/autorecovery.cxx |8 framework/source/services/frame.cxx |2 +- framework/source/services/modulemanager.cxx |2 +- framework/source/services/pathsettings.cxx |2 +- include/comphelper/numberedcollection.hxx |2 +- include/comphelper/sequenceashashmap.hxx |2 +- include/framework/preventduplicateinteraction.hxx |4 ++-- include/framework/titlehelper.hxx |4 ++-- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java |2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusView.java |2 +- sd/inc/Outliner.hxx |2 +- sfx2/source/appl/sfxhelp.cxx |2 +- sfx2/source/dialog/backingcomp.cxx |2 +- svx/source/inc/svxrectctaccessiblecontext.hxx |4 ++-- svx/source/unodraw/recoveryui.cxx |2 +- vcl/source/window/window.cxx |2 +- 42 files changed, 64 insertions(+), 64 deletions(-) New commits: commit 94bc29cb71d08ebe039d5ce5b6b2762ac24cbb8f Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 9 10:12:07 2014 +0100 Typo: I/internaly - I/internally Change-Id: Ic9056baf58698743492ab57a882341c730ef2f7a diff --git a/filter/source/config/cache/contenthandlerfactory.hxx b/filter/source/config/cache/contenthandlerfactory.hxx index aaf300c..9cb44e4 100644 --- a/filter/source/config/cache/contenthandlerfactory.hxx +++ b/filter/source/config/cache/contenthandlerfactory.hxx @@ -120,7 +120,7 @@ class ContentHandlerFactory : public ::cppu::ImplInheritanceHelper1 BaseContain @param xSMGR reference to the uno service manager, which require this new instance. It should be passed to the new object -so it can be used internaly to create own needed uno resources. +so it can be used internally to create own needed uno resources. @return The new instance of this service as an uno reference. */ diff --git a/filter/source/config/cache/filtercache.hxx
[Libreoffice-commits] core.git: framework/source odk/examples
framework/source/services/frame.cxx |2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java |4 ++-- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java |2 +- odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 5b066bc3efed187dd7e63973d2b9731a9eea31e8 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Feb 9 10:14:25 2014 +0100 Typo: (a)synchronoues - a(synchronous) Change-Id: Ia3871d711308eb38ed6e0df81615966cc142030d diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx index 217a096..553979d 100644 --- a/framework/source/services/frame.cxx +++ b/framework/source/services/frame.cxx @@ -2667,7 +2667,7 @@ void SAL_CALL Frame::windowDeactivated( const css::lang::EventObject aEvent ) t void SAL_CALL Frame::windowClosing( const css::lang::EventObject ) throw( css::uno::RuntimeException ) { /* #i62088# -Some interceptor objects intercept our internally asynchronoues implemented dispatch call. +Some interceptor objects intercept our internally asynchronous implemented dispatch call. And they close this frame directly (means synchronous then). Means: Frame::windowClosing()-Frame::close() In such situation its not a good idea to hold this transaction count alive .-) diff --git a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java index 22ce638..33a6b3c 100644 --- a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java +++ b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/IOnewayLink.java @@ -39,9 +39,9 @@ import java.util.ArrayList; /** * We need a generic interface to forward any oneway uno interface method * by using threads to the original object. Reason: - * It's not allowed to call synchronoues back to the office if a java object + * It's not allowed to call synchronous back to the office if a java object * was called in a oneway declared interface method. Then it must be - * executed asynchronoues. To do so - a thread can be created which use this + * executed asynchronous. To do so - a thread can be created which use this * interface. It get the object, which whis to be called back and the type and * parameter of the original request. * diff --git a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java index 355be64..51435cb 100644 --- a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java +++ b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/OnewayExecutor.java @@ -37,7 +37,7 @@ import java.util.ArrayList; // __ Implementation __ /** - * It's not allowed to call synchronoues back inside an oneway interface call. + * It's not allowed to call synchronous back inside an oneway interface call. * (see IOnewayLink too). So we start a thread (implemented by this class), which * gets all necessary parameters from the original called object and * call it back later inside his run() method. So the execution of such oneway call diff --git a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java index 89980b7..29c4fff 100644 --- a/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java +++ b/odk/examples/DevelopersGuide/OfficeDev/DesktopEnvironment/StatusListener.java @@ -57,7 +57,7 @@ import com.sun.star.uno.UnoRuntime; * internal holded dispatch object automaticly. * * Another reason for such extra class for listening: - * Most listener callbacks are asynchronoues [oneay] requests. + * Most listener callbacks are asynchronous [oneay] requests. * And it's not allowed to call back synchronously there. * So we must start threads for updating something internally. * ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - xmloff/source
xmloff/source/draw/sdpropls.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 63756b6bd3bc1c755b7a703fdbcc164fbff6acc2 Author: Michael Stahl mst...@redhat.com Date: Fri Feb 7 16:25:06 2014 +0100 fdo#74230: ODF export: write stroke and fill color in graphic defaults The pool defaults for svg:stroke-color and draw:fill-color were changed and while previously (effective, manually overridden) defaults were written into ODF files, this was lost with the change; restore that. (regression from c0eb5e7772c848806db8ab461f77f9549c1d8b2b) Change-Id: Ibcd863260976aa42116175c7f19cb33760af986f (cherry picked from commit 45d3577bc5726eee44f491fd30a7f11dc428431a) Reviewed-on: https://gerrit.libreoffice.org/7929 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/xmloff/source/draw/sdpropls.cxx b/xmloff/source/draw/sdpropls.cxx index 7ee4ecc..f76c661 100644 --- a/xmloff/source/draw/sdpropls.cxx +++ b/xmloff/source/draw/sdpropls.cxx @@ -74,6 +74,7 @@ using namespace ::xmloff::token; #define _MAP(name,prefix,token,type,context) { name, sizeof(name)-1, prefix, token, type, context, SvtSaveOptions::ODFVER_010, false } #define _MAPV(name,prefix,token,type,context,version) { name, sizeof(name)-1, prefix, token, type, context, version, false } #define GMAP(name,prefix,token,type,context) _MAP(name,prefix,token,type|XML_TYPE_PROP_GRAPHIC,context) +#define GMAP_D(name,prefix,token,type,context) _MAP(name,prefix,token,type|XML_TYPE_PROP_GRAPHIC|MID_FLAG_DEFAULT_ITEM_EXPORT,context) #define GMAPV(name,prefix,token,type,context,version) _MAPV(name,prefix,token,type|XML_TYPE_PROP_GRAPHIC,context,version) #define DPMAP(name,prefix,token,type,context) _MAP(name,prefix,token,type|XML_TYPE_PROP_DRAWING_PAGE,context) #define TMAP(name,prefix,token,type,context) _MAP(name,prefix,token,type|XML_TYPE_PROP_TEXT,context) @@ -93,7 +94,7 @@ const XMLPropertyMapEntry aXMLSDProperties[] = GMAP( LineStyle, XML_NAMESPACE_DRAW, XML_STROKE, XML_SD_TYPE_STROKE, 0 ), GMAP( LineDashName, XML_NAMESPACE_DRAW, XML_STROKE_DASH,XML_TYPE_STYLENAME|MID_FLAG_NO_PROPERTY_IMPORT , CTF_DASHNAME ), GMAP( LineWidth, XML_NAMESPACE_SVG, XML_STROKE_WIDTH, XML_TYPE_MEASURE, 0 ), -GMAP( LineColor, XML_NAMESPACE_SVG, XML_STROKE_COLOR, XML_TYPE_COLOR, 0 ), +GMAP_D(LineColor, XML_NAMESPACE_SVG, XML_STROKE_COLOR, XML_TYPE_COLOR, 0), GMAP( LineStartName, XML_NAMESPACE_DRAW, XML_MARKER_START, XML_TYPE_STYLENAME|MID_FLAG_NO_PROPERTY_IMPORT, CTF_LINESTARTNAME ), GMAP( LineStartWidth, XML_NAMESPACE_DRAW, XML_MARKER_START_WIDTH, XML_TYPE_MEASURE, 0 ), GMAP( LineStartCenter,XML_NAMESPACE_DRAW, XML_MARKER_START_CENTER,XML_TYPE_BOOL, 0 ), @@ -106,8 +107,8 @@ const XMLPropertyMapEntry aXMLSDProperties[] = // fill attributes GMAP( FillStyle, XML_NAMESPACE_DRAW, XML_FILL, XML_SD_TYPE_FILLSTYLE, 0 ), -GMAP( FillColor, XML_NAMESPACE_DRAW, XML_FILL_COLOR, XML_TYPE_COLOR, 0 ), -GMAP( FillColor2, XML_NAMESPACE_DRAW, XML_SECONDARY_FILL_COLOR, XML_TYPE_COLOR, 0 ), +GMAP_D(FillColor, XML_NAMESPACE_DRAW, XML_FILL_COLOR, XML_TYPE_COLOR, 0), +GMAP_D(FillColor2,XML_NAMESPACE_DRAW, XML_SECONDARY_FILL_COLOR, XML_TYPE_COLOR, 0), GMAP( FillGradientName, XML_NAMESPACE_DRAW, XML_FILL_GRADIENT_NAME, XML_TYPE_STYLENAME|MID_FLAG_NO_PROPERTY_IMPORT, CTF_FILLGRADIENTNAME ), GMAP( FillGradientStepCount, XML_NAMESPACE_DRAW, XML_GRADIENT_STEP_COUNT,XML_TYPE_NUMBER16, 0 ), GMAP( FillHatchName, XML_NAMESPACE_DRAW, XML_FILL_HATCH_NAME,XML_TYPE_STYLENAME|MID_FLAG_NO_PROPERTY_IMPORT, CTF_FILLHATCHNAME ), ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - cui/source
cui/source/tabpages/tparea.cxx | 111 +++-- 1 file changed, 64 insertions(+), 47 deletions(-) New commits: commit 8ef53812f161758826f9a4396f7d6416b29c5f97 Author: Michael Stahl mst...@redhat.com Date: Fri Feb 7 18:25:39 2014 +0100 related: fdo#74230: Area tab page: prevent default gradient/hatch/bitmap The Area dialog for shapes unfortunately makes it possible to set gradients/hatching/bitmap that uses the default items in the SfxItemPool. These items however cannot be stored to ODF files, since these are represented as elements, not as attributes on a style:default-style; what we get for defaults is a somewhat silly draw:fill=hatch without an draw:fill-hatch-name. So prevent the dialog from creating them by forcing a selection of an entry in the list. Change-Id: I67cc6dbbf7b491f06d094d4de1e9c3ffe79b01f5 (cherry picked from commit 38d0047da7f964c862360b48d88cc869ad376b6b) Reviewed-on: https://gerrit.libreoffice.org/7930 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx index 462b410..773864a 100644 --- a/cui/source/tabpages/tparea.cxx +++ b/cui/source/tabpages/tparea.cxx @@ -1405,12 +1405,69 @@ sal_Bool SvxAreaTabPage::FillItemSet( SfxItemSet rAttrs ) void SvxAreaTabPage::Reset( const SfxItemSet rAttrs ) { +bool isMissingHatching(false); +bool isMissingGradient(false); +bool isMissingBitmap(false); XFillStyle eXFS; if( rAttrs.GetItemState( XATTR_FILLSTYLE ) != SFX_ITEM_DONTCARE ) { eXFS = (XFillStyle) ( ( ( const XFillStyleItem ) rAttrs. Get( GetWhich( XATTR_FILLSTYLE ) ) ).GetValue() ); m_pTypeLB-SelectEntryPos( sal::static_int_cast sal_uInt16 ( eXFS ) ); + +if (SFX_ITEM_DONTCARE != rAttrs.GetItemState(XATTR_FILLCOLOR)) +{ +XFillColorItem const rColorItem(static_castconst XFillColorItem( +rAttrs.Get(XATTR_FILLCOLOR)) ); +m_pLbColor-SelectEntry( rColorItem.GetColorValue() ); +m_pLbHatchBckgrdColor-SelectEntry( rColorItem.GetColorValue() ); +} + +if (SFX_ITEM_DONTCARE != rAttrs.GetItemState(XATTR_FILLGRADIENT)) +{ +XFillGradientItem const rGradientItem( +static_castconst XFillGradientItem( +rAttrs.Get(XATTR_FILLGRADIENT)) ); +OUString const aString( rGradientItem.GetName() ); +XGradient const aGradient( rGradientItem.GetGradientValue() ); + +m_pLbGradient-SelectEntryByList(pGradientList, aString, aGradient); +} +if (!m_pLbGradient-GetSelectEntryCount()) +{ // avoid relying on pool default - cannot export that +m_pLbGradient-SelectEntryPos(0); // anything better than nothing +isMissingGradient = true; +} + +if (SFX_ITEM_DONTCARE != rAttrs.GetItemState(XATTR_FILLHATCH)) +{ +m_pLbHatching-SelectEntry( static_castconst XFillHatchItem( +rAttrs.Get(XATTR_FILLHATCH)).GetName() ); +} +if (!m_pLbHatching-GetSelectEntryCount()) +{ // avoid relying on pool default - cannot export that +m_pLbHatching-SelectEntryPos(0); // anything better than nothing +isMissingHatching = true; +} +if (SFX_ITEM_DONTCARE != rAttrs.GetItemState(XATTR_FILLBACKGROUND)) +{ +m_pCbxHatchBckgrd-Check( static_castconst XFillBackgroundItem( +rAttrs.Get(XATTR_FILLBACKGROUND)).GetValue() ); +} + +if (SFX_ITEM_DONTCARE != rAttrs.GetItemState(XATTR_FILLBITMAP)) +{ +XFillBitmapItem const rBitmapItem( +static_castconst XFillBitmapItem( +rAttrs.Get(XATTR_FILLBITMAP))); +m_pLbBitmap-SelectEntry(rBitmapItem.GetName()); +} +if (!m_pLbBitmap-GetSelectEntryCount()) +{ // avoid relying on pool default - cannot export that +m_pLbBitmap-SelectEntryPos(0); // anything better than nothing +isMissingBitmap = true; +} + switch( eXFS ) { case XFILL_NONE: @@ -1418,69 +1475,26 @@ void SvxAreaTabPage::Reset( const SfxItemSet rAttrs ) break; case XFILL_SOLID: -if( SFX_ITEM_DONTCARE != rAttrs.GetItemState( XATTR_FILLCOLOR ) ) -{ -XFillColorItem aColorItem( ( const XFillColorItem ) -rAttrs.Get( XATTR_FILLCOLOR ) ); - -m_pLbColor-SelectEntry( aColorItem.GetColorValue() ); -m_pLbHatchBckgrdColor-SelectEntry( aColorItem.GetColorValue() ); -} ClickColorHdl_Impl(); -
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/sgvspln.cxx | 412 -- 1 file changed, 202 insertions(+), 210 deletions(-) New commits: commit 654f0932b94163dbed9c66bb32f595e8f6cea834 Author: Luc Castermans luc.casterm...@gmail.com Date: Sun Feb 9 10:34:18 2014 +0100 Translated German comments - polygon and matrix calculations Change-Id: I3b01520cca854e6504787077a15fbe150eef86d4 Reviewed-on: https://gerrit.libreoffice.org/7950 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/vcl/source/filter/sgvspln.cxx b/vcl/source/filter/sgvspln.cxx index 79c8ae1..167a167 100644 --- a/vcl/source/filter/sgvspln.cxx +++ b/vcl/source/filter/sgvspln.cxx @@ -26,58 +26,59 @@ extern C { /*.pn 277 */ -/*.hlAnhang: C - Programme*/ -/*.hrKonstanten- und Macro-Definitionen*/ -/*.fe Die Include-Datei u_const.h ist in das Verzeichnis zu stellen, */ -/*.fe wo der Compiler nach Include-Dateien sucht. */ +/*.hlAppendix: C - programs*/ +/*.hrConstants- and macrodefinitions*/ +/*.fe The include file u_const.h should be stored in the directory, */ +/*.fe where the compiler searches for include files. */ /*--- FILE u_const.h ---*/ #define IEEE -/* IEEE - Norm fuer die Darstellung von Gleitkommazahlen: +/* IEEE - standard for representation of floating-point numbers: - 8 Byte lange Gleitkommazahlen, mit + 8 byte long floating point numbers with - 53 Bit Mantisse == Mantissenbereich:2 hoch 52 versch. Zahlen - mit 0.1 = Zahl 1.0, - 1 Vorzeichen-Bit - 11 Bit Exponent == Exponentenbereich: -1024...+1023 +53 bit mantissa == mantissa range: 2^52 different numbers + with 0.1 = number 1.0, + 1 sign-bit +11 bit exponent == exponent range: -1024...+1023 - Die 1. Zeile ( #define IEEE ) ist zu loeschen, falls die Maschine - bzw. der Compiler keine Gleitpunktzahlen gemaess der IEEE-Norm - benutzt. Zusaetzlich muessen die Zahlen MAXEXPON, MINEXPON - (s.u.) angepasst werden. - */ + The first line (#define IEEE) should be deleted if the machine + or the compiler does not use floating-point numbers according + to the IEEE standard. In which case also MAXEXPON, MINEXPON (see + below) should be adapted. +*/ -#ifdef IEEE /*--- Falls IEEE Norm */ +#ifdef IEEE /*-- if IEEE norm */ -#define MACH_EPS 2.220446049250313e-016 /* Maschinengenauigkeit*/ - /* IBM-AT: = 2 hoch -52 */ -/* MACH_EPS ist die kleinste positive, auf der Maschine darstellbare - Zahl x, die der Bedingung genuegt: 1.0 + x 1.0 */ +#define MACH_EPS 2.220446049250313e-016 /* machine precision*/ + /* IBM-AT: = 2^-52*/ +/* MACH_EPS is the smallest positive, by the machine representable + number x, which fulfills the equation: 1.0 + x 1.0 */ #define MAXROOT 9.48075190810918e+153 -#else /*-- sonst ---*/ +#else /*-- otherwise*/ double exp (double); double atan (double); double pow (double,double); double sqrt (double); -double masch()/* MACH_EPS maschinenunabhaengig bestimmen */ +double masch()/* calculate MACH_EPS machine independence */ { double eps = 1.0, x = 2.0, y = 1.0; while ( y x ) { eps *= 0.5; x = 1.0 + eps; } - eps *= 2.0; return (eps); + eps *= 2.0; + return (eps); } -short basis() /* BASIS maschinenunabhaengig bestimmen */ +short basis() /* calculate BASE machine independence */ { double x = 1.0, one = 1.0, b = 1.0; @@ -87,15 +88,14 @@ short basis() /* BASIS maschinenunabhaengig bestimmen */ return ( (short) ((x + b) - x) ); } -#define BASIS basis() /* Basis der Zahlendarst. */ +#define BASIS basis() /* base of number representation */ -/* Falls die Maschine (der Compiler) keine IEEE-Darstellung fuer - Gleitkommazahlen nutzt, muessen die folgenden 2 Konstanten an- - gepasst werden. +/* If the machine (the compiler) does not use the IEEE-representation + for floating-point numbers, the next 2 constants should be adapted. */ -#define MAXEXPON 1023.0 /* groesster Exponent */ -#define MINEXPON -1024.0 /* kleinster Exponent */ +#define MAXEXPON 1023.0/* largest exponent */ +#define MINEXPON -1024.0/* smallest exponent */ #define MACH_EPS masch()
[Libreoffice-commits] core.git: 4 commits - chart2/Library_chartcontroller.mk chart2/source chart2/uiconfig chart2/UIConfig_chart2.mk sc/source
chart2/Library_chartcontroller.mk|1 chart2/UIConfig_chart2.mk|1 chart2/source/controller/dialogs/tp_DataSource.cxx |8 - chart2/source/controller/dialogs/tp_RangeChooser.cxx | 12 - chart2/source/view/main/OpenGLRender.cxx | 13 +- chart2/uiconfig/ui/tp_DataSource.ui | 28 chart2/uiconfig/ui/tp_RangeChooser.ui| 119 ++- sc/source/core/tool/interpr1.cxx |2 8 files changed, 162 insertions(+), 22 deletions(-) New commits: commit 7f8b4e14d787ec648a3de69fd51dc90fcfc876d9 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Sun Feb 9 13:45:21 2014 +0100 fix memcheck report about uninitialized fVal Change-Id: I7ae3f6ce0499cc4fda885a13be09063c5b75559d diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx index bbc7110..fbf564f 100644 --- a/sc/source/core/tool/interpr1.cxx +++ b/sc/source/core/tool/interpr1.cxx @@ -1222,7 +1222,7 @@ void ScInterpreter::ScAnd() double fVal; sal_uInt16 nErr = 0; ScValueIterator aValIter( pDok, aRange ); -if ( aValIter.GetFirst( fVal, nErr ) ) +if ( aValIter.GetFirst( fVal, nErr ) nErr == 0 ) { bHaveValue = true; do commit 33c8b164257a481875dee41be8177bd4cd744dd1 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Sat Feb 8 19:43:38 2014 +0100 add a few more debug statements Change-Id: I9c9f4f216f1505d66911cfcf049eb991fbe59ccf diff --git a/chart2/source/view/main/OpenGLRender.cxx b/chart2/source/view/main/OpenGLRender.cxx index 9de0571..cc031f3 100755 --- a/chart2/source/view/main/OpenGLRender.cxx +++ b/chart2/source/view/main/OpenGLRender.cxx @@ -1423,9 +1423,12 @@ int OpenGLRender::RenderTextShape() MoveModelf(trans, angle, scale); m_MVP = m_Projection * m_View * m_Model; glBindBuffer(GL_ARRAY_BUFFER, m_VertexBuffer); +CHECK_GL_ERROR(); glBufferData(GL_ARRAY_BUFFER, sizeof(textInfo.vertex), textInfo.vertex, GL_STATIC_DRAW); +CHECK_GL_ERROR(); glUseProgram(m_TextProID); +CHECK_GL_ERROR(); glUniformMatrix4fv(m_TextMatrixID, 1, GL_FALSE, m_MVP[0][0]); // 1rst attribute buffer : vertices glEnableVertexAttribArray(m_TextVertexID); @@ -1439,6 +1442,7 @@ int OpenGLRender::RenderTextShape() (void*)0// array buffer offset ); //tex coord +CHECK_GL_ERROR(); glEnableVertexAttribArray(m_TextTexCoordID); glBindBuffer(GL_ARRAY_BUFFER, m_TextTexCoordBuf); glVertexAttribPointer( @@ -1450,15 +1454,22 @@ int OpenGLRender::RenderTextShape() (void*)0// array buffer offset ); //texture +CHECK_GL_ERROR(); glBindTexture(GL_TEXTURE_2D, textInfo.texture); +CHECK_GL_ERROR(); glUniform1i(m_TextTexID, 0); +CHECK_GL_ERROR(); //TODO: moggi: get rid fo GL_QUADS -glDrawArrays(GL_QUADS, 0, 4); +glDrawArrays(GL_QUADS, 0, 3); +CHECK_GL_ERROR(); glDisableVertexAttribArray(m_TextTexCoordID); +CHECK_GL_ERROR(); glDisableVertexAttribArray(m_TextVertexID); +CHECK_GL_ERROR(); glBindTexture(GL_TEXTURE_2D, 0); glUseProgram(0); glDeleteTextures(1, textInfo.texture); +CHECK_GL_ERROR(); m_TextInfoList.pop_front(); } CHECK_GL_ERROR(); commit ec4b0ed8e070f2c0955c0a60194328d84490d1bb Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Fri Jan 31 02:23:56 2014 +0100 improve dialogs for mapped properties Change-Id: I87e07a30743de0fc30d0caafd35192b18caf3dae diff --git a/chart2/Library_chartcontroller.mk b/chart2/Library_chartcontroller.mk index d4f309f..bf59cab 100644 --- a/chart2/Library_chartcontroller.mk +++ b/chart2/Library_chartcontroller.mk @@ -103,6 +103,7 @@ $(eval $(call gb_Library_add_exception_objects,chartcontroller,\ chart2/source/controller/dialogs/dlg_InsertTitle \ chart2/source/controller/dialogs/dlg_NumberFormat \ chart2/source/controller/dialogs/dlg_ObjectProperties \ +chart2/source/controller/dialogs/dlg_PropertyMapping \ chart2/source/controller/dialogs/dlg_ShapeFont \ chart2/source/controller/dialogs/dlg_ShapeParagraph \ chart2/source/controller/dialogs/dlg_View3D \ diff --git a/chart2/UIConfig_chart2.mk b/chart2/UIConfig_chart2.mk index d9ef7d7..515ddf0 100644 --- a/chart2/UIConfig_chart2.mk +++ b/chart2/UIConfig_chart2.mk @@ -37,6 +37,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/schart,\ chart2/uiconfig/ui/datarangedialog \ chart2/uiconfig/ui/dlg_DataLabel \
[Libreoffice-commits] core.git: chart2/source chart2/uiconfig
chart2/source/controller/dialogs/dlg_PropertyMapping.cxx | 34 chart2/source/controller/dialogs/dlg_PropertyMapping.hxx | 35 chart2/uiconfig/ui/dlg_PropertyMapping.ui| 119 +++ 3 files changed, 188 insertions(+) New commits: commit 042fec5bf2d00e55a0ef8b2a0120e821189b5088 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Sun Feb 9 14:19:14 2014 +0100 forgot the new files Change-Id: I63bdb340aa06b072541bb8b0ed975457c504c9a2 diff --git a/chart2/source/controller/dialogs/dlg_PropertyMapping.cxx b/chart2/source/controller/dialogs/dlg_PropertyMapping.cxx new file mode 100644 index 000..c41859f --- /dev/null +++ b/chart2/source/controller/dialogs/dlg_PropertyMapping.cxx @@ -0,0 +1,34 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include dlg_PropertyMapping.hxx + +namespace chart { + +namespace { + +static long pListBoxTabs[] = +{ +3, +0, 0, 75 +}; + +} + +PropertyMappingDlg::PropertyMappingDlg(Window* pParent): +ModalDialog(pParent, Property Mapping Dialog, modules/schart/ui/dlg_PropertyMapping.ui) +{ +get(mpMappingTable, LST_PROPERTY_MAPPING); + +mpMappingTable-SetTabs( pListBoxTabs, MAP_APPFONT ); +} + +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/controller/dialogs/dlg_PropertyMapping.hxx b/chart2/source/controller/dialogs/dlg_PropertyMapping.hxx new file mode 100644 index 000..3240a30 --- /dev/null +++ b/chart2/source/controller/dialogs/dlg_PropertyMapping.hxx @@ -0,0 +1,35 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#ifndef CHART2_PROPERTY_MAPPING_HXX +#define CHART2_PROPERTY_MAPPING_HXX + +#include vcl/dialog.hxx +#include svtools/svtabbx.hxx + +namespace chart { + +class PropertyMappingDlg : public ModalDialog +{ +public: + +PropertyMappingDlg(Window* pParent); + +OUString getSelectedEntry(); + +private: + +SvTabListBox* mpMappingTable; +}; + +} + +#endif + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/uiconfig/ui/dlg_PropertyMapping.ui b/chart2/uiconfig/ui/dlg_PropertyMapping.ui new file mode 100644 index 000..55ae428 --- /dev/null +++ b/chart2/uiconfig/ui/dlg_PropertyMapping.ui @@ -0,0 +1,119 @@ +?xml version=1.0 encoding=UTF-8? +!-- Generated with glade 3.16.1 -- +interface + requires lib=gtk+ version=3.10/ + !-- interface-requires LibreOffice 1.0 -- + object class=GtkWindow id=window1 +property name=can_focusFalse/property +property name=type_hintdialog/property +child + object class=GtkBox id=box1 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=orientationvertical/property +child + object class=GtkLabel id=LB_TITLE +property name=visibleTrue/property +property name=can_focusFalse/property +property name=label translatable=yesSelect property mapping:/property + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position0/property + /packing +/child +child + object class=svtlo-SvTabListBox id=LST_PROPERTY_MAPPING +property name=width_request110/property +property name=height_request110/property +property name=visibleTrue/property +property name=can_focusTrue/property +child internal-child=selection + object class=GtkTreeSelection id=Tab List-selection2/ +/child + /object + packing +property name=expandFalse/property +property name=fillTrue/property +property name=position1/property + /packing +/child +child + object class=GtkButtonBox id=buttonbox1 +property name=visibleTrue/property +property name=can_focusFalse/property +property name=margin_top6/property +property name=margin_bottom6/property +property name=spacing6/property +property name=layout_stylestart/property +child + object class=GtkButton id=ok +property name=label translatable=yesOk/property +property name=visibleTrue/property +property
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/main/OpenGLRender.cxx | 48 +-- chart2/source/view/main/OpenGLRender.hxx | 14 + 2 files changed, 48 insertions(+), 14 deletions(-) New commits: commit 904d5010be5e22cdda49cbc09d332d3ee0c00b84 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:00:57 2014 + coverity#1169877 Uninitialized pointer field Change-Id: I3a64f7d476b682c68d05a25ed4b2287ef3e482d5 diff --git a/chart2/source/view/main/OpenGLRender.cxx b/chart2/source/view/main/OpenGLRender.cxx index cc031f3..1f07b46 100755 --- a/chart2/source/view/main/OpenGLRender.cxx +++ b/chart2/source/view/main/OpenGLRender.cxx @@ -756,22 +756,42 @@ void OpenGLRender::Release() #endif } -OpenGLRender::OpenGLRender(uno::Reference drawing::XShape xTarget): -m_Model(glm::mat4(1.0f)), -m_TextureObj(0), -m_FboID(0), -m_RboID(0), -m_iWidth(0), -m_iHeight(0), -mxRenderTarget(xTarget), -mbArbMultisampleSupported(false), +OpenGLRender::OpenGLRender(uno::Reference drawing::XShape xTarget) +: m_Model(glm::mat4(1.0f)) +, m_TextureObj(0) +, m_FboID(0) +, m_RboID(0) +, m_iWidth(0) +, m_iHeight(0) +, m_fLineWidth(0) +, mxRenderTarget(xTarget) +, mbArbMultisampleSupported(false) #if defined( _WIN32 ) -m_iArbMultisampleFormat(0), +, m_iArbMultisampleFormat(0) #endif -m_2DColor(glm::vec4(1.0, 0.0, 0.0, 1.0)), -m_frameBufferMS(0), -m_TextVertexID(0), -m_TextTexCoordID(1) +, m_2DColor(glm::vec4(1.0, 0.0, 0.0, 1.0)) +, m_frameBufferMS(0) +, m_renderBufferColorMS(0) +, m_renderBufferDepthMS(0) +, m_CommonProID(0) +, m_2DVertexID(0) +, m_2DColorID(0) +, m_fZStep(0) +, m_TextProID(0) +, m_TextMatrixID(0) +, m_TextVertexID(0) +, m_TextTexCoordID(1) +, m_TextTexCoordBuf(0) +, m_TextTexID(0) +, m_BackgroundProID(0) +, m_BackgroundMatrixID(0) +, m_BackgroundVertexID(0) +, m_BackgroundColorID(0) +, m_SymbolProID(0) +, m_SymbolVertexID(0) +, m_SymbolMatrixID(0) +, m_SymbolColorID(0) +, m_SymbolShapeID(0) { //TODO: moggi: use STL memset(m_Bubble2DCircle, 0, sizeof(m_Bubble2DCircle)); diff --git a/chart2/source/view/main/OpenGLRender.hxx b/chart2/source/view/main/OpenGLRender.hxx index 8ba5c76..32c91c5 100755 --- a/chart2/source/view/main/OpenGLRender.hxx +++ b/chart2/source/view/main/OpenGLRender.hxx @@ -123,6 +123,20 @@ struct GLWindow const GLubyte* GLExtensions; bool HasGLExtension( const char* name ) { return gluCheckExtension( (const GLubyte*) name, GLExtensions ); } + +GLWindow() +: +#if defined( _WIN32 ) +#elif defined( MACOSX ) +#elif defined( UNX ) +GLXExtensions(NULL), +#endif +bpp(0), +Width(0), +Height(0), +GLExtensions(NULL) +{ +} }; class OpenGLRender ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 13 commits - chart2/source editeng/source formula/source framework/source sc/source sfx2/source starmath/source sw/source
chart2/source/view/main/DummyXShape.cxx | 13 +++--- editeng/source/editeng/impedit2.cxx |6 -- editeng/source/editeng/impedit3.cxx |4 + editeng/source/editeng/impedit4.cxx |4 - formula/source/ui/dlg/formula.cxx|2 framework/source/services/autorecovery.cxx |2 framework/source/uielement/controlmenucontroller.cxx |6 +- sc/source/core/tool/compiler.cxx |2 sc/source/core/tool/tokenstringcontext.cxx |3 - sfx2/source/control/bindings.cxx |2 starmath/source/accessibility.cxx|5 +- sw/source/ui/shells/drwtxtex.cxx | 30 -- sw/source/ui/shells/txtattr.cxx | 40 +++ 13 files changed, 69 insertions(+), 50 deletions(-) New commits: commit a6b41b0c1460d3c9516b8d4e4d88abdc4fdb7ea2 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:53:22 2014 + coverity#1169825 Dereference after null check Change-Id: I74df9084f46e38901b6682b892fa7d0f71d72572 diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx index 0a00747..905fcfe 100644 --- a/sfx2/source/control/bindings.cxx +++ b/sfx2/source/control/bindings.cxx @@ -1917,7 +1917,7 @@ void SfxBindings::ClearCache_Impl( sal_uInt16 nSlotId ) { SfxStateCache* pCache = GetStateCache(nSlotId); if (!pCache) -return +return; pCache-ClearCache(); } commit 57e0062f2043f7a0382db5f4d01c6c70ca8aca46 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:50:10 2014 + coverity#1169826 Dereference after null check Change-Id: Ie431672b5a6ba1d613ae1cb9e48fa6d1db6a6b4a diff --git a/framework/source/uielement/controlmenucontroller.cxx b/framework/source/uielement/controlmenucontroller.cxx index 3a542b3..08723c8 100644 --- a/framework/source/uielement/controlmenucontroller.cxx +++ b/framework/source/uielement/controlmenucontroller.cxx @@ -264,7 +264,7 @@ void ControlMenuController::updateImagesPopupMenu( PopupMenu* pPopupMenu ) if ( pResMgr-IsAvailable( aResId )) { ImageList aImageList( aResId ); - for ( sal_uInt32 i=0; i sizeof(nConvertSlots)/sizeof(nConvertSlots[0]); ++i ) +for ( sal_uInt32 i=0; i sizeof(nConvertSlots)/sizeof(nConvertSlots[0]); ++i ) { // das entsprechende Image dran if ( m_bShowMenuImages ) @@ -411,9 +411,11 @@ void ControlMenuController::impl_setPopupMenu() ResId aResId( RID_FMSHELL_CONVERSIONMENU, *pResMgr ); aResId.SetRT( RSC_MENU ); if ( pResMgr-IsAvailable( aResId )) +{ m_pResPopupMenu = new PopupMenu( aResId ); +updateImagesPopupMenu( m_pResPopupMenu ); +} -updateImagesPopupMenu( m_pResPopupMenu ); delete pResMgr; } } // if ( m_pResPopupMenu == 0 ) commit daf4fb951bf8493b3425f24beb7eb1a6c36f838a Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:43:56 2014 + coverity#1169827 Explicit null dereferenced Change-Id: Iaca51f3795341c1c834772abba340501b3fc60a3 diff --git a/editeng/source/editeng/impedit3.cxx b/editeng/source/editeng/impedit3.cxx index e124021..8bfefb3 100644 --- a/editeng/source/editeng/impedit3.cxx +++ b/editeng/source/editeng/impedit3.cxx @@ -2254,6 +2254,10 @@ sal_Int32 ImpEditEngine::SplitTextPortion( ParaPortion* pPortion, sal_Int32 nPos } DBG_ASSERT( pTextPortion, Position outside the area! ); + +if (!pTextPortion) +return 0; + DBG_ASSERT( pTextPortion-GetKind() == PORTIONKIND_TEXT, SplitTextPortion: No TextPortion! ); sal_Int32 nOverlapp = nTmpPos - nPos; commit ecfeb72252c18c7fc94170e19a1ca6aba4116e72 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:41:54 2014 + coverity#1169828 Explicit null dereferenced Change-Id: Iad58bc1f5295bdaaff4ba17e70cb3aa4d5fc5aca diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index eb1e366..514668c 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -3982,12 +3982,10 @@ long ImpEditEngine::GetXPos( if ( pPortion-GetExtraInfos()-nAsianCompressionTypes CHAR_PUNCTUATIONRIGHT ) { sal_uInt8 nType = GetCharTypeForCompression( pParaPortion-GetNode()-GetChar( nIndex ) ); -if ( nType == CHAR_PUNCTUATIONRIGHT ) +if ( nType == CHAR_PUNCTUATIONRIGHT !pLine-GetCharPosArray().empty() ) { sal_Int32 n = nIndex - nTextPortionStart; -const sal_Int32* pDXArray = NULL; -if (!pLine-GetCharPosArray().empty()) -
[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source
sc/qa/unit/ucalc.hxx |2 ++ sc/qa/unit/ucalc_formula.cxx | 25 + sc/source/core/tool/scmatrix.cxx | 11 ++- 3 files changed, 37 insertions(+), 1 deletion(-) New commits: commit 295869ce95c00a0e0b192ea6bf62753f91badaf2 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 11:34:11 2014 -0500 fdo#74479: Treat empty cells as if they have a value of 0. Change-Id: I3701848016c230138e8791f683a2c8b97219198d diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx index 74f7fa3..090cada 100644 --- a/sc/source/core/tool/scmatrix.cxx +++ b/sc/source/core/tool/scmatrix.cxx @@ -1612,7 +1612,16 @@ public: } break; case mdds::mtm::element_empty: -std::advance(miPos, node.size); +{ +// Empty element is equivalent of having a numeric value of 0.0. +for (size_t i = 0; i node.size; ++i, ++miPos) +{ +if (rtl::math::isNan(*miPos)) +continue; + +*miPos = op(*miPos, 0.0); +} +} default: ; } commit 71fe47cfe652829ff7dc09ae49b1c6c22d9b6a6d Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 11:10:34 2014 -0500 fdo#74479: Test case for SUMPRODUCT. Change-Id: I2e8669c1cd6c824751d557c7c9ee735d580f17e9 diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 053e607..a32b048 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -115,6 +115,7 @@ public: void testFuncROW(); void testFuncSUM(); void testFuncPRODUCT(); +void testFuncSUMPRODUCT(); void testFuncN(); void testFuncCOUNTIF(); void testFuncNUMBERVALUE(); @@ -347,6 +348,7 @@ public: CPPUNIT_TEST(testFuncROW); CPPUNIT_TEST(testFuncSUM); CPPUNIT_TEST(testFuncPRODUCT); +CPPUNIT_TEST(testFuncSUMPRODUCT); CPPUNIT_TEST(testFuncN); CPPUNIT_TEST(testFuncCOUNTIF); CPPUNIT_TEST(testFuncNUMBERVALUE); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 05ff6b6..a4b6289 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -1790,6 +1790,31 @@ void Test::testFuncPRODUCT() m_pDoc-DeleteTab(0); } +void Test::testFuncSUMPRODUCT() +{ +m_pDoc-InsertTab(0, Test); + +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn on auto recalc. + +ScAddress aPos(0,0,0); +m_pDoc-SetString(aPos, =SUMPRODUCT(B1:B3;C1:C3)); +CPPUNIT_ASSERT_EQUAL(0.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(2,0,0), 1.0); // C1 +CPPUNIT_ASSERT_EQUAL(0.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(1,0,0), 1.0); // B1 +CPPUNIT_ASSERT_EQUAL(1.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(1,1,0), 2.0); // B2 +CPPUNIT_ASSERT_EQUAL(1.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(2,1,0), 3.0); // C2 +CPPUNIT_ASSERT_EQUAL(7.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(2,2,0), -2.0); // C3 +CPPUNIT_ASSERT_EQUAL(7.0, m_pDoc-GetValue(aPos)); +m_pDoc-SetValue(ScAddress(1,2,0), 5.0); // B3 +CPPUNIT_ASSERT_EQUAL(-3.0, m_pDoc-GetValue(aPos)); + +m_pDoc-DeleteTab(0); +} + void Test::testFuncN() { OUString aTabName(foo); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 10 commits - basctl/source chart2/source editeng/source framework/source sw/source
basctl/source/basicide/baside2.cxx | 20 ++-- chart2/source/view/main/DummyXShape.cxx| 29 + editeng/source/editeng/editdoc.cxx |6 +++--- framework/source/services/autorecovery.cxx |4 +++- sw/source/core/docnode/ndtbl.cxx |2 +- sw/source/core/text/itrform2.hxx | 10 +- sw/source/core/text/itrpaint.hxx | 15 --- sw/source/filter/ww8/ww8atr.cxx|4 ++-- 8 files changed, 45 insertions(+), 45 deletions(-) New commits: commit 53c84ea21e4e709f3b40d5f56ce764f0c4ce1fc7 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 16:42:44 2014 + coverity#1169804 Unchecked return value Change-Id: I32fb858ab78a741a194ae11a3147645d786c9afe diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index 95362d7..faf8e86 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -4126,7 +4126,9 @@ AutoRecovery::EFailureSafeResult AutoRecovery::implts_copyFile(const OUString s try { -::ucbhelper::Content::create(sSource, xEnvironment, m_xContext, aSourceContent); +bool bSuccess = ::ucbhelper::Content::create(sSource, xEnvironment, m_xContext, aSourceContent); +if (!bSuccess) +return AutoRecovery::E_ORIGINAL_FILE_MISSING; aTargetContent.transferContent(aSourceContent, ::ucbhelper::InsertOperation_COPY, sTargetName, nNameClash); } catch(const css::uno::Exception) commit f2fb3c464716e5f14e5b966592adb5b6714c0566 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 16:36:42 2014 + coverity#1169806 Operands don't affect result Change-Id: I8c219ae3b1adcc615d75a61afba9414eb8acdc22 diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx index 51c0275..728badf 100644 --- a/editeng/source/editeng/editdoc.cxx +++ b/editeng/source/editeng/editdoc.cxx @@ -795,7 +795,7 @@ long ParaPortionList::GetYOffset(const ParaPortion* pPPortion) const sal_Int32 ParaPortionList::FindParagraph(long nYOffset) const { long nY = 0; -for (sal_Int32 i = 0, n = maPortions.size(); i n; ++i) +for (size_t i = 0, n = maPortions.size(); i n; ++i) { nY += maPortions[i].GetHeight(); // should also be correct even in bVisible! if ( nY nYOffset ) commit 54cb92d14175af8991aa33eadf6396ef16835bb7 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 16:28:41 2014 + coverity#1169807 Operands don't affect result Change-Id: Ie96de8af75be60435f00593ca33d1dff2f42a02c diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx index 296c132..51c0275 100644 --- a/editeng/source/editeng/editdoc.cxx +++ b/editeng/source/editeng/editdoc.cxx @@ -2062,7 +2062,7 @@ void EditDoc::Release(sal_Int32 nPos) sal_Int32 EditDoc::Count() const { -sal_Int32 nSize = maContents.size(); +size_t nSize = maContents.size(); if (nSize SAL_MAX_INT32) { SAL_WARN( editeng, EditDoc::Count - overflow nSize); commit 24c5cac41fc6592c0d5639be1ffa9fddcf7b0810 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 16:27:35 2014 + coverity#1169808 Operands don't affect result Change-Id: I95a3c09056a00a6839f25ecf54acc15e366cc360 diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx index 4732c62..296c132 100644 --- a/editeng/source/editeng/editdoc.cxx +++ b/editeng/source/editeng/editdoc.cxx @@ -764,7 +764,7 @@ void ParaPortionList::Append(ParaPortion* p) sal_Int32 ParaPortionList::Count() const { -sal_Int32 nSize = maPortions.size(); +size_t nSize = maPortions.size(); if (nSize SAL_MAX_INT32) { SAL_WARN( editeng, ParaPortionList::Count - overflow nSize); commit 6683634c7c683bda2081c9c36ae80115e8693206 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 16:19:34 2014 + coverity#1169816 Division or modulo by zero Change-Id: Ibd07c0d3766467f2b11b0a9fb18ca089ddcb1cb2 diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx index d8312b5..520b61c 100644 --- a/basctl/source/basicide/baside2.cxx +++ b/basctl/source/basicide/baside2.cxx @@ -886,26 +886,26 @@ sal_Int32 ModulWindow::FormatAndPrint( Printer* pPrinter, sal_Int32 nPrintPage ) OUString aTitle( CreateQualifiedName() ); -sal_uInt16 nLineHeight = (sal_uInt16) pPrinter-GetTextHeight(); +sal_Int32 nLineHeight = pPrinter-GetTextHeight(); if(nLineHeight == 0) { nLineHeight = 1; } -sal_uInt16 nParaSpace = 10; +sal_Int32 nParaSpace = 10; Size aPaperSz = pPrinter-GetOutputSize(); aPaperSz.Width() -= (Print::nLeftMargin + Print::nRightMargin); aPaperSz.Height() -= (Print::nTopMargin + Print::nBottomMargin); // nLinepPage is not
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source
sc/source/core/tool/scmatrix.cxx | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit dbb89000146d118ea28f0869d03e121d01e11f04 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 11:34:11 2014 -0500 fdo#74479: Treat empty cells as if they have a value of 0. Change-Id: I3701848016c230138e8791f683a2c8b97219198d (cherry picked from commit 295869ce95c00a0e0b192ea6bf62753f91badaf2) Reviewed-on: https://gerrit.libreoffice.org/7954 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx index 132923d..45c8e48 100644 --- a/sc/source/core/tool/scmatrix.cxx +++ b/sc/source/core/tool/scmatrix.cxx @@ -1612,7 +1612,16 @@ public: } break; case mdds::mtm::element_empty: -std::advance(miPos, node.size); +{ +// Empty element is equivalent of having a numeric value of 0.0. +for (size_t i = 0; i node.size; ++i, ++miPos) +{ +if (rtl::math::isNan(*miPos)) +continue; + +*miPos = op(*miPos, 0.0); +} +} default: ; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source
sc/source/core/tool/compiler.cxx | 28 1 file changed, 8 insertions(+), 20 deletions(-) New commits: commit 0b3342e214d2f9edffbdc595de3410cfc96322d4 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sat Feb 8 18:19:42 2014 -0500 fdo#74512: Generate escaped sheet names after the grammer is set. Otherwise the single quote characters wouldn't be properly doubled. Change-Id: I864ca8912a35049905e52e002d92d648e1278015 (cherry picked from commit 83cdcdb9f0fe11309939f5dca4fb46e426559896) Reviewed-on: https://gerrit.libreoffice.org/7947 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx index 4a1bbd7..13b3a85 100644 --- a/sc/source/core/tool/compiler.cxx +++ b/sc/source/core/tool/compiler.cxx @@ -239,6 +239,14 @@ void ScCompiler::SetGrammar( const FormulaGrammar::Grammar eGrammar ) if (eMyGrammar != GetGrammar()) SetGrammarAndRefConvention( eMyGrammar, eOldGrammar); } + +if (pDoc maTabNames.empty()) +{ +maTabNames = pDoc-GetAllTableNames(); +std::vectorOUString::iterator it = maTabNames.begin(), itEnd = maTabNames.end(); +for (; it != itEnd; ++it) +ScCompiler::CheckTabQuotes(*it, formula::FormulaGrammar::extractRefConvention(meGrammar)); +} } void ScCompiler::SetNumberFormatter( SvNumberFormatter* pFormatter ) @@ -1562,16 +1570,6 @@ ScCompiler::ScCompiler( ScDocument* pDocument, const ScAddress rPos,ScTokenArra mbRewind( false ) { nMaxTab = pDoc ? pDoc-GetTableCount() - 1 : 0; - -if (pDoc) -{ -maTabNames = pDoc-GetAllTableNames(); -{ -std::vectorOUString::iterator it = maTabNames.begin(), itEnd = maTabNames.end(); -for (; it != itEnd; ++it) -ScCompiler::CheckTabQuotes(*it, formula::FormulaGrammar::extractRefConvention(meGrammar)); -} -} } ScCompiler::ScCompiler( sc::CompileFormulaContext rCxt, const ScAddress rPos ) : @@ -1605,16 +1603,6 @@ ScCompiler::ScCompiler( ScDocument* pDocument, const ScAddress rPos) mbRewind( false ) { nMaxTab = pDoc ? pDoc-GetTableCount() - 1 : 0; - -if (pDoc) -{ -maTabNames = pDoc-GetAllTableNames(); -{ -std::vectorOUString::iterator it = maTabNames.begin(), itEnd = maTabNames.end(); -for (; it != itEnd; ++it) -ScCompiler::CheckTabQuotes(*it, formula::FormulaGrammar::extractRefConvention(meGrammar)); -} -} } ScCompiler::~ScCompiler() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source
sc/source/core/data/formulacell.cxx |8 1 file changed, 8 insertions(+) New commits: commit 5674cf16d2e053ac0590e665310683654b1036d7 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sat Feb 8 15:13:18 2014 -0500 fdo#74453: Only adjust tokens for top formula cells of formula group. Change-Id: Id04387dffac271b3d617da0fbc19c862c929d60a (cherry picked from commit 1556dbc451f067d8744378fb9bac0eaa7ef8f5ac) Reviewed-on: https://gerrit.libreoffice.org/7946 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 7d1dff1..0de5c87 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -3024,6 +3024,10 @@ void ScFormulaCell::UpdateInsertTabAbs(SCTAB nTable) if (pDocument-IsClipOrUndo()) return; +bool bAdjustCode = !mxGroup || mxGroup-mpTopCell == this; +if (!bAdjustCode) +return; + pCode-Reset(); ScToken* p = static_castScToken*(pCode-GetNextReferenceRPN()); while (p) @@ -3046,6 +3050,10 @@ bool ScFormulaCell::TestTabRefAbs(SCTAB nTable) if (pDocument-IsClipOrUndo()) return false; +bool bAdjustCode = !mxGroup || mxGroup-mpTopCell == this; +if (!bAdjustCode) +return false; + bool bRet = false; pCode-Reset(); ScToken* p = static_castScToken*(pCode-GetNextReferenceRPN()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 74479, which changed state. Bug 74479 Summary: CALC problem counting weekdays with sumproduct. Only Saturdays are not counted correctly when the selection contains empty cells or no date. SUMPRODUCT() result error with functions or calculations the last parameter. https://bugs.freedesktop.org/show_bug.cgi?id=74479 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 51780] default to Firebird not HSQLDB in Base
https://bugs.freedesktop.org/show_bug.cgi?id=51780 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Whiteboard|EasyHack| |DifficultyInteresting | |SkillCpp SkillSQL | CC|libreoffice@lists.freedeskt | |op.org | --- Comment #17 from Björn Michaelsen bjoern.michael...@canonical.com --- uneasyhackifying this -- way to complex an issue to get started. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - framework/source
framework/source/uielement/controlmenucontroller.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 0867eac7f862a9f871186df3482e8c1362a15175 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 15:50:10 2014 + coverity#1169826 Dereference after null check Change-Id: Ie431672b5a6ba1d613ae1cb9e48fa6d1db6a6b4a (cherry picked from commit 57e0062f2043f7a0382db5f4d01c6c70ca8aca46) Reviewed-on: https://gerrit.libreoffice.org/7953 Tested-by: Andrzej Hunt andrzej.h...@collabora.com Reviewed-by: Andrzej Hunt andrzej.h...@collabora.com diff --git a/framework/source/uielement/controlmenucontroller.cxx b/framework/source/uielement/controlmenucontroller.cxx index b5e4302..1a1f410 100644 --- a/framework/source/uielement/controlmenucontroller.cxx +++ b/framework/source/uielement/controlmenucontroller.cxx @@ -209,7 +209,7 @@ void ControlMenuController::updateImagesPopupMenu( PopupMenu* pPopupMenu ) if ( pResMgr-IsAvailable( aResId )) { ImageList aImageList( aResId ); - for ( sal_uInt32 i=0; i sizeof(nConvertSlots)/sizeof(nConvertSlots[0]); ++i ) +for ( sal_uInt32 i=0; i sizeof(nConvertSlots)/sizeof(nConvertSlots[0]); ++i ) { // das entsprechende Image dran if ( m_bShowMenuImages ) @@ -356,9 +356,11 @@ void ControlMenuController::impl_setPopupMenu() ResId aResId( RID_FMSHELL_CONVERSIONMENU, *pResMgr ); aResId.SetRT( RSC_MENU ); if ( pResMgr-IsAvailable( aResId )) +{ m_pResPopupMenu = new PopupMenu( aResId ); +updateImagesPopupMenu( m_pResPopupMenu ); +} -updateImagesPopupMenu( m_pResPopupMenu ); delete pResMgr; } } // if ( m_pResPopupMenu == 0 ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - extensions.lst
extensions.lst |4 1 file changed, 4 insertions(+) New commits: commit 69b0d1261c6c06f68ea12d2235663c10e00bcc8b Author: Andrea Pescetti pesce...@apache.org Date: Sun Feb 9 18:08:14 2014 + #i124212# Bundle Lithuanian (lt) dictionary with the lt version. diff --git a/extensions.lst b/extensions.lst index 9e47b4f..ec2554b 100644 --- a/extensions.lst +++ b/extensions.lst @@ -70,6 +70,10 @@ b38cba04b6513dd42b031199d617cce6 http://sourceforge.net/projects/aoo-extensions/files/1388/12/DanskeSynonymer.oxt/download DanskeSynonymer.oxt 6ee1e24fb17e44577d8e3200f3e44adc http://sourceforge.net/projects/aoo-extensions/files/1429/6/dict-da-current.oxt/download dict-da-current.oxt +# Lithuanian dictionary. +[ language=lt ] +d8d4a3d5c6abfde1b4c81cc1ddd1afa0 http://sourceforge.net/projects/aoo-extensions/files/17703/0/openoffice-spellcheck-lt-1.3.oxt/download openoffice-spellcheck-lt-1.3.oxt + # Romanian dictionary. [ language=ro ] b05941b975afc0321df0cd48a4d295c8 http://sourceforge.net/projects/aoo-extensions/files/1392/8/dict-ro.1.5.oxt/download dict-ro.1.5.oxt ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: RepositoryExternal.mk
RepositoryExternal.mk | 68 +- 1 file changed, 34 insertions(+), 34 deletions(-) New commits: commit 864f775189c23053bfa6ce8fb051dbc0d71929d9 Author: David Tardon dtar...@redhat.com Date: Sun Feb 9 21:19:07 2014 +0100 move glew to libs section Change-Id: I1e6a4b025b945fc725738303c499c0ea44f9c8a6 diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk index 0c48bf2..d0cb1fb 100644 --- a/RepositoryExternal.mk +++ b/RepositoryExternal.mk @@ -126,40 +126,6 @@ endef endif -ifeq ($(SYSTEM_GLEW),YES) - -define gb_LinkTarget__use_glew -$(call gb_LinkTarget_set_include,$(1),\ - $$(INCLUDE) \ -$(GLEW_CFLAGS) \ -) -$(call gb_LinkTarget_add_libs,$(1),$(GLEW_LIBS)) - -endef - -else - -define gb_LinkTarget__use_glew -$(call gb_LinkTarget_use_external_project,$(1),glew) -$(call gb_LinkTarget_set_include,$(1),\ - -I$(call gb_UnpackedTarball_get_dir,glew/include) \ - $$(INCLUDE) \ -) - -ifeq ($(COM),MSC) -$(call gb_LinkTarget_add_libs,$(1),\ - $(call gb_UnpackedTarball_get_dir,glew)/lib/$(if $(MSVC_USE_DEBUG_RUNTIME),Debug/Win32/glew32d.lib,Release/Win32/glew32.lib) \ -) -else -$(call gb_LinkTarget_add_libs,$(1),\ - -L$(call gb_UnpackedTarball_get_dir,glew)/lib/ -lGLEW \ -) -endif - -endef - -endif - ifeq ($(SYSTEM_GLM),YES) gb_LinkTarget__use_glm_headers := @@ -249,6 +215,40 @@ endef endif +ifeq ($(SYSTEM_GLEW),YES) + +define gb_LinkTarget__use_glew +$(call gb_LinkTarget_set_include,$(1),\ + $$(INCLUDE) \ +$(GLEW_CFLAGS) \ +) +$(call gb_LinkTarget_add_libs,$(1),$(GLEW_LIBS)) + +endef + +else + +define gb_LinkTarget__use_glew +$(call gb_LinkTarget_use_external_project,$(1),glew) +$(call gb_LinkTarget_set_include,$(1),\ + -I$(call gb_UnpackedTarball_get_dir,glew/include) \ + $$(INCLUDE) \ +) + +ifeq ($(COM),MSC) +$(call gb_LinkTarget_add_libs,$(1),\ + $(call gb_UnpackedTarball_get_dir,glew)/lib/$(if $(MSVC_USE_DEBUG_RUNTIME),Debug/Win32/glew32d.lib,Release/Win32/glew32.lib) \ +) +else +$(call gb_LinkTarget_add_libs,$(1),\ + -L$(call gb_UnpackedTarball_get_dir,glew)/lib/ -lGLEW \ +) +endif + +endef + +endif + define gb_LinkTarget__use_iconv $(call gb_LinkTarget_add_libs,$(1),-liconv) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 54157] LibreOffice 4.0 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 57906, which changed state. Bug 57906 Summary: BUGZILLAASSISTANT: Submit fails with error message It looks like you didn't come from the right page ... https://bugs.freedesktop.org/show_bug.cgi?id=57906 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 13 commits - framework/source sc/inc sc/source starmath/source sw/source vcl/qa
framework/source/services/modulemanager.cxx | 96 +- framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx |8 sc/inc/notesuno.hxx |7 sc/source/ui/unoobj/notesuno.cxx |5 starmath/source/parse.cxx |7 sw/source/core/layout/newfrm.cxx |1 sw/source/ui/dbui/mmaddressblockpage.cxx |2 vcl/qa/cppunit/canvasbitmaptest.cxx | 31 ++- 8 files changed, 94 insertions(+), 63 deletions(-) New commits: commit 0419524c57a7c18386c6cdc893a59fd95e589de9 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 21:07:10 2014 + coverity#1130443 Improper use of negative value Change-Id: Ie56b1d5ceeb68bb3d7dffe6ad8949485a93e1fbb diff --git a/sw/source/ui/dbui/mmaddressblockpage.cxx b/sw/source/ui/dbui/mmaddressblockpage.cxx index 4bd2cf5..bdb0848 100644 --- a/sw/source/ui/dbui/mmaddressblockpage.cxx +++ b/sw/source/ui/dbui/mmaddressblockpage.cxx @@ -1342,7 +1342,7 @@ void AddressMultiLineEdit::SetText( const OUString rStr ) while(true) { sal_Int32 nStart = sPara.indexOf( '', nIndex ); -sal_Int32 nEnd = sPara.indexOf( '', nStart ); +sal_Int32 nEnd = nStart == -1 ? -1 : sPara.indexOf( '', nStart ); nIndex = nEnd; if(nStart != -1 nEnd != -1) pTextEngine-SetAttrib( aProtectAttr, nPara, nStart, nEnd + 1, sal_False ); commit 2c32e2f38366b4cfbdc56375cddaac188b80304e Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 21:04:50 2014 + coverity#1130459 Uncaught exception Change-Id: I1192f6326cc19c076386f0f426ebce911dba184b diff --git a/vcl/qa/cppunit/canvasbitmaptest.cxx b/vcl/qa/cppunit/canvasbitmaptest.cxx index a833767..16492d0 100644 --- a/vcl/qa/cppunit/canvasbitmaptest.cxx +++ b/vcl/qa/cppunit/canvasbitmaptest.cxx @@ -597,7 +597,8 @@ private: } virtual uno::Sequence ::sal_Int8 SAL_CALL convertIntegerFromARGB( const uno::Sequence rendering::ARGBColor ) throw (lang::IllegalArgumentException, - uno::RuntimeException) + uno::RuntimeException, + std::exception) { CPPUNIT_ASSERT_MESSAGE(convertIntegerFromARGB: method not implemented, false); return uno::Sequence sal_Int8 (); commit 7af08465168d49f072ec68c9544587c96861a92a Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 21:04:12 2014 + coverity#1130460 Uncaught exception Change-Id: Iaf0bee84a358914e71f04b84e358a03a5a2cd970 diff --git a/vcl/qa/cppunit/canvasbitmaptest.cxx b/vcl/qa/cppunit/canvasbitmaptest.cxx index ac20f1b..a833767 100644 --- a/vcl/qa/cppunit/canvasbitmaptest.cxx +++ b/vcl/qa/cppunit/canvasbitmaptest.cxx @@ -603,8 +603,10 @@ private: return uno::Sequence sal_Int8 (); } -virtual uno::Sequence ::sal_Int8 SAL_CALL convertIntegerFromPARGB( const uno::Sequence rendering::ARGBColor ) throw (lang::IllegalArgumentException, - uno::RuntimeException) +virtual uno::Sequence ::sal_Int8 SAL_CALL convertIntegerFromPARGB( const uno::Sequence rendering::ARGBColor ) +throw (lang::IllegalArgumentException, +uno::RuntimeException, +std::exception) { CPPUNIT_ASSERT_MESSAGE(convertIntegerFromPARGB: method not implemented, false); return uno::Sequence sal_Int8 (); commit 5267fc5e8a01953c8f55d53a470a414f510efcb5 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 21:02:56 2014 + coverity#1130461 Uncaught exception Change-Id: I6054816a63ec5a60e1c782001e8f5c115e40554f diff --git a/vcl/qa/cppunit/canvasbitmaptest.cxx b/vcl/qa/cppunit/canvasbitmaptest.cxx index 85e1ecb..ac20f1b 100644 --- a/vcl/qa/cppunit/canvasbitmaptest.cxx +++ b/vcl/qa/cppunit/canvasbitmaptest.cxx @@ -488,8 +488,10 @@ private: } virtual uno::Sequence ::sal_Int8 SAL_CALL convertToIntegerColorSpace( const uno::Sequence ::sal_Int8 , - const uno::Reference rendering::XIntegerBitmapColorSpace ) throw (lang::IllegalArgumentException, - uno::RuntimeException) + const uno::Reference
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 69/b0d1261c6c06f68ea12d2235663c10e00bcc8b
69/b0d1261c6c06f68ea12d2235663c10e00bcc8b |1 + 1 file changed, 1 insertion(+) New commits: commit fd93b6bf6b8ab8dc14828d47b5cb77c22fc30e76 Author: Caolán McNamara caol...@redhat.com Date: Sun Feb 9 21:09:12 2014 + Notes added by 'git notes add' diff --git a/69/b0d1261c6c06f68ea12d2235663c10e00bcc8b b/69/b0d1261c6c06f68ea12d2235663c10e00bcc8b new file mode 100644 index 000..2f6c4da --- /dev/null +++ b/69/b0d1261c6c06f68ea12d2235663c10e00bcc8b @@ -0,0 +1 @@ +prefer: 143afd75257fd4c4b44f09ee402ec8caa09011ba ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/app/sdmod2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ad5443b929962dea64985b3b197ea323aafab834 Author: J. Fernando Lagrange fernando+libreoff...@trankil.info Date: Sun Feb 2 16:09:02 2014 +0100 fdo#74383 - PagesField: do not count hidden slides Change-Id: Ied09cc3ed4305c14583e9f4d9ce211514c2c90e1 diff --git a/sd/source/ui/app/sdmod2.cxx b/sd/source/ui/app/sdmod2.cxx index 083abc5..5add228 100644 --- a/sd/source/ui/app/sdmod2.cxx +++ b/sd/source/ui/app/sdmod2.cxx @@ -275,7 +275,7 @@ IMPL_LINK(SdModule, CalcFieldValueHdl, EditFieldInfo*, pInfo) } else if( pDoc ) { -nPageCount = (sal_uInt16)pDoc-GetSdPageCount(PK_STANDARD); +nPageCount = (sal_uInt16)pDoc-GetActiveSdPageCount(); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
J. Fernando Lagrange - licence statement
Hello LibreOffice developers, All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. @+ J. Fernando Lagrange signature.asc Description: OpenPGP digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: No effect after changing source code [PATCH]
Hi Harsh Choudhary, to your other question - managed to get your below change to affect the svg export meanwhile? If not, a description of what you tried would be good. As for the patch, comments inline: From 50042ccd574717e679fadc6028b28e6104d3c359 Mon Sep 17 00:00:00 2001 From: Harsh harsh@harsh-kubuntu.(none) Please fix your git setup (user and email address) Date: Tue, 4 Feb 2014 20:47:50 +0530 Subject: [PATCH] pres This needs at least a minimal description of what this patch does. --- filter/source/svg/presentation_engine.js | 119 -- 1 file changed, 111 insertions(+), 8 deletions(-) diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index c77ff1d..98d1245 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -4100,10 +4100,11 @@ FOURBOXWIPE_TRANSITION = 3; ELLIPSEWIPE_TRANSITION = 4; // 17 CLOCKWIPE_TRANSITION= 5; // 22 PINWHEELWIPE_TRANSITION = 6; // 23 -PUSHWIPE_TRANSITION = 7; // 35 -SLIDEWIPE_TRANSITION= 8; // 36 -FADE_TRANSITION = 9; // 37 -CHECKERBOARDWIPE_TRANSITION = 10; // 39 +WATERFALLWIPE_TRANSITION= 7; //34 +PUSHWIPE_TRANSITION = 8; // 35 +SLIDEWIPE_TRANSITION= 9; // 36 +FADE_TRANSITION = 10; // 37 +CHECKERBOARDWIPE_TRANSITION = 11; // 39 aTransitionTypeInMap = { 'barWipe' : BARWIPE_TRANSITION, @@ -4112,6 +4113,7 @@ aTransitionTypeInMap = { 'ellipseWipe' : ELLIPSEWIPE_TRANSITION, 'clockWipe' : CLOCKWIPE_TRANSITION, 'pinWheelWipe' : PINWHEELWIPE_TRANSITION, +'waterfallWipe' : WATERFALLWIPE_TRANSITION 'pushWipe' : PUSHWIPE_TRANSITION, 'slideWipe' : SLIDEWIPE_TRANSITION, 'fade' : FADE_TRANSITION, @@ -4119,7 +4121,7 @@ aTransitionTypeInMap = { }; aTransitionTypeOutMap = [ '', 'barWipe', 'boxWipe', 'fourBoxWipe', 'ellipseWipe', - 'clockWipe', 'pinWheelWipe', 'pushWipe', 'slideWipe', + 'clockWipe', 'pinWheelWipe', 'waterfallWipe', 'pushWipe', 'slideWipe', 'fade', 'checkerBoardWipe' ]; @@ -4140,7 +4142,9 @@ CLOCKWISENINE_TRANS_SUBTYPE = 12; TWOBLADEVERTICAL_TRANS_SUBTYPE = 13; TWOBLADEHORIZONTAL_TRANS_SUBTYPE= 14; FOURBLADE_TRANS_SUBTYPE = 15; // 39 -FROMLEFT_TRANS_SUBTYPE = 16; // 97 +HORIZONTALLEFT_TRANS_SUBTYPE= 30; //95 +HORIZONTALRIGHT_TRANS_SUBTYPE = 31; +FROMLEFT_TRANS_SUBTYPE = 16; FROMTOP_TRANS_SUBTYPE = 17; FROMRIGHT_TRANS_SUBTYPE = 18; FROMBOTTOM_TRANS_SUBTYPE= 19; @@ -4151,7 +4155,7 @@ FADEOVERCOLOR_TRANS_SUBTYPE = 23; THREEBLADE_TRANS_SUBTYPE= 24; EIGHTBLADE_TRANS_SUBTYPE= 25; ONEBLADE_TRANS_SUBTYPE = 26; // 107 -ACROSS_TRANS_SUBTYPE= 27; +ACROSS_TRANS_SUBTYPE= 27; redundant whitespace change aTransitionSubtypeInMap = { 'leftToRight' : LEFTTORIGHT_TRANS_SUBTYPE, @@ -4169,6 +4173,8 @@ aTransitionSubtypeInMap = { 'twoBladeVertical' : TWOBLADEVERTICAL_TRANS_SUBTYPE, 'twoBladeHorizontal': TWOBLADEHORIZONTAL_TRANS_SUBTYPE, 'fourBlade' : FOURBLADE_TRANS_SUBTYPE, +'horizontalLeft': HORIZONTALLEFT_TRANS_SUBTYPE, +'horizontalRight' : HORIZONTALRIGHT_TRANS_SUBTYPE, 'fromLeft' : FROMLEFT_TRANS_SUBTYPE, 'fromTop' : FROMTOP_TRANS_SUBTYPE, 'fromRight' : FROMRIGHT_TRANS_SUBTYPE, @@ -4187,7 +4193,7 @@ aTransitionSubtypeOutMap = [ 'default', 'leftToRight', 'topToBottom', 'cornersIn 'cornersOut', 'vertical', 'horizontal', 'down', 'circle', 'clockwiseTwelve', 'clockwiseThree', 'clockwiseSix', 'clockwiseNine', 'twoBladeVertical', 'twoBladeHorizontal', - 'fourBlade', 'fromLeft', 'fromTop', 'fromRight', + 'fourBlade', 'horizontalLeft', 'horizontalRight', 'fromLeft', 'fromTop', 'fromRight', 'fromBottom', 'crossfade', 'fadeToColor', 'fadeFromColor', 'fadeOverColor', 'threeBlade', 'eightBlade', 'oneBlade', 'across' ]; @@ -4378,6 +4384,28 @@ aTransitionInfoTable[PINWHEELWIPE_TRANSITION][TWOBLADEHORIZONTAL_TRANS_SUBTYPE] 'scaleIsotropically' : true }; +aTransitionInfoTable[WATERFALLWIPE_TRANSITION] = {}; +aTransitionInfoTable[WATERFALLWIPE_TRANSITION] [HORIZONTALLEFT_TRANS_SUBTYPE] = +{ +'class' : TRANSITION_CLIP_POLYPOLYGON, +'rotationAngle' : -90.0, +'scaleX' : 1.0, +'scaleY' : 1.0, +'reverseMethod' : REVERSEMETHOD_ROTATE_180, +
Re: OpenGL on Linux
Hey Philipp, On Sat, Feb 8, 2014 at 8:09 PM, Philipp Weissenbacher p.weissenbac...@gmail.com wrote: Bit late to the party, but here you go: http://pastie.org/8712627 System: openSUSE 13.1 Hardware: Dell Latitude D830 with a Mobile GM965/GL960 Integrated Graphics Controller Do you by chance run it in Vmware? You are only the third one reporting a 2.1 OpenGL version. Ignoring the base line we are at just yours and Krunoslav Šebetic's. Actually these two are also the ones that don't support anti-aliasing which even if we manage to support these old versions results in ugly output. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - extensions.lst
extensions.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bb5ce8a2eac6b03bfff54ffaadaeca44ff8fb398 Author: Andrea Pescetti pesce...@apache.org Date: Sun Feb 9 23:17:16 2014 + #i124127# Update English dictionary to the latest version. diff --git a/extensions.lst b/extensions.lst index ec2554b..1f53f19 100644 --- a/extensions.lst +++ b/extensions.lst @@ -39,7 +39,7 @@ # English dictionary [ language=en.* || language=de || language=it ] -3c3f841f5d40403bcc4d6bb685a38160 http://sourceforge.net/projects/aoo-extensions/files/17102/1/dict-en.oxt/download dict-en.oxt +043e3c42b1b2a20517f8069afb9cba24 http://sourceforge.net/projects/aoo-extensions/files/17102/2/dict-en-marcoagpinto-20140107.oxt/download dict-en.oxt # English (USA, en_US) dictionary [ language==nl || language==ru ] ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source
sc/qa/unit/ucalc.cxx | 25 + sc/qa/unit/ucalc.hxx |2 ++ sc/source/core/data/table1.cxx |2 +- 3 files changed, 28 insertions(+), 1 deletion(-) New commits: commit b6378a1651e7157063746d7001ef566545338bd0 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 22:10:24 2014 -0500 fdo#74323: The end position is inclusive. Change-Id: Ibd0ff19d7fd2de72a3b8d790a371da4b23df38c8 diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx index 5291ad2..b3385a3 100644 --- a/sc/source/core/data/table1.cxx +++ b/sc/source/core/data/table1.cxx @@ -1428,7 +1428,7 @@ bool ScTable::GetNextMarkedCell( SCCOL rCol, SCROW rRow, const ScMarkData rMa } } -if (nTestRow nEnd) +if (nTestRow = nEnd) { // Cell found. rRow = nTestRow; commit e041a1bfef98b54656cfaafcb0f586867a21edf1 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 21:58:55 2014 -0500 fdo#74323: Add unit test for changing cases of text cells. Change-Id: I858e18a03d97434275676e771d91bdf3209f63fb diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 83498b3..5ae240f 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -80,6 +80,8 @@ #include sstream #include vector +#include com/sun/star/i18n/TransliterationModules.hpp + struct TestImpl { ScDocShellRef m_xDocShell; @@ -5464,6 +5466,29 @@ void Test::testImportStream() m_pDoc-DeleteTab(0); } +void Test::testTransliterateText() +{ +m_pDoc-InsertTab(0, Test); + +// Set texts to A1:A3. +m_pDoc-SetString(ScAddress(0,0,0), Mike); +m_pDoc-SetString(ScAddress(0,1,0), Noah); +m_pDoc-SetString(ScAddress(0,2,0), Oscar); + +// Change them to uppercase. +ScMarkData aMark; +aMark.SetMarkArea(ScRange(0,0,0,0,2,0)); +ScDocFunc rFunc = getDocShell().GetDocFunc(); +rFunc.TransliterateText( +aMark, i18n::TransliterationModules_LOWERCASE_UPPERCASE, true, true); + +CPPUNIT_ASSERT_EQUAL(OUString(MIKE), m_pDoc-GetString(ScAddress(0,0,0))); +CPPUNIT_ASSERT_EQUAL(OUString(NOAH), m_pDoc-GetString(ScAddress(0,1,0))); +CPPUNIT_ASSERT_EQUAL(OUString(OSCAR), m_pDoc-GetString(ScAddress(0,2,0))); + +m_pDoc-DeleteTab(0); +} + void Test::testMixData() { m_pDoc-InsertTab(0, Test); diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index a32b048..64fde25 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -316,6 +316,7 @@ public: void testCondCopyPaste(); void testImportStream(); +void testTransliterateText(); void testColumnFindEditCells(); @@ -447,6 +448,7 @@ public: CPPUNIT_TEST(testCondFormatInsertCol); CPPUNIT_TEST(testCondCopyPaste); CPPUNIT_TEST(testImportStream); +CPPUNIT_TEST(testTransliterateText); CPPUNIT_TEST(testColumnFindEditCells); CPPUNIT_TEST_SUITE_END(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc.cxx | 14 ++ 1 file changed, 14 insertions(+) New commits: commit 863f1bfca71a5eb084931b49393fb7a9c5a0deaf Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Feb 9 22:17:59 2014 -0500 fdo#74323: Test the undo and redo as well. Change-Id: I5ed921290fc3f98ecd268b606c0f7ccbf9016c39 diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx index 5ae240f..fc539d9 100644 --- a/sc/qa/unit/ucalc.cxx +++ b/sc/qa/unit/ucalc.cxx @@ -5486,6 +5486,20 @@ void Test::testTransliterateText() CPPUNIT_ASSERT_EQUAL(OUString(NOAH), m_pDoc-GetString(ScAddress(0,1,0))); CPPUNIT_ASSERT_EQUAL(OUString(OSCAR), m_pDoc-GetString(ScAddress(0,2,0))); +// Test the undo and redo. +SfxUndoManager* pUndoMgr = m_pDoc-GetUndoManager(); +CPPUNIT_ASSERT_MESSAGE(Failed to get undo manager., pUndoMgr); + +pUndoMgr-Undo(); +CPPUNIT_ASSERT_EQUAL(OUString(Mike), m_pDoc-GetString(ScAddress(0,0,0))); +CPPUNIT_ASSERT_EQUAL(OUString(Noah), m_pDoc-GetString(ScAddress(0,1,0))); +CPPUNIT_ASSERT_EQUAL(OUString(Oscar), m_pDoc-GetString(ScAddress(0,2,0))); + +pUndoMgr-Redo(); +CPPUNIT_ASSERT_EQUAL(OUString(MIKE), m_pDoc-GetString(ScAddress(0,0,0))); +CPPUNIT_ASSERT_EQUAL(OUString(NOAH), m_pDoc-GetString(ScAddress(0,1,0))); +CPPUNIT_ASSERT_EQUAL(OUString(OSCAR), m_pDoc-GetString(ScAddress(0,2,0))); + m_pDoc-DeleteTab(0); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Gerrit News for core on 2014-02-10
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + Bug #63962 Dynamically scan the config directory for icon themes in https://gerrit.libreoffice.org/7935 from Tobias Lippert about module cui, framework, include, sfx2, svtools, vcl + Replace handwritten reference counting with stl shared_ptr in https://gerrit.libreoffice.org/7934 from Tobias Lippert about module include, vcl + Remove vcl/settings.hxx from vcl/svapp.hxx and vcl/outdev.hxx in https://gerrit.libreoffice.org/7933 from Tobias Lippert about module accessibility, avmedia, basctl, basic, chart2, cui, dbaccess, desktop, drawinglayer, editeng, extensions, filter, forms, formula, fpicker, framework, include, oox, padmin, reportdesign, sc, scripting, sd, sdext, sfx2, slideshow, starmath, svtools, svx, sw, toolkit, uui, vcl, writerfilter, xmlsecurity End of freshness + fdo#74115 Fix for DOCX GradientFill for Chart Wall in https://gerrit.libreoffice.org/7739 from Vinaya Mandke about module chart2, include, oox + related fdo#65430: forgot to 'unlink' setOpenTemplateHdl in https://gerrit.libreoffice.org/7958 from Joren De Cuyper about module sfx2 + fdo#70414 Added generator of VS2012 project files in https://gerrit.libreoffice.org/7955 from Honza Havlíček about module bin, build + Remove unused icons after cleaning up Math zoom in https://gerrit.libreoffice.org/4117 from Rodolfo Ribeiro Gomes about module icon-themes + fix Wshadow warnings in glm in https://gerrit.libreoffice.org/7952 from Markus Mohrhard about module external + Translated German comments in https://gerrit.libreoffice.org/7951 from Luc Castermans about module vcl + Changes to IsClipRegion and ImplIsAntiparallel in https://gerrit.libreoffice.org/7949 from Chris Sherlock about module editeng, include, vcl + fdo#74424 Move ReMirror into wrapper functions in https://gerrit.libreoffice.org/7943 from Chris Sherlock about module include, vcl + fdo#74424 HasMirroredGraphics changes in https://gerrit.libreoffice.org/7912 from Chris Sherlock about module include, vcl * Merged changes on master for project core changed in the last 25 hours: + Translated German comments - polygon and matrix calculations in https://gerrit.libreoffice.org/7950 from Luc Castermans * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#50763: handle inlined base64 images in https://gerrit.libreoffice.org/7773 from Christina Roßmanith + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + sa/l add release_assert() and assert that stay even in release code in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud + fdo#69407: On transparent frames, shadows are painted in foreground. in https://gerrit.libreoffice.org/7070 from Mohamed-Ali BEN MANSOUR + add a header to provide posix compatible wrapper for platform lacking in https://gerrit.libreoffice.org/6837 from Norbert Thiebaud + upgrade liborcus in https://gerrit.libreoffice.org/7310 from Markus Mohrhard + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + Export CoreText-related SPI stuff in https://gerrit.libreoffice.org/7143 from Douglas Mencken + fdo#60698: Merge animcore into sd and slideshow in https://gerrit.libreoffice.org/7108 from Marcos Souza + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + Code clean-up/consolidation task. in https://gerrit.libreoffice.org/5926 from Vishv Brahmbhatt + fix for exporting of text watermark to DOCX in https://gerrit.libreoffice.org/5568 from Adam CloudOn + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt + fdo#71043 - Use STACK lint tool to clean code in https://gerrit.libreoffice.org/6529 from José Guilherme Vanz + Increase number of remembered recent documents from 10 to 25 in https://gerrit.libreoffice.org/6101 from Krisztian Pinter + startcenter: Make SC open faster by timeouting thumbnails in https://gerrit.libreoffice.org/6102 from Krisztian Pinter + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + fdo#36791 : fix for import of greeting card in https://gerrit.libreoffice.org/4240 from Adam CloudOn + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list
[Libreoffice-commits] core.git: editeng/source
editeng/source/outliner/outlvw.cxx | 26 ++ 1 file changed, 26 insertions(+) New commits: commit 49341001e76389f11bf67d756f4742275bc9dcd9 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Feb 10 01:26:35 2014 -0500 fdo#46707: Don't bother with synonyms for text with mixed script types. Change-Id: I7922905523406d05f864b10e1ecfd27f3fb5f9d6 diff --git a/editeng/source/outliner/outlvw.cxx b/editeng/source/outliner/outlvw.cxx index 6defd32..1b94561 100644 --- a/editeng/source/outliner/outlvw.cxx +++ b/editeng/source/outliner/outlvw.cxx @@ -29,6 +29,7 @@ #include editeng/fhgtitem.hxx #include svl/style.hxx +#include svl/languageoptions.hxx #include i18nlangtag/languagetag.hxx #include editeng/outliner.hxx @@ -1446,6 +1447,27 @@ Selection OutlinerView::GetSurroundingTextSelection() const // = some code for thesaurus sub menu within context menu // == +namespace { + +bool isSingleScriptType( sal_uInt16 nScriptType ) +{ +sal_uInt8 nScriptCount = 0; + +if (nScriptType SCRIPTTYPE_LATIN) +++nScriptCount; +if (nScriptType SCRIPTTYPE_ASIAN) +++nScriptCount; +if (nScriptType SCRIPTTYPE_COMPLEX) +++nScriptCount; + +if (!nScriptCount || nScriptCount 1) +return false; + +return true; +} + +} + // returns: true if a word for thesaurus look-up was found at the current cursor position. // The status string will be word + iso language string (e.g. light#en-US) bool EDITENG_DLLPUBLIC GetStatusValueForThesaurusFromContext( @@ -1461,6 +1483,10 @@ bool EDITENG_DLLPUBLIC GetStatusValueForThesaurusFromContext( aTextSel = pEditEngine-GetWord( aTextSel, i18n::WordType::DICTIONARY_WORD ); aText = pEditEngine-GetText( aTextSel ); aTextSel.Adjust(); + +if (!isSingleScriptType(pEditEngine-GetScriptType(aTextSel))) +return false; + LanguageType nLang = pEditEngine-GetLanguage( aTextSel.nStartPara, aTextSel.nStartPos ); OUString aLangText( LanguageTag::convertToBcp47( nLang ) ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/outliner/outlvw.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 5d4e4f30480016bd1ae0d5dcd2f34f3c74d5a172 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Feb 10 01:31:35 2014 -0500 A little simpler. Change-Id: I684317003a7afee4154fe39098ced7ba27bdff2f diff --git a/editeng/source/outliner/outlvw.cxx b/editeng/source/outliner/outlvw.cxx index 1b94561..c6add09 100644 --- a/editeng/source/outliner/outlvw.cxx +++ b/editeng/source/outliner/outlvw.cxx @@ -1460,10 +1460,7 @@ bool isSingleScriptType( sal_uInt16 nScriptType ) if (nScriptType SCRIPTTYPE_COMPLEX) ++nScriptCount; -if (!nScriptCount || nScriptCount 1) -return false; - -return true; +return nScriptCount == 1; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/sw3io/sw3convert.cxx |3 --- 1 file changed, 3 deletions(-) New commits: commit 3df1b8927a485192c55daf087449c00f505f6e5d Author: Takeshi Abe t...@fixedpoint.jp Date: Mon Feb 10 15:43:42 2014 +0900 Drop unused headers Change-Id: I71b036ff0683307e7a2676e09c90d5a95667d599 diff --git a/sw/source/core/sw3io/sw3convert.cxx b/sw/source/core/sw3io/sw3convert.cxx index 16e1e34..ad53dc4 100644 --- a/sw/source/core/sw3io/sw3convert.cxx +++ b/sw/source/core/sw3io/sw3convert.cxx @@ -17,9 +17,6 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#include stdlib.h - -#include stdio.h #include hintids.hxx #include tools/resid.hxx #include svl/macitem.hxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] fdo#61320: Allow user to choose whether to create thumbnails
Hello developers, this is my first LO patch for review. It enhances LibreOffice by making the thumbnail creation inside odf archive files optional. In some cases users might not want to have a thumbnail included inside their document, because they need the file to be as small as possible. I have added a new save option to the Options dialog under section Load/Save General, whose name might still get improved possibly, so far it is not translated into other languages: Include a thumbnail image. Maybe it should better be Include a thumbnail image for preview and also make it clear, that this only applies to odf documents, not alien formats. -- Mit freundlichen Grüßen/best regards Christian Junker 0001-fdo-61320-make_thumbnail_optional.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 74377] UI: Add keyboard shortcuts to cell context menu in Calc
https://bugs.freedesktop.org/show_bug.cgi?id=74377 dg1727 dg1...@hushmail.com changed: What|Removed |Added Severity|normal |enhancement --- Comment #6 from dg1727 dg1...@hushmail.com --- (In reply to comment #5) Many applications explicitly expose their keyboard shortcuts to “everything”, including in their context menus. Such exposure helps users in their learning curve. Helping users in their learning curve is valuable to the LibreOffice project, which has limited ability to train users individually and has to make complex software usable by people who are minimally computer-literate. People who have difficulty using the mouse (I've seen such people who are generally not disabled or impaired except that they normally use a laptop and have trouble with its touchpad) will tend to use the right-click context menu a lot more than going to the main menu and choosing Edit. These people would benefit from having keyboard shortcuts brought to their attention in the context menu. is this request so much [more] important than others, that it deserves the valuable time of LO developers? I submitted a number of enhancement requests without realizing that I should set the severity to enhancement. This has been fixed with this bug, and the updated severity should take care of Ady's concern here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74720] Missing dialog title (server I/O)
https://bugs.freedesktop.org/show_bug.cgi?id=74720 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Attachment #93674|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74722] Draw crashes immediately
https://bugs.freedesktop.org/show_bug.cgi?id=74722 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- A. Kusch: do you reproduce this problem after having renamed your LO directory profile? (see https://wiki.documentfoundation.org/UserProfile) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72144] Calc Chart: Export as Graphic... creates empty .svg file
https://bugs.freedesktop.org/show_bug.cgi?id=72144 Martin Trautmann tr...@gmx.de changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #5 from Martin Trautmann tr...@gmx.de --- 4.2 now does export a .svg with a reasonable size, although it's not valid svg. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74736] New: calc exports chart as invalid svg
https://bugs.freedesktop.org/show_bug.cgi?id=74736 Priority: medium Bug ID: 74736 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: calc exports chart as invalid svg Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: tr...@gmx.de Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.2.0.4 release Component: Chart Product: LibreOffice Created attachment 93695 -- https://bugs.freedesktop.org/attachment.cgi?id=93695action=edit chart for wikipedia As a followup of Bug 72144: With 4.0 an empty svg was exported. Now, with 4.2, a reasonable content was created. However, the svg is considered as invalid code. What's wrong about the syntax? The major difference I see is some better looking text wrapping. Firefox complaints: This XML file does not appear to have any style information associated with it. Wikimedia complaints: Invalid SVG file: Expected svg tag, got svg in NS ) As a side note: text within the graphics disappeared from an .ods file when changing form 4.0 to 4.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43459] Opening document fails when on samba mount with mixed OS windows/linux
https://bugs.freedesktop.org/show_bug.cgi?id=43459 dg1727 dg1...@hushmail.com changed: What|Removed |Added CC||mviv...@gmail.com --- Comment #2 from dg1727 dg1...@hushmail.com --- *** Bug 48171 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48171] FILEOPEN: Don't warning about opening read-only documents
https://bugs.freedesktop.org/show_bug.cgi?id=48171 dg1727 dg1...@hushmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from dg1727 dg1...@hushmail.com --- *** This bug has been marked as a duplicate of bug 43459 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74736] calc exports chart as invalid svg
https://bugs.freedesktop.org/show_bug.cgi?id=74736 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Attachment #93695|text/plain |image/svg+xml mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74737] New: UI: In FILEOPEN dialogs, make it easier to open files read-only
https://bugs.freedesktop.org/show_bug.cgi?id=74737 Priority: medium Bug ID: 74737 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: In FILEOPEN dialogs, make it easier to open files read-only Severity: enhancement Classification: Unclassified OS: All Reporter: dg1...@hushmail.com Hardware: All Status: NEW Version: 4.1.4.2 release Component: UI Product: LibreOffice Currently, the file-open dialogs (regardless of whether Tools Options... LibreOffice General Use LibreOffice dialogs is enabled) have a checkbox for Read-only in the lower-left corner. The Open button is in the lower-right corner. This makes it un-ergonomic to open a file read-only. There are situations when a person often opens files read-only. For example: When a document is opened read/write by LO, a lock file is written next to the document; when the document is closed, the lock file is removed. This causes the filesystem to update the directory's modification time to when the lock file was removed. This can cause some backup algorithms to detect that the directory has been changed since the last backup and to back up the whole directory even though no changes have been made. This can be undesirable when backing up to a USB thumb drive, due to the comparatively small write lifetime low speed of the drive. So the user may get used to opening files read-only to avoid making the unneeded lock files. Another case is that the user frequently gets files by e-mail and wants to be able to open them read-only before bothering to set the files read-only at the filesystem level. Please consider enhancing the file-open dialogs to make it easier to open files read-only. One way to do this would be to change the Open button to a split button with an Open read-only option. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74558] Defect with the VLOOKUP function
https://bugs.freedesktop.org/show_bug.cgi?id=74558 --- Comment #2 from Josir Gomes josir...@gmail.com --- Created attachment 93696 -- https://bugs.freedesktop.org/attachment.cgi?id=93696action=edit Another example showing VLOOKUP error VLOOKUP stops to work after upgrading Using portuguese version Version 4.2.0.4 ID de compilação: 420m0(Build:4) Ubuntu/Libreoffice installed from ppa-repository. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42815] core dump in a crypto function
https://bugs.freedesktop.org/show_bug.cgi?id=42815 Toralf Förster toralf.foers...@gmx.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #2 from Toralf Förster toralf.foers...@gmx.de --- (In reply to comment #1) Hi Toralf, don't suppose you were able to compile with debug symbols? Has this ever been a problem since? No - with newer versions I did not experienced it again (and in the mean while I do use the -bin package from the Gentoo maintainer due to the looong compile time) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74738] New: Other: cannot copy + paste text from writer to mozilla thunderbird
https://bugs.freedesktop.org/show_bug.cgi?id=74738 Priority: medium Bug ID: 74738 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: cannot copy + paste text from writer to mozilla thunderbird Severity: normal Classification: Unclassified OS: Windows (All) Reporter: maartje2...@gmail.com Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.2.0.4 release Component: Writer Product: LibreOffice Since the latest release (LO 4.2.0.4)i am not able to copy paste (a text written in Writer)to mozilla thunderbird (and see it in message itself). In Libreoffice 4.1 this worked fine. Note: it is still possible to send message from within Libreoffice and then thunderbird opens and is see text as attached document. This is not my intention. I want to copy + paste text in thunderbirds message windowitself. Maarten Operating System: Windows 7 Version: 4.2.0.4 release Last worked in: 4.1.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74739] New: UI: Consider removing Paste Only from ToolsCustomizeKeyboardEdit
https://bugs.freedesktop.org/show_bug.cgi?id=74739 Priority: medium Bug ID: 74739 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: Consider removing Paste Only from ToolsCustomizeKeyboardEdit Severity: enhancement Classification: Unclassified OS: All Reporter: dg1...@hushmail.com Hardware: All Status: UNCONFIRMED Version: 4.1.4.2 release Component: Spreadsheet Product: LibreOffice In Tools Customize... Keyboard tab Category list Edit, in the Function list, there is an entry Paste Only. About Paste Only, it has been said [1]: It may have some use in macro code, but probably not as a key binding. Can this be confirmed, and if this function isn't usable as a keybinding, can it be removed from the Keyboard tab? This function appears to occur in the source code in [2] and [3]. [1] http://ask.libreoffice.org/en/question/29459/in-calc-what-is-the-paste-only-function-tools-customize/#post-id-29464 [2] http://opengrok.libreoffice.org/xref/core/sc/source/ui/src/popup.src#141 [3] http://opengrok.libreoffice.org/xref/core/sfx2/sdi/sfx.sdi#4727 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74740] New: UI: Consider rewording Paste Only Value to Paste Only Numbers
https://bugs.freedesktop.org/show_bug.cgi?id=74740 Priority: medium Bug ID: 74740 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: Consider rewording Paste Only Value to Paste Only Numbers Severity: enhancement Classification: Unclassified OS: All Reporter: dg1...@hushmail.com Hardware: All Status: UNCONFIRMED Version: 4.1.4.2 release Component: Spreadsheet Product: LibreOffice In Calc, in Tools Customize... Keyboard tab Category list Edit, in the Function list, there is an entry Paste Only Value. About Paste Only Value, it has been said [1]: Paste Only Value equates to selecting Numbers in the Paste Special... dialog, which is not very clear to me either. I think a value can be either a string or a number. This was illustrated in [2], in which the column Value/Number, rows UNO function, shows the results of this Paste Only Value keybinding. Numbers are pasted, but strings and dates are not. Can rewording Paste Only Value to Paste Only Numbers, for consistency, be considered? [1] http://ask.libreoffice.org/en/question/29459/in-calc-what-is-the-paste-only-function-tools-customize/#comment-29471 [2] http://ask.libreoffice.org/upfiles/1391678018378366.png -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74709] cell border padding (clpad*) is ignored on RTF import
https://bugs.freedesktop.org/show_bug.cgi?id=74709 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | Summary|cell border padding |cell border padding |(clpad*) and table row |(clpad*) is ignored on RTF |padding(trpadd*) are|import |ignored on RTF import | Ever confirmed|0 |1 --- Comment #1 from Miklos Vajna vmik...@collabora.co.uk --- Thanks, the bugdoc is a good reproducer for the clpad* RTF control words. I'll just adjust the summary to talk about those. Indeed trpadd* is also ignored on import, however it would be nice to have a reproducer document for that as well. Could you please open a separate bug for that? :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74738] Other: cannot copy + paste text from writer to mozilla thunderbird
https://bugs.freedesktop.org/show_bug.cgi?id=74738 A stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A stgohi-lob...@yahoo.de --- reproducible with LO 4.2.0.4 (Win8.1) It is not possible to copy text from WRITER to a Thunderbird email. From IMPRESS and CALC this works fine. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74743] New: Impress systematically freezes when trying to open a file
https://bugs.freedesktop.org/show_bug.cgi?id=74743 Priority: medium Bug ID: 74743 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Impress systematically freezes when trying to open a file Severity: blocker Classification: Unclassified OS: Windows (All) Reporter: pincopall...@orange.fr Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.2.0.4 release Component: Presentation Product: LibreOffice I have a 35 Mb .odp file produced with LO 4.1.4. After upgrading to 4.2.0.4, no way to open it: Impress freezes at about 50% of Load Document. I have uninstalled 4.2.0.4 and reinstalled 4.1.4: everything works fine again. I can provide the file on request, I do not think it is possible to upload a 35 Mb file here and in any case I would not like to have it available to the whole planet Earth. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74736] calc exports chart as invalid svg
https://bugs.freedesktop.org/show_bug.cgi?id=74736 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- reproducible with LO 4.2.0.4 (Win 8.1) Steps done: 1. Open CALC 2. Create a simple chart 3. Select the chart and make a right mouse click and select EXPORT AS IMAGE 4. Save it as a SVG file 5. Open it with Firefox, Internet Explorer and LO DRAW Results: Internet Explorer opens the file but shows no chart only data. Firefox does not open the file and shows This XML file does not appear to have any style information associated with it. DRAW opens the file and shows the chart, but without title, axes labeling and legend. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74736] calc exports chart as invalid svg
https://bugs.freedesktop.org/show_bug.cgi?id=74736 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added OS|Mac OS X (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74744] New: Other: Publish Date 'docProperty' from word docx not-showing/missing when opened in writer
https://bugs.freedesktop.org/show_bug.cgi?id=74744 Priority: medium Bug ID: 74744 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: Publish Date 'docProperty' from word docx not-showing/missing when opened in writer Severity: normal Classification: Unclassified OS: Windows (All) Reporter: scbic...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.0.4 release Component: Writer Product: LibreOffice Created attachment 93705 -- https://bugs.freedesktop.org/attachment.cgi?id=93705action=edit A word document with a publish date set to 09/02/2014 (UK date format) Problem description: Word docx document imported in Writer. The 'Publish Date' document property does not display Steps to reproduce: 1. In Word 2010 create a document. 2. Set the 'Publish Date' document property. 3. On a page in the document insert the property 4. Save the document in the default docx format 5. Close Word 6. Open the document with Writer Current behavior: The 'Publish Date' field shows as blank selection control, on mouse over the date appears as a pop-up prompt. On export to pdf it appears as a blank editable field. On print it appears as a blank box outline, where the field should display. Expected behavior: The 'Publish Date' field value should show: on screen during viewing or editing, in the pdf export, in the printed document. Operating System: Windows 7 Version: 4.2.0.4 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44931] EDITING, FILEOPEN: cross-referencing HEADINGS in a sub-document from master-document fails
https://bugs.freedesktop.org/show_bug.cgi?id=44931 --- Comment #2 from Owen Genat owen.ge...@gmail.com --- I think this is merely a clearer description of the workaround indicated in comment 1 (although I am not certain). Added for clarity, in any case: 1. In the sub-document, at the required location (or highlighting the required range), Insert Cross-reference... Cross-references tab Type of Set reference / Bookmarks enter a meaningful Name click Insert. 2. In the master document, Insert Cross-reference... Cross-references tab Type of Insert reference / Bookmarks select the required mark click Insert. It may be that the current problem highlighted by this bug is actually a limitation of ODF. The ODF v1.2 specification is not very clear about how inter-document citations (of headings, bookmarks, or reference mark) are to be treated. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74706] FORMCONTROLS: bug with mouse command
https://bugs.freedesktop.org/show_bug.cgi?id=74706 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- not reproducible with LO 4.2.0.4 (Win 8.1) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74744] Other: Publish Date 'docProperty' from word docx not-showing/missing when opened in writer
https://bugs.freedesktop.org/show_bug.cgi?id=74744 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added OS|Windows (All) |All Status|UNCONFIRMED |NEW CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated yesterday, I can reproduce this. However if I put the cursor on the control, the date appears as tip text I noticed these console logs: warn:legacy.osl:10498:1:oox/source/docprop/docprophandler.cxx:323: For now unexpected tags are ignored! warn:legacy.osl:10498:1:oox/source/docprop/docprophandler.cxx:323: For now unexpected tags are ignored! warn:legacy.osl:10498:1:oox/source/docprop/docprophandler.cxx:323: For now unexpected tags are ignored! warn:legacy.osl:10498:1:oox/source/docprop/docprophandler.cxx:323: For now unexpected tags are ignored! warn:legacy.osl:10498:1:oox/source/docprop/docprophandler.cxx:323: For now unexpected tags are ignored! warn:writerfilter:10498:1:writerfilter/source/dmapper/FontTable.cxx:147: FontTable::lcl_sprm: unhandled token: 92949 warn:writerfilter:10498:1:writerfilter/source/dmapper/StyleSheetTable.cxx:1157: Some style properties could not be set: Unknown property: CharShadingValue warn:writerfilter:10498:1:writerfilter/source/dmapper/StyleSheetTable.cxx:1157: Some style properties could not be set: Unknown property: ParaInteropGrabBag warn:svl:10498:1:svl/source/items/style.cxx:256: StyleSheet-Follow not found warn:writerfilter:10498:1:writerfilter/source/dmapper/DomainMapper.cxx:2559: unhandled w:dateFormat value warn:legacy.osl:10498:1:oox/source/helper/storagebase.cxx:71: StorageBase::StorageBase - missing base input stream -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44931] EDITING, FILEOPEN: cross-referencing HEADINGS in a sub-document from master-document fails
https://bugs.freedesktop.org/show_bug.cgi?id=44931 Owen Genat owen.ge...@gmail.com changed: What|Removed |Added OS|Windows (All) |All --- Comment #3 from Owen Genat owen.ge...@gmail.com --- I forgot to mention that the provided examples still fail under: - Debian 7.3.0 x86_64 using v4.1.4.2 Build ID: 0a0440ccc0227ad9829de5f46be37cfb6edcf72 - Crunchbang 11 x86_64 using v4.2.0.4 Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71 OS set to All. The Writer Guide v4.0, Ch. 13, pp. 377-380, does however mention that this type of cross-reference between documents requires a reference mark to be set at the anchor point, so it may even be that this particular case is not a bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40176] Show special paste options when needed
https://bugs.freedesktop.org/show_bug.cgi?id=40176 --- Comment #14 from dg1727 dg1...@hushmail.com --- I can reproduce the issue (using steps in comment 9) on LO 4.1.4.2 on Ubuntu. I believe the point of comment 13 is that the issue isn't reproducible on Windows, not that the issue isn't reproducible at all. (The previous commenters were fairly clear about this, but I wanted to clarify a bit further.) I agree with the suggested solutions in comment 0. (Apparently mrkazoo...@gmail.com and philip_hofl...@hotmail.com are the same person, per comment 11 and comment 3.) I searched in the source code: The symbol for the error message in question is MSG_CLPBRD_FORMAT_ERROR It appears in http://opengrok.libreoffice.org/xref/core/sw/source/ui/dochdl/swdtflvr.cxx in methods _PasteFileContent (twice) _PasteDBData _PasteFileList -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74694] EDITING: Odd right aligned 1st page, then left page 2
https://bugs.freedesktop.org/show_bug.cgi?id=74694 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- In my point of view this is no bug. Your reported view happens if you have only two pages and switch to the book mode view. If you insert a third page then you will see and recognize this book mode view. In the book mode view layout you see two pages side by side as in an open book. The first page is a right page with an odd page number and therefore you see it right aligned. How to change it? Go to the right part of the LO status bar at the bottom. There you see three page view layouts (from the left): single page, two pages and book mode. Select here the single page view. Does this solve your question? If yes, then I would propose to close this issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74686] PDF: Export to PDF
https://bugs.freedesktop.org/show_bug.cgi?id=74686 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- reproducible with LO 4.2.0.4 (Win 8.1) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74745] New: Word custom document property with date type does not show as a date
https://bugs.freedesktop.org/show_bug.cgi?id=74745 Priority: medium Bug ID: 74745 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Word custom document property with date type does not show as a date Severity: normal Classification: Unclassified OS: Windows (All) Reporter: scbic...@gmail.com Hardware: Other Status: UNCONFIRMED Version: 4.2.0.4 release Component: Writer Product: LibreOffice Created attachment 93706 -- https://bugs.freedesktop.org/attachment.cgi?id=93706action=edit Example Word document with custom date document property Problem description: A custom date field defined in a document using MS Word 2010 and saved as docx, when opened in Writer fails to show as a date. Steps to reproduce: 1. In MS Word 2010 create a document 2. Create a custom document property set the type to date and set a value 3. Insert the custom date property on the document page 4. Save the document with as a docx close Word 5. Open the document in Writer Current behavior: The date property displays as '41679' Expected behavior: The date field should display as the date entered originally -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62672] Default data type of the Paste function needs to be configurable
https://bugs.freedesktop.org/show_bug.cgi?id=62672 dg1727 dg1...@hushmail.com changed: What|Removed |Added Summary|Paste special - order of|Default data type of the |options needs to be |Paste function needs to be |configurable|configurable --- Comment #7 from dg1727 dg1...@hushmail.com --- I have updated the bug summary to try to reflect the submitter's intention more accurately, as indicated in comment 2 and comment 0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 --- Comment #3 from dan boec0...@gmail.com --- you are correct, that does appear to be the same issue. i really hope this was indeed solved because right now it is pretty painful using calc. i know this spreadsheet is large but it is not that large. thanks for the help. i will put 4.2 on when i can. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74691] Other: Using mouse scrollwheel to change object properties does not work
https://bugs.freedesktop.org/show_bug.cgi?id=74691 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- I am not sure if I understand this right. If I insert e.g. a rectangle shape in IMPRESS and then go to the toolbar at the top to change the area style / filing of this rectangle then I can scroll up and down with the mouse wheel, but it does not change the color. This is only to move up and down. To change the color you have to select the color (by clicking on the color). I think this is correct. It should not change immediately the color. It should change the color only after explicity selecting the color. For instance, if I want to preserve the selected color and only want to look for another color, then scrolling up and down should not change the color, otherwise if I find no better color then I have to search for the previous selected color. Did I understand your issue right? Another question: Why is your screenshot showing no color name for the line color? In my LO this color name is shown correctly. LO 4.2.0.4 (Win 8.1) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74536] Macros: Error Message by Executing Macro after File Editing
https://bugs.freedesktop.org/show_bug.cgi?id=74536 --- Comment #3 from Chris Sherlock chris.sherloc...@gmail.com --- Not happening for me... do you have a debug build? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74731] Help font on OSX very large
https://bugs.freedesktop.org/show_bug.cgi?id=74731 Foss f...@openmailbox.org changed: What|Removed |Added CC||heinzless...@gmail.com --- Comment #1 from Foss f...@openmailbox.org --- I think font size is fine. Not sure if this is indeed a bug. cc: Astron for some design feedback perspective on this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74536] Macros: Error Message by Executing Macro after File Editing
https://bugs.freedesktop.org/show_bug.cgi?id=74536 --- Comment #4 from Chris Sherlock chris.sherloc...@gmail.com --- I must be missing something. Can you literally give me a step-by-step of what you are doing? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74746] New: FILEOPEN: different content right/left in footer is not opened correctly
https://bugs.freedesktop.org/show_bug.cgi?id=74746 Priority: medium Bug ID: 74746 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILEOPEN: different content right/left in footer is not opened correctly Severity: normal Classification: Unclassified OS: All Reporter: ku...@libreoffice.org Hardware: All Status: UNCONFIRMED Version: 4.1.4.2 release Component: Writer Product: LibreOffice Created attachment 93708 -- https://bugs.freedesktop.org/attachment.cgi?id=93708action=edit test document with different footer for right/left - try open with LibO 4.1 or LibO 4.0 vs. LibO 4.2 or LibO 3.6 If you have a file with a footer with different content right/left, it is not opened correctly within LibO 4.1 (tested with 4.1.4.2) and LibO 4.0 (4.0.6.2). The footer is here the same at right/left pages. Within LibO 4.2 (4.2.0.4) and LibO 3.6 (3.6.7.2) the document is opened correctly. This bug only occurs, if the document has a footer but no header. It don't occurs, if the document has a footer and a header, and also don't, if the document only has a header but no footer. You also can save a document with LibO 4.1 or LibO 4.0, and open this within LibO 3.6 or LibO 4.2 correctly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 --- Comment #4 from dan boec0...@gmail.com --- i installed 4.2 and it did not fix the issue. it is just as bad as it was before. what it seems to be doing is it freezes after you put something into a cell. so i type say 2, hit tab or enter for the next cell. it freezes for a bit, many seconds, upto 30 or more as i have seen, and then it does the calcs and moves to the next cell. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 53360] : Conditional Spacing between paragraphs
https://bugs.freedesktop.org/show_bug.cgi?id=53360 --- Comment #26 from João Mac-Cormick joao.corm...@sisejuferj.org.br --- (In reply to comment #25) Bug is solved in version 4.2. Obrigado Marcos pelos testes na 4.2.0. Atualizarei a wiki 3.6. João Mac-Cormick -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59506] FORMATTING: Formatting toolbar has missing icons when editing text inside a textbox.
https://bugs.freedesktop.org/show_bug.cgi?id=59506 --- Comment #12 from Maxim Monastirsky momonas...@gmail.com --- (In reply to comment #11) Any chance you know why I now have text instead of icons on my toolbar now? Go to Tools-Options...-Toolbars, and select the affected toolbar from the drop-down list. Then click on the 'Toolbar' button, and choose the appropriate status (Icons only/Icons Text). Hope this helps. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74731] Help font on OSX very large
https://bugs.freedesktop.org/show_bug.cgi?id=74731 --- Comment #2 from mi...@filmsi.net --- I do not think it is fine. Compared to built-in OS X help, as well as to Microsoft Office on OS X help this is an enormous font size. Displaying only 13 lines of help text means a lot of unwanted scrolling thus making it really user unfriendly. It's just bad UX, not a feature (this could only be a feature for users of accessibility tools for visually impaired people that need larger fonts). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74279] FILEOPEN: Presentation crashes while opening
https://bugs.freedesktop.org/show_bug.cgi?id=74279 --- Comment #5 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- (In reply to comment #4) [...] I maybe wasn't precise enough : the only bugged version is 4.2.0.4 rc. So you should try with the first RC of version 4.2.1 when it will be available. Note: version 4.2.1.0.0+ is the development version of branch 4.2. The master will give the next branch 4.3. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74731] Help font on OSX very large
https://bugs.freedesktop.org/show_bug.cgi?id=74731 --- Comment #3 from Foss f...@openmailbox.org --- Created attachment 93709 -- https://bugs.freedesktop.org/attachment.cgi?id=93709action=edit word and lo help comparison osx -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74731] Help font on OSX very large
https://bugs.freedesktop.org/show_bug.cgi?id=74731 Foss f...@openmailbox.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #4 from Foss f...@openmailbox.org --- You def got a point. Added comparison of Word and LO help. NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72919] Other: UNO-API PDF Mass Export breaks layout
https://bugs.freedesktop.org/show_bug.cgi?id=72919 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Set back status to UNCONFIRMED. Can't test further because I do not have Eclipse installed and I do not want install it. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74743] Impress systematically freezes when trying to open a file
https://bugs.freedesktop.org/show_bug.cgi?id=74743 --- Comment #1 from Foss f...@openmailbox.org --- Hm having the file would be crucial. Can you replace sensitive information and try to upload the file on some dropbox or other hosting service? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74287] No color selectable for scatter chart points if there is no line
https://bugs.freedesktop.org/show_bug.cgi?id=74287 --- Comment #1 from Francisco franciscoadriansanc...@gmail.com --- Not reproducible under Windows 7, x86 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74747] New: FILESAVE corrupts references to cells on another sheet
https://bugs.freedesktop.org/show_bug.cgi?id=74747 Priority: medium Bug ID: 74747 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE corrupts references to cells on another sheet Severity: normal Classification: Unclassified OS: Windows (All) Reporter: scbic...@gmail.com Hardware: x86-64 (AMD64) Status: NEW Version: 4.2.0.4 release Component: Spreadsheet Product: LibreOffice Problem description: Sheet references are broken when a document created in Excel as xlsx is opened and subsequently re-saved as an xlsx using Calc. If the document is opened and saved in calc then subsequently opened in Calc the referenced text appears as 0. Opening the file in Excel the text shows correctly, saving the file from Excel fixes the problem. Steps to reproduce: 1. Create a new spreadsheet in Excel 2010 2. Enter 'Example text' in cell a1 on sheet 1 3. On sheet 2 in cell b1 enter a reference to sheet 1 a1 4. save the sheet as docx and close Excel 5. Open the sheet in Calc. The cell sheet 2 b1 shows the expected text. 6. Make a change to another cell so that the sheet has changed 7. click the save button 8. click the 'Use Microsoft Excel 2007/2010/2013 XML Format' 9. close the Calc application 10. Open the file again in Calc 11. Observer the presented value in sheet 2 cell b1. Current behavior: After opening the re-saved sheet in calc the referenced text in b1 appears as '0' Expected behavior: The referenced text should appear in cell b1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74479] CALC problem counting weekdays with sumproduct. Only Saturdays are not counted correctly when the selection contains empty cells or no date. SUMPRODUCT() result error wi
https://bugs.freedesktop.org/show_bug.cgi?id=74479 Kohei Yoshida libreoff...@kohei.us changed: What|Removed |Added CC||karloofo...@arcor.de --- Comment #9 from Kohei Yoshida libreoff...@kohei.us --- *** Bug 74677 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74677] empty Cells in SUMPRODOCT(...) are evaluated as 1
https://bugs.freedesktop.org/show_bug.cgi?id=74677 Kohei Yoshida libreoff...@kohei.us changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Kohei Yoshida libreoff...@kohei.us --- *** This bug has been marked as a duplicate of bug 74479 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74653] Other: impress search crash
https://bugs.freedesktop.org/show_bug.cgi?id=74653 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with 4.2 sources updated some days ago, I don't reproduce this on a brand new file. bcag2: did you install any LO specific extension? For the test, could you give a try after having renamed your LO directory profile (see https://wiki.documentfoundation.org/UserProfile)? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74747] FILESAVE corrupts references to cells on another sheet
https://bugs.freedesktop.org/show_bug.cgi?id=74747 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- Could you attach the xlsx file for those who, like me, don't have MsOffice? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 --- Comment #5 from mariosv mari...@miguelangel.mobi --- Please reopen the bug and try to explain as detailed as possible how to reproduce it, a sample file could be helpful. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36943] UI: Toolbar Edit Points not available
https://bugs.freedesktop.org/show_bug.cgi?id=36943 --- Comment #13 from Rachit Gupta rachitgupta1...@gmail.com --- I wish to work on this bug. Can someone tell me where to look for the code for the Drawing Toolbar in Writer as well as Calc? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74747] FILESAVE corrupts references to cells on another sheet
https://bugs.freedesktop.org/show_bug.cgi?id=74747 --- Comment #2 from Steve Bickle scbic...@gmail.com --- Having inspected the XML for the cell with a reference from both the original save in Excel and the subsequent save in Calc, this is what I've found: Original Excel file: row r=1 spans=2:2 x14ac:dyDescent=0.25 c r=B1 t=str fSheet1!A1/f vExample text/v /c /row From the Calc save: row r=1 customFormat=false ht=15 hidden=false customHeight=false outlineLevel=0 collapsed=false c r=B1 s=0 t=n f aca=falseSheet1!A1/f v0/v /c /row -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74743] Impress systematically freezes when trying to open a file
https://bugs.freedesktop.org/show_bug.cgi?id=74743 --- Comment #2 from Massimo pincopall...@orange.fr --- Not really sensitive information but work in progress (public presentation for a general public conference, the text is in French). I can upload to a server for a short period and I can remove it once you have downloaded (I get info when the file is downloaded). Would that be OK? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 --- Comment #6 from dan boec0...@gmail.com --- Created attachment 93710 -- https://bugs.freedesktop.org/attachment.cgi?id=93710action=edit workout ods -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 --- Comment #7 from dan boec0...@gmail.com --- that is an example of one of my spreadsheets. over the last couple of revisions it has taken longer and longer to open. on top of that, if you enter a time into column d of the first tab, it will take a long time for it to finish or whatever... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74719] spreadsheet calculations are slow
https://bugs.freedesktop.org/show_bug.cgi?id=74719 dan boec0...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48509] BASIC: Error on opening writer or calc
https://bugs.freedesktop.org/show_bug.cgi?id=48509 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|REOPENED|NEEDINFO CC||serval2...@yahoo.fr --- Comment #5 from Julien Nabet serval2...@yahoo.fr --- kieransgm: do you reproduce this with LO version 4.1.4? If yes, could you rename your LO directory profile and give it a new try? (https://wiki.documentfoundation.org/UserProfile) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48509] BASIC: Error on opening writer or calc
https://bugs.freedesktop.org/show_bug.cgi?id=48509 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Maxim Monastirsky momonas...@gmail.com --- *** This bug has been marked as a duplicate of bug 47953 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47953] : Error messages when opening LibreOffice
https://bugs.freedesktop.org/show_bug.cgi?id=47953 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||kieran...@googlemail.com --- Comment #5 from Maxim Monastirsky momonas...@gmail.com --- *** Bug 48509 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74479] CALC problem counting weekdays with sumproduct. Only Saturdays are not counted correctly when the selection contains empty cells or no date. SUMPRODUCT() result error wi
https://bugs.freedesktop.org/show_bug.cgi?id=74479 --- Comment #10 from Kohei Yoshida libreoff...@kohei.us --- (In reply to comment #8) Created attachment 93686 [details] File sample with SUMPRODUCT() error. I hope a more clear sample. mariosv, there is something wrong with your attachment, I'm afraid. Firefox says it has error, and Calc tries to open it as csv. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74748] New: : FILESAVE Images not saved after exit/Read error in docx file on FILEOPEN in 4.1.4.2
https://bugs.freedesktop.org/show_bug.cgi?id=74748 Priority: medium Bug ID: 74748 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: : FILESAVE Images not saved after exit/Read error in docx file on FILEOPEN in 4.1.4.2 Severity: critical Classification: Unclassified OS: Windows (All) Reporter: colin.mer...@botley.com Hardware: Other Status: UNCONFIRMED Version: 4.1.4.2 release Component: Writer Product: LibreOffice Created attachment 93712 -- https://bugs.freedesktop.org/attachment.cgi?id=93712action=edit Zip has copies of the docx and pdf files - see pdfs for what should be there. Images are not preserved in docx files over exiting and restarting Libre Office. The Read Error comes when Libre Office is next used and the file re-opened. So whilst it looks like a Save fault it could be an Opening fault! Most probably in Save as Libre Office oens docx with images OK. Using 4.1.4.2 and it still has the image read bug in docx files. The fault is trivial to reproduce. Just create a document with text and insert some pictures. Saving and continuing working whilst the document is still open is not a problem. But Save and Exit Libre Office. Re-start Libre Office and the open the file ( I used Recent Documents). I have attached a zip file with the relevant docx and pdfs that describe the sequence explicitly. This bug is related to 52226 but is for Libre Office 4.1.4.2 The text in the final file is below Words written Image Inserted from file on disk using insert image icon Image appears in centre of line, very small. All acceptable and better than large initial image. Moved it to the right and enlarged. All Ok. Had not saved file so now saved as docx – effectively Save As. Still AOK. Typed this text and did a Save. All still looks OK after the Save. To save at this stage I am about to make a pdf copy. First do ordinary save. Then went to Explorer and made a backup just in case that has useful info to help debug. Now save as pdf OK after doing pdf (NB why can't the pdf save use as its starting position the current location for the text file?) PDF looks good. So end of document so will save using the Save icon and then exit. This is the previous saved testImageSave01.docx after I had exited Libre Office, then re-entered and selected via Recent Documents. Will now Save As testImageSave02.docx OK done now as pdf (pdf was this time pointing at last used folder) Colin This is an extremely upsetting bug and has caused many of my colleagues to give up on Libre Office. Please, please resolve. It is reality that many people use docx files. At home I use Open Office but at work I use Microsoft Word. Saying that only odt files are really supported is like putting your head in the sand! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74747] FILESAVE corrupts references to cells on another sheet
https://bugs.freedesktop.org/show_bug.cgi?id=74747 --- Comment #3 from Steve Bickle scbic...@gmail.com --- Created attachment 93713 -- https://bugs.freedesktop.org/attachment.cgi?id=93713action=edit Example file as originally saved from Excel -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74747] FILESAVE corrupts references to cells on another sheet
https://bugs.freedesktop.org/show_bug.cgi?id=74747 --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- Thank you Steve for your feedback. On pc Debian x86-64 with master sources updated yesterday, I can reproduce the problem. I noticed that if I saved first in ods format, then xlsx format, it worked well. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs