LibreOffice Gerrit News for core on 2014-03-17

[gerrit]

Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ RID_SVXDLG_MULTIPATH dialog converted
  in https://gerrit.libreoffice.org/8614 from Szymon Kłos
  about module cui
 End of freshness 

+ fdo#74702 Moved CopyArea() Window specific function
  in https://gerrit.libreoffice.org/8605 from Chris Sherlock
  about module include, vcl
+ Cleanup vcl/inc/unx/salgdi.h
  in https://gerrit.libreoffice.org/8601 from Chris Sherlock
  about module vcl
+ fdo#74702 ImplPrintMask() implemented in Printer
  in https://gerrit.libreoffice.org/8593 from Chris Sherlock
  about module include, vcl
+ fdo#74702 DrawOutDev() and CopyArea() functions now noops in Printer
  in https://gerrit.libreoffice.org/8592 from Chris Sherlock
  about module include, vcl
+ fdo#74702 Move BitmapEx drawing code to seperate functions
  in https://gerrit.libreoffice.org/8588 from Chris Sherlock
  about module include, vcl
+ fdo#74702 Move gradient steps logic into OutputDevice or Printer classes
  in https://gerrit.libreoffice.org/8586 from Chris Sherlock
  about module include, vcl
+ fdo#74702 Moved ImplReleaseGraphics into correct classes
  in https://gerrit.libreoffice.org/8548 from Chris Sherlock
  about module include, vcl


* Merged changes on master for project core changed in the last 25 hours:

None

* Abandoned changes on master for project core changed in the last 25 hours:

+ Use false instead of sal_False in function returning bool
  in https://gerrit.libreoffice.org/8613 from Arnaud Versini


* Open changes needing tweaks, but being untouched for more than a week:

+ WIP: Converting ExtensionUpdate dialog for new format
  in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes
+ Refactored swooxmlexport tests cases. Added function to check contents.
  in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar
+ FDO#74886: Data labels are not preserved for Column Chart in RT file
  in https://gerrit.libreoffice.org/8098 from Umesh Kadam
+ sal: use posix_memalign only if it's available
  in https://gerrit.libreoffice.org/8405 from Douglas Mencken
+ fdo#71984 fix first line indentation in footnotes for MS Word documents
  in https://gerrit.libreoffice.org/8160 from Andras Timar
+ fd0#74150:Numbered list getting display after RT -table-within-table-1.do
  in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji
+ Lots of changes to Tango icons
  in https://gerrit.libreoffice.org/7987 from Miroslav Mazel
+ sw/docx export: fix handling of document with header and section(s)
  in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer
+ fdo#51525 Fix duplicate "Paste Special" entries in Calc.
  in https://gerrit.libreoffice.org/7784 from Andrzej Hunt
+ fdo#72661: Check ‘Hyphenation active’ automatically
  in https://gerrit.libreoffice.org/7291 from Jiwoong Youn
+ sa/l add release_assert() and assert that stay even in release code
  in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud
+ fdo#69407: On transparent frames, shadows are painted in foreground.
  in https://gerrit.libreoffice.org/7070 from Mohamed-Ali BEN MANSOUR
+ add a header to provide posix compatible wrapper for platform lacking
  in https://gerrit.libreoffice.org/6837 from Norbert Thiebaud
+ WIP fdo#72987 Use firebird backup format for .odb
  in https://gerrit.libreoffice.org/7299 from Andrzej Hunt
+ sw/export docx: add unit test for document with header and section(s)
  in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer
+ fix for exporting of text watermark to DOCX
  in https://gerrit.libreoffice.org/5568 from Adam CloudOn
+ WIP: fdo#33980 Preserve selection across all slide sorters.
  in https://gerrit.libreoffice.org/6633 from Andrzej Hunt
+ startcenter: Make SC open faster by timeouting thumbnails
  in https://gerrit.libreoffice.org/6102 from Krisztian Pinter
+ Simplify oslThreadIdentifier on Linux 32.
  in https://gerrit.libreoffice.org/5553 from Arnaud Versini
+ fdo#36791 : fix for import of greeting card
  in https://gerrit.libreoffice.org/4240 from Adam CloudOn
+ Positional Tab additions
  in https://gerrit.libreoffice.org/5387 from Adam CloudOn


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [GSoC] On "ODF Formulas in Writer"

[Matteo Campanelli]

Okay, thank you guys for all the help.
In the meantime I got my patch accepted! :)

Given the news ("ODF formulas in Writer" not being a valid GSoC talks
anymore), I'm going to apply for another project but in case my submission
to GSoC were not successful I might consider working on a sub-part of this
issue anyway this summer 'cause it had intrigued me at the beginning.

Best,
Matteo


On Tue, Mar 11, 2014 at 10:23 PM, Kohei Yoshida  wrote:

> On Tue, 2014-03-11 at 12:53 +0100, Michael Stahl wrote:
> > > However, for now, I would suggest focusing getting your easy hack
> > ready
> > > & accepted; that's required even in case at the end you're
> > interested in
> > > some other LibreOffice idea.
> >
> > absolutely - here are usually more GSoC applicants than available
> > mentors, and the most important thing to get accepted is to show that
> > you can get useful work done.  if we find that this one won't work
> > out,
> > it's always possible to choose a different GSoC project.
>
> And it appears that this idea has been moved out of the Ideas page,
> which means it's no longer a valid GSOC task.
>
> To be honest, I don't even know why this task was left on that page in
> the first place.  I believe it was one of those left-over tasks that we
> forgot to clean up.
>
> Kohei
>
>
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'private/moggi/chart-opengl-fixes' - xmloff/source

[Markus Mohrhard]

 xmloff/source/chart/SchXMLPropertyMappingContext.cxx |  111 +++
 xmloff/source/chart/SchXMLPropertyMappingContext.hxx |   50 
 2 files changed, 161 insertions(+)

New commits:
commit 96b024019472b34696f25c895898e1a92e397bfd
Author: Markus Mohrhard 
Date:   Mon Mar 17 05:36:10 2014 +0100

add missing files

Change-Id: I1d79c1b6678e9ae42642bb0371f8292c42eb4c53

diff --git a/xmloff/source/chart/SchXMLPropertyMappingContext.cxx 
b/xmloff/source/chart/SchXMLPropertyMappingContext.cxx
new file mode 100644
index 000..affe3aa
--- /dev/null
+++ b/xmloff/source/chart/SchXMLPropertyMappingContext.cxx
@@ -0,0 +1,111 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "SchXMLPropertyMappingContext.hxx"
+#include "PropertyMap.hxx"
+#include "SchXMLTools.hxx"
+#include 
+#include 
+#include 
+#include 
+#include "SchXMLImport.hxx"
+
+#include 
+#include 
+#include 
+
+using namespace com::sun::star;
+using namespace com::sun::star::uno;
+
+namespace {
+
+Reference< chart2::data::XLabeledDataSequence2 > createAndAddSequenceToSeries( 
const OUString& rRole
+, const OUString& rRange
+, const Reference< chart2::XChartDocument >& xChartDoc
+, const Reference< chart2::XDataSeries >& xSeries )
+{
+Reference< chart2::data::XLabeledDataSequence2 > xLabeledSeq;
+
+Reference< chart2::data::XDataSource > xSeriesSource( 
xSeries,uno::UNO_QUERY );
+
+if( !(!rRange.isEmpty() && xChartDoc.is() && xSeriesSource.is()) )
+return xLabeledSeq;
+
+// create a new sequence
+xLabeledSeq = SchXMLTools::GetNewLabeledDataSequence();
+
+// set values at the new sequence
+Reference< chart2::data::XDataSequence > xSeq = 
SchXMLTools::CreateDataSequence( rRange, xChartDoc );
+Reference< beans::XPropertySet > xSeqProp( xSeq, uno::UNO_QUERY );
+if( xSeqProp.is())
+xSeqProp->setPropertyValue("Role", uno::makeAny( rRole));
+xLabeledSeq->setValues( xSeq );
+
+return xLabeledSeq;
+}
+
+}
+
+SchXMLPropertyMappingContext::SchXMLPropertyMappingContext( 
SchXMLImportHelper& rImpHelper,
+SvXMLImport& rImport, const OUString& rLocalName,
+tSchXMLLSequencesPerIndex & rLSequencesPerIndex,
+uno::Reference<
+chart2::XDataSeries > xSeries ):
+SvXMLImportContext( rImport, XML_NAMESPACE_LO_EXT, rLocalName ),
+mrImportHelper( rImpHelper ),
+mxDataSeries(xSeries),
+mrLSequencesPerIndex(rLSequencesPerIndex)
+{
+
+}
+
+SchXMLPropertyMappingContext::~SchXMLPropertyMappingContext()
+{
+}
+
+void SchXMLPropertyMappingContext::StartElement(const uno::Reference< 
xml::sax::XAttributeList>& xAttrList )
+{
+OUString aRange;
+OUString aRole;
+// parse attributes
+sal_Int16 nAttrCount = xAttrList.is()? xAttrList->getLength(): 0;
+const SvXMLTokenMap& rAttrTokenMap = 
mrImportHelper.GetPropMappingAttrTokenMap();
+
+for( sal_Int16 i = 0; i < nAttrCount; i++ )
+{
+OUString sAttrName = xAttrList->getNameByIndex( i );
+OUString aLocalName;
+OUString aValue = xAttrList->getValueByIndex( i );
+sal_uInt16 nPrefix = GetImport().GetNamespaceMap().GetKeyByAttrName( 
sAttrName, &aLocalName );
+
+switch( rAttrTokenMap.Get( nPrefix, aLocalName ))
+{
+case XML_TOK_PROPERTY_MAPPING_PROPERTY:
+aRole = aValue;
+break;
+case XML_TOK_PROPERTY_MAPPING_RANGE:
+aRange = aValue;
+break;
+}
+}
+
+if( !aRange.isEmpty() && !aRole.isEmpty() )
+{
+Reference< chart2::XChartDocument > xChartDoc( GetImport().GetModel(), 
uno::UNO_QUERY );
+Reference< chart2::data::XLabeledDataSequence2 > xSeq =
+createAndAddSequenceToSeries(aRole, aRange, xChartDoc, 
mxDataSeries);
+mrLSequencesPerIndex.insert(
+tSchXMLLSequencesPerIndex::value_type(
+tSchXMLIndexWithPart( 0, SCH_XML_PART_VALUES),
+Reference< chart2::data::XLabeledDataSequence >( xSeq, 
UNO_QUERY )));
+}
+}
+
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/chart/SchXMLPropertyMappingContext.hxx 
b/xmloff/source/chart/SchXMLPropertyMappingContext.hxx
new file mode 100644
index 000..b42bba2
--- /dev/null
+++ b/xmloff/source/chart/SchXMLPropertyMappingContext.hxx
@@ -0,0 +1,50 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obta

[Libreoffice-commits] core.git: Changes to 'private/moggi/chart-opengl-fixes'

[Markus Mohrhard]

New branch 'private/moggi/chart-opengl-fixes' available with the following 
commits:
commit ae9916633218e2b26bf204f4336eb8f83fc2f167
Author: Markus Mohrhard 
Date:   Mon Mar 17 05:22:33 2014 +0100

no need for OpenGLRender in OpenGLContext anymore

Change-Id: I8506bcea49792cd1ef6ca451ca515b4669326c29

commit ace5df929e900e2b30c150147e84499b50d61985
Author: Markus Mohrhard 
Date:   Mon Mar 17 05:13:12 2014 +0100

move the windows multisample code to OpenGLContext

Change-Id: I531d058ff00b3b6eaf2bf7c889589058b1be7bd0

commit 0b3278caf4a011fb663c384842f038b314cc53ed
Author: Markus Mohrhard 
Date:   Mon Mar 17 05:06:00 2014 +0100

Revert "Move OpenGLRender to vcl"

This reverts commit 04b70c682e2cdc52b144961a83d05fd203de6884.

The OpenGLRender is not abstract enough for vcl. Leave it in chart2.

Conflicts:
chart2/source/view/inc/DummyXShape.hxx
chart2/source/view/main/OpenGLRender.hxx
vcl/Library_vclopengl.mk

Change-Id: I5392c8ee34462ff49059126ca2284d8ebe1eb379

commit dbb93bc2324c5b8ca03cf19e7b85fc0e62b6ff75
Author: Markus Mohrhard 
Date:   Fri Mar 14 02:49:19 2014 +0100

remove element that was only written for binary formats

Change-Id: Ic930fc6e12912ead8d6b1daa79894c968d99d988

commit 3012e9a7e2468a08eae020447646f8af53ec75dc
Author: Markus Mohrhard 
Date:   Wed Mar 12 02:45:00 2014 +0100

remove whitespace

Change-Id: I131de4b10674dceee821e2ab580b32d107134335

commit e4d304fe9d44515f9bbe451266e88cfaba768cf3
Author: Markus Mohrhard 
Date:   Tue Mar 11 12:38:06 2014 +0100

property mapping import

Change-Id: I0859699b3639b6f7d5d15865e6ec1591b3d36f06

commit bffc725cf7fe97e5e8d2d65109261daff308e493
Author: Markus Mohrhard 
Date:   Sun Mar 9 21:28:53 2014 +0100

we also need to translate from ui to internal roles

Change-Id: Id66f2f015d1eabe469a944f2bbafe2afbb360464

___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 60270] LibreOffice 4.1 most annoying bugs

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=60270

Bug 60270 depends on bug 66232, which changed state.

Bug 66232 Summary: FILEOPEN: cannot open .odt files by clicking on a hyperlink 
in IE
https://bugs.freedesktop.org/show_bug.cgi?id=66232

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 69079] Creating a new themes in the gallery the files are always created as file "new theme.*" instead of "sdxxx.*" - existing files will be overwritten and leads to data loss.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=69079

--- Comment #13 from Chris Sherlock  ---
Peter, are you saying this is still an issue?

If so: we need to look at svx/source/gallery2/galbrws1.cxx - the file name is
created using resource RID_SVXSTR_GALLERY_NEWTHEME. But it *should* be
incrementing the name, but it will be "new themeXX".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Buildbot failure for https://gerrit.libreoffice.org/#/c/8548/

[Chris Sherlock]

Hi all, 

Does anyone have any ideas why https://gerrit.libreoffice.org/#/c/8548/ failed 
only for OS X?

The code around sc/qa/unit/ucalc.cxx isn't OS X specific!

Chris
Sent from my iPad___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Bad empty file at

[Thorsten Behrens]

Hi Andi,

any chance for a quick fix there?

Thanks a lot, Thorsten

Stephan Bergmann wrote:
> Quoting  on
> "Syntax error in Extension Manager when trying to update":
> 
> "The reason [for the syntax error] is that 
> 
> references a completely empty file.  That URL is the value of the
> ExtensionUpdateURL property in the version ini file.  It is used by
> getDefaultUpdateInfos (desktop/source/deployment/misc/dp_update.cxx)
> to try and obtain 'backup' update information from one central place
> for all those extensions that fail to provide their own update
> information.  The current 
> 
> URL is used since 
> 
> 'Switch all urls from TDF to LibreOffice.'  The prior, OOo-specific
> URL 
> 
> still delivers a file starting with
> 
> >
> >http://www.w3.org/2005/Atom"; xml:lang="en-US">
> >  Extension Update Feed
> >   > href="http://extensions.openoffice.org"/>
> >  2013-03-18T12:03:22+00:00
> 
> "I have no idea who is responsible for the empty file at 
> .
> 
> "I see three options to fix this:
> 
> "1  Fix the file at 
> 
> to conform to the expected syntax (even if it would not contain any
> true payload yet, but could do so in the future).  That would fix
> this issue even for already released versions of LO.
> 
> "2  Give the ExtensionUpdateURL property in the version ini file an
> empty value.  That would not fix this issue for already released
> versions of LO, and for future versions of LO would disable the
> (currently unused) feature of providing such central 'backup'
> extension update information (until we change the value back in a
> later release).
> 
> "3  Remove the (currently unused) feature of providing such central
> 'backup' extension update information completely from the code.
> That would not fix this issue for already released versions of LO.
> 
> "I favour option 1 and will see to get hold of somebody to fix the
> file at 
> ."
> 
> So, who can fix that file (or propose a better fix)?
> 
> Stephan
> ___

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Szymon Kłos license statement

[Dennis Roczek]

Added to the wiki page with this edit 
https://wiki.documentfoundation.org/index.php?title=Development%2FDevelopers&action=historysubmit&diff=90479&oldid=89926



Regards,

Dennis

Am 16.03.2014 20:03, schrieb Szymon Kłos:> All of my past & future 
contributions to LibreOffice may be licensed

> under the MPLv2/LGPLv3+ dual license.
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>



smime.p7s
Description: S/MIME Cryptographic Signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Szymon Kłos license statement

[Szymon Kłos]

All of my past & future contributions to LibreOffice may be licensed
under the MPLv2/LGPLv3+ dual license.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

[Tor Lillqvist]

 sw/source/core/layout/calcmove.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c0a6e9a1baa7664ea62a3942f43f7bd79cf3fcc6
Author: Tor Lillqvist 
Date:   Sun Mar 16 19:11:46 2014 +0200

WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'

Change-Id: I44ea80e5e8e6bb568eb91c29a2adf73b110fb660

diff --git a/sw/source/core/layout/calcmove.cxx 
b/sw/source/core/layout/calcmove.cxx
index ce04d82..e796585 100644
--- a/sw/source/core/layout/calcmove.cxx
+++ b/sw/source/core/layout/calcmove.cxx
@@ -86,7 +86,7 @@ bool SwCntntFrm::ShouldBwdMoved( SwLayoutFrm *pNewUpper, 
bool, bool & )
 pSect = pSect->GetUpper()->FindSctFrm();
 OSL_ENSURE( pSect, "Escaping footnote" );
 if( pSect != pMySect )
-return sal_False;
+return false;
 }
 }
 SWRECTFN( this )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Connection to SharePoint and/or Microsoft OneDrive GSOC 2014 Project

[julien2412]

Hi,

About gsoc:
- https://wiki.documentfoundation.org/Development/GSoC
- https://wiki.documentfoundation.org/Development/GSoC/Ideas

About Dev:
- https://wiki.documentfoundation.org/Development

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Connection-to-SharePoint-and-or-Microsoft-OneDrive-GSOC-2014-Project-tp4101719p4101730.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Connection to SharePoint and/or Microsoft OneDrive GSOC 2014 Project

[Tharindu Amila Perera]

Hi all,

I'm a Computer Science and Engineering Undergraduate at University of
Moratuwa. I'm currently in my third year. I hope I'm not too late in
starting on GSOC 2014. I'll start on building LibreOffice as
instructed by the introdution in the GSOC 2014 organization page and
try to give my first patch. If there are any pointers on how to
proceed I'll be most grateful.

-- 
Thanks and regards,
Tharindu Amila Perera
Undergraduate
Department of Computer Science & Engineering
University of Moratuwa
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 47800] Most of the predefined autotexts are missing in czech language

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47800

Jean-Baptiste Faure  changed:

   What|Removed |Added

Summary|: inserting formula by  |Most of the predefined
   |"fn+f3" is not working with |autotexts are missing in
   |czech language  |czech language

--- Comment #9 from Jean-Baptiste Faure  ---
(In reply to comment #8)
> In Czech, there are no items in the AutoText dialog (only a few empty
> categories), so it is indeed a bug.

Ok, so it is not a shortcut problem. Modified summary accordingly.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 70414] create VSProject files for code editing in MSVS from gbuild

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=70414

--- Comment #21 from kie...@outlook.com ---
I ended up commented out the following line in gbuild-to-ide

#os.makedirs(os.path.dirname(project_path), exist_ok = True)

ran /opt/lo/bin/make vs2012-ide-integration several times, creating the
following folders when it complained that they didn't exist:
neon
clucene
ucpp
Redland

After creating these folders and running /opt/lo/bin/make
vs2012-ide-integration, it appears that the command now creates the VS2012
project files successfully.  Now to figure out how to build successfully...

I am using Windows 8 Pro and VS2012 Pro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - oox/source

[Muthu Subramanian]

 oox/source/export/drawingml.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f4d59251a4ef911d794c4d01edbec64310fc8676
Author: Muthu Subramanian 
Date:   Thu Dec 19 16:48:20 2013 +0530

n#828390: Bullet sizes set wrong.

(cherry picked from commit e5cd547846663c69bd66aa1ba94e3b4dcce30a89)
Signed-off-by: Andras Timar 

diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 75bfc56..a8c5741 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -1118,7 +1118,7 @@ void DrawingML::WriteParagraphNumbering( Reference< 
XPropertySet > rXPropSet, sa
 } else {
 if( nBulletRelSize && nBulletRelSize != 100 )
 mpFS->singleElementNS( XML_a, XML_buSzPct,
-   XML_val, IS( std::min( 
(sal_Int32)25000, std::max( (sal_Int32)40, 1000*( (sal_Int32)nBulletRelSize 
) ) ) ), FSEND );
+   XML_val, IS( std::max( 
(sal_Int32)25000, std::min( (sal_Int32)40, 1000*( (sal_Int32)nBulletRelSize 
) ) ) ), FSEND );
 if( bHasFontDesc )
 mpFS->singleElementNS( XML_a, XML_buFont,
XML_typeface, 
OUStringToOString( aFontDesc.Name, RTL_TEXTENCODING_UTF8 ).getStr(),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 64945] inconvenient localized symbol code

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64945

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbf.fa...@sud-ouest.org
Version|unspecified |Inherited From OOo

--- Comment #6 from Jean-Baptiste Faure  ---
Hi,

I prefer the second solution proposed by Frédéric for the following reasons:
- it's a very old problem and many users are accustomed to use localized names
of greek letters; if we change the names used in French they will be confused.
- it is a more generic solution, valid for all languages

In fact, there is two difficulties here:
1/ the difficulty to type a series of uppercase characters; all users are
concerned here, not only French users. The first solution proposed by Frédéric
seems to me the best compromise.

2/ the difficulty to type an accentuated uppercase character; here only
MS-Windows users for languages with accentuated characters are concerned.
Indeed it is not a problem to type accentuated characters under Linux (at least
in French). Here the second solution seems to me the right one. It solve
another problem which is that many users do not know which accent they must
type for greek letters in French. We already have the same kind of option for
the function names in Calc.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - oox/source

[Muthu Subramanian]

 oox/source/export/drawingml.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 3f16ae0233442bd2b8f2f0ebde9a2741a41ef6c4
Author: Muthu Subramanian 
Date:   Wed Dec 18 19:56:28 2013 +0530

fdo#73627 n#828390: Explictly export font properties.

Seems like the status is returned as default,
but the font properties needs to be still exported.

(cherry picked from commit 33b796eb1484b9a3fc11a189faddb7fc36509856)
Signed-off-by: Andras Timar 

Change-Id: I65619d10f44ad54ab79874c718e47677049a2ff8

diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx
index 7526741..75bfc56 100644
--- a/oox/source/export/drawingml.cxx
+++ b/oox/source/export/drawingml.cxx
@@ -699,14 +699,14 @@ void DrawingML::WriteRunProperties( Reference< 
XPropertySet > rRun, sal_Bool bIs
 sal_Int32 nSize = 1800;
 sal_Int32 nCharEscapement = 0;
 
-if( GETAD( CharHeight ) )
+if( GETA( CharHeight ) )
 nSize = (sal_Int32) (100*(*((float*) mAny.getValue(;
 
-if ( ( bComplex && GETAD( CharWeightComplex ) ) || GETAD( CharWeight ) )
+if ( ( bComplex && GETA( CharWeightComplex ) ) || GETA( CharWeight ) )
 if ( *((float*) mAny.getValue()) >= awt::FontWeight::SEMIBOLD )
 bold = "1";
 
-if ( ( bComplex && GETAD( CharPostureComplex ) ) || GETAD( CharPosture ) )
+if ( ( bComplex && GETA( CharPostureComplex ) ) || GETA( CharPosture ) )
 switch ( *((awt::FontSlant*) mAny.getValue()) )
 {
 case awt::FontSlant_OBLIQUE :
@@ -815,7 +815,7 @@ void DrawingML::WriteRunProperties( Reference< XPropertySet 
> rRun, sal_Bool bIs
 WriteSolidFill( color );
 }
 
-if( GETAD( CharFontName ) ) {
+if( GETA( CharFontName ) ) {
 const char* pitch = NULL;
 const char* charset = NULL;
 OUString usTypeface;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 47800] : inserting formula by "fn+f3" is not working with czech language

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47800

--- Comment #8 from Stanislav Horacek  ---
In Czech, there are no items in the AutoText dialog (only a few empty
categories), so it is indeed a bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 47800] : inserting formula by "fn+f3" is not working with czech language

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47800

Jean-Baptiste Faure  changed:

   What|Removed |Added

 CC||jbf.fa...@sud-ouest.org

--- Comment #7 from Jean-Baptiste Faure  ---
It does not work in French too because the shortcut is localized. In French it
is nf+F3 (Numérotation de Formule). If I switch back to the English/USA UI,
then the shortcut becomes fn+F3.

To found the correct shortcut: menu Edit > AutoText and search in the list
"Standard" the equivalent of "Formula Numbering".

For me it is not a bug.

Best regards. JBF

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 64945] inconvenient localized symbol code

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=64945

--- Comment #5 from darshana  ---
If Grimm isn't working on this could I have a go at it ?
Should the changes made be in accordance with what has been mentioned in
comment 4?
Regards 
Darshana

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 47800] : inserting formula by "fn+f3" is not working with czech language

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47800

Michal Horák  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |hora...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 69079] Creating a new themes in the gallery the files are always created as file "new theme.*" instead of "sdxxx.*" - existing files will be overwritten and leads to data loss.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=69079

--- Comment #12 from Peter Mögenburg  ---
Problem is also in version 4.2.2 and 4.2.3.1 .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Manas license statement

[Manas Joshi]

All of my past & future contributions to LibreOffice may be
   licensed under the MPLv2/LGPLv3+ dual license.

Regards,
Manas
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

"[PATCH] fdo#76181: cleanup constructors in ucalc.cxx"

[Manas Joshi]

From 0240fe32a881059fafe20b4afa9f252057cd55dd Mon Sep 17 00:00:00 2001
From: Manas Joshi 
Date: Sat, 15 Mar 2014 13:50:33 -0700
Subject: [PATCH] Bug 76181 has been fixed

---
 sc/qa/unit/ucalc.cxx |  206 +-
 1 file changed, 85 insertions(+), 121 deletions(-)

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index cfc94e0..3a6450b 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -463,10 +463,8 @@ void Test::testPerf()
 
 void Test::testCollator()
 {
-OUString s1("A");
-OUString s2("B");
 CollatorWrapper* p = ScGlobal::GetCollator();
-sal_Int32 nRes = p->compareString(s1, s2);
+sal_Int32 nRes = p->compareString("A", "B");
 CPPUNIT_ASSERT_MESSAGE("these strings are supposed to be different!", nRes != 0);
 }
 
@@ -697,19 +695,16 @@ void Test::testMarkData()
 
 void Test::testInput()
 {
-OUString aTabName("foo");
+
 CPPUNIT_ASSERT_MESSAGE ("failed to insert sheet",
-m_pDoc->InsertTab (0, aTabName));
-
-OUString numstr("'10.5");
-OUString str("'apple'");
+m_pDoc->InsertTab (0, "foo"));
 OUString test;
 
-m_pDoc->SetString(0, 0, 0, numstr);
+m_pDoc->SetString(0, 0, 0, "'10.5");
 test = m_pDoc->GetString(0, 0, 0);
 bool bTest = test == "10.5";
 CPPUNIT_ASSERT_MESSAGE("String number should have the first apostrophe stripped.", bTest);
-m_pDoc->SetString(0, 0, 0, str);
+m_pDoc->SetString(0, 0, 0, "'apple'");
 test = m_pDoc->GetString(0, 0, 0);
 bTest = test == "'apple'";
 CPPUNIT_ASSERT_MESSAGE("Text content should have retained the first apostrophe.", bTest);
@@ -760,7 +755,7 @@ void Test::testDataEntries()
 // Entries are supposed to be sorted in ascending order, and are all unique.
 CPPUNIT_ASSERT_EQUAL(static_cast(3), aEntries.size());
 std::vector::const_iterator it = aEntries.begin();
-CPPUNIT_ASSERT_EQUAL(OUString("Andy"), it->GetString());
+CPPUNIT_ASSERT_EQUAL(OUString("Andy"), it->GetString()); 
 ++it;
 CPPUNIT_ASSERT_EQUAL(OUString("Bruce"), it->GetString());
 ++it;
@@ -937,9 +932,8 @@ void Test::testCopyToDocument()
 
 //note on A1
 ScAddress aAdrA1 (0, 0, 0); // numerical cell content
-OUString aHelloA1("Hello world in A1");
 ScPostIt* pNote = m_pDoc->GetOrCreateNote(aAdrA1);
-pNote->SetText(aAdrA1, aHelloA1);
+pNote->SetText(aAdrA1, "Hello world in A1");
 
 // Copy statically to another document.
 
@@ -1348,7 +1342,7 @@ void Test::testFormulaMatrixResultUpdate()
 pFC->SetChanged(false); // Clear this flag to simulate displaying of formula cell value on screen.
 
 m_pDoc->SetString(ScAddress(0,0,0), "ABC");
-CPPUNIT_ASSERT_EQUAL(OUString("ABC"), m_pDoc->GetString(ScAddress(1,0,0)));
+CPPUNIT_ASSERT_EQUAL(OUString("ABC"), m_pDoc->GetString(ScAddress(1,0,0)));
 pFC->SetChanged(false);
 
 // Put a new value into A1. The formula should update.
@@ -1639,12 +1633,12 @@ void Test::testCellBroadcaster()
 
 void Test::testFuncParam()
 {
-OUString aTabName("foo");
+
 CPPUNIT_ASSERT_MESSAGE ("failed to insert sheet",
-m_pDoc->InsertTab (0, aTabName));
+m_pDoc->InsertTab (0, "foo"));
 
 // First, the normal case, with no missing parameters.
-m_pDoc->SetString(0, 0, 0, OUString("=AVERAGE(1;2;3)"));
+m_pDoc->SetString(0, 0, 0, "=AVERAGE(1;2;3)");  
 m_pDoc->CalcFormulaTree(false, false);
 double val;
 m_pDoc->GetValue(0, 0, 0, val);
@@ -1652,17 +1646,17 @@ void Test::testFuncParam()
 
 // Now function with missing parameters.  Missing values should be treated
 // as zeros.
-m_pDoc->SetString(0, 0, 0, OUString("=AVERAGE(1;;;)"));
+m_pDoc->SetString(0, 0, 0, "=AVERAGE(1;;;)");   
 m_pDoc->CalcFormulaTree(false, false);
 m_pDoc->GetValue(0, 0, 0, val);
 CPPUNIT_ASSERT_MESSAGE("incorrect result", val == 0.25);
 
 // Conversion of string to numeric argument.
-m_pDoc->SetString(0, 0, 0, OUString("=\"\"+3"));// empty string
-m_pDoc->SetString(0, 1, 0, OUString("=\" \"+3"));   // only blank
-m_pDoc->SetString(0, 2, 0, OUString("=\" 4 \"+3")); // number in blanks
-m_pDoc->SetString(0, 3, 0, OUString("=\" x \"+3")); // non-numeric
-m_pDoc->SetString(0, 4, 0, OUString("=\"4.4\"+3")); // locale dependent
+m_pDoc->SetString(0, 0, 0, "=\"\"+3");// empty string   
+m_pDoc->SetString(0, 1, 0, "=\" \"+3");   // only blank
+m_pDoc->SetString(0, 2, 0, "=\" 4 \"+3"); // number in blanks
+m_pDoc->SetString(0, 3, 0, "=\" x \"+3"); // non-numeric
+m_pDoc->SetString(0, 4, 0, "=\"4.4\"+3"); // locale dependent
 
 OUString aVal;
 ScCalcConfig aConfig;
@@ -1795,7 +1789,7 @@ void Test::testNamedRange()
 }
 
 // Test usage in formula expression.
-m_pDoc->SetString (1, 0, 0, OUString("=A1/Divisor"));
+m_pDoc->SetString (1, 0, 0, "=A1/Diviso