LibreOffice Gerrit News for core on 2014-03-26
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo#64945 Remove inconvenient localized symbol code. in https://gerrit.libreoffice.org/8696 from Darshana Padmadas about module officecfg, starmath End of freshness + new method INetURLObject::getData() for data urls in https://gerrit.libreoffice.org/8737 from Christina Roßmanith about module include, sw, tools + fdo#74702 OutputDevice::ImplInitFontList() fails if no fonts on device in https://gerrit.libreoffice.org/8741 from Chris Sherlock about module vcl * Merged changes on master for project core changed in the last 25 hours: + Accessibility: Avoid immediate crash in Impress in https://gerrit.libreoffice.org/8748 from Niklas Johansson + Update make helpfile in https://gerrit.libreoffice.org/8747 from Chris Sherlock + Fix to commit 03568b2e2405fc44435b95720f3680ab1daea836 in https://gerrit.libreoffice.org/8745 from Chris Sherlock + fdo#74702 DrawTransformedBitmapEx simplified in https://gerrit.libreoffice.org/8723 from Chris Sherlock + fdo#74702 Move GetBitCount() and GetAlphaBitCount into correct classes in https://gerrit.libreoffice.org/8722 from Chris Sherlock + fdo#74702 Moved EnableRTL() logic to specific classes where appropriate in https://gerrit.libreoffice.org/8721 from Chris Sherlock + More vertical space for the options dialog in https://gerrit.libreoffice.org/8735 from Andreas Mantke * Abandoned changes on master for project core changed in the last 25 hours: + Remove old outdated gallery Images in https://gerrit.libreoffice.org/4993 from Samuel Mehrbrodt + more in https://gerrit.libreoffice.org/8746 from Chris Sherlock + Revert fdo#74702 Moved EnableRTL() logic to specific classes where appro in https://gerrit.libreoffice.org/8744 from Chris Sherlock + fdo#69407: On transparent frames, shadows are painted in foreground. in https://gerrit.libreoffice.org/7070 from Mohamed-Ali BEN MANSOUR * Open changes needing tweaks, but being untouched for more than a week: + Remove visual noise from ios in https://gerrit.libreoffice.org/8274 from Alexander Wilms + FDO#75205 : Charts - Up Down bars are getting added to Line Chart. in https://gerrit.libreoffice.org/8360 from Umesh Kadam + WIP: Converting ExtensionUpdate dialog for new format in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes + Refactored swooxmlexport tests cases. Added function to check contents. in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar + FDO#74886: Data labels are not preserved for Column Chart in RT file in https://gerrit.libreoffice.org/8098 from Umesh Kadam + sal: use posix_memalign only if it's available in https://gerrit.libreoffice.org/8405 from Douglas Mencken + fdo#71984 fix first line indentation in footnotes for MS Word documents in https://gerrit.libreoffice.org/8160 from Andras Timar + fd0#74150:Numbered list getting display after RT -table-within-table-1.do in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji + Lots of changes to Tango icons in https://gerrit.libreoffice.org/7987 from Miroslav Mazel + sw/docx export: fix handling of document with header and section(s) in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer + fdo#51525 Fix duplicate Paste Special entries in Calc. in https://gerrit.libreoffice.org/7784 from Andrzej Hunt + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + sa/l add release_assert() and assert that stay even in release code in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud + add a header to provide posix compatible wrapper for platform lacking in https://gerrit.libreoffice.org/6837 from Norbert Thiebaud + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt + Simplify oslThreadIdentifier on Linux 32. in https://gerrit.libreoffice.org/5553 from Arnaud Versini + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win
vcl/headless/svpinst.cxx |5 - vcl/inc/headless/svpinst.hxx |1 - vcl/inc/osx/salinst.h |2 -- vcl/inc/salinst.hxx |1 - vcl/inc/unx/salinst.h |1 - vcl/inc/win/salinst.h |2 -- vcl/quartz/salvd.cxx |9 - vcl/source/gdi/virdev.cxx |7 +++ vcl/unx/generic/gdi/salvd.cxx |5 - vcl/win/source/gdi/salvd.cxx |9 - 10 files changed, 3 insertions(+), 39 deletions(-) New commits: commit d852df0d6d6f7b8c12b43c34cec83f673ef0a32f Author: Tor Lillqvist t...@collabora.com Date: Wed Mar 26 09:08:27 2014 +0200 Bin DestroyVirtualDevice(): Just use delete directly at call sites Change-Id: I47c67d3d89ab22b07b3ec6fe7ea6e035d21e85b6 diff --git a/vcl/headless/svpinst.cxx b/vcl/headless/svpinst.cxx index aaf1592..2ce2a01 100644 --- a/vcl/headless/svpinst.cxx +++ b/vcl/headless/svpinst.cxx @@ -228,11 +228,6 @@ SalVirtualDevice* SvpSalInstance::CreateVirtualDevice( SalGraphics* /* pGraphics return pNew; } -void SvpSalInstance::DestroyVirtualDevice( SalVirtualDevice* pDevice ) -{ -delete pDevice; -} - #endif SalTimer* SvpSalInstance::CreateSalTimer() diff --git a/vcl/inc/headless/svpinst.hxx b/vcl/inc/headless/svpinst.hxx index 4a7b7b2..4090e35 100644 --- a/vcl/inc/headless/svpinst.hxx +++ b/vcl/inc/headless/svpinst.hxx @@ -122,7 +122,6 @@ public: virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics, long nDX, long nDY, sal_uInt16 nBitCount, const SystemGraphicsData *pData = NULL ); -virtual voidDestroyVirtualDevice( SalVirtualDevice* pDevice ); // Printer // pSetupData-mpDriverData can be 0 diff --git a/vcl/inc/osx/salinst.h b/vcl/inc/osx/salinst.h index 69261e4..6d9a8d6 100644 --- a/vcl/inc/osx/salinst.h +++ b/vcl/inc/osx/salinst.h @@ -91,8 +91,6 @@ public: virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics, long nDX, long nDY, sal_uInt16 nBitCount, const SystemGraphicsData *pData ) SAL_OVERRIDE; -virtual voidDestroyVirtualDevice( SalVirtualDevice* pDevice ) SAL_OVERRIDE; - virtual SalInfoPrinter* CreateInfoPrinter( SalPrinterQueueInfo* pQueueInfo, ImplJobSetup* pSetupData ) SAL_OVERRIDE; virtual voidDestroyInfoPrinter( SalInfoPrinter* pPrinter ) SAL_OVERRIDE; diff --git a/vcl/inc/salinst.hxx b/vcl/inc/salinst.hxx index 75b390a..b7d1993 100644 --- a/vcl/inc/salinst.hxx +++ b/vcl/inc/salinst.hxx @@ -86,7 +86,6 @@ public: CreateVirtualDevice( SalGraphics* pGraphics, long nDX, long nDY, sal_uInt16 nBitCount, const SystemGraphicsData *pData = NULL ) = 0; -virtual voidDestroyVirtualDevice( SalVirtualDevice* pDevice ) = 0; // Printer // pSetupData-mpDriverData can be 0 diff --git a/vcl/inc/unx/salinst.h b/vcl/inc/unx/salinst.h index d91deaa..77bcb33 100644 --- a/vcl/inc/unx/salinst.h +++ b/vcl/inc/unx/salinst.h @@ -55,7 +55,6 @@ public: virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics, long nDX, long nDY, sal_uInt16 nBitCount, const SystemGraphicsData *pData = NULL ); -virtual voidDestroyVirtualDevice( SalVirtualDevice* pDevice ); virtual voidPostPrintersChanged(); virtual GenPspGraphics *CreatePrintGraphics(); diff --git a/vcl/inc/win/salinst.h b/vcl/inc/win/salinst.h index 0839203..a6ccbb5 100644 --- a/vcl/inc/win/salinst.h +++ b/vcl/inc/win/salinst.h @@ -44,8 +44,6 @@ public: virtual SalVirtualDevice* CreateVirtualDevice( SalGraphics* pGraphics, long nDX, long nDY, sal_uInt16 nBitCount, const SystemGraphicsData *pData ); -virtual voidDestroyVirtualDevice( SalVirtualDevice* pDevice ); - virtual SalInfoPrinter* CreateInfoPrinter( SalPrinterQueueInfo* pQueueInfo, ImplJobSetup* pSetupData ); virtual voidDestroyInfoPrinter( SalInfoPrinter* pPrinter ); diff --git a/vcl/quartz/salvd.cxx b/vcl/quartz/salvd.cxx index b54f7ce..fb3e9a7 100644 --- a/vcl/quartz/salvd.cxx +++ b/vcl/quartz/salvd.cxx @@ -55,15 +55,6 @@ SalVirtualDevice* AquaSalInstance::CreateVirtualDevice( SalGraphics* pGraphics, #endif } - - -void AquaSalInstance::DestroyVirtualDevice( SalVirtualDevice* pDevice ) -{ -delete pDevice; -} - - - AquaSalVirtualDevice::AquaSalVirtualDevice(
Re: Extension in Java
Hello Adriam, On Tue, 2014-03-25 at 16:55 -0400, Adriam Delgado Rivero wrote: thanks, Cedric. I developmend one extension in java, when i try to build the extension LibreofficeManageExtension Cannot determine registration class.I cant find the error in my extension. Sadly without more informations and without code, it'll be hard for me to help you. You know, code is like talking too ;) -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/generic/geninst.h| 30 vcl/inc/headless/svpinst.hxx | 53 +-- vcl/inc/unx/gtk/gtkinst.hxx | 47 +++--- vcl/inc/unx/salinst.h| 35 ++-- 4 files changed, 83 insertions(+), 82 deletions(-) New commits: commit 99a79ef856fb6b02196f71e67907a6a45940de01 Author: Tor Lillqvist t...@collabora.com Date: Wed Mar 26 09:52:04 2014 +0200 Sprinkle some SAL_OVERRIDEs Add SAL_OVERRIDE markup to SalInstance and its derived classes for Unix. In the process, found one pointlessly virtual function (not overridden in any derived class). Change-Id: I49e021e77d53b658e664178372b333a13ffdc9aa diff --git a/vcl/inc/generic/geninst.h b/vcl/inc/generic/geninst.h index 75a4a65..adc05a6 100644 --- a/vcl/inc/generic/geninst.h +++ b/vcl/inc/generic/geninst.h @@ -83,25 +83,25 @@ public: virtual ~SalGenericInstance(); // Yield mutex -virtual comphelper::SolarMutex* GetYieldMutex(); -virtual sal_uIntPtr ReleaseYieldMutex(); -virtual voidAcquireYieldMutex( sal_uIntPtr nCount ); -virtual boolCheckYieldMutex(); +virtual comphelper::SolarMutex* GetYieldMutex() SAL_OVERRIDE; +virtual sal_uIntPtr ReleaseYieldMutex() SAL_OVERRIDE; +virtual voidAcquireYieldMutex( sal_uIntPtr nCount ) SAL_OVERRIDE; +virtual boolCheckYieldMutex() SAL_OVERRIDE; // Printing virtual SalInfoPrinter* CreateInfoPrinter ( SalPrinterQueueInfo* pQueueInfo, - ImplJobSetup* pSetupData ); -virtual voidDestroyInfoPrinter ( SalInfoPrinter* pPrinter ); -virtual SalPrinter* CreatePrinter ( SalInfoPrinter* pInfoPrinter ); -virtual voidDestroyPrinter ( SalPrinter* pPrinter ); -virtual voidGetPrinterQueueInfo( ImplPrnQueueList* pList ); -virtual voidGetPrinterQueueState ( SalPrinterQueueInfo* pInfo ); -virtual voidDeletePrinterQueueInfo ( SalPrinterQueueInfo* pInfo ); -virtual OUString GetDefaultPrinter(); + ImplJobSetup* pSetupData ) SAL_OVERRIDE; +virtual voidDestroyInfoPrinter ( SalInfoPrinter* pPrinter ) SAL_OVERRIDE; +virtual SalPrinter* CreatePrinter ( SalInfoPrinter* pInfoPrinter ) SAL_OVERRIDE; +virtual voidDestroyPrinter ( SalPrinter* pPrinter ) SAL_OVERRIDE; +virtual voidGetPrinterQueueInfo( ImplPrnQueueList* pList ) SAL_OVERRIDE; +virtual voidGetPrinterQueueState ( SalPrinterQueueInfo* pInfo ) SAL_OVERRIDE; +virtual voidDeletePrinterQueueInfo ( SalPrinterQueueInfo* pInfo ) SAL_OVERRIDE; +virtual OUStringGetDefaultPrinter() SAL_OVERRIDE; virtual voidPostPrintersChanged() = 0; -virtual voidupdatePrinterUpdate(); -virtual voidjobStartedPrinterUpdate(); -virtual voidjobEndedPrinterUpdate(); +virtual voidupdatePrinterUpdate() SAL_OVERRIDE; +virtual voidjobStartedPrinterUpdate() SAL_OVERRIDE; +virtual voidjobEndedPrinterUpdate() SAL_OVERRIDE; bool isPrinterInit() const { return mbPrinterInit; } virtual GenPspGraphics *CreatePrintGraphics() = 0; diff --git a/vcl/inc/headless/svpinst.hxx b/vcl/inc/headless/svpinst.hxx index 4090e35..d071e4c 100644 --- a/vcl/inc/headless/svpinst.hxx +++ b/vcl/inc/headless/svpinst.hxx @@ -82,8 +82,7 @@ class SvpSalInstance : public SalGenericInstance boolisFrameAlive( const SalFrame* pFrame ) const; -protected: -virtual voidDoReleaseYield( int nTimeoutMS ); +voidDoReleaseYield( int nTimeoutMS ); public: static SvpSalInstance* s_pDefaultInstance; @@ -107,13 +106,13 @@ public: boolCheckTimeout( bool bExecuteTimers = true ); // Frame -virtual SalFrame* CreateChildFrame( SystemParentData* pParent, sal_uLong nStyle ); -virtual SalFrame* CreateFrame( SalFrame* pParent, sal_uLong nStyle ); -virtual voidDestroyFrame( SalFrame* pFrame ); +virtual SalFrame* CreateChildFrame( SystemParentData* pParent, sal_uLong nStyle ) SAL_OVERRIDE; +virtual SalFrame* CreateFrame( SalFrame* pParent, sal_uLong nStyle ) SAL_OVERRIDE; +virtual voidDestroyFrame( SalFrame* pFrame ) SAL_OVERRIDE; // Object (System Child Window) -virtual SalObject* CreateObject( SalFrame* pParent, SystemWindowData* pWindowData, bool bShow = true ); -virtual voidDestroyObject( SalObject*
Contribution to Impress media controls
Hello there, I contact you as a teaching assistant from the Ensimag software engineering school from Grenoble, France. Each year, our 2nd year students are contributing to open-source projects (usually by groups of 4 students) like Firefox, Git. This year we are interested to contribute to LibreOffice, and more particularly to Impress. Many teachers, from primary schools to universities, are using presentation softwares as support for their lectures. While many of them are using free and open-source softwares like LibreOffice Impress some of them are still using Microsoft Office PowerPoint. After asking PowerPoint users why they were still using this proprietary software we found that the recurring answer was: “With Impress I cannot control efficiently my video and sound medias like I do with PowerPoint”. Indeed, a central feature for teachers, mostly in elementary school, is to be able to control animated media like short videos or sounds. In short they need to: - have multiple video/audio media on the same slide, - be able to play, pause, stop video/audio media, - be able to go scroll back and forth the audio/video media - choose a thumbnail for audio / poster frame for the video media Few weeks ago we posted an issue on freedesktop.org (https://bugs.freedesktop.org/show_bug.cgi?id=73065) to report this request. I would like this year to have a group of students to work on this ‘media control’ feature. For that I would like to discuss about that with the developer community (you guys). It would be awesome to have a referent developer actively involved in Impress to be in contact with the students and provide insights on how to address this improvement. Best, Rémi - -- Rémi Barraquand, Phd VP of Engineering at Carnot-LSI http://remibarraquand.com -- View this message in context: http://nabble.documentfoundation.org/Contribution-to-Impress-media-controls-tp4102996.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Depends on||76607 --- Comment #118 from Laurent BP jumbo4...@yahoo.fr --- Add bug 76607: Calc crash when sorting in specific case -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz
vcl/headless/svpframe.cxx |6 +++ vcl/headless/svpgdi.cxx | 35 ++--- vcl/inc/headless/svpgdi.hxx | 36 +- vcl/quartz/salgdi.cxx | 86 +--- vcl/quartz/salgdicommon.cxx | 12 -- 5 files changed, 41 insertions(+), 134 deletions(-) New commits: commit 628b07cfc0417e87a6f2558543608aba04089d6a Author: Tor Lillqvist t...@collabora.com Date: Mon Mar 24 19:02:37 2014 +0200 Seems we don't need any basebmp stuff in AquaSalGraphics on iOS No repeatable visible differences in TiledLibreOffice for my test docs. Probably we should unify the iOS vcl code even harder with the OS X code, get rid of the last remains of the pre-tiled-rendering basebmp bitmap-based stuff. Change-Id: I2484585d3d0ef5ce758d0a654717d23464464c1a diff --git a/vcl/headless/svpframe.cxx b/vcl/headless/svpframe.cxx index 68aa4d0..6e12d6a 100644 --- a/vcl/headless/svpframe.cxx +++ b/vcl/headless/svpframe.cxx @@ -170,7 +170,9 @@ void SvpSalFrame::LoseFocus() SalGraphics* SvpSalFrame::AcquireGraphics() { SvpSalGraphics* pGraphics = new SvpSalGraphics(); +#ifndef IOS pGraphics-setDevice( m_aFrame ); +#endif m_aGraphics.push_back( pGraphics ); return pGraphics; } @@ -293,7 +295,11 @@ void SvpSalFrame::SetPosSize( long nX, long nY, long nWidth, long nHeight, sal_u // update device in existing graphics for( std::list SvpSalGraphics* ::iterator it = m_aGraphics.begin(); it != m_aGraphics.end(); ++it ) +{ +#ifndef IOS (*it)-setDevice( m_aFrame ); +#endif +} } if( m_bVisible ) m_pInstance-PostEvent( this, NULL, SALEVENT_RESIZE ); diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx index 4ba8ca0..e7c458c 100644 --- a/vcl/headless/svpgdi.cxx +++ b/vcl/headless/svpgdi.cxx @@ -88,9 +88,6 @@ bool SvpSalGraphics::drawAlphaRect( long /*nX*/, long /*nY*/, long /*nWidth*/, l // TODO(P3) implement alpha blending return false; } -#endif - -#ifndef IOS SvpSalGraphics::SvpSalGraphics() : m_bUseLineColor( true ), @@ -110,14 +107,11 @@ SvpSalGraphics::~SvpSalGraphics() { } -#endif - void SvpSalGraphics::setDevice( basebmp::BitmapDeviceSharedPtr rDevice ) { m_aOrigDevice = rDevice; ResetClipRegion(); -#ifndef IOS // determine matching bitmap format for masks basebmp::Format nDeviceFmt = m_aDevice-getScanlineFormat(); switch( nDeviceFmt ) @@ -136,9 +130,10 @@ void SvpSalGraphics::setDevice( basebmp::BitmapDeviceSharedPtr rDevice ) m_eTextFmt = basebmp::FORMAT_ONE_BIT_LSB_GREY; break; } -#endif } +#endif + void SvpSalGraphics::GetResolution( sal_Int32 rDPIX, sal_Int32 rDPIY ) { rDPIX = rDPIY = 96; @@ -151,8 +146,6 @@ sal_uInt16 SvpSalGraphics::GetBitCount() const return SvpSalBitmap::getBitCountFromScanlineFormat( m_aDevice-getScanlineFormat() ); } -#endif - long SvpSalGraphics::GetGraphicsWidth() const { if( m_aDevice.get() ) @@ -163,8 +156,6 @@ long SvpSalGraphics::GetGraphicsWidth() const return 0; } -#ifndef IOS - void SvpSalGraphics::ResetClipRegion() { m_aDevice = m_aOrigDevice; @@ -174,8 +165,6 @@ void SvpSalGraphics::ResetClipRegion() } -#endif - // verify clip for the whole area is setup void SvpSalGraphics::ensureClip() { @@ -284,8 +273,6 @@ bool SvpSalGraphics::isClippedSetup( const basegfx::B2IBox aRange, SvpSalGraphi return false; } -#ifndef IOS - // Clipping by creating unconditional mask bitmaps is horribly // slow so defer it, as much as possible. It is common to get // 3 rectangles pushed, and have to create a vast off-screen @@ -389,7 +376,6 @@ void SvpSalGraphics::SetROPFillColor( SalROPColor nROPColor ) } -#ifndef IOS void SvpSalGraphics::drawPixel( long nX, long nY ) { if( m_bUseLineColor ) @@ -562,8 +548,6 @@ bool SvpSalGraphics::drawPolyPolygon( const basegfx::B2DPolyPolygon, double /*f return false; } -#endif - void SvpSalGraphics::copyArea( long nDestX, long nDestY, long nSrcX, @@ -603,7 +587,6 @@ void SvpSalGraphics::copyBits( const SalTwoRect rPosAry, dbgOut( m_aDevice ); } -#ifndef IOS void SvpSalGraphics::drawBitmap( const SalTwoRect rPosAry, const SalBitmap rSalBitmap ) { @@ -678,8 +661,6 @@ void SvpSalGraphics::drawMask( const SalTwoRect rPosAry, dbgOut( m_aDevice ); } -#endif - SalBitmap* SvpSalGraphics::getBitmap( long nX, long nY, long nWidth, long nHeight ) { basebmp::BitmapDeviceSharedPtr aCopy = @@ -697,16 +678,12 @@ SalBitmap* SvpSalGraphics::getBitmap( long nX, long nY, long nWidth, long nHeigh return pBitmap; } -#endif - SalColor SvpSalGraphics::getPixel( long nX, long nY ) { basebmp::Color aColor( m_aOrigDevice-getPixel( basegfx::B2IPoint( nX, nY ) ) );
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/headless/svpgdi.hxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 1c00c606d125330026689192a8146c95084118ca Author: Tor Lillqvist t...@collabora.com Date: Wed Mar 26 11:24:44 2014 +0200 Return two accidentally removed member functions Change-Id: Ideef97c6ddcde9a3c324084a53792c965c7b6707 diff --git a/vcl/inc/headless/svpgdi.hxx b/vcl/inc/headless/svpgdi.hxx index fdcd5ea..bf4effd 100644 --- a/vcl/inc/headless/svpgdi.hxx +++ b/vcl/inc/headless/svpgdi.hxx @@ -77,6 +77,8 @@ private: ClipUndoHandle( SvpSalGraphics *pGfx ) : m_rGfx( *pGfx ) {} ~ClipUndoHandle(); }; +bool isClippedSetup( const basegfx::B2IBox aRange, ClipUndoHandle rUndo ); +void ensureClip(); public: void setDevice( basebmp::BitmapDeviceSharedPtr rDevice ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/inc sc/source
sc/inc/tokenarray.hxx |2 sc/source/core/data/column.cxx | 15 +++- sc/source/core/data/formulacell.cxx |2 sc/source/core/tool/token.cxx | 135 4 files changed, 108 insertions(+), 46 deletions(-) New commits: commit 0568f9f55b0054629e86561e96e78ecf13a8df5f Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Tue Mar 25 22:34:18 2014 -0400 fdo#74322: Handle moving of named ranges correctly. But named ranges are adjusted if and only if the references are absolute. Change-Id: I6c5287b413884b045f1a798c6c6683aa17863f24 (cherry picked from commit 003a27a14d5cf65fe0b528b6d6015e37a64dbb8e) Reviewed-on: https://gerrit.libreoffice.org/8756 Reviewed-by: Andras Timar andras.ti...@collabora.com Tested-by: Andras Timar andras.ti...@collabora.com diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx index 58ff8d4..5b3e080 100644 --- a/sc/inc/tokenarray.hxx +++ b/sc/inc/tokenarray.hxx @@ -164,6 +164,8 @@ public: */ sc::RefUpdateResult AdjustReferenceInName( const sc::RefUpdateContext rCxt, const ScAddress rPos ); +sc::RefUpdateResult AdjustReferenceInMovedName( const sc::RefUpdateContext rCxt, const ScAddress rPos ); + /** * Adjust all references on sheet deletion. * diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 7a448fd..518766d 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -2529,8 +2529,21 @@ class UpdateRefOnNonCopy : std::unary_functionFormulaGroup, void bRecalcOnMove = aPos != aOldPos; sc::RefUpdateResult aRes = pCode-AdjustReferenceOnMove(*mpCxt, aOldPos, aPos); -if (aRes.mbReferenceModified || bRecalcOnMove) + +if (aRes.mbReferenceModified || aRes.mbNameModified || bRecalcOnMove) { +sc::AutoCalcSwitch(mpCxt-mrDoc, false); + +if (aRes.mbNameModified) +{ +// We need to re-compile the token array when a range name is +// modified, to correctly reflect the new references in the +// name. +ScCompiler aComp(mpCxt-mrDoc, aPos, *pCode); +aComp.SetGrammar(mpCxt-mrDoc.GetGrammar()); +aComp.CompileTokenArray(); +} + // Perform end-listening, start-listening, and dirtying on all // formula cells in the group. diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index eb40441..10c4c14 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -2801,7 +2801,7 @@ bool ScFormulaCell::UpdateReferenceOnMove( { // Update cell or range references. sc::RefUpdateResult aRes = pCode-AdjustReferenceOnMove(rCxt, aOldPos, aPos); -bRefModified = aRes.mbReferenceModified; +bRefModified = aRes.mbReferenceModified || aRes.mbNameModified; bValChanged = aRes.mbValueChanged; } diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 77cc06d..5618ed38 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -2634,6 +2634,19 @@ bool expandRangeByEdge( const sc::RefUpdateContext rCxt, ScRange rRefRange, co return false; } +bool isNameModified( const sc::UpdatedRangeNames rUpdatedNames, SCTAB nOldTab, const formula::FormulaToken rToken ) +{ +if (rToken.GetOpCode() != ocName) +return false; + +SCTAB nTab = -1; +if (!rToken.IsGlobal()) +nTab = nOldTab; + +// Check if this named expression has been modified. +return rUpdatedNames.isNameUpdated(nTab, rToken.GetIndex()); +} + } sc::RefUpdateResult ScTokenArray::AdjustReferenceOnShift( const sc::RefUpdateContext rCxt, const ScAddress rOldPos ) @@ -2772,17 +2785,8 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceOnShift( const sc::RefUpdateCon break; case svIndex: { -const formula::FormulaToken* pToken = *p; -if (pToken-GetOpCode() == ocName) -{ -SCTAB nTab = -1; -if (!pToken-IsGlobal()) -nTab = rOldPos.Tab(); - -// Check if this named expression has been modified. -if (rCxt.maUpdatedNames.isNameUpdated(nTab, pToken-GetIndex())) -aRes.mbNameModified = true; -} +if (isNameModified(rCxt.maUpdatedNames, rOldPos.Tab(), **p)) +aRes.mbNameModified = true; } break; default: @@ -2837,6 +2841,12 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceOnMove( rRef.SetRange(aAbs, rNewPos); } break; +case svIndex: +{ +if (isNameModified(rCxt.maUpdatedNames,
[Libreoffice-commits] core.git: chart2/source
chart2/source/tools/OPropertySet.cxx | 17 + chart2/source/view/charttypes/Splines.cxx | 24 +--- 2 files changed, 18 insertions(+), 23 deletions(-) New commits: commit 3952fab4edb68608dee1e20750a826c6e0c1a417 Author: Takeshi Abe t...@fixedpoint.jp Date: Wed Mar 26 19:01:15 2014 +0900 Avoid possible resource leaks by boost::scoped_array Change-Id: I8b57f970b31b12902e3772c3306b71379b8d3fe5 diff --git a/chart2/source/tools/OPropertySet.cxx b/chart2/source/tools/OPropertySet.cxx index aa4ca40..09a5686 100644 --- a/chart2/source/tools/OPropertySet.cxx +++ b/chart2/source/tools/OPropertySet.cxx @@ -25,6 +25,7 @@ #include vector #include algorithm +#include boost/scoped_array.hpp using namespace ::com::sun::star; @@ -147,11 +148,11 @@ Sequence beans::PropertyState SAL_CALL { cppu::IPropertyArrayHelper rPH = getInfoHelper(); -sal_Int32 * pHandles = new sal_Int32[ aPropertyName.getLength() ]; -rPH.fillHandles( pHandles, aPropertyName ); +boost::scoped_arraysal_Int32 pHandles(new sal_Int32[ aPropertyName.getLength() ]); +rPH.fillHandles( pHandles.get(), aPropertyName ); -::std::vector sal_Int32 aHandles( pHandles, pHandles + aPropertyName.getLength()); -delete[] pHandles; +::std::vector sal_Int32 aHandles( pHandles.get(), pHandles.get() + aPropertyName.getLength()); +pHandles.reset(); return m_pImplProperties-GetPropertyStatesByHandle( aHandles ); } @@ -198,11 +199,11 @@ void SAL_CALL { cppu::IPropertyArrayHelper rPH = getInfoHelper(); -sal_Int32 * pHandles = new sal_Int32[ aPropertyNames.getLength() ]; -rPH.fillHandles( pHandles, aPropertyNames ); +boost::scoped_arraysal_Int32 pHandles(new sal_Int32[ aPropertyNames.getLength() ]); +rPH.fillHandles( pHandles.get(), aPropertyNames ); -::std::vector sal_Int32 aHandles( pHandles, pHandles + aPropertyNames.getLength()); -delete[] pHandles; +::std::vector sal_Int32 aHandles( pHandles.get(), pHandles.get() + aPropertyNames.getLength()); +pHandles.reset(); m_pImplProperties-SetPropertiesToDefault( aHandles ); } diff --git a/chart2/source/view/charttypes/Splines.cxx b/chart2/source/view/charttypes/Splines.cxx index e770b4b..419fb9a 100644 --- a/chart2/source/view/charttypes/Splines.cxx +++ b/chart2/source/view/charttypes/Splines.cxx @@ -23,6 +23,7 @@ #include vector #include algorithm #include functional +#include boost/scoped_array.hpp #define MAX_BSPLINE_DEGREE 15 @@ -727,30 +728,29 @@ void SplineCalculater::CalculateBSplines( continue; // need at least 2 points, degree p needs at least n+1 points // next piece of series -double* t = new double [n+1]; -if (!createParameterT(aPointsIn, t)) +boost::scoped_arraydouble t(new double [n+1]); +if (!createParameterT(aPointsIn, t.get())) { -delete[] t; continue; // next piece of series } lcl_tSizeType m = n + p + 1; -double* u = new double [m+1]; -createKnotVector(n, p, t, u); +boost::scoped_arraydouble u(new double [m+1]); +createKnotVector(n, p, t.get(), u.get()); // The matrix N contains the B-spline basis functions applied to parameters. // In each row only p+1 adjacent elements are non-zero. The starting // column in a higher row is equal or greater than in the lower row. // To store this matrix the non-zero elements are shifted to column 0 // and the amount of shifting is remembered in an array. -double** aMatN = new double*[n+1]; +boost::scoped_arraydouble* aMatN(new double*[n+1]); for (lcl_tSizeType row = 0; row =n; ++row) { aMatN[row] = new double[p+1]; for (sal_uInt32 col = 0; col = p; ++col) aMatN[row][col] = 0.0; } -lcl_tSizeType* aShift = new lcl_tSizeType[n+1]; +boost::scoped_arraylcl_tSizeType aShift(new lcl_tSizeType[n+1]); aMatN[0][0] = 1.0; //all others are zero aShift[0] = 0; aMatN[n][0] = 1.0; @@ -770,7 +770,7 @@ void SplineCalculater::CalculateBSplines( // index in reduced matrix aMatN = (index in full matrix N) - (i-p) aShift[k] = i - p; -applyNtoParameterT(i, t[k], p, u, aMatN[k]); +applyNtoParameterT(i, t[k], p, u.get(), aMatN[k]); } // next row k // Get matrix C of control points from the matrix equation aMatN * C = aPointsIn @@ -886,7 +886,7 @@ void SplineCalculater::CalculateBSplines( pNewX[nNewSize -1 ] = aPointsIn[n].first; pNewY[nNewSize -1 ] = aPointsIn[n].second; pNewZ[nNewSize -1 ] = fZCoordinate; -double* aP = new double[m+1]; +boost::scoped_arraydouble aP(new double[m+1]); lcl_tSizeType nLow = 0; for ( lcl_tSizeType
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - extensions.lst
extensions.lst |4 1 file changed, 4 insertions(+) New commits: commit b885f48409b140f6312e3027ade222e0b9fb907d Author: Andrea Pescetti pesce...@apache.org Date: Wed Mar 26 08:46:00 2014 + #i124423# Bundle Portuguese dictionary. diff --git a/extensions.lst b/extensions.lst index 4e35e03..6c6b680 100644 --- a/extensions.lst +++ b/extensions.lst @@ -135,4 +135,8 @@ [ language=pl ] a69f9221864b1360e38ff3f0b0cc9222 http://sourceforge.net/projects/aoo-extensions/files/806/4/pl-dict.oxt/download pl-dict.oxt +# Portuguese (European). +[ language=pt || language=pt_PT ] +ad882aa5fcd1b48ebc2421b0d25ee178 http://sourceforge.net/projects/aoo-extensions/files/1196/27/oo3x-pt-pt-14.1.1.1.oxt/download dict-pt.oxt + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[GSoC] Actions for mentors: rate students
Hi all, If you're not a mentor for GSoC, you can stop reading here: it'll save you a few seconds ;) The next steps in the GSoS process is to rate the students. So all mentors should go and review / rate the students applications on google melange: http://www.google-melange.com/gsoc/proposal/list/org/google/gsoc2014 You are also required to email how many students you can mentor to your beloved administrators (Fridrich, Thorsten and myself). This will help us select the students and ask for correct slot numbers. Regards, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
master crashes when open/save dialog opens
Hi all, Yesterday Calc crashed when trying to Save As, just when the save dialog opened, both with and without my code changes. This morning I pulled a recent codebase and rebuild. Now LibreOffice crashes also when the open dialog opens. I ran soffice.bin in gdb: Program received signal SIGSEGV, Segmentation fault. 0x7fffedd13270 in g_type_check_instance_cast () from /usr/lib64/libgobject-2.0.so.0 (gdb) backtrace #0 0x7fffedd13270 in g_type_check_instance_cast () from /usr/lib64/libgobject-2.0.so.0 #1 0x7fffdd10d549 in Oxygen::InnerShadowData::registerChild(_GtkWidget*) () from /usr/lib64/gtk-2.0/2.10.0/engines/liboxygen-gtk.so #2 0x7fffdd19e7a4 in ?? () from /usr/lib64/gtk-2.0/2.10.0/engines/liboxygen-gtk.so #3 0x7fffe65190ac in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #4 0x7fffe64ba9d5 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #5 0x7fffedcf1292 in g_closure_invoke () from /usr/lib64/libgobject-2.0.so.0 #6 0x7fffedd02a6b in ?? () from /usr/lib64/libgobject-2.0.so.0 #7 0x7fffedd0a689 in g_signal_emit_valist () from /usr/lib64/libgobject-2.0.so.0 #8 0x7fffedd0ac72 in g_signal_emit () from /usr/lib64/libgobject-2.0.so.0 #9 0x7fffe65ca864 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #10 0x7fffe6443548 in gtk_container_propagate_expose () from /usr/lib64/libgtk-x11-2.0.so.0 #11 0x7fffe640fc5a in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #12 0x7fffe64420d4 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #13 0x7fffe64ba9d5 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #14 0x7fffedcf1292 in g_closure_invoke () from /usr/lib64/libgobject-2.0.so.0 #15 0x7fffedd02a6b in ?? () from /usr/lib64/libgobject-2.0.so.0 #16 0x7fffedd0a689 in g_signal_emit_valist () from /usr/lib64/libgobject-2.0.so.0 #17 0x7fffedd0ac72 in g_signal_emit () from /usr/lib64/libgobject-2.0.so.0 #18 0x7fffe65ca864 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #19 0x7fffe6443548 in gtk_container_propagate_expose () from /usr/lib64/libgtk-x11-2.0.so.0 #20 0x7fffe64e3800 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #21 0x7fffe64420d4 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #22 0x7fffe64e2bd8 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #23 0x7fffe64ba9d5 in ?? () from /usr/lib64/libgtk-x11-2.0.so.0 #24 0x7fffedcf1292 in g_closure_invoke () from /usr/lib64/libgobject-2.0.so.0 #25 0x7fffedd02a6b in ?? () from /usr/lib64/libgobject-2.0.so.0 Any clues? It makes testing my code changes a bit difficult ;) Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] LTO parallelism
Hello, following patch increases parallelism for LTO. I tried to add -flto=+jobserver, but didn't help. Tested on trunk for x86_64 GNU/Linux. Thank you, Martin diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index a4b18a3..93d3fe7 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -98,7 +98,7 @@ ifeq ($(ENABLE_LTO),TRUE) ifeq ($(COM_GCC_IS_CLANG),TRUE) gb_LTOFLAGS := -flto else -gb_LTOFLAGS := -flto=${PARALLELISM} -fuse-linker-plugin -O2 +gb_LTOFLAGS := -flto -fuse-linker-plugin -O2 endif endif ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/rtfimport/data/relsize.rtf | 42 sw/qa/extras/rtfimport/rtfimport.cxx|9 writerfilter/source/rtftok/rtfsdrimport.cxx | 57 3 files changed, 108 insertions(+) New commits: commit bc5060b32f08b0408fb929faea1f8140a58d3cc5 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed Mar 26 11:43:31 2014 +0100 RTF import: handle Relative{Height,Width}{,Relation} Change-Id: Ic3a578af9c0808b188a4d196b1c132c0b23f15f7 diff --git a/sw/qa/extras/rtfimport/data/relsize.rtf b/sw/qa/extras/rtfimport/data/relsize.rtf new file mode 100644 index 000..b32186a --- /dev/null +++ b/sw/qa/extras/rtfimport/data/relsize.rtf @@ -0,0 +1,42 @@ +{\rtf1 +\paperw12240\paperh15840\margl1417\margr1417\margt1417\margb1417 +\pard\plain +{\rtlch +{\shp +{\*\shpinst\shpleft0\shptop0\shpright3739\shpbottom2211\shpwr2\shpwrk0\shpfblwtxt0\shpz0 +{\sp +{\sn shapeType} +{\sv 202} +} +{\sp +{\sn posh} +{\sv 2} +} +{\sp +{\sn dhgt} +{\sv 251659264} +} +{\sp +{\sn fBehindDocument} +{\sv 0} +} +{\sp +{\sn pctHoriz} +{\sv 400} +} +{\sp +{\sn pctVert} +{\sv 200} +} +{\sp +{\sn sizerelv} +{\sv 0} +} +{\shptxt Textbox text. +\par} +} +} +} +{Relative height: 20%, margin.\par} +{Relative width: 40%, page.\par} +} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index cb19476..738d1e2 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -1619,6 +1619,15 @@ DECLARE_RTFIMPORT_TEST(testDprectAnchor, dprect-anchor.rtf) CPPUNIT_ASSERT_EQUAL(text::TextContentAnchorType_AT_CHARACTER, getPropertytext::TextContentAnchorType(getShape(1), AnchorType)); } +DECLARE_RTFIMPORT_TEST(testRelsize, relsize.rtf) +{ +uno::Referencedrawing::XShape xShape = getShape(1); +CPPUNIT_ASSERT_EQUAL(sal_Int16(40), getPropertysal_Int16(xShape, RelativeWidth)); +CPPUNIT_ASSERT_EQUAL(text::RelOrientation::PAGE_FRAME, getPropertysal_Int16(xShape, RelativeWidthRelation)); +CPPUNIT_ASSERT_EQUAL(sal_Int16(20), getPropertysal_Int16(xShape, RelativeHeight)); +CPPUNIT_ASSERT_EQUAL(text::RelOrientation::FRAME, getPropertysal_Int16(xShape, RelativeHeightRelation)); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/rtftok/rtfsdrimport.cxx b/writerfilter/source/rtftok/rtfsdrimport.cxx index d9871d9..4b87586 100644 --- a/writerfilter/source/rtftok/rtfsdrimport.cxx +++ b/writerfilter/source/rtftok/rtfsdrimport.cxx @@ -242,6 +242,10 @@ void RTFSdrImport::resolve(RTFShape rShape, bool bClose) bool bOpaque = true; +boost::optionalsal_Int16 oRelativeWidth, oRelativeHeight; +sal_Int16 nRelativeWidthRelation = text::RelOrientation::PAGE_FRAME; +sal_Int16 nRelativeHeightRelation = text::RelOrientation::PAGE_FRAME; + // The spec doesn't state what is the default for shapeType, Word seems to implement it as a rectangle. if (std::find_if(rShape.aProperties.begin(), rShape.aProperties.end(), @@ -540,6 +544,49 @@ void RTFSdrImport::resolve(RTFShape rShape, bool bClose) oRelBottom.reset(TWIP_TO_MM100(i-second.toInt32())); else if (i-first == fBehindDocument) bOpaque = !i-second.toInt32(); +else if (i-first == pctHoriz || i-first == pctVert) +{ +sal_Int16 nPercentage = rtl::math::round(i-second.toDouble() / 10); +boost::optionalsal_Int16 rPercentage = i-first == pctHoriz ? oRelativeWidth : oRelativeHeight; +if (nPercentage) +rPercentage = nPercentage; +} +else if (i-first == sizerelh) +{ +if (xPropertySet.is()) +{ +switch (i-second.toInt32()) +{ +case 0: // margin +nRelativeWidthRelation = text::RelOrientation::FRAME; +break; +case 1: // page +nRelativeWidthRelation = text::RelOrientation::PAGE_FRAME; +break; +default: +SAL_WARN(writerfilter, RTFSdrImport::resolve: unhandled sizerelh value: i-second); +break; +} +} +} +else if (i-first == sizerelv) +{ +if (xPropertySet.is()) +{ +switch (i-second.toInt32()) +{ +case 0: // margin +nRelativeHeightRelation = text::RelOrientation::FRAME; +break; +case 1: // page +nRelativeHeightRelation = text::RelOrientation::PAGE_FRAME; +break; +default: +SAL_WARN(writerfilter, RTFSdrImport::resolve: unhandled sizerelv value: i-second); +break; +} +} +} else
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - b8/85f48409b140f6312e3027ade222e0b9fb907d
b8/85f48409b140f6312e3027ade222e0b9fb907d |1 + 1 file changed, 1 insertion(+) New commits: commit 19e5472e425f3b7bebdc01c14da82e1de2f4a5a0 Author: Caolán McNamara caol...@redhat.com Date: Wed Mar 26 11:38:14 2014 + Notes added by 'git notes add' diff --git a/b8/85f48409b140f6312e3027ade222e0b9fb907d b/b8/85f48409b140f6312e3027ade222e0b9fb907d new file mode 100644 index 000..07db533 --- /dev/null +++ b/b8/85f48409b140f6312e3027ade222e0b9fb907d @@ -0,0 +1 @@ +prefer: c95f482ac7ac866047864c47f87a8751e634749d ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] LTO parallelism
Hi Margin, On Wed, Mar 26, 2014 at 11:43:24AM +0100, Martin Liška mli...@suse.cz wrote: diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index a4b18a3..93d3fe7 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -98,7 +98,7 @@ ifeq ($(ENABLE_LTO),TRUE) ifeq ($(COM_GCC_IS_CLANG),TRUE) gb_LTOFLAGS := -flto else -gb_LTOFLAGS := -flto=${PARALLELISM} -fuse-linker-plugin -O2 +gb_LTOFLAGS := -flto -fuse-linker-plugin -O2 endif endif Isn't this accidentally a reverse patch? Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - svx/source
svx/source/svdraw/svdotext.cxx |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) New commits: commit 6f2ce153c4bd7350487809d87e72619d5cd9764e Author: Armin Le Grand a...@apache.org Date: Wed Mar 26 11:54:52 2014 + i124389 for tables refresh TextFrame when OutlinerParaObject changes diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx index 41eee32..59cf55b 100644 --- a/svx/source/svdraw/svdotext.cxx +++ b/svx/source/svdraw/svdotext.cxx @@ -63,6 +63,7 @@ #include drawinglayer/geometry/viewinformation2d.hxx #include vcl/virdev.hxx #include basegfx/matrix/b2dhommatrixtools.hxx +#include svx/svdotable.hxx // @@ -1500,8 +1501,11 @@ void SdrTextObj::NbcSetOutlinerParaObjectForText( OutlinerParaObject* pTextObjec } SetTextSizeDirty(); -if (IsTextFrame() (IsAutoGrowHeight() || IsAutoGrowWidth())) -{ // Textrahmen anpassen! + +// #124389# also need to call NbcAdjustTextFrameWidthAndHeight when we are a table object (triggered from undo) +if((IsTextFrame() || 0 != dynamic_cast sdr::table::SdrTableObj* (this)) (IsAutoGrowHeight() || IsAutoGrowWidth())) +{ +// adapt text frame NbcAdjustTextFrameWidthAndHeight(); } if (!IsTextFrame()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] LTO parallelism
Sure, there's correct patch. Martin On 03/26/2014 12:59 PM, Miklos Vajna wrote: Hi Margin, On Wed, Mar 26, 2014 at 11:43:24AM +0100, Martin Liška mli...@suse.cz wrote: diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index a4b18a3..93d3fe7 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -98,7 +98,7 @@ ifeq ($(ENABLE_LTO),TRUE) ifeq ($(COM_GCC_IS_CLANG),TRUE) gb_LTOFLAGS := -flto else -gb_LTOFLAGS := -flto=${PARALLELISM} -fuse-linker-plugin -O2 +gb_LTOFLAGS := -flto -fuse-linker-plugin -O2 endif endif Isn't this accidentally a reverse patch? Miklos diff --git a/solenv/gbuild/platform/com_GCC_defs.mk b/solenv/gbuild/platform/com_GCC_defs.mk index 93d3fe7..a4b18a3 100644 --- a/solenv/gbuild/platform/com_GCC_defs.mk +++ b/solenv/gbuild/platform/com_GCC_defs.mk @@ -98,7 +98,7 @@ ifeq ($(ENABLE_LTO),TRUE) ifeq ($(COM_GCC_IS_CLANG),TRUE) gb_LTOFLAGS := -flto else -gb_LTOFLAGS := -flto -fuse-linker-plugin -O2 +gb_LTOFLAGS := -flto=${PARALLELISM} -fuse-linker-plugin -O2 endif endif ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - include/sot
include/sot/object.hxx | 180 ++-- include/sot/storage.hxx | 20 - 2 files changed, 27 insertions(+), 173 deletions(-) New commits: commit 12d30ef0ca9418d6dfa75e2a95f5213961b2fa21 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 26 12:28:00 2014 +0100 Remove unused macros Change-Id: Ib4838eacd9240664327292bf12c7a14a8cdfbcf1 diff --git a/include/sot/object.hxx b/include/sot/object.hxx index 734ea3e..fb34846 100644 --- a/include/sot/object.hxx +++ b/include/sot/object.hxx @@ -25,18 +25,6 @@ #include tools/ref.hxx #include sot/sotdllapi.h -#define SO2_DECL_BASIC_CLASS(ClassName) \ -private: \ -static SotFactory *pFactory; \ -static SotFactory ** GetFactoryAdress() { return pFactory; }\ -public: \ -static void * CreateInstance( SotObject ** = NULL ); \ -static SotFactory *ClassFactory(); \ -virtual const SotFactory * GetSvFactory() const; \ -virtual void *Cast( const SotFactory * ); - -/** -**/ #define SO2_IMPL_BASIC_CLASS_DLL(ClassName,FactoryName,GlobalName)\ SotFactory * ClassName::ClassFactory() \ { \ @@ -67,12 +55,6 @@ void * ClassName::Cast( const SotFactory * pFact ) \ return pRet; \ } -#define SO2_IMPL_BASIC_CLASS(ClassName,FactoryName,GlobalName) \ -SotFactory * ClassName::pFactory = NULL; \ -SO2_IMPL_BASIC_CLASS_DLL(ClassName,FactoryName,GlobalName) - -/** -**/ #define SO2_IMPL_BASIC_CLASS1_DLL(ClassName,FactoryName,Super1,GlobalName)\ SotFactory * ClassName::ClassFactory() \ { \ @@ -108,145 +90,6 @@ void * ClassName::Cast( const SotFactory * pFact ) \ return pRet; \ } -#define SO2_IMPL_BASIC_CLASS1(ClassName,FactoryName,Super1,GlobalName)\ -SotFactory * ClassName::pFactory = NULL; \ -SO2_IMPL_BASIC_CLASS1_DLL(ClassName,FactoryName,Super1,GlobalName) - -/** -**/ -#define SO2_IMPL_BASIC_CLASS2_DLL(ClassName,FactoryName,Super1,Super2,GlobalName) \ -SotFactory * ClassName::ClassFactory() \ -{ \ -SotFactory **ppFactory = GetFactoryAdress(); \ -if( !*ppFactory ) \ -{ \ -*ppFactory = new FactoryName( GlobalName, \ -OUString( #ClassName ), ClassName::CreateInstance ); \ -(*ppFactory)-PutSuperClass( Super1::ClassFactory() );\ -(*ppFactory)-PutSuperClass( Super2::ClassFactory() );\ -} \ -return *ppFactory;\ -} \ -void * ClassName::CreateInstance( SotObject ** ppObj )\ -{ \ -ClassName * p = new ClassName(); \ -if( ppObj ) \ -*ppObj = p; \ -return p; \ -} \ -const SotFactory * ClassName::GetSvFactory() const\ -{ \ -return ClassFactory();\ -} \ -void * ClassName::Cast( const SotFactory * pFact )\ -{
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/outdev.hxx | 37 +++-- include/vcl/print.hxx |4 vcl/source/gdi/outdev2.cxx | 44 +++- vcl/source/gdi/print.cxx | 21 + 4 files changed, 63 insertions(+), 43 deletions(-) New commits: commit 4daafe4c153ca52d045d726799d4b1753142 Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sun Mar 23 21:50:42 2014 +1100 fdo#74702 Move device specific bitmap drawing to its own function Device specific drawing has been moved to its own function. VirtualDevice and Window draw in the same way, so can be shared in OutputDevice, however Printer has its only specific ways of drawing so it needs its own method. Change-Id: I051fee029a1ec022a131bb12588189178c4109b2 Reviewed-on: https://gerrit.libreoffice.org/8724 Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com Tested-by: Chris Sherlock chris.sherloc...@gmail.com diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index fbeae4b..7350a15 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -832,7 +832,13 @@ protected: basegfx::B2DRange aVisibleRange, double fMaximumArea); -virtual voidScaleBitmap ( Bitmap rBmp, SalTwoRect rPosAry ); + virtual void ScaleBitmap ( Bitmap rBmp, SalTwoRect rPosAry ); + +virtual voidDrawDeviceBitmap( +const Point rDestPt, const Size rDestSize, +const Point rSrcPtPixel, const Size rSrcSizePixel, +BitmapEx rBitmapEx ); + private: typedef void ( OutputDevice::* FontUpdateHandler_t )( bool ); @@ -845,7 +851,7 @@ private: SAL_DLLPRIVATE static void ImplUpdateFontDataForAllFrames( FontUpdateHandler_t pHdl, bool bNewFontLists ); SAL_DLLPRIVATE long ImplGetGradientSteps( const Gradient rGradient, const Rectangle rRect, bool bMtf ); -//not implemented; to detect misuses of DrawOutDev(...OutputDevice); +// not implemented; to detect misuses of DrawOutDev(...OutputDevice); void DrawOutDev( const Point, const Size, const Point, const Size, const Printer); public: @@ -1039,6 +1045,9 @@ public: virtual voidDrawOutDev( const Point rDestPt, const Size rDestSize, const Point rSrcPt, const Size rSrcSize, const OutputDevice rOutDev ); +voidDrawOutDev( const Point rDestPt, const Size rDestSize, +const Point rSrcPt, const Size rSrcSize, +const Printer rOutDev ); virtual voidCopyArea( const Point rDestPt, const Point rSrcPt, const Size rSrcSize, sal_uInt16 nFlags = 0 ); @@ -1141,25 +1150,25 @@ public: BitmapExGetBitmapEx( const Point rSrcPt, const Size rSize ) const; voidEnableMapMode( bool bEnable = true ); -boolIsMapModeEnabled() const { return mbMap; } +boolIsMapModeEnabled() const { return mbMap; } // Enabling/disabling RTL only makes sense for OutputDevices that use a mirroring SalGraphisLayout -virtual voidEnableRTL( bool bEnable = true); -boolIsRTLEnabled() const { return mbEnableRTL; } +voidEnableRTL( bool bEnable = true); +boolIsRTLEnabled() const { return mbEnableRTL; } voidSetConnectMetaFile( GDIMetaFile* pMtf ); GDIMetaFile*GetConnectMetaFile() const { return mpMetaFile; } voidEnableOutput( bool bEnable = true ); -boolIsOutputEnabled() const { return mbOutput; } -boolIsDeviceOutput() const { return mbDevOutput; } -boolIsDeviceOutputNecessary() const { return (mbOutput mbDevOutput); } -boolIsOutputNecessary() const { return ((mbOutput mbDevOutput) || (mpMetaFile != NULL)); } +boolIsOutputEnabled() const { return mbOutput; } +boolIsDeviceOutput() const { return mbDevOutput; } +boolIsDeviceOutputNecessary() const { return (mbOutput mbDevOutput); } +boolIsOutputNecessary() const { return ((mbOutput mbDevOutput) || (mpMetaFile != NULL)); } voidSetClipRegion(); voidSetClipRegion( const Region rRegion ); Region GetClipRegion()
[Libreoffice-commits] core.git: helpcontent2 include/vcl
helpcontent2 |2 +- include/vcl/outdev.hxx |3 --- 2 files changed, 1 insertion(+), 4 deletions(-) New commits: commit 29bea73595b1c5dc8ee6c311ae3f43e3345448bb Author: Chris Sherlock chris.sherloc...@gmail.com Date: Wed Mar 26 23:32:52 2014 +1100 fdo#74702 Followup to 4daafe4c1$53ca52d045d726799d4b1753142 Forgot to commit... oops! Change-Id: If73bdb2acb3fdba7e155d6f4ed2b6a249829db0e Reviewed-on: https://gerrit.libreoffice.org/8757 Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com Tested-by: Chris Sherlock chris.sherloc...@gmail.com diff --git a/helpcontent2 b/helpcontent2 index 2b799e2..2dad754 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2b799e21a07d93f7b997bb1f3fa85e8cffb19356 +Subproject commit 2dad7542c215024cd26ae42030e01ab772f2f9d5 diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 7350a15..013c4ac 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -1045,9 +1045,6 @@ public: virtual voidDrawOutDev( const Point rDestPt, const Size rDestSize, const Point rSrcPt, const Size rSrcSize, const OutputDevice rOutDev ); -voidDrawOutDev( const Point rDestPt, const Size rDestSize, -const Point rSrcPt, const Size rSrcSize, -const Printer rOutDev ); virtual voidCopyArea( const Point rDestPt, const Point rSrcPt, const Size rSrcSize, sal_uInt16 nFlags = 0 ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] LTO parallelism
On 03/26/2014 11:43 AM, Martin Liška wrote: following patch increases parallelism for LTO. I tried to add -flto=+jobserver, but didn't help. According to http://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/Optimize-Options.html#index-flto-891, the + needs to go at the start of the Make recipe line, not in front of jobserver. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/vcl
include/vcl/outdev.hxx | 214 - 1 file changed, 107 insertions(+), 107 deletions(-) New commits: commit b467b85817dfb11b8f481e0cbf853b67b48e991d Author: Chris Sherlock chris.sherloc...@gmail.com Date: Wed Mar 26 23:44:06 2014 +1100 Fix tab spacing in include/vcl/outdev.hxx Change-Id: I98eb64ee6ebad72b534bac8a467a9a334876c2e6 Reviewed-on: https://gerrit.libreoffice.org/8758 Tested-by: Chris Sherlock chris.sherloc...@gmail.com Reviewed-by: Chris Sherlock chris.sherloc...@gmail.com diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 013c4ac..9b115de 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -267,94 +267,94 @@ class VCL_DLLPUBLIC OutputDevice friend void ImplHandleResize( Window* pWindow, long nNewWidth, long nNewHeight ); private: -mutable SalGraphics*mpGraphics; /// Graphics context to draw on -mutable OutputDevice* mpPrevGraphics; /// Previous output device in list -mutable OutputDevice* mpNextGraphics; /// Next output device in list -GDIMetaFile*mpMetaFile; -mutable ImplFontEntry* mpFontEntry; -mutable ImplFontCache* mpFontCache; +mutable SalGraphics*mpGraphics; /// Graphics context to draw on +mutable OutputDevice* mpPrevGraphics; /// Previous output device in list +mutable OutputDevice* mpNextGraphics; /// Next output device in list +GDIMetaFile*mpMetaFile; +mutable ImplFontEntry* mpFontEntry; +mutable ImplFontCache* mpFontCache; mutable PhysicalFontCollection* mpFontCollection; -mutable ImplGetDevFontList* mpGetDevFontList; -mutable ImplGetDevSizeList* mpGetDevSizeList; -ImplObjStack* mpObjStack; -ImplOutDevData* mpOutDevData; -VCLXGraphicsList_impl* mpUnoGraphicsList; -vcl::PDFWriterImpl* mpPDFWriter; -vcl::ExtOutDevData* mpExtOutDevData; +mutable ImplGetDevFontList* mpGetDevFontList; +mutable ImplGetDevSizeList* mpGetDevSizeList; +ImplObjStack* mpObjStack; +ImplOutDevData* mpOutDevData; +VCLXGraphicsList_impl* mpUnoGraphicsList; +vcl::PDFWriterImpl* mpPDFWriter; +vcl::ExtOutDevData* mpExtOutDevData; // TEMP TEMP TEMP -VirtualDevice* mpAlphaVDev; +VirtualDevice* mpAlphaVDev; /// Additional output pixel offset, applied in LogicToPixel (used by SetPixelOffset/GetPixelOffset) -longmnOutOffOrigX; +longmnOutOffOrigX; /// Additional output offset in _logical_ coordinates, applied in PixelToLogic (used by SetPixelOffset/GetPixelOffset) -longmnOutOffLogicX; +longmnOutOffLogicX; /// Additional output pixel offset, applied in LogicToPixel (used by SetPixelOffset/GetPixelOffset) -longmnOutOffOrigY; +longmnOutOffOrigY; /// Additional output offset in _logical_ coordinates, applied in PixelToLogic (used by SetPixelOffset/GetPixelOffset) -longmnOutOffLogicY; +longmnOutOffLogicY; /// Output offset for device output in pixel (pseudo window offset within window system's frames) -longmnOutOffX; +longmnOutOffX; /// Output offset for device output in pixel (pseudo window offset within window system's frames) -longmnOutOffY; -longmnOutWidth; -longmnOutHeight; -sal_Int32 mnDPIX; -sal_Int32 mnDPIY; -sal_Int32 mnDPIScaleFactor; /// For Hi-DPI displays, we want to draw everything mnDPIScaleFactor-times larger +longmnOutOffY; +longmnOutWidth; +longmnOutHeight; +sal_Int32 mnDPIX; +sal_Int32 mnDPIY; +sal_Int32 mnDPIScaleFactor; /// For Hi-DPI displays, we want to draw everything mnDPIScaleFactor-times larger /// font specific text alignment offsets in pixel units -mutable longmnTextOffX; -mutable longmnTextOffY; -mutable longmnEmphasisAscent; -mutable longmnEmphasisDescent; -sal_uLong mnDrawMode; -sal_uLong mnTextLayoutMode; -ImplMapRes maMapRes; -ImplThresholdResmaThresRes; -OutDevType meOutDevType; -OutDevViewType
Contribution to Impress media controls
Hello there, I contact you as a teaching assistant from the Ensimag http://ensimag.grenoble-inp.fr/ecole-nationale-superieure-d-informatique-et-de-mathematiques-appliquees-74488.kjsp?RH=ENSIMAG_FRRF=ENSIMAG_EN software engineering school from Grenoble, France. Each year, our 2nd year students are contributing to open-source projects (usually by groups of 4 students) like Firefox, Git. This year we are interested to contribute to LibreOffice, and more particularly to Impress. Many teachers, from primary schools to universities, are using presentation softwares as support for their lectures. While many of them are using free and open-source softwares like LibreOffice Impress some of them are still using Microsoft Office PowerPoint. After asking PowerPoint users why they were still using this proprietary software we found that the recurring answer was: With Impress I cannot control efficiently my video and sound medias like I do with PowerPoint. Indeed, a central feature for teachers, mostly in elementary school, is to be able to control animated media like short videos or sounds. In short they need to: * have multiple video/audio media on the same slide, * be able to play, pause, stop video/audio media, * be able to go scroll back and forth the audio/video media * choose a thumbnail for audio / poster frame for the video media Few weeks ago we posted an issue on freedesktop.org (https://bugs.freedesktop.org/show_bug.cgi?id=73065) to report this request. I would like this year to have a group of students to work on this 'media control' feature. For that I would like to discuss about that with the developer community (you guys). It would be awesome to have a referent developer actively involved in Impress to be in contact with the students and provide insights on how to address this improvement. Best, Rémi -- Rémi Barraquand, Phd VP of Engineering at Carnot-LSI http://remibarraquand.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: master crashes when open/save dialog opens
Hi Winfried, On Wed, Mar 26, 2014 at 11:35:18AM +0100, Winfried Donkers w.donk...@dci-electronics.nl wrote: Yesterday Calc crashed when trying to Save As, just when the save dialog opened, both with and without my code changes. This morning I pulled a recent codebase and rebuild. Now LibreOffice crashes also when the open dialog opens. I ran soffice.bin in gdb: Program received signal SIGSEGV, Segmentation fault. 0x7fffedd13270 in g_type_check_instance_cast () from /usr/lib64/libgobject-2.0.so.0 (gdb) backtrace #0 0x7fffedd13270 in g_type_check_instance_cast () from /usr/lib64/libgobject-2.0.so.0 #1 0x7fffdd10d549 in Oxygen::InnerShadowData::registerChild(_GtkWidget*) () from /usr/lib64/gtk-2.0/2.10.0/engines/liboxygen-gtk.so Sounds like a gtk2-engine-oxygen / gtk2-theme-oxygen problem. What version of that do you have? I'm asking as I saw a similar problem with a fully updated openSUSE 13.1 as well, just upgrading the oxygen engine fixed the problem. Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - helpcontent2 uui/source
helpcontent2 |2 +- uui/source/ids.hrc |3 +++ uui/source/passworddlg.cxx |1 - uui/source/passworddlg.hrc | 40 uui/source/passworddlg.src |1 - 5 files changed, 4 insertions(+), 43 deletions(-) New commits: commit 586245eb1fb5a5a65f907056285be68ce56d1a50 Author: Jan Holesovsky ke...@collabora.com Date: Wed Mar 26 14:59:23 2014 +0100 Revert the unwanted submodule change. Change-Id: I725d89c5c36ce898f7340b270a40d875a13a839c diff --git a/helpcontent2 b/helpcontent2 index 2dad754..2b799e2 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 2dad7542c215024cd26ae42030e01ab772f2f9d5 +Subproject commit 2b799e21a07d93f7b997bb1f3fa85e8cffb19356 commit 57ee15e5f1ae299e2344e2bbee0da085a434bf2d Author: Jan Holesovsky ke...@collabora.com Date: Wed Mar 26 09:05:20 2014 +0100 These strings are now global resources, define them accordingly. Change-Id: Ia68249242850ef3d82cc56ceae7e5ef84dd08b5b diff --git a/uui/source/ids.hrc b/uui/source/ids.hrc index 06653b9..cc2d35e 100644 --- a/uui/source/ids.hrc +++ b/uui/source/ids.hrc @@ -70,6 +70,9 @@ #define STR_SAME_NAME_USED (RID_UUI_START + 60) #define STR_ENTER_SIMPLE_PASSWORD (RID_UUI_START + 61) #define STR_CONFIRM_SIMPLE_PASSWORD (RID_UUI_START + 62) +#define STR_TITLE_CREATE_PASSWORD (RID_UUI_START + 63) +#define STR_TITLE_ENTER_PASSWORD(RID_UUI_START + 64) +#define STR_PASSWORD_MISMATCH (RID_UUI_START + 65) #define ERRCODE_UUI_IO_ABORT (ERRCODE_AREA_UUI + 0) #define ERRCODE_UUI_IO_ACCESSDENIED (ERRCODE_AREA_UUI + 1) diff --git a/uui/source/passworddlg.cxx b/uui/source/passworddlg.cxx index 91e05e0..19c08e0 100644 --- a/uui/source/passworddlg.cxx +++ b/uui/source/passworddlg.cxx @@ -18,7 +18,6 @@ */ #include passworddlg.hxx -#include passworddlg.hrc #include ids.hrc #include vcl/msgbox.hxx diff --git a/uui/source/passworddlg.hrc b/uui/source/passworddlg.hrc deleted file mode 100644 index 4e60bba..000 --- a/uui/source/passworddlg.hrc +++ /dev/null @@ -1,40 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the License); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -#ifndef PASSWORDDLG_HRC -#define PASSWORDDLG_HRC - -// local identifiers -#define BTN_PASSWORD_OK 1 -#define ED_PASSWORD 2 -#define FT_PASSWORD 3 -#define FT_CONFIRM_PASSWORD 4 -#define ED_CONFIRM_PASSWORD 5 -#define FL_FIXED_LINE_1 6 -#define BTN_PASSWORD_HELP 7 -#define BTN_PASSWORD_CANCEL 8 - -#define STR_TITLE_CREATE_PASSWORD 9 -#define STR_TITLE_ENTER_PASSWORD 10 -#define STR_PASSWORD_MISMATCH 11 - - -#endif // PASSWORDDLG_HRC - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/uui/source/passworddlg.src b/uui/source/passworddlg.src index 874..b07346b 100644 --- a/uui/source/passworddlg.src +++ b/uui/source/passworddlg.src @@ -20,7 +20,6 @@ #define __RSC #include ids.hrc -#include passworddlg.hrc String STR_ENTER_PASSWORD_TO_OPEN { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ww8import/data/cp144.doc |binary sw/qa/extras/ww8import/ww8import.cxx |7 +++ sw/source/filter/ww8/ww8par.cxx |4 +++- 3 files changed, 10 insertions(+), 1 deletion(-) New commits: commit 8757bea2e88c6e349e1fe98d8e9695d7b9c6179e Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed Mar 26 13:34:08 2014 +0100 cp#144 DOC import: fProtEnabled means document is not totally read-only Reading the spec, it seems that we have two cases here: - if lKeyProtDoc is set and fProtEnabled is 1, then editing forms is allowed - if lKeyProtDoc is set, but fProtEnabled is 0, then the document is totally read-only So in the first case avoid the SetModifyPasswordHash() call to allow form field editing. Change-Id: Id0c48e8eb4bde75c5520a7b108fcfada51148faf diff --git a/sw/qa/extras/ww8import/data/cp144.doc b/sw/qa/extras/ww8import/data/cp144.doc new file mode 100755 index 000..ea30cc0 Binary files /dev/null and b/sw/qa/extras/ww8import/data/cp144.doc differ diff --git a/sw/qa/extras/ww8import/ww8import.cxx b/sw/qa/extras/ww8import/ww8import.cxx index 875c039..17296e4 100644 --- a/sw/qa/extras/ww8import/ww8import.cxx +++ b/sw/qa/extras/ww8import/ww8import.cxx @@ -243,6 +243,13 @@ DECLARE_WW8IMPORT_TEST(testBnc821208, bnc821208.doc) CPPUNIT_ASSERT_EQUAL(beans::PropertyState_DEFAULT_VALUE, ePropertyState); } +DECLARE_WW8IMPORT_TEST(testCp144, cp144.doc) +{ +uno::Referenceframe::XStorable xStorable(mxComponent, uno::UNO_QUERY); +// It wasn't possible to fill out this form. +CPPUNIT_ASSERT_EQUAL(false, bool(xStorable-isReadonly())); +} + DECLARE_WW8IMPORT_TEST(testCp139, cp139.doc) { // This was RTL_TEXTENCODING_SYMBOL, causing 1 rendered as a placeholder rectangle. diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 9df2cfb..ed003a2 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -1947,7 +1947,9 @@ void SwWW8ImplReader::ImportDop() } } -mpDocShell-SetModifyPasswordHash(pWDop-lKeyProtDoc); +// Still allow editing of form fields. +if (!pWDop-fProtEnabled) +mpDocShell-SetModifyPasswordHash(pWDop-lKeyProtDoc); const SvtFilterOptions rOpt = SvtFilterOptions::Get(); if (rOpt.IsUseEnhancedFields()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - Repository.mk scp2/source
Repository.mk|2 +- scp2/source/ooo/file_ooo.scp |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 809d724b6da3680f34f7e2e898aa72634a3331d7 Author: Tor Lillqvist t...@collabora.com Date: Fri Mar 7 10:52:50 2014 +0200 Fix OS X build Change-Id: I9437bee64b318754ee5dc595f35be865a21d6a11 diff --git a/Repository.mk b/Repository.mk index 578ebd4c..a3df1b4 100644 --- a/Repository.mk +++ b/Repository.mk @@ -220,7 +220,7 @@ $(eval $(call gb_Helper_register_libraries_for_install,OOOLIBS,ooo, \ canvastools \ chartcore \ chartcontroller \ - $(if $(filter $(OS),WNT),,cmdmail) \ + $(if $(filter $(OS),MACOSX WNT),,cmdmail) \ cppcanvas \ configmgr \ ctl \ diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp index 5597fe5..d08bb4c 100644 --- a/scp2/source/ooo/file_ooo.scp +++ b/scp2/source/ooo/file_ooo.scp @@ -200,7 +200,7 @@ End #endif -#ifdef UNX +#if defined UNX ! defined MACOSX File gid_File_Bin_Uri_Encode BIN_FILE_BODY; @@ -211,14 +211,14 @@ End #endif -#ifdef UNX +#if defined UNX ! defined MACOSX File gid_File_Bin_Senddoc BIN_FILE_BODY; Dir = FILELIST_DIR; Name = shell_senddoc.filelist; Styles = (FILELIST, PACKED); End -#else +#elif defined WNT File gid_File_Bin_Senddoc BIN_FILE_BODY; Dir = gid_Brand_Dir_Program; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - desktop/source
desktop/source/app/check_ext_deps.cxx |3 +++ desktop/source/deployment/misc/dp_misc.cxx |4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 3f26b006e4ef971dfa127d0e7582d369e63fa8d7 Author: Tor Lillqvist t...@collabora.com Date: Tue Feb 25 16:26:30 2014 +0200 Don't do the annoying restart thing when sandboxed on OS X, ignore risks... So far we have just displayed a hugely annoying dialog sorry, but we suck, you need to start LibreOffice again. But that sucks. So just try to do without restart then, and let's see what happens. At least in trivial testing, no crash. Change-Id: I475fe49a0fdb8086bb33a165a08b32ac46548857 diff --git a/desktop/source/app/check_ext_deps.cxx b/desktop/source/app/check_ext_deps.cxx index 23c6b92..5df901b 100644 --- a/desktop/source/app/check_ext_deps.cxx +++ b/desktop/source/app/check_ext_deps.cxx @@ -18,6 +18,7 @@ */ #include config_folders.h +#include config_features.h #include osl/file.hxx #include osl/mutex.hxx @@ -421,8 +422,10 @@ void Desktop::SynchronizeExtensionRepositories() if (m_bCleanedExtensionCache) { deployment::ExtensionManager::get(context)-reinstallDeployedExtensions( true, user, Referencetask::XAbortChannel(), silent); +#if !HAVE_FEATURE_MACOSX_SANDBOX task::OfficeRestartManager::get(context)-requestRestart( silent-getInteractionHandler()); +#endif } else { // reinstallDeployedExtensions above already calls syncRepositories // internally: diff --git a/desktop/source/deployment/misc/dp_misc.cxx b/desktop/source/deployment/misc/dp_misc.cxx index b7720e1..b815be7 100644 --- a/desktop/source/deployment/misc/dp_misc.cxx +++ b/desktop/source/deployment/misc/dp_misc.cxx @@ -18,6 +18,7 @@ */ #include config_folders.h +#include config_features.h #include dp_misc.h #include dp_version.hxx @@ -556,7 +557,7 @@ void syncRepositories( Referencetask::XAbortChannel(), xCmdEnv); } } - +#if !HAVE_FEATURE_MACOSX_SANDBOX if (bModified) { Referencetask::XRestartManager restarter(task::OfficeRestartManager::get(comphelper::getProcessComponentContext())); @@ -567,6 +568,7 @@ void syncRepositories( Referencetask::XInteractionHandler()); } } +#endif } void disposeBridges(Referencecss::uno::XComponentContext const ctx) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - chart2/source
chart2/source/inc/macros.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d4a25be3da00ca71d497e06e9f7e22c409d03cd0 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 11:11:49 2014 -0400 Re-enable the new chart type. Change-Id: If060d101c4a8f2486d3532f4048f9042df0cd204 diff --git a/chart2/source/inc/macros.hxx b/chart2/source/inc/macros.hxx index 21e5911..2319afe 100644 --- a/chart2/source/inc/macros.hxx +++ b/chart2/source/inc/macros.hxx @@ -30,7 +30,7 @@ typeid( ex ).name() , Message: \ ex.Message ) -#define ENABLE_GL3D_BARCHART 0 +#define ENABLE_GL3D_BARCHART 1 #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 60270] LibreOffice 4.1 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 73936, which changed state. Bug 73936 Summary: FILEOPEN: Can't open .doc file: Writer freezes https://bugs.freedesktop.org/show_bug.cgi?id=73936 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 64c7c193c786d355094e583e8c82bde79cf34c53 Author: Caolán McNamara caol...@redhat.com Date: Tue Mar 25 12:12:37 2014 + Resolves: rhbz#1077780 crash on loading .docx Change-Id: I92670b9c46a2c745ba47c6dcc1b4dd672942cf59 Reviewed-on: https://gerrit.libreoffice.org/8742 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 8822882..fb688da 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -688,6 +688,8 @@ void lcl_MoveBorderPropertiesToFrame(uno::Sequencebeans::PropertyValue rFrame { try { +if (!xStartTextRange.is()) //rhbz#1077780 +return; uno::Referencetext::XTextCursor xRangeCursor = xStartTextRange-getText()-createTextCursorByRange( xStartTextRange ); xRangeCursor-gotoRange( xEndTextRange, true ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/virdev.hxx |6 +++--- include/vcl/window.hxx |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) New commits: commit 35ddbcbc42628c57c3e5fda1a3e221231d21803b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 26 16:56:44 2014 +0100 Fix merge conflicts Change-Id: I6e099911afec9c4086f620b45656880135decff0 diff --git a/include/vcl/virdev.hxx b/include/vcl/virdev.hxx index 2713567..2b82d2c 100644 --- a/include/vcl/virdev.hxx +++ b/include/vcl/virdev.hxx @@ -113,7 +113,7 @@ public: virtual ~VirtualDevice(); -virtual voidEnableRTL( bool bEnable = true ) SAL_OVERRIDE; +virtual voidEnableRTL( bool bEnable = true ); boolSetOutputSizePixel( const Size rNewSize, bool bErase = true ); boolSetOutputSizePixelScaleOffsetAndBuffer( const Size rNewSize, const Fraction rScale, const Point rNewOffset, const basebmp::RawMemorySharedArray pBuffer ); @@ -134,8 +134,8 @@ public: voidSetReferenceDevice( sal_Int32 i_nDPIX, sal_Int32 i_nDPIY ); -sal_uInt16 GetBitCount() const SAL_OVERRIDE; -sal_uInt16 GetAlphaBitCount() const SAL_OVERRIDE; +sal_uInt16 GetBitCount() const; +sal_uInt16 GetAlphaBitCount() const; private: SAL_DLLPRIVATE void ImplSetReferenceDevice( RefDevMode, sal_Int32 i_nDPIX, sal_Int32 i_nDPIY ); diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx index 5751489..ecd350e 100644 --- a/include/vcl/window.hxx +++ b/include/vcl/window.hxx @@ -595,7 +595,7 @@ public: OutputDevice const* GetOutDev() const { return mpOutputDevice; }; OutputDevice* GetOutDev() { return mpOutputDevice; }; -virtual voidEnableRTL ( bool bEnable = true ) SAL_OVERRIDE; +virtual voidEnableRTL ( bool bEnable = true ); virtual voidMouseMove( const MouseEvent rMEvt ); virtual voidMouseButtonDown( const MouseEvent rMEvt ); virtual voidMouseButtonUp( const MouseEvent rMEvt ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - vcl/source
vcl/source/window/toolbox.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e9451c72d4e221c993e1af30652c62a538d033d8 Author: Keith Curtis keit...@gmail.com Date: Mon Mar 17 20:16:57 2014 -0400 Hopefully fix Windows HiDPI toolbar layout bug On Windows HiDPI, toolbar buttons are cut off. This may fix the problem. Here is a screenshot: http://i.imgur.com/NADAvYi.png I can't prove this fixes anything on Windows because I can't see this on Linux and don't really understand the surrounding code. On the other hand, it is easy to prove this is reasonable code. Change-Id: I69c19ad46844bead942ce63883d163cb9d0690c9 Reviewed-on: https://gerrit.libreoffice.org/8637 Tested-by: LibreOffice gerrit bot ger...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 509441038ab95dd3a60efd1b6c302bf22bfbc631) Reviewed-on: https://gerrit.libreoffice.org/8743 Reviewed-by: Keith Curtis keit...@gmail.com Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx index 0d7bf8a..4613879 100644 --- a/vcl/source/window/toolbox.cxx +++ b/vcl/source/window/toolbox.cxx @@ -1747,8 +1747,8 @@ sal_Bool ToolBox::ImplCalcItem() longnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH; // set defaults if image or text is needed but empty -nDefWidth = GetDefaultImageSize().Width(); -nDefHeight = GetDefaultImageSize().Height(); +nDefWidth = GetDefaultImageSize().Width() * GetDPIScaleFactor(); +nDefHeight = GetDefaultImageSize().Height() * GetDPIScaleFactor(); mnWinHeight = 0; // determine minimum size necessary in NWF ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - 4 commits - filter/source svx/source sw/source
filter/source/msfilter/msdffimp.cxx | 68 -- svx/source/svdraw/svdotext.cxx |8 +--- svx/source/svdraw/svdundo.cxx | 70 +--- svx/source/table/tableundo.cxx |7 +++ sw/source/ui/docvw/SidebarWin.cxx |3 + 5 files changed, 107 insertions(+), 49 deletions(-) New commits: commit 88b1d35131b0ea44ac6ba6f7edeab82d1c29a39f Author: Armin Le Grand a...@apache.org Date: Wed Mar 26 15:38:38 2014 + i120201 added forcing TableLayouter to take action in table undo/redo (CellUndo) diff --git a/svx/source/table/tableundo.cxx b/svx/source/table/tableundo.cxx index fe9eae5..361bd9d 100644 --- a/svx/source/table/tableundo.cxx +++ b/svx/source/table/tableundo.cxx @@ -136,8 +136,13 @@ void CellUndo::setDataToCell( const Data rData ) mxCell-mnRowSpan = rData.mnRowSpan; mxCell-mnColSpan = rData.mnColSpan; -if( mxObjRef.is() ) +if(mxObjRef.is()) +{ +// #120201# ActionChanged is not enough, we need to trigger TableLayouter::UpdateBorderLayout() +// and this is done best using ReformatText() for table objects mxObjRef-ActionChanged(); +mxObjRef-NbcReformatText(); +} } void CellUndo::getDataFromCell( Data rData ) commit b8c793949e416432619d3c7d7611fc44694c3b77 Author: Oliver-Rainer Wittmann o...@apache.org Date: Wed Mar 26 13:52:38 2014 + 124514: show/hide Overlay object to highlight annotated text range according the according view option which show/hides the annotations/comments diff --git a/sw/source/ui/docvw/SidebarWin.cxx b/sw/source/ui/docvw/SidebarWin.cxx index cdcbcb7..6ab8561 100644 --- a/sw/source/ui/docvw/SidebarWin.cxx +++ b/sw/source/ui/docvw/SidebarWin.cxx @@ -579,7 +579,8 @@ void SwSidebarWin::SetPosAndSize() } // text range overlay -if ( mrSidebarItem.maLayoutInfo.mnStartNodeIdx != 0 +if ( mrMgr.ShowNotes() + mrSidebarItem.maLayoutInfo.mnStartNodeIdx != 0 mrSidebarItem.maLayoutInfo.mnStartContent != STRING_NOTFOUND ) { std::vector basegfx::B2DRange aAnnotationTextRanges; commit c55d29bd33ece4b96fd8bf6babcfa4c99dfc468d Author: Armin Le Grand a...@apache.org Date: Wed Mar 26 12:48:17 2014 + i124389 correct TextFrame layout for tables not when new text is set, but in UNdo/Redo directly for performance reasons diff --git a/svx/source/svdraw/svdotext.cxx b/svx/source/svdraw/svdotext.cxx index 59cf55b..41eee32 100644 --- a/svx/source/svdraw/svdotext.cxx +++ b/svx/source/svdraw/svdotext.cxx @@ -63,7 +63,6 @@ #include drawinglayer/geometry/viewinformation2d.hxx #include vcl/virdev.hxx #include basegfx/matrix/b2dhommatrixtools.hxx -#include svx/svdotable.hxx // @@ -1501,11 +1500,8 @@ void SdrTextObj::NbcSetOutlinerParaObjectForText( OutlinerParaObject* pTextObjec } SetTextSizeDirty(); - -// #124389# also need to call NbcAdjustTextFrameWidthAndHeight when we are a table object (triggered from undo) -if((IsTextFrame() || 0 != dynamic_cast sdr::table::SdrTableObj* (this)) (IsAutoGrowHeight() || IsAutoGrowWidth())) -{ -// adapt text frame +if (IsTextFrame() (IsAutoGrowHeight() || IsAutoGrowWidth())) +{ // Textrahmen anpassen! NbcAdjustTextFrameWidthAndHeight(); } if (!IsTextFrame()) diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx index f5ec0e9..bc8619f 100644 --- a/svx/source/svdraw/svdundo.cxx +++ b/svx/source/svdraw/svdundo.cxx @@ -46,6 +46,9 @@ #include svx/svdograf.hxx #include svx/sdr/contact/viewcontactofgraphic.hxx +// #124389# +#include svx/svdotable.hxx + // iterates over all views and unmarks this SdrObject if it is marked @@ -1187,49 +1190,92 @@ void SdrUndoObjSetText::AfterSetText() void SdrUndoObjSetText::Undo() { +// only works with SdrTextObj +SdrTextObj* pTarget = dynamic_cast SdrTextObj* (pObj); + +if(!pTarget) +{ +OSL_ENSURE(false, SdrUndoObjSetText::Undo with SdrObject not based on SdrTextObj (!)); +return; +} + // #94278# Trigger PageChangeCall ImpShowPageOfThisObject(); // alten Text sichern fuer Redo -if (!bNewTextAvailable) +if(!bNewTextAvailable) +{ AfterSetText(); +} // Text fuer Undo kopieren, denn SetOutlinerParaObject() ist Eigentumsuebereignung OutlinerParaObject* pText1 = pOldText; + if(pText1) +{ pText1 = new OutlinerParaObject(*pText1); +} -SdrText* pText = static_cast SdrTextObj*( pObj )-getText(mnText); -if( pText ) -static_cast SdrTextObj* ( pObj )-NbcSetOutlinerParaObjectForText( pText1, pText ); +SdrText* pText = pTarget-getText(mnText); -pObj-SetEmptyPresObj( bEmptyPresObj ); -pObj-ActionChanged(); +
[Libreoffice-commits] core.git: include/comphelper
include/comphelper/listenernotification.hxx | 45 +--- 1 file changed, 16 insertions(+), 29 deletions(-) New commits: commit b3847f3dfda6ed18f5f09f01354c529925c25889 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 26 17:10:41 2014 +0100 Work around MSC 'override' cannot be used with 'inline' bug Change-Id: Icd3b09f098c19268ac888dd6195fb535979557ed diff --git a/include/comphelper/listenernotification.hxx b/include/comphelper/listenernotification.hxx index cac3a79..5ae133b 100644 --- a/include/comphelper/listenernotification.hxx +++ b/include/comphelper/listenernotification.hxx @@ -203,10 +203,16 @@ namespace comphelper inline boolnotify( const EventClass _rEvent, NotificationMethod _pNotify ) SAL_THROW(( ::com::sun::star::uno::Exception )); protected: -inline virtual boolimplNotify( +virtual boolimplNotify( const ::com::sun::star::uno::Reference ::com::sun::star::lang::XEventListener _rxListener, const ::com::sun::star::lang::EventObject _rEvent -) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) SAL_OVERRIDE; +) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) SAL_OVERRIDE +{ +const EventClass rTypedEvent( static_cast const EventClass ( _rEvent ) ); +ListenerClass* pTypedListener( static_cast ListenerClass* ( _rxListener.get() ) ); +(pTypedListener-*m_pNotificationMethod)( rTypedEvent ); +return true; +} }; @@ -219,19 +225,6 @@ namespace comphelper return bRet; } - -template class LISTENER, class EVENT -inline bool OSimpleListenerContainer LISTENER, EVENT ::implNotify( -const ::com::sun::star::uno::Reference ::com::sun::star::lang::XEventListener _rxListener, -const ::com::sun::star::lang::EventObject _rEvent ) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) -{ -const EventClass rTypedEvent( static_cast const EventClass ( _rEvent ) ); -ListenerClass* pTypedListener( static_cast ListenerClass* ( _rxListener.get() ) ); -(pTypedListener-*m_pNotificationMethod)( rTypedEvent ); -return true; -} - - //= OListenerContainerBase /** is a specialization of OListenerContainer which saves you some additional type casts, @@ -267,10 +260,16 @@ namespace comphelper using OListenerContainer::impl_notify; protected: -inline virtual boolimplNotify( +virtual boolimplNotify( const ::com::sun::star::uno::Reference ::com::sun::star::lang::XEventListener _rxListener, const ::com::sun::star::lang::EventObject _rEvent -) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) SAL_OVERRIDE; +) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) SAL_OVERRIDE +{ +return implTypedNotify( +::com::sun::star::uno::Reference ListenerClass ( static_cast ListenerClass* ( _rxListener.get() ) ), +static_cast const EventClass ( _rEvent ) +); +} virtual boolimplTypedNotify( const ::com::sun::star::uno::Reference ListenerClass _rxListener, @@ -278,18 +277,6 @@ namespace comphelper ) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) = 0; }; -template class LISTENER, class EVENT -inline bool OListenerContainerBase LISTENER, EVENT ::implNotify( -const ::com::sun::star::uno::Reference ::com::sun::star::lang::XEventListener _rxListener, -const ::com::sun::star::lang::EventObject _rEvent ) SAL_THROW( ( ::com::sun::star::uno::Exception ) ) -{ -return implTypedNotify( -::com::sun::star::uno::Reference ListenerClass ( static_cast ListenerClass* ( _rxListener.get() ) ), -static_cast const EventClass ( _rEvent ) -); -} - - } // namespace comphelper ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: stoc/source
stoc/source/javavm/interact.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a3b0d947b026731af6d29891876593c82c2bc65b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 26 17:27:01 2014 +0100 Work around MSC 'override' cannot be used with 'inline' bug Change-Id: If736316402c49153d4c8552672c90552548f90b8 diff --git a/stoc/source/javavm/interact.cxx b/stoc/source/javavm/interact.cxx index e51d278..3edc3ff 100644 --- a/stoc/source/javavm/interact.cxx +++ b/stoc/source/javavm/interact.cxx @@ -38,7 +38,7 @@ class AbortContinuation: public: inline AbortContinuation() {} -virtual inline void SAL_CALL select() throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE {} +virtual void SAL_CALL select() throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE {} private: AbortContinuation(AbortContinuation ); // not implemented ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.1' - writerfilter/source
writerfilter/source/dmapper/CellMarginHandler.cxx |2 +- writerfilter/source/dmapper/ConversionHelper.cxx | 10 -- writerfilter/source/dmapper/ConversionHelper.hxx |1 + 3 files changed, 10 insertions(+), 3 deletions(-) New commits: commit ebdc472eb717976385c02b8809dd483172b42b01 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Mar 26 17:28:51 2014 +0100 apparently some table .docx properties shouldn't be 0 Somewhat related to 10b4da63e3143108ba75891e9e98fdaa2f7953ab , a similar doc has negative value inside w:tblCellMar, which MSO seems to ignore (altering the value has no visible effect), so ignore it as well. Change-Id: I846e9b55fea0d4e66f03ce615584516360b8b7dd diff --git a/writerfilter/source/dmapper/CellMarginHandler.cxx b/writerfilter/source/dmapper/CellMarginHandler.cxx index 6119831..a32554b 100644 --- a/writerfilter/source/dmapper/CellMarginHandler.cxx +++ b/writerfilter/source/dmapper/CellMarginHandler.cxx @@ -55,7 +55,7 @@ void CellMarginHandler::lcl_attribute(Id rName, Value rVal) switch( rName ) { case NS_ooxml::LN_CT_TblWidth_w: -m_nValue = ConversionHelper::convertTwipToMM100( nIntValue ); +m_nValue = ConversionHelper::convertTwipToMM100Unsigned( nIntValue ); break; case NS_ooxml::LN_CT_TblWidth_type: OSL_ENSURE( NS_ooxml::LN_Value_ST_TblWidth_dxa == sal::static_int_castId(nIntValue), cell margins work for absolute values, only); diff --git a/writerfilter/source/dmapper/ConversionHelper.cxx b/writerfilter/source/dmapper/ConversionHelper.cxx index 3ce0133..4cd2539 100644 --- a/writerfilter/source/dmapper/ConversionHelper.cxx +++ b/writerfilter/source/dmapper/ConversionHelper.cxx @@ -230,18 +230,24 @@ OUString ConvertMSFormatStringToSO( } +#define TWIP_TO_MM100(TWIP) ((TWIP) = 0 ? (((TWIP)*127L+36L)/72L) : (((TWIP)*127L-36L)/72L)) sal_Int32 convertTwipToMM100(sal_Int32 _t) { +return TWIP_TO_MM100( _t ); +} + +sal_uInt32 convertTwipToMM100Unsigned(sal_Int32 _t) +{ +if( _t 0 ) +return 0; // It appears that MSO handles large twip values specially, probably legacy 16bit handling, // anything that's bigger than 32767 appears to be simply ignored. if( _t = 0x8000 ) return 0; -#define TWIP_TO_MM100(TWIP) ((TWIP) = 0 ? (((TWIP)*127L+36L)/72L) : (((TWIP)*127L-36L)/72L)) return TWIP_TO_MM100( _t ); } - sal_Int32 convertEMUToMM100(sal_Int32 _t) { return _t / 360; diff --git a/writerfilter/source/dmapper/ConversionHelper.hxx b/writerfilter/source/dmapper/ConversionHelper.hxx index b23872b..3873a39 100644 --- a/writerfilter/source/dmapper/ConversionHelper.hxx +++ b/writerfilter/source/dmapper/ConversionHelper.hxx @@ -44,6 +44,7 @@ namespace ConversionHelper{ OUString ConvertMSFormatStringToSO( const OUString rFormat, ::com::sun::star::lang::Locale rLocale, bool bHijri); sal_Int32 convertTwipToMM100(sal_Int32 _t); +sal_uInt32 convertTwipToMM100Unsigned(sal_Int32 _t); // probably the most useless unit in the world - English Metric Units (EMU) 360 000 EMU == 1cm sal_Int32 convertEMUToMM100(sal_Int32 _t); sal_Int32 ConvertColor(sal_Int32 nWordColor ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - sw/qa writerfilter/source
dev/null |binary sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 24 +++ writerfilter/source/dmapper/CellMarginHandler.cxx|2 writerfilter/source/dmapper/ConversionHelper.cxx | 10 +++- writerfilter/source/dmapper/ConversionHelper.hxx |1 writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 24 +-- writerfilter/source/dmapper/TablePropertiesHandler.cxx |4 - 8 files changed, 32 insertions(+), 33 deletions(-) New commits: commit 0d1abac3a3131a9419cedb4385edf6ab8ccb58de Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Mar 26 17:31:03 2014 +0100 test for ignoring negative cell margin values Change-Id: I7e56762a7097dd7369f9d8d71b499888ee5c081d diff --git a/sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx b/sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx new file mode 100644 index 000..3ae73db Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx differ diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx index b86d26d..da5472d 100644 --- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx +++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx @@ -1981,6 +1981,14 @@ DECLARE_OOXMLIMPORT_TEST(testLargeTwips, large-twips.docx ) CPPUNIT_ASSERT( width.toInt32() 0 ); } +DECLARE_OOXMLIMPORT_TEST(testNegativeCellMarginTwips, negative-cell-margin-twips.docx ) +{ +// Sligtly related to cp#143, the twips value was negative, which wrapped around somewhere, +// while MSO seems to ignore that as well. +OUString width = parseDump( /root/page/body/tab/row[1]/cell[1]/txt/infos/bounds, width ); +CPPUNIT_ASSERT( width.toInt32() 0 ); +} + DECLARE_OOXMLIMPORT_TEST(testFdo38414, fdo38414.docx ) { // The cells in the last (4th) column were merged properly and so the result didn't have the same height. commit 1e47614cdb84b018a22a334dad0cdd9f0f53892c Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Mar 26 17:28:51 2014 +0100 apparently some table .docx properties shouldn't be 0 Somewhat related to 10b4da63e3143108ba75891e9e98fdaa2f7953ab , a similar doc has negative value inside w:tblCellMar, which MSO seems to ignore (altering the value has no visible effect), so ignore it as well. Change-Id: I846e9b55fea0d4e66f03ce615584516360b8b7dd diff --git a/writerfilter/source/dmapper/CellMarginHandler.cxx b/writerfilter/source/dmapper/CellMarginHandler.cxx index 380a8d9..6bbb525 100644 --- a/writerfilter/source/dmapper/CellMarginHandler.cxx +++ b/writerfilter/source/dmapper/CellMarginHandler.cxx @@ -57,7 +57,7 @@ void CellMarginHandler::lcl_attribute(Id rName, Value rVal) { case NS_ooxml::LN_CT_TblWidth_w: m_nWidth = nIntValue; -m_nValue = ConversionHelper::convertTwipToMM100( nIntValue ); +m_nValue = ConversionHelper::convertTwipToMM100Unsigned( nIntValue ); break; case NS_ooxml::LN_CT_TblWidth_type: OSL_ENSURE( NS_ooxml::LN_Value_ST_TblWidth_dxa == sal::static_int_castId(nIntValue), cell margins work for absolute values, only); diff --git a/writerfilter/source/dmapper/ConversionHelper.cxx b/writerfilter/source/dmapper/ConversionHelper.cxx index cba58b7..9de86ee 100644 --- a/writerfilter/source/dmapper/ConversionHelper.cxx +++ b/writerfilter/source/dmapper/ConversionHelper.cxx @@ -226,18 +226,24 @@ OUString ConvertMSFormatStringToSO( } +#define TWIP_TO_MM100(TWIP) ((TWIP) = 0 ? (((TWIP)*127L+36L)/72L) : (((TWIP)*127L-36L)/72L)) sal_Int32 convertTwipToMM100(sal_Int32 _t) { +return TWIP_TO_MM100( _t ); +} + +sal_uInt32 convertTwipToMM100Unsigned(sal_Int32 _t) +{ +if( _t 0 ) +return 0; // It appears that MSO handles large twip values specially, probably legacy 16bit handling, // anything that's bigger than 32767 appears to be simply ignored. if( _t = 0x8000 ) return 0; -#define TWIP_TO_MM100(TWIP) ((TWIP) = 0 ? (((TWIP)*127L+36L)/72L) : (((TWIP)*127L-36L)/72L)) return TWIP_TO_MM100( _t ); } - sal_Int32 convertEMUToMM100(sal_Int32 _t) { return _t / 360; diff --git a/writerfilter/source/dmapper/ConversionHelper.hxx b/writerfilter/source/dmapper/ConversionHelper.hxx index 5b3b4fd..247da5c 100644 --- a/writerfilter/source/dmapper/ConversionHelper.hxx +++ b/writerfilter/source/dmapper/ConversionHelper.hxx @@ -44,6 +44,7 @@ namespace ConversionHelper{ OUString ConvertMSFormatStringToSO( const OUString rFormat, ::com::sun::star::lang::Locale rLocale, bool bHijri); sal_Int32 convertTwipToMM100(sal_Int32 _t); +sal_uInt32 convertTwipToMM100Unsigned(sal_Int32 _t); // probably the most useless unit in the world - English Metric Units (EMU)
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.1' - sw/qa sw/source
sw/qa/extras/ww8import/data/cp144.doc |binary sw/qa/extras/ww8import/ww8import.cxx |9 + sw/source/filter/ww8/ww8par.cxx |4 +++- 3 files changed, 12 insertions(+), 1 deletion(-) New commits: commit ccfd10ac45265f061737514d60fcf20659d429a4 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed Mar 26 13:34:08 2014 +0100 cp#144 DOC import: fProtEnabled means document is not totally read-only Reading the spec, it seems that we have two cases here: - if lKeyProtDoc is set and fProtEnabled is 1, then editing forms is allowed - if lKeyProtDoc is set, but fProtEnabled is 0, then the document is totally read-only So in the first case avoid the SetModifyPasswordHash() call to allow form field editing. (cherry picked from commit 8757bea2e88c6e349e1fe98d8e9695d7b9c6179e) Conflicts: sw/qa/extras/ww8import/ww8import.cxx Change-Id: Id0c48e8eb4bde75c5520a7b108fcfada51148faf diff --git a/sw/qa/extras/ww8import/data/cp144.doc b/sw/qa/extras/ww8import/data/cp144.doc new file mode 100755 index 000..ea30cc0 Binary files /dev/null and b/sw/qa/extras/ww8import/data/cp144.doc differ diff --git a/sw/qa/extras/ww8import/ww8import.cxx b/sw/qa/extras/ww8import/ww8import.cxx index ef1621e..c34e354 100644 --- a/sw/qa/extras/ww8import/ww8import.cxx +++ b/sw/qa/extras/ww8import/ww8import.cxx @@ -37,6 +37,7 @@ public: void testN823651(); void testFdo36868(); void testListNolevel(); +void testCp144(); void testCp139(); void testBnc821208(); @@ -67,6 +68,7 @@ void Test::run() {n823651.doc, Test::testN823651}, {fdo36868.doc, Test::testFdo36868}, {list-nolevel.doc, Test::testListNolevel}, +{cp144.doc, Test::testCp144}, {cp139.doc, Test::testCp139}, {bnc821208.doc, Test::testBnc821208}, }; @@ -288,6 +290,13 @@ void Test::testListNolevel() CPPUNIT_ASSERT_EQUAL(OUString(1.), aText); } +void Test::testCp144() +{ +uno::Referenceframe::XStorable xStorable(mxComponent, uno::UNO_QUERY); +// It wasn't possible to fill out this form. +CPPUNIT_ASSERT_EQUAL(false, bool(xStorable-isReadonly())); +} + void Test::testCp139() { // This was RTL_TEXTENCODING_SYMBOL, causing 1 rendered as a placeholder rectangle. diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index ad39b11..5c46957 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -1608,7 +1608,9 @@ void SwWW8ImplReader::ImportDop() } } -mpDocShell-SetModifyPasswordHash(pWDop-lKeyProtDoc); +// Still allow editing of form fields. +if (!pWDop-fProtEnabled) +mpDocShell-SetModifyPasswordHash(pWDop-lKeyProtDoc); const SvtFilterOptions rOpt = SvtFilterOptions::Get(); if (rOpt.IsUseEnhancedFields()) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/inc
framework/inc/threadhelp/gate.hxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 190085dd4d1bc8cdfa5573158c8986b757ac1faf Author: Stephan Bergmann sberg...@redhat.com Date: Wed Mar 26 17:45:14 2014 +0100 Work around MSC 'override' cannot be used with 'inline' bug Change-Id: I35170712b8f0c83ab35cb5ef7115a6dc434a7a4f diff --git a/framework/inc/threadhelp/gate.hxx b/framework/inc/threadhelp/gate.hxx index a8b87a8..b4e9ab0 100644 --- a/framework/inc/threadhelp/gate.hxx +++ b/framework/inc/threadhelp/gate.hxx @@ -98,7 +98,7 @@ class Gate : public IGate @onerror- *//*-*/ -inline virtual void open() SAL_OVERRIDE +virtual void open() SAL_OVERRIDE { // We must safe access to our internal member! ::osl::MutexGuard aLock( m_aAccessLock ); @@ -121,7 +121,7 @@ class Gate : public IGate @onerror- *//*-*/ -inline virtual void close() SAL_OVERRIDE +virtual void close() SAL_OVERRIDE { // We must safe access to our internal member! ::osl::MutexGuard aLock( m_aAccessLock ); @@ -147,7 +147,7 @@ class Gate : public IGate @onerror- *//*-*/ -inline virtual void openGap() SAL_OVERRIDE +virtual void openGap() SAL_OVERRIDE { // We must safe access to our internal member! ::osl::MutexGuard aLock( m_aAccessLock ); @@ -174,7 +174,7 @@ class Gate : public IGate @onerrorWe return false. *//*-*/ -inline virtual sal_Bool wait( const TimeValue* pTimeOut = NULL ) SAL_OVERRIDE +virtual sal_Bool wait( const TimeValue* pTimeOut = NULL ) SAL_OVERRIDE { // We must safe access to our internal member! ::osl::ClearableMutexGuard aLock( m_aAccessLock ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 60270] LibreOffice 4.1 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=60270 Bug 60270 depends on bug 73936, which changed state. Bug 73936 Summary: FILEOPEN: Can't open .doc file: Writer freezes https://bugs.freedesktop.org/show_bug.cgi?id=73936 What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: external/mysqlcppconn
external/mysqlcppconn/UnpackedTarball_mysqlcppconn.mk |1 external/mysqlcppconn/patches/retrieve_grants.patch.1 | 31 -- 2 files changed, 32 deletions(-) New commits: commit b26f2645d30de5ef86eaeb91ef5346135cfe256d Author: Julien Nabet serval2...@yahoo.fr Date: Wed Mar 26 18:59:33 2014 +0100 Resolves: fdo#76638 Patch retrieve_grants.patch.1 fails Let's remove this since the future is MariaDB Change-Id: I39641f81c59e7d024aaf48e8e3cc9fc9a7c3127c diff --git a/external/mysqlcppconn/UnpackedTarball_mysqlcppconn.mk b/external/mysqlcppconn/UnpackedTarball_mysqlcppconn.mk index ddcb522..9c2282e 100644 --- a/external/mysqlcppconn/UnpackedTarball_mysqlcppconn.mk +++ b/external/mysqlcppconn/UnpackedTarball_mysqlcppconn.mk @@ -18,7 +18,6 @@ $(eval $(call gb_UnpackedTarball_add_file,mysqlcppconn,driver/nativeapi/binding_ $(eval $(call gb_UnpackedTarball_add_patches,mysqlcppconn,\ external/mysqlcppconn/patches/mysql-connector-c++-1.1.0.patch \ external/mysqlcppconn/patches/default_to_protocol_tcp.patch \ - external/mysqlcppconn/patches/retrieve_grants.patch.1 \ external/mysqlcppconn/patches/warnings.patch.0 \ )) diff --git a/external/mysqlcppconn/patches/retrieve_grants.patch.1 b/external/mysqlcppconn/patches/retrieve_grants.patch.1 deleted file mode 100644 index eb63cff..000 --- a/external/mysqlcppconn/patches/retrieve_grants.patch.1 +++ /dev/null @@ -1,31 +0,0 @@ -diff -ur mysqlcppconn.org/driver/mysql_metadata.cpp mysqlcppconn/driver/mysql_metadata.cpp mysqlcppconn.org/driver/mysql_metadata.cpp 2013-12-20 22:12:07.044698692 +0100 -+++ mysqlcppconn/driver/mysql_metadata.cpp 2013-12-20 22:14:56.320394472 +0100 -@@ -3633,12 +3633,14 @@ -- sql::SQLString strAllPrivs(ALTER, DELETE, DROP, INDEX, INSERT, LOCK TABLES, SELECT, UPDATE); -+ sql::SQLString strAllPrivs(SELECT, INSERT, UPDATE, DELETE, CREATE, DROPT, GRANT, REFERENCES, INDEX, ALTER, CREATE VIEW, SHOW VIEW, TRIGGER); - - sql::SQLString cQuote(getIdentifierQuoteString()); -+ size_t posIsGrantable = sql::SQLString::npos; - - while (rs-next() ) { - sql::SQLString aGrant = rs-getString(1); - aGrant = aGrant.replace(0, 6, ); - - size_t pos = aGrant.find(ALL PRIVILEGES); -+ posIsGrantable = aGrant.find(WITH GRANT OPTION); - - if (pos != sql::SQLString::npos) { - aGrant = aGrant.replace(pos, sizeof(ALL PRIVILEGES) - 1, strAllPrivs); -@@ -3737,7 +3739,10 @@ - rs_data_row.push_back(); // GRANTOR - rs_data_row.push_back(getUserName()); // GRANTEE - rs_data_row.push_back(privToken); // PRIVILEGE -- rs_data_row.push_back(); // IS_GRANTABLE - ToDo maybe here WITH GRANT OPTION?? -+if (posIsGrantable != sql::SQLString::npos) -+ rs_data_row.push_back(YES); -+else -+ rs_data_row.push_back(); // IS_GRANTABLE - - rs_data-push_back(rs_data_row); - } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Depends on|73994 | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - 2 commits - chart2/source udkapi/com
chart2/source/model/template/GL3DBarChartType.cxx | 92 ++ chart2/source/model/template/GL3DBarChartType.hxx | 19 +++- udkapi/com/sun/star/beans/PropertyAttribute.idl |4 3 files changed, 109 insertions(+), 6 deletions(-) New commits: commit 70a7d8f880d6f161df17f0c0eedc8be0c051c80b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 14:28:19 2014 -0400 Add a boolean RoundedRectangle property to the GL 3D chart. Change-Id: I3cb23461718c5713c1e76d0b37d92b3e7849d13b diff --git a/chart2/source/model/template/GL3DBarChartType.cxx b/chart2/source/model/template/GL3DBarChartType.cxx index 033c38c..7b94095 100644 --- a/chart2/source/model/template/GL3DBarChartType.cxx +++ b/chart2/source/model/template/GL3DBarChartType.cxx @@ -9,11 +9,84 @@ #include GL3DBarChartType.hxx #include servicenames_charttypes.hxx +#include PropertyHelper.hxx + +#include com/sun/star/beans/Property.hpp +#include com/sun/star/beans/PropertyAttribute.hpp using namespace com::sun::star; namespace chart { +namespace { + +enum +{ +PROP_GL3DCHARTTYPE_ROUNDED_RECTANGLE +}; + +struct DefaultsInitializer +{ +tPropertyValueMap* operator()() +{ +static tPropertyValueMap aStaticDefaults; + +if (aStaticDefaults.empty()) +addDefaults(aStaticDefaults); + +return aStaticDefaults; +} +private: + +void addDefaults( tPropertyValueMap rOutMap ) +{ +PropertyHelper::setPropertyValueDefault(rOutMap, PROP_GL3DCHARTTYPE_ROUNDED_RECTANGLE, false); +} +}; + +struct Defaults : public rtl::StaticAggregatetPropertyValueMap, DefaultsInitializer {}; + +struct InfoHelperInitializer +{ +cppu::OPropertyArrayHelper* operator()() +{ +static cppu::OPropertyArrayHelper aHelper(getProperties()); +return aHelper; +} + +uno::Sequencebeans::Property getProperties() +{ +uno::Sequencebeans::Property aRet(1); + +aRet[0] = beans::Property( +RoundedRectangle, +PROP_GL3DCHARTTYPE_ROUNDED_RECTANGLE, +::getCppuBooleanType(), +beans::PropertyAttribute::BOUND | beans::PropertyAttribute::MAYBEDEFAULT); + +return aRet; +} +}; + +struct InfoHelper : public rtl::StaticAggregatecppu::OPropertyArrayHelper, InfoHelperInitializer {}; + +struct ChartTypeInfoInitializer +{ +uno::Referencebeans::XPropertySetInfo* operator()() +{ +static uno::Referencebeans::XPropertySetInfo xPropertySetInfo; + +if (!xPropertySetInfo.is()) +xPropertySetInfo = cppu::OPropertySetHelper::createPropertySetInfo(*InfoHelper::get()); + +return xPropertySetInfo; +} +}; + +struct ChartTypeInfo : public rtl::StaticAggregateuno::Referencebeans::XPropertySetInfo, ChartTypeInfoInitializer {}; + +} + GL3DBarChartType::GL3DBarChartType( const uno::Referenceuno::XComponentContext xContext ) : ChartType(xContext) { @@ -50,6 +123,25 @@ GL3DBarChartType::createClone() return uno::Referenceutil::XCloneable(new GL3DBarChartType(*this)); } +css::uno::Any GL3DBarChartType::GetDefaultValue( sal_Int32 nHandle ) const +throw (css::beans::UnknownPropertyException) +{ +const tPropertyValueMap rDefaults = *Defaults::get(); +tPropertyValueMap::const_iterator it = rDefaults.find(nHandle); +return it == rDefaults.end() ? uno::Any() : it-second; +} + +cppu::IPropertyArrayHelper GL3DBarChartType::getInfoHelper() +{ +return *InfoHelper::get(); +} + +css::uno::Referencecss::beans::XPropertySetInfo GL3DBarChartType::getPropertySetInfo() +throw (css::uno::RuntimeException, std::exception) +{ +return *ChartTypeInfo::get(); +} + } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/chart2/source/model/template/GL3DBarChartType.hxx b/chart2/source/model/template/GL3DBarChartType.hxx index ee9d0ab..c5da45c 100644 --- a/chart2/source/model/template/GL3DBarChartType.hxx +++ b/chart2/source/model/template/GL3DBarChartType.hxx @@ -33,11 +33,22 @@ protected: GL3DBarChartType( const GL3DBarChartType rOther ); virtual OUString SAL_CALL getChartType() -throw (com::sun::star::uno::RuntimeException, std::exception); +throw (css::uno::RuntimeException, std::exception); -virtual com::sun::star::uno::Referencecom::sun::star::util::XCloneable -SAL_CALL createClone() -throw (com::sun::star::uno::RuntimeException, std::exception); +virtual css::uno::Referencecss::util::XCloneable SAL_CALL +createClone() +throw (css::uno::RuntimeException, std::exception); + +// OPropertySet +virtual css::uno::Any GetDefaultValue( sal_Int32 nHandle ) const +throw (css::beans::UnknownPropertyException); + +virtual cppu::IPropertyArrayHelper SAL_CALL getInfoHelper(); + +// XPropertySet +virtual css::uno::Referencecss::beans::XPropertySetInfo SAL_CALL +getPropertySetInfo() +throw
[Libreoffice-commits] core.git: sw/qa
dev/null |binary sw/qa/extras/ooxmlimport/data/negative-table-cell-twips.docx |binary 2 files changed New commits: commit ea4ce88bf60e46c3caa2e57b6550b52bb58ad861 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Mar 26 20:30:12 2014 +0100 fix test document name Change-Id: I029c77aac896cefacd685705881a3259affee921 diff --git a/sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx b/sw/qa/extras/ooxmlimport/data/negative-table-cell-twips.docx similarity index 100% rename from sw/qa/extras/ooxmlimport/data/negative_table_cell_twips.docx rename to sw/qa/extras/ooxmlimport/data/negative-table-cell-twips.docx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - chart2/source chart2/uiconfig
chart2/source/controller/dialogs/ChartTypeDialogController.cxx|5 ++ chart2/source/controller/dialogs/ChartTypeDialogController.hxx|1 chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx |5 ++ chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx |2 chart2/source/controller/dialogs/tp_ChartType.cxx | 25 ++ chart2/source/controller/dialogs/tp_ChartType.hxx |2 chart2/uiconfig/ui/tp_ChartType.ui| 25 ++ 7 files changed, 65 insertions(+) New commits: commit 9436ae9f8c42747841da2129a7381461db79b75e Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 15:38:25 2014 -0400 Add the UI bits for showing rounded edge property for GL3D chart. Change-Id: Ia6083c423bf8286a0b562d490283f8e1328a0124 diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx index c3faa74..9a5eb1b 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx @@ -372,6 +372,11 @@ bool ChartTypeDialogController::shouldShow_SortByXValuesResourceGroup() const return false; } +bool ChartTypeDialogController::shouldShow_GL3DResourceGroup() const +{ +return false; +} + void ChartTypeDialogController::showExtraControls( VclBuilderContainer* /*pParent*/ ) { } diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx index 4d450b0..a1cb648 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx @@ -100,6 +100,7 @@ public: virtual boolshouldShow_SplineControl() const; virtual boolshouldShow_GeometryControl() const; virtual boolshouldShow_SortByXValuesResourceGroup() const; +virtual boolshouldShow_GL3DResourceGroup() const; virtual voidshowExtraControls(VclBuilderContainer* pParent); virtual voidhideExtraControls() const; diff --git a/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx b/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx index 1b3bfdc..08cb2ec 100644 --- a/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx +++ b/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx @@ -20,6 +20,11 @@ GL3DBarChartDialogController::GL3DBarChartDialogController() {} GL3DBarChartDialogController::~GL3DBarChartDialogController() {} +bool GL3DBarChartDialogController::shouldShow_GL3DResourceGroup() const +{ +return true; +} + OUString GL3DBarChartDialogController::getName() { return SchResId(STR_TYPE_GL3D_BAR).toString(); diff --git a/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx b/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx index e2f31e2..0adba32 100644 --- a/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx +++ b/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx @@ -20,6 +20,8 @@ public: GL3DBarChartDialogController(); virtual ~GL3DBarChartDialogController(); +virtual bool shouldShow_GL3DResourceGroup() const; + virtual OUString getName(); virtual Image getImage(); virtual const tTemplateServiceChartTypeParameterMap getTemplateMap() const; diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index 3a880ec..212a0c7 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -285,6 +285,28 @@ IMPL_LINK_NOARG(StackingResourceGroup, StackingEnableHdl) m_pChangeListener-stateChanged(this); return 0; } + +class GL3DResourceGroup : public ChangingResource +{ +public: +GL3DResourceGroup( VclBuilderContainer* pWindow ); + +void showControls( bool bShow ); + +private: +CheckBox* m_pCB_RoundedEdge; +}; + +GL3DResourceGroup::GL3DResourceGroup( VclBuilderContainer* pWindow ) +{ +pWindow-get(m_pCB_RoundedEdge, rounded-edge); +} + +void GL3DResourceGroup::showControls( bool bShow ) +{ +m_pCB_RoundedEdge-Show(bShow); +} + class SplinePropertiesDialog : public ModalDialog { public: @@ -662,6 +684,7 @@ ChartTypeTabPage::ChartTypeTabPage(Window* pParent , m_pSplineResourceGroup( new SplineResourceGroup(this) ) , m_pGeometryResourceGroup( new GeometryResourceGroup( this ) ) , m_pSortByXValuesResourceGroup( new SortByXValuesResourceGroup( this ) ) +, m_pGL3DResourceGroup(new GL3DResourceGroup(this)) , m_xChartModel( xChartModel ) , m_xCC( xContext ) , m_aChartTypeDialogControllerList(0) @@ -879,6 +902,8 @@ void ChartTypeTabPage::showAllControls( ChartTypeDialogController rTypeControll
[Libreoffice-commits] core.git: sw/qa
dev/null |binary sw/qa/extras/ooxmlimport/data/negative-cell-margin-twips.docx |binary 2 files changed New commits: commit ec2b4ea9b4525b4470f2eace64e43cf30195ad92 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Wed Mar 26 21:05:17 2014 +0100 fix test doc again Change-Id: Icd728e03ac605a05fc9a1f001e2becaf1536ce7d diff --git a/sw/qa/extras/ooxmlimport/data/negative-table-cell-twips.docx b/sw/qa/extras/ooxmlimport/data/negative-cell-margin-twips.docx similarity index 100% rename from sw/qa/extras/ooxmlimport/data/negative-table-cell-twips.docx rename to sw/qa/extras/ooxmlimport/data/negative-cell-margin-twips.docx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - chart2/source chart2/uiconfig
Rebased ref, commits from common ancestor: commit 1eb14c264ceba1abab285b0875cb1e6a63ee9623 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 15:38:25 2014 -0400 Add the UI bits for showing rounded edge property for GL3D chart. Change-Id: Ia6083c423bf8286a0b562d490283f8e1328a0124 diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx index c3faa74..835de9e6 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx @@ -60,6 +60,7 @@ ChartTypeParameter::ChartTypeParameter() , nGeometry3D(DataPointGeometry3D::CUBOID) , eThreeDLookScheme(ThreeDLookScheme_Realistic) , bSortByXValues(false) +, mbGLRoundedEdge(false) { } @@ -79,6 +80,7 @@ ChartTypeParameter::ChartTypeParameter( sal_Int32 SubTypeIndex, bool HasXAxisWit , nGeometry3D(DataPointGeometry3D::CUBOID) , eThreeDLookScheme(ThreeDLookScheme_Realistic) , bSortByXValues(false) +, mbGLRoundedEdge(false) { } ChartTypeParameter::~ChartTypeParameter() @@ -212,6 +214,7 @@ void ChartTypeDialogController::adjustParameterToMainType( ChartTypeParameter r CurveStyle eCurveStyle = rParameter.eCurveStyle; sal_Int32nGeometry3D = rParameter.nGeometry3D; bool bSortByXValues = rParameter.bSortByXValues; +bool bGLRoundedEdge = rParameter.mbGLRoundedEdge; rParameter = (*aIter).second; @@ -222,6 +225,7 @@ void ChartTypeDialogController::adjustParameterToMainType( ChartTypeParameter r rParameter.eCurveStyle = eCurveStyle; rParameter.nGeometry3D = nGeometry3D; rParameter.bSortByXValues = bSortByXValues; +rParameter.mbGLRoundedEdge = bGLRoundedEdge; bFoundSomeMatch = true; break; @@ -372,6 +376,11 @@ bool ChartTypeDialogController::shouldShow_SortByXValuesResourceGroup() const return false; } +bool ChartTypeDialogController::shouldShow_GL3DResourceGroup() const +{ +return false; +} + void ChartTypeDialogController::showExtraControls( VclBuilderContainer* /*pParent*/ ) { } diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx index 4d450b0..991c806 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx @@ -79,6 +79,8 @@ public: ThreeDLookSchemeeThreeDLookScheme; boolbSortByXValues; + +bool mbGLRoundedEdge; }; typedef ::comphelper::MakeMap OUString, ChartTypeParameter tTemplateServiceChartTypeParameterMap; @@ -100,6 +102,7 @@ public: virtual boolshouldShow_SplineControl() const; virtual boolshouldShow_GeometryControl() const; virtual boolshouldShow_SortByXValuesResourceGroup() const; +virtual boolshouldShow_GL3DResourceGroup() const; virtual voidshowExtraControls(VclBuilderContainer* pParent); virtual voidhideExtraControls() const; diff --git a/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx b/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx index 1b3bfdc..08cb2ec 100644 --- a/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx +++ b/chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx @@ -20,6 +20,11 @@ GL3DBarChartDialogController::GL3DBarChartDialogController() {} GL3DBarChartDialogController::~GL3DBarChartDialogController() {} +bool GL3DBarChartDialogController::shouldShow_GL3DResourceGroup() const +{ +return true; +} + OUString GL3DBarChartDialogController::getName() { return SchResId(STR_TYPE_GL3D_BAR).toString(); diff --git a/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx b/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx index e2f31e2..0adba32 100644 --- a/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx +++ b/chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx @@ -20,6 +20,8 @@ public: GL3DBarChartDialogController(); virtual ~GL3DBarChartDialogController(); +virtual bool shouldShow_GL3DResourceGroup() const; + virtual OUString getName(); virtual Image getImage(); virtual const tTemplateServiceChartTypeParameterMap getTemplateMap() const; diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index 3a880ec..b0c5c1f 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -285,6 +285,40 @@
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2-3' - vcl/source
vcl/source/window/toolbox.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b740953537b324e157b22ce3bd46611b01f78e47 Author: Keith Curtis keit...@gmail.com Date: Mon Mar 17 20:16:57 2014 -0400 Hopefully fix Windows HiDPI toolbar layout bug On Windows HiDPI, toolbar buttons are cut off. This may fix the problem. Here is a screenshot: http://i.imgur.com/NADAvYi.png I can't prove this fixes anything on Windows because I can't see this on Linux and don't really understand the surrounding code. On the other hand, it is easy to prove this is reasonable code. Change-Id: I69c19ad46844bead942ce63883d163cb9d0690c9 Reviewed-on: https://gerrit.libreoffice.org/8637 Tested-by: LibreOffice gerrit bot ger...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com (cherry picked from commit 509441038ab95dd3a60efd1b6c302bf22bfbc631) Reviewed-on: https://gerrit.libreoffice.org/8749 Reviewed-by: Keith Curtis keit...@gmail.com Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Norbert Thiebaud nthieb...@gmail.com Reviewed-by: Norbert Thiebaud nthieb...@gmail.com diff --git a/vcl/source/window/toolbox.cxx b/vcl/source/window/toolbox.cxx index 0d7bf8a..4613879 100644 --- a/vcl/source/window/toolbox.cxx +++ b/vcl/source/window/toolbox.cxx @@ -1747,8 +1747,8 @@ sal_Bool ToolBox::ImplCalcItem() longnDropDownArrowWidth = TB_DROPDOWNARROWWIDTH; // set defaults if image or text is needed but empty -nDefWidth = GetDefaultImageSize().Width(); -nDefHeight = GetDefaultImageSize().Height(); +nDefWidth = GetDefaultImageSize().Width() * GetDPIScaleFactor(); +nDefHeight = GetDefaultImageSize().Height() * GetDPIScaleFactor(); mnWinHeight = 0; // determine minimum size necessary in NWF ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
License Statement
All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. Valentin Kettner Git email: vakevk+libreoff...@gmail.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/source
sc/source/core/tool/token.cxx | 26 ++ 1 file changed, 26 insertions(+) New commits: commit 96ef8a7a03c7b098c71f7ce8540fb61d13eaa298 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Tue Mar 25 12:38:48 2014 -0400 fdo#76402: Handle range reference expansion in named ranges. Change-Id: I8314260fc7588f0a0230ab63cc600fa887a8479d (cherry picked from commit 8582db191b5c88c72e5b16c89a024f897a95a6f1) Reviewed-on: https://gerrit.libreoffice.org/8751 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 5618ed38..ce6a644 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -2949,6 +2949,19 @@ bool adjustDoubleRefInName( ScComplexRefData rRef, const sc::RefUpdateContext rCxt, const ScAddress rPos ) { bool bRefChanged = false; +if (rCxt.mnRowDelta 0 rCxt.mrDoc.IsExpandRefs() !rRef.Ref1.IsRowRel() !rRef.Ref2.IsRowRel()) +{ +// Check and see if we should expand the range at the top. +ScRange aSelectedRange = getSelectedRange(rCxt); +ScRange aAbs = rRef.toAbs(rPos); +if (aSelectedRange.Intersects(aAbs)) +{ +// Selection intersects the referenced range. Only expand the +// bottom position. +rRef.Ref2.IncRow(rCxt.mnRowDelta); +return true; +} +} if (adjustSingleRefInName(rRef.Ref1, rCxt, rPos)) bRefChanged = true; @@ -3007,6 +3020,19 @@ sc::RefUpdateResult ScTokenArray::AdjustReferenceInName( aRes.mbReferenceModified = true; } } +else if (rCxt.mnRowDelta 0 rCxt.mrDoc.IsExpandRefs()) +{ +// Check if we could expand range reference by the bottom +// edge. For named expressions, we only expand absolute +// references. +if (!rRef.Ref1.IsRowRel() !rRef.Ref2.IsRowRel() aAbs.aEnd.Row()+1 == rCxt.maRange.aStart.Row()) +{ +// Expand by the bottom edge. +rRef.Ref2.IncRow(rCxt.mnRowDelta); +aRes.mbReferenceModified = true; +} + +} } break; default: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 8 commits - chart2/qa oox/source test/source
chart2/qa/extras/chart2export.cxx| 60 +++ chart2/qa/extras/charttest.hxx | 13 +++--- chart2/qa/extras/data/xlsx/gapWidth.xlsx |binary oox/source/export/chartexport.cxx|3 - test/source/bootstrapfixture.cxx |2 - 5 files changed, 69 insertions(+), 9 deletions(-) New commits: commit 0b4712812fa78b5bbfb9313c36a14f46e1bc662d Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Wed Mar 26 23:55:56 2014 +0100 enable the export validation for chart ODS tests Don't even think about using the new skip flag for your shiny new test. If you itnroduce tests that show validation errors fix them!! Change-Id: I21bf61a113a35ca204a54d18246848a5788ae559 diff --git a/chart2/qa/extras/chart2export.cxx b/chart2/qa/extras/chart2export.cxx index a817c59f..7697bab 100644 --- a/chart2/qa/extras/chart2export.cxx +++ b/chart2/qa/extras/chart2export.cxx @@ -421,6 +421,7 @@ void Chart2ExportTest::testErrorBarXLSX() // in an export - import cycle using different file formats - ODS, XLS and XLSX. void Chart2ExportTest::testTrendline() { +mbSkipValidation = true; load(/chart2/qa/extras/data/ods/, trendline.ods); checkTrendlinesInChart(getChartDocFromSheet( 0, mxComponent)); reload(calc8); diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx index e9f0047..7a2b22c 100644 --- a/chart2/qa/extras/charttest.hxx +++ b/chart2/qa/extras/charttest.hxx @@ -52,6 +52,7 @@ using namespace com::sun::star::uno; class ChartTest : public test::BootstrapFixture, public unotest::MacrosTest { public: +ChartTest():mbSkipValidation(false) {} void load( const OUString rDir, const OUString rFileName ); boost::shared_ptrutl::TempFile reload( const OUString rFileName ); uno::Sequence OUString getImpressChartColumnDescriptions( const char* pDir, const char* pName ); @@ -65,6 +66,7 @@ public: protected: Reference lang::XComponent mxComponent; OUString maServiceName; +bool mbSkipValidation; // if you set this flag for a new test I'm going to haunt you! }; OUString ChartTest::getFileExtension( const OUString aFileName ) @@ -112,7 +114,8 @@ boost::shared_ptrutl::TempFile ChartTest::reload(const OUString rFilterName) } else if(rFilterName == calc8) { -validate(pTempFile-GetFileName(), test::ODF); +if(!mbSkipValidation) +validate(pTempFile-GetFileName(), test::ODF); } CPPUNIT_ASSERT(mxComponent.is()); commit 712daf33c826101a43e918d0a6285e21ac6e339a Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Wed Mar 26 23:46:04 2014 +0100 remove unimplemented method Change-Id: I28c735478142bcb438ac24482612d5fb52a65f6e diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx index 05ffda9..e9f0047 100644 --- a/chart2/qa/extras/charttest.hxx +++ b/chart2/qa/extras/charttest.hxx @@ -59,7 +59,6 @@ public: uno::Reference chart::XChartDocument getChartDocFromImpress( const char* pDir, const char* pName ); -void loadDocx(const char* pDir, const char* pName); virtual void setUp(); virtual void tearDown(); commit e8ed900016f0c51bc0374bae2a2963510e1ddbdc Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Wed Mar 26 23:45:42 2014 +0100 improve formatting Change-Id: Ic174dee2b0c3005b15b30348bf6aebf20ce50fb8 diff --git a/chart2/qa/extras/charttest.hxx b/chart2/qa/extras/charttest.hxx index e1ce5a5..05ffda9 100644 --- a/chart2/qa/extras/charttest.hxx +++ b/chart2/qa/extras/charttest.hxx @@ -49,7 +49,6 @@ using namespace com::sun::star; using namespace com::sun::star::uno; - class ChartTest : public test::BootstrapFixture, public unotest::MacrosTest { public: @@ -114,7 +113,7 @@ boost::shared_ptrutl::TempFile ChartTest::reload(const OUString rFilterName) } else if(rFilterName == calc8) { -// validate(pTempFile-GetFileName(), test::ODF); +validate(pTempFile-GetFileName(), test::ODF); } CPPUNIT_ASSERT(mxComponent.is()); @@ -136,6 +135,7 @@ void ChartTest::tearDown() test::BootstrapFixture::tearDown(); } + Reference lang::XComponent getChartCompFromSheet( sal_Int32 nSheet, uno::Reference lang::XComponent xComponent ) { // let us assume that we only have one chart per sheet @@ -165,6 +165,7 @@ Reference lang::XComponent getChartCompFromSheet( sal_Int32 nSheet, uno::Refe return xChartComp; } + Reference chart2::XChartDocument getChartDocFromSheet( sal_Int32 nSheet, uno::Reference lang::XComponent xComponent ) { uno::Reference chart2::XChartDocument xChartDoc ( getChartCompFromSheet(nSheet, xComponent), UNO_QUERY_THROW ); @@ -210,7 +211,6 @@ Reference chart2::XDataSeries getDataSeriesFromDoc( uno::Reference chart2::X return xSeries; } - uno::Sequence OUString getWriterChartColumnDescriptions( Reference lang::XComponent mxComponent )
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/PieChart.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit da46a0cbcc656dea15a42d4cfc10e2058258b8cc Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Thu Mar 27 00:21:43 2014 +0100 show negative values correctly in pie charts, fdo#69143 Change-Id: I2a33095f7dceb564911478a30aed1137ddacd531 diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx index 81d3539..d4636ee 100644 --- a/chart2/source/view/charttypes/PieChart.cxx +++ b/chart2/source/view/charttypes/PieChart.cxx @@ -488,13 +488,14 @@ void PieChart::createShapes() aScreenPosition2D.Y += aDirection.getY(); } +double nVal = pSeries-getYValue( nPointIndex ); aPieLabelInfo.xTextShape = this-createDataLabel( xTextTarget, *pSeries, nPointIndex -, fLogicYValue, fLogicYSum, aScreenPosition2D, eAlignment ); +, nVal, fLogicYSum, aScreenPosition2D, eAlignment ); uno::Reference container::XChild xChild( aPieLabelInfo.xTextShape, uno::UNO_QUERY ); if( xChild.is() ) aPieLabelInfo.xLabelGroupShape = uno::Referencedrawing::XShape( xChild-getParent(), uno::UNO_QUERY ); -aPieLabelInfo.fValue = fLogicYValue; +aPieLabelInfo.fValue = nVal; aPieLabelInfo.bMovementAllowed = bMovementAllowed; aPieLabelInfo.bMoved= false; aPieLabelInfo.xTextTarget = xTextTarget; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Depends on||76663 --- Comment #119 from m.a.riosv mari...@miguelangel.mobi --- Added https://bugs.freedesktop.org/show_bug.cgi?id=76663 PRODUCT function returns incorrect results in array formula -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - chart2/source
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx| 10 +- chart2/source/controller/dialogs/ChartTypeDialogController.cxx | 16 +- chart2/source/controller/dialogs/ChartTypeDialogController.hxx |2 - chart2/source/controller/dialogs/tp_ChartType.cxx | 14 +++- chart2/source/model/main/Diagram.cxx |9 + chart2/source/model/template/GL3DBarChartType.cxx |8 ++--- 6 files changed, 42 insertions(+), 17 deletions(-) New commits: commit b54fa152efad24890e5d80822ebff003c41e1913 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 20:52:16 2014 -0400 Pass the rounded edge property to the diagram object. Change-Id: I71fa1bf82b879a1da69ca78d53bcf8072bdfa9ae diff --git a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx index 04670ad..a10ee39 100644 --- a/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx +++ b/chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx @@ -137,7 +137,9 @@ enum PROP_DIAGRAM_DATATABLEHBORDER, PROP_DIAGRAM_DATATABLEVBORDER, PROP_DIAGRAM_DATATABLEOUTLINE, -PROP_DIAGRAM_EXTERNALDATA +PROP_DIAGRAM_EXTERNALDATA, + +PROP_DIAGRAM_ROUNDED_EDGE }; void lcl_AddPropertiesToVector( @@ -444,6 +446,12 @@ void lcl_AddPropertiesToVector( beans::PropertyAttribute::BOUND | beans::PropertyAttribute::MAYBEVOID )); +rOutProperties.push_back( + Property( RoundedEdge, + PROP_DIAGRAM_ROUNDED_EDGE, + ::getCppuBooleanType(), + beans::PropertyAttribute::BOUND + | beans::PropertyAttribute::MAYBEVOID)); } struct StaticDiagramWrapperPropertyArray_Initializer diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx index 835de9e6..4ade1fd 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.cxx +++ b/chart2/source/controller/dialogs/ChartTypeDialogController.cxx @@ -60,7 +60,7 @@ ChartTypeParameter::ChartTypeParameter() , nGeometry3D(DataPointGeometry3D::CUBOID) , eThreeDLookScheme(ThreeDLookScheme_Realistic) , bSortByXValues(false) -, mbGLRoundedEdge(false) +, mbRoundedEdge(false) { } @@ -80,7 +80,7 @@ ChartTypeParameter::ChartTypeParameter( sal_Int32 SubTypeIndex, bool HasXAxisWit , nGeometry3D(DataPointGeometry3D::CUBOID) , eThreeDLookScheme(ThreeDLookScheme_Realistic) , bSortByXValues(false) -, mbGLRoundedEdge(false) +, mbRoundedEdge(false) { } ChartTypeParameter::~ChartTypeParameter() @@ -214,7 +214,7 @@ void ChartTypeDialogController::adjustParameterToMainType( ChartTypeParameter r CurveStyle eCurveStyle = rParameter.eCurveStyle; sal_Int32nGeometry3D = rParameter.nGeometry3D; bool bSortByXValues = rParameter.bSortByXValues; -bool bGLRoundedEdge = rParameter.mbGLRoundedEdge; +bool bRoundedEdge = rParameter.mbRoundedEdge; rParameter = (*aIter).second; @@ -225,7 +225,7 @@ void ChartTypeDialogController::adjustParameterToMainType( ChartTypeParameter r rParameter.eCurveStyle = eCurveStyle; rParameter.nGeometry3D = nGeometry3D; rParameter.bSortByXValues = bSortByXValues; -rParameter.mbGLRoundedEdge = bGLRoundedEdge; +rParameter.mbRoundedEdge = bRoundedEdge; bFoundSomeMatch = true; break; @@ -338,11 +338,11 @@ bool ChartTypeDialogController::commitToModel( const ChartTypeParameter rParame if( rParameter.b3DLook ) ThreeDHelper::setScheme( xDiagram, rParameter.eThreeDLookScheme ); -//SortByXValues +uno::Referencebeans::XPropertySet xDiaProp(xDiagram, uno::UNO_QUERY); +if (xDiaProp.is()) { -uno::Reference beans::XPropertySet xDiaProp( xDiagram, uno::UNO_QUERY ); -if( xDiaProp.is() ) -xDiaProp-setPropertyValue( SortByXValues , uno::makeAny( rParameter.bSortByXValues ) ); +xDiaProp-setPropertyValue(SortByXValues , uno::makeAny(rParameter.bSortByXValues)); +xDiaProp-setPropertyValue(RoundedEdge, uno::makeAny(rParameter.mbRoundedEdge)); } } return false; diff --git a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx b/chart2/source/controller/dialogs/ChartTypeDialogController.hxx index 991c806..c4aee62 100644 --- a/chart2/source/controller/dialogs/ChartTypeDialogController.hxx +++
[Libreoffice-commits] core.git: Branch 'private/kohei/new-chart-type-skeleton' - 2 commits - chart2/source include/xmloff xmloff/source
chart2/source/controller/dialogs/tp_ChartType.cxx | 59 -- include/xmloff/xmltoken.hxx |1 xmloff/source/chart/PropertyMap.hxx |3 + xmloff/source/core/xmltoken.cxx |1 4 files changed, 39 insertions(+), 25 deletions(-) New commits: commit 0c13539e8dd36e629dd74420a23b1d8ed631c870 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 23:07:14 2014 -0400 Make sure to set the RoundedEdge check box on load. Change-Id: Ic62e3f26b2cda28e823c465efb78a397fe781d51 diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index 37e63f8..ab7f525 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -37,27 +37,6 @@ namespace chart using namespace ::com::sun::star; using namespace ::com::sun::star::chart2; -namespace -{ -sal_Bool lcl_getSortByXValues( const uno::Reference chart2::XChartDocument xChartDoc ) -{ -sal_Bool bRet = sal_False; -if( xChartDoc.is() ) -{ -try -{ -uno::Reference beans::XPropertySet xDiaProp( xChartDoc-getFirstDiagram(), uno::UNO_QUERY_THROW ); -xDiaProp-getPropertyValue( SortByXValues ) = bRet; -} -catch( const uno::Exception ex ) -{ -ASSERT_EXCEPTION( ex ); -} -} -return bRet; -} -} - #define POS_3DSCHEME_SIMPLE0 #define POS_3DSCHEME_REALISTIC 1 @@ -848,8 +827,18 @@ void ChartTypeTabPage::stateChanged( ChangingResource* /*pResource*/ ) commitToModel( aParameter ); //detect the new ThreeDLookScheme -aParameter.eThreeDLookScheme = ThreeDHelper::detectScheme( ChartModelHelper::findDiagram( m_xChartModel ) ); -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +uno::ReferenceXDiagram xDiagram = ChartModelHelper::findDiagram(m_xChartModel); +aParameter.eThreeDLookScheme = ThreeDHelper::detectScheme(xDiagram); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues) = aParameter.bSortByXValues; +xPropSet-getPropertyValue(RoundedEdge) = aParameter.mbRoundedEdge; +} +catch ( const uno::Exception ex ) +{ +ASSERT_EXCEPTION(ex); +} //the controls have to be enabled/disabled accordingly this-fillAllControls( aParameter ); @@ -906,7 +895,18 @@ void ChartTypeTabPage::selectMainType() if(!aParameter.b3DLook aParameter.eThreeDLookScheme!=ThreeDLookScheme_Realistic ) aParameter.eThreeDLookScheme=ThreeDLookScheme_Realistic; -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +uno::ReferenceXDiagram xDiagram = ChartModelHelper::findDiagram(m_xChartModel); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues) = aParameter.bSortByXValues; +xPropSet-getPropertyValue(RoundedEdge) = aParameter.mbRoundedEdge; +} +catch ( const uno::Exception ex ) +{ +ASSERT_EXCEPTION(ex); +} + this-fillAllControls( aParameter ); uno::Reference beans::XPropertySet xTemplateProps( this-getCurrentTemplate(), uno::UNO_QUERY ); m_pCurrentMainType-fillExtraControls(aParameter,m_xChartModel,xTemplateProps); @@ -981,7 +981,16 @@ void ChartTypeTabPage::initializePage() if(!aParameter.b3DLook aParameter.eThreeDLookScheme!=ThreeDLookScheme_Realistic ) aParameter.eThreeDLookScheme=ThreeDLookScheme_Realistic; -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues) = aParameter.bSortByXValues; +xPropSet-getPropertyValue(RoundedEdge) = aParameter.mbRoundedEdge; +} +catch (const uno::Exception ex) +{ +ASSERT_EXCEPTION(ex); +} this-fillAllControls( aParameter ); if( m_pCurrentMainType ) commit a00f17c4950cc5ee336323bf19adb2be36abce6b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 22:46:43 2014 -0400 Export RoundedEdge property to ODF. Change-Id: I3b20ef70dac4dc9905a169245e0b48b98a20c697 diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx index 3a5996a..6f6ad44 100644 --- a/include/xmloff/xmltoken.hxx +++ b/include/xmloff/xmltoken.hxx @@ -1533,6 +1533,7 @@ namespace xmloff { namespace token { XML_ROTATION_ALIGN, XML_ROTATION_ANGLE, XML_ROUND, +
[Libreoffice-commits] core.git: 6 commits - chart2/source chart2/uiconfig include/xmloff udkapi/com xmloff/source
chart2/source/controller/chartapiwrapper/DiagramWrapper.cxx | 10 chart2/source/controller/dialogs/ChartTypeDialogController.cxx| 17 + chart2/source/controller/dialogs/ChartTypeDialogController.hxx|3 chart2/source/controller/dialogs/GL3DBarChartDialogController.cxx |5 chart2/source/controller/dialogs/GL3DBarChartDialogController.hxx |2 chart2/source/controller/dialogs/tp_ChartType.cxx | 111 +++--- chart2/source/controller/dialogs/tp_ChartType.hxx |2 chart2/source/model/main/Diagram.cxx |9 chart2/source/model/template/GL3DBarChartType.cxx | 95 chart2/source/model/template/GL3DBarChartType.hxx | 19 + chart2/uiconfig/ui/tp_ChartType.ui| 25 ++ include/xmloff/xmltoken.hxx |1 udkapi/com/sun/star/beans/PropertyAttribute.idl |4 xmloff/source/chart/PropertyMap.hxx |3 xmloff/source/core/xmltoken.cxx |1 15 files changed, 269 insertions(+), 38 deletions(-) New commits: commit d87240c0b2fba39b437f87be2b3c9cf54ad0ee5f Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed Mar 26 23:07:14 2014 -0400 Make sure to set the RoundedEdge check box on load. Change-Id: Ic62e3f26b2cda28e823c465efb78a397fe781d51 diff --git a/chart2/source/controller/dialogs/tp_ChartType.cxx b/chart2/source/controller/dialogs/tp_ChartType.cxx index 37e63f8..ab7f525 100644 --- a/chart2/source/controller/dialogs/tp_ChartType.cxx +++ b/chart2/source/controller/dialogs/tp_ChartType.cxx @@ -37,27 +37,6 @@ namespace chart using namespace ::com::sun::star; using namespace ::com::sun::star::chart2; -namespace -{ -sal_Bool lcl_getSortByXValues( const uno::Reference chart2::XChartDocument xChartDoc ) -{ -sal_Bool bRet = sal_False; -if( xChartDoc.is() ) -{ -try -{ -uno::Reference beans::XPropertySet xDiaProp( xChartDoc-getFirstDiagram(), uno::UNO_QUERY_THROW ); -xDiaProp-getPropertyValue( SortByXValues ) = bRet; -} -catch( const uno::Exception ex ) -{ -ASSERT_EXCEPTION( ex ); -} -} -return bRet; -} -} - #define POS_3DSCHEME_SIMPLE0 #define POS_3DSCHEME_REALISTIC 1 @@ -848,8 +827,18 @@ void ChartTypeTabPage::stateChanged( ChangingResource* /*pResource*/ ) commitToModel( aParameter ); //detect the new ThreeDLookScheme -aParameter.eThreeDLookScheme = ThreeDHelper::detectScheme( ChartModelHelper::findDiagram( m_xChartModel ) ); -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +uno::ReferenceXDiagram xDiagram = ChartModelHelper::findDiagram(m_xChartModel); +aParameter.eThreeDLookScheme = ThreeDHelper::detectScheme(xDiagram); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues) = aParameter.bSortByXValues; +xPropSet-getPropertyValue(RoundedEdge) = aParameter.mbRoundedEdge; +} +catch ( const uno::Exception ex ) +{ +ASSERT_EXCEPTION(ex); +} //the controls have to be enabled/disabled accordingly this-fillAllControls( aParameter ); @@ -906,7 +895,18 @@ void ChartTypeTabPage::selectMainType() if(!aParameter.b3DLook aParameter.eThreeDLookScheme!=ThreeDLookScheme_Realistic ) aParameter.eThreeDLookScheme=ThreeDLookScheme_Realistic; -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +uno::ReferenceXDiagram xDiagram = ChartModelHelper::findDiagram(m_xChartModel); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues) = aParameter.bSortByXValues; +xPropSet-getPropertyValue(RoundedEdge) = aParameter.mbRoundedEdge; +} +catch ( const uno::Exception ex ) +{ +ASSERT_EXCEPTION(ex); +} + this-fillAllControls( aParameter ); uno::Reference beans::XPropertySet xTemplateProps( this-getCurrentTemplate(), uno::UNO_QUERY ); m_pCurrentMainType-fillExtraControls(aParameter,m_xChartModel,xTemplateProps); @@ -981,7 +981,16 @@ void ChartTypeTabPage::initializePage() if(!aParameter.b3DLook aParameter.eThreeDLookScheme!=ThreeDLookScheme_Realistic ) aParameter.eThreeDLookScheme=ThreeDLookScheme_Realistic; -aParameter.bSortByXValues = lcl_getSortByXValues( m_xChartModel ); +try +{ +uno::Referencebeans::XPropertySet xPropSet(xDiagram, uno::UNO_QUERY_THROW); +xPropSet-getPropertyValue(SortByXValues)
[Bug 75489] code pointers
Hi community , i am trying to solve fdo#75489 and i need some help i need some code pointers for it. Thank you - Regards, Abdulmajeed Al-Abdulrazzaq Motah Program, KACST http://www.motah.org.sa Warning: This message and its attachment, if any, are confidential and may contain information protected by law. If you are not the intended recipient, please contact the sender immediately and delete the message and its attachment, if any. You should not copy the message and its attachment, if any, or disclose its contents to any other person or use it for any purpose. Statements and opinions expressed in this e-mail and its attachment, if any, are those of the sender, and do not necessarily reflect those of King Abdulaziz city for Science and Technology (KACST) in the Kingdom of Saudi Arabia. KACST accepts no liability for any damage caused by this email. ?: ??? ??? ??? ? ?? ?? (?? ) ? ?? ? ??? ??? ? ? ???. ??? ?? ??? ? ?? ??? ? ??? ?? ? ??? ? (?? )? ??? ?? ??? ?? ? ??? ??? ?? (?? ) ?? ?? ??? ? ?? ? ?? ? ?? ? ??? ???. ? ??? ??? ??? ? (?? ) ?? ??? ??? ??? ? ? ? ?? ??? ? ??? ? ??? ?? ??? ?? ??? ??? ?? ?? ?? ?? ??? ??. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Typo in Norwegian UI
Hi Olav, There seems to be a typo in the Norwegian interface, see: https://bugs.freedesktop.org/show_bug.cgi?id=76643 Thanks to close the bug when you've corrected it :) Cheers Sophie ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Calc Import Unit Tests - Text Functions
Hey Ken, On Wed, Mar 26, 2014 at 12:27 AM, Ken Biondi kenbio...@hotmail.com wrote: Hello, See the attached two files: functions.ods and text-functions.csv. I extended functions.ods with tests (normal parameter values only) for every text function except BAHTTEXT. text-functions.csv contains the expected results. Both files created on WIN 8 machine. I license this content under MPL/LGPLv3+. Sorry that I missed this patch. I'm going to review it as soon as possible but it looks good already. Please add me in the future in CC so I'm less likely to miss such a mail. Thanks for your work, Markus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 76615] FORMATTING: Paragraph moving not correctly - resulting in a gap
https://bugs.freedesktop.org/show_bug.cgi?id=76615 Daniel Däuble d.daeu...@arcor.de changed: What|Removed |Added Severity|normal |major Priority|medium |high -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 33114] pasting picture with alpha channel
https://bugs.freedesktop.org/show_bug.cgi?id=33114 --- Comment #28 from dE de.tec...@gmail.com --- Confirmed under LO draw. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75441] Tamil99 keyboard typing wrong display when converted to Latha font
https://bugs.freedesktop.org/show_bug.cgi?id=75441 --- Comment #8 from Oppili sripathy...@gmail.com --- Please make tamil99 typing compatible with all the Tamil fonts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] New: MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 Priority: medium Bug ID: 76620 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: MySQL Connector extension fails to build on OSX Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: ipla...@yahoo.co.uk Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.0.0.alpha1 Component: Database Product: LibreOffice Some time during 4.2 development, the code for configuring the mysql connector build got changed with the result that the build of the mysql connector fails at the configuration stage if one uses the following switches on OSX : --enable-ext-mariadb-connector --with-system-mariadb --enable-bundle-mariadb The unhelpful error message which appears is to be found in configure.ac : AC_MSG_ERROR([libmariadb is known to be broken as of 2013-10; use libmysqlclient]) which is the result of the test(s) failing on OSX. The problematic test code appears to be somewhere in here : if test $ENABLE_MARIADBC = TRUE; then SCPDEFS=$SCPDEFS -DWITH_EXTENSION_MARIADBC dnl === dnl Check for system MariaDB dnl === AC_MSG_CHECKING([which MariaDB to use]) if test $with_system_mariadb = yes; then AC_MSG_RESULT([external]) SYSTEM_MARIADB=TRUE #AC_PATH_PROG(MARIADBCONFIG, [mariadb_config]) if test -z $MARIADBCONFIG; then AC_PATH_PROG(MARIADBCONFIG, [mysql_config]) if test -z $MARIADBCONFIG; then #AC_MSG_ERROR([mariadb_config and mysql_config are missing. Install MariaDB or MySQL package.]) AC_MSG_ERROR([mysql_config is missing. Install MySQL client library development package.]) fi fi AC_MSG_CHECKING([MariaDB version]) MARIADB_VERSION=`$MARIADBCONFIG --version` MARIADB_MAJOR=`$MARIADBCONFIG --version | cut -d. -f1` if test $MARIADB_MAJOR -ge 5; then AC_MSG_RESULT([OK]) else AC_MSG_ERROR([too old, use 5.0.x or later]) fi AC_MSG_CHECKING([for MariaDB Client library]) MARIADB_CFLAGS=`$MARIADBCONFIG --cflags` if test $COM_GCC_IS_CLANG = TRUE; then MARIADB_CFLAGS=$(printf '%s' $MARIADB_CFLAGS | sed -e s/-fstack-protector-strong//) fi MARIADB_LIBS=`$MARIADBCONFIG --libs_r` dnl At least mariadb-5.5.34-3.fc20.x86_64 plus dnl mariadb-5.5.34-3.fc20.i686 reports 64-bit specific output even under dnl linux32: if test $OS = LINUX -a $CPUNAME = INTEL; then MARIADB_CFLAGS=$(printf '%s' $MARIADB_CFLAGS | sed -e s/-m64//) MARIADB_LIBS=$(printf '%s' $MARIADB_LIBS \ | sed -e 's|/lib64/|/lib/|') fi AC_MSG_RESULT([includes '$MARIADB_CFLAGS', libraries '$MARIADB_LIBS']) AC_MSG_CHECKING([whether to bundle the MySQL/MariaDB client library]) if test $enable_bundle_mariadb = yes; then AC_MSG_RESULT([yes]) BUNDLE_MARIADB=TRUE LIBMARIADB=lib$(echo ${MARIADB_LIBS} | sed -e 's/[[[:space:]]]\+-l/\n/g' | grep -E '(mysqlclient|mariadb)') if test $_os = Darwin; then LIBMARIADB=${LIBMARIADB}.dylib elif test $_os = WINNT; then LIBMARIADB=${LIBMARIADB}.dll else LIBMARIADB=${LIBMARIADB}.so fi LIBMARIADB_PATH=$($MARIADBCONFIG --variable=pkglibdir) AC_MSG_CHECKING([for $LIBMARIADB in $LIBMARIADB_PATH]) if test -e $LIBMARIADB_PATH/$LIBMARIADB; then AC_MSG_RESULT([found.]) PathFormat $LIBMARIADB_PATH LIBMARIADB_PATH=$formatted_path else AC_MSG_ERROR([not found.]) fi else AC_MSG_RESULT([no]) BUNDLE_MARIADB= fi else AC_MSG_RESULT([internal]) AC_MSG_ERROR([libmariadb is known to be broken as of 2013-10; use libmysqlclient]) SYSTEM_MARIADB= MARIADB_CFLAGS=-I${WORKDIR}/UnpackedTarball/mariadb/include MARIADB_LIBS=-L${WORKDIR}/LinkTarget/StaticLibrary -lmariadblib BUILD_TYPE=$BUILD_TYPE MARIADB fi AC_SUBST(SYSTEM_MARIADB) AC_SUBST(MARIADB_CFLAGS) AC_SUBST(MARIADB_LIBS) AC_SUBST(LIBMARIADB) AC_SUBST(LIBMARIADB_PATH) AC_SUBST(BUNDLE_MARIADB) Additionally, if the alternative configure switches are used : --with-system-mysql-cppconn=/path-to-lib-mysqlcppconn/ --with-system-mariadb=/path-to-libmysql/ They appear to be overridden or ignored by the --enable-ext-mariadb-connector switch. Alex -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||lio...@mamane.lu --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Adding Lionel to CC, I know you don't have a Mac so I'm not expecting you to fix it, just a heads up, as this seems to have been forgotten. The fact of the matter is that this connector now only builds on Linux as far as I can tell, and only the Linux distribs provide the connector with their releases. Alex -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- Adding other mysql/Base users as a heads up. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75595] VCL GTK3 plugin does not work completely
https://bugs.freedesktop.org/show_bug.cgi?id=75595 Ravikumar Tulugu naidu@gmail.com changed: What|Removed |Added OS|NetBSD |Linux (All) CC||naidu@gmail.com Version|4.2.1.1 release |4.2.2.1 release --- Comment #1 from Ravikumar Tulugu naidu@gmail.com --- This also happens on linux as well, not sure about other distros but this is found on ubuntu 13.10 amd 64 server distro. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76607] vector::_M_range_check crash when sorting mixed formula and value
https://bugs.freedesktop.org/show_bug.cgi?id=76607 --- Comment #1 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hello On windows XP Version: 4.2.3.1 Build ID: 3d4fc3d9dbf8f4c0aeb61498a81f91c5b7922f13 I do not reproduce with *those* steps. I reproduce the crash by following these steps: 1. Open attached file 2. Select any cell in column B (e.g. B1) 3. Click on button Sort Ascending Expected Actual results : the table is sorted 4. Click on button Sort Descending Crash The crash also occurs if you select any cell in column E (e.g. E1) in step 2 (the cells in column E are calculated from column B) Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75703] FILEOPEN: Logo transparency problem in .xls file
https://bugs.freedesktop.org/show_bug.cgi?id=75703 Nicolas Mailhot nicolas.mail...@laposte.net changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFORME |--- --- Comment #4 from Nicolas Mailhot nicolas.mail...@laposte.net --- Then you've found a bug in excel 2011 for mac (I assume the word part is a typo). Does not change the bug in Libreoffice. Recreating a different file does not invalidate the bug hit with the attached testcase. Please do not close bugs where you have not used the provided testcase to test. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76615] FORMATTING: Paragraph moving not correctly - resulting in a gap
https://bugs.freedesktop.org/show_bug.cgi?id=76615 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||c...@nouenoff.nl Ever confirmed|0 |1 --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Hi Daniel, Thanks for your report. It would be my strong bet, that this is just a case of mixing styles / direct formatting and such. But maybe I'm wrong ;) Can you pls attach your sample editable document? Did you have contact with our user support http://www.libreoffice.org/get-help/community-support/ regards, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76615] FORMATTING: Paragraph moving not correctly - resulting in a gap
https://bugs.freedesktop.org/show_bug.cgi?id=76615 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Severity|major |normal Priority|high|medium -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 72872] FILEOPEN: DOCX file with shapes disappear or can't resize
https://bugs.freedesktop.org/show_bug.cgi?id=72872 Jacobo Aragunde Pérez jaragu...@igalia.com changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #6 from Jacobo Aragunde Pérez jaragu...@igalia.com --- Verified in master, commit b2b3dd2fe6d771f8c662ceb7dcab95149606f041. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76615] FORMATTING: Paragraph moving not correctly - resulting in a gap
https://bugs.freedesktop.org/show_bug.cgi?id=76615 --- Comment #2 from Daniel Däuble d.daeu...@arcor.de --- As mentioned before, I have problems with attaching files here. Maybe someone else can do that for me and take files from https://drive.google.com/folderview?id=0B8E-6W_To5FlVFVjeXJQWVlKRTgusp=sharing The original document where the error occured is in Document.zip. The error with formulas is reproduceable with any document I think. See screenshots in folder Formel. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76615] FORMATTING: Paragraph moving not correctly - resulting in a gap
https://bugs.freedesktop.org/show_bug.cgi?id=76615 --- Comment #3 from Daniel Däuble d.daeu...@arcor.de --- Unfortunately on the screenshots in /Formel are no comments, so: When oversizing a formula by editing in formula-editor, the space under the formula doesn't resolve automatically, I have to remove and paste the formula to get correct behaviour. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76607] vector::_M_range_check crash when sorting mixed formula and value
https://bugs.freedesktop.org/show_bug.cgi?id=76607 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Keywords||regression --- Comment #2 from Laurent BP jumbo4...@yahoo.fr --- Thanks Pierre-Yves: your simpler procedure results in crash also for me with Version: 4.2.3.1 Build ID: 3d4fc3d9dbf8f4c0aeb61498a81f91c5b7922f13 NOT reproduce with Version: 4.1.5.3 Build ID: 1c1366bba2ba2b554cd2ca4d87c06da81c05d24 add Regression as Keyword -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76622] New: Feature Request: Brush Tool (Transfer Format from Cell to Cell) : Enhance with STRG / CRTL Key
https://bugs.freedesktop.org/show_bug.cgi?id=76622 Priority: medium Bug ID: 76622 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Feature Request: Brush Tool (Transfer Format from Cell to Cell) : Enhance with STRG / CRTL Key Severity: normal Classification: Unclassified OS: All Reporter: jkl...@freenet.de Hardware: Other Status: UNCONFIRMED Version: 4.2.3.1 rc Component: Spreadsheet Product: LibreOffice It might be usefull to enhance the functionality of this tool, to transfer the format of one cell to some other cells if they are not connected directly Pressing STRG / CRTL should enable to hold the function active until released regards karl -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Depends on||76607 --- Comment #118 from Laurent BP jumbo4...@yahoo.fr --- Add bug 76607: Calc crash when sorting in specific case -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76607] vector::_M_range_check crash when sorting mixed formula and value
https://bugs.freedesktop.org/show_bug.cgi?id=76607 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Blocks||65675 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #3 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to comment #0) Some time during 4.2 development, the code for configuring the mysql connector build got changed with the result that the build of the mysql connector fails at the configuration stage if one uses the following switches on OSX : --enable-ext-mariadb-connector --with-system-mariadb --enable-bundle-mariadb The unhelpful error message which appears is to be found in configure.ac : AC_MSG_ERROR([libmariadb is known to be broken as of 2013-10; use libmysqlclient]) I added that error message. This error message should definitely *not* appear if --with-system-mariadb is used. Reading configure.ac, I don't understand how it can. If it appears and --with-system-mariadb is used, then please show me the output of ./autogen.sh (in particular the line checking which MariaDB to use), all arguments passed to it, the files autogen.lastrun and autogen.input and config.log. Additionally, if the alternative configure switches are used : --with-system-mysql-cppconn=/path-to-lib-mysqlcppconn/ --with-system-mariadb=/path-to-libmysql/ They appear to be overridden or ignored by the --enable-ext-mariadb-connector switch. That, too, should definitely not happen. I suspect something in autogen.lastrun, autogen.input or some --with-distro=FOO setting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76624] New: EDITING: LibreOffice Writer hangs copy paste image into document
https://bugs.freedesktop.org/show_bug.cgi?id=76624 Priority: medium Bug ID: 76624 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: LibreOffice Writer hangs copy paste image into document Severity: normal Classification: Unclassified OS: Linux (All) Reporter: josezamor...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.1.1 release Component: Writer Product: LibreOffice Created attachment 96404 -- https://bugs.freedesktop.org/attachment.cgi?id=96404action=edit LibreOffice Writer hangs Problem description: When copying images of web pages libreoffice writer crashes, this happens when you copy and paste images from the web browser Google Chrome and Firefox. Steps to reproduce: 1. Copy image (left click - Copy image) for example: https://www.google.com.mx/search?q=solsource=lnmstbm=ischsa=Xei=R5UyU5e5OOXLsQT8rIDAAwved=0CAYQ_AUoAQbiw=1024bih=483#facrc=_imgdii=_imgrc=LqB-IrJ9puxFEM%253A%3BJ_D6dBUvsAJ5qM%3Bhttp%253A%252F%252Fupload.wikimedia.org%252Fwikipedia%252Fcommons%252Ff%252Ff6%252FAfiche_del_sol.svg%3Bhttp%253A%252F%252Fes.wikipedia.org%252Fwiki%252FSol%3B3880%3B2560 2. Paste image (left click - paste into LibreOffice Writer document. Current behavior: LibreOffice Writer hangs. Expected behavior: LibreOffice Writer must paste the image without hangs. Operating System: Ubuntu Version: 4.2.1.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76607] vector::_M_range_check crash when sorting mixed formula and value
https://bugs.freedesktop.org/show_bug.cgi?id=76607 --- Comment #3 from Laurent BP jumbo4...@yahoo.fr --- With Version: 4.3.0.0.alpha0+ Build ID: 9278df2c21fed09b6b10465ca33b227ad7c49b41 TinderBox: Win-x86@47-TDF, Branch:MASTER, Time: 2014-03-19_08:44:54 I cannot reproduce crash with procedure neither of comment 1 nor of comment 2 However, if with procedure of comment 1, I do some other sorts on column C, D and E, it ends with a crash. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76624] EDITING: LibreOffice Writer hangs copy paste image into document
https://bugs.freedesktop.org/show_bug.cgi?id=76624 Jose Zamora josezamor...@gmail.com changed: What|Removed |Added Priority|medium |high Version|4.2.1.1 release |4.2.2.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76613] Memory read error on program Exit
https://bugs.freedesktop.org/show_bug.cgi?id=76613 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Attachment #96394|text/plain |image/jpeg mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76613] Null pointer dereference on program Exit
https://bugs.freedesktop.org/show_bug.cgi?id=76613 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||sberg...@redhat.com Summary|Memory read error on|Null pointer dereference on |program Exit|program Exit -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76611] FILEOPEN: Error formula on .XLS file
https://bugs.freedesktop.org/show_bug.cgi?id=76611 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE CC||mari...@miguelangel.mobi --- Comment #1 from m.a.riosv mari...@miguelangel.mobi --- I think this is a duplicate of https://bugs.freedesktop.org/show_bug.cgi?id=74345, please if you are not agree, reopen it. *** This bug has been marked as a duplicate of bug 74345 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76622] Feature Request: Brush Tool (Transfer Format from Cell to Cell) : Enhance with STRG / CRTL Key
https://bugs.freedesktop.org/show_bug.cgi?id=76622 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||mari...@miguelangel.mobi Ever confirmed|0 |1 --- Comment #1 from m.a.riosv mari...@miguelangel.mobi --- One for you Karl. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76622] Feature Request: Brush Tool (Transfer Format from Cell to Cell) : Enhance with STRG / CRTL Key
https://bugs.freedesktop.org/show_bug.cgi?id=76622 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76625] New: UI conditional formatting: no feedback when editing
https://bugs.freedesktop.org/show_bug.cgi?id=76625 Priority: medium Bug ID: 76625 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI conditional formatting: no feedback when editing Severity: enhancement Classification: Unclassified OS: All Reporter: freedesktop@murb.nl Hardware: Other Status: UNCONFIRMED Version: 4.2.2.1 release Component: Spreadsheet Product: LibreOffice Problem description: There is no feedback when you are editing the condition for a conditional format to appear. For example equal to 'A' doesn't work (it should be equal to A) Steps to reproduce: 1. Create document 2. Type A in first cell (without the quotes) 3. Format - Conditional Format - Condition ... 4. Choose [Cell value] [is equal to] [A] 5. Apply style [Header style] Current behavior: No warning whatsoever that this is not going to work, similarly, 'A' is also not leading to any warnings Expected behavior: When you type in a cell =FIND('A';A1) in B2 (instead of the correct =FIND(B;A1) ) the preview should at least show #VALUE! like when a formula contains an incorrect value (I believe that even this warning should be improved (but that would be a different issue)) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- Testing with: --with-ant-home=/Volumes/HD1/Shared/Repos/LO/packages/apache-ant-1.9.2 --without-junit --enable-64-bit --with-extra-buildid --enable-vlc --enable-ext-nlpsolver --enable-ext-google-docs --enable-ext-languagetool --enable-ext-diagram --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-extra-template --enable-extra-gallery --enable-ext-wiki-publisher --enable-extension-integration --with-lang=fr --with-help --enable-epm --with-package-format=dmg --with-system-mariadb --with-system-mysql-cppconn --enable-ext-mariadb-connector gives : checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... external checking for mysql_config... no configure: error: mysql_config is missing. Install MySQL client library development package. Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- Testing with: --with-ant-home=/Volumes/HD1/Shared/Repos/LO/packages/apache-ant-1.9.2 --without-junit --enable-64-bit --with-extra-buildid --enable-vlc --enable-ext-nlpsolver --enable-ext-google-docs --enable-ext-languagetool --enable-ext-diagram --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-extra-template --enable-extra-gallery --enable-ext-wiki-publisher --enable-extension-integration --with-lang=fr --with-help --enable-epm --with-package-format=dmg --with-system-mariadb=/Shared/Repos/LO/packages/mysql-connector-c-6.1.2-osx10.7-x86_64/ --with-system-mysql-cppconn=/Shared/Repos/LO/packages/mysql-connector-c++-1.1.3-osx10.7-x86-64bit/ --enable-ext-mariadb-connector gives : checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... internal configure: error: libmariadb is known to be broken as of 2013-10; use libmysqlclient Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. make: *** [/Volumes/HD1/Shared/Repos/LO/core/config_host.mk] Error 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- Testing with: --with-ant-home=/Volumes/HD1/Shared/Repos/LO/packages/apache-ant-1.9.2 --without-junit --enable-64-bit --with-extra-buildid --enable-vlc --enable-ext-nlpsolver --enable-ext-google-docs --enable-ext-languagetool --enable-ext-diagram --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-extra-template --enable-extra-gallery --enable-ext-wiki-publisher --enable-extension-integration --with-lang=fr --with-help --enable-epm --with-package-format=dmg --enable-ext-mariadb-connector gives : checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... internal configure: error: libmariadb is known to be broken as of 2013-10; use libmysqlclient Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74654] PDF Security options (can't print file)
https://bugs.freedesktop.org/show_bug.cgi?id=74654 Helping Hand toeg...@iol.pt changed: What|Removed |Added CC||toeg...@iol.pt --- Comment #14 from Helping Hand toeg...@iol.pt --- I'm having the same problem not being able to print an exported PDF set with a permission password. That is to say, it only occurs in LO for windows, LO for Linux (in my case Mint 16) does not seem to have this hiccup. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- Testing with: --with-ant-home=/Volumes/HD1/Shared/Repos/LO/packages/apache-ant-1.9.2 --without-junit --enable-64-bit --with-extra-buildid --enable-vlc --enable-ext-nlpsolver --enable-ext-google-docs --enable-ext-languagetool --enable-ext-diagram --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-extra-template --enable-extra-gallery --enable-ext-wiki-publisher --enable-extension-integration --with-lang=fr --with-help --enable-epm --with-package-format=dmg --with-system-mysql-cppconn=/Shared/Repos/LO/packages/mysql-connector-c++-1.1.3-osx10.7-x86-64bit/ --enable-ext-mariadb-connector gives: checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... internal configure: error: libmariadb is known to be broken as of 2013-10; use libmysqlclient Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. make: *** [/Volumes/HD1/Shared/Repos/LO/core/config_host.mk] Error 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk --- Testing with: --with-ant-home=/Volumes/HD1/Shared/Repos/LO/packages/apache-ant-1.9.2 --without-junit --enable-64-bit --with-extra-buildid --enable-vlc --enable-ext-nlpsolver --enable-ext-google-docs --enable-ext-languagetool --enable-ext-diagram --enable-ext-typo --enable-ext-validator --enable-ext-watch-window --enable-extra-template --enable-extra-gallery --enable-ext-wiki-publisher --enable-extension-integration --with-lang=fr --with-help --enable-epm --with-package-format=dmg --with-system-mariadb=/Shared/Repos/LO/packages/mysql-connector-c-6.1.2-osx10.7-x86_64/ --enable-ext-mariadb-connector gives: checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... internal configure: error: libmariadb is known to be broken as of 2013-10; use libmysqlclient Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. make: *** [/Volumes/HD1/Shared/Repos/LO/core/config_host.mk] Error 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76620] MySQL Connector extension fails to build on OSX
https://bugs.freedesktop.org/show_bug.cgi?id=76620 --- Comment #9 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to comment #4) Testing with: --with-system-mariadb --with-system-mysql-cppconn --enable-ext-mariadb-connector gives : checking whether to build the MariaDB/MySQL Connector extension... yes checking which MariaDB to use... external checking for mysql_config... no configure: error: mysql_config is missing. Install MySQL client library development package. Error running configure at /Volumes/HD1/Shared/Repos/LO/core/autogen.sh line 248. mysql_config is not in the PATH. Either extend the PATH to add the directory where mysql_config is, or set the MARIADBCONFIG environment variable (example path, don't know if it is the right one on your system): export MARIADBCONFIG=/Shared/Repos/LO/packages/mysql-connector-c-6.1.2-osx10.7-x86_64/bin/ ./autogen.sh -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76627] New: Extensions;WWW
https://bugs.freedesktop.org/show_bug.cgi?id=76627 Priority: medium Bug ID: 76627 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Extensions;WWW Severity: normal Classification: Unclassified OS: All Reporter: kking1...@gmail.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: Extensions Product: LibreOffice I'm no tech, but have had continual issues with 3.6 since installed (professionally). I hardly use anything except Libre Writer, which freezes, crashes and numerous issues with features, I've updated a number of times, and went to site to update (my notice said 4.1.4, but as there was no option for this I selected 4.1.5. The site times out (error 504) before I can download anything, and keeps returning me to the 'donate' page. I attempted to repair through my control panel program, which like everything in Libre Office takes forever. Even shutting the program down is next to impossible, as the screen drops slowly like a curtain and freezes anything else I may have open. I never have these problems except when I've been using Libre Office. Automatic updates don't work and since I can't even update from your site, I guess I'm stuck with it. You have a lot of bugs, and I appreciate your efforts, so why not just come out with a simpler version for those who just like to write so we don't have such a CPU hog to deal with which even Task Manager can't close? Thank you for your time. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69461] SLIDESHOW: Inserted Movie files show a white screen for about one frame at the start
https://bugs.freedesktop.org/show_bug.cgi?id=69461 --- Comment #23 from NoWorries sbc_hates_s...@yahoo.com.au --- Thanks for your support on this issue and your contribution. I am still surprised that the developers do not realize how embarrassing this problem is to those using LO Impress for a presentation with movies included. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs