LibreOffice Gerrit News for core on 2014-03-29
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo76734-Text Box is not preserved for file created in MSWord 2007. in https://gerrit.libreoffice.org/8782 from Sourav Mahajan about module sw End of freshness + fdo#57950 Replace chained append() with operator+ in https://gerrit.libreoffice.org/8701 from Krisztian Pinter about module sw + fdo#57950 Replace chained append in htmlatr.cxx in https://gerrit.libreoffice.org/8661 from Krisztian Pinter about module sw + Presentation string for recently-added border types in https://gerrit.libreoffice.org/8781 from Luke Deller about module editeng, include + .doc support for recently-added border line types in https://gerrit.libreoffice.org/8780 from Luke Deller about module editeng, sw + fdo#73147 add Excel2010 functions NETWORKDAYS.INTL and WORKDAY.INTL in https://gerrit.libreoffice.org/8772 from Winfried Donkers about module formula, include, sc + Remove unnecessary(?) warnings_not_errors for vcl KDE code in https://gerrit.libreoffice.org/8775 from Stephan Bergmann about module vcl * Merged changes on master for project core changed in the last 25 hours: + fdo#74702 Refactor OutputDevice::DrawTransparent() in https://gerrit.libreoffice.org/8779 from Chris Sherlock + Fix another typo in a comment in https://gerrit.libreoffice.org/8778 from Chris Sherlock + Fix comment typos in OutputDevice::DrawTransparent() in https://gerrit.libreoffice.org/8777 from Chris Sherlock + fdo#75280 Started cleaning up of sal_uIntPtr usage. in https://gerrit.libreoffice.org/8631 from V V + fdo#38844 Remove XOR rendering code from canvas module in https://gerrit.libreoffice.org/8715 from Krisztian Pinter + fdo#68546 Make menubar's text color of persona the same as Firefox in https://gerrit.libreoffice.org/8712 from Isamu Mogi + fdo#68546 Update style settings before changing layout in https://gerrit.libreoffice.org/8714 from Isamu Mogi + fdo#68546 Add menubar's text color of persona to StyleSettings in https://gerrit.libreoffice.org/8711 from Isamu Mogi + fdo#68546 Update settings for MenuBarWindow in InitStyleSettings in https://gerrit.libreoffice.org/8713 from Isamu Mogi + fdo-50672 Escape underscores in menus for unity in https://gerrit.libreoffice.org/8773 from Samuel Mehrbrodt * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#75757 Remove inheritance to std::map from PropertyMap in https://gerrit.libreoffice.org/8656 from Krisztian Pinter + Remove visual noise from ios in https://gerrit.libreoffice.org/8274 from Alexander Wilms + FDO#75205 : Charts - Up Down bars are getting added to Line Chart. in https://gerrit.libreoffice.org/8360 from Umesh Kadam + WIP: Converting ExtensionUpdate dialog for new format in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes + Refactored swooxmlexport tests cases. Added function to check contents. in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar + FDO#74886: Data labels are not preserved for Column Chart in RT file in https://gerrit.libreoffice.org/8098 from Umesh Kadam + sal: use posix_memalign only if it's available in https://gerrit.libreoffice.org/8405 from Douglas Mencken + fdo#71984 fix first line indentation in footnotes for MS Word documents in https://gerrit.libreoffice.org/8160 from Andras Timar + fd0#74150:Numbered list getting display after RT -table-within-table-1.do in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji + Lots of changes to Tango icons in https://gerrit.libreoffice.org/7987 from Miroslav Mazel + sw/docx export: fix handling of document with header and section(s) in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer + fdo#51525 Fix duplicate Paste Special entries in Calc. in https://gerrit.libreoffice.org/7784 from Andrzej Hunt + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + sa/l add release_assert() and assert that stay even in release code in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt + Positional Tab additions in https://gerrit.libreoffice.org/5387 from Adam CloudOn Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
Re: minutes of ESC call ...
On Thu, 2014-03-27 at 15:51 +, Michael Meeks wrote: + can we publish the latest callgrind output files ? (Michael) + sounds reasonable AI: + look into automatic up-load of data last callgrind traces (Matus/Cloph) Done, it's all uploaded to http://dev-builds.libreoffice.org/callgrind_report/ Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/webdav/webdavprovider.cxx |3 ++-
ucb/source/ucp/webdav/webdavprovider.hxx |1 +
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 1ab55661f3194aa78a0f95c6397d2b546775d04c
Author: Matúš Kukan matus.ku...@collabora.com
Date: Sat Mar 29 10:53:09 2014 +0100
webdav: Store DAVSessionFactory again in ContentProvider.
So that we use only one its instance.
Erroneously removed in 05671c1f01c73bd3f4773c9653d95e3188657eb3.
Change-Id: I714e41bf0b9af88f1bb0d8809a108370c73a9849
diff --git a/ucb/source/ucp/webdav/webdavprovider.cxx
b/ucb/source/ucp/webdav/webdavprovider.cxx
index 0cf92da..16684d8 100644
--- a/ucb/source/ucp/webdav/webdavprovider.cxx
+++ b/ucb/source/ucp/webdav/webdavprovider.cxx
@@ -39,6 +39,7 @@ using namespace http_dav_ucp;
ContentProvider::ContentProvider(
const uno::Reference uno::XComponentContext rContext )
: ::ucbhelper::ContentProviderImplHelper( rContext ),
+ m_xDAVSessionFactory( new DAVSessionFactory() ),
m_pProps( 0 )
{
}
@@ -195,7 +196,7 @@ ContentProvider::queryContent(
try
{
xContent = new ::http_dav_ucp::Content(
-m_xContext, this, xCanonicId, new DAVSessionFactory()
);
+m_xContext, this, xCanonicId, m_xDAVSessionFactory );
registerNewContent( xContent );
}
catch ( ucb::ContentCreationException const )
diff --git a/ucb/source/ucp/webdav/webdavprovider.hxx
b/ucb/source/ucp/webdav/webdavprovider.hxx
index caf95600..9d5c819 100644
--- a/ucb/source/ucp/webdav/webdavprovider.hxx
+++ b/ucb/source/ucp/webdav/webdavprovider.hxx
@@ -68,6 +68,7 @@ namespace http_dav_ucp {
class ContentProvider : public ::ucbhelper::ContentProviderImplHelper
{
+rtl::Reference DAVSessionFactory m_xDAVSessionFactory;
PropertyMap * m_pProps;
public:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/fmsearchdialog.ui |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 937d3d65b1fc52c821f67a618fad637ff7590d8c Author: Andras Timar andras.ti...@collabora.com Date: Sat Mar 29 11:40:36 2014 +0100 add translatable attribute to some .ui labels/items Change-Id: I9c626965d0185cf651a5a304e15754e549d893b2 diff --git a/cui/uiconfig/ui/fmsearchdialog.ui b/cui/uiconfig/ui/fmsearchdialog.ui index e4f431d..d945ce9 100644 --- a/cui/uiconfig/ui/fmsearchdialog.ui +++ b/cui/uiconfig/ui/fmsearchdialog.ui @@ -753,7 +753,7 @@ object class=GtkLabel id=flOptions property name=visibleTrue/property property name=can_focusFalse/property -property name=labelSettings/property +property name=label translatable=yesSettings/property property name=use_underlineTrue/property attributes attribute name=weight value=bold/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sot include/svl sot/source
include/sot/stg.hxx |6 +++---
include/svl/instrm.hxx |2 +-
include/svl/strmadpt.hxx |4 ++--
sot/source/sdstor/stg.cxx|2 +-
sot/source/sdstor/stgole.hxx |2 +-
sot/source/sdstor/stgstrms.hxx |4 ++--
sot/source/sdstor/ucbstorage.cxx |2 +-
7 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit 3e71c1068a4691f19bef94b225770488aaa80390
Author: Matúš Kukan matus.ku...@collabora.com
Date: Sat Mar 29 11:46:47 2014 +0100
Fix some types in virtual methods to properly override.
Thanks to SAL_OVERRIDE!
Adapting to 1258b576aef2ff3cdd4f44e1c03edb8c862a79f6
Change-Id: Iafc9660312ad33f6136c15170c35a59e61c76b26
diff --git a/include/sot/stg.hxx b/include/sot/stg.hxx
index f2c72ff..2805d2a 100644
--- a/include/sot/stg.hxx
+++ b/include/sot/stg.hxx
@@ -78,7 +78,7 @@ public:
TYPEINFO_OVERRIDE();
virtual sal_uLong Read( void * pData, sal_uLong nSize ) = 0;
virtual sal_uLong Write( const void* pData, sal_uLong nSize ) = 0;
-virtual sal_uLong Seek( sal_uLong nPos ) = 0;
+virtual sal_uInt64 Seek( sal_uInt64 nPos ) = 0;
virtual sal_uLong Tell() = 0;
virtual voidFlush() = 0;
virtual boolSetSize( sal_uLong nNewSize ) = 0;
@@ -160,7 +160,7 @@ public:
StorageStream( StgIo*, StgDirEntry*, StreamMode );
virtual sal_uLong Read( void * pData, sal_uLong nSize ) SAL_OVERRIDE;
virtual sal_uLong Write( const void* pData, sal_uLong nSize )
SAL_OVERRIDE;
-virtual sal_uLong Seek( sal_uLong nPos ) SAL_OVERRIDE;
+virtual sal_uInt64 Seek( sal_uInt64 nPos ) SAL_OVERRIDE;
virtual sal_uLong Tell() SAL_OVERRIDE { return nPos; }
virtual voidFlush() SAL_OVERRIDE;
virtual boolSetSize( sal_uLong nNewSize ) SAL_OVERRIDE;
@@ -255,7 +255,7 @@ public:
virtual sal_uLong Read( void * pData, sal_uLong nSize )
SAL_OVERRIDE;
virtual sal_uLong Write( const void* pData, sal_uLong nSize )
SAL_OVERRIDE;
-virtual sal_uLong Seek( sal_uLong nPos ) SAL_OVERRIDE;
+virtual sal_uInt64 Seek( sal_uInt64 nPos ) SAL_OVERRIDE;
virtual sal_uLong Tell() SAL_OVERRIDE;
virtual voidFlush() SAL_OVERRIDE;
virtual boolSetSize( sal_uLong nNewSize ) SAL_OVERRIDE;
diff --git a/include/svl/instrm.hxx b/include/svl/instrm.hxx
index 9571e54..222f79a 100644
--- a/include/svl/instrm.hxx
+++ b/include/svl/instrm.hxx
@@ -39,7 +39,7 @@ class SVL_DLLPUBLIC SvInputStream: public SvStream
com::sun::star::uno::Reference com::sun::star::io::XSeekable
m_xSeekable;
SvDataPipe_Impl * m_pPipe;
-sal_uLong m_nSeekedFrom;
+sal_uInt64 m_nSeekedFrom;
SVL_DLLPRIVATE bool open();
diff --git a/include/svl/strmadpt.hxx b/include/svl/strmadpt.hxx
index 872a850..9d1645b 100644
--- a/include/svl/strmadpt.hxx
+++ b/include/svl/strmadpt.hxx
@@ -43,10 +43,10 @@ public:
rTheOutputStream):
m_xOutputStream(rTheOutputStream), m_nPosition(0) {}
-virtual ErrCode ReadAt(sal_uInt64, void *, sal_uLong, sal_uInt64 *) const
SAL_OVERRIDE;
+virtual ErrCode ReadAt(sal_uInt64, void *, sal_uLong, sal_Size *) const
SAL_OVERRIDE;
virtual ErrCode WriteAt(sal_uInt64 nPos, const void * pBuffer, sal_uLong
nCount,
-sal_uInt64 * pWritten) SAL_OVERRIDE;
+sal_Size * pWritten) SAL_OVERRIDE;
virtual ErrCode Flush() const SAL_OVERRIDE;
diff --git a/sot/source/sdstor/stg.cxx b/sot/source/sdstor/stg.cxx
index 6ffb6ba..d6ae01e 100644
--- a/sot/source/sdstor/stg.cxx
+++ b/sot/source/sdstor/stg.cxx
@@ -223,7 +223,7 @@ sal_uLong StorageStream::Write( const void* pData,
sal_uLong nSize )
return nSize;
}
-sal_uLong StorageStream::Seek( sal_uLong n )
+sal_uInt64 StorageStream::Seek( sal_uInt64 n )
{
if( Validate() )
return nPos = pEntry-Seek( n );
diff --git a/sot/source/sdstor/stgole.hxx b/sot/source/sdstor/stgole.hxx
index 9dd24ee..02f0264 100644
--- a/sot/source/sdstor/stgole.hxx
+++ b/sot/source/sdstor/stgole.hxx
@@ -30,7 +30,7 @@ class StgInternalStream : public SvStream
BaseStorageStream* pStrm;
virtual sal_uLong GetData( void* pData, sal_uLong nSize ) SAL_OVERRIDE;
virtual sal_uLong PutData( const void* pData, sal_uLong nSize )
SAL_OVERRIDE;
-virtual sal_uLong SeekPos( sal_uLong nPos ) SAL_OVERRIDE;
+virtual sal_uInt64 SeekPos( sal_uInt64 nPos ) SAL_OVERRIDE;
virtual void FlushData() SAL_OVERRIDE;
public:
StgInternalStream( BaseStorage, const OUString, bool );
diff --git a/sot/source/sdstor/stgstrms.hxx b/sot/source/sdstor/stgstrms.hxx
index e2c2574c..27fdd62 100644
--- a/sot/source/sdstor/stgstrms.hxx
+++ b/sot/source/sdstor/stgstrms.hxx
@@ -150,14 +150,14 @@ class StgTmpStrm : public SvMemoryStream
using SvMemoryStream::GetData;
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 Samuel M. s.mehrbr...@gmail.com changed: What|Removed |Added CC||andreas_para...@web.de --- Comment #37 from Samuel M. s.mehrbr...@gmail.com --- *** Bug 48324 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 --- Comment #38 from Stéphane Champeau stephane.champ...@gmail.com --- Hi, bug #61991 seem duplicate this one -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: basic/source filter/source
basic/source/runtime/iosys.cxx |4 ++--
filter/source/graphicfilter/itiff/itiff.cxx |2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit d761d5e219d745c10997c4accfbfc9eb5717d0e8
Author: Matúš Kukan matus.ku...@collabora.com
Date: Sat Mar 29 12:08:09 2014 +0100
error: no matching function for call to..
Change-Id: I4792f9deb162c5e7bde16e54a55f80a83eb90b70
diff --git a/basic/source/runtime/iosys.cxx b/basic/source/runtime/iosys.cxx
index c4bd913..940d6d5 100644
--- a/basic/source/runtime/iosys.cxx
+++ b/basic/source/runtime/iosys.cxx
@@ -359,14 +359,14 @@ OslStream::~OslStream()
sal_Size OslStream::GetData(void* pData, sal_Size nSize)
{
-sal_Size nBytesRead = nSize;
+sal_uInt64 nBytesRead = nSize;
maFile.read( pData, nBytesRead, nBytesRead );
return nBytesRead;
}
sal_Size OslStream::PutData(const void* pData, sal_Size nSize)
{
-sal_Size nBytesWritten;
+sal_uInt64 nBytesWritten;
maFile.write( pData, nSize, nBytesWritten );
return nBytesWritten;
}
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index dc27652..fb24548 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1110,7 +1110,7 @@ bool TIFFReader::HasAlphaChannel() const
sal_Bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic rGraphic )
{
sal_uInt16 i, nNumTags, nTagType;
-sal_uLong nMaxPos;
+sal_uInt64 nMaxPos;
sal_uLong nPos;
sal_uInt32 nFirstIfd, nDataLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/itiff/itiff.cxx |2 +-
filter/source/msfilter/escherex.cxx |4 ++--
filter/source/msfilter/msdffimp.cxx |4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 7a120ad4ac99ac70c35132d12d11d630b92bd846
Author: Matúš Kukan matus.ku...@collabora.com
Date: Sat Mar 29 12:52:14 2014 +0100
few more type fixes
Change-Id: I6b953a6792c8c72c29dc0e7b25bdae41da50ca6d
diff --git a/filter/source/graphicfilter/itiff/itiff.cxx
b/filter/source/graphicfilter/itiff/itiff.cxx
index fb24548..c15465f 100644
--- a/filter/source/graphicfilter/itiff/itiff.cxx
+++ b/filter/source/graphicfilter/itiff/itiff.cxx
@@ -1156,7 +1156,7 @@ sal_Bool TIFFReader::ReadTIFF(SvStream rTIFF, Graphic
rGraphic )
pTIFF-ReadUInt16( nTagType ).ReadUInt16( nDataType
).ReadUInt32( nDataLen ).ReadUInt32( nOffset );
if( DataTypeSize() * nDataLen 4 )
-nMaxPos = std::max( nOrigPos + nOffset + DataTypeSize() *
nDataLen, nMaxPos );
+nMaxPos = std::max( (sal_uInt64) nOrigPos + nOffset +
DataTypeSize() * nDataLen, nMaxPos );
}
pTIFF-ReadUInt32( nOffset );
if ( pTIFF-IsEof() )
diff --git a/filter/source/msfilter/escherex.cxx
b/filter/source/msfilter/escherex.cxx
index c187811..ffe2cb7 100644
--- a/filter/source/msfilter/escherex.cxx
+++ b/filter/source/msfilter/escherex.cxx
@@ -5059,8 +5059,8 @@ class SvNullStream : public SvStream
protected:
virtual sal_Size GetData( void* pData, sal_Size nSize ) SAL_OVERRIDE {
memset( pData, 0, nSize ); return nSize; }
virtual sal_Size PutData( const void*, sal_Size nSize ) SAL_OVERRIDE {
return nSize; }
-virtual sal_Size SeekPos( sal_Size nPos ) SAL_OVERRIDE { return nPos; }
-virtual void SetSize( sal_Size ) SAL_OVERRIDE {}
+virtual sal_uInt64 SeekPos( sal_uInt64 nPos ) SAL_OVERRIDE { return nPos; }
+virtual void SetSize( sal_uInt64 ) SAL_OVERRIDE {}
virtual void FlushData() SAL_OVERRIDE {}
public:
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 9063bd0..63686e8 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -6443,7 +6443,7 @@ sal_Bool SvxMSDffManager::ProcessClientAnchor(SvStream
rStData, sal_uInt32 nDat
{
if( nDatLen )
{
-rBuffLen = std::min(rStData.remainingSize(),
static_castsal_Size(nDatLen));
+rBuffLen = std::min(rStData.remainingSize(),
static_castsal_uInt64(nDatLen));
rpBuff = new char[rBuffLen];
rBuffLen = rStData.Read(rpBuff, rBuffLen);
}
@@ -6455,7 +6455,7 @@ sal_Bool SvxMSDffManager::ProcessClientData(SvStream
rStData, sal_uInt32 nDatLe
{
if( nDatLen )
{
-rBuffLen = std::min(rStData.remainingSize(),
static_castsal_Size(nDatLen));
+rBuffLen = std::min(rStData.remainingSize(),
static_castsal_uInt64(nDatLen));
rpBuff = new char[rBuffLen];
rBuffLen = rStData.Read(rpBuff, rBuffLen);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Cppcheck reports Using 'memset' on class that contains ... (sw module)
Hello, Cppcheck reported this: sw/source/filter/ww8/ww8scan.cxx 5158memsetClass error Using 'memset' on class that contains a virtual method. 5158memsetClass error Using 'memset' on class that contains a reference. 5158memsetClass error Using 'memset' on class that contains a 'std::map'. See http://opengrok.libreoffice.org/xref/core/sw/source/filter/ww8/ww8scan.cxx#5155 False positive or real problem? Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Using-memset-on-class-that-contains-sw-module-tp4103435.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/filter/basflt/shellio.cxx | 21 +
1 file changed, 5 insertions(+), 16 deletions(-)
New commits:
commit 2ca930d66b56adcd1ae36b7de473a4598c24acb7
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 13:39:44 2014 +0100
Reader::ResetFrmFmts(): work around spurious MSVC warning C4701
Change-Id: I216888cb92d61a5b8c9252fe8c12c01a6fb9af8a
diff --git a/sw/source/filter/basflt/shellio.cxx
b/sw/source/filter/basflt/shellio.cxx
index 56eefcb..a0db1dd 100644
--- a/sw/source/filter/basflt/shellio.cxx
+++ b/sw/source/filter/basflt/shellio.cxx
@@ -617,23 +617,12 @@ void Reader::ResetFrmFmtAttrs( SfxItemSet rFrmSet )
void Reader::ResetFrmFmts( SwDoc rDoc )
{
-for (sal_uInt16 i=0; i3; ++i)
+sal_uInt16 const s_ids[3] = {
+RES_POOLFRM_FRAME, RES_POOLFRM_GRAPHIC, RES_POOLFRM_OLE
+};
+for (sal_uInt16 i = 0; i SAL_N_ELEMENTS(s_ids); ++i)
{
-sal_uInt16 nPoolId;
-switch (i)
-{
-case 0:
-nPoolId = RES_POOLFRM_FRAME;
-break;
-case 1:
-nPoolId = RES_POOLFRM_GRAPHIC;
-break;
-case 2:
-nPoolId = RES_POOLFRM_OLE;
-break;
-}
-
-SwFrmFmt *pFrmFmt = rDoc.GetFrmFmtFromPool( nPoolId );
+SwFrmFmt *const pFrmFmt = rDoc.GetFrmFmtFromPool( s_ids[i] );
pFrmFmt-ResetFmtAttr( RES_LR_SPACE );
pFrmFmt-ResetFmtAttr( RES_UL_SPACE );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Cppcheck reports Same expression on both sides of '' (sc module)
Hello, Cppcheck reported this: sc/source/core/opencl/op_statistical.cxx 3221duplicateExpression style Same expression on both sides of ''. 3233duplicateExpression style Same expression on both sides of ''. 3245duplicateExpression style Same expression on both sides of ''. 3305duplicateExpression style Same expression on both sides of ''. 3317duplicateExpression style Same expression on both sides of ''. eg: 3220 else if ((pDVR-IsStartFixed() !pDVR-IsEndFixed()) 3221 (pDVR-IsStartFixed() !pDVR-IsEndFixed())) (see http://opengrok.libreoffice.org/xref/core/sc/source/core/opencl/op_statistical.cxx#3220) Should the second line use pDVR1 (like some other parts), should the second line be removed each time, or something else should be done? Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-sc-module-tp4103436.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/excrecds.cxx | 14 +++---
sc/source/filter/excel/xestream.cxx |4 ++--
sc/source/filter/excel/xistream.cxx |2 +-
sc/source/filter/inc/excrecds.hxx|6 +++---
sc/source/filter/inc/xestream.hxx|6 +++---
sc/source/filter/inc/xistream.hxx|2 +-
sc/source/filter/xcl97/XclImpChangeTrack.cxx |2 +-
sc/source/filter/xcl97/xcl97rec.cxx |2 +-
8 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 8cc3ab84b97f2dc110f95476267e8f0a386c9466
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 14:29:36 2014 +0100
sc: adapt Excel filter to SvStream changes
STREAM_SEEK_TO_END is apparently used to initialize variables and signal
failure here, which is odd.
Change-Id: I324a85b441dc377757f7c32eec2ad8a2c9a8c2eb
diff --git a/sc/source/filter/excel/excrecds.cxx
b/sc/source/filter/excel/excrecds.cxx
index b7e6df7..5097c80 100644
--- a/sc/source/filter/excel/excrecds.cxx
+++ b/sc/source/filter/excel/excrecds.cxx
@@ -355,8 +355,8 @@ void Exc1904::SaveXml( XclExpXmlStream rStrm )
//-- class ExcBundlesheet -
ExcBundlesheetBase::ExcBundlesheetBase( RootData rRootData, SCTAB nTabNum ) :
-nStrPos( STREAM_SEEK_TO_END ),
-nOwnPos( STREAM_SEEK_TO_END ),
+m_nStrPos( STREAM_SEEK_TO_END ),
+m_nOwnPos( STREAM_SEEK_TO_END ),
nGrbit( rRootData.pER-GetTabInfo().IsVisibleTab( nTabNum ) ? 0x :
0x0001 ),
nTab( nTabNum )
{
@@ -364,8 +364,8 @@ ExcBundlesheetBase::ExcBundlesheetBase( RootData
rRootData, SCTAB nTabNum ) :
ExcBundlesheetBase::ExcBundlesheetBase() :
-nStrPos( STREAM_SEEK_TO_END ),
-nOwnPos( STREAM_SEEK_TO_END ),
+m_nStrPos( STREAM_SEEK_TO_END ),
+m_nOwnPos( STREAM_SEEK_TO_END ),
nGrbit( 0x ),
nTab( SCTAB_GLOBAL )
{
@@ -374,9 +374,9 @@ ExcBundlesheetBase::ExcBundlesheetBase() :
void ExcBundlesheetBase::UpdateStreamPos( XclExpStream rStrm )
{
-rStrm.SetSvStreamPos( nOwnPos );
+rStrm.SetSvStreamPos( m_nOwnPos );
rStrm.DisableEncryption();
-rStrm static_castsal_uInt32(nStrPos);
+rStrm static_castsal_uInt32(m_nStrPos);
rStrm.EnableEncryption();
}
@@ -400,7 +400,7 @@ ExcBundlesheet::ExcBundlesheet( RootData rRootData, SCTAB
_nTab ) :
void ExcBundlesheet::SaveCont( XclExpStream rStrm )
{
-nOwnPos = rStrm.GetSvStreamPos();
+m_nOwnPos = rStrm.GetSvStreamPos();
rStrm(sal_uInt32) 0x // dummy (stream position
of the sheet)
nGrbit;
rStrm.WriteByteString(aName); // 8 bit length, max 255 chars
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index 289fc62..fc511a0 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -376,7 +376,7 @@ void XclExpStream::DisableEncryption()
EnableEncryption(false);
}
-sal_Size XclExpStream::SetSvStreamPos( sal_Size nPos )
+sal_Size XclExpStream::SetSvStreamPos(sal_uInt64 const nPos)
{
OSL_ENSURE( !mbInRec, XclExpStream::SetSvStreamPos - not allowed inside
of a record );
return mbInRec ? 0 : mrStrm.Seek( nPos );
@@ -599,7 +599,7 @@ sal_uInt16 XclExpBiff8Encrypter::GetOffsetInBlock( sal_Size
nStrmPos ) const
void XclExpBiff8Encrypter::EncryptBytes( SvStream rStrm, vectorsal_uInt8
aBytes )
{
-sal_Size nStrmPos = rStrm.Tell();
+sal_uInt64 nStrmPos = rStrm.Tell();
sal_uInt16 nBlockOffset = GetOffsetInBlock(nStrmPos);
sal_uInt32 nBlockPos = GetBlockPos(nStrmPos);
diff --git a/sc/source/filter/excel/xistream.cxx
b/sc/source/filter/excel/xistream.cxx
index 75662a1..5f98314 100644
--- a/sc/source/filter/excel/xistream.cxx
+++ b/sc/source/filter/excel/xistream.cxx
@@ -79,7 +79,7 @@ void XclImpDecrypter::Update( SvStream rStrm, sal_uInt16
nRecSize )
{
if( IsValid() )
{
-sal_Size nNewPos = rStrm.Tell();
+sal_uInt64 const nNewPos = rStrm.Tell();
if( (mnOldPos != nNewPos) || (mnRecSize != nRecSize) )
{
OnUpdate( mnOldPos, nNewPos, nRecSize );
diff --git a/sc/source/filter/inc/excrecds.hxx
b/sc/source/filter/inc/excrecds.hxx
index 2f19679..22892b1 100644
--- a/sc/source/filter/inc/excrecds.hxx
+++ b/sc/source/filter/inc/excrecds.hxx
@@ -260,8 +260,8 @@ private:
class ExcBundlesheetBase : public ExcRecord
{
protected:
-sal_SizenStrPos;
-sal_SizenOwnPos;// Position NACH # und Len
+sal_uInt64 m_nStrPos;
+sal_uInt64 m_nOwnPos;// Position after # and Len
sal_uInt16 nGrbit;
SCTAB nTab;
@@ -270,7 +270,7 @@ protected:
public:
ExcBundlesheetBase( RootData rRootData, SCTAB
nTab );
-inline void SetStreamPos( sal_Size nNewStrPos ) { nStrPos =
nNewStrPos; }
+inline
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/filter/excel/xestream.cxx | 13 +++--
sc/source/filter/inc/xestream.hxx |2 +-
2 files changed, 4 insertions(+), 11 deletions(-)
New commits:
commit b03b1113d82147093762923bb9b350e52fe08ffe
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 14:58:45 2014 +0100
sc: actually CopyFromStream() can just use remainingSize()
Change-Id: I16e60caa7a1baeb2b05cbe5dc8ae24a67751c390
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index f44bedd..e741e09 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -280,12 +280,8 @@ void XclExpStream::WriteZeroBytesToRecord( sal_Size nBytes
)
void XclExpStream::CopyFromStream(SvStream rInStrm, sal_uInt64 const nBytes)
{
-sal_uInt64 const nStrmPos = rInStrm.Tell();
-rInStrm.Seek( STREAM_SEEK_TO_END );
-sal_uInt64 const nStrmSize = rInStrm.Tell();
-rInStrm.Seek( nStrmPos );
-
-sal_uInt64 nBytesLeft = ::std::min( nBytes, nStrmSize - nStrmPos );
+sal_uInt64 const nRemaining(rInStrm.remainingSize());
+sal_uInt64 nBytesLeft = ::std::min(nBytes, nRemaining);
if( nBytesLeft 0 )
{
const sal_Size nMaxBuffer = 4096;
commit fd76aa7ea8cf4d8e75c50f27a9fb57626198ba5f
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 14:55:09 2014 +0100
sc: adapt XclExpStream::CopyFromStream() to SvStream change
Change-Id: I58c183fe2b8e7b64ec0678e5eb136b9a467f1eb4
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index fc511a0..f44bedd 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -278,15 +278,14 @@ void XclExpStream::WriteZeroBytesToRecord( sal_Size
nBytes )
*this nZero;
}
-sal_Size XclExpStream::CopyFromStream( SvStream rInStrm, sal_Size nBytes )
+void XclExpStream::CopyFromStream(SvStream rInStrm, sal_uInt64 const nBytes)
{
-sal_Size nStrmPos = rInStrm.Tell();
+sal_uInt64 const nStrmPos = rInStrm.Tell();
rInStrm.Seek( STREAM_SEEK_TO_END );
-sal_Size nStrmSize = rInStrm.Tell();
+sal_uInt64 const nStrmSize = rInStrm.Tell();
rInStrm.Seek( nStrmPos );
-sal_Size nBytesLeft = ::std::min( nBytes, nStrmSize - nStrmPos );
-sal_Size nRet = 0;
+sal_uInt64 nBytesLeft = ::std::min( nBytes, nStrmSize - nStrmPos );
if( nBytesLeft 0 )
{
const sal_Size nMaxBuffer = 4096;
@@ -299,12 +298,10 @@ sal_Size XclExpStream::CopyFromStream( SvStream rInStrm,
sal_Size nBytes )
rInStrm.Read( pBuffer, nWriteLen );
sal_Size nWriteRet = Write( pBuffer, nWriteLen );
bValid = (nWriteLen == nWriteRet);
-nRet += nWriteRet;
nBytesLeft -= nWriteRet;
}
delete[] pBuffer;
}
-return nRet;
}
void XclExpStream::WriteUnicodeBuffer( const ScfUInt16Vec rBuffer, sal_uInt8
nFlags )
diff --git a/sc/source/filter/inc/xestream.hxx
b/sc/source/filter/inc/xestream.hxx
index 5971bc4..2d1d3ae 100644
--- a/sc/source/filter/inc/xestream.hxx
+++ b/sc/source/filter/inc/xestream.hxx
@@ -122,7 +122,7 @@ public:
/** Copies nBytes bytes from current position of the stream rInStrm.
@descr Omitting the second parameter means: read to end of stream. */
-sal_SizeCopyFromStream( SvStream rInStrm, sal_Size nBytes =
STREAM_SEEK_TO_END );
+voidCopyFromStream( SvStream rInStrm, sal_uInt64 nBytes =
STREAM_SEEK_TO_END );
// *** unicode string export is realized with helper class XclExpString ***
// (slice length setting has no effect here - disabled automatically)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xestream.cxx |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
New commits:
commit b18ae9085ccb101b757bd9926dd58012b327b6f9
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 15:11:42 2014 +0100
sc: more stream tweaks
Change-Id: I452ba76cec425e397369e0fcc689ba639d5325b0
diff --git a/sc/source/filter/excel/xestream.cxx
b/sc/source/filter/excel/xestream.cxx
index e741e09..e30a39a 100644
--- a/sc/source/filter/excel/xestream.cxx
+++ b/sc/source/filter/excel/xestream.cxx
@@ -285,12 +285,13 @@ void XclExpStream::CopyFromStream(SvStream rInStrm,
sal_uInt64 const nBytes)
if( nBytesLeft 0 )
{
const sal_Size nMaxBuffer = 4096;
-sal_uInt8* pBuffer = new sal_uInt8[ ::std::min( nBytesLeft, nMaxBuffer
) ];
+sal_uInt8 *const pBuffer =
+new sal_uInt8[ ::std::minsal_Size(nBytesLeft, nMaxBuffer) ];
bool bValid = true;
while( bValid (nBytesLeft 0) )
{
-sal_Size nWriteLen = ::std::min( nBytesLeft, nMaxBuffer );
+sal_Size nWriteLen = ::std::minsal_Size(nBytesLeft, nMaxBuffer);
rInStrm.Read( pBuffer, nWriteLen );
sal_Size nWriteRet = Write( pBuffer, nWriteLen );
bValid = (nWriteLen == nWriteRet);
@@ -369,7 +370,7 @@ void XclExpStream::DisableEncryption()
EnableEncryption(false);
}
-sal_Size XclExpStream::SetSvStreamPos(sal_uInt64 const nPos)
+sal_uInt64 XclExpStream::SetSvStreamPos(sal_uInt64 const nPos)
{
OSL_ENSURE( !mbInRec, XclExpStream::SetSvStreamPos - not allowed inside
of a record );
return mbInRec ? 0 : mrStrm.Seek( nPos );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 3d9920bfb805d8de561b397a032c8b55bbacd695
Author: Kohei Yoshida kohei.yosh...@collabora.com
Date: Sat Mar 29 10:32:37 2014 -0400
Add missing header.
Change-Id: I15f43e18bc20b8ddfd20b39bd4725519a2a8ae61
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx
b/chart2/source/view/charttypes/GL3DBarChart.cxx
index 62f189a..0249a65 100644
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -13,6 +13,8 @@
#include com/sun/star/chart2/data/XDataSequence.hpp
#include com/sun/star/chart2/data/LabelOrigin.hpp
+#include stdio.h
+
using namespace com::sun::star;
namespace chart {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - include/vcl unusedcode.easy
include/vcl/outdev.hxx |4 ++-- include/vcl/virdev.hxx |4 ++-- unusedcode.easy|4 3 files changed, 8 insertions(+), 4 deletions(-) New commits: commit 917e6eba1358deeb09eab4adcc2c7a979adbbe9c Author: Caolán McNamara caol...@redhat.com Date: Sat Mar 29 14:51:59 2014 + callcatcher: update unused code Change-Id: If3ef0f2134a15960fa1a14da0bec13cbd6019049 diff --git a/unusedcode.easy b/unusedcode.easy index e60422b..df93e10 100644 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -6,6 +6,8 @@ DocxSdrExport::getFlyFrameGraphic() DocxSdrExport::setFlyFrameGraphic(bool) DocxSdrExport::setFrameBtLr(bool) EditEngine::IsIdleFormatterActive() const +FillAttributes::FillAttributes() +FillAttributes::getFillGradientAttribute() const GDriveDocument::GDriveDocument(GDriveSession*) GDriveFolder::GDriveFolder(GDriveSession*) GDriveProperty::GDriveProperty() @@ -66,6 +68,8 @@ VCLXGraphics::getLineColor() VCLXGraphics::getRasterOp() VCLXGraphics::getTextColor() VCLXGraphics::getTextFillColor() +XFillStyleItem::XFillStyleItem(XFillStyle, unsigned short) +XGradient::VclGradient() const apitest::CellProperties::testRotateReference() apitest::CellProperties::testVertJustify() apitest::DataPilotField::testAutoShowInfo() commit e2294dbff8fa0969760b772e9536259c3367ae66 Author: Caolán McNamara caol...@redhat.com Date: Sat Mar 29 14:51:31 2014 + I realy think these should be virtual Change-Id: Ie95ab47d0252d21391e51116ca5e2c424fba1b59 diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 8f5fd38..363cdbf 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -1420,7 +1420,7 @@ public: sal_Int32* pKashidaPosDropped // invalid kashida positions (out) ) const; -sal_uInt16 GetBitCount() const; +virtual sal_uInt16 GetBitCount() const; boolGetTextIsRTL( const OUString, sal_Int32 nIndex, sal_Int32 nLen ) const; @@ -1429,7 +1429,7 @@ public: @return 0, if no alpha channel available, and the bit depth of the alpha channel otherwise. */ -sal_uInt16 GetAlphaBitCount() const; +virtual sal_uInt16 GetAlphaBitCount() const; sal_uLong GetColorCount() const; voidPush( sal_uInt16 nFlags = PUSH_ALL ); diff --git a/include/vcl/virdev.hxx b/include/vcl/virdev.hxx index 5b25b72..0436b5d 100644 --- a/include/vcl/virdev.hxx +++ b/include/vcl/virdev.hxx @@ -134,8 +134,8 @@ public: voidSetReferenceDevice( sal_Int32 i_nDPIX, sal_Int32 i_nDPIY ); -sal_uInt16 GetBitCount() const; -sal_uInt16 GetAlphaBitCount() const; +virtual sal_uInt16 GetBitCount() const SAL_OVERRIDE; +virtual sal_uInt16 GetAlphaBitCount() const SAL_OVERRIDE; private: SAL_DLLPRIVATE void ImplSetReferenceDevice( RefDevMode, sal_Int32 i_nDPIX, sal_Int32 i_nDPIY ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/wrtw8sty.cxx |2 +-
sw/source/filter/ww8/ww8atr.cxx |8
sw/source/filter/ww8/ww8par.hxx |4 ++--
sw/source/filter/ww8/ww8par4.cxx |2 +-
sw/source/filter/ww8/ww8par6.cxx |4 ++--
sw/source/filter/ww8/ww8scan.cxx |2 +-
6 files changed, 11 insertions(+), 11 deletions(-)
New commits:
commit aabbde06e849c61b9abb696cd84133f11ebfbf34
Author: Julien Nabet serval2...@yahoo.fr
Date: Sat Mar 29 17:20:35 2014 +0100
Typo: varient-variant
Change-Id: I0b62f630573dc76d90e3c1f659b2ac359758b243
diff --git a/sw/source/filter/ww8/wrtw8sty.cxx
b/sw/source/filter/ww8/wrtw8sty.cxx
index 271d118..d2dd257 100644
--- a/sw/source/filter/ww8/wrtw8sty.cxx
+++ b/sw/source/filter/ww8/wrtw8sty.cxx
@@ -481,7 +481,7 @@ void MSWordStyles::SetStyleDefaults( const SwFmt rFmt,
bool bPap )
{
//If we are a character property then see if it is one of the
//western/asian ones that must be collapsed together for export to
-//word. If so default to the western varient.
+//word. If so default to the western variant.
if ( bPap || m_rExport.CollapseScriptsforWordOk(
i18n::ScriptType::LATIN, n) )
{
diff --git a/sw/source/filter/ww8/ww8atr.cxx b/sw/source/filter/ww8/ww8atr.cxx
index e04820a..ea1592b 100644
--- a/sw/source/filter/ww8/ww8atr.cxx
+++ b/sw/source/filter/ww8/ww8atr.cxx
@@ -1080,7 +1080,7 @@ void WW8AttributeOutput::CharFont( const SvxFontItem
rFont )
void WW8AttributeOutput::CharFontCTL( const SvxFontItem rFont )
{
-//Can only export in 8+, in 7- export as normal varient and expect that
+//Can only export in 8+, in 7- export as normal variant and expect that
//upperlevel code has blocked exporting clobbering attributes
sal_uInt16 nFontID = m_rWW8Export.GetId( rFont );
if ( m_rWW8Export.bWrtWW8 )
@@ -1092,7 +1092,7 @@ void WW8AttributeOutput::CharFontCTL( const SvxFontItem
rFont )
void WW8AttributeOutput::CharFontCJK( const SvxFontItem rFont )
{
-//Can only export in 8+, in 7- export as normal varient and expect that
+//Can only export in 8+, in 7- export as normal variant and expect that
//upperlevel code has blocked exporting clobbering attributes
sal_uInt16 nFontID = m_rWW8Export.GetId( rFont );
if ( m_rWW8Export.bWrtWW8 )
@@ -1104,7 +1104,7 @@ void WW8AttributeOutput::CharFontCJK( const SvxFontItem
rFont )
void WW8AttributeOutput::CharWeightCTL( const SvxWeightItem rWeight )
{
-//Can only export in 8+, in 7- export as normal varient and expect that
+//Can only export in 8+, in 7- export as normal variant and expect that
//upperlevel code has blocked exporting clobbering attributes
if (m_rWW8Export.bWrtWW8)
{
@@ -1118,7 +1118,7 @@ void WW8AttributeOutput::CharWeightCTL( const
SvxWeightItem rWeight )
void WW8AttributeOutput::CharPostureCTL( const SvxPostureItem rPosture )
{
-// Can only export in 8+, in 7- export as normal varient and expect that
+// Can only export in 8+, in 7- export as normal variant and expect that
// upperlevel code has blocked exporting clobbering attributes
if (m_rWW8Export.bWrtWW8)
{
diff --git a/sw/source/filter/ww8/ww8par.hxx b/sw/source/filter/ww8/ww8par.hxx
index bc8ff13..bc41c27 100644
--- a/sw/source/filter/ww8/ww8par.hxx
+++ b/sw/source/filter/ww8/ww8par.hxx
@@ -959,8 +959,8 @@ struct ApoTestResults
struct ANLDRuleMap
{
-SwNumRule* mpOutlineNumRule;// WinWord 6 numbering, varient 1
-SwNumRule* mpNumberingNumRule; // WinWord 6 numbering, varient 2
+SwNumRule* mpOutlineNumRule;// WinWord 6 numbering, variant 1
+SwNumRule* mpNumberingNumRule; // WinWord 6 numbering, variant 2
SwNumRule* GetNumRule(sal_uInt8 nNumType);
void SetNumRule(SwNumRule*, sal_uInt8 nNumType);
ANLDRuleMap() : mpOutlineNumRule(0), mpNumberingNumRule(0) {}
diff --git a/sw/source/filter/ww8/ww8par4.cxx b/sw/source/filter/ww8/ww8par4.cxx
index 04e72c3..60a3c3f 100644
--- a/sw/source/filter/ww8/ww8par4.cxx
+++ b/sw/source/filter/ww8/ww8par4.cxx
@@ -484,7 +484,7 @@ void SwWW8ImplReader::Read_CRevisionMark(RedlineType_t
eType,
/*
It is possible to have a number of date stamps for the created time
of the change, (possibly a word bug) so we must use the get a full
- list varient of HasCharSprm and take the last one as the true one.
+ list variant of HasCharSprm and take the last one as the true one.
*/
std::vectorconst sal_uInt8 * aResult;
bool bIns = (nsRedlineType_t::REDLINE_INSERT == eType);
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index a51526d..465f043 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -3279,7 +3279,7 @@ void SwWW8ImplReader::Read_DoubleLine_Rotate( sal_uInt16,
const sal_uInt8* pData
void SwWW8ImplReader::Read_TxtColor( sal_uInt16, const
[Libreoffice-commits] core.git: basegfx/source sc/source
basegfx/source/range/b2drangeclipper.cxx |2 +-
sc/source/filter/excel/xichart.cxx |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 74c5452206bd729413beff4375f7249553fe6a60
Author: Julien Nabet serval2...@yahoo.fr
Date: Sat Mar 29 17:24:28 2014 +0100
Typo: ccordinate-coordinate
Change-Id: I2011dbed8f30b2b0d0568d5e19ed8e56bef509d9
diff --git a/basegfx/source/range/b2drangeclipper.cxx
b/basegfx/source/range/b2drangeclipper.cxx
index 33a81be..5d198fb 100644
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@@ -84,7 +84,7 @@ namespace basegfx
Rectangle this edge is part of
@param fInvariantCoord
-The invariant ccordinate value of this edge
+The invariant coordinate value of this edge
@param eEdgeType
Is fInvariantCoord the lower or the higher value, for
diff --git a/sc/source/filter/excel/xichart.cxx
b/sc/source/filter/excel/xichart.cxx
index 026f64d..b00c49c 100644
--- a/sc/source/filter/excel/xichart.cxx
+++ b/sc/source/filter/excel/xichart.cxx
@@ -3695,7 +3695,7 @@ Reference XCoordinateSystem
XclImpChAxesSet::CreateCoordSystem( Reference XD
{
Reference XCoordinateSystem xCoordSystem;
-/* Try to get existing ccordinate system. For now, all series from primary
+/* Try to get existing coordinate system. For now, all series from primary
and secondary axes sets are inserted into one coordinate system. Later,
this should be changed to use one coordinate system for each axes set.
*/
Reference XCoordinateSystemContainer xCoordSystemCont( xDiagram,
UNO_QUERY );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 34555] Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications
https://bugs.freedesktop.org/show_bug.cgi?id=34555 tommy27 ba...@quipo.it changed: What|Removed |Added CC||all_...@outlook.com --- Comment #39 from tommy27 ba...@quipo.it --- *** Bug 61991 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/chartapiwrapper/WrappedGL3DProperties.cxx | 12
+-
chart2/source/model/template/GL3DBarChartTypeTemplate.hxx |8
+++---
2 files changed, 11 insertions(+), 9 deletions(-)
New commits:
commit 692714b7da20f1545365724ebca5891727d96025
Author: Michael Stahl mst...@redhat.com
Date: Sat Mar 29 18:01:35 2014 +0100
chart2: loplugin:saloverride
Change-Id: I795c8337f3d5fcf3e39849204867f0d57f40c843
diff --git a/chart2/source/controller/chartapiwrapper/WrappedGL3DProperties.cxx
b/chart2/source/controller/chartapiwrapper/WrappedGL3DProperties.cxx
index a4beaf5..20e366c 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedGL3DProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedGL3DProperties.cxx
@@ -57,7 +57,8 @@ public:
virtual ~WrappedGL3DProperty() {}
virtual uno::Any getPropertyValue( const
uno::Referencebeans::XPropertySet /*xInnerPS*/ ) const
-throw (beans::UnknownPropertyException, lang::WrappedTargetException,
uno::RuntimeException)
+throw (beans::UnknownPropertyException, lang::WrappedTargetException,
+ uno::RuntimeException) SAL_OVERRIDE
{
uno::Referencechart2::XChartType xCT = getChartType();
if (!xCT.is())
@@ -77,7 +78,7 @@ public:
const uno::Any rOutValue, const uno::Referencebeans::XPropertySet
/*xInnerPS*/ ) const
throw (beans::UnknownPropertyException,
beans::PropertyVetoException,
lang::IllegalArgumentException,
lang::WrappedTargetException,
- uno::RuntimeException)
+ uno::RuntimeException) SAL_OVERRIDE
{
uno::Referencechart2::XChartType xCT = getChartType();
if (!xCT.is())
@@ -92,7 +93,7 @@ public:
}
virtual void setPropertyToDefault( const
uno::Referencebeans::XPropertyState /*xInnerPropState*/ ) const
-throw (beans::UnknownPropertyException, uno::RuntimeException)
+throw (beans::UnknownPropertyException, uno::RuntimeException)
SAL_OVERRIDE
{
uno::Referencechart2::XChartType xCT = getChartType();
if (!xCT.is())
@@ -107,13 +108,14 @@ public:
}
virtual uno::Any getPropertyDefault( const
uno::Referencebeans::XPropertyState /*xInnerPS*/ ) const
-throw (beans::UnknownPropertyException, lang::WrappedTargetException,
uno::RuntimeException)
+throw (beans::UnknownPropertyException, lang::WrappedTargetException,
+ uno::RuntimeException) SAL_OVERRIDE
{
return maDefault;
}
virtual beans::PropertyState getPropertyState( const
uno::Referencebeans::XPropertyState /*xInnerPS*/ ) const
-throw (beans::UnknownPropertyException,
uno::RuntimeException)
+throw (beans::UnknownPropertyException, uno::RuntimeException)
SAL_OVERRIDE
{
return beans::PropertyState_DIRECT_VALUE;
}
diff --git a/chart2/source/model/template/GL3DBarChartTypeTemplate.hxx
b/chart2/source/model/template/GL3DBarChartTypeTemplate.hxx
index 1651dec..50a21d7 100644
--- a/chart2/source/model/template/GL3DBarChartTypeTemplate.hxx
+++ b/chart2/source/model/template/GL3DBarChartTypeTemplate.hxx
@@ -41,7 +41,7 @@ public:
virtual sal_Bool SAL_CALL matchesTemplate(
const css::uno::Referencecss::chart2::XDiagram xDiagram,
sal_Bool bAdaptProperties )
-throw (css::uno::RuntimeException, std::exception);
+throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
virtual css::uno::Referencecss::chart2::XChartType SAL_CALL
getChartTypeForNewSeries( const
css::uno::Sequencecss::uno::Referencecss::chart2::XChartType
xOldChartTypes )
@@ -52,14 +52,14 @@ public:
// OPropertySet
virtual css::uno::Any GetDefaultValue( sal_Int32 nHandle ) const
-throw (css::beans::UnknownPropertyException);
+throw (css::beans::UnknownPropertyException) SAL_OVERRIDE;
-virtual cppu::IPropertyArrayHelper SAL_CALL getInfoHelper();
+virtual cppu::IPropertyArrayHelper SAL_CALL getInfoHelper() SAL_OVERRIDE;
// XPropertySet
virtual css::uno::Referencecss::beans::XPropertySetInfo SAL_CALL
getPropertySetInfo()
-throw (css::uno::RuntimeException, std::exception);
+throw (css::uno::RuntimeException, std::exception) SAL_OVERRIDE;
};
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 19 commits - cui/source scripting/source sc/source svl/source svtools/source svx/source sw/source vcl/generic
cui/source/customize/cfg.cxx | 49 ++-
sc/source/ui/inc/tabview.hxx |2
sc/source/ui/view/tabview.cxx | 145 -
sc/source/ui/view/tabview3.cxx | 10 -
scripting/source/stringresource/stringresource.cxx | 83 +---
svl/source/misc/strmadpt.cxx |3
svtools/source/brwbox/datwin.cxx | 17 --
svtools/source/brwbox/datwin.hxx |2
svx/source/dialog/svxbmpnumvalueset.cxx|3
svx/source/svdraw/svddrgmt.cxx | 39 -
svx/source/svdraw/svdedxv.cxx |2
svx/source/svdraw/svdmrkv1.cxx | 14 --
sw/source/core/docnode/section.cxx |7 -
sw/source/core/edit/edtox.cxx | 22 ---
sw/source/core/frmedt/tblsel.cxx |2
sw/source/core/uibase/docvw/edtwin2.cxx| 60
sw/source/core/uibase/shells/basesh.cxx|2
sw/source/core/uibase/shells/drwbassh.cxx |5
vcl/generic/print/common_gfx.cxx | 12 -
19 files changed, 140 insertions(+), 339 deletions(-)
New commits:
commit ca5eb633dd1f89d0a077aefa47fd049afe399192
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 17:55:09 2014 +
coverity#984152 Uninitialized pointer field
Change-Id: Ibc4837a5c0652edcf52c58883a490467e43e6eb8
diff --git a/svx/source/dialog/svxbmpnumvalueset.cxx
b/svx/source/dialog/svxbmpnumvalueset.cxx
index 161ca75..03a15234 100644
--- a/svx/source/dialog/svxbmpnumvalueset.cxx
+++ b/svx/source/dialog/svxbmpnumvalueset.cxx
@@ -391,6 +391,9 @@ void SvxNumValueSet::UserDraw( const UserDrawEvent rUDEvt
)
SvxNumValueSet::SvxNumValueSet(Window* pParent, WinBits nWinBits)
: ValueSet(pParent, nWinBits)
+, nPageType(0)
+, bHTMLMode(false)
+, pVDev(NULL)
{
}
commit 7cdbf12f20c51353d90010e06203407586284843
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 17:28:52 2014 +
coverity#982292 Logically dead code
Change-Id: I7862ffc1ba51b1083e7cd1fe428fd9a0e134bc38
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index cb0ae07..e65a4fb 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -2130,11 +2130,11 @@ void SvxConfigPage::MoveEntry( bool bMoveUp )
bool SvxConfigPage::MoveEntryData(
SvTreeListEntry* pSourceEntry, SvTreeListEntry* pTargetEntry )
{
-//modified by shizhoubo for issue53677
-if ( NULL == pSourceEntry || NULL == pTargetEntry )
- {
- return false;
- }
+//#i53677#
+if (NULL == pSourceEntry || NULL == pTargetEntry)
+{
+return false;
+}
// Grab the entries list for the currently selected menu
SvxEntries* pEntries = GetTopLevelSelection()-GetEntries();
@@ -2142,39 +2142,26 @@ bool SvxConfigPage::MoveEntryData(
SvxConfigEntry* pSourceData =
(SvxConfigEntry*) pSourceEntry-GetUserData();
-if ( pTargetEntry == NULL )
-{
-RemoveEntry( pEntries, pSourceData );
-pEntries-insert(
-pEntries-begin(), pSourceData );
+SvxConfigEntry* pTargetData =
+(SvxConfigEntry*) pTargetEntry-GetUserData();
-GetSaveInData()-SetModified( true );
-
-return true;
-}
-else
+if ( pSourceData != NULL pTargetData != NULL )
{
-SvxConfigEntry* pTargetData =
-(SvxConfigEntry*) pTargetEntry-GetUserData();
-
-if ( pSourceData != NULL pTargetData != NULL )
-{
-// remove the source entry from our list
-RemoveEntry( pEntries, pSourceData );
+// remove the source entry from our list
+RemoveEntry( pEntries, pSourceData );
-SvxEntries::iterator iter = pEntries-begin();
-SvxEntries::const_iterator end = pEntries-end();
+SvxEntries::iterator iter = pEntries-begin();
+SvxEntries::const_iterator end = pEntries-end();
-// advance the iterator to the position of the target entry
-while (*iter != pTargetData ++iter != end) ;
+// advance the iterator to the position of the target entry
+while (*iter != pTargetData ++iter != end) ;
-// insert the source entry at the position after the target
-pEntries-insert( ++iter, pSourceData );
+// insert the source entry at the position after the target
+pEntries-insert( ++iter, pSourceData );
-GetSaveInData()-SetModified( true );
+GetSaveInData()-SetModified( true );
-return true;
-}
+return true;
}
return false;
commit 28d202cdc471585a7c7fba366b6247a561c8a5f7
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 17:15:45 2014 +
coverity#735516 Logically dead code
Change-Id:
[Libreoffice-commits] core.git: 2 commits - cui/source writerfilter/source
cui/source/tabpages/tparea.cxx | 15
writerfilter/source/dmapper/genclass.xsl | 710 ---
2 files changed, 725 deletions(-)
New commits:
commit 0353a71eb008d9731bfe369244e8691934c323fe
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 19:27:23 2014 +0100
writerfilter: remove unused genclass.xsl
Change-Id: I4a76c13fb01e728613211ae3e4959f75a151ff33
diff --git a/writerfilter/source/dmapper/genclass.xsl
b/writerfilter/source/dmapper/genclass.xsl
deleted file mode 100644
index 994b35d..000
--- a/writerfilter/source/dmapper/genclass.xsl
+++ /dev/null
@@ -1,710 +0,0 @@
-?xml version=1.0 encoding=utf-8?
-!--
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
---
-xsl:stylesheet
-version=1.0
-xmlns:xsl=http://www.w3.org/1999/XSL/Transform;
-xmlns:rng=http://relaxng.org/ns/structure/1.0;
-xmlns:xalan=http://xml.apache.org/xalan;
-exclude-result-prefixes = xalan
-xml:indent=true
- xsl:output method=text version=1.0 encoding=UTF-8 indent=yes
omit-xml-declaration=no/
-
- xsl:template match=/
-xsl:for-each select=/model/class
- xsl:choose
- xsl:when test=$filetype='inc'
- xsl:call-template name=incfile/
- /xsl:when
- xsl:when test=$filetype='impl'
- xsl:call-template name=implfile/
- /xsl:when
- /xsl:choose
-/xsl:for-each
- /xsl:template
-
- xsl:template name=license
-xsl:text/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */#xa;/xsl:text
- /xsl:template
-
- xsl:template name=memberid
-xsl:variable name=member
- xsl:choose
- xsl:when test=@member
- xsl:value-of select=@member/
- /xsl:when
- xsl:otherwise
- xsl:value-of select=@name/
- /xsl:otherwise
- /xsl:choose
-/xsl:variable
-xsl:for-each select=ancestor::class/member[@name=$member]
- xsl:choose
- xsl:when test=@type='bool'
- xsl:textm_b/xsl:text
- /xsl:when
- xsl:when test=@type='OUString'
- xsl:textm_s/xsl:text
- /xsl:when
- xsl:when test=@type='sal_uInt32'
- xsl:textm_n/xsl:text
- /xsl:when
- xsl:otherwise
- xsl:textm_/xsl:text
- /xsl:otherwise
- /xsl:choose
-/xsl:for-each
-xsl:call-template name=capfirst
- xsl:with-param name=string select=$member/
-/xsl:call-template
- /xsl:template
-
- xsl:template name=incfile
-xsl:call-template name=license/
-xsl:for-each select=//class
- xsl:variable name=includeguard
- xsl:textINCLUDED_/xsl:text
- xsl:value-of select=@name/
- xsl:text_HXX/xsl:text
- /xsl:variable
- xsl:text#ifndef /xsl:text
- xsl:value-of select=$includeguard/
- xsl:text#xa;#define /xsl:text
- xsl:value-of select=$includeguard/
- xsl:text#xa;#include
lt;resourcemodel/WW8ResourceModel.hxx/xsl:text
- xsl:text#xa;#include lt;rtl/ustring.hxx/xsl:text
- xsl:text#xa;namespace writerfilter {/xsl:text
- xsl:text#xa;namespace dmapper {/xsl:text
- xsl:call-template name=classdecl/
- xsl:text#xa;}}/xsl:text
- xsl:text#xa;#endif ///xsl:text
- xsl:value-of select=$includeguard/
- xsl:text#xa;/xsl:text
-/xsl:for-each
- /xsl:template
-
- xsl:template name=implfile
-xsl:call-template name=license/
-xsl:for-each select=//class
- xsl:text#include /xsl:text
- xsl:value-of
[Libreoffice-commits] core.git: editeng/source
editeng/source/editeng/impedit2.cxx |7 +++
editeng/source/editeng/impedit3.cxx | 26 +-
editeng/source/outliner/outliner.cxx |9 -
editeng/source/uno/unonrule.cxx |6 +++---
4 files changed, 23 insertions(+), 25 deletions(-)
New commits:
commit 95c45ef7b853bc00ae1734c8271c862dc0665b24
Author: Takeshi Abe t...@fixedpoint.jp
Date: Sun Mar 30 03:38:11 2014 +0900
Avoid possible resource leaks by boost::scoped_array
Change-Id: Iffc9d1ca971610bad9b3dd2bd9a6cd00f02ff39b
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index c0d432e..1852880 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -62,7 +62,7 @@
#include sot/formats.hxx
#include unicode/ubidi.h
-
+#include boost/scoped_array.hpp
#include boost/scoped_ptr.hpp
#include algorithm
@@ -546,7 +546,7 @@ void ImpEditEngine::Command( const CommandEvent rCEvt,
EditView* pView )
const EditLine* pLine = pParaPortion-GetLines()[nLine];
if ( pLine )
{
-Rectangle* aRects = new Rectangle[ mpIMEInfos-nLen ];
+boost::scoped_arrayRectangle aRects(new Rectangle[
mpIMEInfos-nLen ]);
for (sal_Int32 i = 0; i mpIMEInfos-nLen; ++i)
{
sal_Int32 nInputPos = mpIMEInfos-aPos.GetIndex() + i;
@@ -555,8 +555,7 @@ void ImpEditEngine::Command( const CommandEvent rCEvt,
EditView* pView )
Rectangle aR2 = GetEditCursor( pParaPortion, nInputPos );
aRects[ i ] = pView-GetImpEditView()-GetWindowPos( aR2 );
}
-pView-GetWindow()-SetCompositionCharRect( aRects,
mpIMEInfos-nLen );
-delete[] aRects;
+pView-GetWindow()-SetCompositionCharRect( aRects.get(),
mpIMEInfos-nLen );
}
}
}
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index c095ba2..5c91829 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -72,6 +72,7 @@
#include comphelper/processfactory.hxx
#include rtl/ustrbuf.hxx
#include comphelper/string.hxx
+#include boost/scoped_array.hpp
using namespace ::com::sun::star;
using namespace ::com::sun::star::uno;
@@ -732,7 +733,7 @@ sal_Bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
SvxFont aTmpFont( pNode-GetCharAttribs().GetDefFont() );
sal_Bool bCalcCharPositions = sal_True;
-sal_Int32* pBuf = new sal_Int32[ pNode-Len() ];
+boost::scoped_arraysal_Int32 pBuf(new sal_Int32[ pNode-Len() ]);
sal_Bool bSameLineAgain = sal_False;// For TextRanger, if the height
changes.
TabInfo aCurrentTab;
@@ -1056,7 +1057,7 @@ sal_Bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
if ( bCalcCharPositions || !pPortion-HasValidSize() )
{
-pPortion-GetSize() = aTmpFont.QuickGetTextSize(
GetRefDevice(), pParaPortion-GetNode()-GetString(), nTmpPos,
pPortion-GetLen(), pBuf );
+pPortion-GetSize() = aTmpFont.QuickGetTextSize(
GetRefDevice(), pParaPortion-GetNode()-GetString(), nTmpPos,
pPortion-GetLen(), pBuf.get() );
// #i9050# Do Kerning also behind portions...
if ( ( aTmpFont.GetFixKerning() 0 ) ( ( nTmpPos +
pPortion-GetLen() ) pNode-Len() ) )
@@ -1071,7 +1072,7 @@ sal_Bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
// = Always simply quick inserts.
size_t nPos = nTmpPos - pLine-GetStart();
EditLine::CharPosArrayType rArray =
pLine-GetCharPosArray();
-rArray.insert(rArray.begin()+nPos, pBuf, pBuf+nLen);
+rArray.insert(rArray.begin()+nPos, pBuf.get(),
pBuf.get()+nLen);
}
// And now check for Compression:
@@ -1560,7 +1561,7 @@ sal_Bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
if ( bLineBreak )
CreateAndInsertEmptyLine( pParaPortion, nStartPosY );
-delete[] pBuf;
+pBuf.reset();
sal_Bool bHeightChanged = FinishCreateLines( pParaPortion );
@@ -3029,7 +3030,7 @@ void ImpEditEngine::Paint( OutputDevice* pOutDev,
Rectangle aClipRect, Point aSt
sal_Int32 nTextStart = 0;
sal_Int32 nTextLen = 0;
const sal_Int32* pDXArray = 0;
-sal_Int32* pTmpDXArray = 0;
+boost::scoped_arraysal_Int32 pTmpDXArray;
if ( pTextPortion-GetKind() ==
PORTIONKIND_TEXT )
{
@@ -3173,11 +3174,11 @@ void ImpEditEngine::Paint( OutputDevice* pOutDev,
Rectangle aClipRect, Point aSt
[Libreoffice-commits] core.git: 2 commits - writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
New commits:
commit 10c03d7670c1c99e5c9828aa7162088bc4b3e374
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 20:05:00 2014 +0100
coverity#1194902 Unchecked dynamic_cast
Change-Id: I7a7c8d365e9f90096c98120e448a5571ca5e54a5
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index b0e2b3b..ecc7be2 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1261,7 +1261,8 @@ void DomainMapper::sprmWithProps( Sprm rSprm,
PropertyMapPtr rContext )
{
StyleSheetPropertyMap* pStyleSheetPropertyMap = dynamic_cast
StyleSheetPropertyMap* ( rContext.get() );
-pStyleSheetPropertyMap-SetOutlineLevel( nLvl );
+if (pStyleSheetPropertyMap)
+pStyleSheetPropertyMap-SetOutlineLevel( nLvl );
}
else
{
commit 756a220c13c3af17ea6c3cc95b028928bc3dc8a6
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 20:04:07 2014 +0100
coverity#1194901 Unchecked dynamic_cast
Change-Id: I63f91359f4232c5897de77905b3375e9c2f30d2e
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index f36db65..b0e2b3b 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -1785,7 +1785,8 @@ void DomainMapper::sprmWithProps( Sprm rSprm,
PropertyMapPtr rContext )
if( pContext.get() )
{
ParagraphPropertyMap* pParaContext = dynamic_cast
ParagraphPropertyMap* ( pContext.get() );
-pParaContext-SetFrameMode();
+if (pParaContext)
+pParaContext-SetFrameMode();
}
else
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - writerfilter/source
writerfilter/source/dmapper/DomainMapper.cxx |3 ++-
writerfilter/source/dmapper/DomainMapper_Impl.cxx |6 --
2 files changed, 6 insertions(+), 3 deletions(-)
New commits:
commit 9361d5a2dd9615e053b308e358afb8b36b843e71
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 20:56:15 2014 +0100
coverity#736003 Unchecked dynamic_cast
Change-Id: Ie7451b1c96437df444198152230190d07689c1f1
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index c86a6ac..0df4a54 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -4362,7 +4362,9 @@ uno::Referencecontainer::XIndexAccess
DomainMapper_Impl::GetCurrentNumberingRu
const StyleSheetEntryPtr pEntry =
GetStyleSheetTable()-FindStyleSheetByISTD(aStyle);
if (!pEntry)
return xRet;
-const StyleSheetPropertyMap* pStyleSheetProperties =
dynamic_castconst StyleSheetPropertyMap*(pEntry ? pEntry-pProperties.get() :
0);
+const StyleSheetPropertyMap* pStyleSheetProperties =
dynamic_castconst StyleSheetPropertyMap*(pEntry-pProperties.get());
+if (!pStyleSheetProperties)
+return xRet;
sal_Int32 nListId = pStyleSheetProperties-GetListId();
if (nListId 0)
return xRet;
commit 68184cf69655036b9ab0bfcda86ff91dc1277d1b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 20:54:30 2014 +0100
coverity#705068 Unchecked dynamic_cast
Change-Id: I3573618670d5975d02ec67e3314d734be05fcbe5
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 79c1847..c86a6ac 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -390,7 +390,7 @@ voidDomainMapper_Impl::PushProperties(ContextType eId)
if (!m_aTextAppendStack.empty())
{
uno::Reference text::XTextAppend xTextAppend =
m_aTextAppendStack.top().xTextAppend;
-if (xTextAppend.is())
+if (xTextAppend.is() pSectionContext_)
pSectionContext_-SetStart( xTextAppend-getEnd() );
}
}
commit c24ecb116fd4c89918213e61aab1d6db2c5bb05e
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 20:51:47 2014 +0100
coverity#736001 Unchecked dynamic_cast
Change-Id: I39622eb9c0d5f91c910b9c828beead2d1763af0e
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx
b/writerfilter/source/dmapper/DomainMapper.cxx
index ecc7be2..f48e654 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -704,7 +704,8 @@ void DomainMapper::lcl_attribute(Id nName, Value val)
if( pContext.get() )
{
ParagraphPropertyMap* pParaContext =
dynamic_cast ParagraphPropertyMap* ( pContext.get() );
-pParaContext-SetFrameMode(false);
+if (pParaContext)
+pParaContext-SetFrameMode(false);
}
nIntValue = text::VertOrientation::NONE;
break;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 50672] Unity: Recent file menu removes underscore from file names
https://bugs.freedesktop.org/show_bug.cgi?id=50672 --- Comment #23 from Björn Michaelsen bjoern.michael...@canonical.com --- (In reply to comment #21) You're welcome. I didn't plan this, but now it has happened :) Hi Samuel, thank you very much for this fix, it was always on my agenda, but with such a low prio that I unfortunately never got to it. Ill make sure it'll be in Ubuntu Trusty on release. Best, Bjoern -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 4 commits - writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 ++
writerfilter/source/dmapper/StyleSheetTable.cxx|9 ++---
writerfilter/source/dmapper/TablePropertiesHandler.cxx |2 +-
3 files changed, 9 insertions(+), 4 deletions(-)
New commits:
commit 8736c5222a8e83a1310713a92492e63198749467
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:13:21 2014 +0100
coverity#1194911 Unchecked dynamic_cast
Change-Id: I1e7f4bcd8f54219d86ad7a003469d5a486090f47
diff --git a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
index ed9..e5e4172 100644
--- a/writerfilter/source/dmapper/TablePropertiesHandler.cxx
+++ b/writerfilter/source/dmapper/TablePropertiesHandler.cxx
@@ -98,7 +98,7 @@ namespace dmapper {
DomainMapperTableManager* pManager =
dynamic_castDomainMapperTableManager*(m_pTableManager);
// In case any of the cells has the btLr cell direction,
then an explicit minimal size will just hide the whole row, don't do that.
-if (pMeasureHandler-GetRowHeightSizeType() !=
text::SizeType::MIN || !pManager-HasBtlrCell())
+if (pMeasureHandler-GetRowHeightSizeType() !=
text::SizeType::MIN || !pManager || !pManager-HasBtlrCell())
{
// In case a cell already wanted fixed size, we should
not overwrite it here.
if (!pManager || !pManager-IsRowSizeTypeInserted())
commit f19318697c9b15a464285d5dec2a8f923e955f24
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:09:09 2014 +0100
coverity#705071 Unchecked dynamic_cast
Change-Id: Ic7b120daf4d5456ed882ffa3724c53d1246e7b4d
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index ef56822..955fc3e 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -675,7 +675,8 @@ void StyleSheetTable::lcl_sprm(Sprm rSprm)
uno::makeAny( ConversionHelper::convertTableJustification(
nIntValue )));
break;
case NS_ooxml::LN_CT_TrPrBase_jc: //table alignment - row
properties!
-dynamic_cast StyleSheetPropertyMap* (
m_pImpl-m_pCurrentEntry-pProperties.get() )-SetCT_TrPrBase_jc(nIntValue);
+if (StyleSheetPropertyMap* pMap = dynamic_cast
StyleSheetPropertyMap* ( m_pImpl-m_pCurrentEntry-pProperties.get() ))
+pMap-SetCT_TrPrBase_jc(nIntValue);
break;
case NS_ooxml::LN_CT_TblPrBase_tblBorders: //table borders, might be
defined in table style
{
commit e50a0b6b1fd84694db1768a768570cdb8c614513
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:06:38 2014 +0100
coverity#705070 Unchecked dynamic_cast
Change-Id: Ibb4cf1e8bd002d4c36030f5567e1a16f86ea1668
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 42dd33e..ef56822 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -465,10 +465,12 @@ void StyleSheetTable::lcl_attribute(Id Name, Value val)
}
break;
case NS_ooxml::LN_CT_TblWidth_w:
-dynamic_cast StyleSheetPropertyMap* (
m_pImpl-m_pCurrentEntry-pProperties.get() )-SetCT_TblWidth_w( nIntValue );
+if (StyleSheetPropertyMap* pMap = dynamic_cast
StyleSheetPropertyMap* ( m_pImpl-m_pCurrentEntry-pProperties.get() ))
+pMap-SetCT_TblWidth_w( nIntValue );
break;
case NS_ooxml::LN_CT_TblWidth_type:
-dynamic_cast StyleSheetPropertyMap* (
m_pImpl-m_pCurrentEntry-pProperties.get() )-SetCT_TblWidth_type( nIntValue );
+if (StyleSheetPropertyMap* pMap = dynamic_cast
StyleSheetPropertyMap* ( m_pImpl-m_pCurrentEntry-pProperties.get() ))
+pMap-SetCT_TblWidth_type( nIntValue );
break;
case NS_ooxml::LN_CT_LatentStyles_defQFormat:
m_pImpl-AppendLatentStyleProperty(defQFormat, val);
commit e9509e54b45fc429a93975917dca2ec343e5f48d
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:04:27 2014 +0100
coverity#736004 Unchecked dynamic_cast
Change-Id: Icca4946543409adb0ac6f7bf78915f8ef5b0fa40
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 0df4a54..2177596 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -746,6 +746,8 @@ void DomainMapper_Impl::CheckUnregisteredFrameConversion( )
pFrameProperties[15].Name =
rPropNameSupplier.GetName(PROP_BACK_COLOR_TRANSPARENCY);
const ParagraphProperties* pStyleProperties =
dynamic_castconst ParagraphProperties*(
[Libreoffice-commits] core.git: 4 commits - writerfilter/source
writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |2 ++
writerfilter/source/ooxml/OOXMLStreamImpl.cxx | 14 --
writerfilter/source/rtftok/rtfdocumentimpl.cxx|3 ++-
3 files changed, 12 insertions(+), 7 deletions(-)
New commits:
commit 6812606517e9a6299fcd5fde59fd4cf414d0d493
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:41:52 2014 +0100
coverity#736006 Unchecked dynamic_cast
Change-Id: Id4b0f5e6e4369a850bc159992540e024a4c37c3c
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index 776f1de..cf7b0d6 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -4633,7 +4633,8 @@ int RTFDocumentImpl::popState()
// to RTLD_GLOBAL, so most probably a gcc bug.
oox::FormulaImportBase* pImport =
dynamic_castoox::FormulaImportBase*(dynamic_castSfxBaseModel*(xComponent.get()));
assert( pImport != NULL );
-pImport-readFormulaOoxml(m_aMathBuffer);
+if (pImport)
+pImport-readFormulaOoxml(m_aMathBuffer);
RTFValue::Pointer_t pValue(new RTFValue(xObject));
RTFSprms aMathAttributes;
aMathAttributes.set(NS_ooxml::LN_starmath, pValue);
commit b4107c79fb680c1906a7a4978c0c2eb5c118a41c
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:39:54 2014 +0100
coverity#705083 Unchecked dynamic_cast
Change-Id: I58e7be8d7b78ba83356e169290c289f246e93057
diff --git a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
index c66178f..494011f 100644
--- a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
@@ -455,9 +455,10 @@ OOXMLStream::Pointer_t
OOXMLDocumentFactory::createStream
(OOXMLStream::Pointer_t pStream, const OUString rId)
{
-return OOXMLStream::Pointer_t
-(new OOXMLStreamImpl(*dynamic_castOOXMLStreamImpl *(pStream.get()),
- rId));
+OOXMLStream::Pointer_t pRet;
+if (OOXMLStreamImpl* pImpl = dynamic_castOOXMLStreamImpl
*(pStream.get()))
+pRet.reset(new OOXMLStreamImpl(*pImpl, rId));
+return pRet;
}
}}
commit 7030c700bfeab64a65947d52daa24b5ffefb81ae
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:38:11 2014 +0100
coverity#705082 Unchecked dynamic_cast
Change-Id: Ic4665f2cbd2bfc4b65a0f3d9d746e344d4f3bef8
diff --git a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
index 284d369..c66178f 100644
--- a/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
+++ b/writerfilter/source/ooxml/OOXMLStreamImpl.cxx
@@ -445,9 +445,10 @@ OOXMLStream::Pointer_t
OOXMLDocumentFactory::createStream
(OOXMLStream::Pointer_t pStream, OOXMLStream::StreamType_t nStreamType)
{
-return OOXMLStream::Pointer_t
-(new OOXMLStreamImpl(*dynamic_castOOXMLStreamImpl *(pStream.get()),
- nStreamType));
+OOXMLStream::Pointer_t pRet;
+if (OOXMLStreamImpl* pImpl = dynamic_castOOXMLStreamImpl
*(pStream.get()))
+pRet.reset(new OOXMLStreamImpl(*pImpl, nStreamType));
+return pRet;
}
OOXMLStream::Pointer_t
commit 8d5efb49c37c4e78ef233570e0ead9fedc32d80e
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Sat Mar 29 21:34:10 2014 +0100
coverity#736005 Unchecked dynamic_cast
Change-Id: Ieca4f06f3ca4fecb8a0e87e7528f8583a549013c
diff --git a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
index 14e0c3c..4f73da5 100644
--- a/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
+++ b/writerfilter/source/ooxml/OOXMLFastContextHandler.cxx
@@ -2570,6 +2570,8 @@ void OOXMLFastContextHandlerMath::process()
// to RTLD_GLOBAL, so most probably a gcc bug.
oox::FormulaImportBase* import = dynamic_cast oox::FormulaImportBase* (
dynamic_cast SfxBaseModel* (component.get()));
assert( import != NULL );
+if (!import)
+return;
import-readFormulaOoxml( buffer );
if (isForwardEvents())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - sd/source svx/source
sd/source/core/PageListWatcher.cxx|2 +-
svx/source/customshapes/EnhancedCustomShapeEngine.cxx |2 +-
svx/source/svdraw/svdedtv2.cxx|2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit b3530c2c3eadeaed8637fbd22f6df1fdf2416850
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 20:56:08 2014 +
coverity#1194891 Copy-paste error
Change-Id: I79c5587725850fc14a54f827b931959fbadaf566
diff --git a/sd/source/core/PageListWatcher.cxx
b/sd/source/core/PageListWatcher.cxx
index ed73841..5c2bc12 100644
--- a/sd/source/core/PageListWatcher.cxx
+++ b/sd/source/core/PageListWatcher.cxx
@@ -109,7 +109,7 @@ SdPage* ImpPageListWatcher::GetSdPage(PageKind ePgKind,
sal_uInt32 nPgNum)
else
{
SAL_WARN( sd.core,
- ImpPageListWatcher::GetSdPage(PK_NOTES): page
number nPgNum = maPageVectorStandard.size() );
+ ImpPageListWatcher::GetSdPage(PK_NOTES): page
number nPgNum = maPageVectorNotes.size() );
}
break;
}
commit 62979b4cdf2153c38cf581a4e55eec70300abce2
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 20:54:50 2014 +
coverity#1194928 allocation too small for type
Change-Id: I4d1a3838ef95906b69bf52ba0d04c56859201db8
diff --git a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
index fe25d8d..da3c5df 100644
--- a/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
+++ b/svx/source/customshapes/EnhancedCustomShapeEngine.cxx
@@ -194,7 +194,7 @@ SdrObject*
EnhancedCustomShapeEngine::ImplForceGroupWithText( const SdrObjCustom
if ( bHasText )
{
// #i37011# also create a text object and add at rPos + 1
-SdrTextObj* pTextObj = (SdrTextObj*)SdrObjFactory::MakeNewObject(
+SdrObject* pTextObj = SdrObjFactory::MakeNewObject(
pCustoObj-GetObjInventor(), OBJ_TEXT, 0L,
pCustoObj-GetModel());
// Copy text content
commit 3d2d60960e8a8d5bc8a90199fe90d64ca798f55c
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 20:54:07 2014 +
coverity#1194927 allocation too small for type
Change-Id: I6ddf12cee4ea6d170c791a79014bb8400ab7d779
diff --git a/svx/source/svdraw/svdedtv2.cxx b/svx/source/svdraw/svdedtv2.cxx
index 2c755b0..c82e4e6 100644
--- a/svx/source/svdraw/svdedtv2.cxx
+++ b/svx/source/svdraw/svdedtv2.cxx
@@ -1556,7 +1556,7 @@ void SdrEditView::ImpDismantleOneObject(const SdrObject*
pObj, SdrObjList rOL,
if(pCustomShape-HasText() !pCustomShape-IsTextPath())
{
// #i37011# also create a text object and add at rPos + 1
-SdrTextObj* pTextObj =
(SdrTextObj*)SdrObjFactory::MakeNewObject(
+SdrObject* pTextObj = SdrObjFactory::MakeNewObject(
pCustomShape-GetObjInventor(), OBJ_TEXT, 0L,
pCustomShape-GetModel());
// Copy text content
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 6 commits - oox/source sc/source sd/source sw/source
oox/source/drawingml/textbodyproperties.cxx |5 +++--
sc/source/ui/dbgui/pfiltdlg.cxx |6 +++---
sd/source/core/stlfamily.cxx|4
sd/source/ui/dlg/gluectrl.cxx |2 +-
sd/source/ui/remotecontrol/DiscoveryService.cxx | 16 ++--
sw/source/core/layout/flowfrm.cxx |7 ---
6 files changed, 21 insertions(+), 19 deletions(-)
New commits:
commit f754176e0fe5a4780694450f65810466e0f4bd99
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 21:13:34 2014 +
coverity#1194898 Logically dead code
Change-Id: Iceef129ed11ab4551008eedf765ec0fe5a72c09a
diff --git a/sd/source/core/stlfamily.cxx b/sd/source/core/stlfamily.cxx
index e75c9f1..d59d6c1 100644
--- a/sd/source/core/stlfamily.cxx
+++ b/sd/source/core/stlfamily.cxx
@@ -83,10 +83,6 @@ PresStyleMap SdStyleFamilyImpl::getStyleSheets()
{
// we assume that we have only SdStyleSheets
SdStyleSheet* pSdStyle = static_cast SdStyleSheet* ( pStyle
);
-if (!pSdStyle)
-{
-continue;
-}
if (pSdStyle-GetName().startsWith(aLayoutName))
{
maStyleSheets[ pSdStyle-GetApiName() ] = rtl::Reference
SdStyleSheet ( pSdStyle );
commit 77e662100c5f84752fd26fbfb24f4dd458d2e66f
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 21:09:32 2014 +
coverity#1194941 Uninitialized scalar field
Change-Id: Ieedd977bc45136f087639b8d785fd75335b49087
diff --git a/sd/source/ui/remotecontrol/DiscoveryService.cxx
b/sd/source/ui/remotecontrol/DiscoveryService.cxx
index 42563ed..d37dc3b 100644
--- a/sd/source/ui/remotecontrol/DiscoveryService.cxx
+++ b/sd/source/ui/remotecontrol/DiscoveryService.cxx
@@ -55,17 +55,21 @@ using namespace rtl;
using namespace sd;
DiscoveryService::DiscoveryService()
-: zService( 0 )
+: mSocket(-1)
+, zService(0)
{
}
DiscoveryService::~DiscoveryService()
{
- #ifdef WNT
-closesocket( mSocket );
- #else
-close( mSocket );
- #endif
+if (mSocket != -1)
+{
+#ifdef WNT
+closesocket( mSocket );
+#else
+close( mSocket );
+#endif
+}
if (zService)
zService-clear();
commit dbd6bb6a62ec9740fd008c9ec1f7dceca74db953
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 21:07:08 2014 +
coverity#1194942 Uninitialized scalar field
Change-Id: I21733cb3fc0dd32a39826b0eaa7b2064d50a9c90
diff --git a/oox/source/drawingml/textbodyproperties.cxx
b/oox/source/drawingml/textbodyproperties.cxx
index 73fb9fb..850092c 100644
--- a/oox/source/drawingml/textbodyproperties.cxx
+++ b/oox/source/drawingml/textbodyproperties.cxx
@@ -31,8 +31,9 @@ namespace drawingml {
-TextBodyProperties::TextBodyProperties():
-meVA( TextVerticalAdjust_TOP )
+TextBodyProperties::TextBodyProperties()
+: mbAnchorCtr(false)
+, meVA( TextVerticalAdjust_TOP )
{
}
commit 99780fcf66f12df6be6f8c1bd636e5e44f1918b2
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 21:03:47 2014 +
coverity#1194920 Overflowed array index read
Change-Id: I2f5dc0c4cd56e8304ef3dcd83221a1428fdda194
diff --git a/sd/source/ui/dlg/gluectrl.cxx b/sd/source/ui/dlg/gluectrl.cxx
index a4ed47d..da5fe9a 100644
--- a/sd/source/ui/dlg/gluectrl.cxx
+++ b/sd/source/ui/dlg/gluectrl.cxx
@@ -80,7 +80,7 @@ GlueEscDirLB::~GlueEscDirLB()
*/
void GlueEscDirLB::Select()
{
-sal_uInt16 nPos = GetSelectEntryPos();
+sal_Int32 nPos = GetSelectEntryPos();
SfxUInt16Item aItem( SID_GLUE_ESCDIR, aEscDirArray[ nPos ] );
if ( m_xFrame.is() )
commit c08baae30c62d8bac45c8d49dd556ed1b770889c
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 21:03:04 2014 +
coverity#1194918 Overflowed array index read
Change-Id: Ic9cec3fc6749672b30bb1e0c96159897e50a84e5
diff --git a/sc/source/ui/dbgui/pfiltdlg.cxx b/sc/source/ui/dbgui/pfiltdlg.cxx
index 752bc46..43d9e871 100644
--- a/sc/source/ui/dbgui/pfiltdlg.cxx
+++ b/sc/source/ui/dbgui/pfiltdlg.cxx
@@ -284,9 +284,9 @@ void ScPivotFilterDlg::UpdateValueList( sal_uInt16 nList )
if ( pDoc nList0 nList=3 )
{
ComboBox* pValList= aValueEdArr[nList-1];
-sal_uInt16 nFieldSelPos=
aFieldLbArr[nList-1]-GetSelectEntryPos();
-sal_uInt16 nListPos= 0;
-OUString aCurValue = pValList-GetText();
+sal_Int32 nFieldSelPos=
aFieldLbArr[nList-1]-GetSelectEntryPos();
+sal_Int32 nListPos= 0;
+OUStringaCurValue = pValList-GetText();
pValList-Clear();
pValList-InsertEntry( aStrNotEmpty, 0 );
commit 1ee6577a0eae3d189d11233bccf90d11e48d771d
Author: Caolán McNamara caol...@redhat.com
Date: Sat Mar 29 20:58:57 2014 +
coverity#704900 Dereference after null check
[Libreoffice-commits] core.git: cui/source cui/uiconfig
cui/source/inc/cuitabline.hxx |4 ++-
cui/source/tabpages/tpline.cxx | 17
cui/uiconfig/ui/linetabpage.ui | 42 +
3 files changed, 46 insertions(+), 17 deletions(-)
New commits:
commit 654cea3304572e4d33030c8e60503750b06156a3
Author: Katarina Behrens bu...@bubli.org
Date: Sat Mar 29 22:15:41 2014 +0100
fdo#74287: Correctly enable/disable widgets w/ invisible lines
Restore pre-ui behaviour - disable transparency width control,
but keep colour control active when line contains symbols (e.g.
scatter chart)
Change-Id: I4005fc376fa1640c5b9d7e736fbdac7417f0edd9
diff --git a/cui/source/inc/cuitabline.hxx b/cui/source/inc/cuitabline.hxx
index e795453..0a8a09b 100644
--- a/cui/source/inc/cuitabline.hxx
+++ b/cui/source/inc/cuitabline.hxx
@@ -91,10 +91,12 @@ class SvxLineTabPage : public SvxTabPage
using TabPage::ActivatePage;
using TabPage::DeactivatePage;
private:
-VclBox* m_pBoxStyle;
+VclBox* m_pBoxColor;
LineLB* m_pLbLineStyle;
ColorLB*m_pLbColor;
+VclBox* m_pBoxWidth;
MetricField*m_pMtrLineWidth;
+VclBox* m_pBoxTransparency;
MetricField*m_pMtrTransparent;
VclFrame* m_pFlLineEnds;
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index a9a27e4..9afc604 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -110,9 +110,11 @@ SvxLineTabPage::SvxLineTabPage
nPageType ( 0 )
{
get(m_pLbLineStyle,LB_LINE_STYLE);
+get(m_pBoxColor,boxCOLOR);
get(m_pLbColor,LB_COLOR);
-get(m_pBoxStyle,boxSTYLE_ATTR);
+get(m_pBoxWidth,boxWIDTH);
get(m_pMtrLineWidth,MTR_FLD_LINE_WIDTH);
+get(m_pBoxTransparency,boxTRANSPARENCY);
get(m_pMtrTransparent,MTR_LINE_TRANSPARENT);
get(m_pFlLineEnds,FL_LINE_ENDS);
@@ -1545,13 +1547,11 @@ IMPL_LINK( SvxLineTabPage, ChangePreviewHdl_Impl, void
*, pCntrl )
// Make transparency accessible accordingly
if( m_pLbLineStyle-GetSelectEntryPos() == 0 ) // invisible
{
-// aFtTransparent.Disable();
-m_pMtrTransparent-Disable();
+m_pBoxTransparency-Disable();
}
else
{
-// aFtTransparent.Enable();
-m_pMtrTransparent-Enable();
+m_pBoxTransparency-Enable();
}
const bool bHasLineStyle = m_pLbLineStyle-GetSelectEntryPos() !=0;
@@ -1611,9 +1611,9 @@ IMPL_LINK_NOARG(SvxLineTabPage, ClickInvisibleHdl_Impl)
if( m_pLbLineStyle-GetSelectEntryPos() == 0 ) // invisible
{
if(!bSymbols)
-m_pLbColor-Disable();
+m_pBoxColor-Disable();
-m_pBoxStyle-Disable();
+m_pBoxWidth-Disable();
if( m_pFlLineEnds-IsEnabled() )
{
@@ -1627,7 +1627,8 @@ IMPL_LINK_NOARG(SvxLineTabPage, ClickInvisibleHdl_Impl)
}
else
{
-m_pBoxStyle-Enable();
+m_pBoxColor-Enable();
+m_pBoxWidth-Enable();
if( m_pFlLineEnds-IsEnabled() )
{
diff --git a/cui/uiconfig/ui/linetabpage.ui b/cui/uiconfig/ui/linetabpage.ui
index 85c0f9f..670dfba 100644
--- a/cui/uiconfig/ui/linetabpage.ui
+++ b/cui/uiconfig/ui/linetabpage.ui
@@ -86,7 +86,7 @@
/packing
/child
child
- object class=GtkBox id=boxSTYLE_ATTR
+ object class=GtkBox id=boxCOLOR
property name=visibleTrue/property
property name=can_focusFalse/property
property name=orientationvertical/property
@@ -117,6 +117,18 @@
property name=position1/property
/packing
/child
+ /object
+ packing
+property name=expandFalse/property
+property name=fillTrue/property
+property name=position1/property
+ /packing
+/child
+child
+ object class=GtkBox id=boxWIDTH
+property name=visibleTrue/property
+property name=can_focusFalse/property
+property name=orientationvertical/property
child
object class=GtkLabel id=FT_LINE_WIDTH
property name=visibleTrue/property
@@ -129,24 +141,37 @@
packing
property name=expandFalse/property
property name=fillTrue/property
-property name=position2/property
+property name=position0/property
/packing
/child
Simplifying oslThreadIdentifier in Linux 32
Hi all, The patch https://gerrit.libreoffice.org/#/c/5553/ is described as Simplifying oslThreadIdentifier in Linux 32. It's been in the queue for some time, but it's not entirely clear why it is needed. Obviously simplifying is a great thing, but could we get some more explanation about the change? Chris Sherlock ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Fixing Bug 46200 [Easy Hack]
Hi all, I'm a GSOC participant and I'm trying to solve this feature. The functionality added is to use scroll lock and down key to set the top left cell to the current selection. I looked into the comments and got the code pointers 1] ScTabViewShell::KeyInput as the starting point to capture the event 2] ScViewData class which has the functions to handle viewable data the keyinput function decl is found at tabvwsh.hxx. But I cannot seem to find a place it has been used for reference. I would like to know which source file contains the code to handle keyboard events in a spreadsheet. The bug url : https://bugs.freedesktop.org/show_bug.cgi?id=46200 -- Thanks and regards, Tharindu Amila Perera Undergraduate Department of Computer Science Engineering University of Moratuwa ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] minutes of ESC call ...
On Thu, 2014-03-27 at 15:51 +, Michael Meeks wrote: + can we publish the latest callgrind output files ? (Michael) + sounds reasonable AI: + look into automatic up-load of data last callgrind traces (Matus/Cloph) Done, it's all uploaded to http://dev-builds.libreoffice.org/callgrind_report/ Best, Matus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 74834] CONFIGURATION: Option to disable documents thumbnails on the New Start Screen
https://bugs.freedesktop.org/show_bug.cgi?id=74834 crx...@hotmail.com changed: What|Removed |Added CC||crx...@hotmail.com --- Comment #3 from crx...@hotmail.com --- (In reply to comment #2) There is also a privacy issue. Yes, the privacy issue can be serious. And it confuses some lesser-savvy users. And it slows down startup time or time-to-task if you don't want to use a recently used document. And it encourages new users to not understand proper directory structures and file organization. And it annoys some of the conservative users. Really, it is amazing to me something this sweeping and dramatic would be added without any option to control it at all. To be a world-class program, LO needs to consider all types of users in all types of environments. And that means having flexibility for configuration. There is currently no reasonable workaround. Unlike the first posting, I don't think it should be an -or- but an -and- user should be able to turn it off completely, but also having an additional option choice for a textual listing would be nice (although the listing is already available under the File menu, so it is probably redundant). http://ask.libreoffice.org/en/question/29139/can-the-new-start-screen-in-v42-be-reverted-to-that-in-v41/ http://ask.libreoffice.org/en/question/30702/can-i-supress-the-images-on-the-start-screen/ http://ask.libreoffice.org/en/question/31050/is-there-a-way-to-change-the-initial-screen-in-lo-4211/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76769] New: UI: File - Properties - Security: Default should be Protect rather than Unprotect
https://bugs.freedesktop.org/show_bug.cgi?id=76769 Priority: medium Bug ID: 76769 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: File - Properties - Security: Default should be Protect rather than Unprotect Severity: normal Classification: Unclassified OS: Linux (All) Reporter: suokunl...@gmail.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.2.3.2 rc Component: Spreadsheet Product: LibreOffice Steps: 1. New Calc; 2. File - Properties - Security Current Behaviour: Unprotect... Expected: Protect... This wrong behiour does NOT appear in Writer, Impress and Draw, only appears in Calc. OS: Fedora 20 LibreOffice 4.2.3.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76750] UI: Feature Request to Select the Language of the Cells and Sheet
https://bugs.freedesktop.org/show_bug.cgi?id=76750 --- Comment #2 from A (Andy) stgohi-lob...@yahoo.de --- @m.a.riosv: Thanks for your reply. I know this way, even if it has also still problems (see Bug 76714). With my enhancement request I would like to further improve the UI by adding the possibility to also change the language with the menu TOOLS. I think this is important, more user-friendly, more consistent and intuitive, because if you are working with WRITER and then switch to CALC you will look vainly for the language option in the TOOLS menu. For a user it is not intuitive, that in CALC changing the language is different to WRITER. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76735] UI: Options below Pivot Table - More not visable in GNOME (thus Pivot is useless)
https://bugs.freedesktop.org/show_bug.cgi?id=76735 --- Comment #4 from A (Andy) stgohi-lob...@yahoo.de --- Thanks for your reply. I agree with you that the in your point 2 (in comment 3) discussed issue should be resolved. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45001] FILEOPEN particular .PDF shows some elements at wrong position
https://bugs.freedesktop.org/show_bug.cgi?id=45001 --- Comment #17 from vv...@yandex.ru --- To fix E rotation problem, we need mirroring support for text (or, generally, properly working scale case in draw:transform parameter) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76714] EDITING: Multiple Language not supported?
https://bugs.freedesktop.org/show_bug.cgi?id=76714 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added CC||stgohi-lob...@yahoo.de --- Comment #6 from A (Andy) stgohi-lob...@yahoo.de --- @Raymond: Of course, you can change to LO 4.2 because it has many improvements, but because I checked it with 4.2.2.1 I suppose you will still have the bug. But you also have to keep in mind, that the release 4.2.2.1 is called as a Fresh release which is the most feature rich version of the software, and is suited for early adopters willing to leverage a larger number of innovations. For enterprise deployments, The Document Foundation suggests the more reliable LO 4.1.5 Stable. If you want a more stable version, then you should probably wait a little bit longer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76708] Formatting: Borders toolbar button does not work
https://bugs.freedesktop.org/show_bug.cgi?id=76708 --- Comment #5 from A (Andy) stgohi-lob...@yahoo.de --- @Ian: Thanks for your reply. I don't have this Border button. Maybe somebody else can help? Can anybody else with MS Vista check this issue? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76145] Currently not possible to file a bug
https://bugs.freedesktop.org/show_bug.cgi?id=76145 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #7 from A (Andy) stgohi-lob...@yahoo.de --- It worked again on March 28, 2014. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 68167] Create an outline view similar to that in MS Word and Apple Pages
https://bugs.freedesktop.org/show_bug.cgi?id=68167 --- Comment #33 from Gerry gerry.trep...@googlemail.com --- Isn't this a duplicate of bug 38262? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38262] Outline View (aka MS Word)
https://bugs.freedesktop.org/show_bug.cgi?id=38262 --- Comment #9 from Gerry gerry.trep...@googlemail.com --- Isn't bug 68167 is a duplicate of this one? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38262] Outline View (aka MS Word)
https://bugs.freedesktop.org/show_bug.cgi?id=38262 Gerry gerry.trep...@googlemail.com changed: What|Removed |Added See Also||https://issues.apache.org/o ||oo/show_bug.cgi?id=3959 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76678] Picture from Calc cannot insert to Gimp
https://bugs.freedesktop.org/show_bug.cgi?id=76678 --- Comment #4 from František Svoboda sfren...@seznam.cz --- This problem I have on Windows 7, Lo 4.2 and Gimp. I tried various visual display clipboard and mostly appearing picture like bmp. Sometimes it had the wrong color (only in clipboard-viewer). In OpenSuse 13.1, LO 4.1.5.3 and Gimp its all ok. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76740] Draw: moving and resize EMF files is very slow
https://bugs.freedesktop.org/show_bug.cgi?id=76740 Alexandr alexpik...@gmail.com changed: What|Removed |Added Attachment #96537|text/plain |application/vnd.oasis.opend mime type||ocument.graphics -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76740] Draw: moving and resize EMF files is very slow
https://bugs.freedesktop.org/show_bug.cgi?id=76740 Alexandr alexpik...@gmail.com changed: What|Removed |Added OS|Windows (All) |All CC||alexpik...@gmail.com Version|4.2.2.1 release |3.5.4 release --- Comment #2 from Alexandr alexpik...@gmail.com --- Reproducible with LibreOffice Draw 3.5.4, 4.1.4.2 and 4.3.0.0.alpha0+ Build ID: 926435ef5ab26e647c09887d471bde25b24e1c16 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2014-03-22_00:09:10 on Debian x86_64 The problem is not only with moving/resizing the schemes. Whole interface becomes slow when the problem pictures are displayed. I was able to freeze my system by simple moving Help-About window. The issue is sensible to anti-aliasing. Disabling it makes Draw usable (Tools-Options-LibreOffice-View-Use Anti-Aliasing). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 73285] EDITING: Very slow scrolling with big documents
https://bugs.freedesktop.org/show_bug.cgi?id=73285 Luke lukebe...@hotmail.com changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #28 from Luke lukebe...@hotmail.com --- Please see comment #21. There is no way for us to reproduce this bug without a test file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76374] FILESAVE: Writer doesn't save url links in comments
https://bugs.freedesktop.org/show_bug.cgi?id=76374 Michal our...@gmail.com changed: What|Removed |Added Summary|Writer doesn't save url |FILESAVE: Writer doesn't |links in comments |save url links in comments -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76771] New: Correction of punctuation
https://bugs.freedesktop.org/show_bug.cgi?id=76771 Priority: medium Bug ID: 76771 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Correction of punctuation Severity: enhancement Classification: Unclassified OS: All Reporter: luca.vercelli...@gmail.com Hardware: All Status: UNCONFIRMED Version: 3.5.7.2 release Component: contrib Product: LibreOffice It happens, very often to me, that somebody writes a text full of punctuation mistakes and I have to correct it. I cannot find any trivial function in LO that does this. I have written a macro doing this. You can find it at https://forum.openoffice.org/it/forum/viewtopic.php?f=26t=5464#p27079 Maybe you could insert it, or some similar function, in LO? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76769] UI: File - Properties - Security: Default should be Protect rather than Unprotect
https://bugs.freedesktop.org/show_bug.cgi?id=76769 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- for me not reproducible with LO 4.2.2.1 (Win 8.1): I have there Protect as expected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66118] FILEOPEN: MS 97 .doc Fails to import properly. Missing Separator (2/5)
https://bugs.freedesktop.org/show_bug.cgi?id=66118 Luke lukebe...@hotmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Luke lukebe...@hotmail.com --- In the latest nightly 4.3, the separator bar is now being displayed. Nice work team! Tested on: Version: 4.3.0.0.alpha0+ Build ID: 5e7aad393c0c3fab20c8298697ca96563caa7afe TinderBox: Win-x86@39, Branch:master, Time: 2014-03-28_07:18:14 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66372] FILEOPEN: MS .docx Fails to import properly. Line missing from table (5/6)
https://bugs.freedesktop.org/show_bug.cgi?id=66372 Luke lukebe...@hotmail.com changed: What|Removed |Added Resolution|WORKSFORME |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66369] FILEOPEN: MS .docx Fails to import properly. Picture on wrong side (2/6)
https://bugs.freedesktop.org/show_bug.cgi?id=66369 Luke lukebe...@hotmail.com changed: What|Removed |Added Resolution|WORKSFORME |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76708] Formatting: Borders toolbar button does not work
https://bugs.freedesktop.org/show_bug.cgi?id=76708 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added Attachment #96483|application/octet-stream|image/bmp mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76768] Deleting of a Name for a cell causes LibreOffice to close and go into recovery mode for the document
https://bugs.freedesktop.org/show_bug.cgi?id=76768 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- for me not reproducible with LO 4.2.2.1 (Win 8.1) Is this only linked to a specific file or can you also reproduce this issue with a new file? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48324] EDITING: Crop Pictures in Writer like in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=48324 --- Comment #3 from Stéphane Champeau stephane.champ...@gmail.com --- Hi, This is very blocking feature for people from MS Office. Thanks for your dev, Stéphane -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75804] pdf export non printing option doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=75804 Ydier yd...@free.fr changed: What|Removed |Added Version|4.2.2.1 release |4.2.3.2 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48324] EDITING: Crop Pictures in Writer like in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=48324 --- Comment #4 from Stéphane Champeau stephane.champ...@gmail.com --- double post but there is bug #34555 Make cropping handles for images (as in Draw/Impress) available for all LibreOffice applications -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48324] EDITING: Crop Pictures in Writer like in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=48324 Samuel M. s.mehrbr...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Samuel M. s.mehrbr...@gmail.com --- *** This bug has been marked as a duplicate of bug 34555 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76708] Formatting: Borders toolbar button does not work
https://bugs.freedesktop.org/show_bug.cgi?id=76708 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added CC||courrier.oou.fr.mjk@googlem ||ail.com --- Comment #6 from manj_k courrier.oou.fr@googlemail.com --- See also: http://ask.libreoffice.org/en/question/30142/where-is-the-borders-button/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75307] Character format dialog, Position - Subscript/Superscript uses wrong relative size (1%) in Writer/Impress
https://bugs.freedesktop.org/show_bug.cgi?id=75307 bach_leip...@hotmail.com changed: What|Removed |Added CC||bach_leip...@hotmail.com --- Comment #4 from bach_leip...@hotmail.com --- I can confirm this on LO Linux 4.2.2.1 (Ubuntu 12.04). The superscript dialog was initially set at 1% and for me, even when I manually change it, it makes no difference in the result. When I superscript something, all the characters disappear. Automatic checked or not makes no difference either. Superscript/Subscript appear to be essentially unusable. I might add that it does display correctly when I copy something in off the clipboard that contains superscript characters. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 69674] VIEWING: Notes-over-text range depend on field shadings
https://bugs.freedesktop.org/show_bug.cgi?id=69674 --- Comment #2 from David djrei...@gmail.com --- Also now noted at Ask LibO: http://ask.libreoffice.org/en/question/32125/field-shading-and-comment-highlighting-enhancement-needed/ That was for Version: 4.2.2.1 Build ID: 420m0(Build:1) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76772] New: FORMATTING lost when record changes is active
https://bugs.freedesktop.org/show_bug.cgi?id=76772 Priority: medium Bug ID: 76772 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FORMATTING lost when record changes is active Severity: normal Classification: Unclassified OS: Linux (All) Reporter: slk...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.3.2 rc Component: Writer Product: LibreOffice Created attachment 96584 -- https://bugs.freedesktop.org/attachment.cgi?id=96584action=edit Document showing the underisable behavior When editing a text with different formats, and recording the changes made (menu Edit-Changes-Record), if something is deleted near characters with another format, the deleted content loses its formatting. A few examples are shown in the attached file. Steps to reproduce: 1. Create a new writer document; 2. Write a text with different font, color, etc. 3. Remove some of the text; 4. Save; 5. Both Undo and 'reject the change' are not able to restore the original formatting. p.s.: it may be related to (or a duplicate of) this bug: https://bugs.freedesktop.org/show_bug.cgi?id=58813 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76708] Formatting: Borders toolbar button does not work
https://bugs.freedesktop.org/show_bug.cgi?id=76708 manj_k courrier.oou.fr@googlemail.com changed: What|Removed |Added CC||zolnaitamas2...@gmail.com --- Comment #7 from manj_k courrier.oou.fr@googlemail.com --- Added Zolnai Tamás to CC List. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76773] New: EDITING: calc crashes with an error message
https://bugs.freedesktop.org/show_bug.cgi?id=76773 Priority: medium Bug ID: 76773 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: calc crashes with an error message Severity: normal Classification: Unclassified OS: Linux (All) Reporter: jose1...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.2.1 release Component: Spreadsheet Product: LibreOffice Created attachment 96585 -- https://bugs.freedesktop.org/attachment.cgi?id=96585action=edit sample document causing crash Problem description: program crashes Steps to reproduce: 1. open Export_adries.ods in calc 2. click cell F2 and hit = 3. calc yields the following fatal error and terminates prematurely: class 'TabError': inconsistent use of tabs and spaces in indentation (__init__.py, line 70), traceback follows /usr/lib/libreoffice/program/uno.py:269 in function _uno_import() [return _g_delegatee( name, *optargs, **kwargs )] /usr/lib/libreoffice/share/extensions/numbertext/reg.uno.py:7 in function createInstance() [import org.Numbertext] /usr/lib/libreoffice/program/unohelper.py:292 in function createInstanceWithContext() [return self.clazz( context )] crash reproduced always on arch linux i686 and libreoffice-calc 4.2.2-5 Operating System: Linux (Other) Version: 4.2.2.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74087] Cell gets activated on cell with mis-spelled word regardless of mouse cursor position.
https://bugs.freedesktop.org/show_bug.cgi?id=74087 --- Comment #12 from Andras Timar tima...@gmail.com --- On master, 91923443e0d04218ae7124f439fc06a76f904462 is the first bad commit -- I mean it must have fixed something, the commit message was Fix context menu launch on mis-spelled word in a cell.. But since then, the right click on a cell that contains misspelled word always bring up the suggestion popup, even when user does not right click on the misspelled word. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76774] New: disk image could not be open
https://bugs.freedesktop.org/show_bug.cgi?id=76774 Priority: medium Bug ID: 76774 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: disk image could not be open Severity: critical Classification: Unclassified OS: Mac OS X (All) Reporter: bocegu...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: unspecified Component: Installation Product: LibreOffice Downloaded file LibreOffice_4.2.2_MacOS_x86-64.dmg When double clicking it a warning window comes up The following disk images couldn't be opened Reason Image not recognized -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76775] New: UI: 'File'-Menu does not work anymore
https://bugs.freedesktop.org/show_bug.cgi?id=76775 Priority: medium Bug ID: 76775 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: UI: 'File'-Menu does not work anymore Severity: normal Classification: Unclassified OS: Windows (All) Reporter: marcodebie...@gmail.com Hardware: Other Whiteboard: BSA PossibleRegression Status: UNCONFIRMED Version: 4.2.2.1 release Component: Spreadsheet Product: LibreOffice Since update to 4.2.2.1 the file menu does not appear anymore when directly clicking on it. When clicking on the File-Menu, the wait-cursor shows up, turns around for ca.10s while the window is blocked and the window titlebar shows Keine Rückmeldung. The falls back to normal behaviour. When opening an other menu like Edit and then sliding through the menubar to the File-Menu, the File-Menu shows up and works properly. Operating System: Windows 7 Version: 4.2.2.1 release Last worked in: 4.1.1.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76697] Frames without border are not correctly displayed/saved
https://bugs.freedesktop.org/show_bug.cgi?id=76697 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Whiteboard||bibisected --- Comment #3 from Björn Michaelsen bjoern.michael...@canonical.com --- # bad: [b740953537b324e157b22ce3bd46611b01f78e47] Hopefully fix Windows HiDPI toolbar layout bug # good: [135a37bd7b5a1a50e3da9cc666402adbd348d025] fix crash during xls import, related fdo#36580 git bisect start 'HEAD' '135a37bd7b5a1a50e3da9cc666402adbd348d025' # good: [4040c461fc244940c6817770104ccbcc013ac1f3] cppcheck: duplicateIf git bisect good 4040c461fc244940c6817770104ccbcc013ac1f3 # bad: [1b2cf579105d8a1e44b5e2a8aafb79c274fc8455] fdo#71784: Invalid Sections getting added to the document after RT git bisect bad 1b2cf579105d8a1e44b5e2a8aafb79c274fc8455 # bad: [9a156365277c93bd66c2ef21c42bfa377eaf314b] rhbz#988516: DOCX import: fix context stack when importing header/footer git bisect bad 9a156365277c93bd66c2ef21c42bfa377eaf314b # good: [6b6398b72401b35dc0d01de70ee2124a0a4072a8] fdo#45935: try hard to paint a frame for menus git bisect good 6b6398b72401b35dc0d01de70ee2124a0a4072a8 # bad: [b3bc4e283fc941c6f8c334de31fd34031afa0fef] Oopsy. git bisect bad b3bc4e283fc941c6f8c334de31fd34031afa0fef # good: [682f723d31e6c4a59254a08f5ec62abc700f3fd6] fdo#59329 Fix docked window border lines git bisect good 682f723d31e6c4a59254a08f5ec62abc700f3fd6 # bad: [5e34a3236258f47374c34e5c7ab92fde9b981bb7] Ensure that numeric array storage is aligned to 256-byte boundary. git bisect bad 5e34a3236258f47374c34e5c7ab92fde9b981bb7 # bad: [743d331357af5204108186f0428e949f68d966c7] fdo#75260: Correctly draw double lines for both Writer and Calc. git bisect bad 743d331357af5204108186f0428e949f68d966c7 # first bad commit: [743d331357af5204108186f0428e949f68d966c7] fdo#75260: Correctly draw double lines for both Writer and Calc. 743d331357af5204108186f0428e949f68d966c7 is the first bad commit commit 743d331357af5204108186f0428e949f68d966c7 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Mar 3 17:58:11 2014 -0500 fdo#75260: Correctly draw double lines for both Writer and Calc. Fix all sorts of incorrect double line handling in drawinglayer in order to draw thick-thin double line types correctly. Also change handling of border lines in writer tables. There are still some outstanding issues but it's much better than how it was before. Also realized that Word and Excel handle simple thin double lines differently; Word varies widths of all of the lines and the gap whereas Excel only has one fixed size for its double line. For this reason I decided to add a separate double line type (DOUBLE_THIN) to handle Excel's double line. (cherry picked from commit 2c62596cf264ef10749d8bfdb2bb2ebef2d98fbc) Conflicts: cui/source/tabpages/border.cxx sc/qa/unit/subsequent_export-test.cxx sc/source/ui/view/tabvwsha.cxx sw/source/core/layout/paintfrm.cxx xmloff/source/style/bordrhdl.cxx Change-Id: Iaaa353b6e4f998b524262bea59260b4333e0cdb4 Reviewed-on: https://gerrit.libreoffice.org/8464 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76768] Deleting of a Name for a cell causes LibreOffice to close and go into recovery mode for the document
https://bugs.freedesktop.org/show_bug.cgi?id=76768 --- Comment #2 from PaulK pkonk...@yahoo.com --- (In reply to comment #1) for me not reproducible with LO 4.2.2.1 (Win 8.1) Is this only linked to a specific file or can you also reproduce this issue with a new file? Thanks for quick response. I created a new spreadsheet, created a name, and then deleted the name. I also could not duplicate it. I'll try a couple of things: 1. Create a new document with macro (the document having the problem has macros) and see if the problem is within the new document. 2. Do a save as with a different name and see if the problem will be in the new copied document. 3. Place the Problem Document onto a memory stick and open the document from another PC. 4. I'll open the Problem Doc from Ubuntu and see if the problem is there. If you have additional suggestions for further isolating the problem, please pass them onto me. Again, thanks for your time and effort. I'll update you on the outcome of the above. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76697] Frames without border are not correctly displayed/saved
https://bugs.freedesktop.org/show_bug.cgi?id=76697 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=75260 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75160] table borders wrong thickness (.docx)
https://bugs.freedesktop.org/show_bug.cgi?id=75160 --- Comment #1 from Björn Michaelsen bjoern.michael...@canonical.com --- Possibly related to: fdo#75260 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76776] New: Other: LibreOffice Draw crashes after paste a table from Writer
https://bugs.freedesktop.org/show_bug.cgi?id=76776 Priority: medium Bug ID: 76776 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: LibreOffice Draw crashes after paste a table from Writer Severity: normal Classification: Unclassified OS: Linux (All) Reporter: romulomendesfigueir...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.4.2 release Component: Drawing Product: LibreOffice Created attachment 96587 -- https://bugs.freedesktop.org/attachment.cgi?id=96587action=edit Document with the table Problem description: LibreOffice Draw crashes after paste a table from Writer Steps to reproduce: 1. Open ficha.odt in Writer 2. Press CTRL+A 3. Press CTRL+C 4. Open Draw 5. Press CTRL+V Current behavior: LibreOffice crashes and closes both the source and destination document. Expected behavior: The table should copy into the new document or display an error. More information: Linux HP-Probook1 3.2.0-4-amd64 #1 SMP Debian 3.2.54-2 x86_64 GNU/Linux Operating System: Debian Version: 4.1.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76754] FILESAVE: Saving ODS files can take forever, freezing the UI and forcing to kill the LibO process
https://bugs.freedesktop.org/show_bug.cgi?id=76754 --- Comment #2 from sergio.calleg...@gmail.com --- I see this on linux, specifically Kubuntu 13.10 64 bit Libreoffice as distributed by libreoffice.org (not the ubuntu provided builds) On LibO 4.2.3 RC 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76754] FILESAVE: Saving ODS files can take forever, freezing the UI and forcing to kill the LibO process
https://bugs.freedesktop.org/show_bug.cgi?id=76754 sergio.calleg...@gmail.com changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All |Linux (All) Status|NEEDINFO|NEW Assignee|libreoffice-b...@lists.free |d...@fastmail.fm |desktop.org | CC||sergio.calleg...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76777] New: Format [0][Red]General; General
https://bugs.freedesktop.org/show_bug.cgi?id=76777 Priority: medium Bug ID: 76777 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Format [0][Red]General;General Severity: normal Classification: Unclassified OS: All Reporter: te...@gnome.org Hardware: Other Status: UNCONFIRMED Version: 4.1.3.2 release Component: Spreadsheet Product: LibreOffice LO does not follow the OpenDocument v1.2 standard for conditional number formats. The Excel-style format [0][Red]General;General should be represented by the following ods sniplet: number:number-style style:name=ND-0-0 style:text-properties fo:color=#FF/ number:number number:min-integer-digits=1/ number:text/ /number:number-style number:number-style style:name=ND-0 number:number number:min-integer-digits=1/ number:text/ style:map style:condition=value()!=0 style:apply-style-name=ND-0-0/ /number:number-style See http://valhalla.fciencias.unam.mx/odfdomdoc/doc-files/OpenDocument-v1.2-part1-cd04.xhtml section 19.470. LO cannot load this format. Specifically the problem is that LO does not understand value()!=0 and wants this to be value()0. The standard does not allow that condition. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76777] Format [0][Red]General;General
https://bugs.freedesktop.org/show_bug.cgi?id=76777 --- Comment #1 from M Welinder te...@gnome.org --- Created attachment 96588 -- https://bugs.freedesktop.org/attachment.cgi?id=96588action=edit Sample file following the standard -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76777] Format [0][Red]General;General
https://bugs.freedesktop.org/show_bug.cgi?id=76777 --- Comment #2 from M Welinder te...@gnome.org --- Created attachment 96589 -- https://bugs.freedesktop.org/attachment.cgi?id=96589action=edit Sample file using instead of != -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76768] Deleting of a Name for a cell causes LibreOffice to close and go into recovery mode for the document
https://bugs.freedesktop.org/show_bug.cgi?id=76768 --- Comment #3 from A (Andy) stgohi-lob...@yahoo.de --- @PaulK: Thanks for your very fast reply and your effort to try to reproduce it. If you can reproduce it with your steps (very good suggestion), then please leave in a further comment how we can try to reproduce it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75441] Tamil99 keyboard typing wrong display when converted to Latha font
https://bugs.freedesktop.org/show_bug.cgi?id=75441 --- Comment #12 from Oppili sripathy...@gmail.com --- Created attachment 96590 -- https://bugs.freedesktop.org/attachment.cgi?id=96590action=edit Tamil font extra letter doc file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76774] disk image could not be open
https://bugs.freedesktop.org/show_bug.cgi?id=76774 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- Have you already tried to download the file once more? Maybe, it was not downloaded correctly? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75441] Tamil99 keyboard typing wrong display when converted to Latha font
https://bugs.freedesktop.org/show_bug.cgi?id=75441 --- Comment #13 from Oppili sripathy...@gmail.com --- Created attachment 96591 -- https://bugs.freedesktop.org/attachment.cgi?id=96591action=edit tamil font extra letter pdf file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75441] Tamil99 keyboard typing wrong display when converted to Latha font
https://bugs.freedesktop.org/show_bug.cgi?id=75441 --- Comment #14 from Oppili sripathy...@gmail.com --- Created attachment 96592 -- https://bugs.freedesktop.org/attachment.cgi?id=96592action=edit Tamil font extra letter screenshot png -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76775] UI: 'File'-Menu does not work anymore
https://bugs.freedesktop.org/show_bug.cgi?id=76775 A (Andy) stgohi-lob...@yahoo.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||stgohi-lob...@yahoo.de Ever confirmed|0 |1 --- Comment #1 from A (Andy) stgohi-lob...@yahoo.de --- for me not reproducible with LO 4.2.2.1 (Win 8.1) Can you maybe try to install LO again? Maybe, it was not correctly installed? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75109] Other: LibreLogo
https://bugs.freedesktop.org/show_bug.cgi?id=75109 --- Comment #8 from Kolbjørn Stuestøl kolbjo...@stuestoel.no --- (In reply to comment #7) Many thanks for the test! Do you get a message box with a PRINT 0 command in an English language document? No error message. … Maybe the problem is the missing PENCAP item in the localized LibreLogo_nn.properties etc. files ([installation]/share/Scripts/python/LibreLogo/...). Could you attach it? There is a translated PENCAP: PENCAP=linjeende|pencap|linecap (In addition to the Norwegian translations I also have kept some of the original commands). Made a copy of the file LibreLogo_en_US.properties and renamed it to LibreLogo_nn.properties. (Giving the original nn file another name to preserve it). All works fine, but English commands of course. When using the original nn file again, all is back as described abowe. Restarted LO between changes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75441] Tamil99 keyboard typing wrong display when converted to Latha font
https://bugs.freedesktop.org/show_bug.cgi?id=75441 --- Comment #15 from Oppili sripathy...@gmail.com --- I request to consider the last three attachments only and proceed from there. Sorry for saying that extra letter not appears now. Tamil Letters are appearing in Lohit Hindi, if anyone sends the file to others it will show extra letter in most of words to others. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76778] New: Wildcard support in the File Open dialog is broken
https://bugs.freedesktop.org/show_bug.cgi?id=76778 Priority: medium Bug ID: 76778 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Wildcard support in the File Open dialog is broken Severity: normal Classification: Unclassified OS: All Reporter: pedl...@gmail.com Hardware: Other Status: NEW Version: 4.2.0.3 rc Component: UI Product: LibreOffice As discussed in http://ask.libreoffice.org/en/question/32096/wildcard-support-in-the-file-open-name-box-in-4221/ support for wildcards in the LibreOffice dialog File Open is broken in the 4.2 branch under Windows (XP at least) and Linux (Fedora, Debian and Crunchbang at least) Under Windows it does work as expected when using the OS native Open dialog. This is a regression from the 4.1 branch. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76778] Wildcard support in the File Open dialog is broken
https://bugs.freedesktop.org/show_bug.cgi?id=76778 Pedro pedl...@gmail.com changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 66118] FILEOPEN: MS 97 .doc Fails to import properly. Missing Separator (2/5)
https://bugs.freedesktop.org/show_bug.cgi?id=66118 --- Comment #5 from Foss f...@openmailbox.org --- Wow. Another of your bug reports resolved in nightly. Looks like only one is remaining. Who would have thought... :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75193] FORMATTING: Stock Chart 4 Bug for LO 4.2.0.4
https://bugs.freedesktop.org/show_bug.cgi?id=75193 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Markus Mohrhard markus.mohrh...@googlemail.com --- *** This bug has been marked as a duplicate of bug 75075 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75075] Stock Chart 3 Stock Chart 4 not appropriate display
https://bugs.freedesktop.org/show_bug.cgi?id=75075 --- Comment #3 from Markus Mohrhard markus.mohrh...@googlemail.com --- *** Bug 75193 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76764] After open and closing a few spreadsheets, I am unable to open another spreadsheet.
https://bugs.freedesktop.org/show_bug.cgi?id=76764 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added CC||mari...@miguelangel.mobi --- Comment #2 from m.a.riosv mari...@miguelangel.mobi --- Hi steve, I think this can happen if you open the app twice too quick or try to reopen before it's really closed after quit the app. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 61991] “Crop Image” toolbar command for conveniently crop images isn’t available in Writer and Calc
https://bugs.freedesktop.org/show_bug.cgi?id=61991 tommy27 ba...@quipo.it changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC||ba...@quipo.it --- Comment #6 from tommy27 ba...@quipo.it --- *** This bug has been marked as a duplicate of bug 34555 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76773] EDITING: calc crashes with an error message
https://bugs.freedesktop.org/show_bug.cgi?id=76773 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||mari...@miguelangel.mobi Ever confirmed|0 |1 --- Comment #1 from m.a.riosv mari...@miguelangel.mobi --- Hi Jozef, thanks for reporting. I can't reproduce with Windows7x64. Please try resetting user profile, sometimes solves strange issues. https://wiki.documentfoundation.org/UserProfile -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76750] UI: Feature Request to Select the Language of the Cells and Sheet
https://bugs.freedesktop.org/show_bug.cgi?id=76750 m.a.riosv mari...@miguelangel.mobi changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76773] EDITING: calc crashes with an error message
https://bugs.freedesktop.org/show_bug.cgi?id=76773 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- Could you also check the version of the extension numbertext? (Tools/Extension Manager) Last one is 0.9.5. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76774] disk image could not be open
https://bugs.freedesktop.org/show_bug.cgi?id=76774 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr Version|unspecified |4.2.2.1 release --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- Did you try from official website? Did you compare md5 or other (see http://download.documentfoundation.org/libreoffice/stable/4.2.2/mac/x86_64/LibreOffice_4.2.2_MacOS_x86-64.dmg.mirrorlist) to check the file integrity was ok? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
