LibreOffice Gerrit News for submodules on 2014-04-13

2014-04-12 Thread gerrit 
Moin!



~~ Project dictionaries ~~

Nothing moved in the project for the last 25 hours

~~ Project translations ~~

Nothing moved in the project for the last 25 hours

~~ Project help ~~

* Open changes on master for project help changed in the last 25 hours:

+ fdo#77282 Replace "Edit Group" with "Enter Group" in Writer as in Draw
  in https://gerrit.libreoffice.org/8944 from Laurent BP


* Merged changes on master for project help changed in the last 25 hours:

None

* Abandoned changes on master for project help changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

None

Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

LibreOffice Gerrit News for core on 2014-04-13

2014-04-12 Thread gerrit 
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ fdo#62957 FILESAVE: Save Last Slide Position in Impress
  in https://gerrit.libreoffice.org/8946 from Sujay m
  about module sd
 End of freshness 

+ fdo#77282 Replace "Edit Group" with "Enter Group"
  in https://gerrit.libreoffice.org/8923 from Laurent BP
  about module svx


* Merged changes on master for project core changed in the last 25 hours:

None

* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ new method INetURLObject::getData() for data urls
  in https://gerrit.libreoffice.org/8737 from Christina Roßmanith
+ fdo#67544 Slide transistion sound(other sound) is not included in present
  in https://gerrit.libreoffice.org/8700 from Vishv Brahmbhatt
+ fdo#57950: Replace chained O(U)StringBuffer::append() with operator+
  in https://gerrit.libreoffice.org/8699 from Tharindu Lakmal
+ Refactored
  in https://gerrit.libreoffice.org/8683 from Tharindu Lakmal
+ fdo#75757 Remove inheritance to std::map from PropertyMap
  in https://gerrit.libreoffice.org/8656 from Krisztian Pinter
+ Remove visual noise from ios
  in https://gerrit.libreoffice.org/8274 from Alexander Wilms
+ FDO#75205 : Charts - Up Down bars are getting added to Line Chart.
  in https://gerrit.libreoffice.org/8360 from Umesh Kadam
+ WIP: Converting ExtensionUpdate dialog for new format
  in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes
+ Refactored swooxmlexport tests cases. Added function to check contents.
  in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar
+ FDO#74886: Data labels are not preserved for Column Chart in RT file
  in https://gerrit.libreoffice.org/8098 from Umesh Kadam
+ fdo#71984 fix first line indentation in footnotes for MS Word documents
  in https://gerrit.libreoffice.org/8160 from Andras Timar
+ fd0#74150:Numbered list getting display after RT -table-within-table-1.do
  in https://gerrit.libreoffice.org/7767 from Rajashri Udhoji
+ Lots of changes to Tango icons
  in https://gerrit.libreoffice.org/7987 from Miroslav Mazel
+ sw/docx export: fix handling of document with header and section(s)
  in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer
+ fdo#51525 Fix duplicate "Paste Special" entries in Calc.
  in https://gerrit.libreoffice.org/7784 from Andrzej Hunt
+ fdo#72661: Check ‘Hyphenation active’ automatically
  in https://gerrit.libreoffice.org/7291 from Jiwoong Youn
+ sa/l add release_assert() and assert that stay even in release code
  in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud
+ WIP fdo#72987 Use firebird backup format for .odb
  in https://gerrit.libreoffice.org/7299 from Andrzej Hunt
+ sw/export docx: add unit test for document with header and section(s)
  in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer
+ WIP: fdo#33980 Preserve selection across all slide sorters.
  in https://gerrit.libreoffice.org/6633 from Andrzej Hunt
+ Positional Tab additions
  in https://gerrit.libreoffice.org/5387 from Adam CloudOn


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

What encoding is used?

2014-04-12 Thread julien2412 
Hello,

The use of cppcheck-htmlreport to convert raw cppcheck reports errors to
html fails for some files because of the encodings.
Here's an example message:
cppcheck/htmlreport/cppcheck-htmlreport", line 287, in 
content = input_file.read()
  File "/usr/lib/python2.7/codecs.py", line 296, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf8' codec can't decode byte 0xfc in position 3546:
invalid start byte

Here's the list of files which give this problem:
./hwpfilter/source/hcode.cxx
./hwpfilter/source/hwpread.cxx
./hwpfilter/source/hbox.h
./hwpfilter/source/formula.cxx
./hwpfilter/source/hwpfile.cxx
./hwpfilter/source/hwpeq.cxx
./chart2/source/view/charttypes/Splines.cxx (was containing 2 "ü" but was
detected as iso-8859-1 and not as utf8 by "file -i"), now converted (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=42d494e7925249c36f62206e7268d849437e219d)
./hwpfilter/source/hbox.cxx
./hwpfilter/source/hinfo.cxx

I gave a try to ./hwpfilter/source/hinfo.cxx
Initial view on vi (Debian testing x86-64, French)
 56 /**
 57  * ¹®¼­Á¤º¸¸¦ ÀоîµéÀÌ´Â ÇÔ¼ö ( 128 bytes )
 58  * ¹®¼­Á¤º¸´Â ÆÄÀÏÀνÄÁ¤º¸( 30 bytes ) ´ÙÀ½¿¡ À§Ä¡ÇÑ Á¤º¸ÀÌ´Ù.
 59  */
 60 bool HWPInfo::Read(HWPFile & hwpf)

since README from hwpfilter indicates "Hangul Word Processor" and "Korea", I
gave a try with "iconv -f EUC-KR -t utf8 hwpfilter/source/hinfo.cxx >
stdout.txt", I retrieved this:
  56 /**
 57  * 문서정보를 읽어들이는 함수 ( 128 bytes )
 58  * 문서정보는 파일인식정보( 30 bytes ) 다음에 위치한 정보이다.
 59  */
 60 bool HWPInfo::Read(HWPFile & hwpf)

I gave a try to Google translate which detected the language as Korean
(hopefully! :-)) and translated this:
"Function to read the document information"
which seems ok according to the name of the function.
Remark : I don't know what means "( 128 bytes )" or "( 30 bytes)", is it a
pb in conversion?

Anyway, would this conversion be ok on these files or might we lose some
information?
Of course, I prefer cppcheck to fail the html conversion of some reports
than losing important information in these files.
Perhaps too, it's a cppcheck bug or Python bug which should be fixed.

Any idea?

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/What-encoding-is-used-tp4105106.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Searching help to build LibreOffice

2014-04-12 Thread julien2412 
Hi,

Here's the main page for developpers:
https://wiki.documentfoundation.org/Development
and for LO building on Linux:
https://wiki.documentfoundation.org/Development/BuildingOnLinux

Now which sources are you trying to build? (master, 4.2 branch, ...)

Julien



--
View this message in context: 
http://nabble.documentfoundation.org/Searching-help-to-build-LibreOffice-tp4105103p4105105.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: chart2/source

2014-04-12 Thread Julien Nabet 
 chart2/source/view/charttypes/Splines.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 42d494e7925249c36f62206e7268d849437e219d
Author: Julien Nabet 
Date:   Sat Apr 12 23:59:06 2014 +0200

Fix encoding (iso-8859-1 -> utf8)

Change-Id: I3ce449b6be30edbe99a72a66d18225482e091236

diff --git a/chart2/source/view/charttypes/Splines.cxx 
b/chart2/source/view/charttypes/Splines.cxx
index 419fb9a..b4f7b8d 100644
--- a/chart2/source/view/charttypes/Splines.cxx
+++ b/chart2/source/view/charttypes/Splines.cxx
@@ -98,8 +98,8 @@ private:
 /** @descr this function corresponds to the algorithm 4.76 in [2] and
 theorem 5.3.7 in [3]
 
-[2] Engeln-Müllges, Gisela: Numerik-Algorithmen: Verfahren, Beispiele, 
Anwendungen
-Springer, Berlin; Auflage: 9., überarb. und erw. A. (8. Dezember 
2004)
+[2] Engeln-Müllges, Gisela: Numerik-Algorithmen: Verfahren, 
Beispiele, Anwendungen
+Springer, Berlin; Auflage: 9., überarb. und erw. A. (8. Dezember 
2004)
 Section 4.10.2, page 175
 
 [3] Hanrath, Wilhelm: Mathematik III / Numerik, Vorlesungsskript zur
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vbahelper/source

2014-04-12 Thread Julien Nabet 
 vbahelper/source/msforms/vbacontrol.cxx |4 
 1 file changed, 4 deletions(-)

New commits:
commit 091f4f14c596ea0c34d891372a4fc820f92e36ae
Author: Julien Nabet 
Date:   Sat Apr 12 23:24:11 2014 +0200

cppcheck: multiCondition, remove 2 duplicate "else if" blocks

Change-Id: I538bacd0e52a5e7d5df9847ad4632e02124aeb95

diff --git a/vbahelper/source/msforms/vbacontrol.cxx 
b/vbahelper/source/msforms/vbacontrol.cxx
index 7e39227..fdcfedc 100644
--- a/vbahelper/source/msforms/vbacontrol.cxx
+++ b/vbahelper/source/msforms/vbacontrol.cxx
@@ -699,10 +699,6 @@ void SAL_CALL ScVbaControl::setTabIndex( sal_Int32 
/*nTabIndex*/ ) throw (uno::R
 xVBAControl.set( new ScVbaControl( xVbaParent, xContext, xControl, 
xModel, xGeoHelper.release() ) );
 else if ( xServiceInfo->supportsService( "com.sun.star.awt.UnoFrameModel" 
) )
 xVBAControl.set( new ScVbaFrame( xVbaParent, xContext, xControl, 
xModel, xGeoHelper.release(), xDialog ) );
-else if ( xServiceInfo->supportsService( 
"com.sun.star.awt.UnoControlSpinButtonModel" ) )
-xVBAControl.set( new ScVbaSpinButton( xVbaParent, xContext, xControl, 
xModel, xGeoHelper.release() ) );
-else if ( xServiceInfo->supportsService( 
"com.sun.star.custom.awt.UnoControlSystemAXContainerModel" ) )
-xVBAControl.set( new VbaSystemAXControl( xVbaParent, xContext, 
xControl, xModel, xGeoHelper.release() ) );
 if( xVBAControl.is() )
 return xVBAControl;
 throw uno::RuntimeException( "Unsupported control." , uno::Reference< 
uno::XInterface >() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Searching help to build LibreOffice

2014-04-12 Thread Oswald Luc 

Hi !

I am trying to build LibreOffice and
make returns an error :

Failures !!!
Run: 222   Failure total: 1   Failures: 1   Errors: 0
warn:legacy.osl:21402:1:unotools/source/config/configmgr.cxx:167: 
OSL_ASSERT: items_.empty()


Error: a unit test failed, please do one of:

export DEBUGCPPUNIT=TRUE# for exception catching
export CPPUNITTRACE="gdb --args"# for interactive debugging on Linux
export CPPUNITTRACE="\"[full path to devenv.exe]\" /debugexe" # for 
interactive debugging in Visual Studio

export VALGRIND=memcheck# for memory checking

and retry using: make CppunitTest_sc_opencl_test

make[1]: *** 
[/home/MyLibreOffice/core/workdir/CppunitTest/sc_opencl_test.test] Erreur 1

make: *** [build] Erreur 2

Thanks for help !

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: ios/experimental

2014-04-12 Thread Tor Lillqvist 
 ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj | 
   1 +
 1 file changed, 1 insertion(+)

New commits:
commit cddf4bd65fb4ce5615ca770946707d0db657e8ec
Author: Tor Lillqvist 
Date:   Sat Apr 12 23:35:37 2014 +0300

HEADER_SEARCH_PATHS is duplicated for Debug and Release

Change-Id: Ifbed4933f528342300642673d707c8189eda1e8c

diff --git 
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj 
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
index e8dcc42..bea8539 100644
--- 
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
+++ 
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
@@ -1876,6 +1876,7 @@
$LO_SRCDIR/include,

"$(LO_WORKDIR)/UnoApiHeadersTarget/udkapi/comprehensive",

"$(LO_WORKDIR)/UnoApiHeadersTarget/offapi/comprehensive",
+   
"$(LO_WORKDIR)/UnpackedTarball/icu/source/common",
);
IPHONEOS_DEPLOYMENT_TARGET = 6.1;
ONLY_ACTIVE_ARCH = YES;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

GSOC 2014..

2014-04-12 Thread Sujay m 
Hi everyone,
I've submitted a proposal for GSOC 2014 on Follow-me slideshow.
I never gave myself a chance to discuss about the proposal with the mentors
( though have researched about it ).
I joined the community in january and started working on the Easy Hack
42788. .. I had no luck
on that one, but tried very much without the slightest knowledge of gdb,
git, opengrok too.
I then took up another easy hack fdo#64290 UI: count selected rows and
columns, to boost up my confidence.. I worked on this on for 3 weeks and
finally, i got the result.. I submitted my patch to gerrit (
https://gerrit.libreoffice.org/#/c/8489/ ) for review, but unlucky me,
there was a similar patch that got approved first, so mine was abandoned..
Meanwhile I had found details about GSOC.  But my patch was abandoned so i
took up a new one, which is why I didn't find time to discuss about my
proposal before submission.
*Bug 62957*  - FILESAVE:
Save Last Slide Position in Impress, is my third hack that i worked on.
When I first took it, I wanted to complete it before submission of my
proposal ie. in a week. I couldn't complete it but submitted my proposal
anyway. I took a break for sometime to properly study Telepathy framework
and looked up the implementations of telepathy tubes in LO which is already
present..
A week back I took up the bug again, fully determined to complete it this
time.  I finally completed it yesterday and have submitted it for the
review.
https://gerrit.libreoffice.org/#/c/8946/.

Well, I believe that starting is always the toughest part.. After starting
something, we will do something to end what we have started.. All I am
looking from GSOC is a very good start at the community.
My proposal has lots of week points that I would like to change.. I would
like to become more specific on my goals ie. timeline for submissions etc,
since I ve understood it a little better after reading about telepathy.
Am I too late to be asking this? Is the potential mentor of my proposed
project already been assigned to someone else?
I have learned many things after joining the community and would like to
learn even more and parallely contribute to libreoffice.
Thank you.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Bug 62957 - FILESAVE: Save Last Slide Position in Impress Patch.

2014-04-12 Thread Sujay m 
Hi everyone,
This is still my second submission, so i welcome all sorts of comments. I
have used a static variable to complete this hack (  i've been working on
it for a very long time, so chose the easy way out). All alternative
suggestions are welcomed. :)
https://gerrit.libreoffice.org/#/c/8946/
Thank you.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 62957] FILESAVE: Save Last Slide Position in Impress

2014-04-12 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=62957

--- Comment #14 from Sujay  ---
I have submitted the patch for review, hopefully it gets accepted. :)
https://gerrit.libreoffice.org/#/c/8946/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 38844] Reduce XOR rendering

2014-04-12 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=38844

--- Comment #5 from Commit Notification 
 ---
Chris Sherlock committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb5c7d6a79309236d4f19bb2498f2e850f735a2f

fdo#38844 Reduce XOR clipping for gradients



The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/vcl vcl/source

2014-04-12 Thread Chris Sherlock 
 include/vcl/outdev.hxx |3 ---
 include/vcl/print.hxx  |1 -
 vcl/source/gdi/outdev4.cxx |   26 ++
 vcl/source/gdi/print.cxx   |   10 --
 4 files changed, 6 insertions(+), 34 deletions(-)

New commits:
commit bb5c7d6a79309236d4f19bb2498f2e850f735a2f
Author: Chris Sherlock 
Date:   Sun Apr 13 01:42:27 2014 +1000

fdo#38844 Reduce XOR clipping for gradients

Removed XOR clipping version of ClipAndDrawGradientMetafile. Because it
has been removed, the other version isn't really needed in it's own
function so I've moved it back into DrawGradient.

Change-Id: Ib1519a019061c8c71183db63e5c11681bcad4cc4

diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 596f6b3..8dab299 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -841,9 +841,6 @@ protected:
 virtual voidEmulateDrawTransparent( const PolyPolygon& 
rPolyPoly, sal_uInt16 nTransparencePercent );
 voidDrawInvisiblePolygon( const PolyPolygon& 
rPolyPoly );
 
-voidClipAndDrawGradient( Gradient &rGradient, 
const PolyPolygon &rPolyPoly );
-virtual voidClipAndDrawGradientMetafile ( const Gradient 
&rGradient, const PolyPolygon &rPolyPoly );
-
 private:
 typedef void ( OutputDevice::* FontUpdateHandler_t )( bool );
 
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index b08e27b..865767d 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -274,7 +274,6 @@ public:
 
 protected:
 longImplGetGradientStepCount( long nMinRect ) 
SAL_OVERRIDE;
-virtual voidClipAndDrawGradientMetafile ( const Gradient 
&rGradient, const PolyPolygon &rPolyPoly ) SAL_OVERRIDE;
 virtual boolUsePolyPolygonForComplexGradient() 
SAL_OVERRIDE;
 
 voidScaleBitmap ( Bitmap&, SalTwoRect& ) 
SAL_OVERRIDE { };
diff --git a/vcl/source/gdi/outdev4.cxx b/vcl/source/gdi/outdev4.cxx
index 6b76788..0b1a0bd 100644
--- a/vcl/source/gdi/outdev4.cxx
+++ b/vcl/source/gdi/outdev4.cxx
@@ -613,24 +613,6 @@ void OutputDevice::DrawGradient( const Rectangle& rRect,
 DrawGradient ( aPolyPoly, rGradient );
 }
 
-void OutputDevice::ClipAndDrawGradientMetafile ( const Gradient &rGradient, 
const PolyPolygon &rPolyPoly )
-{
-const Rectangle aBoundRect( rPolyPoly.GetBoundRect() );
-const bool  bOldOutput = IsOutputEnabled();
-
-EnableOutput( false );
-Push( PUSH_RASTEROP );
-SetRasterOp( ROP_XOR );
-DrawGradient( aBoundRect, rGradient );
-SetFillColor( COL_BLACK );
-SetRasterOp( ROP_0 );
-DrawPolyPolygon( rPolyPoly );
-SetRasterOp( ROP_XOR );
-DrawGradient( aBoundRect, rGradient );
-Pop();
-EnableOutput( bOldOutput );
-}
-
 void OutputDevice::DrawGradient( const PolyPolygon& rPolyPoly,
  const Gradient& rGradient )
 {
@@ -666,9 +648,10 @@ void OutputDevice::DrawGradient( const PolyPolygon& 
rPolyPoly,
 
 if( mpMetaFile )
 {
+const Rectangle aBoundRect( rPolyPoly.GetBoundRect() );
+
 if ( rPolyPoly.IsRect() )
 {
-const Rectangle aBoundRect( rPolyPoly.GetBoundRect() );
 mpMetaFile->AddAction( new MetaGradientAction( aBoundRect, 
aGradient ) );
 }
 else
@@ -676,7 +659,10 @@ void OutputDevice::DrawGradient( const PolyPolygon& 
rPolyPoly,
 mpMetaFile->AddAction( new MetaCommentAction( 
"XGRAD_SEQ_BEGIN" ) );
 mpMetaFile->AddAction( new MetaGradientExAction( rPolyPoly, 
rGradient ) );
 
-ClipAndDrawGradientMetafile ( rGradient, rPolyPoly );
+Push( PUSH_CLIPREGION );
+IntersectClipRegion(Region(rPolyPoly));
+DrawGradient( aBoundRect, rGradient );
+Pop();
 
 mpMetaFile->AddAction( new MetaCommentAction( "XGRAD_SEQ_END" 
) );
 }
diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index 95fb0f1..7adfcde 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -1812,14 +1812,4 @@ bool Printer::UsePolyPolygonForComplexGradient()
 return true;
 }
 
-void Printer::ClipAndDrawGradientMetafile ( const Gradient &rGradient, const 
PolyPolygon &rPolyPoly )
-{
-const Rectangle aBoundRect( rPolyPoly.GetBoundRect() );
-
-Push( PUSH_CLIPREGION );
-IntersectClipRegion(Region(rPolyPoly));
-DrawGradient( aBoundRect, rGradient );
-Pop();
-}
-
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 4 commits - bin/lo-all-static-libs external/icu ios/experimental ios/lo.xcconfig.in

2014-04-12 Thread Tor Lillqvist 
 bin/lo-all-static-libs   | 
  21 --
 external/icu/ExternalProject_icu.mk  | 
   4 -
 ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj | 
  23 ++
 ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm | 
  35 ++
 ios/lo.xcconfig.in   | 
   1 
 5 files changed, 76 insertions(+), 8 deletions(-)

New commits:
commit eb6bf90a87b50c60efb3df0f0659e7de3e250ba0
Author: Tor Lillqvist 
Date:   Sat Apr 12 20:29:47 2014 +0300

Mmap in the ICU data file and pass it to udata_setCommonData()

Now done in TiledLibreOffice's lo_initialize(), but should probably be
done in common LO code instead.

Change-Id: I398a703943d13c6d715e4c88ead2a629955fb7c9

diff --git a/ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm 
b/ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm
index 4f60d05..8a55107 100644
--- a/ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm
+++ b/ios/experimental/TiledLibreOffice/TiledLibreOffice/lo.mm
@@ -7,6 +7,8 @@
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 #include 
+#include 
+#include 
 
 #include 
 #import 
@@ -15,6 +17,9 @@
 #include 
 #include 
 
+#include 
+#include 
+
 // generated by solenv/bin/native-code.py:
 #include "native-code.mm"
 
@@ -45,6 +50,36 @@ extern "C" void lo_initialize(NSString *documentPath)
 NSString *uno_types = createPaths(@"-env:UNO_TYPES=", app_root_escaped, 
@[@"offapi.rdb", @"oovbaapi.rdb", @"types.rdb"]);
 NSString *uno_services = createPaths(@"-env:UNO_SERVICES=", 
app_root_escaped, @[@"ure/services.rdb", @"services.rdb"]);
 
+int fd = open([[bundlePath 
stringByAppendingPathComponent:@U_ICUDATA_NAME".dat"] UTF8String], O_RDONLY);
+if (fd != -1) {
+struct stat st;
+if (fstat(fd, &st) != -1
+&& st.st_size < (size_t)-1) {
+void *icudata = mmap(0, (size_t) st.st_size, PROT_READ, 
MAP_FILE|MAP_PRIVATE, fd, 0);
+if (icudata == MAP_FAILED) {
+#if OSL_DEBUG_LEVEL > 0
+NSLog(@"mmap failed:%s", strerror(errno));
+#endif
+} else {
+UErrorCode icuStatus = U_ZERO_ERROR;
+udata_setCommonData(icudata, &icuStatus);
+if (U_FAILURE(icuStatus))
+NSLog(@"udata_setCommonData failed");
+else {
+#if OSL_DEBUG_LEVEL > 0
+// Test that ICU works...
+UConverter *cnv = ucnv_open("iso-8859-3", &icuStatus);
+NSLog(@"ucnv_open(iso-8859-3)-> %p, err = %s, name=%s",
+  (void *)cnv, u_errorName(icuStatus), 
(!cnv)?"?":ucnv_getName(cnv,&icuStatus));
+if (U_SUCCESS(icuStatus))
+ucnv_close(cnv);
+#endif
+}
+}
+}
+close(fd);
+}
+
 const char *argv[] = {
 [[[NSBundle mainBundle] executablePath] UTF8String],
 "-env:URE_INTERNAL_LIB_DIR=file:///",
commit 11842c66432ffda87e7326d6f0d8342d484bfcbb
Author: Tor Lillqvist 
Date:   Sat Apr 12 20:29:12 2014 +0300

Copy the ICU data file into the TiledLibreOffice app

Change-Id: I7f259c96dd9ab0ec833cefd2142682d08b7255b1

diff --git 
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj 
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
index 3c5d9d0..e8dcc42 100644
--- 
a/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
+++ 
b/ios/experimental/TiledLibreOffice/TiledLibreOffice.xcodeproj/project.pbxproj
@@ -7,6 +7,7 @@
objects = {
 
 /* Begin PBXBuildFile section */
+   BE03BF9318F9A7CC00620DC7 /* icudt52l.dat in Resources */ = {isa 
= PBXBuildFile; fileRef = BE03BF9218F9A7CC00620DC7 /* icudt52l.dat */; };
BE55B06D18D87CC600950228 /* DocumentTableViewController.m in 
Sources */ = {isa = PBXBuildFile; fileRef = BE55B06C18D87CC600950228 /* 
DocumentTableViewController.m */; };
BE82BD7618218E2E00A447B5 /* Foundation.framework in Frameworks 
*/ = {isa = PBXBuildFile; fileRef = BE82BD7518218E2E00A447B5 /* 
Foundation.framework */; };
BE82BD7818218E2E00A447B5 /* CoreGraphics.framework in 
Frameworks */ = {isa = PBXBuildFile; fileRef = BE82BD7718218E2E00A447B5 /* 
CoreGraphics.framework */; };
@@ -38,6 +39,7 @@
 
 /* Begin PBXFileReference section */
BE03BF9118F9648F00620DC7 /* udata.cpp */ = {isa = 
PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; name = udata.cpp; 
path = ../../../workdir/UnpackedTarball/icu/source/common/udata.cpp; sourceTree 
= ""; };
+   BE03BF9218F9A7CC00620DC7 /* icudt52l.dat */ = {isa = 
PBXFileReference; lastKnownFileType = file; name = "icudt$(LO_ICU_MAJOR)l.dat"; 
path = ../../../../workdir/UnpackedTarball/icu/sourc

[Libreoffice-commits] core.git: configmgr/CppunitTest_configmgr_unit.mk i18npool/Executable_gencoll_rule.mk i18npool/Executable_genindex_data.mk sc/CppunitTest_sc_rangelst_test.mk sc/CppunitTest_sc_uc

2014-04-12 Thread Tor Lillqvist 
 configmgr/CppunitTest_configmgr_unit.mk |1 -
 i18npool/Executable_gencoll_rule.mk |1 -
 i18npool/Executable_genindex_data.mk|1 -
 sc/CppunitTest_sc_rangelst_test.mk  |1 -
 sc/CppunitTest_sc_ucalc.mk  |1 -
 sc/Library_sc.mk|1 -
 writerperfect/Library_wpftdraw.mk   |1 -
 writerperfect/Library_wpftwriter.mk |1 -
 8 files changed, 8 deletions(-)

New commits:
commit 6d9060a6e6aa05a556594a519cb770c1bf06f79f
Author: Tor Lillqvist 
Date:   Sat Apr 12 18:35:33 2014 +0300

Unnecessary to mention dependency on icudata as only libicuuc directly uses 
it

libicudata exports a single symbol, icudt52_data (for ICU version 52), and
only libicuuc refers to it.

Change-Id: Ia04356fda20cf8109156ccd1cbbd9091e70adf27

diff --git a/configmgr/CppunitTest_configmgr_unit.mk 
b/configmgr/CppunitTest_configmgr_unit.mk
index 0ab0e71..18e40f2 100644
--- a/configmgr/CppunitTest_configmgr_unit.mk
+++ b/configmgr/CppunitTest_configmgr_unit.mk
@@ -49,5 +49,4 @@ $(eval $(call gb_CppunitTest_use_components,configmgr_unit,\
 $(eval $(call gb_CppunitTest_use_externals,configmgr_unit,\
 boost_headers \
 icu_headers \
-icudata \
 ))
diff --git a/i18npool/Executable_gencoll_rule.mk 
b/i18npool/Executable_gencoll_rule.mk
index c1903f0..568619a 100644
--- a/i18npool/Executable_gencoll_rule.mk
+++ b/i18npool/Executable_gencoll_rule.mk
@@ -20,7 +20,6 @@ $(eval $(call gb_Executable_use_libraries,gencoll_rule,\
 ))
 
 $(eval $(call gb_Executable_use_externals,gencoll_rule,\
-   icudata \
icui18n \
icuuc \
icu_headers \
diff --git a/i18npool/Executable_genindex_data.mk 
b/i18npool/Executable_genindex_data.mk
index c95b790..0a10b13 100644
--- a/i18npool/Executable_genindex_data.mk
+++ b/i18npool/Executable_genindex_data.mk
@@ -15,7 +15,6 @@ $(eval $(call gb_Executable_use_libraries,genindex_data,\
 ))
 
 $(eval $(call gb_Executable_use_externals,genindex_data,\
-   icudata \
icui18n \
icuuc \
 ))
diff --git a/sc/CppunitTest_sc_rangelst_test.mk 
b/sc/CppunitTest_sc_rangelst_test.mk
index fb7d600..b5ae3da 100644
--- a/sc/CppunitTest_sc_rangelst_test.mk
+++ b/sc/CppunitTest_sc_rangelst_test.mk
@@ -12,7 +12,6 @@ $(eval $(call gb_CppunitTest_CppunitTest,sc_rangelst_test))
 $(eval $(call gb_CppunitTest_use_externals,sc_rangelst_test, \
boost_headers \
 icu_headers \
-icudata \
 icui18n \
 icuuc \
libxml2 \
diff --git a/sc/CppunitTest_sc_ucalc.mk b/sc/CppunitTest_sc_ucalc.mk
index b4bf31d..b9353ca 100644
--- a/sc/CppunitTest_sc_ucalc.mk
+++ b/sc/CppunitTest_sc_ucalc.mk
@@ -31,7 +31,6 @@ endif
 $(eval $(call gb_CppunitTest_use_externals,sc_ucalc,\
boost_headers \
 icu_headers \
-icudata \
 icui18n \
 icuuc \
libxml2 \
diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk
index 05cefb6..b4b7425 100644
--- a/sc/Library_sc.mk
+++ b/sc/Library_sc.mk
@@ -38,7 +38,6 @@ $(eval $(call gb_Library_use_sdk_api,sc))
 $(eval $(call gb_Library_use_externals,sc,\
 boost_headers \
 icu_headers \
-icudata \
 icui18n \
 icuuc \
 libxml2 \
diff --git a/writerperfect/Library_wpftdraw.mk 
b/writerperfect/Library_wpftdraw.mk
index b2cfc36..8b1a611 100644
--- a/writerperfect/Library_wpftdraw.mk
+++ b/writerperfect/Library_wpftdraw.mk
@@ -58,7 +58,6 @@ $(eval $(call gb_Library_use_externals,wpftdraw,\
libxml2 \
icui18n \
icuuc \
-   icudata \
 ))
 
 $(eval $(call gb_Library_add_exception_objects,wpftdraw,\
diff --git a/writerperfect/Library_wpftwriter.mk 
b/writerperfect/Library_wpftwriter.mk
index 81008f3..fab462b 100644
--- a/writerperfect/Library_wpftwriter.mk
+++ b/writerperfect/Library_wpftwriter.mk
@@ -53,7 +53,6 @@ $(eval $(call gb_Library_use_externals,wpftwriter,\
ebook \
etonyek \
icui18n \
-   icudata \
icuuc \
libxml2 \
mwaw \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[SOLVED] Re: Cppcheck reports 'else if' condition matches previous condition (vcl)

2014-04-12 Thread Julien Nabet 

On 11/04/2014 16:13, Caolán McNamara wrote:

On Sat, 2014-04-05 at 16:06 -0700, julien2412 wrote:

Indeed we have:
 296 else
 297 {
 298 if( aTmpBmpEx.IsAlpha() )
 299 aTmpBmpEx = BitmapEx( aTmpBmp,
aTmpBmpEx.GetAlpha() );
 300 else if( aTmpBmpEx.IsAlpha() )
 301 aTmpBmpEx = BitmapEx( aTmpBmp,
aTmpBmpEx.GetMask() );
 302 }
see
http://opengrok.libreoffice.org/xref/core/vcl/source/gdi/impimage.cxx#298

Should the else if be:
else if( aTmpBmpEx.IsTransparent())

"grep -r IsAlpha -C 5 vcl|grep else" definitely strongly suggests that
was the intent. I reckon its worth making that change and see if
anything falls over. Not the kind of thing I'd backport to 4-2 unless we
get compelling evidence to do that.
Thank you Caolán, I pushed the change in master, see 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6c6f78c6567db73aa85de4beb461db2cddac7b2a


Julien

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/source

2014-04-12 Thread Julien Nabet 
 vcl/source/gdi/pdfwriter_impl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2ae639af5ac5e76b6ecbb7e8fb92d32b1ce002ae
Author: Julien Nabet 
Date:   Sat Apr 12 17:47:44 2014 +0200

cppcheck: Possible inefficient checking for emptiness

Change-Id: I2b353435b29046b05acbb1193fda168309e01f4b

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 4f054a6..88cdf39 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -2712,7 +2712,7 @@ sal_Int32 PDFWriterImpl::emitStructure( 
PDFStructureElement& rEle )
 aLine.append( "\n" );
 }
 }
-if( ! rEle.m_aBBox.IsEmpty() || rEle.m_aAttributes.size() )
+if( (! rEle.m_aBBox.IsEmpty()) || (! rEle.m_aAttributes.empty()) )
 {
 OString aAttribs =  emitStructureAttributes( rEle );
 if( !aAttribs.isEmpty() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/quartz

2014-04-12 Thread Julien Nabet 
 vcl/quartz/ctlayout.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6a3440de1d1156c6a0bdb02e7cc38dea990654e3
Author: Julien Nabet 
Date:   Sat Apr 12 17:43:57 2014 +0200

cppcheck: Prefer prefix ++/-- operators for non-primitive types

Change-Id: I7060802164989c2797d4abea29a378eaa3a54b41

diff --git a/vcl/quartz/ctlayout.cxx b/vcl/quartz/ctlayout.cxx
index a9cac89..06bf300 100644
--- a/vcl/quartz/ctlayout.cxx
+++ b/vcl/quartz/ctlayout.cxx
@@ -395,7 +395,7 @@ int CTLayout::GetNextGlyphs( int nLen, sal_GlyphId* 
pOutGlyphIds, Point& rPos, i
 
 while(iter != m_vRunData.end() && iter->m_EndPos <= nStart)
 {
-iter++;
+++iter;
 }
 if(iter == m_vRunData.end())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: vcl/source

2014-04-12 Thread Julien Nabet 
 vcl/source/gdi/impimage.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6c6f78c6567db73aa85de4beb461db2cddac7b2a
Author: Julien Nabet 
Date:   Sat Apr 12 17:40:41 2014 +0200

cppcheck: multiCondition

2 "else if" with same condition, one of them is wrong and it seems here the 
first one.
More details here: 
http://nabble.documentfoundation.org/Cppcheck-reports-else-if-condition-matches-previous-condition-vcl-td4104270.html

Change-Id: I818cfa879a41c5818c429acc1645b1ee1f8b5103

diff --git a/vcl/source/gdi/impimage.cxx b/vcl/source/gdi/impimage.cxx
index 2d054ab7..c8f4a72 100644
--- a/vcl/source/gdi/impimage.cxx
+++ b/vcl/source/gdi/impimage.cxx
@@ -297,7 +297,7 @@ void ImplImageBmp::Draw( sal_uInt16 nPos, OutputDevice* 
pOutDev,
 {
 if( aTmpBmpEx.IsAlpha() )
 aTmpBmpEx = BitmapEx( aTmpBmp, aTmpBmpEx.GetAlpha() );
-else if( aTmpBmpEx.IsAlpha() )
+else if( aTmpBmpEx.IsTransparent() )
 aTmpBmpEx = BitmapEx( aTmpBmp, aTmpBmpEx.GetMask() );
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2014-04-12 Thread Miklos Vajna 
 sw/qa/extras/rtfimport/data/fdo74599.rtf |8 
 sw/qa/extras/rtfimport/rtfimport.cxx |7 +++
 writerfilter/source/dmapper/DomainMapper.cxx |3 +++
 writerfilter/source/filter/ImportFilter.cxx  |3 ---
 4 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit 2df53ef5002270bfe788e383e95002f636a242d9
Author: Miklos Vajna 
Date:   Sat Apr 12 16:15:28 2014 +0200

fdo#74599 RTF import: enable StylesNoDefault compat setting

The Writer 'Heading 3' paragraph style is gray by default, but (just
like in case of DOCX) that shouldn't have any influence on the RTF
import result.

Fix this by moving the compat setting from the DOCX filter
implementation to the common dmapper.

Change-Id: I86c7cf1a66f82b438ce8379467773a88c9e229af

diff --git a/sw/qa/extras/rtfimport/data/fdo74599.rtf 
b/sw/qa/extras/rtfimport/data/fdo74599.rtf
new file mode 100644
index 000..b47728f
--- /dev/null
+++ b/sw/qa/extras/rtfimport/data/fdo74599.rtf
@@ -0,0 +1,8 @@
+{\rtf1
+{\stylesheet
+{\s3 heading 3;}
+}
+\pard\plain \s3
+This is gray
+\par
+}
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index d06d8fd..67f86bd 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1641,6 +1641,13 @@ DECLARE_RTFIMPORT_TEST(testFdo74823, "fdo74823.rtf")
 CPPUNIT_ASSERT_EQUAL(sal_Int16(5391), getProperty< 
uno::Sequence >(xTableRows->getByIndex(1), 
"TableColumnSeparators")[2].Position);
 }
 
+DECLARE_RTFIMPORT_TEST(testFdo74599, "fdo74599.rtf")
+{
+uno::Reference 
xPropertySet(getStyles("ParagraphStyles")->getByName("Heading 3"), 
uno::UNO_QUERY);
+// Writer default styles weren't disabled, so the color was gray, not 
default (black).
+CPPUNIT_ASSERT_EQUAL(static_cast(-1), 
getProperty(xPropertySet, "CharColor"));
+}
+
 CPPUNIT_PLUGIN_IMPLEMENT();
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index d4e3ab8..23152e6 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -110,6 +110,9 @@ LoggedStream(dmapper_logger, "DomainMapper"),
 PropertyNameSupplier::GetPropertyNameSupplier().GetName( 
PROP_SURROUND_TEXT_WRAP_SMALL ),
 uno::makeAny( true ) );
 
+// Don't load the default style definitions to avoid weird mix
+m_pImpl->SetDocumentSettingsProperty("StylesNoDefault", 
uno::makeAny(true));
+
 //import document properties
 try
 {
diff --git a/writerfilter/source/filter/ImportFilter.cxx 
b/writerfilter/source/filter/ImportFilter.cxx
index d75e56b..277f2da 100644
--- a/writerfilter/source/filter/ImportFilter.cxx
+++ b/writerfilter/source/filter/ImportFilter.cxx
@@ -221,9 +221,6 @@ void WriterFilter::setTargetDocument( const uno::Reference< 
lang::XComponent >&
xSettings->setPropertyValue( "TabOverflow", uno::makeAny( sal_True ) );
xSettings->setPropertyValue( "UnbreakableNumberings", uno::makeAny( 
sal_True ) );
 
-   // Don't load the default style definitions to avoid weird mix
-   xSettings->setPropertyValue( "StylesNoDefault", uno::makeAny( sal_True ) );
-
xSettings->setPropertyValue("FloattableNomargins", uno::makeAny( sal_True 
));
xSettings->setPropertyValue( "ClippedPictures", uno::makeAny( sal_True ) );
xSettings->setPropertyValue( "BackgroundParaOverDrawings", uno::makeAny( 
sal_True ) );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - vcl/source

2014-04-12 Thread Chris Sherlock 
 vcl/source/gdi/outdev4.cxx |  203 ++---
 1 file changed, 64 insertions(+), 139 deletions(-)

New commits:
commit 30e0e6ff95417295874e23376f83fc5ff26bf3d7
Author: Chris Sherlock 
Date:   Sat Apr 12 21:09:51 2014 +1000

Unify DrawGradient functions in OutputDevice

Turns out that the two versions of DrawGradient in OutputDevice are
almost exactly the same in every way, except one deals with a rectangle
and the other with a PolyPolygon. So I just convert the Rectangle into
a PolyPolygon and use the PolyPolygon function.

Now that the functions are unified, the need for a seperate function
to clip and draw the gradient is no longer really required, so I've
merged this back into DrawGradient.

Change-Id: I94d4af1bb7dd900495672f0c0481dc9a1083ff67

diff --git a/vcl/source/gdi/outdev4.cxx b/vcl/source/gdi/outdev4.cxx
index 794c6d7..6b76788 100644
--- a/vcl/source/gdi/outdev4.cxx
+++ b/vcl/source/gdi/outdev4.cxx
@@ -606,100 +606,11 @@ void OutputDevice::SetGrayscaleColors( Gradient 
&rGradient )
 void OutputDevice::DrawGradient( const Rectangle& rRect,
  const Gradient& rGradient )
 {
-if ( mnDrawMode & DRAWMODE_NOGRADIENT )
-return; // nothing to draw!
-
-if ( mbInitClipRegion )
-ImplInitClipRegion();
-
-if ( mbOutputClipped )
-return;
-
-if ( !rRect.IsEmpty() )
-{
-if ( mnDrawMode & ( DRAWMODE_BLACKGRADIENT | DRAWMODE_WHITEGRADIENT | 
DRAWMODE_SETTINGSGRADIENT) )
-{
-Color aColor = GetSingleColorGradientFill();
-
-Push( PUSH_LINECOLOR | PUSH_FILLCOLOR );
-SetLineColor( aColor );
-SetFillColor( aColor );
-DrawRect( rRect );
-Pop();
-return;
-}
-
-Gradient aGradient( rGradient );
-
-if ( mnDrawMode & ( DRAWMODE_GRAYGRADIENT | DRAWMODE_GHOSTEDGRADIENT ) 
)
-{
-SetGrayscaleColors( aGradient );
-}
-
-if( mpMetaFile )
-mpMetaFile->AddAction( new MetaGradientAction( rRect, aGradient ) 
);
-
-if( !IsDeviceOutputNecessary() || ImplIsRecordLayout() )
-return;
-
-if ( !Rectangle( PixelToLogic( Point() ), GetOutputSize() ).IsEmpty() )
-{
-// convert rectangle to pixels
-Rectangle aRect( ImplLogicToDevicePixel( rRect ) );
-aRect.Justify();
-
-// do nothing if the rectangle is empty
-if ( !aRect.IsEmpty() )
-{
-// we need a graphics
-if ( !mpGraphics && !ImplGetGraphics() )
-return;
-
-// secure clip region
-Push( PUSH_CLIPREGION );
-IntersectClipRegion( rRect );
-
-// because we draw with no border line, we have to expand 
gradient
-// rect to avoid missing lines on the right and bottom edge
-aRect.Left()--;
-aRect.Top()--;
-aRect.Right()++;
-aRect.Bottom()++;
-
-if ( mbInitClipRegion )
-ImplInitClipRegion();
-
-if ( !mbOutputClipped )
-{
-// gradients are drawn without border
-if ( mbLineColor || mbInitLineColor )
-{
-mpGraphics->SetLineColor();
-mbInitLineColor = true;
-}
-
-mbInitFillColor = true;
-
-// calculate step count if necessary
-if ( !aGradient.GetSteps() )
-aGradient.SetSteps( GRADIENT_DEFAULT_STEPCOUNT );
-
-if( aGradient.GetStyle() == GradientStyle_LINEAR || 
aGradient.GetStyle() == GradientStyle_AXIAL )
-ImplDrawLinearGradient( aRect, aGradient, false, NULL 
);
-else
-ImplDrawComplexGradient( aRect, aGradient, false, NULL 
);
-}
-
-Pop();
-}
-}
-}
+// Convert rectangle to a PolyPolygon by first converting to a Polygon
+Polygon aPolygon ( rRect );
+PolyPolygon aPolyPoly ( aPolygon );
 
-if( mpAlphaVDev )
-{
-// #i32109#: Make gradient area opaque
-mpAlphaVDev->ImplFillOpaqueRectangle( rRect );
-}
+DrawGradient ( aPolyPoly, rGradient );
 }
 
 void OutputDevice::ClipAndDrawGradientMetafile ( const Gradient &rGradient, 
const PolyPolygon &rPolyPoly )
@@ -720,69 +631,6 @@ void OutputDevice::ClipAndDrawGradientMetafile ( const 
Gradient &rGradient, cons
 EnableOutput( bOldOutput );
 }
 
-void OutputDevice::ClipAndDrawGradient ( Gradient &rGradient, const 
PolyPolygon &rPolyPoly )
-{
-const Rectangle aBoundRect( rPolyPoly.GetBoundRect() );
-
-if( !Rectangle( PixelToLogic( Point() ), GetOutputSize() ).IsEmpty() )
-

[Libreoffice-commits] core.git: sw/source

2014-04-12 Thread Caolán McNamara 
 sw/source/core/uibase/docvw/SidebarWin.cxx |6 --
 1 file changed, 6 deletions(-)

New commits:
commit a7228e0bdbb06de56145d1edeacfe4ede1a7a7d4
Author: Caolán McNamara 
Date:   Sat Apr 12 13:35:20 2014 +0100

Resolves: fdo#37130 use 10pt Default style font for comments

instead of 10pt UI font

Change-Id: I92e2b415ff37f8baae67a00cc077e431b12b924c

diff --git a/sw/source/core/uibase/docvw/SidebarWin.cxx 
b/sw/source/core/uibase/docvw/SidebarWin.cxx
index fb78b3b..930b95b 100644
--- a/sw/source/core/uibase/docvw/SidebarWin.cxx
+++ b/sw/source/core/uibase/docvw/SidebarWin.cxx
@@ -270,12 +270,6 @@ SfxItemSet SwSidebarWin::DefaultItem()
 {
 SfxItemSet aItem( mrView.GetDocShell()->GetPool() );
 aItem.Put(SvxFontHeightItem(200,100,EE_CHAR_FONTHEIGHT));
-aItem.Put(SvxFontItem(FAMILY_SWISS,
-  
GetSettings().GetStyleSettings().GetFieldFont().GetName(),
-  OUString(),
-  PITCH_DONTKNOW,
-  RTL_TEXTENCODING_DONTKNOW,
-  EE_CHAR_FONTINFO));
 return aItem;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - smoketest/data

2014-04-12 Thread Michael Stahl 
 smoketest/data/Basic/Standard/Global.xml   |   10 -
 smoketest/data/Basic/Standard/Test_10er.xml|   43 -
 smoketest/data/Dialogs/Standard/OptionsDlg.xml |1 
 smoketest/data/content.xml |1 
 4 files changed, 1 insertion(+), 54 deletions(-)

New commits:
commit 3d98800c9b925b725fcf42c78e51e02f297a23f6
Author: Michael Stahl 
Date:   Wed Jan 29 09:20:30 2014 +0100

smoketest: remove OpenOffice.org 1.0 XML format export tests

... which fail since the export filter was disabled in
aeeaccf59abbc485d7786486f1accc1cb4d4dbf7.

(cherry picked from commit 694a6478c1cfe18579dc9b355bda3db836b0b3a2)

This is part of the fix for fdo#74979.

Change-Id: I10969a96394d2972376a792af645ff48ccdab7c0
Reviewed-on: https://gerrit.libreoffice.org/8938
Reviewed-by: Kohei Yoshida 
Tested-by: Kohei Yoshida 

diff --git a/smoketest/data/Basic/Standard/Global.xml 
b/smoketest/data/Basic/Standard/Global.xml
index 16947ba..0afffcf 100644
--- a/smoketest/data/Basic/Standard/Global.xml
+++ b/smoketest/data/Basic/Standard/Global.xml
@@ -26,7 +26,7 @@ const cParagraphBreak = 0
 
 global const cExtensionFileName = "TestExtension.oxt"
 
-global const cDocNew = 0, cDocSaveOpen8 = 1, cDocSaveOpenXML = 2, cDocClose = 
3, cDocMacros = 4
+global const cDocNew = 0, cDocSaveOpen8 = 1, cDocClose = 3, cDocMacros = 4
 global const cDBService = 0, cDBOpen = 1, cDBInsert = 2, cDBDelete = 3, 
cDBSeek = 4, cDBClose = 5
 global const cEXTService = 0, cEXTInstall = 1, cEXTUninstall = 2
 global const cTestClosureSetupDoc = 0, cTestClosureWriteStatus = 1
@@ -80,7 +80,6 @@ Global const cUserFieldTestWriter = "Writer", 
cUserFieldTestCalc = &qu
 Global const cUserFieldTestDraw = "Draw", cUserFieldTestMath = 
"Math", cUserFieldTestChart = "Chart"
 Global const cUserFieldTestHTML = "HTML", cUserFieldTestJava = 
"Java", cUserFieldTestDatabase = "Database"
 Global const cUserFieldTestExtension = "Extension"
-Global const cUserFieldTestOpenSaveXML = "SaveOpenXML"
 Global const cUserFieldTestTerminateAfterTest = "Terminate", 
cUserFieldTestOpenSave8 = "SaveOpen8", cUserFieldTestMacros = 
"Macros"
 
 Global const cOptionsDialogName = "OptionsDlg", cTest10Modul = 
"Standard"
@@ -98,7 +97,6 @@ Global bMakeWriterTest as boolean, bMakeCalcTest as  boolean, 
bMakeImpressTest a
 Global bMakeDrawTest as Boolean, bMakeMathTest as boolean, bMakeChartTest as 
boolean
 Global bMakeHTMLTest as boolean, bMakeJavaTest as boolean, bMakeDBTest as 
boolean
 Global bMakeExtensionTest as boolean
-Global bMakeSaveOpenXMLTest as boolean
 Global bMakeTerminateAfterTest as boolean, bShowTable as boolean
 Global bMakeSaveOpen8Test as boolean, bMakeMacrosTest as boolean
 
@@ -225,7 +223,6 @@ Sub CreateStatusTable
 dim tableRows(4) as string
 tableRows(cDocNew) = "new"
 tableRows(cDocSaveOpen8) = "V8.0"
-tableRows(cDocSaveOpenXML) = "XML"
 tableRows(cDocClose) = "close"
 tableRows(cDocMacros) = "macros"
 
@@ -563,7 +560,6 @@ Sub SetOptions
 SetUserFieldState (cUserFieldTestJava, 
-(gOptionsDialog.getControl("cbJavaTest").getState), gOutputDoc)
 SetUserFieldState (cUserFieldTestDatabase, 
-(gOptionsDialog.getControl("cbDatabaseTest").getState), gOutputDoc)
 SetUserFieldState (cUserFieldTestExtension, 
-(gOptionsDialog.getControl("cbExtensionTest").getState), gOutputDoc)
-SetUserFieldState (cUserFieldTestOpenSaveXML, 
-(gOptionsDialog.getControl("cbSaveOpenXMLTest").getState), 
gOutputDoc)
 SetUserFieldState (cUserFieldTestOpenSave8, 
-(gOptionsDialog.getControl("cbSaveOpen8Test").getState), gOutputDoc)
 SetUserFieldState (cUserFieldTestMacros, 
-(gOptionsDialog.getControl("cbMacrosTest").getState), gOutputDoc)
 SetUserFieldState (cUserFieldTestTerminateAfterTest, 
-(gOptionsDialog.getControl("cbTerminateAfterTest").getState), 
gOutputDoc)
@@ -581,7 +577,6 @@ Sub GetOptions
 gOptionsDialog.getControl("cbJavaTest").setState( -( 
GetUserFieldState (cUserFieldTestJava, gOutputDoc)))
 gOptionsDialog.getControl("cbDatabaseTest").setState( -( 
GetUserFieldState (cUserFieldTestDatabase, gOutputDoc)))
 gOptionsDialog.getControl("cbExtensionTest").setState( -( 
GetUserFieldState (cUserFieldTestExtension, gOutputDoc)))
-gOptionsDialog.getControl("cbSaveOpenXMLTest").setState( -( 
GetUserFieldState (cUserFieldTestOpenSaveXML, gOutputDoc)))
 gOptionsDialog.getControl("cbSaveOpen8Test").setState( -( 
GetUserFieldState (cUserFieldTestOpenSave8, gOutputDoc)))
 gOptionsDialog.getControl("cbMacrosTest").setState( -( 
GetUserFieldState (cUserFieldTestMacros, gOutputDoc)))
 gOptionsDialog.getControl("cbTerminateAfterTest").setState( -( 
GetUserFieldState (cUserFieldTestTerminateAfterTest, gOutputDoc)))
@@ -599,7 +594,6 @@ Sub ReadOptions
 bMakeJavaTest = GetUserFieldState (cUserFieldTestJava, gOutputDoc)
 bMakeDBTest = GetUserFieldState (cUserFieldTestDatabase, gOutputDoc)
 bMakeExtensionTest = GetUserFieldState

[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - filter/source

2014-04-12 Thread Bryan Quigley 
 filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu   
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Calc_.xcu   
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Chart_.xcu  
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Draw_.xcu   
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Impress_.xcu
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Math_.xcu   
   |2 +-
 filter/source/config/fragments/filters/StarOffice_XML__Writer_.xcu 
   |2 +-
 filter/source/config/fragments/filters/calc_StarOffice_XML_Calc_Template.xcu   
   |2 +-
 filter/source/config/fragments/filters/draw_StarOffice_XML_Draw_Template.xcu   
   |2 +-
 filter/source/config/fragments/filters/impress_StarOffice_XML_Draw.xcu 
   |2 +-
 
filter/source/config/fragments/filters/impress_StarOffice_XML_Impress_Template.xcu
|2 +-
 
filter/source/config/fragments/filters/writer_StarOffice_XML_Writer_Template.xcu
  |2 +-
 
filter/source/config/fragments/filters/writer_globaldocument_StarOffice_XML_Writer.xcu
|2 +-
 
filter/source/config/fragments/filters/writer_globaldocument_StarOffice_XML_Writer_GlobalDocument.xcu
 |2 +-
 
filter/source/config/fragments/filters/writer_web_StarOffice_XML_Writer_Web_Template.xcu
  |2 +-
 15 files changed, 15 insertions(+), 15 deletions(-)

New commits:
commit 95da7399047e025327aa96bffde2faf1c2a0757c
Author: Bryan Quigley 
Date:   Sun Nov 10 16:10:26 2013 -0500

Remove OOo1.0 file formats from Save As.

List discussion: 
http://lists.freedesktop.org/archives/libreoffice/2013-November/057337.html

Reviewed-on: https://gerrit.libreoffice.org/7489
Tested-by: LibreOffice gerrit bot 
Reviewed-by: Kohei Yoshida 
(cherry picked from commit aeeaccf59abbc485d7786486f1accc1cb4d4dbf7)
(cherry picked from commit c9c4148f00f60a9bb986e9431e76ab7cf8b4c547)

This will be used as a "fix" for fdo#74979.

Change-Id: Iea7e5d9ed8f0e48ffce4504bfaaf0d41067c7a5d
Reviewed-on: https://gerrit.libreoffice.org/8937
Reviewed-by: Bryan Quigley 
Reviewed-by: Kohei Yoshida 
Tested-by: Kohei Yoshida 

diff --git a/filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu 
b/filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu
index b1f5c03..0a1fdce 100644
--- a/filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu
+++ b/filter/source/config/fragments/filters/StarOffice_XML__Base_.xcu
@@ -16,7 +16,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 
-IMPORT EXPORT OWN DEFAULT 3RDPARTYFILTER 
ENCRYPTION
+IMPORT OWN DEFAULT 3RDPARTYFILTER 
ENCRYPTION
 
 
 
diff --git a/filter/source/config/fragments/filters/StarOffice_XML__Calc_.xcu 
b/filter/source/config/fragments/filters/StarOffice_XML__Calc_.xcu
index ffe412a..dbc8bc3 100644
--- a/filter/source/config/fragments/filters/StarOffice_XML__Calc_.xcu
+++ b/filter/source/config/fragments/filters/StarOffice_XML__Calc_.xcu
@@ -16,7 +16,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 
-IMPORT EXPORT TEMPLATE OWN ALIEN 
ENCRYPTION
+IMPORT TEMPLATE OWN ALIEN 
ENCRYPTION
 
 
 
diff --git a/filter/source/config/fragments/filters/StarOffice_XML__Chart_.xcu 
b/filter/source/config/fragments/filters/StarOffice_XML__Chart_.xcu
index 96a5052..f84efc0 100644
--- a/filter/source/config/fragments/filters/StarOffice_XML__Chart_.xcu
+++ b/filter/source/config/fragments/filters/StarOffice_XML__Chart_.xcu
@@ -16,7 +16,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 
-IMPORT EXPORT OWN ALIEN NOTINFILEDIALOG 
NOTINCHOOSER ENCRYPTION
+IMPORT OWN ALIEN NOTINFILEDIALOG 
NOTINCHOOSER ENCRYPTION
 
 com.sun.star.comp.chart2.XMLFilter
 XML
diff --git a/filter/source/config/fragments/filters/StarOffice_XML__Draw_.xcu 
b/filter/source/config/fragments/filters/StarOffice_XML__Draw_.xcu
index b32c713..a4a6c37 100644
--- a/filter/source/config/fragments/filters/StarOffice_XML__Draw_.xcu
+++ b/filter/source/config/fragments/filters/StarOffice_XML__Draw_.xcu
@@ -16,7 +16,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 -->
 
-IMPORT EXPORT TEMPLATE OWN ALIEN 
PREFERRED ENCRYPTION
+IMPORT TEMPLATE OWN ALIEN PREFERRED 
ENCRYPTION
 
 
 XML
diff --git 
a/filter/source/config/fragments/filters/StarOffice_XML__Impress_.xcu 
b/filter/source/config/fragments/filters/

[Libreoffice-commits] core.git: filter/qa

2014-04-12 Thread Caolán McNamara 
 filter/qa/cppunit/data/ras/indeterminate/CVE-2007-2356-1.ras |binary
 1 file changed

New commits:
commit cb35c7cd492fad57ca5b0ad6bff3234d07952d8d
Author: Caolán McNamara 
Date:   Sat Apr 12 12:40:20 2014 +0100

add test case for CVE-2007-2356

Change-Id: I9bf6ca1c5a23dd0e3ef6b7d7c0de041a48df45b6

diff --git a/filter/qa/cppunit/data/ras/indeterminate/CVE-2007-2356-1.ras 
b/filter/qa/cppunit/data/ras/indeterminate/CVE-2007-2356-1.ras
new file mode 100644
index 000..c00c270
Binary files /dev/null and 
b/filter/qa/cppunit/data/ras/indeterminate/CVE-2007-2356-1.ras differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 4 commits - desktop/source include/unotest sd/CppunitTest_sd_filters_test.mk sd/CppunitTest_sd_import_tests.mk sd/source unotest/source

2014-04-12 Thread Tomaž Vajngerl 
 desktop/source/lib/init.cxx   |2 
 include/unotest/macros_test.hxx   |4 
 sd/CppunitTest_sd_filters_test.mk |6 
 sd/CppunitTest_sd_import_tests.mk |6 
 sd/source/filter/html/htmlex.cxx  |  202 +++---
 sd/source/filter/html/htmlex.hxx  |9 +
 sd/source/filter/html/htmlpublishmode.hxx |   10 +
 sd/source/filter/html/sdhtmlfilter.cxx|7 -
 unotest/source/cpp/macros_test.cxx|   17 +-
 9 files changed, 225 insertions(+), 38 deletions(-)

New commits:
commit 272a5e7671fadd254d06d67180f97916891a4cf4
Author: Tomaž Vajngerl 
Date:   Sat Apr 12 12:48:22 2014 +0200

sd tests: tab to spaces

Change-Id: Icfc9d08b073f76d6c489a8b12a3c27b850a116ce

diff --git a/sd/CppunitTest_sd_filters_test.mk 
b/sd/CppunitTest_sd_filters_test.mk
index a2d1562..45c29aa 100644
--- a/sd/CppunitTest_sd_filters_test.mk
+++ b/sd/CppunitTest_sd_filters_test.mk
@@ -45,15 +45,15 @@ $(eval $(call gb_CppunitTest_use_libraries,sd_filters_test, 
\
 svt \
 svx \
 svxcore \
-   test \
+test \
 tl \
 tk \
 ucbhelper \
-   unotest \
+unotest \
 utl \
 vcl \
 xo \
-   $(gb_UWINAPI) \
+$(gb_UWINAPI) \
 ))
 
 $(eval $(call gb_CppunitTest_set_include,sd_filters_test,\
diff --git a/sd/CppunitTest_sd_import_tests.mk 
b/sd/CppunitTest_sd_import_tests.mk
index d1a552f..3661de7 100644
--- a/sd/CppunitTest_sd_import_tests.mk
+++ b/sd/CppunitTest_sd_import_tests.mk
@@ -40,15 +40,15 @@ $(eval $(call gb_CppunitTest_use_libraries,sd_import_tests, 
\
 svt \
 svx \
 svxcore \
-   test \
+test \
 tl \
 tk \
 ucbhelper \
-   unotest \
+unotest \
 utl \
 vcl \
 xo \
-   $(gb_UWINAPI) \
+$(gb_UWINAPI) \
 ))
 
 $(eval $(call gb_CppunitTest_set_include,sd_import_tests,\
commit fa4c74f4d5cb7ff8ae8d4fa43f07c557bcbcf9e0
Author: Tomaž Vajngerl 
Date:   Sat Apr 12 12:33:32 2014 +0200

liblo: fix check of xcomponent

Change-Id: I8a05a067681767518c688eb836bbe676bed05996

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index 183a555..a965be7 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -195,7 +195,7 @@ static LibreOfficeDocument* lo_documentLoad(LibreOffice* 
pThis, const char* pURL
 aURL, OUString("_blank"), 0,
 
uno::Sequence());
 
-if (xComponentLoader.is())
+if (xComponent.is())
 return new LibLODocument_Impl(xComponent);
 else
 pLib->maLastExceptionMsg = "unknown load failure";
commit 5830799d5ba3afbb696dc354535fcfd2f10ba059
Author: Tomaž Vajngerl 
Date:   Fri Apr 11 21:31:43 2014 +0200

macros_test: use "css" short form

Change-Id: I2e8d8773703df67d090059be8bd9f3c7c7335f78

diff --git a/include/unotest/macros_test.hxx b/include/unotest/macros_test.hxx
index d995246..12108ba 100644
--- a/include/unotest/macros_test.hxx
+++ b/include/unotest/macros_test.hxx
@@ -27,10 +27,10 @@ namespace unotest {
 class OOO_DLLPUBLIC_UNOTEST MacrosTest
 {
 public:
-com::sun::star::uno::Reference< com::sun::star::lang::XComponent > 
loadFromDesktop(const OUString& rURL, const OUString& rDocService = OUString() 
);
+css::uno::Reference< css::lang::XComponent > loadFromDesktop(const 
OUString& rURL, const OUString& rDocService = OUString() );
 
 protected:
-com::sun::star::uno::Reference< com::sun::star::frame::XDesktop2> 
mxDesktop;
+css::uno::Reference< css::frame::XDesktop2> mxDesktop;
 };
 
 }
diff --git a/unotest/source/cpp/macros_test.cxx 
b/unotest/source/cpp/macros_test.cxx
index 9305a68..44f0d56 100644
--- a/unotest/source/cpp/macros_test.cxx
+++ b/unotest/source/cpp/macros_test.cxx
@@ -15,21 +15,20 @@
 #include "cppunit/TestAssert.h"
 #include 
 
-using namespace com::sun::star;
+using namespace css;
 
 namespace unotest {
 
-uno::Reference< com::sun::star::lang::XComponent > 
MacrosTest::loadFromDesktop(const OUString& rURL, const OUString& rDocService)
+uno::Reference MacrosTest::loadFromDesktop(const 
OUString& rURL, const OUString& rDocService)
 {
 CPPUNIT_ASSERT_MESSAGE("no desktop", mxDesktop.is());
-uno::Reference< com::sun::star::frame::XComponentLoader> xLoader = 
uno::Reference< com::sun::star::frame::XComponentLoader >( mxDesktop, 
uno::UNO_QUERY );
+uno::Reference xLoader = 
uno::Reference(mxDesktop, uno::UNO_QUERY);
 CPPUNIT_ASSERT_MESSAGE("no loader", xLoader.is());
-com::sun::star::uno::Sequence< com::sun::star::beans::PropertyValue > 
args(1);
+uno::Sequence args(1);
 args[0].Name = "MacroExecutionMode";
 args[0].Handle = -1;
-args[0].Value <<=
-com::sun::star::document::MacroExecMode::ALWAYS_EXECUTE_NO_WARN;
-args[0].State = com::sun::star::beans::PropertyState_DIRECT_VALUE;
+args[0].Value <<= document::MacroExecMode::ALWAYS_EXECUTE_NO_WARN;
+args[

[Libreoffice-commits] core.git: unotools/source

2014-04-12 Thread Eike Rathke 
 unotools/source/config/syslocaleoptions.cxx |1 -
 1 file changed, 1 deletion(-)

New commits:
commit f0d9aab05249ff9ea97a60fa5305f2ae32e2bdbb
Author: Eike Rathke 
Date:   Sat Apr 12 00:41:39 2014 +0200

do not change configured runtime system locale when setting UI locale

This was always plain wrong.

Change-Id: I2b0e3572a8285638c6d2a16e2b095c4a9847a25c

diff --git a/unotools/source/config/syslocaleoptions.cxx 
b/unotools/source/config/syslocaleoptions.cxx
index c2fa6d5..fa25d34 100644
--- a/unotools/source/config/syslocaleoptions.cxx
+++ b/unotools/source/config/syslocaleoptions.cxx
@@ -410,7 +410,6 @@ void SvtSysLocaleOptions_Impl::SetUILocaleString( const 
OUString& rStr )
 
 // as we can't switch UILocale at runtime, we only store changes in 
the configuration
 MakeRealUILocale();
-LanguageTag::setConfiguredSystemLanguage( 
m_aRealUILocale.getLanguageType() );
 SetModified();
 NotifyListeners( SYSLOCALEOPTIONS_HINT_UILOCALE );
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 65675] LibreOffice 4.2 most annoying bugs

2014-04-12 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=65675

superu...@gmail.com changed:

   What|Removed |Added

Version|4.2.0.0.alpha0+ Master  |Inherited From OOo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 65675] LibreOffice 4.2 most annoying bugs

2014-04-12 Thread bugzilla-daemon 
https://bugs.freedesktop.org/show_bug.cgi?id=65675

superu...@gmail.com changed:

   What|Removed |Added

Version|Inherited From OOo  |4.2.0.0.alpha0+ Master

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

2014-04-12 Thread Tor Lillqvist 
 sc/source/ui/view/gridwin.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b0ca4765f304dbef11dbad932c13bf00e245f684
Author: Tor Lillqvist 
Date:   Sat Apr 12 10:46:26 2014 +0300

WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'

Change-Id: Idfecaf013426bb549d3148fe0cab4c9e6c05dd2e

diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 8a47818..be97bc6 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -3050,7 +3050,7 @@ void ScGridWindow::Command( const CommandEvent& rCEvt )
 Link aLink = LINK( this, ScGridWindow, PopupSpellingHdl );
 pEditView->ExecuteSpellPopup( aMenuPos, &aLink );
 
-bDone = sal_True;
+bDone = true;
 }
 }
 else if ( !bMouse )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits