LibreOffice Gerrit News for core on 2014-04-27
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + DrawWaveLine/ImplDrawWaveLine fixes: - try to avoid huge looping due to in https://gerrit.libreoffice.org/9174 from Douglas Mencken about module vcl End of freshness + make signing depend on slowchecks being done in https://gerrit.libreoffice.org/9176 from Christian Lohmaier about module postprocess, solenv * Merged changes on master for project core changed in the last 25 hours: + Clean up remains of URL History List (eHISTORY). in https://gerrit.libreoffice.org/9105 from Andrzej Hunt + fdo#72006 Populate Load URL dropdown from picklist. in https://gerrit.libreoffice.org/9104 from Andrzej Hunt + Toolbar overflow/context menu: keep ordering and don't discard separator. in https://gerrit.libreoffice.org/9169 from Andrzej Hunt + fdo#75489 Pass toolbar context menu commands to toolbar for handling. in https://gerrit.libreoffice.org/9168 from Andrzej Hunt * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + fdo#76934 : FILESAVE: DOCX: Title is not preserved after Roundtrip in https://gerrit.libreoffice.org/8847 from Pallavi Jadhav + move inettype.{hc}xx from svl to tools in https://gerrit.libreoffice.org/8926 from Christina Roßmanith + fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IF in https://gerrit.libreoffice.org/8883 from Michaël Lefèvre + new method INetURLObject::getData() for data urls in https://gerrit.libreoffice.org/8737 from Christina Roßmanith + fdo#67544 Slide transistion sound(other sound) is not included in present in https://gerrit.libreoffice.org/8700 from Vishv Brahmbhatt + fdo#57950: Replace chained O(U)StringBuffer::append() with operator+ in https://gerrit.libreoffice.org/8699 from Tharindu Lakmal + Refactored in https://gerrit.libreoffice.org/8683 from Tharindu Lakmal + fdo#75757 Remove inheritance to std::map from PropertyMap in https://gerrit.libreoffice.org/8656 from Krisztian Pinter + Remove visual noise from ios in https://gerrit.libreoffice.org/8274 from Alexander Wilms + FDO#75205 : Charts - Up Down bars are getting added to Line Chart. in https://gerrit.libreoffice.org/8360 from Umesh Kadam + WIP: Converting ExtensionUpdate dialog for new format in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes + Refactored swooxmlexport tests cases. Added function to check contents. in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar + fdo#71984 fix first line indentation in footnotes for MS Word documents in https://gerrit.libreoffice.org/8160 from Andras Timar + Lots of changes to Tango icons in https://gerrit.libreoffice.org/7987 from Miroslav Mazel + sw/docx export: fix handling of document with header and section(s) in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer + fdo#51525 Fix duplicate Paste Special entries in Calc. in https://gerrit.libreoffice.org/7784 from Andrzej Hunt + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + sa/l add release_assert() and assert that stay even in release code in https://gerrit.libreoffice.org/7625 from Norbert Thiebaud + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + sw/export docx: add unit test for document with header and section(s) in https://gerrit.libreoffice.org/6249 from Pierre-Eric Pelloux-Prayer + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/framework include/svtools include/unotools
include/framework/addonsoptions.hxx |4 ++-- include/svtools/menuoptions.hxx |4 ++-- include/svtools/miscopt.hxx |4 ++-- include/svtools/optionsdrawinglayer.hxx |4 ++-- include/svtools/slidesorterbaropt.hxx|2 +- include/svtools/toolpanelopt.hxx |2 +- include/unotools/cmdoptions.hxx |4 ++-- include/unotools/compatibility.hxx |4 ++-- include/unotools/dynamicmenuoptions.hxx |4 ++-- include/unotools/extendedsecurityoptions.hxx |4 ++-- include/unotools/fontoptions.hxx |4 ++-- include/unotools/historyoptions.hxx |4 ++-- include/unotools/localisationoptions.hxx |4 ++-- include/unotools/moduleoptions.hxx |2 +- include/unotools/printwarningoptions.hxx |4 ++-- include/unotools/securityoptions.hxx |4 ++-- include/unotools/viewoptions.hxx |2 +- 17 files changed, 30 insertions(+), 30 deletions(-) New commits: commit 46a719d893b92f41a0bdbd7bff660d228c2bd714 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Apr 27 09:39:21 2014 +0200 Typos: dfined - defined + add missing 's' Change-Id: I0e806da30ae0518579bdc0c8f0218cf5689dc70f diff --git a/include/framework/addonsoptions.hxx b/include/framework/addonsoptions.hxx index b52db41..79ff32e 100644 --- a/include/framework/addonsoptions.hxx +++ b/include/framework/addonsoptions.hxx @@ -296,8 +296,8 @@ class FWE_DLLPUBLIC AddonsOptions /*Attention -Don't initialize these static member in these header! -a) Double dfined symbols will be detected ... +Don't initialize these static members in these headers! +a) Double defined symbols will be detected ... b) and unresolved externals exist at linking time. Do it in your source only. */ diff --git a/include/svtools/menuoptions.hxx b/include/svtools/menuoptions.hxx index 3b7006c..75a4440 100644 --- a/include/svtools/menuoptions.hxx +++ b/include/svtools/menuoptions.hxx @@ -97,8 +97,8 @@ class SVT_DLLPUBLIC SAL_WARN_UNUSED SvtMenuOptions: public utl::detail::Options /*Attention -Don't initialize these static member in these header! -a) Double dfined symbols will be detected ... +Don't initialize these static members in these headers! +a) Double defined symbols will be detected ... b) and unresolved externals exist at linking time. Do it in your source only. */ diff --git a/include/svtools/miscopt.hxx b/include/svtools/miscopt.hxx index 95db002..4bff149 100644 --- a/include/svtools/miscopt.hxx +++ b/include/svtools/miscopt.hxx @@ -119,8 +119,8 @@ class SVT_DLLPUBLIC SvtMiscOptions: public utl::detail::Options /*Attention -Don't initialize these static member in these header! -a) Double dfined symbols will be detected ... +Don't initialize these static members in these headers! +a) Double defined symbols will be detected ... b) and unresolved externals exist at linking time. Do it in your source only. */ diff --git a/include/svtools/optionsdrawinglayer.hxx b/include/svtools/optionsdrawinglayer.hxx index b632d04..a5bcc98 100644 --- a/include/svtools/optionsdrawinglayer.hxx +++ b/include/svtools/optionsdrawinglayer.hxx @@ -171,8 +171,8 @@ class SVT_DLLPUBLIC SvtOptionsDrawinglayer /*Attention -Don't initialize these static member in these header! -a) Double dfined symbols will be detected ... +Don't initialize these static members in these headers! +a) Double defined symbols will be detected ... b) and unresolved externals exist at linking time. Do it in your source only. */ diff --git a/include/svtools/slidesorterbaropt.hxx b/include/svtools/slidesorterbaropt.hxx index 67d1225..b9e4623 100644 --- a/include/svtools/slidesorterbaropt.hxx +++ b/include/svtools/slidesorterbaropt.hxx @@ -83,7 +83,7 @@ class SVT_DLLPUBLIC SvtSlideSorterBarOptions: public utl::detail::Options /** \attention -Don't initialize these static member in these header! +Don't initialize these static members in these headers! \li Double defined symbols will be detected ... \li and unresolved externals exist at linking time. Do it in your source only. diff --git a/include/svtools/toolpanelopt.hxx b/include/svtools/toolpanelopt.hxx index d261465..c5368a5 100644 --- a/include/svtools/toolpanelopt.hxx +++ b/include/svtools/toolpanelopt.hxx @@ -84,7 +84,7 @@ class SVT_DLLPUBLIC SvtToolPanelOptions: public utl::detail::Options /** \attention -Don't initialize these static member in these header! +Don't
[Libreoffice-commits] core.git: sw/source
sw/source/core/uibase/wrtsh/delete.cxx |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit f5fb361df94449850a83be3b412f68e1f9b949c5 Author: Michael Stahl mst...@redhat.com Date: Fri Apr 25 20:09:47 2014 +0200 fdo#60967: fix deletion of paragraph following table Surprisingly MovePara(fnParaCurr, fnParaEnd) actually moves to the end of the next paragraph if the current one is empty. Change-Id: I780bf663b19044252f1d4532d5467c3a599c8a49 diff --git a/sw/source/core/uibase/wrtsh/delete.cxx b/sw/source/core/uibase/wrtsh/delete.cxx index 7d95390..e18c453 100644 --- a/sw/source/core/uibase/wrtsh/delete.cxx +++ b/sw/source/core/uibase/wrtsh/delete.cxx @@ -462,7 +462,10 @@ long SwWrtShell::DelToEndOfSentence() if (SwCrsrShell::Right(1,CRSR_SKIP_CHARS)) { SetMark(); -SwCrsrShell::MovePara(fnParaCurr, fnParaEnd); +if (!IsEndPara()) // can only be at the end if it's empty +{ // for an empty paragraph this would actually select the _next_ +SwCrsrShell::MovePara(fnParaCurr, fnParaEnd); +} if (!IsEndOfDoc()) // do not delete last paragraph in body text { nRet = DelFullPara() ? 1 : 0; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sd/source svx/source
sd/source/ui/inc/slideshow.hxx |1 - sd/source/ui/slideshow/slideshowimpl.cxx |2 +- svx/source/svdraw/svdotxln.cxx |3 ++- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 037754fa9ecea1792e1a8f73b8b4cad4dac75ee0 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Apr 27 12:31:37 2014 +0200 cppcheck: reduce scope Change-Id: I18d7500dcc4b29e2d0face22649f6f96382eabe8 diff --git a/svx/source/svdraw/svdotxln.cxx b/svx/source/svdraw/svdotxln.cxx index d978094..b4e386f 100644 --- a/svx/source/svdraw/svdotxln.cxx +++ b/svx/source/svdraw/svdotxln.cxx @@ -166,7 +166,7 @@ bool SdrTextObj::ReloadLinkedText( bool bForceLoad) if( pData ) { DateTimeaFileDT( DateTime::EMPTY ); -boolbExists = true, bLoad = false; +boolbExists = true; try { @@ -187,6 +187,7 @@ bool SdrTextObj::ReloadLinkedText( bool bForceLoad) if( bExists ) { +bool bLoad = false; if( bForceLoad ) bLoad = true; else commit 916cbd94d1c848bc69166915b96ff89ac380c913 Author: Julien Nabet serval2...@yahoo.fr Date: Sun Apr 27 12:23:48 2014 +0200 ANIMATIONMODE_VIEW can be removed See http://nabble.documentfoundation.org/About-ANIMATIONMODE-VIEW-in-slideshow-module-td4106488.html Change-Id: I0405e8ef41105a53ac056382aa6b32d2a573c170 diff --git a/sd/source/ui/inc/slideshow.hxx b/sd/source/ui/inc/slideshow.hxx index 0b87eba..20324f5 100644 --- a/sd/source/ui/inc/slideshow.hxx +++ b/sd/source/ui/inc/slideshow.hxx @@ -72,7 +72,6 @@ class FrameView; enum AnimationMode { ANIMATIONMODE_SHOW, -ANIMATIONMODE_VIEW, ANIMATIONMODE_PREVIEW }; diff --git a/sd/source/ui/slideshow/slideshowimpl.cxx b/sd/source/ui/slideshow/slideshowimpl.cxx index 1c3556f..ce7c550 100644 --- a/sd/source/ui/slideshow/slideshowimpl.cxx +++ b/sd/source/ui/slideshow/slideshowimpl.cxx @@ -2659,7 +2659,7 @@ void SlideshowImpl::resize( const Size rSize ) { maPresSize = rSize; -if( mpShowWindow (ANIMATIONMODE_VIEW != meAnimationMode) ) +if(mpShowWindow) { mpShowWindow-SetSizePixel( maPresSize ); mpShowWindow-Show(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 7 commits - avmedia/Library_avmedia.mk avmedia/source include/vcl solenv/gbuild svx/Library_svxcore.mk vcl/source
avmedia/Library_avmedia.mk |7 - avmedia/source/opengl/oglframegrabber.cxx |2 avmedia/source/opengl/oglplayer.cxx| 28 ++-- avmedia/source/opengl/oglplayer.hxx|3 avmedia/source/opengl/oglwindow.cxx| 32 +++- avmedia/source/opengl/oglwindow.hxx| 11 + avmedia/source/viewer/mediawindow_impl.cxx | 52 --- avmedia/source/viewer/mediawindow_impl.hxx |3 include/vcl/opengl/OpenGLContext.hxx | 10 + solenv/gbuild/extensions/pre_MergedLibsList.mk |2 svx/Library_svxcore.mk |2 vcl/source/opengl/OpenGLContext.cxx| 173 + 12 files changed, 231 insertions(+), 94 deletions(-) New commits: commit e112ac81d1c3a91d46ea660ac4e01e6c94ee900e Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Apr 27 12:20:13 2014 +0200 First try to render OpenGL content in a window Change-Id: Ibb7178330d356806cea2cfc972b361167d5a9340 diff --git a/avmedia/source/opengl/oglplayer.cxx b/avmedia/source/opengl/oglplayer.cxx index 720825a..9d5f730 100644 --- a/avmedia/source/opengl/oglplayer.cxx +++ b/avmedia/source/opengl/oglplayer.cxx @@ -24,6 +24,7 @@ namespace avmedia { namespace ogl { OGLPlayer::OGLPlayer() : Player_BASE(m_aMutex) +, m_bIsPlaying(false) { } @@ -98,19 +99,21 @@ void SAL_CALL OGLPlayer::start() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); // TODO: Start playing of gltf model (see com::sun::star::media::XPlayer) +m_bIsPlaying = true; } void SAL_CALL OGLPlayer::stop() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); // TODO: Stop playing of gltf model (see com::sun::star::media::XPlayer) +m_bIsPlaying = false; } sal_Bool SAL_CALL OGLPlayer::isPlaying() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); // TODO: Check whether gltf model is played by now (see com::sun::star::media::XPlayer) -return false; +return m_bIsPlaying; } double SAL_CALL OGLPlayer::getDuration() throw ( uno::RuntimeException, std::exception ) @@ -184,11 +187,19 @@ awt::Size SAL_CALL OGLPlayer::getPreferredPlayerWindowSize() throw ( uno::Runtim return awt::Size( 480, 360 ); // TODO: It will be good for OpenGL too? } -uno::Reference media::XPlayerWindow SAL_CALL OGLPlayer::createPlayerWindow( const uno::Sequence uno::Any /*aArguments*/ ) +uno::Reference media::XPlayerWindow SAL_CALL OGLPlayer::createPlayerWindow( const uno::Sequence uno::Any rArguments ) throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard( m_aMutex ); -OGLWindow* pWindow = new OGLWindow(*this); + +if( rArguments.getLength() 2 ) +{ +sal_IntPtr pIntPtr = 0; +rArguments[ 2 ] = pIntPtr; +SystemChildWindow *pChildWindow = reinterpret_cast SystemChildWindow* ( pIntPtr ); +m_aContext.init(pChildWindow); +} +OGLWindow* pWindow = new OGLWindow(m_pHandle, m_aContext); return uno::Reference media::XPlayerWindow ( pWindow ); } @@ -197,11 +208,10 @@ uno::Reference media::XFrameGrabber SAL_CALL OGLPlayer::createFrameGrabber() { osl::MutexGuard aGuard(m_aMutex); m_aContext.init(); -//TODO: Use real values instead of constants. m_pHandle-viewport.x = 0; m_pHandle-viewport.y = 0; -m_pHandle-viewport.width = 800; -m_pHandle-viewport.height = 600; +m_pHandle-viewport.width = getPreferredPlayerWindowSize().Width; +m_pHandle-viewport.height = getPreferredPlayerWindowSize().Height; gltf_renderer_set_content(m_pHandle); OGLFrameGrabber *pFrameGrabber = new OGLFrameGrabber( m_pHandle ); return uno::Reference media::XFrameGrabber ( pFrameGrabber );; diff --git a/avmedia/source/opengl/oglplayer.hxx b/avmedia/source/opengl/oglplayer.hxx index 2b9b415..a40b43d 100644 --- a/avmedia/source/opengl/oglplayer.hxx +++ b/avmedia/source/opengl/oglplayer.hxx @@ -47,7 +47,7 @@ public: virtual void SAL_CALL setMute( sal_Bool bSet ) throw (com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual sal_Bool SAL_CALL isMute() throw (com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual com::sun::star::awt::Size SAL_CALL getPreferredPlayerWindowSize() throw (com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; -virtual com::sun::star::uno::Reference com::sun::star::media::XPlayerWindow SAL_CALL createPlayerWindow( const com::sun::star::uno::Sequence com::sun::star::uno::Any aArguments ) throw (com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; +virtual com::sun::star::uno::Reference com::sun::star::media::XPlayerWindow SAL_CALL createPlayerWindow( const com::sun::star::uno::Sequence com::sun::star::uno::Any rArguments ) throw
[SOLVED] Re: About ANIMATIONMODE_VIEW in slideshow module
Thorsten Behrens wrote Julien Nabet wrote: Ok to remove ANIMATIONMODE_VIEW or did I miss something? Yep, looks fine to me. Thank you Thorsten for your feedback, I pushed the patch on master (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=916cbd94d1c848bc69166915b96ff89ac380c913) Julien -- View this message in context: http://nabble.documentfoundation.org/About-ANIMATIONMODE-VIEW-in-slideshow-module-tp4106488p4106603.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: vcl/source
vcl/source/opengl/OpenGLContext.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 1bf5639cb30cfc133f8ca30b3a54074ae4a0527a Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Apr 27 12:47:52 2014 +0200 Fix mac build: explicitly check all platforms inside swapBuffers Plus some cosmetics Change-Id: I42d989217a0b40a8a6a03c0ebc6c4aa14b34d387 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 107bcf0..4daae1c 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -586,7 +586,7 @@ bool OpenGLContext::initWindow() return true; } -#elif defined( MACOSX ) || defined( IOS) || defined( ANDROID ) +#elif defined( MACOSX ) || defined( IOS ) || defined( ANDROID ) bool OpenGLContext::initWindow() { @@ -648,7 +648,7 @@ bool OpenGLContext::initWindow() #endif -#if defined( WNT ) || defined( MACOSX ) || defined( IOS) || defined( ANDROID ) +#if defined( WNT ) || defined( MACOSX ) || defined( IOS ) || defined( ANDROID ) SystemWindowData OpenGLContext::generateWinData(Window* /*pParent*/) { @@ -752,8 +752,10 @@ SystemWindowData OpenGLContext::generateWinData(Window* pParent) void OpenGLContext::swapBuffers() { -#if defined( _WIN32 ) +#if defined( WNT ) SwapBuffers(m_aGLWin.hDC); +#elif defined( MACOSX ) || defined( IOS ) || defined( ANDROID ) +// nothing #elif defined( UNX ) glXSwapBuffers(m_aGLWin.dpy, m_aGLWin.win); #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/recentdocsviewitem.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2b4f2541e7bcabc5cf61f2389f64de46eb084a3f Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Apr 27 12:52:34 2014 +0200 Fix ambiguity error Change-Id: I228393b1e41d5f7d6dc0e24e0bbc21a46952287d diff --git a/sfx2/source/control/recentdocsviewitem.cxx b/sfx2/source/control/recentdocsviewitem.cxx index b6f7274..10e798f 100644 --- a/sfx2/source/control/recentdocsviewitem.cxx +++ b/sfx2/source/control/recentdocsviewitem.cxx @@ -170,7 +170,7 @@ void RecentDocsViewItem::Paint(drawinglayer::processor2d::BaseProcessor2D *pProc // paint the remove icon when highlighted if (isHighlighted()) { -Primitive2DSequence aSeq(1); +drawinglayer::primitive2d::Primitive2DSequence aSeq(1); Point aIconPos(getRemoveIconArea().TopLeft()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/sdview3.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit dffcd67a9a9865c9eca9756eea4e85445b50a15e Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Apr 27 12:55:32 2014 +0200 do not crash when pasting impress page into another impress page (cp#167) Put an Impress page into clipboard, create new document, click 'Click to add title', paste - crash. Introduced by 5aee0c13cc62a81a38d4132db7972dc301c21b3d. Change-Id: Ibe61a780244ce98205e5ae3964971d7d75e30870 diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx index cd95616..b54f8d1 100644 --- a/sd/source/ui/view/sdview3.cxx +++ b/sd/source/ui/view/sdview3.cxx @@ -361,6 +361,7 @@ bool View::InsertData( const TransferableDataHelper rDataHelper, if( pOwnData-GetDocShell() pOwnData-IsPageTransferable() ISA( View ) ) { mpClipboard-HandlePageDrop (*pOwnData); +bReturn = true; } else if( pSourceView ) { @@ -1347,6 +1348,7 @@ bool View::InsertData( const TransferableDataHelper rDataHelper, // add text color pPickObj-SetMergedItemSetAndBroadcast( aSet ); } +bReturn = true; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: upper case digits in OUString/OString::number() (was: [Libreoffice-commits] core.git: Change RGB FFFF00 - ffff00 to keep roundtrip test happy)
On Friday 25 of April 2014, Eike Rathke wrote: Hi Stephan, On Friday, 2014-04-25 10:06:17 +0200, Stephan Bergmann wrote: Would it be better to change oox::drawingml::DrawingML::WriteColor(sal_uInt32, sal_Int32) (oox/source/export/drawingml.cxx) to always write OOXML ST_HexColorRGB values in W3C XML Schema hexBinaryCanonical form, i.e., with upper case digits A--F? Which reminds me, we can't force upper case digits in OUString/OString::number(), can we? We can, the docs say it'll be a string representation of the number, it doesn't say whether hex will be uppercase or lowercase. The question is of course how much code makes an assumption about this and whether the change is worth it. -- Lubos Lunak l.lu...@collabora.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/recentdocsviewitem.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7b3ff3882dcaa87e62188ef9300d771321998b20 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Apr 27 13:06:32 2014 +0200 Fix one more ambiguity error Change-Id: I123f536b4dcfd34932d639ebe287ef993b90fddb diff --git a/sfx2/source/control/recentdocsviewitem.cxx b/sfx2/source/control/recentdocsviewitem.cxx index 10e798f..aa2a7e0 100644 --- a/sfx2/source/control/recentdocsviewitem.cxx +++ b/sfx2/source/control/recentdocsviewitem.cxx @@ -174,7 +174,7 @@ void RecentDocsViewItem::Paint(drawinglayer::processor2d::BaseProcessor2D *pProc Point aIconPos(getRemoveIconArea().TopLeft()); -aSeq[0] = Primitive2DReference(new DiscreteBitmapPrimitive2D( +aSeq[0] = drawinglayer::primitive2d::Primitive2DReference(new DiscreteBitmapPrimitive2D( m_bRemoveIconHighlighted? theRemoveRecentBitmapHighlighted::get(): theRemoveRecentBitmap::get(), B2DPoint(aIconPos.X(), aIconPos.Y(; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl
include/vcl/outdev.hxx | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) New commits: commit 75886eb439cb8bc4d78c87482a74aaa1fa422604 Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sun Apr 27 21:08:12 2014 +1000 VCL: make all private functions SAL_DLLPRIVATE visibility Change-Id: I746d41a1bfb9546c02b7381cf54785bcc50f1756 diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 5f261dc..c954e64 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -345,6 +345,7 @@ private: /** @name Initialization and accessor functions */ ///@{ + protected: OutputDevice(); @@ -411,6 +412,7 @@ public: } protected: + /** Acquire a graphics device that the output device uses to draw on. There is an LRU of OutputDevices that is used to get the graphics. The @@ -476,6 +478,7 @@ public: vcl::ExtOutDevData* GetExtOutDevData() const { return mpExtOutDevData; } private: + voidImplRotatePos( long nOriginX, long nOriginY, long rX, long rY, short nOrientation ) const; ///@} @@ -484,7 +487,9 @@ private: /** @name Frame functions */ ///@{ + private: + SAL_DLLPRIVATE void ImplGetFrameDev ( const Point rPt, const Point rDevPt, const Size rDevSize, OutputDevice rOutDev ); SAL_DLLPRIVATE void ImplDrawFrameDev( const Point rPt, const Point rDevPt, const Size rDevSize, @@ -495,7 +500,9 @@ private: /** @Name Direct OutputDevice drawing functions */ ///@{ + public: + virtual voidDrawOutDev( const Point rDestPt, const Size rDestSize, const Point rSrcPt, const Size rSrcSize ); virtual voidDrawOutDev( const Point rDestPt, const Size rDestSize, @@ -506,9 +513,11 @@ public: sal_uInt16 nFlags = 0 ); protected: + virtual voidCopyAreaFinal( SalTwoRect aPosAry, sal_uInt32 nFlags); private: + SAL_DLLPRIVATE void ImplDrawOutDevDirect ( const OutputDevice* pSrcDev, SalTwoRect rPosAry ); // not implemented; to detect misuses of DrawOutDev(...OutputDevice); @@ -575,14 +584,17 @@ public: const Font GetFont() const { return maFont; } private: -voidInitFillColor(); + +SAL_DLLPRIVATE void InitFillColor(); ///@} /** @name Clipping functions */ ///@{ + public: + Region GetClipRegion() const; voidSetClipRegion(); voidSetClipRegion( const Region rRegion ); @@ -597,10 +609,12 @@ public: virtual Region GetActiveClipRegion() const; protected: + virtual voidInitClipRegion(); virtual voidClipToPaintRegion( Rectangle rDstRect ); private: + SAL_DLLPRIVATE void SetDeviceClipRegion( const Region* pRegion ); ///@} @@ -608,7 +622,9 @@ private: /** @name Pixel functions */ ///@{ + public: + voidDrawPixel( const Point rPt ); voidDrawPixel( const Point rPt, const Color rColor ); voidDrawPixel( const Polygon rPts, const Color* pColors = NULL ); @@ -644,7 +660,9 @@ public: /** @name Line functions */ ///@{ + public: + voidDrawLine( const Point rStartPt, const Point rEndPt ); voidDrawLine( const Point rStartPt, const Point rEndPt, @@ -667,6 +685,7 @@ private: /** @name Polyline functions */ ///@{ + public: /** Render the given polygon as a line stroke @@ -1020,6 +1039,7 @@ public: ///@{ public: + FontInfoGetDevFont( int nDevFontIndex ) const; int GetDevFontCount() const; @@ -1080,6 +1100,7 @@ public: const OutputDevice* pOutDev = NULL ); protected: + virtual voidInitFont() const; virtual voidImplReleaseFonts(); virtual voidSetFontOrientation( ImplFontEntry* const pFontEntry ) const; @@ -1087,6 +1108,7 @@ protected: private: + typedef void ( OutputDevice::* FontUpdateHandler_t )( bool ); SAL_DLLPRIVATE void ImplClearFontData( bool bNewFontLists ); @@ -1107,6 +1129,7 @@ private: ///@{ public: + SAL_DLLPRIVATE bool ImplIsAntiparallel() const ; SAL_DLLPRIVATE void ReMirror( Point rPoint ) const; SAL_DLLPRIVATE void ReMirror( Rectangle rRect ) const; @@ -1330,7 +1353,7 @@ private:
About removing macros
Hello, I noticed the use of macros like DECL_PROP1IMPL, DECL_PROP0 (see http://opengrok.libreoffice.org/search?q=DECL_PROP1IMPLproject=coredefs=refs=path=hist=). Does it worth it to remove them? More generally, what macros could/should be removed? Julien -- View this message in context: http://nabble.documentfoundation.org/About-removing-macros-tp4106620.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/vcl vcl/Library_vcl.mk
include/vcl/outdev.hxx | 209 --- vcl/Library_vcl.mk | 238 - 2 files changed, 238 insertions(+), 209 deletions(-) New commits: commit ce941a33b7bcae6a1954d7f4235a1cf15690d95e Author: Chris Sherlock chris.sherloc...@gmail.com Date: Sun Apr 27 22:25:51 2014 +1000 VCL: complete reorganization of text and font functions in outdev.hxx Change-Id: I7dbd9ec79213d43acf6486a2507c8f0cfb47d943 diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index c954e64..28af364 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -468,7 +468,7 @@ public: /** Query an OutputDevice to see whether it supports a specific operation -@return true if operation supported, else false + @returns true if operation supported, else false */ boolsupportsOperation( OutDevSupportType ) const; @@ -479,7 +479,7 @@ public: private: -voidImplRotatePos( long nOriginX, long nOriginY, long rX, long rY, +SAL_DLLPRIVATE void ImplRotatePos( long nOriginX, long nOriginY, long rX, long rY, short nOrientation ) const; ///@} @@ -528,6 +528,7 @@ private: /** @name OutputDevice state functions */ ///@{ + public: voidPush( sal_uInt16 nFlags = PUSH_ALL ); @@ -889,82 +890,127 @@ private: ///@{ public: -SystemTextLayoutDataGetSysTextLayoutData( const Point rStartPt, const OUString rStr, - sal_Int32 nIndex = 0, sal_Int32 nLen = -1, - const sal_Int32* pDXAry = NULL ) const; -SAL_DLLPRIVATE bool ImplNewFont() const; -SAL_DLLPRIVATE void ImplInitTextColor(); -static -SAL_DLLPRIVATE void ImplDrawText( OutputDevice rTargetDevice, const Rectangle rRect, +voidDrawText( const Point rStartPt, const OUString rStr, + sal_Int32 nIndex = 0, sal_Int32 nLen = -1, + MetricVector* pVector = NULL, OUString* pDisplayText = NULL ); + +voidDrawText( const Rectangle rRect, + const OUString rStr, sal_uInt16 nStyle = 0, + MetricVector* pVector = NULL, OUString* pDisplayText = NULL, + ::vcl::ITextLayout* _pTextLayout = NULL ); + +voidImplDrawText( OutputDevice rTargetDevice, const Rectangle rRect, const OUString rOrigStr, sal_uInt16 nStyle, MetricVector* pVector, OUString* pDisplayText, ::vcl::ITextLayout _rLayout ); -SAL_DLLPRIVATE void ImplDrawTextBackground( const SalLayout ); -SAL_DLLPRIVATE void ImplDrawTextLines( SalLayout, FontStrikeout eStrikeout, FontUnderline eUnderline, FontUnderline eOverline, bool bWordLine, bool bUnderlineAbove ); -SAL_DLLPRIVATE bool ImplDrawRotateText( SalLayout ); -SAL_DLLPRIVATE bool ImplDrawTextDirect( SalLayout, bool bTextLines, sal_uInt32 flags = 0 ); -SAL_DLLPRIVATE void ImplDrawSpecialText( SalLayout ); -SAL_DLLPRIVATE void ImplDrawText( SalLayout ); -SAL_DLLPRIVATE RectangleImplGetTextBoundRect( const SalLayout ); -SAL_DLLPRIVATE void ImplDrawTextRect( long nBaseX, long nBaseY, long nX, long nY, long nWidth, long nHeight ); -SAL_DLLPRIVATE void ImplInitTextLineSize(); -SAL_DLLPRIVATE void ImplInitAboveTextLineSize(); +voidImplDrawText( SalLayout ); -SAL_DLLPRIVATE void ImplDrawWavePixel( long nOriginX, long nOriginY, long nCurX, long nCurY, short nOrientation, SalGraphics* pGraphics, OutputDevice* pOutDev, - bool bDrawPixAsRect, long nPixWidth, long nPixHeight ); -SAL_DLLPRIVATE void ImplDrawWaveLine( long nBaseX, long nBaseY, long nStartX, long nStartY, long nWidth, long nHeight, long nLineWidth, short nOrientation, const Color rColor ); -SAL_DLLPRIVATE void ImplDrawWaveTextLine( long nBaseX, long nBaseY, long nX, long nY, long nWidth, FontUnderline eTextLine, Color aColor, bool bIsAbove ); -SAL_DLLPRIVATE void ImplDrawStraightTextLine( long nBaseX, long nBaseY, long nX, long nY, long nWidth, FontUnderline eTextLine, Color aColor, bool bIsAbove ); -SAL_DLLPRIVATE void ImplDrawStrikeoutLine( long nBaseX, long nBaseY, long nX, long nY, long nWidth, FontStrikeout eStrikeout, Color aColor ); -SAL_DLLPRIVATE void ImplDrawStrikeoutChar( long nBaseX, long nBaseY, long nX, long nY, long
[Libreoffice-commits] core.git: sw/source
sw/source/ui/chrdlg/drpcps.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d19af82eabb4a356a1d29cd470c48c42952b6a7e Author: Caolán McNamara caol...@redhat.com Date: Sun Apr 27 13:58:10 2014 +0100 surely std::min was the intent Change-Id: Ic643d047e475cc3be0ea7e972c51e17babc1aa1e diff --git a/sw/source/ui/chrdlg/drpcps.cxx b/sw/source/ui/chrdlg/drpcps.cxx index e5b7b99..e35a10b 100644 --- a/sw/source/ui/chrdlg/drpcps.cxx +++ b/sw/source/ui/chrdlg/drpcps.cxx @@ -782,7 +782,7 @@ void SwDropCapsPage::FillSet( SfxItemSet rSet ) if (!m_pWholeWordCB-IsChecked()) { -sText = sText.copy( 0, std::maxsal_Int32( +sText = sText.copy( 0, std::minsal_Int32( sText.getLength(), m_pDropCapsField-GetValue()) ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sc/inc sc/source
sc/inc/tokenarray.hxx |2 + sc/source/core/tool/token.cxx | 46 + sc/source/filter/excel/excform.cxx |4 ++- sc/source/filter/excel/impop.cxx |1 4 files changed, 52 insertions(+), 1 deletion(-) New commits: commit da739f729223908516deb1c2564d0713231abb5b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Fri Apr 25 23:21:22 2014 -0400 fdo#76611: Wrap reference addresses at max boundaries. When importing shared formula tokens. Change-Id: I7e1a05a78c3a93330476516e0459cffb668e3f66 (cherry picked from commit c6c286f14468d341f5fd88edc39a37175a1b6caa) Reviewed-on: https://gerrit.libreoffice.org/9167 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/inc/tokenarray.hxx b/sc/inc/tokenarray.hxx index bc63154..3c7d7e8 100644 --- a/sc/inc/tokenarray.hxx +++ b/sc/inc/tokenarray.hxx @@ -205,6 +205,8 @@ public: */ OUString CreateString( sc::TokenStringContext rCxt, const ScAddress rPos ) const; +void WrapReference( const ScAddress rPos, SCCOL nMaxCol, SCROW nMaxRow ); + #if DEBUG_FORMULA_COMPILER void Dump() const; #endif diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 320c42e..0e0f8fd 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -3752,6 +3752,52 @@ OUString ScTokenArray::CreateString( sc::TokenStringContext rCxt, const ScAddre return aBuf.makeStringAndClear(); } +namespace { + +void wrapAddress( ScAddress rPos, SCCOL nMaxCol, SCROW nMaxRow ) +{ +if (rPos.Col() nMaxCol) +rPos.SetCol(rPos.Col() - nMaxCol - 1); +if (rPos.Row() nMaxRow) +rPos.SetRow(rPos.Row() - nMaxRow - 1); +} + +} + +void ScTokenArray::WrapReference( const ScAddress rPos, SCCOL nMaxCol, SCROW nMaxRow ) +{ +FormulaToken** p = pCode; +FormulaToken** pEnd = p + static_castsize_t(nLen); +for (; p != pEnd; ++p) +{ +switch ((*p)-GetType()) +{ +case svSingleRef: +{ +ScToken* pToken = static_castScToken*(*p); +ScSingleRefData rRef = pToken-GetSingleRef(); +ScAddress aAbs = rRef.toAbs(rPos); +wrapAddress(aAbs, nMaxCol, nMaxRow); +rRef.SetAddress(aAbs, rPos); +} +break; +case svDoubleRef: +{ +ScToken* pToken = static_castScToken*(*p); +ScComplexRefData rRef = pToken-GetDoubleRef(); +ScRange aAbs = rRef.toAbs(rPos); +wrapAddress(aAbs.aStart, nMaxCol, nMaxRow); +wrapAddress(aAbs.aEnd, nMaxCol, nMaxRow); +aAbs.PutInOrder(); +rRef.SetRange(aAbs, rPos); +} +break; +default: +; +} +} +} + #if DEBUG_FORMULA_COMPILER void ScTokenArray::Dump() const { diff --git a/sc/source/filter/excel/excform.cxx b/sc/source/filter/excel/excform.cxx index 1f1336e..b609e28 100644 --- a/sc/source/filter/excel/excform.cxx +++ b/sc/source/filter/excel/excform.cxx @@ -128,7 +128,8 @@ void ImportExcel::Formula( const ScTokenArray* pSharedCode = pFormConv-GetSharedFormula(aRefPos); if (pSharedCode) { -ScFormulaCell* pCell = new ScFormulaCell(pD, aScPos, *pSharedCode); +ScFormulaCell* pCell = new ScFormulaCell(pD, aScPos, pSharedCode-Clone()); +pCell-GetCode()-WrapReference(aScPos, EXC_MAXCOL8, EXC_MAXROW8); rDoc.getDoc().EnsureTable(aScPos.Tab()); rDoc.setFormulaCell(aScPos, pCell); pCell-SetNeedNumberFormat(false); @@ -156,6 +157,7 @@ void ImportExcel::Formula( if (pResult) { pCell = new ScFormulaCell(rDoc.getDoc(), aScPos, *pResult); +pCell-GetCode()-WrapReference(aScPos, EXC_MAXCOL8, EXC_MAXROW8); rDoc.getDoc().EnsureTable(aScPos.Tab()); rDoc.setFormulaCell(aScPos, pCell); SetLastFormula(aScPos.Col(), aScPos.Row(), fCurVal, nXF, pCell); diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx index 913d1ba..312da25 100644 --- a/sc/source/filter/excel/impop.cxx +++ b/sc/source/filter/excel/impop.cxx @@ -882,6 +882,7 @@ void ImportExcel::Shrfmla( void ) ScDocumentImport rDoc = GetDocImport(); ScFormulaCell* pCell = new ScFormulaCell(pD, aPos, *pErgebnis); +pCell-GetCode()-WrapReference(aPos, EXC_MAXCOL8, EXC_MAXROW8); rDoc.getDoc().EnsureTable(aPos.Tab()); rDoc.setFormulaCell(aPos, pCell); pCell-SetNeedNumberFormat(false); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: oox/source
oox/source/drawingml/customshapeproperties.cxx | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) New commits: commit c764a3d978beb2e6197a8d3f7df53d81ebf72467 Author: Armin Le Grand a...@apache.org Date: Fri Apr 25 12:56:19 2014 + Resolves: #i124703# adapt coordinate range from ms relative... control points to our relative control points (cherry picked from commit 8625253da753153838554fef459ae603ca8d3ecc) Conflicts: oox/source/drawingml/customshapeproperties.cxx Change-Id: I356a44fdbdcc22630811467e706bcb60c41dbc2c diff --git a/oox/source/drawingml/customshapeproperties.cxx b/oox/source/drawingml/customshapeproperties.cxx index 276d5bb..0496dc3 100644 --- a/oox/source/drawingml/customshapeproperties.cxx +++ b/oox/source/drawingml/customshapeproperties.cxx @@ -30,6 +30,7 @@ #include com/sun/star/drawing/XShape.hpp #include com/sun/star/drawing/XEnhancedCustomShapeDefaulter.hpp #include com/sun/star/drawing/EnhancedCustomShapeTextFrame.hpp +#include basegfx/numeric/ftools.hxx using namespace ::oox::core; using namespace ::com::sun::star; @@ -185,7 +186,15 @@ void CustomShapeProperties::pushToPropSet( const ::oox::core::FilterBase /* rFi } } else if ( aAdjustmentSeq.getLength() 0 ) { EnhancedCustomShapeAdjustmentValue aAdjustmentVal; -aAdjustmentVal.Value = (*aIter).maFormula.toInt32(); + +sal_Int32 nValue((*aIter).maFormula.toInt32()); + +// #i124703# The ms control point coordinates are relative to the +// object center in the range [-5 .. 5] while our customshapes +// use a range from [0 .. 21600], so adapt the value as needed +nValue = basegfx::fround((double(nValue) + 5.0) * (21600.0 / 10.0)); + +aAdjustmentVal.Value = nValue; aAdjustmentVal.State = PropertyState_DIRECT_VALUE; aAdjustmentVal.Name = (*aIter).maName; aAdjustmentSeq[ nIndex++ ] = aAdjustmentVal; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 86/25253da753153838554fef459ae603ca8d3ecc
86/25253da753153838554fef459ae603ca8d3ecc |1 + 1 file changed, 1 insertion(+) New commits: commit c42b2a3c22ea95ebf2f2c5ad05458cc10f38a2fe Author: Caolán McNamara caol...@redhat.com Date: Sun Apr 27 14:05:12 2014 +0100 Notes added by 'git notes add' diff --git a/86/25253da753153838554fef459ae603ca8d3ecc b/86/25253da753153838554fef459ae603ca8d3ecc new file mode 100644 index 000..bd8cea5 --- /dev/null +++ b/86/25253da753153838554fef459ae603ca8d3ecc @@ -0,0 +1 @@ +merged as: c764a3d978beb2e6197a8d3f7df53d81ebf72467 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 34/243aa8c03a913b97465433a95a22513625b5a4
34/243aa8c03a913b97465433a95a22513625b5a4 |1 + 1 file changed, 1 insertion(+) New commits: commit 1b9e3427eec15a7ce552a479f4308841ebb8e02b Author: Caolán McNamara caol...@redhat.com Date: Sun Apr 27 14:24:52 2014 +0100 Notes added by 'git notes add' diff --git a/34/243aa8c03a913b97465433a95a22513625b5a4 b/34/243aa8c03a913b97465433a95a22513625b5a4 new file mode 100644 index 000..ed097ce --- /dev/null +++ b/34/243aa8c03a913b97465433a95a22513625b5a4 @@ -0,0 +1 @@ +prefer: 2155c4c0af4d4eb228a0644f423aa3d9b5e8a2fb ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 76611, which changed state. Bug 76611 Summary: FILEOPEN: Error formula on .XLS file https://bugs.freedesktop.org/show_bug.cgi?id=76611 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [libreoffice-projects] [ANN] LIbreOffice 4.1.6 RC2 available
On 25/04/14 01:41, Christian Lohmaier wrote: The Document Foundation is pleased to announce the second release candidate of LibreOffice 4.1.6. The upcoming 4.1.6 will be the sixth and final in a sequence of frequent bugfix releases for our feature-packed 4.1 line. Feel free to give it a try instead of 4.1.5. Do you think it will be possible to release on Tuesday at 1:00PM CEST? Given that Thursday is a holiday in several countries, I would prefer to avoid Wednesday, unless we announce early in the morning, say at 9:00AM CEST. -- Italo Vignoli - italo.vign...@gmail.com mob IT +39.348.5653829 - mob EU +39.392.7481795 sip it...@libreoffice.org - skype italovignoli GPG Key ID - 0xAAB8D5C0 DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/table1.cxx |5 ++--- sc/source/core/tool/chgtrack.cxx | 12 +--- sc/source/core/tool/interpr4.cxx |8 sc/source/filter/dif/difimp.cxx |8 +++- 4 files changed, 14 insertions(+), 19 deletions(-) New commits: commit f2e546efd96b5a8b7c0b339cf2673a9b1996190b Author: Takeshi Abe t...@fixedpoint.jp Date: Sun Apr 27 22:45:29 2014 +0900 Avoid possible memory leaks in case of exceptions Change-Id: Ifd4c87bf038b421a0468edb599eca030c78bad89 diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx index 77de5a8..4827541 100644 --- a/sc/source/core/data/table1.cxx +++ b/sc/source/core/data/table1.cxx @@ -53,6 +53,7 @@ #include formula/vectortoken.hxx #include vector +#include boost/scoped_array.hpp using ::std::vector; @@ -1299,7 +1300,7 @@ void ScTable::GetNextPos( SCCOL rCol, SCROW rRow, SCsCOL nMovX, SCsROW nMovY, if ( !ValidNextPos(nCol, nRow, rMark, bMarked, bUnprotected) ) { -SCsROW* pNextRows = new SCsROW[MAXCOL+1]; +boost::scoped_arraySCsROW pNextRows(new SCsROW[MAXCOL+1]); SCCOL i; if ( nMovX 0 )// vorwaerts @@ -1368,8 +1369,6 @@ void ScTable::GetNextPos( SCCOL rCol, SCROW rRow, SCsCOL nMovX, SCsROW nMovY, } while ( !ValidNextPos(nCol, nRow, rMark, bMarked, bUnprotected) ); } - -delete[] pNextRows; } } diff --git a/sc/source/core/tool/chgtrack.cxx b/sc/source/core/tool/chgtrack.cxx index df37e22..3b5a0b4 100644 --- a/sc/source/core/tool/chgtrack.cxx +++ b/sc/source/core/tool/chgtrack.cxx @@ -43,6 +43,7 @@ #include sfx2/app.hxx #include unotools/useroptions.hxx #include sfx2/sfxsids.hrc +#include boost/scoped_ptr.hpp IMPL_FIXEDMEMPOOL_NEWDEL( ScChangeActionCellListEntry ) IMPL_FIXEDMEMPOOL_NEWDEL( ScChangeActionLinkEntry ) @@ -1822,9 +1823,8 @@ void ScChangeActionContent::GetFormulaString( else { OSL_FAIL( ScChangeActionContent::GetFormulaString: aPos != pCell-aPos ); -ScFormulaCell* pNew = new ScFormulaCell( *pCell, *pCell-GetDocument(), aPos ); +boost::scoped_ptrScFormulaCell pNew(new ScFormulaCell( *pCell, *pCell-GetDocument(), aPos )); pNew-GetFormula( rStr ); -delete pNew; } } @@ -4188,15 +4188,13 @@ bool ScChangeTrack::Reject( ScChangeAction* pAct, bool bShared ) if ( !pAct-IsRejectable() ) return false; -ScChangeActionMap* pMap = NULL; +boost::scoped_ptrScChangeActionMap pMap; if ( pAct-HasDependent() ) { -pMap = new ScChangeActionMap; +pMap.reset(new ScChangeActionMap); GetDependents( pAct, *pMap, false, true ); } -bool bRejected = Reject( pAct, pMap, false ); -if ( pMap ) -delete pMap; +bool bRejected = Reject( pAct, pMap.get(), false ); return bRejected; } diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx index 1a3294d..83197fd 100644 --- a/sc/source/core/tool/interpr4.cxx +++ b/sc/source/core/tool/interpr4.cxx @@ -72,6 +72,7 @@ #include basic/basmgr.hxx #include vbahelper/vbaaccesshelper.hxx #include memory +#include boost/scoped_array.hpp using namespace com::sun::star; using namespace formula; @@ -2635,12 +2636,11 @@ void ScInterpreter::ScExternal() break; case PTR_STRING : { -sal_Char* pcErg = new sal_Char[ADDIN_MAXSTRLEN]; -ppParam[0] = pcErg; +boost::scoped_arraysal_Char pcErg(new sal_Char[ADDIN_MAXSTRLEN]); +ppParam[0] = pcErg.get(); pFuncData-Call(ppParam); -OUString aUni( pcErg, strlen(pcErg), osl_getThreadTextEncoding() ); +OUString aUni( pcErg.get(), strlen(pcErg.get()), osl_getThreadTextEncoding() ); PushString( aUni ); -delete[] pcErg; } break; default: diff --git a/sc/source/filter/dif/difimp.cxx b/sc/source/filter/dif/difimp.cxx index 87c3fb0..1ec7e80 100644 --- a/sc/source/filter/dif/difimp.cxx +++ b/sc/source/filter/dif/difimp.cxx @@ -32,6 +32,7 @@ #include scerrors.hxx #include scitems.hxx #include stringutil.hxx +#include boost/scoped_ptr.hpp const sal_Unicode pKeyTABLE[] = { 'T', 'A', 'B', 'L', 'E', 0 }; const sal_Unicode pKeyVECTORS[] = { 'V', 'E', 'C', 'T', 'O', 'R', 'S', 0 }; @@ -951,7 +952,7 @@ void DifAttrCache::Apply( ScDocument rDoc, SCTAB nTab ) { if( bPlain ) { -ScPatternAttr* pPatt = NULL; +boost::scoped_ptrScPatternAttr pPatt; for( SCCOL nCol = 0 ; nCol = MAXCOL ; nCol++ ) { @@ -959,7 +960,7 @@ void DifAttrCache::Apply( ScDocument rDoc,
[Libreoffice-commits] core.git: 2 commits - cui/source include/vcl svtools/source svx/source vcl/source
cui/source/options/optgdlg.cxx|2 include/vcl/outdev.hxx|6 svtools/source/config/optionsdrawinglayer.cxx |2 svx/source/sdr/overlay/overlayselection.cxx |2 vcl/source/outdev/bitmap.cxx | 362 -- vcl/source/outdev/outdev.cxx |2 vcl/source/outdev/polyline.cxx| 10 7 files changed, 192 insertions(+), 194 deletions(-) New commits: commit e474c95cdec503bc2abb90619a7a3677d2942a63 Author: Chris Sherlock chris.sherloc...@gmail.com Date: Mon Apr 28 00:10:47 2014 +1000 VCL: Renamed two functions Renamed functions: + supportsOperation - SupportsOperation For consistency + DrawAlphaBitmap - DrawDeviceAlphaBitmap I want to make it more clear that these are the functions that call on mpGraphics to actually draw on the graphics device Change-Id: Ic4951bfcc0ac0c09fe5b6908dfdf1f699a634265 diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx index db279d0..7d6e2c2 100644 --- a/cui/source/options/optgdlg.cxx +++ b/cui/source/options/optgdlg.cxx @@ -935,7 +935,7 @@ void OfaViewTabPage::Reset( const SfxItemSet ) // check if transparent selection is possible on this system const bool bTransparentSelectionPossible( !GetSettings().GetStyleSettings().GetHighContrastMode() - supportsOperation(OutDevSupport_TransparentRect)); + SupportsOperation(OutDevSupport_TransparentRect)); // enter values if(bTransparentSelectionPossible) diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx index 28af364..a22d407 100644 --- a/include/vcl/outdev.hxx +++ b/include/vcl/outdev.hxx @@ -470,7 +470,7 @@ public: @returns true if operation supported, else false */ -boolsupportsOperation( OutDevSupportType ) const; +boolSupportsOperation( OutDevSupportType ) const; vcl::PDFWriterImpl* GetPDFWriter() const { return mpPDFWriter; } @@ -734,7 +734,7 @@ private: // #i101491# // Helper who tries to use SalGDI's DrawPolyLine direct and returns it's bool. Contains no AA check. -SAL_DLLPRIVATE bool TryDrawPolyLineDirectNoAA( +SAL_DLLPRIVATE bool TryDrawPolyLineDirectNoAACheck( const basegfx::B2DPolygon rB2DPolygon, double fLineWidth = 0.0, double fTransparency = 0.0, @@ -1342,7 +1342,7 @@ protected: private: -SAL_DLLPRIVATE void DrawAlphaBitmap( +SAL_DLLPRIVATE void DrawDeviceAlphaBitmap( const Bitmap rBmp, const AlphaMask rAlpha, const Point rDestPt, diff --git a/svtools/source/config/optionsdrawinglayer.cxx b/svtools/source/config/optionsdrawinglayer.cxx index b977c72..d0cc92b 100644 --- a/svtools/source/config/optionsdrawinglayer.cxx +++ b/svtools/source/config/optionsdrawinglayer.cxx @@ -809,7 +809,7 @@ bool SvtOptionsDrawinglayer_Impl::IsAAPossibleOnThisSystem() const #endif // check XRenderExtension -if(m_bAllowAA !Application::GetDefaultDevice()-supportsOperation( OutDevSupport_TransparentRect )) +if(m_bAllowAA !Application::GetDefaultDevice()-SupportsOperation( OutDevSupport_TransparentRect )) { pThat-m_bAllowAA = false; } diff --git a/svx/source/sdr/overlay/overlayselection.cxx b/svx/source/sdr/overlay/overlayselection.cxx index e5de597..f230ff8 100644 --- a/svx/source/sdr/overlay/overlayselection.cxx +++ b/svx/source/sdr/overlay/overlayselection.cxx @@ -82,7 +82,7 @@ namespace sdr return OVERLAY_INVERT; } -if(!pOut-supportsOperation(OutDevSupport_TransparentRect)) +if(!pOut-SupportsOperation(OutDevSupport_TransparentRect)) { // not possible when no fast transparence paint is supported on the system return OVERLAY_INVERT; diff --git a/vcl/source/outdev/bitmap.cxx b/vcl/source/outdev/bitmap.cxx index 2809f0c..46d58da 100644 --- a/vcl/source/outdev/bitmap.cxx +++ b/vcl/source/outdev/bitmap.cxx @@ -486,8 +486,6 @@ BitmapEx OutputDevice::GetBitmapEx( const Point rSrcPt, const Size rSize ) con return GetBitmap( rSrcPt, rSize ); } - - void OutputDevice::DrawDeviceBitmap( const Point rDestPt, const Size rDestSize, const Point rSrcPtPixel, const Size rSrcSizePixel, BitmapEx rBmpEx ) @@ -512,7 +510,7 @@ void OutputDevice::DrawDeviceBitmap( const Point rDestPt, const Size rDestSize aSrcPtPixel.X() = rSrcPtPixel.X() * fScaleX;
[Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.freedesktop.org/show_bug.cgi?id=67465 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=67464 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - svx/source writerfilter/source
svx/source/sdr/primitive2d/sdrattributecreator.cxx | 27 ++- writerfilter/source/dmapper/TablePositionHandler.cxx |4 ++ 2 files changed, 23 insertions(+), 8 deletions(-) New commits: commit 313b59d787357ef3da34e2833fefcf1143b09b5e Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Apr 27 17:48:46 2014 +0200 fix transparency of floating tables in docx import (fdo#77723) Normal tables do not have any fill background on their own, i.e. it's possible to see e.g. an image in the background, so if we put a table inside a frame in order to make it floating, make the frame transparent in order to achieve the same result. Change-Id: I77b1c8f847af5355c4238bfa089d760dd6121a69 diff --git a/writerfilter/source/dmapper/TablePositionHandler.cxx b/writerfilter/source/dmapper/TablePositionHandler.cxx index 6909f71..ca20875 100644 --- a/writerfilter/source/dmapper/TablePositionHandler.cxx +++ b/writerfilter/source/dmapper/TablePositionHandler.cxx @@ -93,7 +93,7 @@ void TablePositionHandler::lcl_sprm(Sprm /*rSprm*/) uno::Sequencebeans::PropertyValue TablePositionHandler::getTablePosition() const { -uno::Sequence beans::PropertyValue aFrameProperties(18); +uno::Sequence beans::PropertyValue aFrameProperties(19); beans::PropertyValue* pFrameProperties = aFrameProperties.getArray(); pFrameProperties[0].Name = LeftBorderDistance; @@ -178,6 +178,8 @@ uno::Sequencebeans::PropertyValue TablePositionHandler::getTablePosition() con pFrameProperties[16].Value = nVertOrientRelation; pFrameProperties[17].Name = VertOrientPosition; pFrameProperties[17].Value = ConversionHelper::convertTwipToMM100(m_nY); +pFrameProperties[18].Name = FillTransparence; +pFrameProperties[18].Value = sal_Int32(100); return aFrameProperties; } commit a55dac47b386cd5485ba1d828316e7695c34769b Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Apr 27 17:33:07 2014 +0200 fix drawing of 100% transparent frames (fdo#77723) Without this, the 100% transparent frame is actually drawn opaque. Change-Id: Ibaaeead7fe2379d48ea9680719a082e322b7b0c9 diff --git a/svx/source/sdr/primitive2d/sdrattributecreator.cxx b/svx/source/sdr/primitive2d/sdrattributecreator.cxx index ea4bbb9..4726d06 100644 --- a/svx/source/sdr/primitive2d/sdrattributecreator.cxx +++ b/svx/source/sdr/primitive2d/sdrattributecreator.cxx @@ -383,15 +383,15 @@ namespace drawinglayer { const XFillStyle eStyle(((XFillStyleItem)(rSet.Get(XATTR_FILLSTYLE))).GetValue()); -if(XFILL_NONE != eStyle) -{ -sal_uInt16 nTransparence(((const XFillTransparenceItem)(rSet.Get(XATTR_FILLTRANSPARENCE))).GetValue()); +sal_uInt16 nTransparence(((const XFillTransparenceItem)(rSet.Get(XATTR_FILLTRANSPARENCE))).GetValue()); -if(nTransparence 100) -{ -nTransparence = 100; -} +if(nTransparence 100) +{ +nTransparence = 100; +} +if(XFILL_NONE != eStyle) +{ if(100 != nTransparence) { // need to check XFillFloatTransparence, object fill may still be completely transparent @@ -494,6 +494,19 @@ namespace drawinglayer } } +if(nTransparence == 100) +{ +attribute::FillGradientAttribute aGradient; +attribute::FillHatchAttribute aHatch; +attribute::SdrFillGraphicAttribute aFillGraphic; +return attribute::SdrFillAttribute( +1, +basegfx::BColor( 0, 0, 0 ), +aGradient, +aHatch, +aFillGraphic); +} + return attribute::SdrFillAttribute(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Depends on||64161 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sw/source vcl/source
sw/source/filter/xml/xmltble.cxx|2 -- vcl/source/opengl/OpenGLContext.cxx |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 62219707ff063ce4d4679a3614a551b2854ffcfd Author: Tor Lillqvist t...@collabora.com Date: Sun Apr 27 19:26:26 2014 +0300 WaE: unused variable 'sBuffer' Change-Id: I245998bec7981cecec27d377c44f22a71ef0330e diff --git a/sw/source/filter/xml/xmltble.cxx b/sw/source/filter/xml/xmltble.cxx index d5d935e..d7825e5 100644 --- a/sw/source/filter/xml/xmltble.cxx +++ b/sw/source/filter/xml/xmltble.cxx @@ -546,8 +546,6 @@ void SwXMLExport::ExportTableLinesAutoStyles( const SwTableLines rLines, pTableLines-push_back( pLines ); -OUStringBuffer sBuffer( rNamePrefix.getLength() + 8L ); - // pass 2: export column styles { const SwXMLTableColumns_Impl rCols = pLines-GetColumns(); commit fb57e17251b819a2339e6a10a9a272f6125d1873 Author: Tor Lillqvist t...@collabora.com Date: Sun Apr 27 18:57:50 2014 +0300 WaE: implicit conversion of literal of type 'sal_Bool' to 'bool' Change-Id: I259f3a192097fed449bbea28a18febccfd93db04 diff --git a/vcl/source/opengl/OpenGLContext.cxx b/vcl/source/opengl/OpenGLContext.cxx index 4daae1c..b8c963b 100644 --- a/vcl/source/opengl/OpenGLContext.cxx +++ b/vcl/source/opengl/OpenGLContext.cxx @@ -603,7 +603,7 @@ bool OpenGLContext::initWindow() { if( !m_pChildWindow ) { -m_pChildWindow = new SystemChildWindow(mpWindow, 0, winData, sal_False); +m_pChildWindow = new SystemChildWindow(mpWindow, 0, winData, false); m_pChildWindowGC.reset(m_pChildWindow); } pChildSysData = m_pChildWindow-GetSystemData(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: nlpsolver/src
nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit dfbaef22fcc66f86ecdfccb82037fbfd171c975d Author: Alex Gulyás gulyas.a...@gmail.com Date: Sun Apr 27 18:06:15 2014 +0200 fdo#78004 fix string formatting Added missing 's' Change-Id: I7570d86d65ebcffc547b06ab9c19843de0b90436 Reviewed-on: https://gerrit.libreoffice.org/9181 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java index 60bdcf9..8561763 100644 --- a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java +++ b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java @@ -553,7 +553,7 @@ public abstract class BaseNLPSolver extends WeakBase if (days 0) return String.format(%d %s, %d %s, - days, resourceManager.getLocalizedString(String.format(Time.Day%, days == 1 ? : s), Days), + days, resourceManager.getLocalizedString(String.format(Time.Day%s, days == 1 ? : s), Days), hours, resourceManager.getLocalizedString(String.format(Time.Hour%s, hours == 1 ? : s), Hours)); if (hours 0) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Alex Gulyás license statement
All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ImageMagick convert -- a required bundle to handle EPS on Windows and OSX?
So, poking around on this in Bugzilla and OpenGrok, seems there is no native handling of EPS in LibreOffice, and the filters (input output) are a mess. There has been a call for built-in EPS rendering as fdo#67464 https://bugs.freedesktop.org/show_bug.cgi?id=67464 as an enhancement. Unfortunately for Windows use, until such an enhancement is implemented, there are three helper programs that ieps.cxx can call on Windows. GhostScript -- gswin32c.exe ( http://www.ghostscript.com/download/gsdnld.html ) ImageMagick -- convert.exe ( http://www.imagemagick.org/script/binary-releases.php#windows ) pstoedit -- pstoedit.exe ( http://sourceforge.net/projects/pstoedit/files/pstoedit/ ) The pstoedit command is used for the RenderAsEMF calls, and either gswin32c or convert is used for conversion to bitmaps with the RenderAsBMP calls--not clear to me which is used where in the import and to make previews. So the question becomes which of these should be installed, and are there any best metohds for doing so? And also what documentation/guidance on their use in LibreOffice (or AOO or legacy OOo) is available? -- View this message in context: http://nabble.documentfoundation.org/ImageMagick-convert-a-required-bundle-to-handle-EPS-on-Windows-and-OSX-tp4106546p4106652.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - sd/source
sd/source/ui/view/sdview3.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 5d870f0474d43d6bbcaabda6ac3912c2ae2bbe28 Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Apr 27 12:55:32 2014 +0200 do not crash when pasting impress page into another impress page (cp#167) Put an Impress page into clipboard, create new document, click 'Click to add title', paste - crash. Introduced by 5aee0c13cc62a81a38d4132db7972dc301c21b3d. Change-Id: Ibe61a780244ce98205e5ae3964971d7d75e30870 (cherry picked from commit dffcd67a9a9865c9eca9756eea4e85445b50a15e) diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx index f0f21cf..0aecf6a 100644 --- a/sd/source/ui/view/sdview3.cxx +++ b/sd/source/ui/view/sdview3.cxx @@ -360,6 +360,7 @@ sal_Bool View::InsertData( const TransferableDataHelper rDataHelper, if( pOwnData-GetDocShell() pOwnData-IsPageTransferable() ISA( View ) ) { mpClipboard-HandlePageDrop (*pOwnData); +bReturn = true; } else if( pSourceView ) { @@ -1346,6 +1347,7 @@ sal_Bool View::InsertData( const TransferableDataHelper rDataHelper, // add text color pPickObj-SetMergedItemSetAndBroadcast( aSet ); } +bReturn = true; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - sd/source
sd/source/ui/view/sdview3.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit ff33ba96929cc4591f04e0963aa8c630d989e8bd Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Sun Apr 27 12:55:32 2014 +0200 do not crash when pasting impress page into another impress page (cp#167) Put an Impress page into clipboard, create new document, click 'Click to add title', paste - crash. Introduced by 5aee0c13cc62a81a38d4132db7972dc301c21b3d. Change-Id: Ibe61a780244ce98205e5ae3964971d7d75e30870 (cherry picked from commit dffcd67a9a9865c9eca9756eea4e85445b50a15e) Reviewed-on: https://gerrit.libreoffice.org/9178 Reviewed-by: Andras Timar andras.ti...@collabora.com Tested-by: Andras Timar andras.ti...@collabora.com diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx index f0f21cf..0aecf6a 100644 --- a/sd/source/ui/view/sdview3.cxx +++ b/sd/source/ui/view/sdview3.cxx @@ -360,6 +360,7 @@ sal_Bool View::InsertData( const TransferableDataHelper rDataHelper, if( pOwnData-GetDocShell() pOwnData-IsPageTransferable() ISA( View ) ) { mpClipboard-HandlePageDrop (*pOwnData); +bReturn = true; } else if( pSourceView ) { @@ -1346,6 +1347,7 @@ sal_Bool View::InsertData( const TransferableDataHelper rDataHelper, // add text color pPickObj-SetMergedItemSetAndBroadcast( aSet ); } +bReturn = true; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - vcl/source
vcl/source/filter/wmf/winmtf.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit db477faebd75ed31416cc642a6a1de30227cac29 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Tue Apr 22 12:06:11 2014 +0200 wmf: support fat lines for PolyPolygons in wmf filter Change-Id: I9fe9d7b5237031e3001f64af7001d91fa53f1c64 diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx index 5074a5d..97eed0c 100644 --- a/vcl/source/filter/wmf/winmtf.cxx +++ b/vcl/source/filter/wmf/winmtf.cxx @@ -1316,6 +1316,13 @@ void WinMtfOutput::DrawPolyPolygon( PolyPolygon rPolyPolygon, sal_Bool bRecordP { UpdateLineStyle(); mpGDIMetaFile-AddAction( new MetaPolyPolygonAction( rPolyPolygon ) ); +if (maLineStyle.aLineInfo.GetWidth() 0 || maLineStyle.aLineInfo.GetStyle() == LINE_DASH) +{ +for (sal_uInt16 nPoly = 0; nPoly rPolyPolygon.Count(); ++nPoly) +{ +mpGDIMetaFile-AddAction(new MetaPolyLineAction(rPolyPolygon[nPoly], maLineStyle.aLineInfo)); +} +} } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - vcl/source
vcl/source/gdi/outdev.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ce9161733a8ef433d060b87a24ce566d20365679 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Thu Apr 24 17:57:09 2014 +0200 fdo#74336 wrongly transformed line width - use 0 for height Change-Id: I3915cfabb9568480d74ea6d4e459def6fe912eb9 diff --git a/vcl/source/gdi/outdev.cxx b/vcl/source/gdi/outdev.cxx index f8ec872..069fea1 100644 --- a/vcl/source/gdi/outdev.cxx +++ b/vcl/source/gdi/outdev.cxx @@ -2159,7 +2159,7 @@ bool OutputDevice::ImpTryDrawPolyLineDirect( // transform the line width if used if( fLineWidth != 0.0 ) { -aB2DLineWidth = aTransform * ::basegfx::B2DVector( fLineWidth, fLineWidth ); +aB2DLineWidth = aTransform * ::basegfx::B2DVector( fLineWidth, 0.0 ); } // transform the polygon ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - include/oox oox/source
include/oox/helper/graphichelper.hxx |4 +++- oox/source/drawingml/shape.cxx | 10 +- oox/source/helper/graphichelper.cxx |4 ++-- oox/source/vml/vmlshape.cxx | 10 -- 4 files changed, 22 insertions(+), 6 deletions(-) New commits: commit 9c1da7aa94e2f647570db72b52065525fd699d78 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Thu Apr 24 18:39:27 2014 +0200 fdo#77089 pass shape dimensions to graphicfilter for WMF Conflicts: oox/source/vml/vmlshape.cxx Change-Id: I673a76ef85038b1f304ea85faeed5b4a462cb144 diff --git a/include/oox/helper/graphichelper.hxx b/include/oox/helper/graphichelper.hxx index b96e993..d72daa9 100644 --- a/include/oox/helper/graphichelper.hxx +++ b/include/oox/helper/graphichelper.hxx @@ -115,7 +115,9 @@ public: /** Imports a graphic from the storage stream with the passed path and name. */ ::com::sun::star::uno::Reference ::com::sun::star::graphic::XGraphic -importEmbeddedGraphic( const OUString rStreamName ) const; +importEmbeddedGraphic( +const OUString rStreamName, +const WMF_EXTERNALHEADER* pExtHeader = NULL ) const; /** Creates a persistent graphic object from the passed graphic. @return The URL of the created and internally cached graphic object. */ diff --git a/oox/source/drawingml/shape.cxx b/oox/source/drawingml/shape.cxx index 54db7bb..8b250b1 100644 --- a/oox/source/drawingml/shape.cxx +++ b/oox/source/drawingml/shape.cxx @@ -67,6 +67,8 @@ #include vcl/graphicfilter.hxx #include vcl/svapp.hxx +#include vcl/wmf.hxx + using namespace ::oox::core; using namespace ::com::sun::star; using namespace ::com::sun::star::uno; @@ -822,7 +824,13 @@ OUString Shape::finalizeServiceName( XmlFilterBase rFilter, const OUString rSe // import and store the graphic if( !aGraphicPath.isEmpty() ) { -Reference graphic::XGraphic xGraphic = rFilter.getGraphicHelper().importEmbeddedGraphic( aGraphicPath ); +// Transfer shape's width and heightto graphicsfilter (can be used by WMF/EMF) +WMF_EXTERNALHEADER aExtHeader; +aExtHeader.mapMode = 8; // MM_ANISOTROPIC +aExtHeader.xExt = rShapeRect.Width; +aExtHeader.yExt = rShapeRect.Height; + +Reference graphic::XGraphic xGraphic = rFilter.getGraphicHelper().importEmbeddedGraphic( aGraphicPath, aExtHeader ); if( xGraphic.is() ) maShapeProperties[ PROP_Graphic ] = xGraphic; } diff --git a/oox/source/helper/graphichelper.cxx b/oox/source/helper/graphichelper.cxx index 5cb2b69..7594096 100644 --- a/oox/source/helper/graphichelper.cxx +++ b/oox/source/helper/graphichelper.cxx @@ -275,7 +275,7 @@ Reference XGraphic GraphicHelper::importGraphic( const StreamDataSequence rG return xGraphic; } -Reference XGraphic GraphicHelper::importEmbeddedGraphic( const OUString rStreamName ) const +Reference XGraphic GraphicHelper::importEmbeddedGraphic( const OUString rStreamName, const WMF_EXTERNALHEADER* pExtHeader ) const { Reference XGraphic xGraphic; OSL_ENSURE( !rStreamName.isEmpty(), GraphicHelper::importEmbeddedGraphic - empty stream name ); @@ -284,7 +284,7 @@ Reference XGraphic GraphicHelper::importEmbeddedGraphic( const OUString rStr EmbeddedGraphicMap::const_iterator aIt = maEmbeddedGraphics.find( rStreamName ); if( aIt == maEmbeddedGraphics.end() ) { -xGraphic = importGraphic( mxStorage-openInputStream( rStreamName ) ); +xGraphic = importGraphic(mxStorage-openInputStream(rStreamName), pExtHeader); if( xGraphic.is() ) maEmbeddedGraphics[ rStreamName ] = xGraphic; } diff --git a/oox/source/vml/vmlshape.cxx b/oox/source/vml/vmlshape.cxx index 7b8c9eb..7879315 100644 --- a/oox/source/vml/vmlshape.cxx +++ b/oox/source/vml/vmlshape.cxx @@ -21,6 +21,7 @@ #include boost/optional.hpp #include oox/vml/vmlshape.hxx +#include vcl/wmf.hxx #include com/sun/star/beans/PropertyValues.hpp #include com/sun/star/beans/XPropertySet.hpp @@ -963,8 +964,13 @@ Reference XShape ComplexShape::implConvertAndInsert( const Reference XShapes // set the replacement graphic if( !aGraphicPath.isEmpty() ) { -Reference XGraphic xGraphic = rFilter.getGraphicHelper().importEmbeddedGraphic( aGraphicPath ); -if( xGraphic.is() ) +WMF_EXTERNALHEADER aExtHeader; +aExtHeader.mapMode = 8; +aExtHeader.xExt = rShapeRect.Width; +aExtHeader.yExt = rShapeRect.Height; + +Reference XGraphic xGraphic =
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 2 commits - vcl/source
vcl/source/filter/wmf/winmtf.cxx | 17 +++-- vcl/source/filter/wmf/winwmf.cxx | 37 - 2 files changed, 31 insertions(+), 23 deletions(-) New commits: commit d0855e3a4d874b76b64d219ba2737901621bda6a Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Thu Apr 24 18:46:48 2014 +0200 fdo#77089 if available, use ext. dimensions for non-placable WMF Change-Id: Idcfaa127ed6abed40d6eec7f81fbbfb36658cc91 diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx index d323d0f..a9a85c5 100644 --- a/vcl/source/filter/wmf/winwmf.cxx +++ b/vcl/source/filter/wmf/winwmf.cxx @@ -1132,19 +1132,22 @@ sal_Bool WMFReader::ReadHeader() else { nUnitsPerInch = 96; -pWMF-Seek( nStrmPos + 18 );// set the streampos to the start of the metaactions -GetPlaceableBound( aPlaceableBound, pWMF ); -pWMF-Seek( nStrmPos ); -if ( pExternalHeader != NULL ( pExternalHeader-mapMode == MM_ISOTROPIC -|| pExternalHeader-mapMode == MM_ANISOTROPIC ) ) +if ( pExternalHeader != NULL ( pExternalHeader-mapMode == MM_ISOTROPIC || pExternalHeader-mapMode == MM_ANISOTROPIC ) ) { // #n417818#: If we have an external header then overwrite the bounds! Rectangle aExtRect(0, 0, - pExternalHeader-xExt*567*nUnitsPerInch/1440/1000, - pExternalHeader-yExt*567*nUnitsPerInch/1440/1000); -GetWinExtMax( aExtRect, aPlaceableBound, pExternalHeader-mapMode ); + (double) pExternalHeader-xExt * 567 * nUnitsPerInch / 144, + (double) pExternalHeader-yExt * 567 * nUnitsPerInch / 144); +aPlaceableBound = aExtRect; pOut-SetMapMode( pExternalHeader-mapMode ); } +else +{ +pWMF-Seek( nStrmPos + 18 );// set the streampos to the start of the metaactions +GetPlaceableBound( aPlaceableBound, pWMF ); +} + +pWMF-Seek( nStrmPos ); } pOut-SetWinOrg( aPlaceableBound.TopLeft() ); @@ -1357,6 +1360,22 @@ sal_Bool WMFReader::GetPlaceableBound( Rectangle rPlaceableBound, SvStream* pSt } break; +case W_META_SETVIEWPORTORG: +{ +Point aWinOrg; +aWinOrg = ReadYX(); +rPlaceableBound.SetPos( aWinOrg ); +} +break; + +case W_META_SETVIEWPORTEXT: +{ +sal_Int16 nWidth(0), nHeight(0); +*pStm nHeight nWidth; +rPlaceableBound.SetSize( Size( nWidth, nHeight ) ); +} +break; + case W_META_SETMAPMODE : *pStm nMapMode; break; @@ -1414,7 +1433,7 @@ sal_Bool WMFReader::GetPlaceableBound( Rectangle rPlaceableBound, SvStream* pSt SAL_WARN_IF(!bRecordOk, vcl.filter, polypolygon record has more polygons than we can handle); -bRecordOk = pStm-good(); +bRecordOk = bRecordOk pStm-good(); if (!bRecordOk) { commit 63dc30c49c5b560cff49ea69ac563dffa5b01a71 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Thu Apr 24 18:41:11 2014 +0200 fdo#77089 if font width 0, pass 0 - don't take it from font metric Conflicts: vcl/source/filter/wmf/winmtf.cxx Change-Id: I6c73da1d2470e75774affda836a8d587eebfbe4b diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx index 97eed0c..8bc853c 100644 --- a/vcl/source/filter/wmf/winmtf.cxx +++ b/vcl/source/filter/wmf/winmtf.cxx @@ -240,26 +240,15 @@ WinMtfFontStyle::WinMtfFontStyle( LOGFONTW rFont ) aVDev.SetFont( aFont ); FontMetric aMetric( aVDev.GetFontMetric() ); long nHeight = aMetric.GetAscent() + aMetric.GetDescent(); -if ( nHeight ) +if (nHeight) { double fHeight = ((double)aFontSize.Height() * rFont.lfHeight ) / nHeight; aFontSize.Height() = (sal_Int32)( fHeight + 0.5 ); } } -else if ( aFontSize.Height() 0 ) -aFontSize.Height() *= -1; - -if ( !rFont.lfWidth ) -{ -// #i117968# VirtualDevice is not thread safe, but filter is used in multithreading -SolarMutexGuard aGuard; -VirtualDevice aVDev; -aFont.SetSize( aFontSize ); -aVDev.SetFont( aFont ); -FontMetric aMetric( aVDev.GetFontMetric() ); -aFontSize.Width() = aMetric.GetWidth(); -} +// Convert height to positive +aFontSize.Height() = std::abs(aFontSize.Height()); aFont.SetSize( aFontSize ); }; ___ Libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 2 commits - drawinglayer/source vcl/source
drawinglayer/source/processor2d/vclpixelprocessor2d.cxx | 10 +++ vcl/source/filter/wmf/winmtf.cxx| 22 +--- vcl/source/filter/wmf/winmtf.hxx|2 + 3 files changed, 30 insertions(+), 4 deletions(-) New commits: commit dd655ec3335f1755d84f1a74eb8a49625f20a8b3 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Sat Apr 26 19:20:22 2014 +0200 fdo#74336 need to transform dash length / dot length / distance Dash length, dot length and distance also need to be world transformed to be compatible with device metrics. Conflicts: vcl/source/filter/wmf/winmtf.cxx Change-Id: I57c04f5010006aaf8c1c32e0949cb39b7f2bc67d diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx index 8bc853c..c21d5e8 100644 --- a/vcl/source/filter/wmf/winmtf.cxx +++ b/vcl/source/filter/wmf/winmtf.cxx @@ -483,6 +483,20 @@ void WinMtfOutput::ImplMap( Font rFont ) rFont.SetOrientation( 3600 - rFont.GetOrientation() ); } +sal_Int32 WinMtfOutput::ImplConvertWidth(const sal_Int32 aWidth) +{ +Size aSize(aWidth, 0); +return ImplMap(aSize).Width(); +} + +void WinMtfOutput::ImplMap(LineInfo rLineInfo) +{ +rLineInfo.SetWidth(ImplConvertWidth(rLineInfo.GetWidth())); +rLineInfo.SetDashLen(ImplConvertWidth(rLineInfo.GetDashLen())); +rLineInfo.SetDotLen(ImplConvertWidth(rLineInfo.GetDotLen())); +rLineInfo.SetDistance(ImplConvertWidth(rLineInfo.GetDistance())); +} + Polygon WinMtfOutput::ImplMap( Polygon rPolygon ) { sal_uInt16 nPoints = rPolygon.GetSize(); @@ -701,8 +715,8 @@ void WinMtfOutput::CreateObject( GDIObjectType eType, void* pStyle ) } else if ( eType == GDI_PEN ) { -Size aSize( ((WinMtfLineStyle*)pStyle)-aLineInfo.GetWidth(), 0 ); -((WinMtfLineStyle*)pStyle)-aLineInfo.SetWidth( ImplMap( aSize ).Width() ); +WinMtfLineStyle* pLineStyle = (WinMtfLineStyle*) pStyle; +ImplMap(pLineStyle-aLineInfo); } } sal_uInt32 nIndex; @@ -729,8 +743,8 @@ void WinMtfOutput::CreateObject( sal_Int32 nIndex, GDIObjectType eType, void* pS ImplMap( ((WinMtfFontStyle*)pStyle)-aFont ); else if ( eType == GDI_PEN ) { -Size aSize( ((WinMtfLineStyle*)pStyle)-aLineInfo.GetWidth(), 0 ); -((WinMtfLineStyle*)pStyle)-aLineInfo.SetWidth( ImplMap( aSize ).Width() ); +WinMtfLineStyle* pLineStyle = (WinMtfLineStyle*) pStyle; +ImplMap(pLineStyle-aLineInfo); } } if ( (sal_uInt32)nIndex = vGDIObj.size() ) diff --git a/vcl/source/filter/wmf/winmtf.hxx b/vcl/source/filter/wmf/winmtf.hxx index 9db9245..7438588 100644 --- a/vcl/source/filter/wmf/winmtf.hxx +++ b/vcl/source/filter/wmf/winmtf.hxx @@ -635,6 +635,8 @@ class WinMtfOutput SizeImplMap( const Size rSz ); Rectangle ImplMap( const Rectangle rRectangle ); voidImplMap( Font rFont ); +sal_Int32 ImplConvertWidth(const sal_Int32 aWidth); +voidImplMap(LineInfo rLineInfo); PolygonImplMap( Polygon rPolygon ); PolyPolygonImplMap( PolyPolygon rPolyPolygon ); PolygonImplScale( Polygon rPolygon ); commit 652d6c4481f767aaa9044a73f5400a0446be4c97 Author: Tomaž Vajngerl tomaz.vajng...@collabora.com Date: Sat Apr 26 19:13:31 2014 +0200 fdo#74336 draw hairline if line width is small RenderPolygonStrokePrimitive2D draws a simple hairline if the line width is less than 1.0 (and less than 1.5 if no AA is used) so in tryDrawPolygonStrokePrimitive2DDirect we need to reflect this behaviour - otherwise the lines are drawn too small. Change-Id: Icd3d8f35a00346b1d624b6df010f43ed21968d04 diff --git a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx index 203ce5f..783a064 100644 --- a/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx @@ -237,6 +237,16 @@ namespace drawinglayer fLineWidth = aLineWidth.getLength(); } +// draw simple hairline for small line widths +// see also RenderPolygonStrokePrimitive2D which is used if this try fails +bool bIsAntiAliasing = getOptionsDrawinglayer().IsAntiAliasing(); +if ( (basegfx::fTools::lessOrEqual(fLineWidth, 1.0) bIsAntiAliasing) +|| (basegfx::fTools::lessOrEqual(fLineWidth, 1.5) !bIsAntiAliasing)) +{ +// draw simple hairline +fLineWidth = 0.0; +} + bool bHasPoints(false); bool bTryWorked(false); ___ Libreoffice-commits mailing list
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/fdo77718.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx| 34 +++- sw/source/filter/ww8/docxsdrexport.cxx | 10 sw/source/filter/ww8/docxsdrexport.hxx |3 +- 4 files changed, 41 insertions(+), 6 deletions(-) New commits: commit 825265f093a844f952d0dd64e5b4de9a1aba3185 Author: umeshkadam umesh.ka...@synerzip.com Date: Mon Apr 21 19:46:00 2014 +0530 fdo#77718: Picture inside SmartArt changes after RT - The image data stream for the targets of relId's were getting overwritten, therefore the data was getting loss. - Added anchor id as part of computing a unique name for images. - Added UT for the same. Change-Id: I999ba1b3701ef357641dd0365403a5d7ad8d18aa Reviewed-on: https://gerrit.libreoffice.org/9121 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sw/qa/extras/ooxmlexport/data/fdo77718.docx b/sw/qa/extras/ooxmlexport/data/fdo77718.docx new file mode 100644 index 000..7a22485 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo77718.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index 631f415..31fd36b 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -2748,11 +2748,43 @@ DECLARE_OOXMLEXPORT_TEST(testFdo74792, fdo74792.docx) comphelper::getComponentContext(m_xSFactory), m_aTempFile.GetURL()); //check that images are also saved -OUString sImageFile( word/media/OOXDiagramDataRels0.jpeg ); +OUString sImageFile( word/media/OOXDiagramDataRels1_0.jpeg ); //added anchor id to form a uniqe name uno::Referenceio::XInputStream xInputStream(xNameAccess-getByName( sImageFile ), uno::UNO_QUERY); CPPUNIT_ASSERT( xInputStream.is() ); } +DECLARE_OOXMLEXPORT_TEST(testFdo77718, fdo77718.docx) +{ +//in case of multiple smart arts the names for images were getting +//repeated and thereby causing a data loss as the binary stream was +//getting over written. This test case ensures that unique names are +//given for images in different smart arts. +xmlDocPtr pXmlDataRels1 = parseExport(word/diagrams/_rels/data1.xml.rels); +if( !pXmlDataRels1 ) +return; + +xmlDocPtr pXmlDataRels2 = parseExport(word/diagrams/_rels/data2.xml.rels); +if( !pXmlDataRels2 ) +return; + +//ensure that the rels file is present. +assertXPath(pXmlDataRels1,/rels:Relationships/rels:Relationship, 4); +assertXPath(pXmlDataRels2,/rels:Relationships/rels:Relationship, 4); + +uno::Referencepackages::zip::XZipFileAccess2 xNameAccess = packages::zip::ZipFileAccess::createWithURL( + comphelper::getComponentContext(m_xSFactory), m_aTempFile.GetURL()); + +//check that images are also saved +OUString sImageFile1( word/media/OOXDiagramDataRels1_0.jpeg ); //added anchor id to form a uniqe name +uno::Referenceio::XInputStream xInputStream1(xNameAccess-getByName( sImageFile1 ), uno::UNO_QUERY); +CPPUNIT_ASSERT( xInputStream1.is() ); + +//check that images are saved for other smart-arts as well. +OUString sImageFile2( word/media/OOXDiagramDataRels2_0.jpeg ); //added anchor id to form a uniqe name +uno::Referenceio::XInputStream xInputStream2(xNameAccess-getByName( sImageFile2 ), uno::UNO_QUERY); +CPPUNIT_ASSERT( xInputStream2.is() ); +} + DECLARE_OOXMLEXPORT_TEST(testTableCurruption, tableCurrupt.docx) { xmlDocPtr pXmlDoc = parseExport(word/header4.xml); diff --git a/sw/source/filter/ww8/docxsdrexport.cxx b/sw/source/filter/ww8/docxsdrexport.cxx index da3c9e9..5c5d5a2 100644 --- a/sw/source/filter/ww8/docxsdrexport.cxx +++ b/sw/source/filter/ww8/docxsdrexport.cxx @@ -807,7 +807,8 @@ void DocxSdrExport::writeDMLEffectLst(const SwFrmFmt rFrmFmt) void DocxSdrExport::writeDiagramRels(uno::Referencexml::dom::XDocument xDom, uno::Sequence uno::Sequence uno::Any xRelSeq, - uno::Reference io::XOutputStream xOutStream, const OUString sGrabBagProperyName) + uno::Reference io::XOutputStream xOutStream, const OUString sGrabBagProperyName, + int nAnchorId) { // add image relationships of OOXData, OOXDiagram OUString sType(http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;); @@ -838,7 +839,8 @@ void DocxSdrExport::writeDiagramRels(uno::Referencexml::dom::XDocument xDom, uno::Referenceio::XInputStream dataImagebin(new ::comphelper::SequenceInputStream(dataSeq)); OUString sFragment(../media/); -sFragment += sGrabBagProperyName + OUString::number(j) + sExtension; +//nAnchorId is used to make the name unique irrespective of the number of smart
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - nlpsolver/src
nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a4c438de33df540f18749b2d1013ebee73a38f54 Author: Alex Gulyás gulyas.a...@gmail.com Date: Sun Apr 27 18:06:15 2014 +0200 fdo#78004 fix string formatting Added missing 's' Change-Id: I7570d86d65ebcffc547b06ab9c19843de0b90436 Reviewed-on: https://gerrit.libreoffice.org/9181 Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java index 60bdcf9..8561763 100644 --- a/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java +++ b/nlpsolver/src/com/sun/star/comp/Calc/NLPSolver/BaseNLPSolver.java @@ -553,7 +553,7 @@ public abstract class BaseNLPSolver extends WeakBase if (days 0) return String.format(%d %s, %d %s, - days, resourceManager.getLocalizedString(String.format(Time.Day%, days == 1 ? : s), Days), + days, resourceManager.getLocalizedString(String.format(Time.Day%s, days == 1 ? : s), Days), hours, resourceManager.getLocalizedString(String.format(Time.Hour%s, hours == 1 ? : s), Hours)); if (hours 0) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 4 commits - avmedia/source chart2/source external/libgltf include/vcl vcl/source
avmedia/source/opengl/oglframegrabber.cxx | 27 + avmedia/source/opengl/oglplayer.cxx| 41 +++ avmedia/source/opengl/oglplayer.hxx|1 chart2/source/view/main/OpenGLRender.cxx | 27 - external/libgltf/UnpackedTarball_libgltf.mk|1 external/libgltf/patches/format_parameter_for_bitmap.patch | 68 + include/vcl/opengl/OpenGLHelper.hxx|1 vcl/source/opengl/OpenGLContext.cxx| 28 - vcl/source/opengl/OpenGLHelper.cxx | 29 + 9 files changed, 125 insertions(+), 98 deletions(-) New commits: commit 52b06dab6e53b7a25fd4d1dcebc3051afce4c5b4 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Apr 27 16:30:46 2014 +0200 OGLPlayer: use libgltf methods for playing 3D animation By now this methods are unimplemented inside libgltf. Change-Id: Ib7dfb1a053d11fc43fec26ec4f9195e7f64a8a74 diff --git a/avmedia/source/opengl/oglplayer.cxx b/avmedia/source/opengl/oglplayer.cxx index f6f8ab8..3200f16 100644 --- a/avmedia/source/opengl/oglplayer.cxx +++ b/avmedia/source/opengl/oglplayer.cxx @@ -24,12 +24,13 @@ namespace avmedia { namespace ogl { OGLPlayer::OGLPlayer() : Player_BASE(m_aMutex) -, m_bIsPlaying(false) { } OGLPlayer::~OGLPlayer() { +// Comment out while it causes segmentation fault +// gltf_renderer_release(m_pHandle); } static bool lcl_LoadFile( glTFFile* io_pFile, const OUString rURL) @@ -98,42 +99,37 @@ bool OGLPlayer::create( const OUString rURL ) void SAL_CALL OGLPlayer::start() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Start playing of gltf model (see com::sun::star::media::XPlayer) -m_bIsPlaying = true; +gltf_animation_start(m_pHandle); } void SAL_CALL OGLPlayer::stop() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Stop playing of gltf model (see com::sun::star::media::XPlayer) -m_bIsPlaying = false; +gltf_animation_stop(m_pHandle); } sal_Bool SAL_CALL OGLPlayer::isPlaying() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Check whether gltf model is played by now (see com::sun::star::media::XPlayer) -return m_bIsPlaying; +return (sal_Bool)gltf_animation_is_playing(m_pHandle); } double SAL_CALL OGLPlayer::getDuration() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Get gltf's duration (see com::sun::star::media::XPlayer) -return 0.0; +return gltf_animation_get_duration(m_pHandle); } -void SAL_CALL OGLPlayer::setMediaTime( double /*fTime*/ ) throw ( uno::RuntimeException, std::exception ) +void SAL_CALL OGLPlayer::setMediaTime( double fTime ) throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Set player to the specified point (see com::sun::star::media::XPlayer) +gltf_animation_set_time(m_pHandle, fTime); } double SAL_CALL OGLPlayer::getMediaTime() throw ( ::com::sun::star::uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Get player current time position (see com::sun::star::media::XPlayer) -return 0.0; +return gltf_animation_get_time(m_pHandle); } double SAL_CALL OGLPlayer::getRate() throw ( uno::RuntimeException, std::exception ) @@ -143,17 +139,16 @@ double SAL_CALL OGLPlayer::getRate() throw ( uno::RuntimeException, std::excepti return 1.0; } -void SAL_CALL OGLPlayer::setPlaybackLoop( sal_Bool /*bSet*/ ) throw ( uno::RuntimeException, std::exception ) +void SAL_CALL OGLPlayer::setPlaybackLoop( sal_Bool bSet ) throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Set the playes replay itself when it ends (see com::sun::star::media::XPlayer) +gltf_animation_set_looping(m_pHandle, (int)bSet); } sal_Bool SAL_CALL OGLPlayer::isPlaybackLoop() throw ( uno::RuntimeException, std::exception ) { osl::MutexGuard aGuard(m_aMutex); -// TODO: Check whether playing will restart after it ends (see com::sun::star::media::XPlayer) -return false; +return (sal_Bool)gltf_animation_get_looping(m_pHandle); } void SAL_CALL OGLPlayer::setVolumeDB( sal_Int16 /*nVolumDB*/ ) throw ( uno::RuntimeException, std::exception ) diff --git a/avmedia/source/opengl/oglplayer.hxx b/avmedia/source/opengl/oglplayer.hxx index a40b43d..1f1efce 100644 --- a/avmedia/source/opengl/oglplayer.hxx +++ b/avmedia/source/opengl/oglplayer.hxx @@ -58,7 +58,6 @@ private: OUString m_sURL; glTFHandle* m_pHandle; OpenGLContext m_aContext; -bool m_bIsPlaying; }; } // namespace ogl commit 79d75557100b696a02c3341f2e5277900cb3c4df Author: Zolnai Tamás
[Bug 67465] EPS rendering: locating pstoedit on Mac a problem
https://bugs.freedesktop.org/show_bug.cgi?id=67465 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu See Also||https://issues.apache.org/o ||oo/show_bug.cgi?id=72096 --- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu --- There was a similar issue with ieps.cxx for Windows builds to find correct path to ImageMagick convert.exe (see AOO issue 72096) Caolan M. fixed that back in Nov 2009, perhaps a similar approach for OSX and pstoedit? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Jorendc jore...@libreoffice.org changed: What|Removed |Added Depends on|77973 | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Jorendc jore...@libreoffice.org changed: What|Removed |Added Depends on||77973 --- Comment #6 from Jorendc jore...@libreoffice.org --- Hereby I nominate Bug 77973 - VIEWING: Page not visible in Libreoffice Draw. This makes Draw quite unusable. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=75025 Jorendc jore...@libreoffice.org changed: What|Removed |Added Depends on||77973 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - sw/source writerfilter/source
sw/source/core/view/vprint.cxx |2 writerfilter/source/rtftok/rtftokenizer.cxx | 197 ++-- writerfilter/source/rtftok/rtftokenizer.hxx | 82 +-- 3 files changed, 143 insertions(+), 138 deletions(-) New commits: commit df0dea0bf055fce59beedadbc8d20a2681c96bd6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Sun Apr 27 21:31:10 2014 +0200 writerfilter: fix indentation in rtftokenizer Change-Id: Ia9c609eabc39c3933479eae3d5c4499f11c58528 diff --git a/writerfilter/source/rtftok/rtftokenizer.cxx b/writerfilter/source/rtftok/rtftokenizer.cxx index 2ddc714..a8587e7 100644 --- a/writerfilter/source/rtftok/rtftokenizer.cxx +++ b/writerfilter/source/rtftok/rtftokenizer.cxx @@ -20,8 +20,10 @@ using namespace com::sun::star; -namespace writerfilter { -namespace rtftok { +namespace writerfilter +{ +namespace rtftok +{ std::vectorRTFSymbol RTFTokenizer::m_aRTFControlWords; bool RTFTokenizer::m_bControlWordsSorted; @@ -30,12 +32,12 @@ bool RTFTokenizer::m_bMathControlWordsSorted; RTFTokenizer::RTFTokenizer(RTFListener rImport, SvStream* pInStream, uno::Referencetask::XStatusIndicator const xStatusIndicator) : m_rImport(rImport), -m_pInStream(pInStream), -m_xStatusIndicator(xStatusIndicator), -m_nGroup(0), -m_nLineNumber(0), -m_nLineStartPos(0), -m_nGroupStart(0) + m_pInStream(pInStream), + m_xStatusIndicator(xStatusIndicator), + m_nGroup(0), + m_nLineNumber(0), + m_nLineStartPos(0), + m_nGroupStart(0) { if (!RTFTokenizer::m_bControlWordsSorted) { @@ -62,7 +64,7 @@ SvStream RTFTokenizer::Strm() int RTFTokenizer::resolveParse() { -SAL_INFO( writerfilter, OSL_THIS_FUNC ); +SAL_INFO(writerfilter, OSL_THIS_FUNC); char ch; int ret; // for hex chars @@ -83,7 +85,7 @@ int RTFTokenizer::resolveParse() m_xStatusIndicator-setValue(nLastPos = nCurrentPos); } -while ((Strm().ReadChar( ch ), !Strm().IsEof())) +while ((Strm().ReadChar(ch), !Strm().IsEof())) { //SAL_INFO(writerfilter, OSL_THIS_FUNC : parsing character ' ch '); @@ -103,63 +105,63 @@ int RTFTokenizer::resolveParse() { switch (ch) { -case '{': -m_nGroupStart = Strm().Tell() - 1; -ret = m_rImport.pushState(); -if (ret) -return ret; -break; -case '}': -ret = m_rImport.popState(); -if (ret) -return ret; -if (m_nGroup == 0) -{ -if (m_rImport.isSubstream()) -m_rImport.finishSubstream(); -return 0; -} -break; -case '\\': -ret = resolveKeyword(); +case '{': +m_nGroupStart = Strm().Tell() - 1; +ret = m_rImport.pushState(); +if (ret) +return ret; +break; +case '}': +ret = m_rImport.popState(); +if (ret) +return ret; +if (m_nGroup == 0) +{ +if (m_rImport.isSubstream()) +m_rImport.finishSubstream(); +return 0; +} +break; +case '\\': +ret = resolveKeyword(); +if (ret) +return ret; +break; +case 0x0d: +break; // ignore this +case 0x0a: +m_nLineNumber++; +m_nLineStartPos = nCurrentPos; +break; +default: +if (m_nGroup == 0) +return ERROR_CHAR_OVER; +if (m_rImport.getInternalState() == INTERNAL_NORMAL) +{ +ret = m_rImport.resolveChars(ch); if (ret) return ret; -break; -case 0x0d: -break; // ignore this -case 0x0a: -m_nLineNumber++; -m_nLineStartPos = nCurrentPos; -break; -default: -if (m_nGroup == 0) -return ERROR_CHAR_OVER; -if (m_rImport.getInternalState() == INTERNAL_NORMAL) +} +else +{ +SAL_INFO(writerfilter, OSL_THIS_FUNC : hex internal state); +b = b 4; +sal_Int8 parsed = asHex(ch); +if (parsed == -1) +return ERROR_HEX_INVALID; +b += parsed; +
Re: [libreoffice-projects] [ANN] LIbreOffice 4.1.6 RC2 available
Hi Italo, *, On Sun, Apr 27, 2014 at 3:44 PM, Italo Vignoli italo.vign...@gmail.com wrote: On 25/04/14 01:41, Christian Lohmaier wrote: Do you think it will be possible to release on Tuesday at 1:00PM CEST? No technical / availablilty reason that does speak against this. Just that time between RC and release is shorter - but there are only a few fixes added, so I think it is OK. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 74333, which changed state. Bug 74333 Summary: DATALOSS: Textfield or Picture inside a chart is hidden https://bugs.freedesktop.org/show_bug.cgi?id=74333 What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ImageMagick convert -- a required bundle to handle EPS on Windows and OSX?
Hi Stuart, *, On Sat, Apr 26, 2014 at 8:45 PM, V Stuart Foote vstuart.fo...@utsa.edu wrote: Looking at issue fdo#62051 https://bugs.freedesktop.org/show_bug.cgi?id=62051 , why no versions of LibreOffice seem to handle insertion of EPS. Looking in OpenGrok at ieps.cxx http://opengrok.libreoffice.org/xref/core/filter/source/graphicfilter/ieps/ieps.cxx Linux seems to use the GhostScript -- gs command that is commonly bundled. But Windows seems to require use of ImageMgaick convert command. That is not normally a program a Windows user would install! Nope. ps2edit, convert and ghostscript are tried in that order on all platforms. The first one that is available will be used. So, I installed an ImageMagick binary (32-bit static ImageMagick-6.8.9-0-Q16-x86-static.exe) from http://www.imagemagick.org/script/binary-releases.php and all versions of LibreOffice through 4.1.x now render a viable image of the EPS. That might just as well be because ghostscript has trouble with the border/placement of the image in the preview - that is why the two other variants are tried first. Those do a better job with that. Can find nothing noting a requirement for ImageMagick as a install dependency, should ImageMagick be bundled if EPS rendering is depending on it? No. As all of the above is only used to create a preview image of the EPS file if there is none embedded in the EPS file already. EPS is a niche format that most of the users won't encounter. So no need to confuse those by listing those helper programs as a installation requirement ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Missing package in build
Hi Björn, *, On Sat, Apr 26, 2014 at 8:04 PM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Sat, Apr 26, 2014 at 05:41:46PM +0200, Miklos Vajna wrote: […] So the default upstream build still uses ancient gstreamer 0.10, while 'apt-get build-dep libreoffice' installs what the distro uses, which is the much more sensible gstreamer 1.0. You can do the same with: ./autogen.sh --enable-gstreamer --disable-gstreamer-0-10 @cloph: I wonder if we can make that the default (if needed, by keeping the ancient upstream baseline with explicit changes in ./distro-configs)? No objections in changing plain configure's default, as long as a --with-distro build still works on the baseline. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 70414] create VSProject files for code editing in MSVS from gbuild
https://bugs.freedesktop.org/show_bug.cgi?id=70414 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |WORKSFORME --- Comment #22 from Björn Michaelsen bjoern.michael...@canonical.com --- Looks fixed to me? -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-qa] Empty menus in LO master
Hello @ll, to reproduce a bug, I downloaded LO Version: 4.3.0.0.alpha1+ Build ID: f4a6837025a293312cbc43b9c527851362f11030 TinderBox: Linux-rpm_deb-x86@45-TDF, Branch:master, Time: 2014-04-26_09:15:55 and installed it with en_US lang- as well as helppack under Debian Testing i686, following the instructions from https://wiki.documentfoundation.org/Installing_in_parallel. Much to my astonishment I discovered, that all menus are shown, but if you open an menu, you will only see the entry of the marked menu item, but no other (sub) menus ... :( Can anyone confirm this with another OS/architecture? Steps to reproduce: 1. Download an daily build for master 2. Install it on your system 3. Start LO 4. Look at the menus and open them You will only see the marked menu item or the one, where you move your mouse pointer to ... :( Sorry for the inconvenience Thomas. -- NP: Westing*House – Entrez Dans La Ronde ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-projects] [ANN] LIbreOffice 4.1.6 RC2 available
On 25/04/14 01:41, Christian Lohmaier wrote: The Document Foundation is pleased to announce the second release candidate of LibreOffice 4.1.6. The upcoming 4.1.6 will be the sixth and final in a sequence of frequent bugfix releases for our feature-packed 4.1 line. Feel free to give it a try instead of 4.1.5. Do you think it will be possible to release on Tuesday at 1:00PM CEST? Given that Thursday is a holiday in several countries, I would prefer to avoid Wednesday, unless we announce early in the morning, say at 9:00AM CEST. -- Italo Vignoli - italo.vign...@gmail.com mob IT +39.348.5653829 - mob EU +39.392.7481795 sip it...@libreoffice.org - skype italovignoli GPG Key ID - 0xAAB8D5C0 DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0 ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Empty menus in LO master
Hello Joren, *, On So, 27. Apr 2014 15:30 Joren DC wrote: Should be fixed: https://bugs.freedesktop.org/show_bug.cgi?id=77913 :) ah, O.K. Already reported ... ;) Thanks for the link and your answer Thomas. -- I wonder, he said to himself, what's in a book while it's closed. Oh, I know it's full of letters printed on paper, but all the same, something must be happening, because as soon as I open it, there's a whole story with people I don't know yet and all kinds of adventures and battles. -- Bastian B. Bux ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-projects] [ANN] LIbreOffice 4.1.6 RC2 available
Hi Italo, *, On Sun, Apr 27, 2014 at 3:44 PM, Italo Vignoli italo.vign...@gmail.com wrote: On 25/04/14 01:41, Christian Lohmaier wrote: Do you think it will be possible to release on Tuesday at 1:00PM CEST? No technical / availablilty reason that does speak against this. Just that time between RC and release is shorter - but there are only a few fixes added, so I think it is OK. ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Simpler Updates
Hi All, Is there no means of getting smaller updates to development builds, as i find it wasteful to redownload 200mb on every update. -- Jay Philips ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Simpler Updates
No - tinderbox builds those daily. The only other option is to pull and build. That will be less downloading but could take more time building depending on the day and what commits have come through. Best, Joel On 04/27/2014 07:41 PM, Jay Philips wrote: Hi All, Is there no means of getting smaller updates to development builds, as i find it wasteful to redownload 200mb on every update. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 77987] New: Vertical guidelines X-coordinate in edit window =0 for any guideline with X0
https://bugs.freedesktop.org/show_bug.cgi?id=77987 Priority: medium Bug ID: 77987 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Vertical guidelines X-coordinate in edit window =0 for any guideline with X0 Severity: trivial Classification: Unclassified OS: Windows (All) Reporter: sergey.home...@dinom.su Hardware: x86 (IA32) Status: UNCONFIRMED Version: unspecified Component: Drawing Product: LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77987] Vertical guidelines X-coordinate in edit window =0 for any guideline with X0
https://bugs.freedesktop.org/show_bug.cgi?id=77987 Sergey Homenko sergey.home...@dinom.su changed: What|Removed |Added Priority|medium |low Version|unspecified |4.2.2.1 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77988] New: FILESAVE: DOC, DOCX sentences appear on following line
https://bugs.freedesktop.org/show_bug.cgi?id=77988 Priority: medium Bug ID: 77988 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILESAVE: DOC, DOCX sentences appear on following line Severity: normal Classification: Unclassified OS: All Reporter: philip...@hotmail.com Hardware: Other Status: UNCONFIRMED Version: 4.1.5.3 release Component: Writer Product: LibreOffice Created attachment 98063 -- https://bugs.freedesktop.org/attachment.cgi?id=98063action=edit you'll notice bullet points and then the text following it appears on the next line I downloaded the .docx file found at http://download.microsoft.com/documents/customerevidence/Files/71003670/Xiamen_Tungsten_Group_unifies_enterprise.docx and opened it in LibO and then saved it as a doc file. If you compare the view of this file in LibO and word 2010, on page three, you'll will see many text appearing below empty lines with only a bullet point on it. Tested 4.1 to 4.3. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77893] filter_xslt unit test failed
https://bugs.freedesktop.org/show_bug.cgi?id=77893 --- Comment #1 from Douglas Mencken dougmenc...@gmail.com --- Still present in current master. Backtrace: $ export CPPUNITTRACE=gdb --args make CppunitTest_filter_xslt make -j 2 -rs -f ./lo-build/Makefile.gbuild CppunitTest_filter_xslt [build PKG] ure_install [build CUT] filter_xslt GNU gdb 6.3.50-20050815 (Apple version gdb-967) (Tue Jul 14 02:15:14 UTC 2009) Copyright 2004 Free Software Foundation, Inc. (gdb) run Starting program: ./lo-build/workdir/LinkTarget/Executable/cppunittester ./lo-build/workdir/LinkTarget/CppunitTest/libtest_filter_xslt.dylib --headless -env:BRAND_BASE_DIR=file://./lo-build/instdir/LibreOfficeDev.app/Contents -env:BRAND_SHARE_SUBDIR=share -env:UserInstallation=file://./lo-build/workdir/CppunitTest/filter_xslt.test.user -env:CONFIGURATION_LAYERS=xcsxcu:file://./lo-build/instdir/LibreOfficeDev.app/Contents/share/registry -env:UNO_TYPES=file://./lo-build/instdir/LibreOfficeDev.app/Contents/MacOS/types/offapi.rdb\ file://./lo-build/instdir/LibreOfficeDev.app/Contents/ure-link/share/misc/types.rdb -env:UNO_SERVICES=file://./lo-build/workdir/Rdb/ure/services.rdb\ file://./lo-build/workdir/ComponentTarget/configmgr/source/configmgr.component\ file://./lo-build/workdir/ComponentTarget/filter/source/xsltfilter/xsltfilter.component\ file://./lo-build/workdir/ComponentTarget/i18npool/util/i18npool.component\ file://./lo-build/workdir/ComponentTarget/ucb/source/core/ucb1.component\ file://./lo-build/workdir/ComponentTarget/ucb/source/ucp/file/ucpfile1.component -env:URE_INTERNAL_LIB_DIR=file://./lo-build/instdir/LibreOfficeDev.app/Contents/ure-link/lib -env:LO_LIB_DIR=file://./lo-build/instdir/LibreOfficeDev.app/Contents/MacOS -env:LO_JAVA_DIR=file://./lo-build/instdir/LibreOfficeDev.app/Contents/MacOS/classes --protector ./lo-build/workdir/LinkTarget/Library/unoexceptionprotector.dylib unoexceptionprotector --protector ./lo-build/workdir/LinkTarget/Library/unobootstrapprotector.dylib unobootstrapprotector Reading symbols for shared libraries + done Reading symbols for shared libraries done Reading symbols for shared libraries ... done Reading symbols for shared libraries . done Reading symbols for shared libraries .. done Reading symbols for shared libraries . done Reading symbols for shared libraries . done Reading symbols for shared libraries . done Reading symbols for shared libraries . done Reading symbols for shared libraries . done runtime error Global parameter sourceURL already defined runtime error Global parameter sourceBaseURL already defined runtime error Global parameter targetURL already defined runtime error Global parameter targetBaseURL already defined terminate called after throwing an instance of 'CppUnit::Exception' what(): forced failure - exception while in XSLT Program received signal SIGABRT, Aborted. 0x92f47a88 in __semwait_signal () (gdb) bt #0 0x92f47a88 in __semwait_signal () #1 0x92fa1538 in pthread_join$UNIX2003 () #2 0x04d57dd4 in XSLT::LibXSLTTransformer::~LibXSLTTransformer () #3 0x0317cad8 in (anonymous namespace)::XsltFilterTest::testXsltCopyOld () #4 0x000d04b4 in CppUnit::TestCaseMethodFunctor::operator() () #5 0x000c8434 in CppUnit::ProtectorChain::ProtectFunctor::operator() () #6 0x00036708 in (anonymous namespace)::Prot::protect () #7 0x000c8434 in CppUnit::ProtectorChain::ProtectFunctor::operator() () #8 0x000bbc70 in CppUnit::DefaultProtector::protect () #9 0x000c8434 in CppUnit::ProtectorChain::ProtectFunctor::operator() () #10 0x000c7ee4 in CppUnit::ProtectorChain::protect () #11 0x000ded48 in CppUnit::TestResult::protect () #12 0x000d0190 in CppUnit::TestCase::run () #13 0x000d12f8 in CppUnit::TestComposite::doRunChildTests () #14 0x000d10ac in CppUnit::TestComposite::run () #15 0x000d12f8 in CppUnit::TestComposite::doRunChildTests () #16 0x000d10ac in CppUnit::TestComposite::run () #17 0x000e4d64 in CppUnit::TestRunner::WrappingSuite::run () #18 0x000de2b8 in CppUnit::TestResult::runTest () #19 0x000e4ab8 in CppUnit::TestRunner::run () #20 0x2c30 in (anonymous namespace)::ProtectedFixtureFunctor::run () #21 0x3bd4 in sal_main () #22 0x3ed8 in main () (gdb) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77988] FILESAVE: DOC, DOCX sentences appear on following line
https://bugs.freedesktop.org/show_bug.cgi?id=77988 Jay philip...@hotmail.com changed: What|Removed |Added Attachment #98063|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77987] Vertical guidelines X-coordinate in edit window =0 for any guideline with X0
https://bugs.freedesktop.org/show_bug.cgi?id=77987 --- Comment #1 from Sergey Homenko sergey.home...@dinom.su --- Horisontal guidelines similarly And show - sign on rules for coordinates0, please -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75594] FILESAVE: MS Visual C++ Runtime error R6025
https://bugs.freedesktop.org/show_bug.cgi?id=75594 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- Thank you for your feedback, let's put this to WFM then. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77989] New: CONFIGURATION: Can't turn off autocorrect.
https://bugs.freedesktop.org/show_bug.cgi?id=77989 Priority: medium Bug ID: 77989 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: CONFIGURATION: Can't turn off autocorrect. Severity: normal Classification: Unclassified OS: Linux (All) Reporter: he...@safetymail.info Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.3.3 release Component: Spreadsheet Product: LibreOffice Problem description: Can't turn off autocorrect. Can't back changes made by autocorrect. Steps to reproduce: 1. Type shortcut with 3 capitalized letters 2. Autocorrect changed it to 3 lower case (can't change this in options) 3. Ctrl + Z didn't work Current behavior: 1. Can't disable autocorrect from options 2. Can't back changes made by autocorrect Expected behavior: 1. Option for disable autocorrect permanently 2. Ctrl + Z will back changes made by autocorrect Operating System: Fedora Version: 4.2.3.3 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77893] filter_xslt unit test failed
https://bugs.freedesktop.org/show_bug.cgi?id=77893 --- Comment #2 from Douglas Mencken dougmenc...@gmail.com --- Fix is here: https://gerrit.libreoffice.org/#/c/9177/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48783] Clipboard cleared on exit on Linux
https://bugs.freedesktop.org/show_bug.cgi?id=48783 Lubos Lunak l.lu...@collabora.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTOURBUG |--- --- Comment #11 from Lubos Lunak l.lu...@collabora.com --- Specifications are one thing, but there needs to be also something providing the functionality. While KDE's Klipper is run by default, I'm rather sure it doesn't implement this, I have no idea about other desktops, but IIRC GNOME has never really officially included a clipboard manager, so it's a question of how many users would have it there. But fair enough, I guess this can be kept open for when somebody will feel like implementing this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77771] Correction orthographe dans tableur et texte
https://bugs.freedesktop.org/show_bug.cgi?id=1 Urmas davian...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77771] Correction orthographe dans tableur et texte
https://bugs.freedesktop.org/show_bug.cgi?id=1 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77771] Correction orthographe dans tableur et texte
https://bugs.freedesktop.org/show_bug.cgi?id=1 tommy27 ba...@quipo.it changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INVALID |--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77962] FILEOPEN: DOC incorrect font color
https://bugs.freedesktop.org/show_bug.cgi?id=77962 Alexandr alexpik...@gmail.com changed: What|Removed |Added CC||alexpik...@gmail.com Version|4.2.3.3 release |3.5.4 release --- Comment #3 from Alexandr alexpik...@gmail.com --- Reproducible in LibreOffice 3.5.4 on Debian Wheezy. According to https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Version We currently use the Version field to store the earliest LibreOffice version on which we can reproduce a bug. So I change the version field. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77962] FILEOPEN: DOC incorrect font color
https://bugs.freedesktop.org/show_bug.cgi?id=77962 Alexandr alexpik...@gmail.com changed: What|Removed |Added Attachment #98016|application/octet-stream|application/msword mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62038] SLIDESHOW: particular .eps images not shown
https://bugs.freedesktop.org/show_bug.cgi?id=62038 Jean-Baptiste Faure jbf.fa...@sud-ouest.org changed: What|Removed |Added CC||jbf.fa...@sud-ouest.org --- Comment #27 from Jean-Baptiste Faure jbf.fa...@sud-ouest.org --- Even if the eps file contains a bitmap preview, it does not work. :-( Until the bug is corrected, you have the following workaround for new presentations: use Draw to convert your EPS file in bitmap. step 1: insert the eps image in a new Draw document step 2: select and copy the image by ctrl+C step 3: go to Impress and do paste special as bitmap. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77971] FORMATTING: Writer: Better font selection in Japanese locale on Mac OSX.
https://bugs.freedesktop.org/show_bug.cgi?id=77971 --- Comment #2 from Tomofumi Yagi ya...@mknada.sakura.ne.jp --- I added Khaled Hosny on CC. Because I was taught he is the expert on Mac CoreText API. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77897] Quotes in edit mode dissapear after saving or switching to sql-mode
https://bugs.freedesktop.org/show_bug.cgi?id=77897 rob...@familiegrosskopf.de changed: What|Removed |Added Attachment #97919|0 |1 is obsolete|| --- Comment #5 from rob...@familiegrosskopf.de --- Created attachment 98066 -- https://bugs.freedesktop.org/attachment.cgi?id=98066action=edit Query works with a normal field, doesn't work with Datediff I have tested a little bit more. Have added another query to the database. Seems to be a special problem together with DATEDIFF() and fieldnames with special characters. Same problem with MONTH(date1) - MONTH(date2) There is a query, which works in GUI-mode and in SQL-mode with fields with special characters - also with date-fields. I don't know if there are other combinations, which doesn't work. Let us try it out. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77913] Menus are getting invisible when hovering
https://bugs.freedesktop.org/show_bug.cgi?id=77913 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Jorendc jore...@libreoffice.org --- Verified using windows 8.1 using Version: 4.3.0.0.alpha1+ Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36 Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77978] Editing: deleting row with formulas results in crash with vector::_M_range_check error
https://bugs.freedesktop.org/show_bug.cgi?id=77978 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Attachment #98053|text/plain |application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76984] crash with vector::_M_range_check
https://bugs.freedesktop.org/show_bug.cgi?id=76984 --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- Any update? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77990] New: Update of function results
https://bugs.freedesktop.org/show_bug.cgi?id=77990 Priority: medium Bug ID: 77990 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Update of function results Severity: normal Classification: Unclassified OS: All Reporter: jumbo4...@yahoo.fr Hardware: Other Status: NEW Version: 4.2.3.3 release Component: Spreadsheet Product: LibreOffice Created attachment 98067 -- https://bugs.freedesktop.org/attachment.cgi?id=98067action=edit Test case with wrong results in column D Problem description: MATCH function returns #N/A because it refers to a cell on a different sheet which is not updated. Steps to reproduce: 1. Open attached file (a simplified version of http://trk.free.fr/calendrier/download.html) Current behavior: In sheet Jours fériés, D5 (and other cells in the same column) display #N/A. Expected behavior: If you open with LibO 4.1.5.3 the cells are empty. Confirmed on q...@fr.libreoffice.org http://nabble.documentfoundation.org/Calc-4-2-Probleme-de-mise-a-jour-des-fonctions-tt4106597.html with: - OpenSuse 13.1 Version 4.2.3.3 and fresh master build Version: 4.3.0.0.alpha1+ Build ID: c6c286f14468d341f5fd88edc39a37175a1b6caa - Windows 7 Home Premium Version 4.2.4.1 Build ID: d4c441391e20647b3d2e8dde4d20aa868e77e515 and Version 4.3.0.0.alpha0+ Build ID: d2555ebb240fea2780f152e5ea39d145aab508fe TinderBox: Win-x86@39, Branch:master, Time: 2014-04-14_07:59:5 The MATCH function returns #N/A. It refers to D1 which value comes from other sheet Calendrier perpétuel. Workaround: edit D1 and validate value, or Ctrl+Shift+F9 to force calculation. May be resolution of bug 73113 forget some case? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77962] FILEOPEN: DOC incorrect font color
https://bugs.freedesktop.org/show_bug.cgi?id=77962 --- Comment #4 from Jay philip...@hotmail.com --- (In reply to comment #3) Reproducible in LibreOffice 3.5.4 on Debian Wheezy. According to https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Version We currently use the Version field to store the earliest LibreOffice version on which we can reproduce a bug. So I change the version field. Thanks for testing it on 3.5 and changing it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77934] right-click 'Picture...' dialog does not appear
https://bugs.freedesktop.org/show_bug.cgi?id=77934 --- Comment #4 from Jorendc jore...@libreoffice.org --- Tested using Windows 8.1 using Version: 4.3.0.0.alpha1+ Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36 I can NOT reproduce this anymore. @Jay: you mind retesting latest version :-)? New issue: crash when I go to tab 'Macro' in this Picture... dialog. I will create a new bug report for that. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77991] New: Crash in Picture Macro tab
https://bugs.freedesktop.org/show_bug.cgi?id=77991 Priority: medium Bug ID: 77991 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Crash in Picture Macro tab Severity: major Classification: Unclassified OS: Windows (All) Reporter: jore...@libreoffice.org Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.3.0.0.alpha0+ Master Component: Libreoffice Product: LibreOffice Tested using Windows 8.1 with LibreOffice Version: 4.3.0.0.alpha1+ Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36 How to reproduce: * Open Writer * Insert Image From File and pick a random image. * Right click image Picture ... * Go to 'Macro' tab Crash Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77991] Crash in Picture Macro tab
https://bugs.freedesktop.org/show_bug.cgi?id=77991 Jorendc jore...@libreoffice.org changed: What|Removed |Added CC||jmadero@gmail.com, ||serval2...@yahoo.fr --- Comment #1 from Jorendc jore...@libreoffice.org --- @Joel and Julien: you mind testing this easy one :)? Not sure it is windows only or not. Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77934] right-click 'Picture...' dialog does not appear
https://bugs.freedesktop.org/show_bug.cgi?id=77934 Jorendc jore...@libreoffice.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=77991 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77991] Crash in Picture Macro tab
https://bugs.freedesktop.org/show_bug.cgi?id=77991 Jorendc jore...@libreoffice.org changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=77934 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77991] Crash in Picture Macro tab
https://bugs.freedesktop.org/show_bug.cgi?id=77991 --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources udpated today (037754fa9ecea1792e1a8f73b8b4cad4dac75ee0), I don't reproduce the crash (tested in with png file) Just for information, I noticed these console logs: warn:sfx.control:27376:1:sfx2/source/control/ctrlitem.cxx:43: SfxControllerItem: slot without ...Config-flag at SID 6 warn:sfx.control:27376:1:sfx2/source/control/ctrlitem.cxx:43: SfxControllerItem: slot without ...Config-flag at SID 7 warn:legacy.tools:27376:1:cui/source/tabpages/border.cxx:296: ColorTable not found! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77978] Editing: deleting row with formulas results in crash with vector::_M_range_check error
https://bugs.freedesktop.org/show_bug.cgi?id=77978 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated today or with 4.2 sources updated some days ago, I don't reproduce this. I think it's a dup of fdo#76470. If you c -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77992] New: No visual clue sidebar division is collapsed or not
https://bugs.freedesktop.org/show_bug.cgi?id=77992 Priority: medium Bug ID: 77992 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: No visual clue sidebar division is collapsed or not Severity: normal Classification: Unclassified OS: Windows (All) Reporter: jore...@libreoffice.org Hardware: Other Status: UNCONFIRMED Version: 4.3.0.0.alpha0+ Master Component: UI Product: LibreOffice Created attachment 98068 -- https://bugs.freedesktop.org/attachment.cgi?id=98068action=edit Screenshot to explain this bug Hard to explain in words. Please see attached screenshot :-). This is a regression between 4.2-branch and 4.3-branch. Doesn't look like this is done intentionally. It is now very hard to see there is some content under the subdivision or not. (like the 'Page' subdivision in the screenshot). Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77992] No visual clue sidebar division is collapsed or not
https://bugs.freedesktop.org/show_bug.cgi?id=77992 Jorendc jore...@libreoffice.org changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77978] Editing: deleting row with formulas results in crash with vector::_M_range_check error
https://bugs.freedesktop.org/show_bug.cgi?id=77978 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated today or with 4.2 sources updated some days ago, I don't reproduce this. I think it's a dup of fdo#76470. However I might be wrong, so if you reproduce this with 4.1.4 RC1, don't hesitate to reopen this tracker. *** This bug has been marked as a duplicate of bug 76470 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77992] No visual clue sidebar division is collapsed or not
https://bugs.freedesktop.org/show_bug.cgi?id=77992 Jorendc jore...@libreoffice.org changed: What|Removed |Added Attachment #98068|text/plain |image/png mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77459] Other: Insert Rows Above produces crash with vector::_M_range_check error
https://bugs.freedesktop.org/show_bug.cgi?id=77459 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #2 from Julien Nabet serval2...@yahoo.fr --- It might be a dup of fdo#76470 or fdo#76607 as Joren indicated, however without any file to reproduce the problem, quite difficult to know. Anyway, could you give a try to 4.1.4 RC1 and/or attach a file to reproduce this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77987] Vertical guidelines X-coordinate in edit window =0 for any guideline with X0
https://bugs.freedesktop.org/show_bug.cgi?id=77987 Regina Henschel rb.hensc...@t-online.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||rb.hensc...@t-online.de Ever confirmed|0 |1 --- Comment #2 from Regina Henschel rb.hensc...@t-online.de --- Showing minus sign is an enhancement request. Please write an additional issue for it. I can confirm the error with version 4.2.2 and version 4.3.0. The error does not only appear for snap lines outside the page, but too, when you have moved the origin. [To move the origin, grab the intersection of the rulers and drag it down-right.] It is a LibreOffice error. AOO shows the coordinates correctly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77993] New: Writer crashes constantly
https://bugs.freedesktop.org/show_bug.cgi?id=77993 Priority: medium Bug ID: 77993 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Writer crashes constantly Severity: major Classification: Unclassified OS: Mac OS X (All) Reporter: dougmenc...@gmail.com Hardware: PowerPC Status: UNCONFIRMED Version: 4.3.0.0.alpha0+ Master Component: graphics stack Product: LibreOffice Steps to reproduce: 1. Create new Writer document. 2. Type testing. 3. Press Return key. Actual result: LibreOffice crashes. Exception Type: EXC_BAD_ACCESS (SIGBUS) Exception Codes: KERN_PROTECTION_FAILURE at 0x0013 Crashed Thread: 0 Thread 0 Crashed: 0 com.apple.CoreText0x94767b4c TLine::GetVisibleGlyphRange(double*) const + 96 1 com.apple.CoreText0x94767a20 CTLineCreateJustifiedLine + 100 2 libvcllo.dylib0x01b4528c CTLayout::AdjustLayout(ImplLayoutArgs) + 572 3 libvcllo.dylib0x019a9b98 OutputDevice::ImplLayout(rtl::OUString const, long, long, Point const, long, long const*) const + 696 4 libvcllo.dylib0x019ab994 OutputDevice::DrawTextArray(Point const, rtl::OUString const, long const*, long, long) + 324 5 libswlo.dylib 0x2bc275f8 SwFntObj::DrawText(SwDrawTextInfo) + 7624 6 libswlo.dylib 0x2bc3d610 SwSubFont::_DrawText(SwDrawTextInfo, unsigned char) + 448 7 libswlo.dylib 0x2bbb693c SwTxtPaintInfo::_DrawText(rtl::OUString const, SwLinePortion const, long, long, bool, bool, bool, bool) + 2332 8 libswlo.dylib 0x2bbe699c SwTxtPortion::Paint(SwTxtPaintInfo const) const + 556 9 libswlo.dylib 0x2bbcb948 SwTxtPainter::DrawTextLine(SwRect const, SwSaveClip, bool) + 2424 10 libswlo.dylib 0x2bbafb4c SwTxtFrm::Paint(SwRect const, SwPrintData const*) const + 1452 11 libswlo.dylib 0x2bb2ec5c SwLayoutFrm::Paint(SwRect const, SwPrintData const*) const + 940 12 libswlo.dylib 0x2bb2ec5c SwLayoutFrm::Paint(SwRect const, SwPrintData const*) const + 940 13 libswlo.dylib 0x2bb2fc14 SwRootFrm::Paint(SwRect const, SwPrintData const*) const + 2772 14 libswlo.dylib 0x2be6d9c8 SwViewShell::Paint(Rectangle const) + 696 15 libswlo.dylib 0x2b8c9a78 SwCrsrShell::Paint(Rectangle const) + 312 16 libswlo.dylib 0x2bff8794 SwEditWin::Paint(Rectangle const) + 260 17 libvcllo.dylib0x01b2f5d8 Window::ImplCallPaint(Region const*, unsigned short) + 1032 18 libvcllo.dylib0x01b2f73c Window::ImplCallPaint(Region const*, unsigned short) + 1388 19 libvcllo.dylib0x01b2f73c Window::ImplCallPaint(Region const*, unsigned short) + 1388 20 libvcllo.dylib0x01b2f73c Window::ImplCallPaint(Region const*, unsigned short) + 1388 21 libvcllo.dylib0x01b2f73c Window::ImplCallPaint(Region const*, unsigned short) + 1388 22 libvcllo.dylib0x01b2f73c Window::ImplCallPaint(Region const*, unsigned short) + 1388 23 libvcllo.dylib0x01b32414 Window::ImplHandlePaintHdl(void*) + 148 24 libvcllo.dylib0x0181be5c Timer::ImplTimerCallbackProc() + 220 25 libvcllo.dylib0x01b917ec -[TimerCallbackCaller timerElapsed:] + 140 26 com.apple.Foundation 0x97b9daf8 __NSFireTimer + 144 27 com.apple.CoreFoundation 0x96c12818 CFRunLoopRunSpecific + 2968 28 com.apple.HIToolbox 0x93111b14 RunCurrentEventLoopInMode + 264 29 com.apple.HIToolbox 0x931118a0 ReceiveNextEventCommon + 260 30 com.apple.HIToolbox 0x93111778 BlockUntilNextEventMatchingListInMode + 84 31 com.apple.AppKit 0x960bc244 _DPSNextEvent + 596 32 com.apple.AppKit 0x960bbbfc -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 112 33 libvcllo.dylib0x01b508d8 AquaSalInstance::Yield(bool, bool) + 536 34 libvcllo.dylib0x01816d30 Application::Yield() + 144 35 libvcllo.dylib0x01816e00 Application::Execute() + 64 36 libsofficeapp.dylib 0x000c6688 desktop::Desktop::Main() + 7432 37 libvcllo.dylib0x01819c14 ImplSVMain() + 84 38 libvcllo.dylib0x01b4f52c AquaSalInstance::handleAppDefinedEvent(NSEvent*) + 140 39 libvcllo.dylib0x01b921f8 -[VCL_NSApplication sendEvent:] + 56 40 com.apple.AppKit 0x960b58d4 -[NSApplication run] + 800 41 com.apple.AppKit 0x96086298 NSApplicationMain + 440 42 libvcllo.dylib0x01b4ff08 ImplSVMainHook(int*) + 344 43 libvcllo.dylib
[Libreoffice-bugs] [Bug 77994] New: Find Replace doesn't search footnotes in LibO Writer
https://bugs.freedesktop.org/show_bug.cgi?id=77994 Priority: medium Bug ID: 77994 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Find Replace doesn't search footnotes in LibO Writer Severity: normal Classification: Unclassified OS: Linux (All) Reporter: henkel.dan...@gmail.com Hardware: x86-64 (AMD64) Status: UNCONFIRMED Version: 4.2.3.3 release Component: Writer Product: LibreOffice In a rather large document (47002 words, 287035 characters, 76 pages, 240 footnotes) the Find Replace function is unable to find certain words which are verifiably present in footnotes. After running a few other random searches in the document, it manages to find the words which were previously ignored. I have only encountered this problem so far with footnotes in large documents, but it may concern other areas of text in smaller documents as well. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77988] FILESAVE: DOC, DOCX sentences appear on following line
https://bugs.freedesktop.org/show_bug.cgi?id=77988 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jore...@libreoffice.org Ever confirmed|0 |1 --- Comment #1 from Jorendc jore...@libreoffice.org --- Reproducible, tested using Windows 8.1 with LibreOffice Version: 4.3.0.0.alpha1+ Build ID: 145f2e970f46a3a3e5456b122d71f17c3abe878f TinderBox: Win-x86@42, Branch:master, Time: 2014-04-26_23:32:36 Kind regards, Joren -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77987] Vertical guidelines X-coordinate in edit window =0 for any guideline with X0
https://bugs.freedesktop.org/show_bug.cgi?id=77987 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||serval2...@yahoo.fr --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated today, I opened Draw, create a Basic shape then View/Snap Lines/Display Snap Lines but don't understand what's the problem. Indeed at the very bottom of Draw window, I can see coordinates (X and Y) which seem ok. Regina: could you explain a bit or give me a link to a doc? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75330] EDITING: Feature request Show the legend without overlapping the chart
https://bugs.freedesktop.org/show_bug.cgi?id=75330 Jorendc jore...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEW Severity|normal |enhancement CC||jore...@libreoffice.org Ever confirmed|0 |1 --- Comment #2 from Jorendc jore...@libreoffice.org --- Looks like a reasonable feature request to me. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77992] No visual clue sidebar division is collapsed or not
https://bugs.freedesktop.org/show_bug.cgi?id=77992 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||serval2...@yahoo.fr Ever confirmed|0 |1 --- Comment #1 from Julien Nabet serval2...@yahoo.fr --- On pc Debian x86-64 with master sources updated today, I can reproduce this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75330] EDITING: Show the legend without overlapping the chart
https://bugs.freedesktop.org/show_bug.cgi?id=75330 Jorendc jore...@libreoffice.org changed: What|Removed |Added Summary|EDITING: Feature request|EDITING: Show the legend |Show the legend without|without overlapping the |overlapping the chart |chart -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77992] No visual clue if sidebar division is collapsed or not
https://bugs.freedesktop.org/show_bug.cgi?id=77992 Jorendc jore...@libreoffice.org changed: What|Removed |Added OS|Windows (All) |All Summary|No visual clue sidebar |No visual clue if sidebar |division is collapsed or|division is collapsed or |not |not -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs