LibreOffice Gerrit News for core on 2014-05-14
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo#78599: Fixed for file corruption which contains fields and hyperlink in https://gerrit.libreoffice.org/9330 from Priyanka Gaikwad about module sw End of freshness + fdo#70474: Random number generation weak with Rnd in BASIC in https://gerrit.libreoffice.org/9349 from Thomas Arnhold about module basic + move boost rng wrapper from sc to comphelper in https://gerrit.libreoffice.org/9348 from Thomas Arnhold about module comphelper, include, sc + upgrade to python-3.3.5 in https://gerrit.libreoffice.org/9311 from Thomas Arnhold about module build, external + libgltf: Update to the new version. in https://gerrit.libreoffice.org/9333 from Jan Holesovsky about module avmedia, build, external + Introduce Collada2gltf external library in https://gerrit.libreoffice.org/9291 from Matúš Kukan about module build, external + Introduce OpenCollada external library in https://gerrit.libreoffice.org/9290 from Matúš Kukan about module build, external + fdo#67544 Slide transistion sound(other sound) is not included in present in https://gerrit.libreoffice.org/8700 from Vishv Brahmbhatt about module include, sd, sfx2 + fdo#78384: Fix for corruption if file contains symbols. in https://gerrit.libreoffice.org/9281 from Rohit Deshmukh about module sw, writerfilter + -fsanitize=address does not like -z defs in https://gerrit.libreoffice.org/9334 from Markus Mohrhard about module external * Merged changes on master for project core changed in the last 25 hours: + coverity#735464 Logically dead code in https://gerrit.libreoffice.org/9301 from Thomas Arnhold + fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO in https://gerrit.libreoffice.org/9343 from Noel Grandin + upgrade to libpng-1.5.18 in https://gerrit.libreoffice.org/9344 from Thomas Arnhold + Use collada2gltf to open .dae files and convert them to .json. in https://gerrit.libreoffice.org/9332 from Matúš Kukan + Access2Base new release - V1.1.0 in https://gerrit.libreoffice.org/9303 from Jean-Pierre Ledure + remove unused code -SvtLanguageTable::AddLanguageTag in https://gerrit.libreoffice.org/9342 from Noel Grandin + fdo#78420 File is getting corrupted after exported from LO. in https://gerrit.libreoffice.org/9286 from Ravindra Vidhate + coverity#1212488 Copy-paste error in https://gerrit.libreoffice.org/9302 from Thomas Arnhold + vcl-quartz: fix for fdo#77993 (specific to OS X 10.6) in https://gerrit.libreoffice.org/9180 from Douglas Mencken * Abandoned changes on master for project core changed in the last 25 hours: + fdo#72661: Check ‘Hyphenation active’ automatically in https://gerrit.libreoffice.org/7291 from Jiwoong Youn + remove dead code in https://gerrit.libreoffice.org/9339 from Noel Grandin + remove dead code in SW in https://gerrit.libreoffice.org/9341 from Noel Grandin + remove dead code SwAccessibleField in https://gerrit.libreoffice.org/9340 from Noel Grandin * Open changes needing tweaks, but being untouched for more than a week: + cppunittest_filter_xslt: fix fdo#77893 in https://gerrit.libreoffice.org/9177 from Douglas Mencken + DrawWaveLine/ImplDrawWaveLine fixes: - try to avoid huge looping due to in https://gerrit.libreoffice.org/9174 from Douglas Mencken + FDO#74886: Data labels are not preserved for Column Chart in RT file in https://gerrit.libreoffice.org/8098 from Umesh Kadam + new method INetURLObject::getData() for data urls in https://gerrit.libreoffice.org/8737 from Christina Roßmanith + fdo#75757 Remove inheritance to std::map from PropertyMap in https://gerrit.libreoffice.org/8656 from Krisztian Pinter + Remove visual noise from ios in https://gerrit.libreoffice.org/8274 from Alexander Wilms + FDO#75205 : Charts - Up Down bars are getting added to Line Chart. in https://gerrit.libreoffice.org/8360 from Umesh Kadam + WIP: Converting ExtensionUpdate dialog for new format in https://gerrit.libreoffice.org/8506 from Rodolfo Ribeiro Gomes + fdo#71984 fix first line indentation in footnotes for MS Word documents in https://gerrit.libreoffice.org/8160 from Andras Timar + fdo#51525 Fix duplicate Paste Special entries in Calc. in https://gerrit.libreoffice.org/7784 from Andrzej Hunt + WIP fdo#72987 Use firebird backup format for .odb in https://gerrit.libreoffice.org/7299 from Andrzej Hunt + WIP: fdo#33980 Preserve selection across all slide sorters. in https://gerrit.libreoffice.org/6633 from Andrzej Hunt Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Access2Base - New release
On 13/05/2014 10:13, Lionel Elie Mamane wrote: I presume it is compliant with the LO release policy to push the same patch also to the LO 4.2 branch ? I don't think so; no new features, only bugfixes. Can't an installation as extension override the bundled one, or something like that? I don't see how: installing the extension on LO 4.2 makes that 2 Basic libraries with the same name are present either in My macros or in LibreOffice macros. To be used a library must first be loaded by giving its (presumably unique) name ?? The result is LO being unstable or corrupt. JP. --- This email is free from viruses and malware because avast! Antivirus protection is active. http://www.avast.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/gridwin.cxx |7 +++ sc/source/ui/view/gridwin2.cxx |6 +++--- sc/source/ui/view/gridwin4.cxx | 12 +--- sc/source/ui/view/output.cxx | 12 ++-- sc/source/ui/view/output2.cxx | 14 ++ 5 files changed, 23 insertions(+), 28 deletions(-) New commits: commit decfecc3d2414a6467bae6d5e9069fb63885e3fe Author: Takeshi Abe t...@fixedpoint.jp Date: Wed May 14 14:52:56 2014 +0900 Avoid possible memory leaks in case of exceptions Change-Id: Ib74c40bb4ac11edf97b6843e983a911308fa4b98 diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx index d1194bf..2226ab1 100644 --- a/sc/source/ui/view/gridwin.cxx +++ b/sc/source/ui/view/gridwin.cxx @@ -1262,15 +1262,15 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec const ScValidationData* pData = pDoc-GetValidationEntry( nIndex ); if (pData) { -ScTypedStrData* pNew = NULL; +boost::scoped_ptrScTypedStrData pNew; OUString aDocStr = pDoc-GetString(nCol, nRow, nTab); if ( pDoc-HasValueData( nCol, nRow, nTab ) ) { double fVal = pDoc-GetValue(ScAddress(nCol, nRow, nTab)); -pNew = new ScTypedStrData(aDocStr, fVal, ScTypedStrData::Value); +pNew.reset(new ScTypedStrData(aDocStr, fVal, ScTypedStrData::Value)); } else -pNew = new ScTypedStrData(aDocStr, 0.0, ScTypedStrData::Standard); +pNew.reset(new ScTypedStrData(aDocStr, 0.0, ScTypedStrData::Standard)); bool bSortList = ( pData-GetListType() == ValidListType::SORTEDASCENDING); if ( bSortList ) @@ -1293,7 +1293,6 @@ void ScGridWindow::LaunchDataSelectMenu( SCCOL nCol, SCROW nRow, bool bDataSelec nSelPos = std::distance(itBeg, it); } } -delete pNew; } } } diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx index 6ea8c89..357b419 100644 --- a/sc/source/ui/view/gridwin2.cxx +++ b/sc/source/ui/view/gridwin2.cxx @@ -47,6 +47,7 @@ #include com/sun/star/sheet/DataPilotFieldOrientation.hpp #include vector +#include boost/scoped_ptr.hpp #include boost/unordered_map.hpp using namespace com::sun::star; @@ -210,8 +211,8 @@ void ScGridWindow::DoPushPivotButton( SCCOL nCol, SCROW nRow, const MouseEvent ScAbstractDialogFactory* pFact = ScAbstractDialogFactory::Create(); OSL_ENSURE(pFact, ScAbstractFactory create fail!); -AbstractScPivotFilterDlg* pDlg = pFact-CreateScPivotFilterDlg( -pViewData-GetViewShell()-GetDialogParent(), aArgSet, nSrcTab); +boost::scoped_ptrAbstractScPivotFilterDlg pDlg(pFact-CreateScPivotFilterDlg( +pViewData-GetViewShell()-GetDialogParent(), aArgSet, nSrcTab)); OSL_ENSURE(pDlg, Dialog create fail!); if ( pDlg-Execute() == RET_OK ) { @@ -228,7 +229,6 @@ void ScGridWindow::DoPushPivotButton( SCCOL nCol, SCROW nRow, const MouseEvent aFunc.DataPilotUpdate( pDPObj, aNewObj, true, false ); pViewData-GetView()-CursorPosChanged(); // shells may be switched } -delete pDlg; } } else diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx index 5405b89..2625a96 100644 --- a/sc/source/ui/view/gridwin4.cxx +++ b/sc/source/ui/view/gridwin4.cxx @@ -917,7 +917,7 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2, } Font aFont; -ScEditEngineDefaulter* pEditEng = NULL; +boost::scoped_ptrScEditEngineDefaulter pEditEng; const ScPatternAttr rDefPattern = ((const ScPatternAttr)pDoc-GetPool()-GetDefaultItem(ATTR_PATTERN)); if ( nPageScript == SCRIPTTYPE_LATIN ) { @@ -929,7 +929,7 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2, else { // use EditEngine to draw mixed-script string -pEditEng = new ScEditEngineDefaulter( EditEngine::CreatePool(), true ); +pEditEng.reset(new ScEditEngineDefaulter( EditEngine::CreatePool(), true )); pEditEng-SetRefMapMode( pContentDev-GetMapMode() ); SfxItemSet* pEditDefaults = new SfxItemSet( pEditEng-GetEmptyItemSet() ); rDefPattern.FillEditItemSet( pEditDefaults ); @@ -1093,8 +1093,6 @@ void ScGridWindow::DrawPagePreview( SCCOL nX1, SCROW nY1, SCCOL nX2, SCROW nY2, } } } - -delete pEditEng; } } @@ -,7 +1109,7 @@ void ScGridWindow::DrawButtons( SCCOL nX1, SCCOL nX2, ScTableInfo rTabInfo, Out SCSIZE nQuery; SCTAB
Re: Hello from a Newb Here to Help
Hi, On Wed, May 07, 2014 at 06:38:19PM -0500, Lindsey wrote: Hi, I know y'all are busy so I'll try to keep this short. I just started using Libre Office and I LOVE it. I want to learn all I can about it but I also hit some snags. I'm not really a dev - so I can't help with coding stuff but I can help with writing documentation, wikis, and anything in that regard. In the past I've found writing about things can go a long way to speed up the learning process. I really want to learn this and I also want to help out as I go. If someone would be so kind as to point me in the right direction, I'd be much obliged. Thank you! You can start with http://www.libreoffice.org/community/get-involved/ . D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] buildbot.git: 2 commits - bin/tinbuild bin/tinbuild2
bin/tinbuild | 367 -- bin/tinbuild2 |1 2 files changed, 1 insertion(+), 367 deletions(-) New commits: commit d9fbd644cf17ca43f06f0ae33b4312d47a86354d Author: Thorsten Behrens t...@documentfoundation.org Date: Wed May 14 09:27:40 2014 +0200 tinbuild is long-since unused, bin it. Proof: last branch this was possibly built with was 3.6 ... diff --git a/bin/tinbuild b/bin/tinbuild deleted file mode 100755 index 6d1ae9e..000 --- a/bin/tinbuild +++ /dev/null @@ -1,367 +0,0 @@ -#!/usr/bin/env bash - -export LC_ALL=C - -## default config -PAUSE_SECONDS=$((15*60)) -BIN_PATH=`dirname $0` -HTML_OUTPUT=0 -SEND_MAIL=0 -PUSH_NIGHTLIES=0 -NICE= -OWNER= -GNUDATE=0 -TINDERNAME= -BANDWIDTH= -LOCK= - -SMTPPORT=25 -SMTPHOST= -SMTPUSER= -SMTPPW= - -## Determine if we have GNU date(1) or not -date --version 2 /dev/null | grep -q Free\ Software\ Foundation -if [ $? -eq 0 ]; then - GNUDATE=1 -fi - -## Determine how GNU make(1) is called on the system -for _g in make gmake gnumake; do - $_g --version 2 /dev/null | grep -q GNU - if test $? -eq 0; then - MAKE=$_g - break - fi -done - -# Do we have flock? If yes, synchronize - if there are more tinbuilds running -# at the same time, just one of them builds / installs / whatever at the given -# time -if which flock /dev/null 21 ; then - LOCK=1 -fi - -# Do we have timeout? If yes, guard git pull with that - which has a -# tendency to hang forever, when connection is flaky -if which timeout /dev/null 21 ; then - # std coreutils - timeout is two hours - timeout=`which timeout` 2h -elif which gtimeout /dev/null 21 ; then - # Mac - timeout is two hours - timeout=`which gtimeout` 2h -fi - -## subroutines -usage () -{ - echo Usage: $0 [options] - echo Options: - echo -d name name of the distro-config to use - echo -e don't synchronize (when running 1 tindbuilds at the same time) - echo -h this help - echo -i run with ionice -c3, can be combined with -n - echo -l write html build log - echo -m owner mail errors to the committer, general errors to the owner - echo -n run with nice, can be combined with -i - echo -r kbyte rsync build to nightlies archive, using KBytes/sec bandwidth - echo -s host SMTP server - echo -c type SMTP crypt to use - either none, tls or ssl - echo -u user SMTP user name for auth login - echo -p pass SMTP password for auth login - echo -t name send tinderbox mails, identify self as name - echo -w N specify timeout in secs between subsequent pull requests -} - -# echo the message to the screen including a timestamp -echots () -{ - echo [`date -u '+%Y-%m-%d %H:%M:%S'` $TINDER_BRANCH] $@ -} - -getCommitters () -{ - from_date=$1 - - ./g -s log '--pretty=tformat:%ce' --after=$from_date | sort | uniq | tr '\n' ',' -} - -sendMailMsg () -{ - TO=$1 - SUBJECT=$2 - HEADERS=$3 - BCC=$4 - LOG=$5 - - CMD='$BIN_PATH/sendEmail -q -f $OWNER -s $SMTPHOST -xu $SMTPUSER -xp $SMTPPW -t $TO -bcc $BCC -u $SUBJECT -o message-header=$HEADERS' - - if test -n $LOG test -f $LOG; then - CMD=$CMD -a $LOG - fi - eval $CMD - - echots Sent a mail to \$TO\ with subject \$SUBJECT\. -} - -reportError () -{ - error_kind=$1 - shift - - rough_time=$1 - shift - - to_mail= - if test $SEND_MAIL -eq 1; then - case $error_kind in - owner) to_mail=$OWNER - message=box broken ;; - *) if test -z $last_success ; then - # we need at least one successful build to - # be reliable - to_mail=$OWNER - else - to_mail=`getCommitters $last_success` - fi - message=last success: $rough_time ;; - esac - fi - - echo $* 12 - echo Last success: $rough_time 12 - if test -n $to_mail ; then - TINDER1= - TINDER2= - if test $SEND_MAIL -eq 1 -a -n $TINDERNAME ; then - TINDER1=`echo \Full log available at http://tinderbox.libreoffice.org/$TINDER_BRANCH/status.html\`; - TINDER2=`echo \Box name: $TINDERNAME\` - fi - cat EOF | sendMailMsg $to_mail Tinderbox failure, $message $OWNER -Hi folks, - -One of you broke the build of LibreOffice master with your commit :-( -Please commit and push a fix ASAP! - -${TINDER1} - -Tinderbox info: - - ${TINDER2} - Machine: `uname -a` - Configured with: `cat autogen.lastrun` - -Commits since the last
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/fdo78384.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx |7 +++ writerfilter/source/dmapper/DomainMapper.cxx | 11 ++- writerfilter/source/dmapper/DomainMapper_Impl.cxx | 11 +++ writerfilter/source/dmapper/DomainMapper_Impl.hxx |4 5 files changed, 32 insertions(+), 1 deletion(-) New commits: commit f51640c5f40d5132b396a9fb6589420383df1610 Author: Rohit Deshmukh rohit.deshm...@synerzip.com Date: Thu May 8 16:33:44 2014 +0530 fdo#78384: Fix for corruption if file contains symbols. * In case of symbol, symbol character get imported first and then font of symbols. * So we are storing symbol character and when we parse symbol font then create UNO object for text. Change-Id: If5b79521c6a59aec02b165e8120dafdd472cdaeb Reviewed-on: https://gerrit.libreoffice.org/9281 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sw/qa/extras/ooxmlexport/data/fdo78384.docx b/sw/qa/extras/ooxmlexport/data/fdo78384.docx new file mode 100644 index 000..ee10264 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo78384.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index 4919d01..87097d9 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -3321,6 +3321,13 @@ DECLARE_OOXMLEXPORT_TEST(testFDO78284, fdo78284.docx) image/png); } +DECLARE_OOXMLEXPORT_TEST(testFDO78384,fdo78384.docx) +{ +xmlDocPtr pXmlDoc = parseExport(word/document.xml); +if (!pXmlDoc) +return; +assertXPath(pXmlDoc, /w:document/w:body/w:p[1]/w:r[1]/w:rPr/w:rFonts,ascii,Wingdings); +} #endif CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index dd92026..3dfb392 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -239,7 +239,7 @@ void DomainMapper::lcl_attribute(Id nName, Value val) } else //it's a _real_ symbol { -utext( reinterpret_cast const sal_uInt8 * ( nIntValue ), 1 ); +m_pImpl-SetSymbolData(nIntValue); } break; case NS_ooxml::LN_CT_Sym_font: @@ -253,7 +253,16 @@ void DomainMapper::lcl_attribute(Id nName, Value val) } else //a real symbol if (m_pImpl-GetTopContext()) +{ m_pImpl-GetTopContext()-Insert(PROP_CHAR_FONT_NAME, uno::makeAny( sStringValue )); +/* + * In case of symbol, symbol character get imported first and then font of symbols. + * So we are storing symbol character and when we parse symbol font then create UNO object for text. + */ +sal_Int32 symboldata = m_pImpl-GetSymbolData(); +utext( reinterpret_cast const sal_uInt8 * ( (symboldata) ), 1 ); +} + break; case NS_ooxml::LN_CT_Underline_val: handleUnderlineType(nIntValue, m_pImpl-GetTopContext()); diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 410b064..bb81d09 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -164,6 +164,7 @@ DomainMapper_Impl::DomainMapper_Impl( m_bTOCPageRef(false), m_bStartGenericField(false), m_bTextInserted(false), +m_nSymboldata(-1), m_pLastSectionContext( ), m_pLastCharacterContext(), m_nCurrentTabStopIndex( 0 ), @@ -375,6 +376,16 @@ void DomainMapper_Impl::RemoveLastParagraph( ) } } +void DomainMapper_Impl::SetSymbolData( bool nSymbolData ) +{ +m_nSymboldata = nSymbolData; +} + +sal_Int32 DomainMapper_Impl::GetSymbolData() +{ +return m_nSymboldata; +} + void DomainMapper_Impl::SetIsLastParagraphInSection( bool bIsLast ) { m_bIsLastParaInSection = bIsLast; diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 2694a51..0c1178a 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -331,6 +331,7 @@ private: BookmarkMap_t m_aBookmarkMap; _PageMar m_aPageMargins; +sal_Int32 m_nSymboldata; // TableManagers are stacked: one for each stream to avoid any confusion @@ -466,6 +467,9 @@ public: bool GetIsTextFrameInserted(); void SetParaSectpr(bool bParaSectpr); bool GetParaSectpr();
[Libreoffice-commits] core.git: 2 commits - package/source vcl/source
package/source/zipapi/ZipFile.cxx |2 +- vcl/source/gdi/bitmap4.cxx|4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 8c004aa108f7b712b377469139baf9f0f53d0c93 Author: Noel Grandin n...@peralex.com Date: Wed May 14 09:45:34 2014 +0200 cid#982783 Unintentional integer overflow Change-Id: Ida52d1fbe3d84c9c0070c91ae24cae58dc4aa13f diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx index 8444dce..2c8d7e8 100644 --- a/package/source/zipapi/ZipFile.cxx +++ b/package/source/zipapi/ZipFile.cxx @@ -1097,7 +1097,7 @@ void ZipFile::getSizeAndCRC( sal_Int64 nOffset, sal_Int64 nCompressedSize, sal_I sal_Int32 nBlockSize = static_cast sal_Int32 (::std::min( nCompressedSize, static_cast sal_Int64 ( 32000 ) ) ); aGrabber.seek( nOffset ); -for ( int ind = 0; +for ( sal_Int64 ind = 0; !aInflaterLocal.finished() aGrabber.readBytes( aBuffer, nBlockSize ) ind * nBlockSize nCompressedSize; ind++ ) { commit 3c42d5e41478cb5abd4f592633d6eb2f4145c6db Author: Noel Grandin n...@peralex.com Date: Wed May 14 09:38:55 2014 +0200 cid#705542 Unintentional integer overflow Change-Id: Ibd3ef676de7d99ebdd273ee85665ddf9ec0f9c10 diff --git a/vcl/source/gdi/bitmap4.cxx b/vcl/source/gdi/bitmap4.cxx index f8c987e..29d4e57 100644 --- a/vcl/source/gdi/bitmap4.cxx +++ b/vcl/source/gdi/bitmap4.cxx @@ -946,8 +946,8 @@ bool Bitmap::ImplPopArt( const BmpFilterParam* /*pFilterParam*/, const Link* /*p { const long nWidth = pWriteAcc-Width(); const long nHeight = pWriteAcc-Height(); -const sal_uLong nEntryCount = 1 pWriteAcc-GetBitCount(); -sal_uLong n; +const sal_uLong nEntryCount = 1L pWriteAcc-GetBitCount(); +sal_uLong n; PopArtEntry*pPopArtTable = new PopArtEntry[ nEntryCount ]; for( n = 0; n nEntryCount; n++ ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |2 +- writerfilter/source/dmapper/DomainMapper_Impl.hxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 671eb12dee290607ed66f3b325f28e7bd4695cba Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 09:54:22 2014 +0200 writerfilter: DomainMapper_Impl::SetSymbolData() should take an int One wonders how did this work so far. Change-Id: I6aee6a2f7e15c1c4931ca5d65b6ad39d025ff9ed diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index bb81d09..bfeb770 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -376,7 +376,7 @@ void DomainMapper_Impl::RemoveLastParagraph( ) } } -void DomainMapper_Impl::SetSymbolData( bool nSymbolData ) +void DomainMapper_Impl::SetSymbolData( sal_Int32 nSymbolData ) { m_nSymboldata = nSymbolData; } diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index 0c1178a..5b17baf 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -468,7 +468,7 @@ public: void SetParaSectpr(bool bParaSectpr); bool GetParaSectpr(); -void SetSymbolData( bool nSymbolData ); +void SetSymbolData( sal_Int32 nSymbolData ); sal_Int32 GetSymbolData(); /// Setter method for m_bSdt. void SetSdt(bool bSdt); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/opencollada
external/opencollada/opencollada.clang.patch.0 | 10 ++ 1 file changed, 10 insertions(+) New commits: commit fb33f0d898d371401a0efeba04713cd73efe2836 Author: Tor Lillqvist t...@collabora.com Date: Wed May 14 11:15:11 2014 +0300 Make it compile with Apple's Clang and libc++ Change-Id: I45feb0d715e6e823a42c7960fd87346412ebcc48 diff --git a/external/opencollada/opencollada.clang.patch.0 b/external/opencollada/opencollada.clang.patch.0 index 1fe57be..14e67e9 100644 --- a/external/opencollada/opencollada.clang.patch.0 +++ b/external/opencollada/opencollada.clang.patch.0 @@ -1,6 +1,16 @@ +-*- Mode: Diff -*- diff -ur opencollada.org/COLLADABaseUtils/include/COLLADABUhash_map.h opencollada/COLLADABaseUtils/include/COLLADABUhash_map.h --- COLLADABaseUtils/include/COLLADABUhash_map.h 2014-05-09 11:12:05.740858077 +0200 +++ COLLADABaseUtils/include/COLLADABUhash_map.h 2014-05-09 11:17:38.616861995 +0200 +@@ -60,7 +60,7 @@ + #define COLLADABU_HASH_NAMESPACE_CLOSE } + #define COLLADABU_HASH_FUN hash + #endif +-#elif defined(__FreeBSD__) defined(_LIBCPP_VERSION) ++#elif (defined(__APPLE__) || defined(__FreeBSD__)) defined(_LIBCPP_VERSION) + #include unordered_map + #include unordered_set + #define COLLADABU_HASH_MAP std::unordered_map @@ -70,7 +70,7 @@ #define COLLADABU_HASH_NAMESPACE_CLOSE #define COLLADABU_HASH_FUN hash ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Changes to 'feature/textbox'
New branch 'feature/textbox' available with the following commits: commit e939daf25b2b2b8a5fd66ba78bc792a5dcb2f0b2 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 11:52:33 2014 +0200 SwXShape: new bool TextBox property Change-Id: Id9744db2d2a7c6102514f05109c80650af243e28 commit 31f26e74bd249c9ab93f485b28ab9af7b29a3b36 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 11:44:35 2014 +0200 SwXShape: invoke SwTextBoxHelper For now, only in queryInterface(), setPropertyValue() and setSize(). It's safe to always call these methods, if they are not relevant, the method will be a NOP. Change-Id: I1985f8bcac38cf232652a1e30241a5fa6bef5aba commit 0c6932a8c79c455c57270fc9203d1041d1a26574 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 11:41:19 2014 +0200 Initial SwTextBoxHelper Change-Id: I928cf7d7cbfb62ffa98be9412d7425a6dc61bfdb commit a9c5d2e2112d693c00e2c3b01a26753d0e6c3c4b Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 11:36:35 2014 +0200 WIP: oox: trigger the TextBox property on XML_txbx Change-Id: Ia3e69e61073cc915c4462c9d3fcfe07b75ac3fb3 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ooxmlexport/data/fdo78599.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 10 ++ sw/source/filter/ww8/docxattributeoutput.cxx | 10 ++ 3 files changed, 20 insertions(+) New commits: commit 8db493240a2caced1ab72a9e0fc87d39a6d3f12d Author: PriyankaGaikwad priyanka.gaik...@synerzip.com Date: Mon May 12 17:54:30 2014 +0530 fdo#78599: Fixed for file corruption which contains fields and hyperlink Field inside a hyperlink closed after the ending tag of hyperlink, which corrupted the RT file. Change-Id: Ib89ead8d2f8a9eb6c8473ffd14853495ee1b2f62 Reviewed-on: https://gerrit.libreoffice.org/9330 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/extras/ooxmlexport/data/fdo78599.docx b/sw/qa/extras/ooxmlexport/data/fdo78599.docx new file mode 100644 index 000..3c81780 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo78599.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index 87097d9..df265ff 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -3328,6 +3328,16 @@ DECLARE_OOXMLEXPORT_TEST(testFDO78384,fdo78384.docx) return; assertXPath(pXmlDoc, /w:document/w:body/w:p[1]/w:r[1]/w:rPr/w:rFonts,ascii,Wingdings); } + +DECLARE_OOXMLEXPORT_TEST(testfdo78599,fdo78599.docx) +{ + xmlDocPtr pXmlDoc = parseExport(word/document.xml); +if (!pXmlDoc) +return; +//docx file after RT is getting corrupted. +assertXPath ( pXmlDoc, /w:document/w:body/w:p[1]/w:hyperlink/w:r[6]/w:fldChar, fldCharType, end ); +} + #endif CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 4598bb7..74c47c6 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -746,6 +746,7 @@ void DocxAttributeOutput::EndRun() EndField_Impl( m_Fields.back( ) ); if (m_Fields.back().pField) delete m_Fields.back().pField; +m_Fields.pop_back(); } m_pSerializer-endElementNS( XML_w, XML_hyperlink ); m_startedHyperlink = false; @@ -871,6 +872,15 @@ void DocxAttributeOutput::EndRun() m_endPageRef = false; m_hyperLinkAnchor = ; } +for ( int i = 0; i m_nFieldsInHyperlink; i++ ) +{ +// If fields begin after hyperlink start then +// it should end before hyperlink close +EndField_Impl( m_Fields.back( ) ); +if (m_Fields.back().pField) +delete m_Fields.back().pField; +m_Fields.pop_back(); +} m_pSerializer-endElementNS( XML_w, XML_hyperlink ); m_startedHyperlink = false; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source filter/source framework/source include/unotools sd/qa sfx2/source sw/source unotools/source
connectivity/source/drivers/dbase/DTable.cxx |2 +- filter/source/xsltdialog/xmlfiltertestdialog.cxx |4 ++-- framework/source/services/autorecovery.cxx |2 +- include/unotools/tempfile.hxx| 10 +- sd/qa/unit/HtmlExportTest.cxx|2 +- sd/qa/unit/sdmodeltestbase.hxx |2 +- sfx2/source/doc/docfile.cxx |6 +++--- sw/source/core/doc/docglbl.cxx |4 ++-- sw/source/core/uibase/dbui/dbmgr.cxx |4 ++-- sw/source/core/uibase/misc/glosdoc.cxx |2 +- sw/source/core/uibase/uno/unomailmerge.cxx |2 +- sw/source/ui/dbui/addresslistdialog.cxx |2 +- sw/source/ui/dbui/mmlayoutpage.cxx |2 +- unotools/source/ucbhelper/tempfile.cxx |7 --- 14 files changed, 18 insertions(+), 33 deletions(-) New commits: commit c8695c6cce4aaa07ab2d615783d74037abb241b5 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 13:38:23 2014 +0200 Unify utl::TempFile ctors Change-Id: I0a781a86804808cebf7756506d9299971c13e2ff diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx index 609161e..9dd02ba 100644 --- a/connectivity/source/drivers/dbase/DTable.cxx +++ b/connectivity/source/drivers/dbase/DTable.cxx @@ -2453,7 +2453,7 @@ OUString ODbaseTable::createTempFile() OUString sTempName(aIdent); OUString sExt(OUString(.) + m_pConnection-getExtension()); OUString sName(m_Name); -TempFile aTempFile(sName, sExt, sTempName); +TempFile aTempFile(sName, true, sExt, sTempName); if(!aTempFile.IsValid()) getConnection()-throwGenericSQLException(STR_COULD_NOT_ALTER_TABLE, *this); diff --git a/filter/source/xsltdialog/xmlfiltertestdialog.cxx b/filter/source/xsltdialog/xmlfiltertestdialog.cxx index 8c504a6..4358071 100644 --- a/filter/source/xsltdialog/xmlfiltertestdialog.cxx +++ b/filter/source/xsltdialog/xmlfiltertestdialog.cxx @@ -430,7 +430,7 @@ void XMLFilterTestDialog::doExport( Reference XComponent xComp ) if( xStorable.is() ) { OUString const ext(.xml); -utl::TempFile aTempFile(OUString(), ext); +utl::TempFile aTempFile(OUString(), true, ext); OUString aTempFileURL( aTempFile.GetURL() ); const application_info_impl* pAppInfo = getApplicationInfo( m_pFilterInfo-maExportService ); @@ -593,7 +593,7 @@ void XMLFilterTestDialog::import( const OUString rURL ) if( m_pCBXDisplaySource-IsChecked() ) { OUString const ext(.xml); -TempFile aTempFile(OUString(), ext); +TempFile aTempFile(OUString(), true, ext); OUString aTempFileURL( aTempFile.GetURL() ); Reference XImportFilter xImporter( mxContext-getServiceManager()-createInstanceWithContext( com.sun.star.documentconversion.XSLTFilter, mxContext ), UNO_QUERY ); diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index 1d5178e..715b4ba 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -3541,7 +3541,7 @@ void AutoRecovery::implts_generateNewTempURL(const OUString sBack OUString sName(sUniqueName.makeStringAndClear()); OUString sExtension(rInfo.Extension); OUString sPath(sBackupPath); -::utl::TempFile aTempFile(sName, sExtension, sPath); +::utl::TempFile aTempFile(sName, true, sExtension, sPath); rInfo.NewTempURL = aTempFile.GetURL(); } diff --git a/include/unotools/tempfile.hxx b/include/unotools/tempfile.hxx index 3299e58..67f03fb 100644 --- a/include/unotools/tempfile.hxx +++ b/include/unotools/tempfile.hxx @@ -69,17 +69,9 @@ public: Same as above; additionally the name starts with some given characters followed by a counter ( example: rLeadingChars=abc means abc0,abc1 and so on, depending on existing files in the folder ). The extension string may be f.e. .txt or , if no extension string is given, .tmp is used -*/ -TempFile( const OUString rLeadingChars, const OUString* pExtension=NULL, const OUString* pParent=NULL, -bool bDirectory=false); - -/** -Same as above; additionally the name starts with some given characters followed by a counter ( example: -rLeadingChars=abc means abc0,abc1 and so on, depending on existing files in the folder ). -The extension string may be f.e. .txt or , if no extension string is given, .tmp is used @param _bStartWithZero If set to false names will be generated like abc,abc0,abc1 */ -TempFile( const OUString rLeadingChars, bool
[Libreoffice-commits] core.git: configure.ac
configure.ac |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit e5934962bd55970c54b399351559e90d02b75b6b Author: Douglas Mencken dougmenc...@gmail.com Date: Wed May 14 07:33:48 2014 -0400 use bundled (non-system) versions of libxml2 and libxslt for OS X 10.6 fixes fdo#78612 and fdo#77893 Change-Id: Iac36211095cc009a356f335a93a184ea5078214d Reviewed-on: https://gerrit.libreoffice.org/9353 Reviewed-by: Tor Lillqvist t...@collabora.com Tested-by: Tor Lillqvist t...@collabora.com diff --git a/configure.ac b/configure.ac index 28d4291..ef6bf92 100644 --- a/configure.ac +++ b/configure.ac @@ -7820,7 +7820,11 @@ if test $with_system_libxml = auto; then with_system_libxml=$with_system_libs ;; *) -with_system_libxml=yes +if test $_os = Darwin -a $MAC_OS_X_VERSION_MAX_ALLOWED -lt 1060; then +with_system_libxml=no +else +with_system_libxml=yes +fi ;; esac fi ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/qa
chart2/qa/extras/xshape/chart2xshape.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5588d66825c800b613d67bf6dc5305ebe9c166c2 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 14:30:47 2014 +0200 loplugin:passstringbyref Change-Id: I0e97ab6ed479ba4057470946d45a0e8cda29470e diff --git a/chart2/qa/extras/xshape/chart2xshape.cxx b/chart2/qa/extras/xshape/chart2xshape.cxx index ba100a6..d46df46 100644 --- a/chart2/qa/extras/xshape/chart2xshape.cxx +++ b/chart2/qa/extras/xshape/chart2xshape.cxx @@ -41,7 +41,7 @@ private: namespace { -bool checkDumpAgainstFile( const OUString rDump, const OUString aFilePath) +bool checkDumpAgainstFile( const OUString rDump, const OUString aFilePath) { OString aOFile = OUStringToOString(aFilePath, RTL_TEXTENCODING_UTF8); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-2' - 2 commits - sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/fdo78384.docx |binary sw/qa/extras/ooxmlexport/ooxmlexport.cxx |7 +++ writerfilter/source/dmapper/DomainMapper.cxx | 11 ++- writerfilter/source/dmapper/DomainMapper_Impl.cxx | 11 +++ writerfilter/source/dmapper/DomainMapper_Impl.hxx |4 5 files changed, 32 insertions(+), 1 deletion(-) New commits: commit 0ae0cc447a71102bb8cea0ecc3ea5af486165cca Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 09:54:22 2014 +0200 writerfilter: DomainMapper_Impl::SetSymbolData() should take an int One wonders how did this work so far. Change-Id: I6aee6a2f7e15c1c4931ca5d65b6ad39d025ff9ed (cherry picked from commit 671eb12dee290607ed66f3b325f28e7bd4695cba) Signed-off-by: Andras Timar andras.ti...@collabora.com diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 92748f1..7f61328 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -325,7 +325,7 @@ void DomainMapper_Impl::RemoveLastParagraph( ) } } -void DomainMapper_Impl::SetSymbolData( bool nSymbolData ) +void DomainMapper_Impl::SetSymbolData( sal_Int32 nSymbolData ) { m_nSymboldata = nSymbolData; } diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx b/writerfilter/source/dmapper/DomainMapper_Impl.hxx index c8859a200..3c95a4c 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx @@ -461,7 +461,7 @@ public: void SetParaSectpr(bool bParaSectpr); bool GetParaSectpr(); -void SetSymbolData( bool nSymbolData ); +void SetSymbolData( sal_Int32 nSymbolData ); sal_Int32 GetSymbolData(); /// Setter method for m_bSdt. void SetSdt(bool bSdt); commit ba4b62e10924f43136c8ce048ce8504b44c5ec61 Author: Rohit Deshmukh rohit.deshm...@synerzip.com Date: Thu May 8 16:33:44 2014 +0530 fdo#78384: Fix for corruption if file contains symbols. * In case of symbol, symbol character get imported first and then font of symbols. * So we are storing symbol character and when we parse symbol font then create UNO object for text. Reviewed-on: https://gerrit.libreoffice.org/9281 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Miklos Vajna vmik...@collabora.co.uk (cherry picked from commit f51640c5f40d5132b396a9fb6589420383df1610) Signed-off-by: Andras Timar andras.ti...@collabora.com Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx writerfilter/source/dmapper/DomainMapper_Impl.cxx Change-Id: If5b79521c6a59aec02b165e8120dafdd472cdaeb diff --git a/sw/qa/extras/ooxmlexport/data/fdo78384.docx b/sw/qa/extras/ooxmlexport/data/fdo78384.docx new file mode 100644 index 000..ee10264 Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/fdo78384.docx differ diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx index 7095ea2..ee5f974 100644 --- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx +++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx @@ -2048,6 +2048,13 @@ DECLARE_OOXMLEXPORT_TEST(testFdo71785, fdo71785.docx) // crashtest } +DECLARE_OOXMLEXPORT_TEST(testFDO78384,fdo78384.docx) +{ +xmlDocPtr pXmlDoc = parseExport(word/document.xml); +if (!pXmlDoc) +return; +assertXPath(pXmlDoc, /w:document/w:body/w:p[1]/w:r[1]/w:rPr/w:rFonts,ascii,Wingdings); +} #endif CPPUNIT_PLUGIN_IMPLEMENT(); diff --git a/writerfilter/source/dmapper/DomainMapper.cxx b/writerfilter/source/dmapper/DomainMapper.cxx index c7625e3..4a520c8 100644 --- a/writerfilter/source/dmapper/DomainMapper.cxx +++ b/writerfilter/source/dmapper/DomainMapper.cxx @@ -893,7 +893,7 @@ void DomainMapper::lcl_attribute(Id nName, Value val) } else //it's a _real_ symbol { -utext( reinterpret_cast const sal_uInt8 * ( nIntValue ), 1 ); +m_pImpl-SetSymbolData(nIntValue); } break; case NS_rtf::LN_CHAR: //footnote symbol character @@ -911,7 +911,16 @@ void DomainMapper::lcl_attribute(Id nName, Value val) } else //a real symbol if (m_pImpl-GetTopContext()) +{ m_pImpl-GetTopContext()-Insert(PROP_CHAR_FONT_NAME, uno::makeAny( sStringValue )); +/* + * In case of symbol, symbol character get imported first and then font of symbols. + * So we are storing symbol character and when we parse symbol font then create UNO object for text. + */ +sal_Int32 symboldata = m_pImpl-GetSymbolData(); +utext( reinterpret_cast const sal_uInt8 * ( (symboldata) ), 1 ); +} + break; case NS_ooxml::LN_CT_Underline_val: handleUnderlineType(nIntValue,
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit b28c0afdae884dff3a2f06adce80e3520f6ebf68 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 14:52:19 2014 +0200 DomainMapper_Impl::AddDummyParaForTableInSection: shapes can't have sections Trying to add (and later remove) a dummy paragraph is just not needed at the moment, but it'll cause a real problem for textboxes. Change-Id: I9f90b515171ce4b498de49c2381b7324002e3c20 diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 9cda806..f3eb595 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -301,6 +301,9 @@ void DomainMapper_Impl::RemoveDummyParaForTableInSection() } void DomainMapper_Impl::AddDummyParaForTableInSection() { +// Shapes can't have sections. +if (IsInShape()) +return; if (!m_aTextAppendStack.empty()) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 78635, which changed state. Bug 78635 Summary: LibreOffice Importing Symbols Incorrectly from .docx https://bugs.freedesktop.org/show_bug.cgi?id=78635 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] dev-tools.git: export-validation/README
export-validation/README |5 - 1 file changed, 4 insertions(+), 1 deletion(-) New commits: commit 003d8b64e97abd433214adc1b21746b2e57a137b Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 15:15:42 2014 +0200 export-validation/README: add URL's Change-Id: I8b7d3e8d85178b5f2f72644061f88d3cfc8ea8b9 diff --git a/export-validation/README b/export-validation/README index d97aea1..2488e46 100644 --- a/export-validation/README +++ b/export-validation/README @@ -1,4 +1,7 @@ -We use ODF Validator for ODF export validation and officeotron for OOXML export validation. +We use ODF Validator [1] for ODF export validation and officeotron [2] for OOXML export validation. Both tools should be available through a wrapper script that is in the path and is called officeotron respectively odfvalidator and should have a form similar to the ones of the two scripts in this directory. + +[1] http://incubator.apache.org/odftoolkit/conformance/ODFValidator.html +[2] https://code.google.com/p/officeotron/ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: framework/inc framework/source
framework/inc/classes/filtercachedata.hxx |5 - framework/inc/dispatch/menudispatcher.hxx |1 framework/inc/dispatch/oxt_handler.hxx|2 framework/inc/dispatch/popupmenudispatcher.hxx|1 framework/inc/helper/ocomponentaccess.hxx |1 framework/inc/helper/ocomponentenumeration.hxx|1 framework/inc/services/desktop.hxx|1 framework/inc/threadhelp/transactionguard.hxx |1 framework/source/dispatch/menudispatcher.cxx |2 framework/source/fwe/classes/addonsoptions.cxx| 29 -- framework/source/helper/ocomponentaccess.cxx |2 framework/source/helper/oframes.cxx |1 framework/source/services/frame.cxx |1 framework/source/services/substitutepathvars.cxx |1 framework/source/uiconfiguration/moduleuicfgsupplier.cxx |1 framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx |1 framework/source/uiconfiguration/uiconfigurationmanager.cxx |1 17 files changed, 1 insertion(+), 51 deletions(-) New commits: commit 493bd11fcb1305e761daddb79457e84322593b53 Author: Hussian Alamri husain.a...@me.com Date: Tue May 13 18:50:42 2014 -0400 Removed redundant private methods comments diff --git a/framework/inc/classes/filtercachedata.hxx b/framework/inc/classes/filtercachedata.hxx index 6f70eb1..7ccd82e 100644 --- a/framework/inc/classes/filtercachedata.hxx +++ b/framework/inc/classes/filtercachedata.hxx @@ -82,7 +82,6 @@ struct FileType inline FileTypeoperator= ( const FileType rCopy ) { return impl_copy( rCopy ); } inline void free( ) { impl_clear(); } -// private methods private: @@ -143,7 +142,6 @@ struct Filter inline Filter operator= ( const Filter rCopy ) { return impl_copy( rCopy ); } inline void free( ) { impl_clear(); } -// private methods private: @@ -212,7 +210,6 @@ struct Detector inline Detectoroperator= ( const Detector rCopy ) { return impl_copy( rCopy ); } inline void free( ) { impl_clear(); } -// private methods private: @@ -254,7 +251,6 @@ struct Loader inline Loader operator= ( const Loader rCopy ) { return impl_copy( rCopy ); } inline void free( ) { impl_clear(); } -// private methods private: @@ -298,7 +294,6 @@ struct ContentHandler inline ContentHandler operator= ( const ContentHandler rCopy ) { return impl_copy( rCopy ); } inline void free ( ) { impl_clear(); } -// private methods private: diff --git a/framework/inc/dispatch/menudispatcher.hxx b/framework/inc/dispatch/menudispatcher.hxx index 92bde6d..a1d3f75 100644 --- a/framework/inc/dispatch/menudispatcher.hxx +++ b/framework/inc/dispatch/menudispatcher.hxx @@ -155,7 +155,6 @@ class MenuDispatcher :public ::cppu::WeakImplHelper2 virtual ~MenuDispatcher(); -// private methods private: diff --git a/framework/inc/dispatch/oxt_handler.hxx b/framework/inc/dispatch/oxt_handler.hxx index b8d6d2e..b32a53e 100644 --- a/framework/inc/dispatch/oxt_handler.hxx +++ b/framework/inc/dispatch/oxt_handler.hxx @@ -93,8 +93,6 @@ class Oxt_Handler :public ::cppu::WeakImplHelper3 protected: -// private methods - private: // variables diff --git a/framework/inc/dispatch/popupmenudispatcher.hxx b/framework/inc/dispatch/popupmenudispatcher.hxx index 8c60489..d216326 100644 --- a/framework/inc/dispatch/popupmenudispatcher.hxx +++ b/framework/inc/dispatch/popupmenudispatcher.hxx @@ -121,7 +121,6 @@ class PopupMenuDispatcher : public ::cppu::WeakImplHelper5 void impl_RetrievePopupControllerQuery(); void impl_CreateUriRefFactory(); -// private methods // variables private: diff --git a/framework/inc/helper/ocomponentaccess.hxx b/framework/inc/helper/ocomponentaccess.hxx index 570ae47..d97a74a 100644 --- a/framework/inc/helper/ocomponentaccess.hxx +++ b/framework/inc/helper/ocomponentaccess.hxx @@ -129,7 +129,6 @@ class OComponentAccess : public ::cppu::WeakImplHelper1 ::com::sun::star::co virtual ~OComponentAccess(); -// private methods private: diff --git a/framework/inc/helper/ocomponentenumeration.hxx b/framework/inc/helper/ocomponentenumeration.hxx index
[Libreoffice-commits] core.git: filter/source
filter/source/graphicfilter/ieps/ieps.cxx | 43 +- 1 file changed, 31 insertions(+), 12 deletions(-) New commits: commit 1a428ed5670e0257b21c04590ce95b86b2896ee4 Author: Caolán McNamara caol...@redhat.com Date: Wed May 14 14:12:30 2014 +0100 Related: fdo#64161 ask pstoedit to mark out the bounding box and tell pstoedit to use the original ps bounding box not its own calculation of it Change-Id: I06f3440a0def45ec8c3a4247c046ec499ed1012e diff --git a/filter/source/graphicfilter/ieps/ieps.cxx b/filter/source/graphicfilter/ieps/ieps.cxx index 26a2025..c361bc2c 100644 --- a/filter/source/graphicfilter/ieps/ieps.cxx +++ b/filter/source/graphicfilter/ieps/ieps.cxx @@ -195,17 +195,37 @@ static oslProcessError runProcessWithPathSearch(const OUString rProgName, static bool RenderAsEMF(const sal_uInt8* pBuf, sal_uInt32 nBytesRead, Graphic rGraphic) { -utl::TempFile aTemp; -aTemp.EnableKillingFile(); -OUString fileName(pstoedit EXESUFFIX); -OUString arg1(-f); -OUString arg2(emf:-OO); -OUString arg3(-); +utl::TempFile aTempOutput; +utl::TempFile aTempInput; +aTempOutput.EnableKillingFile(); +aTempInput.EnableKillingFile(); OUString output; -osl::FileBase::getSystemPathFromFileURL(aTemp.GetURL(), output); +osl::FileBase::getSystemPathFromFileURL(aTempOutput.GetURL(), output); +OUString input; +osl::FileBase::getSystemPathFromFileURL(aTempInput.GetURL(), input); + +SvStream* pInputStream = aTempInput.GetStream(STREAM_WRITE); +sal_uInt64 nCount = pInputStream-Write(pBuf, nBytesRead); +aTempInput.CloseStream(); + +OUString fileName(pstoedit EXESUFFIX); +//fdo#64161 pstoedit under non-windows uses libEMF to output the EMF, but +//libEMF cannot calculate the bounding box of text, so the overall bounding +//box is not increased to include that of any text in the eps +// +//-drawbb will force pstoedit to draw a pair of pixels with the bg color to +//the topleft and bottom right of the bounding box as pstoedit sees it, +//which libEMF will then extend its bounding box to fit +// +//-usebbfrominput forces pstoedit to take the original ps bounding box +//as the bounding box as it sees it, instead of calculating its own +//which also doesn't work for this example +OUString arg1(-usebbfrominput); //-usebbfrominput use the original ps bounding box +OUString arg2(-f); +OUString arg3(emf:-OO -drawbb); //-drawbb mark out the bounding box extent with bg pixels rtl_uString *args[] = { -arg1.pData, arg2.pData, arg3.pData, output.pData +arg1.pData, arg2.pData, arg3.pData, input.pData, output.pData }; oslProcess aProcess; oslFileHandle pIn = NULL; @@ -219,9 +239,9 @@ static bool RenderAsEMF(const sal_uInt8* pBuf, sal_uInt32 nBytesRead, Graphic r return false; bool bRet = false; -sal_uInt64 nCount; -osl_writeFile(pIn, pBuf, nBytesRead, nCount); if (pIn) osl_closeFile(pIn); +osl_joinProcess(aProcess); +osl_freeProcessHandle(aProcess); bool bEMFSupported=true; if (pOut) { @@ -235,14 +255,13 @@ static bool RenderAsEMF(const sal_uInt8* pBuf, sal_uInt32 nBytesRead, Graphic r osl_closeFile(pOut); } if (pErr) osl_closeFile(pErr); -osl_joinProcess(aProcess); -osl_freeProcessHandle(aProcess); if (nCount == nBytesRead bEMFSupported) { SvFileStream aFile(output, STREAM_READ); if (GraphicConverter::Import(aFile, rGraphic, CVT_EMF) == ERRCODE_NONE) bRet = true; } + return bRet; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: test/source
test/source/bootstrapfixture.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit d226c4726f94e5db65fdd707bce293fc0330babe Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 15:28:29 2014 +0200 Fail the test if executing the validator fails Change-Id: I15aac53a817ca309697cba8a962e788aea1619d0 diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx index 5473c2d..d166dae 100644 --- a/test/source/bootstrapfixture.cxx +++ b/test/source/bootstrapfixture.cxx @@ -164,7 +164,9 @@ void test::BootstrapFixture::validate(const OUString rPath, test::ValidationFor OUString aCommand = aValidator + rPath ++ aOutputFile; int returnValue = system(OUStringToOString(aCommand, RTL_TEXTENCODING_UTF8).getStr()); -(void)returnValue; +CPPUNIT_ASSERT_EQUAL_MESSAGE( +OUStringToOString(aCommand, RTL_TEXTENCODING_UTF8).getStr(), 0, +returnValue); OString aContentString = loadFile(aOutput.GetURL()); OUString aContentOUString = OStringToOUString(aContentString, RTL_TEXTENCODING_UTF8); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/recentdocsview.hxx|2 ++ include/sfx2/recentdocsviewitem.hxx|2 +- include/sfx2/thumbnailviewitem.hxx |2 +- sfx2/source/control/recentdocsview.cxx | 16 sfx2/source/control/recentdocsviewitem.cxx |2 +- 5 files changed, 17 insertions(+), 7 deletions(-) New commits: commit 4a902e0c59b0dd01e6459c226268bdee4f15489a Author: Maxim Monastirsky momonas...@gmail.com Date: Wed May 14 16:06:42 2014 +0300 Revert startcenter: react on mouse down instead This reverts commit 1a2a961c1e7cdef648c28e211433e8de6e8a831b. As suggested by Kendy, opening with a single click by mouse up is more natural. We need to find a better solution for the bug mentioned in the above commit. diff --git a/include/sfx2/recentdocsview.hxx b/include/sfx2/recentdocsview.hxx index 0ebf30e..c1ba062 100644 --- a/include/sfx2/recentdocsview.hxx +++ b/include/sfx2/recentdocsview.hxx @@ -63,6 +63,8 @@ public: protected: virtual void MouseButtonDown( const MouseEvent rMEvt ) SAL_OVERRIDE; +virtual void MouseButtonUp( const MouseEvent rMEvt ) SAL_OVERRIDE; + virtual void OnItemDblClicked(ThumbnailViewItem *pItem) SAL_OVERRIDE; virtual void Paint( const Rectangle rRect ) SAL_OVERRIDE; diff --git a/include/sfx2/recentdocsviewitem.hxx b/include/sfx2/recentdocsviewitem.hxx index 71b6474..b1a51fe 100644 --- a/include/sfx2/recentdocsviewitem.hxx +++ b/include/sfx2/recentdocsviewitem.hxx @@ -33,7 +33,7 @@ public: virtual void Paint(drawinglayer::processor2d::BaseProcessor2D *pProcessor, const ThumbnailItemAttributes *pAttrs) SAL_OVERRIDE; -virtual void MouseButtonDown(const MouseEvent rMEvt) SAL_OVERRIDE; +virtual void MouseButtonUp(const MouseEvent rMEvt) SAL_OVERRIDE; /// Called when the user clicks a document - it will open it. void OpenDocument(); diff --git a/include/sfx2/thumbnailviewitem.hxx b/include/sfx2/thumbnailviewitem.hxx index cf3e860..ee4fd7f 100644 --- a/include/sfx2/thumbnailviewitem.hxx +++ b/include/sfx2/thumbnailviewitem.hxx @@ -129,7 +129,7 @@ public: static drawinglayer::primitive2d::PolygonHairlinePrimitive2D* createBorderLine (const basegfx::B2DPolygon rPolygon); -virtual void MouseButtonDown(const MouseEvent) {} +virtual void MouseButtonUp(const MouseEvent) {} protected: diff --git a/sfx2/source/control/recentdocsview.cxx b/sfx2/source/control/recentdocsview.cxx index b4be9c8..0564e8b 100644 --- a/sfx2/source/control/recentdocsview.cxx +++ b/sfx2/source/control/recentdocsview.cxx @@ -213,19 +213,27 @@ void RecentDocsView::MouseButtonDown( const MouseEvent rMEvt ) { if (rMEvt.IsLeft()) { -if (rMEvt.GetClicks() 1) -return; +// ignore to avoid stuff done in ThumbnailView; we don't do selections etc. +return; +} + +ThumbnailView::MouseButtonDown(rMEvt); +} +void RecentDocsView::MouseButtonUp(const MouseEvent rMEvt) +{ +if (rMEvt.IsLeft()) +{ size_t nPos = ImplGetItem(rMEvt.GetPosPixel()); ThumbnailViewItem* pItem = ImplGetItem(nPos); if (pItem) { -pItem-MouseButtonDown(rMEvt); +pItem-MouseButtonUp(rMEvt); return; } } -ThumbnailView::MouseButtonDown(rMEvt); +ThumbnailView::MouseButtonUp(rMEvt); } void RecentDocsView::OnItemDblClicked(ThumbnailViewItem *) diff --git a/sfx2/source/control/recentdocsviewitem.cxx b/sfx2/source/control/recentdocsviewitem.cxx index 0dfef15..aa2a7e0 100644 --- a/sfx2/source/control/recentdocsviewitem.cxx +++ b/sfx2/source/control/recentdocsviewitem.cxx @@ -182,7 +182,7 @@ void RecentDocsViewItem::Paint(drawinglayer::processor2d::BaseProcessor2D *pProc } } -void RecentDocsViewItem::MouseButtonDown(const MouseEvent rMEvt) +void RecentDocsViewItem::MouseButtonUp(const MouseEvent rMEvt) { if (rMEvt.IsLeft()) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx |8 ++-- chart2/source/view/inc/GL3DBarChart.hxx|3 +++ 2 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 9a73719c394049648278203448f7ba91f919e837 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 09:36:03 2014 -0400 Try to zoom into a bar when clicked. For now we hardcode the object ID of 1. Just for testing. Change-Id: Ifec15ae0beb0a3c863085e9d43bdebd7bcce4027 diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index 35bcb51..04c3cac 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -28,7 +28,8 @@ GL3DBarChart::GL3DBarChart( OpenGLWindow rWindow) : mxChartType(xChartType), mpRenderer(new opengl3D::OpenGL3DRenderer()), -mrWindow(rWindow) +mrWindow(rWindow), +mpCamera(NULL) { mrWindow.setRenderer(this); mpRenderer-init(); @@ -65,6 +66,8 @@ void GL3DBarChart::create3DShapes(const boost::ptr_vectorVDataSeries rDataSer maShapes.clear(); maShapes.push_back(new opengl3D::Camera(mpRenderer.get())); +mpCamera = static_castopengl3D::Camera*(maShapes.back()); + sal_Int32 nSeriesIndex = 0; for (boost::ptr_vectorVDataSeries::const_iterator itr = rDataSeriesContainer.begin(), itrEnd = rDataSeriesContainer.end(); itr != itrEnd; ++itr) @@ -185,7 +188,8 @@ void GL3DBarChart::update() void GL3DBarChart::clickedAt(const Point ) { - +if (mpCamera) +mpCamera-zoom(1); } } diff --git a/chart2/source/view/inc/GL3DBarChart.hxx b/chart2/source/view/inc/GL3DBarChart.hxx index 1741b3d..92a3b6c 100644 --- a/chart2/source/view/inc/GL3DBarChart.hxx +++ b/chart2/source/view/inc/GL3DBarChart.hxx @@ -26,6 +26,7 @@ namespace opengl3D { class Renderable3DObject; class OpenGL3DRenderer; +class Camera; } @@ -53,6 +54,8 @@ private: boost::scoped_ptropengl3D::OpenGL3DRenderer mpRenderer; OpenGLWindow mrWindow; + +opengl3D::Camera* mpCamera; }; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit da33122c84c18ea78932c6ee607824c0f3d4de99 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 15:37:08 2014 +0200 Fix --with-export-validation check Change-Id: I12b99b361a10f48435694719870ed16f2ce4a31a diff --git a/configure.ac b/configure.ac index ef6bf92..053fc51 100644 --- a/configure.ac +++ b/configure.ac @@ -2633,7 +2633,7 @@ dnl === dnl Export file validation dnl === AC_MSG_CHECKING([whether to enable export file validation]) -if test with_export_validation != no; then +if test $with_export_validation = yes; then AC_MSG_RESULT([yes]) AC_DEFINE(HAVE_EXPORT_VALIDATION) else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dictionaries.git: hu_HU/hu_HU.aff hu_HU/hu_HU.dic
hu_HU/hu_HU.aff |3 ++- hu_HU/hu_HU.dic |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) New commits: commit c74b87732cb0acb7a67f326dce3b94f03d691315 Author: Andras Timar andras.ti...@collabora.com Date: Wed May 14 15:44:14 2014 +0200 hu dict: do not suggest this word Change-Id: I768e1fc63bb7669db405289bc1ac449af6bd73da diff --git a/hu_HU/hu_HU.aff b/hu_HU/hu_HU.aff index f146d0c..7174397 100644 --- a/hu_HU/hu_HU.aff +++ b/hu_HU/hu_HU.aff @@ -1,4 +1,4 @@ -AF 1262 +AF 1263 AF V˯j×LnÓéè³ÄäTtYc¸¼l # 1 AF UmÒyiYcÇ # 2 AF ÕCWR̯jÞÔíyÈÁÿYc½ # 3 @@ -1261,6 +1261,7 @@ AF DRT # 1259 AF DQS # 1260 AF @ # 1261 AF % # 1262 +AF V˯j×LnÓéè³ÄäTtYc¸¼l= # 1263 AM 22805 AM po:noun ts:NOM AM po:noun ts:NOM al:üzletágak diff --git a/hu_HU/hu_HU.dic b/hu_HU/hu_HU.dic index a0ef0ff..6b4b2bb 100644 --- a/hu_HU/hu_HU.dic +++ b/hu_HU/hu_HU.dic @@ -17426,7 +17426,7 @@ nikkel/21 1 nihilizmus/30 1 nihil/16 1 night/266 1 -nigger/1 1 +nigger/12631 niamey-i/225 4145 niacin/259 1 ni 33 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 032cd25a260a4165773a835f004257ee139d6004 Author: Andras Timar andras.ti...@collabora.com Date: Wed May 14 15:44:14 2014 +0200 Updated core Project: dictionaries c74b87732cb0acb7a67f326dce3b94f03d691315 diff --git a/dictionaries b/dictionaries index b76a214..c74b877 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit b76a214cc1e5c52cc0f012888b25aaa3b3b4e032 +Subproject commit c74b87732cb0acb7a67f326dce3b94f03d691315 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dictionaries
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 49a28f98a3c1a6622f7cce82c2a58845cbb5e705 Author: Andras Timar andras.ti...@collabora.com Date: Wed May 14 15:51:49 2014 +0200 Updated core Project: dictionaries 117686ef79d5a2a42e328dcef8af3969af933700 diff --git a/dictionaries b/dictionaries index c74b877..117686e 16 --- a/dictionaries +++ b/dictionaries @@ -1 +1 @@ -Subproject commit c74b87732cb0acb7a67f326dce3b94f03d691315 +Subproject commit 117686ef79d5a2a42e328dcef8af3969af933700 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/openglwin.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 9a9bde50204347444825572bdf62f55cccdea49b Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed May 14 16:11:14 2014 +0200 provide the click event to chart2 Change-Id: I4ee1c51d6602a089483099f5700afcb03f474d5b diff --git a/vcl/source/window/openglwin.cxx b/vcl/source/window/openglwin.cxx index c1716b7..880376c 100644 --- a/vcl/source/window/openglwin.cxx +++ b/vcl/source/window/openglwin.cxx @@ -58,6 +58,8 @@ void OpenGLWindow::MouseButtonDown( const MouseEvent rMEvt ) Color aColor = GetPixel(aPoint); SAL_WARN(vcl.opengl, aColor.GetColor()); +if(mpRenderer) +mpRenderer-clickedAt(aPoint); } void OpenGLWindow::setRenderer(IRenderer* pRenderer) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/textbox' - 2 commits - sw/source writerfilter/source
sw/source/core/doc/textboxhelper.cxx |4 writerfilter/source/dmapper/DomainMapper_Impl.cxx |3 +++ 2 files changed, 7 insertions(+) New commits: commit 356c059eddab6ec72f259f4bbbc45adbf3329c4a Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 16:06:13 2014 +0200 SwTextBoxHelper::syncProperty(): avoid crash on not-yet-inserted shape Change-Id: Ic5d6a62ec3ba2e096e9257ab7d30004cf3213069 diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index ec27548..9937778 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -105,6 +105,10 @@ uno::Any SwTextBoxHelper::getXTextAppend(SwFrmFmt* pShape, const uno::Type rTyp void SwTextBoxHelper::syncProperty(SwFrmFmt* pShape, sal_uInt16 nWID, sal_uInt8 nMemberId, const OUString rPropertyName, const css::uno::Any rValue) { +// No shape yet? Then nothing to do, initial properties are set by create(). +if (!pShape) +return; + uno::Any aValue(rValue); nMemberId = ~CONVERT_TWIPS; commit df5d8624b7dfd68e206cd484d46723af4b91b441 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 14:52:19 2014 +0200 DomainMapper_Impl::AddDummyParaForTableInSection: shapes can't have sections Change-Id: I9f90b515171ce4b498de49c2381b7324002e3c20 diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx index 410b064..248c436 100644 --- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx +++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx @@ -300,6 +300,9 @@ void DomainMapper_Impl::RemoveDummyParaForTableInSection() } void DomainMapper_Impl::AddDummyParaForTableInSection() { +// Shapes can't have sections. +if (IsInShape()) +return; if (!m_aTextAppendStack.empty()) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/textbox' - sw/inc sw/source
sw/inc/textboxhelper.hxx |2 ++ sw/source/core/doc/textboxhelper.cxx | 16 sw/source/core/unocore/unodraw.cxx |3 ++- 3 files changed, 20 insertions(+), 1 deletion(-) New commits: commit f5731a1e78896bf32fe5e7fd36b38cc21553db5a Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 17:03:45 2014 +0200 SwXShape: allow setting TextBox property to false Change-Id: I3b501d6928cded0f4684817c24674423c1d6c2da diff --git a/sw/inc/textboxhelper.hxx b/sw/inc/textboxhelper.hxx index 93a459d..0c992dc 100644 --- a/sw/inc/textboxhelper.hxx +++ b/sw/inc/textboxhelper.hxx @@ -26,6 +26,8 @@ class SwTextBoxHelper public: /// Create a TextBox for a shape. static void create(SwFrmFmt* pShape); +/// Destroy a TextBox for a shape. +static void destroy(SwFrmFmt* pShape); /// Get XTextAppend of a shape's TextBox, if there is any. static css::uno::Any getXTextAppend(SwFrmFmt* pShape, const css::uno::Type rType); /// Sync property of TextBox with the one of the shape. diff --git a/sw/source/core/doc/textboxhelper.cxx b/sw/source/core/doc/textboxhelper.cxx index 9937778..faadb5f 100644 --- a/sw/source/core/doc/textboxhelper.cxx +++ b/sw/source/core/doc/textboxhelper.cxx @@ -65,6 +65,22 @@ void SwTextBoxHelper::create(SwFrmFmt* pShape) } } +void SwTextBoxHelper::destroy(SwFrmFmt* pShape) +{ +// If a TextBox was enabled previously +if (pShape-GetAttrSet().HasItem(RES_CNTNT)) +{ +SwFrmFmt* pFmt = findTextBox(pShape); + +// Unlink the TextBox's text range from the original shape. +pShape-ResetFmtAttr(RES_CNTNT); + +// Delete the associated TextFrame. +if (pFmt) +pShape-GetDoc()-DelLayoutFmt(pFmt); +} +} + SwFrmFmt* SwTextBoxHelper::findTextBox(SwFrmFmt* pShape) { SwFrmFmt* pRet = 0; diff --git a/sw/source/core/unocore/unodraw.cxx b/sw/source/core/unocore/unodraw.cxx index 5ece513..6a3261b 100644 --- a/sw/source/core/unocore/unodraw.cxx +++ b/sw/source/core/unocore/unodraw.cxx @@ -1182,9 +1182,10 @@ void SwXShape::setPropertyValue(const OUString rPropertyName, const uno::Any a { bool bValue; aValue = bValue; -// If TextBox is to be enabled. if (bValue) SwTextBoxHelper::create(pFmt); +else +SwTextBoxHelper::destroy(pFmt); } // #i28749# ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/inc/swmodeltestbase.hxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 96084f9426f0184be722da800797df37f008dc9b Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 17:13:09 2014 +0200 Always remove SwModelTestBase::m_aTempFile Change-Id: I3719d1ce64bee055a4a7248361f2d2dccaa75cdc diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx b/sw/qa/extras/inc/swmodeltestbase.hxx index daac08b..84f445d 100644 --- a/sw/qa/extras/inc/swmodeltestbase.hxx +++ b/sw/qa/extras/inc/swmodeltestbase.hxx @@ -132,7 +132,7 @@ public: mpFilter(pFilter), m_nStartTime(0), m_bExported(false) -{} +{ m_aTempFile.EnableKillingFile(); } virtual ~SwModelTestBase() {} @@ -495,7 +495,6 @@ protected: aMediaDescriptor[FilterName] = aFilterName; if (!maFilterOptions.isEmpty()) aMediaDescriptor[FilterOptions] = maFilterOptions; -m_aTempFile.EnableKillingFile(); xStorable-storeToURL(m_aTempFile.GetURL(), aMediaDescriptor.getAsConstPropertyValueList()); uno::Referencelang::XComponent xComponent(xStorable, uno::UNO_QUERY); xComponent-dispose(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Need info on sd/source/ui/accessibility.po for l10n
Hi Caolán Le 13/05/2014 15:31, Marina Latini a écrit : [...] Da: Caolán McNamara caol...@redhat.com A: Sophie gautier.sop...@gmail.com Cc: libreoffice-dev libreoffice@lists.freedesktop.org, LibreOffice-l10n l...@global.libreoffice.org Inviato: Martedì, 13 maggio 2014 14:58:37 Oggetto: Re: Need info on sd/source/ui/accessibility.po for l10n Looking at where they get used, they are the accessibility descriptions for the things they describe, presentation pages and notes and so on. So you'd need an accessibility tool to hear them read out as you select them in the UI. Anyway, it looks completely safe to separate them with spaces and remove the capitals etc, and just format them as natural for your language. We should probably separate them in the English version too. Thanks a lot for your feedback and clear explanation :) Cheers Sophie ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 6 commits - formula/source include/formula sc/inc sc/source
formula/source/core/api/FormulaCompiler.cxx | 43 formula/source/ui/dlg/formula.cxx |4 +- include/formula/FormulaCompiler.hxx | 11 +++ sc/inc/compiler.hxx |8 ++--- sc/source/core/data/formulacell.cxx |2 + sc/source/core/data/grouptokenconverter.cxx |4 -- sc/source/core/opencl/formulagroupcl.cxx| 14 - sc/source/core/tool/compiler.cxx| 13 ++-- sc/source/core/tool/token.cxx |9 - sc/source/ui/miscdlgs/anyrefdg.cxx |3 + sc/source/ui/unoobj/tokenuno.cxx|4 +- 11 files changed, 68 insertions(+), 47 deletions(-) New commits: commit d459c3648c28981250809ae3e3cf02dde7157f51 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 13:12:21 2014 -0400 Enable vectorization for the jump function opcodes. Change-Id: I24333db598943a0984fb1abb603e90b79d37d845 diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 0bc46f9..4f4cbf6 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -1328,10 +1328,15 @@ void ScTokenArray::CheckToken( const FormulaToken r ) if (SC_OPCODE_START_FUNCTION = eOp eOp SC_OPCODE_STOP_FUNCTION) { -// This is a function opcode. For now, we only support vectorization -// for min, max, sum and average. +// We support vectorization for the following opcodes. switch (eOp) { +case ocIf: +case ocIfError: +case ocIfNA: +case ocChose: +// Jump commands are now supported. +break; case ocAverage: case ocMin: case ocMinA: commit 17774c46a470dbcd35c9efd2c730acb396dc6539 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 13:01:17 2014 -0400 Disable jump command reordering of RPN tokens for OpenCL interpreter. Change-Id: I03e1e8a8cda1ff88b1d65876ffc27605090f1f4d diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 0c2755b..78c847e 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -3678,6 +3678,8 @@ bool ScFormulaCell::InterpretFormulaGroup() return false; } +// The converted code does not have RPN tokens yet. The interpreter will +// generate them. mxGroup-meCalcState = sc::GroupCalcRunning; if (!sc::FormulaGroupInterpreter::getStatic()-interpret(*pDocument, mxGroup-mpTopCell-aPos, mxGroup, aCode)) { diff --git a/sc/source/core/data/grouptokenconverter.cxx b/sc/source/core/data/grouptokenconverter.cxx index 47585fd..a43efb0 100644 --- a/sc/source/core/data/grouptokenconverter.cxx +++ b/sc/source/core/data/grouptokenconverter.cxx @@ -226,10 +226,6 @@ bool ScGroupTokenConverter::convert(ScTokenArray rCode) } } -ScCompiler aComp(mrDoc, mrPos, mrGroupTokens); -aComp.SetGrammar(mrDoc.GetGrammar()); -aComp.CompileTokenArray(); // Regenerate RPN tokens. - return true; } diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx index d4873b6..7066c4f 100644 --- a/sc/source/core/opencl/formulagroupcl.cxx +++ b/sc/source/core/opencl/formulagroupcl.cxx @@ -3433,20 +3433,20 @@ CompiledFormula* FormulaGroupInterpreterOpenCL::createCompiledFormula(ScDocument ScFormulaCellGroup rGroup, ScTokenArray rCode) { -ScTokenArray aConvertedCode; -ScGroupTokenConverter aConverter(aConvertedCode, rDoc, *rGroup.mpTopCell, rTopPos); -if (!aConverter.convert(rCode) || aConvertedCode.GetLen() == 0) -return NULL; - SymbolTable::nR = rGroup.mnLength; - -return DynamicKernel::create(rDoc, rTopPos, aConvertedCode); +return DynamicKernel::create(rDoc, rTopPos, rCode); } bool FormulaGroupInterpreterOpenCL::interpret( ScDocument rDoc, const ScAddress rTopPos, ScFormulaCellGroupRef xGroup, ScTokenArray rCode ) { +ScCompiler aComp(rDoc, rTopPos, rCode); +aComp.SetGrammar(rDoc.GetGrammar()); +// Disable special ordering for jump commands for the OpenCL interpreter. +aComp.EnableJumpCommandReorder(false); +aComp.CompileTokenArray(); // Regenerate RPN tokens. + DynamicKernel *pKernel = NULL; boost::scoped_ptrDynamicKernel pLocalKernel; commit ffa18f56511a91294a3f45bdee9767595e8c03f5 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 11:45:30 2014 -0400 Update the method comment and add assertion per what the comment says. Change-Id: I751e33a8bba732e3b7935fc41385ea5e1f8c8704 diff --git a/sc/inc/compiler.hxx b/sc/inc/compiler.hxx index 811028c..527ad76 100644 --- a/sc/inc/compiler.hxx +++ b/sc/inc/compiler.hxx @@ -392,8 +392,9
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/printaccessoryview.mm | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) New commits: commit 9f2217fd8a62a3c1f560fc26e6d56e4cade30ca2 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 20:52:42 2014 +0200 loplugin:passsequencebyref Change-Id: I3a6656117b2d2aa9d9cdcadc53a804e963f805a7 diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm index 852263a..1ee2190 100644 --- a/vcl/osx/printaccessoryview.mm +++ b/vcl/osx/printaccessoryview.mm @@ -446,12 +446,12 @@ class ControllerProperties } }; -static void filterAccelerator( rtl::OUString io_rText ) +static OUString filterAccelerator( rtl::OUString const rText ) { -rtl::OUStringBuffer aBuf( io_rText.getLength() ); +rtl::OUStringBuffer aBuf( rText.getLength() ); for( sal_Int32 nIndex = 0; nIndex != -1; ) -aBuf.append( io_rText.getToken( 0, '~', nIndex ) ); -io_rText = aBuf.makeStringAndClear(); +aBuf.append( rText.getToken( 0, '~', nIndex ) ); +return aBuf.makeStringAndClear(); } @implementation ControlTarget @@ -823,7 +823,7 @@ static void addBool( NSView* pCurParent, long rCurX, long rCurY, long nAttachO static void addRadio( NSView* pCurParent, long rCurX, long rCurY, long nAttachOffset, const rtl::OUString rText, - const rtl::OUString rProperty, Sequence rtl::OUString rChoices, sal_Int32 nSelectValue, + const rtl::OUString rProperty, Sequencertl::OUString const rChoices, sal_Int32 nSelectValue, std::vectorColumnItem rLeftColumn, std::vectorColumnItem rRightColumn, ControllerProperties* pControllerProperties, @@ -868,8 +868,7 @@ static void addRadio( NSView* pCurParent, long rCurX, long rCurY, long nAttach for( sal_Int32 m = 0; m rChoices.getLength(); m++ ) { NSCell* pCell = [pCells objectAtIndex: m]; -filterAccelerator( rChoices[m] ); -linebreakCell( pCell, rChoices[m] ); +linebreakCell( pCell, filterAccelerator( rChoices[m] ) ); // connect target and action [pCell setTarget: pCtrlTarget]; [pCell setAction: @selector(triggered:)]; @@ -898,7 +897,7 @@ static void addRadio( NSView* pCurParent, long rCurX, long rCurY, long nAttach static void addList( NSView* pCurParent, long rCurX, long rCurY, long /*nAttachOffset*/, const rtl::OUString rText, -const rtl::OUString rProperty, const Sequence rtl::OUString rChoices, sal_Int32 nSelectValue, +const rtl::OUString rProperty, Sequencertl::OUString const rChoices, sal_Int32 nSelectValue, std::vectorColumnItem rLeftColumn, std::vectorColumnItem rRightColumn, ControllerProperties* pControllerProperties, @@ -1184,7 +1183,7 @@ static void addEdit( NSView* pCurParent, long rCurX, long rCurY, long nAttachO if( rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(Text)) ) { rEntry.Value = aText; -filterAccelerator( aText ); +aText = filterAccelerator( aText ); } else if( rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(ControlType)) ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: test/source
test/source/bootstrapfixture.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 969df2a069d5b9bd90467a0ed447fcf36a90557e Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 14 21:12:23 2014 +0200 -Werror,-Wunused-function Change-Id: I894ca2eb865405a9991f921997cc22c5a34c4da2 diff --git a/test/source/bootstrapfixture.cxx b/test/source/bootstrapfixture.cxx index d166dae..b7c49ba 100644 --- a/test/source/bootstrapfixture.cxx +++ b/test/source/bootstrapfixture.cxx @@ -122,6 +122,7 @@ test::BootstrapFixture::~BootstrapFixture() { } +#if HAVE_EXPORT_VALIDATION namespace { OString loadFile(const OUString rURL) @@ -141,6 +142,7 @@ OString loadFile(const OUString rURL) } } +#endif void test::BootstrapFixture::validate(const OUString rPath, test::ValidationFormat eFormat ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/recentdocsview.hxx|3 +++ sfx2/source/control/recentdocsview.cxx | 10 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) New commits: commit f22d651487382c64d0e6ce5ce3720eaccaf1150f Author: Maxim Monastirsky momonas...@gmail.com Date: Wed May 14 22:28:40 2014 +0300 startcenter: another attempt to fix mouse up issues see commits 1a2a961c1e7cdef648c28e211433e8de6e8a831b 4a902e0c59b0dd01e6459c226268bdee4f15489a Change-Id: I94b90dfc5db779317d4dda1171aeceeac6373548 diff --git a/include/sfx2/recentdocsview.hxx b/include/sfx2/recentdocsview.hxx index c1ba062..00e339b 100644 --- a/include/sfx2/recentdocsview.hxx +++ b/include/sfx2/recentdocsview.hxx @@ -40,6 +40,9 @@ enum ApplicationType class SFX2_DLLPUBLIC RecentDocsView : public ThumbnailView { +private: +size_t mnLastMouseDownItem = THUMBNAILVIEW_ITEM_NOTFOUND; + public: RecentDocsView( Window* pParent ); virtual ~RecentDocsView(); diff --git a/sfx2/source/control/recentdocsview.cxx b/sfx2/source/control/recentdocsview.cxx index 0564e8b..0f797f6 100644 --- a/sfx2/source/control/recentdocsview.cxx +++ b/sfx2/source/control/recentdocsview.cxx @@ -213,6 +213,8 @@ void RecentDocsView::MouseButtonDown( const MouseEvent rMEvt ) { if (rMEvt.IsLeft()) { +mnLastMouseDownItem = ImplGetItem(rMEvt.GetPosPixel()); + // ignore to avoid stuff done in ThumbnailView; we don't do selections etc. return; } @@ -227,11 +229,13 @@ void RecentDocsView::MouseButtonUp(const MouseEvent rMEvt) size_t nPos = ImplGetItem(rMEvt.GetPosPixel()); ThumbnailViewItem* pItem = ImplGetItem(nPos); -if (pItem) -{ +if (pItem nPos == mnLastMouseDownItem) pItem-MouseButtonUp(rMEvt); + +mnLastMouseDownItem = THUMBNAILVIEW_ITEM_NOTFOUND; + +if (pItem) return; -} } ThumbnailView::MouseButtonUp(rMEvt); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/sfx2 sfx2/source
include/sfx2/recentdocsview.hxx|4 +--- sfx2/source/control/recentdocsview.cxx |1 + 2 files changed, 2 insertions(+), 3 deletions(-) New commits: commit ed1d0f0c45b616bf67a571d8f09e30673e0be77e Author: Maxim Monastirsky momonas...@gmail.com Date: Wed May 14 22:46:33 2014 +0300 fix build Change-Id: I40b7f9388388e05ab5b034ac81861aa34a23d2a8 diff --git a/include/sfx2/recentdocsview.hxx b/include/sfx2/recentdocsview.hxx index 00e339b..453eb3f 100644 --- a/include/sfx2/recentdocsview.hxx +++ b/include/sfx2/recentdocsview.hxx @@ -40,9 +40,6 @@ enum ApplicationType class SFX2_DLLPUBLIC RecentDocsView : public ThumbnailView { -private: -size_t mnLastMouseDownItem = THUMBNAILVIEW_ITEM_NOTFOUND; - public: RecentDocsView( Window* pParent ); virtual ~RecentDocsView(); @@ -80,6 +77,7 @@ protected: longmnTextHeight; longmnItemPadding; longmnItemMaxTextLength; +size_t mnLastMouseDownItem; /// Image that appears when there is no recent document. Image maWelcomeImage; diff --git a/sfx2/source/control/recentdocsview.cxx b/sfx2/source/control/recentdocsview.cxx index 0f797f6..80bbde8 100644 --- a/sfx2/source/control/recentdocsview.cxx +++ b/sfx2/source/control/recentdocsview.cxx @@ -47,6 +47,7 @@ RecentDocsView::RecentDocsView( Window* pParent ) , maWelcomeImage(SfxResId(IMG_WELCOME)) , maWelcomeLine1(SfxResId(STR_WELCOME_LINE1)) , maWelcomeLine2(SfxResId(STR_WELCOME_LINE2)) +, mnLastMouseDownItem(THUMBNAILVIEW_ITEM_NOTFOUND) { Rectangle aScreen = Application::GetScreenPosSizePixel(Application::GetDisplayBuiltInScreen()); mnItemMaxSize = std::min(aScreen.GetWidth(),aScreen.GetHeight()) 800 ? 256 : 192; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/control/recentdocsview.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0c53ccd11f6a4318c29fd76cbc3de4e80dff769c Author: Maxim Monastirsky momonas...@gmail.com Date: Wed May 14 22:58:16 2014 +0300 Fix warning Change-Id: I90187024bc599f66bb99295ed342e106080adeb7 diff --git a/sfx2/source/control/recentdocsview.cxx b/sfx2/source/control/recentdocsview.cxx index 80bbde8..d0a59e9 100644 --- a/sfx2/source/control/recentdocsview.cxx +++ b/sfx2/source/control/recentdocsview.cxx @@ -44,10 +44,10 @@ RecentDocsView::RecentDocsView( Window* pParent ) , mnTextHeight(30) , mnItemPadding(5) , mnItemMaxTextLength(30) +, mnLastMouseDownItem(THUMBNAILVIEW_ITEM_NOTFOUND) , maWelcomeImage(SfxResId(IMG_WELCOME)) , maWelcomeLine1(SfxResId(STR_WELCOME_LINE1)) , maWelcomeLine2(SfxResId(STR_WELCOME_LINE2)) -, mnLastMouseDownItem(THUMBNAILVIEW_ITEM_NOTFOUND) { Rectangle aScreen = Application::GetScreenPosSizePixel(Application::GetDisplayBuiltInScreen()); mnItemMaxSize = std::min(aScreen.GetWidth(),aScreen.GetHeight()) 800 ? 256 : 192; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
coverity#735354 SQL_ODBC_SQL_CONFORMANCE same on both sides
connectivity/source/drivers/odbc/ODatabaseMetaData.cxx:1502 is.. 1501 ... SQL_ODBC_SQL_CONFORMANCE ... 1502 ... SQL_OSC_CORE || ... SQL_OAC_LEVEL1 || ... SQL_OAC_LEVEL2 ... and coverity complains that SQL_OAC_LEVEL1 and SQL_OSC_CORE are both 1. Looking at external/unixODBC/inc/odbc/sqlext.h I see that... /* SQL_ODBC_SQL_CONFORMANCE values */ #define SQL_OSC_MINIMUM 0x #define SQL_OSC_CORE0x0001 #define SQL_OSC_EXTENDED0x0002 while... /* SQL_ODBC_API_CONFORMANCE values */ #define SQL_OAC_NONE0x #define SQL_OAC_LEVEL1 0x0001 #define SQL_OAC_LEVEL2 0x0002 i.e. we're randomly comparing a SQL_ODBC_API_CONFORMANCE value against a result from SQL_ODBC_SQL_CONFORMANCE so it looks like it should either be... SQL_OSC_MINIMUM || SQL_OSC_CORE || SQL_OSC_EXTENDED which would be a change in logic, but perhaps the intent, or SQL_OSC_CORE || SQL_OSC_EXTENDED which would keep the status quo (which is 13 years since 26f4169ad38df90493149e8c0b2270eb8e47d541). Any thoughts on which is preferable? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: formula/source include/formula sc/source
formula/source/core/api/vectortoken.cxx | 29 +++- include/formula/vectortoken.hxx |5 sc/source/core/data/column2.cxx | 20 +-- sc/source/core/data/grouptokenconverter.cxx |6 + 4 files changed, 45 insertions(+), 15 deletions(-) New commits: commit b6b0b95bae845a2a59831f4e3ae63de3e54a2984 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 16:23:11 2014 -0400 Bail out of group calculation in case the array fetching fails. Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3 diff --git a/formula/source/core/api/vectortoken.cxx b/formula/source/core/api/vectortoken.cxx index bd75efb..c1ff94c 100644 --- a/formula/source/core/api/vectortoken.cxx +++ b/formula/source/core/api/vectortoken.cxx @@ -11,15 +11,34 @@ namespace formula { -VectorRefArray::VectorRefArray() : mpNumericArray(NULL), mpStringArray(NULL) {} -VectorRefArray::VectorRefArray( const double* pArray ) : mpNumericArray(pArray), mpStringArray(NULL) {} -VectorRefArray::VectorRefArray( rtl_uString** pArray ) : mpNumericArray(NULL), mpStringArray(pArray) {} +VectorRefArray::VectorRefArray() : +mpNumericArray(NULL), +mpStringArray(NULL), +mbValid(true) {} + +VectorRefArray::VectorRefArray( InitInvalid ) : +mpNumericArray(NULL), +mpStringArray(NULL), +mbValid(false) {} + +VectorRefArray::VectorRefArray( const double* pArray ) : +mpNumericArray(pArray), +mpStringArray(NULL), +mbValid(true) {} + +VectorRefArray::VectorRefArray( rtl_uString** pArray ) : +mpNumericArray(NULL), +mpStringArray(pArray), +mbValid(true) {} + VectorRefArray::VectorRefArray( const double* pNumArray, rtl_uString** pStrArray ) : -mpNumericArray(pNumArray), mpStringArray(pStrArray) {} +mpNumericArray(pNumArray), +mpStringArray(pStrArray), +mbValid(true) {} bool VectorRefArray::isValid() const { -return mpNumericArray || mpStringArray; +return mbValid; } SingleVectorRefToken::SingleVectorRefToken( const VectorRefArray rArray, size_t nReqLength, size_t nArrayLength ) : diff --git a/include/formula/vectortoken.hxx b/include/formula/vectortoken.hxx index 125dd40..0c28f7e 100644 --- a/include/formula/vectortoken.hxx +++ b/include/formula/vectortoken.hxx @@ -34,10 +34,15 @@ namespace formula { */ struct FORMULA_DLLPUBLIC VectorRefArray { +enum InitInvalid { Invalid }; + const double* mpNumericArray; rtl_uString** mpStringArray; +bool mbValid; + VectorRefArray(); +VectorRefArray( InitInvalid ); VectorRefArray( const double* pArray ); VectorRefArray( rtl_uString** pArray ); VectorRefArray( const double* pNumArray, rtl_uString** pStrArray ); diff --git a/sc/source/core/data/column2.cxx b/sc/source/core/data/column2.cxx index 56fe643..d6019be 100644 --- a/sc/source/core/data/column2.cxx +++ b/sc/source/core/data/column2.cxx @@ -2426,7 +2426,7 @@ bool hasNonEmpty( const sc::FormulaGroupContext::StrArrayType rArray, SCROW nRo formula::VectorRefArray ScColumn::FetchVectorRefArray( SCROW nRow1, SCROW nRow2 ) { if (nRow1 nRow2) -return formula::VectorRefArray(); +return formula::VectorRefArray(formula::VectorRefArray::Invalid); // See if the requested range is already cached. sc::FormulaGroupContext rCxt = pDocument-GetFormulaGroupContext(); @@ -2470,13 +2470,13 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( SCROW nRow1, SCROW nRow2 pColArray = rCxt.setCachedColArray(nTab, nCol, rArray, NULL); if (!pColArray) // Failed to insert a new cached column array. -return formula::VectorRefArray(); +return formula::VectorRefArray(formula::VectorRefArray::Invalid); // Fill the remaining array with values from the following blocks. size_t nPos = itBlk-size; ++itBlk; if (!appendToBlock(pDocument, rCxt, *pColArray, nPos, nRow2+1, itBlk, maCells.end())) -return formula::VectorRefArray(); +return formula::VectorRefArray(formula::VectorRefArray::Invalid); if (pColArray-mpStrArray) return formula::VectorRefArray((*pColArray-mpNumArray)[nRow1], (*pColArray-mpStrArray)[nRow1]); @@ -2507,7 +2507,7 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( SCROW nRow1, SCROW nRow2 size_t nPos = itBlk-size; ++itBlk; if (!appendToBlock(pDocument, rCxt, *pColArray, nPos, nRow2+1, itBlk, maCells.end())) -return formula::VectorRefArray(); +return formula::VectorRefArray(formula::VectorRefArray::Invalid); if (pColArray-mpNumArray) return formula::VectorRefArray((*pColArray-mpNumArray)[nRow1], (*pColArray-mpStrArray)[nRow1]); @@ -2524,7 +2524,7 @@ formula::VectorRefArray ScColumn::FetchVectorRefArray( SCROW nRow1,
[Libreoffice-commits] core.git: 4 commits - oox/source reportdesign/inc reportdesign/Library_rpt.mk reportdesign/Library_rptui.mk reportdesign/Library_rptxml.mk reportdesign/source sfx2/source
oox/source/export/drawingml.cxx |6 reportdesign/Library_rpt.mk |2 reportdesign/Library_rptui.mk |2 reportdesign/Library_rptxml.mk |2 reportdesign/inc/PropertyForward.hxx|2 reportdesign/inc/RptPage.hxx|2 reportdesign/inc/dllapi.h |2 reportdesign/inc/pch/precompiled_rpt.cxx| 12 reportdesign/inc/pch/precompiled_rpt.hxx| 204 +++ reportdesign/inc/pch/precompiled_rptui.cxx | 12 reportdesign/inc/pch/precompiled_rptui.hxx | 319 reportdesign/inc/pch/precompiled_rptxml.cxx | 12 reportdesign/inc/pch/precompiled_rptxml.hxx | 132 reportdesign/source/core/api/services.cxx |2 reportdesign/source/core/inc/ReportControlModel.hxx |8 reportdesign/source/filter/xml/xmlControlProperty.cxx |2 reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx |8 reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx |8 reportdesign/source/ui/dlg/AddField.cxx |2 reportdesign/source/ui/dlg/Navigator.cxx|6 reportdesign/source/ui/inc/AddField.hxx |2 reportdesign/source/ui/inc/DataProviderHandler.hxx | 24 reportdesign/source/ui/inc/DesignView.hxx |2 reportdesign/source/ui/inc/FixedTextColor.hxx |2 reportdesign/source/ui/inc/FormattedFieldBeautifier.hxx |2 reportdesign/source/ui/inc/GeometryHandler.hxx | 20 reportdesign/source/ui/inc/GroupsSorting.hxx|2 reportdesign/source/ui/inc/ReportComponentHandler.hxx | 12 reportdesign/source/ui/inc/ReportControllerObserver.hxx |4 reportdesign/source/ui/inc/ReportSection.hxx|2 reportdesign/source/ui/inc/ReportWindow.hxx |2 reportdesign/source/ui/inc/ScrollHelper.hxx |4 reportdesign/source/ui/inc/ViewsWindow.hxx |8 reportdesign/source/ui/inspection/GeometryHandler.cxx |4 reportdesign/source/ui/inspection/metadata.cxx |2 reportdesign/source/ui/report/ScrollHelper.cxx |2 sfx2/source/doc/graphhelp.cxx |5 37 files changed, 770 insertions(+), 74 deletions(-) New commits: commit 7ea20ee3d08ef409d6bfbac222b20d0791294558 Author: Thomas Arnhold tho...@arnhold.org Date: Wed May 14 22:25:00 2014 +0200 WaE: warning C4701: potentially uninitialized local variable Change-Id: I00a4ebdcfc278274a567403bc1ccb5332ada836f diff --git a/oox/source/export/drawingml.cxx b/oox/source/export/drawingml.cxx index 2f9f7f2..1d663e4 100644 --- a/oox/source/export/drawingml.cxx +++ b/oox/source/export/drawingml.cxx @@ -2497,7 +2497,8 @@ void DrawingML::WriteShape3DEffects( Reference XPropertySet xPropSet ) if( aExtrusionColorProps.getLength() 0 ) { OUString sSchemeClr; -sal_Int32 nColor, nTransparency; +sal_Int32 nColor(0); +sal_Int32 nTransparency(0); Sequence PropertyValue aColorTransformations; for( sal_Int32 i=0; i aExtrusionColorProps.getLength(); ++i ) { @@ -2522,7 +2523,8 @@ void DrawingML::WriteShape3DEffects( Reference XPropertySet xPropSet ) if( aContourColorProps.getLength() 0 ) { OUString sSchemeClr; -sal_Int32 nColor, nTransparency; +sal_Int32 nColor(0); +sal_Int32 nTransparency(0); Sequence PropertyValue aColorTransformations; for( sal_Int32 i=0; i aContourColorProps.getLength(); ++i ) { commit 057d59533695f3a283c0a4427813d76a27798a20 Author: Thomas Arnhold tho...@arnhold.org Date: Wed May 14 22:21:23 2014 +0200 warning C4305: 'argument' : truncation from 'const rtl::OUString *' ...to 'bool' Change-Id: If2b2b1bf27b8e241be131c3ac63c79f8211f47d9 diff --git a/sfx2/source/doc/graphhelp.cxx b/sfx2/source/doc/graphhelp.cxx index d0c9db6..c2aa204 100644 --- a/sfx2/source/doc/graphhelp.cxx +++ b/sfx2/source/doc/graphhelp.cxx @@ -84,10 +84,7 @@ void* GraphicHelper::getEnhMetaFileFromGDI_Impl( const GDIMetaFile* pGDIMeta ) if ( pGDIMeta ) { OUString const aStr(.emf); -::utl::TempFile aTempFile( OUString(), - aStr, - NULL, - sal_False ); +::utl::TempFile aTempFile( OUString(), true, aStr ); OUString aMetaFile = aTempFile.GetFileName(); OUString aMetaURL = aTempFile.GetURL(); commit c12998c9d342b36d255e03c792fa737d49d4371b Author: Thomas Arnhold
[Libreoffice-commits] core.git: 3 commits - include/filter sw/source
include/filter/msfilter/sprmids.hxx | 315 --- sw/source/core/doc/docbm.cxx|3 sw/source/filter/ww8/sprmids.hxx| 316 sw/source/filter/ww8/wrtw8nds.cxx |2 sw/source/filter/ww8/wrtw8num.cxx |2 sw/source/filter/ww8/wrtw8sty.cxx |2 sw/source/filter/ww8/wrtww8.cxx |2 sw/source/filter/ww8/wrtww8gr.cxx |2 sw/source/filter/ww8/ww8atr.cxx |2 sw/source/filter/ww8/ww8par2.cxx|2 sw/source/filter/ww8/ww8par3.cxx|2 sw/source/filter/ww8/ww8par4.cxx|2 sw/source/filter/ww8/ww8par6.cxx|2 sw/source/filter/ww8/ww8scan.cxx|2 14 files changed, 329 insertions(+), 327 deletions(-) New commits: commit a14752a864b098976f684036cda1bd5d9c0dafc8 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 22:24:55 2014 +0200 coverity#704863 Unchecked dynamic_cast Change-Id: I0c451cb576dc1818043816390b14c32607609748 diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx index 9e1d2e2..b28239f 100644 --- a/sw/source/core/doc/docbm.cxx +++ b/sw/source/core/doc/docbm.cxx @@ -472,7 +472,8 @@ namespace sw { namespace mark sw::mark::IMark* pMark = makeMark( rPaM, rName, IDocumentMarkAccess::TEXT_FIELDMARK ); sw::mark::IFieldmark* pFieldMark = dynamic_castsw::mark::IFieldmark*( pMark ); -pFieldMark-SetFieldname( rType ); +if (pFieldMark) +pFieldMark-SetFieldname( rType ); return pFieldMark; } commit e8b74ad4135f9bddee4da2c85cdb3d5d0973d687 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 14 22:20:28 2014 +0200 sw: fix indentation in sprmids Change-Id: Ifebb34942ab5d5e75d2ff9797c0450a825f955b8 diff --git a/sw/source/filter/ww8/sprmids.hxx b/sw/source/filter/ww8/sprmids.hxx index 656d624..a76a6de 100644 --- a/sw/source/filter/ww8/sprmids.hxx +++ b/sw/source/filter/ww8/sprmids.hxx @@ -21,293 +21,294 @@ #include sal/types.h -namespace NS_sprm { -const sal_uInt16 LN_PContextualSpacing = 0x246d; -const sal_uInt16 LN_PIstdPermute = 0xc601; -const sal_uInt16 LN_PTabProps = 0x646b; -const sal_uInt16 LN_TFCantSplit90 = 0x3466; -const sal_uInt16 LN_TCantSplit = 0x3644; -const sal_uInt16 LN_PIncLvl = 0x2602; -const sal_uInt16 LN_PJcExtra = 0x2461; -const sal_uInt16 LN_PJc = 0x2403; -const sal_uInt16 LN_PFSideBySide = 0x2404; -const sal_uInt16 LN_PFKeep = 0x2405; -const sal_uInt16 LN_PFKeepFollow = 0x2406; -const sal_uInt16 LN_PFPageBreakBefore = 0x2407; -const sal_uInt16 LN_PBrcl = 0x2408; -const sal_uInt16 LN_PBrcp = 0x2409; -const sal_uInt16 LN_PIlvl = 0x260a; -const sal_uInt16 LN_PIlfo = 0x460b; -const sal_uInt16 LN_PFNoLineNumb = 0x240c; -const sal_uInt16 LN_PChgTabsPapx = 0xc60d; -const sal_uInt16 LN_PDxaRight = 0x840e; -const sal_uInt16 LN_PDxaLeft = 0x840f; -const sal_uInt16 LN_PNest = 0x4610; -const sal_uInt16 LN_PDxaLeft180 = 0x8411; -const sal_uInt16 LN_PDyaLine = 0x6412; -const sal_uInt16 LN_PDyaBefore = 0xa413; -const sal_uInt16 LN_PDyaAfter = 0xa414; -const sal_uInt16 LN_PChgTabs = 0xc615; -const sal_uInt16 LN_PFInTable = 0x2416; -const sal_uInt16 LN_PCell = 0x244b; -const sal_uInt16 LN_PRow = 0x244c; -const sal_uInt16 LN_PFTtp = 0x2417; -const sal_uInt16 LN_PDxaAbs = 0x8418; -const sal_uInt16 LN_PDyaAbs = 0x8419; -const sal_uInt16 LN_PDxaWidth = 0x841a; -const sal_uInt16 LN_PPc = 0x261b; -const sal_uInt16 LN_PBrcTop10 = 0x461c; -const sal_uInt16 LN_PBrcLeft10 = 0x461d; -const sal_uInt16 LN_PBrcBottom10 = 0x461e; -const sal_uInt16 LN_PBrcRight10 = 0x461f; -const sal_uInt16 LN_PBrcBetween10 = 0x4620; -const sal_uInt16 LN_PBrcBar10 = 0x4621; -const sal_uInt16 LN_PDxaFromText10 = 0x4622; -const sal_uInt16 LN_PWr = 0x2423; -const sal_uInt16 LN_PBrcBar = 0x6629; -const sal_uInt16 LN_PFNoAutoHyph = 0x242a; -const sal_uInt16 LN_PWHeightAbs = 0x442b; -const sal_uInt16 LN_PDcs = 0x442c; -const sal_uInt16 LN_PShd = 0x442d; -const sal_uInt16 LN_PDyaFromText = 0x842e; -const sal_uInt16 LN_PDxaFromText = 0x842f; -const sal_uInt16 LN_PFLocked = 0x2430; -const sal_uInt16 LN_PFWidowControl = 0x2431; -const sal_uInt16 LN_PRuler = 0xc632; -const sal_uInt16 LN_PFKinsoku = 0x2433; -const sal_uInt16 LN_PFWordWrap = 0x2434; -const sal_uInt16 LN_PFOverflowPunct = 0x2435; -const sal_uInt16 LN_PFTopLinePunct = 0x2436; -const sal_uInt16 LN_PFAutoSpaceDE = 0x2437; -const sal_uInt16 LN_PFAutoSpaceDN = 0x2438; -const sal_uInt16 LN_PWAlignFont = 0x4439; -const sal_uInt16 LN_PFrameTextFlow = 0x443a; -const sal_uInt16 LN_PISnapBaseLine = 0x243b; -const sal_uInt16 LN_PAnld = 0xc63e; -const sal_uInt16 LN_PPropRMark = 0xc63f; -const sal_uInt16 LN_POutLvl = 0x2640; -const sal_uInt16
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/doc/graphhelp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5e41d7e63829a0a74576615fde149084621d2e8f Author: Thomas Arnhold tho...@arnhold.org Date: Wed May 14 22:41:25 2014 +0200 bool conversion for windows, too Change-Id: I38e481ce7d4eeea6679e33640555469cd18d3109 diff --git a/sfx2/source/doc/graphhelp.cxx b/sfx2/source/doc/graphhelp.cxx index c2aa204..f1d0bc5 100644 --- a/sfx2/source/doc/graphhelp.cxx +++ b/sfx2/source/doc/graphhelp.cxx @@ -184,7 +184,7 @@ void* GraphicHelper::getWinMetaFileFromGDI_Impl( const GDIMetaFile* pGDIMeta, co bool GraphicHelper::supportsMetaFileHandle_Impl() { #ifdef WNT -return sal_True; +return true; #else return false; #endif ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Semi-automated ASCII art removal tool
I have been working on a tool to semi-automate the process of removing ASCII art and pointless comments (ref: https://bugs.freedesktop.org/show_bug.cgi?id=62475). Unless someone has an alternate suggestion, for the time being I will host it here: https://bitbucket.org/MostThingsWeb/asciitool. Screenshots: http://imgur.com/a/BO0t2 I say the tool is semi-automated because while it will make a suggestion regarding what to do with each comment, it is ultimately up to you to decide what to do. The tool lets you jump immediately into Vim to edit either its suggestion or the original comment. It provides 5 lines of context before and after, like git diff. It makes a best effort at preserving justification (leading whitespace). The only preq is colorama: https://pypi.python.org/pypi/colorama I'd be interested in getting some feedback regarding this, whether it's bug reports, suggested features, or even just why bother?. If you're interested in trying it out, I'd recommend cloning the repo linked above since I'm making fixes and improvements almost each day. Chris -- View this message in context: http://nabble.documentfoundation.org/Semi-automated-ASCII-art-removal-tool-tp4108832.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/inc
sw/inc/pch/precompiled_msword.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit 67f85d7419a475c1e10b6b1d829bb0c575a39fbf Author: Thomas Arnhold tho...@arnhold.org Date: Wed May 14 23:04:48 2014 +0200 fix windows build Change-Id: Ib2e882194087e3eb85b52921f27fafc40227c52d diff --git a/sw/inc/pch/precompiled_msword.hxx b/sw/inc/pch/precompiled_msword.hxx index 1653395..e98a103 100644 --- a/sw/inc/pch/precompiled_msword.hxx +++ b/sw/inc/pch/precompiled_msword.hxx @@ -157,7 +157,6 @@ #include filter/msfilter/msdffimp.hxx #include filter/msfilter/msoleexp.hxx #include filter/msfilter/rtfutil.hxx -#include filter/msfilter/sprmids.hxx #include filter/msfilter/svxmsbas.hxx #include fstream #include functional ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: comphelper/source connectivity/source cppuhelper/source extensions/source filter/source forms/source reportdesign/source sc/source sd/source sfx2/source starmath/source
comphelper/source/property/propertycontainerhelper.cxx |6 +++--- connectivity/source/commontools/dbexception.cxx|2 +- cppuhelper/source/propertysetmixin.cxx | 10 +++--- extensions/source/propctrlr/standardcontrol.cxx|6 +++--- extensions/source/resource/ResourceIndexAccess.hxx |2 +- filter/source/config/cache/basecontainer.cxx |8 +++- forms/source/component/DatabaseForm.cxx| 14 +++--- forms/source/component/Date.cxx|2 +- forms/source/component/ListBox.cxx |6 +++--- forms/source/component/Time.cxx|2 +- forms/source/component/formcontrolfont.cxx |4 ++-- forms/source/component/refvaluecomponent.cxx |2 +- forms/source/component/scrollbar.cxx |2 +- forms/source/component/spinbutton.cxx |2 +- reportdesign/source/core/api/FixedLine.cxx |2 +- reportdesign/source/core/api/FixedText.cxx |2 +- reportdesign/source/core/api/FormattedField.cxx|2 +- reportdesign/source/core/api/Functions.cxx |2 +- reportdesign/source/core/api/Groups.cxx|2 +- reportdesign/source/core/api/ImageControl.cxx |2 +- reportdesign/source/core/api/Section.cxx |2 +- reportdesign/source/core/api/Shape.cxx |2 +- reportdesign/source/filter/xml/xmlControlProperty.cxx | 14 +++--- sc/source/ui/unoobj/cellvaluebinding.cxx |2 +- sd/source/ui/framework/factories/ViewShellWrapper.cxx |2 +- sfx2/source/notify/globalevents.cxx|2 +- starmath/source/unomodel.cxx |2 +- stoc/source/corereflection/criface.cxx |2 +- sw/source/core/access/acccell.cxx |4 ++-- sw/source/core/access/accdoc.cxx |4 ++-- sw/source/core/access/accnotextframe.cxx |4 ++-- sw/source/core/access/accpara.cxx | 10 +- sw/source/core/unocore/unofield.cxx|4 ++-- sw/source/core/unocore/unoframe.cxx|2 +- ucb/source/core/ucbcmds.cxx|8 ++-- ucb/source/ucp/cmis/cmis_content.cxx |2 +- ucb/source/ucp/ext/ucpext_content.cxx |2 +- ucb/source/ucp/file/shell.cxx |6 +++--- ucb/source/ucp/ftp/ftpcontent.cxx | 12 ++-- ucb/source/ucp/hierarchy/hierarchycontent.cxx |6 ++ ucb/source/ucp/tdoc/tdoc_content.cxx | 11 +++ vcl/qa/cppunit/dndtest.cxx |2 +- xmloff/source/draw/sdpropls.cxx|4 ++-- 43 files changed, 86 insertions(+), 103 deletions(-) New commits: commit c288b17cc5a1d5051325e02a29aa40df5be6f016 Author: Julien Nabet serval2...@yahoo.fr Date: Wed May 14 23:17:17 2014 +0200 Prefer cppu::UnoTypeT::get() to ::getCppuType((T*)0) part12 Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7 diff --git a/comphelper/source/property/propertycontainerhelper.cxx b/comphelper/source/property/propertycontainerhelper.cxx index b13b7f5..0fd8e9e 100644 --- a/comphelper/source/property/propertycontainerhelper.cxx +++ b/comphelper/source/property/propertycontainerhelper.cxx @@ -81,7 +81,7 @@ void OPropertyContainerHelper::registerProperty(const OUString _rName, sal_Int3 { OSL_ENSURE((_nAttributes PropertyAttribute::MAYBEVOID) == 0, OPropertyContainerHelper::registerProperty: don't use this for properties which may be void ! There is a method called \registerMayBeVoidProperty\ for this !); -OSL_ENSURE(!_rMemberType.equals(::getCppuType(static_cast Any* (NULL))), +OSL_ENSURE(!_rMemberType.equals(cppu::UnoTypeAny::get()), OPropertyContainerHelper::registerProperty: don't give my the type of an uno::Any ! Really can't handle this !); OSL_ENSURE(_pPointerToMember, OPropertyContainerHelper::registerProperty: you gave me nonsense : the pointer must be non-NULL); @@ -109,7 +109,7 @@ void OPropertyContainerHelper::registerMayBeVoidProperty(const OUString _rName, { OSL_ENSURE((_nAttributes PropertyAttribute::MAYBEVOID) != 0, OPropertyContainerHelper::registerMayBeVoidProperty: why calling this when the attributes say nothing about may-be-void ?); -OSL_ENSURE(!_rExpectedType.equals(::getCppuType(static_cast Any* (NULL))), +OSL_ENSURE(!_rExpectedType.equals(cppu::UnoTypeAny::get()), OPropertyContainerHelper::registerMayBeVoidProperty: don't give my the type of an uno::Any ! Really can't handle this !); OSL_ENSURE(_pPointerToMember, OPropertyContainerHelper::registerMayBeVoidProperty: you gave me nonsense : the
[Libreoffice-commits] core.git: Changes to 'private/kohei/if-or-not-if-jump'
New branch 'private/kohei/if-or-not-if-jump' available with the following commits: commit fd50548489e1804b20c2a7896a4c82a6c617adf7 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 21:05:56 2014 -0400 Write test for RPN token generation with and without jump command reordering. Change-Id: I45d83448be04e0983f39ca28392671cf84ae928c commit 308cb3bd9f7770c0378460f6a9038e77c8f783d6 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 16:23:11 2014 -0400 Bail out of group calculation in case the array fetching fails. Change-Id: Ibb7575eeb025fc025d05b147629113796185c5d3 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 39631] add optimisation helpers
https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #3 from Kohei Yoshida libreoff...@kohei.us --- That header sal/inc/sal/macros.h these days lives in include/sal/macros.h. BTW, there never was sal/inc/sal/macros.hxx. It was always sal/inc/sal/macros.h. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39631] add optimisation helpers
https://bugs.freedesktop.org/show_bug.cgi?id=39631 Michal Strnad high...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |high...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39631] add optimisation helpers
https://bugs.freedesktop.org/show_bug.cgi?id=39631 --- Comment #4 from Michal Strnad high...@gmail.com --- I am working on this bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'private/kohei/if-or-not-if-jump' - sc/qa
sc/qa/unit/ucalc.hxx |2 ++ sc/qa/unit/ucalc_formula.cxx | 16 2 files changed, 18 insertions(+) New commits: commit 223dbffa46ed3a1bfc0b47a7cfc7792ec9893b3b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 22:12:19 2014 -0400 Add unit test for IF function. Change-Id: I2265458883fb05582c54157714b88345362efa0d diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 6291fd9..6726d9b 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -153,6 +153,7 @@ public: void testFuncCELL(); void testFuncDATEDIF(); void testFuncINDIRECT(); +void testFuncIF(); void testFuncIFERROR(); void testFuncSHEET(); void testFuncNOW(); @@ -414,6 +415,7 @@ public: CPPUNIT_TEST(testFuncCELL); CPPUNIT_TEST(testFuncDATEDIF); CPPUNIT_TEST(testFuncINDIRECT); +CPPUNIT_TEST(testFuncIF); CPPUNIT_TEST(testFuncIFERROR); CPPUNIT_TEST(testFuncGETPIVOTDATA); CPPUNIT_TEST(testFuncGETPIVOTDATALeafAccess); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 3b374d7..efd1d8c 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -2793,6 +2793,22 @@ void Test::testFuncCOUNTIF() m_pDoc-DeleteTab(0); } +void Test::testFuncIF() +{ +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. + +m_pDoc-InsertTab(0, Formula); + +m_pDoc-SetString(ScAddress(0,0,0), =IF(B1=2;\two\;\not two\)); +CPPUNIT_ASSERT_EQUAL(OUString(not two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 2.0); +CPPUNIT_ASSERT_EQUAL(OUString(two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 3.0); +CPPUNIT_ASSERT_EQUAL(OUString(not two), m_pDoc-GetString(ScAddress(0,0,0))); + +m_pDoc-DeleteTab(0); +} + void Test::testFuncIFERROR() { // IFERROR/IFNA (fdo#56124) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/kohei/if-or-not-if-jump' - sc/qa
sc/qa/unit/ucalc.hxx |2 ++ sc/qa/unit/ucalc_formula.cxx | 22 ++ 2 files changed, 24 insertions(+) New commits: commit 2b4666435cde4a029d5c059266212a540220fee2 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 22:52:50 2014 -0400 Add test for CHOOSE function. This function is also a jump function requiring a special RPN reordering. Change-Id: I34f68875febeb4fb8c78527d763d4a6352f50b03 diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 6726d9b..35d57ce 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -154,6 +154,7 @@ public: void testFuncDATEDIF(); void testFuncINDIRECT(); void testFuncIF(); +void testFuncCHOOSE(); void testFuncIFERROR(); void testFuncSHEET(); void testFuncNOW(); @@ -416,6 +417,7 @@ public: CPPUNIT_TEST(testFuncDATEDIF); CPPUNIT_TEST(testFuncINDIRECT); CPPUNIT_TEST(testFuncIF); +CPPUNIT_TEST(testFuncCHOOSE); CPPUNIT_TEST(testFuncIFERROR); CPPUNIT_TEST(testFuncGETPIVOTDATA); CPPUNIT_TEST(testFuncGETPIVOTDATALeafAccess); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index efd1d8c..7720881 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -2809,6 +2809,28 @@ void Test::testFuncIF() m_pDoc-DeleteTab(0); } +void Test::testFuncCHOOSE() +{ +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. + +m_pDoc-InsertTab(0, Formula); + +m_pDoc-SetString(ScAddress(0,0,0), =CHOOSE(B1;\one\;\two\;\three\)); +sal_uInt16 nError = m_pDoc-GetErrCode(ScAddress(0,0,0)); +CPPUNIT_ASSERT_MESSAGE(Formula result should be an error since B1 is still empty., nError); +m_pDoc-SetValue(ScAddress(1,0,0), 1.0); +CPPUNIT_ASSERT_EQUAL(OUString(one), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 2.0); +CPPUNIT_ASSERT_EQUAL(OUString(two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 3.0); +CPPUNIT_ASSERT_EQUAL(OUString(three), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 4.0); +nError = m_pDoc-GetErrCode(ScAddress(0,0,0)); +CPPUNIT_ASSERT_MESSAGE(Formula result should be an error due to out-of-bound input.., nError); + +m_pDoc-DeleteTab(0); +} + void Test::testFuncIFERROR() { // IFERROR/IFNA (fdo#56124) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - sc/qa
sc/qa/unit/helper/qahelper.cxx | 12 sc/qa/unit/helper/qahelper.hxx |4 + sc/qa/unit/ucalc.hxx |6 ++ sc/qa/unit/ucalc_formula.cxx | 120 +++-- 4 files changed, 139 insertions(+), 3 deletions(-) New commits: commit 45c89d62b527abec07072074484bd596ab1aa04a Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 22:52:50 2014 -0400 Add test for CHOOSE function. This function is also a jump function requiring a special RPN reordering. Change-Id: I34f68875febeb4fb8c78527d763d4a6352f50b03 diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 6726d9b..35d57ce 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -154,6 +154,7 @@ public: void testFuncDATEDIF(); void testFuncINDIRECT(); void testFuncIF(); +void testFuncCHOOSE(); void testFuncIFERROR(); void testFuncSHEET(); void testFuncNOW(); @@ -416,6 +417,7 @@ public: CPPUNIT_TEST(testFuncDATEDIF); CPPUNIT_TEST(testFuncINDIRECT); CPPUNIT_TEST(testFuncIF); +CPPUNIT_TEST(testFuncCHOOSE); CPPUNIT_TEST(testFuncIFERROR); CPPUNIT_TEST(testFuncGETPIVOTDATA); CPPUNIT_TEST(testFuncGETPIVOTDATALeafAccess); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index efd1d8c..7720881 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -2809,6 +2809,28 @@ void Test::testFuncIF() m_pDoc-DeleteTab(0); } +void Test::testFuncCHOOSE() +{ +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. + +m_pDoc-InsertTab(0, Formula); + +m_pDoc-SetString(ScAddress(0,0,0), =CHOOSE(B1;\one\;\two\;\three\)); +sal_uInt16 nError = m_pDoc-GetErrCode(ScAddress(0,0,0)); +CPPUNIT_ASSERT_MESSAGE(Formula result should be an error since B1 is still empty., nError); +m_pDoc-SetValue(ScAddress(1,0,0), 1.0); +CPPUNIT_ASSERT_EQUAL(OUString(one), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 2.0); +CPPUNIT_ASSERT_EQUAL(OUString(two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 3.0); +CPPUNIT_ASSERT_EQUAL(OUString(three), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 4.0); +nError = m_pDoc-GetErrCode(ScAddress(0,0,0)); +CPPUNIT_ASSERT_MESSAGE(Formula result should be an error due to out-of-bound input.., nError); + +m_pDoc-DeleteTab(0); +} + void Test::testFuncIFERROR() { // IFERROR/IFNA (fdo#56124) commit 3e377f86d8c8d15c80879f8d6f1228abe2afba28 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 22:12:19 2014 -0400 Add unit test for IF function. Change-Id: I2265458883fb05582c54157714b88345362efa0d diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 6291fd9..6726d9b 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -153,6 +153,7 @@ public: void testFuncCELL(); void testFuncDATEDIF(); void testFuncINDIRECT(); +void testFuncIF(); void testFuncIFERROR(); void testFuncSHEET(); void testFuncNOW(); @@ -414,6 +415,7 @@ public: CPPUNIT_TEST(testFuncCELL); CPPUNIT_TEST(testFuncDATEDIF); CPPUNIT_TEST(testFuncINDIRECT); +CPPUNIT_TEST(testFuncIF); CPPUNIT_TEST(testFuncIFERROR); CPPUNIT_TEST(testFuncGETPIVOTDATA); CPPUNIT_TEST(testFuncGETPIVOTDATALeafAccess); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 3b374d7..efd1d8c 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -2793,6 +2793,22 @@ void Test::testFuncCOUNTIF() m_pDoc-DeleteTab(0); } +void Test::testFuncIF() +{ +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. + +m_pDoc-InsertTab(0, Formula); + +m_pDoc-SetString(ScAddress(0,0,0), =IF(B1=2;\two\;\not two\)); +CPPUNIT_ASSERT_EQUAL(OUString(not two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 2.0); +CPPUNIT_ASSERT_EQUAL(OUString(two), m_pDoc-GetString(ScAddress(0,0,0))); +m_pDoc-SetValue(ScAddress(1,0,0), 3.0); +CPPUNIT_ASSERT_EQUAL(OUString(not two), m_pDoc-GetString(ScAddress(0,0,0))); + +m_pDoc-DeleteTab(0); +} + void Test::testFuncIFERROR() { // IFERROR/IFNA (fdo#56124) commit 12383c8d7465d7057b49844695b3fc34b51186ca Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Wed May 14 21:05:56 2014 -0400 Write test for RPN token generation with and without jump command reordering. Change-Id: I45d83448be04e0983f39ca28392671cf84ae928c diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx index 951cd61..91b4a12 100644 --- a/sc/qa/unit/helper/qahelper.cxx +++ b/sc/qa/unit/helper/qahelper.cxx @@ -473,6 +473,18 @@ bool checkFormulaPositions( return true; } +ScTokenArray* compileFormula( +ScDocument* pDoc, const OUString rFormula, const ScAddress* pPos, +
Alamri Hussian - License statement
Greetings, All of my past future contributions to LibreOffice may be licensed under the MPLv2/LGPLv3+ dual license. -- Alamri Hussian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/ucalc_formula.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 282b0123a34b978ea221d88ac668ed0c4423f801 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu May 15 07:29:07 2014 +0200 error: invalid conversion from 'int' to 'formula::StackVar' Change-Id: I77280f843ae3123a6e0459becb2ce0b5fd7b78cc diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 7720881..b1ef561 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -821,11 +821,11 @@ void Test::testFormulaCompilerJumpReordering() TokenCheck aCheckRPN[] = { { ocPush, svSingleRef }, -{ ocIf,0 }, +{ ocIf,static_castformula::StackVar(0) }, { ocPush, svDouble}, -{ ocSep, 0 }, +{ ocSep, static_castformula::StackVar(0) }, { ocPush, svString}, -{ ocClose, 0 }, +{ ocClose, static_castformula::StackVar(0) }, }; sal_uInt16 nLen = pCode-GetCodeLen(); @@ -852,7 +852,7 @@ void Test::testFormulaCompilerJumpReordering() { ocPush, svSingleRef }, { ocPush, svDouble}, { ocPush, svString}, -{ ocIf,0 }, +{ ocIf,static_castformula::StackVar(0) }, }; nLen = pCode-GetCodeLen(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit fd37d0757685dfd5a19ebd262c10e5353b8f891a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Thu May 15 07:33:49 2014 +0200 change transformation matrix diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx index 04c3cac..8ceb3d9 100644 --- a/chart2/source/view/charttypes/GL3DBarChart.cxx +++ b/chart2/source/view/charttypes/GL3DBarChart.cxx @@ -72,7 +72,7 @@ void GL3DBarChart::create3DShapes(const boost::ptr_vectorVDataSeries rDataSer for (boost::ptr_vectorVDataSeries::const_iterator itr = rDataSeriesContainer.begin(), itrEnd = rDataSeriesContainer.end(); itr != itrEnd; ++itr) { -nYPos = nSeriesIndex * (nBarSizeY + nBarDistanceY) + nBarSizeY; +nYPos = nSeriesIndex * (nBarSizeY + nBarDistanceY); const VDataSeries rDataSeries = *itr; sal_Int32 nPointCount = rDataSeries.getTotalPointCount(); @@ -97,10 +97,10 @@ void GL3DBarChart::create3DShapes(const boost::ptr_vectorVDataSeries rDataSer for(sal_Int32 nIndex = 0; nIndex nPointCount; ++nIndex) { float nVal = rDataSeries.getYValue(nIndex); -float nXPos = nIndex * (nBarSizeX + nBarDistanceX) + nBarSizeX; +float nXPos = nIndex * (nBarSizeX + nBarDistanceX); -glm::mat4 aScaleMatrix = glm::scale(nBarSizeX, nBarSizeY, nVal); +glm::mat4 aScaleMatrix = glm::scale(nBarSizeX, nBarSizeY, 0); glm::mat4 aTranslationMatrix = glm::translate(nXPos, nYPos, nVal); glm::mat4 aBarPosition = aTranslationMatrix * aScaleMatrix; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] Call for papers: last days!
Hi all, Tomorrow is the end of call for proposals, so don't miss the date! All the information we need for the moment is an abstract of your talk and your bio. I'm sure you have something you want to share with us, so write it just now :) Where to post it? http://conference.libreoffice.org/2014/call-for-papers Cheers Sophie ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Running LO 4.3 alpha in Windows XP...
Hi Pedro, *, On Mon, May 5, 2014 at 12:42 AM, Pedro pedl...@gmail.com wrote: Hi all I can't do anything with LO 4.3 alpha under Windows XP Pro x86 en_US SP3: 1) create new doc, type one word, crash 2) create new spreadsheet, type anything, crash 3) create new presentation, crash 4) create new drawing, crash ... Reproducible, and only with auto-spellcheck enabled. (as also indicated by Stuart's trace) That means that the spellcheck components very likely are not compiled using proper compatibility version info. ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 78682] New: EDITING: Highlight the active row in Calc (enhancement request)
https://bugs.freedesktop.org/show_bug.cgi?id=78682 Priority: medium Bug ID: 78682 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: Highlight the active row in Calc (enhancement request) Severity: normal Classification: Unclassified OS: All Reporter: a...@tosovsky.eu Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.4.2 release Component: Spreadsheet Product: LibreOffice I would really appreciate if you could make a feature that would allow to automatically highlight the active row (or the row and even the column) while moving in spreadsheet. It would greatly improve orientation in large tables. Something like this: http://en.libreofficeforum.org/node/7548 Thanks! Operating System: All Version: 4.2.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77482] Writer: Inserting multi worded autotexts adds unnecessary line break
https://bugs.freedesktop.org/show_bug.cgi?id=77482 --- Comment #4 from a07cd040897db54e1...@spambog.com --- (In reply to comment #3) Hello Laurent, I cannot reproduce with Autotext New. I can only reproduce if I select Autotext New (Text only) which is the same as bug 53023. You are right. This seems to be the same bug. As you can see in attachment #97395 i also used New (Text only). For my case I can *NOT* workaround this issue by using Autotext New because this also adds the current formatting of the text. As we use many different preformatted document templates with styles+formatting templates these two kinds of formatting would produce inexpected results. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77431] FILESAVE : Hiding first sheet is not possible in xlsx
https://bugs.freedesktop.org/show_bug.cgi?id=77431 David Tardon dtar...@redhat.com changed: What|Removed |Added Severity|major |minor Priority|high|low CC||dtar...@redhat.com --- Comment #4 from David Tardon dtar...@redhat.com --- (In reply to comment #3) I am able to reproduce this problem as well. It is a security issue, No, it is not. Hidden sheets can be made visible again any time. because many people actually use the sheet-hiding mechanism for confidentiality. I would rather not comment on this... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] New: Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 Priority: medium Bug ID: 78683 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Font problem when opening PDF file in Impress Severity: normal Classification: Unclassified OS: All Reporter: ulrich.wi...@rz.uni-regensburg.de Hardware: Other Status: UNCONFIRMED Version: 4.1.5.3 release Component: filters and storage Product: LibreOffice Created attachment 99007 -- https://bugs.freedesktop.org/attachment.cgi?id=99007action=edit Sample PDF file Probably the scenario is unusual, but I have problems when opening PDF files in Impress (I had a DIN A5 form as PDF that I wanted to print twice on one DIN A4 sheet. As draw couldn't import or open PDF, I opened the PDF in Impress, selected all, copies and pasted it into draw, duplicated and move it to ful fill the requirement. After print I saw some unusual character spacing that wasn't seen in the Original PDF). The test case is this: I have a PDF produced with Inkscape in Linux and exported to PDF (Cairo, I think). When Opening the PDF in Impress, the problem manifests as the word Signature(s) being shown as Signa tures(2) (It seems there are other artefacts also, but I'll concentrate on that one). I'll provide a sample PDF file as well as partial screen shots, trying to show that the problem is not the PDF file. I also tried opening the PDF on the same Linux platform that created it (to rule out a missing font issue), but the result is the same. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 --- Comment #1 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 99008 -- https://bugs.freedesktop.org/attachment.cgi?id=99008action=edit Partial screen shot from PDF viewer (Signature.pdf, Acrobat on Windows 7) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 --- Comment #2 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 99009 -- https://bugs.freedesktop.org/attachment.cgi?id=99009action=edit Partial screen shot from Impress (Windows 7) showing artefact -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 --- Comment #3 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 99010 -- https://bugs.freedesktop.org/attachment.cgi?id=99010action=edit Another text artefact (different PDF, Impress on Windows 7) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 --- Comment #4 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 99011 -- https://bugs.freedesktop.org/attachment.cgi?id=99011action=edit Partial screen shot (reference) from PDF viewer (another PDF, Acrobat on Windows 7) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78573] Trojan in download
https://bugs.freedesktop.org/show_bug.cgi?id=78573 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTOURBUG --- Comment #3 from Mike Kaganski mikekagan...@hotmail.com --- Well, then, this must be a false positive. You may check this using, e.g., VirusTotal. The soffice.bin from 4.2.4.2 for Windows check result is here: https://www.virustotal.com/en/file/ec430fa2fa2be06b12fac546c2f5428e662037dfee6af1f2aec5a824dc82a9c2/analysis/1400049976/ - you may see it's clean. As this issue describes a problem in outside software (false-positive in an AV package), I close it as NOTOURBUG. You may report this to your AV software vendor. But I believe that this is already fixed, as VirusTotal scan includes results from Comodo. Next time, please don't answer to messages from Bugzilla using your email client program; instead, use the Bugzilla WEB interface. This helps keeping issues clean and understandable. Thank you for reporting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78683] Font problem when opening PDF file in Impress
https://bugs.freedesktop.org/show_bug.cgi?id=78683 Ulrich Windl ulrich.wi...@rz.uni-regensburg.de changed: What|Removed |Added Attachment #99010|Another text artefact |Another text artefact description|(different PDF, Impress on |(partial screen shot, |Windows 7) |different PDF, Impress on ||Windows 7) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60338] FILESAVE: Saved files have incorrect permissions on linux
https://bugs.freedesktop.org/show_bug.cgi?id=60338 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |sberg...@redhat.com |desktop.org | --- Comment #18 from Stephan Bergmann sberg...@redhat.com --- (In reply to comment #17) This sounds promising. I will test the daily build in a day or so (allowing time for the fix to propagate there). Note that the issue is not fully fixed yet. I'm pushing incremental changes to master, and some robot is setting this issue's whiteboard target when it sees commits that mention this issue's ID. I will make note here once the issue is fully fixed on master. The whiteboard indicates the fix is targetting 4.3.0. Since this problem more or less makes 4.2.x a non-starter in a business environment (where preservation of access modes is important), is there any chance it could be pushed into a 4.2.x maintenance release as well? It appears to be a fairly important bugfix to me, at least as far as Linux users are concerned. Depending on the ultimate fix, backporting could be somewhat tricky. And given that this issue is reported against LO 3.6 (and is probably even older than LO itself), I'm not sure how pressing a fix for 4.2 vs. 4.3 actually is overall. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78686] New: pdfimport: Allow to select pages to be imported
https://bugs.freedesktop.org/show_bug.cgi?id=78686 Priority: medium Bug ID: 78686 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: pdfimport: Allow to select pages to be imported Severity: enhancement Classification: Unclassified OS: All Reporter: ja...@rinac.com Hardware: All Status: UNCONFIRMED Version: 4.3.0.0.alpha1 Component: Extensions Product: LibreOffice Now pdf import will import all pages. For larger files, it will lot of time. If pages can selected like gimp, it will be very useful. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78592] UI: Provide RSS feed for torrent downloads
https://bugs.freedesktop.org/show_bug.cgi?id=78592 s-varoxamox...@vf.uni-konstanz.de changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78686] pdfimport: Allow to select pages to be imported
https://bugs.freedesktop.org/show_bug.cgi?id=78686 --- Comment #1 from Jaise James ja...@rinac.com --- Created attachment 99016 -- https://bugs.freedesktop.org/attachment.cgi?id=99016action=edit Gimp Pdf import Window -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78689] New: pdfimport :Table border underlines overlap with text
https://bugs.freedesktop.org/show_bug.cgi?id=78689 Priority: medium Bug ID: 78689 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: pdfimport :Table border underlines overlap with text Severity: normal Classification: Unclassified OS: All Reporter: ja...@rinac.com Hardware: Other Status: UNCONFIRMED Version: 4.3.0.0.alpha1 Component: Extensions Product: LibreOffice Table border underlines overlap with text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78689] pdfimport :Table border underlines overlap with text
https://bugs.freedesktop.org/show_bug.cgi?id=78689 --- Comment #1 from Jaise James ja...@rinac.com --- Created attachment 99024 -- https://bugs.freedesktop.org/attachment.cgi?id=99024action=edit underline overlap with text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78689] pdfimport :Table border underlines overlap with text
https://bugs.freedesktop.org/show_bug.cgi?id=78689 --- Comment #2 from Jaise James ja...@rinac.com --- Created attachment 99025 -- https://bugs.freedesktop.org/attachment.cgi?id=99025action=edit Actual file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78689] pdfimport :Table border underlines overlap with text
https://bugs.freedesktop.org/show_bug.cgi?id=78689 --- Comment #3 from Jaise James ja...@rinac.com --- Created attachment 99026 -- https://bugs.freedesktop.org/attachment.cgi?id=99026action=edit Imported draw file -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78690] New: pdfimport: mixed Page orientation[landscape portrait] not imported correctly
https://bugs.freedesktop.org/show_bug.cgi?id=78690 Priority: medium Bug ID: 78690 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: pdfimport: mixed Page orientation[landscape portrait] not imported correctly Severity: normal Classification: Unclassified OS: All Reporter: ja...@rinac.com Hardware: Other Status: UNCONFIRMED Version: 4.3.0.0.alpha1 Component: Extensions Product: LibreOffice mixed Page orientation[landscape portrait] not imported correctly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78658] Other: Corrupt: File is getting corrupt after RT because of drawing objects into a text box
https://bugs.freedesktop.org/show_bug.cgi?id=78658 Dinesh dinesh.pa...@synerzip.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |dinesh.pa...@synerzip.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78693] New: The following piece of code generates an error when closing the document.
https://bugs.freedesktop.org/show_bug.cgi?id=78693 Priority: medium Bug ID: 78693 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: The following piece of code generates an error when closing the document. Severity: normal Classification: Unclassified OS: All Reporter: dmasa...@multicharts.com Hardware: Other Status: UNCONFIRMED Version: unspecified Component: BASIC Product: LibreOffice Important: before running the code copy any picture to the clipboard. The same code works fine in Open Office. var service_managername = com.sun.star.ServiceManager; var calc_servername = com.sun.star.frame.Desktop; var service_manager = new ActiveXObject(service_managername); var desktop = service_manager.createInstance(calc_servername); var oDispatcher = service_manager.createInstance(com.sun.star.frame.DispatchHelper); var hidden_Param = service_manager.Bridge_GetStruct(com.sun.star.beans.PropertyValue); hidden_Param.Name = Hidden; hidden_Param.Value = true; var PropValues = new Array(); PropValues[0] = hidden_Param; var sheets_total = 0; var document = desktop.LoadComponentFromURL(private:factory/scalc, _blank, 0, PropValues); document.lockControllers(); document.addActionLock(); oDispatcher.executeDispatch(document.CurrentController.Frame, .uno:Paste, , 0, new Array()); document.StoreToURL(file:///c:/test.ods, new Array()); document.unLockControllers(); document.removeActionLock(); document.close(true); -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 60589] [Template manager]: Can not copy styles between different files and templates
https://bugs.freedesktop.org/show_bug.cgi?id=60589 --- Comment #22 from m...@tercel.com.tw --- Because I cannot find a way to copy styles between different files in LibreOffice 4.2.4.2, I don't know how to retest against 4.2.4.2 ?? If tommy27 or someone knows the method to copy styles between different files in LibreOffice 4.2.4.2, please give a hint or a link. Thank you and regards. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78612] build: error ‘xmlChildElementCount’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=78612 --- Comment #2 from Douglas Mencken dougmenc...@gmail.com --- First I tried commit 867aa217e6bcb543, now I tried commit a93bb27aa46c8441. Problem is still here. I'm building on Mac OS X 10.5 @PowerPC. autogen.lastrun: --prefix=/usr --mandir=/usr/share/man --with-macosx-sdk=10.5 --with-build-version=Built by Douglas Mencken for PowerPC --with-vendor=Unaffiliated Hackers --disable-firebird-sdbc --disable-pdfimport --disable-sdremote --enable-eot --enable-epm --with-package-format=dmg -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78599] Other: File corrupt because hyperlink close before fldchar end
https://bugs.freedesktop.org/show_bug.cgi?id=78599 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|BSA |BSA target:4.3.0 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- PriyankaGaikwad committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8db493240a2caced1ab72a9e0fc87d39a6d3f12d fdo#78599: Fixed for file corruption which contains fields and hyperlink The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78694] New: After partial sorting data become incorrect
https://bugs.freedesktop.org/show_bug.cgi?id=78694 Priority: medium Bug ID: 78694 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: After partial sorting data become incorrect Severity: normal Classification: Unclassified OS: Windows (All) Reporter: kaktebyaviru...@gmail.com Hardware: x86 (IA32) Status: UNCONFIRMED Version: 4.2.4.2 release Component: Spreadsheet Product: LibreOffice Created attachment 99028 -- https://bugs.freedesktop.org/attachment.cgi?id=99028action=edit file were partial sorting causes problems LibreOffice Version: 4.2.4.2 Build ID: 63150712c6d317d27ce2db16eb94c2f3d7b699f8 on Russian Windows XP Professional SP3 (32bit) If we try to open Example_34.ods file in LibreOffice, select cells A4:E38 and make Sort Ascending and after that immediately Undo: Sort (or Ctrl+Z) that we'll see that some cells (from cell F25 to F39) have a value other than the original (cell F25 had value 1677,13 after such operations became 1669,87; cell F27 had value 527,64 after such operations became 525,86 and so on). If we select full rows (A4:AMJ38), than after Undo all is fine. In LibreOffice Version 4.1.4.2 there was no such problem with partial sorting. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78695] New: Other: Automatic update download
https://bugs.freedesktop.org/show_bug.cgi?id=78695 Priority: medium Bug ID: 78695 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Other: Automatic update download Severity: normal Classification: Unclassified OS: Mac OS X (All) Reporter: grillotituba...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.1.6.2 release Component: UI Product: LibreOffice Problem description: I wish LibreOffice could download its own updates without me requiring to visit libreoffice.org. Operating System: Mac OS X Version: 4.1.6.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78696] New: FILEOPEN: freezes when opening large docx file
https://bugs.freedesktop.org/show_bug.cgi?id=78696 Priority: medium Bug ID: 78696 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILEOPEN: freezes when opening large docx file Severity: normal Classification: Unclassified OS: Windows (All) Reporter: marale...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.4.2 release Component: Writer Product: LibreOffice Problem description: I was trying to open my thesis, which is about 168 pages, or 71,000 words long, including footnotes. While libreoffice will open other docx files with no problem (the largest I tried successfully was about 15,000 words), it cannot open my thesis. It freezes, and even given a large amount of times (around 20 min) will not open the file. Upgrading to the latest version of Libreoffice did not fix this problem Steps to reproduce: 1. create a large (168 pages or 71,000 words) docx file 2. attempt to open 3. fail to open Current behavior: freezes, must be shut down Expected behavior: opens file without problems Operating System: Windows 7 Version: 4.2.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78612] build: error ‘xmlChildElementCount’ was not declared in this scope
https://bugs.freedesktop.org/show_bug.cgi?id=78612 Douglas Mencken dougmenc...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |dougmenc...@gmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #4 from Douglas Mencken dougmenc...@gmail.com --- Assigning this to myself. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78697] New: Copy-Paste from PDF changes the document's creation date, author
https://bugs.freedesktop.org/show_bug.cgi?id=78697 Priority: medium Bug ID: 78697 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: Copy-Paste from PDF changes the document's creation date, author Severity: normal Classification: Unclassified OS: Windows (All) Reporter: marc.wuille...@gmail.com Hardware: All Status: UNCONFIRMED Version: 4.2.4.2 release Component: Writer Product: LibreOffice When copying and pasting text from certain PDF files to a Writer document, Writer changes the document's creation date, creator name as well as title, subject and keywords (if present) to that of the PDF file. Steps to reproduce: 1. Open writer, type some text and save the file. See the document's properties for correct Created date and author name and Modified date and author name. 2. Open a PDF document with Adobe Reader, select a passage and press CTRL+C to copy. 3. Go to the Writer document and press CTRL+V to paste the passage. 4. See the Writer document's properties for changed Created date, author as well as title, subject and keywords (if present). I tested in Win7 64bit with LO 4.2.4.2 release and Adobe Reader 11.0.06. The phenomenon also appears in Windows Vista 32bit with LO 4.2.4.2 release and Adobe Reader 9.5.5. It does not happen with Calc. Also, it does not happen with a different PDF viewer, for example SumatraPDF v2.4. And it does not happen with all PDF files. An example of a PDF file that triggers the phenomenon is the Intel SSD Toolbox Release Notes document: http://downloadmirror.intel.com/18455/eng/Intel_SSD_Toolbox_Release_Notes_Rev3_2_1_325993_017.pdf -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76311] FORMATTING: Impossible to change format to number for differently formatted cells where first one is formatted as number
https://bugs.freedesktop.org/show_bug.cgi?id=76311 Kohei Yoshida libreoff...@kohei.us changed: What|Removed |Added Status|REOPENED|NEW --- Comment #4 from Kohei Yoshida libreoff...@kohei.us --- This is a bug, though it's probably a very old bug. I think the dialog is not registering that the change has been made to the number format, which is why the caller of the dialog is not applying it to the selection. I already see this in 3.5, I won't be surprised if we inherited this from OOo. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Bug 65675 depends on bug 78635, which changed state. Bug 78635 Summary: LibreOffice Importing Symbols Incorrectly from .docx https://bugs.freedesktop.org/show_bug.cgi?id=78635 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78635] LibreOffice Importing Symbols Incorrectly from .docx
https://bugs.freedesktop.org/show_bug.cgi?id=78635 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Whiteboard||target:4.3.0 target:4.2.5 Resolution|--- |FIXED --- Comment #4 from Andras Timar tima...@gmail.com --- Fixed by f51640c5 and 671eb12d in master. I cherry-picked the fixes to libreoffice-4-2 branch. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78698] New: EDITING: Comments on cell disappear after pasting content
https://bugs.freedesktop.org/show_bug.cgi?id=78698 Priority: medium Bug ID: 78698 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: EDITING: Comments on cell disappear after pasting content Severity: normal Classification: Unclassified OS: Windows (All) Reporter: petracup...@gmail.com Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.4.2 release Component: Spreadsheet Product: LibreOffice Problem description: Comments on cells disappear when you paste any content on it. Steps to reproduce: 1. Copy a cell without a comment. 2. Paste it on a cell with a comment. Current behavior: Comment disappeared from destination cell. Expected behavior: Comment keeps showing on cell after pasting new values. Operating System: Windows 7 Version: 4.2.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64161] PDF: EPS images don't get exported when writing a PDF file
https://bugs.freedesktop.org/show_bug.cgi?id=64161 --- Comment #34 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolan McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a428ed5670e0257b21c04590ce95b86b2896ee4 Related: fdo#64161 ask pstoedit to mark out the bounding box The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78430] remove redundant 'private method' comments ...
https://bugs.freedesktop.org/show_bug.cgi?id=78430 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Michael Meeks michael.me...@collabora.com --- Hi Hussain - thanks for that ! =) one reason we do this is to gain vertical space - so more can be seen on the screen; it'd be great to have a second clean-up to have just single lines between the functions in framework you touched there I guess. Anyhow - I've pushed it for now; can you send a license statement to the developers' mailing list: https://wiki.documentfoundation.org/Development/Developers#Example_Statement And great to have you involved ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78204] PRINTING PDF: note icon misplaced in exported PDF when comments are printed in the margins
https://bugs.freedesktop.org/show_bug.cgi?id=78204 --- Comment #1 from Caolán McNamara caol...@redhat.com --- sigh, these are drawn in different passes, before and after the scaled stage. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 59699] RTF: INCLUDEPICTURE image not shown
https://bugs.freedesktop.org/show_bug.cgi?id=59699 --- Comment #5 from Albrecht Müller albrecht.muel...@astrail.de --- Using a very old installation of Star Office 9 I was able to convert a .rtf file containing linked pictures into an .odt file. LibreOffice displays the converted file correctly. There are some flaws however: A more then 15 years old version of Word, Word97, shows the pictures in some reasonable default format, e.g. it scales larges pictures in a way such that they fit on a page. The .odf file seems to contain the pictures in their original size. This requires substantial work to format them by hand, and I think the related dialog box is confusing and lacks a feature that allows to change the scaling while maintainig a fixed aspect ratio, especially the aspect ratio of the original picture. I would expect that LibreOffice scales big linked pictures such that they fit on a page while maintaining the aspect ratio of the original as a default behaviour (the .rtf file may specify something else). A feature that allows to scale a picture using a fixed aspect ratio would be helpful. GIMPs user interface contains this kind of scaling transformations. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78699] New: FILTER: crash when auto filter enabled and empty column header
https://bugs.freedesktop.org/show_bug.cgi?id=78699 Priority: medium Bug ID: 78699 Assignee: libreoffice-bugs@lists.freedesktop.org Summary: FILTER: crash when auto filter enabled and empty column header Severity: normal Classification: Unclassified OS: Windows (All) Reporter: gtre...@ville-saintdie.fr Hardware: Other Whiteboard: BSA Status: UNCONFIRMED Version: 4.2.4.2 release Component: Spreadsheet Product: LibreOffice Problem description: Calc crash when auto filter enabled and empty column header and try to sort table. Steps to reproduce: 1. add column with empty header but with a non-empty cell 2. enable auto filter 3. try to sort table Current behavior: calc crash (maybe segmentation fault) Expected behavior: calc not crash but it could warning the user about header problem. Operating System: Windows 7 Version: 4.2.4.2 release -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78204] PRINTING PDF: note icon misplaced in exported PDF when comments are printed in the margins
https://bugs.freedesktop.org/show_bug.cgi?id=78204 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #2 from Joel Madero jmadero@gmail.com --- Confirmed: Ubuntu 14.04 x64 Master 4.3 built a couple weeks ago Normal - can prevent professional work Medium - seems appropriate Attaching document showing problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78204] PRINTING PDF: note icon misplaced in exported PDF when comments are printed in the margins
https://bugs.freedesktop.org/show_bug.cgi?id=78204 --- Comment #3 from Joel Madero jmadero@gmail.com --- Created attachment 99034 -- https://bugs.freedesktop.org/attachment.cgi?id=99034action=edit PDF Showing Note Icon -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78204] PRINTING PDF: note icon misplaced in exported PDF when comments are printed in the margins
https://bugs.freedesktop.org/show_bug.cgi?id=78204 Joel Madero jmadero@gmail.com changed: What|Removed |Added Version|4.2.0.0.alpha0+ Master |4.3.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78151] FORMATTING: Not possible to format auto layout text - it's locked to outline style
https://bugs.freedesktop.org/show_bug.cgi?id=78151 Caolán McNamara caol...@redhat.com changed: What|Removed |Added CC||t...@libreoffice.org --- Comment #3 from Caolán McNamara caol...@redhat.com --- So, here's a video of how to achieve what you want to do with the current UI. http://youtu.be/Guqjv_uKadA Here's what I think we could do (without looking into the implementation details to see if thats plausible yet). 1. In the master slide view modify it so that any changes in formatting to the preview is automatically synced up to the outline level style. So formatting an outline level 2 preview changes outline level 2 style 2. Disallow changes to the preview which aren't logical, e.g. can't delete a paragraph from it, can't insert a paragraph, etc. Seeing as we aren't currently supporting custom text for the click-here to edit, disallow changing the text two and automatically select the entire paragraph and not allow partial selections of the paragraph. caolanm-thb: Does this sound plausible to you ? Why do we currently allow these to be edited in the master view at the moment ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs