date:20140619

LibreOffice Gerrit News for core on 2014-06-19

2014-06-19 Thread gerrit

Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ fix build error AVFoundation/AVFoundation.h: no such file or directory
  in https://gerrit.libreoffice.org/9769 from Douglas Mencken
  about module avmedia, build, postprocess
+ fdo#79599: use \highlightN instead of \chcbpatN in RTF import and export
  in https://gerrit.libreoffice.org/9776 from Norbert X
  about module sw, writerfilter
 End of freshness 

+ related fdo#63230: Fix unit test for fdo#44286 to run in all locales
  in https://gerrit.libreoffice.org/9826 from Isamu Mogi
  about module svl
+ Resolves fdo#79276 Add fallback system for autocorrection of French varia
  in https://gerrit.libreoffice.org/9825 from Julien Nabet
  about module editeng, extras, include, sw
+ new compilerplugin returnbyref
  in https://gerrit.libreoffice.org/9817 from Noel Grandin
  about module compilerplugins, sw


* Merged changes on master for project core changed in the last 25 hours:

+ Convert RID_SVXFLOAT_HYPERLINK_MARKWND to .ui
  in https://gerrit.libreoffice.org/9803 from Mihály Palenik
+ fdo#80084 file driver PreparedStatement: close previous ResultSet on reex
  in https://gerrit.libreoffice.org/9822 from Lionel Elie Mamane
+ Convert RID_XMLSECDLG_MACROWARN to .ui
  in https://gerrit.libreoffice.org/9798 from Mihály Palenik
+ OS X: JDK include path for JDK 1.8
  in https://gerrit.libreoffice.org/9785 from Robert Antoni Buj i Gelonch
+ fix 'NSWindow' may not respond to '+windowNumbersWithOptions'
  in https://gerrit.libreoffice.org/9760 from Douglas Mencken
+ LOK: kill double initialize.
  in https://gerrit.libreoffice.org/9816 from Andrzej Hunt
+ related fdo#63230: Add unit test for fdo#44286
  in https://gerrit.libreoffice.org/9781 from Isamu Mogi
+ OS X: modify rhino1_5R5 patch for JDKs = 1.5
  in https://gerrit.libreoffice.org/9809 from Robert Antoni Buj i Gelonch


* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ fdo#77985 make calc function NETWORKDAYS comply with ODFF1.2
  in https://gerrit.libreoffice.org/9327 from Winfried Donkers
+ fdo#79018: LO hangs while opening file.
  in https://gerrit.libreoffice.org/9564 from Yogesh Bharate
+ configure, gbuild: remove Cygwin paths from make environment
  in https://gerrit.libreoffice.org/9698 from Michael Stahl
+ sw/docx export: fix handling of document with header and section(s)
  in https://gerrit.libreoffice.org/6248 from Pierre-Eric Pelloux-Prayer
+ move OpenGLContext to SAL
  in https://gerrit.libreoffice.org/9429 from David Tardon
+ Changes for Wordml
  in https://gerrit.libreoffice.org/9013 from Michel Messak
+ fdo#64945 Remove inconvenient localized symbol code.
  in https://gerrit.libreoffice.org/8696 from Darshana Padmadas
+ fdo#77716 : Paragraph spacing is not preserved after RT.
  in https://gerrit.libreoffice.org/9197 from Tushar Bende
+ Lots of changes to Tango icons
  in https://gerrit.libreoffice.org/7987 from Miroslav Mazel
+ Refactored swooxmlexport tests cases. Added function to check contents.
  in https://gerrit.libreoffice.org/8390 from Nikhil Walvekar
+ fdo#77121 Header / Footer positions not preserved after RT
  in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: fdo#44286 unittest fails in non-English locale

2014-06-19 Thread Isamu Mogi


Hi. I published the patch to gerrit https://gerrit.libreoffice.org/#/c/9826/ .
Please wait a bit until the patch is merged.

(2014/06/19 14:00), Lionel Elie Mamane wrote:

The recently committed unittest for fdo#44286
(https://gerrit.libreoffice.org/#/c/9781/) fails on a non-English locale:

$ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit
[build CUT] svl_qa_cppunit
/home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous
namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

svl.cxx:403:Assertion
Test name: (anonymous namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

Failures !!!
Run: 7   Failure total: 1   Failures: 1   Errors: 0




--
Isamu Mogi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: svl/qa

2014-06-19 Thread Isamu Mogi

 svl/qa/unit/svl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d2c469cc16bf303d4f5065a438d5252a31b3a564
Author: Isamu Mogi saturda...@gmail.com
Date:   Thu Jun 19 23:45:38 2014 +0900

related fdo#63230: Fix unit test for fdo#44286 to run in all locales

fdo#44286 test fails depending on system language. To fix it, this commit 
sets
output language to LANGUAGE_ENGLISH_US.

Erorr message:
| $ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit
| [build CUT] svl_qa_cppunit
| 
/home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous
| namespace)::Test::testFdo44286
| equality assertion failed
| - Expected: 1902-04-22
| - Actual  : -04-DD
|
| svl.cxx:403:Assertion
| Test name: (anonymous namespace)::Test::testFdo44286
| equality assertion failed
| - Expected: 1902-04-22
| - Actual  : -04-DD
|
| Failures !!!
| Run: 7   Failure total: 1   Failures: 1   Errors: 0

Change-Id: I58756c7508c7f02bec9c3b7b693032265d18c6ae
Reviewed-on: https://gerrit.libreoffice.org/9826
Reviewed-by: Lionel Elie Mamane lio...@mamane.lu
Tested-by: Lionel Elie Mamane lio...@mamane.lu

diff --git a/svl/qa/unit/svl.cxx b/svl/qa/unit/svl.cxx
index 673c8d2..25bc217 100644
--- a/svl/qa/unit/svl.cxx
+++ b/svl/qa/unit/svl.cxx
@@ -405,7 +405,7 @@ void Test::checkPreviewString(SvNumberFormatter aFormatter,
 
 void Test::testFdo44286()
 {
-LanguageType eLang = LANGUAGE_SYSTEM;
+LanguageType eLang = LANGUAGE_ENGLISH_US;
 OUString sCode = -MM-DD, sExpected;
 double fPreviewNumber;
 SvNumberFormatter aFormatter(m_xContext, eLang);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: fdo#44286 unittest fails in non-English locale

2014-06-19 Thread Isamu Mogi


Hi, I confirmed that Lionel merged the patch. Thanks a lot!

(2014/06/19 14:00), Lionel Elie Mamane wrote:

The recently committed unittest for fdo#44286
(https://gerrit.libreoffice.org/#/c/9781/) fails on a non-English locale:

$ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit
[build CUT] svl_qa_cppunit
/home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous
namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

svl.cxx:403:Assertion
Test name: (anonymous namespace)::Test::testFdo44286
equality assertion failed
- Expected: 1902-04-22
- Actual  : -04-DD

Failures !!!
Run: 7   Failure total: 1   Failures: 1   Errors: 0




--
Isamu Mogi

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 3 commits - include/tools sfx2/source sw/source

2014-06-19 Thread Stephan Bergmann

 include/tools/ref.hxx |8 ++--
 sfx2/source/doc/sfxbasemodel.cxx  |5 -
 sw/source/core/docnode/ndsect.cxx |5 -
 3 files changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 160ae9889e4d16217a7cca7d930f776f5a645ec8
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jun 19 09:28:47 2014 +0200

Catch illegal null pointer dereferences early

Change-Id: I4d558e9a6e2c4e4d9feb45eb5a3fd01ee322bef8

diff --git a/include/tools/ref.hxx b/include/tools/ref.hxx
index 0bf519e..87aed32 100644
--- a/include/tools/ref.hxx
+++ b/include/tools/ref.hxx
@@ -19,6 +19,10 @@
 #ifndef INCLUDED_TOOLS_REF_HXX
 #define INCLUDED_TOOLS_REF_HXX
 
+#include sal/config.h
+
+#include cassert
+
 #include tools/toolsdllapi.h
 #include vector
 
@@ -59,9 +63,9 @@ public:
 
 T * operator () const { return pObj; }
 
-T * operator -() const { return pObj; }
+T * operator -() const { assert(pObj != 0); return pObj; }
 
-T  operator *() const { return *pObj; }
+T  operator *() const { assert(pObj != 0); return *pObj; }
 
 operator T *() const { return pObj; }
 
commit e7c1e48794df85d5cb35d67a1bab7543690f084e
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jun 19 09:25:28 2014 +0200

Prevent null pointer dereference

(even though the null pointer dereference in SwSection::GetBaseLink would be
somewhat harmless in this case, as the result is here immediately turned 
into a
pointer again; but it also does not look like LinkManager::Remove is 
designed to
be called with a null pointer argument)

Change-Id: Ia1560b03be6a654c1207c146c873f29788b68558

diff --git a/sw/source/core/docnode/ndsect.cxx 
b/sw/source/core/docnode/ndsect.cxx
index 94c3f2e..b004366 100644
--- a/sw/source/core/docnode/ndsect.cxx
+++ b/sw/source/core/docnode/ndsect.cxx
@@ -1363,8 +1363,11 @@ void SwSectionNode::NodesArrChgd()
 }
 else
 {
-if (CONTENT_SECTION != m_pSection-GetType())
+if (CONTENT_SECTION != m_pSection-GetType()
+ m_pSection-IsConnected())
+{
 pDoc-GetLinkManager().Remove( m_pSection-GetBaseLink() );
+}
 
 if (m_pSection-IsServer())
 pDoc-GetLinkManager().RemoveServer( m_pSection-GetObject() );
commit 80f8bf77e5420c550294048b31911fefffa12fc5
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jun 19 09:24:35 2014 +0200

Prevent null pointer dereference

Change-Id: Ia197152f6ece37dd2dd2ce1b41c1dfd1a985781c

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 35af9e2..15a76db 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -778,7 +778,10 @@ void SAL_CALL SfxBaseModel::dispose() 
throw(RuntimeException, std::exception)
 
 m_pData-m_xDocumentMetadata.clear();
 
-EndListening( *m_pData-m_pObjectShell );
+if ( m_pData-m_pObjectShell.Is() )
+{
+EndListening( *m_pData-m_pObjectShell );
+}
 
 m_pData-m_xCurrent = Reference frame::XController  ();
 m_pData-m_seqControllers = Sequence Reference frame::XController   () 
;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[SOLVED] Re: Build fails on CppunitTest_svl_qa_cppunit

2014-06-19 Thread julien2412

Solved thanks to Lionel and Isamu (see
http://nabble.documentfoundation.org/fdo-44286-unittest-fails-in-non-English-locale-td4112845.html)



--
View this message in context: 
http://nabble.documentfoundation.org/Build-fails-on-CppunitTest-svl-qa-cppunit-tp4112827p4112855.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'feature/textbox' - 0 commits -

2014-06-19 Thread Unknown

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/svl oox/source sw/qa sw/source writerfilter/source

2014-06-19 Thread Miklos Vajna

 include/svl/grabbagitem.hxx   |5 ++-
 oox/source/shape/LockedCanvasContext.hxx  |5 ++-
 oox/source/shape/WpgContext.hxx   |5 ++-
 oox/source/shape/WpsContext.hxx   |5 ++-
 sw/qa/extras/rtfimport/rtfimport.cxx  |6 +--
 sw/source/filter/ww8/rtfattributeoutput.hxx   |5 ++-
 writerfilter/source/dmapper/SdtHelper.hxx |   25 ---
 writerfilter/source/rtftok/rtfdocumentimpl.cxx|   30 --
 writerfilter/source/rtftok/rtfdocumentimpl.hxx|   10 --
 writerfilter/source/rtftok/rtfreferenceproperties.hxx |   10 --
 writerfilter/source/rtftok/rtfsprm.cxx|   13 +++
 writerfilter/source/rtftok/rtftokenizer.hxx   |5 ++-
 writerfilter/source/rtftok/rtfvalue.cxx   |3 -
 13 files changed, 77 insertions(+), 50 deletions(-)

New commits:
commit 19863db3373effd2a4836481dd6706a0efe6db39
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Thu Jun 19 09:39:49 2014 +0200

indentation fixes

Change-Id: Ia391ccc9889a135730f0fead11eb0b6c2f748ec4

diff --git a/include/svl/grabbagitem.hxx b/include/svl/grabbagitem.hxx
index 9ba6868..c02edaa 100644
--- a/include/svl/grabbagitem.hxx
+++ b/include/svl/grabbagitem.hxx
@@ -30,7 +30,10 @@ public:
 SfxGrabBagItem(const SfxGrabBagItem rItem);
 virtual ~SfxGrabBagItem();
 
-const std::mapOUString, com::sun::star::uno::Any GetGrabBag() const { 
return m_aMap;}
+const std::mapOUString, com::sun::star::uno::Any GetGrabBag() const
+{
+return m_aMap;
+}
 
 virtual bool operator==(const SfxPoolItem) const SAL_OVERRIDE;
 virtual SfxPoolItem* Clone(SfxItemPool* pPool = 0) const SAL_OVERRIDE;
diff --git a/oox/source/shape/LockedCanvasContext.hxx 
b/oox/source/shape/LockedCanvasContext.hxx
index ab8ceae..4284eec 100644
--- a/oox/source/shape/LockedCanvasContext.hxx
+++ b/oox/source/shape/LockedCanvasContext.hxx
@@ -27,7 +27,10 @@ public:
 
 virtual ::oox::core::ContextHandlerRef onCreateContext(sal_Int32 Element, 
const ::oox::AttributeList rAttribs) SAL_OVERRIDE;
 
-oox::drawingml::ShapePtr getShape() { return mpShape;}
+oox::drawingml::ShapePtr getShape()
+{
+return mpShape;
+}
 
 protected:
 
diff --git a/oox/source/shape/WpgContext.hxx b/oox/source/shape/WpgContext.hxx
index e59cf54..694aef0 100644
--- a/oox/source/shape/WpgContext.hxx
+++ b/oox/source/shape/WpgContext.hxx
@@ -27,7 +27,10 @@ public:
 
 virtual oox::core::ContextHandlerRef onCreateContext(sal_Int32 
nElementToken, const oox::AttributeList rAttribs) SAL_OVERRIDE;
 
-oox::drawingml::ShapePtr getShape() { return mpShape;}
+oox::drawingml::ShapePtr getShape()
+{
+return mpShape;
+}
 
 protected:
 oox::drawingml::ShapePtr mpShape;
diff --git a/oox/source/shape/WpsContext.hxx b/oox/source/shape/WpsContext.hxx
index cde3532..c7678c7 100644
--- a/oox/source/shape/WpsContext.hxx
+++ b/oox/source/shape/WpsContext.hxx
@@ -27,7 +27,10 @@ public:
 
 virtual oox::core::ContextHandlerRef onCreateContext(sal_Int32 
nElementToken, const oox::AttributeList rAttribs) SAL_OVERRIDE;
 
-oox::drawingml::ShapePtr getShape() { return mpShape;}
+oox::drawingml::ShapePtr getShape()
+{
+return mpShape;
+}
 
 protected:
 oox::drawingml::ShapePtr mpShape;
diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx 
b/sw/qa/extras/rtfimport/rtfimport.cxx
index 79a4494..8d8e048 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1173,10 +1173,8 @@ DECLARE_RTFIMPORT_TEST(testN825305, n825305.rtf)
 
 DECLARE_RTFIMPORT_TEST(testParaBottomMargin, para-bottom-margin.rtf)
 {
-uno::Referencebeans::XPropertySet xPropertySet(
-getStyles(ParagraphStyles)-getByName(Standard), uno::UNO_QUERY);
-CPPUNIT_ASSERT_EQUAL(sal_Int32(353),
-getPropertysal_Int32(xPropertySet, ParaBottomMargin));
+uno::Referencebeans::XPropertySet 
xPropertySet(getStyles(ParagraphStyles)-getByName(Standard), 
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(353), getPropertysal_Int32(xPropertySet, 
ParaBottomMargin));
 
 // This was 353, i.e. bottom margin of the paragraph was 0.35cm instead of 
0.
 // The reason why this is 0 despite the default style containing \sa200
diff --git a/sw/source/filter/ww8/rtfattributeoutput.hxx 
b/sw/source/filter/ww8/rtfattributeoutput.hxx
index fdd8ff1..8452f73 100644
--- a/sw/source/filter/ww8/rtfattributeoutput.hxx
+++ b/sw/source/filter/ww8/rtfattributeoutput.hxx
@@ -76,7 +76,10 @@ public:
 
 // Access to (anyway) private buffers, used by the sdr exporter
 OStringBuffer RunText();
-OStringBuffer Styles() { return m_aStyles; }
+OStringBuffer Styles()
+{
+return m_aStyles;
+}
 
 /// Output text (without markup).
 virtual void RawText(const OUString rText, bool bForceUnicode,

[Libreoffice-commits] core.git: udkapi/com

2014-06-19 Thread Stephan Bergmann

 udkapi/com/sun/star/io/FilePermission.idl |   69 ++
 1 file changed, 34 insertions(+), 35 deletions(-)

New commits:
commit 9947032c4c6a772df888323338df699f54087013
Author: Stephan Bergmann sberg...@redhat.com
Date:   Thu Jun 19 11:15:32 2014 +0200

Work around problem with nested /* in Doxygen comment

...where Doxygen apparently deliberately tracks nested /* ... */ comments in
/** ... */ comments (even though languages like C, C++, Java don't).  
Thanks to
Lionel for finding it.

Change-Id: I0cfc54216df4e49c194c097e5ad3b00f5270d395

diff --git a/udkapi/com/sun/star/io/FilePermission.idl 
b/udkapi/com/sun/star/io/FilePermission.idl
index d23d90a..b3d1981 100644
--- a/udkapi/com/sun/star/io/FilePermission.idl
+++ b/udkapi/com/sun/star/io/FilePermission.idl
@@ -22,41 +22,40 @@
 module com {  module sun {  module star {  module io {
 
 
-/** This permission represents access to a file or directory.
-A FilePermission consists of a file url and a set of actions valid for 
that url.
-p
-The path of the file url that ends in code/*/code indicates all the 
files and
-directories contained in that directory.  A path that ends with 
code/-/code
-indicates (recursively) all files and subdirectories contained in that
-directory.  A file url string consisting of the special token
-codeALL FILES/code matches any file.
-br
-Note: A file url string consisting of a single code*/code indicates 
all the files
-in the current directory, while a string consisting of a single 
code-/code indicates
-all the files in the current directory and (recursively) all files and
-subdirectories contained in the current directory.
-br
-The actions to be granted is a list of one or more comma-separated 
keywords.
-The possible keywords are coderead/code, codewrite/code,
-codeexecute/code, and codedelete/code.
-Their meaning is defined as follows:
-ul
-licoderead/code -- read permission/li
-licodewrite/code -- write permission/li
-licodeexecute/code -- execute permission/li
-licodedelete/code -- delete permission/li
-/ulbr
-The actions string is processed case-insensitive.
-/p
-
-@attention
-Be careful when granting FilePermissions.  Think about the implications of
-granting read and especially write access to various files and directories.
-The codeALL FILES/code permission with write action is
-especially dangerous.  This grants permission to write to the entire file 
system.
-
-@since OOo 1.1.2
-*/
+/// This permission represents access to a file or directory.
+/// A FilePermission consists of a file url and a set of actions valid for 
that url.
+/// p
+/// The path of the file url that ends in code/*/code indicates all the 
files and
+/// directories contained in that directory.  A path that ends with 
code/-/code
+/// indicates (recursively) all files and subdirectories contained in that
+/// directory.  A file url string consisting of the special token
+/// codeALL FILES/code matches any file.
+/// br
+/// Note: A file url string consisting of a single code*/code indicates 
all the files
+/// in the current directory, while a string consisting of a single 
code-/code indicates
+/// all the files in the current directory and (recursively) all files and
+/// subdirectories contained in the current directory.
+/// br
+/// The actions to be granted is a list of one or more comma-separated 
keywords.
+/// The possible keywords are coderead/code, codewrite/code,
+/// codeexecute/code, and codedelete/code.
+/// Their meaning is defined as follows:
+/// ul
+/// licoderead/code -- read permission/li
+/// licodewrite/code -- write permission/li
+/// licodeexecute/code -- execute permission/li
+/// licodedelete/code -- delete permission/li
+/// /ulbr
+/// The actions string is processed case-insensitive.
+/// /p
+///
+/// @attention
+/// Be careful when granting FilePermissions.  Think about the implications of
+/// granting read and especially write access to various files and directories.
+/// The codeALL FILES/code permission with write action is
+/// especially dangerous.  This grants permission to write to the entire file 
system.
+///
+/// @since OOo 1.1.2
 published struct FilePermission
 {
 /** target file url
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 75025] LibreOffice 4.3 most annoying bugs

2014-06-19 Thread bugzilla-daemon

https://bugs.freedesktop.org/show_bug.cgi?id=75025

suokunl...@gmail.com changed:

   What|Removed |Added

 Depends on||79810

--- Comment #29 from suokunl...@gmail.com ---
Adding Bug 79810 - DOCX IMPORT: Wrong underline applied to list style.

This causes wrong formating when open DOCX file.
It's a regression in 4.3.0.0 beta2, and still exists in 4.3.0 RC1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: 18 commits - extensions/source formula/source include/formula l10ntools/source sc/source sd/source starmath/source svtools/source svx/source sw/inc sw/source unusedcode

2014-06-19 Thread Caolán McNamara

 extensions/source/propctrlr/genericpropertyhandler.cxx |3 +-
 extensions/source/propctrlr/genericpropertyhandler.hxx |2 -
 formula/source/ui/dlg/funcutl.cxx  |   24 -
 include/formula/funcutl.hxx|5 ---
 l10ntools/source/export.cxx|2 -
 sc/source/filter/xml/xmlfonte.cxx  |9 +-
 sc/source/ui/unoobj/exceldetect.cxx|   18 +---
 sd/source/core/sdpage.cxx  |2 -
 sd/source/ui/func/fuinsfil.cxx |2 -
 sd/source/ui/unoidl/unoobj.cxx |4 +-
 starmath/source/node.cxx   |2 -
 starmath/source/parse.cxx  |4 +-
 starmath/source/smdetect.cxx   |   24 -
 svtools/source/contnr/imivctl2.cxx |   13 +
 svx/source/unogallery/unogalitem.cxx   |7 ++--
 svx/source/unogallery/unogalitem.hxx   |2 -
 sw/inc/IDocumentDrawModelAccess.hxx|   10 +++
 sw/source/core/access/accmap.cxx   |1 
 sw/source/core/doc/DocumentDeviceManager.cxx   |1 
 sw/source/core/doc/DocumentDrawModelManager.cxx|   10 +++
 sw/source/core/doc/DocumentSettingManager.cxx  |1 
 sw/source/core/doc/docfly.cxx  |1 
 sw/source/core/doc/doclay.cxx  |1 
 sw/source/core/docnode/nodedump.cxx|1 
 sw/source/core/draw/dcontact.cxx   |1 
 sw/source/core/frmedt/feshview.cxx |1 
 sw/source/core/inc/DocumentDrawModelManager.hxx|   12 
 sw/source/core/layout/fly.cxx  |1 
 sw/source/core/layout/frmtool.cxx  |1 
 sw/source/core/layout/newfrm.cxx   |1 
 sw/source/core/layout/paintfrm.cxx |1 
 sw/source/core/text/itrform2.cxx   |5 +--
 sw/source/core/undo/docundo.cxx|1 
 sw/source/core/undo/unattr.cxx |1 
 sw/source/core/unocore/unodraw.cxx |1 
 sw/source/core/unocore/unoframe.cxx|1 
 sw/source/core/view/vdraw.cxx  |1 
 sw/source/core/view/viewimp.cxx|1 
 sw/source/core/view/viewsh.cxx |1 
 sw/source/filter/html/htmldrawreader.cxx   |1 
 sw/source/filter/writer/writer.cxx |   16 ---
 sw/source/filter/ww8/docxsdrexport.cxx |1 
 sw/source/filter/ww8/rtfattributeoutput.cxx|1 
 sw/source/filter/ww8/wrtw8esh.cxx  |1 
 sw/source/filter/ww8/wrtww8.cxx|1 
 sw/source/filter/ww8/ww8graf.cxx   |1 
 sw/source/filter/xml/swxml.cxx |1 
 sw/source/filter/xml/xmlexp.cxx|1 
 sw/source/filter/xml/xmlimp.cxx|1 
 sw/source/uibase/app/docshdrw.cxx  |1 
 sw/source/uibase/app/docstyle.cxx  |1 
 sw/source/uibase/dialog/SwSpellDialogChildWindow.cxx   |1 
 sw/source/uibase/lingu/sdrhhcwrap.cxx  |1 
 sw/source/uibase/shells/drwbassh.cxx   |1 
 sw/source/uibase/shells/frmsh.cxx  |1 
 sw/source/uibase/shells/grfsh.cxx  |1 
 sw/source/uibase/shells/grfshex.cxx|1 
 sw/source/uibase/uno/unodefaults.cxx   |2 -
 sw/source/uibase/uno/unotxdoc.cxx  |   12 
 sw/source/uibase/utlui/content.cxx |1 
 unusedcode.easy|2 -
 61 files changed, 130 insertions(+), 99 deletions(-)

New commits:
commit cf309ee274fad755de1b53b40bc1d2b112f16171
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jun 19 10:24:08 2014 +0100

coverity#704771 Explicit null dereferenced

Change-Id: I653866006a54f5bc73dae4614b0b9c8ddfeb4989

diff --git a/sd/source/ui/unoidl/unoobj.cxx b/sd/source/ui/unoidl/unoobj.cxx
index 2305df2..bb2411b 100644
--- a/sd/source/ui/unoidl/unoobj.cxx
+++ b/sd/source/ui/unoidl/unoobj.cxx
@@ -775,9 +775,9 @@ void SAL_CALL SdXShape::setPropertyValue( const OUString 
aPropertyName, const :
 case WID_BOOKMARK:
 {
 OUString aString;
-if( pInfo )
+SdDrawDocument* pDoc = mpModel ? mpModel-GetDoc() : NULL;
+if (pInfo  pDoc)
 {
-SdDrawDocument* pDoc = mpModel?mpModel-GetDoc():NULL;
 // is the bookmark a page?
 bool bIsMasterPage;

[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - svtools/source

2014-06-19 Thread Caolán McNamara

 svtools/source/contnr/imivctl2.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4a3fe589d03720148a9389f6c826350b18b78672
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Thu Jun 19 09:01:56 2014 +0100

sizeof(bool) is not required to be 1

(cherry picked from commit 3daec14fd62a6a1655813d26e470513237129263)

Conflicts:
svtools/source/contnr/imivctl2.cxx

Change-Id: I19ba4e27a4403d2c17d0bbf3f29c42e4745e4c41

diff --git a/svtools/source/contnr/imivctl2.cxx 
b/svtools/source/contnr/imivctl2.cxx
index dda5d4e..6892cc1 100644
--- a/svtools/source/contnr/imivctl2.cxx
+++ b/svtools/source/contnr/imivctl2.cxx
@@ -579,7 +579,7 @@ void IcnGridMap_Impl::Create_Impl()
 _nGridCols += 50;
 
 _pGridMap = new bool[ _nGridRows * _nGridCols];
-memset( (void*)_pGridMap, 0, _nGridRows * _nGridCols );
+memset( _pGridMap, 0, _nGridRows * _nGridCols * sizeof(bool) );
 
 const size_t nCount = _pView-aEntries.size();
 for( size_t nCur=0; nCur  nCount; nCur++ )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - basic/source sw/inc sw/sdi sw/source

2014-06-19 Thread Miklos Vajna

 basic/source/sbx/sbxvalue.cxx  |4 +-
 basic/source/sbx/sbxvar.cxx|2 -
 sw/inc/cmdid.h |2 +
 sw/inc/swcommands.h|2 +
 sw/sdi/drawsh.sdi  |   14 +
 sw/sdi/swriter.sdi |   48 ++
 sw/source/ui/app/mn.src|   12 
 sw/source/uibase/shells/drawsh.cxx |   52 +
 8 files changed, 133 insertions(+), 3 deletions(-)

New commits:
commit 692ea03e1d9974d036e1b9109c3fe32e1c0e51cd
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Thu Jun 19 10:11:34 2014 +0200

sw: add UI for removing the textbox of a draw shape

Change-Id: Ib95573228d3dc98c88cd4af19995c99433c84ae6

diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h
index 79f4dc6..46c84b1 100644
--- a/sw/inc/cmdid.h
+++ b/sw/inc/cmdid.h
@@ -479,6 +479,7 @@
 #define FN_EXPAND_GLOSSARY  (FN_EXTRA + 28)   /* expand text building 
blocks */
 #define FN_CHANGE_PAGENUM   (FN_EXTRA + 34)   /* change page numbers*/
 #define FN_ADD_TEXT_BOX (FN_EXTRA + 35)   /* add text box to draw 
shape */
+#define FN_REMOVE_TEXT_BOX  (FN_EXTRA + 36)   /* remove text box of 
draw shape */
 
 //  Region: Glossary
 
diff --git a/sw/inc/swcommands.h b/sw/inc/swcommands.h
index 3417a74..0d7aadd 100644
--- a/sw/inc/swcommands.h
+++ b/sw/inc/swcommands.h
@@ -79,6 +79,7 @@
 #define CMD_FN_PRINT_PAGEPREVIEW.uno:PrintPagePreview
 #define CMD_FN_TABLE_SET_READ_ONLY_CELLS.uno:Protect
 #define CMD_FN_REMOVE_CUR_TOX   .uno:RemoveTableOf
+#define CMD_FN_REMOVE_TEXT_BOX  .uno:RemoveTextBox
 #define CMD_FN_FORMAT_RESET .uno:ResetAttributes
 #define CMD_FN_TOOL_ANCHOR_AT_CHAR  .uno:SetAnchorAtChar
 #define CMD_FN_TOOL_ANCHOR_CHAR .uno:SetAnchorToChar
diff --git a/sw/sdi/drawsh.sdi b/sw/sdi/drawsh.sdi
index d181a0d..5b2b27a 100644
--- a/sw/sdi/drawsh.sdi
+++ b/sw/sdi/drawsh.sdi
@@ -515,5 +515,12 @@ shell SwDrawShell : SwDrawBaseShell
 StateMethod = GetState ;
 DisableFlags=SW_DISABLE_ON_PROTECTED_CURSOR;
 ]
+
+FN_REMOVE_TEXT_BOX
+[
+ExecMethod = Execute ;
+StateMethod = GetState ;
+DisableFlags=SW_DISABLE_ON_PROTECTED_CURSOR;
+]
 }
 
diff --git a/sw/sdi/swriter.sdi b/sw/sdi/swriter.sdi
index 271ad17..fc78e4a 100644
--- a/sw/sdi/swriter.sdi
+++ b/sw/sdi/swriter.sdi
@@ -10103,3 +10103,27 @@ SfxVoidItem AddTextBox FN_ADD_TEXT_BOX
 ToolBoxConfig = TRUE,
 GroupId = GID_DRAWING;
 ]
+
+SfxVoidItem RemoveTextBox FN_REMOVE_TEXT_BOX
+()
+[
+/* flags: */
+AutoUpdate = FALSE,
+Cachable = Cachable,
+FastCall = FALSE,
+HasCoreId = FALSE,
+HasDialog = FALSE,
+ReadOnlyDoc = FALSE,
+Toggle = FALSE,
+Container = FALSE,
+RecordAbsolute = FALSE,
+RecordPerSet;
+Synchron;
+
+/* config: */
+AccelConfig = TRUE,
+MenuConfig = TRUE,
+StatusBarConfig = FALSE,
+ToolBoxConfig = TRUE,
+GroupId = GID_DRAWING;
+]
diff --git a/sw/source/ui/app/mn.src b/sw/source/ui/app/mn.src
index 80090e0..f62c8da 100644
--- a/sw/source/ui/app/mn.src
+++ b/sw/source/ui/app/mn.src
@@ -1050,6 +1050,12 @@ Menu MN_DRAW_POPUPMENU
 HelpId = CMD_FN_ADD_TEXT_BOX;
 Text [ en-US ] = Add Text Box;
 };
+MenuItem
+{
+Identifier = FN_REMOVE_TEXT_BOX;
+HelpId = CMD_FN_REMOVE_TEXT_BOX;
+Text [ en-US ] = Remove Text Box;
+};
 };
 };
 
diff --git a/sw/source/uibase/shells/drawsh.cxx 
b/sw/source/uibase/shells/drawsh.cxx
index 76d2538..d4887fa 100644
--- a/sw/source/uibase/shells/drawsh.cxx
+++ b/sw/source/uibase/shells/drawsh.cxx
@@ -409,6 +409,16 @@ void SwDrawShell::Execute(SfxRequest rReq)
 }
 break;
 }
+case FN_REMOVE_TEXT_BOX:
+{
+if (SdrObject* pObj = IsSingleFillableNonOLESelected())
+{
+SwFrmFmt* pFrmFmt = ::FindFrmFmt(pObj);
+if (pFrmFmt)
+SwTextBoxHelper::destroy(pFrmFmt);
+}
+break;
+}
 default:
 OSL_ENSURE(!this, wrong dispatcher);
 return;
@@ -529,6 +539,21 @@ void SwDrawShell::GetState(SfxItemSet rSet)
 rSet.DisableItem(nWhich);
 break;
 }
+case FN_REMOVE_TEXT_BOX:
+{
+bool bDisable = true;
+if (SdrObject* pObj = IsSingleFillableNonOLESelected())
+{
+SwFrmFmt* pFrmFmt = ::FindFrmFmt(pObj);
+// Allow removing a TextBox only in case it has one.
+if (pFrmFmt  SwTextBoxHelper::findTextBox(pFrmFmt))
+bDisable = false;
+}
+
+if (bDisable)
+

Re: doxygen warning / nested comments

2014-06-19 Thread Stephan Bergmann

On 06/18/2014 05:16 PM, Lionel Elie Mamane wrote:

Noticed in my build:

/home/master/src/libreoffice/workdirs/libreoffice-4-3/udkapi/com/sun/star/io/FilePermission.idl:76:warning:
Reached end of file while still inside a (nested) comment. Nesting level 1
(probable line reference: 25)

This seems to be a message from doxygen. This looks like the
documentation of FilePermission will be blank because the content is
skipped because taken as part of comment... However,
http://api.libreoffice.org/docs/idl/ref/structcom_1_1sun_1_1star_1_1io_1_1FilePermission.html
looks reasonable, so maybe this is a red herring.

No idea with exactly what 4.2 sources and what toolchain
http://api.libreoffice.org/docs/idl/ref has been generated, but at
least recent Doxygen 1.8.6 and 1.8.7 indeed would miss documentation of
FilePermissions.

Looks like Doxygen deliberately tracks nested /* ... */ comments within
/** ... */ comments (cf. g_nestingCount in src/commentcnv.l), maybe to
support such comments inside @code blocks as discussed at
https://sourceforge.net/p/doxygen/mailman/doxygen-users/thread/ad6e09750605081949w8555322u711dbb4eb8dc0...@mail.gmail.com/
[Doxygen-users] how to add c-style comments inside @code? But I did
not find any rationale for that in the Doxygen documentation at
http://www.stack.nl/~dimitri/doxygen/manual/index.html.

1 2 3 >

1 - 100 of 286 matches

Mail list logo