LibreOffice Gerrit News for core on 2014-10-27
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo#85046 - MENU: Edit Changes should be renamed for better clarity in https://gerrit.libreoffice.org/12098 from Yousuf Philips about module officecfg, sc, svx, sw + fix trying to encode non-integer type as a bitfield in https://gerrit.libreoffice.org/12094 from Douglas Mencken about module vcl + prefer `if (s)' to `if (nil != s)' for objective-c in https://gerrit.libreoffice.org/11891 from Douglas Mencken about module vcl + Fix python wrapper script on OS X in https://gerrit.libreoffice.org/12101 from Matthew Francis about module pyuno + fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT in https://gerrit.libreoffice.org/12103 from Naruhiko Ogasawara about module pyuno End of freshness + Rendering support for multiStop GradientFill (OOXML LINEAR) in https://gerrit.libreoffice.org/12056 from Vinaya Mandke about module UnoControls, chart2, drawinglayer, filter, include, offapi, oox, sc, sd, sfx2, svx, sw, toolkit, vbahelper, vcl, xmloff + HIG fixes for smath dialogs in https://gerrit.libreoffice.org/12105 from Adolfo Jayme Barrientos about module starmath + fdo#84938: replace KEYTYPE_ constants with enum in https://gerrit.libreoffice.org/12104 from Noel Grandin about module cui, dbaccess, editeng, extensions, include, rsc, sc, starmath, svx, sw, vcl * Merged changes on master for project core changed in the last 25 hours: + fdo#62947 - Relabelling the submenu items in https://gerrit.libreoffice.org/12093 from Yousuf Philips + add transparency to fontwork gallery tango icons in https://gerrit.libreoffice.org/12100 from Yousuf Philips * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + HIG-ification of GSoC Color Picker dialog in https://gerrit.libreoffice.org/11494 from Olivier Hallot + WIP: fdo#43090: Add an option to disable autoclose brackets in https://gerrit.libreoffice.org/12024 from Marcos Paulo de Souza + convert ScHint ID's to an enum in https://gerrit.libreoffice.org/11986 from Noel Grandin + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl + Sane configure GStreamer handling in https://gerrit.libreoffice.org/11912 from Jan-Marek Glogowski + fdo#58194 - export DOCX Automatic indent as firstLine indent in https://gerrit.libreoffice.org/10425 from Joren De Cuyper + WIP (do not merge): remove custom impl of bidirectional list in https://gerrit.libreoffice.org/11001 from Chris Laplante + fdo#83003 Startcenter: No method for returnin Recent Docs in https://gerrit.libreoffice.org/11525 from Efe Gürkan Yalaman + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + Perftest for loading autocorrect dictionaries (fdo#79761) in https://gerrit.libreoffice.org/11296 from Matúš Kukan + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in https://gerrit.libreoffice.org/9914 from Rajashri Udhoji + fdo#80996:Fix for DataLabel not preserved for ColumnChart after RT in https://gerrit.libreoffice.org/10169 from Dushyant Bhalgami + fdo#77121 Header / Footer positions not preserved after RT in https://gerrit.libreoffice.org/9235 from Priyanka Gaikwad Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on||79395 --- Comment #225 from tommy27 ba...@quipo.it --- (In reply to chtfn from comment #224) Hi Kevin I just removed Bug 79395 as the 4.2 branch will not have any bugfix release anymore. not correct, the 4.2.x branch will have a new 4.2.7 update (the last) in a few days. then the official END-OF-LIFE is expected by 19 2014 see: https://wiki.documentfoundation.org/ReleasePlan#4.2_release I see it is reproducible in the 4.3 branch, so please nominate it as a 4.3 MAB on Bug 75025. Cheers! :) please do not mess things removing/adding MABs without knowing the exact procedures. that bug which is reproducible in 4.2.x has to stay in the mab4.2 list (I'm gonna put it back there) and will moved to the mab4.3 list only after the official EOL of the 4.2.x branch the mab4.2 to mab4.3 migration will be done by QA people by that time. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #226 from chtfn stephane.guil...@gmail.com --- (In reply to tommy27 from comment #225) Hi Tommy. Thank you for checking. not correct, the 4.2.x branch will have a new 4.2.7 update (the last) in a few days. then the official END-OF-LIFE is expected by 19 2014 see: https://wiki.documentfoundation.org/ReleasePlan#4.2_release I assumed 4.2.7 was out already as (1) I already got a 4.2.7 update on Ubuntu a few days ago and (2) the release plan states that 4.2.7 should have been out by the 26th of October (yesterday). So I am sorry if in fact 4.2.7 is not officially out yet, I just had two good reasons to believe it was. please do not mess things removing/adding MABs without knowing the exact procedures. that bug which is reproducible in 4.2.x has to stay in the mab4.2 list (I'm gonna put it back there) and will moved to the mab4.3 list only after the official EOL of the 4.2.x branch the mab4.2 to mab4.3 migration will be done by QA people by that time. I am aware of the the exact procedures. I have participated in MAB transfers before. In the wiki, the following is written: If there are no further releases of a LibreOffice version (or “branch”; e.g., 3.5.x), we close the MAB tracking bug for that version, and move all remaining MAB listed for that version to the MAB tracking bug for the next version – you do not need to do that yourself. I assumed 4.2.7 was out, therefore I knew there was no further release for the 4.2 branch. I then asked Kevin to nominate that bug in 4.3 MAB as this is what should be done according to the wiki (no use of adding a MAB if no extra bugfix version is planned). This not me starting a migration, even though I think we should get cracking on that before the 4.2 EOL as MABs hanging out here after 4.2.7 will have no visibility at all (and, once again, it is what is recommended on the wiki). Thank you. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #227 from tommy27 ba...@quipo.it --- sorry for sounding rude in the previous post. the 4.2.7 is not officially out yet but besides this I ask everybody here to hold on migrating mab4.2 to the mab4.3 list. It's better to wait a few weekes for the exact 4.2.x EOL to be sure that no critical issue pops out in the meantime and that no extra release will be necessary. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #228 from chtfn stephane.guil...@gmail.com --- (In reply to tommy27 from comment #227) sorry for sounding rude in the previous post. the 4.2.7 is not officially out yet but besides this I ask everybody here to hold on migrating mab4.2 to the mab4.3 list. It's better to wait a few weekes for the exact 4.2.x EOL to be sure that no critical issue pops out in the meantime and that no extra release will be necessary. No worries. Sure, that actually makes a lot of sense. It should be worded that way on the wiki to make it clear for everybody then, I am sure most QA people agree on that. Thanks -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/core/docnode/node.cxx | 50 1 file changed, 25 insertions(+), 25 deletions(-) New commits: commit 608396721edcdfce8a325026844fd2fab72bbb73 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Oct 27 08:49:46 2014 +0100 sw: fix misleading prefixes of param names in AttrSetHandleHelper Change-Id: Id7da4e54bf3a11c2cf46f924f249706eddb183f2 diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx index 00f82ac..3188fed 100644 --- a/sw/source/core/docnode/node.cxx +++ b/sw/source/core/docnode/node.cxx @@ -81,27 +81,27 @@ TYPEINIT2( SwCntntNode, SwModify, SwIndexReg ) namespace AttrSetHandleHelper { -void GetNewAutoStyle( boost::shared_ptrconst SfxItemSet mrpAttrSet, +void GetNewAutoStyle( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, SwAttrSet rNewAttrSet ) { -const SwAttrSet* pAttrSet = static_castconst SwAttrSet*(mrpAttrSet.get()); +const SwAttrSet* pAttrSet = static_castconst SwAttrSet*(rpAttrSet.get()); if( rNode.GetModifyAtAttr() ) const_castSwAttrSet*(pAttrSet)-SetModifyAtAttr( 0 ); IStyleAccess rSA = pAttrSet-GetPool()-GetDoc()-GetIStyleAccess(); -mrpAttrSet = rSA.getAutomaticStyle( rNewAttrSet, rNode.IsTxtNode() ? +rpAttrSet = rSA.getAutomaticStyle( rNewAttrSet, rNode.IsTxtNode() ? IStyleAccess::AUTO_STYLE_PARA : IStyleAccess::AUTO_STYLE_NOTXT ); -const bool bSetModifyAtAttr = ((SwAttrSet*)mrpAttrSet.get())-SetModifyAtAttr( rNode ); +const bool bSetModifyAtAttr = ((SwAttrSet*)rpAttrSet.get())-SetModifyAtAttr( rNode ); rNode.SetModifyAtAttr( bSetModifyAtAttr ); } -void SetParent( boost::shared_ptrconst SfxItemSet mrpAttrSet, +void SetParent( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, const SwFmt* pParentFmt, const SwFmt* pConditionalFmt ) { -const SwAttrSet* pAttrSet = static_castconst SwAttrSet*(mrpAttrSet.get()); +const SwAttrSet* pAttrSet = static_castconst SwAttrSet*(rpAttrSet.get()); OSL_ENSURE( pAttrSet, no SwAttrSet ); OSL_ENSURE( pParentFmt || !pConditionalFmt, ConditionalFmt without ParentFmt? ); @@ -128,25 +128,25 @@ void SetParent( boost::shared_ptrconst SfxItemSet mrpAttrSet, aNewSet.Put( aFmtColl ); } -GetNewAutoStyle( mrpAttrSet, rNode, aNewSet ); +GetNewAutoStyle( rpAttrSet, rNode, aNewSet ); } } -const SfxPoolItem* Put( boost::shared_ptrconst SfxItemSet mrpAttrSet, +const SfxPoolItem* Put( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, const SfxPoolItem rAttr ) { -SwAttrSet aNewSet( (SwAttrSet)*mrpAttrSet ); +SwAttrSet aNewSet( (SwAttrSet)*rpAttrSet ); const SfxPoolItem* pRet = aNewSet.Put( rAttr ); if ( pRet ) -GetNewAutoStyle( mrpAttrSet, rNode, aNewSet ); +GetNewAutoStyle( rpAttrSet, rNode, aNewSet ); return pRet; } -bool Put( boost::shared_ptrconst SfxItemSet mrpAttrSet, const SwCntntNode rNode, +bool Put( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, const SfxItemSet rSet ) { -SwAttrSet aNewSet( (SwAttrSet)*mrpAttrSet ); +SwAttrSet aNewSet( (SwAttrSet)*rpAttrSet ); // #i76273# Robust SfxItemSet* pStyleNames = 0; @@ -166,16 +166,16 @@ bool Put( boost::shared_ptrconst SfxItemSet mrpAttrSet, const SwCntntNode rN } if ( nRet ) -GetNewAutoStyle( mrpAttrSet, rNode, aNewSet ); +GetNewAutoStyle( rpAttrSet, rNode, aNewSet ); return nRet; } -bool Put_BC( boost::shared_ptrconst SfxItemSet mrpAttrSet, +bool Put_BC( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, const SfxPoolItem rAttr, SwAttrSet* pOld, SwAttrSet* pNew ) { -SwAttrSet aNewSet( (SwAttrSet)*mrpAttrSet ); +SwAttrSet aNewSet( (SwAttrSet)*rpAttrSet ); // for a correct broadcast, we need to do a SetModifyAtAttr with the items // from aNewSet. The 'regular' SetModifyAtAttr is done in GetNewAutoStyle @@ -185,16 +185,16 @@ bool Put_BC( boost::shared_ptrconst SfxItemSet mrpAttrSet, const bool nRet = aNewSet.Put_BC( rAttr, pOld, pNew ); if ( nRet ) -GetNewAutoStyle( mrpAttrSet, rNode, aNewSet ); +GetNewAutoStyle( rpAttrSet, rNode, aNewSet ); return nRet; } -bool Put_BC( boost::shared_ptrconst SfxItemSet mrpAttrSet, +bool Put_BC( boost::shared_ptrconst SfxItemSet rpAttrSet, const SwCntntNode rNode, const SfxItemSet rSet, SwAttrSet* pOld, SwAttrSet* pNew ) { -SwAttrSet aNewSet( (SwAttrSet)*mrpAttrSet ); +SwAttrSet aNewSet( (SwAttrSet)*rpAttrSet ); // #i76273# Robust SfxItemSet* pStyleNames = 0; @@ -219,35
[Libreoffice-commits] core.git: cui/source dbaccess/source editeng/source extensions/source include/rsc include/vcl rsc/inc rsc/source sc/source starmath/source svx/source sw/source vcl/source
cui/source/tabpages/autocdlg.cxx |2 - dbaccess/source/ui/control/dbtreelistbox.cxx | 10 ++--- dbaccess/source/ui/control/sqledit.cxx |2 - editeng/source/editeng/editeng.cxx | 24 ++-- editeng/source/editeng/impedit.cxx |8 ++-- editeng/source/outliner/outlvw.cxx | 14 +++ extensions/source/bibliography/framectr.cxx |6 +-- include/rsc/rsc-vcl-shared-types.hxx | 11 ++--- include/vcl/keycod.hxx | 14 +++ rsc/inc/rscdb.hxx|2 + rsc/source/parser/rscicpx.cxx| 38 ++-- sc/source/ui/app/inputhdl.cxx|2 - sc/source/ui/view/tabvwsh4.cxx |4 +- starmath/source/view.cxx |6 +-- svx/source/fmcomp/gridctrl.cxx |2 - svx/source/form/navigatortree.cxx|6 +-- svx/source/svdraw/svdview.cxx| 16 sw/source/uibase/docvw/edtwin.cxx|2 - vcl/source/control/edit.cxx | 24 ++-- vcl/source/edit/texteng.cxx | 14 +++ vcl/source/edit/textview.cxx | 16 vcl/source/window/keycod.cxx | 50 +-- 22 files changed, 137 insertions(+), 136 deletions(-) New commits: commit 7ef698355ad59c6fa263daa4ded124cf512e8926 Author: Noel Grandin n...@peralex.com Date: Sun Oct 26 13:01:46 2014 +0200 fdo#84938: replace KEYTYPE_ constants with enum Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index f1d3a8f..4c25cb7 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -2335,7 +2335,7 @@ bool OfaAutoCompleteTabPage::AutoCompleteMultiListBox::PreNotify( break; default: -if( KEYFUNC_COPY == rKeyCode.GetFunction() ) +if( KeyFuncType::COPY == rKeyCode.GetFunction() ) { m_pPage-CopyToClipboard(); nHandled = true; diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx b/dbaccess/source/ui/control/dbtreelistbox.cxx index a91b22c..8c6978a 100644 --- a/dbaccess/source/ui/control/dbtreelistbox.cxx +++ b/dbaccess/source/ui/control/dbtreelistbox.cxx @@ -311,26 +311,26 @@ void DBTreeListBox::KeyInput( const KeyEvent rKEvt ) sal_uInt16 nCode = rKEvt.GetKeyCode().GetCode(); bool bHandled = false; -if(eFunc != KEYFUNC_DONTKNOW) +if(eFunc != KeyFuncType::DONTKNOW) { switch(eFunc) { -case KEYFUNC_CUT: +case KeyFuncType::CUT: bHandled = ( m_aCutHandler.IsSet() !m_aSelectedEntries.empty() ); if ( bHandled ) m_aCutHandler.Call( NULL ); break; -case KEYFUNC_COPY: +case KeyFuncType::COPY: bHandled = ( m_aCopyHandler.IsSet() !m_aSelectedEntries.empty() ); if ( bHandled ) m_aCopyHandler.Call( NULL ); break; -case KEYFUNC_PASTE: +case KeyFuncType::PASTE: bHandled = ( m_aPasteHandler.IsSet() !m_aSelectedEntries.empty() ); if ( bHandled ) m_aPasteHandler.Call( NULL ); break; -case KEYFUNC_DELETE: +case KeyFuncType::DELETE: bHandled = ( m_aDeleteHandler.IsSet() !m_aSelectedEntries.empty() ); if ( bHandled ) m_aDeleteHandler.Call( NULL ); diff --git a/dbaccess/source/ui/control/sqledit.cxx b/dbaccess/source/ui/control/sqledit.cxx index 72f6a27..ff4007f 100644 --- a/dbaccess/source/ui/control/sqledit.cxx +++ b/dbaccess/source/ui/control/sqledit.cxx @@ -126,7 +126,7 @@ void OSqlEdit::KeyInput( const KeyEvent rKEvt ) // Is this a cut, copy, paste event? KeyFuncType aKeyFunc = rKEvt.GetKeyCode().GetFunction(); -if( (aKeyFunc==KEYFUNC_CUT)||(aKeyFunc==KEYFUNC_COPY)||(aKeyFunc==KEYFUNC_PASTE) ) +if( (aKeyFunc==KeyFuncType::CUT)||(aKeyFunc==KeyFuncType::COPY)||(aKeyFunc==KeyFuncType::PASTE) ) m_bAccelAction = true; MultiLineEditSyntaxHighlight::KeyInput( rKEvt ); diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index 56c487c..4635136 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -974,18 +974,18 @@ bool EditEngine::PostKeyEvent( const KeyEvent rKeyEvent, EditView* pEditView, v sal_uInt16 nCode = rKeyEvent.GetKeyCode().GetCode(); KeyFuncType eFunc = rKeyEvent.GetKeyCode().GetFunction(); -if ( eFunc !=
[Libreoffice-commits] core.git: Branch 'feature/droid_calcimpress3' - android/mobile-config.py
android/mobile-config.py | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) New commits: commit 32b8d6734388e9e67db5ed76277874f9aaf9c740 Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 10:19:59 2014 +0200 Beware of modifying a list being iterated Change-Id: Ib9cf1a47eb20bd28d954ddcded89f67cf6865f1c diff --git a/android/mobile-config.py b/android/mobile-config.py index ff2fd53..cdf0afc 100755 --- a/android/mobile-config.py +++ b/android/mobile-config.py @@ -54,18 +54,26 @@ if __name__ == '__main__': tree = ET.parse(sys.argv[1]) root = tree.getroot() -saved = 0 total = 0 for child in root: -section = child.attrib['{http://openoffice.org/2001/registry}name'] -package = child.attrib['{http://openoffice.org/2001/registry}package'] -size = len(ET.tostring(child)); -total = total + size -key = '%s/%s' % (package, section) -if key in main_xcd_discard: -root.remove(child) -print 'removed %s - saving %d' % (key, size) -saved = saved + size +total += len(ET.tostring(child)) + +saved = 0 +restarted = True + +while restarted: +restarted = False +for child in root: +section = child.attrib['{http://openoffice.org/2001/registry}name'] +package = child.attrib['{http://openoffice.org/2001/registry}package'] +size = len(ET.tostring(child)); +key = '%s/%s' % (package, section) +if key in main_xcd_discard: +root.remove(child) +print 'removed %s - saving %d' % (key, size) +saved = saved + size +restarted = True +break print saved %d of %d bytes: %2.f%% % (saved, total, saved*100.0/total) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - 3 commits - sc/qa sd/qa sw/CppunitTest_sw_globalfilter.mk sw/Module_sw.mk sw/qa
sc/qa/unit/data/ods/document_with_an_image.ods|binary sc/qa/unit/subsequent_export-test.cxx | 72 sd/qa/unit/data/odp/document_with_an_image.odp|binary sd/qa/unit/export-tests.cxx | 70 sw/CppunitTest_sw_globalfilter.mk | 90 ++ sw/Module_sw.mk |1 sw/qa/extras/globalfilter/data/document_with_an_image.odt |binary sw/qa/extras/globalfilter/globalfilter.cxx| 120 ++ 8 files changed, 353 insertions(+) New commits: commit 002b1dc2f3bfe2360f8fe368d93f7c7a8b4a4155 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sat Oct 25 18:21:40 2014 +0200 Test for swapped out image loss during Calc export Related to the bug fdo#52226. The problem was that the images were somehow swapped out but were not swapped in during export. Test the main Calc formats: ODS, XLS, XLSX, HTML. Change-Id: I4835ff2960fbd11cc9750ed3da20df26cd6cbaba diff --git a/sc/qa/unit/data/ods/document_with_an_image.ods b/sc/qa/unit/data/ods/document_with_an_image.ods new file mode 100644 index 000..adfcd4c Binary files /dev/null and b/sc/qa/unit/data/ods/document_with_an_image.ods differ diff --git a/sc/qa/unit/subsequent_export-test.cxx b/sc/qa/unit/subsequent_export-test.cxx index 988ed34..9e058b2 100644 --- a/sc/qa/unit/subsequent_export-test.cxx +++ b/sc/qa/unit/subsequent_export-test.cxx @@ -42,6 +42,8 @@ #include dputil.hxx #include svx/svdoole2.hxx +#include svx/svdpage.hxx +#include svx/svdograf.hxx #include tabprotection.hxx #include editeng/wghtitem.hxx #include editeng/postitem.hxx @@ -62,6 +64,10 @@ #include com/sun/star/table/BorderLineStyle.hpp #include com/sun/star/sheet/DataPilotFieldOrientation.hpp #include com/sun/star/sheet/GeneralFunction.hpp +#include com/sun/star/drawing/XDrawPage.hpp +#include com/sun/star/drawing/XDrawPageSupplier.hpp +#include com/sun/star/awt/XBitmap.hpp +#include com/sun/star/graphic/XGraphic.hpp using namespace ::com::sun::star; using namespace ::com::sun::star::uno; @@ -124,6 +130,7 @@ public: void testPivotTableXLSX(); void testPivotTableTwoDataFieldsXLSX(); +void testSwappedOutImageExport(); CPPUNIT_TEST_SUITE(ScExportTest); CPPUNIT_TEST(test); @@ -164,6 +171,7 @@ public: CPPUNIT_TEST(testPivotTableXLSX); CPPUNIT_TEST(testPivotTableTwoDataFieldsXLSX); CPPUNIT_TEST(testFunctionsExcel2010ODS); +CPPUNIT_TEST(testSwappedOutImageExport); CPPUNIT_TEST_SUITE_END(); @@ -2250,6 +2258,70 @@ void ScExportTest::testFunctionsExcel2010ODS() //testFunctionsExcel2010(ODS); } +void ScExportTest::testSwappedOutImageExport() +{ +std::vectorOUString aFilterNames = { +calc8, +MS Excel 97, +Calc Office Open XML, +generic_HTML, +}; + +for( size_t nFilter = 0; nFilter aFilterNames.size(); ++nFilter ) +{ +// Check whether the export code swaps in the image which was swapped out before. +ScDocShellRef xDocSh = loadDoc(document_with_an_image., ODS); + +const OString sFailedMessage = OString(Failed on filter: ) + + OUStringToOString(aFilterNames[nFilter], RTL_TEXTENCODING_ASCII_US); + +// Find and swap out the image +CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), xDocSh.Is()); +ScDocument* pDoc = xDocSh-GetDocument(); +CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), pDoc); +ScDrawLayer* pDrawLayer = pDoc-GetDrawLayer(); +CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), pDrawLayer); +const SdrPage* pPage = pDrawLayer-GetPage(0); +CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), pPage); +const SdrObject* pObj = pPage-GetObj(0); +CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), pObj-GetObjIdentifier() == OBJ_GRAF); +const SdrGrafObj rGrafObj = static_castconst SdrGrafObj(*pObj); +rGrafObj.ForceSwapOut(); + +// Export the document and import again for a check +ScDocShellRef xDocSh2 = saveAndReload(xDocSh, nFilter); +xDocSh-DoClose(); + +// Check whether graphic exported well after it was swapped out +uno::Reference frame::XModel xModel = xDocSh2-GetModel(); +uno::Reference sheet::XSpreadsheetDocument xDoc(xModel, UNO_QUERY_THROW); +uno::Reference container::XIndexAccess xIA(xDoc-getSheets(), UNO_QUERY_THROW); +uno::Reference drawing::XDrawPageSupplier xDrawPageSupplier( xIA-getByIndex(0), UNO_QUERY_THROW); +uno::Reference container::XIndexAccess xDraws(xDrawPageSupplier-getDrawPage(), UNO_QUERY_THROW); +CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailedMessage.getStr(), static_castsal_Int32(1), xDraws-getCount()); + +uno::Referencedrawing::XShape xImage(xDraws-getByIndex(0), uno::UNO_QUERY); +uno::Reference
[Libreoffice-commits] core.git: 2 commits - connectivity/source package/source
connectivity/source/drivers/jdbc/ResultSet.cxx |2 +- connectivity/source/inc/java/sql/ResultSet.hxx |2 +- package/source/zippackage/ZipPackageEntry.cxx |2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) New commits: commit c0c8478620c1a157e1175cc3c632b09e0e4506a3 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 11:36:37 2014 +0200 cid#1249676 Uninitialized scalar field Change-Id: I87df4e9c1d3f36afccf13aebfd95d1b4f3bfa655 diff --git a/package/source/zippackage/ZipPackageEntry.cxx b/package/source/zippackage/ZipPackageEntry.cxx index 4d5d63d..78a2e5d 100644 --- a/package/source/zippackage/ZipPackageEntry.cxx +++ b/package/source/zippackage/ZipPackageEntry.cxx @@ -42,7 +42,9 @@ using namespace com::sun::star::packages::zip::ZipConstants; ZipPackageEntry::ZipPackageEntry() : mbIsFolder( false ) +, mbAllowRemoveOnInsert(false) , mpParent ( NULL ) +, m_nFormat(0) { } commit 5c90f8dd04d77ebc444b68723e0a17f166b700cd Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 11:34:06 2014 +0200 cid#1249675 Uncaught exception Change-Id: I3923a6a83bfc0a35f5a5af86cfd0e5308cfda24c diff --git a/connectivity/source/drivers/jdbc/ResultSet.cxx b/connectivity/source/drivers/jdbc/ResultSet.cxx index 948c127..7122937 100644 --- a/connectivity/source/drivers/jdbc/ResultSet.cxx +++ b/connectivity/source/drivers/jdbc/ResultSet.cxx @@ -899,7 +899,7 @@ sal_Bool java_sql_ResultSet::convertFastPropertyValue( ::com::sun::star::uno::Any rOldValue, sal_Int32 nHandle, const ::com::sun::star::uno::Any rValue ) -throw (::com::sun::star::lang::IllegalArgumentException) +throw (::com::sun::star::lang::IllegalArgumentException, ::com::sun::star::uno::RuntimeException) { bool bRet = false; switch(nHandle) diff --git a/connectivity/source/inc/java/sql/ResultSet.hxx b/connectivity/source/inc/java/sql/ResultSet.hxx index eb3a2ca..07a0653 100644 --- a/connectivity/source/inc/java/sql/ResultSet.hxx +++ b/connectivity/source/inc/java/sql/ResultSet.hxx @@ -87,7 +87,7 @@ namespace connectivity ::com::sun::star::uno::Any rOldValue, sal_Int32 nHandle, const ::com::sun::star::uno::Any rValue ) -throw (::com::sun::star::lang::IllegalArgumentException) SAL_OVERRIDE; +throw (::com::sun::star::lang::IllegalArgumentException, ::com::sun::star::uno::RuntimeException) SAL_OVERRIDE; virtual void SAL_CALL setFastPropertyValue_NoBroadcast( sal_Int32 nHandle, const ::com::sun::star::uno::Any rValue ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: ciabot/libreoffice-bugzilla2.py
ciabot/libreoffice-bugzilla2.py |1 + 1 file changed, 1 insertion(+) New commits: commit c1f9d3a8334053c53b90a81b6931a9ea3dde7a44 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Oct 27 11:00:25 2014 +0100 add missing new line diff --git a/ciabot/libreoffice-bugzilla2.py b/ciabot/libreoffice-bugzilla2.py index 1a72143..7d2adeb 100644 --- a/ciabot/libreoffice-bugzilla2.py +++ b/ciabot/libreoffice-bugzilla2.py @@ -72,6 +72,7 @@ It has been pushed to %s: %s %s + It will be available in %s. The patch should be included in the daily builds available at ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/crystal icon-themes/oxygen icon-themes/sifr icon-themes/tango
icon-themes/crystal/cmd/lc_insertfieldctrl.png |binary icon-themes/crystal/cmd/sc_insertfieldctrl.png |binary icon-themes/oxygen/cmd/lc_insertfieldctrl.png |binary icon-themes/oxygen/cmd/sc_insertfieldctrl.png |binary icon-themes/sifr/cmd/lc_insertfieldctrl.png|binary icon-themes/sifr/cmd/sc_insertfieldctrl.png|binary icon-themes/tango/cmd/lc_insertfieldctrl.png |binary icon-themes/tango/cmd/sc_insertfieldctrl.png |binary 8 files changed New commits: commit 573aa44d74c205a5f3962a9335313b6d140a7102 Author: Yousuf Philips philip...@hotmail.com Date: Mon Oct 27 12:43:39 2014 +0400 fdo#85500 - TOOLBAR: Use insert page number icon for insert field control Change-Id: Ibebe4ea7ba504b306a191ca0cd61cfd366577d5e Reviewed-on: https://gerrit.libreoffice.org/12107 Reviewed-by: Matthew Francis mjay.fran...@gmail.com Tested-by: Matthew Francis mjay.fran...@gmail.com diff --git a/icon-themes/crystal/cmd/lc_insertfieldctrl.png b/icon-themes/crystal/cmd/lc_insertfieldctrl.png new file mode 100644 index 000..20a36d4 Binary files /dev/null and b/icon-themes/crystal/cmd/lc_insertfieldctrl.png differ diff --git a/icon-themes/crystal/cmd/sc_insertfieldctrl.png b/icon-themes/crystal/cmd/sc_insertfieldctrl.png new file mode 100644 index 000..f0a7787 Binary files /dev/null and b/icon-themes/crystal/cmd/sc_insertfieldctrl.png differ diff --git a/icon-themes/oxygen/cmd/lc_insertfieldctrl.png b/icon-themes/oxygen/cmd/lc_insertfieldctrl.png index 160030f..20a36d4 100644 Binary files a/icon-themes/oxygen/cmd/lc_insertfieldctrl.png and b/icon-themes/oxygen/cmd/lc_insertfieldctrl.png differ diff --git a/icon-themes/oxygen/cmd/sc_insertfieldctrl.png b/icon-themes/oxygen/cmd/sc_insertfieldctrl.png index 5c0dffb..f0a7787 100644 Binary files a/icon-themes/oxygen/cmd/sc_insertfieldctrl.png and b/icon-themes/oxygen/cmd/sc_insertfieldctrl.png differ diff --git a/icon-themes/sifr/cmd/lc_insertfieldctrl.png b/icon-themes/sifr/cmd/lc_insertfieldctrl.png new file mode 100644 index 000..f099a37 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertfieldctrl.png differ diff --git a/icon-themes/sifr/cmd/sc_insertfieldctrl.png b/icon-themes/sifr/cmd/sc_insertfieldctrl.png new file mode 100644 index 000..c67104a Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertfieldctrl.png differ diff --git a/icon-themes/tango/cmd/lc_insertfieldctrl.png b/icon-themes/tango/cmd/lc_insertfieldctrl.png new file mode 100644 index 000..1f7ea64 Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertfieldctrl.png differ diff --git a/icon-themes/tango/cmd/sc_insertfieldctrl.png b/icon-themes/tango/cmd/sc_insertfieldctrl.png new file mode 100644 index 000..b2817b3 Binary files /dev/null and b/icon-themes/tango/cmd/sc_insertfieldctrl.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - 3 commits - include/svtools svtools/source sw/inc sw/source
include/svtools/grfmgr.hxx |2 +- svtools/source/graphic/grfmgr.cxx|3 ++- svtools/source/graphic/grfmgr2.cxx |4 ++-- sw/inc/ndgrf.hxx |4 ++-- sw/source/core/graphic/ndgrf.cxx | 12 sw/source/filter/ww8/docxattributeoutput.cxx | 10 ++ sw/source/filter/ww8/rtfattributeoutput.cxx |6 -- sw/source/filter/ww8/wrtw8esh.cxx|2 -- sw/source/filter/ww8/wrtww8gr.cxx|2 -- 9 files changed, 21 insertions(+), 24 deletions(-) New commits: commit 6836e9d9ff9c1f79f24fb5d53b617da104ba2969 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Mon Oct 27 11:20:49 2014 +0100 Assign graphic data also during auto swap in Change-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6 diff --git a/svtools/source/graphic/grfmgr.cxx b/svtools/source/graphic/grfmgr.cxx index 2886524..68c19ab 100644 --- a/svtools/source/graphic/grfmgr.cxx +++ b/svtools/source/graphic/grfmgr.cxx @@ -266,6 +266,7 @@ void GraphicObject::ImplAutoSwapIn() mpMgr-ImplGraphicObjectWasSwappedIn( *this ); } } +ImplAssignGraphicData(); } bool GraphicObject::ImplGetCropParams( OutputDevice* pOut, Point rPt, Size rSz, const GraphicAttr* pAttr, commit aee25dbf569ef6b5ee80453e4f581f96e80151ae Author: Zolnai Tamás tamas.zol...@collabora.com Date: Sun Oct 26 12:26:18 2014 +0100 fdo#46447: do not auto swap out the same image which was swapped in right now Before an image data is used GraphicObject should be swapped in. When a GraphicObject is swapped in auto swapping mechanism is triggered which can swap out some of the images. We should avoid to swap out the same image on which the swap in method was called before because the caller code assumes that the image data is there. Change-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be diff --git a/include/svtools/grfmgr.hxx b/include/svtools/grfmgr.hxx index d452276..a8c391c 100644 --- a/include/svtools/grfmgr.hxx +++ b/include/svtools/grfmgr.hxx @@ -615,7 +615,7 @@ private: // For 32Bit systems this leads to situations where graphics will be missing. This method will actively swap out // the longest swapped in graphics until a maximum memory boundary (derived from user settings in tools/options/memory) // is no longer exceeded -void SVT_DLLPRIVATE ImplCheckSizeOfSwappedInGraphics(); +void SVT_DLLPRIVATE ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGraphicToIgnore); public: GraphicManager( sal_uLong nCacheSize = 1000UL, sal_uLong nMaxObjCacheSize = 240UL ); diff --git a/svtools/source/graphic/grfmgr.cxx b/svtools/source/graphic/grfmgr.cxx index eb482cf..2886524 100644 --- a/svtools/source/graphic/grfmgr.cxx +++ b/svtools/source/graphic/grfmgr.cxx @@ -70,7 +70,7 @@ void GraphicObject::ImplAfterDataChange() // check memory footprint of all GraphicObjects managed and evtl. take action if (mpMgr) -mpMgr-ImplCheckSizeOfSwappedInGraphics(); +mpMgr-ImplCheckSizeOfSwappedInGraphics(this); } GraphicObject::GraphicObject( const GraphicManager* pMgr ) : diff --git a/svtools/source/graphic/grfmgr2.cxx b/svtools/source/graphic/grfmgr2.cxx index b61f079..c97a043 100644 --- a/svtools/source/graphic/grfmgr2.cxx +++ b/svtools/source/graphic/grfmgr2.cxx @@ -192,7 +192,7 @@ namespace }; } // end of anonymous namespace -void GraphicManager::ImplCheckSizeOfSwappedInGraphics() +void GraphicManager::ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGraphicToIgnore) { // get the currently used memory footprint of all swapped in bitmap graphics // of this graphic manager. Remember candidates in a vector. The size in bytes is @@ -205,7 +205,7 @@ void GraphicManager::ImplCheckSizeOfSwappedInGraphics() for (size_t i = 0, n = maObjList.size(); i n; ++i) { pObj = maObjList[i]; -if (pObj-meType == GRAPHIC_BITMAP !pObj-IsSwappedOut() pObj-GetSizeBytes()) +if (pObj-meType == GRAPHIC_BITMAP !pObj-IsSwappedOut() pObj-GetSizeBytes() pObj != pGraphicToIgnore) { aCandidates.push_back(pObj); size_t const nSize = pObj-GetSizeBytes(); commit 827d11af9b383223a9aa00de7d45079bbaeacc2a Author: Zolnai Tamás tamas.zol...@collabora.com Date: Mon Oct 27 09:49:55 2014 +0100 Swap in graphic by SwGrfNode/SwOLENode and not manually It's a Writer specific problem, that images lost during export because of not swapped in graphic data. Other components (Impress, Calc...) use SdrGrafObj to get the graphic and SdrGrafObj calls swap in before retrun with the graphic. Change-Id: I7398d8e3f6535199b10de048acd58543bdb42531 diff --git a/sw/inc/ndgrf.hxx b/sw/inc/ndgrf.hxx index 212a612..2b50fce 100644 --- a/sw/inc/ndgrf.hxx +++ b/sw/inc/ndgrf.hxx @@ -123,8 +123,8 @@ class
[Libreoffice-commits] core.git: Branch 'feature/droid_calcimpress3' - framework/source
framework/source/services/taskcreatorsrv.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit e41162d786895863fdd3f37d24bd126a77058481 Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 13:26:31 2014 +0200 Ignore exceptions when getting the background color configuration We are experimenting with a pruned configuration database in the desktop case, and letting the exception propagate here killed the document loading. Change-Id: I59e5d016617c17c2bc36de2fd69c6691bfa6b135 diff --git a/framework/source/services/taskcreatorsrv.cxx b/framework/source/services/taskcreatorsrv.cxx index 0e30ef5..2b04c81 100644 --- a/framework/source/services/taskcreatorsrv.cxx +++ b/framework/source/services/taskcreatorsrv.cxx @@ -272,10 +272,21 @@ css::uno::Reference css::awt::XWindow TaskCreatorService::implts_createContai if ( ! xWindow.is()) throw css::uno::Exception(TaskCreator service was not able to create suitable frame window., static_cast ::cppu::OWeakObject* (this)); + +sal_Int32 nBackground = 0x; + if (bTopWindow) - xPeer-setBackground(::svtools::ColorConfig().GetColorValue(::svtools::APPBACKGROUND).nColor); -else -xPeer-setBackground(0x); +{ +try +{ +nBackground = ::svtools::ColorConfig().GetColorValue(::svtools::APPBACKGROUND).nColor; +} +catch (const css::uno::Exception ) +{ +// Ignore +} +} +xPeer-setBackground(nBackground); return xWindow; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/qa writerfilter/source
sw/qa/extras/htmlexport/htmlexport.cxx|4 +-- sw/qa/extras/rtfimport/data/fdo85179.rtf | 33 ++ sw/qa/extras/rtfimport/rtfimport.cxx |7 + writerfilter/source/dmapper/GraphicImport.cxx | 32 +++-- writerfilter/source/dmapper/GraphicImport.hxx |2 - 5 files changed, 68 insertions(+), 10 deletions(-) New commits: commit 07f36a421461217a78e61d97e86760738acabbe6 Author: Miklos Vajna vmik...@collabora.co.uk Date: Thu Oct 23 17:09:25 2014 +0200 fdo#85179 RTF filter: import image border Also adjust CppunitTest_sw_htmlexport that implicitly tested that there is no color around the image. (cherry picked from commit 01a32b7d074511bed24044dc94e1159aea62722b) Conflicts: writerfilter/source/dmapper/GraphicImport.cxx Change-Id: I8e14dfa7e7be80c4f8c492999071decae6a492e8 Reviewed-on: https://gerrit.libreoffice.org/12092 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/sw/qa/extras/htmlexport/htmlexport.cxx b/sw/qa/extras/htmlexport/htmlexport.cxx index a59515e..faa3d4f 100644 --- a/sw/qa/extras/htmlexport/htmlexport.cxx +++ b/sw/qa/extras/htmlexport/htmlexport.cxx @@ -122,7 +122,7 @@ DECLARE_HTMLEXPORT_TEST(testExportOfImages, textAndImage.docx) CPPUNIT_ASSERT(pDoc); assertXPath(pDoc, /html/body, 1); -assertXPath(pDoc, /html/body/p/img, 1); +assertXPath(pDoc, /html/body/p/font/img, 1); } DECLARE_HTMLEXPORT_TEST(testExportOfImagesWithSkipImageEnabled, textAndImage.docx) @@ -131,7 +131,7 @@ DECLARE_HTMLEXPORT_TEST(testExportOfImagesWithSkipImageEnabled, textAndImage.do CPPUNIT_ASSERT(pDoc); assertXPath(pDoc, /html/body, 1); -assertXPath(pDoc, /html/body/p/img, 0); +assertXPath(pDoc, /html/body/p/font/img, 0); } DECLARE_HTMLEXPORT_TEST(testSkipImageEmbedded, skipimage-embedded.doc) diff --git a/sw/qa/extras/rtfimport/data/fdo85179.rtf b/sw/qa/extras/rtfimport/data/fdo85179.rtf new file mode 100644 index 000..fb9bcfa --- /dev/null +++ b/sw/qa/extras/rtfimport/data/fdo85179.rtf @@ -0,0 +1,33 @@ +{\rtf1 +\pard\plain +{\*\shppict +{\pict +{\*\picprop\shplid1025 +{\sp +{\sn shapeType} +{\sv 75} +} +{\sp +{\sn lineColor} +{\sv 65535} +} +{\sp +{\sn lineWidth} +{\sv 50800} +} +} +\picscalex100\picscaley100\piccropl0\piccropr0\piccropt0\piccropb0\picw1806\pich1806\picwgoal1024\pichgoal1024\pngblip +89504e470d0a1a0a000d4948445200400040080460b955000467414d41b18f0bfc610500017352474200aece1ce9 +00206348524d7a268084fa0080e87530ea603a9817709cba513c0002624b4744aa8d233200096f464673 +0006000c7355d30009704859730dd70dd70142289b78000976704167004c0040009d31381b01cd4944415468 +deedd93d4fc24018c0f17f89c6cdc44940e3e222be2c0e7e0417e3a8113571707632514012a320c6f84d34be2c2ec2b750f40be8e6e4a00113cfe14a5b69b108 +f4589ee71652eefafce0b9f42e3d7063822aaac3f641d173a75d3efee85b6582c0c8749c5eb7332cfb4e6f213d336ed29807304477b1c7a94db80ae9e9c934d0 +fcdd12e7ffcefcc9168f9a0059143b8cb0d2de581f609854073fbecc220f60b18722479d0d14abed8c8cb5d3293ce2949903b0d8a7047cb1c98541008cba840c +a736e1d2200046b967567f740961d3b197008873cf74835002eaac736319ca0d4296121675d2dc1a0440d2256428625163ed2f42cf011e8245d621b42c44 +0400485261a699706d192fa100d4490713220240dc25e438b1090185880ca09f8ece5c28d9843b009e82471ca25069d5cb785529bd007fdbfb8541b65b2f +531100947a51530d42c1d92f9829818e31ca4ce9421c70e427440e80712a7a89b7c8fb0906003046a5311df31cf501a01f4d0ee1b80f00bd4c398558ee0340ff +0b939a30df17002459f05d330a080a0108421084210842108421f8ce0ddf798e30dd7b38e0ce7ea16d2abc25a819cbda225337c7 +f7ff69bf8eef7f0084e08d42bdf8a03e0025744558746372656174652d6461746500323031302d31322d32305431373a30383a33362b30313a30307ae51b1c0025744558746d6f646966792d6461746500323031302d31322d32305431373a30383a33372b30313a30308323669c49454e44ae4260820a} +} +\par +} diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx index 24afe98..d4cb897 100644 --- a/sw/qa/extras/rtfimport/rtfimport.cxx +++ b/sw/qa/extras/rtfimport/rtfimport.cxx @@ -1907,6 +1907,13 @@ DECLARE_RTFIMPORT_TEST(testFdo83464, fdo83464.rtf) CPPUNIT_ASSERT_EQUAL(OUString(Verdana), getPropertyOUString(getRun(getParagraphOfText(1, xFrameText-getText()), 1), CharFontName)); } +DECLARE_RTFIMPORT_TEST(testFdo85179, fdo85179.rtf) +{ +// This was 0, border around the picture was ignored on import. +// 360: EMU - MM100 +CPPUNIT_ASSERT_EQUAL(sal_uInt32(50800/360), getPropertytable::BorderLine2(getShape(1), TopBorder).LineWidth); +} + CPPUNIT_PLUGIN_IMPLEMENT(); /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/writerfilter/source/dmapper/GraphicImport.cxx b/writerfilter/source/dmapper/GraphicImport.cxx index 4c68904..f53f7f3 100644 ---
[Libreoffice-commits] core.git: icon-themes/sifr
icon-themes/sifr/cmd/lc_autosum.png |binary icon-themes/sifr/cmd/lc_insertformula.png |binary icon-themes/sifr/cmd/sc_autosum.png |binary icon-themes/sifr/cmd/sc_insertformula.png |binary 4 files changed New commits: commit bb214c3279a6e00229c459980cfec151a753fad0 Author: Yousuf Philips philip...@hotmail.com Date: Mon Oct 27 16:19:19 2014 +0400 SIFR: add missing icons for calc's function wizard and sum toolbar buttons Change-Id: Ia3fd2f71ee68e03a409c00d146ad0647e305a6f2 Reviewed-on: https://gerrit.libreoffice.org/12109 Reviewed-by: Matthew Francis mjay.fran...@gmail.com Tested-by: Matthew Francis mjay.fran...@gmail.com diff --git a/icon-themes/sifr/cmd/lc_autosum.png b/icon-themes/sifr/cmd/lc_autosum.png new file mode 100644 index 000..bddc620 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_autosum.png differ diff --git a/icon-themes/sifr/cmd/lc_insertformula.png b/icon-themes/sifr/cmd/lc_insertformula.png new file mode 100644 index 000..02782d5 Binary files /dev/null and b/icon-themes/sifr/cmd/lc_insertformula.png differ diff --git a/icon-themes/sifr/cmd/sc_autosum.png b/icon-themes/sifr/cmd/sc_autosum.png new file mode 100644 index 000..056a6bb Binary files /dev/null and b/icon-themes/sifr/cmd/sc_autosum.png differ diff --git a/icon-themes/sifr/cmd/sc_insertformula.png b/icon-themes/sifr/cmd/sc_insertformula.png new file mode 100644 index 000..17846de Binary files /dev/null and b/icon-themes/sifr/cmd/sc_insertformula.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - icon-themes/tango include/svx sc/inc sc/source sc/uiconfig svx/inc svx/source svx/uiconfig
icon-themes/tango/links.txt |1 include/svx/dialogs.hrc |6 sc/inc/helpids.h |3 sc/inc/sc.hrc|1 sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx | 71 -- sc/source/ui/sidebar/CellAppearancePropertyPanel.hrc |5 sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx | 13 - sc/source/ui/sidebar/CellAppearancePropertyPanel.src | 25 --- sc/uiconfig/scalc/ui/sidebarcellappearance.ui|4 svx/inc/helpid.hrc |1 svx/source/sidebar/area/AreaPropertyPanel.cxx| 126 --- svx/source/sidebar/area/AreaPropertyPanel.hrc|2 svx/source/sidebar/area/AreaPropertyPanel.hxx| 23 --- svx/source/sidebar/area/AreaPropertyPanel.src| 21 --- svx/source/tbxctrls/tbcontrl.cxx |4 svx/uiconfig/ui/sidebararea.ui |6 16 files changed, 14 insertions(+), 298 deletions(-) New commits: commit 3c3257e499ff48e89b58ce722364ca96738970b1 Author: Maxim Monastirsky momonas...@gmail.com Date: Mon Oct 27 13:57:38 2014 +0200 fdo#84844 Sidebar: Use SvxColorToolBoxControl for fill color Change-Id: I0aa9dbef960391334097b68c980064724435db38 diff --git a/icon-themes/tango/links.txt b/icon-themes/tango/links.txt index 4656c97..3bbd259 100644 --- a/icon-themes/tango/links.txt +++ b/icon-themes/tango/links.txt @@ -315,7 +315,6 @@ svx/res/symphony/rotate_left.png cmd/sc_rotateleft.png svx/res/symphony/rotate_right.png cmd/sc_rotateright.png svx/res/symphony/sc_backgroundcolor.png cmd/sc_formatarea.png svx/res/symphony/sch_backgroundcolor.png cmd/sc_formatarea.png -svx/res/symphony/fill_color.png cmd/sc_formatarea.png sw/res/sidebar/pageproppanel/last_custom_common.png svx/res/symphony/last_custom_common.png sw/res/sidebar/pageproppanel/last_custom_common_grey.png svx/res/symphony/last_custom_common_grey.png sc/imglst/na05.png cmd/sc_upsearch.png diff --git a/include/svx/dialogs.hrc b/include/svx/dialogs.hrc index 196a6eb..d3a74f0 100644 --- a/include/svx/dialogs.hrc +++ b/include/svx/dialogs.hrc @@ -206,7 +206,6 @@ #define RID_POPUPPANEL_TEXTPAGE_FONT_COLOR (RID_SVX_START + 316) #define RID_POPUPPANEL_TEXTPAGE_SPACING (RID_SVX_START + 317) -#define RID_POPUPPANEL_AERAPAGE_COLOR (RID_SVX_START + 319) #define RID_POPUPPANEL_AREAPAGE_TRGR(RID_SVX_START + 320) #define RID_SIDEBAR_LINE_PANEL (RID_SVX_START + 321) @@ -1043,9 +1042,8 @@ #define IMG_RADIAL (RID_SVX_SIDEBAR_BEGIN + 33) #define IMG_SQUARE (RID_SVX_SIDEBAR_BEGIN + 34) #define IMG_LINEAR (RID_SVX_SIDEBAR_BEGIN + 35) -#define IMG_AREA_COLOR (RID_SVX_SIDEBAR_BEGIN + 36) -#define IMG_ROT_LEFT (RID_SVX_SIDEBAR_BEGIN + 37) -#define IMG_ROT_RIGHT(RID_SVX_SIDEBAR_BEGIN + 38) +#define IMG_ROT_LEFT (RID_SVX_SIDEBAR_BEGIN + 36) +#define IMG_ROT_RIGHT(RID_SVX_SIDEBAR_BEGIN + 37) #define RID_SVX_SIDEBAR_END (RID_SVX_START + 1279) #define RID_SVXIMG_GREENCHECK(RID_SVX_START + 1280) diff --git a/svx/inc/helpid.hrc b/svx/inc/helpid.hrc index 75bed5e..02c098e 100644 --- a/svx/inc/helpid.hrc +++ b/svx/inc/helpid.hrc @@ -118,7 +118,6 @@ #define HID_PPROPERTYPANEL_LINE_VS_STYLE SVX_HID_PPROPERTYPANEL_LINE_VS_STYLE #define HID_PPROPERTYPANEL_LINE_BTN_STYLE SVX_HID_PPROPERTYPANEL_LINE_BTN_STYLE #define HID_PPROPERTYPANEL_TEXT_SPACING_VS SVX_HID_PPROPERTYPANEL_TEXT_SPACING_VS -#define HID_PPROPERTYPANEL_AREA_COLOR_VS SVX_HID_PPROPERTYPANEL_AREA_COLOR_VS #define HID_PPROPERTYPANEL_AREA_LB_FILL_TYPES SVX_HID_PPROPERTYPANEL_AREA_LB_FILL_TYPES #define HID_PPROPERTYPANEL_AREA_LB_FILL_ATTR SVX_HID_PPROPERTYPANEL_AREA_LB_FILL_ATTR diff --git a/svx/source/sidebar/area/AreaPropertyPanel.cxx b/svx/source/sidebar/area/AreaPropertyPanel.cxx index 9ab67b1..63467d2 100644 --- a/svx/source/sidebar/area/AreaPropertyPanel.cxx +++ b/svx/source/sidebar/area/AreaPropertyPanel.cxx @@ -38,7 +38,6 @@ #include svx/svxitems.hrc #include vcl/toolbox.hxx #include svtools/toolbarmenu.hxx -#include svx/sidebar/ColorControl.hxx #include boost/bind.hpp @@ -46,7 +45,6 @@ using namespace css; using namespace css::uno; using ::sfx2::sidebar::Theme; -const char UNO_SIDEBARCOLOR[]= .uno:sidebarcolor; const char UNO_SIDEBARGRADIENT[] = .uno:sidebargradient; namespace svx { namespace sidebar { @@ -65,7 +63,6 @@ AreaPropertyPanel::AreaPropertyPanel( SfxBindings* pBindings) : PanelLayout(pParent, AreaPropertyPanel, svx/ui/sidebararea.ui, rxFrame), meLastXFS(static_castsal_uInt16(-1)), - maLastColor(Color(COL_DEFAULT_SHAPE_FILLING)), mnLastPosGradient(0), mnLastPosHatch(0), mnLastPosBitmap(0), @@ -86,7
[Libreoffice-commits] dev-tools.git: ciabot/run-libreoffice-ciabot.pl
ciabot/run-libreoffice-ciabot.pl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7f19d99f5c1cc9a1982f32e6512c8f6715fed9cc Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Oct 27 13:31:47 2014 +0100 use the new git bugzilla script now diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl index c095b26..12be7f9 100755 --- a/ciabot/run-libreoffice-ciabot.pl +++ b/ciabot/run-libreoffice-ciabot.pl @@ -120,13 +120,13 @@ sub report($$$) { qx(perl -I $cwd $cwd/sigui-bugzilla.pl $repo $_ $branch_name); } else { if ( is_valid_bugzilla_commit( $repo, $branch_name ) ) { -qx(perl -I $cwd $cwd/libreoffice-bugzilla.pl $repo $_ $branch_name); +qx(python libreoffice-bugzilla2.py -r $repo -c $_ -b $branch_name); } qx($ciabot $repo $_ $branch_name $ciaproxy); } } else { if ( is_valid_bugzilla_commit( $repo, $branch_name ) ) { -print perl -I $cwd $cwd/libreoffice-bugzilla.pl '$repo' '$_' '$branch_name'\n; +print python libreoffice-bugzilla2.py -r '$repo' -c '$_' -b '$branch_name'\n; } print $ciabot '$repo' '$_' '$branch_name' $ciaproxy\n; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: ciabot/libreoffice-bugzilla2.py
ciabot/libreoffice-bugzilla2.py |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 768897fc4033b0600ca2bee899195bdd299412a4 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Oct 27 13:33:12 2014 +0100 write cookie and token into tmp directory This helps the server as it otherwise has some problems with our user configuration. diff --git a/ciabot/libreoffice-bugzilla2.py b/ciabot/libreoffice-bugzilla2.py index 7d2adeb..322ad82 100644 --- a/ciabot/libreoffice-bugzilla2.py +++ b/ciabot/libreoffice-bugzilla2.py @@ -47,7 +47,7 @@ class FreedesktopBZ: url = config.get('bugzilla', 'url') user = config.get('bugzilla', 'user') password = config.get('bugzilla', 'password') -self.bz = self.bzclass(url=url) +self.bz = self.bzclass(url=url, cookiefile = /tmp/cookie, tokenfile = /tmp/token) self.bz.login(user=user, password=password) def update_whiteboard(self, commit, bugnr, new_version, branch, repo_name): ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/droid_calcimpress3' - 3 commits - android/Bootstrap android/mobile-config.py framework/source
android/Bootstrap/Makefile.shared|4 +++- android/mobile-config.py |1 - framework/source/layoutmanager/layoutmanager.cxx |6 ++ 3 files changed, 9 insertions(+), 2 deletions(-) New commits: commit 2efc7da79eaddc53d91d87ed93a593e20d3a8623 Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 14:33:51 2014 +0200 The configuration pruning with mobile-config.py seems to work now Change-Id: I1b1891f0d7d7b8aa407e7da346ff5f8e3cbe8657 diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 3924dfe..984f368 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -138,7 +138,9 @@ copy-stuff: rm -Rf assets/share # pre-clean it mkdir -p assets/share/config cp -R $(INSTDIR)/share/registry assets/share -# $(SRC_ROOT)/android/mobile-config.py assets/share/registry/main.xcd assets/share/registry/main.xcd.new mv assets/share/registry/main.xcd.new assets/share/registry/main.xcd + for F in main.xcd res/registry_en-US.xcd; do \ + $(SRC_ROOT)/android/mobile-config.py assets/share/registry/$$F assets/share/registry/$$F.new mv assets/share/registry/$$F.new assets/share/registry/$$F; \ + done if ! test z$(DISABLE_UI) = zTRUE; then \ echo Copying UI files into the apk; \ cp -R $(INSTDIR)/share/config/soffice.cfg assets/share/config; \ commit bd08374a04aad60518390c0702397831f6572ce8 Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 14:10:18 2014 +0200 Don't prune org.openoffice.Office/UI It apparently contains color schemes and stuff that the code wants access to here and there. Change-Id: Ie3f0de5e3846df99a02a2693156679cc6c010d10 diff --git a/android/mobile-config.py b/android/mobile-config.py index cdf0afc..59ade79 100755 --- a/android/mobile-config.py +++ b/android/mobile-config.py @@ -24,7 +24,6 @@ main_xcd_discard = [ # no conventional UI; reverse sorted by size 'org.openoffice.Office.UI/GenericCommands', 'org.openoffice.Office/Accelerators', -'org.openoffice.Office/UI', 'org.openoffice.Office.UI/DrawImpressCommands', 'org.openoffice.Office.UI/Sidebar', 'org.openoffice.Office.UI/ChartCommands', commit 447fed3aebbc88a14506e02c8b7e6d29bd89ccbd Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 14:09:56 2014 +0200 Avoid automatic toolbars in the non-desktop case Change-Id: I9e5bff735b0035c147e10ae066da3a4873d66749 diff --git a/framework/source/layoutmanager/layoutmanager.cxx b/framework/source/layoutmanager/layoutmanager.cxx index eb58919..bd4eaf9 100644 --- a/framework/source/layoutmanager/layoutmanager.cxx +++ b/framework/source/layoutmanager/layoutmanager.cxx @@ -17,6 +17,8 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include config_features.h + #include services/layoutmanager.hxx #include helpers.hxx @@ -113,7 +115,11 @@ LayoutManager::LayoutManager( const Reference XComponentContext xContext ) : , m_bVisible( true ) , m_bParentWindowVisible( false ) , m_bMustDoLayout( true ) +#if HAVE_FEATURE_DESKTOP , m_bAutomaticToolbars( true ) +#else +, m_bAutomaticToolbars( false ) +#endif , m_bStoreWindowState( false ) , m_bHideCurrentUI( false ) , m_bGlobalSettings( false ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: ciabot/setup
ciabot/setup/install |1 + 1 file changed, 1 insertion(+) New commits: commit 6afccac502565eebb0edb984ab3e54ab69891955 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Oct 27 13:35:17 2014 +0100 install the new bugzilla script as well diff --git a/ciabot/setup/install b/ciabot/setup/install index 6044e40..8d8ab5f 100755 --- a/ciabot/setup/install +++ b/ciabot/setup/install @@ -18,6 +18,7 @@ prefix=/home/ciabot/prod for i in $origin/../../../irker-cia-proxy/irker-cia-proxy.py \ $origin/../libreoffice-bugzilla.pl \ +$origin/../libreoffice-bugzilla2.py \ $origin/../libreoffice-ciabot.pl \ $origin/../projmap.json \ $origin/../run-libreoffice-ciabot.pl \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source
sc/source/core/data/table3.cxx |7 +-- sc/source/ui/undo/undosort.cxx |3 +-- 2 files changed, 6 insertions(+), 4 deletions(-) New commits: commit 81e4dbe1adf196ee20f1a4bfbc50b54abfc79f4b Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Sun Oct 26 14:43:14 2014 -0700 fdo#85215: Don't adjust references wrt cell position when disabled. Change-Id: Ie1a12cc189bcb66fad59ea9901ac0dc95bb68788 (cherry picked from commit 10fc138307afb4b39baddb0d56eb8e986e5d29ea) Reviewed-on: https://gerrit.libreoffice.org/12106 Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index ce17bb9..05285d8 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -856,8 +856,11 @@ void ScTable::SortReorderByRow( ScAddress aOldPos = rCell.maCell.mpFormula-aPos; ScFormulaCell* pNew = rCell.maCell.mpFormula-Clone( aCellPos, SC_CLONECELL_DEFAULT); -pNew-CopyAllBroadcasters(*rCell.maCell.mpFormula); -pNew-GetCode()-AdjustReferenceOnMovedOrigin(aOldPos, aCellPos); +if (pArray-IsUpdateRefs()) +{ +pNew-CopyAllBroadcasters(*rCell.maCell.mpFormula); +pNew-GetCode()-AdjustReferenceOnMovedOrigin(aOldPos, aCellPos); +} sc::CellStoreType::iterator itBlk = rCellStore.push_back(pNew); } diff --git a/sc/source/ui/undo/undosort.cxx b/sc/source/ui/undo/undosort.cxx index 36156fe..4a00707 100644 --- a/sc/source/ui/undo/undosort.cxx +++ b/sc/source/ui/undo/undosort.cxx @@ -46,8 +46,7 @@ void UndoSort::Execute( bool bUndo ) ScUndoUtil::MarkSimpleBlock(pDocShell, maParam.maSortRange); -pDocShell-PostPaint(maParam.maSortRange, PAINT_GRID); -pDocShell-PostDataChanged(); +rDoc.SetDirty(maParam.maSortRange); if (!aParam.mbUpdateRefs) rDoc.BroadcastCells(aParam.maSortRange, SC_HINT_DATACHANGED); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] dev-tools.git: ciabot/run-libreoffice-ciabot.pl
ciabot/run-libreoffice-ciabot.pl |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ec5c232195db7a3f931af15a06198668745a3d5b Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Oct 27 13:45:17 2014 +0100 fix script invocation diff --git a/ciabot/run-libreoffice-ciabot.pl b/ciabot/run-libreoffice-ciabot.pl index 12be7f9..80551a0 100755 --- a/ciabot/run-libreoffice-ciabot.pl +++ b/ciabot/run-libreoffice-ciabot.pl @@ -120,13 +120,13 @@ sub report($$$) { qx(perl -I $cwd $cwd/sigui-bugzilla.pl $repo $_ $branch_name); } else { if ( is_valid_bugzilla_commit( $repo, $branch_name ) ) { -qx(python libreoffice-bugzilla2.py -r $repo -c $_ -b $branch_name); +qx(python $cwd/libreoffice-bugzilla2.py -r $repo -c $_ -b $branch_name); } qx($ciabot $repo $_ $branch_name $ciaproxy); } } else { if ( is_valid_bugzilla_commit( $repo, $branch_name ) ) { -print python libreoffice-bugzilla2.py -r '$repo' -c '$_' -b '$branch_name'\n; +print python $cwd/libreoffice-bugzilla2.py -r '$repo' -c '$_' -b '$branch_name'\n; } print $ciabot '$repo' '$_' '$branch_name' $ciaproxy\n; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - svtools/source
svtools/source/graphic/grfmgr.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e4bb46d5d6c60428561e855b8024eb75368cf6bb Author: Zolnai Tamás tamas.zol...@collabora.com Date: Mon Oct 27 13:16:06 2014 +0100 Call assign graphic data only when graphic actually changed Change-Id: I2ac81667a587a20917dc1bd613a51f0310f1250c diff --git a/svtools/source/graphic/grfmgr.cxx b/svtools/source/graphic/grfmgr.cxx index 68c19ab..098e1f6 100644 --- a/svtools/source/graphic/grfmgr.cxx +++ b/svtools/source/graphic/grfmgr.cxx @@ -265,8 +265,8 @@ void GraphicObject::ImplAutoSwapIn() if( !mbAutoSwapped mpMgr ) mpMgr-ImplGraphicObjectWasSwappedIn( *this ); } +ImplAssignGraphicData(); } -ImplAssignGraphicData(); } bool GraphicObject::ImplGetCropParams( OutputDevice* pOut, Point rPt, Size rSz, const GraphicAttr* pAttr, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
new git bugzilla script
Hey, so I finally implemented a new git bugzilla script that should bring back the commit notifications in bugzilla for fixed bugs. As it is a complete new implementation you should report any problems as soon as possible. Especially in the beta and the RC phase. I used the old script as a guideline but there are some special portions in it that can only be tested between the first beta and the last RC. Otherwise the script provides nearly the same features as the old script plus it will now handle several bug references in the commit line correctly. So now fdo#12345 fdo#23456 will be handled correctly and both bugs will be updated. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
call about new testing hardware
Hey, so based on the doodle poll everyone who wants to join has time Tuesday at 14:00 UTC. Everyone who is interested in discussing how we can use our testing hardware is invited to join the call. Some of the topics are: * fuzzing * crash testing * performance testing * which hardware? * administration * other ideas I suppose we will use the same room as for the public ESC call so if you want to join have a look at the last ESC invite to find the number and the room details. Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 3 commits - sc/source sw/source
sc/source/core/data/attrib.cxx | 10 +++ sc/source/core/tool/defaultsoptions.cxx |2 - sc/source/core/tool/docoptio.cxx |2 - sc/source/core/tool/formulaopt.cxx |2 - sc/source/core/tool/printopt.cxx |2 - sc/source/core/tool/viewopti.cxx |2 - sc/source/ui/app/uiitems.cxx | 18 +++--- sw/source/core/attr/cellatr.cxx |6 ++-- sw/source/core/attr/fmtwrapinfluenceonobjpos.cxx |6 ++-- sw/source/core/layout/atrfrm.cxx | 28 +++--- sw/source/core/para/paratr.cxx |4 +-- sw/source/core/tox/tox.cxx |2 - sw/source/core/txtnode/atrfld.cxx|2 - sw/source/core/txtnode/atrflyin.cxx |2 - sw/source/core/txtnode/atrftn.cxx|2 - sw/source/core/txtnode/atrref.cxx|2 - sw/source/core/txtnode/fmtatr2.cxx | 10 +++ sw/source/core/txtnode/thints.cxx| 29 +++ sw/source/uibase/chrdlg/ccoll.cxx|2 - sw/source/uibase/config/cfgitems.cxx |8 +++--- sw/source/uibase/utlui/uiitems.cxx |6 ++-- 21 files changed, 73 insertions(+), 74 deletions(-) New commits: commit 8f7e364a5b6179fdc3b716a3b250e71341536220 Author: Michael Stahl mst...@redhat.com Date: Mon Oct 27 13:55:21 2014 +0100 sw: deploy some asserts in SwpHints::TryInsertNesting() Change-Id: I584edadf13b34edf054e3405865c43bae74a7830 diff --git a/sw/source/core/txtnode/thints.cxx b/sw/source/core/txtnode/thints.cxx index a38fae5..c29f87e 100644 --- a/sw/source/core/txtnode/thints.cxx +++ b/sw/source/core/txtnode/thints.cxx @@ -164,8 +164,8 @@ bool isSelfNestable(const sal_uInt16 nWhich) (RES_TXTATR_CJK_RUBY == nWhich) || (RES_TXTATR_INPUTFIELD == nWhich)) return false; - OSL_ENSURE((RES_TXTATR_META == nWhich) || - (RES_TXTATR_METAFIELD == nWhich), ???); +assert((RES_TXTATR_META == nWhich) || + (RES_TXTATR_METAFIELD == nWhich)); return true; } @@ -175,9 +175,9 @@ bool isSplittable(const sal_uInt16 nWhich) if ((RES_TXTATR_INETFMT == nWhich) || (RES_TXTATR_CJK_RUBY == nWhich)) return true; -OSL_ENSURE((RES_TXTATR_META == nWhich) || +assert((RES_TXTATR_META == nWhich) || (RES_TXTATR_METAFIELD == nWhich) || - (RES_TXTATR_INPUTFIELD == nWhich), ???); + (RES_TXTATR_INPUTFIELD == nWhich)); return false; } @@ -246,7 +246,7 @@ MakeTxtAttrNesting(SwTxtNode rNode, SwTxtAttrNesting rNesting, break; } default: -OSL_FAIL(MakeTxtAttrNesting: what the hell is that?); +assert(!MakeTxtAttrNesting: what the hell is that?); break; } return static_txtattr_castSwTxtAttrNesting*(pNew); @@ -362,12 +362,11 @@ SwpHints::TryInsertNesting( SwTxtNode rNode, SwTxtAttrNesting rNewHint ) const sal_Int32 nNewEnd ( *rNewHint.GetEnd() ); const bool bNewSelfNestable( isSelfNestable(nNewWhich) ); -OSL_ENSURE( (RES_TXTATR_INETFMT == nNewWhich) || +assert( (RES_TXTATR_INETFMT == nNewWhich) || (RES_TXTATR_CJK_RUBY == nNewWhich) || (RES_TXTATR_META == nNewWhich) || (RES_TXTATR_METAFIELD == nNewWhich) || -(RES_TXTATR_INPUTFIELD == nNewWhich), -TryInsertNesting: Expecting INETFMT or RUBY or META or METAFIELD or INPUTFIELD ); +(RES_TXTATR_INPUTFIELD == nNewWhich)); NestList_t OverlappingExisting; // existing hints to be split NestList_t OverwrittenExisting; // existing hints to be replaced @@ -403,7 +402,7 @@ SwpHints::TryInsertNesting( SwTxtNode rNode, SwTxtAttrNesting rNewHint ) static_txtattr_castSwTxtAttrNesting*(pOther)); break; default: -OSL_FAIL(bad code monkey); +assert(!bad code monkey); break; } } @@ -419,7 +418,7 @@ SwpHints::TryInsertNesting( SwTxtNode rNode, SwTxtAttrNesting rNewHint ) { if (rNewHint.HasDummyChar()) { -OSL_FAIL(ERROR: inserting duplicate CH_TXTATR hint); +assert(!ERROR: inserting duplicate CH_TXTATR hint); return false; } else if (nNewEnd nOtherEnd) { // other has dummy char, new is inside other, but @@ -428,7 +427,7 @@ SwpHints::TryInsertNesting( SwTxtNode rNode, SwTxtAttrNesting rNewHint ) // in SwXMeta::createEnumeration // SplitNew is sorted, so this is the first split
[Libreoffice-commits] core.git: Branch 'feature/droid_calcimpress3' - 2 commits - android/Bootstrap android/mobile-config.py
android/Bootstrap/Makefile.shared |6 +++--- android/mobile-config.py |1 - 2 files changed, 3 insertions(+), 4 deletions(-) New commits: commit 7a68c61f0f798dafa92c03a0ab053f695eb9ff3d Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 15:17:03 2014 +0200 We seem to crash unless we have org.openoffice.Office.UI/Factories Change-Id: Ie172f60a7134173462ff9711a40dc74c94ad8206 diff --git a/android/mobile-config.py b/android/mobile-config.py index 59ade79..8b1f44e 100755 --- a/android/mobile-config.py +++ b/android/mobile-config.py @@ -33,7 +33,6 @@ main_xcd_discard = [ 'org.openoffice.Office.UI/BasicIDEWindowState', 'org.openoffice.Office.UI/GenericCategories', 'org.openoffice.Office.UI/ChartWindowState', -'org.openoffice.Office.UI/Factories', 'org.openoffice.Office.UI/BaseWindowState', 'org.openoffice.Office.UI/BasicIDECommands', 'org.openoffice.Office.UI/BibliographyCommands', commit 8de4c5d4ea157ef92631582ea5e5a2ec212d38ac Author: Tor Lillqvist t...@collabora.com Date: Mon Oct 27 15:16:33 2014 +0200 Do the configuration pruning only in the DISABLE_UI case Change-Id: If85c6a86434c0aa32d188a0f128f6b6cd613bbb5 diff --git a/android/Bootstrap/Makefile.shared b/android/Bootstrap/Makefile.shared index 984f368..8389241 100644 --- a/android/Bootstrap/Makefile.shared +++ b/android/Bootstrap/Makefile.shared @@ -138,14 +138,14 @@ copy-stuff: rm -Rf assets/share # pre-clean it mkdir -p assets/share/config cp -R $(INSTDIR)/share/registry assets/share - for F in main.xcd res/registry_en-US.xcd; do \ - $(SRC_ROOT)/android/mobile-config.py assets/share/registry/$$F assets/share/registry/$$F.new mv assets/share/registry/$$F.new assets/share/registry/$$F; \ - done if ! test z$(DISABLE_UI) = zTRUE; then \ echo Copying UI files into the apk; \ cp -R $(INSTDIR)/share/config/soffice.cfg assets/share/config; \ else \ echo Skipping UI files; \ + for F in main.xcd res/registry_en-US.xcd; do \ + $(SRC_ROOT)/android/mobile-config.py assets/share/registry/$$F assets/share/registry/$$F.new mv assets/share/registry/$$F.new assets/share/registry/$$F; \ + done; \ fi mkdir -p assets/unpack/program ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - include/vcl svx/source tools/source vcl/source
include/vcl/svapp.hxx |2 +- svx/source/engine3d/float3d.cxx |2 +- tools/source/generic/poly.cxx |2 +- vcl/source/app/svapp.cxx|8 +++- 4 files changed, 6 insertions(+), 8 deletions(-) New commits: commit 2d2bb23a3bd860c4baa2dcfe4d1bbe1dea64b9a2 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 13:21:00 2014 +0200 cid#735507 Logically dead code Change-Id: Ie251bca3e4fa7c67aa84c8ff3ae451b0aaa57f44 diff --git a/svx/source/engine3d/float3d.cxx b/svx/source/engine3d/float3d.cxx index 6030a40..742f1f0 100644 --- a/svx/source/engine3d/float3d.cxx +++ b/svx/source/engine3d/float3d.cxx @@ -2111,7 +2111,7 @@ void Svx3DWin::GetAttr( SfxItemSet rAttrs ) // Textures // Art -nValue = 3; +nValue = 99; if( aBtnTexLuminance.IsChecked() ) nValue = 1; else if( aBtnTexColor.IsChecked() ) commit 627a9982f25b22520537592e9c7a566e0d9c950a Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 12:30:28 2014 +0200 cid#705053 Dereference after null check re-arrange the code to help coverity out Change-Id: Iddc9284cbdcbaae7a0dc17e62d0e8f4b4832297c diff --git a/include/vcl/svapp.hxx b/include/vcl/svapp.hxx index 68dd3c7..7f9dc50 100644 --- a/include/vcl/svapp.hxx +++ b/include/vcl/svapp.hxx @@ -1546,7 +1546,7 @@ public: private: -static void InitSettings(); +static void InitSettings(ImplSVData* pSVData); DECL_STATIC_LINK( Application, PostEventHandler, void* ); }; diff --git a/vcl/source/app/svapp.cxx b/vcl/source/app/svapp.cxx index fd0077e..0355ec0 100644 --- a/vcl/source/app/svapp.cxx +++ b/vcl/source/app/svapp.cxx @@ -517,7 +517,7 @@ void Application::SetSettings( const AllSettings rSettings ) ImplSVData* pSVData = ImplGetSVData(); if ( !pSVData-maAppData.mpSettings ) { -InitSettings(); +InitSettings(pSVData); *pSVData-maAppData.mpSettings = rSettings; ResMgr::SetDefaultLocale( rSettings.GetUILanguageTag() ); } @@ -616,16 +616,14 @@ const AllSettings Application::GetSettings() ImplSVData* pSVData = ImplGetSVData(); if ( !pSVData-maAppData.mpSettings ) { -InitSettings(); +InitSettings(pSVData); } return *(pSVData-maAppData.mpSettings); } -void Application::InitSettings() +void Application::InitSettings(ImplSVData* pSVData) { -ImplSVData* pSVData = ImplGetSVData(); - assert(!pSVData-maAppData.mpSettings initialization should not happen twice!); pSVData-maAppData.mpCfgListener = new LocaleConfigurationListener; commit 91fac2a32c1c6b784bd33cf664ea64a734b1c776 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 11:59:36 2014 +0200 cid#705051 Dereference after null check Change-Id: I6b7adb593efa137bb09b3b8d49539f6cd405dd20 diff --git a/tools/source/generic/poly.cxx b/tools/source/generic/poly.cxx index a588719..56b224b 100644 --- a/tools/source/generic/poly.cxx +++ b/tools/source/generic/poly.cxx @@ -606,7 +606,7 @@ void Polygon::SetFlags( sal_uInt16 nPos, PolyFlags eFlags ) // we do only want to create the flag array if there // is at least one flag different to POLY_NORMAL -if ( mpImplPolygon || ( eFlags != POLY_NORMAL ) ) +if ( eFlags != POLY_NORMAL ) { ImplMakeUnique(); mpImplPolygon-ImplCreateFlagArray(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - editeng/source sw/source vcl/generic
editeng/source/editeng/impedit2.cxx |2 -- sw/source/uibase/docvw/edtwin.cxx |2 +- vcl/generic/glyphs/gcach_ftyp.cxx |8 3 files changed, 1 insertion(+), 11 deletions(-) New commits: commit 393032d98be09be43e66604a11269da88958f297 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 15:52:54 2014 +0200 cid#1247616 Logically dead code Change-Id: I2577bf1d61c24f78070de409c285c8e36dddb3d6 diff --git a/sw/source/uibase/docvw/edtwin.cxx b/sw/source/uibase/docvw/edtwin.cxx index ed57dc3..38e4232 100644 --- a/sw/source/uibase/docvw/edtwin.cxx +++ b/sw/source/uibase/docvw/edtwin.cxx @@ -3898,7 +3898,7 @@ void SwEditWin::MouseMove(const MouseEvent _rMEvt) case SwTab::COLSEL_VERT : nPointer = POINTER_TAB_SELECT_W; break; -case SwTab::COL_NONE: break; // prevent compiler warning +default: break; // prevent compiler warning } if ( USHRT_MAX != nPointer commit 96725576e59b25f2d24c431b6e67ccf4c67a1e57 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 15:50:43 2014 +0200 cid#1209201 Logically dead code Change-Id: I8a7a9e23ad33f0c62813ae4ebd84cece3fe75283 diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index 3b56fdb..9a46f58 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -3103,8 +3103,6 @@ sal_uInt32 ImpEditEngine::CalcTextWidth( bool bIgnoreExtraSpace ) } } } -if ( nMaxWidth 0 ) -nMaxWidth = 0; nMaxWidth++; // widen it, because in CreateLines for = is wrapped. return (sal_uInt32)nMaxWidth; commit b89121208c0667e31f873fd22bb2285b9e073b79 Author: Noel Grandin n...@peralex.com Date: Mon Oct 27 15:43:51 2014 +0200 cid#735557 Logically dead code Change-Id: I0f6851a4ce5c02ea48110bdb8ed47cdb15853917 diff --git a/vcl/generic/glyphs/gcach_ftyp.cxx b/vcl/generic/glyphs/gcach_ftyp.cxx index 9e12d5a..6b1ce3e 100644 --- a/vcl/generic/glyphs/gcach_ftyp.cxx +++ b/vcl/generic/glyphs/gcach_ftyp.cxx @@ -1605,8 +1605,6 @@ bool ServerFont::ApplyGSUB( const FontSelectPattern rFSD ) ReqFeatureTagList aReqFeatureTagList; if( rFSD.mbVertical ) aReqFeatureTagList.push_back( MKTAG(vert) ); -sal_uLong nRequestedScript = 0; //MKTAG(hani);//### TODO: where to get script? -sal_uLong nRequestedLangsys = 0;//MKTAG(ZHT); //### TODO: where to get langsys? // TODO: request more features depending on script and language system if( aReqFeatureTagList.empty()) // nothing to do @@ -1634,11 +1632,8 @@ bool ServerFont::ApplyGSUB( const FontSelectPattern rFSD ) pScriptHeader += 2; for( sal_uInt16 nScriptIndex = 0; nScriptIndex nCntScript; ++nScriptIndex ) { -const sal_uLong nScriptTag = GetUInt( pScriptHeader+0 ); // e.g. hani/arab/kana/hang const sal_uInt16 nOfsScriptTable= GetUShort( pScriptHeader+4 ); pScriptHeader += 6; -if( (nScriptTag != nRequestedScript) (nRequestedScript != 0) ) -continue; const FT_Byte* pScriptTable = pGsubBase + nOfsScriptList + nOfsScriptTable; const sal_uInt16 nDefaultLangsysOfs = GetUShort( pScriptTable+0 ); @@ -1648,11 +1643,8 @@ bool ServerFont::ApplyGSUB( const FontSelectPattern rFSD ) for( sal_uInt16 nLangsysIndex = 0; nLangsysIndex nCntLangSystem; ++nLangsysIndex ) { -const sal_uLong nTag= GetUInt( pScriptTable+0 );// e.g. KOR/ZHS/ZHT/JAN const sal_uInt16 nOffset= GetUShort( pScriptTable+4 ); pScriptTable += 6; -if( (nTag != nRequestedLangsys) (nRequestedLangsys != 0) ) -continue; nLangsysOffset = nOffset; break; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: jurt/com
jurt/com/sun/star/lib/util/UrlToFileMapper.java |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit d0a8fc24b351517ff4255e93fb1c8a78391facf7 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Oct 27 15:09:02 2014 +0100 Fix indentation Change-Id: Ic058759782f95e330d8c581911aeb163340a7c4b diff --git a/jurt/com/sun/star/lib/util/UrlToFileMapper.java b/jurt/com/sun/star/lib/util/UrlToFileMapper.java index 3380992..87b27c6 100644 --- a/jurt/com/sun/star/lib/util/UrlToFileMapper.java +++ b/jurt/com/sun/star/lib/util/UrlToFileMapper.java @@ -82,10 +82,10 @@ public final class UrlToFileMapper { } catch (UnsupportedEncodingException e) { throw new RuntimeException(e); // should never happen } - } - } +} +} return buf.toString(); - } +} - private UrlToFileMapper() {} +private UrlToFileMapper() {} } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: call about new testing hardware
Hi, Markus Mohrhard wrote on 2014-10-27 at 14:10: so based on the doodle poll everyone who wants to join has time Tuesday at 14:00 UTC. Everyone who is interested in discussing how we can use our testing hardware is invited to join the call. thanks for organizing this! So, this means 1500 local German time. I'd like to have Alex in as well when he's around, being the master of our infra. :-) I suppose we will use the same room as for the public ESC call so if you want to join have a look at the last ESC invite to find the number and the room details. Sounds good! Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
copying version from Help About
Hello, All, I am in the habit of copying version information for LibreOffice on Windows from the Help About dialog. Today with the build (beware: I am typing this rather than pasting it grin /): Build ID: c967872d... TinderBox: Win-x86@42, Branch:master, Time: 2014-10-13_00:02:37 Ctrl+A in the dialog does not highlight the version information and Ctrl+C does not copy it. Is this a bug? In LibreOffice rather than something on the tinderbox machine? How can I tell? Thanks, Terry. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 10 commits - connectivity/source cppu/source desktop/source extensions/source forms/source offapi/com package/inc package/source sw/source vcl/headless vcl/unx
connectivity/source/drivers/jdbc/Object.cxx |9 ++--- connectivity/source/parse/sqlnode.cxx |1 + cppu/source/uno/sequence.cxx |2 ++ desktop/source/deployment/registry/package/dp_package.cxx |2 +- extensions/source/plugin/unx/npwrap.cxx |4 ++-- forms/source/component/DatabaseForm.cxx |7 +-- offapi/com/sun/star/packages/zip/XZipFileAccess.idl |1 + package/inc/zipfileaccess.hxx |2 +- package/source/zippackage/zipfileaccess.cxx |2 +- sw/source/filter/ww8/ww8par.cxx |2 +- vcl/headless/svpinst.cxx |8 vcl/unx/generic/app/saldata.cxx |4 ++-- 12 files changed, 27 insertions(+), 17 deletions(-) New commits: commit 1d200aa17096aceca5fe7d3d1d8e4b939e5cb3fd Author: Caolán McNamara caol...@redhat.com Date: Mon Oct 27 13:44:55 2014 + coverity#706590 Uncaught exception Change-Id: I2005b792c74ad5a5f58c831dcc7caa5134280890 diff --git a/offapi/com/sun/star/packages/zip/XZipFileAccess.idl b/offapi/com/sun/star/packages/zip/XZipFileAccess.idl index 58e7842..af3ac00 100644 --- a/offapi/com/sun/star/packages/zip/XZipFileAccess.idl +++ b/offapi/com/sun/star/packages/zip/XZipFileAccess.idl @@ -45,6 +45,7 @@ interface XZipFileAccess: ::com::sun::star::uno::XInterface ::com::sun::star::io::XInputStream getStreamByPattern( [in] string aPattern ) raises( ::com::sun::star::container::NoSuchElementException, ::com::sun::star::io::IOException, +::com::sun::star::packages::WrongPasswordException, ::com::sun::star::packages::zip::ZipException ); }; diff --git a/package/inc/zipfileaccess.hxx b/package/inc/zipfileaccess.hxx index 6d3b2d9..33d3f33 100644 --- a/package/inc/zipfileaccess.hxx +++ b/package/inc/zipfileaccess.hxx @@ -82,7 +82,7 @@ public: virtual sal_Bool SAL_CALL hasElements( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; // XZipFileAccess -virtual ::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream SAL_CALL getStreamByPattern( const OUString aPattern ) throw (::com::sun::star::container::NoSuchElementException, ::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException, css::packages::zip::ZipException, std::exception) SAL_OVERRIDE; +virtual ::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream SAL_CALL getStreamByPattern( const OUString aPattern ) throw (::com::sun::star::container::NoSuchElementException, ::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException, css::packages::WrongPasswordException, css::packages::zip::ZipException, std::exception) SAL_OVERRIDE; // XComponent virtual void SAL_CALL dispose( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/package/source/zippackage/zipfileaccess.cxx b/package/source/zippackage/zipfileaccess.cxx index 0efa97d..ccd0746 100644 --- a/package/source/zippackage/zipfileaccess.cxx +++ b/package/source/zippackage/zipfileaccess.cxx @@ -358,7 +358,7 @@ sal_Bool SAL_CALL OZipFileAccess::hasElements() // XZipFileAccess uno::Reference io::XInputStream SAL_CALL OZipFileAccess::getStreamByPattern( const OUString aPatternString ) throw ( container::NoSuchElementException, -io::IOException, packages::zip::ZipException, +io::IOException, packages::WrongPasswordException, packages::zip::ZipException, uno::RuntimeException, std::exception ) { ::osl::MutexGuard aGuard( m_aMutexHolder-GetMutex() ); commit 0095bccdf5e31de6ec6d1a3d83cc31efc8c1daae Author: Caolán McNamara caol...@redhat.com Date: Mon Oct 27 13:41:00 2014 + coverity#706321 Uncaught exception Change-Id: Ie3b66520ab0c859272a4b0291f6c907e7fce61e5 diff --git a/connectivity/source/drivers/jdbc/Object.cxx b/connectivity/source/drivers/jdbc/Object.cxx index 24058cf..5c02098 100644 --- a/connectivity/source/drivers/jdbc/Object.cxx +++ b/connectivity/source/drivers/jdbc/Object.cxx @@ -219,10 +219,13 @@ void java_lang_Object::ThrowSQLException( JNIEnv* _pEnvironment, const Reference void java_lang_Object::ThrowRuntimeException( JNIEnv* _pEnvironment, const Reference XInterface _rxContext ) { -SQLException aException; -if ( lcl_translateJNIExceptionToUNOException( _pEnvironment, _rxContext, aException ) ) +try +{ +ThrowSQLException(_pEnvironment, _rxContext); +} +catch (const SQLException e) { -throw WrappedTargetRuntimeException(aException.Message, aException.Context, makeAny(aException)); +throw WrappedTargetRuntimeException(e.Message, e.Context, makeAny(e)); } } commit 8fbbb94a3914223de1f690090e86a1ec9fbdaa30 Author:
[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source
sc/qa/unit/ucalc.hxx |4 sc/qa/unit/ucalc_formula.cxx | 226 ++ sc/source/core/tool/token.cxx | 67 +++- 3 files changed, 291 insertions(+), 6 deletions(-) New commits: commit 0dc61dab04507cb4b3698a1fa1ed696a123b9219 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Oct 27 07:33:38 2014 -0700 fdo#85282: Write test for this. Change-Id: I2a0567c2872b503ceb3740127b6b58b1d1789690 diff --git a/sc/qa/unit/ucalc.hxx b/sc/qa/unit/ucalc.hxx index 9eaa709..0e58c18 100644 --- a/sc/qa/unit/ucalc.hxx +++ b/sc/qa/unit/ucalc.hxx @@ -133,6 +133,8 @@ public: void testFormulaRefUpdateMoveUndo(); void testFormulaRefUpdateMoveToSheet(); void testFormulaRefUpdateDeleteContent(); +void testFormulaRefUpdateDeleteAndShiftLeft(); +void testFormulaRefUpdateDeleteAndShiftUp(); void testFormulaRefUpdateName(); void testFormulaRefUpdateNameMove(); void testFormulaRefUpdateNameExpandRef(); @@ -427,6 +429,8 @@ public: CPPUNIT_TEST(testFormulaRefUpdateMoveUndo); CPPUNIT_TEST(testFormulaRefUpdateMoveToSheet); CPPUNIT_TEST(testFormulaRefUpdateDeleteContent); +CPPUNIT_TEST(testFormulaRefUpdateDeleteAndShiftLeft); +CPPUNIT_TEST(testFormulaRefUpdateDeleteAndShiftUp); CPPUNIT_TEST(testFormulaRefUpdateName); CPPUNIT_TEST(testFormulaRefUpdateNameMove); CPPUNIT_TEST(testFormulaRefUpdateNameExpandRef); diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx index 5e0018a..f96c07b 100644 --- a/sc/qa/unit/ucalc_formula.cxx +++ b/sc/qa/unit/ucalc_formula.cxx @@ -1944,6 +1944,232 @@ void Test::testFormulaRefUpdateDeleteContent() m_pDoc-DeleteTab(0); } +void Test::testFormulaRefUpdateDeleteAndShiftLeft() +{ +sc::AutoCalcSwitch aACSwitch(*m_pDoc, true); // turn auto calc on. + +m_pDoc-InsertTab(0, Test); + +// Insert 1,2,3,4,5 in C1:G1. +for (SCCOL i = 0; i = 4; ++i) +m_pDoc-SetValue(ScAddress(i+2,0,0), i+1); + +// Insert formula in H1. +ScAddress aPos(7,0,0); +m_pDoc-SetString(aPos, =SUM(C1:G1)); + +CPPUNIT_ASSERT_EQUAL(15.0, m_pDoc-GetValue(aPos)); + +// Delete columns D:E (middle of the reference). +ScMarkData aMark; +aMark.SelectOneTable(0); +ScDocFunc rFunc = getDocShell().GetDocFunc(); +bool bDeleted = rFunc.DeleteCells(ScRange(3,0,0,4,MAXROW,0), aMark, DEL_CELLSLEFT, true, true); +CPPUNIT_ASSERT(bDeleted); + +aPos.IncCol(-2); +CPPUNIT_ASSERT_EQUAL(10.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:E1))) +CPPUNIT_FAIL(Wrong formula!); + +// Undo and check. +SfxUndoManager* pUndo = m_pDoc-GetUndoManager(); +CPPUNIT_ASSERT(pUndo); + +pUndo-Undo(); +aPos.IncCol(2); +CPPUNIT_ASSERT_EQUAL(15.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:G1))) +CPPUNIT_FAIL(Wrong formula!); + +// Delete columns C:D (left end of the reference). +bDeleted = rFunc.DeleteCells(ScRange(2,0,0,3,MAXROW,0), aMark, DEL_CELLSLEFT, true, true); +CPPUNIT_ASSERT(bDeleted); + +aPos.IncCol(-2); +CPPUNIT_ASSERT_EQUAL(12.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:E1))) +CPPUNIT_FAIL(Wrong formula!); + +// Undo and check again. +pUndo-Undo(); +aPos.IncCol(2); +CPPUNIT_ASSERT_EQUAL(15.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:G1))) +CPPUNIT_FAIL(Wrong formula!); + +// Delete columns B:E (overlaps on the left). +bDeleted = rFunc.DeleteCells(ScRange(1,0,0,4,MAXROW,0), aMark, DEL_CELLSLEFT, true, true); +CPPUNIT_ASSERT(bDeleted); + +aPos.IncCol(-4); +CPPUNIT_ASSERT_EQUAL(9.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(B1:C1))) +CPPUNIT_FAIL(Wrong formula!); + +// Undo and check again. +pUndo-Undo(); +aPos.IncCol(4); +CPPUNIT_ASSERT_EQUAL(15.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:G1))) +CPPUNIT_FAIL(Wrong formula!); + +// Start over with a new scenario. +clearSheet(m_pDoc, 0); + +// Insert 1,2,3,4,5,6 into C1:H1. +for (SCCOL i = 0; i = 5; ++i) +m_pDoc-SetValue(ScAddress(i+2,0,0), i+1); + +// Set formula in B1. +aPos = ScAddress(1,0,0); +m_pDoc-SetString(aPos, =SUM(C1:H1)); +CPPUNIT_ASSERT_EQUAL(21.0, m_pDoc-GetValue(aPos)); + +// Delete columns F:H (right end of the reference). +bDeleted = rFunc.DeleteCells(ScRange(5,0,0,7,MAXROW,0), aMark, DEL_CELLSLEFT, true, true); +CPPUNIT_ASSERT(bDeleted); + +CPPUNIT_ASSERT_EQUAL(6.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:E1))) +CPPUNIT_FAIL(Wrong formula!); + +// Undo and check. +pUndo-Undo(); +CPPUNIT_ASSERT_EQUAL(21.0, m_pDoc-GetValue(aPos)); +if (!checkFormula(*m_pDoc, aPos, SUM(C1:H1))) +CPPUNIT_FAIL(Wrong formula!); + +// Delete columns G:I (overlaps on the
[Libreoffice-commits] core.git: sw/source
sw/source/filter/basflt/iodetect.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2128f3c969ff6103511b7d485b9cbb2647427342 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Oct 27 15:40:13 2014 +0100 SwIoSystem::GetFileFilter: prevent out of bounds string access Change-Id: I0f2ebc9cbad16534b50083cc6d13ee042c2ff869 diff --git a/sw/source/filter/basflt/iodetect.cxx b/sw/source/filter/basflt/iodetect.cxx index 9fdfe13..64da606 100644 --- a/sw/source/filter/basflt/iodetect.cxx +++ b/sw/source/filter/basflt/iodetect.cxx @@ -171,7 +171,7 @@ const SfxFilter* SwIoSystem::GetFileFilter(const OUString rFileName) { while ( pFilter ) { -if( 'C' == pFilter-GetUserData()[0] IsValidStgFilter( xStor, *pFilter ) ) +if( !pFilter-GetUserData().isEmpty() 'C' == pFilter-GetUserData()[0] IsValidStgFilter( xStor, *pFilter ) ) { if (pFilter-IsOwnTemplateFormat()) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - svtools/source
svtools/source/graphic/grfmgr2.cxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit e3d9dc5be1b591bedbf123bf71ec8f62d7c232b0 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Mon Oct 27 15:55:38 2014 +0100 Ignore the swapped in graphic, but use its size Change-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab diff --git a/svtools/source/graphic/grfmgr2.cxx b/svtools/source/graphic/grfmgr2.cxx index c97a043..427c312 100644 --- a/svtools/source/graphic/grfmgr2.cxx +++ b/svtools/source/graphic/grfmgr2.cxx @@ -205,12 +205,15 @@ void GraphicManager::ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGrap for (size_t i = 0, n = maObjList.size(); i n; ++i) { pObj = maObjList[i]; -if (pObj-meType == GRAPHIC_BITMAP !pObj-IsSwappedOut() pObj-GetSizeBytes() pObj != pGraphicToIgnore) +if (pObj-meType == GRAPHIC_BITMAP !pObj-IsSwappedOut() pObj-GetSizeBytes()) { -aCandidates.push_back(pObj); +if( pObj != pGraphicToIgnore ) +{ +aCandidates.push_back(pObj); +sizes.insert(std::make_pair(pObj, nSize)); +} size_t const nSize = pObj-GetSizeBytes(); nUsedSize += nSize; -sizes.insert(std::make_pair(pObj, nSize)); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: IAccessible2 bridgecomponent context fails
On 10/24/2014 10:11 PM, sleeping.pil...@gmail.com wrote: Since last week I’m having some troubles with my Windows build and I can no longer get the IAccessible2 parts to work. I get the following warning when opening LibreOffice with NVDA screen reader running: warn:vcl:8004:12820:vcl/source/app/svdata.cxx:265: got no IAccessible2 bridgecomponent context fails to supply service 'com.sun.star.accessibility.MSAAService' of type 'com.sun.star.accessibility.XMSAAService' program/services/services.rdb needs to contain the string com.sun.star.accessibility.MSAAService. If it doesn't for you, I assume the condition $(if $(DISABLE_ATL),, \ $(if $(filter WNT,$(OS)), \ embeddedobj/source/msole/emboleobj.windows \ embedserv/util/emser \ extensions/source/ole/oleautobridge \ winaccessibility/source/service/winaccessibility \ ) \ ) \ in postprocess/Rdb_services.mk no longer holds for you---wasn't there some recent change to how configure.ac sets up DISABLE_ATL? However, it services.rdb still contains that string, most likely there's some problem loading the corresponding program/winaccessibility.dll. The easiest way to find out whether/why that's the case on Windows is probably to run program/soffice.exe from Depends (I guess there's a wiki page about that). Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: OS X: coinmp is not using install_name_tool
On 10/25/2014 03:42 PM, Robert Antoni Buj i Gelonch wrote: I wonder if we can do it easer using @rpath prefix and passing possible library locations in ld flags. https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/RunpathDependentLibraries.html I don't see a benefit in using that less precise @rpath mechanism. (You'd still need to force the @rpath install names into external libs, so those would remain the biggest pain anyway.) Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - svtools/source
svtools/source/graphic/grfmgr2.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit b0b45f82dbc6a16e6f29887531951a41c15b081f Author: Zolnai Tamás tamas.zol...@collabora.com Date: Mon Oct 27 16:16:04 2014 +0100 Fix build Change-Id: Id0dbf155e6430a456c7e1d9ab1d3b892d7a724a4 diff --git a/svtools/source/graphic/grfmgr2.cxx b/svtools/source/graphic/grfmgr2.cxx index 427c312..7f93bf9 100644 --- a/svtools/source/graphic/grfmgr2.cxx +++ b/svtools/source/graphic/grfmgr2.cxx @@ -207,13 +207,13 @@ void GraphicManager::ImplCheckSizeOfSwappedInGraphics(const GraphicObject* pGrap pObj = maObjList[i]; if (pObj-meType == GRAPHIC_BITMAP !pObj-IsSwappedOut() pObj-GetSizeBytes()) { +size_t const nSize = pObj-GetSizeBytes(); +nUsedSize += nSize; if( pObj != pGraphicToIgnore ) { aCandidates.push_back(pObj); sizes.insert(std::make_pair(pObj, nSize)); } -size_t const nSize = pObj-GetSizeBytes(); -nUsedSize += nSize; } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Refactor image handling
Hi there, Just a short note about that currently I'm working on refactoring of image handling (Graphic / GraphicObject). Mainly working on swapping mechanisms which cause a lot's of headache as I see. LO's bad swapping mechanism leads both to image loss and to ineffective behavior. So it's time to clean this up a bit. Any idea, advice is appreciated. Best Regards, Tamás ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/oox
include/oox/helper/binaryoutputstream.hxx | 14 ++ 1 file changed, 14 insertions(+) New commits: commit f70db32aa2df79cca42c44f05baf4baac6e04bf5 Author: David Tardon dtar...@redhat.com Date: Mon Oct 27 16:12:43 2014 +0100 fix writing const arrays on big endian Btw, th unanounced byte-swapping of valuse in the input array in writeArray seems a bit dubious to me... It could too easily cause unintentional memory damage. I just hope it is always called either with data that is not used after that anymore or with a copy of the data. Change-Id: Ica0e9ea16cd101fe87d7e0a8fa696911769e0654 diff --git a/include/oox/helper/binaryoutputstream.hxx b/include/oox/helper/binaryoutputstream.hxx index 7f3ee73..4ccc585 100644 --- a/include/oox/helper/binaryoutputstream.hxx +++ b/include/oox/helper/binaryoutputstream.hxx @@ -20,6 +20,9 @@ #ifndef INCLUDED_OOX_HELPER_BINARYOUTPUTSTREAM_HXX #define INCLUDED_OOX_HELPER_BINARYOUTPUTSTREAM_HXX +#include memory +#include boost/shared_array.hpp + #include oox/helper/binarystreambase.hxx namespace com { namespace sun { namespace star { @@ -64,6 +67,9 @@ public: template typename Type void writeArray( Type* opnArray, sal_Int32 nElemCount ); +template typename Type +void writeArray( const Type* opnArray, sal_Int32 nElemCount ); + /** Stream operator for all data types supported by the writeValue() function. */ template typename Type BinaryOutputStream operator( Type nValue ) { writeValue( nValue ); return *this; } @@ -88,6 +94,14 @@ void BinaryOutputStream::writeArray( Type* opnArray, sal_Int32 nElemCount ) writeMemory( opnArray, nWriteSize, sizeof( Type ) ); } +template typename Type +void BinaryOutputStream::writeArray( const Type* opnArray, sal_Int32 nElemCount ) +{ +boost::shared_arrayType pArray(new Type[nElemCount]); +std::uninitialized_copy(opnArray, opnArray + nElemCount, pArray.get()); +writeArray(pArray.get(), nElemCount); +} + typedef ::boost::shared_ptr BinaryOutputStream BinaryOutputStreamRef; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/qa sc/source
sc/qa/unit/ucalc_sort.cxx | 34 +- sc/source/core/data/table3.cxx | 15 +++ 2 files changed, 48 insertions(+), 1 deletion(-) New commits: commit 0b3f0f0bad8752c2ff2a1933ced57874ee846805 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Oct 27 08:53:33 2014 -0700 fdo#85215: Write test for this. Change-Id: I789da5d81e6211ed8f5fae1e293833bde5ce375b diff --git a/sc/qa/unit/ucalc_sort.cxx b/sc/qa/unit/ucalc_sort.cxx index d0997c3..a1189dd 100644 --- a/sc/qa/unit/ucalc_sort.cxx +++ b/sc/qa/unit/ucalc_sort.cxx @@ -18,6 +18,7 @@ #include scopetools.hxx #include globalnames.hxx #include dbdocfun.hxx +#include docfunc.hxx #include scitems.hxx #include editutil.hxx @@ -1430,7 +1431,38 @@ void Test::testSortRefUpdate6() { 9, 1, 7 }, }; -bool bSuccess = checkOutput3(m_pDoc, aDataRange, aOutputCheck, Sorted without reference update); +bool bSuccess = checkOutput3(m_pDoc, aDataRange, aOutputCheck, After redo); +CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess); +} + +// Change the value of C1 and make sure the formula broadcasting chain still works. +ScDocFunc rFunc = getDocShell().GetDocFunc(); +rFunc.SetValueCell(ScAddress(2,0,0), 11.0, false); +{ +// Expected output table content. 0 = empty cell +const char* aOutputCheck[][3] = { +{ Order, Value, 11 }, +{ 1, 2, 13 }, +{ 8, 3, 16 }, +{ 9, 1, 17 }, +}; + +bool bSuccess = checkOutput3(m_pDoc, aDataRange, aOutputCheck, Change the header value); +CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess); +} + +// Undo and check. +pUndoMgr-Undo(); +{ +// Expected output table content. 0 = empty cell +const char* aOutputCheck[][3] = { +{ Order, Value, 1 }, +{ 1, 2, 3 }, +{ 8, 3, 6 }, +{ 9, 1, 7 }, +}; + +bool bSuccess = checkOutput3(m_pDoc, aDataRange, aOutputCheck, After undo of header value change); CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess); } commit 1eb82c78a223d9a0b2bb5c3f5c129c1ee8bdf303 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Oct 27 08:52:38 2014 -0700 fdo#85215: Ensure that formula broadcasting works after sort. When the reference update on sort is turned off. Change-Id: I547dd1525a638dd447fe331e22583af4a7947308 diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 3e8250a..04bbbce 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -801,6 +801,15 @@ void ScTable::SortReorderByRow( ScSortInfoArray::RowsType* pRows = pArray-GetDataRows(); assert(pRows); // In sort-by-row mode we must have data rows already populated. +if (!pArray-IsUpdateRefs()) +{ +// When the update ref mode is disabled, we need to detach all formula +// cells in the sorted range before reordering, and re-start them +// afterward. +sc::EndListeningContext aCxt(*pDocument); +DetachFormulaCells(aCxt, nCol1, nRow1, nCol2, nRow2); +} + // Split formula groups at the sort range boundaries (if applicable). std::vectorSCROW aRowBounds; aRowBounds.reserve(2); @@ -1081,6 +1090,12 @@ void ScTable::SortReorderByRow( // Re-group columns in the sorted range too. for (SCCOL i = nCol1; i = nCol2; ++i) aCol[i].RegroupFormulaCells(); + +if (!pArray-IsUpdateRefs()) +{ +sc::StartListeningContext aCxt(*pDocument); +AttachFormulaCells(aCxt, nCol1, nRow1, nCol2, nRow2); +} } short ScTable::CompareCell( ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - 2 commits - sc/source
sc/source/core/data/table3.cxx | 15 + sc/source/core/tool/token.cxx | 67 + 2 files changed, 76 insertions(+), 6 deletions(-) New commits: commit 800eb8025233c340b154843c074fd5b6e8d21d35 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Oct 27 07:32:32 2014 -0700 fdo#85282: Correct adjustment of range reference on delete shift. Change-Id: I6e01c160f77599dfa4a2e55b60e23d256184c822 diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx index 7208d9d..f78e1c1 100644 --- a/sc/source/core/tool/token.cxx +++ b/sc/source/core/tool/token.cxx @@ -2536,6 +2536,9 @@ void setRefDeleted( ScComplexRefData rRef, const sc::RefUpdateContext rCxt ) bool shrinkRange( const sc::RefUpdateContext rCxt, ScRange rRefRange, const ScRange rDeletedRange ) { +if (!rDeletedRange.Intersects(rRefRange)) +return false; + if (rCxt.mnColDelta 0) { // Shifting left. @@ -2543,9 +2546,35 @@ bool shrinkRange( const sc::RefUpdateContext rCxt, ScRange rRefRange, const Sc // Deleted range is only partially overlapping in vertical direction. Bail out. return false; -// Move the last column position to the left. -SCCOL nDelta = rDeletedRange.aStart.Col() - rDeletedRange.aEnd.Col() - 1; -rRefRange.aEnd.IncCol(nDelta); +if (rDeletedRange.aStart.Col() = rRefRange.aStart.Col()) +{ +if (rRefRange.aEnd.Col() = rDeletedRange.aEnd.Col()) +{ +// Reference is entirely deleted. +rRefRange.SetInvalid(); +} +else +{ +// The reference range is truncated on the left. +SCCOL nOffset = rDeletedRange.aStart.Col() - rRefRange.aStart.Col(); +SCCOL nDelta = rRefRange.aStart.Col() - rDeletedRange.aEnd.Col() - 1; +rRefRange.aStart.IncCol(nOffset); +rRefRange.aEnd.IncCol(nDelta+nOffset); +} +} +else if (rDeletedRange.aEnd.Col() rRefRange.aEnd.Col()) +{ +// Reference is deleted in the middle. Move the last column +// position to the left. +SCCOL nDelta = rDeletedRange.aStart.Col() - rDeletedRange.aEnd.Col() - 1; +rRefRange.aEnd.IncCol(nDelta); +} +else +{ +// The reference range is truncated on the right. +SCCOL nDelta = rDeletedRange.aStart.Col() - rRefRange.aEnd.Col() - 1; +rRefRange.aEnd.IncCol(nDelta); +} return true; } else if (rCxt.mnRowDelta 0) @@ -2556,9 +2585,35 @@ bool shrinkRange( const sc::RefUpdateContext rCxt, ScRange rRefRange, const Sc // Deleted range is only partially overlapping in horizontal direction. Bail out. return false; -// Move the last row position up. -SCROW nDelta = rDeletedRange.aStart.Row() - rDeletedRange.aEnd.Row() - 1; -rRefRange.aEnd.IncRow(nDelta); +if (rDeletedRange.aStart.Row() = rRefRange.aStart.Row()) +{ +if (rRefRange.aEnd.Row() = rDeletedRange.aEnd.Row()) +{ +// Reference is entirely deleted. +rRefRange.SetInvalid(); +} +else +{ +// The reference range is truncated on the top. +SCCOL nOffset = rDeletedRange.aStart.Row() - rRefRange.aStart.Row(); +SCCOL nDelta = rRefRange.aStart.Row() - rDeletedRange.aEnd.Row() - 1; +rRefRange.aStart.IncRow(nOffset); +rRefRange.aEnd.IncRow(nDelta+nOffset); +} +} +else if (rDeletedRange.aEnd.Row() rRefRange.aEnd.Row()) +{ +// Reference is deleted in the middle. Move the last row +// position upward. +SCCOL nDelta = rDeletedRange.aStart.Row() - rDeletedRange.aEnd.Row() - 1; +rRefRange.aEnd.IncRow(nDelta); +} +else +{ +// The reference range is truncated on the bottom. +SCCOL nDelta = rDeletedRange.aStart.Row() - rRefRange.aEnd.Row() - 1; +rRefRange.aEnd.IncRow(nDelta); +} return true; } commit 452165fb459dd026b86de1e4b5fe0ade5beb3a83 Author: Kohei Yoshida kohei.yosh...@collabora.com Date: Mon Oct 27 08:52:38 2014 -0700 fdo#85215: Ensure that formula broadcasting works after sort. When the reference update on sort is turned off. Change-Id: I547dd1525a638dd447fe331e22583af4a7947308 (cherry picked from commit 1eb82c78a223d9a0b2bb5c3f5c129c1ee8bdf303) diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx index 9a6069c..d646678 100644 --- a/sc/source/core/data/table3.cxx +++ b/sc/source/core/data/table3.cxx @@ -802,6 +802,15 @@ void ScTable::SortReorderByRow( ScSortInfoArray::RowsType*
Re: new git bugzilla script
On Mon, 27 Oct 2014 14:00:56 +0100, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Hey, so I finally implemented a new git bugzilla script that should bring back the commit notifications in bugzilla for fixed bugs. As it is a complete new implementation you should report any problems as soon as possible thank Markus. one question: may we remove this test bug from the UNCONFIRMED list? https://bugs.freedesktop.org/show_bug.cgi?id=85461 should we change status to RESOLVED FIXED or NOTABUG or whatever you prefer? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: jvmfwk/plugins
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx | 70 +--- 1 file changed, 34 insertions(+), 36 deletions(-) New commits: commit 564fe4e36a9fdf313dc1abb86f6c24f61e03f31e Author: Stephan Bergmann sberg...@redhat.com Date: Mon Oct 27 17:59:06 2014 +0100 Clean up JNI_CreateJavaVM option code Change-Id: I1902c73a72f29e948e479a2ae4776f2dff77b2b5 diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx index 3d4e3f4..8bcca85 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx @@ -655,60 +655,58 @@ javaPluginError jfw_plugin_startJavaVirtualMachine( // Valgrind typically emits many false errors when executing JIT'ed JVM // code, so force the JVM into interpreted mode: -bool forceInterpreted = FORCE_INTERPRETED 0; +bool addForceInterpreted = FORCE_INTERPRETED 0; // Some testing with Java 1.4 showed that JavaVMOption.optionString has to // be encoded with the system encoding (i.e., osl_getThreadTextEncoding): JavaVMInitArgs vm_args; -sal_Int32 nOptions = 1 + cOptions + (forceInterpreted ? 1 : 0); -//TODO: check for overflow -boost::scoped_arrayJavaVMOption sarOptions(new JavaVMOption[nOptions]); -JavaVMOption * options = sarOptions.get(); +struct Option { +Option(OString const theOptionString, void * theExtraInfo): +optionString(theOptionString), extraInfo(theExtraInfo) +{} + +OString optionString; +void * extraInfo; +}; +std::vectorOption options; // We set an abort handler which is called when the VM calls _exit during // JNI_CreateJavaVM. This happens when the LD_LIBRARY_PATH does not contain // all some directories of the Java installation. This is necessary for // all versions below 1.5.1 -int n = 0; -options[n].optionString= (char *) abort; -options[n].extraInfo= reinterpret_castvoid*(abort_handler); -++n; -OString sClassPathOption; +options.push_back(Option(abort, reinterpret_castvoid*(abort_handler))); for (int i = 0; i cOptions; i++) { +OString opt(arOptions[i].optionString); #ifdef UNX -// Until java 1.5 we need to put a plugin.jar or javaplugin.jar (1.4.2) -// in the class path in order to have applet support. -OString sClassPath = arOptions[i].optionString; -if (sClassPath.startsWith(-Djava.class.path=)) +// Until java 1.5 we need to put a plugin.jar or javaplugin.jar (1.4.2) +// in the class path in order to have applet support: +if (opt.startsWith(-Djava.class.path=)) { OString sAddPath = getPluginJarPath(pInfo-sVendor, pInfo-sLocation,pInfo-sVersion); if (!sAddPath.isEmpty()) -sClassPathOption = sClassPath + OString(SAL_PATHSEPARATOR) -+ sAddPath; -else -sClassPathOption = sClassPath; -options[n].optionString = (char *) sClassPathOption.getStr(); -options[n].extraInfo = arOptions[i].extraInfo; +opt += OString(SAL_PATHSEPARATOR) + sAddPath; } -else -{ #endif -options[n].optionString = arOptions[i].optionString; -options[n].extraInfo = arOptions[i].extraInfo; -#ifdef UNX +if (opt == -Xint) { +addForceInterpreted = false; } -#endif -#if OSL_DEBUG_LEVEL = 2 -JFW_TRACE2(VM option: options[n].optionString); -#endif -++n; +options.push_back(Option(opt, arOptions[i].extraInfo)); } -if (forceInterpreted) { -options[n].optionString = const_castchar *(-Xint); -options[n].extraInfo = 0; -++n; +if (addForceInterpreted) { +options.push_back(Option(-Xint, nullptr)); +} + +boost::scoped_arrayJavaVMOption sarOptions(new JavaVMOption[options.size()]); +for (std::vectorOption::size_type i = 0; i != options.size(); ++i) { +SAL_INFO( +jfw, +VM option \ options[i].optionString \ + options[i].extraInfo); +sarOptions[i].optionString = const_castchar *( +options[i].optionString.getStr()); +sarOptions[i].extraInfo = options[i].extraInfo; } #ifdef MACOSX @@ -716,8 +714,8 @@ javaPluginError jfw_plugin_startJavaVirtualMachine( #else vm_args.version= JNI_VERSION_1_2; #endif -vm_args.options= options; -vm_args.nOptions= nOptions; +vm_args.options= sarOptions.get(); +vm_args.nOptions= options.size(); //TODO overflow vm_args.ignoreUnrecognized= JNI_TRUE; /* We set a global flag which is used by the abort handler in order to ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/inc/workctrl.hxx|4 - sw/source/uibase/ribbar/workctrl.cxx | 92 +++ 2 files changed, 21 insertions(+), 75 deletions(-) New commits: commit 4aa2791ea6ee72d429cb8ddcaffd0a9fe647e3db Author: Juergen Funk juergen.funk...@cib.de Date: Wed Oct 22 15:52:04 2014 +0200 fdo#84408 Toolbar: Insert Field dropdown doesn't contain icons Change-Id: I3c8db72a84f2a68f1f68a0be1b21e2454707d84a Reviewed-on: https://gerrit.libreoffice.org/12068 Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com diff --git a/sw/source/uibase/inc/workctrl.hxx b/sw/source/uibase/inc/workctrl.hxx index 5a56dd4..567a0d0 100644 --- a/sw/source/uibase/inc/workctrl.hxx +++ b/sw/source/uibase/inc/workctrl.hxx @@ -96,10 +96,6 @@ public: class SwTbxFieldCtrl : public SfxToolBoxControl { -PopupMenu* pPopup; -SwView* pView; - -voidDelPopup(); public: SFX_DECL_TOOLBOX_CONTROL(); diff --git a/sw/source/uibase/ribbar/workctrl.cxx b/sw/source/uibase/ribbar/workctrl.cxx index 6984554..ef1e5b7 100644 --- a/sw/source/uibase/ribbar/workctrl.cxx +++ b/sw/source/uibase/ribbar/workctrl.cxx @@ -25,6 +25,8 @@ #include sfx2/dispatch.hxx #include sfx2/bindings.hxx #include sfx2/imagemgr.hxx +#include sfx2/mnumgr.hxx +#include sfx2/msgpool.hxx #include swmodule.hxx #include view.hxx #include initui.hxx @@ -47,6 +49,8 @@ #include vcl/svapp.hxx + + // Size check #define NAVI_ENTRIES 20 #if NAVI_ENTRIES != NID_COUNT @@ -282,57 +286,48 @@ SwTbxFieldCtrl::SwTbxFieldCtrl( sal_uInt16 nSlotId, sal_uInt16 nId, ToolBox rTbx ) : -SfxToolBoxControl( nSlotId, nId, rTbx ), -pPopup(0), -pView(0) +SfxToolBoxControl( nSlotId, nId, rTbx ) { rTbx.SetItemBits( nId, ToolBoxItemBits::DROPDOWNONLY | rTbx.GetItemBits( nId ) ); } SwTbxFieldCtrl::~SwTbxFieldCtrl() { -DelPopup(); } SfxPopupWindow* SwTbxFieldCtrl::CreatePopupWindow() { -pView = ::GetActiveView(); +SwView* pView = ::GetActiveView(); if(pView !pView-GetDocShell()-IsReadOnly() !pView-GetWrtShell().HasReadonlySel() ) { -ToolBox rBox = GetToolBox(); +PopupMenu* pPopup = new PopupMenu(SW_RES(RID_INSERT_FIELD_CTRL)); -Rectangle aItemRect( rBox.GetItemRect( GetId() ) ); -Point aPt(rBox.OutputToScreenPixel(aItemRect.TopLeft())); -aPt.X() += aItemRect.GetWidth()/2; -aPt.Y() += aItemRect.GetHeight()/2; -if(pView) +if (::GetHtmlMode(pView-GetDocShell()) HTMLMODE_ON) { -Link aLnk = LINK(this, SwTbxFieldCtrl, PopupHdl); +pPopup-RemoveItem(pPopup-GetItemPos(FN_INSERT_FLD_PGCOUNT)); +pPopup-RemoveItem(pPopup-GetItemPos(FN_INSERT_FLD_TOPIC)); +} -pPopup = new PopupMenu(SW_RES(RID_INSERT_FIELD_CTRL)); -pPopup-SetSelectHdl(aLnk); +ToolBox* pToolBox = GetToolBox(); +sal_uInt16nId = GetId(); +SfxDispatcher *rDispat = pView-GetViewFrame()-GetDispatcher(); + +// set the icons in the Popup-Menu, delete the pPopup +SfxPopupMenuManager aPop( pPopup, rDispat-GetFrame()-GetBindings() ); -if (::GetHtmlMode(pView-GetDocShell()) HTMLMODE_ON) -{ -pPopup-RemoveItem(pPopup-GetItemPos(FN_INSERT_FLD_PGCOUNT)); -pPopup-RemoveItem(pPopup-GetItemPos(FN_INSERT_FLD_TOPIC)); -} -} -ToolBox* pToolBox = GetToolBox(); -sal_uInt16 nId = GetId(); pToolBox-SetItemDown( nId, true ); pPopup-Execute( pToolBox, pToolBox-GetItemRect( nId ), -(pToolBox-GetAlign() == WINDOWALIGN_TOP || pToolBox-GetAlign() == WINDOWALIGN_BOTTOM) ? -POPUPMENU_EXECUTE_DOWN : POPUPMENU_EXECUTE_RIGHT ); +(pToolBox-GetAlign() == WINDOWALIGN_TOP || pToolBox-GetAlign() == WINDOWALIGN_BOTTOM) ? + POPUPMENU_EXECUTE_DOWN : POPUPMENU_EXECUTE_RIGHT ); pToolBox-SetItemDown( nId, false ); } + GetToolBox().EndSelection(); -DelPopup(); -return 0; +return 0; } SfxPopupWindowType SwTbxFieldCtrl::GetPopupWindowType() const @@ -351,51 +346,6 @@ void SwTbxFieldCtrl::StateChanged( sal_uInt16, } } -IMPL_LINK(SwTbxFieldCtrl, PopupHdl, PopupMenu*, pMenu) -{ -sal_uInt16 nId = pMenu-GetCurItemId(); - -Sequence PropertyValue aArgs; -const char* pChar = 0; -switch(nId) -{ -case FN_INSERT_FLD_DATE: -pChar = .uno:InsertDateField; -break; -case FN_INSERT_FLD_TIME: -pChar = .uno:InsertTimeField; -break; -case FN_INSERT_FLD_PGNUMBER: -pChar = .uno:InsertPageNumberField; -break; -case FN_INSERT_FLD_PGCOUNT: -pChar = .uno:InsertPageCountField; -break; -case FN_INSERT_FLD_TOPIC: -
[Libreoffice-commits] core.git: jvmfwk/plugins
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx | 40 1 file changed, 40 insertions(+) New commits: commit f66cbdb948c6c43909a18be10aa838c69338dcb0 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Oct 27 18:26:33 2014 +0100 Work around OpenJDK's os::workaround_expand_exec_shield_cs_limit Change-Id: Iea1b6354764db0a22976b3de49bf3e22ccb7243e diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx index 8bcca85..2b72408 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx @@ -70,6 +70,10 @@ #endif #endif +#if defined LINUX defined X86 +#include sys/resource.h +#endif + using namespace osl; using namespace std; using namespace jfw_plugin; @@ -676,6 +680,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine( // all some directories of the Java installation. This is necessary for // all versions below 1.5.1 options.push_back(Option(abort, reinterpret_castvoid*(abort_handler))); +bool hasStackSize = false; for (int i = 0; i cOptions; i++) { OString opt(arOptions[i].optionString); @@ -692,11 +697,46 @@ javaPluginError jfw_plugin_startJavaVirtualMachine( if (opt == -Xint) { addForceInterpreted = false; } +if (opt.startsWith(-Xss)) { +hasStackSize = true; +} options.push_back(Option(opt, arOptions[i].extraInfo)); } if (addForceInterpreted) { options.push_back(Option(-Xint, nullptr)); } +if (!hasStackSize) { +#if defined LINUX defined X86 +// At least OpenJDK 1.8.0's os::workaround_expand_exec_shield_cs_limit +// (hotspot/src/os_cpu/linux_x86/vm/os_linux_x86.cpp) can mmap an rwx +// page into the area that the main stack can grow down to according to +// ulimit -s, as os::init_2's (hotspot/src/os/linux/vm/os_linux.cpp) +// call to +// +// Linux::capture_initial_stack(JavaThread::stack_size_at_create()); +// +// caps _initial_thread_stack_size at threadStackSizeInBytes ,i.e., +// -Xss, which appears to default to only 327680, whereas ulimit -s +// defaults to 8192 * 1024 at least on Fedora 20; so attempt to pass in +// a useful -Xss argument: +rlimit l; +if (getrlimit(RLIMIT_STACK, l) == 0) { +if (l.rlim_cur == RLIM_INFINITY) { +SAL_INFO(jfw, RLIMIT_STACK RLIM_INFINITY - 8192K); +l.rlim_cur = 8192 * 1024; +} else if (l.rlim_cur 512 * 1024 * 1024) { +SAL_INFO( +jfw, huge RLIMIT_STACK l.rlim_cur - 8192K); +l.rlim_cur = 8192 * 1024; +} +options.push_back( +Option(-Xss + OString::number(l.rlim_cur), nullptr)); +} else { +int e = errno; +SAL_WARN(jfw, getrlimit(RLIMIT_STACK) failed with errno e); +} +#endif +} boost::scoped_arrayJavaVMOption sarOptions(new JavaVMOption[options.size()]); for (std::vectorOption::size_type i = 0; i != options.size(); ++i) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: IAccessible2 bridgecomponent context fails
Hi Stephan Thank you for the reply. Stephan Bergmann skrev 2014-10-27 16:03: in postprocess/Rdb_services.mk no longer holds for you---wasn't there some recent change to how configure.ac sets up DISABLE_ATL? Ah, thanks for the hint. I haven't had a chance to test it yet but the commit [1] disable atl and activex be default if a Visual Studio Express is detected seems very likely to be what is giving me trouble. I do have an Express version installed on the same machine so it probably picks that one up and disables ATL. Will build with --enable-atl and keep my fingers crossed, might take me a day or to but I'll let you know how it goes. Thanks, Niklas Johansson [1] http://cgit.freedesktop.org/libreoffice/core/commit/configure.ac?id=1744fed4a455a85d948507d91af1f2e186046851 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/perfwork4' - 2 commits - filter/source include/package package/inc package/source
filter/source/xsltfilter/OleHandler.cxx|2 - include/package/Deflater.hxx |2 - package/inc/CRC32.hxx |2 - package/inc/ZipOutputEntry.hxx |2 - package/inc/ZipOutputStream.hxx|2 - package/source/zipapi/CRC32.cxx|7 ++--- package/source/zipapi/Deflater.cxx |8 ++ package/source/zipapi/ZipFile.cxx |4 +-- package/source/zipapi/ZipOutputEntry.cxx |6 ++--- package/source/zipapi/ZipOutputStream.cxx |7 ++--- package/source/zippackage/ZipPackage.cxx | 14 +-- package/source/zippackage/ZipPackageStream.cxx | 30 +++-- 12 files changed, 39 insertions(+), 47 deletions(-) New commits: commit ac467076029907da366280f2ab1244bee7067bb0 Author: Matúš Kukan matus.ku...@collabora.com Date: Mon Oct 27 14:26:54 2014 +0100 Simplify input parameters to just take the sequence Change-Id: Ic2538ca8b0f7261064e1dfbf3884dd452003c797 diff --git a/filter/source/xsltfilter/OleHandler.cxx b/filter/source/xsltfilter/OleHandler.cxx index 1515174..f1a7ea0 100644 --- a/filter/source/xsltfilter/OleHandler.cxx +++ b/filter/source/xsltfilter/OleHandler.cxx @@ -198,7 +198,7 @@ namespace XSLT // Compress the bytes Sequencesal_Int8 output(oledata.getLength()); boost::scoped_ptr ::ZipUtils::Deflater compresser(new ::ZipUtils::Deflater((sal_Int32) 3, false)); -compresser-setInputSegment(oledata, 0, oledata.getLength()); +compresser-setInputSegment(oledata); compresser-finish(); int compressedDataLength = compresser-doDeflateSegment(output, 0, oledata.getLength()); compresser.reset(); diff --git a/include/package/Deflater.hxx b/include/package/Deflater.hxx index ad73f28..665407d 100644 --- a/include/package/Deflater.hxx +++ b/include/package/Deflater.hxx @@ -46,7 +46,7 @@ protected: public: ~Deflater(); Deflater(sal_Int32 nSetLevel, bool bNowrap); -void SAL_CALL setInputSegment( const ::com::sun::star::uno::Sequence sal_Int8 rBuffer, sal_Int32 nNewOffset, sal_Int32 nNewLength ); +void SAL_CALL setInputSegment( const ::com::sun::star::uno::Sequence sal_Int8 rBuffer ); void SAL_CALL setLevel( sal_Int32 nNewLevel ); bool SAL_CALL needsInput( ); void SAL_CALL finish( ); diff --git a/package/inc/CRC32.hxx b/package/inc/CRC32.hxx index daaf4b5..cfc66c4 100644 --- a/package/inc/CRC32.hxx +++ b/package/inc/CRC32.hxx @@ -35,7 +35,7 @@ public: sal_Int64 SAL_CALL updateStream (::com::sun::star::uno::Reference ::com::sun::star::io::XInputStream xStream) throw(::com::sun::star::uno::RuntimeException); -void SAL_CALL updateSegment(const ::com::sun::star::uno::Sequence sal_Int8 b, sal_Int32 off, sal_Int32 len) +void SAL_CALL updateSegment(const ::com::sun::star::uno::Sequence sal_Int8 b, sal_Int32 len) throw(::com::sun::star::uno::RuntimeException); void SAL_CALL update(const ::com::sun::star::uno::Sequence sal_Int8 b) throw(::com::sun::star::uno::RuntimeException); diff --git a/package/inc/ZipOutputEntry.hxx b/package/inc/ZipOutputEntry.hxx index 9e396ce..26ebb15 100644 --- a/package/inc/ZipOutputEntry.hxx +++ b/package/inc/ZipOutputEntry.hxx @@ -59,7 +59,7 @@ public: bool isEncrypt() { return m_bEncryptCurrentEntry; } void closeEntry(); -void write(const css::uno::Sequence sal_Int8 rBuffer, sal_Int32 nNewOffset, sal_Int32 nNewLength); +void write(const css::uno::Sequence sal_Int8 rBuffer); private: void doDeflate(); diff --git a/package/inc/ZipOutputStream.hxx b/package/inc/ZipOutputStream.hxx index ddc921d..54638d5 100644 --- a/package/inc/ZipOutputStream.hxx +++ b/package/inc/ZipOutputStream.hxx @@ -50,7 +50,7 @@ public: void writeLOC( ZipEntry *pEntry, bool bEncrypt = false ) throw(::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException); -void rawWrite( ::com::sun::star::uno::Sequence sal_Int8 rBuffer, sal_Int32 nNewOffset, sal_Int32 nNewLength ) +void rawWrite( const css::uno::Sequence sal_Int8 rBuffer ) throw(::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException); void rawCloseEntry( bool bEncrypt = false ) throw(::com::sun::star::io::IOException, ::com::sun::star::uno::RuntimeException); diff --git a/package/source/zipapi/CRC32.cxx b/package/source/zipapi/CRC32.cxx index 6aee4d5..39b4f4c 100644 --- a/package/source/zipapi/CRC32.cxx +++ b/package/source/zipapi/CRC32.cxx @@ -47,11 +47,10 @@ sal_Int32 SAL_CALL CRC32::getValue() } /** Update CRC32 with specified sequence of bytes */ -void SAL_CALL CRC32::updateSegment(const Sequence sal_Int8 b, - sal_Int32 off, sal_Int32 len) +void SAL_CALL CRC32::updateSegment(const Sequence sal_Int8 b, sal_Int32 len) throw(RuntimeException) { -
Re: minutes of ESC call ...
Hi, Le 23/10/2014 17:20, Michael Meeks a écrit : [...] * Pending Action Items: + get a clear use-case description of what doesn't work vs. master wrt. Calc sorting (JBF) First draft here: https://bugs.freedesktop.org/show_bug.cgi?id=85490 and https://bugs.freedesktop.org/attachment.cgi?id=108474 Comments are welcome :-) Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 4 commits - vcl/inc vcl/Library_vcl.mk vcl/source vcl/unx
vcl/Library_vcl.mk |1 + vcl/inc/unx/salframe.h |5 - vcl/source/opengl/OpenGLContext.cxx |2 +- vcl/unx/generic/gdi/salgdi.cxx | 10 ++ vcl/unx/generic/window/salframe.cxx |5 + 5 files changed, 17 insertions(+), 6 deletions(-) New commits: commit 3b497a3080ea090978824321f99779a10b8df6e9 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Mon Oct 27 20:38:46 2014 +0100 better way to access the X11 window Now any plugin that implements this class will automatically work. Change-Id: I7b00ef3e76dfd24e497a31fe4d3c468eb5b4b654 diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index c680634..8580701 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -554,6 +554,7 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/unx/generic/plugadapt/salplug \ vcl/unx/generic/printer/jobdata \ vcl/unx/generic/printer/ppdparser \ + vcl/unx/generic/gdi/x11windowprovider \ $(if $(filter TRUE,$(ENABLE_CUPS)),\ vcl/unx/generic/printer/cupsmgr \ vcl/unx/generic/printer/printerinfomanager \ diff --git a/vcl/inc/unx/salframe.h b/vcl/inc/unx/salframe.h index 637ef67..9b737f9 100644 --- a/vcl/inc/unx/salframe.h +++ b/vcl/inc/unx/salframe.h @@ -26,6 +26,7 @@ #include unx/salunx.h #include unx/saltype.h #include unx/saldisp.hxx +#include unx/x11windowprovider.hxx #include salframe.hxx #include salwtype.hxx #include salinst.hxx @@ -48,7 +49,7 @@ namespace vcl_sal { class WMAdaptor; class NetWMAdaptor; class GnomeWMAdaptor; } #define SHOWSTATE_NORMAL1 #define SHOWSTATE_HIDDEN2 -class VCLPLUG_GEN_PUBLIC X11SalFrame : public SalFrame +class VCLPLUG_GEN_PUBLIC X11SalFrame : public SalFrame, public X11WindowProvider { friend class vcl_sal::WMAdaptor; friend class vcl_sal::NetWMAdaptor; @@ -270,6 +271,8 @@ public: // done setting up the clipregion virtual voidEndSetClipRegion() SAL_OVERRIDE; +virtual Window GetX11Window() SAL_OVERRIDE; + static Bool checkKeyReleaseForRepeat( Display*, XEvent*, XPointer pX11SalFrame ); /// @internal diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx index d51d24f..9b23a64 100644 --- a/vcl/unx/generic/gdi/salgdi.cxx +++ b/vcl/unx/generic/gdi/salgdi.cxx @@ -51,6 +51,7 @@ #include unx/x11/xlimits.hxx #include salgdiimpl.hxx +#include unx/x11windowprovider.hxx #include gdiimpl.hxx #include openglgdiimpl.hxx @@ -154,14 +155,11 @@ void X11SalGraphics::SetDrawable( Drawable aDrawable, SalX11Screen nXScreen ) else { OpenGLSalGraphicsImpl* pOpenGLImpl = dynamic_castOpenGLSalGraphicsImpl*(mpImpl.get()); -if (pOpenGLImpl m_pFrame) +if (pOpenGLImpl m_pFrame dynamic_castX11WindowProvider*(m_pFrame)) { -if( dynamic_castX11SalFrame*(m_pFrame)) -{ -Window aWin = dynamic_castX11SalFrame*(m_pFrame)-GetDrawable(); +Window aWin = dynamic_castX12WindowProvider*(m_pFrame)-GetX11Window(); pOpenGLImpl-GetOpenGLContext().init(GetXDisplay(), aWin, m_nXScreen.getXScreen()); -} } } nTextPixel_ = GetPixel( nTextColor_ ); diff --git a/vcl/unx/generic/window/salframe.cxx b/vcl/unx/generic/window/salframe.cxx index 0bda729..6c98968 100644 --- a/vcl/unx/generic/window/salframe.cxx +++ b/vcl/unx/generic/window/salframe.cxx @@ -4268,4 +4268,9 @@ void X11SalFrame::EndSetClipRegion() } +Window X11SalFrame::GetX11Window() +{ +return mhWindow; +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit b5b81f8a6588b0eb2dd1cd19f73606220621c1b2 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Mon Oct 27 20:02:10 2014 +0100 handle the OpenGL context for the x11 backend Change-Id: If3f5f879cc4fc0b78c325908c3358d09194144c6 diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx index 7e4100b..d51d24f 100644 --- a/vcl/unx/generic/gdi/salgdi.cxx +++ b/vcl/unx/generic/gdi/salgdi.cxx @@ -154,10 +154,14 @@ void X11SalGraphics::SetDrawable( Drawable aDrawable, SalX11Screen nXScreen ) else { OpenGLSalGraphicsImpl* pOpenGLImpl = dynamic_castOpenGLSalGraphicsImpl*(mpImpl.get()); -if (pOpenGLImpl) +if (pOpenGLImpl m_pFrame) { -pOpenGLImpl-GetOpenGLContext().init(GetXDisplay(), -GetDisplay()-GetDrawable(m_nXScreen), m_nXScreen.getXScreen()); +if( dynamic_castX11SalFrame*(m_pFrame)) +{ +Window aWin = dynamic_castX11SalFrame*(m_pFrame)-GetDrawable(); +pOpenGLImpl-GetOpenGLContext().init(GetXDisplay(), +aWin, m_nXScreen.getXScreen()); +}
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 2 commits - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |5 - vcl/unx/generic/gdi/salgdi.cxx |2 +- vcl/unx/gtk/window/gtksalframe.cxx |5 + 3 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 5776ab7107d4e0692c6945c9a309406581349421 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Mon Oct 27 21:08:06 2014 +0100 implement X11WindowProvider for GtkSalFrame Change-Id: Id763f9b69f4d4476a3b6401bb83e2bf173248e8a diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index 93a7f1d..c10f0b5 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -33,6 +33,7 @@ #include salframe.hxx #include vcl/sysdata.hxx +#include unx/x11windowprovider.hxx #include unx/saltype.h #include tools/link.hxx @@ -58,7 +59,7 @@ typedef ::Window GdkNativeWindow; typedef void GDBusConnection; #endif -class GtkSalFrame : public SalFrame +class GtkSalFrame : public SalFrame, public X11WindowProvider { static const int nMaxGraphics = 2; @@ -445,6 +446,8 @@ public: static GtkSalFrame *getFromWindow( GtkWindow *pWindow ); virtual voiddamaged (const basegfx::B2IBox rDamageRect); + +virtual Window GetX11Window() SAL_OVERRIDE; }; #define OOO_TYPE_FIXED ooo_fixed_get_type() diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index b39875f..03cf9df 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -4508,4 +4508,9 @@ Size GtkSalDisplay::GetScreenSize( int nDisplayScreen ) return Size( aRect.GetWidth(), aRect.GetHeight() ); } +Window GtkSalFrame::GetX11Window() +{ +return widget_get_xid(m_pWindow); +} + /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit 605971da3ac6e915d572b5729dcc90f693bc0846 Author: Markus Mohrhard markus.mohrh...@collabora.co.uk Date: Mon Oct 27 20:42:59 2014 +0100 fix stupid typo Change-Id: I119503d3057afbfa3e04ce7736fed966a414b9b9 diff --git a/vcl/unx/generic/gdi/salgdi.cxx b/vcl/unx/generic/gdi/salgdi.cxx index 9b23a64..caa7b1c 100644 --- a/vcl/unx/generic/gdi/salgdi.cxx +++ b/vcl/unx/generic/gdi/salgdi.cxx @@ -157,7 +157,7 @@ void X11SalGraphics::SetDrawable( Drawable aDrawable, SalX11Screen nXScreen ) OpenGLSalGraphicsImpl* pOpenGLImpl = dynamic_castOpenGLSalGraphicsImpl*(mpImpl.get()); if (pOpenGLImpl m_pFrame dynamic_castX11WindowProvider*(m_pFrame)) { -Window aWin = dynamic_castX12WindowProvider*(m_pFrame)-GetX11Window(); +Window aWin = dynamic_castX11WindowProvider*(m_pFrame)-GetX11Window(); pOpenGLImpl-GetOpenGLContext().init(GetXDisplay(), aWin, m_nXScreen.getXScreen()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on||46447 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on|46447 | -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: enhancing perfcheck - Proof of concept proposals
Hi, On Wed, 2014-10-22 at 12:18 +0200, Laurent Godard wrote: I instrumented the big file load for testing purpose but yes, in absolute, i'm also interrested in perf check of such files loading (and even saving) I've added it to loperf; it's now in http://dev-builds.libreoffice.org/callgrind_report/ So, there is no need for the load test now, I think. i agree to keep the instrumentation as slow as possible, but in my experience, some perf problem start to appear exponentially with file complexity (a lot of sheets/formulas/named ranges/cell notes) heh, hopefully not exponential but 'just' quadratic or something like that :-) Yes, to see problems, the data have to be resonable big often, but I think it's a bit different with callgrind - you see everything there. And with 100 items, you should be already able to spot quadratic complexity. Well, this is good but it's hard to parse the results quickly. Do you think we could have date/commit in one line with all numbers? And descriptions somewhere at the top. So that we could compare results in one column easily (and draw graphs..) Something like http://dev-builds.libreoffice.org/callgrind_report/history.fods this is what is intended to be done the output is a tabulated separated csv file, with all the information on a single line (and description at top) yes, it is but I meant something else - current description is not that usefull. We have lastCommit test_name filedatetime dump_comment count commit test_name date1 dump_comment number_1 ... other tests ... commit+1 test_name date2 dump_comment number_2 and it's hard to see how situation has improved between commit and commit+1 for test_name-dump_comment test Instead something like commit date test_name-1-dump_comment-1 ... test_name-n-dump_comment-m commit date number_1 ... numbers for different tests commit+1 date number_2 ... would be better I think - you can just compare number_1 and number_2 on the next row in the same column. Hopefully this makes sense. The problem is adding new tests - they would need new columns. The script would need to be clever enough to add new columns when needed somehow. Or, another possibility is to have another script which would generate file with the second format mentioned here from the existing csv file. Or - even better - we could just compile in the callgrind code all the time and decide when running make, whether we want to run under valgrind --tool=callgrind or not (or both). If that works. :-) So, something like IS_PERFCHECK is always true, no duplication and only decide whether to run under valgrind. Does that make sense? What do you think? i like the approach as it will simplify the trickiest part (the nasty include to avoid double linking problem) indeed imho, it would be clearer to keep some 'make perfcheck' command but this would only - set IS_PERFCHECK this would be set all the time (not needed) make perfcheck would just run tests under callgrind, where it makes sense feel free to give me some code pointers (remember, i'm only a poor scripter, always-beginner in core stuff ;) ) Do you want to work on this? It's just a matter of adding some include/test/callgrind.hxx and using that instead of macros with content similar to yours https://gerrit.libreoffice.org/gitweb?p=core.git;a=blob;f=sc/qa/perf/perf_instrumentation.cxx;h=2bfea52063b8584ba9dab6110bace230d6899bcd;hb=ac1ef94b035813895a1420e7b1434eeb925dd220 and some makefiles hacking I guess. I am happy to hack this in, or help you with implementation - as you choose. Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: setup_native/scripts
setup_native/scripts/source/getuid.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) New commits: commit 077ad1a5ab6848255e0350df368c4f45ae73da9c Author: Stephan Bergmann sberg...@redhat.com Date: Mon Oct 27 21:55:52 2014 +0100 -Werror,-Wtautological-pointer-compare (/usr/include/sys/stat.h annotates __lxstat params as __nonnull) Change-Id: I4297c4a05f54bc35688b65dd1ddcdeb7bc7fc37b diff --git a/setup_native/scripts/source/getuid.c b/setup_native/scripts/source/getuid.c index 17ed60d..d3660f4 100644 --- a/setup_native/scripts/source/getuid.c +++ b/setup_native/scripts/source/getuid.c @@ -17,6 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include assert.h #include fcntl.h #include sys/types.h #include sys/stat.h @@ -122,11 +123,9 @@ int __lxstat(int n, const char *path, struct stat *buf) p_lstat = (int (*)(int n, const char *path, struct stat *buf)) dlsym (RTLD_NEXT, __lxstat); ret = (*p_lstat)(n, path, buf); -if (buf != NULL) -{ -buf-st_uid = 0; /* root */ -buf-st_gid = 0; /* root */ -} +assert(buf != NULL); +buf-st_uid = 0; /* root */ +buf-st_gid = 0; /* root */ return ret; } #else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/libetonyek
external/libetonyek/ExternalProject_libetonyek.mk |2 +- external/libetonyek/UnpackedTarball_libetonyek.mk |6 +- external/libetonyek/assert.patch | 20 3 files changed, 26 insertions(+), 2 deletions(-) New commits: commit e7682068a184d5233229533585f9bd06298c7731 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Oct 27 22:06:10 2014 +0100 Pass ENABLE_DEBUG into external/libetonyek (and consequently fix the argument type of one assert invocation) Change-Id: I8bf5f024cc104a3885f7b9bf6ed63b9f6259d47b diff --git a/external/libetonyek/ExternalProject_libetonyek.mk b/external/libetonyek/ExternalProject_libetonyek.mk index 84d6e7f..0d281b5 100644 --- a/external/libetonyek/ExternalProject_libetonyek.mk +++ b/external/libetonyek/ExternalProject_libetonyek.mk @@ -30,7 +30,7 @@ $(call gb_ExternalProject_get_state_target,libetonyek,build) : --enable-static \ --disable-shared \ --without-docs \ - --disable-debug \ + $(if $(ENABLE_DEBUG),--enable-debug,--disable-debug) \ --disable-werror \ --disable-weffc \ --without-tools \ diff --git a/external/libetonyek/UnpackedTarball_libetonyek.mk b/external/libetonyek/UnpackedTarball_libetonyek.mk index 7a8746c..448e41e 100644 --- a/external/libetonyek/UnpackedTarball_libetonyek.mk +++ b/external/libetonyek/UnpackedTarball_libetonyek.mk @@ -11,6 +11,10 @@ $(eval $(call gb_UnpackedTarball_UnpackedTarball,libetonyek)) $(eval $(call gb_UnpackedTarball_set_tarball,libetonyek,$(ETONYEK_TARBALL))) -$(eval $(call gb_UnpackedTarball_set_patchlevel,libetonyek,1)) +$(eval $(call gb_UnpackedTarball_set_patchlevel,libetonyek,0)) + +$(eval $(call gb_UnpackedTarball_add_patches,libetonyek, \ +external/libetonyek/assert.patch \ +)) # vim: set noet sw=4 ts=4: diff --git a/external/libetonyek/assert.patch b/external/libetonyek/assert.patch new file mode 100644 index 000..39d68db --- /dev/null +++ b/external/libetonyek/assert.patch @@ -0,0 +1,20 @@ +--- src/lib/EtonyekDocument.cpp src/lib/EtonyekDocument.cpp +@@ -7,6 +7,8 @@ + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + ++#include cassert ++ + #include boost/scoped_ptr.hpp + #include boost/shared_ptr.hpp + #include boost/logic/tribool.hpp +@@ -179,7 +181,7 @@ + info.input-seek(0, RVNG_SEEK_SET); + } + +- assert(!isGzipped); ++ assert(bool(!isGzipped)); + + return probeXMLImpl(info.input, probe, type, info); + } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/nss
external/nss/ExternalProject_nss.mk |1 + 1 file changed, 1 insertion(+) New commits: commit ae064ec005f157cb76fedb8ae5482f38c56704ad Author: Robert Antoni Buj i Gelonch robert@gmail.com Date: Thu Oct 23 23:18:52 2014 +0200 nss: add libnsspem.dylib to macosx-change-install-names.pl call Change-Id: If457f9e090a4ef3a5b2b8e4f09ce0b5e3b3d04ec Signed-off-by: Stephan Bergmann sberg...@redhat.com diff --git a/external/nss/ExternalProject_nss.mk b/external/nss/ExternalProject_nss.mk index f518bb4..17ea6f1 100644 --- a/external/nss/ExternalProject_nss.mk +++ b/external/nss/ExternalProject_nss.mk @@ -87,6 +87,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libnss3.dylib \ $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libnssckbi.dylib \ $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libnssdbm3.dylib \ + $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libnsspem.dylib \ $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libnssutil3.dylib \ $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libplc4.dylib \ $(gb_Package_SOURCEDIR_nss)/dist/out/lib/libplds4.dylib \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 Mihkel Tõnnov mihh...@gmail.com changed: What|Removed |Added Depends on||46447 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 85486] Clean up unnecessary enumerations from xenum.hxx
https://bugs.freedesktop.org/show_bug.cgi?id=85486 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Ever confirmed|0 |1 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: icon-themes/galaxy icon-themes/human icon-themes/tango
dev/null |binary icon-themes/galaxy/cmd/lc_insertpagebreak.png|binary icon-themes/galaxy/cmd/sc_insertpagebreak.png|binary icon-themes/human/cmd/sc_spacepara1.xcf.bz2 |binary icon-themes/human/cmd/sc_spacepara15.xcf.bz2 |binary icon-themes/human/cmd/sc_spacepara2.xcf.bz2 |binary icon-themes/tango/cmd/lc_insertpagebreak.png |binary icon-themes/tango/cmd/lc_insertpagebreak.xcf.bz2 |binary icon-themes/tango/cmd/lc_spacepara.xcf.bz2 |binary icon-themes/tango/cmd/lc_spacepara1.png |binary icon-themes/tango/cmd/lc_spacepara15.png |binary icon-themes/tango/cmd/lc_spacepara2.png |binary icon-themes/tango/cmd/sc_insertannotation.png|binary icon-themes/tango/cmd/sc_insertannotation.xcf|binary icon-themes/tango/cmd/sc_insertfootnote.png |binary icon-themes/tango/cmd/sc_insertfootnote.xcf.bz2 |binary icon-themes/tango/cmd/sc_inserthyperlink.png |binary icon-themes/tango/cmd/sc_inserthyperlink.xcf.bz2 |binary icon-themes/tango/cmd/sc_insertpagebreak.png |binary icon-themes/tango/cmd/sc_insertpagebreak.xcf.bz2 |binary icon-themes/tango/cmd/sc_spacepara.xcf.bz2 |binary icon-themes/tango/cmd/sc_spacepara1.png |binary icon-themes/tango/cmd/sc_spacepara15.png |binary icon-themes/tango/cmd/sc_spacepara2.png |binary 24 files changed New commits: commit 14a2cfc27f86112469f2a2252bdc154ad8d3219f Author: Yousuf Philips philip...@hotmail.com Date: Tue Oct 28 08:44:25 2014 +0400 TANGO: add new icons for page break, line spacing, comment, and footnote Change-Id: I222c7df70543de344af73fbc3c8f7e8dae77b196 Reviewed-on: https://gerrit.libreoffice.org/12118 Reviewed-by: Matthew Francis mjay.fran...@gmail.com Tested-by: Matthew Francis mjay.fran...@gmail.com diff --git a/icon-themes/galaxy/cmd/lc_insertpagebreak.png b/icon-themes/galaxy/cmd/lc_insertpagebreak.png new file mode 100644 index 000..1efad71 Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_insertpagebreak.png differ diff --git a/icon-themes/galaxy/cmd/sc_insertpagebreak.png b/icon-themes/galaxy/cmd/sc_insertpagebreak.png new file mode 100644 index 000..cb99d32 Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_insertpagebreak.png differ diff --git a/icon-themes/tango/cmd/sc_spacepara1.xcf.bz2 b/icon-themes/human/cmd/sc_spacepara1.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/sc_spacepara1.xcf.bz2 rename to icon-themes/human/cmd/sc_spacepara1.xcf.bz2 diff --git a/icon-themes/tango/cmd/sc_spacepara15.xcf.bz2 b/icon-themes/human/cmd/sc_spacepara15.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/sc_spacepara15.xcf.bz2 rename to icon-themes/human/cmd/sc_spacepara15.xcf.bz2 diff --git a/icon-themes/tango/cmd/sc_spacepara2.xcf.bz2 b/icon-themes/human/cmd/sc_spacepara2.xcf.bz2 similarity index 100% rename from icon-themes/tango/cmd/sc_spacepara2.xcf.bz2 rename to icon-themes/human/cmd/sc_spacepara2.xcf.bz2 diff --git a/icon-themes/tango/cmd/lc_insertpagebreak.png b/icon-themes/tango/cmd/lc_insertpagebreak.png new file mode 100644 index 000..1efad71 Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertpagebreak.png differ diff --git a/icon-themes/tango/cmd/lc_insertpagebreak.xcf.bz2 b/icon-themes/tango/cmd/lc_insertpagebreak.xcf.bz2 new file mode 100644 index 000..83d2e29 Binary files /dev/null and b/icon-themes/tango/cmd/lc_insertpagebreak.xcf.bz2 differ diff --git a/icon-themes/tango/cmd/lc_spacepara.xcf.bz2 b/icon-themes/tango/cmd/lc_spacepara.xcf.bz2 new file mode 100644 index 000..da262d3 Binary files /dev/null and b/icon-themes/tango/cmd/lc_spacepara.xcf.bz2 differ diff --git a/icon-themes/tango/cmd/lc_spacepara1.png b/icon-themes/tango/cmd/lc_spacepara1.png index 7507658..c9b197b 100644 Binary files a/icon-themes/tango/cmd/lc_spacepara1.png and b/icon-themes/tango/cmd/lc_spacepara1.png differ diff --git a/icon-themes/tango/cmd/lc_spacepara15.png b/icon-themes/tango/cmd/lc_spacepara15.png index 8d1c67d..7282c16 100644 Binary files a/icon-themes/tango/cmd/lc_spacepara15.png and b/icon-themes/tango/cmd/lc_spacepara15.png differ diff --git a/icon-themes/tango/cmd/lc_spacepara2.png b/icon-themes/tango/cmd/lc_spacepara2.png index fe70d53..cb6dd0f 100644 Binary files a/icon-themes/tango/cmd/lc_spacepara2.png and b/icon-themes/tango/cmd/lc_spacepara2.png differ diff --git a/icon-themes/tango/cmd/sc_insertannotation.png b/icon-themes/tango/cmd/sc_insertannotation.png index 31bb6a6..5864cb4 100644 Binary files a/icon-themes/tango/cmd/sc_insertannotation.png and b/icon-themes/tango/cmd/sc_insertannotation.png differ diff --git a/icon-themes/tango/cmd/sc_insertannotation.xcf b/icon-themes/tango/cmd/sc_insertannotation.xcf new file mode 100644 index 000..ef28885 Binary files /dev/null and b/icon-themes/tango/cmd/sc_insertannotation.xcf differ diff --git
Re: [Libreoffice-qa] UNCONFIRMED bug count at 700
I'm slightly concerned that many of these are going into NEEDINFO with just a please test against latest release. I don't have the time to adequately check into this right now but if someone else could look. I've seen quite a few emails from FDO with these kinds of comments and this would go against current processes. We don't put things into NEEDINFO unless the instructions provided are unclear - it's our duty to check at least once before putting it into NEEDINFO. Best, Joel On 10/26/2014 10:34 PM, Tommy wrote: On Sat, 25 Oct 2014 16:59:16 +0200, Tommy ba...@quipo.it wrote: WOW!!! close to break another milestone... in this very moment the count is 700!!! who's gonna kick the next one? STATS: https://bugs.freedesktop.org/report.cgi?y_axis_field=bug_statusquery_format=report-tableproduct=LibreOfficeformat=tableaction=wrap CHART: https://bugs.freedesktop.org/buglist.cgi?action=wrapproduct=LibreOfficebug_status=UNCONFIRMEDlist_id=484606 right now 665 which is our new record (see chart) :-) let's keep triaging and get to 500 before Christmas. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] UNCONFIRMED bug count at 700
On Mon, 27 Oct 2014 08:06:24 +0100, Joel Madero jmadero@gmail.com wrote: I'm slightly concerned that many of these are going into NEEDINFO with just a please test against latest release. yes we should avoid that. I don't have the time to adequately check into this right now but if someone else could look. from this chart it seems that the drop in UNCONFIRMED in bigger that the increase of NEEDINFO so probably the stat improvement is not just of UNCONFIRMED - NEEDINFO status change https://bugs.freedesktop.org/reports.cgi?product=LibreOfficedatasets=UNCONFIRMEDdatasets=NEEDINFO I've seen quite a few emails from FDO with these kinds of comments and this would go against current processes. We don't put things into NEEDINFO unless the instructions provided are unclear - it's our duty to check at least once before putting it into NEEDINFO. Best, Joel I'll better take a look at it. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] new git bugzilla script
Hey, so I finally implemented a new git bugzilla script that should bring back the commit notifications in bugzilla for fixed bugs. As it is a complete new implementation you should report any problems as soon as possible. Especially in the beta and the RC phase. I used the old script as a guideline but there are some special portions in it that can only be tested between the first beta and the last RC. Otherwise the script provides nearly the same features as the old script plus it will now handle several bug references in the commit line correctly. So now fdo#12345 fdo#23456 will be handled correctly and both bugs will be updated. Regards, Markus ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
Hi, Le 23/10/2014 17:20, Michael Meeks a écrit : [...] * Pending Action Items: + get a clear use-case description of what doesn't work vs. master wrt. Calc sorting (JBF) First draft here: https://bugs.freedesktop.org/show_bug.cgi?id=85490 and https://bugs.freedesktop.org/attachment.cgi?id=108474 Comments are welcome :-) Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 85490] [METABUG] Use-Cases for sorting with references
https://bugs.freedesktop.org/show_bug.cgi?id=85490 --- Comment #4 from Joey Reid joeyisdama...@gmail.com --- Sorry if I was not clear. By the definition of absolute reference and by every spreadsheet's implementation, formulas with absolute references should always be adjusted when sorting. The fact that it's not sorting correctly with newer versions of Calc is unrelated to the issue of how the sorting of formulas with relative references should be handled. In the case of relative references, they should not be adjusted with the sort. The only time I have ever seen a spreadsheet with the option to adjust formulas, is with Gnumeric. And in that case, it is a sort option (not a system setting) and it is disabled by default. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 tommy27 ba...@quipo.it changed: What|Removed |Added Depends on||79395 --- Comment #225 from tommy27 ba...@quipo.it --- (In reply to chtfn from comment #224) Hi Kevin I just removed Bug 79395 as the 4.2 branch will not have any bugfix release anymore. not correct, the 4.2.x branch will have a new 4.2.7 update (the last) in a few days. then the official END-OF-LIFE is expected by 19 2014 see: https://wiki.documentfoundation.org/ReleasePlan#4.2_release I see it is reproducible in the 4.3 branch, so please nominate it as a 4.3 MAB on Bug 75025. Cheers! :) please do not mess things removing/adding MABs without knowing the exact procedures. that bug which is reproducible in 4.2.x has to stay in the mab4.2 list (I'm gonna put it back there) and will moved to the mab4.3 list only after the official EOL of the 4.2.x branch the mab4.2 to mab4.3 migration will be done by QA people by that time. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79395] Grid lines messed up when editing certain spreadsheet file
https://bugs.freedesktop.org/show_bug.cgi?id=79395 tommy27 ba...@quipo.it changed: What|Removed |Added Blocks||65675 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64966] FORMATTING: Incorrect envelope format
https://bugs.freedesktop.org/show_bug.cgi?id=64966 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #5 from tommy27 ba...@quipo.it --- for the record it would be nice to know the brand and model of the affected printers. actually there are multiple bugs with Brother and Canon printers -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52926] Format changes from #10 Envelope to User with different height, margin-top, and offset (Canon printers)
https://bugs.freedesktop.org/show_bug.cgi?id=52926 --- Comment #8 from tommy27 ba...@quipo.it --- this seems a Canon specific issue (added to summary notes) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77277] PRINTING: #10 Envelope changes to 6 x 9 envelope (Brother printers)
https://bugs.freedesktop.org/show_bug.cgi?id=77277 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Summary|PRINTING: #10 Envelope |PRINTING: #10 Envelope |changes to 6 x 9 envelope |changes to 6 x 9 envelope ||(Brother printers) Ever confirmed|0 |1 --- Comment #26 from tommy27 ba...@quipo.it --- this bug seems related to the use of a Brother printer (adding it to summary) @Marc Pare so do you reproduce the bug with a Brother printer but not with a Samsung printer, is that correct? @Chad Condon please define your printer brand and model -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #226 from chtfn stephane.guil...@gmail.com --- (In reply to tommy27 from comment #225) Hi Tommy. Thank you for checking. not correct, the 4.2.x branch will have a new 4.2.7 update (the last) in a few days. then the official END-OF-LIFE is expected by 19 2014 see: https://wiki.documentfoundation.org/ReleasePlan#4.2_release I assumed 4.2.7 was out already as (1) I already got a 4.2.7 update on Ubuntu a few days ago and (2) the release plan states that 4.2.7 should have been out by the 26th of October (yesterday). So I am sorry if in fact 4.2.7 is not officially out yet, I just had two good reasons to believe it was. please do not mess things removing/adding MABs without knowing the exact procedures. that bug which is reproducible in 4.2.x has to stay in the mab4.2 list (I'm gonna put it back there) and will moved to the mab4.3 list only after the official EOL of the 4.2.x branch the mab4.2 to mab4.3 migration will be done by QA people by that time. I am aware of the the exact procedures. I have participated in MAB transfers before. In the wiki, the following is written: If there are no further releases of a LibreOffice version (or “branch”; e.g., 3.5.x), we close the MAB tracking bug for that version, and move all remaining MAB listed for that version to the MAB tracking bug for the next version – you do not need to do that yourself. I assumed 4.2.7 was out, therefore I knew there was no further release for the 4.2 branch. I then asked Kevin to nominate that bug in 4.3 MAB as this is what should be done according to the wiki (no use of adding a MAB if no extra bugfix version is planned). This not me starting a migration, even though I think we should get cracking on that before the 4.2 EOL as MABs hanging out here after 4.2.7 will have no visibility at all (and, once again, it is what is recommended on the wiki). Thank you. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82087] FORMATTING: (Hyphenation) Paragraph Styles Text Flow Characters at line end lower limit is wrong for Greek language
https://bugs.freedesktop.org/show_bug.cgi?id=82087 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from Beluga todven...@suomi24.fi --- (In reply to Spiros Georgaras from comment #3) You can use any of the following for Modern Greek - http://www.eikonical.com/libregreek.oxt Link doesn't work. - http://extensions.openoffice.org/de/node/1411/releases This works. Yet, I can't get it to hyphenate anything at all. Hyphenation is set to automatic for the paragraph, but no words get hyphenated. Please, can someone else test? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85499] New: HiDPI: Moving a window to a non-retina display and back causes blurred text
https://bugs.freedesktop.org/show_bug.cgi?id=85499 Bug ID: 85499 Summary: HiDPI: Moving a window to a non-retina display and back causes blurred text Product: LibreOffice Version: 4.3.2.2 release Hardware: All OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ian...@gmail.com Hi, I have a retina macbook pro, and if I open a text document in LibreOffice 4.3.2 it opens with text rendered fine on a HiDPI display. BUT if I move that window across onto another (attached) LoDPI monitor and then back to my HiDPI display, the text becomes blurry. Other apps (or the underlying OS) switch just fine, but LibreOffice needs to be restarted to regain the HiDPI text rendering display... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #227 from tommy27 ba...@quipo.it --- sorry for sounding rude in the previous post. the 4.2.7 is not officially out yet but besides this I ask everybody here to hold on migrating mab4.2 to the mab4.3 list. It's better to wait a few weekes for the exact 4.2.x EOL to be sure that no critical issue pops out in the meantime and that no extra release will be necessary. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65675] LibreOffice 4.2 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=65675 --- Comment #228 from chtfn stephane.guil...@gmail.com --- (In reply to tommy27 from comment #227) sorry for sounding rude in the previous post. the 4.2.7 is not officially out yet but besides this I ask everybody here to hold on migrating mab4.2 to the mab4.3 list. It's better to wait a few weekes for the exact 4.2.x EOL to be sure that no critical issue pops out in the meantime and that no extra release will be necessary. No worries. Sure, that actually makes a lot of sense. It should be worded that way on the wiki to make it clear for everybody then, I am sure most QA people agree on that. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85500] New: TOOLBAR: Use insert page number icon for insert field control
https://bugs.freedesktop.org/show_bug.cgi?id=85500 Bug ID: 85500 Summary: TOOLBAR: Use insert page number icon for insert field control Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Is it is difficult to change the main control button to an insert page number so that it will reflect the insert page number icon, the workaround is to use the insert page number icon for it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81633] Sorting shouldn't always automatically adjust references.
https://bugs.freedesktop.org/show_bug.cgi?id=81633 --- Comment #58 from dmdcare...@care2.com --- Clearly the bug is still far from resolved and For me it is usable but it is a big change in the workflow which I was used to is unacceptable to me and, possibly, other users. The sorting should work without users having to sort in specific ways. There is, I believe, a strong case for removing the new functionality which has caused all these problems and for a considered approach to be taken the issue with it only being released when it works. I am hoping the developers have learned a lesson about releasing - let us not beat around the bush - half-baked functionality. The release of the new functionality which corrupted formulae by sorting was unacceptable. The time it is taking to fix the bug is also unacceptable. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85501] New: mab list test
https://bugs.freedesktop.org/show_bug.cgi?id=85501 Bug ID: 85501 Summary: mab list test Product: LibreOffice Version: 4.4.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Libreoffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@quipo.it this is a bugzilla test. please do not add new comments or change fields. 34467: FORMATTING Fit to Frame for text boxes is broken 34957: ODT containing multi-page table with table setting Keep with next paragraph is pushed to next page 36799: If you insert an envelope into a document only the envelope is printed (Mac OS X) 37223: Target for paste cells from column in Calc into TABLE will be single cell instead of column 37315: cropped pictures in .docx file are mangled and in wrong place 37960: Shift click to select multiple drawings does not work if picture there[Summary in Comment # 30] 40780: Impress Custom Animation Sound Effect not audible in Slide Show 40907: FILEOPEN: concurrent access to AFP shared files impossible - total lock on file 41169: All hotkeys are language dependent, don't work in non-Latin keyboard layout. 44621: EDITING: Drag and drop images into Writer opens Draw (OS X = 10.7) 44725: VIEWING: Heading - Footer - Pagebreak lines appear somewhere in the page 46635: FILESAVE Endless loop during autorecovery if format not writable 48409: FILEOPEN LibO 3.3 documents shows Writer OLE object contents shifted right / down in object after edit of object because of page border issue 49102: Writer: Incorrect numbering when cells are merged in the table 49853: EDITING: Attempting paste into find bar with Edit:Paste (or Cmd-V on OS X) pastes into document 50057: EDITING: Replication of frames when record changes (redlining) is on 50430: FILEOPEN: Can't Open .uop file 51550: FILESAVE as .docx looses embedded OLE objects 53228: [Task]: FILEOPEN .ods / .ots spreadsheet from former LibO version or OOo shows graphic elements at wrong position 53473: Embedded HSQLDB calls flush (CHECKPOINT) too often 54398: FILESAVE: DOC files created in LO lose drawings (anchored as character probably - and grouped?) after field update in MS Word 2007 54933: EDITING Report builder: mouse-move control: gap between mouse position 55018: FILESAVE and FILEOPEN: Joined cells in table cause table distortion after save to doc and docx and reopen in LO 56394: FILEOPEN - FILESAVE: very slow opening of .xlsx and freeze when saving 57215: Wrong text rotation in SVG Export (rotated text appears as non-rotated) 58691: PIVOTTABLE: export to Excel 2007/2010 breaks functionality 59613: RTL VIEWING: Increasing size of dialogs to right or bottom causes artifacts 59886: FILESAVE as .docx: Date (fixed), Time (fixed) fields become static field name text 59918: FILESAVE: FILEOPEN: save document as docx and reopen result in an freeze/endless loop 60268: FORMATTING: Square root and cdot are not correct displayed under Windows 8 60533: Brackets (..),{..},[..] inverted )..(,}..{,]..[ when switch to RTL text direction with all fonts (Affect : calc, impress, draw). 60589: [Template manager]: Can not copy styles between different files and templates 62073: editing/formatting: pasting formatted font messes up formatting of bullets 63483: UI: FILESAVE with 'Open file read-only' not offered in Draw and Impress 64490: LibO Writer text highligthing not compatible with MS Word DOC and DOCX (highlighting transforms to background color) 64945: inconvenient localized symbol code 66209: inserting/deleting rows: data integrity problem when sum of the charts of the opened documents exceeds the Options-Memory-Number of objects 66232: FILEOPEN: cannot open .odt files by clicking on a hyperlink in IE 67347: FILEOPEN: MS .pptx Textbox size imported wrong size 67379: Problems changing focus to inside frame 67534: FILEOPEN SMB File claimed to be Locked By Unknown User when opened via double-click in Explorer if LO Explorer Shell Extensions are installed 67712: form controls and draw objects anchored to cell but changes position after reopening 68604: FILESAVE: part of the comment text is lost in .docx using save toolbar button or save menu item 68806: SIDEBAR: Wrong Paragraph spacing values after activating the Properties pane 69495: FORMATTING: Toggling off bold/italic does not turn it off, but instead applies no-bold/no-italic. This messes up any style afterwards that has bold/italic in it (until Clear Direct Formatting is used). 69593: FILEOPEN: PPTX import with shapes causes text to disappear 70223: Chart not exported to PDF 70809: [EDITING] Selecting with mouse: too fast changing to
[Libreoffice-bugs] [Bug 85501] mab list test
https://bugs.freedesktop.org/show_bug.cgi?id=85501 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Version|4.4.0.0.alpha0+ Master |4.2.0.0.alpha0+ Master -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85501] mab list test
https://bugs.freedesktop.org/show_bug.cgi?id=85501 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85502] New: Maximum of iteration steps
https://bugs.freedesktop.org/show_bug.cgi?id=85502 Bug ID: 85502 Summary: Maximum of iteration steps Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Spreadsheet Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wolte...@gmail.com Currently there is a limit of 1000 iterations that LibreOffice Calc can go over when iteration is enabled (Options LibreOffice Calc Calculate). The user should be able to specify the maximum amount of iterations he considers reasonable for his hardware and or problem to solve. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84746] android: prune redundant configmgr settings
https://bugs.freedesktop.org/show_bug.cgi?id=84746 --- Comment #5 from Tor Lillqvist t...@iki.fi --- I figured out a problem in the mobile-config.py script: it calls remove() on a child of the root object while it is iterating the very same children. This s a bit like modifying an iterator that is being used in C++, and causes it to skip one child for each removed child. Thus failing to prune some stuff it was supposed to prune. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43213] Can not toggle bold in text containing 3 lines, 1 overlined, 1 not over/underlined, 1 underlined
https://bugs.freedesktop.org/show_bug.cgi?id=43213 KB_Pößneck ka...@web.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from KB_Pößneck ka...@web.de --- In LibO 4.2.6.2 ist das Problem behoben. Vielen Dank -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85502] Maximum of iteration steps
https://bugs.freedesktop.org/show_bug.cgi?id=85502 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85496] Read-error.Format error discovered in the file sub-document content.xml at 2, 217379
https://bugs.freedesktop.org/show_bug.cgi?id=85496 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||momonas...@gmail.com Ever confirmed|0 |1 --- Comment #2 from Maxim Monastirsky momonas...@gmail.com --- Hi, (In reply to SriJanani from comment #0) wherein file contents are not recoverable. We have to redo all the work and loosing productivity. Fortunately that's not the case. It's just a duplicate style:font-name attribute inside content.xml. You can unzip the file, fix content.xml by removing one of the duplicates (doable also with automated tools), and zip again. (In reply to SriJanani from comment #1) I have tried with different version of LO and PC. Also with profile recreation its not working. This won't help, because the bug is in the saving procedure, so the file is already corrupted and won't open as-is by any version. Instead we need to identify whether it is possible to *create* such broken files with the latest version. Now, looking at the attached file I see that you're created this file using 4.3.1.1, which is not the latest one (and BTW it's a pre-release version - and it's a bad idea to use pre-release in a production environment, exactly because such bugs that maybe there), so it's not clear if this bug is still there. So for now let's put this bug to NEEDINFO status, and if you'll have this bug again with files that are *saved* with the latest version, then add here a comment about it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85500] TOOLBAR: Use insert page number icon for insert field control
https://bugs.freedesktop.org/show_bug.cgi?id=85500 Jay Philips philip...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |philip...@hotmail.com |desktop.org | Ever confirmed|0 |1 --- Comment #1 from Jay Philips philip...@hotmail.com --- Patch put in for sifr, tango, crystal, and oxygen. https://gerrit.libreoffice.org/12107 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85441] Macro Recorder doesn't give working code for character border
https://bugs.freedesktop.org/show_bug.cgi?id=85441 --- Comment #2 from Sooraj Kenoth soorajken...@gmail.com --- (In reply to tommy27 from comment #1) please describe step by step which buttons or menus do you click while the macro recorder is activated. Selected the charecters first. Then, Tools-Record Macro, then Method 1 (Using Keyboard) Alt+o - Down Arrow(To select Charecter)- Entre Key - Tab button(to get control on tabs) -Side Arrow(to get border sub window) - ctrl+u - Down Arrow(to select Border) - Space Bar(To activate) - Enter Key Stop recording and save Method 2(Using Mouse) Selected the charecters first. Then, Tools-Record Macro, then Right Click - select charecter - select boeder tab - select the border type - ok Stop recording and save Both method gave same result. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84626] Cannot handle sound since upgrade
https://bugs.freedesktop.org/show_bug.cgi?id=84626 --- Comment #6 from Andrew Allcock ajallc...@yahoo.com --- Having upgraded to Ubunto 14.10 the problem is still there. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84626] Cannot handle sound since upgrade
https://bugs.freedesktop.org/show_bug.cgi?id=84626 --- Comment #7 from Andrew Allcock ajallc...@yahoo.com --- (In reply to Andrew Allcock from comment #3) Created attachment 107405 [details] Sample presentation displaying behaviour as described Files I have been trying to use are .ogg files. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81883] Macros: Libreoffice crash on exit
https://bugs.freedesktop.org/show_bug.cgi?id=81883 --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- Created attachment 108499 -- https://bugs.freedesktop.org/attachment.cgi?id=108499action=edit Linux 4.4 master backtrace I take the above back, I did eventually manage to get the attached crash on 4.4 master - it looks completely different, so the two issues may be unrelated -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85501] mab list test
https://bugs.freedesktop.org/show_bug.cgi?id=85501 --- Comment #1 from tommy27 ba...@quipo.it --- Bug 34467: FORMATTING Fit to Frame for text boxes is broken Bug 34957: ODT containing multi-page table with table setting Keep with next paragraph is pushed to next page Bug 36799: If you insert an envelope into a document only the envelope is printed (Mac OS X) Bug 37223: Target for paste cells from column in Calc into TABLE will be single cell instead of column Bug 37315: cropped pictures in .docx file are mangled and in wrong place Bug 37960: Shift click to select multiple drawings does not work if picture there[Summary in Comment # 30] Bug 40780: Impress Custom Animation Sound Effect not audible in Slide Show Bug 40907: FILEOPEN: concurrent access to AFP shared files impossible - total lock on file Bug 41169: All hotkeys are language dependent, don't work in non-Latin keyboard layout. Bug 44621: EDITING: Drag and drop images into Writer opens Draw (OS X = 10.7) Bug 44725: VIEWING: Heading - Footer - Pagebreak lines appear somewhere in the page Bug 46635: FILESAVE Endless loop during autorecovery if format not writable Bug 48409: FILEOPEN LibO 3.3 documents shows Writer OLE object contents shifted right / down in object after edit of object because of page border issue Bug 49102: Writer: Incorrect numbering when cells are merged in the table Bug 49853: EDITING: Attempting paste into find bar with Edit:Paste (or Cmd-V on OS X) pastes into document Bug 50057: EDITING: Replication of frames when record changes (redlining) is on Bug 50430: FILEOPEN: Can't Open .uop file Bug 51550: FILESAVE as .docx looses embedded OLE objects Bug 53228: [Task]: FILEOPEN .ods / .ots spreadsheet from former LibO version or OOo shows graphic elements at wrong position Bug 53473: Embedded HSQLDB calls flush (CHECKPOINT) too often Bug 54398: FILESAVE: DOC files created in LO lose drawings (anchored as character probably - and grouped?) after field update in MS Word 2007 Bug 54933: EDITING Report builder: mouse-move control: gap between mouse position Bug 55018: FILESAVE and FILEOPEN: Joined cells in table cause table distortion after save to doc and docx and reopen in LO Bug 56394: FILEOPEN - FILESAVE: very slow opening of .xlsx and freeze when saving Bug 57215: Wrong text rotation in SVG Export (rotated text appears as non-rotated) Bug 58691: PIVOTTABLE: export to Excel 2007/2010 breaks functionality Bug 59613: RTL VIEWING: Increasing size of dialogs to right or bottom causes artifacts Bug 59886: FILESAVE as .docx: Date (fixed), Time (fixed) fields become static field name text Bug 59918: FILESAVE: FILEOPEN: save document as docx and reopen result in an freeze/endless loop Bug 60268: FORMATTING: Square root and cdot are not correct displayed under Windows 8 Bug 60533: Brackets (..),{..},[..] inverted )..(,}..{,]..[ when switch to RTL text direction with all fonts (Affect : calc, impress, draw). Bug 60589: [Template manager]: Can not copy styles between different files and templates Bug 62073: editing/formatting: pasting formatted font messes up formatting of bullets Bug 63483: UI: FILESAVE with 'Open file read-only' not offered in Draw and Impress Bug 64490: LibO Writer text highligthing not compatible with MS Word DOC and DOCX (highlighting transforms to background color) Bug 64945: inconvenient localized symbol code Bug 66209: inserting/deleting rows: data integrity problem when sum of the charts of the opened documents exceeds the Options-Memory-Number of objects Bug 66232: FILEOPEN: cannot open .odt files by clicking on a hyperlink in IE Bug 67347: FILEOPEN: MS .pptx Textbox size imported wrong size Bug 67379: Problems changing focus to inside frame Bug 67534: FILEOPEN SMB File claimed to be Locked By Unknown User when opened via double-click in Explorer if LO Explorer Shell Extensions are installed Bug 67712: form controls and draw objects anchored to cell but changes position after reopening Bug 68604: FILESAVE: part of the comment text is lost in .docx using save toolbar button or save menu item Bug 68806: SIDEBAR: Wrong Paragraph spacing values after activating the Properties pane Bug 69495: FORMATTING: Toggling off bold/italic does not turn it off, but instead applies no-bold/no-italic. This messes up any style afterwards that has bold/italic in it (until Clear Direct Formatting is used). Bug 69593: FILEOPEN: PPTX import with shapes causes text to disappear Bug 70223: Chart not exported to PDF Bug 70809: [EDITING] Selecting with mouse: too fast changing to next/previous page Bug 71278: UI mouse pointer disappears during presentation and does not come back after exiting presentation Bug 71409: Excessive duplicate accessible focused events for Calc input line [a11y] Bug 72072: text not rendered fully (cut off) when editing 90deg rotated rectangle Bug 72075: EDITING: undo leads to duplication for operations that involve of
[Libreoffice-bugs] [Bug 82087] FORMATTING: (Hyphenation) Paragraph Styles Text Flow Characters at line end lower limit is wrong for Greek language
https://bugs.freedesktop.org/show_bug.cgi?id=82087 --- Comment #6 from Spiros Georgaras s...@hellug.gr --- (In reply to Beluga from comment #5) (In reply to Spiros Georgaras from comment #3) You can use any of the following for Modern Greek - http://www.eikonical.com/libregreek.oxt Link doesn't work. I just uploaded it on my hellug account. You can get it from here: - http://members.hellug.gr/sng/libregreek.oxt -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70753] FILESAVE: PDF export via intern PDF export option checks all check boxes despite them being unchecked in writer document
https://bugs.freedesktop.org/show_bug.cgi?id=70753 foss f...@openmailbox.org changed: What|Removed |Added Attachment #87972|f...@openmailbox.org|test file description|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85056] Writer crash after copy paste specific text
https://bugs.freedesktop.org/show_bug.cgi?id=85056 --- Comment #11 from grofaty grof...@hotmail.com --- @tommy27, it looks like to me. The problem appeared after installing LibreOffice 4.3.2.2 over 4.2.6.2, but I have done such a migration many many times. So it also could be some left over from any other previous migration. Final point is uninstalling and manually deleting left overs and installing 4.3.2.2 again solves the problem. But you never know, maybe some other product on my PC has corrupted some Python variable or something similar and LibreOffice stopped working. Maybe I should install 4.3.2.2 over existing 4.3.2.2 (the same version), but I haven't tried that and I don't have exact environment anymore (I have deleted virtual machines, because I have found work-around for the problem). @oscar valenzuela, I am not sure about OSX, but if I am not mistaken, Python is only embed in LibreOffice for Windows. On Linux it is used default package already installed on Linux distribution. I am not sure about OSX. So in my humble opinion the only relevant test is Windows, because LibreOffice install has some specifics about Python embed install. I hope I am not mistaken, this is as far as I remember reading some LibreOffice document few months ago. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84746] android: prune redundant configmgr settings
https://bugs.freedesktop.org/show_bug.cgi?id=84746 --- Comment #6 from Tor Lillqvist t...@iki.fi --- Now then the loading of the document just silently fails again. After some debugging it seems to be caused by an attempt to get the configured application background colour, or something... Exceptions are fun. #0 0x6d39b0d4 in __cxa_throw () from /home/tml/lo/android-calcimpress3/android/experimental/LOAndroid3/obj/local/armeabi-v7a/liblo-native-code.so #1 0x6902a518 in configmgr::RootAccess::getNode() () at /home/tml/lo/android-calcimpress3/configmgr/source/rootaccess.cxx:224 #2 0x6904525e in configmgr::Access::isValue() () at /home/tml/lo/android-calcimpress3/configmgr/source/access.cxx:114 #3 0x69013176 in configmgr::configuration_provider::(anonymous namespace)::Service::createInstanceWithArguments(rtl::OUString const, com::sun::star::uno::Sequencecom::sun::star::uno::Any const) () at /home/tml/lo/android-calcimpress3/configmgr/source/configurationprovider.cxx:273 #4 0x6bfc3fea in utl::ConfigManager::acquireTree(utl::ConfigItem) () at /home/tml/lo/android-calcimpress3/unotools/source/config/configmgr.cxx:161 #5 0x6bfc419c in utl::ConfigManager::addConfigItem(utl::ConfigItem) () at /home/tml/lo/android-calcimpress3/unotools/source/config/configmgr.cxx:174 #6 0x6bfc0008 in utl::ConfigItem::ConfigItem(rtl::OUString const, short) () at /home/tml/lo/android-calcimpress3/unotools/source/config/configitem.cxx:177 #7 0x6ae1fcb4 in svtools::ColorConfig_Impl::ColorConfig_Impl(bool) () at /home/tml/lo/android-calcimpress3/svtools/source/config/colorcfg.cxx:192 #8 0x6ae20770 in svtools::ColorConfig::ColorConfig() () at /home/tml/lo/android-calcimpress3/svtools/source/config/colorcfg.cxx:397 #9 0x693a5bfa in (anonymous namespace)::TaskCreatorService::implts_createContainerWindow(com::sun::star::uno::Referencecom::sun::star::awt::XWindow const, com::sun::star::awt::Rectangle const, bool) () at /home/tml/lo/android-calcimpress3/framework/source/services/taskcreatorsrv.cxx:276 #10 0x693a56d0 in (anonymous namespace)::TaskCreatorService::createInstanceWithArguments(com::sun::star::uno::Sequencecom::sun::star::uno::Any const) () at /home/tml/lo/android-calcimpress3/framework/source/services/taskcreatorsrv.cxx:167 #11 0x693efc6c in framework::TaskCreator::createTask(rtl::OUString const, bool) () at /home/tml/lo/android-calcimpress3/framework/source/classes/taskcreator.cxx:114 #12 0x69382016 in framework::Desktop::findFrame(rtl::OUString const, long) () at /home/tml/lo/android-calcimpress3/framework/source/services/desktop.cxx:921 #13 0x69410d48 in framework::LoadEnv::impl_loadContent() () at /home/tml/lo/android-calcimpress3/framework/source/loadenv/loadenv.cxx:1029 #14 0x6940e98c in framework::LoadEnv::startLoading() () at /home/tml/lo/android-calcimpress3/framework/source/loadenv/loadenv.cxx:383 #15 0x6940dc94 in framework::LoadEnv::loadComponentFromURL(com::sun::star::uno::Referencecom::sun::star::frame::XComponentLoader const, com::sun::star::uno::Referencecom::sun::star::uno::XComponentContext const, rtl::OUString const, rtl::OUString const, long, com::sun::star::uno::Sequencecom::sun::star::beans::PropertyValue const) () at /home/tml/lo/android-calcimpress3/framework/source/loadenv/loadenv.cxx:164 #16 0x6938162e in framework::Desktop::loadComponentFromURL(rtl::OUString const, rtl::OUString const, long, com::sun::star::uno::Sequencecom::sun::star::beans::PropertyValue const) () at /home/tml/lo/android-calcimpress3/framework/source/services/desktop.cxx:567 #17 0x6ac92bc6 in lo_documentLoad () at /home/tml/lo/android-calcimpress3/desktop/source/lib/init.cxx:306 #18 0x6ac95390 in Java_org_libreoffice_kit_Office_documentLoadNative () at /home/tml/lo/android-calcimpress3/desktop/source/lib/lokandroid.cxx:82 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 70753] FILESAVE: PDF export via intern PDF export option checks all check boxes despite them being unchecked in writer document
https://bugs.freedesktop.org/show_bug.cgi?id=70753 --- Comment #5 from foss f...@openmailbox.org --- 4.3.3.1 persisting. can't test 4.4 nightly because it crashes like crazy on 10.10 for me. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82087] FORMATTING: (Hyphenation) Paragraph Styles Text Flow Characters at line end lower limit is wrong for Greek language
https://bugs.freedesktop.org/show_bug.cgi?id=82087 --- Comment #7 from Beluga todven...@suomi24.fi --- Created attachment 108501 -- https://bugs.freedesktop.org/attachment.cgi?id=108501action=edit Screenshot of LO 4.3.2.2, auto hyphenation with libregreek.oxt Thanks! That libregreek.oxt did the trick and I got hyphenation working. I confirm the behavior you described. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85509] New: word in table of contents stays as grammically false, when changing the language of a word
https://bugs.freedesktop.org/show_bug.cgi?id=85509 Bug ID: 85509 Summary: word in table of contents stays as grammically false, when changing the language of a word Product: LibreOffice Version: 4.2.5.2 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Linguistic Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sno...@ilnet.ch The table of contents or directory or index of a document (which is the right word in this case?) shows gramatical misspelled words also with an underline as the word in the text. This behavior semms to be wrong for me, because this word is only a reference to the original word and it's the source of the described error. I'm writing a document in german, but some words are english. Because of this, I change the language of this words to english. The problem is, that the index of the document isn't actualised and can't be changed. Because of this, the word stays there as misspelled. I add an attachement to show the problem. Sincerely, Markus -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs