Re: master build fails in calcoptionsdlg.cxx
Hi, Le 06/11/2014 15:05, Jean-Baptiste Faure a écrit : Hi, I get a compilation error here: .../LibO/master/sc/source/ui/optdlg/calcoptionsdlg.cxx: In member function ‘void ScCalcOptionsDialog::SelectionChanged()’: .../LibO/master/sc/source/ui/optdlg/calcoptionsdlg.cxx:597:66: error: ‘fillListBox’ was not declared in this scope fillListBox(mpListBox, maConfig.maOpenCLWhiteList); ^ .../LibO/master/sc/source/ui/optdlg/calcoptionsdlg.cxx:602:66: error: ‘fillListBox’ was not declared in this scope fillListBox(mpListBox, maConfig.maOpenCLBlackList); I guess it comes from this commit: https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=97a74ee6b86532ac9c1f5c4b2d0d0a557e5ddb59 because it seems to be the last in which calcoptionsdlg.cxx was modified The error seems to come from my build option --disable-opencl in my autogen.input. I tried a blind fix, I enclosed the code block lines 582-605 between #if HAVE_FEATURE_OPENCL and #endif It worked, but I am not able to say if it is the correct fix. Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: master build fails in calcoptionsdlg.cxx
The error seems to come from my build option --disable-opencl in my autogen.input. Yeah; —disable-opencl is not a good idea in master right now. I will fix it eventually. —tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: svx/source
svx/source/tbxctrls/SvxColorValueSet.cxx | 21 +
svx/source/tbxctrls/tbcontrl.cxx |1 +
2 files changed, 10 insertions(+), 12 deletions(-)
New commits:
commit 8923bf821cab049e8f82380450b2440d5e146c7c
Author: Juergen Funk juergen.funk...@cib.de
Date: Fri Nov 7 10:09:07 2014 +0100
Fix fdo#84574 - COLOR PICKER: Palette color list should have scrollbar
Change-Id: Ib927d3e1b1349f9a1b5f575180d217fe31f1f11f
Reviewed-on: https://gerrit.libreoffice.org/12296
Reviewed-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
Tested-by: Samuel Mehrbrodt s.mehrbr...@gmail.com
diff --git a/svx/source/tbxctrls/SvxColorValueSet.cxx
b/svx/source/tbxctrls/SvxColorValueSet.cxx
index 4085912..11e90ed 100644
--- a/svx/source/tbxctrls/SvxColorValueSet.cxx
+++ b/svx/source/tbxctrls/SvxColorValueSet.cxx
@@ -162,22 +162,19 @@ Size SvxColorValueSet::layoutToGivenHeight(sal_uInt32
nHeight, sal_uInt32 nEntry
SetStyle(aWinBits);
Size aNewSize(CalcWindowSizePixel(aItemSize, getColumnCount()));
-// evtl. activate vertical scroll
-const bool bAdaptHeight(static_cast sal_uInt32 (aNewSize.Height())
nHeight);
-
-if(bAdaptHeight)
-{
-SetStyle(aWinBits|WB_VSCROLL);
-aNewSize = CalcWindowSizePixel(aItemSize, getColumnCount());
-}
-
+const Size aItemSizePixel(CalcItemSizePixel(aItemSize));
// calculate field height and available height for requested height
const sal_uInt32 nFieldHeight(aNewSize.Height() -
aSizeNoScrollNoFields.Height());
-const sal_uInt32 nAvailableHeight(nHeight = nFieldHeight ? nHeight -
nFieldHeight : 0);
+const sal_uInt32 nAvailableHeight(nHeight = nFieldHeight ? nHeight -
nFieldHeight + aItemSizePixel.Height() - 1 : 0);
// calculate how many lines can be shown there
-const Size aItemSizePixel(CalcItemSizePixel(aItemSize));
-const sal_uInt32 nLineCount((nAvailableHeight + aItemSizePixel.Height() -
1) / aItemSizePixel.Height());
+const sal_uInt32 nLineCount(nAvailableHeight / aItemSizePixel.Height());
+const sal_uInt32 nLineMax(ceil(double(nEntryCount)/getColumnCount()));
+
+if(nLineMax nLineCount)
+{
+SetStyle(aWinBits|WB_VSCROLL);
+}
// set height to wanted height
aNewSize.Height() = nHeight;
diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index e5b0d1a..a0a9649 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1270,6 +1270,7 @@ IMPL_LINK_NOARG(SvxColorWindow_Impl, SelectPaletteHdl)
sal_Int32 nPos = mpPaletteListBox-GetSelectEntryPos();
mrPaletteManager.SetPalette( nPos );
mrPaletteManager.ReloadColorSet(*mpColorSet);
+mpColorSet-layoutToGivenHeight(mpColorSet-GetSizePixel().Height(),
mrPaletteManager.GetColorCount());
return 0;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl svl/source unusedcode.easy
include/svl/zforlist.hxx| 10 ---
include/svl/zformat.hxx |6
svl/source/numbers/zforlist.cxx | 57
svl/source/numbers/zformat.cxx | 20 --
unusedcode.easy |1
5 files changed, 94 deletions(-)
New commits:
commit 8b8b0dfa1ce9015f0514feaa64234831972a5f1d
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 09:17:46 2014 +
callcatcher: number format serialization cleanup fallout
Change-Id: Ib5b5f653b027bfe5c05c0db417a2aa713309d9a5
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index bd3c0de..2ce4730 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -295,12 +295,6 @@ public:
sal_uInt16 nCurrFormat,
bool bBank );
static sal_uInt16 GetEffectiveNegativeFormat( sal_uInt16 nIntlFormat,
sal_uInt16 nCurrFormat,
bool bBank );
-
-/// General Unicode Euro symbol
-static inline sal_Unicode GetEuroSymbol() { return sal_Unicode(0x20AC); }
-/** Platform and CharSet dependent Euro symbol,
- needed for import/export */
-static sal_CharGetEuroSymbol( rtl_TextEncoding eTextEncoding );
};
typedef boost::ptr_vectorNfCurrencyEntry NfCurrencyTable;
@@ -809,10 +803,6 @@ private:
// called by ctors
SVL_DLLPRIVATE void ImpConstruct( LanguageType eLang );
-// Changes initialized language/country, clears the entries and generates
-// new ones, may ONLY be called by the binary file format load
-SVL_DLLPRIVATE void ImpChangeSysCL( LanguageType eLnge, bool
bNoAdditionalFormats );
-
// Generate builtin formats provided by i18n behind CLOffset,
// if bNoAdditionalFormats==false also generate additional i18n formats.
SVL_DLLPRIVATE void ImpGenerateFormats( sal_uInt32 CLOffset, bool
bNoAdditionalFormats );
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index b488647..00b1aa6 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -163,9 +163,6 @@ class SVL_DLLPUBLIC SvNumberformat
};
public:
-// Ctor for Load
-SvNumberformat( ImpSvNumberformatScan rSc, LanguageType eLge );
-
// Normal ctor
SvNumberformat( OUString rString,
ImpSvNumberformatScan* pSc,
@@ -313,9 +310,6 @@ public:
// Whether a new SYMBOLTYPE_CURRENCY is contained in the format
bool HasNewCurrency() const;
-// Build string from NewCurrency for saving it SO50 compatible
-void Build50Formatstring( OUString rStr ) const;
-
// strip [$-yyy] from all [$xxx-yyy] leaving only xxx's,
// if bQuoteSymbol==true the xxx will become xxx
static OUString StripNewCurrencyDelimiters( const OUString rStr,
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 5363d6a..b7885f8 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -348,40 +348,6 @@ sal_uInt16 SvNumberFormatter::GetStandardPrec()
return pFormatScanner-GetStandardPrec();
}
-void SvNumberFormatter::ImpChangeSysCL( LanguageType eLnge, bool
bNoAdditionalFormats )
-{
-if (eLnge == LANGUAGE_DONTKNOW)
-{
-eLnge = UNKNOWN_SUBSTITUTE;
-}
-if (eLnge != IniLnge)
-{
-IniLnge = eLnge;
-ChangeIntl(eLnge);
-// delete old formats
-for (SvNumberFormatTable::iterator it = aFTable.begin(); it !=
aFTable.end(); ++it)
-{
-delete it-second;
-}
-aFTable.clear();
-ImpGenerateFormats( 0, bNoAdditionalFormats ); // new standard
formats
-}
-else if ( bNoAdditionalFormats )
-{
-// delete additional standard formats
-sal_uInt32 nKey;
-SvNumberFormatTable::iterator it = aFTable.find(
SV_MAX_ANZ_STANDARD_FORMATE + 1 );
-while ( it != aFTable.end()
-(nKey = it-first) SV_MAX_ANZ_STANDARD_FORMATE
-nKey SV_COUNTRY_LANGUAGE_OFFSET )
-{
-delete it-second;
-aFTable.erase( it++ );
-}
-}
-}
-
-
void SvNumberFormatter::ReplaceSystemCL( LanguageType eOldLanguage )
{
sal_uInt32 nCLOffset = ImpGetCLOffset( LANGUAGE_SYSTEM );
@@ -4258,27 +4224,4 @@ sal_uInt16 NfCurrencyEntry::GetEffectiveNegativeFormat(
sal_uInt16 nIntlFormat,
return nIntlFormat;
}
-
-// we only support default encodings here
-// static
-sal_Char NfCurrencyEntry::GetEuroSymbol( rtl_TextEncoding eTextEncoding )
-{
-switch ( eTextEncoding )
-{
-case RTL_TEXTENCODING_MS_1252 :
-case RTL_TEXTENCODING_ISO_8859_1 :
-return '\x80';
-case RTL_TEXTENCODING_ISO_8859_15 :
-return '\xA4';
-case RTL_TEXTENCODING_IBM_850 :
-return '\xD5';
-case RTL_TEXTENCODING_APPLE_ROMAN :
-return '\xDB';
-default:
-return
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport4.cxx|2 +-
sw/qa/extras/ooxmlimport/data/tcw-rounding.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx |6 ++
writerfilter/source/dmapper/DomainMapperTableManager.cxx |4 ++--
4 files changed, 9 insertions(+), 3 deletions(-)
New commits:
commit 29cbbad64088354425c606f9eb6c267bdf7731dc
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Nov 7 10:13:08 2014 +0100
DOCX import: fix rounding error in table cell widths
Change-Id: I733fd4b998ba4d0bde2f91f2b3d76205f0dc8020
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
index 3a8502b..e187959 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport4.cxx
@@ -295,7 +295,7 @@ DECLARE_OOXMLEXPORT_TEST(testSegFaultWhileSave,
test_segfault_while_save.docx)
xmlDocPtr pXmlDoc = parseExport(word/document.xml);
if (!pXmlDoc)
return;
-CPPUNIT_ASSERT(getXPath(pXmlDoc,
/w:document/w:body/w:tbl/w:tblGrid/w:gridCol[2], w).match(6138));
+CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(6137), getXPath(pXmlDoc,
/w:document/w:body/w:tbl/w:tblGrid/w:gridCol[2], w).toInt32());
}
DECLARE_OOXMLEXPORT_TEST(fdo69656, Table_cell_auto_width_fdo69656.docx)
diff --git a/sw/qa/extras/ooxmlimport/data/tcw-rounding.docx
b/sw/qa/extras/ooxmlimport/data/tcw-rounding.docx
new file mode 100644
index 000..d4055c9
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tcw-rounding.docx
differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index d4d1766..3a541ad 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -2391,6 +2391,12 @@ static OString dateTimeToString( const util::DateTime
dt )
return DateTimeToOString( DateTime( Date( dt.Day, dt.Month, dt.Year ),
tools::Time( dt.Hours, dt.Minutes, dt.Seconds )));
}
+DECLARE_OOXMLIMPORT_TEST(testTcwRounding, tcw-rounding.docx)
+{
+// Width of the A1 cell in twips was 3200, due to a rounding error.
+CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(3201),
parseDump(/root/page/body/tab/row/cell[1]/infos/bounds, width).toInt32());
+}
+
DECLARE_OOXMLIMPORT_TEST(testBnc821804, bnc821804.docx)
{
CPPUNIT_ASSERT_EQUAL( OUString( TITLE ), getRun( getParagraph( 1 ), 1
)-getString());
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index 0caba65..15f4397 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -34,6 +34,7 @@
#include ooxml/resourceids.hxx
#include dmapperLoggers.hxx
#include dmapper/DomainMapper.hxx
+#include rtl/math.hxx
namespace writerfilter {
namespace dmapper {
@@ -745,8 +746,7 @@ void DomainMapperTableManager::endOfRowAction()
for ( sal_Int32 nGridCount = *aSpansIter; nGridCount 0;
--nGridCount )
fGridWidth += (*pTableGrid.get())[nBorderGridIndex++];
-sal_Int16 nRelPos =
-sal::static_int_cast sal_Int16 ((fGridWidth * 1) /
nFullWidthRelative);
+sal_Int16 nRelPos = rtl::math::round((fGridWidth * 1) /
nFullWidthRelative);
pSeparators[nBorder].Position = nRelPos + nLastRelPos;
pSeparators[nBorder].IsVisible = sal_True;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl
include/svl/zforlist.hxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 19bba5545358421d8b86d8978261059c9426678e
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 09:29:34 2014 +
still need one of the variants
Change-Id: I4639fb32c1dfc115bc33ce071fc3440138605362
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index 2ce4730..d2573a0 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -952,6 +952,8 @@ public:
// return the corresponding date separator
inline const OUString GetDateSep() const { return aDateSep; }
+/// General Unicode Euro symbol
+static inline sal_Unicode GetEuroSymbol() { return sal_Unicode(0x20AC); }
};
inline sal_uInt32 SvNumberFormatter::GetMergeFmtIndex( sal_uInt32 nOldFmt )
const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl
include/svl/zforlist.hxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit ccef581c42d2c6fd30a5804657f6d23e001daa66
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 09:35:51 2014 +
wrong place I guess
Change-Id: I56d18dec48ab637ed3d818f4dd757c6f873b
diff --git a/include/svl/zforlist.hxx b/include/svl/zforlist.hxx
index d2573a0..092ccd6 100644
--- a/include/svl/zforlist.hxx
+++ b/include/svl/zforlist.hxx
@@ -295,6 +295,9 @@ public:
sal_uInt16 nCurrFormat,
bool bBank );
static sal_uInt16 GetEffectiveNegativeFormat( sal_uInt16 nIntlFormat,
sal_uInt16 nCurrFormat,
bool bBank );
+
+/// General Unicode Euro symbol
+static inline sal_Unicode GetEuroSymbol() { return sal_Unicode(0x20AC); }
};
typedef boost::ptr_vectorNfCurrencyEntry NfCurrencyTable;
@@ -951,9 +954,6 @@ public:
// return the corresponding date separator
inline const OUString GetDateSep() const { return aDateSep; }
-
-/// General Unicode Euro symbol
-static inline sal_Unicode GetEuroSymbol() { return sal_Unicode(0x20AC); }
};
inline sal_uInt32 SvNumberFormatter::GetMergeFmtIndex( sal_uInt32 nOldFmt )
const
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 35 commits - filter/source include/svtools include/svx include/vcl oox/source sc/CppunitTest_sc_subsequent_export_test.mk sc/qa sd/CppunitTest_sd_export_tests.mk sd/qa
filter/source/msfilter/msdffimp.cxx |2 include/svtools/grfmgr.hxx | 16 - include/svx/svdograf.hxx|3 include/svx/svdpage.hxx | 17 - include/svx/svdundo.hxx |3 include/vcl/graph.hxx |4 oox/source/export/drawingml.cxx | 16 - sc/CppunitTest_sc_subsequent_export_test.mk |4 sc/qa/unit/data/ods/document_with_two_images.ods|binary sc/qa/unit/subsequent_export-test.cxx | 86 +++ sd/CppunitTest_sd_export_tests.mk |4 sd/qa/unit/data/odp/document_with_two_images.odp|binary sd/qa/unit/data/xml/fdo64586_0.xml |4 sd/qa/unit/data/xml/n758621_0.xml |4 sd/qa/unit/data/xml/n758621_1.xml |4 sd/qa/unit/data/xml/n819614_0.xml |2 sd/qa/unit/export-tests.cxx | 90 +++ svtools/README | 15 - svtools/source/graphic/grfmgr.cxx | 141 ++-- svtools/source/graphic/grfmgr2.cxx | 51 +--- svx/source/sdr/contact/viewobjectcontactofgraphic.cxx | 13 - svx/source/svdraw/svdograf.cxx |8 svx/source/svdraw/svdpage.cxx | 34 -- svx/source/svdraw/svdundo.cxx | 28 -- svx/source/unodraw/unoshap2.cxx | 10 sw/CppunitTest_sw_globalfilter.mk | 94 sw/Module_sw.mk |1 sw/inc/ndgrf.hxx|7 sw/inc/ndole.hxx|1 sw/qa/extras/globalfilter/data/document_with_two_images.odt |binary sw/qa/extras/globalfilter/globalfilter.cxx | 130 +++ sw/source/core/doc/notxtfrm.cxx | 30 -- sw/source/core/docnode/ndnotxt.cxx |3 sw/source/core/edit/editsh.cxx | 33 -- sw/source/core/frmedt/fefly1.cxx|3 sw/source/core/graphic/ndgrf.cxx| 54 ++-- sw/source/core/layout/paintfrm.cxx | 21 - sw/source/core/ole/ndole.cxx|5 sw/source/core/undo/unins.cxx |3 sw/source/core/unocore/unoframe.cxx | 19 - sw/source/filter/html/htmlgrin.cxx | 10 sw/source/filter/inc/msfilter.hxx | 21 - sw/source/filter/ww8/docxattributeoutput.cxx| 15 - sw/source/filter/ww8/rtfattributeoutput.cxx | 14 - sw/source/filter/ww8/writerhelper.cxx | 25 -- sw/source/filter/ww8/wrtw8esh.cxx |2 sw/source/filter/ww8/wrtww8gr.cxx |6 sw/source/filter/xml/xmltexte.cxx |4 vcl/inc/impgraph.hxx|1 vcl/source/gdi/cvtgrf.cxx |2 vcl/source/gdi/graph.cxx|6 vcl/source/gdi/impgraph.cxx | 13 - 52 files changed, 552 insertions(+), 530 deletions(-) New commits: commit 250bd093509fb99afa59d8d4290b8a996a0962c6 Author: Zolnai Tamás tamas.zol...@collabora.com Date: Fri Nov 7 10:09:24 2014 +0100 Update notes about swapping Change-Id: I6b9f5f9c4a0bc87376a469835a50dc2cf598479e diff --git a/svtools/README b/svtools/README index b4f399c..dbcc30b 100644 --- a/svtools/README +++ b/svtools/README @@ -3,13 +3,14 @@ Tools on top of VCL. Common dialogs, file and print dialogs, wizards, vcl filter == Image swapping == -LO has three kind of swapout mechanisms: +LO has two kind of swapout mechanisms: -1) Manual swap out calls: Maybe it comes from old days, when memory was more expensive to use so LO tried to store -images in the memory only when it is really used and swap out them directly after use. These manual calls seems -useless nowadays and even ineffective. - -2) Size based auto swapping: when the size of all graphic objects reaches a configurable limit (20 MB by default) +1) Size based auto swapping: when the size of all graphic objects reaches a configurable limit (20 MB by default) then some of the graphics are saved to the local file system and freed in the memory. +Configure: Tools - Options - Memory - GraphicsCache - Use for LibreOffice + +2) Time based auto swapping: after an
[Libreoffice-commits] core.git: wizards/source
wizards/source/euro/AutoPilotRun.xba | 16 1 file changed, 8 insertions(+), 8 deletions(-) New commits: commit babff1023a9dbfb35069b332b456f4d22986518a Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 7 09:56:01 2014 + default to ods instead of sxc Change-Id: I66e6905237307f177fadfef2ffc13f04ffc43921 diff --git a/wizards/source/euro/AutoPilotRun.xba b/wizards/source/euro/AutoPilotRun.xba index fe2bed7..b35cc05 100644 --- a/wizards/source/euro/AutoPilotRun.xba +++ b/wizards/source/euro/AutoPilotRun.xba @@ -391,14 +391,14 @@ Sub CallFilePicker() Else ReDim FilterNames(3,1) as String End If - FilterNames(0,0) = oTypes.GetByName(quot;calc_StarOffice_XML_Calcquot;).UIName - Filternames(0,1) = quot;*.sxcquot; - FilterNames(1,0) = oTypes.GetByName(quot;calc_StarOffice_XML_Calc_Templatequot;).UIName - Filternames(1,1) = quot;*.stcquot; - FilterNames(2,0) = oTypes.GetByName(quot;calc8quot;).UIName - Filternames(2,1) = quot;*.odsquot; - FilterNames(3,0) = oTypes.GetByName(quot;calc8_templatequot;).UIName - Filternames(3,1) = quot;*.otsquot; + FilterNames(0,0) = oTypes.GetByName(quot;calc8quot;).UIName + Filternames(0,1) = quot;*.odsquot; + FilterNames(1,0) = oTypes.GetByName(quot;calc8_templatequot;).UIName + Filternames(1,1) = quot;*.otsquot; + FilterNames(2,0) = oTypes.GetByName(quot;calc_StarOffice_XML_Calcquot;).UIName + Filternames(2,1) = quot;*.sxcquot; + FilterNames(3,0) = oTypes.GetByName(quot;calc_StarOffice_XML_Calc_Templatequot;).UIName + Filternames(3,1) = quot;*.stcquot; GetFileName(DialogModel.txtSource, Filternames()) Else GetFolderName(DialogModel.txtSource) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
RE: Useless includes (maybe...)
Hi all, what i discuss with Tor i mean the construct (void) bSuccess; assert(bSuccess); is a little bit ugly In assert.h #ifdef NDEBUG #define assert(_Expression) ((void)0) #else Why '((void)0)' better empty or we define this #ifdef NDEBUG #define assert(_Expression) ((void) (Expression) ) #else But I am not really sure for work in all situations, but we can do define a special macro for this situation Juergen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/ui/frmdlg/frmdlg.cxx |2 +-
sw/source/uibase/inc/frmpage.hxx |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 30ec4ce259a26d7cefa2ee1d3c13383e8d86414c
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Nov 7 10:57:08 2014 +0100
SwFrmPage::SetFrmType: take an OUString
Currently these values are ASCII, but it's better to convert it to
OUString from the string literals directly than trying to guess their
encoding later.
Change-Id: I2629329a84c89410bd6d81d871b564988394e74e
diff --git a/sw/source/ui/frmdlg/frmdlg.cxx b/sw/source/ui/frmdlg/frmdlg.cxx
index da504e1..68257b0 100644
--- a/sw/source/ui/frmdlg/frmdlg.cxx
+++ b/sw/source/ui/frmdlg/frmdlg.cxx
@@ -148,7 +148,7 @@ void SwFrmDlg::PageCreated( sal_uInt16 nId, SfxTabPage
rPage )
{
((SwFrmPage)rPage).SetNewFrame(m_bNew);
((SwFrmPage)rPage).SetFormatUsed(m_bFormat);
-((SwFrmPage)rPage).SetFrmType(OUStringToOString(m_sDlgType,
RTL_TEXTENCODING_UTF8));
+((SwFrmPage)rPage).SetFrmType(m_sDlgType);
}
else if (nId == m_nAddId)
{
diff --git a/sw/source/uibase/inc/frmpage.hxx b/sw/source/uibase/inc/frmpage.hxx
index 21d0573..556f7d1 100644
--- a/sw/source/uibase/inc/frmpage.hxx
+++ b/sw/source/uibase/inc/frmpage.hxx
@@ -104,7 +104,7 @@ class SwFrmPage: public SfxTabPage
boolbIsInRightToLeft; // current frame is in right-to-left
environment - strings are exchanged
boolbHtmlMode;
sal_uInt16 nHtmlMode;
-OString sDlgType;
+OUStringsDlgType;
SizeaGrfSize;
SwTwips nUpperBorder;
SwTwips nLowerBorder;
@@ -192,7 +192,7 @@ public:
voidSetNewFrame(bool bNewFrame) { bNew = bNewFrame; }
voidSetFormatUsed(bool bFmt);
-voidSetFrmType(const OString rType) { sDlgType = rType; }
+voidSetFrmType(const OUString rType) { sDlgType = rType; }
inline bool IsInGraficMode( void ) { return sDlgType ==
PictureDialog || sDlgType == ObjectDialog; }
voidEnableVerticalPositioning( bool bEnable );
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 2 commits - vcl/Executable_vcldemo.mk vcl/workben
vcl/Executable_vcldemo.mk |4
vcl/workben/vcldemo.cxx | 267 ++
2 files changed, 160 insertions(+), 111 deletions(-)
New commits:
commit d4d9483d7d3b20a23c238502a989f72da6ec2e09
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 10:42:12 2014 +
vcldemo: kill all the legacy cruft.
Change-Id: I60d7d30ff20a01e375d9851afd8bd8ce12835752
diff --git a/vcl/Executable_vcldemo.mk b/vcl/Executable_vcldemo.mk
index fb29b9a..561f7d6 100644
--- a/vcl/Executable_vcldemo.mk
+++ b/vcl/Executable_vcldemo.mk
@@ -36,4 +36,8 @@ $(eval $(call gb_Executable_add_exception_objects,vcldemo,\
vcl/workben/vcldemo \
))
+$(eval $(call gb_Executable_use_static_libraries,vcldemo,\
+vclmain \
+))
+
# vim: set noet sw=4 ts=4:
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index 2f910ea..a8eccd0 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -5,73 +5,30 @@
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed
- * with this work for additional information regarding copyright
- * ownership. The ASF licenses this file to you under the Apache
- * License, Version 2.0 (the License); you may not use this file
- * except in compliance with the License. You may obtain a copy of
- * the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#include sal/main.h
-#include tools/extendapplicationenvironment.hxx
-
-#include cppuhelper/bootstrap.hxx
#include comphelper/processfactory.hxx
-
+#include cppuhelper/bootstrap.hxx
#include com/sun/star/lang/XMultiServiceFactory.hpp
-#include com/sun/star/uno/XComponentContext.hpp
+#include com/sun/star/lang/XInitialization.hpp
+#include com/sun/star/registry/XSimpleRegistry.hpp
+#include com/sun/star/ucb/UniversalContentBroker.hpp
+
+#include vcl/vclmain.hxx
-#include vcl/event.hxx
#include vcl/svapp.hxx
#include vcl/wrkwin.hxx
-#include vcl/msgbox.hxx
-
-#include unistd.h
-#include stdio.h
-using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::lang;
-using namespace cppu;
+using namespace css;
-// Forward declaration
-void Main();
-
-SAL_IMPLEMENT_MAIN()
-{
-tools::extendApplicationEnvironment();
-
-Reference XComponentContext xContext =
defaultBootstrap_InitialComponentContext();
-Reference XMultiServiceFactory xServiceManager(
xContext-getServiceManager(), UNO_QUERY );
-
-if( !xServiceManager.is() )
-Application::Abort( Failed to bootstrap );
-
-comphelper::setProcessServiceFactory( xServiceManager );
-
-InitVCL();
-::Main();
-DeInitVCL();
-
-return 0;
-}
-
-class MyWin : public WorkWindow
+class DemoWin : public WorkWindow
{
public:
- MyWin( vcl::Window* pParent, WinBits nWinStyle );
+DemoWin() : WorkWindow( NULL, WB_APP | WB_STDWORK)
+{
+}
-virtual void MouseMove( const MouseEvent rMEvt ) SAL_OVERRIDE;
-virtual void MouseButtonDown( const MouseEvent rMEvt ) SAL_OVERRIDE;
-virtual void MouseButtonUp( const MouseEvent rMEvt ) SAL_OVERRIDE;
-virtual void KeyInput( const KeyEvent rKEvt ) SAL_OVERRIDE;
-virtual void KeyUp( const KeyEvent rKEvt ) SAL_OVERRIDE;
virtual void Paint( const Rectangle rRect ) SAL_OVERRIDE;
-virtual void Resize() SAL_OVERRIDE;
std::vectorRectangle partitionAndClear(int nX, int nY);
@@ -134,49 +91,7 @@ public:
}
};
-void Main()
-{
-MyWin aMainWin( NULL, WB_APP | WB_STDWORK );
-aMainWin.SetText( OUString( VCLDemo - VCL Workbench ) );
-aMainWin.Show();
-
-Application::Execute();
-}
-
-MyWin::MyWin( vcl::Window* pParent, WinBits nWinStyle ) :
-WorkWindow( pParent, nWinStyle )
-{
-}
-
-void MyWin::MouseMove( const MouseEvent rMEvt )
-{
-WorkWindow::MouseMove( rMEvt );
-}
-
-void MyWin::MouseButtonDown( const MouseEvent rMEvt )
-{
-Rectangle aRect(0,0,4,4);
-aRect.SetPos( rMEvt.GetPosPixel() );
-SetFillColor(Color(COL_RED));
-DrawRect( aRect );
-}
-
-void MyWin::MouseButtonUp( const MouseEvent rMEvt )
-{
-WorkWindow::MouseButtonUp( rMEvt );
-}
-
-void MyWin::KeyInput( const KeyEvent rKEvt )
-{
-WorkWindow::KeyInput( rKEvt );
-}
-
-void MyWin::KeyUp( const KeyEvent rKEvt )
-{
-WorkWindow::KeyUp( rKEvt );
-}
-
-std::vectorRectangle MyWin::partitionAndClear(int nX, int nY)
+std::vectorRectangle DemoWin::partitionAndClear(int nX, int nY)
{
Rectangle r;
std::vectorRectangle aRegions;
@@ -211,9 +126,9 @@ std::vectorRectangle MyWin::partitionAndClear(int nX, int
nY)
return aRegions;
}
-void MyWin::Paint( const Rectangle rRect )
+void
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/workben
vcl/workben/outdevgrind.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 51d61a22e1d6d95fde18fa434e233aa0087e4846 Author: Jan Holesovsky ke...@collabora.com Date: Fri Nov 7 11:42:50 2014 +0100 Fix the Windows build. Change-Id: Ic95f241ea1b4cadddfacb46a1fff157555c8c8b5 diff --git a/vcl/workben/outdevgrind.cxx b/vcl/workben/outdevgrind.cxx index 262d550..66763e0 100644 --- a/vcl/workben/outdevgrind.cxx +++ b/vcl/workben/outdevgrind.cxx @@ -48,7 +48,6 @@ #include boost/bind.hpp #include stdio.h -#include unistd.h using namespace ::com::sun::star; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/Module_vcl.mk vcl/opengl vcl/workben
vcl/Module_vcl.mk |8
vcl/opengl/salbmp.cxx |2 +-
vcl/workben/vcldemo.cxx |1 +
3 files changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 3935b123e0e9b19b7e4753e23b3905a6f59b36db
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 7 12:03:28 2014 +0100
Build vcldemo on Windows too.
Change-Id: Ia6f7cfb819983a3a75ac78015a8eec1da539bead
diff --git a/vcl/Module_vcl.mk b/vcl/Module_vcl.mk
index 82597a2..5d1d2d2 100644
--- a/vcl/Module_vcl.mk
+++ b/vcl/Module_vcl.mk
@@ -27,13 +27,13 @@ $(eval $(call gb_Module_add_targets,vcl,\
StaticLibrary_vclmain \
Executable_ui-previewer \
$(if $(filter LINUX MACOSX WNT,$(OS)), \
- Executable_icontest \
- Executable_outdevgrind )) \
+ Executable_icontest \
+ Executable_outdevgrind \
+ Executable_vcldemo )) \
$(if $(filter-out ANDROID IOS WNT,$(OS)), \
Executable_svdemo \
Executable_svptest \
-Executable_svpclient \
-Executable_vcldemo) \
+Executable_svpclient) \
))
$(eval $(call gb_Module_add_l10n_targets,vcl,\
diff --git a/vcl/opengl/salbmp.cxx b/vcl/opengl/salbmp.cxx
index 46c2b0c..0736773 100644
--- a/vcl/opengl/salbmp.cxx
+++ b/vcl/opengl/salbmp.cxx
@@ -130,7 +130,7 @@ bool OpenGLSalBitmap::Create( const
::com::sun::star::uno::Reference ::com::sun
return false;
}
-bool OpenGLSalBitmap::Draw( OpenGLContext rContext, const SalTwoRect rPosAry
)
+bool OpenGLSalBitmap::Draw( OpenGLContext rContext, const SalTwoRect
/*rPosAry*/ )
{
if( !mpContext )
mpContext = rContext;
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index a8eccd0..e381f09 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -154,6 +154,7 @@ public:
aMainWin.SetText( Interactive VCL demo );
aMainWin.Show();
Application::Execute();
+return 0;
}
protected:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/priorities' - sfx2/source vcl/source
sfx2/source/appl/newhelp.cxx |6 +++---
sfx2/source/appl/newhelp.hxx |2 +-
vcl/source/edit/textdat2.hxx |2 +-
vcl/source/edit/textdata.cxx |5 +++--
vcl/source/edit/texteng.cxx |2 +-
5 files changed, 9 insertions(+), 8 deletions(-)
New commits:
commit 2b468b1b6b3bde9ac931a19ee30b8783c893fc49
Author: Tobias Madl tobias.madl@gmail.com
Date: Fri Nov 7 11:13:37 2014 +
change timers to idles
Change-Id: I224976e75b020d03e4b0d8beb79ad1c1310e8874
diff --git a/sfx2/source/appl/newhelp.cxx b/sfx2/source/appl/newhelp.cxx
index 4ee115d..d38356f 100644
--- a/sfx2/source/appl/newhelp.cxx
+++ b/sfx2/source/appl/newhelp.cxx
@@ -1875,8 +1875,8 @@ SfxHelpTextWindow_Impl::SfxHelpTextWindow_Impl(
SfxHelpWindow_Impl* pParent ) :
InitOnStartupBox( false );
aOnStartupCB.SetClickHdl( LINK( this, SfxHelpTextWindow_Impl, CheckHdl ) );
-aSelectTimer.SetTimeoutHdl( LINK( this, SfxHelpTextWindow_Impl, SelectHdl
) );
-aSelectTimer.SetTimeout( 1000 );
+aSelectIdle.SetIdleHdl( LINK( this, SfxHelpTextWindow_Impl, SelectHdl ) );
+aSelectIdle.SetPriority( VCL_IDLE_PRIORITY_LOWEST );
char* pEnv = getenv( help_debug );
if ( pEnv )
@@ -2497,7 +2497,7 @@ void SfxHelpTextWindow_Impl::SelectSearchText( const
OUString rSearchText, bool
{
aSearchText = rSearchText;
bIsFullWordSearch = _bIsFullWordSearch;
-aSelectTimer.Start();
+aSelectIdle.Start();
}
diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index a910fd0..eb303e1 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -405,7 +405,7 @@ class SfxHelpTextWindow_Impl : public vcl::Window
private:
ToolBox aToolBox;
CheckBoxaOnStartupCB;
-Timer aSelectTimer;
+IdleaSelectIdle;
Image aIndexOnImage;
Image aIndexOffImage;
OUStringaIndexOnText;
diff --git a/vcl/source/edit/textdat2.hxx b/vcl/source/edit/textdat2.hxx
index b5e2118..820be5e 100644
--- a/vcl/source/edit/textdat2.hxx
+++ b/vcl/source/edit/textdat2.hxx
@@ -261,7 +261,7 @@ public:
virtual voidDestroyAnchor() SAL_OVERRIDE;
};
-class IdleFormatter : public Timer
+class IdleFormatter : public Idle
{
private:
TextView* mpView;
diff --git a/vcl/source/edit/textdata.cxx b/vcl/source/edit/textdata.cxx
index e6bebd2..dbdfbee 100644
--- a/vcl/source/edit/textdata.cxx
+++ b/vcl/source/edit/textdata.cxx
@@ -223,6 +223,7 @@ IdleFormatter::IdleFormatter()
{
mpView = 0;
mnRestarts = 0;
+SetPriority(VCL_IDLE_PRIORITY_HIGH);
}
IdleFormatter::~IdleFormatter()
@@ -240,7 +241,7 @@ void IdleFormatter::DoIdleFormat( TextView* pV, sal_uInt16
nMaxRestarts )
if ( mnRestarts nMaxRestarts )
{
mnRestarts = 0;
-((Link)GetTimeoutHdl()).Call( this );
+((Link)GetIdleHdl()).Call( this );
}
else
{
@@ -254,7 +255,7 @@ void IdleFormatter::ForceTimeout()
{
Stop();
mnRestarts = 0;
-((Link)GetTimeoutHdl()).Call( this );
+((Link)GetIdleHdl()).Call( this );
}
}
diff --git a/vcl/source/edit/texteng.cxx b/vcl/source/edit/texteng.cxx
index 5be733f..629c8a7 100644
--- a/vcl/source/edit/texteng.cxx
+++ b/vcl/source/edit/texteng.cxx
@@ -92,7 +92,7 @@ TextEngine::TextEngine()
mpLocaleDataWrapper = NULL;
mpIdleFormatter = new IdleFormatter;
-mpIdleFormatter-SetTimeoutHdl( LINK( this, TextEngine, IdleFormatHdl ) );
+mpIdleFormatter-SetIdleHdl( LINK( this, TextEngine, IdleFormatHdl ) );
mpRefDev = new VirtualDevice;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/workben
vcl/workben/vcldemo.cxx | 66 +---
1 file changed, 57 insertions(+), 9 deletions(-)
New commits:
commit 7dedb96d7a82f206dfa69ca6ed6a61e569dcddf8
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 11:23:43 2014 +
vcldemo: initial bitmap tests.
Change-Id: I2841e689b732467f2168450dc47464b322baa183
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index e381f09..1fdd751 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -7,6 +7,7 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
+#include rtl/bootstrap.hxx
#include comphelper/processfactory.hxx
#include cppuhelper/bootstrap.hxx
#include com/sun/star/lang/XMultiServiceFactory.hpp
@@ -16,16 +17,41 @@
#include vcl/vclmain.hxx
+#include tools/urlobj.hxx
+#include tools/stream.hxx
#include vcl/svapp.hxx
+#include vcl/pngread.hxx
#include vcl/wrkwin.hxx
+#include vcl/graphicfilter.hxx
using namespace css;
class DemoWin : public WorkWindow
{
+Bitmap maIntroBW;
+BitmapEx maIntro;
+
public:
DemoWin() : WorkWindow( NULL, WB_APP | WB_STDWORK)
{
+// Needed to find images
+OUString aPath;
+rtl::Bootstrap::get(SYSBINDIR, aPath);
+#ifdef FIXME_THIS_FAILS
+rtl::Bootstrap::set(BRAND_BASE_DIR, aPath + /..);
+if (Application::LoadBrandBitmap(intro, maIntro))
+Application::Abort(Failed to load intro image);
+#else
+aPath = aPath + /intro.png;
+SvFileStream aFileStream( aPath, STREAM_READ );
+GraphicFilter aGraphicFilter(false);
+Graphic aGraphic;
+if (aGraphicFilter.ImportGraphic(aGraphic, aPath, aFileStream) != 0)
+Application::Abort(Failed to load intro image: + aPath);
+maIntro = aGraphic.GetBitmapEx();
+#endif
+maIntroBW = maIntro.GetBitmap();
+maIntroBW.Filter( BMP_FILTER_EMBOSS_GREY );
}
virtual void Paint( const Rectangle rRect ) SAL_OVERRIDE;
@@ -46,9 +72,10 @@ public:
void drawRadialLines(Rectangle r)
{
SetFillColor(Color(COL_LIGHTRED));
-SetLineColor(Color(COL_LIGHTGREEN));
+SetLineColor(Color(COL_BLACK));
DrawRect( r );
+// FIXME: notice these appear reflected at the bottom not the top.
for(int i=0; ir.GetHeight(); i+=15)
DrawLine( Point(r.Left(), r.Top()+i), Point(r.Right(),
r.Bottom()-i) );
for(int i=0; ir.GetWidth(); i+=15)
@@ -69,12 +96,10 @@ public:
SetLineColor(Color(COL_RED));
//DrawPolyLine(aPoly);
}
-
void drawPolyPoly(Rectangle r)
{
(void)r;
}
-
void drawCheckered(Rectangle r)
{
DrawCheckered(r.TopLeft(), r.GetSize());
@@ -82,13 +107,31 @@ public:
void drawGradient(Rectangle r)
{
Gradient aGradient;
-aGradient.SetStartColor(COL_BLUE);
-aGradient.SetEndColor(COL_GREEN);
+aGradient.SetStartColor(COL_YELLOW);
+aGradient.SetEndColor(COL_RED);
//aGradient.SetAngle(45);
-aGradient.SetStyle(GradientStyle_LINEAR);
+aGradient.SetStyle(GradientStyle_RECT);
aGradient.SetBorder(r.GetSize().Width()/20);
DrawGradient(r, aGradient);
}
+void drawBitmap(Rectangle r)
+{
+Bitmap aBitmap(maIntroBW);
+aBitmap.Scale(r.GetSize(), BMP_SCALE_BESTQUALITY);
+DrawBitmap(r.TopLeft(), aBitmap);
+}
+void drawBitmapEx(Rectangle r)
+{
+BitmapEx aBitmap(maIntro);
+aBitmap.Scale(r.GetSize(), BMP_SCALE_BESTQUALITY);
+DrawBitmapEx(r.TopLeft(), aBitmap);
+}
+void fetchDrawBitmap(Rectangle r)
+{
+Bitmap aBitmap(GetBitmap(Point(0,0),GetSizePixel()));
+aBitmap.Scale(r.GetSize(), BMP_SCALE_BESTQUALITY);
+DrawBitmap(r.TopLeft(), aBitmap);
+}
};
std::vectorRectangle DemoWin::partitionAndClear(int nX, int nY)
@@ -100,8 +143,7 @@ std::vectorRectangle DemoWin::partitionAndClear(int nX,
int nY)
Size aSize(GetSizePixel());
long nBorderSize = aSize.Width() / 32;
long nBoxWidth = (aSize.Width() - nBorderSize*(nX+1)) / nX;
-long nBoxHeight = (aSize.Height() - nBorderSize*(nX+1)) / nY;
-//SL_DEBUG(Size aSize boxes nBoxWidth x nBoxHeight
border nBorderSize);
+long nBoxHeight = (aSize.Height() - nBorderSize*(nY+1)) / nY;
for (int y = 0; y nY; y++ )
{
for (int x = 0; x nX; x++ )
@@ -117,7 +159,8 @@ std::vectorRectangle DemoWin::partitionAndClear(int nX,
int nY)
DrawRect(r);
else
DrawRect(r);
-// DrawRect(r, nBorderSize, nBorderSize); FIXME - lfrb
+// FIXME: rendering these guys doesn't work at all
+// DrawRect(r, nBorderSize, nBorderSize);
aRegions.push_back(r);
}
@@ -140,7 +183,12 @@ void DemoWin::Paint( const Rectangle rRect )
drawPoly(aRegions[i++]);
[Libreoffice-commits] core.git: Branch 'feature/opengl-canvas-rework' - 2 commits - canvas/opengl canvas/source
canvas/opengl/rectangularMultiColorGradientFragmentShader.glsl |6
canvas/source/opengl/ogl_canvascustomsprite.cxx| 30 +--
canvas/source/opengl/ogl_canvascustomsprite.hxx|1
canvas/source/opengl/ogl_canvashelper.cxx | 78
++
canvas/source/opengl/ogl_canvashelper.hxx |2
canvas/source/opengl/ogl_renderHelper.cxx |6
canvas/source/opengl/ogl_renderHelper.hxx |3
canvas/source/opengl/ogl_spritedevicehelper.cxx|8 +
canvas/source/opengl/ogl_spritedevicehelper.hxx|7
9 files changed, 86 insertions(+), 55 deletions(-)
New commits:
commit 56fb90618a731567bf44339bd4e0b8d0e4dd4dd9
Author: Michael Jaumann meta_...@yahoo.com
Date: Fri Nov 7 11:22:32 2014 +
mv renderHelper-Spritedevicehelper,init OglContxt
Change-Id: I81e4035796e47bd845c8f211d30cc2655b9c09f0
diff --git a/canvas/source/opengl/ogl_canvascustomsprite.cxx
b/canvas/source/opengl/ogl_canvascustomsprite.cxx
index f64e25c..58b2561 100644
--- a/canvas/source/opengl/ogl_canvascustomsprite.cxx
+++ b/canvas/source/opengl/ogl_canvascustomsprite.cxx
@@ -47,7 +47,6 @@ namespace oglcanvas
::canvas::tools::setIdentityAffineMatrix2D(maTransformation);
maCanvasHelper.init( *rRefDevice.get(),
rDeviceHelper );
-mRenderHelper.SetVP(1600, 900);//is this right?
}
void CanvasCustomSprite::disposeThis()
@@ -55,7 +54,6 @@ namespace oglcanvas
::osl::MutexGuard aGuard( m_aMutex );
mpSpriteCanvas.clear();
-mRenderHelper.dispose();
// forward to parent
CanvasCustomSpriteBaseT::disposeThis();
}
@@ -132,10 +130,10 @@ namespace oglcanvas
if( ::basegfx::fTools::equalZero( mfAlpha ) )
return true;
-const ::basegfx::B2IVector aSpriteSizePixel(
+const glm::vec2 aSpriteSizePixel(
::canvas::tools::roundUp( maSize.Width ),
::canvas::tools::roundUp( maSize.Height ));
-
+RenderHelper* pRenderHelper =
maCanvasHelper.getDeviceHelper()-getRenderHelper();
IBufferContextSharedPtr pBufferContext;
if( mfAlpha != 1.0 || mxClip.is() )
{
@@ -161,7 +159,7 @@ namespace oglcanvas
maTransformation.m02, maTransformation.m12, 0, 1
);
-mRenderHelper.SetModelAndMVP(translate * aGLTransform);
+pRenderHelper-SetModelAndMVP(translate * aGLTransform);
// content ended up in background buffer - compose to
// screen now. Calls below switches us back to window
// context, and binds to generated, dynamic texture
@@ -197,8 +195,8 @@ namespace oglcanvas
rTriangulatedPolygon,
basegfx::B2DRange(
0,0,
-aSpriteSizePixel.getX(),
-aSpriteSizePixel.getY(;
+aSpriteSizePixel.x,
+aSpriteSizePixel.y)));
GLfloat vertices[rTriangulatedPolygon.count()*2];
for( sal_uInt32 i=0; irTriangulatedPolygon.count(); i++ )
@@ -207,29 +205,29 @@ namespace oglcanvas
vertices[i*2]= rPt.getX();
vertices[i*2+1]= rPt.getY();
}
-mRenderHelper.renderVertexTex( vertices, fWidth, fHeight,
color, GL_TRIANGLES);
+pRenderHelper-renderVertexTex( vertices, fWidth, fHeight,
color, GL_TRIANGLES);
}
else
{
-const double fWidth=maSize.Width/aSpriteSizePixel.getX();
-const double fHeight=maSize.Height/aSpriteSizePixel.getY();
+const double fWidth=maSize.Width/aSpriteSizePixel.x;
+const double fHeight=maSize.Height/aSpriteSizePixel.y;
GLfloat vertices[] = {0, 0,
- 0, (float) aSpriteSizePixel.getY(),
- (float) aSpriteSizePixel.getX(), 0,
- (float) aSpriteSizePixel.getX(),
(float) aSpriteSizePixel.getY() };
+ 0, (float) aSpriteSizePixel.y,
+ (float) aSpriteSizePixel.x, 0,
+ (float) aSpriteSizePixel.x, (float)
aSpriteSizePixel.y };
GLfloat uvCoordinates[] = {0, 0,
0, (float) fHeight,
(float) fWidth, 0,
(float) fWidth, (float) fHeight
};
-
[Libreoffice-commits] core.git: Branch 'feature/priorities' - chart2/source sc/source svx/source
chart2/source/view/charttypes/GL3DBarChart.cxx |9 -
chart2/source/view/inc/GL3DBarChart.hxx|2 +-
sc/source/ui/inc/acredlin.hxx |4 ++--
sc/source/ui/miscdlgs/acredlin.cxx | 10 +-
svx/source/form/filtnav.cxx| 25 ++---
5 files changed, 18 insertions(+), 32 deletions(-)
New commits:
commit aaf84ed18316ad41f10f9a1f88405ac606ec9c16
Author: Jennifer Liebel jliebe...@gmail.com
Date: Fri Nov 7 11:21:23 2014 +
changed timers to idle
Change-Id: Ibdecb970f7e6119929ec172e56d986c682008487
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx
b/chart2/source/view/charttypes/GL3DBarChart.cxx
index 7924e48..8236706 100755
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -26,7 +26,6 @@
#define CALC_POS_EVENT_ID 1
#define SHAPE_START_ID 10
-#define DATA_UPDATE_TIME 15
#define FPS_TIME 500
#define DATAUPDATE_FPS_TIME 1000
#define HISTORY_NUM 51
@@ -561,9 +560,9 @@ GL3DBarChart::GL3DBarChart(
{
mbAutoFly = atoi(aAutoFly);
}
-maTimer.SetTimeout(DATA_UPDATE_TIME);
-maTimer.SetTimeoutHdl(LINK(this, GL3DBarChart, UpdateTimerHdl));
-maTimer.Start();
+maIdle.SetPriority(VCL_IDLE_PRIORITY_REPAINT);
+maIdle.SetIdleHdl(LINK(this, GL3DBarChart, UpdateTimerHdl));
+maIdle.Start();
osl_getSystemTime(maFPSRenderStartTime);
osl_getSystemTime(maFPSRenderEndTime);
osl_getSystemTime(maDataUpdateStartTime);
@@ -1475,7 +1474,7 @@ void GL3DBarChart::processAutoFly(sal_uInt32 nId,
sal_uInt32 nColor)
IMPL_LINK_NOARG(GL3DBarChart, UpdateTimerHdl)
{
updateScreenText();
-maTimer.Start();
+maIdle.Start();
return 0;
}
diff --git a/chart2/source/view/inc/GL3DBarChart.hxx
b/chart2/source/view/inc/GL3DBarChart.hxx
index 79d816d..0daeed0 100644
--- a/chart2/source/view/inc/GL3DBarChart.hxx
+++ b/chart2/source/view/inc/GL3DBarChart.hxx
@@ -174,7 +174,7 @@ private:
Point maClickPos;
sal_uInt32 miScrollRate;
bool mbScrollFlg;
-Timer maTimer;
+Idle maIdle;
bool mbScreenTextNewRender;
boost::ptr_vectoropengl3D::Renderable3DObject maScreenTextShapes;
OUString maFPS;
diff --git a/sc/source/ui/inc/acredlin.hxx b/sc/source/ui/inc/acredlin.hxx
index 048e552..79a7ad5 100644
--- a/sc/source/ui/inc/acredlin.hxx
+++ b/sc/source/ui/inc/acredlin.hxx
@@ -95,8 +95,8 @@ class ScAcceptChgDlg : public SfxModelessDialog
{
private:
-Timer aSelectionTimer;
-Timer aReOpenTimer;
+IdleaSelectionIdle;
+IdleaReOpenIdle;
SvxAcceptChgCtr*m_pAcceptChgCtr;
ScViewData* pViewData;
ScDocument* pDoc;
diff --git a/sc/source/ui/miscdlgs/acredlin.cxx
b/sc/source/ui/miscdlgs/acredlin.cxx
index 8614e81..ccf4543 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -114,14 +114,14 @@ ScAcceptChgDlg::ScAcceptChgDlg(SfxBindings* pB,
SfxChildWindow* pCW, vcl::Window
m_pAcceptChgCtr = new SvxAcceptChgCtr(get_content_area());
nAcceptCount=0;
nRejectCount=0;
-aReOpenTimer.SetTimeout(50);
-aReOpenTimer.SetTimeoutHdl(LINK( this, ScAcceptChgDlg, ReOpenTimerHdl ));
+aReOpenIdle.SetPriority(VCL_IDLE_PRIORITY_MEDIUM);
+aReOpenIdle.SetIdleHdl(LINK( this, ScAcceptChgDlg, ReOpenTimerHdl ));
pTPFilter=m_pAcceptChgCtr-GetFilterPage();
pTPView=m_pAcceptChgCtr-GetViewPage();
pTheView=pTPView-GetTableControl();
-aSelectionTimer.SetTimeout(100);
-aSelectionTimer.SetTimeoutHdl(LINK( this, ScAcceptChgDlg,
UpdateSelectionHdl ));
+aSelectionIdle.SetPriority(VCL_IDLE_PRIORITY_LOW);
+aSelectionIdle.SetIdleHdl(LINK( this, ScAcceptChgDlg, UpdateSelectionHdl
));
pTPFilter-SetReadyHdl(LINK( this, ScAcceptChgDlg, FilterHandle ));
pTPFilter-SetRefHdl(LINK( this, ScAcceptChgDlg, RefHandle ));
@@ -1104,7 +1104,7 @@ IMPL_LINK_NOARG(ScAcceptChgDlg, AcceptAllHandle)
IMPL_LINK_NOARG(ScAcceptChgDlg, SelectHandle)
{
if(!bNoSelection)
-aSelectionTimer.Start();
+aSelectionIdle.Start();
bNoSelection=false;
return 0;
diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx
index ae552aa..6cbf052 100644
--- a/svx/source/form/filtnav.cxx
+++ b/svx/source/form/filtnav.cxx
@@ -1265,12 +1265,7 @@ IMPL_LINK_NOARG(FmFilterNavigator, OnDropActionTimer)
{
SvTreeListEntry* pToExpand = GetEntry(m_aTimerTriggered);
if (pToExpand (GetChildCount(pToExpand) 0)
!IsExpanded(pToExpand))
-// tja, eigentlich muesste ich noch testen, ob die Node nicht
schon expandiert ist, aber ich
-// habe dazu weder in den Basisklassen noch im Model eine
Methode gefunden ...
-// aber ich denke, die BK sollte es
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/create-tags |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d045ad920be0aa55cd3761dc236fc621bcd8e387
Author: Takeshi Abe t...@fixedpoint.jp
Date: Fri Nov 7 13:52:44 2014 +0900
make 'make tags' work in case of out-of-tree build
Change-Id: I6c25988497208d9ae652feb1f9c37032f22ae376
Reviewed-on: https://gerrit.libreoffice.org/12295
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/solenv/bin/create-tags b/solenv/bin/create-tags
index a9f2622..1d3f2a5 100755
--- a/solenv/bin/create-tags
+++ b/solenv/bin/create-tags
@@ -12,7 +12,7 @@ omnicppoptions=--c++-kinds=+p --fields=+iaS --extra=+q
ctags -h +.hdl.hrc --langmap=c:+.hrc.src,c++:+.hdl $omnicppoptions \
--languages=-HTML,Java,JavaScript \
-R --exclude=instdir --exclude=workdir \
- --exclude=clone --totals=yes *
+ --exclude=clone --totals=yes ${SRCDIR:-*}
ctags -h +.hdl.hrc --langmap=c:+.hrc.src,c++:+.hdl $omnicppoptions \
--languages=-HTML,Java,JavaScript \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - winaccessibility/source
winaccessibility/source/service/AccObjectWinManager.cxx | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
New commits:
commit 162535ded77633a07871be917b719861bcaf9f43
Author: Niklas Johansson sleeping.pil...@gmail.com
Date: Wed Nov 5 09:44:24 2014 +0100
fdo#81264 Accessiblitiy focus not tracked for cells in Calc
When the accessibility roles for DOCUMENT_SPREADSHEET etc. was introduced
the following places in Windows specific files where not updated to take
these new roles into account. This patch should hopefully fix that. As a
side effect the initial code for tracking cell movement in Calc works again.
Well at least as well as it did before the change, there are still some
quirks left to fix.
Change-Id: If3cacdc27a73c4cee85b1450c406d490bd741456
Reviewed-on: https://gerrit.libreoffice.org/12261
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit a1a9f0e5c4f7d7331072854250a7eb9046e4f111)
Reviewed-on: https://gerrit.libreoffice.org/12298
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/winaccessibility/source/service/AccObjectWinManager.cxx
b/winaccessibility/source/service/AccObjectWinManager.cxx
index 32c155e..f257541 100644
--- a/winaccessibility/source/service/AccObjectWinManager.cxx
+++ b/winaccessibility/source/service/AccObjectWinManager.cxx
@@ -548,7 +548,10 @@ void AccObjectWinManager::DeleteAccObj( XAccessible* pXAcc
)
size_t i = XResIdAccList.erase(accObj.GetResID());
assert(i != 0);
DeleteFromHwndXAcc(pXAcc);
-if (DOCUMENT == accObj.GetRole())
+if( accObj.GetRole() == DOCUMENT ||
+accObj.GetRole() == DOCUMENT_PRESENTATION ||
+accObj.GetRole() == DOCUMENT_SPREADSHEET ||
+accObj.GetRole() == DOCUMENT_TEXT )
{
XHWNDDocList.erase(accObj.GetParentHWND());
}
@@ -710,7 +713,10 @@ sal_Bool AccObjectWinManager::InsertAccObj( XAccessible*
pXAcc,XAccessible* pPar
pObj.SetParentHWND( pWnd );
//for file name support
-if ( pObj.GetRole() == DOCUMENT )
+if( pObj.GetRole() == DOCUMENT ||
+pObj.GetRole() == DOCUMENT_PRESENTATION ||
+pObj.GetRole() == DOCUMENT_SPREADSHEET ||
+pObj.GetRole() == DOCUMENT_TEXT )
{
XHWNDToDocumentHash::iterator aIter = XHWNDDocList.find(pWnd);
if ( aIter != XHWNDDocList.end() )
@@ -793,6 +799,9 @@ AccObjectWinManager::CreateAccEventListener(XAccessible*
pXAcc)
case /*AccessibleRole::*/CANVAS:
case /*AccessibleRole::*/COMBO_BOX:
case /*AccessibleRole::*/DOCUMENT:
+case /*AccessibleRole::*/DOCUMENT_PRESENTATION:
+case /*AccessibleRole::*/DOCUMENT_SPREADSHEET:
+case /*AccessibleRole::*/DOCUMENT_TEXT:
case /*AccessibleRole::*/END_NOTE:
case /*AccessibleRole::*/FILLER:
case /*AccessibleRole::*/FOOTNOTE:
@@ -1037,6 +1046,9 @@ sal_Bool AccObjectWinManager::IsContainer(XAccessible*
pAccessible)
case /*AccessibleRole::*/CANVAS:
case /*AccessibleRole::*/COMBO_BOX:
case /*AccessibleRole::*/DOCUMENT:
+case /*AccessibleRole::*/DOCUMENT_PRESENTATION:
+case /*AccessibleRole::*/DOCUMENT_SPREADSHEET:
+case /*AccessibleRole::*/DOCUMENT_TEXT:
case /*AccessibleRole::*/EMBEDDED_OBJECT:
case /*AccessibleRole::*/END_NOTE:
case /*AccessibleRole::*/FILLER:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - winaccessibility/source
winaccessibility/source/service/AccObject.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a148f119c7f6fe758f9bf8905ac12c646d934a52
Author: Niklas Johansson sleeping.pil...@gmail.com
Date: Thu Oct 16 12:14:15 2014 +0200
fdo#74441 [Accessiblity] Don't expose 0 for empty cells in Calc
At the moment non numercial cells in Calc is exposed to AT tools
(screen readers etc) as the value 0. It makes more sence to present
the string value of the cell which basically is what a sighted user
will see. This small patch should be a good start into making
Calc more accessible on Windows.
Change-Id: Ide76f2dc044c98f32aa78836049f12f2251522eb
Reviewed-on: https://gerrit.libreoffice.org/11996
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit 55eca9dbb34aec8c435da91c0748453e3e097f1e)
Reviewed-on: https://gerrit.libreoffice.org/12299
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/winaccessibility/source/service/AccObject.cxx
b/winaccessibility/source/service/AccObject.cxx
index 63db986..3f957e1 100644
--- a/winaccessibility/source/service/AccObject.cxx
+++ b/winaccessibility/source/service/AccObject.cxx
@@ -392,6 +392,7 @@ void AccObject::SetValue( Any pAny )
case TEXT:
case PARAGRAPH:
case HEADING:
+case TABLE_CELL:
if(pRText.get())
{
@@ -402,7 +403,6 @@ void AccObject::SetValue( Any pAny )
case TREE_ITEM:
//case CHECK_BOX: //Commented by Li Xing to disable the value for
general checkbox
case COMBO_BOX:
-case TABLE_CELL:
case NOTE:
case SCROLL_BAR:
m_pIMAcc-Put_XAccValue( GetMAccessibleValueFromAny(pAny).getStr() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sd/qa sw/qa
sc/qa/unit/subsequent_export-test.cxx |5 ++---
sd/qa/unit/export-tests.cxx|4 ++--
sw/qa/extras/globalfilter/globalfilter.cxx | 16 +++-
3 files changed, 7 insertions(+), 18 deletions(-)
New commits:
commit e284d7f2526bb01a3dc4b6297ba61b04a0613eff
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Fri Nov 7 12:28:51 2014 +0100
Make these tests weaker to fix build.
Image loss indicator is the empty URL.
Change-Id: I0f8b037dc23bae3d7342d73cfafa4ecc55090ab6
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index cdc7532..7c1de6b 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -2304,8 +2304,7 @@ void ScExportTest::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-CPPUNIT_ASSERT_EQUAL_MESSAGE(
-sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:1262017D9F4CD7A2), sURL);
+CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
@@ -2323,7 +2322,7 @@ void ScExportTest::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:138402580A24B597), sURL);
+CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 08f8547..e907e47 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -539,7 +539,7 @@ void SdExportTest::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:1262017D9F4CD7A2), sURL);
+CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
@@ -559,7 +559,7 @@ void SdExportTest::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-CPPUNIT_ASSERT_EQUAL_MESSAGE(sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:138402580A24B597), sURL);
+CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx
b/sw/qa/extras/globalfilter/globalfilter.cxx
index 1fd4331..6a28692 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -81,8 +81,7 @@ void Test::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-CPPUNIT_ASSERT_EQUAL_MESSAGE(
-sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:1262017D9F4CD7A2), sURL);
+CPPUNIT_ASSERT_MESSAGE(sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
@@ -101,17 +100,8 @@ void Test::testSwappedOutImageExport()
{
OUString sURL;
XPropSet-getPropertyValue(GraphicURL) = sURL;
-// HTML filter changes the name, but the real indicater here is
the null URL.
-if( aFilterNames[nFilter] == HTML (StarWriter) )
-{
-CPPUNIT_ASSERT_MESSAGE(
-sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
-}
-else
-{
-CPPUNIT_ASSERT_EQUAL_MESSAGE(
-sFailedMessage.getStr(),
OUString(vnd.sun.star.GraphicObject:138402580A24B597), sURL);
-}
+CPPUNIT_ASSERT_MESSAGE(
+sFailedMessage.getStr(), sURL !=
OUString(vnd.sun.star.GraphicObject:));
}
// Check size
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/CppunitTest_sw_uiwriter.mk
sw/CppunitTest_sw_uiwriter.mk |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 055a46d0e95345e7bf201adf64bccdff5451 Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Wed Nov 5 17:52:53 2014 +0100 Fixup headless build Don't require vcl.unx component on headless build Change-Id: I33c3d90b67dd4ef3fc52ae2555b41ca2deb191de Reviewed-on: https://gerrit.libreoffice.org/12267 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/sw/CppunitTest_sw_uiwriter.mk b/sw/CppunitTest_sw_uiwriter.mk index 7e3e3e8..a5c9db0 100644 --- a/sw/CppunitTest_sw_uiwriter.mk +++ b/sw/CppunitTest_sw_uiwriter.mk @@ -80,7 +80,9 @@ $(eval $(call gb_CppunitTest_use_components,sw_uiwriter,\ unoxml/source/service/unoxml \ uui/util/uui \ $(if $(filter-out MACOSX WNT,$(OS)), \ -vcl/vcl.unx \ +$(if $(ENABLE_HEADLESS),, \ +vcl/vcl.unx \ +) \ ) \ $(if $(filter DESKTOP,$(BUILD_TYPE)),xmlhelp/util/ucpchelp1) \ writerfilter/util/writerfilter \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/oox lotuswordpro/source vcl/inc xmloff/inc xmloff/source
include/oox/ppt/timenode.hxx |1 -
lotuswordpro/source/filter/xfilter/xfendnoteconfig.hxx |2 --
vcl/inc/PhysicalFontFamily.hxx |1 -
xmloff/inc/txtvfldi.hxx|1 -
xmloff/source/transform/TransformerTokenMap.hxx|3 ---
5 files changed, 8 deletions(-)
New commits:
commit a44163ada4de97d53910cf48a4017ab191b4fb16
Author: Andrea Gelmini andrea.gelm...@gelma.net
Date: Wed Nov 5 21:46:08 2014 +0100
Removed #includes including themselves
Change-Id: I3fe3227967e07b6b0c82dccf3c9400bfe6e1d729
Reviewed-on: https://gerrit.libreoffice.org/12292
Reviewed-by: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/include/oox/ppt/timenode.hxx b/include/oox/ppt/timenode.hxx
index fd9a7e8..9c8eda4 100644
--- a/include/oox/ppt/timenode.hxx
+++ b/include/oox/ppt/timenode.hxx
@@ -32,7 +32,6 @@
#include oox/ppt/slidetransition.hxx
#include oox/ppt/slidepersist.hxx
#include oox/ppt/animationspersist.hxx
-#include oox/ppt/timenode.hxx
namespace oox { namespace ppt {
diff --git a/lotuswordpro/source/filter/xfilter/xfendnoteconfig.hxx
b/lotuswordpro/source/filter/xfilter/xfendnoteconfig.hxx
index d034a9e..5e4519d 100644
--- a/lotuswordpro/source/filter/xfilter/xfendnoteconfig.hxx
+++ b/lotuswordpro/source/filter/xfilter/xfendnoteconfig.hxx
@@ -60,8 +60,6 @@
#ifndef INCLUDED_LOTUSWORDPRO_SOURCE_FILTER_XFILTER_XFENDNOTECONFIG_HXX
#define INCLUDED_LOTUSWORDPRO_SOURCE_FILTER_XFILTER_XFENDNOTECONFIG_HXX
-#include xfendnoteconfig.hxx
-
class XFEndnoteConfig : public XFFootnoteConfig
{
public:
diff --git a/vcl/inc/PhysicalFontFamily.hxx b/vcl/inc/PhysicalFontFamily.hxx
index 71861e9..61f7c42 100644
--- a/vcl/inc/PhysicalFontFamily.hxx
+++ b/vcl/inc/PhysicalFontFamily.hxx
@@ -25,7 +25,6 @@
#include unotools/fontcfg.hxx
#include PhysicalFontFace.hxx
-#include PhysicalFontFamily.hxx
class PhysicalFontFace;
class PhysicalFontCollection;
diff --git a/xmloff/inc/txtvfldi.hxx b/xmloff/inc/txtvfldi.hxx
index c58f5f4..276dc9b 100644
--- a/xmloff/inc/txtvfldi.hxx
+++ b/xmloff/inc/txtvfldi.hxx
@@ -25,7 +25,6 @@
#ifndef INCLUDED_XMLOFF_INC_TXTVFLDI_HXX
#define INCLUDED_XMLOFF_INC_TXTVFLDI_HXX
-#include txtvfldi.hxx
#include txtfldi.hxx
#include com/sun/star/beans/XPropertySet.hpp
#include com/sun/star/beans/XPropertySetInfo.hpp
diff --git a/xmloff/source/transform/TransformerTokenMap.hxx
b/xmloff/source/transform/TransformerTokenMap.hxx
index ec4cf09..b3a05a1 100644
--- a/xmloff/source/transform/TransformerTokenMap.hxx
+++ b/xmloff/source/transform/TransformerTokenMap.hxx
@@ -23,9 +23,6 @@
#include rtl/ustring.hxx
#include boost/unordered_map.hpp
#include xmloff/xmltoken.hxx
-#include TransformerTokenMap.hxx
-
-
class XMLTransformerTokenMap :
public ::boost::unordered_map OUString, ::xmloff::token::XMLTokenEnum,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: shell/Module_shell.mk
shell/Module_shell.mk |2 ++ 1 file changed, 2 insertions(+) New commits: commit 8b94b2e6d6f4d96b8f4b5da3471a66eed6b78af6 Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Wed Nov 5 17:10:16 2014 +0100 Don't add toolkit related shell packages with headless build Change-Id: Ib68bf02ef7065c76ff25f36b8c29a9a4b028b2e0 Reviewed-on: https://gerrit.libreoffice.org/12268 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/shell/Module_shell.mk b/shell/Module_shell.mk index 98f6c87..48c7cc3 100644 --- a/shell/Module_shell.mk +++ b/shell/Module_shell.mk @@ -112,6 +112,7 @@ $(eval $(call gb_Module_add_targets,shell,\ endif ifneq ($(filter-out MACOSX WNT,$(OS)),) +ifneq ($(ENABLE_HEADLESS),TRUE) $(eval $(call gb_Module_add_targets,shell,\ Executable_gnome_open_url \ @@ -122,6 +123,7 @@ $(eval $(call gb_Module_add_targets,shell,\ )) endif +endif ifneq ($(OS),WNT) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 2 commits - vcl/source vcl/workben
vcl/source/opengl/OpenGLHelper.cxx |3 ++-
vcl/workben/vcldemo.cxx| 29 -
2 files changed, 26 insertions(+), 6 deletions(-)
New commits:
commit 28d9d7dcfa62eeef9894c558ff97111d21a300e8
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 11:51:43 2014 +
vcldemo: cover more features.
Change-Id: I12341c28a5d8d8b1d9d5343eaff4a1a08700fadb
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index 1fdd751..65f143d 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -24,6 +24,11 @@
#include vcl/wrkwin.hxx
#include vcl/graphicfilter.hxx
+#if 0
+# define FIXME_ALPHA_WORKING
+# define FIXME_ROUNDED_RECT_WORKING
+#endif
+
using namespace css;
class DemoWin : public WorkWindow
@@ -96,9 +101,9 @@ public:
SetLineColor(Color(COL_RED));
//DrawPolyLine(aPoly);
}
-void drawPolyPoly(Rectangle r)
+void drawEllipse(Rectangle r)
{
-(void)r;
+DrawEllipse(r);
}
void drawCheckered(Rectangle r)
{
@@ -122,12 +127,22 @@ public:
}
void drawBitmapEx(Rectangle r)
{
+drawCheckered(r);
+
BitmapEx aBitmap(maIntro);
aBitmap.Scale(r.GetSize(), BMP_SCALE_BESTQUALITY);
+#ifdef FIXME_ALPHA_WORKING
+AlphaMask aSemiTransp(aBitmap.GetSizePixel());
+aSemiTransp.Erase(64);
+DrawBitmapEx(r.TopLeft(), BitmapEx(aBitmap.GetBitmap(),
+ aSemiTransp));
+#else
DrawBitmapEx(r.TopLeft(), aBitmap);
+#endif
}
void fetchDrawBitmap(Rectangle r)
{
+// FIXME: should work ...
Bitmap aBitmap(GetBitmap(Point(0,0),GetSizePixel()));
aBitmap.Scale(r.GetSize(), BMP_SCALE_BESTQUALITY);
DrawBitmap(r.TopLeft(), aBitmap);
@@ -158,9 +173,13 @@ std::vectorRectangle DemoWin::partitionAndClear(int nX,
int nY)
if ((x + y) % 2)
DrawRect(r);
else
+{
+#ifdef FIXME_ROUNDED_RECT_WORKING
+DrawRect(r, nBorderSize, nBorderSize);
+#else
DrawRect(r);
-// FIXME: rendering these guys doesn't work at all
-// DrawRect(r, nBorderSize, nBorderSize);
+#endif
+}
aRegions.push_back(r);
}
@@ -181,7 +200,7 @@ void DemoWin::Paint( const Rectangle rRect )
drawRadialLines(aRegions[i++]);
drawText(aRegions[i++]);
drawPoly(aRegions[i++]);
-drawPolyPoly(aRegions[i++]);
+drawEllipse(aRegions[i++]);
drawCheckered(aRegions[i++]);
drawBitmapEx(aRegions[i++]);
drawBitmap(aRegions[i++]);
commit e2ed91f2e0f7c3e530ac4ad0ea231198dc20979c
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 11:34:31 2014 +
Make it easy to disable OpenGL in the environment.
Change-Id: I9ea0c9f7345e0cbad9ebb51ab724dada7ce77106
diff --git a/vcl/source/opengl/OpenGLHelper.cxx
b/vcl/source/opengl/OpenGLHelper.cxx
index e30d607..4705e3f 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -360,7 +360,8 @@ void OpenGLHelper::checkGLError(const char* pFile, size_t
nLine)
bool OpenGLHelper::supportsVCLOpenGL()
{
-return true;
+static bool bDisableGL = !getenv(SAL_DISABLEGL);
+return bDisableGL;
}
#if defined UNX !defined MACOSX !defined IOS !defined ANDROID
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build broken with --enable-headless
Hi Riccardo, Thanks for the patch. I think a little modification is required. $(if $(ENABLE_HEADLESS),, \ must be modified to: $(if ! $(ENABLE_HEADLESS),, \ Also after making this change I got this error: Test name: testFdo37606Copy::Import equality assertion failed - Expected: 2 - Actual : 1 Failures !!! Run: 20 Failure total: 1 Failures: 1 Errors: 0 Error: a unit test failed, please do one of: export DEBUGCPPUNIT=TRUE# for exception catching export CPPUNITTRACE=gdb --args # for interactive debugging on linux export CPPUNITTRACE=[full path to devenv.exe] /debugexe # for interactive debugging in Visual Studio export VALGRIND=memcheck# for memory checking and retry using: make CppunitTest_sw_odfimport /usr/local/google/home/tarungoyal/Downloads/libreoffice_4_2/core/solenv/gbuild/CppunitTest.mk:77: recipe for target '/usr/local/google/home/tarungoyal/Downloads/libreoffice_4_2/core/workdir/CppunitTest/sw_odfimport.test' failed make[1]: *** [/usr/local/google/home/tarungoyal/Downloads/libreoffice_4_2/core/workdir/CppunitTest/sw_odfimport.test] Error 1 make[1]: *** Waiting for unfinished jobs Makefile:217: recipe for target 'build' failed make: *** [build] Error 2 On following the given instructions it still fails. Thanks, Tarun -- View this message in context: http://nabble.documentfoundation.org/Build-broken-with-enable-headless-tp4128038p4128371.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: avmedia/Library_avmediagst.mk avmedia/Module_avmedia.mk config_host.mk.in configure.ac postprocess/Rdb_services.mk Repository.mk
Repository.mk |2 - avmedia/Library_avmediagst.mk |4 +-- avmedia/Module_avmedia.mk |2 - config_host.mk.in |6 ++--- configure.ac | 46 +- postprocess/Rdb_services.mk |2 - 6 files changed, 31 insertions(+), 31 deletions(-) New commits: commit 65a00c71a5e3a8cdd74ac1a557208e183e23cf01 Author: Jan-Marek Glogowski glo...@fbihome.de Date: Fri Oct 10 23:15:28 2014 +0200 Clarify configure GStreamer handling Currrently --disables-gstreamer disables GStreamer API 1.0 support and --enable-gstreamer-0-10 enables GStreamer API 0.10 support. To build with GStreamer API 0.10 you need to --disable-gstreamer and --enable-gstreamer-0-10, which doesn't seem logical. But actually it's possible to build both avmedia GStreamer backends, so this changes: * --disable-gstreamer to --disable-gstreamer-1-0 * configure variables to include the GStreamer API version 1_0 * adapts the configure help text Change-Id: Icffd8cfb9d80b3021e290675e7c9644c2a31fce8 Reviewed-on: https://gerrit.libreoffice.org/11912 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/Repository.mk b/Repository.mk index 0e7b9b9..fd05e11 100644 --- a/Repository.mk +++ b/Repository.mk @@ -592,7 +592,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_NONE, \ $(eval $(call gb_Helper_register_libraries_for_install,PLAINLIBS_OOO,ooo, \ $(if $(ENABLE_VLC),avmediavlc) \ - $(if $(ENABLE_GSTREAMER),avmediagst) \ + $(if $(ENABLE_GSTREAMER_1_0),avmediagst) \ $(if $(ENABLE_GSTREAMER_0_10),avmediagst_0_10) \ $(if $(ENABLE_DIRECTX),avmediawin) \ $(if $(ENABLE_GLTF),avmediaogl) \ diff --git a/avmedia/Library_avmediagst.mk b/avmedia/Library_avmediagst.mk index 42a6a49..9eae219 100644 --- a/avmedia/Library_avmediagst.mk +++ b/avmedia/Library_avmediagst.mk @@ -14,9 +14,9 @@ $(eval $(call gb_Library_set_componentfile,avmediagst,avmedia/source/gstreamer/a $(eval $(call gb_Library_set_include,avmediagst,\ $$(INCLUDE) \ -I$(SRCDIR)/avmedia/source/inc \ - $(GSTREAMER_CFLAGS) \ + $(GSTREAMER_1_0_CFLAGS) \ )) -$(eval $(call gb_Library_add_libs,avmediagst,$(GSTREAMER_LIBS))) +$(eval $(call gb_Library_add_libs,avmediagst,$(GSTREAMER_1_0_LIBS))) $(eval $(call gb_Library_use_external,avmediagst,boost_headers)) diff --git a/avmedia/Module_avmedia.mk b/avmedia/Module_avmedia.mk index f0108e5..06af36f 100644 --- a/avmedia/Module_avmedia.mk +++ b/avmedia/Module_avmedia.mk @@ -17,7 +17,7 @@ $(eval $(call gb_Module_add_l10n_targets,avmedia,\ AllLangResTarget_avmedia \ )) -ifeq ($(ENABLE_GSTREAMER),TRUE) +ifeq ($(ENABLE_GSTREAMER_1_0),TRUE) $(eval $(call gb_Module_add_targets,avmedia,\ Library_avmediagst \ )) diff --git a/config_host.mk.in b/config_host.mk.in index 98dad1d..7a5d42a 100644 --- a/config_host.mk.in +++ b/config_host.mk.in @@ -134,8 +134,8 @@ export ENABLE_GLTF=@ENABLE_GLTF@ export SYSTEM_LIBGLTF=@SYSTEM_LIBGLTF@ export LIBGLTF_CFLAGS=@LIBGLTF_CFLAGS@ export LIBGLTF_LIBS=@LIBGLTF_LIBS@ -export ENABLE_GSTREAMER=@ENABLE_GSTREAMER@ export ENABLE_GSTREAMER_0_10=@ENABLE_GSTREAMER_0_10@ +export ENABLE_GSTREAMER_1_0=@ENABLE_GSTREAMER_1_0@ export ENABLE_GTK3=@ENABLE_GTK3@ export ENABLE_GTK=@ENABLE_GTK@ export ENABLE_GTK_PRINT=@ENABLE_GTK_PRINT@ @@ -227,8 +227,8 @@ export HARFBUZZ_LIBS=$(gb_SPACE)@HARFBUZZ_LIBS@ export GSSAPI_LIBS=@GSSAPI_LIBS@ export GSTREAMER_0_10_CFLAGS=$(gb_SPACE)@GSTREAMER_0_10_CFLAGS@ export GSTREAMER_0_10_LIBS=$(gb_SPACE)@GSTREAMER_0_10_LIBS@ -export GSTREAMER_CFLAGS=$(gb_SPACE)@GSTREAMER_CFLAGS@ -export GSTREAMER_LIBS=$(gb_SPACE)@GSTREAMER_LIBS@ +export GSTREAMER_1_0_CFLAGS=$(gb_SPACE)@GSTREAMER_1_0_CFLAGS@ +export GSTREAMER_1_0_LIBS=$(gb_SPACE)@GSTREAMER_1_0_LIBS@ export GTHREAD_CFLAGS=$(gb_SPACE)@GTHREAD_CFLAGS@ export GTHREAD_LIBS=$(gb_SPACE)@GTHREAD_LIBS@ export GTK3_CFLAGS=$(gb_SPACE)@GTK3_CFLAGS@ diff --git a/configure.ac b/configure.ac index b06f16b..b1fada1 100644 --- a/configure.ac +++ b/configure.ac @@ -542,12 +542,11 @@ case $host_os in solaris*) test_gtk=yes -build_gstreamer=yes +build_gstreamer_1_0=yes build_gstreamer_0_10=yes test_tde=yes test_kde=yes test_freetype=yes -test_gstreamer=yes _os=SunOS dnl === @@ -572,7 +571,7 @@ solaris*) linux-gnu*|k*bsd*-gnu*) test_gtk=yes -build_gstreamer=yes +build_gstreamer_1_0=yes build_gstreamer_0_10=yes test_tde=yes test_kde=yes @@ -665,7 +664,7 @@ darwin*) # Mac OS X or iOS freebsd*) test_gtk=yes -build_gstreamer=yes +build_gstreamer_1_0=yes build_gstreamer_0_10=yes test_tde=yes test_kde=yes @@ -695,7 +694,7 @@ freebsd*) *netbsd*) test_gtk=yes -build_gstreamer=yes +
Re: Useless includes (maybe...)
On 11/07/2014 11:02 AM, Juergen Funk Mailinglist wrote: i mean the construct (void) bSuccess; assert(bSuccess); is a little bit ugly That's a well-known shortcoming of standard C assert, inherited by C++. See http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4154.pdf Operator assert for a potential way this may change in a future C++ standard. (And our own SAL_WARN etc. macros are careful to avoid this problem, but their semantics are different from those of standard assert.) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/opengl vcl/workben
vcl/opengl/gdiimpl.cxx |3 ++-
vcl/opengl/texture.cxx |4
vcl/workben/vcldemo.cxx | 16 ++--
3 files changed, 20 insertions(+), 3 deletions(-)
New commits:
commit 8d47d7a6be0fbc577686a9e918f087a2bf7602fc
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 12:33:15 2014 +
vcldemo - test the drawAlphaRect method.
Change-Id: I05e62b57c9b1cbdd89dc32b73b9db26a3c65
diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx
index 868728d..6d794ef 100644
--- a/vcl/opengl/gdiimpl.cxx
+++ b/vcl/opengl/gdiimpl.cxx
@@ -734,7 +734,8 @@ void OpenGLSalGraphicsImpl::drawMask(
SalBitmap* OpenGLSalGraphicsImpl::getBitmap( long nX, long nY, long nWidth,
long nHeight )
{
OpenGLSalBitmap* pBitmap = new OpenGLSalBitmap;
-SAL_INFO( vcl.opengl, ::getBitmap );
+SAL_INFO( vcl.opengl, ::getBitmap nX , nY
+ nWidth x nHeight );
if( !pBitmap-Create( maContext, nX, nY, nWidth, nHeight ) )
{
delete pBitmap;
diff --git a/vcl/opengl/texture.cxx b/vcl/opengl/texture.cxx
index ad1b8c9..2770c20 100644
--- a/vcl/opengl/texture.cxx
+++ b/vcl/opengl/texture.cxx
@@ -18,6 +18,8 @@
*/
#include sal/config.h
+#include vcl/opengl/OpenGLHelper.hxx
+
#include vcl/salbtype.hxx
#include opengl/texture.hxx
@@ -59,7 +61,9 @@ OpenGLTexture::OpenGLTexture( int nX, int nY, int nWidth, int
nHeight )
glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST );
glTexParameteri( GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST );
glCopyTexImage2D( GL_TEXTURE_2D, 0, GL_RGBA, nX, nY, nWidth, nHeight, 0 );
+CHECK_GL_ERROR();
glBindTexture( GL_TEXTURE_2D, 0 );
+CHECK_GL_ERROR();
}
OpenGLTexture::OpenGLTexture( int nWidth, int nHeight, int nFormat, int nType,
sal_uInt8* pData )
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index 65f143d..b58c70f 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -97,9 +97,21 @@ public:
void drawPoly(Rectangle r) // pretty
{
-Polygon aPoly(r, r.TopLeft(), r.TopRight());
+drawCheckered(r);
+
+long nDx = r.GetWidth()/20;
+long nDy = r.GetHeight()/20;
+Rectangle aShrunk(r);
+aShrunk.Move(nDx, nDy);
+aShrunk.SetSize(Size(r.GetWidth()-nDx*2,
+ r.GetHeight()-nDy*2));
+Polygon aPoly(aShrunk);
+tools::PolyPolygon aPPoly(aPoly);
SetLineColor(Color(COL_RED));
-//DrawPolyLine(aPoly);
+SetFillColor(Color(COL_RED));
+// This hits the 'drawAlphaRect' code-path
+// FIXME: not alpha ...
+DrawTransparent(aPPoly, 64);
}
void drawEllipse(Rectangle r)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - avmedia/source basctl/source chart2/source dbaccess/source extensions/source include/svx include/vcl o3tl/qa sc/source sd/source sfx2/source svtools/source
avmedia/source/viewer/mediaevent_impl.cxx |8 -
basctl/source/basicide/bastypes.cxx|2
chart2/source/controller/main/ChartController_TextEdit.cxx |2
chart2/source/controller/main/ChartController_Window.cxx |2
dbaccess/source/ui/app/AppDetailPageHelper.cxx |4
dbaccess/source/ui/control/toolboxcontroller.cxx |2
extensions/source/bibliography/toolbar.cxx |2
include/svx/svdview.hxx| 10 +-
include/vcl/event.hxx | 61 +++--
o3tl/qa/test-typed_flags.cxx |1
sc/source/ui/drawfunc/fudraw.cxx |2
sc/source/ui/drawfunc/fupoor.cxx |2
sc/source/ui/drawfunc/futext.cxx |2
sc/source/ui/navipi/navipi.cxx |2
sc/source/ui/view/gridwin.cxx |4
sc/source/ui/view/gridwin5.cxx |2
sd/source/ui/func/fudraw.cxx |2
sd/source/ui/func/fuediglu.cxx | 10 +-
sd/source/ui/func/fupoor.cxx |4
sd/source/ui/func/fusel.cxx| 10 +-
sfx2/source/statbar/stbitem.cxx|6 -
svtools/source/brwbox/brwbox2.cxx |9 -
svtools/source/brwbox/datwin.cxx |2
svtools/source/contnr/treelistbox.cxx |2
svtools/source/control/tabbar.cxx |4
svx/source/dialog/connctrl.cxx |2
svx/source/fmcomp/gridcell.cxx |2
svx/source/svdraw/svdview.cxx |2
toolkit/source/awt/vclxwindow.cxx |4
vcl/inc/window.h |5 -
vcl/source/window/mouse.cxx|6 -
vcl/source/window/mouseevent.cxx |6 -
vcl/source/window/toolbox.cxx |6 -
vcl/source/window/window.cxx |2
vcl/source/window/window2.cxx | 10 +-
vcl/source/window/winproc.cxx | 33 +++
36 files changed, 127 insertions(+), 108 deletions(-)
New commits:
commit 31d902d3c00fdc5f088aff433b7ebf308a718339
Author: Noel Grandin n...@peralex.com
Date: Fri Nov 7 12:30:39 2014 +0200
fdo#84938: replace MOUSE_ modifier constants with enum
and make the two categories of constants non-overlapping, we
really don't need to risk confusion in order to save 6 bits in
a data structure like this.
Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
diff --git a/avmedia/source/viewer/mediaevent_impl.cxx
b/avmedia/source/viewer/mediaevent_impl.cxx
index 2db8831..86e1817 100644
--- a/avmedia/source/viewer/mediaevent_impl.cxx
+++ b/avmedia/source/viewer/mediaevent_impl.cxx
@@ -107,7 +107,7 @@ void SAL_CALL MediaEventListenersImpl::mousePressed( const
::com::sun::star::awt
{
MouseEvent aVCLMouseEvt( Point( e.X, e.Y ),
sal::static_int_cast sal_uInt16
(e.ClickCount),
- 0,
+ MouseEventModifiers::NONE,
( ( e.Buttons 1 ) ? MOUSE_LEFT : 0 ) |
( ( e.Buttons 2 ) ? MOUSE_RIGHT : 0 ) |
( ( e.Buttons 4 ) ? MOUSE_MIDDLE : 0 ),
@@ -128,7 +128,7 @@ void SAL_CALL MediaEventListenersImpl::mouseReleased( const
::com::sun::star::aw
{
MouseEvent aVCLMouseEvt( Point( e.X, e.Y ),
sal::static_int_cast sal_uInt16
(e.ClickCount),
- 0,
+ MouseEventModifiers::NONE,
( ( e.Buttons 1 ) ? MOUSE_LEFT : 0 ) |
( ( e.Buttons 2 ) ? MOUSE_RIGHT : 0 ) |
( ( e.Buttons 4 ) ? MOUSE_MIDDLE : 0 ),
@@ -173,7 +173,7 @@ void SAL_CALL MediaEventListenersImpl::mouseDragged( const
::com::sun::star::awt
if( mpNotifyWindow )
{
-MouseEvent aVCLMouseEvt( Point( e.X, e.Y ), 0, 0, e.Buttons,
e.Modifiers );
+MouseEvent aVCLMouseEvt( Point( e.X, e.Y ), 0,
MouseEventModifiers::NONE, e.Buttons, e.Modifiers );
Application::PostMouseEvent( VCLEVENT_WINDOW_MOUSEMOVE,
reinterpret_cast vcl::Window* ( mpNotifyWindow ), aVCLMouseEvt );
}
}
@@ -188,7 +188,7 @@ void SAL_CALL MediaEventListenersImpl::mouseMoved( const
::com::sun::star::awt::
if( mpNotifyWindow )
{
-MouseEvent aVCLMouseEvt( Point( e.X, e.Y ), 0, 0,
[Bug 84938] replace #defined constants with ‘enum class’
https://bugs.freedesktop.org/show_bug.cgi?id=84938 --- Comment #4 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Noel Grandin committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=31d902d3c00fdc5f088aff433b7ebf308a718339 fdo#84938: replace MOUSE_ modifier constants with enum It will be available in 4.4.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'private/tml/opencl-default-1' - 7 commits - officecfg/registry sc/inc sc/source sc/uiconfig
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |2
sc/inc/calcconfig.hxx| 72 +
sc/source/core/tool/calcconfig.cxx | 56 ++--
sc/source/core/tool/formulaopt.cxx | 62
sc/source/ui/optdlg/calcoptionsdlg.cxx | 190 ++-
sc/source/ui/optdlg/calcoptionsdlg.hxx | 22 +
sc/uiconfig/scalc/ui/formulacalculationoptions.ui| 22 -
7 files changed, 301 insertions(+), 125 deletions(-)
New commits:
commit 7452ba318b677587be018ba8d0afa7c9966a3fce
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 7 15:08:07 2014 +0200
Make it possible to actually edit existing white/black list entries
Still not possible to add new ones or delete existing ones, though. And the
UI
for this is not finished at all. Work in progress.
Also some refactoring. To increase readability, introduce typedefs in
ScCalcConfig. Not sure whether nested types inside the class is a good idea
or
not.
Change-Id: I8e1695bb0594e2cd5f8b5ce0ece075842b77762a
diff --git a/sc/inc/calcconfig.hxx b/sc/inc/calcconfig.hxx
index 1a4c62c..4b72dc8 100644
--- a/sc/inc/calcconfig.hxx
+++ b/sc/inc/calcconfig.hxx
@@ -101,10 +101,15 @@ struct SC_DLLPUBLIC ScCalcConfig
bool mbOpenCLAutoSelect:1;
OUString maOpenCLDevice;
sal_Int32 mnOpenCLMinimumFormulaGroupSize;
-std::setOpCodeEnum maOpenCLSubsetOpCodes;
-std::setOpenCLImpl maOpenCLWhiteList;
-std::setOpenCLImpl maOpenCLBlackList;
+typedef std::setOpCodeEnum OpCodeSet;
+
+OpCodeSet maOpenCLSubsetOpCodes;
+
+typedef std::setOpenCLImpl OpenCLImplSet;
+
+OpenCLImplSet maOpenCLWhiteList;
+OpenCLImplSet maOpenCLBlackList;
ScCalcConfig();
@@ -117,11 +122,13 @@ struct SC_DLLPUBLIC ScCalcConfig
bool operator!= (const ScCalcConfig r) const;
};
+SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImpl rImpl);
+SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImplSet rSet);
SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig rConfig);
-SC_DLLPUBLIC OUString ScOpCodeSetToNumberString(const std::setOpCodeEnum
rOpCodes);
-SC_DLLPUBLIC OUString ScOpCodeSetToSymbolicString(const std::setOpCodeEnum
rOpCodes);
-SC_DLLPUBLIC std::setOpCodeEnum ScStringToOpCodeSet(const OUString
rOpCodes);
+SC_DLLPUBLIC OUString ScOpCodeSetToNumberString(const ScCalcConfig::OpCodeSet
rOpCodes);
+SC_DLLPUBLIC OUString ScOpCodeSetToSymbolicString(const
ScCalcConfig::OpCodeSet rOpCodes);
+SC_DLLPUBLIC ScCalcConfig::OpCodeSet ScStringToOpCodeSet(const OUString
rOpCodes);
#endif
diff --git a/sc/source/core/tool/calcconfig.cxx
b/sc/source/core/tool/calcconfig.cxx
index 5fd4aec..583c2a3 100644
--- a/sc/source/core/tool/calcconfig.cxx
+++ b/sc/source/core/tool/calcconfig.cxx
@@ -82,27 +82,32 @@ bool ScCalcConfig::operator!= (const ScCalcConfig r) const
return !operator==(r);
}
-namespace {
+std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImpl rImpl)
+{
+rStream {
+OS= rImpl.maOS ,
+OSVersion= rImpl.maOSVersion ,
+PlatformVendor= rImpl.maPlatformVendor ,
+Device= rImpl.maDevice ,
+DriverVersion= rImpl.maDriverVersion
+};
-std::ostream operator(std::ostream rStream, const
std::setScCalcConfig::OpenCLImpl rSet)
+return rStream;
+}
+
+std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImplSet rSet)
{
+rStream {;
for (auto i = rSet.cbegin(); i != rSet.cend(); ++i)
{
if (i != rSet.cbegin())
rStream ,;
-rStream {
-OS= (*i).maOS ,
-OSVersion= (*i).maOSVersion ,
-PlatformVendor= (*i).maPlatformVendor ,
-Device= (*i).maDevice ,
-DriverVersion= (*i).maDriverVersion
-};
+rStream *i;
}
+rStream };
return rStream;
}
-} // anonymous namespace
-
std::ostream operator(std::ostream rStream, const ScCalcConfig rConfig)
{
rStream {
@@ -115,8 +120,8 @@ std::ostream operator(std::ostream rStream, const
ScCalcConfig rConfig)
OpenCLDevice=' rConfig.maOpenCLDevice ',
OpenCLMinimumFormulaGroupSize=
rConfig.mnOpenCLMinimumFormulaGroupSize ,
OpenCLSubsetOpCodes={
ScOpCodeSetToSymbolicString(rConfig.maOpenCLSubsetOpCodes) },
-OpenCLWhiteList={ rConfig.maOpenCLWhiteList },
-OpenCLBlackList={ rConfig.maOpenCLBlackList }
+OpenCLWhiteList= rConfig.maOpenCLWhiteList ,
+OpenCLBlackList= rConfig.maOpenCLBlackList
};
return rStream;
}
@@ -140,7 +145,7 @@ formula::FormulaCompiler::OpCodeMapPtr setup()
} // anonymous namespace
-OUString ScOpCodeSetToNumberString(const std::setOpCodeEnum rOpCodes)
+OUString ScOpCodeSetToNumberString(const
[Libreoffice-commits] core.git: distro-configs/LibreOfficeAndroidAarch64.conf distro-configs/LibreOfficeAndroid.conf distro-configs/LibreOfficeAndroidX86.conf distro-configs/LibreOfficeLinux.conf
distro-configs/LibreOfficeAndroid.conf|2 +- distro-configs/LibreOfficeAndroidAarch64.conf |2 +- distro-configs/LibreOfficeAndroidX86.conf |2 +- distro-configs/LibreOfficeLinux.conf |2 +- 4 files changed, 4 insertions(+), 4 deletions(-) New commits: commit c7ae999bb7cfc03652ab7368f54c6e751f22b53f Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com Date: Fri Nov 7 14:52:32 2014 +0100 rename --disable-gstreamer â --disable-gstreamer-1-0 Change-Id: I9f1e0ae2d5ac71ea7e9edb06d3719d626adb80a4 diff --git a/distro-configs/LibreOfficeAndroid.conf b/distro-configs/LibreOfficeAndroid.conf index 5ec2d22..409ee62 100644 --- a/distro-configs/LibreOfficeAndroid.conf +++ b/distro-configs/LibreOfficeAndroid.conf @@ -4,7 +4,7 @@ --disable-gconf --disable-gnome-vfs --disable-gstreamer-0-10 ---disable-gstreamer +--disable-gstreamer-1-0 --disable-liblangtag --disable-lockdown --disable-odk diff --git a/distro-configs/LibreOfficeAndroidAarch64.conf b/distro-configs/LibreOfficeAndroidAarch64.conf index 3871acf..ead8073 100644 --- a/distro-configs/LibreOfficeAndroidAarch64.conf +++ b/distro-configs/LibreOfficeAndroidAarch64.conf @@ -4,7 +4,7 @@ --disable-gconf --disable-gnome-vfs --disable-gstreamer-0-10 ---disable-gstreamer +--disable-gstreamer-1-0 --disable-liblangtag --disable-lockdown --disable-odk diff --git a/distro-configs/LibreOfficeAndroidX86.conf b/distro-configs/LibreOfficeAndroidX86.conf index c03858b..7d13428 100644 --- a/distro-configs/LibreOfficeAndroidX86.conf +++ b/distro-configs/LibreOfficeAndroidX86.conf @@ -4,7 +4,7 @@ --disable-gconf --disable-gnome-vfs --disable-gstreamer-0-10 ---disable-gstreamer +--disable-gstreamer-1-0 --disable-liblangtag --disable-lockdown --disable-odk diff --git a/distro-configs/LibreOfficeLinux.conf b/distro-configs/LibreOfficeLinux.conf index 451df4e..6974db7 100644 --- a/distro-configs/LibreOfficeLinux.conf +++ b/distro-configs/LibreOfficeLinux.conf @@ -24,7 +24,7 @@ --enable-lockdown --enable-kde --enable-gstreamer-0-10 ---disable-gstreamer +--disable-gstreamer-1-0 --enable-evolution2 --enable-gnome-vfs --enable-scripting-beanshell ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] buildbot.git: bin/push_nightlies.sh
bin/push_nightlies.sh |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
New commits:
commit fd188bda674ab20148dadcd802bcbbc78b8ca921
Author: Christian Lohmaier lohmaier+git...@googlemail.com
Date: Fri Nov 7 12:00:27 2014 +0100
INPATH wath removed a year ago..
diff --git a/bin/push_nightlies.sh b/bin/push_nightlies.sh
index a737f2b..a4ec16e 100755
--- a/bin/push_nightlies.sh
+++ b/bin/push_nightlies.sh
@@ -76,7 +76,11 @@ fi
topdir=$PWD
-cd instsetoo_native/${INPATH}
+if [ -z $INPATH ] ; then
+false
+else
+cd instsetoo_native/${INPATH}
+fi
if [ $? != 0 ]; then
cd workdir
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build broken with --enable-headless
Il 07/11/2014 12:51, tarungoyal ha scritto: Hi Riccardo, Thanks for the patch. I think a little modification is required. $(if $(ENABLE_HEADLESS),, \ must be modified to: $(if ! $(ENABLE_HEADLESS),, \ Nope, the original patch was fine :) The if syntax is: conditional,true branch,false branch Also after making this change I got this error: Test name: testFdo37606Copy::Import equality assertion failed - Expected: 2 - Actual : 1 Failures !!! Run: 20 Failure total: 1 Failures: 1 Errors: 0 I'd say that it's fine for us to ignore that since it's a cp bug where we well maybe not implementing all the interfaces. thanks, riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/qa sd/qa sw/qa
sc/qa/unit/subsequent_export-test.cxx |4 ++--
sd/qa/unit/export-tests.cxx|8
sw/qa/extras/globalfilter/globalfilter.cxx |4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
New commits:
commit aeebbec4e8fb77a24b231362844d5a3f0f05e3c2
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Fri Nov 7 15:16:59 2014 +0100
Build fix: back to C++98
Change-Id: I5aa74c17f3274a130f76a25fc7bbb184b3f5c69b
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 7c1de6b..2d74ed5 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -2265,7 +2265,7 @@ void ScExportTest::testFunctionsExcel2010ODS()
void ScExportTest::testSwappedOutImageExport()
{
-std::vectorOUString aFilterNames = {
+const OUString aFilterNames[] = {
calc8,
MS Excel 97,
Calc Office Open XML,
@@ -2277,7 +2277,7 @@ void ScExportTest::testSwappedOutImageExport()
officecfg::Office::Common::Cache::GraphicManager::TotalCacheSize::set(sal_Int32(1),
xBatch);
xBatch-commit();
-for( size_t nFilter = 0; nFilter aFilterNames.size(); ++nFilter )
+for( size_t nFilter = 0; nFilter 4; ++nFilter )
{
// Check whether the export code swaps in the image which was swapped
out before.
ScDocShellRef xDocSh = loadDoc(document_with_two_images., ODS);
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index e907e47..c1caa46 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -498,7 +498,7 @@ void SdExportTest::testFdo79731()
void SdExportTest::testSwappedOutImageExport()
{
// Problem was with the swapped out images, which were not swapped in
during export.
-static const std::vectorsal_Int32 vFormats = {
+const sal_Int32 vFormats[] = {
ODP,
PPT,
PPTX,
@@ -509,17 +509,17 @@ void SdExportTest::testSwappedOutImageExport()
officecfg::Office::Common::Cache::GraphicManager::TotalCacheSize::set(sal_Int32(1),
xBatch);
xBatch-commit();
-for( size_t nExportFormat = 0; nExportFormat vFormats.size();
++nExportFormat )
+for( size_t nExportFormat = 0; nExportFormat 3; ++nExportFormat )
{
// Load the original file with one image
::sd::DrawDocShellRef xDocShRef =
loadURL(getURLFromSrc(/sd/qa/unit/data/odp/document_with_two_images.odp),
ODP);
-const OString sFailedMessage = OString(Failed on filter: ) +
OString(aFileFormats[nExportFormat].pFilterName);
+const OString sFailedMessage = OString(Failed on filter: ) +
OString(aFileFormats[nExportFormat]].pFilterName);
// Export the document and import again for a check
uno::Reference lang::XComponent xComponent(xDocShRef-GetModel(),
uno::UNO_QUERY);
uno::Referenceframe::XStorable xStorable(xComponent, uno::UNO_QUERY);
utl::MediaDescriptor aMediaDescriptor;
-aMediaDescriptor[FilterName] =
OStringToOUString(OString(aFileFormats[nExportFormat].pFilterName),
RTL_TEXTENCODING_UTF8);
+aMediaDescriptor[FilterName] =
OStringToOUString(OString(aFileFormats[vFormats[nExportFormat]].pFilterName),
RTL_TEXTENCODING_UTF8);
utl::TempFile aTempFile;
aTempFile.EnableKillingFile();
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx
b/sw/qa/extras/globalfilter/globalfilter.cxx
index 6a28692..af5b2fa 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -33,14 +33,14 @@ public:
void Test::testSwappedOutImageExport()
{
-std::vectorOUString aFilterNames = {
+const OUString aFilterNames[] = {
writer8,
Rich Text Format,
MS Word 97,
Office Open XML Text,
};
-for( size_t nFilter = 0; nFilter aFilterNames.size(); ++nFilter )
+for( size_t nFilter = 0; nFilter 4; ++nFilter )
{
// Check whether the export code swaps in the image which was swapped
out before by auto mechanism
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/opengl
vcl/opengl/gdiimpl.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9084d7be36f3955725e2395ae176d2af1ceac358 Author: Michael Meeks michael.me...@collabora.com Date: Fri Nov 7 14:33:48 2014 + vcl: vertically invert line and point positions Change-Id: I306e44cfe287b573c9664662c170f96d3fb09e6a diff --git a/vcl/opengl/gdiimpl.cxx b/vcl/opengl/gdiimpl.cxx index 6d794ef..2d520ea 100644 --- a/vcl/opengl/gdiimpl.cxx +++ b/vcl/opengl/gdiimpl.cxx @@ -252,7 +252,7 @@ void OpenGLSalGraphicsImpl::DrawPoint( long nX, long nY ) GLushort pPoint[2]; pPoint[0] = nX; -pPoint[1] = nY; +pPoint[1] = GetHeight() - nY; glEnableVertexAttribArray( GL_ATTRIB_POS ); glVertexAttribPointer( GL_ATTRIB_POS, 2, GL_UNSIGNED_SHORT, GL_FALSE, 0, pPoint ); @@ -265,9 +265,9 @@ void OpenGLSalGraphicsImpl::DrawLine( long nX1, long nY1, long nX2, long nY2 ) GLfloat pPoints[4]; pPoints[0] = (2 * nX1) / GetWidth() - 1.0; -pPoints[1] = (2 * nY1) / GetHeight() - 1.0; +pPoints[1] = (2 * (GetHeight() - nY1)) / GetHeight() - 1.0; pPoints[2] = (2 * nX2) / GetWidth() - 1.0;; -pPoints[3] = (2 * nY2) / GetHeight() - 1.0; +pPoints[3] = (2 * (GetHeight() - nY2)) / GetHeight() - 1.0; glEnableVertexAttribArray( GL_ATTRIB_POS ); glVertexAttribPointer( GL_ATTRIB_POS, 2, GL_FLOAT, GL_FALSE, 0, pPoints ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/inc/cuicharmap.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8da62747d0d870db3b9746b765d18b2a62e4b31b Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 7 14:30:50 2014 + Resolves: fdo#85939 its not an OKButton anymore Change-Id: Idecd7dc056749b2135e0690c54560aedf7f653a2 diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx index ebc6df7..a2e30e5 100644 --- a/cui/source/inc/cuicharmap.hxx +++ b/cui/source/inc/cuicharmap.hxx @@ -70,7 +70,7 @@ private: SvxShowCharSet* m_pShowSet; Edit* m_pShowText; -OKButton* m_pOKBtn; +PushButton* m_pOKBtn; FixedText* m_pFontText; ListBox*m_pFontLB; FixedText* m_pSubsetText; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/qa
sd/qa/unit/export-tests.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 673f3dfc3cc4190a01001280330ff0b63cd1cc7f
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Fri Nov 7 15:41:53 2014 +0100
Build fix again
Change-Id: Ia3ddea84b022a34709b6be14afb105bedeef0553
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index c1caa46..244c4e8 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -513,7 +513,7 @@ void SdExportTest::testSwappedOutImageExport()
{
// Load the original file with one image
::sd::DrawDocShellRef xDocShRef =
loadURL(getURLFromSrc(/sd/qa/unit/data/odp/document_with_two_images.odp),
ODP);
-const OString sFailedMessage = OString(Failed on filter: ) +
OString(aFileFormats[nExportFormat]].pFilterName);
+const OString sFailedMessage = OString(Failed on filter: ) +
OString(aFileFormats[vFormats[nExportFormat]].pFilterName);
// Export the document and import again for a check
uno::Reference lang::XComponent xComponent(xDocShRef-GetModel(),
uno::UNO_QUERY);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - vcl/workben
vcl/workben/vcldemo.cxx | 56
1 file changed, 56 insertions(+)
New commits:
commit 0ec02a11bac301f07ca818875189ab3eaf713f14
Author: Michael Meeks michael.me...@collabora.com
Date: Fri Nov 7 15:11:38 2014 +
vcldemo: more interesting pieces, DrawPoint, DrawTransparent and more.
Change-Id: I77c6e5c54a9d0e71014e8c7905132a56e39a302a
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index b58c70f..b3c488c 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -27,6 +27,7 @@
#if 0
# define FIXME_ALPHA_WORKING
# define FIXME_ROUNDED_RECT_WORKING
+# define FIXME_DRAW_TRANSPARENT_WORKING
#endif
using namespace css;
@@ -85,6 +86,17 @@ public:
DrawLine( Point(r.Left(), r.Top()+i), Point(r.Right(),
r.Bottom()-i) );
for(int i=0; ir.GetWidth(); i+=15)
DrawLine( Point(r.Left()+i, r.Bottom()), Point(r.Right()-i,
r.Top()) );
+
+// Should draw a white-line across the middle
+Color aLastPixel( COL_WHITE );
+Point aCenter((r.Left() + r.Right())/2 - 4,
+ (r.Top() + r.Bottom())/2 - 4);
+for(int i=0; i8; i++)
+{
+DrawPixel(aCenter, aLastPixel);
+aLastPixel = GetPixel(aCenter);
+aCenter.Move(1,1);
+}
}
void drawText(Rectangle r)
@@ -152,6 +164,49 @@ public:
DrawBitmapEx(r.TopLeft(), aBitmap);
#endif
}
+void drawPolyPolgons(Rectangle r)
+{
+struct {
+double nX, nY;
+} aPoints[] = { { 0.1, 0.1 }, { 0.9, 0.9 },
+{ 0.9, 0.1 }, { 0.1, 0.9 },
+{ 0.1, 0.1 } };
+
+tools::PolyPolygon aPolyPoly;
+// Render 4x polygons aggregate into another PolyPolygon
+for (int x = 0; x 2; x++)
+{
+for (int y = 0; y 2; y++)
+{
+Rectangle aSubRect(r);
+aSubRect.Move(x * r.GetWidth()/3, y * r.GetHeight()/3);
+aSubRect.SetSize(Size(r.GetWidth()/2, r.GetHeight()/4));
+Polygon aPoly(SAL_N_ELEMENTS(aPoints));
+for (size_t v = 0; v SAL_N_ELEMENTS(aPoints); v++)
+{
+aPoly.SetPoint(Point(aSubRect.Left() +
+ aSubRect.GetWidth() * aPoints[v].nX,
+ aSubRect.Top() +
+ aSubRect.GetHeight() * aPoints[v].nY),
+ v);
+}
+SetLineColor(Color(COL_YELLOW));
+SetFillColor(Color(COL_BLACK));
+DrawPolygon(aPoly);
+
+// now move and add to the polypolygon
+aPoly.Move(0, r.GetHeight()/2);
+aPolyPoly.Insert(aPoly);
+}
+}
+SetLineColor(Color(COL_LIGHTRED));
+SetFillColor(Color(COL_GREEN));
+#ifdef FIXME_DRAW_TRANSPARENT_WORKING
+DrawTransparent(aPolyPoly, 50);
+#else
+DrawPolyPolygon(aPolyPoly);
+#endif
+}
void fetchDrawBitmap(Rectangle r)
{
// FIXME: should work ...
@@ -217,6 +272,7 @@ void DemoWin::Paint( const Rectangle rRect )
drawBitmapEx(aRegions[i++]);
drawBitmap(aRegions[i++]);
drawGradient(aRegions[i++]);
+drawPolyPolgons(aRegions[i++]);
// last - thumbnail all the above
fetchDrawBitmap(aRegions[i++]);
assert(i=12);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/tml/opencl-default-1' - sc/source
sc/source/ui/optdlg/calcoptionsdlg.cxx | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
New commits:
commit 180ad590fbf08968599cc833349c322d4bd4803b
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 7 17:35:52 2014 +0200
Update the white or black list when editing an entry
Must be careful to re-select the logically same entry even after it actually
has been removed and the edited on inserted.
Change-Id: Id19f7845fadbc018affab7a6cb6b421ed9170297
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index 8140eef..051cd98 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -308,19 +308,23 @@ void ScCalcOptionsDialog::fillOpenCLList()
namespace {
-void fillListBox(ListBox* pListBox, const ScCalcConfig::OpenCLImplSet
rSet)
+OUString format(const ScCalcConfig::OpenCLImpl rImpl)
+{
+return (rImpl.maOS + +
+rImpl.maOSVersion + +
+rImpl.maPlatformVendor + +
+rImpl.maDevice + +
+rImpl.maDriverVersion);
+}
+
+void fillListBox(ListBox* pListBox, const ScCalcConfig::OpenCLImplSet rSet)
{
pListBox-SetUpdateMode(false);
pListBox-Clear();
for (auto i = rSet.cbegin(); i != rSet.cend(); ++i)
{
-pListBox-InsertEntry((*i).maOS + +
- (*i).maOSVersion + +
- (*i).maPlatformVendor + +
- (*i).maDevice + +
- (*i).maDriverVersion,
- LISTBOX_APPEND);
+pListBox-InsertEntry(format(*i), LISTBOX_APPEND);
}
pListBox-SetUpdateMode(true);
@@ -799,6 +803,9 @@ void ScCalcOptionsDialog::EditFieldValueChanged(Control
*pCtrl)
rSet.erase(impl);
rSet.insert(newImpl);
+
+fillListBox(mpOpenCLWhiteAndBlackListBox, rSet);
+mpOpenCLWhiteAndBlackListBox-SelectEntry(format(newImpl));
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: forms/source
forms/source/component/ImageControl.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5771bde234ec65d79501d5eab938e06dfe43e232
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Fri Nov 7 16:53:47 2014 +0100
Try to fix ambiguity error
Change-Id: I93cf7497e52d065d00f762f61f79a4e8f8609bfc
diff --git a/forms/source/component/ImageControl.cxx
b/forms/source/component/ImageControl.cxx
index fc3b65a..193d69b 100644
--- a/forms/source/component/ImageControl.cxx
+++ b/forms/source/component/ImageControl.cxx
@@ -279,7 +279,7 @@ void
OImageControlModel::setFastPropertyValue_NoBroadcast(sal_Int32 nHandle, con
m_xGraphicObject.clear();
else
{
-m_xGraphicObject = GraphicObject::create( m_xContext );
+m_xGraphicObject = graphic::GraphicObject::create( m_xContext
);
m_xGraphicObject-setGraphic( xGraphic );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/qa sd/qa sw/qa
sc/qa/unit/subsequent_export-test.cxx |2 +-
sd/qa/unit/export-tests.cxx|2 +-
sw/qa/extras/globalfilter/globalfilter.cxx |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit b6a41916f351fd2d6c8934a9f35ec72159ee5009
Author: Zolnai Tamás tamas.zol...@collabora.com
Date: Fri Nov 7 17:01:08 2014 +0100
Use SAL_N_ELEMENTS
Change-Id: I3d26823a93fd0925ef5e71affd941cd51219ab9e
diff --git a/sc/qa/unit/subsequent_export-test.cxx
b/sc/qa/unit/subsequent_export-test.cxx
index 2d74ed5..87a5f21 100644
--- a/sc/qa/unit/subsequent_export-test.cxx
+++ b/sc/qa/unit/subsequent_export-test.cxx
@@ -2277,7 +2277,7 @@ void ScExportTest::testSwappedOutImageExport()
officecfg::Office::Common::Cache::GraphicManager::TotalCacheSize::set(sal_Int32(1),
xBatch);
xBatch-commit();
-for( size_t nFilter = 0; nFilter 4; ++nFilter )
+for( size_t nFilter = 0; nFilter SAL_N_ELEMENTS(aFilterNames); ++nFilter
)
{
// Check whether the export code swaps in the image which was swapped
out before.
ScDocShellRef xDocSh = loadDoc(document_with_two_images., ODS);
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index 244c4e8..dfa2edc 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -509,7 +509,7 @@ void SdExportTest::testSwappedOutImageExport()
officecfg::Office::Common::Cache::GraphicManager::TotalCacheSize::set(sal_Int32(1),
xBatch);
xBatch-commit();
-for( size_t nExportFormat = 0; nExportFormat 3; ++nExportFormat )
+for( size_t nExportFormat = 0; nExportFormat SAL_N_ELEMENTS(vFormats);
++nExportFormat )
{
// Load the original file with one image
::sd::DrawDocShellRef xDocShRef =
loadURL(getURLFromSrc(/sd/qa/unit/data/odp/document_with_two_images.odp),
ODP);
diff --git a/sw/qa/extras/globalfilter/globalfilter.cxx
b/sw/qa/extras/globalfilter/globalfilter.cxx
index af5b2fa..9f7d603 100644
--- a/sw/qa/extras/globalfilter/globalfilter.cxx
+++ b/sw/qa/extras/globalfilter/globalfilter.cxx
@@ -40,7 +40,7 @@ void Test::testSwappedOutImageExport()
Office Open XML Text,
};
-for( size_t nFilter = 0; nFilter 4; ++nFilter )
+for( size_t nFilter = 0; nFilter SAL_N_ELEMENTS(aFilterNames); ++nFilter
)
{
// Check whether the export code swaps in the image which was swapped
out before by auto mechanism
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: 'master' 'make check' lcov code coverage report
On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? 4.) If the make check (run the tests) fails, do you want the script to: a) continue running the other tests, do a 'make -k' a1) upload the report anyway; we rather have an incomplete report than nothing b) stop running the other tests, like a regular make b1) dont upload the report; we dont want incomplete reports. log an error or send an notification or something 5.) Should the script log its output somewhere ? 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? Also, I am currently running into an lcov/gcov issue (either lcov or gcc/gcov is giving problems) on my own Fedora vm's. It does not seem to be triggered with the version on the vm cloph provided, so it seems I can write the script but the issue needs to be investigated (sort of working on it as we speak) as it might be triggered sometime in the future with that gcc version as well I guess. - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 4 commits - officecfg/registry sc/inc sc/source sc/uiconfig
officecfg/registry/schema/org/openoffice/Office/Calc.xcs |2
sc/inc/calcconfig.hxx| 70 -
sc/source/core/tool/calcconfig.cxx | 44 ++-
sc/source/core/tool/formulaopt.cxx | 62 +++-
sc/source/ui/optdlg/calcoptionsdlg.cxx | 197 ++-
sc/source/ui/optdlg/calcoptionsdlg.hxx | 22 +
sc/uiconfig/scalc/ui/formulacalculationoptions.ui| 22 -
7 files changed, 300 insertions(+), 119 deletions(-)
New commits:
commit d156dd493c089ebe953348b3ae3668b233701fda
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 7 17:35:52 2014 +0200
Update the white or black list when editing an entry
Must be careful to re-select the logically same entry even after it actually
has been removed and the edited on inserted.
Change-Id: Id19f7845fadbc018affab7a6cb6b421ed9170297
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index 8140eef..051cd98 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -308,19 +308,23 @@ void ScCalcOptionsDialog::fillOpenCLList()
namespace {
-void fillListBox(ListBox* pListBox, const ScCalcConfig::OpenCLImplSet
rSet)
+OUString format(const ScCalcConfig::OpenCLImpl rImpl)
+{
+return (rImpl.maOS + +
+rImpl.maOSVersion + +
+rImpl.maPlatformVendor + +
+rImpl.maDevice + +
+rImpl.maDriverVersion);
+}
+
+void fillListBox(ListBox* pListBox, const ScCalcConfig::OpenCLImplSet rSet)
{
pListBox-SetUpdateMode(false);
pListBox-Clear();
for (auto i = rSet.cbegin(); i != rSet.cend(); ++i)
{
-pListBox-InsertEntry((*i).maOS + +
- (*i).maOSVersion + +
- (*i).maPlatformVendor + +
- (*i).maDevice + +
- (*i).maDriverVersion,
- LISTBOX_APPEND);
+pListBox-InsertEntry(format(*i), LISTBOX_APPEND);
}
pListBox-SetUpdateMode(true);
@@ -799,6 +803,9 @@ void ScCalcOptionsDialog::EditFieldValueChanged(Control
*pCtrl)
rSet.erase(impl);
rSet.insert(newImpl);
+
+fillListBox(mpOpenCLWhiteAndBlackListBox, rSet);
+mpOpenCLWhiteAndBlackListBox-SelectEntry(format(newImpl));
}
}
commit 0485355e05da36f4023b4c594ecb80b342608f5a
Author: Tor Lillqvist t...@collabora.com
Date: Fri Nov 7 15:08:07 2014 +0200
Make it possible to actually edit existing white/black list entries
Still not possible to add new ones or delete existing ones, though. And the
UI
for this is not finished at all. Work in progress.
Also some refactoring. To increase readability, introduce typedefs in
ScCalcConfig. Not sure whether nested types inside the class is a good idea
or
not.
Change-Id: I8e1695bb0594e2cd5f8b5ce0ece075842b77762a
diff --git a/sc/inc/calcconfig.hxx b/sc/inc/calcconfig.hxx
index 1a4c62c..4b72dc8 100644
--- a/sc/inc/calcconfig.hxx
+++ b/sc/inc/calcconfig.hxx
@@ -101,10 +101,15 @@ struct SC_DLLPUBLIC ScCalcConfig
bool mbOpenCLAutoSelect:1;
OUString maOpenCLDevice;
sal_Int32 mnOpenCLMinimumFormulaGroupSize;
-std::setOpCodeEnum maOpenCLSubsetOpCodes;
-std::setOpenCLImpl maOpenCLWhiteList;
-std::setOpenCLImpl maOpenCLBlackList;
+typedef std::setOpCodeEnum OpCodeSet;
+
+OpCodeSet maOpenCLSubsetOpCodes;
+
+typedef std::setOpenCLImpl OpenCLImplSet;
+
+OpenCLImplSet maOpenCLWhiteList;
+OpenCLImplSet maOpenCLBlackList;
ScCalcConfig();
@@ -117,11 +122,13 @@ struct SC_DLLPUBLIC ScCalcConfig
bool operator!= (const ScCalcConfig r) const;
};
+SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImpl rImpl);
+SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig::OpenCLImplSet rSet);
SC_DLLPUBLIC std::ostream operator(std::ostream rStream, const
ScCalcConfig rConfig);
-SC_DLLPUBLIC OUString ScOpCodeSetToNumberString(const std::setOpCodeEnum
rOpCodes);
-SC_DLLPUBLIC OUString ScOpCodeSetToSymbolicString(const std::setOpCodeEnum
rOpCodes);
-SC_DLLPUBLIC std::setOpCodeEnum ScStringToOpCodeSet(const OUString
rOpCodes);
+SC_DLLPUBLIC OUString ScOpCodeSetToNumberString(const ScCalcConfig::OpCodeSet
rOpCodes);
+SC_DLLPUBLIC OUString ScOpCodeSetToSymbolicString(const
ScCalcConfig::OpCodeSet rOpCodes);
+SC_DLLPUBLIC ScCalcConfig::OpCodeSet ScStringToOpCodeSet(const OUString
rOpCodes);
#endif
diff --git a/sc/source/core/tool/calcconfig.cxx
b/sc/source/core/tool/calcconfig.cxx
index 5fd4aec..583c2a3 100644
--- a/sc/source/core/tool/calcconfig.cxx
+++ b/sc/source/core/tool/calcconfig.cxx
@@ -82,27 +82,32 @@ bool ScCalcConfig::operator!= (const ScCalcConfig r) const
return !operator==(r);
}
-namespace {
+std::ostream
[Libreoffice-commits] core.git: Branch 'feature/opengl-vcl' - 3 commits - vcl/inc vcl/source vcl/win
vcl/inc/win/salgdi.h|2 +-
vcl/source/opengl/OpenGLContext.cxx |5 +
vcl/win/source/gdi/salgdi.cxx |6 +-
3 files changed, 11 insertions(+), 2 deletions(-)
New commits:
commit a865aafc30607dcbe2f824a2415f0aae55e7375e
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 7 18:04:37 2014 +0100
windows opengl: Make SwapBuffers() actually do something.
Change-Id: If58e9eaccd4850d33302ced5e83f649415158e24
diff --git a/vcl/inc/win/salgdi.h b/vcl/inc/win/salgdi.h
index aadd971..f09af28 100644
--- a/vcl/inc/win/salgdi.h
+++ b/vcl/inc/win/salgdi.h
@@ -397,7 +397,7 @@ public:
virtual SystemGraphicsData GetGraphicsData() const;
virtual SystemFontData GetSysFontData( int nFallbacklevel ) const;
-virtual bool SwapBuffers() SAL_OVERRIDE { return false; };
+virtual bool SwapBuffers() SAL_OVERRIDE;
/// Update settings based on the platform values
static void updateSettingsNative( AllSettings rSettings );
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 138775a..f185955 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -1029,4 +1029,9 @@ SystemGraphicsData WinSalGraphics::GetGraphicsData() const
return aRes;
}
+bool WinSalGraphics::SwapBuffers()
+{
+return mpImpl-swapBuffers();
+}
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
commit 4d0510f802d1a56e654e34f5c3414081ec8deda9
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 7 18:01:54 2014 +0100
windows opengl: Don't construct WinSalGraphicsImpl just to destroy it again.
Change-Id: I61afb35503a3947aa21bd90224e2f8614033a384
diff --git a/vcl/win/source/gdi/salgdi.cxx b/vcl/win/source/gdi/salgdi.cxx
index 17074a8..138775a 100644
--- a/vcl/win/source/gdi/salgdi.cxx
+++ b/vcl/win/source/gdi/salgdi.cxx
@@ -567,7 +567,6 @@ void ImplClearHDCCache( SalData* pData )
}
WinSalGraphics::WinSalGraphics(WinSalGraphics::Type eType, bool bScreen, HWND
hWnd):
-mpImpl(new WinSalGraphicsImpl(*this)),
mhLocalDC(0),
mbPrinter(eType == WinSalGraphics::PRINTER),
mbVirDev(eType == WinSalGraphics::VIRTUAL_DEVICE),
commit 745ba7b00347ede698cfb007b35adb191c11f31f
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Nov 7 17:56:35 2014 +0100
windows opengl: Setup the OpenGL window size also on Windows.
Change-Id: I5020cfb86e02ac331cb8922397e8be4f7d68d15e
diff --git a/vcl/source/opengl/OpenGLContext.cxx
b/vcl/source/opengl/OpenGLContext.cxx
index 521c4f2..b5a1898 100644
--- a/vcl/source/opengl/OpenGLContext.cxx
+++ b/vcl/source/opengl/OpenGLContext.cxx
@@ -677,6 +677,11 @@ bool OpenGLContext::ImplInit()
return false;
}
+RECT clientRect;
+GetClientRect(WindowFromDC(m_aGLWin.hDC), clientRect);
+m_aGLWin.Width = clientRect.right - clientRect.left;
+m_aGLWin.Height = clientRect.bottom - clientRect.top;
+
#elif defined( MACOSX )
NSOpenGLView* pView = getOpenGLView();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. 4.) If the make check (run the tests) fails, do you want the script to: Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 7:29 PM, Norbert Thiebaud nthieb...@gmail.com wrote: On Fri, Nov 7, 2014 at 10:38 AM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:12 PM, Maarten Hoes hoes.maar...@gmail.com wrote: On Mon, Nov 3, 2014 at 8:02 PM, Markus Mohrhard markus.mohrh...@googlemail.com wrote: Maybe not weekly but bi-weekly or monthly. Otherwise it will only be done from time to time without a plan. Hrm. Good point. Even weekly would not hurt as we have neither a problem with disk space or build hardware. Cool. You can choose whatever technology is a good fit and that you know. Of course something that other people can understand and maintain is preferred. A shell script sounds like a good idea for this task and would simplify the handling. Alright, I guess that means Ill have a go at it, then. So who do I need to mail my pub ssh key and what is the hostname/ip of the machine I would be allowed to royally mess up for this purpose ? ;) Hi, So I have something now that seems to work (doing a first test run now) on the vm cloph kindly provided, but has no logging, error notification, source updating, error handling, or uploading of reports. Time for a few questions: 1.) Where do the reports have to be uploaded to ? 2.) What do you want the script to do when it detects a failure ? Log an error ? Send an email to an admin ? 3.) Does the script have to handle its own source code updating ? git pull ? all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. Alright, so no complex error handling code then. But I guess you still will want the script to exit with a non-zero exit code if a single one of the commands in it fails (so jenkins can pick up on the failure) instead of it just blindly continuing as if nothing happened ? 4.) If the make check (run the tests) fails, do you want the script to: Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time So in other words: instead of 'make -k check' do a 'make check', and have the script exit with a non zero exit code if the make command fails ? 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? - Maarten ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
QA Meeting Minutes - 2014-11-05
Hi all, Big thanks to everyone in attendance at the QA Meeting today! I want to give a quick shout-out to Beluga, one of our newest QA contributors, who has been doing a lot of great work on various bug reports, including some of our oldest and hardest-to-repro UNCONFIRMED reports. If you are looking for a challenge in QA, hop on IRC and chat with Beluga or Joel (jmadero) about helping us to tackle this important work! Full meeting minutes and agenda: https://wiki.documentfoundation.org/QA/Meetings/2014/November_05 http://pumbaa.documentfoundation.org/meetbot/libreoffice-qa/2014/libreoffice-qa.2014-11-05-18.44.html Our next meeting will be in two weeks: https://wiki.documentfoundation.org/QA/Meetings/2014/November_19 Best, --R -- Robinson Tryon QA Engineer - The Document Foundation LibreOffice Community Outreach Herald qu...@libreoffice.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
FOSDEM Call for Paper
FOSDEM 15 will be held at the ULB Campus Solbosch on Saturday, January 31, and Sunday, February 1st, 2015. Open document editors are coming again to FOSDEM with a shared devroom which gives every project in this area a chance to present ODF related developments and innovations. The devroom is jointly organized by Apache OpenOffice and LibreOffice. We invite submission of talks for the Open Document Editors devroom, to be held on Saturday, January 31, from 10AM to 6PM. Length of talks should be limited to 20 minutes, as we would like to have questions after each presentation, and to fit as many presenters as possible in the schedule. Exceptions must be explicitly requested and justified. Technical talks (code, extensions, localization, QA, tools and adoption related cases) about open document editors or the ODF document format are welcome. Submissions must be done by the speakers using the Pentabarf system: https://penta.fosdem.org/submission/FOSDEM15 While filing your proposal, please provide the title of your talk, a short abstract (one or two paragraphs), some information about yourself (name, bio and photo, but please do remember that your profile might be already stored at Pentabarf) and specify what topic (Apache OpenOffice, LibreOffice, other ODF editors, ODF in general...) your talk is about. You do not need to create a new account if you already have one. If the password has been lost, you can easily recover it. The deadline is Sunday, December 14, 2014. Accepted speakers will be notified by December 28, 2014. You can send any questions to the devroom mailing list: open-document-devr...@lists.fosdem.org -- Italo Vignoli - it...@italovignoli.com mob IT +39.348.5653829 - mob EU +39.392.7481795 skype italovignoli - hangout italo.vign...@gmail.com GPG Key ID - 0xAAB8D5C0 DB75 1534 3FD0 EA5F 56B5 FDA6 DE82 934C AAB8 D5C0 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: REOPENED Bugs
Hi Joel, On Thursday, 2014-11-06 15:01:40 -0800, Joel Madero wrote: Good news is - now REOPENED actually has a useful definition: A bug is REOPENED if it is (1) assigned; (2) the assigned developer said they fixed it; (3) someone has reproduced the problem on a version which according to the developer the problem should not appear. Useful? Probably ;-) And thanks! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpTegy_oXAeM.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: 'master' 'make check' lcov code coverage report
On Fri, Nov 7, 2014 at 1:28 PM, Maarten Hoes hoes.maar...@gmail.com wrote: all these 3 point could be solved by putting that job under jenkins control.. I'll have a look at doing that. Alright, so no complex error handling code then. But I guess you still will want the script to exit with a non-zero exit code if a single one of the commands in it fails (so jenkins can pick up on the failure) instead of it just blindly continuing as if nothing happened ? yes. Ideally I would chain that job behind a sucessful build, so that this does not happen iow first fidn a 'good' commit, then submit the job but before that happen, the msot usefull way would be I think to just drop that build, and retry a bit latter with hopefully a good build at that time So in other words: instead of 'make -k check' do a 'make check', and have the script exit with a non zero exit code if the make command fails ? yes 6.) Should I send a license/code statement to the list for the 'code', even though this is just a shell script ? This is not really part of the product we package... os just put an appropriate open-source license statement at the to of the script. and prolly the best is to find a place for it in 'buildbot.git' (accessble via gerrit) So where does this 'buildbot.git' live, and how do I set up submit access to that so I can commit the script ? as I said :-) gerrit. gerrit.libreoffice.org/buildbot same process to upload patches than core.git :-) see content at https://gerrit.libreoffice.org/gitweb?p=buildbot.git;a=tree you can prolly just create a lcov directory and put stuff in there... Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa writerfilter/source
sw/qa/extras/ooxmlexport/data/table-rtl.docx |binary
sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 10 ++
writerfilter/source/dmapper/DomainMapperTableManager.cxx |7 +++
3 files changed, 17 insertions(+)
New commits:
commit dce20aa0e7df0cf43c2ec3b04c4cb5a405b6fd9b
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Nov 7 21:09:26 2014 +0100
writerfilter: handle ooxml:CT_TblPrBase_bidiVisual
Change-Id: I619a6b161e5ed7e902406b288552b06fe7da487e
diff --git a/sw/qa/extras/ooxmlexport/data/table-rtl.docx
b/sw/qa/extras/ooxmlexport/data/table-rtl.docx
new file mode 100644
index 000..90fba0b
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/table-rtl.docx differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 11ba954..c06ed65 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -15,6 +15,7 @@
#include com/sun/star/text/FontEmphasis.hpp
#include com/sun/star/text/HoriOrientation.hpp
#include com/sun/star/text/XTextRangeCompare.hpp
+#include com/sun/star/text/WritingMode2.hpp
#include string
@@ -503,6 +504,15 @@ DECLARE_OOXMLEXPORT_TEST(testPageBreakBefore,
page-break-before.docx)
CPPUNIT_ASSERT_EQUAL(style::BreakType_NONE,
getPropertystyle::BreakType(getParagraph(2), BreakType));
}
+DECLARE_OOXMLEXPORT_TEST(testTableRtl, table-rtl.docx)
+{
+uno::Referencetext::XTextTablesSupplier xTablesSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XIndexAccess
xTables(xTablesSupplier-getTextTables(), uno::UNO_QUERY);
+uno::Referencetext::XTextTable xTable(xTables-getByIndex(0),
uno::UNO_QUERY);
+// This was text::WritingMode2::LR_TB, i.e. direction of the table was
ignored.
+CPPUNIT_ASSERT_EQUAL(text::WritingMode2::RL_TB,
getPropertysal_Int16(xTable, WritingMode));
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
index 15f4397..51cfd9b 100644
--- a/writerfilter/source/dmapper/DomainMapperTableManager.cxx
+++ b/writerfilter/source/dmapper/DomainMapperTableManager.cxx
@@ -463,6 +463,13 @@ bool DomainMapperTableManager::sprm(Sprm rSprm)
case NS_ooxml::LN_CT_TblPrBase_tblCellSpacing:
// To-Do: Not yet preserved
break;
+case NS_ooxml::LN_CT_TblPrBase_bidiVisual:
+{
+TablePropertyMapPtr pPropMap(new TablePropertyMap());
+pPropMap-Insert(PROP_WRITING_MODE, uno::makeAny(nIntValue ?
text::WritingMode2::RL_TB : text::WritingMode2::LR_TB));
+insertTableProps(pPropMap);
+break;
+}
default:
bRet = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: coverity warnings update, 120 remaining warnings
Hi Caolán, On Tuesday, 2014-11-04 21:00:27 +, Caolán McNamara wrote: Great, my next contender for most suspicious remaining warning is 1242526 Arguments in wrong order in sc/source/ui/Accessibility/AccessessiblePreviewTable.cxx:322 where rRowInfo.bIsHeader, rCorInfo.bIsHeader arguments are passed to the ScAccessiblePreviewHeaderCell ctor in the same postions as arguments named bIsColHdr and bIsRowHdr Done, dismissed. Similar to other occurrences of this row-column wording mismatch; a row of headers where each cell is a column header, and a column of headers where each cell is a row header. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpqzFobZ5yZU.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sd/source
sd/source/filter/xml/sdxmlwrp.cxx | 48 ++
1 file changed, 48 insertions(+)
New commits:
commit 4139f124e01526c3bf9dd5736c41d7b48799a2d2
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 14:16:58 2014 +
Resolves: rhbz#1161238 sync PRESOBJ_OUTLINE para depths to outline numbering
same problem as fdo#78151, except that pre-existing documents created
before the bullet/numbering toggling UI change have PRESOBJ_OUTLINEs with
paras in them with numbering off but the outline level they are a
preview of still have numbering enabled.
Leave the actual numbering styles alone in this case and toggle the
PRESOBJ_OUTLINEs paras back to the level they really are
Change-Id: I76508f88b5003afd1740feee3ec328326117f896
diff --git a/sd/source/filter/xml/sdxmlwrp.cxx
b/sd/source/filter/xml/sdxmlwrp.cxx
index 73ce021..fd8cacc 100644
--- a/sd/source/filter/xml/sdxmlwrp.cxx
+++ b/sd/source/filter/xml/sdxmlwrp.cxx
@@ -26,6 +26,7 @@
#include sfx2/docfile.hxx
#include sfx2/docfilt.hxx
#include drawdoc.hxx
+#include Outliner.hxx
#include unotools/streamwrap.hxx
#include svx/xmlgrhlp.hxx
@@ -415,6 +416,51 @@ sal_Int32 ReadThroughComponent(
}
+//PRESOBJ_OUTLINEs in master pages are the preview of the outline styles
+//numbering format. Since fdo#78151 toggling bullets on and off changes
+//the style they are a preview of, previously toggling bullets on and off
+//would only affect the preview paragraph itself without an effect on the
+//style. i.e. previews of numbering which don't match the real numbering
+//they are supposed to be a preview of.
+//
+//But there exist documents which were saved previous to that modification
+//so here we detect such cases and fix them up to ensure the previews
+//numbering level matches that of the outline level it previews
+void fixupOutlinePlaceholderNumberingDepths(SdDrawDocument* pDoc)
+{
+for (sal_uInt16 i = 0; i pDoc-GetMasterSdPageCount(PK_STANDARD); ++i)
+{
+SdPage *pMasterPage = pDoc-GetMasterSdPage(i, PK_STANDARD);
+SdrObject* pMasterOutline = pMasterPage-GetPresObj(PRESOBJ_OUTLINE);
+if (!pMasterOutline)
+continue;
+OutlinerParaObject* pOutlParaObj =
pMasterOutline-GetOutlinerParaObject();
+if (!pOutlParaObj)
+continue;
+::sd::Outliner* pOutliner = pDoc-GetInternalOutliner();
+pOutliner-Clear();
+pOutliner-SetText(*pOutlParaObj);
+bool bInconsistent = false;
+const sal_Int32 nParaCount = pOutliner-GetParagraphCount();
+for (sal_Int32 j = 0; j nParaCount; ++j)
+{
+const sal_Int16 nExpectedDepth = j;
+if (nExpectedDepth != pOutliner-GetDepth(j))
+{
+Paragraph* p = pOutliner-GetParagraph(j);
+pOutliner-SetDepth(p, nExpectedDepth);
+bInconsistent = true;
+}
+}
+if (bInconsistent)
+{
+SAL_WARN(sd.filter, Fixing inconsistent outline numbering
placeholder preview depth);
+
pMasterOutline-SetOutlinerParaObject(pOutliner-CreateParaObject(0,
nParaCount));
+}
+pOutliner-Clear();
+}
+}
+
bool SdXMLFilter::Import( ErrCode nError )
{
sal_uInt32 nRet = 0;
@@ -763,6 +809,8 @@ bool SdXMLFilter::Import( ErrCode nError )
}
}
+fixupOutlinePlaceholderNumberingDepths(pDoc);
+
pDoc-EnableUndo(true);
mrDocShell.ClearUndoBuffer();
return nRet == 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 3 commits - include/svx svx/source svx/workben vcl/workben
include/svx/unoshape.hxx|2 +-
svx/source/unodraw/unoshap3.cxx |2 +-
svx/workben/pixelctl.cxx|5 +
vcl/workben/svpclient.cxx |5 +
4 files changed, 12 insertions(+), 2 deletions(-)
New commits:
commit d58c32fc168d7c8431e09e7fd275eaed68e13a7d
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 20:49:22 2014 +
coverity#1251176 Uncaught exception
Change-Id: Ibeedfcb59e3a249c066a9c0f5dd3fcced9beed90
diff --git a/include/svx/unoshape.hxx b/include/svx/unoshape.hxx
index b0d2679..d56d87b 100644
--- a/include/svx/unoshape.hxx
+++ b/include/svx/unoshape.hxx
@@ -685,7 +685,7 @@ protected:
public:
Svx3DSceneObject( SdrObject* pObj, SvxDrawPage* pDrawPage ) throw();
// overide these for special property handling in subcasses. Return true
if property is handled
-virtual bool setPropertyValueImpl( const OUString rName, const
SfxItemPropertySimpleEntry* pProperty, const ::com::sun::star::uno::Any rValue
) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::beans::PropertyVetoException,
::com::sun::star::lang::IllegalArgumentException,
::com::sun::star::lang::WrappedTargetException,
::com::sun::star::uno::RuntimeException) SAL_OVERRIDE;
+virtual bool setPropertyValueImpl( const OUString rName, const
SfxItemPropertySimpleEntry* pProperty, const ::com::sun::star::uno::Any rValue
) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::beans::PropertyVetoException,
::com::sun::star::lang::IllegalArgumentException,
::com::sun::star::lang::WrappedTargetException,
::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE;
virtual bool getPropertyValueImpl(const OUString rName, const
SfxItemPropertySimpleEntry* pProperty,
css::uno::Any rValue )
throw (css::beans::UnknownPropertyException,
css::lang::WrappedTargetException,
diff --git a/svx/source/unodraw/unoshap3.cxx b/svx/source/unodraw/unoshap3.cxx
index 571b3c1..fa6fc5f 100644
--- a/svx/source/unodraw/unoshap3.cxx
+++ b/svx/source/unodraw/unoshap3.cxx
@@ -304,7 +304,7 @@ struct ImpRememberTransAndRect
Rectangle maRect;
};
-bool Svx3DSceneObject::setPropertyValueImpl( const OUString rName, const
SfxItemPropertySimpleEntry* pProperty, const ::com::sun::star::uno::Any rValue
) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::beans::PropertyVetoException,
::com::sun::star::lang::IllegalArgumentException,
::com::sun::star::lang::WrappedTargetException,
::com::sun::star::uno::RuntimeException)
+bool Svx3DSceneObject::setPropertyValueImpl( const OUString rName, const
SfxItemPropertySimpleEntry* pProperty, const ::com::sun::star::uno::Any rValue
) throw(::com::sun::star::beans::UnknownPropertyException,
::com::sun::star::beans::PropertyVetoException,
::com::sun::star::lang::IllegalArgumentException,
::com::sun::star::lang::WrappedTargetException,
::com::sun::star::uno::RuntimeException, std::exception)
{
switch( pProperty-nWID )
{
commit c0e348a72a2f027eb7cdfe5b66b0e901cfdd676b
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 20:47:25 2014 +
coverity#1251177 Uncaught exception
Change-Id: Id71b104f8d1c420b3716b093cebad00a7eb3f431
diff --git a/svx/workben/pixelctl.cxx b/svx/workben/pixelctl.cxx
index f962042..09cb020 100644
--- a/svx/workben/pixelctl.cxx
+++ b/svx/workben/pixelctl.cxx
@@ -68,6 +68,11 @@ SAL_IMPLEMENT_MAIN()
SAL_WARN(vcl.app, Fatal exception: e.Message);
return 1;
}
+catch (const std::exception e)
+{
+SAL_WARN(vcl.app, Fatal exception: e.what());
+return 1;
+}
return 0;
}
commit dce66ad650a2707ea3fca3afef0cbe4ee3e2338c
Author: Caolán McNamara caol...@redhat.com
Date: Fri Nov 7 20:46:17 2014 +
coverity#1251175 Uncaught exception
Change-Id: I862320e5a4b8277ba39e8174b077df8c838b4629
diff --git a/vcl/workben/svpclient.cxx b/vcl/workben/svpclient.cxx
index 3f9e274..35cd62c 100644
--- a/vcl/workben/svpclient.cxx
+++ b/vcl/workben/svpclient.cxx
@@ -81,6 +81,11 @@ SAL_IMPLEMENT_MAIN()
SAL_WARN(vcl.app, Fatal exception: e.Message);
return 1;
}
+catch (const std::exception e)
+{
+SAL_WARN(vcl.app, Fatal exception: e.what());
+return 1;
+}
return 0;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/namedlg/namedefdlg.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit bbdecd902bf2844d781dc1550a1d24bcac80b260 Author: Eike Rathke er...@redhat.com Date: Fri Nov 7 21:34:52 2014 +0100 coverity#735814 Explicit null dereferenced Change-Id: I7c6ebe65cd8c3364b541b5545ab36a13d155a61c diff --git a/sc/source/ui/namedlg/namedefdlg.cxx b/sc/source/ui/namedlg/namedefdlg.cxx index 214bfb1..43b4ecc 100644 --- a/sc/source/ui/namedlg/namedefdlg.cxx +++ b/sc/source/ui/namedlg/namedefdlg.cxx @@ -237,8 +237,10 @@ void ScNameDefDlg::AddPushed() if (!mpDoc-GetTable(aScope, nTab)) nTab = -1; -mpDocShell-GetUndoManager()-AddUndoAction( -new ScUndoAddRangeData( mpDocShell, pNewEntry, nTab) ); +assert( pNewEntry); // undo of no insertion smells fishy +if (pNewEntry) +mpDocShell-GetUndoManager()-AddUndoAction( +new ScUndoAddRangeData( mpDocShell, pNewEntry, nTab) ); // set table stream invalid, otherwise RangeName won't be saved if no other // call invalidates the stream ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/drviewse.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ba59fc533b6ac393969b456e72223d7d839b46c1 Author: Caolán McNamara caol...@redhat.com Date: Fri Nov 7 21:06:18 2014 + coverity#1251173 Dereference before null check Change-Id: I2e7f98f6b2df5f87be546606f86fd29202050d87 diff --git a/sd/source/ui/view/drviewse.cxx b/sd/source/ui/view/drviewse.cxx index 331b62b..d0901b1 100644 --- a/sd/source/ui/view/drviewse.cxx +++ b/sd/source/ui/view/drviewse.cxx @@ -672,7 +672,7 @@ void DrawViewShell::FuDeleteSelectedObjects() ::vcl::KeyCode aKCode(KEY_DELETE); KeyEvent aKEvt( 0, aKCode); -bConsumed = mpDrawView mpDrawView-getSmartTags().KeyInput( aKEvt ); +bConsumed = mpDrawView-getSmartTags().KeyInput( aKEvt ); if( !bConsumed HasCurrentFunction() ) bConsumed = GetCurrentFunction()-KeyInput(aKEvt); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sw/qa sw/source writerfilter/source
sw/qa/extras/rtfexport/data/cjklist12.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist13.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist16.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist20.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist21.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist24.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist25.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist30.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist31.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist34.rtf| 225 +++
sw/qa/extras/rtfexport/data/cjklist38.rtf| 225 +++
sw/qa/extras/rtfexport/rtfexport.cxx | 101 ++
sw/qa/extras/rtfimport/rtfimport.cxx | 49 +
sw/source/filter/ww8/docxattributeoutput.cxx | 52 +
sw/source/filter/ww8/rtfattributeoutput.cxx | 62 ++
sw/source/filter/ww8/wrtw8num.cxx| 55 +
sw/source/filter/ww8/ww8par2.cxx | 37 +++
sw/source/filter/ww8/ww8par3.cxx | 63 --
writerfilter/source/dmapper/ConversionHelper.cxx | 30 +--
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 66 ++
20 files changed, 2911 insertions(+), 79 deletions(-)
New commits:
commit d30a8ec448bcd08c6a52a37d6ae41a4b71c235da
Author: Mark Hung mark...@gmail.com
Date: Tue Nov 4 05:31:53 2014 -0800
Correct number format mapping for CJK numbered lists in rtf/doc/docx
filters.
Reviewed on:
https://gerrit.libreoffice.org/12252
Change-Id: I2d8760c7ecb3677464e167528b2424aaca19a0d7
diff --git a/sw/qa/extras/rtfexport/data/cjklist12.rtf
b/sw/qa/extras/rtfexport/data/cjklist12.rtf
new file mode 100644
index 000..bb01457
--- /dev/null
+++ b/sw/qa/extras/rtfexport/data/cjklist12.rtf
@@ -0,0 +1,225 @@
+{\rtf1\adeflang1025\ansi\ansicpg950\uc2\adeff0\deff0\stshfdbch31505\stshfloch31506\stshfhich31506\stshfbi0\deflang1033\deflangfe1028\themelang1033\themelangfe1028\themelangcs0{\fonttbl{\f0\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}
+{\f14\fbidi \froman\fcharset136\fprq2{\*\panose
02020500}\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9{\*\falt
PMingLiU};}{\f14\fbidi \froman\fcharset136\fprq2{\*\panose
02020500}\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9{\*\falt PMingLiU};}
+{\f37\fbidi \fswiss\fcharset0\fprq2{\*\panose
020f0502020204030204}Calibri;}{\f38\fbidi \froman\fcharset136\fprq2{\*\panose
}@\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9;}
+{\flomajor\f31500\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman;}{\fdbmajor\f31501\fbidi
\froman\fcharset136\fprq2{\*\panose
02020500}\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9{\*\falt PMingLiU};}
+{\fhimajor\f31502\fbidi \froman\fcharset0\fprq2{\*\panose
02040503050406030204}Cambria;}{\fbimajor\f31503\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New Roman;}
+{\flominor\f31504\fbidi \froman\fcharset0\fprq2{\*\panose
02020603050405020304}Times New Roman;}{\fdbminor\f31505\fbidi
\froman\fcharset136\fprq2{\*\panose
02020500}\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9{\*\falt PMingLiU};}
+{\fhiminor\f31506\fbidi \fswiss\fcharset0\fprq2{\*\panose
020f0502020204030204}Calibri;}{\fbiminor\f31507\fbidi
\froman\fcharset0\fprq2{\*\panose 02020603050405020304}Times New
Roman;}{\f40\fbidi \froman\fcharset238\fprq2 Times New Roman CE;}
+{\f41\fbidi \froman\fcharset204\fprq2 Times New Roman Cyr;}{\f43\fbidi
\froman\fcharset161\fprq2 Times New Roman Greek;}{\f44\fbidi
\froman\fcharset162\fprq2 Times New Roman Tur;}{\f45\fbidi
\froman\fcharset177\fprq2 Times New Roman (Hebrew);}
+{\f46\fbidi \froman\fcharset178\fprq2 Times New Roman (Arabic);}{\f47\fbidi
\froman\fcharset186\fprq2 Times New Roman Baltic;}{\f48\fbidi
\froman\fcharset163\fprq2 Times New Roman (Vietnamese);}
+{\f182\fbidi \froman\fcharset0\fprq2 PMingLiU Western{\*\falt
PMingLiU};}{\f182\fbidi \froman\fcharset0\fprq2 PMingLiU Western{\*\falt
PMingLiU};}{\f410\fbidi \fswiss\fcharset238\fprq2 Calibri CE;}{\f411\fbidi
\fswiss\fcharset204\fprq2 Calibri Cyr;}
+{\f413\fbidi \fswiss\fcharset161\fprq2 Calibri Greek;}{\f414\fbidi
\fswiss\fcharset162\fprq2 Calibri Tur;}{\f417\fbidi \fswiss\fcharset186\fprq2
Calibri Baltic;}{\f418\fbidi \fswiss\fcharset163\fprq2 Calibri (Vietnamese);}
+{\f422\fbidi \froman\fcharset0\fprq2 @\'b7\'73\'b2\'d3\'a9\'fa\'c5\'e9
Western;}{\flomajor\f31508\fbidi \froman\fcharset238\fprq2 Times New Roman
CE;}{\flomajor\f31509\fbidi \froman\fcharset204\fprq2 Times New Roman Cyr;}
+{\flomajor\f31511\fbidi \froman\fcharset161\fprq2 Times New Roman
Greek;}{\flomajor\f31512\fbidi \froman\fcharset162\fprq2 Times New Roman
[Libreoffice-commits] core.git: vcl/android
vcl/android/androidinst.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 46a47217de2c3225bfdeb9d32bb76bbbd8c26c36
Author: Tor Lillqvist t...@collabora.com
Date: Sat Nov 8 00:29:47 2014 +0200
These constants are now in the MouseEventModifiers class enum
Change-Id: Ie6a0c86b18a7a01c8b020c37dcbcadc529deb80b
diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx
index 262a7c1..4bb391c 100644
--- a/vcl/android/androidinst.cxx
+++ b/vcl/android/androidinst.cxx
@@ -485,15 +485,15 @@ Java_org_libreoffice_android_AppSupport_touch(JNIEnv * /*
env */,
switch (action) {
case AMOTION_EVENT_ACTION_DOWN:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT);
nEvent = VCLEVENT_WINDOW_MOUSEBUTTONDOWN;
break;
case AMOTION_EVENT_ACTION_UP:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT);
nEvent = VCLEVENT_WINDOW_MOUSEBUTTONUP;
break;
case AMOTION_EVENT_ACTION_MOVE:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLEMOVE, MOUSE_LEFT);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLEMOVE, MOUSE_LEFT);
nEvent = VCLEVENT_WINDOW_MOUSEMOVE;
break;
default:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/ios
vcl/ios/iosinst.cxx |8
1 file changed, 4 insertions(+), 4 deletions(-)
New commits:
commit c989f5e0e11e295b11ffc921b0d105869e037e47
Author: Tor Lillqvist t...@collabora.com
Date: Sat Nov 8 00:51:21 2014 +0200
These constants are now in the scoped enum MouseEventModifiers
Change-Id: I73e1498198cbb55ccd969713a38b6cd678c94643
diff --git a/vcl/ios/iosinst.cxx b/vcl/ios/iosinst.cxx
index 73092e6..f3fe0b3 100644
--- a/vcl/ios/iosinst.cxx
+++ b/vcl/ios/iosinst.cxx
@@ -321,15 +321,15 @@ void touch_lo_mouse(int x, int y, MLOMouseButtonState
state, MLOModifierMask mod
switch (state) {
case DOWN:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT,
nModifiers);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT, nModifiers);
nEvent = VCLEVENT_WINDOW_MOUSEBUTTONDOWN;
break;
case MOVE:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLEMOVE, MOUSE_LEFT,
nModifiers);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLEMOVE, MOUSE_LEFT, nModifiers);
nEvent = VCLEVENT_WINDOW_MOUSEMOVE;
break;
case UP:
-aEvent = MouseEvent(Point(x, y), 1, MOUSE_SIMPLECLICK, MOUSE_LEFT,
nModifiers);
+aEvent = MouseEvent(Point(x, y), 1,
MouseEventModifiers::SIMPLECLICK, MOUSE_LEFT, nModifiers);
nEvent = VCLEVENT_WINDOW_MOUSEBUTTONUP;
break;
default:
@@ -388,7 +388,7 @@ void touch_lo_keyboard_did_hide()
if (pFocus) {
MouseEvent aEvent;
-aEvent = MouseEvent(Point(0, 0), 0, MOUSE_LEAVEWINDOW, MOUSE_LEFT);
+aEvent = MouseEvent(Point(0, 0), 0, MouseEventModifiers::LEAVEWINDOW,
MOUSE_LEFT);
Application::PostMouseEvent(VCLEVENT_WINDOW_MOUSEMOVE,
pFocus-GetWindow(), aEvent);
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - linguistic/source sc/source
linguistic/source/spelldsp.cxx |4 +++-
sc/source/ui/optdlg/calcoptionsdlg.cxx |5 -
2 files changed, 7 insertions(+), 2 deletions(-)
New commits:
commit fe076b977661679842d44ecf21a66fca4d96ce33
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Fri Nov 7 19:48:19 2014 -0600
sc, opencl dependant code called even without FEATURE_OPENCL
Change-Id: I9629904b6b48d6b8356d6abb0c3cffe6e3fba517
diff --git a/sc/source/ui/optdlg/calcoptionsdlg.cxx
b/sc/source/ui/optdlg/calcoptionsdlg.cxx
index 051cd98..06e74fa 100644
--- a/sc/source/ui/optdlg/calcoptionsdlg.cxx
+++ b/sc/source/ui/optdlg/calcoptionsdlg.cxx
@@ -582,6 +582,7 @@ void ScCalcOptionsDialog::SelectionChanged()
mpEditField-Hide();
mpOpenCLWhiteAndBlackListGrid-Show();
mpOpenclInfoList-GetParent()-Hide();
+#if HAVE_FEATURE_OPENCL
if ( nSelectedPos == CALC_OPTION_OPENCL_WHITELIST )
{
mpFtAnnotation-SetText(maDescOpenCLWhiteList);
@@ -592,6 +593,7 @@ void ScCalcOptionsDialog::SelectionChanged()
mpFtAnnotation-SetText(maDescOpenCLBlackList);
fillListBox(mpOpenCLWhiteAndBlackListBox,
maConfig.maOpenCLBlackList);
}
+#endif
}
break;
}
@@ -803,9 +805,10 @@ void ScCalcOptionsDialog::EditFieldValueChanged(Control
*pCtrl)
rSet.erase(impl);
rSet.insert(newImpl);
-
+#if HAVE_FEATURE_OPENCL
fillListBox(mpOpenCLWhiteAndBlackListBox, rSet);
mpOpenCLWhiteAndBlackListBox-SelectEntry(format(newImpl));
+#endif
}
}
commit 169e1058d50cca32f8ed8702c6f6a13a39fe899f
Author: Norbert Thiebaud nthieb...@gmail.com
Date: Fri Nov 7 19:05:11 2014 -0600
coverity#1251171 Missing break in switch
Change-Id: Iefdeecc9fb2032d171cc2a353fe160dcd92050b2
diff --git a/linguistic/source/spelldsp.cxx b/linguistic/source/spelldsp.cxx
index 3a2f025..c3b3282 100644
--- a/linguistic/source/spelldsp.cxx
+++ b/linguistic/source/spelldsp.cxx
@@ -696,8 +696,10 @@ Reference XSpellAlternatives
SpellCheckerDispatcher::spell_Impl(
break;
case CAPTYPE_ALLCAP:
aProposalList.Prepend(
pCharClass-uppercase(aAddRplcTxt) );
+break;
default:
-aProposalList.Prepend( aAddRplcTxt );
+/* can't happen because of if ct ==
above */
+break;
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Gerrit News for core on 2014-11-08
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + fdo#81475 Disabling background color in enabling some other buttons in https://gerrit.libreoffice.org/12306 from Yousuf Philips about module sw + make line spacing icons point to themes icons in https://gerrit.libreoffice.org/12274 from Yousuf Philips about module svx + fdo#85825 unify alignment tooltips in https://gerrit.libreoffice.org/12272 from Yousuf Philips about module officecfg + Fix common typos. No automatic tools. Handmade… in https://gerrit.libreoffice.org/12164 from Andrea Gelmini about module android, avmedia, basctl, basic, bin, bridges, build, canvas, chart2, cli_ure, comphelper, compilerplugins, connectivity, cppuhelper, crashrep, dbaccess, desktop, editeng, embeddedobj, embedserv, eventattacher, extensions, external, filter, forms, fpicker, framework, hwpfilter, i18nlangtag, i18npool, include, instsetoo_native, javaunohelper, jurt, jvmfwk, linguistic, lotuswordpro, odk, offapi, officecfg, oox, package, pyuno, qadevOOo, readlicense_oo, registry, reportbuilder, reportdesign, ridljar, sal, sc, scaddins, scp2, scripting, sd, setup_native, sfx2, shell, slideshow, solenv, sot, starmath, stoc, svl, svtools, svx, sw, test, toolkit, tools, tubes, ucb, ucbhelper, udkapi, unodevtools, unotools, uui, vcl, winaccessibility, wizards, writerfilter, xmerge, xmlhelp, xmloff, xmlsecurity End of freshness + add 'make etags' to generate etags in https://gerrit.libreoffice.org/12300 from Takeshi Abe about module build, solenv + sw: disable failing cp test on headless build in https://gerrit.libreoffice.org/12301 from Riccardo Magliocchetti about module sw + calc performance test in https://gerrit.libreoffice.org/12218 from Laurent Godard about module include, sc, test + configure: --enable-headless is dead long live --without-x in https://gerrit.libreoffice.org/12303 from Riccardo Magliocchetti about module build + addNewFromTitles : avoid broadcasting SC_HINT_AREAS_CHANGED twice in https://gerrit.libreoffice.org/12302 from Laurent Godard about module sc * Merged changes on master for project core changed in the last 25 hours: + Correct number format mapping for CJK numbered lists in rtf/doc/docx filt in https://gerrit.libreoffice.org/12252 from Mark Hung + fdo#84938: replace MOUSE_ modifier constants with enum in https://gerrit.libreoffice.org/12297 from Noel Grandin + make 'make tags' work in case of out-of-tree build in https://gerrit.libreoffice.org/12295 from Takeshi Abe + Clarify configure GStreamer handling in https://gerrit.libreoffice.org/11912 from Jan-Marek Glogowski + Don't add toolkit related shell packages with headless build in https://gerrit.libreoffice.org/12268 from Riccardo Magliocchetti + Removed #includes including themselves in https://gerrit.libreoffice.org/12292 from Andrea Gelmini + Fixup headless build in https://gerrit.libreoffice.org/12267 from Riccardo Magliocchetti + Fix fdo#84574 - COLOR PICKER: Palette color list should have scrollbar in https://gerrit.libreoffice.org/12296 from juegen funk * Abandoned changes on master for project core changed in the last 25 hours: + bug in typed flags in https://gerrit.libreoffice.org/12286 from Noel Grandin * Open changes needing tweaks, but being untouched for more than a week: + Perftest for loading autocorrect dictionaries, related fdo#79761 in https://gerrit.libreoffice.org/11296 from Matúš Kukan + android: Show document browser back in the menu in https://gerrit.libreoffice.org/12108 from Jacobo Aragunde Pérez + coverity#1242459 Identical code for different branches in https://gerrit.libreoffice.org/11772 from Caolán McNamara + jvmfwk: Apple Oracle's JRE detection for OS X 10.8+ in https://gerrit.libreoffice.org/12057 from Robert Antoni Buj i Gelonch + HIG-ification of GSoC Color Picker dialog in https://gerrit.libreoffice.org/11494 from Olivier Hallot + WIP: fdo#43090: Add an option to disable autoclose brackets in https://gerrit.libreoffice.org/12024 from Marcos Paulo de Souza + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl + fdo#58194 - export DOCX Automatic indent as firstLine indent in https://gerrit.libreoffice.org/10425 from Joren De Cuyper + WIP (do not merge): remove custom impl of bidirectional list in https://gerrit.libreoffice.org/11001 from Chris Laplante + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + fdo#81956 : Rendering of vml group shape was wrong. in https://gerrit.libreoffice.org/11013 from sushil_shinde + fdo#79018: LO hangs while opening file. in https://gerrit.libreoffice.org/9564 from Yogesh Bharate + fdo#81426 : Data from header and footer is getting lost. in https://gerrit.libreoffice.org/10531 from Rajashri Udhoji + fdo#79541 :Corrupt: Shape enclosed within a floating table in
[Libreoffice-qa] difference between builds
Hi, Could anybody explain the difference between builds on the page, please? http://dev-builds.libreoffice.org/daily/master/ I understand what is “Linux”, “Window”, “MacOs”, x86, 86_64, rpm, deb. But don't understand the piece after @ (at). Thank you in advance. Lera. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] difference between builds
Hi Lera, On Fri, Nov 7, 2014 at 2:37 PM, Lera Goncharuk lera.goncha...@gmail.com wrote: Hi, Could anybody explain the difference between builds on the page, please? http://dev-builds.libreoffice.org/daily/master/ I understand what is “Linux”, “Window”, “MacOs”, x86, 86_64, rpm, deb. But don't understand the piece after @ (at). That's the identifier of the tinderbox/buildbot that created the build. See https://wiki.documentfoundation.org/Development/Tinderbox#List_of_registered_Tinderboxes for a list so in case there's a problem with a bot, you can find contact address there (or in the build_info.txt in the upload-dir) ciao Christian ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] difference between builds
Hi Christian. Thank you. Now it is clear. Lera. В письме от 7 ноября 2014 14:40:57 пользователь Christian Lohmaier написал: That's the identifier of the tinderbox/buildbot that created the build. See https://wiki.documentfoundation.org/Development/Tinderbox#List_of_registere d_Tinderboxes for a list so in case there's a problem with a bot, you can find contact address there (or in the build_info.txt in the upload-dir) ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] the Win-x86@51-TDF build
Hello, Can you add the Russian language in the Win-x86@51-TDF build, please? Some Russian people don't know English, but try to check the functionality which they use every day for this build. They asked me to make this request. Is it possible? Thank you in advance. Lera. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] QA Meeting Minutes - 2014-11-05
Hi! Robinson Tryon wrote Yes, passwords should be invalidated. Could you please confirm it? I couldn't check it by myself. Robinson Tryon wrote Bugmail is currently enabled for regular user accounts. I've added a warning message asking people to try to avoid heavily-spamming people who aren't involved in the migration process. I don't think it is good idea to send real messages. Redirecting bugmail to file is a better idea. Robinson Tryon wrote In general seems it works fine. Speed is OK for 1000 bugs. Excellent :-) I meant 1 :). Robinson Tryon wrote - TimeTracking is enabled, so probably params differs from freedesktop instance Yes; we can decide whether or not that's a useful component. Not so useful... This is old and unmaintained feature. Robinson Tryon wrote - freedesktop UI changes are not applied [...] Design may have some ideas about how we can create a unique, beautiful, and functional theme for our Bugzilla. This is not what I was writing about. UI changes like Be aware that all comments posted, including attachments are public. are not added. BTW: Bugzilla 5 will probably have new sandstone skin as default, which probably will be easy to LibreOffice'fy... Best regards. -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-QA-Meeting-Minutes-2014-11-05-tp4128183p4128391.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] REOPENED Bugs
Hi *, Am 07.11.2014 um 00:01 schrieb Joel Madero: 1. What should we do about bugs that are REOPENED but unassigned? IMHO these should be pushed back to NEW +1 2. Should we ping developers who have reopened bugs to see if they are going to look into it again or if they can drop the bug? +1 Good news is - now REOPENED actually has a useful definition: A bug is REOPENED if it is (1) assigned; (2) the assigned developer said they fixed it; (3) someone has reproduced the problem on a version which according to the developer the problem should not appear. Useful? +1 regards Jochen ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] QA Meeting Minutes - 2014-11-05
On Fri, Nov 7, 2014 at 8:23 AM, bfoman bfo.bugm...@spamgourmet.com wrote: Robinson Tryon wrote Yes, passwords should be invalidated. Could you please confirm it? I couldn't check it by myself. The database dump I received has the passwords cleared. Robinson Tryon wrote Bugmail is currently enabled for regular user accounts. I've added a warning message asking people to try to avoid heavily-spamming people who aren't involved in the migration process. I don't think it is good idea to send real messages. Redirecting bugmail to file is a better idea. The goal of this test install is for us to verify that it can operate in the same fashion as Bugzilla running on FDO. Because email is used so heavily in the bug tracker, I think it would be a huge burden to try to test if we shunted the bugmail to a file. Do you have any suggestions about how we could make testing easier in that scenario? One option could be to just disabled bugmail for everyone, and then testers would have to turn it back on (Of course, each big automated change we perform in the DB takes us further away from the environment running on FDO right now) Robinson Tryon wrote In general seems it works fine. Speed is OK for 1000 bugs. Excellent :-) I meant 1 :). Yep, if we do start to run into some limitations, we can definitely look into optimizations for Postgres, consider allocating more memory, etc.. Robinson Tryon wrote - TimeTracking is enabled, so probably params differs from freedesktop instance Yes; we can decide whether or not that's a useful component. Not so useful... This is old and unmaintained feature. Sure. I took a quick glance, but didn't immediately see a config option to disable its display. If someone knows where to toggle that on/off, please let me know, otherwise I'll dig deeper for it soon :-) Robinson Tryon wrote - freedesktop UI changes are not applied [...] Design may have some ideas about how we can create a unique, beautiful, and functional theme for our Bugzilla. This is not what I was writing about. UI changes like Be aware that all comments posted, including attachments are public. are not added. I think that's definitely a similar improvement, and one that we can add rather quickly after we complete our initial migration. As I've mentioned previously, we really hope to make the migration involve as small a delta as possible from what's running on the FDO servers today. So unless there are some very important reasons for making a change (e.g. adding the standard TDF legal/license footer to Bugzilla), my suggestion is to put those changes off to the side for now. The good news here is that I've been experimenting with storing Bugzilla and some of our modified templates in git. This will eventually allow anyone to submit a pull request for improvements to the bug tracker, from simple typo fixes to adding improved fields and better filtering/organizing tools. BTW: Bugzilla 5 will probably have new sandstone skin as default, which probably will be easy to LibreOffice'fy... Yes, I do hope to get the Design Team involved in LibreOffice-i-fying the drab colors into something much more pleasant for our QA Team members to view :-) Best, --R -- Robinson Tryon QA Engineer - The Document Foundation LibreOffice Community Outreach Herald qu...@libreoffice.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] QA Meeting Minutes - 2014-11-05
Hi! Robinson Tryon wrote The goal of this test install is for us to verify that it can operate in the same fashion as Bugzilla running on FDO. Because email is used so heavily in the bug tracker, I think it would be a huge burden to try to test if we shunted the bugmail to a file. Do you have any suggestions about how we could make testing easier in that scenario? You are missing a point - you took a database and want to test it with real messages. Nobody gave you explicit permission to use their email. I would be very surprised to receive any mail from unknown Bugzilla install just because I'm CCed on more than 1k bugs and someone is testing something. Robinson Tryon wrote One option could be to just disabled bugmail for everyone, and then testers would have to turn it back on This is the idea. I don't know what you want to test with bugmail enabled. Sending of mails? Jobqueue.pl script? TDF mailserver infrastructure? Send the bugmails to mailserver, but not to the people. Robinson Tryon wrote Yep, if we do start to run into some limitations, we can definitely look into optimizations for Postgres, consider allocating more memory, etc.. Nice example of big Bugzilla infrasctructure is here = http://www.justdave.net/dave/2011/05/04/the-hardware-behind-bugzilla-mozilla-org/ Robinson Tryon wrote Sure. I took a quick glance, but didn't immediately see a config option to disable its display. If someone knows where to toggle that on/off, please let me know, otherwise I'll dig deeper for it soon :-) Seems you have timetrackinggroup defined. If you want to disable it - just change to empty value. Robinson Tryon wrote As I've mentioned previously, we really hope to make the migration involve as small a delta as possible from what's running on the FDO servers today. So unless there are some very important reasons for making a change (e.g. adding the standard TDF legal/license footer to Bugzilla), my suggestion is to put those changes off to the side for now. Please compare bug page on freedesktop and test install. Noticed a difference? I still don't know if this diff is because you want to have default Bugzilla UI or just because you do not have template changes copied from FDO install. Best regards. -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-QA-Meeting-Minutes-2014-11-05-tp4128183p4128407.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] REOPENED Bugs
Hi Joel, On Thursday, 2014-11-06 15:01:40 -0800, Joel Madero wrote: Good news is - now REOPENED actually has a useful definition: A bug is REOPENED if it is (1) assigned; (2) the assigned developer said they fixed it; (3) someone has reproduced the problem on a version which according to the developer the problem should not appear. Useful? Probably ;-) And thanks! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpcG0m8_bW9Y.pgp Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 85914] Shrink to fit cell size cuts text by omitting words which would have overflown if using original size
https://bugs.freedesktop.org/show_bug.cgi?id=85914 Edgar Kuchelmeister 101.367...@germanynet.de changed: What|Removed |Added CC||101.367...@germanynet.de --- Comment #2 from Edgar Kuchelmeister 101.367...@germanynet.de --- the error doesn't appear in 4.2.6.2 but in 4.2.7.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54907] PRINTING ctrl-p should show print form like in writer
https://bugs.freedesktop.org/show_bug.cgi?id=54907 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |NEEDINFO CC||todven...@suomi24.fi --- Comment #1 from Beluga todven...@suomi24.fi --- For me this does not happen. What Linux distro and desktop environment are you using? Set back to UNCONFIRMED, if the bug is still happening. Win 7 64-bit Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85912] ibus keyboarding solution - kmfl characters are not swallowed after completing the complex letter
https://bugs.freedesktop.org/show_bug.cgi?id=85912 Justin L jl...@mail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Justin L jl...@mail.com --- I'm pretty sure the bug is in the changes made to sw/source/core/access/accpara.cxx Marking as confirmed based on Doug's comments, and on emails I have received since posting this bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40732] Calc: Using ROW() and COLUMN() in array formula fails
https://bugs.freedesktop.org/show_bug.cgi?id=40732 Sören Weber s...@ditec-gmbh.de changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|3.4.3 release |4.3.2.2 release Ever confirmed|0 |1 --- Comment #5 from Sören Weber s...@ditec-gmbh.de --- I can reproduce the issue with the attached file in the current stable version of LibreOffice Calc 4.3.3.2 (Build-ID: 9bb7eadab57b6755b1265afa86e04bf45fbfc644) on Win 7 32bit Btw: Couldn't adjust Version field above, because latest stable version is missing! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54907] PRINTING ctrl-p should show print form like in writer
https://bugs.freedesktop.org/show_bug.cgi?id=54907 Paolo Benvenuto paolobe...@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52156] I recevive the error ORA-00933 : Sql command not properly ended
https://bugs.freedesktop.org/show_bug.cgi?id=52156 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |NEEDINFO CC||todven...@suomi24.fi -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52156] I recevive the error ORA-00933 : Sql command not properly ended
https://bugs.freedesktop.org/show_bug.cgi?id=52156 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56630] FORMATTING, UI:numbering/bullets do not indent
https://bugs.freedesktop.org/show_bug.cgi?id=56630 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Beluga todven...@suomi24.fi --- Confirmed, I don't get any result with the shortcuts. Win 7 64-bit Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56850] top line file save, file save as, etc does not consistantly appear
https://bugs.freedesktop.org/show_bug.cgi?id=56850 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |NEEDINFO CC||todven...@suomi24.fi --- Comment #1 from Beluga todven...@suomi24.fi --- What Linux distro and desktop environment are you using? Set to UNCONFIRMED, if the bug is still happening. RESOLVED WORKSFORME, if not. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57057] npsoplugin: sometimes does not display document after closing tabs/soffice
https://bugs.freedesktop.org/show_bug.cgi?id=57057 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57056] npsoplugin: starting soffice in parallel does not show start center
https://bugs.freedesktop.org/show_bug.cgi?id=57056 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48887] FILESAVE: Save as HTML in Writer should not embed images
https://bugs.freedesktop.org/show_bug.cgi?id=48887 --- Comment #16 from David N. Welton dav...@dedasys.com --- I'm not sure if this is the correct place to comment, but if this is added as an option, it would be wonderful if it were possible to control it from the command line. I use libreoffice with --headless --convert-to to automate conversion of some files, so a fix that only involves the UI would not solve this problem. Thank you! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57759] VIEWING: Gradient in metafile object is not rotated together with object if anti-aliasing is off.
https://bugs.freedesktop.org/show_bug.cgi?id=57759 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #1 from Beluga todven...@suomi24.fi --- Works ok now. Win 7 64-bit Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83765] EDITING: Wrong/Random ordering on sort by column.
https://bugs.freedesktop.org/show_bug.cgi?id=83765 --- Comment #16 from ralf.feh...@gmx.net --- First I though that my file was corrupted. Now I assume, it is libreoffice calc, which is broken. The same effect occurs with old backups of my file. The sort order changes every time, the sort button is pressed. The more rows in the table, the more phantasy the sort algorithm gets. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85611] Entering a protected space by keyboard not working
https://bugs.freedesktop.org/show_bug.cgi?id=85611 li...@hkopf.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |NOTOURBUG --- Comment #1 from li...@hkopf.de --- Hi! Today I found the solution. When only pressing control and space, now (probably since an update) a small window appeared showing the change of the keyboard settings - even though I only activated one layout! With this information the solution was easy to find: a ubuntu program called ibus took over this shortcut globally and there is no (or at least no easy) way to change it. I didn't need ibus, removed it and after a restart, control+space was not pre-used anymore = control+shift+space works again! SORRY! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58287] EDITING: Selecting a rectangle without background requires hitting border
https://bugs.freedesktop.org/show_bug.cgi?id=58287 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58287] EDITING: Selecting a rectangle without background requires hitting border
https://bugs.freedesktop.org/show_bug.cgi?id=58287 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|NEW |NEEDINFO CC||todven...@suomi24.fi Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85867] LibreOffice slow at rendering charts involving a large number of data points
https://bugs.freedesktop.org/show_bug.cgi?id=85867 Robert Pollak robert.pol...@mykolab.com changed: What|Removed |Added CC||robert.pol...@mykolab.com --- Comment #2 from Robert Pollak robert.pol...@mykolab.com --- This bug is certainly a duplicate of an existing one, but I could not find that yet. If it stays open, a reduced version of the test data should be directly attached. This test chart only contains 7448 x/y samples. On my machine (Intel Core i7-2600K @ 3.4 GHz) I notice about 2 seconds of delay when switching from Points only to Lines only (in LibreOffice 4.2.6.2 on Windows 7). I often work with data sets containing ~32k samples, where the corresponding delays are really annoying. PS: If you read this and just want to express that you are also affected, please don't post a comment!. Just CC yourselves instead, to keep the issue readable. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74390] Header odd/even/first page information corrupted after ODT FILESAVE / FILELOAD cycle
https://bugs.freedesktop.org/show_bug.cgi?id=74390 Pergamon d...@dosc.net changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #8 from Pergamon d...@dosc.net --- Retested this scenario with LibreOffice 4.3.3: The bug is fixed. Header handling works now as expected with no duplications. Can be closed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74390] Header odd/even/first page information corrupted after ODT FILESAVE / FILELOAD cycle
https://bugs.freedesktop.org/show_bug.cgi?id=74390 --- Comment #9 from Pergamon d...@dosc.net --- Retested this scenario with LibreOffice 4.3.3: The bug is fixed. Header handling works now as expected with no duplications. Can be closed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56707] Starting up LibO crashes in Windows XP Pro SP3
https://bugs.freedesktop.org/show_bug.cgi?id=56707 --- Comment #61 from A (Andy) stgohi-lob...@yahoo.de --- I am also very sorry to hear that. Too bad. Maybe, Michael has any further ideas? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85184] Meta: Track new color picker bugs
https://bugs.freedesktop.org/show_bug.cgi?id=85184 Bug 85184 depends on bug 84574, which changed state. Bug 84574 Summary: COLOR PICKER: Palette color list should have scrollbar https://bugs.freedesktop.org/show_bug.cgi?id=84574 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84574] COLOR PICKER: Palette color list should have scrollbar
https://bugs.freedesktop.org/show_bug.cgi?id=84574 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |juergen.funk...@cib.de |desktop.org | QA Contact|juergen.funk...@cib.de | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35077] [UI] Add an OPTION to switch off special effects, such as flashing lines around copy source cell(s)
https://bugs.freedesktop.org/show_bug.cgi?id=35077 andréb and...@laposte.net changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #23 from andréb and...@laposte.net --- (In reply to Joel Madero from comment #22) This was never confirmed by anyone on QA team or developer side - in fact, This problem was confirmed by numerous users. It is disingenuous at best to say that it is not confirmed. the most involved developers heavily disfavor this idea. That being said - Just because developers aren't interested does not mean that users do not find it an important problem - as the comments clearly show. (You did bother to read them, didn't you ?) Note also that these same developers confirmed the behavior in question. (One with the audacity to call the annoying behavior it a vital part of calc.) REOPENED is incorrect. Moving to UNCONFIRMED and asking for UX input (as was originally requested by Kohei but no one took the time to do that). Please stop messing with the severity/priority for your pet bugsit doesn't help anyone. By calling it unconfirmed, you are messing inappropriately with the bug report. Correcting the status to new. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 57478] UI: FILEOPEN LibOCreated.xls with grouped columns shows collapse '-' instead expand'+' above collapsed columns
https://bugs.freedesktop.org/show_bug.cgi?id=57478 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Beluga todven...@suomi24.fi --- Still reproduced. I opened attachment 70503 and did these steps: 0. download sample document 1. Open document from LibO Start center You see a small '+' button above column heading D 2. Expand / collapse Columns A...C by clikcing the small + / - button above column heading 3. Click Cell N+, type a blank and Return 4. Save as document2010LibO333.xls (MSO97) 5. close document 6. Reopen and this happened: you see a small '-' button to collapse columns, but they are already collapsed Click '-' As expected, nothing happens with columns, columns are already collapsed. But button changes to '+', Clicking it will expand the 3 columns, clicking the now visible '-' will hide columns a-C and so on Win 7 64-bit Version: 4.4.0.0.alpha1+ Build ID: 8b21b5cbe78945b27525b4ce78ae3d981f90590f TinderBox: Win-x86@39, Branch:master, Time: 2014-11-06_03:55:51 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37240] [BASIC]thisComponent.currentController.activeSheet gives error when loading spreadsheet
https://bugs.freedesktop.org/show_bug.cgi?id=37240 andréb and...@laposte.net changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #9 from andréb and...@laposte.net --- (In reply to Joel Madero from comment #8) Never confirmed by QA team - moving to UNCONFIRMED. Since there is a test document submitted to confirm the bug, by someone other than the bug reporter, it is appropriate that it should be considered confirmed. The definition of confirmed does not require review by the QA team. Correcting status to new (which means confirmed). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 81714] Other: The new Language Tag feature in LO 4.3 works only with Latin scripts
https://bugs.freedesktop.org/show_bug.cgi?id=81714 --- Comment #5 from martin_hos...@sil.org --- I think what is needed is to change cui/source/inc/chardlg.hxx such that SvxLanguageBox* m_pEastFontLanguageLB; SvxLanguageBox* m_pCTLFontLanguageLB; become: SvxLanguageComboBox* m_pEastFontLanguageLB; SvxLanguageComboBox* m_pCTLFontLanguageLB; -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
