Re: libi18nlangtag crash on SunOS 5.11

2014-12-21 Thread Richard PALO
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

This seems to be liblangtag issue as its testsuite has problems as well.
I'll need to get those resolved first. thx
-BEGIN PGP SIGNATURE-
Version: GnuPG v1
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJUlo7FAAoJECAB22fHtp275RMH+wSSMSde5HrZ4IEghLICF7V5
X2QkRK8OrkpJ33v7LXvJH7TO0HGDxM+QeOdKQxyIo8mOHFWpMnB7e9LgfdelP7IS
JopdQkKkvJvMpKTyYpZQJKcoGNCU9ikc5f+k56+urgeyPIrF5QaUZe2TCaH5Qf/l
+JFsSsDq1lNR2KbSWn9tPHGLYJJh8EkpyVkc/zIwvUVWbSih11An3c+6guzHV1Hc
hGPRjffnSV7DNa2psStiATFwTpCK0SMSlyYMZLQjIctuurulMCQIA5NsWP2PDvfs
U25tQ8q8ovKPLVV/R+1JjYJ2EnAIV2IJKFpOgMagAGjwVmSKyzTRkDTvI3xKjVk=
=+95j
-END PGP SIGNATURE-
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] libvisio.git: src/lib

2014-12-21 Thread Miklos Vajna
 src/lib/VSDXParser.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 526368176b655a6f30d9f26b9cf3285367672b00
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Sun Dec 21 11:05:27 2014 +0100

VSDXParser::processXmlNode: print debug messages to stderr

Change-Id: I4d5b8414f9836dc75ef988985c64d929dbc6b336

diff --git a/src/lib/VSDXParser.cpp b/src/lib/VSDXParser.cpp
index 9fe333a..d694650 100644
--- a/src/lib/VSDXParser.cpp
+++ b/src/lib/VSDXParser.cpp
@@ -503,7 +503,7 @@ void libvisio::VSDXParser::processXmlNode(xmlTextReaderPtr 
reader)
 {
   const xmlChar *name1 = xmlTextReaderConstName(reader);
   const xmlChar *value1 = xmlTextReaderConstValue(reader);
-  printf( %s=\%s\, name1, value1);
+  fprintf(stderr,  %s=\%s\, name1, value1);
 }
   }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2014-12-21 Thread Michael Weghorn
 sc/source/filter/dif/difimp.cxx|3 +--
 sc/source/filter/rtf/rtfparse.cxx  |3 +--
 sc/source/filter/xml/XMLExportIterator.cxx |5 +++--
 sc/source/filter/xml/xmlexprt.cxx  |5 ++---
 sc/source/filter/xml/xmlfonte.cxx  |4 ++--
 sc/source/ui/dbgui/filtdlg.cxx |2 +-
 sc/source/ui/dbgui/foptmgr.cxx |3 +--
 sc/source/ui/dbgui/sfiltdlg.cxx|3 +--
 sc/source/ui/dbgui/tpsort.cxx  |3 +--
 sc/source/ui/dbgui/tpsubt.cxx  |4 +---
 sc/source/ui/docshell/docfunc.cxx  |   15 ++-
 sc/source/ui/docshell/docsh4.cxx   |4 ++--
 sc/source/ui/docshell/docsh8.cxx   |4 ++--
 sc/source/ui/drawfunc/fuins2.cxx   |3 +--
 sc/source/ui/drawfunc/fusel.cxx|2 +-
 sc/source/ui/miscdlgs/acredlin.cxx |   15 ++-
 sc/source/ui/optdlg/tpusrlst.cxx   |2 +-
 sc/source/ui/pagedlg/areasdlg.cxx  |3 +--
 sc/source/ui/unoobj/cellsuno.cxx   |2 +-
 19 files changed, 35 insertions(+), 50 deletions(-)

New commits:
commit ea5effc3df7b89a9332ea5b1b1e6cd40bf37f081
Author: Michael Weghorn m.wegh...@posteo.de
Date:   Sat Dec 20 16:48:11 2014 +0100

fdo#39440 sc: reduce scope of local variables

This addresses some cppcheck warnings.

Change-Id: I2eaf9a6792ca2c06a005385ec45c08f1292cba23

diff --git a/sc/source/filter/dif/difimp.cxx b/sc/source/filter/dif/difimp.cxx
index 59d8238..6d5be2a 100644
--- a/sc/source/filter/dif/difimp.cxx
+++ b/sc/source/filter/dif/difimp.cxx
@@ -61,7 +61,6 @@ FltError ScFormatFilterPluginImpl::ScImportDif( SvStream 
rIn, ScDocument* pDoc,
 boolbOverflowWarn = false;
 
 OUString   aData = aDifParser.aData;
-boolbData = false;
 
 rIn.Seek( 0 );
 
@@ -73,7 +72,7 @@ FltError ScFormatFilterPluginImpl::ScImportDif( SvStream 
rIn, ScDocument* pDoc,
 
 aPrgrsBar.Progress();
 
-bData = !aData.isEmpty();
+const bool bData = !aData.isEmpty();
 
 switch( eTopic )
 {
diff --git a/sc/source/filter/rtf/rtfparse.cxx 
b/sc/source/filter/rtf/rtfparse.cxx
index 87716da..ef818ce 100644
--- a/sc/source/filter/rtf/rtfparse.cxx
+++ b/sc/source/filter/rtf/rtfparse.cxx
@@ -266,7 +266,6 @@ void ScRTFParser::NewCellRow( ImportInfo* /*pInfo*/ )
 
 void ScRTFParser::ProcToken( ImportInfo* pInfo )
 {
-ScEEParseEntry* pE;
 switch ( pInfo-nToken )
 {
 case RTF_TROWD: // denotes table row defauls, before RTF_CELLX
@@ -351,7 +350,7 @@ void ScRTFParser::ProcToken( ImportInfo* pInfo )
 {   // Assign current Twips to MergeCell
 if ( !maList.empty() )
 {
-pE = maList.back();
+ScEEParseEntry* pE = maList.back();
 pE-nTwips = pActDefault-nTwips;
 }
 // Adjust selection of free-flying pActEntry
diff --git a/sc/source/filter/xml/XMLExportIterator.cxx 
b/sc/source/filter/xml/XMLExportIterator.cxx
index 9f9307e..f08e4dd 100644
--- a/sc/source/filter/xml/XMLExportIterator.cxx
+++ b/sc/source/filter/xml/XMLExportIterator.cxx
@@ -653,8 +653,6 @@ void ScMyNotEmptyCellsIterator::SetCellData( ScMyCell 
rMyCell, const table::Cel
 rMyCell.bIsMatrixCovered = false;
 rMyCell.bIsMatrixBase = false;
 
-bool bIsMatrixBase = false;
-
 switch (rMyCell.maBaseCell.meType)
 {
 case CELLTYPE_VALUE:
@@ -672,11 +670,14 @@ void ScMyNotEmptyCellsIterator::SetCellData( ScMyCell 
rMyCell, const table::Cel
 }
 
 if (rMyCell.maBaseCell.meType == CELLTYPE_FORMULA)
+{
+bool bIsMatrixBase = false;
 if (rExport.IsMatrix(rMyCell.maCellAddress, rMyCell.aMatrixRange, 
bIsMatrixBase))
 {
 rMyCell.bIsMatrixBase = bIsMatrixBase;
 rMyCell.bIsMatrixCovered = !bIsMatrixBase;
 }
+}
 }
 
 void ScMyNotEmptyCellsIterator::HasAnnotation(ScMyCell aCell)
diff --git a/sc/source/filter/xml/xmlexprt.cxx 
b/sc/source/filter/xml/xmlexprt.cxx
index f468fca..d731f23 100644
--- a/sc/source/filter/xml/xmlexprt.cxx
+++ b/sc/source/filter/xml/xmlexprt.cxx
@@ -937,7 +937,6 @@ void ScXMLExport::ExportColumns(const sal_Int32 nTable, 
const table::CellRangeAd
 sal_Int32 nPrevColumn(0);
 bool bPrevIsVisible (true);
 bool bWasHeader (false);
-bool bIsHeader (false);
 bool bIsClosed (true);
 sal_Int32 nPrevIndex (-1);
 sal_Int32 nColumn;
@@ -947,7 +946,7 @@ void ScXMLExport::ExportColumns(const sal_Int32 nTable, 
const table::CellRangeAd
 bool bIsVisible(true);
 nIndex = pColumnStyles-GetStyleNameIndex(nTable, nColumn, bIsVisible);
 
-bIsHeader = bHasColumnHeader  (aColumnHeaderRange.StartColumn = 
nColumn)  (nColumn = aColumnHeaderRange.EndColumn);
+const bool bIsHeader = bHasColumnHeader  
(aColumnHeaderRange.StartColumn = nColumn)  (nColumn = 

[Bug 39440] cppcheck cleanliness

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #40 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea5effc3df7b89a9332ea5b1b1e6cd40bf37f081

fdo#39440 sc: reduce scope of local variables

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Pieter Adriaensen license statement

2014-12-21 Thread Pieter Adriaensen
All of my past  future contributions to LibreOffice may be licensed under
the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 79641] LibreOffice 4.4 most annoying bugs

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79641

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||86984

--- Comment #24 from Cor Nouws c...@nouenoff.nl ---
adding Bug 86984 - UI:Line Numbering. Include header or footer not preserved
and has no effect on counting

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: internal openldap build fails when exporting FLAGS

2014-12-21 Thread Maarten Hoes
Hi,


Thanks for that. It looks like with my patch, the build fails for the
'Continuous Integration Bot'. Is there a logfile or something like that,
which I can take a look at to try and figure out why it failed ?


Thanks,


- Maarten


On Sun, Dec 21, 2014 at 2:52 AM, Chris Sherlock chris.sherloc...@gmail.com
wrote:

 That does look an error.

 I've rebased and started a build - can't see any issues though!

 Chris

 Sent from my iPhone

 On 21 Dec 2014, at 7:41 am, Maarten Hoes hoes.maar...@gmail.com wrote:

 Hi,


 I made the minimum amount of change I needed, and submitted a patch to
 gerrit for review.

 https://gerrit.libreoffice.org/13568

 - Maarten



 On Sat, Dec 20, 2014 at 12:23 PM, Maarten Hoes hoes.maar...@gmail.com
 wrote:

 Hi,


 For lcov code coverage purposes, I have to build libreoffice with the
 following FLAGS set and exported :

 LDFLAGS='-fprofile-arcs' CFLAGS='-fprofile-arcs -ftest-coverage'
 CXXFLAGS='-fprofile-arcs -ftest-coverage' CPPFLAGS='-fprofile-arcs
 -ftest-coverage'
 export LDFLAGS CFLAGS CXXFLAGS CPPFLAGS

 And then proceed with

 ./autogen.sh --enable-python=internal --disable-online-update
 --without-system-libs --without-system-headers
 make build-nocheck

 I run into a build error of the internal openldap version, with undefined
 references to  '__gcov_'. This shouldnt happen when setting
 FLAGS+='-fprofile-arcs -ftest-coverage' ... But it looks like '-lgcov' isnt
 passed to the linker properly (which should happen by setting
 LDFLAGS='-fprofile-arcs'). It appears that the FLAGS arent being passed
 down correctly in here :

 external/openldap/ExternalProject_openldap.mk

 Where at multiple points it appears that all current
 CFLAGS/CPPFLAGS/LDFLAGS are overwritten with entries like this:

 LDFLAGS = foo
 CPPFLAGS= bar

 instead of something like this

 LDFLAGS=$(LDFLAGS) foo
 CPPFLAGS=$(CPPFLAGS) bar

 It seems easy enough to modify, but I cant figure out if this was done on
 purpose for some reason, or if it can be modified without causing issues ?
 Perhaps only the (last) line with LDFLAGS can/needs to be changed, and the
 other FLAGS need to be left as they are ? For me, internal openldap builds
 without issues when making the modifications (see attached diff).


 All thoughts and comments are more than appreciated,



 - Maarten


 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: internal openldap build fails when exporting FLAGS

2014-12-21 Thread Maarten Hoes
Hi,


Sorry for not looking in the right direction. Is it this log ?

http://ci.libreoffice.org/job/lo_gerrit_master/10/Gerrit=Gerrit,Platform=MacOSX/console

If so,I have no idea why that failed java statement at the end was caused
by this patch ? Is the (java) maximum line length somehow exceeded when
parsing the modified Makefile on Mac (when, why?) or something ?


- Maarten.






On Sun, Dec 21, 2014 at 12:52 PM, Maarten Hoes hoes.maar...@gmail.com
wrote:

 Hi,


 Thanks for that. It looks like with my patch, the build fails for the
 'Continuous Integration Bot'. Is there a logfile or something like that,
 which I can take a look at to try and figure out why it failed ?


 Thanks,


 - Maarten


 On Sun, Dec 21, 2014 at 2:52 AM, Chris Sherlock 
 chris.sherloc...@gmail.com wrote:

 That does look an error.

 I've rebased and started a build - can't see any issues though!

 Chris

 Sent from my iPhone

 On 21 Dec 2014, at 7:41 am, Maarten Hoes hoes.maar...@gmail.com wrote:

 Hi,


 I made the minimum amount of change I needed, and submitted a patch to
 gerrit for review.

 https://gerrit.libreoffice.org/13568

 - Maarten



 On Sat, Dec 20, 2014 at 12:23 PM, Maarten Hoes hoes.maar...@gmail.com
 wrote:

 Hi,


 For lcov code coverage purposes, I have to build libreoffice with the
 following FLAGS set and exported :

 LDFLAGS='-fprofile-arcs' CFLAGS='-fprofile-arcs -ftest-coverage'
 CXXFLAGS='-fprofile-arcs -ftest-coverage' CPPFLAGS='-fprofile-arcs
 -ftest-coverage'
 export LDFLAGS CFLAGS CXXFLAGS CPPFLAGS

 And then proceed with

 ./autogen.sh --enable-python=internal --disable-online-update
 --without-system-libs --without-system-headers
 make build-nocheck

 I run into a build error of the internal openldap version, with
 undefined references to  '__gcov_'. This shouldnt happen when setting
 FLAGS+='-fprofile-arcs -ftest-coverage' ... But it looks like '-lgcov' isnt
 passed to the linker properly (which should happen by setting
 LDFLAGS='-fprofile-arcs'). It appears that the FLAGS arent being passed
 down correctly in here :

 external/openldap/ExternalProject_openldap.mk

 Where at multiple points it appears that all current
 CFLAGS/CPPFLAGS/LDFLAGS are overwritten with entries like this:

 LDFLAGS = foo
 CPPFLAGS= bar

 instead of something like this

 LDFLAGS=$(LDFLAGS) foo
 CPPFLAGS=$(CPPFLAGS) bar

 It seems easy enough to modify, but I cant figure out if this was done
 on purpose for some reason, or if it can be modified without causing issues
 ? Perhaps only the (last) line with LDFLAGS can/needs to be changed, and
 the other FLAGS need to be left as they are ? For me, internal openldap
 builds without issues when making the modifications (see attached diff).


 All thoughts and comments are more than appreciated,



 - Maarten


 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: internal openldap build fails when exporting FLAGS

2014-12-21 Thread Maarten Hoes
Hi,

Sorry.

Wrong cutnpaste, I meant this one of course: (same error though, but
different build):

http://ci.libreoffice.org/job/lo_gerrit_master/Gerrit=Gerrit,Platform=MacOSX/5/console


- Maarten.


On Sun, Dec 21, 2014 at 1:08 PM, Maarten Hoes hoes.maar...@gmail.com
wrote:

 Hi,


 Sorry for not looking in the right direction. Is it this log ?


 http://ci.libreoffice.org/job/lo_gerrit_master/10/Gerrit=Gerrit,Platform=MacOSX/console

 If so,I have no idea why that failed java statement at the end was caused
 by this patch ? Is the (java) maximum line length somehow exceeded when
 parsing the modified Makefile on Mac (when, why?) or something ?


 - Maarten.






 On Sun, Dec 21, 2014 at 12:52 PM, Maarten Hoes hoes.maar...@gmail.com
 wrote:

 Hi,


 Thanks for that. It looks like with my patch, the build fails for the
 'Continuous Integration Bot'. Is there a logfile or something like that,
 which I can take a look at to try and figure out why it failed ?


 Thanks,


 - Maarten


 On Sun, Dec 21, 2014 at 2:52 AM, Chris Sherlock 
 chris.sherloc...@gmail.com wrote:

 That does look an error.

 I've rebased and started a build - can't see any issues though!

 Chris

 Sent from my iPhone

 On 21 Dec 2014, at 7:41 am, Maarten Hoes hoes.maar...@gmail.com wrote:

 Hi,


 I made the minimum amount of change I needed, and submitted a patch to
 gerrit for review.

 https://gerrit.libreoffice.org/13568

 - Maarten



 On Sat, Dec 20, 2014 at 12:23 PM, Maarten Hoes hoes.maar...@gmail.com
 wrote:

 Hi,


 For lcov code coverage purposes, I have to build libreoffice with the
 following FLAGS set and exported :

 LDFLAGS='-fprofile-arcs' CFLAGS='-fprofile-arcs -ftest-coverage'
 CXXFLAGS='-fprofile-arcs -ftest-coverage' CPPFLAGS='-fprofile-arcs
 -ftest-coverage'
 export LDFLAGS CFLAGS CXXFLAGS CPPFLAGS

 And then proceed with

 ./autogen.sh --enable-python=internal --disable-online-update
 --without-system-libs --without-system-headers
 make build-nocheck

 I run into a build error of the internal openldap version, with
 undefined references to  '__gcov_'. This shouldnt happen when setting
 FLAGS+='-fprofile-arcs -ftest-coverage' ... But it looks like '-lgcov' isnt
 passed to the linker properly (which should happen by setting
 LDFLAGS='-fprofile-arcs'). It appears that the FLAGS arent being passed
 down correctly in here :

 external/openldap/ExternalProject_openldap.mk

 Where at multiple points it appears that all current
 CFLAGS/CPPFLAGS/LDFLAGS are overwritten with entries like this:

 LDFLAGS = foo
 CPPFLAGS= bar

 instead of something like this

 LDFLAGS=$(LDFLAGS) foo
 CPPFLAGS=$(CPPFLAGS) bar

 It seems easy enough to modify, but I cant figure out if this was done
 on purpose for some reason, or if it can be modified without causing issues
 ? Perhaps only the (last) line with LDFLAGS can/needs to be changed, and
 the other FLAGS need to be left as they are ? For me, internal openldap
 builds without issues when making the modifications (see attached diff).


 All thoughts and comments are more than appreciated,



 - Maarten


 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Clément Lassieur license statement

2014-12-21 Thread Clément Lassieur
All of my past  future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.

I’m affiliated with Linagora.

-- 
Clément Lassieur
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Bug 83795] Add UI for Wearable devices to the Impress Remote for Android

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83795

--- Comment #4 from foo.stra...@gmail.com ---
Update: Created a fairly simple full screen android wear app,implemented
WearableListenerService on both mobile and wear,added new intents that are
broadcast from the service to SlideShowActivity. In other words: the wear app
can trigger slide transitions.

TODO:
-Sending presentation info(a counter) to wear.
-Implement notification UI.
-Optimize Google Api Client connection on both sides.

Should I change the bug status to ASSIGNED?Any feedback on how I'm supposed
to post updates of the assignment is welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: external/openldap

2014-12-21 Thread Maarten Hoes
 external/openldap/ExternalProject_openldap.mk |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 109df0652440c31df7a19275167f8f5640722a1b
Author: Maarten Hoes hoes.maar...@gmail.com
Date:   Sat Dec 20 21:35:07 2014 +0100

Honor additional LDFLAGS when exporting them on the commandline.

Change-Id: I794f8d9d23234af46f16a71021be069ca5383f03
Reviewed-on: https://gerrit.libreoffice.org/13568
Tested-by: LibreOffice gerrit bot ger...@libreoffice.org
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/external/openldap/ExternalProject_openldap.mk 
b/external/openldap/ExternalProject_openldap.mk
index 7c320cb..67c2a79 100644
--- a/external/openldap/ExternalProject_openldap.mk
+++ b/external/openldap/ExternalProject_openldap.mk
@@ -46,7 +46,7 @@ $(call gb_ExternalProject_get_state_target,openldap,build) :
CPPFLAGS=-I$(call 
gb_UnpackedTarball_get_dir,nss)/dist/public/nss -I$(call 
gb_UnpackedTarball_get_dir,nss)/dist/out/include \
CFLAGS=-I$(call 
gb_UnpackedTarball_get_dir,nss)/dist/public/nss -I$(call 
gb_UnpackedTarball_get_dir,nss)/dist/out/include \
) \
-   $(if $(openldap_LDFLAGS),LDFLAGS=$(openldap_LDFLAGS)) 
\
+   $(if $(openldap_LDFLAGS),LDFLAGS=$(LDFLAGS) 
$(openldap_LDFLAGS)) \
 MAKEFLAGS=  $(MAKE) \
)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source

2014-12-21 Thread Eike Rathke
 sc/source/core/data/document.cxx |   15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

New commits:
commit ed92c5f1e3d0e2184672d6d31f25d0e933ebd3cd
Author: Eike Rathke er...@redhat.com
Date:   Thu Dec 18 20:07:55 2014 +0100

fdo#68385 update references only if cut originates from the same document

Change-Id: Ia7b27309251cf9e47505c58d8ed0172d134280f4
(cherry picked from commit f2ac9fab2677a6a718f251baef75d3cae96d1f01)
Reviewed-on: https://gerrit.libreoffice.org/13529
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 56e751b..f53426a0 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -2562,11 +2562,16 @@ void ScDocument::CopyBlockFromClip(
 aRefCxt.mnTabDelta = nDz;
 if (rCxt.getClipDoc()-GetClipParam().mbCutMode)
 {
-bool bOldInserting = IsInsertingFromOtherDoc();
-SetInsertingFromOtherDoc( true);
-aRefCxt.meMode = URM_MOVE;
-UpdateReference(aRefCxt, rCxt.getUndoDoc(), false);
-SetInsertingFromOtherDoc( bOldInserting);
+// Update references only if cut originates from the same
+// document we are pasting into.
+if (rCxt.getClipDoc()-GetPool() == GetPool())
+{
+bool bOldInserting = IsInsertingFromOtherDoc();
+SetInsertingFromOtherDoc( true);
+aRefCxt.meMode = URM_MOVE;
+UpdateReference(aRefCxt, rCxt.getUndoDoc(), false);
+SetInsertingFromOtherDoc( bOldInserting);
+}
 }
 else
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - cui/source vcl/source

2014-12-21 Thread Markus Mohrhard
 cui/source/options/optgdlg.cxx |2 +-
 vcl/source/opengl/OpenGLHelper.cxx |   19 +--
 2 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit f1252d8c24a59833596c17fed1ef6320d2e72609
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Thu Dec 18 10:13:40 2014 +0100

ifix the OpenGL UI config part

Change-Id: I931a4b618f35188e4e0cca07305ff15bbbacc20a
Reviewed-on: https://gerrit.libreoffice.org/13520
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk

diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index ffe4bda..842e453 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -145,7 +145,7 @@ OpenGLCfg::~OpenGLCfg()
 boost::shared_ptr comphelper::ConfigurationChanges  batch( 
comphelper::ConfigurationChanges::create() );
 officecfg::Office::Common::VCL::UseOpenGL::set(mbUseOpenGL, batch);
 officecfg::Office::Common::VCL::ForceOpenGL::set(mbForceOpenGL, batch);
-
+batch-commit();
 }
 }
 
diff --git a/vcl/source/opengl/OpenGLHelper.cxx 
b/vcl/source/opengl/OpenGLHelper.cxx
index 7f4cf36..a30b9ef 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -401,6 +401,17 @@ bool OpenGLHelper::supportsVCLOpenGL()
 
 bool OpenGLHelper::isVCLOpenGLEnabled()
 {
+/**
+ * The !bSet part should only be called once! Changing the results in the 
same
+ * run will mix OpenGL and normal rendering.
+ */
+static bool bSet = false;
+static bool bEnable = false;
+static bool bForceOpenGL = false;
+if (bSet)
+{
+return bForceOpenGL || bEnable;
+}
 /*
  * There are a number of cases that these environment variables cover:
  *  * SAL_FORCEGL forces OpenGL independent of any other option
@@ -408,16 +419,20 @@ bool OpenGLHelper::isVCLOpenGLEnabled()
  *  * SAL_ENABLEGL overrides VCL_HIDE_WINDOWS and the configuration 
variable
  *  * the configuration variable is checked if no environment variable is 
set
  */
-static bool bForceOpenGL = !!getenv(SAL_FORCEGL) || 
officecfg::Office::Common::VCL::ForceOpenGL::get();
+
+bSet = true;
+bForceOpenGL = !!getenv(SAL_FORCEGL) || 
officecfg::Office::Common::VCL::ForceOpenGL::get();
 if (bForceOpenGL)
 return true;
 
 if (!supportsVCLOpenGL())
+{
 return false;
+}
 
 static bool bEnableGLEnv = !!getenv(SAL_ENABLEGL);
 
-bool bEnable = bEnableGLEnv;
+bEnable = bEnableGLEnv;
 
 static bool bDuringBuild = getenv(VCL_HIDE_WINDOWS);
 if (bDuringBuild  !bEnable /* env. enable overrides */)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Site libreoffice.org attacked or in maintenance mode ?

2014-12-21 Thread Alexander
Hi,

Why site down?


Good Luck,
  Alexander.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [documentliberation-discuss] [ANN] libabw 0.1.1 has been released

2014-12-21 Thread Hanno Böck
Hi,

I did a quick run with american fuzzy lop on libabw and it found the
attached crasher.
Attached both sample exposing segfault and asan/valgrind output. It's
an invalid memory read access.

As here are a lot of people working on import filters: These are very
suspectible to these type of memory access errors and they can often
easily be found with fuzzing. You may wanna have a look at
https://fuzzing-project.org

cu,
-- 
Hanno Böck
http://hboeck.de/

mail/jabber: ha...@hboeck.de
GPG: BBB51E42


libabw-segfault.tar.xz
Description: application/xz


pgpXKsoi9IIuD.pgp
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: svx/source

2014-12-21 Thread Lionel Elie Mamane
 svx/source/fmcomp/gridcell.cxx |   19 ---
 svx/source/inc/gridcell.hxx|1 -
 2 files changed, 4 insertions(+), 16 deletions(-)

New commits:
commit 17402c73cfd513ade823a5f26c17371766047b6d
Author: Lionel Elie Mamane lio...@mamane.lu
Date:   Sun Dec 21 18:44:26 2014 +0100

fdo#87555 ComboBox in table should use same formatting as floating ComboBox

Same as fdo#67615 for TexFields, but for ComboBox.
Same problem, same cause, same solution.
ListBox seems not to have this problem :)

Change-Id: I953c5452f6c313b8940fbd1048b4c901b331fc58
Reviewed-on: https://gerrit.libreoffice.org/13578
Reviewed-by: Lionel Elie Mamane lio...@mamane.lu
Tested-by: Lionel Elie Mamane lio...@mamane.lu

diff --git a/svx/source/fmcomp/gridcell.cxx b/svx/source/fmcomp/gridcell.cxx
index c594238..4ed0c87 100644
--- a/svx/source/fmcomp/gridcell.cxx
+++ b/svx/source/fmcomp/gridcell.cxx
@@ -2407,7 +2407,6 @@ bool DbTimeField::commitControl()
 
 DbComboBox::DbComboBox(DbGridColumn _rColumn)
:DbCellControl(_rColumn)
-   ,m_nKeyType(::com::sun::star::util::NumberFormat::UNDEFINED)
 {
 setAlignedController( false );
 
@@ -2479,9 +2478,6 @@ void DbComboBox::Init( vcl::Window rParent, const 
Reference XRowSet  xCursor
 SetList( xModel-getPropertyValue( FM_PROP_STRINGITEMLIST ) );
 implAdjustGenericFieldSetting( xModel );
 
-if (m_rColumn.GetParent().getNumberFormatter().is())
-m_nKeyType  = 
comphelper::getNumberFormatType(m_rColumn.GetParent().getNumberFormatter()-getNumberFormatsSupplier()-getNumberFormats(),
 m_rColumn.GetKey());
-
 DbCellControl::Init( rParent, xCursor );
 }
 
@@ -2494,17 +2490,10 @@ CellControllerRef DbComboBox::CreateController() const
 
 OUString DbComboBox::GetFormatText(const Reference 
::com::sun::star::sdb::XColumn  _rxField, const Reference XNumberFormatter 
 xFormatter, Color** /*ppColor*/)
 {
-OUString aString;
-if (_rxField.is())
-try
-{
-aString = getFormattedValue( _rxField, xFormatter, 
m_rColumn.GetParent().getNullDate(), m_rColumn.GetKey(), m_nKeyType );
-}
-catch( const Exception )
-{
-DBG_UNHANDLED_EXCEPTION();
-}
-return aString;
+const com::sun::star::uno::Referencecom::sun::star::beans::XPropertySet 
xPS(_rxField, UNO_QUERY);
+::dbtools::FormattedColumnValue fmter( xFormatter, xPS );
+
+return fmter.getFormattedValue();
 }
 
 
diff --git a/svx/source/inc/gridcell.hxx b/svx/source/inc/gridcell.hxx
index 5d23f19..8d1ddf9 100644
--- a/svx/source/inc/gridcell.hxx
+++ b/svx/source/inc/gridcell.hxx
@@ -467,7 +467,6 @@ protected:
 
 class DbComboBox : public DbCellControl
 {
-sal_Int16 m_nKeyType;
 
 public:
 TYPEINFO_OVERRIDE();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source sc/workben

2014-12-21 Thread Michael Weghorn
 sc/source/ui/vba/vbachart.cxx   |4 ++--
 sc/source/ui/vba/vbarange.cxx   |   15 +++
 sc/source/ui/view/cellsh1.cxx   |7 ---
 sc/source/ui/view/drawvie3.cxx  |9 +++--
 sc/source/ui/view/output.cxx|9 +++--
 sc/source/ui/view/output2.cxx   |4 ++--
 sc/source/ui/view/viewfun3.cxx  |6 ++
 sc/source/ui/xmlsource/xmlsourcedlg.cxx |9 +++--
 sc/workben/dpcache/perf-test.cpp|3 +--
 9 files changed, 27 insertions(+), 39 deletions(-)

New commits:
commit 8870e068cc7368ffa14a6938836b370d2a188b64
Author: Michael Weghorn m.wegh...@posteo.de
Date:   Sat Dec 20 20:47:39 2014 +0100

fdo#39440 sc: reduce scope of local variables

This addresses some cppcheck warnings.

Change-Id: Icd031be4aeec07ba60804923e3506d64cf876dd8

diff --git a/sc/source/ui/vba/vbachart.cxx b/sc/source/ui/vba/vbachart.cxx
index f9f8db7..dd89baa 100644
--- a/sc/source/ui/vba/vbachart.cxx
+++ b/sc/source/ui/vba/vbachart.cxx
@@ -923,9 +923,9 @@ ScVbaChart::is100PercentStacked() throw ( 
uno::RuntimeException )
 sal_Int32
 ScVbaChart::getSolidType(sal_Int32 _nDeep, sal_Int32 _nVertiStacked, sal_Int32 
_nVerti100PercentStacked, sal_Int32 _nVertiUnStacked, sal_Int32 _nHoriStacked, 
sal_Int32 _nHori100PercentStacked, sal_Int32 _nHoriUnStacked) throw ( 
script::BasicErrorException )
 {
-bool bIsVertical = true;
 try
 {
+bool bIsVertical = true;
 mxDiagramPropertySet-getPropertyValue(VERTICAL) = bIsVertical;
 bool bIsDeep = false;
 mxDiagramPropertySet-getPropertyValue(DEEP) = bIsDeep;
@@ -955,9 +955,9 @@ ScVbaChart::getSolidType(sal_Int32 _nDeep, sal_Int32 
_nVertiStacked, sal_Int32 _
 sal_Int32
 ScVbaChart::getStockUpDownValue(sal_Int32 _nUpDown, sal_Int32 _nNotUpDown) 
throw (script::BasicErrorException)
 {
-bool bUpDown = false;
 try
 {
+bool bUpDown = false;
 mxDiagramPropertySet-getPropertyValue(UPDOWN) = bUpDown;
 if (bUpDown)
 {
diff --git a/sc/source/ui/vba/vbarange.cxx b/sc/source/ui/vba/vbarange.cxx
index 642ddec..6102226 100644
--- a/sc/source/ui/vba/vbarange.cxx
+++ b/sc/source/ui/vba/vbarange.cxx
@@ -1190,7 +1190,6 @@ bool getScRangeListForAddress( const OUString sName, 
ScDocShell* pDocSh, ScRang
 OUString sAddress = (*it).trim();
 // if a local name ( on the active sheet ) exists this will
 // take precedence over a global with the same name
-bool bLocalName = false;
 if ( !xNameAccess-hasByName( sAddress ) )
 {
 // try a local name
@@ -1199,7 +1198,7 @@ bool getScRangeListForAddress( const OUString sName, 
ScDocShell* pDocSh, ScRang
 ScRangeName* pRangeName = rDoc.GetRangeName(nCurTab);
 if (pRangeName)
 {
-bLocalName = 
pRangeName-findByUpperName(ScGlobal::pCharClass-uppercase(sAddress)) != NULL;
+bool bLocalName = 
pRangeName-findByUpperName(ScGlobal::pCharClass-uppercase(sAddress)) != NULL;
 // TODO: Handle local names correctly.
 (void)bLocalName;
 }
@@ -2094,9 +2093,9 @@ ScVbaRange::Address(  const uno::Any RowAbsolute, const 
uno::Any ColumnAbsolut
 if ( !bVal )
 nFlags = ~COL_ABSOLUTE;
 }
-bool bLocal = false;
 if ( External.hasValue() )
 {
+bool bLocal = false;
 External = bLocal;
 if (  bLocal )
 nFlags |= SCA_TAB_3D | SCA_FORCE_DOC;
@@ -3045,7 +3044,6 @@ ScVbaRange::Replace( const OUString What, const 
OUString Replacement, const un
 sal_Int16 nLook =  globalSearchOptions.GetWordOnly() ?  
excel::XlLookAt::xlPart : excel::XlLookAt::xlWhole;
 sal_Int16 nSearchOrder = globalSearchOptions.GetRowDirection() ? 
excel::XlSearchOrder::xlByRows : excel::XlSearchOrder::xlByColumns;
 
-bool bMatchCase = false;
 uno::Reference util::XReplaceable  xReplace( mxRange, uno::UNO_QUERY );
 if ( xReplace.is() )
 {
@@ -3088,6 +3086,8 @@ ScVbaRange::Replace( const OUString What, const 
OUString Replacement, const un
 }
 if ( MatchCase.hasValue() )
 {
+bool bMatchCase = false;
+
 // SearchCaseSensitive
 MatchCase = bMatchCase;
 xDescriptor-setPropertyValue( SC_UNO_SRCHCASE, uno::makeAny( 
bMatchCase ) );
@@ -4470,7 +4470,6 @@ ScVbaRange::AutoFilter( const uno::Any aField, const 
uno::Any Criteria1, const
 
 if (  !aField.hasValue()  ( Criteria1.hasValue() || Operator.hasValue() 
|| Criteria2.hasValue() ) )
 throw uno::RuntimeException();
-bool bAll = false;
 uno::Any Field( aField );
 if ( !( Field = nField ) )
 {
@@ -4488,6 +4487,8 @@ ScVbaRange::AutoFilter( const uno::Any aField, const 
uno::Any Criteria1, const
 // in this case we just call the core calc functionality -
 if ( ( Field = nField )  )
 {
+bool bAll = false;
+
 

[Bug 39440] cppcheck cleanliness

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #41 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8870e068cc7368ffa14a6938836b370d2a188b64

fdo#39440 sc: reduce scope of local variables

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 4 commits - writerfilter/inc writerfilter/Library_writerfilter.mk writerfilter/source

2014-12-21 Thread Miklos Vajna
 writerfilter/Library_writerfilter.mk  |2 
 writerfilter/inc/resourcemodel/TagLogger.hxx  |   83 --
 writerfilter/inc/resourcemodel/WW8ResourceModel.hxx   |   18 +
 writerfilter/source/dmapper/DomainMapper.cxx  |   31 ++
 writerfilter/source/dmapper/DomainMapper.hxx  |3 
 writerfilter/source/dmapper/DomainMapper_Impl.cxx |   11 
 writerfilter/source/dmapper/DomainMapper_Impl.hxx |   10 
 writerfilter/source/dmapper/GraphicHelpers.cxx|  116 +++-
 writerfilter/source/dmapper/GraphicHelpers.hxx|   11 
 writerfilter/source/dmapper/GraphicImport.cxx |   14 -
 writerfilter/source/dmapper/GraphicImport.hxx |2 
 writerfilter/source/dmapper/LoggedResources.cxx   |   30 ++
 writerfilter/source/dmapper/LoggedResources.hxx   |7 
 writerfilter/source/dmapper/PropertyMap.hxx   |2 
 writerfilter/source/dmapper/PropertyMapHelper.cxx |2 
 writerfilter/source/dmapper/TableManager.hxx  |2 
 writerfilter/source/dmapper/TagLogger.cxx |  243 ++
 writerfilter/source/dmapper/TagLogger.hxx |   83 ++
 writerfilter/source/dmapper/dmapperLoggers.hxx|2 
 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |   28 --
 writerfilter/source/resourcemodel/TagLogger.cxx   |  243 --
 writerfilter/source/rtftok/rtfdocumentimpl.cxx|   41 +--
 22 files changed, 519 insertions(+), 465 deletions(-)

New commits:
commit be34823092ce05002be61a50d0dbf156bb5095ba
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Sun Dec 21 15:08:02 2014 +0100

writerfilter: hardcoded cFieldStart/Sep/End

Change-Id: If7278418e1c7f8b8f812ce0b01720f8666e9ae5a

diff --git a/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx 
b/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
index f00592d..b6ba40e 100644
--- a/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
+++ b/writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
@@ -170,6 +170,10 @@ protected:
 ~BinaryObj() {}
 };
 
+const sal_uInt8 cFieldStart = 0x13;
+const sal_uInt8 cFieldSep = 0x14;
+const sal_uInt8 cFieldEnd = 0x15;
+
 /**
Handler for a stream.
  */
diff --git a/writerfilter/source/dmapper/DomainMapper.cxx 
b/writerfilter/source/dmapper/DomainMapper.cxx
index af00497..b85538c 100644
--- a/writerfilter/source/dmapper/DomainMapper.cxx
+++ b/writerfilter/source/dmapper/DomainMapper.cxx
@@ -2856,15 +2856,15 @@ void DomainMapper::lcl_text(const sal_uInt8 * data_, 
size_t len)
 
m_pImpl-finishParagraph(m_pImpl-GetTopContextOfType(CONTEXT_PARAGRAPH));
 return;
 }
-case 0x13:
+case cFieldStart:
 m_pImpl-PushFieldContext();
 return;
-case 0x14:
+case cFieldSep:
 // delimiter not necessarily available
 // appears only if field contains further content
 m_pImpl-CloseFieldCommand();
 return;
-case 0x15: /* end of field */
+case cFieldEnd:
 m_pImpl-PopFieldContext();
 return;
 default:
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index df119b5..678b19e 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -2551,9 +2551,6 @@ uno::Reference beans::XPropertySet  
DomainMapper_Impl::FindOrCreateFieldMaster
 return xMaster;
 }
 
-/*-
-//field context starts with a 0x13
-  ---*/
 void DomainMapper_Impl::PushFieldContext()
 {
 m_bParaHadField = true;
@@ -3389,9 +3386,6 @@ void DomainMapper_Impl::handleIndex
 }
 }
 
-/*-
-//the field command has to be closed (0x14 appeared)
-  ---*/
 void DomainMapper_Impl::CloseFieldCommand()
 {
 if(m_bDiscardHeaderFooter)
@@ -4278,9 +4272,6 @@ void 
DomainMapper_Impl::SetFieldFFData(FFDataHandler::Pointer_t pFFDataHandler)
 #endif
 }
 
-/*-
-//the end of field is reached (0x15 appeared) - the command might still be open
-  ---*/
 void DomainMapper_Impl::PopFieldContext()
 {
 if(m_bDiscardHeaderFooter)
diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.hxx 
b/writerfilter/source/dmapper/DomainMapper_Impl.hxx
index 3a9658f..3cabbf5 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.hxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.hxx

[Libreoffice-commits] core.git: scaddins/source scripting/source sd/source

2014-12-21 Thread Michael Weghorn
 scaddins/source/analysis/bessel.cxx|8 ++--
 scaddins/source/analysis/financial.cxx |7 +++
 scripting/source/dlgprov/dlgprov.cxx   |2 +-
 scripting/source/stringresource/stringresource.cxx |2 +-
 sd/source/core/EffectMigration.cxx |7 +++
 sd/source/core/drawdoc.cxx |3 +--
 sd/source/core/drawdoc2.cxx|   12 +---
 sd/source/core/drawdoc4.cxx|6 ++
 sd/source/core/sdpage2.cxx |9 +++--
 sd/source/filter/eppt/epptso.cxx   |3 ++-
 sd/source/filter/eppt/pptx-text.cxx|2 +-
 11 files changed, 24 insertions(+), 37 deletions(-)

New commits:
commit 17fc7aa3b8fcd731fb05b5e17e23ee984d166a8f
Author: Michael Weghorn m.wegh...@posteo.de
Date:   Sat Dec 20 21:09:40 2014 +0100

fdo#39440 reduce scope of local variables

This addresses some cppcheck warnings.

Change-Id: I390607e002e93cf7a6babc26d9be084d9f185058

diff --git a/scaddins/source/analysis/bessel.cxx 
b/scaddins/source/analysis/bessel.cxx
index 5a4581b..9161655 100644
--- a/scaddins/source/analysis/bessel.cxx
+++ b/scaddins/source/analysis/bessel.cxx
@@ -284,15 +284,13 @@ double BesselK( double fNum, sal_Int32 nOrder ) throw( 
IllegalArgumentException,
 case 1: return Besselk1( fNum );
 default:
 {
-double  fBkp;
-
 double  fTox = 2.0 / fNum;
 double  fBkm = Besselk0( fNum );
 double  fBk = Besselk1( fNum );
 
 for( sal_Int32 n = 1 ; n  nOrder ; n++ )
 {
-fBkp = fBkm + double( n ) * fTox * fBk;
+const double fBkp = fBkm + double( n ) * fTox * fBk;
 fBkm = fBk;
 fBk = fBkp;
 }
@@ -438,15 +436,13 @@ double BesselY( double fNum, sal_Int32 nOrder ) throw( 
IllegalArgumentException,
 case 1: return Bessely1( fNum );
 default:
 {
-double  fByp;
-
 double  fTox = 2.0 / fNum;
 double  fBym = Bessely0( fNum );
 double  fBy = Bessely1( fNum );
 
 for( sal_Int32 n = 1 ; n  nOrder ; n++ )
 {
-fByp = double( n ) * fTox * fBy - fBym;
+const double fByp = double( n ) * fTox * fBy - fBym;
 fBym = fBy;
 fBy = fByp;
 }
diff --git a/scaddins/source/analysis/financial.cxx 
b/scaddins/source/analysis/financial.cxx
index 7e79fba..81cf3c4 100644
--- a/scaddins/source/analysis/financial.cxx
+++ b/scaddins/source/analysis/financial.cxx
@@ -539,14 +539,13 @@ double SAL_CALL AnalysisAddIn::getXirr(
 static const sal_Int32 nMaxIter = 50;
 
 // Newton's method - try to find a fResultRate, so that 
lcl_sca_XirrResult() returns 0.
-double fNewRate, fRateEps, fResultValue;
 sal_Int32 nIter = 0;
 bool bContLoop;
 do
 {
-fResultValue = lcl_sca_XirrResult( aValues, aDates, fResultRate );
-fNewRate = fResultRate - fResultValue / lcl_sca_XirrResult_Deriv1( 
aValues, aDates, fResultRate );
-fRateEps = fabs( fNewRate - fResultRate );
+double fResultValue = lcl_sca_XirrResult( aValues, aDates, fResultRate 
);
+double fNewRate = fResultRate - fResultValue / 
lcl_sca_XirrResult_Deriv1( aValues, aDates, fResultRate );
+double fRateEps = fabs( fNewRate - fResultRate );
 fResultRate = fNewRate;
 bContLoop = (fRateEps  fMaxEps)  (fabs( fResultValue )  fMaxEps);
 }
diff --git a/scripting/source/dlgprov/dlgprov.cxx 
b/scripting/source/dlgprov/dlgprov.cxx
index 3829429..c6b23ba 100644
--- a/scripting/source/dlgprov/dlgprov.cxx
+++ b/scripting/source/dlgprov/dlgprov.cxx
@@ -669,9 +669,9 @@ static const char aResourceResolverPropName[] = 
ResourceResolver;
 uno::Reference beans::XPropertySet  xDlgModPropSet( 
xCtrlMod, uno::UNO_QUERY );
 if( xDlgModPropSet.is() )
 {
-bool bDecoration = true;
 try
 {
+bool bDecoration = true;
 Any aDecorationAny = xDlgModPropSet-getPropertyValue( 
aDecorationPropName );
 aDecorationAny = bDecoration;
 if( !bDecoration )
diff --git a/scripting/source/stringresource/stringresource.cxx 
b/scripting/source/stringresource/stringresource.cxx
index cde4e73..667a900 100644
--- a/scripting/source/stringresource/stringresource.cxx
+++ b/scripting/source/stringresource/stringresource.cxx
@@ -543,10 +543,10 @@ void StringResourceImpl::removeLocale( const Locale 
locale )
 sal_Int32 nLocaleCount = m_aLocaleItemVector.size();
 if( nLocaleCount  1 )
 {
-LocaleItem* pFallbackItem = NULL;
 if( m_pCurrentLocaleItem 

[Bug 39440] cppcheck cleanliness

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #42 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=17fc7aa3b8fcd731fb05b5e17e23ee984d166a8f

fdo#39440 reduce scope of local variables

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: sd/source

2014-12-21 Thread Michael Weghorn
 sd/source/filter/html/htmlex.cxx   |6 ++
 sd/source/filter/ppt/pptin.cxx |9 +
 sd/source/ui/animations/CustomAnimationList.cxx|9 +++--
 sd/source/ui/dlg/custsdlg.cxx  |6 ++
 sd/source/ui/dlg/dlgassim.cxx  |3 +--
 sd/source/ui/dlg/sdtreelb.cxx  |5 ++---
 sd/source/ui/func/fuinsfil.cxx |3 +--
 sd/source/ui/sidebar/CurrentMasterPagesSelector.cxx|6 ++
 sd/source/ui/slidesorter/controller/SlsSlotManager.cxx |3 +--
 sd/source/ui/unoidl/unolayer.cxx   |3 +--
 sd/source/ui/unoidl/unopback.cxx   |3 +--
 sd/source/ui/view/drviews2.cxx |3 +--
 sd/source/ui/view/drviewsa.cxx |3 +--
 sd/source/ui/view/drviewsf.cxx |2 +-
 sd/source/ui/view/frmview.cxx  |6 ++
 sd/source/ui/view/outlview.cxx |6 ++
 sd/source/ui/view/sdview.cxx   |3 +--
 sd/source/ui/view/sdview2.cxx  |3 ++-
 sd/source/ui/view/sdview3.cxx  |4 ++--
 19 files changed, 33 insertions(+), 53 deletions(-)

New commits:
commit fb7c18884223f08818b44a9953b55c69a029c71c
Author: Michael Weghorn m.wegh...@posteo.de
Date:   Sat Dec 20 21:45:16 2014 +0100

fdo#39440 sd: reduce scope of local variables

This addresses some cppcheck warnings.

Change-Id: I14107ca24aa98f4111f542c3999866eb1a93a72b

diff --git a/sd/source/filter/html/htmlex.cxx b/sd/source/filter/html/htmlex.cxx
index 66544a2..23a3ce3 100644
--- a/sd/source/filter/html/htmlex.cxx
+++ b/sd/source/filter/html/htmlex.cxx
@@ -1035,12 +1035,11 @@ bool HtmlExport::CreateImagesForPresPages( bool 
bThumbnail)
 SdrTextObj* HtmlExport::GetLayoutTextObject(SdrPage* pPage)
 {
 const size_t nObjectCount = pPage-GetObjCount();
-SdrObject*  pObject  = NULL;
 SdrTextObj* pResult  = NULL;
 
 for (size_t nObject = 0; nObject  nObjectCount; ++nObject)
 {
-pObject = pPage-GetObj(nObject);
+SdrObject* pObject = pPage-GetObj(nObject);
 if (pObject-GetObjInventor() == SdrInventor 
 pObject-GetObjIdentifier() == OBJ_OUTLINETEXT)
 {
@@ -1326,13 +1325,12 @@ void HtmlExport::WriteOutlinerParagraph(OUStringBuffer 
aStr, SdrOutliner* pOutl
 
 sal_Int32 nCount = pOutliner-GetParagraphCount();
 
-Paragraph* pParagraph = NULL;
 
 sal_Int16 nCurrentDepth = -1;
 
 for (sal_Int32 nIndex = 0; nIndex  nCount; nIndex++)
 {
-pParagraph = pOutliner-GetParagraph(nIndex);
+Paragraph* pParagraph = pOutliner-GetParagraph(nIndex);
 if(pParagraph == NULL)
 continue;
 
diff --git a/sd/source/filter/ppt/pptin.cxx b/sd/source/filter/ppt/pptin.cxx
index 70a8ba0..b01e1b6 100644
--- a/sd/source/filter/ppt/pptin.cxx
+++ b/sd/source/filter/ppt/pptin.cxx
@@ -872,8 +872,6 @@ bool ImplSdPPTImport::Import()
 {
 for ( sal_uInt16 nPage = 0; nPage  nPageAnz; nPage++ )
 {
-bool bNewAnimationsUsed = false;
-
 mePresChange = PRESCHANGE_SEMIAUTO;
 SetPageNum( nPage, PPT_SLIDEPAGE );
 SdPage* pPage = static_castSdPage*(MakeBlancPage( false ));
@@ -896,6 +894,8 @@ bool ImplSdPPTImport::Import()
 DffRecordHeader aPageHd;
 if ( SeekToAktPage( aPageHd ) )
 {
+bool bNewAnimationsUsed = false;
+
 aPageHd.SeekToContent( rStCtrl );
 while ( ( rStCtrl.GetError() == 0 )  ( rStCtrl.Tell()  
aPageHd.GetRecEndFilePos() ) )
 {
@@ -2527,12 +2527,13 @@ SdrObject* ImplSdPPTImport::ProcessObj( SvStream rSt, 
DffObjData rObjData, voi
 pObj, PRESOBJ_PAGE );
 }
 
-bool bInhabitanceChecked = false;
-bool bAnimationInfoFound = false;
 DffRecordHeader aMasterShapeHd;
 
 if ( maShapeRecords.SeekToContent( rSt, DFF_msofbtClientData, 
SEEK_FROM_CURRENT_AND_RESTART ) )
 {
+bool bInhabitanceChecked = false;
+bool bAnimationInfoFound = false;
+
 DffRecordHeader rHdClientData = *maShapeRecords.Current();
 while( true )
 {
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx 
b/sd/source/ui/animations/CustomAnimationList.cxx
index e62b84b..c29cd2e 100644
--- a/sd/source/ui/animations/CustomAnimationList.cxx
+++ b/sd/source/ui/animations/CustomAnimationList.cxx
@@ -541,9 +541,6 @@ void CustomAnimationList::update()
 long nLastVis = -1;
 long nFirstSelOld = -1;
 long nLastSelOld = -1;
-bool bMoved = false;
-bool bMovedUp = false;
-bool bMovedDown = false;
 
 if( mpMainSequence.get() )

[Bug 39440] cppcheck cleanliness

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #43 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=fb7c18884223f08818b44a9953b55c69a029c71c

fdo#39440 sd: reduce scope of local variables

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 3 commits - compilerplugins/clang odk/CppunitTest_odk_checkapi.mk solenv/gbuild

2014-12-21 Thread Stephan Bergmann
 compilerplugins/clang/literaltoboolconversion.cxx |7 +--
 odk/CppunitTest_odk_checkapi.mk   |2 --
 solenv/gbuild/CppunitTest.mk  |1 -
 solenv/gbuild/Executable.mk   |1 -
 solenv/gbuild/Library.mk  |1 -
 solenv/gbuild/LinkTarget.mk   |   19 ++-
 solenv/gbuild/StaticLibrary.mk|1 -
 7 files changed, 11 insertions(+), 21 deletions(-)

New commits:
commit 1b1c86c14adb20f3f0429e4809f8b1d3d352899e
Author: Stephan Bergmann sberg...@redhat.com
Date:   Sun Dec 21 22:05:46 2014 +0100

Remove unused gb_*_disable_compiler_plugins

Change-Id: Ia6395282916011d75a4fa01aa12e96d866621411

diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk
index dd535ae7..bc1aa06 100644
--- a/solenv/gbuild/CppunitTest.mk
+++ b/solenv/gbuild/CppunitTest.mk
@@ -387,7 +387,6 @@ $(eval $(foreach method,\
set_warnings_not_errors \
set_external_code \
set_generated_cxx_suffix \
-   disable_compiler_plugins \
 ,\
$(call gb_CppunitTest__forward_to_Linktarget,$(method))\
 ))
diff --git a/solenv/gbuild/Executable.mk b/solenv/gbuild/Executable.mk
index d45e2dc..a3767b5 100644
--- a/solenv/gbuild/Executable.mk
+++ b/solenv/gbuild/Executable.mk
@@ -140,7 +140,6 @@ $(eval $(foreach method,\
set_warnings_not_errors \
set_external_code \
set_generated_cxx_suffix \
-   disable_compiler_plugins \
 ,\
$(call gb_Executable_forward_to_Linktarget,$(method))\
 ))
diff --git a/solenv/gbuild/Library.mk b/solenv/gbuild/Library.mk
index c66b57c..fc57b37 100644
--- a/solenv/gbuild/Library.mk
+++ b/solenv/gbuild/Library.mk
@@ -225,7 +225,6 @@ $(eval $(foreach method,\
set_warnings_not_errors \
set_external_code \
set_generated_cxx_suffix \
-   disable_compiler_plugins \
 ,\
$(call gb_Library__forward_to_Linktarget,$(method))\
 ))
diff --git a/solenv/gbuild/LinkTarget.mk b/solenv/gbuild/LinkTarget.mk
index 1859c8b..9faed8c 100644
--- a/solenv/gbuild/LinkTarget.mk
+++ b/solenv/gbuild/LinkTarget.mk
@@ -136,7 +136,7 @@ $(call gb_CObject_get_target,%) : $(call 
gb_CObject_get_source,$(SRCDIR),%) $(gb
 else
 $(call gb_CObject_get_target,%) : $(call gb_CObject_get_source,$(SRCDIR),%)
$(call gb_Output_announce,$*.c,$(true),C  ,3)
-   $(call gb_CObject__command_pattern,$@,$(T_CFLAGS) 
$(T_CFLAGS_APPEND),$,$(call 
gb_CObject_get_dep_target,$*),$(T_COMPILER_PLUGINS))
+   $(call gb_CObject__command_pattern,$@,$(T_CFLAGS) 
$(T_CFLAGS_APPEND),$,$(call gb_CObject_get_dep_target,$*),$(COMPILER_PLUGINS))
 endif
 
 # Note: if the *Object_dep_target does not exist it will be created by
@@ -188,7 +188,7 @@ else
 $(call gb_CxxObject_get_target,%) : $(call gb_CxxObject_get_source,$(SRCDIR),%)
$(call gb_Output_announce,$*.cxx,$(true),CXX,3)
$(eval $(gb_CxxObject__set_pchflags))
-   $(call gb_CObject__command_pattern,$@,$(T_CXXFLAGS) 
$(T_CXXFLAGS_APPEND),$,$(call 
gb_CxxObject_get_dep_target,$*),$(T_COMPILER_PLUGINS))
+   $(call gb_CObject__command_pattern,$@,$(T_CXXFLAGS) 
$(T_CXXFLAGS_APPEND),$,$(call 
gb_CxxObject_get_dep_target,$*),$(COMPILER_PLUGINS))
 endif
 
 ifeq ($(gb_FULLDEPS),$(true))
@@ -212,7 +212,7 @@ gb_GenCObject_get_source = $(WORKDIR)/$(1).c
 $(call gb_GenCObject_get_target,%) :
$(call gb_Output_announce,$*.c,$(true),C  ,3)
test -f $(call gb_GenCObject_get_source,$*) || (echo Missing generated 
source file $(call gb_GenCObject_get_source,$*)  false)
-   $(call gb_CObject__command_pattern,$@,$(T_CFLAGS) 
$(T_CFLAGS_APPEND),$(call gb_GenCObject_get_source,$*),$(call 
gb_GenCObject_get_dep_target,$*),$(T_COMPILER_PLUGINS))
+   $(call gb_CObject__command_pattern,$@,$(T_CFLAGS) 
$(T_CFLAGS_APPEND),$(call gb_GenCObject_get_source,$*),$(call 
gb_GenCObject_get_dep_target,$*),$(COMPILER_PLUGINS))
 
 ifeq ($(gb_FULLDEPS),$(true))
 $(dir $(call gb_GenCObject_get_dep_target,%)).dir :
@@ -235,7 +235,7 @@ $(call gb_GenCxxObject_get_target,%) :
$(call gb_Output_announce,$(subst 
$(BUILDDIR)/,,$(GEN_CXX_SOURCE)),$(true),CXX,3)
test -f $(GEN_CXX_SOURCE) || (echo Missing generated source file 
$(GEN_CXX_SOURCE)  false)
$(eval $(gb_CxxObject__set_pchflags))
-   $(call gb_CObject__command_pattern,$@,$(T_CXXFLAGS) 
$(T_CXXFLAGS_APPEND),$(GEN_CXX_SOURCE),$(call 
gb_GenCxxObject_get_dep_target,$*),$(T_COMPILER_PLUGINS))
+   $(call gb_CObject__command_pattern,$@,$(T_CXXFLAGS) 
$(T_CXXFLAGS_APPEND),$(GEN_CXX_SOURCE),$(call 
gb_GenCxxObject_get_dep_target,$*),$(COMPILER_PLUGINS))
 
 ifeq ($(gb_FULLDEPS),$(true))
 $(dir $(call gb_GenCxxObject_get_dep_target,%)).dir :
@@ -321,7 +321,7 @@ $(call gb_ObjCxxObject_get_target,%) : $(call 
gb_ObjCxxObject_get_source,$(SRCDI
 else
 $(call gb_ObjCxxObject_get_target,%) : $(call 
gb_ObjCxxObject_get_source,$(SRCDIR),%)
$(call 

[Libreoffice-commits] core.git: sc/source

2014-12-21 Thread Julien Nabet
 sc/source/core/data/funcdesc.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 889e20bb1f37b063032e1ab6887a309204c84868
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Dec 21 22:45:43 2014 +0100

Resolves fdo#87558: Duplication in Last Used Functions sidebar list

Change-Id: If15199e205671d3e96e5c2b2940c0a6defced0e0

diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index 14b504e..912ae33 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -774,7 +774,10 @@ void 
ScFunctionMgr::fillLastRecentlyUsedFunctions(::std::vector const formula::
 if ( pLRUListIds )
 {
 for (sal_uInt16 i = 0; i  nLRUFuncCount; ++i)
-_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+{
+if (std::find(_rLastRUFunctions.begin(), _rLastRUFunctions.end(), 
Get(pLRUListIds[i])) == _rLastRUFunctions.end())
+_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Re: minutes of ESC call ...

2014-12-21 Thread Mat M

Hello

Le Thu, 18 Dec 2014 16:39:53 +0100, Michael Meeks  
michael.me...@collabora.com a écrit:



* gerrit daily digest AWOL (Bjoern)
+ seems to have died 2x weeks ago - any ideas ?
+ migration to new server in that time-frame (Michael)
+ would love to have that back on the dev-list

Yeah, this would  bring the new version pushed 2 months ago ;-)
Nice Xmas present for me.

+ ran 'git gc' on the send / E-mail copy
+ 60Gb - ~1ish Gb.
+ and setup an auto-gc.
I suppose you are talking about the core repo used to identify committers  
? we can enforce a git gc right after the update, daily, weekly, or  
monthly.
BTW, I am surprised by the volume since the repo is bare (or supposed to  
be, at least)


Regards

Mat
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: minutes of ESC call ...

2014-12-21 Thread Mat M

Le Sun, 21 Dec 2014 23:46:58 +0100, Mat M m...@gmx.fr a écrit:


Hello

Le Thu, 18 Dec 2014 16:39:53 +0100, Michael Meeks  
michael.me...@collabora.com a écrit:



* gerrit daily digest AWOL (Bjoern)
+ seems to have died 2x weeks ago - any ideas ?
+ migration to new server in that time-frame (Michael)
+ would love to have that back on the dev-list

Yeah, this would  bring the new version pushed 2 months ago ;-)
Nice Xmas present for me.


Well, seeing the week-end mails, I think this is not the last version.
Could someone check if tools repo is up-to-date and  
gerritbot/send-daily-digest has line 75 like:

  subprocess.call(['git','fetch','origin','master:master'])
If confirmed, I need to dig more about updates (Douglas Mencken and  
Michael Weghorn are *not* fresh committers), so would be pleased with a  
small fix on gerrit VM, because, with my account, I got a


bash: gerrit: command not found

when I tried to query gerrit through ssh .


+ ran 'git gc' on the send / E-mail copy
+ 60Gb - ~1ish Gb.
+ and setup an auto-gc.
I suppose you are talking about the core repo used to identify  
committers ? we can enforce a git gc right after the update, daily,  
weekly, or monthly.
BTW, I am surprised by the volume since the repo is bare (or supposed to  
be, at least)

OK, you are doing so many changes... Keep up the good work !

Mat
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: 5 commits - chart2/qa cui/source sc/inc sc/source

2014-12-21 Thread Markus Mohrhard
 chart2/qa/extras/xshape/data/reference/fdo75075.xml |   84 +-
 chart2/qa/extras/xshape/data/reference/property-mapping-bar.xml |  326 
+-
 cui/source/options/optgdlg.cxx  |   22 
 sc/inc/scmatrix.hxx |2 
 sc/inc/token.hxx|3 
 sc/source/core/tool/interpr5.cxx|   26 
 sc/source/core/tool/interpr6.cxx|1 
 sc/source/core/tool/scmatrix.cxx|  309 
+
 8 files changed, 532 insertions(+), 241 deletions(-)

New commits:
commit 32d73c29a2b866fcd24b6f2a6a7d3390e4435e30
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 01:38:30 2014 +0100

fix error in last commit

Change-Id: Icafbe6e5daab64e7431d80c8956143341eb2ef0b

diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 7594025..cb7701f 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -2505,7 +2505,7 @@ public:
 
 double operator()(double nVal) const
 {
-return nVal - mnVal;
+return mnVal - nVal;
 }
 
 double operator()(bool bVal) const
commit 3d6cedd70b3c79b3ebb65c2662df420a8acb0818
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 00:14:35 2014 +0100

improve performance of some matrix operations, related fdo#83187

Change-Id: I0e6816a7f0d2dc051dff6a462724cb4a3c155289

diff --git a/sc/inc/scmatrix.hxx b/sc/inc/scmatrix.hxx
index 1e4c74f..a5117be 100644
--- a/sc/inc/scmatrix.hxx
+++ b/sc/inc/scmatrix.hxx
@@ -379,6 +379,8 @@ public:
 void GetDoubleArray( std::vectordouble rArray, bool bEmptyAsZero = true 
) const;
 void MergeDoubleArray( std::vectordouble rArray, Op eOp ) const;
 
+void SubAddOp(bool bSub, double fVal, svl::SharedString aString, ScMatrix 
rMat);
+
 ScMatrix operator+= ( const ScMatrix r );
 
 #if DEBUG_MATRIX
diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx
index e7b8b65..533aafb 100644
--- a/sc/source/core/tool/interpr5.cxx
+++ b/sc/source/core/tool/interpr5.cxx
@@ -1188,6 +1188,11 @@ void ScInterpreter::ScAdd()
 {
 CalculateAddSub(false);
 }
+
+namespace {
+
+}
+
 void ScInterpreter::CalculateAddSub(bool _bSub)
 {
 ScMatrixRef pMat1 = NULL;
@@ -1278,26 +1283,21 @@ void ScInterpreter::CalculateAddSub(bool _bSub)
 ScMatrixRef pResMat = GetNewMat(nC, nR);
 if (pResMat)
 {
-SCSIZE nCount = nC * nR;
+svl::SharedString aString = 
mrStrPool.intern(ScGlobal::GetRscString(STR_NO_VALUE));
 if (bFlag || !_bSub )
 {
-for ( SCSIZE i = 0; i  nCount; i++ )
+if (_bSub)
 {
-if (pMat-IsValue(i))
-pResMat-PutDouble( _bSub ? ::rtl::math::approxSub( 
fVal, pMat-GetDouble(i)) : ::rtl::math::approxAdd( pMat-GetDouble(i), fVal), 
i);
-else
-
pResMat-PutString(mrStrPool.intern(ScGlobal::GetRscString(STR_NO_VALUE)), i);
+pMat-SubAddOp(true, fVal, aString, *pResMat);
+}
+else
+{
+pMat-SubAddOp(false, fVal, aString, *pResMat);
 }
 }
 else
 {
-for ( SCSIZE i = 0; i  nCount; i++ )
-{
-if (pMat-IsValue(i))
-pResMat-PutDouble( ::rtl::math::approxSub( 
pMat-GetDouble(i), fVal), i);
-else
-
pResMat-PutString(mrStrPool.intern(ScGlobal::GetRscString(STR_NO_VALUE)), i);
-}
+pMat-SubAddOp(true, fVal, aString, *pResMat);
 }
 PushMatrix(pResMat);
 }
diff --git a/sc/source/core/tool/scmatrix.cxx b/sc/source/core/tool/scmatrix.cxx
index 5b6ccbe..7594025 100644
--- a/sc/source/core/tool/scmatrix.cxx
+++ b/sc/source/core/tool/scmatrix.cxx
@@ -286,6 +286,9 @@ public:
 void MergeDoubleArray( std::vectordouble rArray, ScMatrix::Op eOp ) 
const;
 void AddValues( const ScMatrixImpl rMat );
 
+templatetypename T
+void ApplyOperation(T aOp, ScMatrixImpl rMat);
+
 #if DEBUG_MATRIX
 void Dump() const;
 #endif
@@ -1821,6 +1824,214 @@ void ScMatrixImpl::AddValues( const ScMatrixImpl rMat )
 }
 }
 
+namespace Op {
+
+templatetypename T
+struct return_type
+{
+typedef T type;
+};
+
+template
+struct return_typebool
+{
+typedef double type;
+};
+
+template
+struct return_typechar
+{
+typedef svl::SharedString type;
+};
+
+}
+
+templatetypename T, typename U
+struct wrapped_iterator
+{
+typedef ::std::bidirectional_iterator_tag iterator_category;
+typedef typename T::const_iterator::value_type old_value_type;
+typedef typename 

[Libreoffice-commits] core.git: solenv/bin solenv/gbuild

2014-12-21 Thread Norbert Thiebaud
 solenv/bin/write_classpath.sh |   16 
 solenv/gbuild/Jar.mk  |6 +++---
 2 files changed, 19 insertions(+), 3 deletions(-)

New commits:
commit 4ca4050de7a33985b359b527a59abac3ac3a87f5
Author: Norbert Thiebaud nthieb...@gmail.com
Date:   Sun Dec 21 18:44:27 2014 -0600

try to keep Class-Path lenght under control

Change-Id: I5cc6f325eff9f5177e77de661728621383fa5558

diff --git a/solenv/bin/write_classpath.sh b/solenv/bin/write_classpath.sh
new file mode 100755
index 000..29aeecb
--- /dev/null
+++ b/solenv/bin/write_classpath.sh
@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+
+dest=$1
+shift
+base='Class-Path: '
+
+while [ ${1} !=  ]; do
+p=$1
+shift
+echo $base $1  $dest
+base=' '
+done
+
+#echo added classpath
+#cat $dest
+#echo ===
diff --git a/solenv/gbuild/Jar.mk b/solenv/gbuild/Jar.mk
index c9fd2b9c3..151fb99 100644
--- a/solenv/gbuild/Jar.mk
+++ b/solenv/gbuild/Jar.mk
@@ -34,7 +34,7 @@ $(call gb_JavaClassSet_get_classdir,$(call 
gb_Jar_get_classsetname,$(1)))
 endef
 
 # location of manifest file in workdir
-define gb_Jar_get_manifest_target 
+define gb_Jar_get_manifest_target
 $(call gb_Jar_get_workdir,$(1))/META-INF/MANIFEST.MF
 endef
 
@@ -43,7 +43,7 @@ gb_Jar__get_dir_for_layer = $(patsubst $(1):%,%,$(filter 
$(1):%,$(gb_Jar_LAYER_D
 gb_Jar_get_install_target = $(call gb_Jar__get_dir_for_layer,$(call 
gb_Jar__get_layer,$(1)))/$(1).jar
 
 # creates classset and META-INF folders if they don't exist
-# adds manifest version, class path, solarversion and content from sources to 
manifest file 
+# adds manifest version, class path, solarversion and content from sources to 
manifest file
 # creates the target folder of the jar file if it doesn't exist
 # creates the jar file
 # jar program does not remove the target in case of error, so rm it manually
@@ -58,7 +58,7 @@ define gb_Jar__command
$(call gb_Helper_abbreviate_dirs,\
mkdir -p $(call gb_Jar_get_workdir,$(1))/META-INF  \
echo Manifest-Version: 1.0  $(call gb_Jar_get_manifest_target,$(1))  
\
-   $(if $(JARCLASSPATH),echo Class-Path: $(strip $(JARCLASSPATH))  
$(call gb_Jar_get_manifest_target,$(1)) ) \
+   $(if $(JARCLASSPATH),$(SRCDIR)/solenv/bin/write_classpath.sh $(call 
gb_Jar_get_manifest_target,$(1)) $(strip $(JARCLASSPATH)) ) \
echo Solar-Version: 
$(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO).$(LIBO_VERSION_PATCH)
  $(call gb_Jar_get_manifest_target,$(1))  \
$(if $(MANIFEST),cat $(MANIFEST)  $(call 
gb_Jar_get_manifest_target,$(1)) ) \
mkdir -p $(dir $(2))  cd $(call gb_Jar_get_workdir,$(1))  \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source

2014-12-21 Thread Julien Nabet
 sc/source/core/data/funcdesc.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 8ef3727ea2cab81605913b866d8eaef341f26b00
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Dec 21 22:45:43 2014 +0100

Resolves fdo#87558: Duplication in Last Used Functions sidebar list

Change-Id: If15199e205671d3e96e5c2b2940c0a6defced0e0
Reviewed-on: https://gerrit.libreoffice.org/13583
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index d7d1f9f..cdc6171 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -783,7 +783,10 @@ void 
ScFunctionMgr::fillLastRecentlyUsedFunctions(::std::vector const formula::
 if ( pLRUListIds )
 {
 for (sal_uInt16 i = 0; i  nLRUFuncCount; ++i)
-_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+{
+if (std::find(_rLastRUFunctions.begin(), _rLastRUFunctions.end(), 
Get(pLRUListIds[i])) == _rLastRUFunctions.end())
+_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source

2014-12-21 Thread Julien Nabet
 sc/source/core/data/funcdesc.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit a5e169a2f06b8ff159534a8d37e64ecb1a0f4d55
Author: Julien Nabet serval2...@yahoo.fr
Date:   Sun Dec 21 22:45:43 2014 +0100

Resolves fdo#87558: Duplication in Last Used Functions sidebar list

Change-Id: If15199e205671d3e96e5c2b2940c0a6defced0e0
Reviewed-on: https://gerrit.libreoffice.org/13582
Reviewed-by: Markus Mohrhard markus.mohrh...@googlemail.com
Tested-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sc/source/core/data/funcdesc.cxx b/sc/source/core/data/funcdesc.cxx
index 14b504e..912ae33 100644
--- a/sc/source/core/data/funcdesc.cxx
+++ b/sc/source/core/data/funcdesc.cxx
@@ -774,7 +774,10 @@ void 
ScFunctionMgr::fillLastRecentlyUsedFunctions(::std::vector const formula::
 if ( pLRUListIds )
 {
 for (sal_uInt16 i = 0; i  nLRUFuncCount; ++i)
-_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+{
+if (std::find(_rLastRUFunctions.begin(), _rLastRUFunctions.end(), 
Get(pLRUListIds[i])) == _rLastRUFunctions.end())
+_rLastRUFunctions.push_back( Get( pLRUListIds[i] ) );
+}
 }
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


Aron Budea license statement

2014-12-21 Thread Budea, Áron
All of my past  future contributions to LibreOffice may be licensed 
under the MPLv2/LGPLv3+ dual license.

-- 
Aron Budea
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-commits] core.git: svtools/source

2014-12-21 Thread Tomaž Vajngerl
 svtools/source/control/tabbar.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 87f3ff202efc3a4445d5af1a9526fb0369fa9371
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date:   Mon Dec 22 13:10:46 2014 +0900

fdo#56970 Show insert tab at the correct position when RTL is on

Change-Id: I1e7e751123fa3c3f365e5342211a0b75395a1711

diff --git a/svtools/source/control/tabbar.cxx 
b/svtools/source/control/tabbar.cxx
index 90d3edc..a7f8d0a 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -35,13 +35,14 @@
 #include svtools/svtools.hrc
 #include limits
 
-
+namespace {
 #define TABBAR_DRAG_SCROLLOFF   5
 #define TABBAR_MINSIZE  5
 
 const sal_uInt16 ADDNEWPAGE_AREAWIDTH = 10;
+const sal_uInt16 INSERT_TAB_WIDTH = 32;
 
-
+} // anonymous namespace
 
 struct ImplTabBarItem
 {
@@ -1730,12 +1731,14 @@ Rectangle TabBar::ImplGetInsertTabRect(ImplTabBarItem* 
pItem) const
 {
 if (mbHasInsertTab  pItem)
 {
+sal_Int32 aScaleFactor = GetDPIScaleFactor();
+sal_Int32 nInsertTabWidth = aScaleFactor * INSERT_TAB_WIDTH;
 Rectangle aInsTabRect = pItem-maRect;
 if ( !mbMirrored )
 aInsTabRect.setX(aInsTabRect.getX() + aInsTabRect.getWidth());
 else
-aInsTabRect.setX(aInsTabRect.getX());
-aInsTabRect.setWidth(32);
+aInsTabRect.setX(aInsTabRect.getX() - nInsertTabWidth);
+aInsTabRect.setWidth(nInsertTabWidth);
 return aInsTabRect;
 }
 return Rectangle();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - svtools/source

2014-12-21 Thread Tomaž Vajngerl
 svtools/source/control/tabbar.cxx |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

New commits:
commit d0379e8f220941087ea025b37b0f70eb25f8de07
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date:   Mon Dec 22 13:10:46 2014 +0900

fdo#56970 Show insert tab at the correct position when RTL is on

Change-Id: I1e7e751123fa3c3f365e5342211a0b75395a1711

diff --git a/svtools/source/control/tabbar.cxx 
b/svtools/source/control/tabbar.cxx
index 2f01cbc..638d875 100644
--- a/svtools/source/control/tabbar.cxx
+++ b/svtools/source/control/tabbar.cxx
@@ -35,13 +35,14 @@
 #include svtools/svtools.hrc
 #include limits
 
-
+namespace {
 #define TABBAR_DRAG_SCROLLOFF   5
 #define TABBAR_MINSIZE  5
 
 const sal_uInt16 ADDNEWPAGE_AREAWIDTH = 10;
+const sal_uInt16 INSERT_TAB_WIDTH = 32;
 
-
+} // anonymous namespace
 
 struct ImplTabBarItem
 {
@@ -1730,12 +1731,14 @@ Rectangle TabBar::ImplGetInsertTabRect(ImplTabBarItem* 
pItem) const
 {
 if (mbHasInsertTab  pItem)
 {
+sal_Int32 aScaleFactor = GetDPIScaleFactor();
+sal_Int32 nInsertTabWidth = aScaleFactor * INSERT_TAB_WIDTH;
 Rectangle aInsTabRect = pItem-maRect;
 if ( !mbMirrored )
 aInsTabRect.setX(aInsTabRect.getX() + aInsTabRect.getWidth());
 else
-aInsTabRect.setX(aInsTabRect.getX());
-aInsTabRect.setWidth(32);
+aInsTabRect.setX(aInsTabRect.getX() - nInsertTabWidth);
+aInsTabRect.setWidth(nInsertTabWidth);
 return aInsTabRect;
 }
 return Rectangle();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/source

2014-12-21 Thread Markus Mohrhard
 sc/source/filter/xcl97/XclExpChangeTrack.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit 4aae972ab14ef254d8eeaf859a431099f3a9afb7
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 05:00:24 2014 +0100

fix OOXML validation errors

Change-Id: Ieac082a3b312602eff5ec101529536d747fa3836

diff --git a/sc/source/filter/xcl97/XclExpChangeTrack.cxx 
b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
index 4cf119b..2989f20 100644
--- a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
+++ b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
@@ -1073,6 +1073,12 @@ void XclExpChTrCellContent::SaveXml( XclExpXmlStream 
rRevisionLogStrm )
 if( pOldData )
 {
 lcl_WriteCell( rRevisionLogStrm, XML_oc, aPosition, pOldData );
+if (!pNewData)
+{
+pStream-singleElement(XML_nc,
+XML_r,  XclXmlUtils::ToOString( aPosition ).getStr(),
+FSEND);
+}
 }
 if( pNewData )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.2' - sc/source

2014-12-21 Thread Markus Mohrhard
 sc/source/filter/xcl97/XclExpChangeTrack.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit ffb40fa1d7561d3847379488a61b340760924a64
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 05:00:24 2014 +0100

fix OOXML validation errors

Change-Id: Ieac082a3b312602eff5ec101529536d747fa3836

diff --git a/sc/source/filter/xcl97/XclExpChangeTrack.cxx 
b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
index fe27e92..ae86948 100644
--- a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
+++ b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
@@ -1109,6 +1109,12 @@ void XclExpChTrCellContent::SaveXml( XclExpXmlStream 
rRevisionLogStrm )
 if( pOldData )
 {
 lcl_WriteCell( rRevisionLogStrm, XML_oc, aPosition, pOldData );
+if (!pNewData)
+{
+pStream-singleElement(XML_nc,
+XML_r,  XclXmlUtils::ToOString( aPosition ).getStr(),
+FSEND);
+}
 }
 if( pNewData )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: 2 commits - sc/source

2014-12-21 Thread Markus Mohrhard
 sc/source/filter/excel/xelink.cxx |   34 +-
 1 file changed, 21 insertions(+), 13 deletions(-)

New commits:
commit b241910325456b32c2d3614c2e200305e85a357c
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 06:22:45 2014 +0100

fix another validation error for OOXML, related fdo#40746

e.g. exporting fdo40746-2.ods as OOXML

Change-Id: I8a19ec2caecbc3687229d820ac2ec11fc01facd1

diff --git a/sc/source/filter/excel/xelink.cxx 
b/sc/source/filter/excel/xelink.cxx
index 8ecef76..7cbf9a5 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -241,7 +241,7 @@ protected:
 /** Writes the list of externalName elements. */
 voidWriteExtNameBufferXml( XclExpXmlStream rStrm );
 
-private:
+protected:
 typedef boost::shared_ptr XclExpExtNameBufferXclExpExtNameBfrRef;
 XclExpExtNameBfrRef mxExtNameBfr;   /// List of EXTERNNAME records.
 };
@@ -1680,14 +1680,18 @@ void XclExpSupbook::SaveXml( XclExpXmlStream rStrm )
 
 }
 
-pExternalLink-startElement( XML_sheetDataSet, FSEND);
+if (!maXctList.IsEmpty() || mxExtNameBfr)
+{
+pExternalLink-startElement( XML_sheetDataSet, FSEND);
 
-// sheetData elements
-maXctList.SaveXml( rStrm );
-// externalName elements
-WriteExtNameBufferXml( rStrm );
+// sheetData elements
+maXctList.SaveXml( rStrm );
+// externalName elements
+WriteExtNameBufferXml( rStrm );
 
-pExternalLink-endElement( XML_sheetDataSet);
+pExternalLink-endElement( XML_sheetDataSet);
+
+}
 pExternalLink-endElement( XML_externalBook);
 pExternalLink-endElement( XML_externalLink);
 }
commit 3e551da43da5661396fbc2530a203d4774e29f78
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 06:18:07 2014 +0100

fix OOXML validation error, related fdo#40746

e.g. fdo40746-2.ods exported to OOXML

Change-Id: I48bc7a7d21ddc00eceaeb09970a2b1a60330fbf0

diff --git a/sc/source/filter/excel/xelink.cxx 
b/sc/source/filter/excel/xelink.cxx
index a347dce..8ecef76 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -1667,14 +1667,18 @@ void XclExpSupbook::SaveXml( XclExpXmlStream rStrm )
 FSNS(XML_r, XML_id),XclXmlUtils::ToOString( sId ).getStr(),
 FSEND);
 
-pExternalLink-startElement( XML_sheetNames, FSEND);
-for (size_t nPos = 0, nSize = maXctList.GetSize(); nPos  nSize; ++nPos)
+if (!maXctList.IsEmpty())
 {
-pExternalLink-singleElement( XML_sheetName,
-XML_val,XclXmlUtils::ToOString( maXctList.GetRecord( nPos 
)-GetTabName()).getStr(),
-FSEND);
+pExternalLink-startElement( XML_sheetNames, FSEND);
+for (size_t nPos = 0, nSize = maXctList.GetSize(); nPos  nSize; 
++nPos)
+{
+pExternalLink-singleElement( XML_sheetName,
+XML_val,XclXmlUtils::ToOString( maXctList.GetRecord( 
nPos )-GetTabName()).getStr(),
+FSEND);
+}
+pExternalLink-endElement( XML_sheetNames);
+
 }
-pExternalLink-endElement( XML_sheetNames);
 
 pExternalLink-startElement( XML_sheetDataSet, FSEND);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: sc/qa

2014-12-21 Thread Markus Mohrhard
 sc/qa/unit/data/xlsb/universal-content.xlsb |binary
 sc/qa/unit/filters-test.cxx |   12 
 sc/qa/unit/helper/qahelper.cxx  |3 ++-
 sc/qa/unit/helper/qahelper.hxx  |2 ++
 4 files changed, 16 insertions(+), 1 deletion(-)

New commits:
commit 319ba046b3a1266b20661116d742779417d38cbf
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Mon Dec 22 06:57:05 2014 +0100

add import test for xlsb

Change-Id: Ieb01027851b423287681f0145d3a39f98fc97f88

diff --git a/sc/qa/unit/data/xlsb/universal-content.xlsb 
b/sc/qa/unit/data/xlsb/universal-content.xlsb
new file mode 100644
index 000..fd9c253
Binary files /dev/null and b/sc/qa/unit/data/xlsb/universal-content.xlsb differ
diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index fab94ba..3e3b02b 100644
--- a/sc/qa/unit/filters-test.cxx
+++ b/sc/qa/unit/filters-test.cxx
@@ -72,6 +72,7 @@ public:
 void testContentXLSXStrict(); // strict OOXML
 void testContentLotus123();
 void testContentDIF();
+void testContentXLSB();
 //void testContentXLS_XML();
 void testSharedFormulaXLS();
 void testSharedFormulaXLSX();
@@ -93,6 +94,7 @@ public:
 CPPUNIT_TEST(testContentXLSXStrict);
 CPPUNIT_TEST(testContentLotus123);
 CPPUNIT_TEST(testContentDIF);
+CPPUNIT_TEST(testContentXLSB);
 //CPPUNIT_TEST(testContentXLS_XML);
 CPPUNIT_TEST(testSharedFormulaXLS);
 CPPUNIT_TEST(testSharedFormulaXLSX);
@@ -301,6 +303,16 @@ void ScFiltersTest::testContentDIF()
 xDocSh-DoClose();
 }
 
+void ScFiltersTest::testContentXLSB()
+{
+ScDocShellRef xDocSh = loadDoc(universal-content., XLSB);
+xDocSh-DoHardRecalc(true);
+
+ScDocument rDoc = xDocSh-GetDocument();
+testContentImpl(rDoc, XLSB);
+xDocSh-DoClose();
+}
+
 // void ScFiltersTest::testContentXLS_XML()
 // {
 // ScDocShellRef xDocSh = loadDoc(universal-content., XLS_XML);
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index 2b183eb..9713eac 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -74,7 +74,8 @@ FileFormat aFileFormats[] = {
 { html , calc_HTML_WebQuery, generic_HTML, HTML_FORMAT_TYPE },
 { 123 , Lotus, calc_Lotus, LOTUS123_FORMAT_TYPE },
 { dif, DIF, calc_DIF, DIF_FORMAT_TYPE },
-{ xml, MS Excel 2003 XML, calc_MS_Excel_2003_XML, 
XLS_XML_FORMAT_TYPE }
+{ xml, MS Excel 2003 XML, calc_MS_Excel_2003_XML, 
XLS_XML_FORMAT_TYPE },
+{ xlsb, Calc MS Excel 2007 Binary, MS Excel 2007 Binary, 
XLSB_XML_FORMAT_TYPE }
 };
 
 bool testEqualsWithTolerance( long nVal1, long nVal2, long nTol )
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index 30a655d..f204dba 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -48,6 +48,7 @@
 #define HTML_FORMAT_TYPE (SFX_FILTER_IMPORT | SFX_FILTER_EXPORT | 
SFX_FILTER_ALIEN | SFX_FILTER_USESOPTIONS)
 #define DIF_FORMAT_TYPE 195
 #define XLS_XML_FORMAT_TYPE (SFX_FILTER_IMPORT | SFX_FILTER_EXPORT | 
SFX_FILTER_ALIEN)
+#define XLSB_XML_FORMAT_TYPE 268959809
 
 #define ODS  0
 #define XLS  1
@@ -58,6 +59,7 @@
 #define LOTUS123 6
 #define DIF  7
 #define XLS_XML  8
+#define XLSB 9
 
 enum StringType { PureString, FormulaValue, StringValue };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


LibreOffice Gerrit News for core on 2014-12-22

2014-12-21 Thread gerrit
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ fdo#43368 Remove MapiLogon/Logoff calls so simplemail works with WLM
  in https://gerrit.libreoffice.org/13591 from Aron Budea
  about module shell
+ Resolves: fdo#87488 Wrong text rotation inside a preset shape from docx
  in https://gerrit.libreoffice.org/13561 from Gary Houston
  about module oox
+ fdo#46723 - enable configmgr unit tests
  in https://gerrit.libreoffice.org/13514 from Ioan Radu
  about module configmgr
+ fdo#75757: Remove inheritance from std::vector
  in https://gerrit.libreoffice.org/12136 from Matthew Pottage
  about module comphelper, configmgr, cui, editeng, extensions, filter, 
fpicker, framework, include, oox, package, sax, sfx2, svx, sw, unotools, 
unoxml, writerfilter, xmloff
+ fdo#87003 - Kill BOOST_FOREACH
  in https://gerrit.libreoffice.org/13575 from Pieter Adriaensen
  about module avmedia, basic, sd, svx, sw
+ fdo#84051 fix distribute on multiple sheets of paper
  in https://gerrit.libreoffice.org/13577 from Clément Lassieur
  about module sd, vcl
+ fdo#65505 fdo#57431 Autofilter checkbox for blank cells like in MS Excel
  in https://gerrit.libreoffice.org/13573 from Deena P. F.
  about module sc
+ fdo#85945 reorganize the file menu and set global shortcut for .uno:Close
  in https://gerrit.libreoffice.org/13571 from Yousuf Philips
  about module icon-themes, officecfg, sw
+ organize standard and formatting toolbars for writer web
  in https://gerrit.libreoffice.org/13572 from Yousuf Philips
  about module sw
+ fdo#87185 reorganize the image context menu
  in https://gerrit.libreoffice.org/13570 from Yousuf Philips
  about module sw
 End of freshness 

+ Improve HIG in OpenCL Add/Edit dialog
  in https://gerrit.libreoffice.org/13584 from Olivier Hallot
  about module cui
+ Fixup --without-x build
  in https://gerrit.libreoffice.org/13452 from Riccardo Magliocchetti
  about module build, desktop, include, postprocess, svx, sw, vcl


* Merged changes on master for project core changed in the last 25 hours:

+ fdo#39440 sd: reduce scope of local variables
  in https://gerrit.libreoffice.org/13569 from Michael Weghorn
+ fdo#39440 reduce scope of local variables
  in https://gerrit.libreoffice.org/13567 from Michael Weghorn
+ fdo#39440 sc: reduce scope of local variables
  in https://gerrit.libreoffice.org/13566 from Michael Weghorn
+ fdo#87555 ComboBox in table should use same formatting as floating ComboB
  in https://gerrit.libreoffice.org/13578 from Lionel Elie Mamane
+ Honor additional LDFLAGS when exporting them on the commandline.
  in https://gerrit.libreoffice.org/13568 from Maarten Hoes
+ fdo#39440 sc: reduce scope of local variables
  in https://gerrit.libreoffice.org/13564 from Michael Weghorn


* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ fdo#39625 Make existing CppUnittests work
  in https://gerrit.libreoffice.org/11605 from Tobias Madl
+ fdo#86606 removal of direct formatting options from the context menu
  in https://gerrit.libreoffice.org/13196 from Yousuf Philips
+ fdo#86784 make soffice commandline in juh Bootstrap.bootstrap() configura
  in https://gerrit.libreoffice.org/13290 from Christoph Lutz
+ l10ntools-transex3: core refactoring and improvements
  in https://gerrit.libreoffice.org/11317 from Douglas Mencken
+ Fix Python build in debug mode for x64 Windows
  in https://gerrit.libreoffice.org/13089 from David Ostrovsky
+ Replace image-sort.pl with image-sort.py
  in https://gerrit.libreoffice.org/13124 from Marcos Paulo de Souza
+ start detection of kf5 stuff in configure.ac
  in https://gerrit.libreoffice.org/13079 from Jonathan Riddell
+ fdo#65209 attempt to enable daylight saving time
  in https://gerrit.libreoffice.org/11441 from Lim Jing
+ Move more places to boost::signal2 in math
  in https://gerrit.libreoffice.org/13065 from Marcos Paulo de Souza
+ more breeze icons
  in https://gerrit.libreoffice.org/13058 from Jonathan Riddell
+ vcl: change Timer and Idle to use boost's Signal2
  in https://gerrit.libreoffice.org/12528 from Chris Sherlock
+ Removed useless includes in accessibility/ tree
  in https://gerrit.libreoffice.org/12948 from Andrea Gelmini
+ Perftest for loading autocorrect dictionaries, related fdo#79761
  in https://gerrit.libreoffice.org/11296 from Matúš Kukan
+ HIG-ification of GSoC Color Picker dialog
  in https://gerrit.libreoffice.org/11494 from Olivier Hallot
+ WIP: fdo#43090: Add an option to disable autoclose brackets
  in https://gerrit.libreoffice.org/12024 from Marcos Paulo de Souza


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice 

Re: [documentliberation-discuss] [ANN] libabw 0.1.1 has been released

2014-12-21 Thread Hanno Böck
On Sun, 21 Dec 2014 12:57:03 +1100
Chris Sherlock chris.sherloc...@gmail.com wrote:

 Do you have any instructions on how you went about doing that?

I've finished now the three-part tutorial for the fuzzing project, you
may find that helpful:
https://fuzzing-project.org/tutorial1.html

If you feel advanced you can directly skip to part 3 which is about
afl (which is kind of the gold standard of fuzzing right now).

-- 
Hanno Böck
http://hboeck.de/

mail/jabber: ha...@hboeck.de
GPG: BBB51E42


pgp94fVh1blRf.pgp
Description: OpenPGP digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


Re: [Libreoffice-qa] Freshly installed 4.4.0.0RC1 reports 4.3.5 as available update

2014-12-21 Thread Thomas Hackert
Good morning Robinson, *,
On Sat, 20. December 2014 20:15 Robinson Tryon wrote:
 On Sat, Dec 20, 2014 at 1:56 PM, Thomas Hackert
 thack...@nexgo.de wrote:
 for 4.4.0.0.beta2, so perhaps we just need to make a tweak to
 the updater: https://wiki.documentfoundation.org/Updater

 O.K. But where do I need to tweak it? On my system, or somewhere
 on the TDF server?
 
 As mentioned on that wiki page, the updater lives in git. Here's
 the commit that added the build hash for 4.4.0.1 that points to
 4.3.5:
 
http://cgit.freedesktop.org/libreoffice/website/commit/check.php?h=updateid=5249d17efb2d35de709ec5164e364b8bbde94913

ah, O.K. Thanks for the link :)

 It's possible that the change is intentional, but given than it's
 pointing at 4.3.5.1 (and not .2), I think it might be in error? We
 can ask cloph :-)

Maybe ... ;)

 I have found it on
 https://wiki.documentfoundation.org/BugHunting_Session_4.4.0_RC1
 below Quick Start. There it links to
 http://dev-builds.libreoffice.org/pre-releases/deb/x86_64/?C=S;O=D;P=*4.4.0.1*
 for some reason ... :(
 
 That's where the pre-releases such as 4.4.0.1 live. I just played
 around w/urls, and it looks like we can use this as well:
 https://www.libreoffice.org/download/libreoffice-fresh/?version=4.4.0

Thanks for your explanation :)
Have a nice day
Thomas.

-- 
When in doubt, tell the truth.
-- Mark Twain

___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 87548] Numbering in the first column of writer table

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87548

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #2 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.0.0.beta1 and 4.3.4.1 (Win 8.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87418] Bad ordered list ol after saving ODT document as HTML.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87418

Robinson Tryon (qubit) qu...@runcibility.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||qu...@runcibility.com
 Ever confirmed|0   |1

--- Comment #2 from Robinson Tryon (qubit) qu...@runcibility.com ---
(In reply to Piotr Orlewicz from comment #0)
 After you save the ODT document as HTML, lists are wrong numbered. 
 [...]
 See attached examples.

To focus on just one piece of the bug report, the attached images do appear to
show incorrect numbering of the lists after export.

Could you please attach an example file that shows this behavior?

Thanks!

Status - NEEDINFO

(Please change the status back to UNCONFIRMED after the test document is
uploaded)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87545] Window title retains '(read-only)' after exiting read-only mode

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87545

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.0.0.beta1 and 4.3.4.1 (Win 8.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87422] Buttons in 'Contour Editor' dialog dont function correctly

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87422

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #4 from Julien Nabet serval2...@yahoo.fr ---
Caolan: one for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87491] Track Changes: After opening a document with changes and click next change the comment Function is not enabled

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87491

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.0.0.beta1 (Win 8.1).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49048] : form wizard, applying style

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49048

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Julien Nabet serval2...@yahoo.fr ---
Fixed on master sources by Lionel.
There are several patch on gerrit for 4.4, you can check here:
https://gerrit.libreoffice.org/#/q/status:open,n,z

*** This bug has been marked as a duplicate of bug 87301 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 49048] form wizard, applying style

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=49048

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

Summary|: form wizard, applying |form wizard, applying style
   |style   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 52156] error ORA-00933 : Sql command not properly ended

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52156

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

Summary|I recevive the error|error ORA-00933 : Sql
   |ORA-00933 : Sql command not |command not properly ended
   |properly ended  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 47832] FILESAVE: Pictures on buttons, created in forms, gone after reopening form

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47832

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

 CC||zolnaitamas2...@gmail.com

--- Comment #33 from Julien Nabet serval2...@yahoo.fr ---
On pc Debian x86-64 with master sources updated yesterday, I still reproduce
this.
Same console log:
warn:legacy.osl:6972:1:svx/source/xml/xmlgrhlp.cxx:727: graphic object with ID
'1201001800189E41363E' has an unknown type
Zolnai: thought you might be interested in this one since you worked on image
management recently.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87545] Window title retains '(read-only)' after exiting read-only mode

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87545

Adolfo Jayme f...@libreoffice.org changed:

   What|Removed |Added

   Priority|medium  |low
 CC||s.mehrbr...@gmail.com
  Component|Libreoffice |UI

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 85875] [EDITING] properties of controls cannot be selected in the normal manner

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=85875

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 CC||caol...@redhat.com

--- Comment #3 from Cor Nouws c...@nouenoff.nl ---
@matthew: thanks for noticing this

@caolán: can we ask you advise here pls?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=39440

--- Comment #40 from Commit Notification 
libreoffice-comm...@lists.freedesktop.org ---
Michael Weghorn committed a patch related to this issue.
It has been pushed to master:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea5effc3df7b89a9332ea5b1b1e6cd40bf37f081

fdo#39440 sc: reduce scope of local variables

It will be available in 4.5.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds
Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87525] Wrong replace behaviour with Find Replace window open

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87525

--- Comment #2 from Michael Bauer f...@akerbeltz.org ---
Ah... thank you. I think I will keep this open as a bug though because this is
pretty idiotic I must say, as a 'feature'. If the user has (and that's the
behaviour most users will exhibit) selected a particular data range, than this
should automatically active the 'current selection only' feature.

In my case, this may have cost me 2 days work because I did NOT realise that
the adjacent column aside, this may have affected data across the large
spreadsheet I was working in. Now I have to backtrack to make sure LO did not
mess up my data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87524] FILEOPEN: Calc shows 0 when it should show nothing, i.e.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87524

--- Comment #6 from Markus Mohrhard markus.mohrh...@googlemail.com ---
The problem is in the file:

table:table-cell table:style-name=ce17
table:formula=of:=IF(ISNA(VLOOKUP([.B$1];[People.$A$2:.$H$65200];[People.$F$1];0));quot;quot;;VLOOKUP([.B$1];[People.$A$2:.$H$65200];[People.$F$1];0))
office:value-type=float office:value=0 calcext:value-type=float
  text:p/
/table:table-cell

Without checking our import code, reading the spec and some thinking I can
currently not decide if this is an import or an export bug. I think you can
workaround the problem by switching to Always recalculate for the ODF import.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 77354] Mail Merge E-mail test: No SSL support included in this Python

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77354

--- Comment #6 from engelbertsansvernet engelbert.sans.ver...@gmail.com ---
edited post
===
I noticed that the solucion was not in compatibility mode... see what I've
discovered now...

If I follow exactly this steeps... it worked (in openoffice, not i libreoffice)
1) open openoffice, make new writter document (or open swriter directly)
2) got to configuration options and do the mail test... (it work fine)
3) now, without close openoffice, open yout document, and it it's all right

Note that if I didn't do the steeps 1) + 2), it doesn't work... I known it's
very funny...

Bye...


edito respuesta
==
Hola de nuevo... terminando de hacer pruebas he visto que la solucion anterior
tiene otra explicacion... y parece que no tiene que ver con ejecutar con modo
compatibilidad -windows 8-...

Como solucion provisonal (de momento definitiva)... lo que he visto es que
unicamente funciona si siguo exactamente y en este orden los passos:
1) abro oppenoffice y creo un documento nuevo de writter (o bien directamente
abro swritter y ya se crea automaticamente un documento en blanco) 
2) realizo la prueba de correo (configuracion, opciones de swritter, probar
configuracion...) y sale todo correcto
3) entonces es cuando, sin cerrar el oppenoffice, abro el documento en question
que ha tengo creado (des de abrir o con doble click) y ahora funciona...

Si no realizo previamente 1) + 2), siempre sale error cosa realmente rara
rara rara y mas teniendo en cuenta que desde otro ordenador que tengo
funciona SIEMPRE...

Saludos...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 63905] FORMATTING: Page format in draw is not sent to the printer

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63905

Clément Lassieur clem...@lassieur.org changed:

   What|Removed |Added

 CC||clem...@lassieur.org
   Assignee|libreoffice-b...@lists.free |clem...@lassieur.org
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87410] RTL font fallback in rtl layout when using uniscribe backend results in a total mess

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87410

--- Comment #4 from a6487...@neto.net.il ---
(In reply to Urmas from comment #2)
 I don't see anything strange in your document. Please attach a (cropped)
 screenshot.

Do you have Arial Black installed on your system? Is it missing Hebrew
glyphs? If the answer is no to any of those questions, try forcing font
fallback by choosing another font that is missing Hebrew glyphs, e.g. DejaVu
Serif or one of the many others.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87525] Wrong replace behaviour with Find Replace window open

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87525

--- Comment #3 from Michael Bauer f...@akerbeltz.org ---
Ah and I discovered something else. When the FindReplace window is not open
and I select a data range, then I open it, then the Selected Range Only is
selected. So the problem is 'ticking that box' when the window is already open.
So I think it actually is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86984] UI:Line Numbering. Include header or footer not preserved and has no effect on counting.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86984

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||c...@nouenoff.nl
 Resolution|WORKSFORME  |---
Summary|UI:Line Numbering. Include  |UI:Line Numbering. Include
   |header or footer can't be   |header or footer not
   |checked and has no effect   |preserved and has no effect
   |on counting.|on counting.
 Ever confirmed|0   |1

--- Comment #2 from Cor Nouws c...@nouenoff.nl ---
I reopen this one.
Does not work in 4.0.0.rc1 and it's announced as new feature..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86984] UI:Line Numbering. Include header or footer not preserved and has no effect on counting.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86984

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

   Priority|medium  |highest
 Status|REOPENED|NEW
 OS|Windows (All)   |All
   Severity|minor   |critical

--- Comment #3 from Cor Nouws c...@nouenoff.nl ---
will mark as MAB

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 79641] LibreOffice 4.4 most annoying bugs

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79641

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Depends on||86984

--- Comment #24 from Cor Nouws c...@nouenoff.nl ---
adding Bug 86984 - UI:Line Numbering. Include header or footer not preserved
and has no effect on counting

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86984] UI:Line Numbering. Include header or footer not preserved and has no effect on counting.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86984

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Blocks||79641

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87549] New: UI: activating Line numbering for Header and Footer with dialogs Tools Line Numbering and Styles Header/Footer not synchronised

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87549

Bug ID: 87549
   Summary: UI: activating Line numbering for Header and Footer
with dialogs Tools  Line Numbering and Styles
Header/Footer not synchronised
   Product: LibreOffice
   Version: 4.4.0.0.alpha1
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: c...@nouenoff.nl

Talking about the new function from bug 84504
 
https://wiki.documentfoundation.org/ReleaseNotes/4.4#Line_numbering_easier_to_apply_for_headers_and_footers

- activating Line numbering for Header and Footer with dialog Tools  Line
Numbering
- add Header with some lines..
  works OK in ENG_US version

- look at dialog paragraph style Header, tab Outline and Numbering
  Line numbering is not activated there
   this is not OK

- disable line numbering in dialog dialog paragraph style Header, click OK
  Line numbering is not shown
   is OK

- look at dialog Tools  Line Numbering
  include Header and Footer still activated there
   this is not OK

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86984] UI:Line Numbering. Include header or footer not preserved and has no effect on counting.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86984

--- Comment #4 from Cor Nouws c...@nouenoff.nl ---
hmm. seems to work with ENG_US but not with Dutch_NL locale?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87525] Wrong replace behaviour with Find Replace window open

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87525

--- Comment #4 from raal r...@post.cz ---
(In reply to Michael Bauer from comment #3)
 Ah and I discovered something else. When the FindReplace window is not open
 and I select a data range, then I open it, then the Selected Range Only is
 selected. So the problem is 'ticking that box' when the window is already
 open. So I think it actually is a bug.

Yes, looks like dialog check selected cells during starting. How LO should
solve this situation?

 - user select more cells
 - open FindReplace window
 - untick Current selection for some reason
 - run FindReplace  -- (more cells are selected)

You propose findreplace If the user has (and that's the behaviour most users
will exhibit) selected a particular data range, than this should automatically
active the 'current selection only' feature., but user untick Current
selection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87551] New: UI VIEWING: The left field in the Options window is show not correct

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87551

Bug ID: 87551
   Summary: UI VIEWING: The left field in the Options window is
show not correct
   Product: LibreOffice
   Version: 4.4.0.1 rc
  Hardware: x86 (IA32)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lera.goncha...@gmail.com

Created attachment 07
  -- https://bugs.freedesktop.org/attachment.cgi?id=07action=edit
the screenshot of the Options window

OS:
Kubuntu 14.04.1 x86

Problem description: If you look at the screenshot, you can see that words do
not fit into the left field of Options window (Tools - Options...) in Russian
localisation. Also it is in EN localisation.
It is not in 4.3.5 version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87551] UI VIEWING: The left field in the Options window is show not correct

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87551

--- Comment #1 from Lera lera.goncha...@gmail.com ---
the screenshot of the Options window:
http://storage6.static.itmages.ru/i/14/1221/h_1419166826_7494645_336e9e83bb.png
http://storage6.static.itmages.ru/i/14/1221/h_1419166826_8835779_a01babdee7.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87548] Numbering in the first column of writer table

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87548

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

   Keywords||regression
 CC||c...@nouenoff.nl
Version|4.3.5.2 release |4.3.0.0.alpha1

--- Comment #3 from Cor Nouws c...@nouenoff.nl ---
first version with problem that I have is 430alpha1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87542] Closing a component should not revert to start center

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87542

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 CC||c...@nouenoff.nl,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
  Component|UI  |ux-advise
   Hardware|x86-64 (AMD64)  |All
Version|4.4.0.0.beta2   |4.4.0.0.alpha0+ Master
Summary|Closing a component should  |Closing a component should
   |not revert to LO general|not revert to start center
   |starting point  |
 OS|Windows (All)   |All

--- Comment #1 from Cor Nouws c...@nouenoff.nl ---
hi @pb
Thanks for the idea - looks a bit tangential to the wishes heard to get more
easy access to the start center, I think...

assign to UX-advise

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87551] UI VIEWING: The left field in the Options window is show not correct

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87551

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

 Attachment #07|text/plain  |image/png
  mime type||
 CC||c...@nouenoff.nl

--- Comment #2 from Cor Nouws c...@nouenoff.nl ---
Comment on attachment 07
  -- https://bugs.freedesktop.org/attachment.cgi?id=07
the screenshot of the Options window

set proper mime type

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87551] UI VIEWING: The left field in the Options window is show not correct: text does not fit

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87551

Cor Nouws c...@nouenoff.nl changed:

   What|Removed |Added

Summary|UI VIEWING: The left field  |UI VIEWING: The left field
   |in the Options window is|in the Options window is
   |show not correct|show not correct: text does
   ||not fit

--- Comment #3 from Cor Nouws c...@nouenoff.nl ---
I see the same for Dutch in 4.2.x when there is a long text in left pane.
(I have that when I adapt the product name from LibreOffice to LibreOffice
version bla bla in the share/registry/main.xcd node ooname - not for dummies
;) )
So I'm not sure if I can confirm the problem..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54933] EDITING Report builder: mouse-move control: gap between mouse position

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54933

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

   Keywords|regression  |
 CC||fdb...@neosheffield.co.uk
Version|3.5.7.1 rc  |Inherited From OOo
 Whiteboard|bibisectRequest |

--- Comment #32 from Matthew Francis fdb...@neosheffield.co.uk ---
I can reproduce this in LO 3.3.0, so it doesn't appear to be a regression but
an inherited bug.

- Removing Whiteboard: bibisectRequest and Keywords: regression
- Setting Version to Inherited from OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 80715] Search and replace with over 16k+ replacements halts LibO

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80715

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||fdb...@neosheffield.co.uk
 Whiteboard|perf bibisectRequest|perf bibisected

--- Comment #14 from Matthew Francis fdb...@neosheffield.co.uk ---
Bibisect results from 43all:

commit 2a9ff869c5638dc5c3aa387d0fe55c3291c86288
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Wed Nov 27 05:01:37 2013 +

source-hash-01b7e04172889cbc9e4ac404b105e18ddc062d6f

commit 01b7e04172889cbc9e4ac404b105e18ddc062d6f
Author: Tor Lillqvist t...@collabora.com
AuthorDate: Sun Oct 13 14:04:29 2013 +0300
Commit: Tor Lillqvist t...@collabora.com
CommitDate: Sun Oct 13 14:04:29 2013 +0300

Bin unnecessary #include

Change-Id: I9ea868ed5bf6e2e2defbd51d5a0a1e6362c3be8d

# bad: [423a84c4f7068853974887d98442bc2a2d0cc91b]
source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e
# good: [c2069a369d738078124812312d51f21ea1ce2421]
source-hash-f160e4935c474a5293b3d3c11b3d538efb4767a0
git bisect start 'latest' 'last41onmaster'
# bad: [33ac6698e6d90d84f99d784b9553ee87eec27d6a]
source-hash-732c0f929fc0229b6da37d4ec4b6de8994fcea46
git bisect bad 33ac6698e6d90d84f99d784b9553ee87eec27d6a
# good: [e3a648fdaa2bb87293750400b70ba590733a804a]
source-hash-33526481788137d959f27ae32910127d1436c1a8
git bisect good e3a648fdaa2bb87293750400b70ba590733a804a
# good: [e3a648fdaa2bb87293750400b70ba590733a804a]
source-hash-33526481788137d959f27ae32910127d1436c1a8
git bisect good e3a648fdaa2bb87293750400b70ba590733a804a
# bad: [a1bd890a0802bd142798b7b601f370ca9c21426b]
source-hash-04532617c7d264411563db24dc359326cc18eda7
git bisect bad a1bd890a0802bd142798b7b601f370ca9c21426b
# bad: [a1bd890a0802bd142798b7b601f370ca9c21426b]
source-hash-04532617c7d264411563db24dc359326cc18eda7
git bisect bad a1bd890a0802bd142798b7b601f370ca9c21426b
# good: [560f398ecbc305b65a32a4ba0b9e761db889]
source-hash-dace560b350346b9f9a102ee602bb129a008bcfe
git bisect good 560f398ecbc305b65a32a4ba0b9e761db889
# bad: [e371c174576801a7865420008f494c0d3f153f1b]
source-hash-01a13519e2a12e1e9b61bab1437d340e389e44bf
git bisect bad e371c174576801a7865420008f494c0d3f153f1b
# bad: [047d10291c5cd0615c992821829c9153e2f06b13]
source-hash-43ccd83d2598256de2193348c0b3c7f85fb4870e
git bisect bad 047d10291c5cd0615c992821829c9153e2f06b13
# skip: [a235cee7729b6eda7f2f6b1cf3347d8eb2a1a49c]
source-hash-fa469b2e00d83459faebe4c1fcb3ea1aac5fb20d
git bisect skip a235cee7729b6eda7f2f6b1cf3347d8eb2a1a49c
# bad: [f0f03d19b3f0418cef7eb8c5b3f060266781016f]
source-hash-3ad12d1a540eeb54fbb34afc3b7a76bf9e3207c3
git bisect bad f0f03d19b3f0418cef7eb8c5b3f060266781016f
# bad: [2a9ff869c5638dc5c3aa387d0fe55c3291c86288]
source-hash-01b7e04172889cbc9e4ac404b105e18ddc062d6f
git bisect bad 2a9ff869c5638dc5c3aa387d0fe55c3291c86288
# first bad commit: [2a9ff869c5638dc5c3aa387d0fe55c3291c86288]
source-hash-01b7e04172889cbc9e4ac404b105e18ddc062d6f

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 80715] Search and replace with over 16k+ replacements halts LibO

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80715

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||mst...@redhat.com

--- Comment #15 from Matthew Francis fdb...@neosheffield.co.uk ---
Within the above bibisect range, possibly this commit.

Adding Cc: to mst...@redhat.com. Could you possibly take a look at this? Thanks
(To recap, before the perf regression of this bug, replacing the 16,000 $ in
the attached file with   takes a few seconds. After, it takes ~forever)


commit b60ce8465c8f01242354abccebe00742d164af60
Author: Michael Stahl mst...@redhat.com
Date:   Sat Oct 12 01:54:37 2013 +0200

sw: fix regex search/replace of $ in selection

SwView::Replace() nowadays first searches for the to-be-replaced text in
the current selection, which does not work in the corner case of $
when the selection starts at end of a paragraph, as it will when
clicking Find to look for $ and then clicking Replace.

The problem is that there is some antique code in SwPaM::Find() to
move the cursor forward if it's at the end of a paragraph, which is
presumably some pointless micro-optimization; the result is that
Replace does not replace the selected paragraph break but the
one in the following paragraph.

(regression from 68a014dbca8bbd25056f75ef551fb81a0dbfb1b7)

Change-Id: I5aae9c272d102a48166c63e01775dc6322f9f02d

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87542] Closing a component should not revert to start center

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87542

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||vstuart.fo...@utsa.edu
 Blocks||61914
 Ever confirmed|0   |1

--- Comment #2 from V Stuart Foote vstuart.fo...@utsa.edu ---
Not invalid, but requested function would have to be wrapped up with work bug
77590 and bug 75644, needs UI/UX consideration.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61914] [META] Start Center -- implementation UI and UX

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61914

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 Depends on||87542

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87551] UI VIEWING: The left field in the Options window is show not correct: text does not fit

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87551

--- Comment #4 from Lera lera.goncha...@gmail.com ---
There was no such problem until the version 4.4.0. I know that forms have been
translated into GTK+, and this is evident from the behavior. But in version
4.3.5 the window is comfortable.
http://storage8.static.itmages.ru/i/14/1221/h_1419169168_6264975_eb1624e685.png

And I see no reason to make it uncomfortable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87534] HYPERLINK call in a name does not work

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87534

m.a.riosv mari...@miguelangel.mobi changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||mari...@miguelangel.mobi
 Ever confirmed|0   |1
 OS|Linux (All) |All
   Severity|normal  |enhancement

--- Comment #2 from m.a.riosv mari...@miguelangel.mobi ---
Hi @rlk, thanks for reporting.

It doesn't work in any version, neither OpenOffice.

I think it wasn't implemented to work in this way.

Please take a look: https://issues.oasis-open.org/browse/OFFICE-3435

May be better as request for enhancement, please if you are not agree reopen
it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87529] FORMATTING, EDITING combined cells, filling splits combined cells

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87529

m.a.riosv mari...@miguelangel.mobi changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mari...@miguelangel.mobi
 Resolution|--- |DUPLICATE

--- Comment #2 from m.a.riosv mari...@miguelangel.mobi ---


*** This bug has been marked as a duplicate of bug 86143 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86143] Dragging merged from the corner puts it in a single cell

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86143

m.a.riosv mari...@miguelangel.mobi changed:

   What|Removed |Added

 CC||karsten.henn...@gmx.de

--- Comment #4 from m.a.riosv mari...@miguelangel.mobi ---
*** Bug 87529 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87538] COLOR PICKER: New default color palette

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87538

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 CC||maz...@gmail.com,
   ||owen.ge...@gmail.com,
   ||vstuart.fo...@utsa.edu,
   ||wadep_silic...@yahoo.com

--- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu ---
@Jay, *,

I'm not opposed to this. But if the color picker at 12 columns but showing just
10 rows is a problem, it might be a better option to expand number or rows, or
even columns shown.

Q: what would be the best layout of the color picker to accommodate a new
standard.soc pallet? 

And, regards the standard.soc pallet, two issues with that:

1.) kind of feel like we are obliged to support our LibreOffice branding,
https://wiki.documentfoundation.org/Marketing/Branding#Color_Table most of
which are in our standard.soc table now.  Reworking as you suggest probably
would require that we move this entire branding color chart into its own
pallet--an addition to your bug 87541 suggestion. Leaving us free to reduce and
adjust the standard.soc;

2.)  Wade Peterson's did some very compelling work for a device neutral color
pallet, in bug 80196 -- it could/should occupy the lower rows of the standard
pallet.

@Wade, @Owen opinions please...

Stuart

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84929] EDITING: Clicking in the footer area brings focus/view to last cursor position on page

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84929

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||fdb...@neosheffield.co.uk
 Whiteboard|bibisectRequest |notBibisectable

--- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk ---
I also can't find any version in the bibisect repos that behaves as described.
Assuming for the sake of argument that this is a regression, it doesn't appear
to be readily bibisectable, but I suspect that this is more properly an
enhancement request

Setting Whiteboard:notBibisectable

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87541] COLOR PICKER: New color palettes

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87541

V Stuart Foote vstuart.fo...@utsa.edu changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #1 from V Stuart Foote vstuart.fo...@utsa.edu ---
For sure, Wade P.'s device neutral technical pallet of bug 80196. and if the
standard.soc is adjusted we will need to accommodate the project branding color
table -- https://wiki.documentfoundation.org/Marketing/Branding#Color_Table

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83818] Text selection highlight is incompletely rendered when using the HFW Cursive font

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83818

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||fdb...@neosheffield.co.uk
 Whiteboard|bibisectRequest |bibisected

--- Comment #9 from Matthew Francis fdb...@neosheffield.co.uk ---
Bibisect results from 43all:

e2a9149a7723f4e00eb3cafe466e204e5da19e9c is the first bad commit
commit e2a9149a7723f4e00eb3cafe466e204e5da19e9c
Author: Bjoern Michaelsen bjoern.michael...@canonical.com
Date:   Thu Oct 17 05:01:44 2013 +

source-hash-2ede6c95e6481c92cc199e7d74fd36c841636304

commit 2ede6c95e6481c92cc199e7d74fd36c841636304
Author: Khaled Hosny khaledho...@eglug.org
AuthorDate: Sun May 12 17:59:50 2013 +0200
Commit: Khaled Hosny khaledho...@eglug.org
CommitDate: Sun May 12 18:47:36 2013 +0200

Some logging

Change-Id: I4515d4d6760e22ce4d77fbb3cbce93e3ce097b98

# bad: [c2069a369d738078124812312d51f21ea1ce2421]
source-hash-f160e4935c474a5293b3d3c11b3d538efb4767a0
# good: [a71a4447320f177181c9cff9f7c6fd93802cbd8e]
source-hash-9afb6e1e38c362a768e8e981f7b03cf8bcaf22cf
git bisect start 'last41onmaster' 'last36onmaster'
# good: [7fa43e1a1b181ccdcb395c16788a66c591b63045]
source-hash-41c2b0375773b2d2945d75e255ea6bb6c7fd378d
git bisect good 7fa43e1a1b181ccdcb395c16788a66c591b63045
# good: [beaf8d511be9863b1369a1889151302498fb63c9]
source-hash-1890f4ba4c0b345a73185adf320d06d0974f644b
git bisect good beaf8d511be9863b1369a1889151302498fb63c9
# good: [fa884dc86639e1925692df2117e53599726e366d]
source-hash-86fd12408ee72899abc24daf5e4402a61add
git bisect good fa884dc86639e1925692df2117e53599726e366d
# good: [ba45b2fb759b79ac39d73851bacc5ce216531318]
source-hash-2b449f5f9ad126618ec85d442ec149c5864853de
git bisect good ba45b2fb759b79ac39d73851bacc5ce216531318
# good: [3894c5d4955cdef8187b35e8d3eeb37ecdf8d7b7]
source-hash-a2c34b3d9ac2d7e43e52846308cc63447fd51f23
git bisect good 3894c5d4955cdef8187b35e8d3eeb37ecdf8d7b7
# bad: [38e06ae137e1dcaaaf82127b977869499742bd94]
source-hash-3fb33e3e04c7f339e1e15d24529e8ea1d4dbe321
git bisect bad 38e06ae137e1dcaaaf82127b977869499742bd94
# bad: [e2a9149a7723f4e00eb3cafe466e204e5da19e9c]
source-hash-2ede6c95e6481c92cc199e7d74fd36c841636304
git bisect bad e2a9149a7723f4e00eb3cafe466e204e5da19e9c
# good: [7735ac016add3b7e4b96d6017919a828e3271a0a]
source-hash-923312f67fbf120158f01c2c0e588af38fc22364
git bisect good 7735ac016add3b7e4b96d6017919a828e3271a0a
# first bad commit: [e2a9149a7723f4e00eb3cafe466e204e5da19e9c]
source-hash-2ede6c95e6481c92cc199e7d74fd36c841636304

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 84929] EDITING: Clicking in the footer area brings focus/view to last cursor position on page

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84929

--- Comment #4 from Jay Philips philip...@hotmail.com ---
Created attachment 09
  -- https://bugs.freedesktop.org/attachment.cgi?id=09action=edit
screencast

Here is a screencast of 3.6.7 showing it works and 4.0.6 showing it doesnt
work. Tested it also on windows 7 and its the same thing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86984] UI:Line Numbering. Include header or footer not preserved and has no effect on counting.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86984

--- Comment #5 from riesslibo lothar.bec...@riess-app.de ---
Can confirm described behaviour even for German de_de UI in Win7/64 LibO
4.4.0.0.beta2 .

No recounting is startet and displaxed and looking in the numbering properties
shows, that the check of the include head and footer disapear.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87239] Inconsistent look and operation of drop-down buttons

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87239

Jean Spiteri beimaginativeegr...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||beimaginativeegroup@gmail.c
   ||om
Version|3.3.0 release   |4.4.0.1 rc
 Ever confirmed|0   |1

--- Comment #1 from Jean Spiteri beimaginativeegr...@gmail.com ---
This is definitely valid. Setting as NEW and enhancement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 86545] CALC: Sheet tabs and buttons should maybe be a little bit larger

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86545

Jean Spiteri beimaginativeegr...@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||beimaginativeegroup@gmail.c
   ||om
 Ever confirmed|0   |1

--- Comment #3 from Jean Spiteri beimaginativeegr...@gmail.com ---
I've tested it on RC1 (4.4) and the size of the buttons did change. Can you
check?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83818] Text selection highlight is incompletely rendered when using the HFW Cursive font

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83818

Matthew Francis fdb...@neosheffield.co.uk changed:

   What|Removed |Added

 CC||khaledho...@eglug.org

--- Comment #10 from Matthew Francis fdb...@neosheffield.co.uk ---
Within the above bibisect range, I would say that the following two commits are
strong candidates

Adding Cc: to khaledho...@eglug.org. Could you possibly shed any light on this
one? Thanks


commit f9560c8f9982eaef09b74baa479c187f049c4f9e
Author: Khaled Hosny khaledho...@eglug.org
Date:   Sat May 11 07:07:29 2013 +0200

Cleanup FreeType ascender/descender handling a bit

Change-Id: I9734f15811020ce1a7b761688d602c7e244167c7

commit 5e77c9e17ba7dd9d296c9b755093f01e7eb4f514
Author: Khaled Hosny khaledho...@eglug.org
Date:   Sat May 11 00:50:59 2013 +0200

Revert 052f181dad89ad34d90513bc9dcd3e3239727933

Which in itself was effectively a revert of
3364fefe1e2dec522211040f2f9ea37bf5cd7466

Keeping the old broken line height calculation code is just masking of
the real problem; there are some code elsewhere that have fragile
workarounds to the real bug here (the removed code here shows a good
example of such workarounds). On Mac we use the correct metrics as well,
so we need to find the quirks and fix them, instead of pretending they
do not exist.

This fixes fdo#55469, among others.

Change-Id: I36f13b28eaba022b7c388feae7e0bfd0ed1c3e89

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87534] HYPERLINK call in a name does not work

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87534

r...@alum.mit.edu changed:

   What|Removed |Added

   Severity|enhancement |minor

--- Comment #3 from r...@alum.mit.edu ---
I'd prefer to call it a defect (from the user perspective).

I'm willing to call it minor severity, since there's a workaround always
available (at least in this situation).  But from my perspective, it's a defect
-- I can put anything else in a name and it works the same as it does in the
actual formula.

While I'm not familiar with the innards of LibreOffice, the issue you refer to
doesn't sound like it covers this situation one way or the other, and there's
nothing in the documentation to indicate any limitation of this nature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 72944] FORMATTING: LibreOffice Writer's font handling fails to recognize font family and parameters.

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72944

Jean Spiteri beimaginativeegr...@gmail.com changed:

   What|Removed |Added

 CC||beimaginativeegroup@gmail.c
   ||om

--- Comment #7 from Jean Spiteri beimaginativeegr...@gmail.com ---
Should it be set as NEW?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87555] New: Fields in table-control of a form show '0' in a combobox, when GUI-language isn't English

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87555

Bug ID: 87555
   Summary: Fields in table-control of a form show '0' in a
combobox, when GUI-language isn't English
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Database
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rob...@familiegrosskopf.de

Created attachment 12
  -- https://bugs.freedesktop.org/attachment.cgi?id=12action=edit
Open the form and have a look - '0' for all fields in PRODUZECE

We have had the same bug with table-control and textfields:
https://bugs.freedesktop.org/show_bug.cgi?id=67615

In a tablecontrol will appear '0' instead of text, if you use a combobox
together with a wrong-formatted field of the table.

Open the form fpartnerij of the attached database and have a look at the
second field PRODUZECE. It's shown as '0' in all versions - also the versions
where Bug67615 has been fixed (since LO 4.3.2)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 67615] Fields in table-control of a form show '0' instead of text, when GUI-language isn't English

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=67615

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=87555

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87555] Fields in table-control of a form show '0' in a combobox, when GUI-language isn't English

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87555

rob...@familiegrosskopf.de changed:

   What|Removed |Added

   See Also||https://bugs.freedesktop.or
   ||g/show_bug.cgi?id=67615

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87555] Fields in table-control of a form show '0' in a combobox, when GUI-language isn't English

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87555

rob...@familiegrosskopf.de changed:

   What|Removed |Added

 Attachment #12|text/plain  |application/vnd.oasis.opend
  mime type||ocument.base

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87556] New: Fatal error with use Fontwork

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87556

Bug ID: 87556
   Summary: Fatal error with use Fontwork
   Product: LibreOffice
   Version: 4.5.0.0.alpha0+ Master
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: 79045_79...@mail.ru

LO 4.5 alpha0+, Writer
id build: ea5effc3df7b89a9332ea5b1b1e6cd40bf37f081,
OS: Windows 7 x86-64

Fatal error with use Fontwork.

1. Open new writer document
2. create object Fontwork
3. right-click on object
4. select add text box (bottom context menu)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87557] New: LibreOffice does not support ae_AlMohanad Arabic font

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87557

Bug ID: 87557
   Summary: LibreOffice does not support ae_AlMohanad Arabic font
   Product: LibreOffice
   Version: unspecified
  Hardware: Other
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: yousifjka...@yahoo.com

Created attachment 13
  -- https://bugs.freedesktop.org/attachment.cgi?id=13action=edit
ae_AlMohanad Arabic Font

Hi. Please look for attached file. It is ae_AlMohanad Arabic font. It is not
supported by LibreOffice. Please fix it's problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 87557] LibreOffice does not support ae_AlMohanad Arabic font

2014-12-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87557

--- Comment #1 from yousifjka...@yahoo.com ---
Not only in writer. But in all program elements.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


  1   2   3   4   >