[Libreoffice-commits] core.git: vcl/inc
vcl/inc/unx/saldisp.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit df2c08855e2e5435004d291a1a5cdee52d0b52eb Author: Stephan Bergmann Date: Mon Jan 26 08:55:14 2015 +0100 Fix --enable-kde4 Change-Id: Ia4211a3f3a2e8e84051388a3b48725a6f722f0d5 diff --git a/vcl/inc/unx/saldisp.hxx b/vcl/inc/unx/saldisp.hxx index 4eac942..63b8bae 100644 --- a/vcl/inc/unx/saldisp.hxx +++ b/vcl/inc/unx/saldisp.hxx @@ -395,7 +395,7 @@ public: virtual ~SalX11Display(); virtual boolDispatch( XEvent *pEvent ) SAL_OVERRIDE; -voidYield(); +virtual voidYield(); virtual voidPostUserEvent() SAL_OVERRIDE; boolIsEvent(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/removevirtuals.cxx | 141 - compilerplugins/clang/store/removevirtuals.cxx | 141 + compilerplugins/clang/store/unnecessaryvirtual.cxx | 119 + compilerplugins/clang/unnecessaryvirtual.cxx | 119 - 4 files changed, 260 insertions(+), 260 deletions(-) New commits: commit 414d84232de858c464c43995a7a559f96cfdd7be Author: Noel Grandin Date: Mon Jan 26 09:39:18 2015 +0200 move these plugins into /store we don't need to run them on an ongoing basis, and the current code does not compile with older versions of clang. Change-Id: I07ccacf7ff7b00e8e2453fff91a3f487dd5abed9 diff --git a/compilerplugins/clang/removevirtuals.cxx b/compilerplugins/clang/store/removevirtuals.cxx similarity index 100% rename from compilerplugins/clang/removevirtuals.cxx rename to compilerplugins/clang/store/removevirtuals.cxx diff --git a/compilerplugins/clang/unnecessaryvirtual.cxx b/compilerplugins/clang/store/unnecessaryvirtual.cxx similarity index 100% rename from compilerplugins/clang/unnecessaryvirtual.cxx rename to compilerplugins/clang/store/unnecessaryvirtual.cxx ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx | 49
--
1 file changed, 20 insertions(+), 29 deletions(-)
New commits:
commit 26ad60aec69310fecd918f1c2e09056aa4782320
Author: Tomaž Vajngerl
Date: Mon Jan 26 15:29:38 2015 +0900
convert to use std random instead of boost
Change-Id: I7746b17a41a6f8807d8ef441ad44a005d04775af
diff --git a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
index 9e9b5c5..954cadd 100644
--- a/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RandomNumberGeneratorDialog.cxx
@@ -23,16 +23,7 @@
#include "docfunc.hxx"
#include "StatisticsDialogs.hrc"
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
+#include
#include "RandomNumberGeneratorDialog.hxx"
@@ -178,7 +169,7 @@ void
ScRandomNumberGeneratorDialog::SelectGeneratorAndGenerateNumbers()
seedValue = now.Nanosec;
}
-boost::mt19937 seed(seedValue);
+std::mt19937 seed(seedValue);
sal_Int64 parameterInteger1 = mpParameter1Value->GetValue();
sal_Int64 parameterInteger2 = mpParameter2Value->GetValue();
@@ -196,64 +187,64 @@ void
ScRandomNumberGeneratorDialog::SelectGeneratorAndGenerateNumbers()
{
case DIST_UNIFORM:
{
-boost::random::uniform_real_distribution<>
distribution(parameter1, parameter2);
-boost::variate_generator > rng(seed, distribution);
+std::uniform_real_distribution<> distribution(parameter1,
parameter2);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_UNIFORM_REAL,
aDecimalPlaces);
break;
}
case DIST_UNIFORM_INTEGER:
{
-boost::random::uniform_int_distribution<>
distribution(parameterInteger1, parameterInteger2);
-boost::variate_generator > rng(seed, distribution);
+std::uniform_int_distribution<> distribution(parameterInteger1,
parameterInteger2);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_UNIFORM_INTEGER,
aDecimalPlaces);
break;
}
case DIST_NORMAL:
{
-boost::random::normal_distribution<> distribution(parameter1,
parameter2);
-boost::variate_generator > rng(seed, distribution);
+std::normal_distribution<> distribution(parameter1, parameter2);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_NORMAL, aDecimalPlaces);
break;
}
case DIST_CAUCHY:
{
-boost::random::cauchy_distribution<> distribution(parameter1);
-boost::variate_generator > rng(seed, distribution);
+std::cauchy_distribution<> distribution(parameter1);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_CAUCHY, aDecimalPlaces);
break;
}
case DIST_BERNOULLI:
{
-boost::random::bernoulli_distribution<> distribution(parameter1);
-boost::variate_generator > rng(seed, distribution);
+std::bernoulli_distribution distribution(parameter1);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_BERNOULLI, aDecimalPlaces);
break;
}
case DIST_BINOMIAL:
{
-boost::random::binomial_distribution<>
distribution(parameterInteger2, parameter1);
-boost::variate_generator > rng(seed, distribution);
+std::binomial_distribution<> distribution(parameterInteger2,
parameter1);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_BINOMIAL, aDecimalPlaces);
break;
}
case DIST_NEGATIVE_BINOMIAL:
{
-boost::random::negative_binomial_distribution<>
distribution(parameterInteger2, parameter1);
-boost::variate_generator > rng(seed, distribution);
+std::negative_binomial_distribution<>
distribution(parameterInteger2, parameter1);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_NEGATIVE_BINOMIAL,
aDecimalPlaces);
break;
}
case DIST_CHI_SQUARED:
{
-boost::random::chi_squared_distribution<> distribution(parameter1);
-boost::variate_generator > rng(seed, distribution);
+std::chi_squared_distribution<> distribution(parameter1);
+auto rng = std::bind(distribution, seed);
GenerateNumbers(rng, STR_DISTRIBUTION_CHI_SQUARED, aDecimalPlaces);
break;
}
case DIST_GEOMETRIC:
{
-
Re: buildbot/bin/sendEmail issue
Hi Maarten,
Did you manage to get it working? as I had setup something at work to use
gmail to relay. Not sure if this will be of any use to you
https://rtcamp.com/tutorials/linux/ubuntu-postfix-gmail-smtp/
On Sat, Jan 24, 2015 at 11:00 AM, Maarten Hoes
wrote:
> Hi,
>
> On Sat, Jan 24, 2015 at 10:52 AM, Matúš Kukan
> wrote:
> >
> > On 24 January 2015 at 10:38, Maarten Hoes
> wrote:
> > > if ($conf{'tls_server'} == 1 and $conf{'tls_client'} == 1 and
> > > $opt{'tls'} =~ /^(yes|auto)$/) {
> > > printmsg("DEBUG => Starting TLS", 2);
> > > if (SMTPchat('STARTTLS')) { quit($conf{'error'}, 1); }
> > > -my $ssl_ver = 'SSLv3 TLSv1';
> > > +my $ssl_ver = 'SSLv3';
> >
> > That's exactly what I did after spent some time.
> > And I was told it's a known issue.
> > I am for pushing this or at least put some comment into the script.
> > I am sorry, I forgot to do the latter.
> >
> > Thanks,
> > Matus
>
>
> Done.
>
> https://gerrit.libreoffice.org/14151
>
>
>
> - Maarten
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
--
Jonathan Aquilina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sw/source
sw/source/filter/html/wrthtml.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit bb6d767bd328debd5f800aa7bb03573111b01313
Author: Caolán McNamara
Date: Sun Jan 25 14:12:22 2015 +
coverity#1266508 Useless call (gold)
regression from
commit 832e5aadbff006ec24959162c29756fe2b1982be
Author: Caolán McNamara
Date: Tue Oct 8 10:06:59 2013 +0100
Related: fdo#38838 remove UniString::SearchAndReplaceAll
(cherry picked from commit 6cde3ff3dd646f51f37f2342863371db8de9087a)
Conflicts:
sw/source/filter/html/wrthtml.cxx
Change-Id: If792925eddc9c640584a2e8fa313a4297a32c74c
Reviewed-on: https://gerrit.libreoffice.org/14172
Tested-by: Markus Mohrhard
Reviewed-by: Markus Mohrhard
diff --git a/sw/source/filter/html/wrthtml.cxx
b/sw/source/filter/html/wrthtml.cxx
index b9464f6..b5f7848 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1134,8 +1134,7 @@ void SwHTMLWriter::OutImplicitMark( const OUString& rMark,
{
if( !rMark.isEmpty() && !aImplicitMarks.empty() )
{
-OUString sMark( rMark );
-sMark + OUString(cMarkSeparator) +
OUString::createFromAscii(pMarkType);
+OUString sMark(rMark + OUString(cMarkSeparator) +
OUString::createFromAscii(pMarkType));
if( 0 != aImplicitMarks.erase( sMark ) )
{
OutAnchor(sMark.replace('?', '_')); // '?' causes problems in
IE/Netscape 5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/filter/html/wrthtml.cxx |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
New commits:
commit c221a1b93dd70a14b897c3a96b8e032cd97b9593
Author: Caolán McNamara
Date: Sun Jan 25 14:12:22 2015 +
coverity#1266508 Useless call (gold)
regression from
commit 832e5aadbff006ec24959162c29756fe2b1982be
Author: Caolán McNamara
Date: Tue Oct 8 10:06:59 2013 +0100
Related: fdo#38838 remove UniString::SearchAndReplaceAll
(cherry picked from commit 6cde3ff3dd646f51f37f2342863371db8de9087a)
Conflicts:
sw/source/filter/html/wrthtml.cxx
Change-Id: If792925eddc9c640584a2e8fa313a4297a32c74c
Reviewed-on: https://gerrit.libreoffice.org/14171
Tested-by: Markus Mohrhard
Reviewed-by: Markus Mohrhard
diff --git a/sw/source/filter/html/wrthtml.cxx
b/sw/source/filter/html/wrthtml.cxx
index 13add63..f9d60e5 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -1170,8 +1170,7 @@ void SwHTMLWriter::OutImplicitMark( const OUString& rMark,
{
if( !rMark.isEmpty() && !aImplicitMarks.empty() )
{
-OUString sMark( rMark );
-sMark + OUString(cMarkSeparator) +
OUString::createFromAscii(pMarkType);
+OUString sMark(rMark + OUString(cMarkSeparator) +
OUString::createFromAscii(pMarkType));
if( 0 != aImplicitMarks.erase( sMark ) )
{
OutAnchor(sMark.replace('?', '_')); // '?' causes problems in
IE/Netscape 5
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/misc/dsntypes.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit eef0c5bf210635fe3edbe1ba58b73639fef4bc4b
Author: Lionel Elie Mamane
Date: Mon Jan 26 05:17:30 2015 +0100
indentation
Change-Id: Ib33d2321e15934ec4f6eb8d0c566bbd0e6de8da7
diff --git a/dbaccess/source/core/misc/dsntypes.cxx
b/dbaccess/source/core/misc/dsntypes.cxx
index 3b73fa1..f2a99f6 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -233,7 +233,7 @@ void ODsnTypeCollection::extractHostNamePort(const
OUString& _rDsn,OUString& _sD
_sDatabaseName = sUrl.getToken(comphelper::string::getTokenCount(sUrl,
'/') - 1, '/');
}
else if (
_rDsn.startsWithIgnoreAsciiCase("sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;DATA
SOURCE=")
- ||
_rDsn.startsWithIgnoreAsciiCase("sdbc:ado:access:PROVIDER=Microsoft.Jet.OLEDB.4.0;DATA
SOURCE=") )
+ ||
_rDsn.startsWithIgnoreAsciiCase("sdbc:ado:access:PROVIDER=Microsoft.Jet.OLEDB.4.0;DATA
SOURCE=") )
{
OUString sNewFileName;
if ( ::osl::FileBase::getFileURLFromSystemPath( sUrl, sNewFileName )
== ::osl::FileBase::E_None )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Jenkins verification of gerrit patches
On Sun, Jan 11, 2015 at 11:28:02PM -0600, Norbert Thiebaud wrote: > As you may have noticed, Jenkins is now setting 'Verify +1' on patches > it built successfully. > It start putting V+1 because now Jenkins do build on all 3 main > platforms (at first it was building only Mac, then Mac and Windows.. > now it build Mac, Windows and Linux) Is there some way to get the compilation result? That could be a nice way to verify patches for a platform one does not have a build environment for, and/or to give an experimental version to test to a bug reporter. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/misc/dsntypes.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 4735ad02167576036c9f3c9dffb3ccbd0a884db7
Author: Lionel Elie Mamane
Date: Mon Jan 26 04:44:08 2015 +0100
tdf#70236 propertly recognise full Access 2007 URL
Change-Id: If1f4986cfffada6a6ab507296a54589bdd5404ff
diff --git a/dbaccess/source/core/misc/dsntypes.cxx
b/dbaccess/source/core/misc/dsntypes.cxx
index 421b6b81..3b73fa1 100644
--- a/dbaccess/source/core/misc/dsntypes.cxx
+++ b/dbaccess/source/core/misc/dsntypes.cxx
@@ -361,7 +361,7 @@ DATASOURCE_TYPE ODsnTypeCollection::determineType(const
OUString& _rDsn) const
{
if (sDsn.startsWithIgnoreAsciiCase("sdbc:ado:access"))
{
-if
(sDsn.equalsIgnoreAsciiCase("sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;"))
+if
(sDsn.startsWithIgnoreAsciiCase("sdbc:ado:access:Provider=Microsoft.ACE.OLEDB.12.0;"))
return DST_MSACCESS_2007;
else
return DST_MSACCESS;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 13 commits - basic/source cppuhelper/source cui/source editeng/source filter/source sc/source vcl/source xmlsecurity/source
basic/source/comp/buffer.cxx|5 ---
cppuhelper/source/component_context.cxx | 12 +
cui/source/inc/insdlg.hxx |2 -
editeng/source/accessibility/AccessibleEditableTextPara.cxx | 10 +--
editeng/source/items/flditem.cxx|9 ++
filter/source/graphicfilter/itiff/itiff.cxx |9 ++
filter/source/msfilter/svdfppt.cxx | 16 ++--
sc/source/core/data/documen4.cxx|8 --
vcl/source/window/dlgctrl.cxx |6 ++--
xmlsecurity/source/helper/xsecctl.cxx | 12 +++--
10 files changed, 60 insertions(+), 29 deletions(-)
New commits:
commit 784d069cc1d9f1d6e6a4e543a278376ab483d1eb
Author: Caolán McNamara
Date: Sun Jan 25 21:28:20 2015 +
coverity#1266475 Dereference null return value
Change-Id: Ife68d6e6d837d1e4e1e1de3a82998866e5ef7e83
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index a7d6e7a..2b63b3f 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -231,7 +231,7 @@ vcl::Window* Window::ImplGetDlgWindow( sal_uInt16 nIndex,
sal_uInt16 nType,
pWindow = ImplGetChildWindow( this, nFormStart, i, true );
}
-if ( i <= nFormEnd )
+if (i <= nFormEnd && pWindow)
{
// carry the 2nd index, in case all controls are disabled
sal_uInt16 nStartIndex2 = i;
@@ -252,9 +252,9 @@ vcl::Window* Window::ImplGetDlgWindow( sal_uInt16 nIndex,
sal_uInt16 nType,
else
pWindow = ImplGetNextWindow( this, i, i, true );
}
-while ( (i != nStartIndex) && (i != nStartIndex2) );
+while (i != nStartIndex && i != nStartIndex2 && pWindow);
-if ( (i == nStartIndex2) &&
+if ( (i == nStartIndex2) && pWindow &&
(!(pWindow->GetStyle() & WB_TABSTOP) ||
!isEnabledInLayout(pWindow)) )
i = nStartIndex;
}
commit 6347df7af9a6c095da49c353aa8cc31914da8510
Author: Caolán McNamara
Date: Sun Jan 25 21:24:41 2015 +
coverity#1266458 Argument cannot be negative
and
coverity#1266464 Argument cannot be negative
Change-Id: I27fb7789cd37046fcdaeaaa801d6dc0547a8afa1
diff --git a/xmlsecurity/source/helper/xsecctl.cxx
b/xmlsecurity/source/helper/xsecctl.cxx
index 66edb6a..1225097 100644
--- a/xmlsecurity/source/helper/xsecctl.cxx
+++ b/xmlsecurity/source/helper/xsecctl.cxx
@@ -1019,10 +1019,8 @@ void SAL_CALL XSecController::signatureCreated(
sal_Int32 securityId, com::sun::
throw (com::sun::star::uno::RuntimeException, std::exception)
{
int index = findSignatureInfor(securityId);
-DBG_ASSERT( index != -1, "Signature Not Found!" );
-
-SignatureInformation& signatureInfor =
m_vInternalSignatureInformations[index].signatureInfor;
-
+assert(index != -1 && "Signature Not Found!");
+SignatureInformation& signatureInfor =
m_vInternalSignatureInformations.at(index).signatureInfor;
signatureInfor.nStatus = nResult;
}
@@ -1033,10 +1031,8 @@ void SAL_CALL XSecController::signatureVerified(
sal_Int32 securityId, com::sun:
throw (com::sun::star::uno::RuntimeException, std::exception)
{
int index = findSignatureInfor(securityId);
-DBG_ASSERT( index != -1, "Signature Not Found!" );
-
-SignatureInformation& signatureInfor =
m_vInternalSignatureInformations[index].signatureInfor;
-
+assert(index != -1 && "Signature Not Found!");
+SignatureInformation& signatureInfor =
m_vInternalSignatureInformations.at(index).signatureInfor;
signatureInfor.nStatus = nResult;
}
commit e11fe1886a58498899d7b074348186a46c5f6ac6
Author: Caolán McNamara
Date: Sun Jan 25 21:20:32 2015 +
coverity#1266474 Dereference null return value
Change-Id: I240be73629a26a7067bfde5d2b662315a3259d1f
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index 27f8a20..ba09b3b 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -82,14 +82,19 @@ bool ScDocument::Solver(SCCOL nFCol, SCROW nFRow, SCTAB
nFTab,
GetCellType(nVCol, nVRow, nVTab, eVType);
// #i108005# convert target value to number using default format,
// as previously done in ScInterpreter::GetDouble
+ScFormulaCell* pFormula = NULL;
double fTargetVal = 0.0;
sal_uInt32 nFIndex = 0;
if ( eFType == CELLTYPE_FORMULA && eVType == CELLTYPE_VALUE &&
GetFormatTable()->IsNumberFormat( sValStr, nFIndex, fTargetVal ) )
{
+ScAddress aFormulaAdr( nFCol, nFRow, nFTab );
+pFormula = GetFormulaCell( aFormulaAdr );
+
[Bug 39439] Web search for UI strings
https://bugs.documentfoundation.org/show_bug.cgi?id=39439 Mat M changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 m.a.riosv changed: What|Removed |Added Depends on||88792 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/unx
vcl/source/filter/wmf/winwmf.cxx |5 +
vcl/unx/generic/gdi/gdiimpl.cxx |2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
New commits:
commit 2b95714814b60a3d703525a7a5df453e5b87988c
Author: Caolán McNamara
Date: Sun Jan 25 15:04:48 2015 +
coverity#982431 Division or modulo by float zero
and
coverity#982432 Division or modulo by float zero
Change-Id: I1b9036d85c4b31b8136a96d330d95d7b024530aa
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index aef13a1..3c8ed8b 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -250,6 +250,11 @@ void WMFReader::ReadRecordParams( sal_uInt16 nFunc )
{
short nXNum = 0, nXDenom = 0, nYNum = 0, nYDenom = 0;
pWMF->ReadInt16( nYDenom ).ReadInt16( nYNum ).ReadInt16( nXDenom
).ReadInt16( nXNum );
+if (!nYDenom || !nXDenom)
+{
+pWMF->SetError( SVSTREAM_FILEFORMAT_ERROR );
+break;
+}
pOut->ScaleDevExt( (double)nXNum / nXDenom, (double)nYNum /
nYDenom );
}
break;
commit e3c70196e7f640cfde360b9832e91bec4eb7ab26
Author: Caolán McNamara
Date: Sun Jan 25 14:44:20 2015 +
coverity#1266437 Unintended comparison to logical negation
Change-Id: Ia4fc4ccbdfe3586afc78a16378ef0b3859308d64
diff --git a/vcl/unx/generic/gdi/gdiimpl.cxx b/vcl/unx/generic/gdi/gdiimpl.cxx
index 7eddf05..17a9a10 100644
--- a/vcl/unx/generic/gdi/gdiimpl.cxx
+++ b/vcl/unx/generic/gdi/gdiimpl.cxx
@@ -1230,7 +1230,7 @@ void X11SalGraphicsImpl::SetROPFillColor( SalROPColor
nROPColor )
void X11SalGraphicsImpl::SetXORMode( bool bSet, bool )
{
-if( !mbXORMode == bSet )
+if (mbXORMode != bSet)
{
mbXORMode = bSet;
mbPenGC = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: l10ntools/source scp2/source solenv/inc
l10ntools/source/ulfconv/msi-encodinglist.txt |7 --- scp2/source/ooo/module_helppack.ulf |6 ++ scp2/source/ooo/module_langpack.ulf |8 +++- solenv/inc/langlist.mk|1 + 4 files changed, 18 insertions(+), 4 deletions(-) New commits: commit b68ecae158c327c3fd85de9d2babb657ae97da1d Author: Andras Timar Date: Sun Jan 25 19:47:25 2015 +0100 add Guarani (gug) language Change-Id: Icf1612f88447e9ae348ef9ad333607a3f6dc8d32 diff --git a/l10ntools/source/ulfconv/msi-encodinglist.txt b/l10ntools/source/ulfconv/msi-encodinglist.txt index e83e95a..86c9b54 100644 --- a/l10ntools/source/ulfconv/msi-encodinglist.txt +++ b/l10ntools/source/ulfconv/msi-encodinglist.txt @@ -33,7 +33,7 @@ bg 0 1026 # Bulgarian bn 0 2117 # Bengali bn-BD0 2117 # Bengali Bangladesh bn-IN0 1093 # Bengali India -bo 0 2121 +bo 0 2121 br 0 1150 # Breton brx 0 1603 # Bodo (India) bs 0 5146 # bosnian @@ -64,6 +64,7 @@ gd 0 1084 # Gaelic (Scotland) gl 0 1110 # Galician gu 0 1095 # Gujarati gu-IN0 1095 # Gujarati +gug 0 1140 # Guarani - Paraguay he 0 1037 hi 0 1081 hr 0 1050 # Croatian @@ -116,7 +117,7 @@ om 0 2162 or 0 1096 # Odia or-IN0 1096 pa-IN0 1094 # Punjabi -pap 0 2171 +pap 0 2171 pl 0 1045 ps 0 2171 pt 0 2070 @@ -145,7 +146,7 @@ st 0 1072 # Southern Sotho, Sutu sv 0 1053 sw 0 1089 # Swahili sw-TZ0 1089 # Swahili -so 0 1143 +so 0 1143 ta 0 1097 # Tamil ta-IN0 1097 # Tamil te 0 1098 diff --git a/scp2/source/ooo/module_helppack.ulf b/scp2/source/ooo/module_helppack.ulf index 2fcc6e5..bc70e6c 100644 --- a/scp2/source/ooo/module_helppack.ulf +++ b/scp2/source/ooo/module_helppack.ulf @@ -520,6 +520,12 @@ en-US = "Gujarati" [STR_DESC_MODULE_HELPPACK_GU] en-US = "Installs Gujarati help in %PRODUCTNAME %PRODUCTVERSION" +[STR_NAME_MODULE_HELPPACK_GUG] +en-US = "Guarani" + +[STR_DESC_MODULE_HELPPACK_GUG] +en-US = "Installs Guarani help in %PRODUCTNAME %PRODUCTVERSION" + [STR_NAME_MODULE_HELPPACK_EN_ZA] en-US = "English (South Africa)" diff --git a/scp2/source/ooo/module_langpack.ulf b/scp2/source/ooo/module_langpack.ulf index 37e911e..41f6974 100644 --- a/scp2/source/ooo/module_langpack.ulf +++ b/scp2/source/ooo/module_langpack.ulf @@ -15,7 +15,7 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ - + [STR_NAME_MODULE_ROOT_LANGPACK] en-US = "Additional user interface languages" @@ -526,6 +526,12 @@ en-US = "Gujarati" [STR_DESC_MODULE_LANGPACK_GU] en-US = "Installs the Gujarati user interface" +[STR_NAME_MODULE_LANGPACK_GUG] +en-US = "Guarani" + +[STR_DESC_MODULE_LANGPACK_GUG] +en-US = "Installs the Guarani user interface" + [STR_NAME_MODULE_LANGPACK_EN_ZA] en-US = "English (South Africa)" diff --git a/solenv/inc/langlist.mk b/solenv/inc/langlist.mk index 5d2448b..26852c2 100644 --- a/solenv/inc/langlist.mk +++ b/solenv/inc/langlist.mk @@ -53,6 +53,7 @@ ga \ gd \ gl \ gu \ +gug \ he \ hi \ hr \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: registry/source
registry/source/reflread.cxx |2 --
1 file changed, 2 deletions(-)
New commits:
commit 643c46bbd69ae47d90327726a8348f589d2a487d
Author: Stephan Bergmann
Date: Sun Jan 25 20:13:03 2015 +0100
loplugin:unreffun
Change-Id: Id7e0ddf60e32a27cb3922ae6c64feeec40f8e079
diff --git a/registry/source/reflread.cxx b/registry/source/reflread.cxx
index 2905bd3..23f267d 100644
--- a/registry/source/reflread.cxx
+++ b/registry/source/reflread.cxx
@@ -821,8 +821,6 @@ public:
}
}
-sal_uInt32 parseIndex() { return ((m_numOfEntries ? sizeof(sal_uInt16) :
0) + (m_numOfEntries * m_REFERENCE_ENTRY_SIZE));}
-
const sal_Char* getReferenceName(sal_uInt16 index);
RTReferenceType getReferenceType(sal_uInt16 index);
const sal_Char* getReferenceDoku(sal_uInt16 index);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 39a712a7f9e9c2b70015f84c97978e0a39fd5174 Author: Andras Timar Date: Sun Jan 25 19:23:01 2015 +0100 Updated core Project: translations b88d2877688f4d01d3f054a4fd0246b2159136c3 diff --git a/translations b/translations index 8c4fea3..b88d287 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 8c4fea354d3d98a6cb8da4f9ddb87e072bdc21e6 +Subproject commit b88d2877688f4d01d3f054a4fd0246b2159136c3 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] translations.git: source/gug
source/gug/accessibility/source/helper.po | 30 source/gug/avmedia/source/framework.po | 32 source/gug/avmedia/source/viewer.po | 16 source/gug/basctl/source/basicide.po | 244 - source/gug/basctl/source/dlged.po | 16 source/gug/basctl/uiconfig/basicide/ui.po | 130 source/gug/basic/source/classes.po | 219 - source/gug/basic/source/sbx.po |8 source/gug/chart2/source/controller/dialogs.po | 14 source/gug/chart2/uiconfig/ui.po | 38 source/gug/connectivity/registry/ado/org/openoffice/Office/DataAccess.po | 10 source/gug/connectivity/registry/calc/org/openoffice/Office/DataAccess.po |8 source/gug/connectivity/registry/firebird/org/openoffice/Office/DataAccess.po |8 source/gug/connectivity/registry/flat/org/openoffice/Office/DataAccess.po |8 source/gug/cui/source/customize.po | 228 - source/gug/cui/source/dialogs.po | 182 - source/gug/cui/source/options.po | 362 +- source/gug/cui/source/tabpages.po | 245 - source/gug/cui/uiconfig/ui.po | 1327 +- source/gug/dbaccess/source/ext/macromigration.po | 12 source/gug/dbaccess/source/sdbtools/resource.po |8 source/gug/dbaccess/source/ui/app.po | 28 source/gug/dbaccess/source/ui/browser.po | 12 source/gug/dbaccess/source/ui/control.po | 10 source/gug/dbaccess/source/ui/dlg.po | 22 source/gug/dbaccess/source/ui/inc.po |8 source/gug/dbaccess/source/ui/misc.po | 14 source/gug/dbaccess/source/ui/querydesign.po |8 source/gug/dbaccess/source/ui/relationdesign.po |8 source/gug/dbaccess/source/ui/tabledesign.po | 18 source/gug/dbaccess/uiconfig/ui.po | 56 source/gug/desktop/source/deployment/gui.po | 10 source/gug/desktop/source/deployment/registry/help.po |8 source/gug/desktop/source/deployment/unopkg.po |8 source/gug/desktop/uiconfig/ui.po |6 source/gug/dictionaries/en/dialog.po | 10 source/gug/editeng/source/editeng.po | 14 source/gug/editeng/source/items.po | 62 source/gug/editeng/source/outliner.po | 10 source/gug/extensions/source/abpilot.po |8 source/gug/extensions/source/bibliography.po | 16 source/gug/extensions/source/dbpilots.po |8 source/gug/extensions/source/propctrlr.po | 75 source/gug/extensions/source/update/check.po | 12 source/gug/extensions/uiconfig/sabpilot/ui.po |8 source/gug/extensions/uiconfig/sbibliography/ui.po | 10 source/gug/extensions/uiconfig/scanner/ui.po | 10 source/gug/extensions/uiconfig/spropctrlr/ui.po |8 source/gug/extras/source/gallery/share.po | 28 source/gug/filter/source/config/fragments/filters.po | 226 - source/gug/filter/source/config/fragments/internalgraphicfilters.po | 16 source/gug/filter/source/config/fragments/types.po | 51 source/gug/filter/source/pdf.po | 18 source/gug/filter/source/t602.po | 10 source/gug/filter/source/xsltdialog.po |8 source/gug/filter/uiconfig/ui.po | 32 source/gug/forms/source/resource.po
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/browser/sbagrid.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 71ba72260ea9526bbe2003f669bb4f006a907504
Author: Lionel Elie Mamane
Date: Sun Jan 25 19:01:00 2015 +0100
tdf#73059 isDBReadOnly ensure connection before trying to retrieve it
Change-Id: I03f9b8ea72bd6906df61ccf05ead3670d7f90eb7
Reviewed-on: https://gerrit.libreoffice.org/14175
Reviewed-by: Lionel Elie Mamane
Tested-by: Lionel Elie Mamane
diff --git a/dbaccess/source/ui/browser/sbagrid.cxx
b/dbaccess/source/ui/browser/sbagrid.cxx
index cf86c83..dcd42dc 100644
--- a/dbaccess/source/ui/browser/sbagrid.cxx
+++ b/dbaccess/source/ui/browser/sbagrid.cxx
@@ -989,6 +989,7 @@ bool SbaGridControl::IsReadOnlyDB() const
if (xColumns.is())
{
Reference< XRowSet > xDataSource(xColumns->getParent(), UNO_QUERY);
+::dbtools::ensureRowSetConnection( xDataSource, getContext(), false );
// NOT SURE ABOUT FALSE
Reference< XChild >
xConn(::dbtools::getConnection(xDataSource),UNO_QUERY);
if (xConn.is())
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/api/RowSet.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit 294cea0f5b84e6d9e0b508e0c181c77f526264ae
Author: Lionel Elie Mamane
Date: Sun Jan 25 19:01:19 2015 +0100
that better be the case
Change-Id: Ic0262292e207146c563b8830243a80104f94f903
Reviewed-on: https://gerrit.libreoffice.org/14176
Reviewed-by: Lionel Elie Mamane
Tested-by: Lionel Elie Mamane
diff --git a/dbaccess/source/core/api/RowSet.cxx
b/dbaccess/source/core/api/RowSet.cxx
index 079673d..c28763f 100644
--- a/dbaccess/source/core/api/RowSet.cxx
+++ b/dbaccess/source/core/api/RowSet.cxx
@@ -315,6 +315,7 @@ void SAL_CALL
ORowSet::setFastPropertyValue_NoBroadcast(sal_Int32 nHandle,const
case PROPERTY_ID_ACTIVE_CONNECTION:
// the new connection
{
+assert(m_aActiveConnection == rValue);
Reference< XConnection >
xNewConnection(m_aActiveConnection,UNO_QUERY);
setActiveConnection(xNewConnection, false);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/core/api/RowSetBase.cxx | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
New commits:
commit 3d12bdfb243e1efbc368d95d3e42e7d713b63b45
Author: Lionel Elie Mamane
Date: Sun Jan 25 19:01:52 2015 +0100
when beforeFirst/afterLast, there is no value, so none to notify
Change-Id: I599f8efae98e7cc7f65f47cec7f342c8b3dc8282
Reviewed-on: https://gerrit.libreoffice.org/14177
Reviewed-by: Lionel Elie Mamane
Tested-by: Lionel Elie Mamane
diff --git a/dbaccess/source/core/api/RowSetBase.cxx
b/dbaccess/source/core/api/RowSetBase.cxx
index 3dbd6a0..53be639 100644
--- a/dbaccess/source/core/api/RowSetBase.cxx
+++ b/dbaccess/source/core/api/RowSetBase.cxx
@@ -1055,6 +1055,12 @@ void ORowSetBase::setCurrentRow( bool _bMoved, bool
_bDoNotify, const ORowSetRow
ORowSetRow rRow = (*m_aCurrentRow);
OSL_ENSURE(rRow.is() ,"Invalid size of vector!");
#endif
+
+// notification order
+// - column values
+if ( _bDoNotify )
+firePropertyChange(_rOldValues);
+
}
else
{
@@ -1064,11 +1070,6 @@ void ORowSetBase::setCurrentRow( bool _bMoved, bool
_bDoNotify, const ORowSetRow
m_aCurrentRow.setBookmark(m_aBookmark);
}
-// notification order
-// - column values
-if ( _bDoNotify )
-firePropertyChange(_rOldValues);
-
// TODO: can this be done before the notifications?
if(!(m_bBeforeFirst || m_bAfterLast) && !m_aCurrentRow.isNull() &&
m_aCurrentRow->is() && m_aCurrentRow != m_pCache->getEnd())
m_aOldRow->setRow(new ORowSetValueVector( *(*m_aCurrentRow) ));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 11638719eab866162a617f4b51cac9c3b872abed Author: Andras Timar Date: Sun Jan 25 19:14:48 2015 +0100 Updated core Project: translations 8c4fea354d3d98a6cb8da4f9ddb87e072bdc21e6 diff --git a/translations b/translations index 78a223e..8c4fea3 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 78a223e7931ed04859cfe0c8bd834c4956e50e0b +Subproject commit 8c4fea354d3d98a6cb8da4f9ddb87e072bdc21e6 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/excel/xetable.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit aa943c3938e19ada039ddf63f3a0b2cfba3584b8 Author: Michael Meeks Date: Wed Jan 21 15:17:05 2015 + Revert "Globally disable threading for these for now." This effctively reverts commit d677bf455f08264096edd13e3306c55f74f7ee1d. It appears that the memory corruption was an out-of-memory condition on 32bit Windows, so restore XclExpRow threading for now. Change-Id: I85e61e5850bd8ff3288dac39de7699cd05dd4de8 diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx index 807ea80..70f3373 100644 --- a/sc/source/filter/excel/xetable.cxx +++ b/sc/source/filter/excel/xetable.cxx @@ -2065,7 +2065,7 @@ void XclExpRowBuffer::Finalize( XclExpDefaultRowData& rDefRowData, const ScfUInt GetProgressBar().ActivateFinalRowsSegment(); -#if 0 +#if 1 // This is staggeringly slow, and each element operates only // on its own data. const size_t nRows = maRowMap.size(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Build failure in 4.4 branch with --enable-ext-google-docs on Xubuntu 14.04 amd64: "undefined reference to symbol 'dlclose@@GLIBC_2.2.5'"
On 17 December 2014 at 12:10, Andras Timar wrote: > On Wed, Dec 17, 2014 at 12:35 PM, David Gerard wrote: [making LO connect to Google Drive reliably] >> So I need to ... literally compile my credentials into LO? >> How do the Windows builds of 4.3 and 4.4beta1 work? Are you saying >> they have someone's credentials actually compiled into them? > Yes. For TDF builds TDF credentials are compiled in. But it is not > used for anything else, but to identify the application with Google > Drive. It is not a personal thing. I now have a build that connects reasonably reliably, using this line: ./autogen.sh --with-gdrive-client-secret="GYWrDtzyZQZ0_g5YoBCC6F0I" --with-gdrive-client-id="457862564325.apps.googleusercontent.com"; make That's the TDF secret. I want to write a blog post saying how I did this - before I do so, will there be a problem putting it up with that secret (which is presumably the one in every TDF build)? Should I use another one? If so, how do I obtain another one? (also, will this stop working when Google stops doing OAuth2?) - d. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: include/vcl svtools/source vcl/source
include/vcl/settings.hxx|3 ---
svtools/source/contnr/treelistbox.cxx | 23 ++-
svtools/source/contnr/treelistentry.cxx |2 --
vcl/source/app/settings.cxx | 16
4 files changed, 14 insertions(+), 30 deletions(-)
New commits:
commit 148e489e33a34c6345326c9beaf248ac91f8cd01
Author: Palenik Mihály
Date: Sun Jan 25 01:03:57 2015 +0100
fdo#84592 Improve SvTreeListBox class with alternating rows.
It is possible to set alternating rows. Expert Configuration dialog use it.
This bug was fixed earlier, but after this feature didn't work.
Change-Id: I3602a6b03db32d6f43ec163de2427f4a018c7779
Reviewed-on: https://gerrit.libreoffice.org/14164
Reviewed-by: Andras Timar
Tested-by: Andras Timar
diff --git a/include/vcl/settings.hxx b/include/vcl/settings.hxx
index a657127..c701654 100644
--- a/include/vcl/settings.hxx
+++ b/include/vcl/settings.hxx
@@ -351,9 +351,6 @@ public:
voidSetInactiveTabColor( const Color& rColor );
const Color&GetInactiveTabColor() const;
-voidSetRowColor( const Color& rColor );
-const Color&GetRowColor() const;
-
voidSetAlternatingRowColor( const Color&
rColor );
const Color&GetAlternatingRowColor() const;
diff --git a/svtools/source/contnr/treelistbox.cxx
b/svtools/source/contnr/treelistbox.cxx
index 707b7bb..aadadd6 100644
--- a/svtools/source/contnr/treelistbox.cxx
+++ b/svtools/source/contnr/treelistbox.cxx
@@ -470,12 +470,14 @@ IMPL_LINK_INLINE_END( SvTreeListBox, CloneHdl_Impl,
SvTreeListEntry*, pEntry )
sal_uLong SvTreeListBox::Insert( SvTreeListEntry* pEntry, SvTreeListEntry*
pParent, sal_uLong nPos )
{
sal_uLong nInsPos = pModel->Insert( pEntry, pParent, nPos );
+pEntry->SetBackColor( GetBackground().GetColor() );
if(mbAlternatingRowColors)
{
if(nPos == TREELIST_APPEND)
-pEntry->SetBackColor( Prev(pEntry) && Prev(pEntry)->GetBackColor()
== GetSettings().GetStyleSettings().GetRowColor() ?
-
GetSettings().GetStyleSettings().GetAlternatingRowColor() :
-
GetSettings().GetStyleSettings().GetRowColor() );
+{
+if(Prev(pEntry) && Prev(pEntry)->GetBackColor() ==
GetBackground().GetColor())
+pEntry->SetBackColor(
GetSettings().GetStyleSettings().GetAlternatingRowColor() );
+}
else
SetAlternatingRowColors( true );
}
@@ -485,12 +487,14 @@ sal_uLong SvTreeListBox::Insert( SvTreeListEntry* pEntry,
SvTreeListEntry* pPare
sal_uLong SvTreeListBox::Insert( SvTreeListEntry* pEntry,sal_uLong nRootPos )
{
sal_uLong nInsPos = pModel->Insert( pEntry, nRootPos );
+pEntry->SetBackColor( GetBackground().GetColor() );
if(mbAlternatingRowColors)
{
if(nRootPos == TREELIST_APPEND)
-pEntry->SetBackColor( Prev(pEntry) && Prev(pEntry)->GetBackColor()
== GetSettings().GetStyleSettings().GetRowColor() ?
-
GetSettings().GetStyleSettings().GetAlternatingRowColor() :
-
GetSettings().GetStyleSettings().GetRowColor() );
+{
+if(Prev(pEntry) && Prev(pEntry)->GetBackColor() ==
GetBackground().GetColor())
+pEntry->SetBackColor(
GetSettings().GetStyleSettings().GetAlternatingRowColor() );
+}
else
SetAlternatingRowColors( true );
}
@@ -3020,6 +3024,8 @@ long SvTreeListBox::PaintEntry1(SvTreeListEntry*
pEntry,long nLine,sal_uInt16 nT
SetTextColor( aBackupTextColor );
Control::SetFont( aBackupFont );
}
+else
+aWallpaper.SetColor( pEntry->GetBackColor() );
}
// draw background
@@ -3414,14 +3420,13 @@ void SvTreeListBox::SetAlternatingRowColors( bool
bEnable )
SvTreeListEntry* pEntry = pModel->First();
for(size_t i = 0; pEntry; ++i)
{
-pEntry->SetBackColor( i % 2 == 0 ?
GetSettings().GetStyleSettings().GetRowColor() :
-
GetSettings().GetStyleSettings().GetAlternatingRowColor());
+pEntry->SetBackColor( i % 2 == 0 ? GetBackground().GetColor() :
GetSettings().GetStyleSettings().GetAlternatingRowColor());
pEntry = pModel->Next(pEntry);
}
}
else
for(SvTreeListEntry* pEntry = pModel->First(); pEntry; pEntry =
pModel->Next(pEntry))
-pEntry->SetBackColor(
GetSettings().GetStyleSettings().GetRowColor() );
+pEntry->SetBackColor( GetBackground().GetColor() );
pImp->UpdateAll();
}
diff --git a/svtools/source/contnr/treelistentry.cxx
b/svtools/source/contnr/treelistentry.cxx
index e8b
[Libreoffice-commits] core.git: 5 commits - dbaccess/source filter/source sc/inc svtools/source vcl/source
dbaccess/source/core/dataaccess/documentdefinition.cxx |2 --
filter/source/msfilter/msdffimp.cxx|3 +++
sc/inc/document.hxx| 16 +++-
svtools/source/brwbox/brwbox1.cxx |5 +++--
vcl/source/opengl/OpenGLHelper.cxx |6 ++
5 files changed, 19 insertions(+), 13 deletions(-)
New commits:
commit 164903c0441a2cd79bc06708fe7e69780bb85a09
Author: Caolán McNamara
Date: Sun Jan 25 14:40:42 2015 +
WaE: unused member
Change-Id: I3fe4cc5ba4c40b54718338ac4c02c67979486feb
diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx
b/dbaccess/source/core/dataaccess/documentdefinition.cxx
index 5711294..09032e3 100644
--- a/dbaccess/source/core/dataaccess/documentdefinition.cxx
+++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx
@@ -164,7 +164,6 @@ namespace dbaccess
Reference< XEmbeddedObject >m_xBroadCaster;
ODocumentDefinition*m_pDefinition;
boolm_bInStateChange;
-boolm_bInChangingState;
protected:
virtual void SAL_CALL disposing() SAL_OVERRIDE;
public:
@@ -173,7 +172,6 @@ namespace dbaccess
,m_xBroadCaster(_xBroadCaster)
,m_pDefinition(_pDefinition)
,m_bInStateChange(false)
-,m_bInChangingState(false)
{
osl_atomic_increment( &m_refCount );
{
commit 09f38e21c1a69bc0b00a72b954bd88b9545bb1c5
Author: Caolán McNamara
Date: Sun Jan 25 14:36:14 2015 +
coverity#1266483 String not null terminated
Change-Id: I4d22e5a621d36fa2e914891e82ce7e8e06f60b4c
diff --git a/vcl/source/opengl/OpenGLHelper.cxx
b/vcl/source/opengl/OpenGLHelper.cxx
index af1d8e7..372f0bd 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -50,10 +50,8 @@ OString loadShader(const OUString& rFilename)
boost::scoped_array content(new char[nSize+1]);
sal_uInt64 nBytesRead = 0;
aFile.read(content.get(), nSize, nBytesRead);
-if(nSize != nBytesRead)
-assert(false);
-
-content[nSize] = 0;
+assert(nSize == nBytesRead);
+content[nBytesRead] = 0;
return OString(content.get());
}
else
commit 18a1d996edde4845394090642ce03ec083c5761b
Author: Caolán McNamara
Date: Sun Jan 25 14:34:19 2015 +
coverity#1266498 Uninitialized scalar variable
Change-Id: I203b9ff32cca1ca8d03911567290e534e082ee52
diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index baf8c9c..e992b0f 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -217,11 +217,11 @@ namespace com { namespace sun { namespace star {
#define SC_ASIANKERNING_INVALID 0xff
enum ScDocumentMode
-{
-SCDOCMODE_DOCUMENT,
-SCDOCMODE_CLIP,
-SCDOCMODE_UNDO
-};
+{
+SCDOCMODE_DOCUMENT,
+SCDOCMODE_CLIP,
+SCDOCMODE_UNDO
+};
struct ScDocStat
{
@@ -229,6 +229,12 @@ struct ScDocStat
SCTAB nTableCount;
sal_uLong nCellCount;
sal_uInt16 nPageCount;
+ScDocStat()
+: nTableCount(0)
+, nCellCount(0)
+, nPageCount(0)
+{
+}
};
// DDE link modes
commit 05fcc0ff9f55e739871b3ad42b57935541f9a8a5
Author: Caolán McNamara
Date: Sun Jan 25 14:29:26 2015 +
coverity#440858 Argument cannot be negative
Change-Id: Ia2725c54ef5850e5c66a79fbe54956769582b013
diff --git a/svtools/source/brwbox/brwbox1.cxx
b/svtools/source/brwbox/brwbox1.cxx
index 657d29c..334040c 100644
--- a/svtools/source/brwbox/brwbox1.cxx
+++ b/svtools/source/brwbox/brwbox1.cxx
@@ -299,7 +299,6 @@ void BrowseBox::InsertDataColumn( sal_uInt16 nItemId, const
OUString& rText,
ColumnInserted( nPos );
}
-
sal_uInt16 BrowseBox::ToggleSelectedColumn()
{
sal_uInt16 nSelectedColId = BROWSER_INVALIDID;
@@ -307,7 +306,9 @@ sal_uInt16 BrowseBox::ToggleSelectedColumn()
{
DoHideCursor( "ToggleSelectedColumn" );
ToggleSelection();
-nSelectedColId = (*pCols)[ pColSel->FirstSelected() ]->GetId();
+long nSelected = pColSel->FirstSelected();
+if (nSelected != static_cast(SFX_ENDOFSELECTION))
+nSelectedColId = (*pCols)[nSelected]->GetId();
pColSel->SelectAll(false);
}
return nSelectedColId;
commit a6218ad20adf29675194ad7f422bfa0d5ddf5a73
Author: Caolán McNamara
Date: Sun Jan 25 14:24:57 2015 +
coverity#984091 Uninitialized scalar field
Change-Id: Ie0d90edb26fe2704192895a2b456a37f3d500a17
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 107b38a..77b6b80 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -5527,6 +5527,9 @@ SvxMSDffManager::SvxMSDffManager(SvStream& rStCtrl_,
nGroupShapeFlags(0),
[Libreoffice-commits] dev-tools.git: cppcheck/cppcheck-report.sh
cppcheck/cppcheck-report.sh | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
New commits:
commit a71cf8c84898db994215d3a822027e0d58dad080
Author: Maarten Hoes
Date: Sun Jan 25 10:08:09 2015 +0100
Fix 'UnicodeEncodeError'. Get correct git commit date/time.
Change-Id: I83c095964f6a179099e64868cbc09ace41387523
Reviewed-on: https://gerrit.libreoffice.org/14166
Reviewed-by: Caolán McNamara
Tested-by: Caolán McNamara
diff --git a/cppcheck/cppcheck-report.sh b/cppcheck/cppcheck-report.sh
index 05efb95..64706c4 100755
--- a/cppcheck/cppcheck-report.sh
+++ b/cppcheck/cppcheck-report.sh
@@ -97,9 +97,9 @@ get_commit_lo()
pushd "${LO_SRC_DIR?}" > /dev/null || die "Failed to change directory to
${LO_SRC_DIR?}"
-COMMIT_SHA1_LO=$(git log --date=iso | head -3 | awk '/^commit/ {print $2}')
-COMMIT_DATE_LO=$(git log --date=iso | head -3 | awk '/^Date/ {print $2}')
-COMMIT_TIME_LO=$(git log --date=iso | head -3 | awk '/^Date/ {print $3}')
+COMMIT_SHA1_LO=$(git log --date=iso | head -5 | awk '/^commit/ {print $2}')
+COMMIT_DATE_LO=$(git log --date=iso | head -5 | awk '/^Date/ {print $2}')
+COMMIT_TIME_LO=$(git log --date=iso | head -5 | awk '/^Date/ {print $3}')
popd > /dev/null || die "Failed to change directory out of ${LO_SRC_DIR?}"
}
@@ -110,9 +110,9 @@ get_commit_cppcheck()
pushd "${CPPCHECK_DIR?}" > /dev/null || die "Failed to change directory to
${CPPCHECK_DIR?}"
-COMMIT_SHA1_CPPCHECK=$(git log --date=iso | head -3 | awk '/^commit/
{print $2}')
-COMMIT_DATE_CPPCHECK=$(git log --date=iso | head -3 | awk '/^Date/ {print
$2}')
-COMMIT_TIME_CPPCHECK=$(git log --date=iso | head -3 | awk '/^Date/ {print
$3}')
+COMMIT_SHA1_CPPCHECK=$(git log --date=iso | head -5 | awk '/^commit/
{print $2}')
+COMMIT_DATE_CPPCHECK=$(git log --date=iso | head -5 | awk '/^Date/ {print
$2}')
+COMMIT_TIME_CPPCHECK=$(git log --date=iso | head -5 | awk '/^Date/ {print
$3}')
popd > /dev/null || die "Failed to change directory out of
${CPPCHECK_DIR?}"
}
@@ -134,7 +134,7 @@ cat > "$EMAIL_BODY" "$EMAIL_BODY" <___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 9 commits - dbaccess/source editeng/source registry/source sfx2/source sw/source uui/source vcl/workben
dbaccess/source/core/dataaccess/documentdefinition.cxx |7 +--
editeng/source/editeng/impedit4.cxx|2 --
registry/source/reflread.cxx |2 --
sfx2/source/appl/appbas.cxx|5 -
sw/source/core/layout/pagechg.cxx |3 +--
sw/source/filter/html/wrthtml.cxx |3 +--
sw/source/uibase/globdoc/globdoc.cxx |1 -
uui/source/fltdlg.cxx |1 -
vcl/workben/vcldemo.cxx|1 +
9 files changed, 4 insertions(+), 21 deletions(-)
New commits:
commit 00c42b64ab57a54db2475084cdfd70e64405bd8c
Author: Caolán McNamara
Date: Sun Jan 25 14:20:35 2015 +
coverity#1266499 Uninitialized scalar field
Change-Id: I788f0b34abd80feab247c3f2bba8ac5d49fc5c08
diff --git a/vcl/workben/vcldemo.cxx b/vcl/workben/vcldemo.cxx
index 0d81a74..0a36eb8 100644
--- a/vcl/workben/vcldemo.cxx
+++ b/vcl/workben/vcldemo.cxx
@@ -1209,6 +1209,7 @@ class DemoWin : public WorkWindow
, mrWin(rWin)
{
maDelay.Seconds = nDelaySecs;
+maDelay.Nanosec = 0;
launch();
}
virtual ~RenderThread()
commit 688cade99564380bac9e9229519afa88f4d5fd04
Author: Caolán McNamara
Date: Sun Jan 25 14:19:36 2015 +
coverity#1266500 Unused value
Change-Id: I81441568c4c5b864abbf1375b561a9389a72ef90
diff --git a/dbaccess/source/core/dataaccess/documentdefinition.cxx
b/dbaccess/source/core/dataaccess/documentdefinition.cxx
index 0cbeb70..5711294 100644
--- a/dbaccess/source/core/dataaccess/documentdefinition.cxx
+++ b/dbaccess/source/core/dataaccess/documentdefinition.cxx
@@ -196,13 +196,8 @@ namespace dbaccess
m_pDefinition = NULL;
}
-void SAL_CALL OEmbedObjectHolder::changingState( const lang::EventObject&
/*aEvent*/, ::sal_Int32 nOldState, ::sal_Int32 nNewState ) throw
(embed::WrongStateException, uno::RuntimeException, std::exception)
+void SAL_CALL OEmbedObjectHolder::changingState( const lang::EventObject&
/*aEvent*/, ::sal_Int32 /*nOldState*/, ::sal_Int32 /*nNewState*/ ) throw
(embed::WrongStateException, uno::RuntimeException, std::exception)
{
-if ( !m_bInChangingState && nNewState == EmbedStates::RUNNING &&
nOldState == EmbedStates::ACTIVE && m_pDefinition )
-{
-m_bInChangingState = true;
-m_bInChangingState = false;
-}
}
void SAL_CALL OEmbedObjectHolder::stateChanged( const lang::EventObject&
aEvent, ::sal_Int32 nOldState, ::sal_Int32 nNewState ) throw
(uno::RuntimeException, std::exception)
commit f8e7e33c6bd87065f2aa36b8bf7b830c11bdddfe
Author: Caolán McNamara
Date: Sun Jan 25 14:17:08 2015 +
coverity#1266501 Unused value
Change-Id: I53a1f16a08c3552fcf77d17f5be4ae0d483c5933
diff --git a/sw/source/uibase/globdoc/globdoc.cxx
b/sw/source/uibase/globdoc/globdoc.cxx
index 2e1ae47..23caf61 100644
--- a/sw/source/uibase/globdoc/globdoc.cxx
+++ b/sw/source/uibase/globdoc/globdoc.cxx
@@ -61,7 +61,6 @@ void SwGlobalDocShell::FillClass( SvGlobalName * pClassName,
else if (nVersion == SOFFICE_FILEFORMAT_8)
{
*pClassName = SvGlobalName( SO3_SWGLOB_CLASSID_60 );
-*pClipFormat= SOT_FORMATSTR_ID_STARWRITERGLOB_8;
*pClipFormat= bTemplate ?
SOT_FORMATSTR_ID_STARWRITERGLOB_8_TEMPLATE : SOT_FORMATSTR_ID_STARWRITERGLOB_8;
*pLongUserName = SW_RESSTR(STR_WRITER_GLOBALDOC_FULLTYPE);
}
commit 5bf41f6026a656841c46efd77bd9e1d4e5dde504
Author: Caolán McNamara
Date: Sun Jan 25 14:16:06 2015 +
coverity#1266503 Useless call
Change-Id: Ifcbee64fcb41a99421b4894e3b4e2472c1ea58a4
diff --git a/uui/source/fltdlg.cxx b/uui/source/fltdlg.cxx
index d6256cc..a24a34e 100644
--- a/uui/source/fltdlg.cxx
+++ b/uui/source/fltdlg.cxx
@@ -51,7 +51,6 @@ FilterDialog::FilterDialog( vcl::Window* pParentWindow )
{
get(m_pFtURL, "url");
get(m_pLbFilters, "filters");
-m_pFtURL->GetOutputSizePixel();
Size aSize(pParentWindow->LogicToPixel(Size(182, 175), MAP_APPFONT));
m_pLbFilters->set_height_request(aSize.Height());
m_pLbFilters->set_width_request(aSize.Width());
commit f0a9acee2430a265a65e0b0a6047163397026b1b
Author: Caolán McNamara
Date: Sun Jan 25 14:15:31 2015 +
coverity#1266504 Useless call
Change-Id: I11a2760799937393bfa1a91c1d454ccb3c4027e4
diff --git a/registry/source/reflread.cxx b/registry/source/reflread.cxx
index 4099e4a..2905bd3 100644
--- a/registry/source/reflread.cxx
+++ b/registry/source/reflread.cxx
@@ -1241,8 +1241,6 @@ TypeRegistryEntry::TypeRegistryEntry(
new ReferenceList(
m_pBuffer + offset + entrySize, m_bufferLen - (offset + entrySize),
readUINT16(offset), m_pCP.get()));
-
-m_pReferences->parseIndex();
}
typereg_Version TypeRegistryEntry::getVersion() cons
[Libreoffice-commits] core.git: 4 commits - lotuswordpro/source sc/source sfx2/source sw/source
lotuswordpro/source/filter/lwppara.cxx |4 +---
sc/source/core/opencl/op_statistical.cxx |2 +-
sfx2/source/control/bindings.cxx |1 -
sfx2/source/view/viewfrm.cxx |6 ++
sw/source/core/doc/docredln.cxx |4 +---
5 files changed, 5 insertions(+), 12 deletions(-)
New commits:
commit 5c85b4eacbabf651c3b49f00c30532a86c133510
Author: Caolán McNamara
Date: Sun Jan 25 14:09:45 2015 +
coverity#1266509 Useless call
Change-Id: Ie2b17f067e5f9a7bacc5e6488e142d0171741106
diff --git a/sc/source/core/opencl/op_statistical.cxx
b/sc/source/core/opencl/op_statistical.cxx
index 1f667f5..04dcf60 100644
--- a/sc/source/core/opencl/op_statistical.cxx
+++ b/sc/source/core/opencl/op_statistical.cxx
@@ -4626,7 +4626,7 @@ void OpRsq::GenSlidingWindowFunction(
ss << "double fInx;\n";
ss << "double fIny;\n";
ss << "double tmp0,tmp1;\n";
-vSubArguments.size();
+
ss <<"\n";
ss << " for(int i=0; i<"<
Date: Sun Jan 25 14:08:29 2015 +
coverity#1266510 Useless call
Change-Id: I4e3127243b103ea77a56aa9cfbcb61793a644ce3
diff --git a/sfx2/source/control/bindings.cxx b/sfx2/source/control/bindings.cxx
index fe51948..466d818 100644
--- a/sfx2/source/control/bindings.cxx
+++ b/sfx2/source/control/bindings.cxx
@@ -1106,7 +1106,6 @@ const SfxPoolItem* SfxBindings::Execute_Impl( sal_uInt16
nId, const SfxPoolItem*
SfxDispatcher &rDispatcher = *pDispatcher;
rDispatcher.Flush();
-rDispatcher.GetFrame(); // -Wall is this required???
// get SlotServer (Slot+ShellLevel) and Shell from cache
::boost::scoped_ptr xCache;
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 77a15b5..de07b92 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -845,15 +845,15 @@ void SfxViewFrame::ExecReload_Impl( SfxRequest& rReq )
}
}
-
void SfxViewFrame::StateReload_Impl( SfxItemSet& rSet )
{
SfxObjectShell* pSh = GetObjectShell();
if ( !pSh )
+{
// I'm just on reload and am yielding myself ...
return;
+}
-GetFrame().GetParentFrame();
SfxWhichIter aIter( rSet );
for ( sal_uInt16 nWhich = aIter.FirstWhich(); nWhich; nWhich =
aIter.NextWhich() )
{
@@ -925,8 +925,6 @@ void SfxViewFrame::StateReload_Impl( SfxItemSet& rSet )
}
}
-
-
void SfxViewFrame::ExecHistory_Impl( SfxRequest &rReq )
{
// Is there an Undo-Manager on the top Shell?
commit 80c0d3de5c855386ccf079501f3d6d77babb81e1
Author: Caolán McNamara
Date: Sun Jan 25 14:07:50 2015 +
coverity#1266511 Useless call
Change-Id: I0ca967e6e07cc00159612dd8e19648445e0a011a
diff --git a/lotuswordpro/source/filter/lwppara.cxx
b/lotuswordpro/source/filter/lwppara.cxx
index 22cf028..b2326f0 100644
--- a/lotuswordpro/source/filter/lwppara.cxx
+++ b/lotuswordpro/source/filter/lwppara.cxx
@@ -578,8 +578,6 @@ void LwpPara::RegisterStyle()
LwpNumberingOverride* pNumbering =
this->GetParaNumbering();
sal_uInt16 nPosition = pNumbering->GetPosition();
bool bLesser = m_pSilverBullet->IsLesserLevel(nPosition);
-/*sal_Bool bResetSection =*/
m_pSilverBullet->IsNewSection(nPosition);
-bool bHeading;
LwpPara* pPara = this;
LwpPara* pPrePara = NULL;
sal_uInt16 nNum = 0, nLevel = 0, nFoundLevel = 0x,
nFoundBound = 0;
@@ -589,7 +587,7 @@ void LwpPara::RegisterStyle()
{
nFoundBound++;
}
-bHeading = pNumbering->IsHeading();
+bool bHeading = pNumbering->IsHeading();
while(true)
{
commit f0fdd59f0ec88ef69b463d73963a0f3f81e1d78a
Author: Caolán McNamara
Date: Sun Jan 25 14:05:02 2015 +
coverity#1266513 Useless call
Change-Id: Icbfa17fc28b9ba3f2472d9042bc6c422b5c79b46
diff --git a/sw/source/core/doc/docredln.cxx b/sw/source/core/doc/docredln.cxx
index b2f1eea..52e2e80 100644
--- a/sw/source/core/doc/docredln.cxx
+++ b/sw/source/core/doc/docredln.cxx
@@ -747,10 +747,8 @@ SwRedlineExtraData*
SwRedlineExtraData_FormattingChanges::CreateNew() const
return new SwRedlineExtraData_FormattingChanges( *this );
}
-void SwRedlineExtraData_FormattingChanges::Reject( SwPaM& rPam ) const
+void SwRedlineExtraData_FormattingChanges::Reject(SwPaM&) const
{
-rPam.GetDoc(); // This is here just to prevent build 'warning'
-
// ToDo: Add 'Reject' logic
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - dbaccess/source editeng/source
dbaccess/source/core/api/SingleSelectQueryComposer.cxx |2 +-
editeng/source/editeng/impedit4.cxx|1 -
2 files changed, 1 insertion(+), 2 deletions(-)
New commits:
commit db15e9290e8e966edc83393c2abc793bcd954193
Author: Caolán McNamara
Date: Sun Jan 25 14:03:56 2015 +
coverity#1266514 Useless call
Change-Id: I2a95e2faa7682934cd69264c82ed2618225be2a7
diff --git a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
index f8f8c2b..f4b765b 100644
--- a/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
+++ b/dbaccess/source/core/api/SingleSelectQueryComposer.cxx
@@ -1660,7 +1660,7 @@ void OSingleSelectQueryComposer::setConditionByColumn(
const Reference< XPropert
const sal_Int8* pEnd= pBegin + aSeq.getLength();
for(;pBegin != pEnd;++pBegin)
{
-aSQL.append( (sal_Int32)*pBegin, 16 ).getStr();
+aSQL.append( (sal_Int32)*pBegin, 16 );
}
if(nSearchable == ColumnSearch::CHAR)
aSQL.append( "\'" );
commit f2a817edb0f31f65111544b57ee1bccc1a8d60a3
Author: Caolán McNamara
Date: Sun Jan 25 14:01:55 2015 +
coverity#1266515 Useless call
Change-Id: I554ca2a961a9ba6009bef23067febe8611ba1f80
diff --git a/editeng/source/editeng/impedit4.cxx
b/editeng/source/editeng/impedit4.cxx
index d721ca3..667a969 100644
--- a/editeng/source/editeng/impedit4.cxx
+++ b/editeng/source/editeng/impedit4.cxx
@@ -1918,7 +1918,6 @@ void ImpEditEngine::StartSpelling(EditView& rEditView,
bool bMultipleDoc)
Reference< XSpellAlternatives > ImpEditEngine::ImpFindNextError(EditSelection&
rSelection)
{
-aEditDoc.GetObject( (aEditDoc.Count()-1) );
EditSelection aCurSel( rSelection.Min() );
OUString aWord;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/tocread.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 18b290370da6d3256eb027985345781e42889397 Author: Caolán McNamara Date: Sun Jan 25 14:00:38 2015 + coverity#1266516 Useless call Change-Id: Icbf0e6ff8bad7e83c596f4e18003a06ba361b5eb diff --git a/lotuswordpro/source/filter/tocread.cxx b/lotuswordpro/source/filter/tocread.cxx index fe45eb0..135281a 100644 --- a/lotuswordpro/source/filter/tocread.cxx +++ b/lotuswordpro/source/filter/tocread.cxx @@ -124,7 +124,7 @@ CBenTOCReader::ReadLabel(unsigned long * pTOCOffset, unsigned long * pTOCSize) return BenErr_UnknownBentoFormatVersion; pCurrLabel += 2; -UtGetIntelWord(pCurrLabel); pCurrLabel += 2;// Minor version +pCurrLabel += 2;// Minor version *pTOCOffset = UtGetIntelDWord(pCurrLabel); pCurrLabel += 4; *pTOCSize = UtGetIntelDWord(pCurrLabel); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/filter/RtfFilter.cxx | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
New commits:
commit e60a54c717bf89c8905fcbce6d244a05532f5034
Author: Miklos Vajna
Date: Sun Jan 25 13:55:08 2015 +0100
Use std::initializer_list ctor
Change-Id: I5ce7b48a3c867fe8c5fdbe0f6fc8e3f33e457082
Reviewed-on: https://gerrit.libreoffice.org/14169
Reviewed-by: Miklos Vajna
Tested-by: Miklos Vajna
diff --git a/writerfilter/source/filter/RtfFilter.cxx
b/writerfilter/source/filter/RtfFilter.cxx
index d737394..b2de8d8 100644
--- a/writerfilter/source/filter/RtfFilter.cxx
+++ b/writerfilter/source/filter/RtfFilter.cxx
@@ -167,12 +167,13 @@ OUString RtfFilter_getImplementationName()
throw(uno::RuntimeException)
return OUString("com.sun.star.comp.Writer.RtfFilter");
}
-uno::Sequence< OUString > RtfFilter_getSupportedServiceNames()
throw(uno::RuntimeException)
+uno::Sequence RtfFilter_getSupportedServiceNames()
throw(uno::RuntimeException)
{
-uno::Sequence < OUString > aRet(2);
-OUString* pArray = aRet.getArray();
-pArray[0] = "com.sun.star.document.ImportFilter";
-pArray[1] = "com.sun.star.document.ExportFilter";
+uno::Sequence aRet =
+{
+OUString("com.sun.star.document.ImportFilter"),
+OUString("com.sun.star.document.ExportFilter")
+};
return aRet;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
70 new defect(s) introduced to LibreOffice found with Coverity Scan.
503 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 70 defect(s)
** CID 440858: Argument cannot be negative (NEGATIVE_RETURNS)
/svtools/source/brwbox/brwbox1.cxx: 310 in BrowseBox::ToggleSelectedColumn()()
** CID 703982: Unchecked return value (CHECKED_RETURN)
/sc/source/core/data/table2.cxx: 2758 in ScTable::SetRowHeightRange(int, int,
unsigned short, double, double)()
** CID 704680: Dereference after null check (FORWARD_NULL)
/sc/source/filter/excel/xeformula.cxx: 591 in
XclExpFmlaCompImpl::Init(XclFormulaType, const ScTokenArray &, const ScAddress
*, std::vector> *)()
** CID 735323: Unchecked return value (CHECKED_RETURN)
/sd/source/filter/eppt/eppt.cxx: 394 in
PPTWriter::ImplWriteSlideMaster(unsigned int,
com::sun::star::uno::Reference)()
** CID 982431: Division or modulo by float zero (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned
short)()
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned
short)()
** CID 982432: Division or modulo by float zero (DIVIDE_BY_ZERO)
/vcl/source/filter/wmf/winwmf.cxx: 233 in WMFReader::ReadRecordParams(unsigned
short)()
/vcl/source/filter/wmf/winwmf.cxx: 253 in WMFReader::ReadRecordParams(unsigned
short)()
** CID 984091: Uninitialized scalar field (UNINIT_CTOR)
/filter/source/msfilter/msdffimp.cxx: 5562 in
SvxMSDffManager::SvxMSDffManager(SvStream &, const rtl::OUString &, unsigned
int, SvStream *, SdrModel *, long, unsigned int, unsigned long, SvStream *)()
** CID 1242859: Untrusted loop bound (TAINTED_SCALAR)
/vcl/source/gdi/regionband.cxx: 268 in RegionBand::load(SvStream &)()
** CID 1244944: Use of untrusted scalar value (TAINTED_SCALAR)
/vcl/source/gdi/cvtsvm.cxx: 404 in ImplReadExtendedPolyPolygonAction(SvStream
&, tools::PolyPolygon &)()
** CID 1244945: Untrusted value as argument (TAINTED_SCALAR)
** CID 1244946: Untrusted value as argument (TAINTED_SCALAR)
** CID 1266440: Unchecked return value (CHECKED_RETURN)
/svx/source/tbxctrls/Palette.cxx: 196 in
PaletteSOC::LoadColorSet(SvxColorValueSet &)()
** CID 1266441: Unchecked return value (CHECKED_RETURN)
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3837 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()
/sw/source/filter/ww8/rtfattributeoutput.cxx: 3853 in
RtfAttributeOutput::FlyFrameGraphic(const SwFlyFrmFmt *, const SwGrfNode *)()
** CID 1266442: Dereference after null check (FORWARD_NULL)
/sw/source/uibase/docvw/edtwin.cxx: 2976 in SwEditWin::MouseButtonDown(const
MouseEvent &)()
** CID 1266443: Dereference after null check (FORWARD_NULL)
/sw/source/core/layout/trvlfrm.cxx: 749 in lcl_UpDown(SwPaM *, const SwCntntFrm
*, const SwCntntFrm *(*)(const SwCntntFrm *), bool)()
** CID 1266444: Explicit null dereferenced (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1528 in WW8Export::TrueFrameBgBrush(const
SwFrmFmt &) const()
** CID 1266445: Explicit null dereferenced (FORWARD_NULL)
/cppuhelper/source/component_context.cxx: 747 in
cppu::ComponentContext::disposing()()
** CID 1266446: Explicit null dereferenced (FORWARD_NULL)
/sw/source/core/undo/unattr.cxx: 594 in
SwUndoFmtResetAttr::SwUndoFmtResetAttr(SwFmt &, unsigned short)()
** CID 1266447: Explicit null dereferenced (FORWARD_NULL)
/sw/source/filter/ww8/wrtw8nds.cxx: 1508 in WW8Export::GetCurrentPageBgBrush()
const()
** CID 1266448: Explicit null dereferenced (FORWARD_NULL)
/sc/source/filter/excel/xiescher.cxx: 243 in XclImpDrawObjBase::ReadObj4(const
XclImpRoot &, XclImpStream &)()
*** CID 440858: Argument cannot be negative (NEGATIVE_RETURNS)
/svtools/source/brwbox/brwbox1.cxx: 310 in BrowseBox::ToggleSelectedColumn()()
304 {
305 sal_uInt16 nSelectedColId = BROWSER_INVALIDID;
306 if ( pColSel && pColSel->GetSelectCount() )
307 {
308 DoHideCursor( "ToggleSelectedColumn" );
309 ToggleSelection();
>>> CID 440858: Argument cannot be negative (NEGATIVE_RETURNS)
>>> "this->pColSel->FirstSelected(false)" is passed to a parameter that
>>> cannot be negative. [Note: The source code implementation of the function
>>> has been overridden by a builtin model.]
310 nSelectedColId = (*pCols)[ pColSel->FirstSelected() ]->GetId();
311 pColSel->SelectAll(false);
312 }
313 return nSelectedColId;
314 }
315
*** CID 703982: Unchecked return value (CHECKED_RETURN)
/sc/source/core/da
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 --- Comment #36 from m.a.riosv --- Added https://bugs.documentfoundation.org/show_bug.cgi?id=88786 Sign result with a rest between a number and an array is changed. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 m.a.riosv changed: What|Removed |Added Depends on||88786 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
short term loans for unemplyed @ http://fastloansforunemployeds.co.uk
Once you get the moment funds, you'll utilize cash for several functions whether or not it should be for debt consolidation, getting of recent automotive, home improvement, tour expenses and plenty additional. In fact, imperative loans for unhealthy credit area unit nice money facilitate for all UN agency area unit residents folks. To understand additional concerning its loan quotes, you'll compare and search on-line from the net. As the name suggests, pressing loans for unhealthy credit square measure particularly crafted for unhealthy creditors UN agency need to avail fast money before they got monthly regular payment. If you're definitely in want of taking pressing money, you ought to select availing such loan. Such loan is today offered wide within the monetary market folks. So, it's straightforward for you to avail fast money from these loans. http://fastloansforunemployeds.co.uk loans for unemployed fast loans for unemployed -- View this message in context: http://nabble.documentfoundation.org/short-term-loans-for-unemplyed-http-fastloansforunemployeds-co-uk-tp4137384.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - chart2/source
chart2/source/view/charttypes/GL3DBarChart.cxx | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
New commits:
commit 8eef38d87d5a876b9628355289ab6ddf9915db89
Author: Caolán McNamara
Date: Fri Jan 23 15:02:31 2015 +
Resolves: fdo#88229 Crash when you try to create a bar chart GL3D
Change-Id: I6390f8988ca287de19e9981053bdeb9473d1e3e1
(cherry picked from commit 05e7b1db351ee964d155e49c55de7db3c917083f)
Reviewed-on: https://gerrit.libreoffice.org/14138
Tested-by: Markus Mohrhard
Reviewed-by: Markus Mohrhard
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx
b/chart2/source/view/charttypes/GL3DBarChart.cxx
index 7924e48..7d3159b 100755
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -650,8 +650,15 @@ void GL3DBarChart::create3DShapes(const
boost::ptr_vector& rDataSer
sal_Int32 nSeriesIndex = 0;
sal_Int32 nMaxPointCount = 0;
double nMaxVal = findMaxValue(rDataSeriesContainer)/100;
-const VDataSeries& rFirstRow = *(rDataSeriesContainer.begin());
-mnBarsInRow = rFirstRow.getTotalPointCount();
+if (rDataSeriesContainer.empty())
+{
+mnBarsInRow = 0;
+}
+else
+{
+const VDataSeries& rFirstRow = *(rDataSeriesContainer.begin());
+mnBarsInRow = rFirstRow.getTotalPointCount();
+}
for (boost::ptr_vector::const_iterator itr =
rDataSeriesContainer.begin(),
itrEnd = rDataSeriesContainer.end(); itr != itrEnd; ++itr)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 4 commits - sw/inc sw/source
sw/inc/docary.hxx |1 +
sw/source/core/doc/docbasic.cxx |4 ++--
sw/source/core/doc/docbm.cxx|2 +-
sw/source/core/doc/docchart.cxx | 16
sw/source/core/doc/doccomp.cxx | 11 +--
sw/source/core/doc/docglos.cxx |4 ++--
6 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 802b80fcd378d5788adff1c7c98af526651a30c2
Author: Matteo Casalin
Date: Sun Jan 25 01:31:20 2015 +0100
Retrieve sub-OUStrings without unnecessary copying
Change-Id: I1aaaef4bf81f5b56fe71ca0aae59b59dbd0dee59
diff --git a/sw/source/core/doc/docchart.cxx b/sw/source/core/doc/docchart.cxx
index bbe92a0..426fd56 100644
--- a/sw/source/core/doc/docchart.cxx
+++ b/sw/source/core/doc/docchart.cxx
@@ -51,16 +51,16 @@ bool SwTable::IsTblComplexForChart( const OUString&
rSelection ) const
const SwTableBox* pSttBox, *pEndBox;
if( 2 < rSelection.getLength() )
{
-// Remove brackets at the beginning and from the end
-OUString sBox( rSelection );
-if( '<' == sBox[0] ) sBox = sBox.copy( 1 );
-if( '>' == sBox[ sBox.getLength()-1 ] ) sBox = sBox.copy( 0,
sBox.getLength()-1 );
-
-sal_Int32 nSeparator = sBox.indexOf( ':' );
+const sal_Int32 nSeparator {rSelection.indexOf( ':' )};
OSL_ENSURE( -1 != nSeparator, "no valid selection" );
-pSttBox = GetTblBox( sBox.copy( 0, nSeparator ));
-pEndBox = GetTblBox( sBox.copy( nSeparator+1 ));
+// Remove brackets at the beginning and from the end
+const sal_Int32 nOffset {'<' == rSelection[0] ? 1 : 0};
+const sal_Int32 nLength {'>' == rSelection[ rSelection.getLength()-1 ]
+? rSelection.getLength()-1 : rSelection.getLength()};
+
+pSttBox = GetTblBox(rSelection.copy( nOffset, nSeparator - nOffset ));
+pEndBox = GetTblBox(rSelection.copy( nSeparator+1, nLength -
(nSeparator+1) ));
}
else
{
commit 834f711841f0d7a29b23eac47267c6ad852f395e
Author: Matteo Casalin
Date: Sun Jan 25 01:03:12 2015 +0100
Fix selection handling in SwTable::IsTblComplexForChart
Change-Id: I5f35a705316db164474c64ea99ee4e4eada57d49
diff --git a/sw/source/core/doc/docchart.cxx b/sw/source/core/doc/docchart.cxx
index 669fa78..bbe92a0 100644
--- a/sw/source/core/doc/docchart.cxx
+++ b/sw/source/core/doc/docchart.cxx
@@ -53,7 +53,7 @@ bool SwTable::IsTblComplexForChart( const OUString&
rSelection ) const
{
// Remove brackets at the beginning and from the end
OUString sBox( rSelection );
-if( '<' == sBox[0] ) sBox = sBox.copy( 0, 1 );
+if( '<' == sBox[0] ) sBox = sBox.copy( 1 );
if( '>' == sBox[ sBox.getLength()-1 ] ) sBox = sBox.copy( 0,
sBox.getLength()-1 );
sal_Int32 nSeparator = sBox.indexOf( ':' );
commit 0019a535f27e666fba98bc37d8d672544d40c526
Author: Matteo Casalin
Date: Sun Jan 25 00:56:38 2015 +0100
Use more proper integer types
Change-Id: I0c0eceb46738af44e527cbda48e62f4ca75e069d
diff --git a/sw/inc/docary.hxx b/sw/inc/docary.hxx
index 4f40a22..fba92fb 100644
--- a/sw/inc/docary.hxx
+++ b/sw/inc/docary.hxx
@@ -229,6 +229,7 @@ public:
using _SwRedlineTbl::begin;
using _SwRedlineTbl::end;
using _SwRedlineTbl::size;
+using _SwRedlineTbl::size_type;
using _SwRedlineTbl::operator[];
using _SwRedlineTbl::empty;
};
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index fd3f601..b3272a5 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1369,7 +1369,7 @@ void _DelBookmarks(
// which holds all position information as offset.
// Assignement happens after moving.
SwRedlineTbl& rTbl = pDoc->getIDocumentRedlineAccess().GetRedlineTbl();
-for(sal_uInt16 nCnt = 0; nCnt < rTbl.size(); ++nCnt )
+for(SwRedlineTbl::size_type nCnt = 0; nCnt < rTbl.size(); ++nCnt )
{
// Is at position?
SwRangeRedline* pRedl = rTbl[ nCnt ];
diff --git a/sw/source/core/doc/doccomp.cxx b/sw/source/core/doc/doccomp.cxx
index 91ab8d0..61f207f 100644
--- a/sw/source/core/doc/doccomp.cxx
+++ b/sw/source/core/doc/doccomp.cxx
@@ -624,16 +624,15 @@ void Compare::CountDifference( const CompareData& rData,
sal_uLong* pCounts )
void Compare::SetDiscard( const CompareData& rData,
sal_Char* pDiscard, sal_uLong* pCounts )
{
-sal_uLong nLen = rData.GetLineCount();
+const sal_uLong nLen = rData.GetLineCount();
// calculate Max with respect to the line count
-sal_uInt16 nMax = 5;
-sal_uLong n;
+sal_uLong nMax = 5;
-for( n = nLen / 64; ( n = n >> 2 ) > 0; )
+for( sal_uLong n = nLen / 64; ( n = n >> 2 ) > 0; )
nMax <<= 1;
-for( n = 0; n < nLen; ++n )
+for( sal_uLong n = 0; n < nLen; ++n )
{
sal_uLong nIdx = rData.GetIndex( n );
if( nIdx )
@@ -2077,7 +2076,7 @@ long SwDoc::MergeDoc( const SwDoc& rDoc )
const
[Libreoffice-commits] core.git: Branch 'libreoffice-4-3' - sc/source
sc/source/ui/cctrl/checklistmenu.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit e56e924d2d7b683049d2c6820e92ef14933a75ef
Author: Caolán McNamara
Date: Sat Jan 24 20:37:36 2015 +
Resolves: tdf#81124 crash on setting autofilter on column with no content
Change-Id: Id53e589789144d892427a8a4ec1af1926aa97b52
(cherry picked from commit 3a5fa612b4afb72b5f91877a5c52e25c7604ae1a)
Reviewed-on: https://gerrit.libreoffice.org/14159
Tested-by: Markus Mohrhard
Reviewed-by: Markus Mohrhard
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 1b05eff..51166aa 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1091,6 +1091,8 @@ void ScCheckListMenuWindow::selectCurrentMemberOnly(bool
bSet)
{
setAllMemberState(!bSet);
SvTreeListEntry* pEntry = maChecks.GetCurEntry();
+if (!pEntry)
+return;
maChecks.CheckEntry(pEntry, bSet );
}
@@ -1486,7 +1488,6 @@ void ScCheckListBox::KeyInput( const KeyEvent& rKEvt )
if ( rKey.GetCode() == KEY_RETURN || rKey.GetCode() == KEY_SPACE )
{
SvTreeListEntry* pEntry = GetCurEntry();
-
if ( pEntry )
{
bool bCheck = ( GetCheckButtonState( pEntry ) == SV_BUTTON_CHECKED
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/ui/cctrl/checklistmenu.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 62f66fabadc80c5466aeedb61b373cf1dd5e4133
Author: Caolán McNamara
Date: Sat Jan 24 20:37:36 2015 +
Resolves: tdf#81124 crash on setting autofilter on column with no content
Change-Id: Id53e589789144d892427a8a4ec1af1926aa97b52
(cherry picked from commit 3a5fa612b4afb72b5f91877a5c52e25c7604ae1a)
Reviewed-on: https://gerrit.libreoffice.org/14158
Tested-by: Markus Mohrhard
Reviewed-by: Markus Mohrhard
diff --git a/sc/source/ui/cctrl/checklistmenu.cxx
b/sc/source/ui/cctrl/checklistmenu.cxx
index 9fbcd2c..3db1622 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -1066,6 +1066,8 @@ void ScCheckListMenuWindow::selectCurrentMemberOnly(bool
bSet)
{
setAllMemberState(!bSet);
SvTreeListEntry* pEntry = maChecks.GetCurEntry();
+if (!pEntry)
+return;
maChecks.CheckEntry(pEntry, bSet );
}
@@ -1461,7 +1463,6 @@ void ScCheckListBox::KeyInput( const KeyEvent& rKEvt )
if ( rKey.GetCode() == KEY_RETURN || rKey.GetCode() == KEY_SPACE )
{
SvTreeListEntry* pEntry = GetCurEntry();
-
if ( pEntry )
{
bool bCheck = ( GetCheckButtonState( pEntry ) == SV_BUTTON_CHECKED
);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [libreoffice-website] [LibreOffice Bugzilla Migration] We're done! Please visit the new site to reset your password!
Hi, Robinson Tryon wrote on 2015-01-24 at 21:50: The migration was a great success. All of our bugs are now happily living at https://bugs.documentfoundation.org/ thanks a lot to everyone involved, especially Robinson, Cloph and Alex - great work, and happy to finally have BugZilla in our own infrastructure! Thanks for the extra work during the weekend, you rock! ;-) Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
