LibreOffice Gerrit News for core on 2015-02-02
Moin! * Open changes on master for project core changed in the last 25 hours: + tdf#87309: SVG - use black as default currentColor if no color was specif in https://gerrit.libreoffice.org/14242 from Christina Roßmanith about module svgio + fdo#47577 Zoom slider should only react to full click in https://gerrit.libreoffice.org/14265 from Rodolfo Ribeiro Gomes about module include, svx + move test file to workdir to avoid overwriting in https://gerrit.libreoffice.org/14272 from Markus Mohrhard about module dbaccess, unotest * Merged changes on master for project core changed in the last 25 hours: + sw::mark::MarkManager: make it possible to generate a default ctor in https://gerrit.libreoffice.org/14269 from Miklos Vajna * Abandoned changes on master for project core changed in the last 25 hours: None * Open changes needing tweaks, but being untouched for more than a week: + wip: get rid of svx dbtoolsclient in https://gerrit.libreoffice.org/11737 from Lionel Elie Mamane + fdo#86606 removal of direct formatting options from the context menu in https://gerrit.libreoffice.org/13196 from Yousuf Philips + Fix typo code Persistant in https://gerrit.libreoffice.org/14030 from Andrea Gelmini + fdo#88309: Standardize, cleanup, and improve Assertions in https://gerrit.libreoffice.org/13945 from Ashod Nakashian + --with-macosx-app-name= is unused, so bin it from AC_ARG_WITH list in https://gerrit.libreoffice.org/13658 from Douglas Mencken + fdo#30541: Default icon set on Windows should be Galaxy, not Tango. in https://gerrit.libreoffice.org/13859 from Rimas Kudelis + fdo#63905: fix regression by using paper size set in printer properties in https://gerrit.libreoffice.org/13763 from Clément Lassieur + fdo#75825-"Send Document as E-Mail" not working in https://gerrit.libreoffice.org/13786 from Charu Tyagi + solenv-filelists.pm: fix "can't call method `mode' on an undefined value" in https://gerrit.libreoffice.org/13669 from Douglas Mencken + gbuild-to-ide fixes in https://gerrit.libreoffice.org/11754 from Peter Foley + fdo#82335. in https://gerrit.libreoffice.org/11555 from Sudarshan Rao + fdo#39625 Make existing CppUnittests work in https://gerrit.libreoffice.org/11605 from Tobias Madl + fdo#86784 make soffice commandline in juh Bootstrap.bootstrap() configura in https://gerrit.libreoffice.org/13290 from Christoph Lutz + start detection of kf5 stuff in configure.ac in https://gerrit.libreoffice.org/13079 from Jonathan Riddell + more breeze icons in https://gerrit.libreoffice.org/13058 from Jonathan Riddell + Perftest for loading autocorrect dictionaries, related fdo#79761 in https://gerrit.libreoffice.org/11296 from Matúš Kukan Best, Your friendly LibreOffice Gerrit Digest Mailer Note: The bot generating this message can be found and improved here: https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 V Stuart Foote changed: What|Removed |Added Depends on||88935 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 m.a.riosv changed: What|Removed |Added Depends on|89012 | --- Comment #39 from m.a.riosv --- Added https://bugs.documentfoundation.org/show_bug.cgi?id=89012 LibreOffice hangs "Create Report in Design View" in base. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 79641] LibreOffice 4.4 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=79641 m.a.riosv changed: What|Removed |Added Depends on||89012 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 12 commits - basctl/source editeng/source filter/source framework/source include/editeng offapi/com sfx2/source svtools/source unusedcode.easy vcl/source vcl/unx xmloff
basctl/source/dlged/dlgedobj.cxx|2 -
basctl/source/inc/dlgedobj.hxx |2 -
editeng/source/accessibility/AccessibleEditableTextPara.cxx |3 +
filter/source/config/cache/filtercache.cxx |2 -
framework/source/accelerators/acceleratorconfiguration.cxx | 13
framework/source/inc/accelerators/acceleratorconfiguration.hxx | 12 +++
include/editeng/AccessibleEditableTextPara.hxx |2 -
offapi/com/sun/star/accessibility/XAccessibleTextAttributes.idl |3 +
offapi/com/sun/star/ui/XAcceleratorConfiguration.idl|6 ++-
sfx2/source/doc/objstor.cxx |3 -
svtools/source/contnr/treelist.cxx |4 +-
unusedcode.easy | 16
--
vcl/source/opengl/OpenGLHelper.cxx |2 -
vcl/unx/kde4/KDESalGraphics.cxx |2 -
xmloff/source/forms/elementimport.cxx |6 +++
xmloff/source/forms/elementimport.hxx |1
16 files changed, 49 insertions(+), 30 deletions(-)
New commits:
commit f2ae6d2053256e1917104f1c44485099966155be
Author: Tsutomu Uchino
Date: Sat Jan 31 07:26:19 2015 +
Resolves: #i114416# use default service name for scroll bar...
if failed to detect the control-implementation
(cherry picked from commit 23e16b91ad69a123e795d63f2d4862d94412d582)
Conflicts:
xmloff/source/forms/elementimport.cxx
xmloff/source/forms/elementimport.hxx
Change-Id: I0ab4f9ff909ceba18a74d38488f6d0bdb3126110
diff --git a/xmloff/source/forms/elementimport.cxx
b/xmloff/source/forms/elementimport.cxx
index 4f50177..608fcb5 100644
--- a/xmloff/source/forms/elementimport.cxx
+++ b/xmloff/source/forms/elementimport.cxx
@@ -683,6 +683,7 @@ namespace xmloff
case OControlElement::IMAGE_FRAME: pServiceName =
"com.sun.star.form.component.DatabaseImageControl"; break;
case OControlElement::HIDDEN:pServiceName =
"com.sun.star.form.component.HiddenControl"; break;
case OControlElement::GRID: pServiceName =
"com.sun.star.form.component.GridControl"; break;
+case OControlElement::VALUERANGE:pServiceName =
"com.sun.star.form.component.ScrollBar"; break;
case OControlElement::TIME: pServiceName =
"com.sun.star.form.component.TimeField"; break;
case OControlElement::DATE: pServiceName =
"com.sun.star.form.component.DateField"; break;
default: break;
@@ -2112,6 +2113,11 @@ namespace xmloff
}
}
+OUString OFormImport::determineDefaultServiceName() const
+{
+return OUString("com.sun.star.form.component.Form");
+}
+
} // namespace xmloff
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/xmloff/source/forms/elementimport.hxx
b/xmloff/source/forms/elementimport.hxx
index 4d2592a..230ff6d 100644
--- a/xmloff/source/forms/elementimport.hxx
+++ b/xmloff/source/forms/elementimport.hxx
@@ -695,6 +695,7 @@ namespace xmloff
sal_uInt16 _nPrefix, const OUString& _rLocalName,
OControlElement::ElementType _eType );
+virtual OUString determineDefaultServiceName() const SAL_OVERRIDE;
void implTranslateStringListProperty(const OUString& _rPropertyName,
const OUString& _rValue);
};
commit e112dc0df7344e98414f64e70ddb7f764790bd06
Author: Caolán McNamara
Date: Sun Feb 1 09:06:30 2015 +
callcatcher: yet more unused code
Change-Id: I75b8cdffd965c6d99fd3693a6297c023279df76e
diff --git a/unusedcode.easy b/unusedcode.easy
index 51eea3a..fed4585 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -2,8 +2,6 @@ BigInt::BigInt(unsigned int)
CalendarWrapper::getDSTOffsetInMillis() const
CalendarWrapper::getZoneOffsetInMillis() const
FontCharMap::GetDefaultMap(bool)
-Interceptor::addEventListener(com::sun::star::uno::Reference
const&)
-Interceptor::removeEventListener(com::sun::star::uno::Reference
const&)
LineListBox::Clear()
LineListBox::InsertEntry(rtl::OUString const&, int)
LineListBox::RemoveEntry(int)
@@ -62,10 +60,12 @@ ScUserListItem::GetValueText() const
ScVbaFormat::getAddIndent()
ScVbaFormat::setAddIndent(com::sun::star::uno::Any
const&)
ScViewObjectModeItem::GetValueText(unsigned short) const
+SdrUndoObjList::SetOrdNum(unsigned int)
SecurityEnvironment_NssImpl::getCertificate(rtl::OUString const&,
rtl::OUString const&)
SfxAppMenuControl_Impl::RegisterControl(unsigned short, SfxModule*)
SfxBoolItem::GetValueCount() const
SfxFrameItem::GetValueText() const
+SfxObjectShell::DdeExecute(rtl::OUString const&)
SfxObjectShellItem::GetValueText() const
SfxProgress::SetText(rtl::OUString const&)
SfxTemplat
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/core/api/Section.cxx | 15 ---
1 file changed, 15 deletions(-)
New commits:
commit c97dbb56596eecd19d73a0adb49f9de1ee279e14
Author: Stephan Bergmann
Date: Sun Feb 1 22:06:32 2015 +0100
loplugin:unreffun
Change-Id: I32479fd238e720b9ba0fa0af55e8377ebd972a20
diff --git a/reportdesign/source/core/api/Section.cxx
b/reportdesign/source/core/api/Section.cxx
index d25f0e2d..cec1429 100644
--- a/reportdesign/source/core/api/Section.cxx
+++ b/reportdesign/source/core/api/Section.cxx
@@ -422,21 +422,6 @@ uno::Reference< report::XReportDefinition > SAL_CALL
OSection::getReportDefiniti
return xRet;
}
-const ::std::vector< OUString >& lcl_getControlModelMap()
-{
-static ::std::vector< OUString > s_sControlModels;
-if ( s_sControlModels.empty() )
-{
-s_sControlModels.push_back( OUString("FixedText") );
-s_sControlModels.push_back( OUString("FixedLine") );
-s_sControlModels.push_back( OUString("ImageControl") );
-s_sControlModels.push_back( OUString("FormattedField") );
-s_sControlModels.push_back( OUString("Shape") );
-}
-return s_sControlModels;
-
-}
-
// XChild
uno::Reference< uno::XInterface > SAL_CALL OSection::getParent( ) throw
(uno::RuntimeException, std::exception)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svx/source
svx/source/accessibility/AccessibleTextHelper.cxx | 20
1 file changed, 20 deletions(-)
New commits:
commit 36b74a58d6e4483895f5ba4eb0334e2b44c27f16
Author: Stephan Bergmann
Date: Sun Feb 1 21:09:49 2015 +0100
loplugin:unreffun
Change-Id: I25213abc84c3e512fa620aa7c08e0c2e1bc0159a
diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx
b/svx/source/accessibility/AccessibleTextHelper.cxx
index 9b4f556..2331d84 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++ b/svx/source/accessibility/AccessibleTextHelper.cxx
@@ -118,10 +118,6 @@ namespace accessibility
{
mxFrontEnd = rInterface;
}
-uno::Reference< XAccessible > GetEventSource() const
-{
-return mxFrontEnd;
-}
void SetOffset( const Point& );
Point GetOffset() const
@@ -141,8 +137,6 @@ namespace accessibility
void SetAdditionalChildStates( const VectorOfStates& rChildStates );
-bool IsSelected() const;
-
void Dispose();
// do NOT hold object mutex when calling this! Danger of deadlock
@@ -350,20 +344,6 @@ namespace accessibility
throw
uno::RuntimeException("AccessibleTextHelper_Impl::GetEditSource: no edit
source", mxFrontEnd );
}
-bool AccessibleTextHelper_Impl::IsSelected() const
-{
-bool bRet = false;
-
-try
-{
-ESelection aSelection;
-bRet = GetEditViewForwarder().GetSelection( aSelection );
-}
-catch( const uno::Exception& ) {}
-
-return bRet;
-}
-
// functor for sending child events (no stand-alone function, they are
maybe not inlined)
class AccessibleTextHelper_OffsetChildIndex : public
::std::unary_function< ::accessibility::AccessibleEditableTextPara&, void >
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: editeng/source
editeng/source/accessibility/AccessibleStaticTextBase.cxx | 12
1 file changed, 12 deletions(-)
New commits:
commit bf5bb7c5b9da1231d4435a00432e1893d6771a0f
Author: Stephan Bergmann
Date: Sun Feb 1 20:52:11 2015 +0100
loplugin:unreffun
Change-Id: Icfef034a7838e0a7139d3802491cff3b77fd5d9e
diff --git a/editeng/source/accessibility/AccessibleStaticTextBase.cxx
b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
index a149799..8d97b0e 100644
--- a/editeng/source/accessibility/AccessibleStaticTextBase.cxx
+++ b/editeng/source/accessibility/AccessibleStaticTextBase.cxx
@@ -120,12 +120,6 @@ namespace accessibility
AccessibleStaticTextBase_Impl();
~AccessibleStaticTextBase_Impl();
-SvxEditSourceAdapter& GetEditSource() const
-{
-
-return maEditSource;
-}
-
void SetEditSource( ::std::unique_ptr< SvxEditSource > && pEditSource
);
void SetEventSource( const uno::Reference< XAccessible >& rInterface )
@@ -135,12 +129,6 @@ namespace accessibility
}
void SetOffset( const Point& );
-Point GetOffset() const
-{
-
-::osl::MutexGuard aGuard( maMutex ); Point aPoint( maOffset );
-return aPoint;
-}
void UpdateChildren();
void Dispose();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: svl/source
svl/source/misc/strmadpt.cxx | 22 --
1 file changed, 22 deletions(-)
New commits:
commit e54b974033ea68101014f280061b06cd82256412
Author: Stephan Bergmann
Date: Sun Feb 1 20:39:29 2015 +0100
loplugin:unreffun
Change-Id: Iaf75d9570c2091365a16e13119e4515957a86551
diff --git a/svl/source/misc/strmadpt.cxx b/svl/source/misc/strmadpt.cxx
index 241a031..df8b901 100644
--- a/svl/source/misc/strmadpt.cxx
+++ b/svl/source/misc/strmadpt.cxx
@@ -90,9 +90,6 @@ public:
inline bool isEOF() const;
-bool addMark(sal_uInt32 nPosition);
-bool removeMark(sal_uInt32 nPosition);
-
SeekResult setReadPosition(sal_uInt32 nPosition);
};
@@ -745,25 +742,6 @@ sal_uInt32 SvDataPipe_Impl::write(sal_Int8 const *
pBuffer, sal_uInt32 nSize)
return nSize - nRemain;
}
-bool SvDataPipe_Impl::addMark(sal_uInt32 nPosition)
-{
-if (m_pFirstPage != 0 && m_pFirstPage->m_nOffset > nPosition)
-return false;
-m_aMarks.insert(nPosition);
-return true;
-}
-
-bool SvDataPipe_Impl::removeMark(sal_uInt32 nPosition)
-{
-std::multiset< sal_uInt32 >::iterator t = m_aMarks.find(nPosition);
-if (t == m_aMarks.end())
-return false;
-m_aMarks.erase(t);
-// coverity[pass_freed_arg] - remove frees m_pFirstPage but then sets
m_pFirstPage to something else
-while (remove(m_pFirstPage)) ;
-return true;
-}
-
SvDataPipe_Impl::SeekResult SvDataPipe_Impl::setReadPosition(sal_uInt32
nPosition)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/get-bugzilla-attachments-by-mimetype
bin/get-bugzilla-attachments-by-mimetype |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit ca5479fb576060f2703c09206d78d9ae6f537af8
Author: David Tardon
Date: Sun Feb 1 19:00:55 2015 +0100
add space
Change-Id: I1ec18ded65b3359b71d97a733aab7f8b2a27e699
diff --git a/bin/get-bugzilla-attachments-by-mimetype
b/bin/get-bugzilla-attachments-by-mimetype
index 905ab5b..53108e2 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -508,7 +508,7 @@ def generate_multi_threading():
try:
jobs.put([uri, mimetype, prefix, extension], block=True,
timeout=3)
-print("successfully placed a job in the queue searching for "
+ mimetype + "in bugtracker " + prefix)
+print("successfully placed a job in the queue searching for "
+ mimetype + " in bugtracker " + prefix)
except KeyboardInterrupt:
raise # Ctrl+C should work
except:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/svl svl/source sw/source
include/svl/undo.hxx|2 ++
svl/source/undo/undo.cxx| 11 +++
sw/source/core/docnode/nodedump.cxx | 13 -
sw/source/core/inc/UndoManager.hxx |2 --
4 files changed, 13 insertions(+), 15 deletions(-)
New commits:
commit 6b07a6eedb7260f1cdf375884f1329b72c892828
Author: Miklos Vajna
Date: Sun Feb 1 18:44:34 2015 +0100
Extract SfxUndoManager::dumpAsXml() from sw
Change-Id: Ic031b63641e0fd0fbd1524657082188d9ce78fcf
diff --git a/include/svl/undo.hxx b/include/svl/undo.hxx
index 2c19238..903bbc8 100644
--- a/include/svl/undo.hxx
+++ b/include/svl/undo.hxx
@@ -368,6 +368,8 @@ public:
*/
voidRemoveOldestUndoActions( size_t const i_count );
+void dumpAsXml(struct _xmlTextWriter* pWriter) const;
+
protected:
boolUndoWithContext( SfxUndoContext& i_context );
boolRedoWithContext( SfxUndoContext& i_context );
diff --git a/svl/source/undo/undo.cxx b/svl/source/undo/undo.cxx
index 1fcc649..a8f7c1d 100644
--- a/svl/source/undo/undo.cxx
+++ b/svl/source/undo/undo.cxx
@@ -1279,6 +1279,17 @@ void SfxUndoManager::RemoveOldestUndoActions( size_t
const i_count )
}
}
+void SfxUndoManager::dumpAsXml(xmlTextWriterPtr pWriter) const
+{
+xmlTextWriterStartElement(pWriter, BAD_CAST("sfxUndoManager"));
+xmlTextWriterWriteAttribute(pWriter, BAD_CAST("nUndoActionCount"),
BAD_CAST(OString::number(GetUndoActionCount()).getStr()));
+
+for (size_t i = 0; i < GetUndoActionCount(); ++i)
+GetUndoAction(i)->dumpAsXml(pWriter);
+
+xmlTextWriterEndElement(pWriter);
+}
+
struct SfxListUndoAction::Impl
{
sal_uInt16 mnId;
diff --git a/sw/source/core/docnode/nodedump.cxx
b/sw/source/core/docnode/nodedump.cxx
index 902c494..c9aa867 100644
--- a/sw/source/core/docnode/nodedump.cxx
+++ b/sw/source/core/docnode/nodedump.cxx
@@ -656,17 +656,4 @@ void SwExtraRedlineTbl::dumpAsXml( xmlTextWriterPtr w )
const
writer.endElement( );// swextraredlinetbl
}
-void sw::UndoManager::dumpAsXml(xmlTextWriterPtr w)
-{
-WriterHelper writer(w);
-
-writer.startElement("m_pUndoManager");
-writer.writeFormatAttribute("nUndoActionCount", TMP_FORMAT,
GetUndoActionCount());
-
-for (size_t i = 0; i < GetUndoActionCount(); ++i)
-GetUndoAction(i)->dumpAsXml(w);
-
-writer.endElement();
-}
-
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/core/inc/UndoManager.hxx
b/sw/source/core/inc/UndoManager.hxx
index 43c5995..934edc5 100644
--- a/sw/source/core/inc/UndoManager.hxx
+++ b/sw/source/core/inc/UndoManager.hxx
@@ -85,8 +85,6 @@ public:
SwNodes const& GetUndoNodes() const;
SwNodes & GetUndoNodes();
-void dumpAsXml(xmlTextWriterPtr w);
-
private:
IDocumentDrawModelAccess & m_rDrawModelAccess;
IDocumentRedlineAccess & m_rRedlineAccess;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - android/CustomTarget_lo_android.mk
android/CustomTarget_lo_android.mk | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) New commits: commit bfceafa67ed1cc3e4e03f8f214a2716f57b2d1e7 Author: Tor Lillqvist Date: Sun Feb 1 13:43:55 2015 +0100 Bin obsolete comments diff --git a/android/CustomTarget_lo_android.mk b/android/CustomTarget_lo_android.mk index 4d32cac..24225c0 100644 --- a/android/CustomTarget_lo_android.mk +++ b/android/CustomTarget_lo_android.mk @@ -13,18 +13,11 @@ loandroid3_DIR := $(call gb_CustomTarget_get_workdir,android/experimental/LOAndr $(call gb_CustomTarget_get_target,android/loandroid3) : \ $(loandroid3_DIR)/done -# We want that to be built completely first, -# so that we can serialize Ant access to Bootstrap, which is used both -# by DocumentLoader. We don't want one Ant to be cleaning -# out Bootstrap while another is building stuff that depends on it. -# Yeah, this sucks - $(loandroid3_DIR)/done : $(call gb_Postprocess_get_target,AllModulesButInstsetNative) $(call gb_Output_announce,$(subst $(WORKDIR)/,,$@),$(true),MAK,2) cd $(SRCDIR)/android/experimental/LOAndroid3 && $(MAKE) all # Copy to $(BUILDDIR)/instsetoo_native as that is where the tinderbox build script -# still looks for the .apk, and we want fresh daily builds to be uploaded. Even if -# the apps as such are mostly useless. +# still looks for the .apk, and we want fresh daily builds to be uploaded. # Us "foo" instead of the old INPATH mkdir -p $(BUILDDIR)/instsetoo_native/foo/bin; \ cp $(SRCDIR)/android/experimental/LOAndroid3/bin/*-debug.apk $(BUILDDIR)/instsetoo_native/foo/bin commit 1895fd2195ab11026e07271dbba71c0e963c0a3b Author: Tor Lillqvist Date: Sun Feb 1 13:41:48 2015 +0100 Copy only *-debug.apk We don't want the silly 'unaligned' apk to end up being uploaded. diff --git a/android/CustomTarget_lo_android.mk b/android/CustomTarget_lo_android.mk index 5ee53d4..4d32cac 100644 --- a/android/CustomTarget_lo_android.mk +++ b/android/CustomTarget_lo_android.mk @@ -27,7 +27,7 @@ $(loandroid3_DIR)/done : $(call gb_Postprocess_get_target,AllModulesButInstsetNa # the apps as such are mostly useless. # Us "foo" instead of the old INPATH mkdir -p $(BUILDDIR)/instsetoo_native/foo/bin; \ - cp $(SRCDIR)/android/experimental/LOAndroid3/bin/*.apk $(BUILDDIR)/instsetoo_native/foo/bin + cp $(SRCDIR)/android/experimental/LOAndroid3/bin/*-debug.apk $(BUILDDIR)/instsetoo_native/foo/bin $(call gb_CustomTarget_get_clean_target,android/loandroid3) : $(call gb_Output_announce,$(subst $(WORKDIR)/Clean/,,$@),$(false),MAK,2) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/image_rework' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/docbm.cxx | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
New commits:
commit 41465d9b7c978ce93aff9e3ff82ecfa83e90d64b
Author: Miklos Vajna
Date: Sun Feb 1 11:36:52 2015 +0100
sw::mark::MarkManager: make it possible to generate a default ctor
Should fix Windows werror build.
Change-Id: I9e71bc9042e86e3208cc23f804034957deeb0f81
Reviewed-on: https://gerrit.libreoffice.org/14269
Tested-by: Jenkins
Reviewed-by: Miklos Vajna
diff --git a/sw/source/core/doc/docbm.cxx b/sw/source/core/doc/docbm.cxx
index 0a3d27f..72fdf6d 100644
--- a/sw/source/core/doc/docbm.cxx
+++ b/sw/source/core/doc/docbm.cxx
@@ -1138,21 +1138,21 @@ void MarkManager::dumpAsXml(xmlTextWriterPtr pWriter)
const
struct
{
const char* pName;
-const container_t& rContainer;
+const container_t* pContainer;
} aContainers[] =
{
-{"bookmarks", m_vBookmarks},
-{"fieldmarks", m_vFieldmarks},
-{"annotationmarks", m_vAnnotationMarks}
+{"bookmarks", &m_vBookmarks},
+{"fieldmarks", &m_vFieldmarks},
+{"annotationmarks", &m_vAnnotationMarks}
};
xmlTextWriterStartElement(pWriter, BAD_CAST("markManager"));
for (size_t i = 0; i < SAL_N_ELEMENTS(aContainers); ++i)
{
-if (!aContainers[i].rContainer.empty())
+if (!aContainers[i].pContainer->empty())
{
xmlTextWriterStartElement(pWriter, BAD_CAST(aContainers[i].pName));
-for (const_iterator_t it = aContainers[i].rContainer.begin(); it
!= aContainers[i].rContainer.end(); ++it)
+for (const_iterator_t it = aContainers[i].pContainer->begin(); it
!= aContainers[i].pContainer->end(); ++it)
(*it)->dumpAsXml(pWriter);
xmlTextWriterEndElement(pWriter);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [libreoffice-projects] minutes of ESC call ...
Hi, Le 29/01/2015 17:06, Michael Meeks a écrit : [...] * GSoC (Cedric) + We need to have new ideas added to the wiki page: https://wiki.documentfoundation.org/Development/Gsoc/Ideas + sooner the better etc. preferably before FOSDEM: today / tomorrow. here are some ideas : if you think some might be interesting, tell me and I'll make some specs/ux design - writer : when you drag'n'drop several images in a document, all images are anchored at the same paragraph. If user wants each image to be bellow the previous, he has to do that manually (think about writing a user manual with lots of screenshots). --> Add something to allow user to select the anchor type (or better : some predefined layout) of the dropped images. "something" might be a floating/popup panel or a sidebar panel ? - calc : indicate sheet protection via something visual in the tab sheets. Maybe an icon beside the name inside each tab ? Maybe add an option to visually identify protected cells (dim protected cells or highlight editable cells) TBD : how/where to indicate if the whole document is protected ? - calc : - allow to easily call python/js/beanshell/.. functions from cell formula. just do "=MyPythonFunction()". It would allow to easily use scientific python libraries. - show a suggestion panel for functions, just bellow the edited cell (a kind of autocomplete, with infos about function, args...) - the suggestion panel may allow to create new functions (name and arguments) and then switch to macro editor ; default code would include useful comments (some how-to, building blocks, sample codes...) - the existing function wizard should list functions from all languages (python/js/beanshell/..). TBD : how to handle documentation of user-defined macros ? - macros : - reorganize dialogs (I made a quick proposal that would need further polishing) : https://wiki.documentfoundation.org/Design/Whiteboard/Macros_Dialogs#Proposal_by_Michel_R (but the iTunes-like selector is not consistent with the current macro editor) - replace the macro editor engine with scintilla (http://www.scintilla.org/) to allow to edit easily other languages (python/js/beanshell/..) ; writing a scintilla lexer for LOBasic should not be complicated. - general: reorganize "Insert" menu ex with writer : https://wiki.documentfoundation.org/User:Michelr#Writer_:_new_Insert_menu (A consequence is that OLE embedding needs to have some visual/UX bugs corrected : I'll file bugs asap) - writer/calc : transpose the current "table design" sidebar panel from impress to writer and calc. It would not answer the need for table styles, but it would replace existing obsolete autoformat dialog. For calc, it would modify selected cells. The "table design" panel could be slightly enhanced to handle some more options (change colors, text options...) - draw: when user selects multiple shapes, there is only one visual selection (a rect with 9 green handles) around all selected objets. The problem is that user doesn't know exactly which objects are selected. Change that to have each object selected, with their own blue handles. Hope this helps, Michel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: LibreOffice Gerrit News for core on 2015-02-01
Hi, On Sun, Feb 01, 2015 at 06:00:05AM -, ger...@libreoffice.org wrote: > First time contributors doing great things! > + fdo#39440: replace C-style cast's with static_cast > in https://gerrit.libreoffice.org/14268 from Juan Picca > about module basic This section seems to still contain fake entries, Juan is not a first-time contributor, e.g. 5573fd8cf991b62c405ec9a4b624ebaf28cb8894 is an earlier example. Who is the contact for the running instance with the ability to debug this? ;-) Thanks, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa sw/source writerfilter/source
sw/qa/extras/ooxmlexport/ooxmlexport.cxx |6 +++---
sw/source/core/unocore/unocrsrhelper.cxx | 10 +++---
writerfilter/source/dmapper/CellColorHandler.cxx | 12 +---
writerfilter/source/dmapper/PropertyIds.cxx |2 ++
writerfilter/source/dmapper/PropertyIds.hxx |2 ++
5 files changed, 23 insertions(+), 9 deletions(-)
New commits:
commit 24077b2d52ab3d0fd0db5afb25d8b94b62386e3e
Author: Miklos Vajna
Date: Sun Feb 1 00:11:21 2015 +0100
writerfilter: import paragraph color as fill attributes
In theory this is to be in sync with the ODF import. In practice the old
UNO property seems not to have a proper fallback to populate the doc
model with the fillattributes, so without this even if the import result
is visible, it would be lost on ODF export.
Additionally, this detected a bug in SwUnoCursorHelper::makeRedline(),
where paragraph format redline tried to use the map of a text portion
instead of a paragraph.
Change-Id: I026e38e1990ed2a460624a8d967a16ae3fb6c512
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
index 53a0b7e..1815242 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport.cxx
@@ -10,6 +10,7 @@
#include
#include
+#include
#include
#include
#include
@@ -631,9 +632,8 @@ DECLARE_OOXMLEXPORT_TEST(testEffectExtentMargin,
"effectextent-margin.docx")
DECLARE_OOXMLEXPORT_TEST(testTdf88583, "tdf88583.odt")
{
-if (xmlDocPtr pXmlDoc = parseExport())
-// had no child element, paragraph background was lost.
-assertXPath(pXmlDoc, "//w:pPr/w:shd", "fill", "00CC00");
+CPPUNIT_ASSERT_EQUAL(drawing::FillStyle_SOLID,
getProperty(getParagraph(1), "FillStyle"));
+CPPUNIT_ASSERT_EQUAL(static_cast(0x00cc00),
getProperty(getParagraph(1), "FillColor"));
}
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sw/source/core/unocore/unocrsrhelper.cxx
b/sw/source/core/unocore/unocrsrhelper.cxx
index 9432230..6f65383 100644
--- a/sw/source/core/unocore/unocrsrhelper.cxx
+++ b/sw/source/core/unocore/unocrsrhelper.cxx
@@ -1217,9 +1217,13 @@ void makeRedline( SwPaM& rPaM,
// Check if the value exists
if ( aRevertPropertiesValue >>= aRevertProperties )
{
-// sw/source/core/unocore/unoport.cxx#83 is where it's decided what
map gets used for a text portion
-// so it's PROPERTY_MAP_TEXTPORTION_EXTENSIONS, unless it's a redline
portion
-SfxItemPropertySet const& rPropSet =
(*aSwMapProvider.GetPropertySet(PROPERTY_MAP_TEXTPORTION_EXTENSIONS));
+int nMap = 0;
+// Make sure that paragraph format gets its own map, otherwise e.g.
fill attributes are not preserved.
+if (eType == nsRedlineType_t::REDLINE_PARAGRAPH_FORMAT)
+nMap = PROPERTY_MAP_PARAGRAPH;
+else
+nMap = PROPERTY_MAP_TEXTPORTION_EXTENSIONS;
+SfxItemPropertySet const& rPropSet =
(*aSwMapProvider.GetPropertySet(nMap));
// Check if there are any properties
if (aRevertProperties.getLength())
diff --git a/writerfilter/source/dmapper/CellColorHandler.cxx
b/writerfilter/source/dmapper/CellColorHandler.cxx
index 3c8b506..63e7ed4 100644
--- a/writerfilter/source/dmapper/CellColorHandler.cxx
+++ b/writerfilter/source/dmapper/CellColorHandler.cxx
@@ -21,6 +21,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -268,9 +269,14 @@ TablePropertyMapPtr CellColorHandler::getProperties()
pPropertyMap->Insert(PROP_CHAR_SHADING_VALUE, uno::makeAny(
nShadingPattern ));
}
-pPropertyMap->Insert( m_OutputFormat == Form ? PROP_BACK_COLOR
-: m_OutputFormat == Paragraph ? PROP_PARA_BACK_COLOR
-: PROP_CHAR_BACK_COLOR, uno::makeAny( nApplyColor ));
+if (m_OutputFormat == Paragraph)
+{
+pPropertyMap->Insert(PROP_FILL_STYLE,
uno::makeAny(drawing::FillStyle_SOLID));
+pPropertyMap->Insert(PROP_FILL_COLOR, uno::makeAny(nApplyColor));
+}
+else
+pPropertyMap->Insert( m_OutputFormat == Form ? PROP_BACK_COLOR
+: PROP_CHAR_BACK_COLOR, uno::makeAny( nApplyColor
));
createGrabBag("originalColor",
uno::makeAny(OUString::fromUtf8(msfilter::util::ConvertColor(nApplyColor,
true;
diff --git a/writerfilter/source/dmapper/PropertyIds.cxx
b/writerfilter/source/dmapper/PropertyIds.cxx
index 8d21989..f380c45 100644
--- a/writerfilter/source/dmapper/PropertyIds.cxx
+++ b/writerfilter/source/dmapper/PropertyIds.cxx
@@ -401,6 +401,8 @@ OUString PropertyNameSupplier::GetName( PropertyIds eId )
const
case PROP_ROW_CNF_STYLE: sName = "RowCnfStyle"; break;
case PROP_CELL_HIDE_MARK: sName = "CellHideMark"; break;
case PROP_FOLLOW_TEXT_FLOW: sName = "IsFollowingTextFlow"; break;
+case PROP_FILL_STYLE: sName = "FillStyle"; break;
+
