[Libreoffice-commits] core.git: 2 commits - canvas/source

2015-03-11 Thread Stephan Bergmann
 canvas/source/factory/canvasfactory.component |5 +-
 canvas/source/factory/cf_service.cxx  |   45 --
 2 files changed, 10 insertions(+), 40 deletions(-)

New commits:
commit 9c89ce00d79c107bd704fc83b5061bd8a9f54913
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Mar 11 15:56:06 2015 +0100

Clean up previous commit

Change-Id: Icd4703c1541fa82bbe76f44369434a12cb397a19

diff --git a/canvas/source/factory/canvasfactory.component 
b/canvas/source/factory/canvasfactory.component
index 91a0fa7..3f9cabf 100644
--- a/canvas/source/factory/canvasfactory.component
+++ b/canvas/source/factory/canvasfactory.component
@@ -18,7 +18,7 @@
  --
 
 component loader=com.sun.star.loader.SharedLibrary environment=@CPPU_ENV@
-prefix=canvasfactory xmlns=http://openoffice.org/2010/uno-components;
+xmlns=http://openoffice.org/2010/uno-components;
   implementation name=com.sun.star.comp.rendering.CanvasFactory
   
constructor=com_sun_star_comp_rendering_CanvasFactory_get_implementation
 service name=com.sun.star.rendering.CanvasFactory/
diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 2dd9754..3f3c24e 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -49,17 +49,6 @@ using namespace ::com::sun::star::uno;
 namespace
 {
 
-OUString SAL_CALL getImplName()
-{
-return OUString(com.sun.star.comp.rendering.CanvasFactory);
-}
-
-SequenceOUString SAL_CALL getSuppServices()
-{
-OUString name(com.sun.star.rendering.CanvasFactory);
-return SequenceOUString(name, 1);
-}
-
 class CanvasFactory
 : public ::cppu::WeakImplHelper3 lang::XServiceInfo,
   lang::XMultiComponentFactory,
@@ -229,7 +218,7 @@ CanvasFactory::~CanvasFactory()
 // XServiceInfo
 OUString CanvasFactory::getImplementationName() throw (RuntimeException, 
std::exception)
 {
-return getImplName();
+return OUString(com.sun.star.comp.rendering.CanvasFactory);
 }
 
 sal_Bool CanvasFactory::supportsService( OUString const  serviceName )
@@ -241,7 +230,8 @@ sal_Bool CanvasFactory::supportsService( OUString const  
serviceName )
 SequenceOUString CanvasFactory::getSupportedServiceNames()
 throw (RuntimeException, std::exception)
 {
-return getSuppServices();
+OUString name(com.sun.star.rendering.CanvasFactory);
+return SequenceOUString(name, 1);
 }
 
 // XMultiComponentFactory
commit ccd627d5105fc5157d4c65ab8abb903df01e5485
Author: Chris Sherlock chris.sherl...@collabora.com
Date:   Thu Mar 5 20:34:00 2015 +1100

canvas: use constructor syntax in canvas.component

Change-Id: I983307f7eeb5702c51ca2398e69c9c560c6e2435
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/canvas/source/factory/canvasfactory.component 
b/canvas/source/factory/canvasfactory.component
index 514f242..91a0fa7 100644
--- a/canvas/source/factory/canvasfactory.component
+++ b/canvas/source/factory/canvasfactory.component
@@ -19,7 +19,8 @@
 
 component loader=com.sun.star.loader.SharedLibrary environment=@CPPU_ENV@
 prefix=canvasfactory xmlns=http://openoffice.org/2010/uno-components;
-  implementation name=com.sun.star.comp.rendering.CanvasFactory
+  implementation name=com.sun.star.comp.rendering.CanvasFactory
+  
constructor=com_sun_star_comp_rendering_CanvasFactory_get_implementation
 service name=com.sun.star.rendering.CanvasFactory/
   /implementation
 /component
diff --git a/canvas/source/factory/cf_service.cxx 
b/canvas/source/factory/cf_service.cxx
index 6d413fd..2dd9754 100644
--- a/canvas/source/factory/cf_service.cxx
+++ b/canvas/source/factory/cf_service.cxx
@@ -226,12 +226,6 @@ CanvasFactory::~CanvasFactory()
 }
 
 
-ReferenceXInterface create( ReferenceXComponentContext const  xContext )
-{
-return static_cast ::cppu::OWeakObject * (
-new CanvasFactory( xContext ) );
-}
-
 // XServiceInfo
 OUString CanvasFactory::getImplementationName() throw (RuntimeException, 
std::exception)
 {
@@ -503,30 +497,15 @@ ReferenceXInterface 
CanvasFactory::createInstanceWithArguments(
 name, args, m_xContext );
 }
 
-const ::cppu::ImplementationEntry s_entries [] = {
-{
-create,
-getImplName,
-getSuppServices,
-::cppu::createSingleComponentFactory,
-0, 0
-},
-{ 0, 0, 0, 0, 0, 0 }
-};
-
 } // anon namespace
 
-extern C {
 
-SAL_DLLPUBLIC_EXPORT void * SAL_CALL canvasfactory_component_getFactory(
-sal_Char const * pImplName,
-void * pServiceManager,
-void * pRegistryKey )
+extern C SAL_DLLPUBLIC_EXPORT ::com::sun::star::uno::XInterface* SAL_CALL
+com_sun_star_comp_rendering_CanvasFactory_get_implementation(::com::sun::star::uno::XComponentContext*
 context,
+ 
::com::sun::star::uno::Sequencecss::uno::Any const )
 {
-return ::cppu::component_getFactoryHelper(
-pImplName, pServiceManager, 

[Libreoffice-commits] core.git: 2 commits - sw/source

2015-03-11 Thread Caolán McNamara
 sw/source/uibase/dbui/dbmgr.cxx |   66 
 1 file changed, 33 insertions(+), 33 deletions(-)

New commits:
commit bcf3897db4f3e58e802a4278e02b636ddafce9a4
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 16:13:09 2015 +

WaE: -Werror=maybe-uninitialized

Change-Id: I20827fc39d49f4dc77b399abb1e0127aac9330db

diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index bcd7537..448c23a 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -1167,7 +1167,7 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 
 //#i72517# put the styles to the target document
 //if the source uses headers or footers each new 
copy need to copy a new page styles
-SwPageDesc* pTargetPageDesc;
+SwPageDesc* pTargetPageDesc(NULL);
 if(bPageStylesWithHeaderFooter)
 {
 //create a new pagestyle
commit 3318400ad44a076fcadfd372f1e6c7613769f6be
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 16:12:41 2015 +

fix indent

Change-Id: I708c306afab92ff574d671d3580088ea1caf5606

diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 85f7fa8..bcd7537 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -1183,45 +1183,45 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* 
pSourceShell,
 lcl_CopyFollowPageDesc( *pTargetShell, 
*pWorkPageDesc, *pTargetPageDesc, nDocNo );
 }
 }
-else if( rMergeDescriptor.nMergeType == 
DBMGR_MERGE_PRINTER )
-{
-assert(!bCreateSingleFile);
-if( 1 == nDocNo ) // set up printing only once at 
the beginning
+else if( rMergeDescriptor.nMergeType == 
DBMGR_MERGE_PRINTER )
 {
-// printing should be done synchronously 
otherwise the document
-// might already become invalid during the 
process
-uno::Sequence beans::PropertyValue  
aOptions( rMergeDescriptor.aPrintOptions );
-
-aOptions.realloc( 2 );
-aOptions[ 0 ].Name = Wait;
-aOptions[ 0 ].Value = sal_True;
-aOptions[ 1 ].Name = MonitorVisible;
-aOptions[ 1 ].Value = sal_False;
-// move print options
-const beans::PropertyValue* pPrintOptions = 
rMergeDescriptor.aPrintOptions.getConstArray();
-for( sal_Int32 nOption = 0, nIndex = 1 ; 
nOption  rMergeDescriptor.aPrintOptions.getLength(); ++nOption)
+assert(!bCreateSingleFile);
+if( 1 == nDocNo ) // set up printing only once 
at the beginning
 {
-if( pPrintOptions[nOption].Name == 
CopyCount || pPrintOptions[nOption].Name == FileName
-|| pPrintOptions[nOption].Name == 
Collate || pPrintOptions[nOption].Name == Pages
-|| pPrintOptions[nOption].Name == 
Wait || pPrintOptions[nOption].Name == PrinterName )
+// printing should be done synchronously 
otherwise the document
+// might already become invalid during the 
process
+uno::Sequence beans::PropertyValue  
aOptions( rMergeDescriptor.aPrintOptions );
+
+aOptions.realloc( 2 );
+aOptions[ 0 ].Name = Wait;
+aOptions[ 0 ].Value = sal_True;
+aOptions[ 1 ].Name = MonitorVisible;
+aOptions[ 1 ].Value = sal_False;
+// move print options
+const beans::PropertyValue* pPrintOptions 
= rMergeDescriptor.aPrintOptions.getConstArray();
+for( sal_Int32 nOption = 0, nIndex = 1 ; 
nOption  rMergeDescriptor.aPrintOptions.getLength(); ++nOption)
 {
-// add an option
-aOptions.realloc( nIndex + 1 );
-aOptions[ nIndex ].Name = 
pPrintOptions[nOption].Name;
-aOptions[ nIndex++ ].Value = 

[Libreoffice-commits] core.git: 6 commits - vcl/inc vcl/unx

2015-03-11 Thread Caolán McNamara
 vcl/inc/unx/gtk/gtkframe.hxx  |   12 -
 vcl/inc/unx/gtk/gtkgdi.hxx|4 
 vcl/unx/gtk/window/gtksalframe.cxx|  173 ++
 vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |   40 --
 4 files changed, 78 insertions(+), 151 deletions(-)

New commits:
commit eeef59d94cd358916d1defdb7925e25c740ac8d0
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 16:36:43 2015 +

AllocateFrame only needed for gtk3 path

Change-Id: I118f640e770491448b16f1a9387ffe6df5063cd9

diff --git a/vcl/unx/gtk/window/gtksalframe.cxx 
b/vcl/unx/gtk/window/gtksalframe.cxx
index f3a4353..afcdbe5 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -405,6 +405,7 @@ void GtkSalFrame::doKeyCallback( guint state,
 vcl::DeletionListener aDel( this );
 
 #if GTK_CHECK_VERSION(3,0,0)
+#if 0
 // shift-zero forces a re-draw and event is swallowed
 if (keyval == GDK_0)
 {
@@ -424,7 +425,7 @@ void GtkSalFrame::doKeyCallback( guint state,
 fprintf(stderr, toggle dump frames to %d\n, dumpframes);
 return;
 }
-
+#endif
 #endif
 
 /*
@@ -3115,7 +3116,6 @@ bool GtkSalFrame::Dispatch( const XEvent* pEvent )
 maGeometry.nWidth  = pEvent-xconfigure.width;
 maGeometry.nHeight = pEvent-xconfigure.height;
 setMinMaxSize();
-AllocateFrame();
 getDisplay()-SendInternalEvent( this, NULL, SALEVENT_RESIZE );
 }
 }
commit e786d60ceee3e32eff8bd77b13a9d1b3d00e78b9
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 16:30:36 2015 +

drop -1 +2 hack unless someone can show a need for it again

Change-Id: Ib6ac83dfe9e187cdbb40ebb539552b4cef824e48

diff --git a/vcl/unx/gtk/window/gtksalframe.cxx 
b/vcl/unx/gtk/window/gtksalframe.cxx
index 3a84f98..f3a4353 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -3391,15 +3391,11 @@ void GtkSalFrame::damaged (const basegfx::B2IBox 
rDamageRect)
 cairo_surface_write_to_png(cairo_get_target(getCairoContext()), 
tmp.getStr());
 }
 
-/* FIXME: this is a dirty hack, to render buttons correctly, we
- * should of course remove the -1 and +2, but the whole area
- * won't be rendered then.
- */
-gtk_widget_queue_draw_area( m_pWindow,
-rDamageRect.getMinX() - 1,
-rDamageRect.getMinY() - 1,
-rDamageRect.getWidth() + 2,
-rDamageRect.getHeight() + 2 );
+gtk_widget_queue_draw_area(m_pWindow,
+   rDamageRect.getMinX(),
+   rDamageRect.getMinY(),
+   rDamageRect.getWidth(),
+   rDamageRect.getHeight());
 }
 
 // blit our backing basebmp buffer to the target cairo context cr
commit 082f7a97f40f1ebacf64b7a1b9fdee2bbde60a07
Author: Caolán McNamara caol...@redhat.com
Date:   Mon Mar 9 10:40:14 2015 +

debug helpers

Change-Id: I75e697a1500cd51ba714d16e3a5f131d922e2906

diff --git a/vcl/unx/gtk/window/gtksalframe.cxx 
b/vcl/unx/gtk/window/gtksalframe.cxx
index 8e32df6..3a84f98 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -382,6 +382,8 @@ struct DamageTracker : public 
basebmp::IBitmapDeviceDamageTracker
 GtkSalFrame m_rFrame;
 };
 }
+
+static bool dumpframes = false;
 #endif
 
 void GtkSalFrame::doKeyCallback( guint state,
@@ -406,10 +408,23 @@ void GtkSalFrame::doKeyCallback( guint state,
 // shift-zero forces a re-draw and event is swallowed
 if (keyval == GDK_0)
 {
-fprintf( stderr, force re-draw\n);
+fprintf( stderr, force widget_queue_draw\n);
 gtk_widget_queue_draw (m_pWindow);
 return;
 }
+else if (keyval == GDK_1)
+{
+fprintf( stderr, force repaint all\n);
+TriggerPaintEvent();
+return;
+}
+else if (keyval == GDK_2)
+{
+dumpframes = !dumpframes;
+fprintf(stderr, toggle dump frames to %d\n, dumpframes);
+return;
+}
+
 #endif
 
 /*
@@ -3367,14 +3382,14 @@ void GtkSalFrame::damaged (const basegfx::B2IBox 
rDamageRect)
  (int) rDamageRect.getHeight(),
  area );
 }
-
-#if FRAME_BY_FRAME_DEBUG
-static int frame;
-OString tmp(/tmp/frame + OString::number(frame++) + .png);
-cairo_surface_write_to_png(cairo_get_target(getCairoContext()), 
tmp.getStr());
 #endif
 
-#endif
+if (dumpframes)
+{
+static int frame;
+OString tmp(/tmp/frame + OString::number(frame++) + .png);
+cairo_surface_write_to_png(cairo_get_target(getCairoContext()), 
tmp.getStr());
+}
 
 /* FIXME: this is a dirty hack, to render buttons correctly, we
  * should of course remove the -1 and +2, but 

[Libreoffice-commits] core.git: canvas/source

2015-03-11 Thread Caolán McNamara
 canvas/source/directx/dx_config.cxx |2 +-
 canvas/source/directx/dx_config.hxx |4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7cfa311d55f50c0e42067efd6fda29597d2e1522
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 17:18:33 2015 +

presumably this Commit-ImplCommit is the right build fix

Change-Id: Ica4ccac97c077dd3046e42650889ba538814bf9b

diff --git a/canvas/source/directx/dx_config.cxx 
b/canvas/source/directx/dx_config.cxx
index 64d591a..d1d410d 100644
--- a/canvas/source/directx/dx_config.cxx
+++ b/canvas/source/directx/dx_config.cxx
@@ -130,7 +130,7 @@ namespace dxcanvas
 }
 
 void DXCanvasItem::Notify( const com::sun::star::uno::SequenceOUString 
) {}
-void DXCanvasItem::Commit() {}
+void DXCanvasItem::ImplCommit() {}
 
 bool DXCanvasItem::isDeviceUsable( const DeviceInfo rDeviceInfo ) const
 {
diff --git a/canvas/source/directx/dx_config.hxx 
b/canvas/source/directx/dx_config.hxx
index 34707ef..0f244c8 100644
--- a/canvas/source/directx/dx_config.hxx
+++ b/canvas/source/directx/dx_config.hxx
@@ -66,10 +66,10 @@ namespace dxcanvas
 bool isBlacklistCurrentDevice() const;
 void blacklistDevice( const DeviceInfo rDeviceInfo );
 void adaptMaxTextureSize( basegfx::B2IVector io_maxTextureSize ) 
const;
-virtual voidNotify( const 
com::sun::star::uno::SequenceOUString aPropertyNames);
-virtual voidCommit();
+virtual void   Notify( const 
com::sun::star::uno::SequenceOUString aPropertyNames) SAL_OVERRIDE;
 
 private:
+virtual void   ImplCommit() SAL_OVERRIDE;
 typedef std::set DeviceInfo  ValueSet;
 ValueSet   maValues;
 boost::optionalsal_Int32 maMaxTextureSize;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89942] Draw created shapes fail to copy into Writer properly.

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89942

--- Comment #2 from bugzi...@rhynas.com ---
Created attachment 114041
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114041action=edit
Example Draw file and Writer file

As suggested I've tried various background options. Firstly frame area
Gradient, Hatching and Bitmap, and the results are the same as for Colour.  I
also confirm that on Writer document reload, the frame is always reset to
Transparency= Solid 100%, regardless of the original setting (as detailed in
Bug 86578).

Using Paste Special ... with Draw8, Drawing format, GDI Metafile  Bitmap,
confirmed the problem only occurs with the Drawing format (I presume equivalent
to simple Cut/Paste).

Also created Draw shapes with hatching and bitmap backgrounds, problem same as
with colour background.

See attached 7z file containing a sample Draw file and Writer file.

What I'm observing is the issue where Draw shapes (circles, rectangles etc) 
copied into a Writer frame, become stuck behind the frame background. However
any Draw lines and all Writer generated shapes remain in the foreground (as
intended).  Thus any frame transparency less than 100% causes Draw shapes to
fade to varying degrees (or disappear at 10%). This is my major concern.

My other observation that a single Draw shape copied to Writer and placed on
the page or in a frame (circle, rectangle) always vanishes after reload, may
have a different root cause. Howver as most people are likely to create a
simple shape directly in Writer rather than copy from Draw, it is not a major
issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89957] Spreadsheet errors in 4.4.1.2 (OK in 4.4.1.1)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89957

David Lynch david_ly...@blueyonder.co.uk changed:

   What|Removed |Added

 CC||david_ly...@blueyonder.co.u
   ||k
Version|unspecified |4.4.1.2 rc

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89957] New: Spreadsheet errors in 4.4.1.2 (OK in 4.4.1.1)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89957

Bug ID: 89957
   Summary: Spreadsheet errors in 4.4.1.2 (OK in 4.4.1.1)
   Product: LibreOffice
   Version: unspecified
  Hardware: x86 (IA32)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: david_ly...@blueyonder.co.uk

Created attachment 114042
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114042action=edit
Spreadsheet exhibiting bug

I upgraded from 4.4.1.1 to 4.4.1.2 this week (on Windows 8.1).

I have a fairly complex spreadsheet that worked well on 4.4.1.1. I hadn't
changed it for several weeks.

In 4.4.1.2:

Whenever I try to add a column in sheet w (eg between G and H), Calc crashes
with an unexpected error (no further detail). I can recover the file and
usually a second attempt at adding a column works.

Some formulae involving names give incorrect results (eg many cells in sheet a,
a.EN2:EP513 contain Error: No result). If I rewrite them
using A1:B2 notation they work.

It is significantly slower.

I have tried a new user profile and increasing the memory allocated, with no
change in behaviour.

Spreadsheet attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: shell/source

2015-03-11 Thread Caolán McNamara
 shell/source/win32/shlxthandler/columninfo/columninfo.cxx |9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 6617505ee19cd0fa1f19815f5a736755e488beae
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 17:12:27 2015 +

V512: we want the number of wide-chars here, not the number of bytes

Change-Id: I121cdfd586562b9ce298448f51d0b2e3b2a52c39

diff --git a/shell/source/win32/shlxthandler/columninfo/columninfo.cxx 
b/shell/source/win32/shlxthandler/columninfo/columninfo.cxx
index 6f4129e..9eeb252 100644
--- a/shell/source/win32/shlxthandler/columninfo/columninfo.cxx
+++ b/shell/source/win32/shlxthandler/columninfo/columninfo.cxx
@@ -110,10 +110,7 @@ HRESULT STDMETHODCALLTYPE 
CColumnInfo::Initialize(LPCSHCOLUMNINIT /*psci*/)
 return S_OK;
 }
 
-
 // Register all columns we support
-
-
 HRESULT STDMETHODCALLTYPE CColumnInfo::GetColumnInfo(DWORD dwIndex, 
SHCOLUMNINFO *psci)
 {
 if (dwIndex = ColumnInfoTableSize)
@@ -126,14 +123,12 @@ HRESULT STDMETHODCALLTYPE 
CColumnInfo::GetColumnInfo(DWORD dwIndex, SHCOLUMNINFO
 psci-scid.fmtid = ColumnInfoTable[dwIndex].scid.fmtid;
 psci-scid.pid   = ColumnInfoTable[dwIndex].scid.pid;
 ZeroMemory(psci-wszTitle, sizeof(psci-wszTitle));
-wcsncpy(psci-wszTitle, ColumnInfoTable[dwIndex].wszTitle, 
(sizeof(psci-wszTitle) - 1));
-
+wcsncpy(psci-wszTitle, ColumnInfoTable[dwIndex].wszTitle,
+(sizeof(psci-wszTitle) / sizeof(psci-wszTitle[0]) - 1));
 
 return S_OK;
 }
 
-
-
 HRESULT STDMETHODCALLTYPE CColumnInfo::GetItemData(LPCSHCOLUMNID pscid, 
LPCSHCOLUMNDATA pscd, VARIANT *pvarData)
 {
 if (IsOOFileExtension(pscd-pwszExt))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89778] Mailing assistant does not allow anymore viewing and editing individual document

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89778

Beluga todven...@suomi24.fi changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #7 from Beluga todven...@suomi24.fi ---
Thanks. I'll close this as INVALID because the profile reset solved it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89958] New: Data-Filter-Standard Filter, condition does not end with does filter too much

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89958

Bug ID: 89958
   Summary: Data-Filter-Standard Filter, condition does not end
with does filter too much
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: Other
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bjoern.michael...@canonical.com

Created attachment 114043
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114043action=edit
test documeny

Steps to reproduce:
1/ Open attached document
2/ Select column A
3/ Menu: Data-Filter-Standard Filter ...
4/ Field Name Column A, Condition Does not end with, Value: CTORS

Expected behaviours:
A2 is not filtered as it does not end with CTORS.

Actual behaviour:
A2 is filtered (and a lot of other row not ending in CTORS are).

Tested with 4.2.8.2 from Ubuntu PPA on Ubuntu 14.04 and 4.3.5.2 on gentoo.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89919] Zooming out should have a limit

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89919

Robinson Tryon (qubit) qu...@runcibility.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||qu...@runcibility.com
Version|unspecified |4.5.0.0.alpha0+ Master
 Ever confirmed|0   |1

--- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com ---
TESTING with F-droid 4.5-master (2f6bc9c) on Android 4.4.4

(In reply to Khaled Hosny from comment #0)
 Currently when ones zooms out in the Android voiwer, it goes on untill the
 document disppears completely. I think there should be some limit on how
 much one can zoom out like other Android applications do.

I just tested with a sample ODT, and I am stopped from zooming-in after a
certain point, however I am not stopped from zooming-out...the page just gets
smaller and smaller and smaller

Personally, I don't see a big problem here. If someone has a really big
document, infinite zoom-out might cover that use case well. Is there a speed
hit or usability problem that would be rectified by limiting zoom?

Status - NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sw/source

2015-03-11 Thread Michael Stahl
 sw/source/uibase/dbui/dbmgr.cxx |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit fa8543c558d6402077b9f85ab60c6961e5d6949f
Author: Michael Stahl mst...@redhat.com
Date:   Wed Mar 11 17:42:46 2015 +0100

sw: MacOSX has CUPS but no psp::PrinterInfoManager

... so disable the we-can-queue-jobs-better-than-cups code on Mac.

Change-Id: If91eb96c5d7bd27fe162bd233ee958e581de23fc

diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index 448c23a..74ecf73 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -136,7 +136,9 @@
 
 #include boost/scoped_ptr.hpp
 #include config_cups.h
+#if ENABLE_CUPS  !defined(MACOSX)
 #include vcl/printerinfomanager.hxx
+#endif
 
 
 using namespace ::osl;
@@ -838,7 +840,7 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 // and send them to CUPS only as one job at the very end. Therefore, 
with CUPS, it's ok
 // to use the faster mode. As I have no idea about other platforms, 
keep them using
 // the slower singlefile mode (or feel free to check them, or rewrite 
the printing code).
-#if ENABLE_CUPS
+#if ENABLE_CUPS  !defined(MACOSX)
 bCreateSingleFile = 
!psp::PrinterInfoManager::get().supportsBatchPrint();
 #else
 bCreateSingleFile = true;
@@ -1215,7 +1217,7 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 SfxPrinter* pDocPrt = 
pWorkView-GetPrinter(false);
 JobSetup aJobSetup = pDocPrt ? 
pDocPrt-GetJobSetup() : pWorkView-GetJobSetup();
 Printer::PreparePrintJob( 
pWorkView-GetPrinterController(), aJobSetup );
-#if ENABLE_CUPS
+#if ENABLE_CUPS  !defined(MACOSX)
 
psp::PrinterInfoManager::get().startBatchPrint();
 #endif
 }
@@ -1379,7 +1381,7 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 if( rMergeDescriptor.nMergeType == DBMGR_MERGE_PRINTER )
 {
 Printer::FinishPrintJob( 
pWorkView-GetPrinterController());
-#if ENABLE_CUPS
+#if ENABLE_CUPS  !defined(MACOSX)
 psp::PrinterInfoManager::get().flushBatchPrint();
 #endif
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 61398] FILEOPEN: can't get rid of macro warning

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61398

--- Comment #3 from Joel Madero jmadero@gmail.com ---
@Richard - I think that this issue has been resolved. Can you verify that this
is the case with 4.4.1.2 or newer and mark the bug as RESOLVED - WORKSFORME?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 6 commits - config_host/config_cups.h.in configure.ac include/sfx2 include/vcl sfx2/source sw/source vcl/inc vcl/source vcl/unx

2015-03-11 Thread Miklos Vajna
 config_host/config_cups.h.in   |6 
 configure.ac   |3 
 include/sfx2/viewsh.hxx|5 
 include/vcl/jobdata.hxx|6 
 include/vcl/print.hxx  |9 +
 include/vcl/printerinfomanager.hxx |   10 +
 sfx2/source/view/viewprn.cxx   |   15 ++
 sw/source/uibase/dbui/dbmgr.cxx|  160 -
 sw/source/uibase/inc/view.hxx  |   11 -
 sw/source/uibase/uno/unomailmerge.cxx  |2 
 vcl/inc/cupsmgr.hxx|   24 +++
 vcl/source/gdi/print3.cxx  |   73 ++-
 vcl/unx/generic/printer/cupsmgr.cxx|  101 +--
 vcl/unx/generic/printer/jobdata.cxx|   18 ++
 vcl/unx/generic/printer/printerinfomanager.cxx |   15 ++
 15 files changed, 373 insertions(+), 85 deletions(-)

New commits:
commit d5c93cccaebf92b7f99e174552a7c84a5c652690
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Wed Mar 11 16:03:25 2015 +0100

SwDBManager::MergeMailFiles: merge two bCreateSingleFile blocks

Change-Id: Ia4290a8bfafc88c8e8e7601d62781c0da250824e

diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx
index b01e2b2..85f7fa8 100644
--- a/sw/source/uibase/dbui/dbmgr.cxx
+++ b/sw/source/uibase/dbui/dbmgr.cxx
@@ -1141,9 +1141,6 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 rWorkShell.SwViewShell::UpdateFlds();
 
SfxGetpApp()-NotifyEvent(SfxEventHint(SW_EVENT_FIELD_MERGE_FINISHED, 
SwDocShell::GetEventName(STR_SW_EVENT_FIELD_MERGE_FINISHED), xWorkDocSh));
 
-if( bCreateSingleFile )
-pWorkDoc-RemoveInvisibleContent();
-
 // launch MailMergeEvent if required
 const SwXMailMerge *pEvtSrc = GetMailMergeEvtSrc();
 if(pEvtSrc)
@@ -1155,6 +1152,8 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell,
 
 if(bCreateSingleFile)
 {
+pWorkDoc-RemoveInvisibleContent();
+
 OSL_ENSURE( pTargetShell, no target shell 
available! );
 // copy created file into the target document
 rWorkShell.ConvertFieldsToText();
commit 138d29aa09417eba4d15ade4c9f4dab2620b6326
Author: Luboš Luňák l.lu...@collabora.com
Date:   Thu Feb 26 15:56:24 2015 +0100

support fast MM printing in non-single-file mode only for CUPS

As said in the comment, the non-single-file mode could create way too many 
print
jobs, so enable this only for the CUPS backend, which has been modified
to send them as a single batch.

Conflicts:
configure.ac
include/vcl/printerinfomanager.hxx
sw/source/uibase/dbui/dbmgr.cxx
vcl/inc/cupsmgr.hxx
vcl/unx/generic/printer/cupsmgr.cxx
vcl/unx/generic/printer/printerinfomanager.cxx

Change-Id: I4c02ca0e8b91323b1d02f004c7b4813433064a11

diff --git a/config_host/config_cups.h.in b/config_host/config_cups.h.in
new file mode 100644
index 000..6794703
--- /dev/null
+++ b/config_host/config_cups.h.in
@@ -0,0 +1,6 @@
+#ifndef CONFIG_CUPS_H
+#define CONFIG_CUPS_H
+
+#define ENABLE_CUPS 0
+
+#endif
diff --git a/configure.ac b/configure.ac
index 9131d9b..e8d4fe8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4633,7 +4633,7 @@ if test $test_cups = yes; then
 if test $ac_cv_lib_cups_cupsPrintFiles != yes -o 
$ac_cv_header_cups_cups_h != yes; then
 AC_MSG_ERROR([Could not find CUPS. Install libcups2-dev or 
cups-devel.])
 fi
-
+AC_DEFINE(ENABLE_CUPS)
 else
 AC_MSG_RESULT([no])
 fi
@@ -12900,6 +12900,7 @@ AC_CONFIG_FILES([config_host.mk
 AC_CONFIG_HEADERS([config_host/config_buildid.h])
 AC_CONFIG_HEADERS([config_host/config_clang.h])
 AC_CONFIG_HEADERS([config_host/config_eot.h])
+AC_CONFIG_HEADERS([config_host/config_cups.h])
 AC_CONFIG_HEADERS([config_host/config_features.h])
 AC_CONFIG_HEADERS([config_host/config_folders.h])
 AC_CONFIG_HEADERS([config_host/config_gcc.h])
diff --git a/include/vcl/jobdata.hxx b/include/vcl/jobdata.hxx
index 8cffdd1..c173863 100644
--- a/include/vcl/jobdata.hxx
+++ b/include/vcl/jobdata.hxx
@@ -79,6 +79,12 @@ struct VCL_DLLPUBLIC JobData
 static bool constructFromStreamBuffer( void* pData, int bytes, JobData 
rJobData );
 };
 
+bool operator==(const psp::JobData rLeft, const psp::JobData rRight);
+inline bool operator!=(const psp::JobData rLeft, const psp::JobData rRight)
+{
+return !( rLeft == rRight );
+}
+
 } // namespace
 
 
diff --git a/include/vcl/printerinfomanager.hxx 
b/include/vcl/printerinfomanager.hxx
index 97e68d1..ec5c587 100644
--- a/include/vcl/printerinfomanager.hxx
+++ b/include/vcl/printerinfomanager.hxx
@@ -196,6 +196,16 @@ 

[Libreoffice-bugs] [Bug 89954] New: FORMATTING: Autocapitalisation does not happen if the last word in the previous sentence has a comment in the middle of the word

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89954

Bug ID: 89954
   Summary: FORMATTING:  Autocapitalisation does not happen if the
last word in the previous sentence has a comment in
the middle of the word
   Product: LibreOffice
   Version: 4.4.1.2 rc
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: gordon1dr...@yahoo.com

Created attachment 114040
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114040action=edit
Examples of no autocapitalisation

Non-range comment:
1. New Text Document.
2. Type test..
3. Insert comment between s and t.
4. Type test into comment box.
5. Place cursor after Test. in document.
6. Spacebar
7. Type this is a test..
Expected Result:
this is capitalised.
Result:
this is not capitalised.

Additionally, inserting a non-range comment at the beginning or end of the word
(before or after the punctuation) does autocapitalise the beginning of the next
sentence.

Range comment:
1. New Text Document.
2. Type test..
3. Select Te from Test..
4. Insert comment.
5. Type test into comment box.
6. Place cursor after Test. in document.
7. Spacebar
8. Type this is a test..
Expected Result:
this is capitalised.
Result:
this is not capitalised.
Alternate:
3. Select es from Test..
4. Insert comment.
5. Type test into comment box.
6. Place cursor after Test. in document.
7. Spacebar
8. Type this is a test..
Expected Result:
this is capitalised.
Result:
this is not capitalised.

Additionally, inserting a range comment that includes the last letter of the
word (with or without punctuation) does autocapitalise the beginning of the
next sentence.

Also, for range comments, including the beginning of the last word in a
sentence with previous words in that sentence does not autocapitalise the
beginning of the next sentence.


Version: 4.4.1.2
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/headless

2015-03-11 Thread Caolán McNamara
 vcl/headless/svpgdi.cxx |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 3fde719130781fc509241a66d08a8f57ba95354f
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 15:34:04 2015 +

the clipping must be against the original device

seeing as the clipping replaces the old clipping and doesn't
further subset the clipping

and presumably, the same must be true for unclipping
the device

This nearly killed me to debug and is a crucial bit to make the gtk3 thing 
work
right.

Change-Id: I21629ef7c8a19b720d05d4e4938f40d4776bee76

diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index a0bea2b..ea043b1 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -240,6 +240,8 @@ bool SvpSalGraphics::isClippedSetup( const basegfx::B2IBox 
aRange, SvpSalGraphi
 {
 if( aHitRect.IsInside( aRect ) )
 {
+//The region to be painted (aRect) is equal to or inside the
+//current clipping region
 //fprintf (stderr,  is inside ! avoid deeper clip ...\n);
 return false;
 }
@@ -276,6 +278,7 @@ bool SvpSalGraphics::setClipRegion( const vcl::Region 
i_rClip )
 m_aClipMap.reset();
 if( i_rClip.IsEmpty() )
 {
+m_aDevice = m_aOrigDevice;
 m_bClipSetup = true;
 return true;
 }
@@ -283,8 +286,9 @@ bool SvpSalGraphics::setClipRegion( const vcl::Region 
i_rClip )
 RectangleVector aRectangles;
 i_rClip.GetRegionRectangles(aRectangles);
 
-if(1 == aRectangles.size())
+if (1 == aRectangles.size())
 {
+//simplest case, subset the device to clip bounds
 m_aClipMap.reset();
 
 const Rectangle aBoundRect = aRectangles[0];
@@ -295,7 +299,14 @@ bool SvpSalGraphics::setClipRegion( const vcl::Region 
i_rClip )
 m_bClipSetup = true;
 }
 else
+{
+//more complex, either setup and tear down temporary
+//subsets of the original device around render calls
+//or generate m_aClipMap and pass that to basebmp
+//calls
+m_aDevice = m_aOrigDevice;
 m_bClipSetup = false;
+}
 
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-commits] core.git: Branch 'feature/tiled-editing' - svx/source

2015-03-11 Thread Miklos Vajna
 svx/source/svdraw/svdmrkv.cxx |   24 
 1 file changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 46d05bbb8ece5d16deef15be6dc45fb027f031c6
Author: Miklos Vajna vmik...@collabora.co.uk
Date:   Wed Mar 11 16:33:25 2015 +0100

SdrMarkView::SetMarkHandles: when tiled rendering, show non-frame handles, 
too

This gives graphic selection / moving / resizing for non-frame shapes
(the ones with the blue handles on the desktop).

Change-Id: I59018d4beb2ad1d2133d439afda56686b3c00b0c

diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index 3209f4e..cc8badb 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -699,20 +699,20 @@ void SdrMarkView::SetMarkHandles()
 }
 }
 
-if (bFrmHdl)
-{
-Rectangle aRect(GetMarkedObjRect());
+Rectangle aRect(GetMarkedObjRect());
 
-if (GetModel()-isTiledRendering())
-{
-OString sRectangle;
-if (aRect.IsEmpty())
-sRectangle = EMPTY;
-else
-sRectangle = aRect.toString();
-
GetModel()-libreOfficeKitCallback(LOK_CALLBACK_GRAPHIC_SELECTION, 
sRectangle.getStr());
-}
+if (GetModel()-isTiledRendering())
+{
+OString sRectangle;
+if (aRect.IsEmpty())
+sRectangle = EMPTY;
+else
+sRectangle = aRect.toString();
+GetModel()-libreOfficeKitCallback(LOK_CALLBACK_GRAPHIC_SELECTION, 
sRectangle.getStr());
+}
 
+if (bFrmHdl)
+{
 if(!aRect.IsEmpty())
 { // otherwise nothing is found
 if( bSingleTextObjMark )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89955] New: EDITING: focus lost when using edit button or CTRL-SHIFT_M

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89955

Bug ID: 89955
   Summary: EDITING: focus lost when using edit button or
CTRL-SHIFT_M
   Product: LibreOffice
   Version: 4.4.1.2 rc
  Hardware: Other
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: bernard.more...@gmail.com

When going into read-only mode in any document using the edit button or
CTRL-SHIFT-M, focus is lost (PageUp/Down no longer works, and CTRL-SHIFT-M is
also disabled) until the user clicks on the document text area.

May be related to bug 89688

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 82855] MAILMERGE: Mail Merge Wizard not working anymore (freezes) when a data source exists

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=82855

--- Comment #17 from Beluga todven...@suomi24.fi ---
(In reply to ildflue from comment #16)
 I was too eager of reporting it worked. It does NOT: When I tried to save
 the merged document, it crashed. 
 
 Tried many times, always crash while saving the merged document.

You could try getting a backtrace and attaching it here.
Instructions for Win:
https://wiki.documentfoundation.org/How_to_get_a_backtrace_with_WinDbg

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 71231] Automatic filter doesn't work with more than 65535 rows

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=71231

Kamil Páral kamil.pa...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Kamil Páral kamil.pa...@gmail.com ---
You're right, it works well in newer versions of LO. Except for All and Show
only current item buttons, which make Calc consume 100% CPU for long minutes
and one has to kill it. But that should be a separate report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 68050] UI: Fields dialog does not preserve scroll position when focussed

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68050

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1
 OS|Linux (All) |All

--- Comment #4 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: sal/osl

2015-03-11 Thread Markus Mohrhard
 sal/osl/w32/profile.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6c6caf02aebb5637f98cb153bc96abab23ccdfce
Author: Markus Mohrhard markus.mohrh...@collabora.co.uk
Date:   Wed Mar 11 22:03:26 2015 +0100

better way to check for empty strings

Change-Id: Ib52b3f958e9e346194d4427bf59c6f62ee8ed105
Signed-off-by: Michael Stahl mst...@redhat.com

diff --git a/sal/osl/w32/profile.cxx b/sal/osl/w32/profile.cxx
index 066aeed..27bc9d7 100644
--- a/sal/osl/w32/profile.cxx
+++ b/sal/osl/w32/profile.cxx
@@ -2389,7 +2389,7 @@ static sal_Bool lookupProfile(const sal_Unicode *strPath, 
const sal_Unicode *str
 osl_closeProfile(hProfile);
 
 /* if not found, try the fallback */
-if ((strlen(Buffer) = 0)
+if ((Buffer[0] == '\0')
  (strcmp(SVERSION_LOCATION, SVERSION_FALLBACK)
 != 0))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89951] EDITING: [italic/underline/bold] markup removed when merging cells

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89951

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

Note to Step 2:
It is not reproducible when merging the cell with a cell right to or below that
cell.  It is only reproducible when merging the cell with a cell above or left
to that cell.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 53056] Format paintbrush cannot be used between documents

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=53056

Jean-Baptiste Faure jbfa...@libreoffice.org changed:

   What|Removed |Added

 CC||jbfa...@libreoffice.org
  Attachment #67196|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34652] Using automatic file name extension in Libreoffice native dialog, Presentation minimizer does not export proper file name.

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34652

Jean-Baptiste Faure jbfa...@libreoffice.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |WORKSFORME

--- Comment #4 from Jean-Baptiste Faure jbfa...@libreoffice.org ---
Not reproducible for me too with LibreOffice 4.4.3.0.0+ built at home under
Ubuntu 14.10 x86-64.

Closing as WorksForMe. Please, feel free to reopen if you still encounter the
same bug.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89954] FORMATTING: Autocapitalisation does not happen if the last word in the previous sentence has a comment in the middle of the word

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89954

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/qa

2015-03-11 Thread Caolán McNamara
 vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36334-1.gif |2 ++
 vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36335-1.gif |binary
 2 files changed, 2 insertions(+)

New commits:
commit 00d7d6db0219c28dbc30e3e0175721c2f6161da9
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 20:57:44 2015 +

add EBD-36335 and EBD-36334 tests

Change-Id: I7c70b0b95dc921b5fa535a090843cd1679bd683f

diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36334-1.gif 
b/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36334-1.gif
new file mode 100644
index 000..a8f51b6
--- /dev/null
+++ b/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36334-1.gif
@@ -0,0 +1,2 @@
+””X©=ŠÜ؝¿;ekbΐ~§6à*^1Ì.”Ä„#᛾fLt€wüO zØâjA÷–F®HT©Øî
+ÞeŸ€Ô ?AäUõaŒÈ»L*ÖVÉqd¦ó`©6~[­ŠÓ…j™ÜæÏøªÖ`¦µo§D9ëÚ.4ùÓ
\ No newline at end of file
diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36335-1.gif 
b/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36335-1.gif
new file mode 100644
index 000..8f0f4fd
Binary files /dev/null and 
b/vcl/qa/cppunit/graphicfilter/data/gif/fail/EBD-36335-1.gif differ
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89945] LO won't remember formatting 'text extension inside cell' as reference edge when saved in xlsx

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89945

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 CC||stgohi-lob...@yahoo.de

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
For me not reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89926] FILEOPEN: gradient in .pptx reversed

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89926

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #4 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89950] backround color in contingent table lost in xlsx

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89950

raal r...@post.cz changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal r...@post.cz ---
Created attachment 114050
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114050action=edit
printscreen

Hello,
specify which cell colors are lost.I can see the same colors as in excel,LO
4.4.1.2, win7 and linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78840

--- Comment #3 from m.a.riosv mari...@miguelangel.mobi ---
Thanks a lot for take a look.

I think the workaround entering the character unicode can cover well with a few
characters to find.

By Eike answer seems that search and replace text it's analyze and transformed
before it is passed to regex matcher, so this can imply a high effort for a
little benefit.

Maybe if a regex expression could be used directly without any transformation,
but sure it's also not an easy garden to cut.

For me no problem on closing the request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89957] Spreadsheet errors in 4.4.1.2 (OK in 4.4.1.1)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89957

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1
   Severity|normal  |critical

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1, increased the importance due to crash of
CALC

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89931] Feature request: FORMATTING with returns

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89931

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
I create such formats sometimes manually.  But I don't know how many date
formats can or should be at maximum be included in LO to not overload the date
format list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89951] EDITING: [italic/underline/bold] markup removed when merging cells

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89951

--- Comment #2 from harm.dewei...@gmail.com ---
(In reply to A (Andy) from comment #1)
 Reproducible with LO 4.4.1.2, Win 8.1
 
 Note to Step 2:
 It is not reproducible when merging the cell with a cell right to or below
 that cell.  It is only reproducible when merging the cell with a cell above
 or left to that cell.

Can confirm for 4.3.2.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - sd/Library_sdd.mk sd/source sd/util

2015-03-11 Thread Stephan Bergmann
 sd/Library_sdd.mk|1 
 sd/source/ui/unoidl/detreg.cxx   |   71 ---
 sd/source/ui/unoidl/sddetect.cxx |   23 +++-
 sd/source/ui/unoidl/sddetect.hxx |8 +++-
 sd/util/sdd.component|5 +-
 5 files changed, 15 insertions(+), 93 deletions(-)

New commits:
commit 6661f6fee34d3c24bb9a054d5c24566c311e4a09
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Mar 11 20:20:35 2015 +0100

Clean up previous commit

Change-Id: I380e9b9bce052e6575a77ccec2676e828683565a

diff --git a/sd/util/sdd.component b/sd/util/sdd.component
index 85d8120..c3e25b2 100644
--- a/sd/util/sdd.component
+++ b/sd/util/sdd.component
@@ -18,8 +18,8 @@
  --
 
 component loader=com.sun.star.loader.SharedLibrary environment=@CPPU_ENV@
-prefix=sdd xmlns=http://openoffice.org/2010/uno-components;
-implementation name=com.sun.star.comp.draw.FormatDetector
+xmlns=http://openoffice.org/2010/uno-components;
+  implementation name=com.sun.star.comp.draw.FormatDetector
 constructor=com_sun_star_comp_draw_FormatDetector_get_implementation
 service name=com.sun.star.frame.ExtendedTypeDetection/
   /implementation
commit 53ca3f6f9e006b6cc584be17fe8971ffa67f5721
Author: Chris Sherlock chris.sherl...@collabora.com
Date:   Mon Mar 2 15:47:28 2015 +1100

sd: use constructor syntax for sdd.component

Signed-off-by: Stephan Bergmann sberg...@redhat.com,
with small fix to com_sun_star_comp_draw_FormatDetector_get_implementation
signature

Change-Id: Idf42503710f2ac536c620c80f8b5e21c3704389d

diff --git a/sd/Library_sdd.mk b/sd/Library_sdd.mk
index 2726023..cfabf22 100644
--- a/sd/Library_sdd.mk
+++ b/sd/Library_sdd.mk
@@ -34,7 +34,6 @@ $(eval $(call gb_Library_use_libraries,sdd,\
 $(eval $(call gb_Library_set_componentfile,sdd,sd/util/sdd))
 
 $(eval $(call gb_Library_add_exception_objects,sdd,\
-sd/source/ui/unoidl/detreg \
 sd/source/ui/unoidl/sddetect \
 ))
 
diff --git a/sd/source/ui/unoidl/detreg.cxx b/sd/source/ui/unoidl/detreg.cxx
deleted file mode 100644
index 791f399..000
--- a/sd/source/ui/unoidl/detreg.cxx
+++ /dev/null
@@ -1,71 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#include sddetect.hxx
-#include com/sun/star/lang/XServiceInfo.hpp
-#include com/sun/star/registry/XRegistryKey.hpp
-#include com/sun/star/uno/Sequence.h
-#include rtl/ustring.hxx
-#include sal/types.h
-
-using namespace ::com::sun::star;
-using namespace ::com::sun::star::uno;
-using namespace ::com::sun::star::lang;
-
-extern C {
-
-SAL_DLLPUBLIC_EXPORT void* SAL_CALL sdd_component_getFactory(
-const sal_Char* pImplementationName,
-void* pServiceManager,
-void*  )
-{
-// Set default return value for this operation - if it failed.
-void* pReturn = NULL ;
-
-if  (
-( pImplementationName   !=  NULL ) 
-( pServiceManager   !=  NULL )
-)
-{
-// Define variables which are used in following macros.
-Reference XSingleServiceFactoryxFactory  
  ;
-Reference XMultiServiceFactory xServiceManager( 
reinterpret_cast XMultiServiceFactory* ( pServiceManager ) ) ;
-
-if( SdFilterDetect::impl_getStaticImplementationName().equalsAscii( 
pImplementationName ) )
-{
-xFactory = ::cppu::createSingleFactory( xServiceManager,
-SdFilterDetect::impl_getStaticImplementationName(),
-SdFilterDetect::impl_createInstance,
-SdFilterDetect::impl_getStaticSupportedServiceNames() );
-}
-
-// Factory is valid - service was found.
-if ( xFactory.is() )
-{
-xFactory-acquire();
-pReturn = xFactory.get();
-}
-}
-
-// Return with result of this operation.
-return pReturn ;
-}
-} // extern C
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/unoidl/sddetect.cxx b/sd/source/ui/unoidl/sddetect.cxx
index 81b7da2..f2e2a71 100644
--- 

[Libreoffice-bugs] [Bug 89932] UI: Bullets and Numbering Position tab Level 1 does not display default values

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89932

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

But I have no answer/opinion to the question raised at the end of the bug
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89662] Undocked toolbars disappear with focus follows mouse on Xfce

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89662

--- Comment #4 from Octavio Alvarez alvar...@alvarezp.ods.org ---
Yes, focus delay is supposed to be as short as possible in a focus follows
mouse setup without raise on click.

The point is that docks should not automatically disappear because they are
disappearing on focus and becoming unreachable. They should disappear on raise,
but this is a job that should be done by the WM, not LibO. This way, if I raise
the window, the WM would bring all the related windows to the front as needed
and hide only those windows that overlap the window I raised.

At the very least, an option should be provided to turn off this incorrect
behavior.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89947] Pressing repo refresh button with blank entry causes crash

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89947

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

After step 6 the LO application is no longer responding to any mouse clicks and
can only be closed with the Windows Task Manager.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 45965] LibreOffice Writer closes unexpectedly/crashes whenever opening a file with footnotes etc

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=45965

Jean-Baptiste Faure jbfa...@libreoffice.org changed:

   What|Removed |Added

Version|4.1.3.2 release |3.4.4 release

--- Comment #8 from Jean-Baptiste Faure jbfa...@libreoffice.org ---
Please, do not change the version number, it shows the oldest version in which
the bug has been found.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89952] FILTER libreoffice --convert-to ods actually converts to fods

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89952

raal r...@post.cz changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal r...@post.cz ---
Hello,
I tested convert

this command produce xml
soffice --headless --convert-to ods /tmp/sxcFile.sxc
convert /tmp/sxcFile.sxc - /tmp/sxcFile.ods using OpenDocument Spreadsheet
Flat XML


If you want .ods you should use this:
soffice --headless --convert-to ods:calc8 /tmp/sxcFile.sxc
convert /tmp/sxcFile.sxc - /tmp/sxcFile.ods using calc8

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89928] FILEOPEN: image color in PPTX file is black instead of white

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89928

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #3 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89950] background color in pivot table lost in xlsx

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89950

raal r...@post.cz changed:

   What|Removed |Added

Summary|backround color in  |background color in pivot
   |contingent table lost in|table lost in xlsx
   |xlsx|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83726

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||960

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||726
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 89960] New: Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

Bug ID: 89960
   Summary: Suggestion to Change Style Behavior in Relation to
Direct Formatting
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: ux-advise
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jmadero@gmail.com
CC: libreoffice-ux-adv...@lists.freedesktop.org

There are essentially two ways that a user might apply a style:
1. Select the style in advance, then start typing;
2. Have text already written and then select it, and apply a style.

Suggestion to change behavior of the interaction between styles and direct
formatting to address these two different use cases.

For #1 (selecting style in advance and then typing);
*This should overwrite any direct formatting that has been previously applied
in the document.
**For a demonstration of why this should be the case, please take a look at bug
83726
***Note that this would be equivalent of doing ctrl + m and then applying the
style

For #2 (have text already, then apply style)
*Suggest that a dialog appears if there is any direct formatting applied in the
selected text (i.e. if a word is italicized, bolded, etc…) that says something
like “do you want the style to overwrite any direct formatting in the selected
text”
**This can be similar to the dialog that appears in Calc if you copy/paste into
a cell that already has a value
**This should have an option to say “do this every time.”

This should avoid breaking the workflow of people used to the current behavior,
and add the ability to make it more intuitive for those who find the current
process counter-intuitive (those who want a style to be applied uniformly every
time). Talking on QA channel and on user mailing list makes me think that the
current situation is counter-intuitive to a fair number of people. Also I know
at least a couple bugs have been closed because people were unaware of the
direct formatting always taking precedent over styles. At least some users –
myself included – think that if I have taken the time to define a style, I want
that style to apply the same way, every single time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 89960] New: Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

Bug ID: 89960
   Summary: Suggestion to Change Style Behavior in Relation to
Direct Formatting
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: ux-advise
  Assignee: libreoffice-b...@lists.freedesktop.org
  Reporter: jmadero@gmail.com
CC: libreoffice-ux-advise@lists.freedesktop.org

There are essentially two ways that a user might apply a style:
1. Select the style in advance, then start typing;
2. Have text already written and then select it, and apply a style.

Suggestion to change behavior of the interaction between styles and direct
formatting to address these two different use cases.

For #1 (selecting style in advance and then typing);
*This should overwrite any direct formatting that has been previously applied
in the document.
**For a demonstration of why this should be the case, please take a look at bug
83726
***Note that this would be equivalent of doing ctrl + m and then applying the
style

For #2 (have text already, then apply style)
*Suggest that a dialog appears if there is any direct formatting applied in the
selected text (i.e. if a word is italicized, bolded, etc…) that says something
like “do you want the style to overwrite any direct formatting in the selected
text”
**This can be similar to the dialog that appears in Calc if you copy/paste into
a cell that already has a value
**This should have an option to say “do this every time.”

This should avoid breaking the workflow of people used to the current behavior,
and add the ability to make it more intuitive for those who find the current
process counter-intuitive (those who want a style to be applied uniformly every
time). Talking on QA channel and on user mailing list makes me think that the
current situation is counter-intuitive to a fair number of people. Also I know
at least a couple bugs have been closed because people were unaware of the
direct formatting always taking precedent over styles. At least some users –
myself included – think that if I have taken the time to define a style, I want
that style to apply the same way, every single time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-commits] core.git: starmath/source

2015-03-11 Thread Takeshi Abe
 starmath/source/cfgitem.cxx |   30 --
 starmath/source/cfgitem.hxx |9 +
 2 files changed, 17 insertions(+), 22 deletions(-)

New commits:
commit f16f322ce4cbdfbd01b74eea8f68038fe0cb457f
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Wed Mar 11 18:45:33 2015 +0900

Adapt std::unique_ptr to SmMathConfig

Change-Id: I89c03719c1727aa70d187fcb6ba4630694549301
Reviewed-on: https://gerrit.libreoffice.org/14833
Tested-by: Michael Stahl mst...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com

diff --git a/starmath/source/cfgitem.cxx b/starmath/source/cfgitem.cxx
index 3b12c54..7616043 100644
--- a/starmath/source/cfgitem.cxx
+++ b/starmath/source/cfgitem.cxx
@@ -328,23 +328,19 @@ const OUString SmFontFormatList::GetNewFontFormatId() 
const
 
 SmMathConfig::SmMathConfig() :
 ConfigItem(OUString(aRootName))
+, pFormat()
+, pOther()
+, pFontFormatList()
+, pSymbolMgr()
+, bIsOtherModified(false)
+, bIsFormatModified(false)
 {
-pFormat = 0;
-pOther  = 0;
-pFontFormatList = 0;
-pSymbolMgr  = 0;
-
-bIsOtherModified = bIsFormatModified = false;
 }
 
 
 SmMathConfig::~SmMathConfig()
 {
 Save();
-delete pFormat;
-delete pOther;
-delete pFontFormatList;
-delete pSymbolMgr;
 }
 
 
@@ -461,7 +457,7 @@ SmSymbolManager  SmMathConfig::GetSymbolManager()
 {
 if (!pSymbolMgr)
 {
-pSymbolMgr = new SmSymbolManager;
+pSymbolMgr.reset(new SmSymbolManager);
 pSymbolMgr-Load();
 }
 return *pSymbolMgr;
@@ -571,7 +567,7 @@ SmFontFormatList  SmMathConfig::GetFontFormatList()
 void SmMathConfig::LoadFontFormatList()
 {
 if (!pFontFormatList)
-pFontFormatList = new SmFontFormatList;
+pFontFormatList.reset(new SmFontFormatList);
 else
 pFontFormatList-Clear();
 
@@ -750,8 +746,8 @@ void SmMathConfig::StripFontFormatList( const std::vector 
SmSym  rSymbols )
 // remove unused font-formats from list
 SmFontFormatList rFntFmtList = GetFontFormatList();
 size_t nCnt = rFntFmtList.GetCount();
-SmFontFormat *pTmpFormat = new SmFontFormat[ nCnt ];
-OUString *pId= new OUString[ nCnt ];
+std::unique_ptrSmFontFormat[] pTmpFormat(new SmFontFormat[ nCnt ]);
+std::unique_ptrOUString[] pId(new OUString[ nCnt ]);
 size_t k;
 for (k = 0;  k  nCnt;  ++k)
 {
@@ -765,15 +761,13 @@ void SmMathConfig::StripFontFormatList( const 
std::vector SmSym  rSymbols )
 rFntFmtList.RemoveFontFormat( pId[k] );
 }
 }
-delete [] pId;
-delete [] pTmpFormat;
 }
 
 
 void SmMathConfig::LoadOther()
 {
 if (!pOther)
-pOther = new SmCfgOther;
+pOther.reset(new SmCfgOther);
 
 pOther-bPrintTitle = officecfg::Office::Math::Print::Title::get();
 pOther-bPrintFormulaText = 
officecfg::Office::Math::Print::FormulaText::get();
@@ -814,7 +808,7 @@ void SmMathConfig::SaveOther()
 void SmMathConfig::LoadFormat()
 {
 if (!pFormat)
-pFormat = new SmFormat;
+pFormat.reset(new SmFormat);
 
 
 Sequence OUString  aNames = lcl_GetFormatPropertyNames();
diff --git a/starmath/source/cfgitem.hxx b/starmath/source/cfgitem.hxx
index 2fe2cdd..5b881eb 100644
--- a/starmath/source/cfgitem.hxx
+++ b/starmath/source/cfgitem.hxx
@@ -33,6 +33,7 @@
 
 #include symbol.hxx
 #include types.hxx
+#include memory
 
 class SmSym;
 class SmFormat;
@@ -92,10 +93,10 @@ public:
 
 class SmMathConfig : public utl::ConfigItem
 {
-SmFormat *  pFormat;
-SmCfgOther *pOther;
-SmFontFormatList *  pFontFormatList;
-SmSymbolManager *   pSymbolMgr;
+std::unique_ptrSmFormat pFormat;
+std::unique_ptrSmCfgOther   pOther;
+std::unique_ptrSmFontFormatList pFontFormatList;
+std::unique_ptrSmSymbolManager  pSymbolMgr;
 boolbIsOtherModified;
 boolbIsFormatModified;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 89895] Report: overlining works only in preview

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89895

--- Comment #6 from Julien Nabet serval2...@yahoo.fr ---
From #10 0x2aaae008f101 in rptui::GeometryHandler::setPropertyValue
(this=0x69fa190, PropertyName=FontDescriptor, Value=
uno::Any uno::Sequence of length 4 = {{Name = Font, Value = uno::Any
{Name = Liberation Sans, Height = 12, Width = 0, StyleName = , Family = 3,
CharSet = 76, Pitch = 2, CharacterWidth = 100, Weight = 150, Slant =
com::sun::star::awt::FontSlant_NONE, Underline = 1, Strikeout = 0, Orientation
= 0, Kerning = 0 '\000', WordLineMode = 0 '\000', Type = 0}}, {Name =
FontAsian, Value = uno::Any {Name = Source Han Sans CN Regular, Height =
12, Width = 0, StyleName = , Family = 6, CharSet = 76, Pitch = 2,
CharacterWidth = 75, Weight = 100, Slant = com::sun::star::awt::FontSlant_NONE,
Underline = 1, Strikeout = 0, Orientation = 0, Kerning = 0 '\000', WordLineMode
= 0 '\000', Type = 0}}, {Name = FontComplex, Value = uno::Any {Name =
FreeSans, Height = 12, Width = 0, StyleName = , Family = 6, CharSet = 76,
Pitch = 2, CharacterWidth = 100, Weight = 100, Slant =
com::sun::star::awt::FontSlant_NONE, Underline = 1, Strikeout = 0, Orientation
= 0, Kerning = 0 '\000', WordLineMode = 0 '\000', Type = 0}}, {Name =
CharUnderlineColor, Value = uno::Any 4294967295}}) at
/home/julien/compile-libreoffice/libreoffice/reportdesign/source/ui/inspection/GeometryHandler.cxx:657

I got this:
#10 0x2aaae008f101 in rptui::GeometryHandler::setPropertyValue
(this=0x69fa190, PropertyName=FontDescriptor, Value=
uno::Any uno::Sequence of length 4 = 

{
{Name = Font, Value = uno::Any 
{Name = Liberation Sans, Height = 12, Width = 0, StyleName = ,
Family = 3, CharSet = 76, Pitch = 2, CharacterWidth = 100, Weight = 150, Slant
= com::sun::star::awt::FontSlant_NONE, Underline = 15, Strikeout = 0,
Orientation = 0, Kerning = 0 '\000', WordLineMode = 0 '\000', Type = 0
}
}, 
{Name = FontAsian, Value = uno::Any 
{Name = Source Han Sans CN Regular, Height = 12, Width = 0, StyleName
= , Family = 6, CharSet = 76, Pitch = 2, CharacterWidth = 75, Weight = 100,
Slant = com::sun::star::awt::FontSlant_NONE, Underline = 15, Strikeout = 0,
Orientation = 0, Kerning = 0 '\000', WordLineMode = 0 '\000', Type = 0
}
}, 
{Name = FontComplex, Value = uno::Any 
{Name = FreeSans, Height = 12, Width = 0, StyleName = , Family = 6,
CharSet = 76, Pitch = 2, CharacterWidth = 100, Weight = 100, Slant =
com::sun::star::awt::FontSlant_NONE, Underline = 15, Strikeout = 0, Orientation
= 0, Kerning = 0 '\000', WordLineMode = 0 '\000', Type = 0
}
}, 
{Name = CharUnderlineColor, Value = uno::Any 4294967295
}
}) at
/home/julien/compile-libreoffice/libreoffice/reportdesign/source/ui/inspection/GeometryHandler.cxx:657
where we can see there's no overline part.

After some research, the location to fix seems there:
http://opengrok.libreoffice.org/xref/core/reportdesign/source/ui/misc/UITools.cxx#594

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89953] UI, Formatting: Character spacing

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89953

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
(In reply to Alex from comment #0)
 There are several issues with the character spacing menu in LibreOffice
 Writer:
 
 1. If there are 2 or more types of character spacing within the selected
 text (lets say, one word is expanded by 0.5pt and another word next to it is
 condensed by 0.2pt), the character spacing menu (Format  Character 
 Position  Spacing) shows 'default' (but it's not default, because it's not
 0), and when I click 'default' and OK, the spacing doesn't change (in the
 same situation in MS Office Word the spacing changes to 0pt for both words),
 so I have to adjust every word manually which is not correct. 

Reproducible with LO 4.4.1.2, Win 8.1

 2. The spacing is adjusted by 1.0pt, but it would be more convenient if it's
 0.1pt for small or normal fonts (~8-16pt). 

I can live with the current solution, but maybe other users think also
different about this.

 3. You have to select the type of spacing first ('Expanded' or 'Condensed'),
 before you can adjust the numbers (if the type is not selected, the field is
 disabled), but it would be more comfortable to set the value of spacing
 directly using arrows (up for expanded and down for condensed) or just write
 the numbers into the field (with + or - respectively).

For me this sounds like a good and reasonable enhancement proposal.  But it
would be better to open a separate enhancement request for this, because it is
not linked to the bug mentioned in No. 1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 53056] Format paintbrush cannot be used between documents

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=53056

Jean-Baptiste Faure jbfa...@libreoffice.org changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
 OS|Linux (All) |All
   Severity|normal  |enhancement

--- Comment #8 from Jean-Baptiste Faure jbfa...@libreoffice.org ---
This report is about format paintbrush, not about paste special with format.

I think that this is not a bug, format paintbrush seems to not have designed to
work from a document to another. Though, that seems a receivable enhancement
request.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 76183] Image cell anchor broken when autowrap text size increase causes row height change

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=76183

--- Comment #5 from a abc...@hotmail.com ---
'scrolling of images' seems to work fine when deleting (or inserting) a row
above the image : the image moves up (and down).
it still doesn't work with automatic wrap (wrapping text in a cell, or when
pasting a  wrapped cell) images don't scroll
thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89929] FILEOPEN: Image is flipped horizontally in PPTX

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89929

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #1 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

The right image (part) is mirrored when comparing it with IMPRESS and
PowerPoint.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89927] FILEOPEN: text is black instead of white in .PPTX file and it appears to be missing

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89927

A (Andy) stgohi-lob...@yahoo.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||stgohi-lob...@yahoo.de
 Ever confirmed|0   |1

--- Comment #3 from A (Andy) stgohi-lob...@yahoo.de ---
Reproducible with LO 4.4.1.2, Win 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89415] The problem of sorting data via AutoFilter; header with dropdowns sorted (header with empty cells)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89415

raal r...@post.cz changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from raal r...@post.cz ---
Bug fixed. Closing. Thanks for info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89606] Meta: Table of Contents and Indexes bugs and enhancements

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89606

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Depends on||34121

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 34121] Chapter related Table of Contents not updated

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=34121

Jay Philips philip...@hotmail.com changed:

   What|Removed |Added

 Blocks||89606

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 53290] [Find and replace] Backreference is not evaluated if word boundary is present in search string

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=53290

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 CC||jmadero@gmail.com
   Severity|normal  |enhancement

--- Comment #8 from Joel Madero jmadero@gmail.com ---
Prioritizing:
*Please do not adjust the priority without consulting QA on the mailing list or
in the chat room http://webchat.freenode.net/?channels=libreoffice-qa

Priorities are set per this chart:
https://wiki.documentfoundation.org/File:Prioritizing_Bugs_Flowchart.jpg

Per Michael's input from the comment, it seems like this is an enhancement
request. Regex was updated for Calc/Writer but for some reason left out of
Impress. So - it's an enhancement to bring that functionality into impress.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89919] Zooming out should have a limit

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89919

--- Comment #2 from Khaled Hosny khaledho...@eglug.org ---
No specific problem, it just seems pointless to zoom out indifinately and it
gives a bit of an unfinished feeling to the application. No other application
on Android seems to do this, even desktop version of LibreOffice does not allow
zooming out below 20%.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83726

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=89
   ||960

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=83
   ||726
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89895] Report: overlining works only in preview

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89895

--- Comment #5 from Julien Nabet serval2...@yahoo.fr ---
Created attachment 114049
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114049action=edit
bt with underline

I've updated my local repo and runned make clean  make.
Slowdown has disappeared :-)

So I finally found a bt when clicking Ok after having changed underline.

I thought it will be easy then to pinpoint the location where overlining could
be lacking, but for the moment, nothing.

Let's stay optimistic! :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 39756] Paragraph background color may extend too far FORMATTING

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=39756

Jean-Baptiste Faure jbfa...@libreoffice.org changed:

   What|Removed |Added

Version|4.4.0.3 release |3.3.3 release

--- Comment #9 from Jean-Baptiste Faure jbfa...@libreoffice.org ---
Please, do not change the version number, it shows the oldest version in which
the bug has been found.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Minutes of the Design Hangout: 2015-02-04

2015-03-11 Thread Jan Holesovsky
* Present: Heiko, Jay, Steve, Stuart
 
* Completed Action Items:

+ Jay/Kendy: GSoC for application (color) themes. (added it, Kendy add the 
rest)
  
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Application_Themes
  
https://docs.google.com/document/d/1J_aogLuQThqhvT0R2em27Vpew-SLAQgpH5TbNTgXPZM/edit?usp=sharing
+ Kendy: More work around templates repository / online templates / 
integration into the start screen / ...
  https://bugs.freedesktop.org/show_bug.cgi?id=85420
  https://bugs.freedesktop.org/attachment.cgi?id=108377
+ Heiko/Kendy: Rework of the Tools - Customization... dialog
  http://user-prompt.com/how-to-make-libreoffice-customization-usable/
+ will create a bug report for that (Heiko)
- https://bugs.documentfoundation.org/show_bug.cgi?id=88896
+ Kendy/Jay: Document preview in open dialog
  Adolfo suggest this be a GSoC
  https://bugs.freedesktop.org/show_bug.cgi?id=87748
+ need to double-check the technical feasibility - if that's the 
system's responsibility or LO's
+ maybe we should re-consider a bit how we are opening files
+ very hard to setup connection to google docs / onedrive etc.
Have popular CMIS pre-configured in LO custom dialog - 
https://bugs.freedesktop.org/show_bug.cgi?id=86699 
Easy access to online document storage services like Google Drive 
- https://bugs.freedesktop.org/show_bug.cgi?id=86703
 
* Pending Action Items:
 
+ Default document view for Writer, single page rather than automatic
  https://bugs.freedesktop.org/show_bug.cgi?id=88001
+ Stuart: Change the default to single page
+ Jay/Stuart: Change the tooltip to Multipage view or Multiple page 
view
  [https://bugs.freedesktop.org/show_bug.cgi?id=88001#c5 - would be 
great to get that to gerrit]
  AI: Stuart -- figure it out and get it posted.
+ Jay: Double check if we can change 'Spelling' to 'Spelling and Grammar'
  https://bugs.freedesktop.org/show_bug.cgi?id=87648
+ Jay: Send a mail to documentat...@global.libreoffice.org with the wiki 
page that collects changes in menus
+ Kendy: Collecting of the user information should be incremental, 
somewhere in the user's profile
+ Ahmed: Push the new Sifr icons he's done recently
+ Kendy: Talk to Milos wrt. 
https://bugs.freedesktop.org/show_bug.cgi?id=48622
+ Alex: Gnome 2.20-style 'a' icons  Gnome 3-style text line icons
+ Samuel: Formulas and Navigator should open in the sidebar, not as a 
special window
  https://bugs.freedesktop.org/show_bug.cgi?id=85897
  + Is that issue for the Navigator too (I dont read it from the issue)
  and in Writer the choice anycase was to allow opening separate too. (Cor, 
after discussion on 20150128)
 + the bug report only discusses the separate formulas sidebar in calc (Jay)
 
* Easy Hacks to be filed:

+ Kendy: The Window's closing button should indeed close the window, not 
dock the sidebar
  https://bugs.freedesktop.org/show_bug.cgi?id=87217
+ Kendy: Do / find someone / easy-hack-ize automatic opening of the Track 
changes toolbar
  when there are tracked changes
+ Kendy: Check how hard it is to make sidebar honor the icon size setting
+ Kendy: Easy Hack-ize fixing of uno commands that need to be duplicated in 
Draw and Impress
+ https://bugs.freedesktop.org/show_bug.cgi?id=84258#c2
+ Kendy: Create Easy Hack for the Hi-contrast Sifr
+ Kendy: Adding 1.15 to the drop down list - 
https://bugs.freedesktop.org/show_bug.cgi?id=85949
+ Kendy: Research what is needed to do to only disable (not hide) the 
formula bar in Calc when Chart component
  is activated
+ Kendy: Tell Jay how to fiddle with the default position of toolbars (so 
that he can tweak the Chart's toolbars)
+ Kendy: Only activate image toolbar when an image is selected - 
https://bugs.freedesktop.org/show_bug.cgi?id=87362
+ Adolfo: Create easy hacks for the options Design decided to drop since 
2012:
  https://wiki.documentfoundation.org/Design/Whiteboards/Options/Global
+ Kendy: Should border around an image have no padding by default
  https://bugs.freedesktop.org/show_bug.cgi?id=87360
 
* GSoC tasks to be filed:

+ Jay: add a Styles usability improvements section + list the various 
things to implement to GSoC-next ideas
+ https://wiki.documentfoundation.org/Development/GSoC/GenialIdeas
  [styles previews in the sidebar etc.]
+ Ahmed, Jay: Brainstorm about some nice / more styles for Calc
  https://redmine.documentfoundation.org/boards/1/topics/493
  [longer term - maybe better to add to the GSoC Styles task?]
+ Jay: Impress also needs more default object styles (only 2 are 
available)
  
* Residual issues with BZ migration? Heiko not receiving digest subscription of 
ux-advise issues, while
  those taking all UX-advise seeing issues.

[Libreoffice-commits] core.git: 2 commits - formula/source include/formula sc/inc

2015-03-11 Thread Eike Rathke
 formula/source/core/resource/core_resource.src |   31 +
 include/formula/compiler.hrc   |9 +--
 include/formula/opcode.hxx |5 
 sc/inc/token.hxx   |   16 
 4 files changed, 53 insertions(+), 8 deletions(-)

New commits:
commit 7867b976e8cb68a30df3cc825ccaa021269e219a
Author: Eike Rathke er...@redhat.com
Date:   Wed Mar 11 21:01:54 2015 +0100

TableRef: add item specifiers and opcodes

Change-Id: I043db29e3e1023566682b1df63a1d663dd432fee

diff --git a/formula/source/core/resource/core_resource.src 
b/formula/source/core/resource/core_resource.src
index 0fd104f..b6e6f7e 100644
--- a/formula/source/core/resource/core_resource.src
+++ b/formula/source/core/resource/core_resource.src
@@ -30,6 +30,7 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH_ODFF
 String SC_OPCODE_CHOOSE { Text = CHOOSE ; };
 String SC_OPCODE_OPEN { Text = ( ; };
 String SC_OPCODE_CLOSE { Text = ) ; };
+// SC_OPCODE_TABLE_REF_... not supported in ODFF
 String SC_OPCODE_ARRAY_OPEN { Text = { ; };
 String SC_OPCODE_ARRAY_CLOSE { Text = } ; };
 String SC_OPCODE_ARRAY_ROW_SEP { Text = | ; };
@@ -441,6 +442,11 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH_OOXML
 String SC_OPCODE_CLOSE { Text = ) ; };
 String SC_OPCODE_TABLE_REF_OPEN { Text = [ ; };
 String SC_OPCODE_TABLE_REF_CLOSE { Text = ] ; };
+String SC_OPCODE_TABLE_REF_ITEM_ALL { Text = #All ; };
+String SC_OPCODE_TABLE_REF_ITEM_HEADERS { Text = #Headers ; };
+String SC_OPCODE_TABLE_REF_ITEM_DATA { Text = #Data ; };
+String SC_OPCODE_TABLE_REF_ITEM_TOTALS { Text = #Totals ; };
+String SC_OPCODE_TABLE_REF_ITEM_THIS_ROW { Text = #This Row ; };
 String SC_OPCODE_ARRAY_OPEN { Text = { ; };
 String SC_OPCODE_ARRAY_CLOSE { Text = } ; };
 String SC_OPCODE_ARRAY_ROW_SEP { Text = ; ; };
@@ -854,6 +860,11 @@ Resource RID_STRLIST_FUNCTION_NAMES_ENGLISH
 String SC_OPCODE_CLOSE { Text = ) ; };
 String SC_OPCODE_TABLE_REF_OPEN { Text = [ ; };
 String SC_OPCODE_TABLE_REF_CLOSE { Text = ] ; };
+String SC_OPCODE_TABLE_REF_ITEM_ALL { Text = #All ; };
+String SC_OPCODE_TABLE_REF_ITEM_HEADERS { Text = #Headers ; };
+String SC_OPCODE_TABLE_REF_ITEM_DATA { Text = #Data ; };
+String SC_OPCODE_TABLE_REF_ITEM_TOTALS { Text = #Totals ; };
+String SC_OPCODE_TABLE_REF_ITEM_THIS_ROW { Text = #This Row ; };
 String SC_OPCODE_ARRAY_OPEN { Text = { ; };
 String SC_OPCODE_ARRAY_CLOSE { Text = } ; };
 String SC_OPCODE_ARRAY_ROW_SEP { Text = | ; };
@@ -1276,6 +1287,26 @@ Resource RID_STRLIST_FUNCTION_NAMES
 String SC_OPCODE_CLOSE { Text = ) ; };
 String SC_OPCODE_TABLE_REF_OPEN { Text = [ ; };
 String SC_OPCODE_TABLE_REF_CLOSE { Text = ] ; };
+String SC_OPCODE_TABLE_REF_ITEM_ALL
+{
+Text [ en-US ] = #All ;
+};
+String SC_OPCODE_TABLE_REF_ITEM_HEADERS
+{
+Text [ en-US ] = #Headers ;
+};
+String SC_OPCODE_TABLE_REF_ITEM_DATA
+{
+Text [ en-US ] = #Data ;
+};
+String SC_OPCODE_TABLE_REF_ITEM_TOTALS
+{
+Text [ en-US ] = #Totals ;
+};
+String SC_OPCODE_TABLE_REF_ITEM_THIS_ROW
+{
+Text [ en-US ] = #This Row ;
+};
 String SC_OPCODE_ARRAY_OPEN { Text = { ; };
 String SC_OPCODE_ARRAY_CLOSE { Text = } ; };
 String SC_OPCODE_ARRAY_ROW_SEP { Text = | ; };
diff --git a/include/formula/compiler.hrc b/include/formula/compiler.hrc
index 9131ce0..1fd4a58 100644
--- a/include/formula/compiler.hrc
+++ b/include/formula/compiler.hrc
@@ -53,8 +53,13 @@
 #define SC_OPCODE_ARRAY_COL_SEP  27 /* some convs use sep != col_sep */
 #define SC_OPCODE_TABLE_REF_OPEN 28
 #define SC_OPCODE_TABLE_REF_CLOSE29
-#define SC_OPCODE_STOP_DIV   30
-#define SC_OPCODE_SKIP   31 /* used to skip raw tokens during 
string compilation */
+#define SC_OPCODE_TABLE_REF_ITEM_ALL  30
+#define SC_OPCODE_TABLE_REF_ITEM_HEADERS  31
+#define SC_OPCODE_TABLE_REF_ITEM_DATA 32
+#define SC_OPCODE_TABLE_REF_ITEM_TOTALS   33
+#define SC_OPCODE_TABLE_REF_ITEM_THIS_ROW 34
+#define SC_OPCODE_STOP_DIV   35
+#define SC_OPCODE_SKIP   36 /* used to skip raw tokens during 
string compilation */
 
 /*** error constants #... ***/
 #define SC_OPCODE_START_ERRORS   40
diff --git a/include/formula/opcode.hxx b/include/formula/opcode.hxx
index c093ab5..fa4c1bf 100644
--- a/include/formula/opcode.hxx
+++ b/include/formula/opcode.hxx
@@ -53,6 +53,11 @@ enum OpCode : sal_uInt16
 ocStringXML = SC_OPCODE_STRINGXML,
 ocSpaces= SC_OPCODE_SPACES,
 ocMatRef= SC_OPCODE_MAT_REF,
+ocTableRefItemAll = SC_OPCODE_TABLE_REF_ITEM_ALL,
+ocTableRefItemHeaders = SC_OPCODE_TABLE_REF_ITEM_HEADERS,
+ocTableRefItemData= SC_OPCODE_TABLE_REF_ITEM_DATA,
+ocTableRefItemTotals  = 

[Libreoffice-commits] core.git: 2 commits - animations/Library_animcore.mk animations/source

2015-03-11 Thread Stephan Bergmann
 animations/Library_animcore.mk|1 
 animations/source/animcore/animcore.component |   35 ++-
 animations/source/animcore/animcore.cxx   |  232 ++
 animations/source/animcore/factreg.cxx|   69 ---
 animations/source/animcore/factreg.hxx|   46 -
 5 files changed, 228 insertions(+), 155 deletions(-)

New commits:
commit 6d97df009dc9cf733781643b00911e5324e1a6f5
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Mar 11 16:50:54 2015 +0100

Clean up previous commit

...and fix AnimationNode::getSupportedServiceNames

Change-Id: I199bc5a58174873794f082b149352359918bfc6b

diff --git a/animations/source/animcore/animcore.component 
b/animations/source/animcore/animcore.component
index 4ec3d12..c6c4cce 100644
--- a/animations/source/animcore/animcore.component
+++ b/animations/source/animcore/animcore.component
@@ -18,7 +18,7 @@
  --
 
 component loader=com.sun.star.loader.SharedLibrary environment=@CPPU_ENV@
-prefix=animcore xmlns=http://openoffice.org/2010/uno-components;
+xmlns=http://openoffice.org/2010/uno-components;
   implementation name=animcore::Animate
   constructor=com_sun_star_animations_Animate_get_implementation
 service name=com.sun.star.animations.Animate/
diff --git a/animations/source/animcore/animcore.cxx 
b/animations/source/animcore/animcore.cxx
index 1f6d43d..9b804a9 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -58,8 +58,6 @@
 #include algorithm
 #include string.h
 
-#include factreg.hxx
-
 using ::osl::Mutex;
 using ::osl::Guard;
 using ::cppu::OInterfaceContainerHelper;
@@ -901,6 +899,8 @@ Sequence OUString  
AnimationNode::getSupportedServiceNames(void) throw(std::ex
 return getSupportedServiceNames_ANIMATEMOTION();
 case AnimationNodeType::TRANSITIONFILTER:
 return getSupportedServiceNames_TRANSITIONFILTER();
+case AnimationNodeType::ANIMATETRANSFORM:
+return getSupportedServiceNames_ANIMATETRANSFORM();
 case AnimationNodeType::AUDIO:
 return getSupportedServiceNames_AUDIO();
 case AnimationNodeType::COMMAND:
diff --git a/animations/source/animcore/factreg.hxx 
b/animations/source/animcore/factreg.hxx
deleted file mode 100644
index 152976c..000
--- a/animations/source/animcore/factreg.hxx
+++ /dev/null
@@ -1,62 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the License); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-#ifndef INCLUDED_ANIMATIONS_SOURCE_ANIMCORE_FACTREG_HXX
-#define INCLUDED_ANIMATIONS_SOURCE_ANIMCORE_FACTREG_HXX
-
-namespace animcore {
-
-extern OUString getImplementationName_PAR();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_PAR();
-
-extern OUString getImplementationName_SEQ();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_SEQ();
-
-extern OUString getImplementationName_ITERATE();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_ITERATE();
-
-extern OUString getImplementationName_ANIMATE();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_ANIMATE();
-
-extern OUString getImplementationName_SET();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_SET();
-
-extern OUString getImplementationName_ANIMATECOLOR();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_ANIMATECOLOR();
-
-extern OUString getImplementationName_ANIMATEMOTION();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_ANIMATEMOTION();
-
-extern OUString getImplementationName_ANIMATETRANSFORM();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_ANIMATETRANSFORM();
-
-extern OUString getImplementationName_TRANSITIONFILTER();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_TRANSITIONFILTER();
-
-extern OUString getImplementationName_AUDIO();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_AUDIO();
-
-extern OUString getImplementationName_COMMAND();
-extern ::com::sun::star::uno::Sequence OUString 
getSupportedServiceNames_COMMAND();

Minutes of the Design Hangout: 2015-02-11

2015-03-11 Thread Jan Holesovsky
* Present: Heiko, Ibrahim, Jay, Kendy, Stuart
 
* Completed Action Items:

+ Jay/Kendy: GSoC for application (color) themes. (added it, Kendy add the 
rest)
  
https://wiki.documentfoundation.org/Development/GSoC/Ideas#Application_Themes
  
https://docs.google.com/document/d/1J_aogLuQThqhvT0R2em27Vpew-SLAQgpH5TbNTgXPZM/edit?usp=sharing
+ Kendy: More work around templates repository / online templates / 
integration into the start screen / ...
  https://bugs.freedesktop.org/show_bug.cgi?id=85420
  https://bugs.freedesktop.org/attachment.cgi?id=108377
+ Heiko/Kendy: Rework of the Tools - Customization... dialog
  http://user-prompt.com/how-to-make-libreoffice-customization-usable/
+ will create a bug report for that (Heiko)
- https://bugs.documentfoundation.org/show_bug.cgi?id=88896
+ Kendy/Jay: Document preview in open dialog
  Adolfo suggest this be a GSoC
  https://bugs.freedesktop.org/show_bug.cgi?id=87748
+ need to double-check the technical feasibility - if that's the 
system's responsibility or LO's
+ maybe we should re-consider a bit how we are opening files
+ very hard to setup connection to google docs / onedrive etc.
Have popular CMIS pre-configured in LO custom dialog - 
https://bugs.freedesktop.org/show_bug.cgi?id=86699 
Easy access to online document storage services like Google Drive 
- https://bugs.freedesktop.org/show_bug.cgi?id=86703
 
* Pending Action Items:
 
+ Default document view for Writer, single page rather than automatic
  https://bugs.freedesktop.org/show_bug.cgi?id=88001
+ Stuart: Change the default to single page
+ Jay/Stuart: Change the tooltip to Multipage view or Multiple page 
view
  [https://bugs.freedesktop.org/show_bug.cgi?id=88001#c5 - would be 
great to get that to gerrit]
  AI: Stuart -- figure it out and get it posted.
+ Jay: Double check if we can change 'Spelling' to 'Spelling and Grammar'
  https://bugs.freedesktop.org/show_bug.cgi?id=87648
+ Jay: Send a mail to documentat...@global.libreoffice.org with the wiki 
page that collects changes in menus
+ Kendy: Collecting of the user information should be incremental, 
somewhere in the user's profile
+ Ahmed: Push the new Sifr icons he's done recently
+ Kendy: Talk to Milos wrt. 
https://bugs.freedesktop.org/show_bug.cgi?id=48622
+ Alex: Gnome 2.20-style 'a' icons  Gnome 3-style text line icons
+ Samuel: Formulas and Navigator should open in the sidebar, not as a 
special window
  https://bugs.freedesktop.org/show_bug.cgi?id=85897
+ Is that issue for the Navigator too (I dont read it from the issue)
  and in Writer the choice anycase was to allow opening separate too. 
(Cor, after discussion on 20150128)
+ the bug report only discusses the separate formulas sidebar in calc (Jay)
 
* Easy Hacks to be filed:

+ Kendy: The Window's closing button should indeed close the window, not 
dock the sidebar
  https://bugs.freedesktop.org/show_bug.cgi?id=87217
+ Kendy: Do / find someone / easy-hack-ize automatic opening of the Track 
changes toolbar
  when there are tracked changes
+ Kendy: Check how hard it is to make sidebar honor the icon size setting
+ Kendy: Easy Hack-ize fixing of uno commands that need to be duplicated in 
Draw and Impress
+ https://bugs.freedesktop.org/show_bug.cgi?id=84258#c2
+ Kendy: Create Easy Hack for the Hi-contrast Sifr
+ Kendy: Adding 1.15 to the drop down list - 
https://bugs.freedesktop.org/show_bug.cgi?id=85949
+ Kendy: Research what is needed to do to only disable (not hide) the 
formula bar in Calc when Chart component
  is activated
+ Kendy: Tell Jay how to fiddle with the default position of toolbars (so 
that he can tweak the Chart's toolbars)
+ Kendy: Only activate image toolbar when an image is selected - 
https://bugs.freedesktop.org/show_bug.cgi?id=87362
+ Adolfo: Create easy hacks for the options Design decided to drop since 
2012:
  https://wiki.documentfoundation.org/Design/Whiteboards/Options/Global
+ Kendy: Should border around an image have no padding by default
  https://bugs.freedesktop.org/show_bug.cgi?id=87360
 
* GSoC tasks to be filed:

+ Jay: add a Styles usability improvements section + list the various 
things to implement to GSoC-next ideas
+ https://wiki.documentfoundation.org/Development/GSoC/GenialIdeas
  [styles previews in the sidebar etc.]
+ Ahmed, Jay: Brainstorm about some nice / more styles for Calc
  https://redmine.documentfoundation.org/boards/1/topics/493
  [longer term - maybe better to add to the GSoC Styles task?]
+ Jay: Impress also needs more default object styles (only 2 are 
available)
+ Kendy: On-demand / programmatic colorization of the Sifr icons
+ Kendy: Change tracking UI in the document
 
* UI changes 

[Libreoffice-bugs] [Bug 61908] FILESAVE: Array Formulas Not Stored Correctly In XLSX Format (ods/xls work fine)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61908

Jim Avera jim.av...@gmail.com changed:

   What|Removed |Added

 Attachment #114045|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 56126] EDITING: Conditional field and vertical separator

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=56126

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   Priority|medium  |low
 CC||jmadero@gmail.com
   Hardware|x86-64 (AMD64)  |All
   Severity|normal  |major

--- Comment #6 from Joel Madero jmadero@gmail.com ---
Prioritizing:
*Please do not adjust the priority without consulting QA on the mailing list or
in the chat room http://webchat.freenode.net/?channels=libreoffice-qa

Priorities are set per this chart:
https://wiki.documentfoundation.org/File:Prioritizing_Bugs_Flowchart.jpg

Major: - loss of data
Low: In several years we have seen no duplicates, no additional users outside
of QA confirming, etc... pretty obvious that this is a corner case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 54860] FORMATTING: Indentation handles on horizontal ruler sometimes stuck in Print Layout

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=54860

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

   Priority|medium  |low
   Hardware|x86-64 (AMD64)  |All
   Severity|normal  |minor

--- Comment #11 from Joel Madero jmadero@gmail.com ---
Prioritizing:
*Please do not adjust the priority without consulting QA on the mailing list or
in the chat room http://webchat.freenode.net/?channels=libreoffice-qa

Priorities are set per this chart:
https://wiki.documentfoundation.org/File:Prioritizing_Bugs_Flowchart.jpg


Minor - will not prevent high quality work but can slow you down;
Low - unless we have a reason to think this is a regression, the workaround is
pretty straight forward so default is appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: vcl/unx

2015-03-11 Thread Caolán McNamara
 vcl/unx/generic/gdi/cairotextrender.cxx  |1 +
 vcl/unx/generic/gdi/openglx11cairotextrender.cxx |1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 4c11ac451a00e552899429253652a6423829573b
Author: Caolán McNamara caol...@redhat.com
Date:   Wed Mar 11 17:34:02 2015 +

flush surface for all backends

Change-Id: Ifa6f7f9a816096bfe9f44baca17b34e54b83a5c6

diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx 
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 0445771..b107c95 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -338,6 +338,7 @@ void CairoTextRender::DrawServerFontLayout( const 
ServerFontLayout rLayout )
 aI = aNext;
 }
 
+cairo_surface_flush(cairo_get_target(cr));
 drawSurface(cr);
 cairo_destroy(cr);
 }
diff --git a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx 
b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
index 8edeba8..dbb6ecf 100644
--- a/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/openglx11cairotextrender.cxx
@@ -65,7 +65,6 @@ void OpenGLX11CairoTextRender::drawSurface(cairo_t* cr)
 cairo_surface_t* pSurface = cairo_get_target(cr);
 int nWidth = cairo_image_surface_get_width( pSurface );
 int nHeight = cairo_image_surface_get_height( pSurface );
-cairo_surface_flush( pSurface );
 unsigned char *pSrc = cairo_image_surface_get_data( pSurface );
 
 // XXX: lfrb: GLES 2.0 doesn't support GL_UNSIGNED_INT_8_8_8_8_REV
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits


[Libreoffice-bugs] [Bug 65323] Objects anchored as characters aren't treated as characters

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=65323

--- Comment #8 from sergio.calleg...@gmail.com ---
Bug still present as of 4.4.1.2.

Please give this bug adequate attention as it contributes strongly to failures
in attempts at advocating the use of LibO in the scientific academic community.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89939] FILEOPEN XLS using Import Options Auto Data Missing

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89939

--- Comment #2 from Mateo ms...@senecamedical.com ---
(In reply to raal from comment #1)
 It's a xml file with .xls extension

Is there a way to open this type of file (xml) with LO?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - avmedia/source avmedia/util

2015-03-11 Thread Stephan Bergmann
 avmedia/source/framework/soundhandler.cxx |   70 +++---
 avmedia/source/framework/soundhandler.hxx |   12 -
 avmedia/util/avmedia.component|5 +-
 3 files changed, 12 insertions(+), 75 deletions(-)

New commits:
commit d7b48d03b6b08c3a324a44513b622146263c725a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Mar 11 18:38:16 2015 +0100

Clean up previous commit

Change-Id: I0e0351177fa72b7aeff7e2d61122f4590e8e6311

diff --git a/avmedia/source/framework/soundhandler.cxx 
b/avmedia/source/framework/soundhandler.cxx
index 2995acf..24e478f 100644
--- a/avmedia/source/framework/soundhandler.cxx
+++ b/avmedia/source/framework/soundhandler.cxx
@@ -113,7 +113,7 @@ css::uno::Sequence css::uno::Type  SAL_CALL 
SoundHandler::getTypes() throw( cs
 
/*===*/
 OUString SAL_CALL SoundHandler::getImplementationName() throw( 
css::uno::RuntimeException, std::exception )
 {
-return impl_getStaticImplementationName();
+return IMPLEMENTATIONNAME_SOUNDHANDLER;
 }
 
 // XServiceInfo
@@ -125,27 +125,11 @@ sal_Bool SAL_CALL SoundHandler::supportsService( const 
OUString sServiceName )
 // XServiceInfo
 css::uno::Sequence OUString  SAL_CALL 
SoundHandler::getSupportedServiceNames() throw( css::uno::RuntimeException, 
std::exception )
 {
-return impl_getStaticSupportedServiceNames();
-}
-
-// Helper for XServiceInfo
-css::uno::Sequence OUString  
SoundHandler::impl_getStaticSupportedServiceNames()
-{
 css::uno::Sequence OUString  seqServiceNames( 1 );
 seqServiceNames.getArray() [0] = com.sun.star.frame.ContentHandler;
 return seqServiceNames;
 }
 
-// Helper for XServiceInfo
-OUString SoundHandler::impl_getStaticImplementationName()
-{
-return IMPLEMENTATIONNAME_SOUNDHANDLER;
-}
-
-void SAL_CALL SoundHandler::impl_initService()
-{
-}
-
 
/*-
 @short  standard ctor
 @descr  These initialize a new instance of this class with needed 
information for work.
@@ -156,13 +140,12 @@ void SAL_CALL SoundHandler::impl_initService()
 @onerrorShow an assertion and do nothing else.
 @threadsafe yes
 
*//*-*/
-SoundHandler::SoundHandler( const css::uno::Reference 
css::lang::XMultiServiceFactory  xFactory )
+SoundHandler::SoundHandler()
 //  Init baseclasses first
 :   ThreadHelpBase  (  )
 ,   ::cppu::OWeakObject (  )
 // Init member
 ,   m_bError( false)
-,   m_xFactory  ( xFactory )
 {
 m_aUpdateIdle.SetIdleHdl(LINK(this, SoundHandler, implts_PlayerNotify));
 }
@@ -357,13 +340,10 @@ IMPL_LINK_NOARG(SoundHandler, implts_PlayerNotify)
 
 
 extern C SAL_DLLPUBLIC_EXPORT ::com::sun::star::uno::XInterface* SAL_CALL
-com_sun_star_comp_framework_SoundHandler_get_implementation(::com::sun::star::uno::XComponentContext*
 context,
+com_sun_star_comp_framework_SoundHandler_get_implementation(::com::sun::star::uno::XComponentContext*,
 
::com::sun::star::uno::Sequencecss::uno::Any const )
 {
-css::uno::Reference css::lang::XMultiServiceFactory 
xSM(context-getServiceManager(), css::uno::UNO_QUERY_THROW);
-avmedia::SoundHandler* pClass = new avmedia::SoundHandler( xSM );
-pClass-impl_initService();
-return cppu::acquire( pClass );
+return cppu::acquire(new avmedia::SoundHandler);
 }
 
 
diff --git a/avmedia/source/framework/soundhandler.hxx 
b/avmedia/source/framework/soundhandler.hxx
index 2a39c9d..30b9b26 100644
--- a/avmedia/source/framework/soundhandler.hxx
+++ b/avmedia/source/framework/soundhandler.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_AVMEDIA_SOURCE_FRAMEWORK_SOUNDHANDLER_HXX
 
 #include com/sun/star/lang/XTypeProvider.hpp
-#include com/sun/star/lang/XMultiServiceFactory.hpp
 #include com/sun/star/frame/XNotifyingDispatch.hpp
 #include com/sun/star/frame/XStatusListener.hpp
 #include com/sun/star/frame/XFrame.hpp
@@ -74,7 +73,7 @@ class SoundHandler  :   // interfaces
 public:
 
 // constructor / destructor
- SoundHandler( const css::uno::Reference 
css::lang::XMultiServiceFactory  xFactory );
+ SoundHandler();
 virtual ~SoundHandler( 
   );
 
 //  XInterface, XTypeProvider, XServiceInfo
@@ -88,11 +87,6 @@ class SoundHandler  :   // interfaces
virtual OUString   SAL_CALL 
getImplementationName  (
   ) throw( css::uno::RuntimeException, 
std::exception ) SAL_OVERRIDE;
virtual 

[Libreoffice-bugs] [Bug 51644] FORMATTING: text animation suddenly not possible

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=51644

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 CC||jmadero@gmail.com

--- Comment #6 from Joel Madero jmadero@gmail.com ---
Prioritizing:
*Please do not adjust the priority without consulting QA on the mailing list or
in the chat room http://webchat.freenode.net/?channels=libreoffice-qa

Priorities are set per this chart:
https://wiki.documentfoundation.org/File:Prioritizing_Bugs_Flowchart.jpg

Normal - can prevent high quality/professional quality work;
Medium - default seems fine here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 68050] UI: Fields dialog does not preserve scroll position when focussed

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68050

Gordo gordon1dr...@yahoo.com changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 68050] UI: Fields dialog does not preserve scroll position when focussed

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=68050

--- Comment #3 from Gordo gordon1dr...@yahoo.com ---
Created attachment 114044
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114044action=edit
Sample document with endnotes

1. Open attached document.
2. Place cursor after a sentence and after sentences with endnotes.
3. Insert → Cross-reference.
4. Select Type → Endnotes.
5. Scroll down list but don't select any of the endnotes (first item in list is
still selected).
6. Click back on the document.
7. Select endnote xxii in cross reference dialog.
Expected Result:
Endnote xxii is highlighted.
Result:
Selection jumps to xxvii, which is highlighted.  At this point you don't have
to insert the wrong reference.
Alternate:
6. Switch to another open application.
7. Switch back to document.
Result:
Scroll position has reset.

This is in Windows Vista (Really?!).  The only difference I had with how it was
reported is that it was not possible to mouse wheel scroll when the cross
reference dialog does not have focus.

Version: 4.4.1.2
Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61908] FILESAVE: Array Formulas Not Stored Correctly In XLSX Format (ods/xls work fine)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61908

--- Comment #11 from Jim Avera jim.av...@gmail.com ---
Created attachment 114047
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114047action=edit
Another simple test case with embedded instructions

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 61908] FILESAVE: Array Formulas Not Stored Correctly In XLSX Format (ods/xls work fine)

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=61908

Jim Avera jim.av...@gmail.com changed:

   What|Removed |Added

 CC||jim.av...@gmail.com

--- Comment #10 from Jim Avera jim.av...@gmail.com ---
Created attachment 114045
  -- https://bugs.documentfoundation.org/attachment.cgi?id=114045action=edit
Another simple test case

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78840

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Joel Madero jmadero@gmail.com ---
Talked to the dev room and they say this is valid - although might confuse
users with yet more options.

As such marking as NEW.

Also got this from one of the devs: well a workaround would be to use \u
(see https://help.libreoffice.org/Common/List_of_Regular_Expressions ) -- no
clue what that means but maybe it'll help those who are interested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78840

Joel Madero jmadero@gmail.com changed:

   What|Removed |Added

 Whiteboard|NeedAdvice  |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 78840] Add the regular expression (?ismwx-ismwx: ... ) Flag settings. Evaluate parenthesized expression with specifics flags enabled or -disabled. To have a case sensitive mode

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=78840

--- Comment #2 from Eike Rathke er...@redhat.com ---
Well, valid request doesn't mean it would come easy.. it would be yet another
option in the calculation settings confusing more users, rework how text is fed
to the regex matcher (with or without ignore-case transliteration), and last
but not least would have to be stored in the document, yet another ODF
extension I presume.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89933] Calc crashes after pressing F2 after keyboard formatted input

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89933

Julien Nabet serval2...@yahoo.fr changed:

   What|Removed |Added

   Keywords||have-backtrace
 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet serval2...@yahoo.fr ---
part of bt:
#2  0x2aaace88307e in WrongList::empty (this=0x0) at
/home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/edtspell.cxx:519
#3  0x2aaace8d3d76 in ImpEditEngine::Paint (this=0x2eb66a0,
pOutDev=0x2c53420, aClipRect=Rectangle = {...}, aStartPos=Point = {...},
bStripOnly=false, nOrientation=0)
at
/home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/impedit3.cxx:3478
#4  0x2aaace8d5cc7 in ImpEditEngine::Paint (this=0x2eb66a0,
pView=0x3095930, rRect=Rectangle = {...}, pTargetDevice=0x2c53420,
bUseVirtDev=false)
at
/home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/impedit3.cxx:3859
#5  0x2aaace87a3e0 in EditView::Paint (this=0x3035010, rRect=Rectangle =
{...}, pTargetDevice=0x2c53420)
at
/home/julien/compile-libreoffice/libreoffice/editeng/source/editeng/editview.cxx:268
#6  0x2aaacbc1b040 in ScGridWindow::DrawContent (this=0x2c53420,
rDevice=..., rTableInfo=..., aOutputData=..., bLogicText=false,
eMode=SC_UPDATE_MARKS)
at
/home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:891
#7  0x2aaacbc193aa in ScGridWindow::Draw (this=0x2c53420, nX1=0, nY1=0,
nX2=16, nY2=0, eMode=SC_UPDATE_MARKS)
at
/home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:508
#8  0x2aaacbc187b2 in ScGridWindow::Paint (this=0x2c53420, rRect=Rectangle
= {...}) at
/home/julien/compile-libreoffice/libreoffice/sc/source/ui/view/gridwin4.cxx:374
#9  0x2aaab1767058 in PaintHelper::DoPaint (this=0x7fff4720,
pRegion=0x0) at
/home/julien/compile-libreoffice/libreoffice/vcl/source/window/paint.cxx:125

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: include/xmloff sc/inc sc/qa sc/source sc/uiconfig xmloff/source

2015-03-11 Thread Deena Francis
 include/xmloff/xmltoken.hxx|1 
 sc/inc/dapiuno.hxx |2 
 sc/inc/dpsave.hxx  |5 
 sc/inc/dptabsrc.hxx|2 
 sc/inc/pivot.hxx   |1 
 sc/inc/unonames.hxx|2 
 sc/qa/unit/ucalc.hxx   |6 
 sc/qa/unit/ucalc_pivottable.cxx|  173 ++---
 sc/source/core/data/dpobject.cxx   |3 
 sc/source/core/data/dpsave.cxx |   11 +
 sc/source/core/data/dptabres.cxx   |   14 +-
 sc/source/core/data/dptabsrc.cxx   |8 +
 sc/source/core/data/pivot2.cxx |3 
 sc/source/filter/xml/XMLExportDataPilot.cxx|5 
 sc/source/filter/xml/xmldpimp.cxx  |5 
 sc/source/filter/xml/xmldpimp.hxx  |1 
 sc/source/filter/xml/xmlimprt.cxx  |1 
 sc/source/filter/xml/xmlimprt.hxx  |3 
 sc/source/ui/dbgui/PivotLayoutDialog.cxx   |1 
 sc/source/ui/dbgui/pvfundlg.cxx|4 
 sc/source/ui/inc/pvfundlg.hxx  |1 
 sc/source/ui/unoobj/dapiuno.cxx|   25 +++
 sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui |   16 ++
 xmloff/source/core/xmltoken.cxx|1 
 24 files changed, 244 insertions(+), 50 deletions(-)

New commits:
commit 7b355da6853af6678c4ba22710d157cf8a6d43eb
Author: Deena Francis deena.fran...@gmail.com
Date:   Mon Feb 16 22:28:52 2015 +0530

Enhancement tdf#87972 :  Cannot repeat items labels on a pivot table

Change-Id: I44b2521ea548b51a1b3e9b42cfa64c5f50d7798a
Reviewed-on: https://gerrit.libreoffice.org/14504
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Kohei Yoshida libreoff...@kohei.us
Tested-by: Kohei Yoshida libreoff...@kohei.us

diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index 1fb984f..ef40853 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -2637,6 +2637,7 @@ namespace xmloff { namespace token {
 XML_DEFAULT_OUTLINE_LEVEL,
 XML_SHOW_DETAILS,
 XML_SHOW_EMPTY,
+XML_REPEAT_ITEM_LABELS,
 XML_ITERATIVE,
 XML_uX,
 XML_NP_DLG,
diff --git a/sc/inc/dapiuno.hxx b/sc/inc/dapiuno.hxx
index f034767..6bedada 100644
--- a/sc/inc/dapiuno.hxx
+++ b/sc/inc/dapiuno.hxx
@@ -586,6 +586,8 @@ public:
 void setSortInfo(const com::sun::star::sheet::DataPilotFieldSortInfo* 
pInfo);
 bool getShowEmpty() const;
 void setShowEmpty(bool bShow);
+bool getRepeatItemLabels() const;
+void setRepeatItemLabels(bool bShow);
 
 bool hasGroupInfo();
 com::sun::star::sheet::DataPilotFieldGroupInfo getGroupInfo();
diff --git a/sc/inc/dpsave.hxx b/sc/inc/dpsave.hxx
index c9bf960..9b2136b 100644
--- a/sc/inc/dpsave.hxx
+++ b/sc/inc/dpsave.hxx
@@ -106,6 +106,7 @@ private:
 sal_uInt16 nFunction; // enum GeneralFunction, for data dimensions
 long nUsedHierarchy;
 sal_uInt16 nShowEmptyMode; //! at level
+bool bRepeatItemLabels; //! at level
 bool bSubTotalDefault; //! at level
 long nSubTotalCount;
 sal_uInt16* pSubTotalFuncs; // enum GeneralFunction
@@ -162,6 +163,10 @@ public:
 bool GetShowEmpty() const
 { return bool(nShowEmptyMode); }
 
+void SetRepeatItemLabels(bool bSet);
+bool GetRepeatItemLabels() const
+{ return bRepeatItemLabels; }
+
 void SetFunction(sal_uInt16 nNew); // enum GeneralFunction
 sal_uInt16 GetFunction() const
 { return nFunction; }
diff --git a/sc/inc/dptabsrc.hxx b/sc/inc/dptabsrc.hxx
index 016e709..c07a242 100644
--- a/sc/inc/dptabsrc.hxx
+++ b/sc/inc/dptabsrc.hxx
@@ -564,6 +564,7 @@ private:
 longnAutoMeasure;   // measure (index of data 
dimension) for AutoShow
 boolbShowEmpty:1;
 boolbEnableLayout:1;  // enabled only for row 
fields, not for the innermost one
+boolbRepeatItemLabels:1;
 
 public:
 ScDPLevel( ScDPSource* pSrc, long nD, long nH, 
long nL );
@@ -635,6 +636,7 @@ public:
 
 com::sun::star::uno::Sequencecom::sun::star::sheet::GeneralFunction 
getSubTotals() const;
 bool getShowEmpty() const { return bShowEmpty;}
+bool getRepeatItemLabels() const { return bRepeatItemLabels; }
 
 const ::com::sun::star::sheet::DataPilotFieldSortInfo GetSortInfo() const 
 { return aSortInfo; }
 const ::com::sun::star::sheet::DataPilotFieldAutoShowInfo GetAutoShow() 
const  { return aAutoShowInfo; }
diff --git a/sc/inc/pivot.hxx b/sc/inc/pivot.hxx
index 3fdabb2..35e6e60 100644
--- a/sc/inc/pivot.hxx
+++ b/sc/inc/pivot.hxx
@@ -75,6 +75,7 @@ struct ScDPLabelData
 bool   mbShowAll:1;/// true = Show all (also empty) results.
 bool   mbIsValue:1;/// true = Sum or count in data 

[Libreoffice-commits] core.git: 2 commits - svl/Library_svl.mk svl/source svl/util

2015-03-11 Thread Stephan Bergmann
 svl/Library_svl.mk  |1 
 svl/source/inc/registerservices.hxx |   46 -
 svl/source/numbers/numfmuno.cxx |   17 +++---
 svl/source/numbers/supservs.cxx |   16 --
 svl/source/numbers/supservs.hxx |   11 
 svl/source/uno/pathservice.cxx  |   14 ++---
 svl/source/uno/registerservices.cxx |   94 
 svl/util/svl.component  |   11 ++--
 8 files changed, 37 insertions(+), 173 deletions(-)

New commits:
commit 888c28dd07ad97454231e0ff7e976f311b39e40c
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Mar 11 22:47:53 2015 +0100

Clean up previous commit

Change-Id: I6ecc801d19c54ff93559bff627b99c656e71a6e4

diff --git a/svl/source/numbers/supservs.hxx b/svl/source/numbers/supservs.hxx
index e49f399..da04e95 100644
--- a/svl/source/numbers/supservs.hxx
+++ b/svl/source/numbers/supservs.hxx
@@ -25,11 +25,6 @@
 #include com/sun/star/lang/XInitialization.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
 
-extern C ::com::sun::star::uno::XInterface *
-SAL_CALL 
com_sun_star_uno_util_numbers_SvNumberFormatsSupplierServiceObject_get_implementation(
-::com::sun::star::uno::XComponentContext* context,
-::com::sun::star::uno::Sequencecss::uno::Any const );
-
 /**
  * SvNumberFormatsSupplierServiceObject - a number formats supplier which
  * - can be instantiated as an service
@@ -38,16 +33,10 @@ extern C ::com::sun::star::uno::XInterface *
  * with a specific language (i.e. ::com::sun::star::lang::Locale)
  */
 class SvNumberFormatsSupplierServiceObject
-:protected SvNumberFormatsSupplierObj
+:public SvNumberFormatsSupplierObj
 ,public ::com::sun::star::lang::XInitialization
 ,public ::com::sun::star::lang::XServiceInfo
-{   // don't want the Set-/GetNumberFormatter to be accessible from outside
-
-friend ::com::sun::star::uno::XInterface *
-SAL_CALL 
com_sun_star_uno_util_numbers_SvNumberFormatsSupplierServiceObject_get_implementation(
-::com::sun::star::uno::XComponentContext* context,
-::com::sun::star::uno::Sequencecss::uno::Any const );
-
+{
 protected:
 SvNumberFormatter*  m_pOwnFormatter;
 ::com::sun::star::uno::Reference ::com::sun::star::uno::XComponentContext 

diff --git a/svl/source/uno/pathservice.cxx b/svl/source/uno/pathservice.cxx
index 8e02fd8..00e81d8 100644
--- a/svl/source/uno/pathservice.cxx
+++ b/svl/source/uno/pathservice.cxx
@@ -26,7 +26,10 @@
 #include com/sun/star/frame/XConfigManager.hpp
 #include com/sun/star/lang/XMultiServiceFactory.hpp
 #include com/sun/star/lang/XServiceInfo.hpp
-#include com/sun/star/uno/XComponentContext.hpp
+
+namespace com { namespace sun { namespace star { namespace uno {
+class XComponentContext;
+} } } }
 
 class PathService : public ::cppu::WeakImplHelper2 
css::frame::XConfigManager, css::lang::XServiceInfo 
 {
diff --git a/svl/util/svl.component b/svl/util/svl.component
index e50f918..eabd64d 100644
--- a/svl/util/svl.component
+++ b/svl/util/svl.component
@@ -18,7 +18,7 @@
  --
 
 component loader=com.sun.star.loader.SharedLibrary environment=@CPPU_ENV@
-prefix=svl xmlns=http://openoffice.org/2010/uno-components;
+xmlns=http://openoffice.org/2010/uno-components;
   implementation name=com.sun.star.comp.svl.PathService
   constructor=com_sun_star_comp_svl_PathService_get_implementation
 service name=com.sun.star.config.SpecialConfigManager/
commit 0214898aa695bc17a40007e82dad3542d855ea70
Author: Chris Sherlock chris.sherl...@collabora.com
Date:   Mon Mar 2 16:25:59 2015 +1100

svl: use constructor syntax in svl.component

Change-Id: I2cb78695ede4017dfc4594175268e3d3c7eb4eca
Signed-off-by: Stephan Bergmann sberg...@redhat.com

diff --git a/svl/Library_svl.mk b/svl/Library_svl.mk
index 0754157..db08af5 100644
--- a/svl/Library_svl.mk
+++ b/svl/Library_svl.mk
@@ -139,7 +139,6 @@ $(eval $(call gb_Library_add_exception_objects,svl,\
 svl/source/svsql/converter \
 svl/source/undo/undo \
 svl/source/uno/pathservice \
-svl/source/uno/registerservices \
 ))
 
 ifeq ($(OS),WNT)
diff --git a/svl/source/inc/registerservices.hxx 
b/svl/source/inc/registerservices.hxx
deleted file mode 100644
index a6af007..000
--- a/svl/source/inc/registerservices.hxx
+++ /dev/null
@@ -1,46 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional 

[Libreoffice-bugs] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83726

Octavio Alvarez alvar...@alvarezp.ods.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #13 from Octavio Alvarez alvar...@alvarezp.ods.org ---
This is clearly not a bug as stated in previous comments. The paragraph has the
'regular weight' formatting attribute directly applied, and thus, everything
else is working just as designed.

It *is* consistent and users that know how this works will find quickly resort
to using CTRL+M to make sure Direct Formatting is not affecting the application
of styles.

The user abused DF by removing DF by applying more DF. In fact, the user
applied bold in the first place because he didn't know how to use Character
Styles (or he was lazy). That's not a bug of the program.

To override part of the paragraph, the user had three options. Please see the
example that follows:

1. Delete all text after the period in original., including next paragraphs.
Make sure the period is the very last character.

2. Select the last paragraph (Shiffer [...] original.) and hit CTRL+M.

With this the paragraph is DF-clean [*].

3. While still selected, hit Ctrl+B for Bold.

4. Select no different [...] original. and hit Ctrl+B again.

This is how the user got into this situation. Continue with the reproduction of
the behavior:

5. Hit Enter.

6. Apply Heading 3.

7. Type. -- Text is correctly of regular weight.

The user had 3 chances of doing things right.

First and proper one, use Character Styles:

3. Only mark Shifer [...] Books and apply the Strong emphasis character
style. Select the paragraph and hit Ctrl+M; you'll notice the document keeps
the bold because no DF is applied; no place for confusion.

Second one, only override what is needed:

3. Only mark Shifer [...] Books and hit Ctrl+B.

Third one, un-override the formatting instead of reoverriding it:

4. Select no different [...] original. and hit Ctrl+M to remove his DF,
instead of overriding it with more DF.

Because this bug is about consistent application of character properties and
Writer *is* consistently applying character properties, this is clearly not a
bug and thus I'm closing it as such.

The confusion arises from the visual semantics of the second click on the
Bold button. Visually, the bold button is unpressed, the mental mapping
being that the DF is removed and leaving the last part paragraph DF-clean, and
thus, having the application of Header 3 behave as expected. Reality is
different: By re-clicking on the Bold button, another DF is applied to change
Bold weight for Regular weight. This is where the confusion comes from. What if
the style is Header 3 and we clicked on Bold to unpress it to override the
bold for a regular weight?

[*] I abbreviate Direct Formatting as DF.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 89931] Feature request: FORMATTING with returns

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89931

--- Comment #2 from Neil gonegah...@hotmail.com ---
This is more to do with user defined formats.
Was hoping for some way to include a [return] into the format so that the
result can be made to appear over two or more lines.  eg.
10/11
2015
in a single cell by a user format something like:  DD/MM[return]YY
The user need only type 10/11/2015 but it would appear over the two lines?
Presently I have to use two cells with the date in the top and a formula in the
bottom which just feels messy and awkward.
Any chance of adding something like this?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-commits] core.git: 2 commits - vcl/source

2015-03-11 Thread Tor Lillqvist
 vcl/source/gdi/pdfwriter_impl.cxx |   25 -
 1 file changed, 12 insertions(+), 13 deletions(-)

New commits:
commit 33434f47ac44f5cb4612a11b1c28c4582976cb25
Author: Tor Lillqvist t...@collabora.com
Date:   Thu Mar 12 00:31:18 2015 +0200

Fix crash when timestamping PDF signature

Using the NSS API for CMS and ASN.1-based stuff in general correctly is
extremely hard. It is very easy to do things slightly wrong. Of course no
compiler warnings are produced. You just get code that happens to work by
accident when compiled with one compiler, but not another, or depending on
contents of uninitialised memory, or the phase of the moon.

The problem was that the values field of a NSSCMSAttribute struct 
apparently
is supposed to point to *two* SECItem pointers, one pointing to the actual
value, and a NULL one.

Anyway, now valgrind finally does not complain about any use of 
uninitialised
memory.

Most likely my earlier recent commits to this file were not necessary after
all. They just seemed to help by accident, at least at one stage. But
whatever...

Change-Id: Ic98401b5d151bbb2398f809f47699f670e9720fa

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index bc29a4e..fc44073 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6893,7 +6893,9 @@ bool PDFWriterImpl::finalizeSignature()
 SECItem response_item;
 NSSCMSAttribute timestamp;
 SECItem values[2];
-SECItem *valuesp = values;
+SECItem *valuesp[2];
+valuesp[0] = values;
+valuesp[1] = NULL;
 SECOidData typetag;
 
 if( !m_aContext.SignTSA.isEmpty() )
@@ -7149,12 +7151,15 @@ bool PDFWriterImpl::finalizeSignature()
 
 // timestamp.type filled in below
 
+// Not sure if we actually need two entries in the values array, now 
when valuesp is an
+// array too, the pointer to the values array followed by a null 
pointer. But I don't feel
+// like experimenting.
 values[0] = response.timeStampToken;
 values[1].type = siBuffer;
 values[1].data = NULL;
 values[1].len = 0;
 
-timestamp.values = valuesp;
+timestamp.values = valuesp;
 
 typetag.oid.data = NULL;
 // id-aa-timeStampToken OBJECT IDENTIFIER ::= { iso(1)
commit 20e5de21225bfd2b55fcff6afcc235b035b38134
Author: Tor Lillqvist t...@collabora.com
Date:   Wed Mar 11 22:31:47 2015 +0200

Don't bother with macros that are dummy on Unix in Unix-only code

In NSS's secasn1t.h, for non-Windows:

 #define SEC_ASN1_SUB(x)x
 #define SEC_ASN1_XTRN  0
 #define SEC_ASN1_MKSUB(x)

Change-Id: Ie42d881cebffdd060309d6a15d8d9c319c260699

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index df2e74e..bc29a4e 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6299,16 +6299,10 @@ TimeStampResp ::= SEQUENCE  {
  timeStampToken TimeStampToken OPTIONAL  }
 */
 
-SEC_ASN1_MKSUB(SECOID_AlgorithmIDTemplate)
-SEC_ASN1_MKSUB(MessageImprint_Template)
-SEC_ASN1_MKSUB(Extensions_Template)
-SEC_ASN1_MKSUB(PKIStatusInfo_Template)
-SEC_ASN1_MKSUB(Any_Template)
-
 const SEC_ASN1Template MessageImprint_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(MessageImprint) },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(MessageImprint, 
hashAlgorithm), SEC_ASN1_SUB(SECOID_AlgorithmIDTemplate), 0 },
+{ SEC_ASN1_INLINE, offsetof(MessageImprint, hashAlgorithm), 
SECOID_AlgorithmIDTemplate, 0 },
 { SEC_ASN1_OCTET_STRING, offsetof(MessageImprint, hashedMessage), 0, 0 },
 { 0, 0, 0, 0 }
 };
@@ -6331,11 +6325,11 @@ const SEC_ASN1Template TimeStampReq_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(TimeStampReq) },
 { SEC_ASN1_INTEGER, offsetof(TimeStampReq, version), 0, 0 },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(TimeStampReq, messageImprint), 
SEC_ASN1_SUB(MessageImprint_Template), 0 },
+{ SEC_ASN1_INLINE, offsetof(TimeStampReq, messageImprint), 
MessageImprint_Template, 0 },
 { SEC_ASN1_OBJECT_ID | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, 
reqPolicy), 0, 0 },
 { SEC_ASN1_INTEGER | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, nonce), 0, 
0 },
 { SEC_ASN1_BOOLEAN | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, certReq), 
0, 0 },
-{ SEC_ASN1_XTRN | SEC_ASN1_OPTIONAL | SEC_ASN1_CONTEXT_SPECIFIC | 0, 
offsetof(TimeStampReq, extensions), SEC_ASN1_SUB(Extensions_Template), 0 },
+{ SEC_ASN1_OPTIONAL | SEC_ASN1_CONTEXT_SPECIFIC | 0, 
offsetof(TimeStampReq, extensions), Extensions_Template, 0 },
 { 0, 0, 0, 0 }
 };
 
@@ -6367,8 +6361,8 @@ typedef struct {
 const SEC_ASN1Template TimeStampResp_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(TimeStampResp) },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(TimeStampResp, status), 

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.3' - 2 commits - vcl/source

2015-03-11 Thread Tor Lillqvist
 vcl/source/gdi/pdfwriter_impl.cxx |   25 -
 1 file changed, 12 insertions(+), 13 deletions(-)

New commits:
commit 6bcbcb21faed17e529591f29aa0e492600f49ec3
Author: Tor Lillqvist t...@collabora.com
Date:   Thu Mar 12 00:31:18 2015 +0200

Fix crash when timestamping PDF signature

Using the NSS API for CMS and ASN.1-based stuff in general correctly is
extremely hard. It is very easy to do things slightly wrong. Of course no
compiler warnings are produced. You just get code that happens to work by
accident when compiled with one compiler, but not another, or depending on
contents of uninitialised memory, or the phase of the moon.

The problem was that the values field of a NSSCMSAttribute struct 
apparently
is supposed to point to *two* SECItem pointers, one pointing to the actual
value, and a NULL one.

Anyway, now valgrind finally does not complain about any use of 
uninitialised
memory.

Most likely my earlier recent commits to this file were not necessary after
all. They just seemed to help by accident, at least at one stage. But
whatever...

Change-Id: Ic98401b5d151bbb2398f809f47699f670e9720fa

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index f815d99..296a76a 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6857,7 +6857,9 @@ bool PDFWriterImpl::finalizeSignature()
 SECItem response_item;
 NSSCMSAttribute timestamp;
 SECItem values[2];
-SECItem *valuesp = values;
+SECItem *valuesp[2];
+valuesp[0] = values;
+valuesp[1] = NULL;
 SECOidData typetag;
 
 if( !m_aContext.SignTSA.isEmpty() )
@@ -7114,12 +7116,15 @@ bool PDFWriterImpl::finalizeSignature()
 
 // timestamp.type filled in below
 
+// Not sure if we actually need two entries in the values array, now 
when valuesp is an
+// array too, the pointer to the values array followed by a null 
pointer. But I don't feel
+// like experimenting.
 values[0] = response.timeStampToken;
 values[1].type = siBuffer;
 values[1].data = NULL;
 values[1].len = 0;
 
-timestamp.values = valuesp;
+timestamp.values = valuesp;
 
 typetag.oid.data = NULL;
 // id-aa-timeStampToken OBJECT IDENTIFIER ::= { iso(1)
commit a7d335746e6ab6807b39719d9cf15335e67082f9
Author: Tor Lillqvist t...@collabora.com
Date:   Wed Mar 11 22:31:47 2015 +0200

Don't bother with macros that are dummy on Unix in Unix-only code

In NSS's secasn1t.h, for non-Windows:

 #define SEC_ASN1_SUB(x)x
 #define SEC_ASN1_XTRN  0
 #define SEC_ASN1_MKSUB(x)

Change-Id: Ie42d881cebffdd060309d6a15d8d9c319c260699

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index 8fb4f36..f815d99 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -6262,16 +6262,10 @@ TimeStampResp ::= SEQUENCE  {
  timeStampToken TimeStampToken OPTIONAL  }
 */
 
-SEC_ASN1_MKSUB(SECOID_AlgorithmIDTemplate)
-SEC_ASN1_MKSUB(MessageImprint_Template)
-SEC_ASN1_MKSUB(Extensions_Template)
-SEC_ASN1_MKSUB(PKIStatusInfo_Template)
-SEC_ASN1_MKSUB(Any_Template)
-
 const SEC_ASN1Template MessageImprint_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(MessageImprint) },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(MessageImprint, 
hashAlgorithm), SEC_ASN1_SUB(SECOID_AlgorithmIDTemplate), 0 },
+{ SEC_ASN1_INLINE, offsetof(MessageImprint, hashAlgorithm), 
SECOID_AlgorithmIDTemplate, 0 },
 { SEC_ASN1_OCTET_STRING, offsetof(MessageImprint, hashedMessage), 0, 0 },
 { 0, 0, 0, 0 }
 };
@@ -6294,11 +6288,11 @@ const SEC_ASN1Template TimeStampReq_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(TimeStampReq) },
 { SEC_ASN1_INTEGER, offsetof(TimeStampReq, version), 0, 0 },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(TimeStampReq, messageImprint), 
SEC_ASN1_SUB(MessageImprint_Template), 0 },
+{ SEC_ASN1_INLINE, offsetof(TimeStampReq, messageImprint), 
MessageImprint_Template, 0 },
 { SEC_ASN1_OBJECT_ID | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, 
reqPolicy), 0, 0 },
 { SEC_ASN1_INTEGER | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, nonce), 0, 
0 },
 { SEC_ASN1_BOOLEAN | SEC_ASN1_OPTIONAL, offsetof(TimeStampReq, certReq), 
0, 0 },
-{ SEC_ASN1_XTRN | SEC_ASN1_OPTIONAL | SEC_ASN1_CONTEXT_SPECIFIC | 0, 
offsetof(TimeStampReq, extensions), SEC_ASN1_SUB(Extensions_Template), 0 },
+{ SEC_ASN1_OPTIONAL | SEC_ASN1_CONTEXT_SPECIFIC | 0, 
offsetof(TimeStampReq, extensions), Extensions_Template, 0 },
 { 0, 0, 0, 0 }
 };
 
@@ -6330,8 +6324,8 @@ typedef struct {
 const SEC_ASN1Template TimeStampResp_Template[] =
 {
 { SEC_ASN1_SEQUENCE, 0, NULL, sizeof(TimeStampResp) },
-{ SEC_ASN1_INLINE | SEC_ASN1_XTRN, offsetof(TimeStampResp, status), 

[Libreoffice-bugs] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

--- Comment #1 from Octavio Alvarez alvar...@alvarezp.ods.org ---
The case exposed in bug #83726 is invalid because the user did not properly use
the tool. *However*, a change could be done to prevent users from falling into
the 'hidden DF trap' and making the program behavior more consistent.

I recommend discussing --in a separate bug-- the issue of what should happen if
the user uses DF to the visual equivalent of removing DF.

Suppose:

1. A paragraph has a style that uses Bold.

2. The user selects part of the paragraph (selection A) and hits Bold.

3. Then, the user selects a subsection of selection A (selection B) and
hits bold again.

Currently, the selection B will have 'DF:bold'. The alternative is to have
'DF:regular' removed.

[*] DF = Direct Formatting

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-bugs] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83726

--- Comment #14 from Octavio Alvarez alvar...@alvarezp.ods.org ---
This bug is referenced by #89960.

I have made comments there to suggest a change that could potentially prevent
users from falling into the hidden Direct Formatting trap, as described in
this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

--- Comment #1 from Octavio Alvarez alvar...@alvarezp.ods.org ---
The case exposed in bug #83726 is invalid because the user did not properly use
the tool. *However*, a change could be done to prevent users from falling into
the 'hidden DF trap' and making the program behavior more consistent.

I recommend discussing --in a separate bug-- the issue of what should happen if
the user uses DF to the visual equivalent of removing DF.

Suppose:

1. A paragraph has a style that uses Bold.

2. The user selects part of the paragraph (selection A) and hits Bold.

3. Then, the user selects a subsection of selection A (selection B) and
hits bold again.

Currently, the selection B will have 'DF:bold'. The alternative is to have
'DF:regular' removed.

[*] DF = Direct Formatting

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 64805] FORMATTING: Table formatting error after saving file

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=64805

michael.kingsl...@yahoo.com.au changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #8 from michael.kingsl...@yahoo.com.au ---
Problem does not appear any longer in version 4.3.4.1 on 64 bit Windows 8.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 83726] Applying Styles Does Not Consistently Set Character Properties

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=83726

Octavio Alvarez alvar...@alvarezp.ods.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #13 from Octavio Alvarez alvar...@alvarezp.ods.org ---
This is clearly not a bug as stated in previous comments. The paragraph has the
'regular weight' formatting attribute directly applied, and thus, everything
else is working just as designed.

It *is* consistent and users that know how this works will find quickly resort
to using CTRL+M to make sure Direct Formatting is not affecting the application
of styles.

The user abused DF by removing DF by applying more DF. In fact, the user
applied bold in the first place because he didn't know how to use Character
Styles (or he was lazy). That's not a bug of the program.

To override part of the paragraph, the user had three options. Please see the
example that follows:

1. Delete all text after the period in original., including next paragraphs.
Make sure the period is the very last character.

2. Select the last paragraph (Shiffer [...] original.) and hit CTRL+M.

With this the paragraph is DF-clean [*].

3. While still selected, hit Ctrl+B for Bold.

4. Select no different [...] original. and hit Ctrl+B again.

This is how the user got into this situation. Continue with the reproduction of
the behavior:

5. Hit Enter.

6. Apply Heading 3.

7. Type. -- Text is correctly of regular weight.

The user had 3 chances of doing things right.

First and proper one, use Character Styles:

3. Only mark Shifer [...] Books and apply the Strong emphasis character
style. Select the paragraph and hit Ctrl+M; you'll notice the document keeps
the bold because no DF is applied; no place for confusion.

Second one, only override what is needed:

3. Only mark Shifer [...] Books and hit Ctrl+B.

Third one, un-override the formatting instead of reoverriding it:

4. Select no different [...] original. and hit Ctrl+M to remove his DF,
instead of overriding it with more DF.

Because this bug is about consistent application of character properties and
Writer *is* consistently applying character properties, this is clearly not a
bug and thus I'm closing it as such.

The confusion arises from the visual semantics of the second click on the
Bold button. Visually, the bold button is unpressed, the mental mapping
being that the DF is removed and leaving the last part paragraph DF-clean, and
thus, having the application of Header 3 behave as expected. Reality is
different: By re-clicking on the Bold button, another DF is applied to change
Bold weight for Regular weight. This is where the confusion comes from. What if
the style is Header 3 and we clicked on Bold to unpress it to override the
bold for a regular weight?

[*] I abbreviate Direct Formatting as DF.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-ux-advise] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

--- Comment #2 from Joel Madero jmadero@gmail.com ---
I really think that you all should talk to users about their experience with
the tool (ping the user mailing list for instance). The way I use it is how
*many* people use it - so to say we are using it wrong, means that the tool is
designed in a way that makes it intuitive to use it wrong which is a problem in
and of itself.

This notion that because it was designed this way it should never change is
just silly - join QA channel and ask for input there (I've spoken with 5+ in
that room, and we are all contributors) who agree that the current behavior is
counter-intuitive. I also pinged the user mailing list and had multiple users
agree that it's not intuitive. Lastly, there have been a couple other bugs that
described the same problem.

So - while you may say I'm wrong for using the tool this way, I'd respond with
then make the tool more intuitive.

If the goal is to get users to use styles more - I'm afraid the job is not
going well. I would never recommend users to use styles with how they currently
function - I use LibreOffice daily for legal work, I contribute both in QA and
other places, etc.. etc... and I'm thinking about not using styles any more
because I'm *constantly* having to interrupt my workflow and do ctrl+m.

Anyways - I think my proposed solution could work for everyone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 89960] Suggestion to Change Style Behavior in Relation to Direct Formatting

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89960

--- Comment #2 from Joel Madero jmadero@gmail.com ---
I really think that you all should talk to users about their experience with
the tool (ping the user mailing list for instance). The way I use it is how
*many* people use it - so to say we are using it wrong, means that the tool is
designed in a way that makes it intuitive to use it wrong which is a problem in
and of itself.

This notion that because it was designed this way it should never change is
just silly - join QA channel and ask for input there (I've spoken with 5+ in
that room, and we are all contributors) who agree that the current behavior is
counter-intuitive. I also pinged the user mailing list and had multiple users
agree that it's not intuitive. Lastly, there have been a couple other bugs that
described the same problem.

So - while you may say I'm wrong for using the tool this way, I'd respond with
then make the tool more intuitive.

If the goal is to get users to use styles more - I'm afraid the job is not
going well. I would never recommend users to use styles with how they currently
function - I use LibreOffice daily for legal work, I contribute both in QA and
other places, etc.. etc... and I'm thinking about not using styles any more
because I'm *constantly* having to interrupt my workflow and do ctrl+m.

Anyways - I think my proposed solution could work for everyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


LibreOffice Gerrit News for core on 2015-03-11

2015-03-11 Thread gerrit
Moin!

* Open changes on master for project core changed in the last 25 hours:

 First time contributors doing great things! 
+ Parallelized update precompiled headers.
  in https://gerrit.libreoffice.org/14802 from Ashod Nakashian
  about module bin
+ tdf#62957 Save Last Slide Position in Impress
  in https://gerrit.libreoffice.org/14782 from Anurag Kanungo
  about module sd
+ tdf#86787: Page style margin limited to 99.99mm
  in https://gerrit.libreoffice.org/14821 from Rishabh Kumar
  about module cui
+ tdf#89482 fix __refheading__ regression, set only CrossRefs as TOC.
  in https://gerrit.libreoffice.org/14822 from Justin Luth
  about module sw
 End of freshness 

+ tdf#89666: vcl: speed up HbLayoutEngine with cache in SwTxtFormatInfo
  in https://gerrit.libreoffice.org/14732 from Michael Stahl
  about module include, sw, vcl


* Merged changes on master for project core changed in the last 25 hours:

+ Spare extra call stack
  in https://gerrit.libreoffice.org/14765 from Takeshi Abe
+ Replace boost::noncopyable with use of SAL_DELETED_FUNCTION
  in https://gerrit.libreoffice.org/14825 from Takeshi Abe
+ tdf#89592 Using initializer_lists to populate SequencePropertyValue
  in https://gerrit.libreoffice.org/14781 from Swachhand Lokhande


* Abandoned changes on master for project core changed in the last 25 hours:

None

* Open changes needing tweaks, but being untouched for more than a week:

+ SkipImages option for document import
  in https://gerrit.libreoffice.org/14733 from Németh László
+ fdo#83672 , fdo#67776 : Fixed shape rotation angle in xlsx import.
  in https://gerrit.libreoffice.org/13090 from Sushil Shinde
+ tdf#85491 : break parameter incorrectly set in .XLSX import.
  in https://gerrit.libreoffice.org/12213 from Sushil Shinde
+ more breeze icons
  in https://gerrit.libreoffice.org/13058 from Jonathan Riddell
+ fdo#86606 removal of direct formatting options from the context menu
  in https://gerrit.libreoffice.org/13196 from Yousuf Philips
+ fdo#87441-Sending document as Email removes invisible content - this shou
  in https://gerrit.libreoffice.org/14549 from Charu Tyagi
+ Drop MAC_OS_X_VERSION_... variables
  in https://gerrit.libreoffice.org/13212 from Douglas Mencken
+ fdo#63905: fix regression by using paper size set in printer properties
  in https://gerrit.libreoffice.org/13763 from Clément Lassieur
+ jpeg-turbo: OpenCL for decompression of jpegs.
  in https://gerrit.libreoffice.org/13315 from Jan Holesovsky
+ GPU Calc:Support string parameter in SUMIF an SUMIFS.
  in https://gerrit.libreoffice.org/12044 from Hao Chen
+ vcl: Reduce OpenGLX11CairoTextRender surface area to size of text bounds
  in https://gerrit.libreoffice.org/14148 from Chris Sherlock
+ wip: get rid of svx dbtoolsclient
  in https://gerrit.libreoffice.org/11737 from Lionel Elie Mamane
+ Fix typo code Persistant
  in https://gerrit.libreoffice.org/14030 from Andrea Gelmini
+ fdo#88309: Standardize, cleanup, and improve Assertions
  in https://gerrit.libreoffice.org/13945 from Ashod Nakashian
+ --with-macosx-app-name= is unused, so bin it from AC_ARG_WITH list
  in https://gerrit.libreoffice.org/13658 from Douglas Mencken
+ fdo#75825-Send Document as E-Mail not working
  in https://gerrit.libreoffice.org/13786 from Charu Tyagi
+ solenv-filelists.pm: fix can't call method `mode' on an undefined value
  in https://gerrit.libreoffice.org/13669 from Douglas Mencken
+ gbuild-to-ide fixes
  in https://gerrit.libreoffice.org/11754 from Peter Foley
+ fdo#82335.
  in https://gerrit.libreoffice.org/11555 from Sudarshan Rao
+ fdo#39625 Make existing CppUnittests work
  in https://gerrit.libreoffice.org/11605 from Tobias Madl
+ fdo#86784 make soffice commandline in juh Bootstrap.bootstrap() configura
  in https://gerrit.libreoffice.org/13290 from Christoph Lutz
+ start detection of kf5 stuff in configure.ac
  in https://gerrit.libreoffice.org/13079 from Jonathan Riddell


Best,

Your friendly LibreOffice Gerrit Digest Mailer

Note: The bot generating this message can be found and improved here:
   
https://gerrit.libreoffice.org/gitweb?p=dev-tools.git;a=blob;f=gerritbot/send-daily-digest
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


[Libreoffice-bugs] [Bug 57341] Modal dialogs are a horrible user experience

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57341

--- Comment #6 from Dave Yost d...@yost.com ---
Heiko Tietze and Jean-Baptiste Faure,
are you the final arbiters of UI design for this project?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


[Libreoffice-ux-advise] [Bug 57341] Modal dialogs are a horrible user experience

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=57341

--- Comment #6 from Dave Yost d...@yost.com ---
Heiko Tietze and Jean-Baptiste Faure,
are you the final arbiters of UI design for this project?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise


[Libreoffice-bugs] [Bug 89859] USD currency formats shown when selecting another currency

2015-03-11 Thread bugzilla-daemon
https://bugs.documentfoundation.org/show_bug.cgi?id=89859

--- Comment #7 from Jay Philips philip...@hotmail.com ---
In the case of the Euro, there should be an entry in the list that provides the
currency symbol and currency code which is not associated with a locale, as it
is cross-country currency.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs


Crash test update

2015-03-11 Thread Crashtest VM
New crashtest update available at 
http://dev-builds.libreoffice.org/crashtest/95af5f51fa6c7a0129360bb9df687fb8660fd3c9/


exportCrashes.csv
Description: Binary data


importCrash.csv
Description: Binary data


validationErrors.csv
Description: Binary data
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


  1   2   3   >