[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 --- Comment #109 from Joel Madero jmadero@gmail.com --- Added bug 91078 - regression + bibisected Deleting a sheet that has no relationship to formulas on other sheets ruins the formulas on those sheets. Simple test document attached. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 --- Comment #109 from Joel Madero jmadero@gmail.com --- Added bug 91078 - regression + bibisected Deleting a sheet that has no relationship to formulas on other sheets ruins the formulas on those sheets. Simple test document attached. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 Joel Madero jmadero@gmail.com changed: What|Removed |Added Depends on||91078 -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 75025] LibreOffice 4.3 most annoying bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=75025 Joel Madero jmadero@gmail.com changed: What|Removed |Added Depends on||91078 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/native-code.py |5 + 1 file changed, 5 insertions(+) New commits: commit 5cddfc798e5ba55493fa5fd64340785164ca9dd4 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 6 10:16:47 2015 +0200 android: add ctors needed for ODT saving to the edit list Change-Id: I8b83b57f8dbbbc3cc75618d133139fdbe2c24603 diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py index 8bc0840..2bd15f2 100755 --- a/solenv/bin/native-code.py +++ b/solenv/bin/native-code.py @@ -228,6 +228,11 @@ edit_constructor_list = [ com_sun_star_comp_framework_GlobalAcceleratorConfiguration_get_implementation, com_sun_star_i18n_InputSequenceChecker_get_implementation, com_sun_star_i18n_OrdinalSuffix_get_implementation, +# sw/util/sw.component +com_sun_star_comp_Writer_XMLOasisContentExporter_get_implementation, +com_sun_star_comp_Writer_XMLOasisMetaExporter_get_implementation, +com_sun_star_comp_Writer_XMLOasisSettingsExporter_get_implementation, +com_sun_star_comp_Writer_XMLOasisStylesExporter_get_implementation, ] calc_factory_list = [ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91100] Closing Word count crashes writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91100 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||michael.me...@collabora.com Whiteboard||bibisected Severity|blocker |critical --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- This began at the below commit. Adding Cc: to michael.me...@collabora.com; Could you possibly take a look at this one? Thanks commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91073] Crash on insert table split button
https://bugs.documentfoundation.org/show_bug.cgi?id=91073 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||michael.me...@collabora.com Whiteboard||bibisected --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- This began at the below commit. Adding Cc: to michael.me...@collabora.com; Could you possibly take a look at this one? Thanks commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-commits] Adapt SwSrcEditWindow's SyntaxTimerHdl to being used in an Idle now
Patch in Gerrit: 5a142827fb945408c51725b31ebc1ded13a2d9c5 On Wed, May 6, 2015 at 10:03 AM, Tobias Madl tobias.madl@gmail.com wrote: So yeah SetTimeout should be deletet, but it should be replaced with SetPriority (and of course set with an appropriate Priority), because otherwise it gets the default priority: HIGH. The taks should be stopped if there is absolutely no more work to do. If stop is called it gets completely removed of the tasklist. So if you think that it has no more work todo you can stop it by yourself. But i think i get your point, because i see that i missed to ask if the task is active (i only check if it should be delete). I wil change this and then you could set the task as inactive if you think that for now it has no more work to do and if it comes to the position: if (... !pIdle-IsActive()) pIdle-Start(); it should be reactivatet. On Tue, May 5, 2015 at 11:46 AM, Stephan Bergmann sberg...@redhat.com wrote: I assume deleting the SetTimeout calls without replacement is fine, as the idle handler will automatically keep being called again? But then, is it OK that it only ever gets Stop()'ed in SwSrcEditWindow::dispose, or should it also stop itself when there's no more work to do? And is it necessary to do that if (... !pIdle-IsActive()) pIdle-Start(); thing from within the handler? On 05/05/2015 10:22 AM, Stephan Bergmann wrote: commit c0e209bf5f418f1564d16e234251783a0857a9d4 Author: Stephan Bergmann sberg...@redhat.com Date: Tue May 5 10:16:43 2015 +0200 Adapt SwSrcEditWindow's SyntaxTimerHdl to being used in an Idle now ...not a Timer, since d843f3de731667a298a83fc66637c7f983f3b24d changed timers to idle Change-Id: If8c6a52d6fb7b1e392e8f31bc8f0db22b2f049e1 diff --git a/sw/source/uibase/docvw/srcedtw.cxx b/sw/source/uibase/docvw/srcedtw.cxx index cd66ace..02e1e66 100644 --- a/sw/source/uibase/docvw/srcedtw.cxx +++ b/sw/source/uibase/docvw/srcedtw.cxx @@ -56,7 +56,6 @@ struct SwTextPortion #define MAX_SYNTAX_HIGHLIGHT 20 #define MAX_HIGHLIGHTTIME 200 -#define SYNTAX_HIGHLIGHT_TIMEOUT 200 typedef std::dequeSwTextPortion SwTextPortions; @@ -579,7 +578,7 @@ IMPL_LINK(SwSrcEditWindow, ScrollHdl, ScrollBar*, pScroll) return 0; } -IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) +IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Idle *, pIdle ) { tools::Time aSyntaxCheckStart( tools::Time::SYSTEM ); SAL_WARN_IF(pTextView == 0, sw, No View yet, but syntax highlighting?!); @@ -605,7 +604,6 @@ IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) break; if((tools::Time( tools::Time::SYSTEM ).GetTime() - aSyntaxCheckStart.GetTime()) MAX_HIGHLIGHTTIME ) { -pTimer-SetTimeout( 2 * SYNTAX_HIGHLIGHT_TIMEOUT ); break; } } @@ -620,13 +618,12 @@ IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) nCount ++; if(tools::Time( tools::Time::SYSTEM ).GetTime() - aSyntaxCheckStart.GetTime() MAX_HIGHLIGHTTIME) { -pTimer-SetTimeout( 2 * SYNTAX_HIGHLIGHT_TIMEOUT ); break; } } -if(!aSyntaxLineTable.empty() !pTimer-IsActive()) -pTimer-Start(); +if(!aSyntaxLineTable.empty() !pIdle-IsActive()) +pIdle-Start(); // SyntaxTimerHdl is called when text changed // = good opportunity to determine text width! long nPrevTextWidth = nCurTextWidth; diff --git a/sw/source/uibase/inc/srcedtw.hxx b/sw/source/uibase/inc/srcedtw.hxx index 823e3cd..55e53f4 100644 --- a/sw/source/uibase/inc/srcedtw.hxx +++ b/sw/source/uibase/inc/srcedtw.hxx @@ -95,7 +95,7 @@ private: using OutputDevice::SetFont; voidSetFont(); -DECL_LINK( SyntaxTimerHdl, Timer * ); +DECL_LINK( SyntaxTimerHdl, Idle * ); DECL_LINK( TimeoutHdl, Timer * ); using Window::Notify; ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 75057] [META] .docx and .xlsx MSO related CHART object issues
https://bugs.documentfoundation.org/show_bug.cgi?id=75057 Luke lukebe...@hotmail.com changed: What|Removed |Added Depends on|82824 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82824] FILEOPEN: position of MS .docx charts lost on import
https://bugs.documentfoundation.org/show_bug.cgi?id=82824 Luke lukebe...@hotmail.com changed: What|Removed |Added CC|markus.mohrhard@googlemail. | |com | Blocks|75057 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74301] IMPORT: non-English text is garbled in specific WMF
https://bugs.documentfoundation.org/show_bug.cgi?id=74301 --- Comment #7 from Mike Kaganski mikekagan...@hotmail.com --- Submitted patch to gerrit: https://gerrit.libreoffice.org/15641 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91090] Crash when launching extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=91090 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=222a9ef69c1a60526de5546433a9fce62d44823a tdf#91090 - avoid de-referencing DIALOG_NO_PARENT (-1) It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/deployment/gui/dp_gui_theextmgr.cxx | 17 + desktop/source/deployment/gui/dp_gui_theextmgr.hxx | 13 +++-- 2 files changed, 16 insertions(+), 14 deletions(-) New commits: commit 222a9ef69c1a60526de5546433a9fce62d44823a Author: Michael Meeks michael.me...@collabora.com Date: Wed May 6 09:39:46 2015 +0100 tdf#91090 - avoid de-referencing DIALOG_NO_PARENT (-1) Change-Id: I1032054765013a43744a7be548e892fc973a40ce diff --git a/desktop/source/deployment/gui/dp_gui_theextmgr.cxx b/desktop/source/deployment/gui/dp_gui_theextmgr.cxx index 3cad803..fa42dc2 100644 --- a/desktop/source/deployment/gui/dp_gui_theextmgr.cxx +++ b/desktop/source/deployment/gui/dp_gui_theextmgr.cxx @@ -49,10 +49,10 @@ namespace dp_gui { // TheExtensionManager -TheExtensionManager::TheExtensionManager( vcl::Window *pParent, +TheExtensionManager::TheExtensionManager( const uno::Reference awt::XWindow xParent, const uno::Reference uno::XComponentContext xContext ) : m_xContext( xContext ), -m_pParent( pParent ), +m_xParent( xParent ), m_pExtMgrDialog( NULL ), m_pUpdReqDialog( NULL ), m_pExecuteCmdQueue( NULL ) @@ -120,7 +120,12 @@ void TheExtensionManager::createDialog( const bool bCreateUpdDlg ) } else if ( !m_pExtMgrDialog ) { -m_pExtMgrDialog = VclPtrExtMgrDialog::Create( m_pParent, this ); +// FIXME: horrible ... +vcl::Window* pParent = DIALOG_NO_PARENT; +if (m_xParent.is()) +pParent = VCLUnoHelper::GetWindow(m_xParent); + +m_pExtMgrDialog = VclPtrExtMgrDialog::Create( pParent, this ); delete m_pExecuteCmdQueue; m_pExecuteCmdQueue = new ExtensionCmdQueue( m_pExtMgrDialog.get(), this, m_xContext ); m_pExtMgrDialog-setGetExtensionsURL( m_sGetExtensionsURL ); @@ -483,11 +488,7 @@ void TheExtensionManager::modified( ::lang::EventObject const /*rEvt*/ ) return s_ExtMgr; } -vcl::Window* pParent = DIALOG_NO_PARENT; -if (xParent.is()) -pParent = VCLUnoHelper::GetWindow(xParent); - -::rtl::ReferenceTheExtensionManager that( new TheExtensionManager( pParent, xContext ) ); +::rtl::ReferenceTheExtensionManager that( new TheExtensionManager( xParent, xContext ) ); const SolarMutexGuard guard; if ( ! s_ExtMgr.is() ) diff --git a/desktop/source/deployment/gui/dp_gui_theextmgr.hxx b/desktop/source/deployment/gui/dp_gui_theextmgr.hxx index 39d41b2..2341a5a 100644 --- a/desktop/source/deployment/gui/dp_gui_theextmgr.hxx +++ b/desktop/source/deployment/gui/dp_gui_theextmgr.hxx @@ -53,18 +53,19 @@ private: ::com::sun::star::uno::Reference ::com::sun::star::deployment::XExtensionManager m_xExtensionManager; ::com::sun::star::uno::Reference ::com::sun::star::container::XNameAccess m_xNameAccessNodes; -VclPtrvcl::Window m_pParent; -VclPtrExtMgrDialogm_pExtMgrDialog; -VclPtrUpdateRequiredDialogm_pUpdReqDialog; -ExtensionCmdQueue *m_pExecuteCmdQueue; +css::uno::Reference + css::awt::XWindow m_xParent; +VclPtrExtMgrDialog m_pExtMgrDialog; +VclPtrUpdateRequiredDialog m_pUpdReqDialog; +ExtensionCmdQueue *m_pExecuteCmdQueue; OUString m_sGetExtensionsURL; public: static ::rtl::ReferenceTheExtensionManager s_ExtMgr; - TheExtensionManager( vcl::Window * pParent, - const ::com::sun::star::uno::Reference ::com::sun::star::uno::XComponentContext xContext ); + TheExtensionManager( const css::uno::Reference css::awt::XWindow xParent, + const css::uno::Reference css::uno::XComponentContext xContext ); virtual ~TheExtensionManager(); void createDialog( const bool bCreateUpdDlg ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89654] EDITING: selecting document text causes Fedora platform freeze.
https://bugs.documentfoundation.org/show_bug.cgi?id=89654 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #113680|application/octet-stream|application/vnd.oasis.opend mime type||ocument.text -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91090] Crash when launching extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=91090 --- Comment #4 from Michael Meeks michael.me...@collabora.com --- Program received signal SIGSEGV, Segmentation fault. Reference (pBody=0x, this=0x7fffcc038f60) at /data/opt/libreoffice/master/include/rtl/ref.hxx:63 63m_pBody-acquire(); (gdb) bt #0 Reference (pBody=0x, this=0x7fffcc038f60) at /data/opt/libreoffice/master/include/rtl/ref.hxx:63 #1 VclPtr (pBody=0x, this=0x7fffcc038f60) at /data/opt/libreoffice/master/include/vcl/vclptr.hxx:97 #2 dp_gui::TheExtensionManager::TheExtensionManager (this=0x7fffcc038f08, pParent=0x, xContext= uno::Reference to (cppu::ComponentContext *) 0x7fffe2402418) at /data/opt/libreoffice/master/desktop/source/deployment/gui/dp_gui_theextmgr.cxx:58 #3 0x7fffb4f4d227 in dp_gui::TheExtensionManager::get (xContext=uno::Reference to (cppu::ComponentContext *) 0x7fffe2402418, xParent=empty uno::Reference, extensionURL=) at /data/opt/libreoffice/master/desktop/source/deployment/gui/dp_gui_theextmgr.cxx:490 #4 0x7fffb4f4527b in dp_gui::ServiceImpl::startExecuteModal (this=0x7fffcc038d28, xListener=empty uno::Reference) at /data/opt/libreoffice/master/desktop/source/deployment/gui/dp_gui_service.cxx:261 #5 0x7fffb4f44c8f in dp_gui::ServiceImpl::trigger (this=0x7fffcc038d28, rEvent=...) at /data/opt/libreoffice/master/desktop/source/deployment/gui/dp_gui_service.cxx:303 * Amazing: desktop/source/deployment/gui/dp_gui_theextmgr.cxx:vcl::Window* pParent = DIALOG_NO_PARENT; filter/source/xsltdialog/xmlfilterdialogcomponent.cxx:vcl::Window* pParent = DIALOG_NO_PARENT; include/vcl/dialog.hxx:#define DIALOG_NO_PARENT (reinterpret_castvcl::Window*(sal_IntPtr(-1))) sw/qa/tiledrendering/tiledrendering.cxx:ModalDialog(DIALOG_NO_PARENT, TiledRendering, qa/sw/ui/tiledrendering.ui), toolkit/source/awt/vclxtoolkit.cxx:pParent = DIALOG_NO_PARENT; vcl/source/uipreviewer/previewer.cxx:VclPtrInstanceDialog pDialog(DIALOG_NO_PARENT, WB_STDDIALOG | WB_SIZEABLE); vcl/source/window/dialog.cxx:// DIALOG_NO_PARENT: explicitly don't have a parent for this Dialog vcl/source/window/dialog.cxx:else if( pParent == DIALOG_NO_PARENT ) * Ideally - all these need removing a new parameter passing to Dialog to capture that semantic. Or a split constructor for this use-case ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Android Build Error on Linux (openSuSE)
Hi Andreas, *, On Tue, May 5, 2015 at 6:52 PM, Andreas Mantke ma...@gmx.de wrote: Am 04.05.2015 um 10:49 schrieb Miklos Vajna: Hi Andreas, cp: der Aufruf von stat für „/home/andi/Android/Sdk/extras/android/support/v7/appcompat/*“ ist nicht möglich: Datei oder Verzeichnis nicht gefunden There you have it, your SDK setup doesn't include the appcompat library - use your sdk-manager to install it... (android sdk from tools dir, or from within android studio) ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91044] thousands separator '
https://bugs.documentfoundation.org/show_bug.cgi?id=91044 raal r...@post.cz changed: What|Removed |Added Status|REOPENED|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #14 from Burak Ural buraku...@gmail.com --- Created attachment 115379 -- https://bugs.documentfoundation.org/attachment.cgi?id=115379action=edit Macro code for converting letters to Turkish -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow TABLE to split ... does not work although checked
https://bugs.documentfoundation.org/show_bug.cgi?id=43496 Ulrich Windl ulrich.wi...@rz.uni-regensburg.de changed: What|Removed |Added CC||ulrich.wi...@rz.uni-regensb ||urg.de --- Comment #13 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- I don't know when I first hit this bug, but maybe it's several years old: It always seemed to me that the text explanation (ALLOW table to split ...) was just wrong (i.e. inverted logic, meaning PREVENT table to split ...). Amazingly if you read the German help text for 4.3.7 (or 3.6), you'll find that the explanation says just that: Trennung der Tabelle an Seiten- oder Spaltenenden zulassen Verhindert einen Seiten- oder Spaltenumbruch in der Tabelle. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 Burak Ural buraku...@gmail.com changed: What|Removed |Added Attachment #115381|0 |1 is obsolete|| --- Comment #18 from Burak Ural buraku...@gmail.com --- Created attachment 115382 -- https://bugs.documentfoundation.org/attachment.cgi?id=115382action=edit Correct code; converting character set to Turkish letters. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55071] Array Formulas Do Not Work
https://bugs.documentfoundation.org/show_bug.cgi?id=55071 Luke lukebe...@hotmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID Severity|major |minor --- Comment #6 from Luke lukebe...@hotmail.com --- Tools Options LO Calc Formula Detail calculation setting Custom : Excel A1 Causes Calc to generate the same results as Excel in Column J. J7:J26 give results, while the rest are #Value In the second example, SeatGeek Excel Challenge.xls: =STDEV('Raw Data'!C2:C252/MID('Raw Data'!A2:A252,10,4)) Calc also gives the same results as Excel, #DIV/0! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 74301] IMPORT: non-English text is garbled in specific WMF
https://bugs.documentfoundation.org/show_bug.cgi?id=74301 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: comphelper/source
comphelper/source/misc/random.cxx | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) New commits: commit 776d74bb557e243c3aefe868dd5367a2a065ee06 Author: Tor Lillqvist t...@collabora.com Date: Wed May 6 12:34:17 2015 +0300 If using std::random_device fails, fall back to just time(nullptr) For instance, if using LibreOfficeKit in a chroot jail, there might not be a /dev/urandom, which causes the std::random_device ctor to throw a std::runtime_error exception, at least in the libstdc++ I have. Change-Id: Icc91a4ddf92ce66c66b6ffb8b4d1a02ab5f29ee9 diff --git a/comphelper/source/misc/random.cxx b/comphelper/source/misc/random.cxx index 84e3176..50f3ce4 100644 --- a/comphelper/source/misc/random.cxx +++ b/comphelper/source/misc/random.cxx @@ -12,9 +12,11 @@ #include comphelper/random.hxx #include rtl/instance.hxx +#include rtl/ustring.hxx #include assert.h #include time.h #include random +#include stdexcept // this is nothing but a simple wrapper around // the std::random generators @@ -37,13 +39,21 @@ struct RandomNumberGenerator STD_RNG_ALGO global_rng; RandomNumberGenerator() { -std::random_device rd; -// initialises the state of the global random number generator -// should only be called once. -// (note, a few std::variate_generator (like normal) have their -// own state which would need a reset as well to guarantee identical -// sequence of numbers, e.g. via myrand.distribution().reset()) -global_rng.seed(rd() ^ time(nullptr)); +try +{ +std::random_device rd; +// initialises the state of the global random number generator +// should only be called once. +// (note, a few std::variate_generator (like normal) have their +// own state which would need a reset as well to guarantee identical +// sequence of numbers, e.g. via myrand.distribution().reset()) +global_rng.seed(rd() ^ time(nullptr)); +} +catch (std::runtime_error e) +{ +SAL_WARN(comphelper.random, OUString(Using std::random_device failed: ) e.what()); +global_rng.seed(time(nullptr)); +} } }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/toolbox2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1fe85984f00c38017095944e2c34b34c57622367 Author: Tor Lillqvist t...@collabora.com Date: Wed May 6 12:44:16 2015 +0300 WaE: loplugin:cstylecast Change-Id: Id59ba5f0fcb27e5a3fec322ba0a016c5fc4bacc1 diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx index 13e77ef..211afd3 100644 --- a/vcl/source/window/toolbox2.cxx +++ b/vcl/source/window/toolbox2.cxx @@ -938,7 +938,7 @@ sal_uInt16 ToolBox::GetItemId( const Point rPos ) const Size ToolBox::GetItemContentSize( sal_uInt16 nItemId ) const { if ( mbCalc || mbFormat ) -((ToolBox*)this)-ImplFormat(); +(const_castToolBox*(this))-ImplFormat(); sal_uInt16 nPos = GetItemPos( nItemId ); if ( nPos mpData-m_aItems.size() ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91058] Show styles by means of subtle text background colours EDITING:
https://bugs.documentfoundation.org/show_bug.cgi?id=91058 --- Comment #5 from Cor Nouws c...@nouenoff.nl --- (In reply to Christopher R Lee from comment #4) I'm not used to this bug handling system ;) I added above a screeshot of the only example I have, which Henrik made when we were discussing a particular question*. He set a background colour for each style; there doesn't seem to be an option for patterns with that. Thanks. Now in Writer, a style is visible in the document most of the time due to the fact that it has _formatting_. And in Latex that visual representation lacks. So I expect it to be more usefull there? It occurred to me later that the idea should be of wider interest. I'll send Henrik the link to this bug, and try and make an example more relevant to other users. *OT here, but the question we were dealing with highlights a couple of things that could be developed with LO Interesting... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90565] UI Dialog Number format (Writer tables) has focus on Help button, rather then on list Category
https://bugs.documentfoundation.org/show_bug.cgi?id=90565 --- Comment #6 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Katarina Behrens committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=e8fcf3f01e48ae7453d70cfd5ae0acc2d8c50d58 tdf#90565: Focus category list on showing the dialog It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90565] UI Dialog Number format (Writer tables) has focus on Help button, rather then on list Category
https://bugs.documentfoundation.org/show_bug.cgi?id=90565 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |katarina.behr...@cib.de |desktop.org | Whiteboard|bibisected target:5.0.0 |bibisected -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90990] experimental features design button in sidebar crash
https://bugs.documentfoundation.org/show_bug.cgi?id=90990 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||michael.me...@collabora.com Whiteboard||bibisected --- Comment #3 from Matthew Francis fdb...@neosheffield.co.uk --- This began at the below commit. Adding Cc: to michael.me...@collabora.com; Could you possibly take a look at this one? Thanks commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/win
vcl/inc/win/salbmp.h |2 +- vcl/win/source/gdi/salbmp.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 74778b12f4f662e45ca8915739ab52b4402fde49 Author: Noel Grandin n...@peralex.com Date: Wed May 6 10:33:13 2015 +0200 fix windows build Change-Id: I32dc6c24c523519d6c2376c555b2d774fa40b3ba diff --git a/vcl/inc/win/salbmp.h b/vcl/inc/win/salbmp.h index b7d6622..4b64d5d 100644 --- a/vcl/inc/win/salbmp.h +++ b/vcl/inc/win/salbmp.h @@ -99,7 +99,7 @@ public: virtual boolCrop( const Rectangle rRectPixel ) SAL_OVERRIDE; virtual boolErase( const Color rFillColor ) SAL_OVERRIDE; -virtual boolScale( const double rScaleX, const double rScaleY, sal_uInt32 nScaleFlag ) SAL_OVERRIDE; +virtual boolScale( const double rScaleX, const double rScaleY, BmpScaleFlag nScaleFlag ) SAL_OVERRIDE; virtual boolReplace( const Color rSearchColor, const Color rReplaceColor, sal_uLong nTol ) SAL_OVERRIDE; }; diff --git a/vcl/win/source/gdi/salbmp.cxx b/vcl/win/source/gdi/salbmp.cxx index 0c890d0..86656dd 100644 --- a/vcl/win/source/gdi/salbmp.cxx +++ b/vcl/win/source/gdi/salbmp.cxx @@ -1066,7 +1066,7 @@ bool WinSalBitmap::Erase( const ::Color /*rFillColor*/ ) return false; } -bool WinSalBitmap::Scale( const double /*rScaleX*/, const double /*rScaleY*/, sal_uInt32 /*nScaleFlag*/ ) +bool WinSalBitmap::Scale( const double /*rScaleX*/, const double /*rScaleY*/, BmpScaleFlag /*nScaleFlag*/ ) { return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Android Print
Hi Massimiliano, Massimiliano Fiori píše v Út 05. 05. 2015 v 16:48 +0200: First of all thank you for your reply. I will check your links and your suggestions, but where can i find a documentation that explain me how UNO works? I would write a documentation of my work but first I have to understand the working logical. You don't really need UNO for the Android work, instead use LibreOfficeKit (and the PDF export as Miklos suggested). Please have a look at: http://cgit.freedesktop.org/libreoffice/core/tree/android/README and http://cgit.freedesktop.org/libreoffice/core/tree/libreofficekit/README All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88821] Import HTML file into Calc wrongly assumes source code-page is Windows-1252 for HTML 5 files. It correctly recognizes code page for old HTML 4.x files.
https://bugs.documentfoundation.org/show_bug.cgi?id=88821 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112821|application/octet-stream|text/csv mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88821] Import HTML file into Calc wrongly assumes source code-page is Windows-1252 for HTML 5 files. It correctly recognizes code page for old HTML 4.x files.
https://bugs.documentfoundation.org/show_bug.cgi?id=88821 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112823|application/octet-stream|text/csv mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88909] [4.4.0.3] After upgrading, opening a CSV UTF-8 in Calc defaults to UTF-16 encoding
https://bugs.documentfoundation.org/show_bug.cgi?id=88909 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #112924|text/plain |text/csv mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91090] Crash when launching extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=91090 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89545] Writer’s internal inserted pages mess the page numeration
https://bugs.documentfoundation.org/show_bug.cgi?id=89545 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #113865|application/octet-stream|application/zip mime type|| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91090] Crash when launching extension manager
https://bugs.documentfoundation.org/show_bug.cgi?id=91090 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- Even if a better fix is expected according to your comment in the patch, let's put this one to FIXED. Anyway ,thank you Michael for your quick feedback! :-) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/uiconfig
cui/uiconfig/ui/numberingformatpage.ui |1 + 1 file changed, 1 insertion(+) New commits: commit e8fcf3f01e48ae7453d70cfd5ae0acc2d8c50d58 Author: Katarina Behrens katarina.behr...@cib.de Date: Wed May 6 11:36:45 2015 +0200 tdf#90565: Focus category list on showing the dialog Change-Id: Ice995c7061b195ae7ac600635fc7643f762841c0 diff --git a/cui/uiconfig/ui/numberingformatpage.ui b/cui/uiconfig/ui/numberingformatpage.ui index b7be2e1..c98755d 100644 --- a/cui/uiconfig/ui/numberingformatpage.ui +++ b/cui/uiconfig/ui/numberingformatpage.ui @@ -355,6 +355,7 @@ object class=GtkTreeView id=categorylb:border property name=visibleTrue/property property name=can_focusTrue/property +property name=has_focusTrue/property property name=modelliststore1/property property name=search_column0/property child internal-child=selection ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91015] FILEOPEN: Open Csv file create with calc, crash, without error message.
https://bugs.documentfoundation.org/show_bug.cgi?id=91015 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk Whiteboard||bibisected --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- This seems to have started at the below commit. Relevant parties already Cc:'d so nobody to add commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #15 from Burak Ural buraku...@gmail.com --- Comment on attachment 115379 -- https://bugs.documentfoundation.org/attachment.cgi?id=115379 Macro code for converting letters to Turkish IGNORE THIS, CODE IS WRONG, I WILL UPDATE IT . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow TABLE to split ... does not work although checked
https://bugs.documentfoundation.org/show_bug.cgi?id=43496 --- Comment #14 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- (In reply to my comment #13) Whewn rechecking with 4.3.7 it seems things are even worse: While in some older versions the logic seemed inverted, now whatever I check, my two-page table always starts a new page (i.e. the table rows are not split). I found out that Keep with next paragraph (which is empty in my test case) actually prevents splitting the table. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91092] JavaScript macro causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=91092 --- Comment #3 from Noel Grandin noelgran...@gmail.com --- setting breakpoints go me this: Breakpoint 2, vcl::Window::~Window (this=0x1d554f0) at /home/noel/libo4/vcl/source/window/window.cxx:579 579{ (gdb) bt 30 #0 vcl::Window::~Window (this=0x1d554f0) at /home/noel/libo4/vcl/source/window/window.cxx:579 #1 0x2aaab1bc95d7 in Control::~Control (this=0x1d554f0) at /home/noel/libo4/vcl/source/control/ctrl.cxx:71 #2 0x2fc8d1b4 in SvTreeListBox::~SvTreeListBox (this=0x1d554f0) at /home/noel/libo4/svtools/source/contnr/treelistbox.cxx:1543 #3 0x2aaadf74b915 in SFTreeListBox::~SFTreeListBox (this=0x1d554f0) at /home/noel/libo4/cui/source/dialogs/scriptdlg.cxx:105 #4 0x2aaadf74ba59 in SFTreeListBox::~SFTreeListBox (this=0x1d554f0) at /home/noel/libo4/cui/source/dialogs/scriptdlg.cxx:103 #5 0x2aaab191895e in OutputDevice::release (this=0x1d554f0) at /home/noel/libo4/include/vcl/outdev.hxx:284 #6 0x2aaab19188ae in rtl::Referencevcl::Window::set (this=0x19055c0, pBody=0x0) at /home/noel/libo4/include/rtl/ref.hxx:95 #7 0x2aaab191b650 in rtl::Referencevcl::Window::operator= (this=0x19055c0, handle=empty rtl::Reference) at /home/noel/libo4/include/rtl/ref.hxx:106 #8 0x2aaab190f76f in VclPtrvcl::Window::operator= (this=0x19055c0) at /home/noel/libo4/include/vcl/vclptr.hxx:83 #9 0x2aaab19581ab in vcl::Window::ImplRemoveWindow (this=0x1d554f0, bRemoveFrameData=true) at /home/noel/libo4/vcl/source/window/stacking.cxx:148 #10 0x2aaab1b4020a in vcl::Window::dispose (this=0x1d554f0) at /home/noel/libo4/vcl/source/window/window.cxx:511 #11 0x2aaab1bc9684 in Control::dispose (this=0x1d554f0) at /home/noel/libo4/vcl/source/control/ctrl.cxx:76 #12 0x2fc8d636 in SvTreeListBox::dispose (this=0x1d554f0) at /home/noel/libo4/svtools/source/contnr/treelistbox.cxx:1584 #13 0x2aaadf74bb22 in SFTreeListBox::dispose (this=0x1d554f0) at /home/noel/libo4/cui/source/dialogs/scriptdlg.cxx:110 #14 0x2aaab1ce6401 in OutputDevice::disposeOnce (this=0x1d554f0) at /home/noel/libo4/vcl/source/outdev/outdev.cxx:202 #15 0x2aaab1993c6c in VclPtrvcl::Window::disposeAndClear (this=0x1c8fc98) at /home/noel/libo4/include/vcl/vclptr.hxx:209 #16 0x2aaab1976904 in VclBuilder::disposeBuilder (this=0x1eebfa0) at /home/noel/libo4/vcl/source/window/builder.cxx:536 #17 0x2aaab19e638f in VclBuilderContainer::disposeBuilder (this=0x18fd560) at /home/noel/libo4/vcl/source/window/dialog.cxx:462 #18 0x2aaab1ad984c in SystemWindow::dispose (this=0x18fd340) at /home/noel/libo4/vcl/source/window/syswin.cxx:121 #19 0x2aaab19e7074 in Dialog::dispose (this=0x18fd340) at /home/noel/libo4/vcl/source/window/dialog.cxx:557 #20 0x2eb42a6d in SfxModalDialog::dispose (this=0x18fd340) at /home/noel/libo4/sfx2/source/dialog/basedlgs.cxx:180 #21 0x2aaadf74fa4e in SvxScriptOrgDialog::dispose (this=0x18fd340) at /home/noel/libo4/cui/source/dialogs/scriptdlg.cxx:521 #22 0x2aaab1ce6401 in OutputDevice::disposeOnce (this=0x18fd340) at /home/noel/libo4/vcl/source/outdev/outdev.cxx:202 #23 0x2aaadf79ff8c in VclPtrDialog::disposeAndClear (this=0x17edec8) at /home/noel/libo4/include/vcl/vclptr.hxx:209 #24 0x2aaadf79fff8 in ScopedVclPtrDialog::~ScopedVclPtr (this=0x17edec8) at /home/noel/libo4/include/vcl/vclptr.hxx:344 #25 0x2aaadf7a6695 in CuiVclAbstractDialog_Impl::~CuiVclAbstractDialog_Impl (this=0x17edec0) at /home/noel/libo4/cui/source/factory/dlgfact.hxx:91 #26 0x2aaadf7a66c9 in CuiVclAbstractDialog_Impl::~CuiVclAbstractDialog_Impl (this=0x17edec0) at /home/noel/libo4/cui/source/factory/dlgfact.hxx:91 #27 0x2e96be68 in SfxApplication::OfaExec_Impl (this=0x12dd4a0, rReq=...) at /home/noel/libo4/sfx2/source/appl/appserv.cxx:1208 #28 0x2e94b568 in SfxStubSfxApplicationOfaExec_Impl (pShell=0x12dd4a0, rReq=...) at /home/noel/libo4/workdir/SdiTarget/sfx2/sdi/sfxslots.hxx:1217 #29 0x2ea98932 in SfxShell::CallExec (this=0x12dd4a0, pFunc=0x2e94b540 SfxStubSfxApplicationOfaExec_Impl(SfxShell*, SfxRequest), rReq=...) at /home/noel/libo4/include/sfx2/shell.hxx:210 As can be seen by looking at the values of the this pointer, 0x1d554f0 is being destructed before we are done with it, which does not make a lot of sense because we should be holding a reference to it at stack location #15 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: unotools/source
unotools/source/config/fontcfg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0a825b9aae390dc426261e873ffbacc867814e53 Author: Noel Grandin n...@peralex.com Date: Wed May 6 11:40:38 2015 +0200 fix windows build warning C4334: '' : result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) after my commit 60e659ae355d073b05b3b9c8d2ac3bdc5f76020d convert IMPL_FONT_ATTR constants to scoped enum Change-Id: I83f1ea5869fa60c89dbc706020f68cc2c4277f48 diff --git a/unotools/source/config/fontcfg.cxx b/unotools/source/config/fontcfg.cxx index 967794e..8053d95 100644 --- a/unotools/source/config/fontcfg.cxx +++ b/unotools/source/config/fontcfg.cxx @@ -988,7 +988,7 @@ FontWidth FontSubstConfiguration::getSubstWidth( const com::sun::star::uno::Refe ImplFontAttrs FontSubstConfiguration::getSubstType( const com::sun::star::uno::Reference XNameAccess rFont, const OUString rType ) const { -sal_uLong type = 0; +unsigned long type = 0; try { Any aAny = rFont-getByName( rType ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 67582] Opening specific Word file, 80+ pages with lots of images, opens slow and is nearly impossible to work with
https://bugs.documentfoundation.org/show_bug.cgi?id=67582 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Hardware|x86-64 (AMD64) |All Version|4.4.3.2 rc |4.1.0.4 release OS|Windows (All) |All --- Comment #12 from Cor Nouws c...@nouenoff.nl --- Thanks for confirming, Slava. Please do not change field version and so. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91095] crash exporting the given docx to docbook
https://bugs.documentfoundation.org/show_bug.cgi?id=91095 --- Comment #4 from Laurent Godard lgodard.li...@laposte.net --- in case it helps, some extra console outputs * on loading the document warn:writerfilter:13137:1:writerfilter/source/dmapper/DomainMapper_Impl.cxx:563: no context of type 1 available ... a lot of same line ... warn:writerfilter:13137:1:writerfilter/source/dmapper/DomainMapper_Impl.cxx:563: no context of type 1 available warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: HorizontalBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: VerticalBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: BottomBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: LeftBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: RightBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: TopBorder. Message: ... a lot of same lines ... warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: HorizontalBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: VerticalBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: BottomBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: LeftBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: RightBorder. Message: warn:sw.uno:13137:1:sw/source/core/unocore/unotext.cxx:2280: Exception when setting property: TopBorder. Message: warn:legacy.osl:13206:1:vcl/source/filter/wmf/emfwr.cxx:1526: EMFWriter::ImplWriteActions: unsupported MetaAction #150 warn:legacy.osl:13206:1:vcl/source/filter/wmf/wmfwr.cxx:1636: WMFWriter::WriteRecords: unsupported MetaAction #150 warn:legacy.osl:13206:1:oox/source/core/contexthandler2.cxx:112: ContextHandler2Helper::implEndElement - context stack broken warn:writerfilter:13206:1:writerfilter/source/dmapper/DomainMapper.cxx:1047: DomainMapper::lcl_attribute: unhandled token: 92354 warn:legacy.osl:13206:1:oox/source/helper/storagebase.cxx:67: StorageBase::StorageBase - missing base input stream warn:legacy.osl:13206:1:sw/source/core/layout/anchoredobject.cxx:581: SwAnchoredObject::GetObjRectWithSpaces - cache for object rectangle inclusive spaces marked as valid, but it couldn't be. Missing invalidation of cache. Please inform OD. warn:legacy.osl:13206:1:sw/source/core/layout/anchoredobject.cxx:581: SwAnchoredObject::GetObjRectWithSpaces - cache for object rectangle inclusive spaces marked as valid, but it couldn't be. Missing invalidation of cache. Please inform OD. warn:legacy.osl:13206:1:sw/source/core/layout/anchoredobject.cxx:581: SwAnchoredObject::GetObjRectWithSpaces - cache for object rectangle inclusive spaces marked as valid, but it couldn't be. Missing invalidation of cache. Please inform OD. warn:legacy.osl:13206:1:editeng/source/items/frmitems.cxx:476: unknown MemberId warn:legacy.osl:13206:1:editeng/source/items/frmitems.cxx:476: unknown MemberId * on saving as Docbook warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.letter.CallWizard?insert warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.fax.CallWizard?insert warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.agenda.CallWizard?insert warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.web.CallWizard?start warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for macro:///ImportWizard.Main.Main warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for macro:///Euro.AutoPilotRun.StartAutoPilot warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.letter.CallWizard?insert warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for service:com.sun.star.wizards.fax.CallWizard?insert warn:ucb.ucp.gio:13206:1:ucb/source/ucp/gio/gio_content.cxx:404: ignoring GError L'emplacement indiqué n'est pas pris en charge for
[Libreoffice-bugs] [Bug 91104] Editing presentation. Text is blocked in white and cannot be read.
https://bugs.documentfoundation.org/show_bug.cgi?id=91104 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- Hello Tim, Thank you for reporting the bug. Please attach a sample document, as this makes it easier for us to verify the bug. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' once the requested document is provided. (Please note that the attachment will be public, remove any sensitive information before attaching it. See https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F for help on how to do so.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43496] FILEOPEN .doc FORMATTING Allow TABLE to split ... does not work although checked
https://bugs.documentfoundation.org/show_bug.cgi?id=43496 --- Comment #15 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 115380 -- https://bugs.documentfoundation.org/attachment.cgi?id=115380action=edit Test Case (German) from LibreOffice 4.3.7.2 (Windows) The table starts at a new page, even though there is plenty of space on that page (see comment #14). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #16 from Burak Ural buraku...@gmail.com --- In the old days of ooo 1.0, when there was no unicode , I had to convert letters to the correct Turkish character sets. I uploaded an attachment turkish.txt it has code that converts the letters in a document to the correct ones. (Ignore the first one I uploaded) You might want to use it to test if the rtf file being opened correctly or not. You can also test it with MS Office as well. Thanks, Burak -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - include/vcl svx/source vcl/source
include/vcl/toolbox.hxx|3 +++ svx/source/tbxctrls/tbxcolorupdate.cxx |4 ++-- vcl/source/font/PhysicalFontFamily.cxx | 13 - vcl/source/window/toolbox2.cxx | 12 4 files changed, 17 insertions(+), 15 deletions(-) New commits: commit 27d94c482e82ea5d4f202109614c6fb3578fb0a4 Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 10:25:34 2015 +0100 color bar doesn't fill tool item since commit b8f21298288890d52c06fef6c84441634c56c986 Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk Date: Mon Mar 2 20:57:32 2015 +0900 the color bar is always drawn under the icon and doesn't get drawn to the right and fill all the empty space of the tool item, e.g. in impress see the new toolbar color selector Change-Id: Ib70fec9c933b9d743e67475899938a5d9f405496 diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx index f6a4f14..9c94f80 100644 --- a/include/vcl/toolbox.hxx +++ b/include/vcl/toolbox.hxx @@ -379,6 +379,9 @@ public: Rectangle GetItemRect( sal_uInt16 nItemId ) const; Rectangle GetItemPosRect( sal_uInt16 nPos ) const; +/// Returns size of the bitmap / text that is inside this toolbox item. +SizeGetItemContentSize( sal_uInt16 nItemId ) const; + /// Retrieves the optimal position to place a popup window for this item (subtoolbar or dropdown) Point GetItemPopupPosition( sal_uInt16 nItemId, const Size rSize ) const; diff --git a/svx/source/tbxctrls/tbxcolorupdate.cxx b/svx/source/tbxctrls/tbxcolorupdate.cxx index ff4dc5e..5f1a186 100644 --- a/svx/source/tbxctrls/tbxcolorupdate.cxx +++ b/svx/source/tbxctrls/tbxcolorupdate.cxx @@ -79,8 +79,7 @@ namespace svx void ToolboxButtonColorUpdater::Update(const Color rColor) { Image aImage(mpTbx-GetItemImageOriginal(mnBtnId)); -BitmapEx aSource(aImage.GetBitmapEx()); -Size aItemSize = aSource.GetSizePixel(); +Size aItemSize(mpTbx-GetItemContentSize(mnBtnId)); const bool bSizeChanged = (maBmpSize != aItemSize); const bool bDisplayModeChanged = (mbWasHiContrastMode != mpTbx-GetSettings().GetStyleSettings().GetHighContrastMode()); @@ -101,6 +100,7 @@ namespace svx sal_uInt8 nAlpha = 255; BitmapEx aBmpEx(Bitmap(aItemSize, 24), AlphaMask(aItemSize, nAlpha)); +BitmapEx aSource(aImage.GetBitmapEx()); long nWidth = std::min(aItemSize.Width(), aSource.GetSizePixel().Width()); long nHeight = std::min(aItemSize.Height(), aSource.GetSizePixel().Height()); diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx index e209fd2..13e77ef 100644 --- a/vcl/source/window/toolbox2.cxx +++ b/vcl/source/window/toolbox2.cxx @@ -935,6 +935,18 @@ sal_uInt16 ToolBox::GetItemId( const Point rPos ) const return 0; } +Size ToolBox::GetItemContentSize( sal_uInt16 nItemId ) const +{ +if ( mbCalc || mbFormat ) +((ToolBox*)this)-ImplFormat(); + +sal_uInt16 nPos = GetItemPos( nItemId ); +if ( nPos mpData-m_aItems.size() ) +return mpData-m_aItems[nPos].maContentSize; +else +return Size(); +} + sal_uInt16 ToolBox::GetItemId(const OUString rCommand) const { if (!mpData) commit ea593a29006e71e25071aaf01c838e5da632adf0 Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 09:26:22 2015 +0100 this is a no-op, remove if Change-Id: I01a7d41084185c8c9d4a103fb124a0416a3bc890 diff --git a/vcl/source/font/PhysicalFontFamily.cxx b/vcl/source/font/PhysicalFontFamily.cxx index 552c2da..b3c650c 100644 --- a/vcl/source/font/PhysicalFontFamily.cxx +++ b/vcl/source/font/PhysicalFontFamily.cxx @@ -159,19 +159,6 @@ bool PhysicalFontFamily::AddFontFace( PhysicalFontFace* pNewData ) || (pNewData-GetSlant() == ITALIC_OBLIQUE) ) mnTypeFaces |= FONT_FAMILY_ITALIC; -if( (meMatchWeight == WEIGHT_DONTKNOW) -|| (meMatchWidth == WIDTH_DONTKNOW) -|| (mnMatchType == ImplFontAttrs::None) ) -{ -// TODO: is it cheaper to calc matching attributes now or on demand? -// calc matching attributes if other entries are already initialized - -// Do lazy, quite expensive, not needed in start-up! -// const FontSubstConfiguration rFontSubst = *FontSubstConfiguration::get(); -// InitMatchData( rFontSubst, maSearchName ); -// mbMatchData=true; // Somewhere else??? -} - // reassign name (sharing saves memory) if( pNewData-GetFamilyName() == GetFamilyName() ) pNewData-SetFamilyName( GetFamilyName() ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 89257] chart-feature fillcolor defined from Cellrange should also reflect into same colors for legend-Symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=89257 Michael Stahl mst...@redhat.com changed: What|Removed |Added Attachment #113255|application/octet-stream|application/vnd.oasis.opend mime type||ocument.spreadsheet -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #13 from Burak Ural buraku...@gmail.com --- Other then the image and Turkish characters , yes it opens. Could you the character problem also, it would be great. I do not know any paid service for Libreoffice. If there is how they work? Do they release different versions? Are they integrated here also? Thanks for finding the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91014] LO crashes 100% of attempts to add a hyperlink in writer or calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91014 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||fdb...@neosheffield.co.uk, ||michael.me...@collabora.com Whiteboard|bibisectRequest |bibisected --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- This began at the below commit. Adding Cc: to michael.me...@collabora.com; Could you possibly take a look at this one? Thanks commit e8b97a52c96df9c8e8055407b1e40ed7cb9cfc67 Merge: 2b0be6c 0cde74f Author: Michael Meeks michael.me...@collabora.com Date: Tue Apr 28 11:41:31 2015 +0100 Merge remote-tracking branch 'origin/feature/vclptr' Resolve several thousand lines of conflicts. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91109] Letter converts temporary in uppercase
https://bugs.documentfoundation.org/show_bug.cgi?id=91109 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Ever confirmed|0 |1 OS|Linux (All) |All Severity|normal |minor --- Comment #1 from raal r...@post.cz --- I can confirm with LO 4.4.2, win7. Lowering importance -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 Burak Ural buraku...@gmail.com changed: What|Removed |Added Attachment #115379|0 |1 is obsolete|| --- Comment #17 from Burak Ural buraku...@gmail.com --- Created attachment 115381 -- https://bugs.documentfoundation.org/attachment.cgi?id=115381action=edit Correct code; converting character set to Turkish letters. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools unotools/source
include/unotools/fontcfg.hxx |9 + unotools/source/config/fontcfg.cxx |2 ++ 2 files changed, 11 insertions(+) New commits: commit fa405087c6345053580fb9d8eca46c6ca71c18d9 Author: Tor Lillqvist t...@collabora.com Date: Wed May 6 12:08:04 2015 +0300 Add comments about ImplFontAttrs Change-Id: I32d8b8f4301188245721d31fd234bb1784a1ae8d diff --git a/include/unotools/fontcfg.hxx b/include/unotools/fontcfg.hxx index 1d181a9..c13e4a5 100644 --- a/include/unotools/fontcfg.hxx +++ b/include/unotools/fontcfg.hxx @@ -34,6 +34,15 @@ enum class DefaultFontType; +// If you think the below concept of classifying a font (typeface) as possibly being one or several +// of Default, Standard, and Normal, etc, is madness, you are probably right. On the other +// hand we have in officecfg/registry/data/org/openoffice/VCL.xcu carefully (or not) assigned to +// each font mentioned in that file what its attributes are, so it is quite possible that touching +// this would cause a regression that nobody would notice until after many years. + +// Note that the bit flags must match the entries in the pAttribNames array in +// unotools/source/config/fontcfg.cxx. + enum class ImplFontAttrs : sal_uLong { None = 0x, diff --git a/unotools/source/config/fontcfg.cxx b/unotools/source/config/fontcfg.cxx index d7933a9..967794e 100644 --- a/unotools/source/config/fontcfg.cxx +++ b/unotools/source/config/fontcfg.cxx @@ -796,6 +796,8 @@ struct StrictStringSort : public ::std::binary_function const FontNameAttr, co { return rLeft.Name.compareTo( rRight.Name ) 0; } }; +// The entries in this table must match the bits in the ImplFontAttrs enum. + static const char* const pAttribNames[] = { default, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/swdbdata.hxx |6 -- sw/source/core/doc/docfmt.cxx|1 + sw/source/filter/xml/xmlimp.cxx |5 + sw/source/uibase/uno/SwXDocumentSettings.cxx | 15 +++ 4 files changed, 25 insertions(+), 2 deletions(-) New commits: commit 7bd6f298b43732fd5d4a270f2493ae11eb20ad22 Author: Miklos Vajna vmik...@collabora.co.uk Date: Wed May 6 10:33:46 2015 +0200 sw: add SwDBData::sEmbeddedName It is supposed to contain the name of a stream in the document storage (like Object 1) that has an embedded database for mail merge data source definition purposes. It's just loaded / saved from ODF at the moment, it's not yet used for anything. Change-Id: Ida366478fd83aa51e66e958ac09d852332c227c9 diff --git a/sw/inc/swdbdata.hxx b/sw/inc/swdbdata.hxx index 6d91e2b..02ccf68 100644 --- a/sw/inc/swdbdata.hxx +++ b/sw/inc/swdbdata.hxx @@ -28,14 +28,16 @@ struct SwDBData OUString sDataSource; OUString sCommand; //table, query or statement sal_Int32 nCommandType; //com::sun::star::sdb::CommandType +/// Name of the embedded database that's included in the current document. +OUString sEmbeddedName; SwDBData() : nCommandType(0){} void dumpAsXml(struct _xmlTextWriter* pWriter) const; bool operator !=(const SwDBData rCmp) const -{return rCmp.sDataSource != sDataSource || rCmp.sCommand != sCommand || rCmp.nCommandType != nCommandType;} +{return rCmp.sDataSource != sDataSource || rCmp.sCommand != sCommand || rCmp.nCommandType != nCommandType || rCmp.sEmbeddedName != sEmbeddedName;} bool operator ==(const SwDBData rCmp) const -{return rCmp.sDataSource == sDataSource rCmp.sCommand == sCommand rCmp.nCommandType == nCommandType;} +{return rCmp.sDataSource == sDataSource rCmp.sCommand == sCommand rCmp.nCommandType == nCommandType rCmp.sEmbeddedName == sEmbeddedName;} }; #endif diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx index c900a08..5e41a85 100644 --- a/sw/source/core/doc/docfmt.cxx +++ b/sw/source/core/doc/docfmt.cxx @@ -1957,6 +1957,7 @@ void SwDBData::dumpAsXml(xmlTextWriterPtr pWriter) const xmlTextWriterWriteAttribute(pWriter, BAD_CAST(sDataSource), BAD_CAST(sDataSource.toUtf8().getStr())); xmlTextWriterWriteAttribute(pWriter, BAD_CAST(sCommand), BAD_CAST(sCommand.toUtf8().getStr())); xmlTextWriterWriteAttribute(pWriter, BAD_CAST(nCommandType), BAD_CAST(OString::number(nCommandType).getStr())); +xmlTextWriterWriteAttribute(pWriter, BAD_CAST(sEmbeddedName), BAD_CAST(sEmbeddedName.toUtf8().getStr())); xmlTextWriterEndElement(pWriter); } diff --git a/sw/source/filter/xml/xmlimp.cxx b/sw/source/filter/xml/xmlimp.cxx index eb806ed..08ab57c 100644 --- a/sw/source/filter/xml/xmlimp.cxx +++ b/sw/source/filter/xml/xmlimp.cxx @@ -1159,6 +1159,7 @@ void SwXMLImport::SetConfigurationSettings(const Sequence PropertyValue aC const PropertyValue* currentDatabaseDataSource = NULL; const PropertyValue* currentDatabaseCommand = NULL; const PropertyValue* currentDatabaseCommandType = NULL; +const PropertyValue* embeddedDatabaseName = 0; while( nCount-- ) { @@ -1189,6 +1190,8 @@ void SwXMLImport::SetConfigurationSettings(const Sequence PropertyValue aC currentDatabaseCommand = pValues; else if( pValues-Name == CurrentDatabaseCommandType ) currentDatabaseCommandType = pValues; +else if (pValues-Name == EmbeddedDatabaseName) +embeddedDatabaseName = pValues; else xProps-setPropertyValue( pValues-Name, pValues-Value ); @@ -1263,6 +1266,8 @@ void SwXMLImport::SetConfigurationSettings(const Sequence PropertyValue aC xProps-setPropertyValue( currentDatabaseCommand-Name, currentDatabaseCommand-Value ); if( currentDatabaseCommandType != NULL ) xProps-setPropertyValue( currentDatabaseCommandType-Name, currentDatabaseCommandType-Value ); +if (embeddedDatabaseName) +xProps-setPropertyValue(embeddedDatabaseName-Name, embeddedDatabaseName-Value); } catch( Exception ) { OSL_FAIL( SwXMLImport::SetConfigurationSettings: Exception! ); diff --git a/sw/source/uibase/uno/SwXDocumentSettings.cxx b/sw/source/uibase/uno/SwXDocumentSettings.cxx index 7d222ae..f57cf50 100644 --- a/sw/source/uibase/uno/SwXDocumentSettings.cxx +++ b/sw/source/uibase/uno/SwXDocumentSettings.cxx @@ -72,6 +72,7 @@ enum SwDocumentSettingsPropertyHandles HANDLE_CURRENT_DATABASE_DATA_SOURCE, HANDLE_CURRENT_DATABASE_COMMAND, HANDLE_CURRENT_DATABASE_COMMAND_TYPE, +HANDLE_EMBEDDED_DATABASE_NAME,
[Libreoffice-commits] core.git: cui/source
cui/source/factory/dlgfact.cxx | 12 +--- cui/source/factory/dlgfact.hxx |7 +-- 2 files changed, 2 insertions(+), 17 deletions(-) New commits: commit 80b3c85269a593b0b10355e770dc91ab3d419696 Author: Noel Grandin n...@peralex.com Date: Wed May 6 11:44:15 2015 +0200 simplify code using ScopedVclPtr Change-Id: I71db7422ab8ad83455cc61df5314cf214a4d388c diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index c6079c3..4ec04be 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -104,17 +104,7 @@ IMPL_ABSTDLG_BASE(AbstractHangulHanjaConversionDialog_Impl); IMPL_ABSTDLG_BASE(AbstractFmShowColsDialog_Impl); IMPL_ABSTDLG_BASE(AbstractHyphenWordDialog_Impl) IMPL_ABSTDLG_BASE(AbstractThesaurusDialog_Impl) - -AbstractSvxZoomDialog_Impl::~AbstractSvxZoomDialog_Impl() -{ -pDlg.disposeAndClear(); -} - -short AbstractSvxZoomDialog_Impl::Execute() -{ -return pDlg-Execute(); -} - +IMPL_ABSTDLG_BASE(AbstractSvxZoomDialog_Impl) IMPL_ABSTDLG_BASE(AbstractSearchProgress_Impl); IMPL_ABSTDLG_BASE(AbstractTakeProgress_Impl); IMPL_ABSTDLG_BASE(AbstractTitleDialog_Impl); diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index 4a4dbcd..b194d19 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -62,19 +62,14 @@ class HangulHanjaConversionDialog; using namespace svx; #define DECL_ABSTDLG_BASE(Class,DialogClass)\ -VclPtrDialogClass pDlg; \ +ScopedVclPtrDialogClass pDlg; \ public: \ Class( DialogClass* p) \ : pDlg(p) \ {} \ -virtual ~Class(); \ virtual short Execute() SAL_OVERRIDE ; #define IMPL_ABSTDLG_BASE(Class)\ -Class::~Class() \ -{ \ - pDlg.disposeAndClear();\ -} \ short Class::Execute() \ { \ return pDlg-Execute(); \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
LibreOffice Gerrit News for core on 2015-05-06
Moin! * Open changes on master for project core changed in the last 25 hours: First time contributors doing great things! + tdf#91066: Condensed Character Spacing i.e spc(negative value) is not exp in https://gerrit.libreoffice.org/15635 from Yogesh Bharate about module oox, sc + Breeze: update will sync with the svg plasma-next-icons git repository in https://gerrit.libreoffice.org/15564 from Andreas Kainz about module icon-themes + tdf#90905 fix for url encoding in internal urls in https://gerrit.libreoffice.org/15625 from Vasily Melenchuk about module sw + tdf#90190 PPTX table cell border width is not exported. in https://gerrit.libreoffice.org/15350 from Yogesh Bharate about module include, oox, sd + tdf#74299: improve DXF import in https://gerrit.libreoffice.org/15627 from Mike Kaganski about module filter + Resolves tdf#83365 Other: Access across spreadsheet returns Err:504 in https://gerrit.libreoffice.org/15363 from Henry Castro about module sc + tdf#90494: Change gradient angle diagonally by choosing option. in https://gerrit.libreoffice.org/15180 from Heena Gupta about module cui + tdf#90174 FILESAVE: export of bullet color for pptx in https://gerrit.libreoffice.org/15169 from Priyanka Gaikwad about module oox, sd + tdf#90672: PPTX table cell border color is not exported. in https://gerrit.libreoffice.org/15364 from Yogesh Bharate about module oox, sd End of freshness + tdf#90994 Sidebar tab bar buttons should should have accessible names in https://gerrit.libreoffice.org/15639 from Niklas Johansson about module sfx2 + editing/experimental mode as user-preference (Android Viewer) in https://gerrit.libreoffice.org/15638 from Christian Lohmaier about module android + tdf#90258 Sidebar: toggle Thousand/Engineering in https://gerrit.libreoffice.org/15609 from Laurent BP about module include, sc + tdf#90258 Toggle Thousand Separator with Engineering Notation in https://gerrit.libreoffice.org/15606 from Laurent BP about module cui, include, svl, svx + tdf#90994 The accessible name should not contain the accessible role in https://gerrit.libreoffice.org/15636 from Niklas Johansson about module sfx2 * Merged changes on master for project core changed in the last 25 hours: + fdo#77985 make calc function NETWORKDAYS comply with ODFF1.2 in https://gerrit.libreoffice.org/9827 from Winfried Donkers + Resolves tdf#84240 : Red squiggly underline does not appear instantly in https://gerrit.libreoffice.org/14872 from Deena Francis + Avoid redefine of TRANSPARENT on solaris after including stream.h in https://gerrit.libreoffice.org/15361 from Richard PALO + Related tdf#91009: Correct thousands separator character for locale es_CR in https://gerrit.libreoffice.org/15630 from Julien Nabet + tdf#91081 Fix LO crash after dialog closing by ESC in https://gerrit.libreoffice.org/15626 from Philippe Jung + Use typed Timer::SetTimeoutHdl Link in https://gerrit.libreoffice.org/15634 from Stephan Bergmann + loplugin:staticmethods in https://gerrit.libreoffice.org/15511 from Noel Grandin + loplugin:staticmethods in https://gerrit.libreoffice.org/15512 from Noel Grandin + loplugin:staticmethods in https://gerrit.libreoffice.org/15513 from Noel Grandin + loplugin:staticmethods in https://gerrit.libreoffice.org/15516 from Noel Grandin + loplugin:staticmethods in https://gerrit.libreoffice.org/15517 from Noel Grandin + loplugin:staticmethods in https://gerrit.libreoffice.org/15518 from Noel Grandin + seed mt19937 with random data in https://gerrit.libreoffice.org/15591 from Norbert Thiebaud + tdf#34555 add crop features to sw in https://gerrit.libreoffice.org/15590 from Philippe Jung + tdf#34555 add to scalc: crop, change img, save img, edit with ext tools in https://gerrit.libreoffice.org/15589 from Philippe Jung + tdf#34555 add crop features to svx in https://gerrit.libreoffice.org/15588 from Philippe Jung + prefer OUStringBuffer to concatenating OUString in a loop in https://gerrit.libreoffice.org/15582 from Takeshi Abe + tdf#90539 special case for EMF placeholder icon of OLE object in https://gerrit.libreoffice.org/15632 from Andras Timar + typo: strech - stretch in https://gerrit.libreoffice.org/15628 from Andras Timar * Abandoned changes on master for project core changed in the last 25 hours: + fdo#50950 make Calc functions (ISO)WEEKNUM comply with ODFF1.2 in https://gerrit.libreoffice.org/12089 from Winfried Donkers + convert SFX_STYLESHEET_ constants to scoped enum in https://gerrit.libreoffice.org/15346 from Noel Grandin + convert SVX_SEARCHIN_ flags to scoped enum in https://gerrit.libreoffice.org/15347 from Noel Grandin + convert BROWSER_ constants to scoped enum in https://gerrit.libreoffice.org/15348 from Noel Grandin + convert BorderWidth flags to scoped enum in https://gerrit.libreoffice.org/15398 from Noel Grandin + convert FONTLIST_FONTNAMETYPE constants to scoped enum in
[Libreoffice-commits] core.git: vcl/inc vcl/quartz
vcl/inc/quartz/salbmp.h |2 +- vcl/quartz/salbmp.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 918a03c53839ad5696d0e154fbf657af49f67d8f Author: Noel Grandin n...@peralex.com Date: Wed May 6 09:14:12 2015 +0200 fix OSX build Change-Id: I6df0009cad65134e626f89563be168ff739ca092 diff --git a/vcl/inc/quartz/salbmp.h b/vcl/inc/quartz/salbmp.h index 9c2209d..49679f0 100644 --- a/vcl/inc/quartz/salbmp.h +++ b/vcl/inc/quartz/salbmp.h @@ -77,7 +77,7 @@ public: boolCrop( const Rectangle rRectPixel ) SAL_OVERRIDE; boolErase( const Color rFillColor ) SAL_OVERRIDE; -boolScale( const double rScaleX, const double rScaleY, sal_uInt32 nScaleFlag ) SAL_OVERRIDE; +boolScale( const double rScaleX, const double rScaleY, BmpScaleFlag nScaleFlag ) SAL_OVERRIDE; boolReplace( const Color rSearchColor, const Color rReplaceColor, sal_uLong nTol ) SAL_OVERRIDE; private: diff --git a/vcl/quartz/salbmp.cxx b/vcl/quartz/salbmp.cxx index 2bb7b29..06b55ac 100644 --- a/vcl/quartz/salbmp.cxx +++ b/vcl/quartz/salbmp.cxx @@ -978,7 +978,7 @@ bool QuartzSalBitmap::Erase( const ::Color /*rFillColor*/ ) return false; } -bool QuartzSalBitmap::Scale( const double /*rScaleX*/, const double /*rScaleY*/, sal_uInt32 /*nScaleFlag*/ ) +bool QuartzSalBitmap::Scale( const double /*rScaleX*/, const double /*rScaleY*/, BmpScaleFlag /*nScaleFlag*/ ) { return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: cui/source
cui/source/inc/ControlFocusHelper.hxx | 44 -- cui/source/inc/dbregister.hxx |1 cui/source/inc/optpath.hxx|1 cui/source/options/optpath.cxx| 11 4 files changed, 57 deletions(-) New commits: commit 19b91e0d76df10646cd261431c7847e3447e08b1 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 6 09:55:21 2015 +0200 Remove unused SvxControlFocusHelper Change-Id: I3bdadb02918bf109e7e93ea0c7c709f018caed4a diff --git a/cui/source/inc/ControlFocusHelper.hxx b/cui/source/inc/ControlFocusHelper.hxx deleted file mode 100644 index 6530f3c..000 --- a/cui/source/inc/ControlFocusHelper.hxx +++ /dev/null @@ -1,44 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the License); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -#ifndef INCLUDED_CUI_SOURCE_INC_CONTROLFOCUSHELPER_HXX -#define INCLUDED_CUI_SOURCE_INC_CONTROLFOCUSHELPER_HXX - -#include vcl/ctrl.hxx - -// class SvxControlFocusHelper - - -class SvxControlFocusHelper : public Control -{ -private: -VclPtrControlm_pFocusCtrl; - -public: -SvxControlFocusHelper( vcl::Window* pParent, const ResId rId ) : -Control( pParent, rId ), m_pFocusCtrl( NULL ) {} -virtual ~SvxControlFocusHelper(); -virtual void dispose() SAL_OVERRIDE; - -voidSetFocusControl( Control* pCtrl ) { m_pFocusCtrl = pCtrl; } - -virtual boolNotify( NotifyEvent rNEvt ) SAL_OVERRIDE; -}; - -#endif // INCLUDED_CUI_SOURCE_INC_CONTROLFOCUSHELPER_HXX - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/cui/source/inc/dbregister.hxx b/cui/source/inc/dbregister.hxx index 0c9d91e..00c26d1 100644 --- a/cui/source/inc/dbregister.hxx +++ b/cui/source/inc/dbregister.hxx @@ -25,7 +25,6 @@ #include svl/poolitem.hxx #include svtools/simptabl.hxx #include optpath.hxx -#include ControlFocusHelper.hxx class SvTreeListEntry; namespace svx diff --git a/cui/source/inc/optpath.hxx b/cui/source/inc/optpath.hxx index a394d09..d793485 100644 --- a/cui/source/inc/optpath.hxx +++ b/cui/source/inc/optpath.hxx @@ -23,7 +23,6 @@ #include svtools/simptabl.hxx #include vcl/fixed.hxx #include vcl/group.hxx -#include ControlFocusHelper.hxx #include com/sun/star/ui/dialogs/XFolderPicker2.hpp #include svtools/dialogclosedlistener.hxx diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx index 218f814..0bab1a9 100644 --- a/cui/source/options/optpath.cxx +++ b/cui/source/options/optpath.cxx @@ -161,17 +161,6 @@ OUString Convert_Impl( const OUString rValue ) return aReturn; } -// class SvxControlFocusHelper - - -bool SvxControlFocusHelper::Notify( NotifyEvent rNEvt ) -{ -bool nRet = Control::Notify( rNEvt ); - -if ( m_pFocusCtrl rNEvt.GetWindow() != m_pFocusCtrl rNEvt.GetType() == MouseNotifyEvent::GETFOCUS ) -m_pFocusCtrl-GrabFocus(); -return nRet; -} - // functions - bool IsMultiPath_Impl( const sal_uInt16 nIndex ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91108] New: No visible Cursor during placing of Draw-elements (incl. form-elements)
https://bugs.documentfoundation.org/show_bug.cgi?id=91108 Bug ID: 91108 Summary: No visible Cursor during placing of Draw-elements (incl. form-elements) Product: LibreOffice Version: 5.0.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@mic-consulting.de Created attachment 115378 -- https://bugs.documentfoundation.org/attachment.cgi?id=115378action=edit No Cursor visible trying to place a Formula-Textfield When trying to place a drawing object (line, shape, textbox) or a formula object (all) inside a writer document, there is no cursor visible. see attached picture. So all placing is only possible by feeling - that is strange. After object is inserted it can by positioned. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/unotools
include/unotools/fontcfg.hxx | 48 ++- 1 file changed, 16 insertions(+), 32 deletions(-) New commits: commit 35a185e8e1dbe8dd42455795ff5f300bf67b0ffb Author: Jan Holesovsky ke...@collabora.com Date: Wed May 6 09:55:52 2015 +0200 Doxygenize comments. Change-Id: I2a54f0c2694bb069478a8c8764a1789a377b4c0a diff --git a/include/unotools/fontcfg.hxx b/include/unotools/fontcfg.hxx index faca982..1d181a9 100644 --- a/include/unotools/fontcfg.hxx +++ b/include/unotools/fontcfg.hxx @@ -34,37 +34,21 @@ enum class DefaultFontType; -// DEFAULT - Default-Font like Andale Sans UI, Palace Script, Albany, Thorndale, Cumberland, ... -// STANDARD - Standard-Font like Arial, Times, Courier, ... -// NORMAL- normal Font for writing text like Arial, Verdana, Arial Narrow, Trebuchet, Times, Courier, ... -// SYMBOL- Font with symbols -// DECORATIVE- Readable and normally used for drawings -// SPECIAL - very special design -// TITLING - only uppercase characters -// FONT_ATTR_FULL - Font with normally all characters -// CAPITALS - only uppercase characters, but lowercase characters smaller as the uppercase characters -// TYPEWRITER- like a typewriter: Courier, ... -// SCRIPT- Handwriting or Script -// HANDWRITING - More Handwriting with normal letters -// CHANCERY - Like Zapf Chancery -// COMIC - Like Comic Sans MS -// BRUSHSCRIPT - More Script -// OTHERSTYLE- OldStyle, ... so negativ points enum class ImplFontAttrs : sal_uLong { None = 0x, -Default = 0x0001, -Standard = 0x0002, -Normal= 0x0004, -Symbol= 0x0008, +Default = 0x0001, /// Default-Font like Andale Sans UI, Palace Script, Albany, Thorndale, Cumberland, ... +Standard = 0x0002, /// Standard-Font like Arial, Times, Courier, ... +Normal= 0x0004, /// Normal Font for writing text like Arial, Verdana, Arial Narrow, Trebuchet, Times, Courier, ... +Symbol= 0x0008, /// Font with symbols Fixed = 0x0010, SansSerif = 0x0020, Serif = 0x0040, -Decorative= 0x0080, -Special = 0x0100, +Decorative= 0x0080, /// Readable and normally used for drawings +Special = 0x0100, /// Very special design Italic= 0x0200, -Titling = 0x0400, -Capitals = 0x0800, +Titling = 0x0400, /// Only uppercase characters +Capitals = 0x0800, /// Only uppercase characters, but lowercase characters smaller as the uppercase characters CJK = 0x1000, CJK_JP= 0x2000, CJK_SC= 0x4000, @@ -72,19 +56,19 @@ enum class ImplFontAttrs : sal_uLong CJK_KR= 0x0001, CTL = 0x0002, NoneLatin = 0x0004, -Full = 0x0008, +Full = 0x0008, /// Font with normally all characters Outline = 0x0010, Shadow= 0x0020, Rounded = 0x0040, -Typewriter= 0x0080, -Script= 0x0100, -Handwriting = 0x0200, -Chancery = 0x0400, -Comic = 0x0800, -BrushScript = 0x1000, +Typewriter= 0x0080, /// Like a typewriter: Courier, ... +Script= 0x0100, /// Handwriting or Script +Handwriting = 0x0200, /// More Handwriting with normal letters +Chancery = 0x0400, /// Like Zapf Chancery +Comic = 0x0800, /// Like Comic Sans MS +BrushScript = 0x1000, /// More Script Gothic= 0x2000, Schoolbook= 0x4000, -OtherStyle= 0x8000, +OtherStyle= 0x8000, /// OldStyle, ... so negativ points CJK_AllLang = CJK_JP | CJK_SC | CJK_TC | CJK_KR, AllScript = Script | Handwriting | Chancery | Comic | BrushScript, AllSubscript = Handwriting | Chancery | Comic | BrushScript, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91078] Deleting a sheet which is not referenced by other sheets, destroys the formulas in those other sheets.
https://bugs.documentfoundation.org/show_bug.cgi?id=91078 Joel Madero jmadero@gmail.com changed: What|Removed |Added Priority|medium |highest CC||jmadero@gmail.com Hardware|Other |All Version|4.2.0.0.beta1 |4.1.6.2 release Blocks||75025 Whiteboard||bibisected Severity|normal |major --- Comment #9 from Joel Madero jmadero@gmail.com --- Version is oldest confirmed version. Updating per comment 1 setting to Major - loss of data Highest - regression + likely to impact a lot of users. Adding to 4.3mab ba096f438393091574da98fe7b8e6b05182a8971 is the first bad commit commit ba096f438393091574da98fe7b8e6b05182a8971 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Thu Oct 17 20:00:21 2013 + source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8 commit 8499e78ca03c792f4fa2650e02b519094ba0baa8 Author: Caolán McNamara caol...@redhat.com AuthorDate: Thu Jul 25 16:01:13 2013 +0100 Commit: Caolán McNamara caol...@redhat.com CommitDate: Thu Jul 25 16:08:01 2013 +0100 Related: fdo#61544 convert language page from box to grid grid compress better than boxes if there isn't enough available space Change-Id: I35b433b89a29159a33fc9edb646e46b371747a57 :100644 100644 28f5d06d73a1be6ffa14981fa5c85369334b42f3 69df816431adccb1d94d7239031fa72b51b69fd9 Mccache.log :100644 100644 e90dd416081e52bf1f529e5cc252b740762fb67f fb3eed5f2df90e38291b7693863d22a51ae5f909 Mcommitmsg :100644 100644 f3412ea896c81e0e5e7c7c5b20da51801f5732d1 b37aff13469762597fe8e71b9eec6543077c6320 Mdev-install.log :100644 100644 20c900e22a8115c31e67f895acbe3ec11c432314 a6d96513f1e560f38ad6b20e13ae9c5ddb619132 Mmake.log :04 04 956ae0b2d085e2de7f912e234fe22cb51b2e3f29 14c94892e549a813ae539489d88273f18ad79631 Mopt # bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e # good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932 git bisect start 'latest' 'oldest' # good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574 # bad: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b git bisect bad 4850941efe43ae800be5c76e1102ab80ac2c085d # skip: [a043626b542eb8314218d7439534dce2fc325304] source-hash-9379a922c07df3cdb7d567cc88dfaaa39ead3681 git bisect skip a043626b542eb8314218d7439534dce2fc325304 # skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6 # skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6 # bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930 git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31 # bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930 git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31 # bad: [1d4980621741d3050a5fe61b247c157d769988f2] source-hash-89d01a7d8028ddb765e02c116d202a2435894217 git bisect bad 1d4980621741d3050a5fe61b247c157d769988f2 # bad: [ba096f438393091574da98fe7b8e6b05182a8971] source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8 git bisect bad ba096f438393091574da98fe7b8e6b05182a8971 # good: [9daa289e178460daaafa4b3911031df5b8736218] source-hash-704292996a3731a61339b1a4a5c90c9403aa095f git bisect good 9daa289e178460daaafa4b3911031df5b8736218 # good: [34eab3946c46bb7273ba4ca395db9c4421dd232f] source-hash-e962805b31074d6b6a2ed0db6452769448337553 git bisect good 34eab3946c46bb7273ba4ca395db9c4421dd232f # good: [a8577b9049e085140768f97f7d4ff555a8a447cb] source-hash-98ded3e42011b060368899018c07cbd32e7993f1 git bisect good a8577b9049e085140768f97f7d4ff555a8a447cb # good: [da4ad98ef394c644bb0aa80161ff599330862e7c] source-hash-570fe620e9d573cfc9fc260e6518563c6a6c1a3c git bisect good da4ad98ef394c644bb0aa80161ff599330862e7c # good: [2d9baecf3ce2ea1ec8bea3e842eed595061eeef6] source-hash-ff51a2b64571a8d72ff4d8a8181d17cf98c42e69 git bisect good 2d9baecf3ce2ea1ec8bea3e842eed595061eeef6 # first bad commit: [ba096f438393091574da98fe7b8e6b05182a8971] source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org
[Libreoffice-commits] core.git: 3 commits - avmedia/inc avmedia/source chart2/source cui/source dbaccess/source extensions/source framework/inc framework/source include/sfx2 include/svx include/vcl re
avmedia/inc/mediacontrol.hxx|2 avmedia/source/framework/mediacontrol.cxx |4 - chart2/source/controller/dialogs/dlg_DataEditor.cxx |4 - chart2/source/controller/inc/dlg_DataEditor.hxx |2 cui/source/customize/cfg.cxx|4 - cui/source/inc/cfg.hxx |2 dbaccess/source/ui/app/AppDetailPageHelper.cxx |3 dbaccess/source/ui/app/AppDetailPageHelper.hxx |2 dbaccess/source/ui/dlg/indexdialog.cxx |4 - dbaccess/source/ui/inc/indexdialog.hxx |2 extensions/source/bibliography/toolbar.cxx |3 extensions/source/bibliography/toolbar.hxx |2 framework/inc/uielement/addonstoolbarmanager.hxx| 10 +- framework/inc/uielement/toolbarmanager.hxx | 12 +-- framework/source/uielement/addonstoolbarmanager.cxx | 30 ++-- framework/source/uielement/toolbarmanager.cxx | 43 --- include/sfx2/sidebar/SidebarToolBox.hxx | 12 +-- include/sfx2/templatedlg.hxx|8 +- include/sfx2/titledockwin.hxx |6 - include/svx/fontwork.hxx|6 - include/svx/imapdlg.hxx |2 include/vcl/toolbox.hxx | 29 +++ reportdesign/source/ui/dlg/AddField.cxx |3 reportdesign/source/ui/dlg/Condition.cxx|7 - reportdesign/source/ui/dlg/Condition.hxx|4 - reportdesign/source/ui/dlg/GroupsSorting.cxx|3 reportdesign/source/ui/inc/AddField.hxx |2 reportdesign/source/ui/inc/GroupsSorting.hxx|2 sc/source/ui/inc/navipi.hxx |2 sc/source/ui/navipi/navipi.cxx |4 - sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx| 11 +- sc/source/ui/sidebar/CellAppearancePropertyPanel.hxx|4 - sc/source/ui/sidebar/CellBorderStyleControl.cxx | 18 +--- sc/source/ui/sidebar/CellBorderStyleControl.hxx |6 - sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx |6 - sc/source/ui/sidebar/NumberFormatPropertyPanel.hxx |2 sd/source/ui/dlg/navigatr.cxx | 12 +-- sd/source/ui/inc/navigatr.hxx |6 - sfx2/source/appl/newhelp.cxx|4 - sfx2/source/appl/newhelp.hxx|4 - sfx2/source/dialog/recfloat.cxx |4 - sfx2/source/dialog/taskpane.cxx |6 - sfx2/source/dialog/templdlg.cxx | 11 +- sfx2/source/dialog/titledockwin.cxx |6 - sfx2/source/doc/templatedlg.cxx | 16 +--- sfx2/source/inc/recfloat.hxx|2 sfx2/source/inc/templdgi.hxx|6 - sfx2/source/sidebar/SidebarToolBox.cxx | 45 sfx2/source/sidebar/TitleBar.cxx|4 - sfx2/source/sidebar/TitleBar.hxx|2 starmath/inc/toolbox.hxx|4 - starmath/source/toolbox.cxx |6 - svx/inc/galbrws2.hxx|2 svx/source/dialog/_bmpmask.cxx |6 - svx/source/dialog/_contdlg.cxx |4 - svx/source/dialog/contimp.hxx |2 svx/source/dialog/fontwork.cxx |9 -- svx/source/dialog/imapdlg.cxx |4 - svx/source/form/datanavi.cxx|3 svx/source/gallery2/galbrws2.cxx|4 - svx/source/inc/datanavi.hxx |2 svx/source/sidebar/area/AreaPropertyPanel.cxx | 10 +- svx/source/sidebar/area/AreaPropertyPanel.hxx |2 svx/source/sidebar/area/AreaTransparencyGradientControl.cxx | 12 +-- svx/source/sidebar/area/AreaTransparencyGradientControl.hxx |4 - svx/source/sidebar/line/LinePropertyPanel.cxx |9 +- svx/source/sidebar/line/LinePropertyPanel.hxx |2 svx/source/sidebar/paragraph/ParaPropertyPanel.cxx | 14 +-- svx/source/sidebar/paragraph/ParaPropertyPanel.hxx |4 - svx/source/sidebar/possize/PosSizePropertyPanel.cxx |4 - svx/source/sidebar/possize/PosSizePropertyPanel.hxx |
[Libreoffice-commits] core.git: sc/source
sc/source/filter/starcalc/scflt.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f593be5bcde09965bb3478e00bcdedbc6bd5bc57 Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 6 08:17:32 2015 +0200 SfxBoolItem takes a sal_uInt16 nWhich as first argument This code was like that ever since 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24 initial import. From the surrounding code, the best bet appears to be ATTR_LINEBREAK? Change-Id: Id0e3346f2f9bb9c00c202003d06c2518dea38112 diff --git a/sc/source/filter/starcalc/scflt.cxx b/sc/source/filter/starcalc/scflt.cxx index 682eb20..b21f9a4 100644 --- a/sc/source/filter/starcalc/scflt.cxx +++ b/sc/source/filter/starcalc/scflt.cxx @@ -1189,7 +1189,7 @@ void Sc10Import::LoadPatternCollection() } if( ( OJustify ojWordBreak ) == ojWordBreak ) -rItemSet.Put( SfxBoolItem( sal_True ) ); +rItemSet.Put( SfxBoolItem( ATTR_LINEBREAK, true ) ); if( ( OJustify ojBottomTop ) == ojBottomTop ) rItemSet.Put( SfxInt32Item( ATTR_ROTATE_VALUE, 9000 ) ); else if( ( OJustify ojTopBottom ) == ojTopBottom ) @@ -1830,7 +1830,7 @@ void Sc10Import::LoadColAttr(SCCOL Col, SCTAB Tab) } if (OJustify ojWordBreak) -aScPattern.GetItemSet().Put(SfxBoolItem(sal_True)); +aScPattern.GetItemSet().Put(SfxBoolItem(ATTR_LINEBREAK, true)); if (OJustify ojBottomTop) aScPattern.GetItemSet().Put(SfxInt32Item(ATTR_ROTATE_VALUE,9000)); else if (OJustify ojTopBottom) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90382] Regression in libreoffice 4.3.6.1 on sending document by mail
https://bugs.documentfoundation.org/show_bug.cgi?id=90382 --- Comment #6 from Stephan Bergmann sberg...@redhat.com --- (In reply to bruno from comment #5) Your patch indeed is fixing my issue, when I improved it. I added comments to that gerrit link. no idea what your patch is 'If the mailclient value has not been specified, ie under Options: Internet - E-mail - E-mail program, E-mail program is empty.' My argument is that this should not normally happen on Linux. If the user does not explicitly specify the E-mail program option, it should automatically obtain a value (on GNOME, using the exact same gconf value that you're using in your patch). In our case we use KDE, and thunderbird is configured in the KDE panel as default mail client using the line /usr/bin/thunderbird -compse ... and there is no program specified manually in libreoffice options. Do you have the KDE backend libkdebe1lo.so installed as part of LO? If not, that explains why LO's E-mail program option is not automatically filled in. If yes, you need to debug into the if ( id == ExternalMailer ) { branch of getValue() in shell/source/backends/kdebe/kdeaccess.cxx to find out why reading that value from KDE does not work for you in LO. (So when you are on KDE, it is kind of structurally the wrong thing anyway to try and use GNOME's gconftool-2 to obtain a KDE setting's value.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91044] thousands separator '
https://bugs.documentfoundation.org/show_bug.cgi?id=91044 --- Comment #5 from rupert.thur...@gmail.com --- haha, now than i know the workaround, i guess it is more a usability problem. but a big enough one to make me search for a solution and a bug tracker. just as an additional note, microsoft designed the regional settings quite well i find, an old screenshot here: http://www.helixtech.com.au/languagesettings.htm . they do not mix language and number formatting. the region is important only important for the defaults, like keyboard, number format, date format, time format, language. at the end of the day, most regional settings seem to glue on the region, except the language and the keyboard seems to more glue on a person. maybe because it is most difficult to learn when a person moves from one region to another. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91107] New: Cut/Copy/Paste are active while they shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=91107 Bug ID: 91107 Summary: Cut/Copy/Paste are active while they shouldn't Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sworddrag...@aol.com I'm noticing in Calc and Writer that the Paste action is not disabled while the clipboard is empty. Also in Calc the actions Cut and Copy are active if the input line has the focus without selecting anything. Maybe other parts of LibreOffice are affected too but I haven't tested them. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91107] Cut/Copy/Paste/Select All are active while they shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=91107 sworddrag...@aol.com changed: What|Removed |Added Summary|Cut/Copy/Paste are active |Cut/Copy/Paste/Select All |while they shouldn't|are active while they ||shouldn't -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91107] Cut/Copy/Paste are active while they shouldn't
https://bugs.documentfoundation.org/show_bug.cgi?id=91107 --- Comment #1 from sworddrag...@aol.com --- I'm also noticing that this happens for the entry Select All in Writer while the document is empty and in Calc while the input line is empty. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/d879d5346b525c478e93363b7ec06e797ce01461/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/dbui/dbmgr.cxx | 14 -- 1 file changed, 14 deletions(-) New commits: commit 9f68d0a24bd0b85e325b3983a19331550bbdc1b1 Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 07:57:05 2015 +0100 drop useless temp debugging strings Change-Id: I3dbcc792278814df6c23d0f593bd6d86b5d4907e diff --git a/sw/source/uibase/dbui/dbmgr.cxx b/sw/source/uibase/dbui/dbmgr.cxx index d315405..0574eb4 100644 --- a/sw/source/uibase/dbui/dbmgr.cxx +++ b/sw/source/uibase/dbui/dbmgr.cxx @@ -1452,20 +1452,6 @@ bool SwDBManager::MergeMailFiles(SwWrtShell* pSourceShell, else if( pTargetView ) // must be available! { //print the target document -#if OSL_DEBUG_LEVEL 1 -bool _bVal; -sal_Int16 _nVal; -OUString _sVal; -const beans::PropertyValue* pDbgPrintOptions = rMergeDescriptor.aPrintOptions.getConstArray(); -for( sal_Int32 nOption = 0; nOption rMergeDescriptor.aPrintOptions.getLength(); ++nOption) -{ -OUString aName( pDbgPrintOptions[nOption].Name ); -uno::Any aVal( pDbgPrintOptions[nOption].Value ); -aVal = _bVal; -aVal = _nVal; -aVal = _sVal; -} -#endif // printing should be done synchronously otherwise the document // might already become invalid during the process uno::Sequence beans::PropertyValue aOptions( rMergeDescriptor.aPrintOptions ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-commits] Adapt SwSrcEditWindow's SyntaxTimerHdl to being used in an Idle now
So yeah SetTimeout should be deletet, but it should be replaced with SetPriority (and of course set with an appropriate Priority), because otherwise it gets the default priority: HIGH. The taks should be stopped if there is absolutely no more work to do. If stop is called it gets completely removed of the tasklist. So if you think that it has no more work todo you can stop it by yourself. But i think i get your point, because i see that i missed to ask if the task is active (i only check if it should be delete). I wil change this and then you could set the task as inactive if you think that for now it has no more work to do and if it comes to the position: if (... !pIdle-IsActive()) pIdle-Start(); it should be reactivatet. On Tue, May 5, 2015 at 11:46 AM, Stephan Bergmann sberg...@redhat.com wrote: I assume deleting the SetTimeout calls without replacement is fine, as the idle handler will automatically keep being called again? But then, is it OK that it only ever gets Stop()'ed in SwSrcEditWindow::dispose, or should it also stop itself when there's no more work to do? And is it necessary to do that if (... !pIdle-IsActive()) pIdle-Start(); thing from within the handler? On 05/05/2015 10:22 AM, Stephan Bergmann wrote: commit c0e209bf5f418f1564d16e234251783a0857a9d4 Author: Stephan Bergmann sberg...@redhat.com Date: Tue May 5 10:16:43 2015 +0200 Adapt SwSrcEditWindow's SyntaxTimerHdl to being used in an Idle now ...not a Timer, since d843f3de731667a298a83fc66637c7f983f3b24d changed timers to idle Change-Id: If8c6a52d6fb7b1e392e8f31bc8f0db22b2f049e1 diff --git a/sw/source/uibase/docvw/srcedtw.cxx b/sw/source/uibase/docvw/srcedtw.cxx index cd66ace..02e1e66 100644 --- a/sw/source/uibase/docvw/srcedtw.cxx +++ b/sw/source/uibase/docvw/srcedtw.cxx @@ -56,7 +56,6 @@ struct SwTextPortion #define MAX_SYNTAX_HIGHLIGHT 20 #define MAX_HIGHLIGHTTIME 200 -#define SYNTAX_HIGHLIGHT_TIMEOUT 200 typedef std::dequeSwTextPortion SwTextPortions; @@ -579,7 +578,7 @@ IMPL_LINK(SwSrcEditWindow, ScrollHdl, ScrollBar*, pScroll) return 0; } -IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) +IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Idle *, pIdle ) { tools::Time aSyntaxCheckStart( tools::Time::SYSTEM ); SAL_WARN_IF(pTextView == 0, sw, No View yet, but syntax highlighting?!); @@ -605,7 +604,6 @@ IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) break; if((tools::Time( tools::Time::SYSTEM ).GetTime() - aSyntaxCheckStart.GetTime()) MAX_HIGHLIGHTTIME ) { -pTimer-SetTimeout( 2 * SYNTAX_HIGHLIGHT_TIMEOUT ); break; } } @@ -620,13 +618,12 @@ IMPL_LINK( SwSrcEditWindow, SyntaxTimerHdl, Timer *, pTimer ) nCount ++; if(tools::Time( tools::Time::SYSTEM ).GetTime() - aSyntaxCheckStart.GetTime() MAX_HIGHLIGHTTIME) { -pTimer-SetTimeout( 2 * SYNTAX_HIGHLIGHT_TIMEOUT ); break; } } -if(!aSyntaxLineTable.empty() !pTimer-IsActive()) -pTimer-Start(); +if(!aSyntaxLineTable.empty() !pIdle-IsActive()) +pIdle-Start(); // SyntaxTimerHdl is called when text changed // = good opportunity to determine text width! long nPrevTextWidth = nCurTextWidth; diff --git a/sw/source/uibase/inc/srcedtw.hxx b/sw/source/uibase/inc/srcedtw.hxx index 823e3cd..55e53f4 100644 --- a/sw/source/uibase/inc/srcedtw.hxx +++ b/sw/source/uibase/inc/srcedtw.hxx @@ -95,7 +95,7 @@ private: using OutputDevice::SetFont; voidSetFont(); -DECL_LINK( SyntaxTimerHdl, Timer * ); +DECL_LINK( SyntaxTimerHdl, Idle * ); DECL_LINK( TimeoutHdl, Timer * ); using Window::Notify; ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #12 from Joel Madero jmadero@gmail.com --- Created attachment 115377 -- https://bugs.documentfoundation.org/attachment.cgi?id=115377action=edit RTF that opens and seems to look right -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 Joel Madero jmadero@gmail.com changed: What|Removed |Added Keywords||regression CC||jmadero@gmail.com, ||vmik...@collabora.co.uk Whiteboard||filter:rtf bibisected OS|Windows (All) |All --- Comment #11 from Joel Madero jmadero@gmail.com --- Whoa - didn't think that this one was ever working but I found that for a very short period of time it did. This is thus a regression. @Burak - if you're using LibreOffice in a professional environment I highly recommend getting paid support. Else you'll have to wait until someone chooses to fix this (might be fast, might take months) bc687bf6bc5604c51680e798536ccbf35fa0c6b8 is the first bad commit commit bc687bf6bc5604c51680e798536ccbf35fa0c6b8 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Dec 11 00:03:49 2012 + source-hash-1692cf6854ff7adbb2bd47f2f7ec2b3de51864f3 commit 1692cf6854ff7adbb2bd47f2f7ec2b3de51864f3 Author: Caolán McNamara caol...@redhat.com AuthorDate: Sat Oct 27 16:50:37 2012 +0100 Commit: Caolán McNamara caol...@redhat.com CommitDate: Sat Oct 27 20:16:51 2012 +0100 drop unnecessary usings Change-Id: I65b7c81a45925894ef78f141219fd00652ad5c1d :100644 100644 6472c84c882da95b0efce6abb6f22ada8cbc650e 00f767a0b986e96e8b9f19c999d03a5ac4e44b8d Mccache.log :100644 100644 0c218954a7d6d690e76b671fc666a21001821d51 48d30a62e5b1dfc2329507412ef49b07a3051fb6 Mcommitmsg :100644 100644 7e7c9fd328d3cec865d8fa5342caaf44d193f9f8 54f9e1f393211af775093e98cf73f9e4148acede Mdev-install.log :100644 100644 99e9024e01746ce12aeea90bf311b7b27f0432b1 899d636a463e69df872bc4010e2df4f16b284611 Mmake.log :04 04 514acc838a19a0402d6947011628b8a7bd8a 422b4adc652e4c0e578682b53de32a05f9d4d869 Mopt # bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e # good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932 git bisect start 'latest' 'oldest' # bad: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb git bisect bad e02439a3d6297a1f5334fa558ddec5ef4212c574 # good: [8f4aeaad2f65d656328a451154142bb82efa4327] source-hash-1885266f274575327cdeee9852945a3e91f32f15 git bisect good 8f4aeaad2f65d656328a451154142bb82efa4327 # bad: [9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02] source-hash-8600bc24bbc9029e92bea6102bff2921bc10b33e git bisect bad 9995fae0d8a24ce31bcb5e9cd0459b69cfbf7a02 # bad: [51b63dca7427db64929ae1885d7cf1cc7eb0ba28] source-hash-806d18ae7b8c241fe90e49d3d370306769c50a10 git bisect bad 51b63dca7427db64929ae1885d7cf1cc7eb0ba28 # good: [446a69834acf747d9d18841ec583512ae8fa42e7] source-hash-06a8ca9339f02fccf6961c0de77c49673823b35f git bisect good 446a69834acf747d9d18841ec583512ae8fa42e7 # good: [2f701cd5a012710b5a360239b7078ca3b23206ab] source-hash-e9960f36675a025c0536dec30ae56c50f4adecb1 git bisect good 2f701cd5a012710b5a360239b7078ca3b23206ab # good: [9342aecf0416e372c1d2f307d49c715ec726c6bd] source-hash-b0da54bec69f4931af0adbc15d230d3f4eea7b08 git bisect good 9342aecf0416e372c1d2f307d49c715ec726c6bd # good: [1e4f8bf8304c7ecaaf68f2d16f09ef2f97d10af7] source-hash-fe347327a44f2d8ed201f9fbc2ae4858f34962d8 git bisect good 1e4f8bf8304c7ecaaf68f2d16f09ef2f97d10af7 # bad: [d3bd29a09db468f81d33acb14551b385b3615472] source-hash-7799ceab2639f1e3bcd35c6cf7e7b064bb1b6e9a git bisect bad d3bd29a09db468f81d33acb14551b385b3615472 # bad: [bc687bf6bc5604c51680e798536ccbf35fa0c6b8] source-hash-1692cf6854ff7adbb2bd47f2f7ec2b3de51864f3 git bisect bad bc687bf6bc5604c51680e798536ccbf35fa0c6b8 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/rendercontext' - 6 commits - basctl/source include/vcl sw/source vcl/source
basctl/source/basicide/baside2b.cxx |6 - include/vcl/slider.hxx |9 + include/vcl/spin.h | 14 +- include/vcl/tabctrl.hxx |6 - include/vcl/textview.hxx| 17 +-- include/vcl/toolbox.hxx | 10 +- sw/source/uibase/docvw/srcedtw.cxx |4 vcl/source/app/help.cxx | 36 +++ vcl/source/control/slider.cxx | 166 +++-- vcl/source/control/spinbtn.cxx | 18 +-- vcl/source/control/spinfld.cxx | 154 +++--- vcl/source/control/tabctrl.cxx | 179 ++-- vcl/source/edit/texteng.cxx |5 - vcl/source/edit/textview.cxx| 86 - vcl/source/edit/vclmedit.cxx|6 - vcl/source/window/toolbox.cxx |2 16 files changed, 368 insertions(+), 350 deletions(-) New commits: commit 4d69a3fec28a4d35d9c09b6e0feee80dfbc2aaaf Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk Date: Wed May 6 15:49:16 2015 +0900 refactor TextEdit co. to use RenderContext Change-Id: Ib26ecb9640d23714acec73304f26e2fd6af90ed4 diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx index 6cbaaf5..d805646 100644 --- a/basctl/source/basicide/baside2b.cxx +++ b/basctl/source/basicide/baside2b.cxx @@ -915,12 +915,12 @@ void EditorWindow::SetupAndShowCodeCompleteWnd( const std::vector OUString a pEditView-GetWindow()-GrabFocus(); } -void EditorWindow::Paint( vcl::RenderContext /*rRenderContext*/, const Rectangle rRect ) +void EditorWindow::Paint(vcl::RenderContext rRenderContext, const Rectangle rRect) { -if ( !pEditEngine ) // We need it now at latest +if (!pEditEngine) // We need it now at latest CreateEditEngine(); -pEditView-Paint( rRect ); +pEditView-Paint(rRenderContext, rRect); } void EditorWindow::LoseFocus() diff --git a/include/vcl/textview.hxx b/include/vcl/textview.hxx index baf97a9..721c0c0 100644 --- a/include/vcl/textview.hxx +++ b/include/vcl/textview.hxx @@ -25,10 +25,11 @@ #include vcl/dllapi.h #include vcl/dndhelp.hxx #include vcl/textdata.hxx +#include vcl/window.hxx class TextEngine; class OutputDevice; -namespace vcl { class Window; } + class KeyEvent; class MouseEvent; class CommandEvent; @@ -37,11 +38,7 @@ class SelectionEngine; class VirtualDevice; struct TextDDInfo; -namespace com { -namespace sun { -namespace star { -namespace datatransfer { -namespace clipboard { +namespace com { namespace sun { namespace star { namespace datatransfer { namespace clipboard { class XClipboard; } @@ -72,8 +69,8 @@ protected: voidImpSetSelection( const TextSelection rNewSel, bool bUI ); boolIsInSelection( const TextPaM rPaM ); -voidImpPaint( OutputDevice* pOut, const Point rStartPos, Rectangle const* pPaintArea, TextSelection const* pPaintRange = 0, TextSelection const* pSelection = 0 ); -voidImpPaint( const Rectangle rRect, bool bUseVirtDev ); +voidImpPaint(vcl::RenderContext rRenderContext, const Point rStartPos, Rectangle const* pPaintArea, TextSelection const* pPaintRange = 0, TextSelection const* pSelection = 0); +voidImpPaint(vcl::RenderContext rRenderContext, const Rectangle rRect, bool bUseVirtDev); voidImpShowCursor( bool bGotoCursor, bool bForceVisCursor, bool bEndKey ); voidImpHighlight( const TextSelection rSel ); voidImpSetSelection( const TextSelection rSelection ); @@ -127,8 +124,8 @@ public: voidInsertText( const OUString rNew, bool bSelect = false ); -boolKeyInput( const KeyEvent rKeyEvent ); -voidPaint( const Rectangle rRect ); +boolKeyInput( const KeyEvent rKeyEvent ); +voidPaint(vcl::RenderContext rRenderContext, const Rectangle rRect); voidMouseButtonUp( const MouseEvent rMouseEvent ); voidMouseButtonDown( const MouseEvent rMouseEvent ); voidMouseMove( const MouseEvent rMouseEvent ); diff --git a/sw/source/uibase/docvw/srcedtw.cxx b/sw/source/uibase/docvw/srcedtw.cxx index cd66ace..2e42082 100644 --- a/sw/source/uibase/docvw/srcedtw.cxx +++ b/sw/source/uibase/docvw/srcedtw.cxx @@ -479,9 +479,9 @@ void TextViewOutWin::KeyInput( const KeyEvent rKEvt ) } } -void TextViewOutWin::Paint( vcl::RenderContext /*rRenderContext*/, const Rectangle rRect ) +void TextViewOutWin::Paint(vcl::RenderContext rRenderContext, const Rectangle rRect) { -pTextView-Paint( rRect ); +pTextView-Paint(rRenderContext, rRect); } void SwSrcEditWindow::CreateTextEngine() diff --git a/vcl/source/edit/texteng.cxx b/vcl/source/edit/texteng.cxx index 235dd13..86a7173 100644 ---
[Libreoffice-bugs] [Bug 91098] SCM friendly file format
https://bugs.documentfoundation.org/show_bug.cgi?id=91098 David Juran da...@juran.se changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|NOTABUG |--- --- Comment #3 from David Juran da...@juran.se --- Not having read the paper, in my opinion, the Flat ODF format is still not a perfect fit. Among other issues, it is rather chatty with e.g. a time-stamp embedded in every save which makes diff:in and merging challenging. In my opinion, we should keep this RFE open to decide what to do with it. Modifications to the Flat ODF? A new format? Or something entirely different... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91109] New: Letter converts temporary in uppercase
https://bugs.documentfoundation.org/show_bug.cgi?id=91109 Bug ID: 91109 Summary: Letter converts temporary in uppercase Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sworddrag...@aol.com Steps to reproduce: 1. Open Calc and click into the input line. 2. Type a and press tab or enter. Actual result: The letter a in the input line converts for a very short time into an A. Expected result: The letter a in the input line should not convert into an A. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91073] Crash on insert table split button
https://bugs.documentfoundation.org/show_bug.cgi?id=91073 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Michael Meeks michael.me...@collabora.com --- Thanks for the report - looks like another duplicate; please do de-duplicate it if you can reproduce with a more recent master build. Thanks ! *** This bug has been marked as a duplicate of bug 91081 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sd/source
sd/source/ui/view/DocumentRenderer.cxx | 44 + 1 file changed, 13 insertions(+), 31 deletions(-) New commits: commit b186e6f1ad9dfd1c6534f047bdd3e22ee993a7c8 Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 12:21:11 2015 +0100 impress and draw want to disable the size category with brochure printing Change-Id: I08e814a2895490faebd79ca9e340d6bd8a0b5bfd diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx index 8f00559..0fae5ca 100644 --- a/sd/source/ui/view/DocumentRenderer.cxx +++ b/sd/source/ui/view/DocumentRenderer.cxx @@ -506,37 +506,19 @@ namespace { aWidgetIds[1] = fittoprintable; aWidgetIds[2] = distributeonmultiple; aWidgetIds[3] = tilesheet; -if( mbImpress ) -{ -// FIXME: additional dependency on PrintProspect = false -vcl::PrinterOptionsHelper::UIControlOptions aPageOptionsOpt( PageContentType , 0 ); -AddDialogControl( vcl::PrinterOptionsHelper::setChoiceRadiosControlOpt( -aWidgetIds, -, -aHelpIds, -PageOptions , - CreateChoice(_STR_IMPRESS_PRINT_UI_PAGE_OPTIONS_CHOICES), -0, -Sequence sal_Bool (), -aPageOptionsOpt -) -); -} -else -{ -vcl::PrinterOptionsHelper::UIControlOptions aPageOptionsOpt( PrintProspect , sal_False ); -AddDialogControl( vcl::PrinterOptionsHelper::setChoiceRadiosControlOpt( -aWidgetIds, -, -aHelpIds, -PageOptions , - CreateChoice(_STR_IMPRESS_PRINT_UI_PAGE_OPTIONS_CHOICES_DRAW), -0, -Sequence sal_Bool (), -aPageOptionsOpt -) -); -} + +vcl::PrinterOptionsHelper::UIControlOptions aPageOptionsOpt(PrintProspect, 0); +AddDialogControl( vcl::PrinterOptionsHelper::setChoiceRadiosControlOpt( +aWidgetIds, +, +aHelpIds, +PageOptions , +CreateChoice(mbImpress ? _STR_IMPRESS_PRINT_UI_PAGE_OPTIONS_CHOICES : _STR_IMPRESS_PRINT_UI_PAGE_OPTIONS_CHOICES_DRAW), +0, +Sequence sal_Bool (), +aPageOptionsOpt +) +); vcl::PrinterOptionsHelper::UIControlOptions aBrochureOpt; aBrochureOpt.maGroupHint = LayoutPage ; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90943] Merge and Center Cells bug
https://bugs.documentfoundation.org/show_bug.cgi?id=90943 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords|regression | CC||fdb...@neosheffield.co.uk Version|4.3.7.2 rc |Inherited From OOo Whiteboard|bibisectRequest | --- Comment #2 from Matthew Francis fdb...@neosheffield.co.uk --- I can reproduce this back to OOo 3.3.0 @Beluga: Also reproduces for me on libreoffice-3.5.0rc3, could you re-check? Thanks - Version: Inherited from OOo -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sfx2/source
sfx2/source/dialog/basedlgs.cxx | 81 1 file changed, 42 insertions(+), 39 deletions(-) New commits: commit 8c4bbc0a0ddb1ea8051f0be5a42ef128cf7d891e Author: Michael Meeks michael.me...@collabora.com Date: Wed May 6 13:42:21 2015 +0100 tdf#91100 - don't Notify focus changes after dispose. Change-Id: If870f88d1d83db8bd436ac1bb9a1c676c34605b5 diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx index d33f895..b961ac1 100644 --- a/sfx2/source/dialog/basedlgs.cxx +++ b/sfx2/source/dialog/basedlgs.cxx @@ -48,8 +48,8 @@ using namespace ::com::sun::star::uno; SingleTabDlgImpl::SingleTabDlgImpl() : m_pSfxPage(NULL) , m_pLine(NULL) -{ -} +{ +} class SfxModelessDialog_Impl : public SfxListener { @@ -335,30 +335,31 @@ void SfxModelessDialog::Init(SfxBindings *pBindinx, SfxChildWindow *pCW) */ bool SfxModelessDialog::Notify( NotifyEvent rEvt ) { -if ( rEvt.GetType() == MouseNotifyEvent::GETFOCUS ) -{ -pBindings-SetActiveFrame( pImp-pMgr-GetFrame() ); -pImp-pMgr-Activate_Impl(); -} -else if ( rEvt.GetType() == MouseNotifyEvent::LOSEFOCUS !HasChildPathFocus() ) -{ -pBindings-SetActiveFrame( ::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame () ); -pImp-pMgr-Deactivate_Impl(); -} -else if( rEvt.GetType() == MouseNotifyEvent::KEYINPUT ) +if ( pImp ) { -// First, allow KeyInput for Dialog functions ( TAB etc. ) -if ( !ModelessDialog::Notify( rEvt ) SfxViewShell::Current() ) -// then also for valid global accelerators. -return SfxViewShell::Current()-GlobalKeyInput_Impl( *rEvt.GetKeyEvent() ); -return true; +if ( rEvt.GetType() == MouseNotifyEvent::GETFOCUS ) +{ +pBindings-SetActiveFrame( pImp-pMgr-GetFrame() ); +pImp-pMgr-Activate_Impl(); +} +else if ( rEvt.GetType() == MouseNotifyEvent::LOSEFOCUS !HasChildPathFocus() ) +{ +pBindings-SetActiveFrame( ::com::sun::star::uno::Reference ::com::sun::star::frame::XFrame () ); +pImp-pMgr-Deactivate_Impl(); +} +else if( rEvt.GetType() == MouseNotifyEvent::KEYINPUT ) +{ +// First, allow KeyInput for Dialog functions ( TAB etc. ) +if ( !ModelessDialog::Notify( rEvt ) SfxViewShell::Current() ) +// then also for valid global accelerators. +return SfxViewShell::Current()-GlobalKeyInput_Impl( *rEvt.GetKeyEvent() ); +return true; +} } return ModelessDialog::Notify( rEvt ); } - - SfxModelessDialog::~SfxModelessDialog() { disposeOnce(); @@ -369,6 +370,7 @@ void SfxModelessDialog::dispose() if ( pImp-pMgr-GetFrame().is() pImp-pMgr-GetFrame() == pBindings-GetActiveFrame() ) pBindings-SetActiveFrame( NULL ); delete pImp; +pImp = NULL; ModelessDialog::dispose(); } @@ -423,33 +425,34 @@ bool SfxFloatingWindow::Notify( NotifyEvent rEvt ) */ { -if ( rEvt.GetType() == MouseNotifyEvent::GETFOCUS ) -{ -pBindings-SetActiveFrame( pImp-pMgr-GetFrame() ); -pImp-pMgr-Activate_Impl(); -} -else if ( rEvt.GetType() == MouseNotifyEvent::LOSEFOCUS ) +if ( pImp ) { -if ( !HasChildPathFocus() ) +if ( rEvt.GetType() == MouseNotifyEvent::GETFOCUS ) { -pBindings-SetActiveFrame( NULL ); -pImp-pMgr-Deactivate_Impl(); +pBindings-SetActiveFrame( pImp-pMgr-GetFrame() ); +pImp-pMgr-Activate_Impl(); +} +else if ( rEvt.GetType() == MouseNotifyEvent::LOSEFOCUS ) +{ +if ( !HasChildPathFocus() ) +{ +pBindings-SetActiveFrame( NULL ); +pImp-pMgr-Deactivate_Impl(); +} +} +else if( rEvt.GetType() == MouseNotifyEvent::KEYINPUT ) +{ +// First, allow KeyInput for Dialog functions +if ( !FloatingWindow::Notify( rEvt ) SfxViewShell::Current() ) +// then also for valid global accelerators. +return SfxViewShell::Current()-GlobalKeyInput_Impl( *rEvt.GetKeyEvent() ); +return true; } -} -else if( rEvt.GetType() == MouseNotifyEvent::KEYINPUT ) -{ -// First, allow KeyInput for Dialog functions -if ( !FloatingWindow::Notify( rEvt ) SfxViewShell::Current() ) -// then also for valid global accelerators. -return SfxViewShell::Current()-GlobalKeyInput_Impl( *rEvt.GetKeyEvent() ); -return true; } return FloatingWindow::Notify( rEvt ); } - - SfxFloatingWindow::SfxFloatingWindow( SfxBindings *pBindinx, SfxChildWindow *pCW, vcl::Window* pParent, WinBits nWinBits) : ___
[Libreoffice-bugs] [Bug 47596] FILEOPEN: MS-Office doc file incorrectly displaying of attached picture
https://bugs.documentfoundation.org/show_bug.cgi?id=47596 --- Comment #12 from grofaty grof...@hotmail.com --- Retested on LibreOffice v.4.4.2.2 on Windows 7 and problem still persists. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/dialogs/cuihyperdlg.cxx |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) New commits: commit 952220b750a5bc8a9d9df03e109ed1d84c393842 Author: Michael Meeks michael.me...@collabora.com Date: Wed May 6 11:54:24 2015 +0100 tdf#91014 - dispose SfxControllerItem sub-class earlier. This avoids getting StateChange calls on disposed widgets. Change-Id: I33968f1afc09df47eda5ad5e0f0ae3a5cc408a63 diff --git a/cui/source/dialogs/cuihyperdlg.cxx b/cui/source/dialogs/cuihyperdlg.cxx index 1270e09..6c3c549 100644 --- a/cui/source/dialogs/cuihyperdlg.cxx +++ b/cui/source/dialogs/cuihyperdlg.cxx @@ -36,8 +36,8 @@ using ::com::sun::star::frame::XFrame; SvxHlinkCtrl::SvxHlinkCtrl( sal_uInt16 _nId, SfxBindings rBindings, SvxHpLinkDlg* pDlg ) -: SfxControllerItem ( _nId, rBindings ) - ,aRdOnlyForwarder ( SID_READONLY_MODE, *this ) +: SfxControllerItem ( _nId, rBindings ) +, aRdOnlyForwarder ( SID_READONLY_MODE, *this ) { pParent = pDlg; } @@ -45,7 +45,7 @@ SvxHlinkCtrl::SvxHlinkCtrl( sal_uInt16 _nId, SfxBindings rBindings, SvxHpLinkD void SvxHlinkCtrl::StateChanged( sal_uInt16 nSID, SfxItemState eState, const SfxPoolItem* pState ) { -if ( eState == SfxItemState::DEFAULT ) +if ( eState == SfxItemState::DEFAULT !pParent-IsDisposed() ) { switch ( nSID ) { @@ -169,6 +169,8 @@ void SvxHpLinkDlg::dispose() delete mpItemSet; mpItemSet = NULL; +maCtrl.dispose(); + IconChoiceDialog::dispose(); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91014] LO crashes 100% of attempts to add a hyperlink in writer or calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91014 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Michael Meeks michael.me...@collabora.com --- Thanks for the report ! =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 88276] Please add UI for new LO 4.4. feature Text Background Color in Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=88276 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC|libreoffice-ux-advise@lists |philip...@hotmail.com |.freedesktop.org| Component|ux-advise |Draw --- Comment #6 from Yousuf (Jay) Philips philip...@hotmail.com --- So what is needed is to incorporate various features available in Writer. 1) Toolbar button - A 'Highlighting' (aka character background) button should be added to the 'Text Formatting' toolbar next to the 'Font Color' button. 2) Sidebar button - The 'Highlighting' button should also be added to the character section of the properties tab 3) Character dialog - A 'background' tab should be added to the dialog. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91014] LO crashes 100% of attempts to add a hyperlink in writer or calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91014 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91014] LO crashes 100% of attempts to add a hyperlink in writer or calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91014 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Meeks committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=952220b750a5bc8a9d9df03e109ed1d84c393842 tdf#91014 - dispose SfxControllerItem sub-class earlier. It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source include/svl include/svx svl/source svx/source
cui/source/dialogs/cuires.src | 10 + cui/source/inc/cuires.hrc |3 + cui/source/inc/numfmt.hxx |3 + cui/source/tabpages/numfmt.cxx | 38 ++- include/svl/zforlist.hxx|6 +++ include/svl/zformat.hxx |3 + include/svx/numfmtsh.hxx|2 + svl/source/numbers/zforlist.cxx | 77 +--- svx/source/items/numfmtsh.cxx |7 +++ 9 files changed, 134 insertions(+), 15 deletions(-) New commits: commit f630f9598f2e328cbe37aff5af0e93c027a94de5 Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net Date: Sun May 3 15:09:20 2015 +0200 tdf#90258 Toggle Thousand Separator with Engineering Notation If scientific format is selected, Thousands separator option is almost useless. It could be replaced by Engineering Notation. Rebase of https://gerrit.libreoffice.org/15152 Update with more robust tests. Change-Id: Ie2b88b1f149fce26c32a43ace623cf1f45f38e6e Reviewed-on: https://gerrit.libreoffice.org/15606 Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com diff --git a/cui/source/dialogs/cuires.src b/cui/source/dialogs/cuires.src index fe97a9c..a738423 100644 --- a/cui/source/dialogs/cuires.src +++ b/cui/source/dialogs/cuires.src @@ -60,6 +60,16 @@ String RID_SVXSTR_AUTO_ENTRY Text [ en-US ] = Automatic; }; +String RID_SVXSTR_THOUSAND_SEP +{ +Text [ en-US ] = Thousands separator; +}; + +String RID_SVXSTR_ENGINEERING +{ +Text [ en-US ] = Engineering notation; +}; + String RID_SVXSTR_EDIT_GRAPHIC { Text [ en-US ] = Link ; diff --git a/cui/source/inc/cuires.hrc b/cui/source/inc/cuires.hrc index a8cf111..d6852c3 100644 --- a/cui/source/inc/cuires.hrc +++ b/cui/source/inc/cuires.hrc @@ -440,6 +440,9 @@ #define RID_SVXSTR_PERSONA_MUSIC(RID_SVX_START + 1288) #define RID_SVXSTR_PERSONA_NATURE (RID_SVX_START + 1289) +#define RID_SVXSTR_THOUSAND_SEP (RID_SVX_START + 1290) +#define RID_SVXSTR_ENGINEERING (RID_SVX_START + 1291) + #define RID_SVXPAGE_OPENCL (RID_SVX_START + 254) #endif diff --git a/cui/source/inc/numfmt.hxx b/cui/source/inc/numfmt.hxx index 65e9f1a..c4413ab 100644 --- a/cui/source/inc/numfmt.hxx +++ b/cui/source/inc/numfmt.hxx @@ -130,6 +130,8 @@ private: short nFixedCategory; OUString sAutomaticEntry; +OUString sThousandSeparator; +OUString sEngineeringNotation; VclPtrvcl::WindowpLastActivWindow; @@ -138,6 +140,7 @@ private: voidFillFormatListBox_Impl( std::vectorOUString rEntries ); voidUpdateOptions_Impl( bool bCheckCatChange ); voidUpdateFormatListBox_Impl( bool bCat, bool bUpdateEdit ); +voidUpdateThousandEngineeringText(); voidObstructing(); voidEnableBySourceFormat_Impl(); voidSetCategory( sal_uInt16 nPos ); diff --git a/cui/source/tabpages/numfmt.cxx b/cui/source/tabpages/numfmt.cxx index 352077e..5720e2d 100644 --- a/cui/source/tabpages/numfmt.cxx +++ b/cui/source/tabpages/numfmt.cxx @@ -243,6 +243,8 @@ SvxNumberFormatTabPage::SvxNumberFormatTabPage(vcl::Window* pParent, , pNumFmtShell(NULL) , nInitFormat(ULONG_MAX) , sAutomaticEntry(CUI_RES(RID_SVXSTR_AUTO_ENTRY)) +, sThousandSeparator(CUI_RES(RID_SVXSTR_THOUSAND_SEP)) +, sEngineeringNotation(CUI_RES(RID_SVXSTR_ENGINEERING)) , pLastActivWindow(NULL) { get(m_pFtCategory, categoryft); @@ -355,6 +357,7 @@ void SvxNumberFormatTabPage::Init_Impl() m_pIbAdd-SetClickHdl( HDL( ClickHdl_Impl ) ); m_pIbRemove-SetClickHdl( HDL( ClickHdl_Impl ) ); m_pIbInfo-SetClickHdl( HDL( ClickHdl_Impl ) ); +UpdateThousandEngineeringText(); aLink = LINK( this, SvxNumberFormatTabPage, LostFocusHdl_Impl); @@ -907,7 +910,7 @@ void SvxNumberFormatTabPage::FillFormatListBox_Impl( std::vectorOUString rEnt void SvxNumberFormatTabPage::UpdateOptions_Impl( bool bCheckCatChange /*= sal_False*/ ) { -OUString theFormat = m_pEdFormat-GetText(); +OUStringtheFormat = m_pEdFormat-GetText(); sal_Int32 nCurCategory= m_pLbCategory-GetSelectEntryPos(); sal_uInt16 nCategory = static_castsal_uInt16(nCurCategory); sal_uInt16 nDecimals = 0; @@ -965,10 +968,18 @@ void SvxNumberFormatTabPage::UpdateOptions_Impl( bool bCheckCatChange /*= sal_Fa switch ( nCategory ) { +case CAT_SCIENTIFIC: // bThousand is for Engineering notation +{ +sal_uInt16 nIntDigits = pNumFmtShell-GetFormatIntegerDigits(theFormat); +if ( (nIntDigits 0) (nIntDigits % 3 == 0) ) +bThousand = true; +else +bThousand = false; +} +// fallthru
[Libreoffice-bugs] [Bug 91015] FILEOPEN: Open Csv file create with calc, crash, without error message.
https://bugs.documentfoundation.org/show_bug.cgi?id=91015 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Michael Meeks michael.me...@collabora.com --- Thanks for the report - missing VirtualDevice instances during the VclPtr migration. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91092] JavaScript macro causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=91092 --- Comment #4 from Stephan Bergmann sberg...@redhat.com --- (In reply to Matthew Francis from comment #2) The history of this appears to be that: [...] making the script visible again but still not allowing it to be run successfully. What is the exact problem? Something else than the crash on current master described in comment 3, which happens upon Tools - Macros - Organize Macros - JavaScript... - demo.ods - Language - language.js.js - Edit? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91100] Closing Word count crashes writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91100 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- @mmeeks: bug 91081 is fixed but I can still reproduce this one on a fresh (dbgutil) master build as of 0a6012912f76a6fca7c6aac081b4b2940b8d055c -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: solenv/bin
solenv/bin/native-code.py | 11 +++ 1 file changed, 11 insertions(+) New commits: commit a5a17610d5eff80387c7330527793de87cc82e58 Author: Jan Holesovsky ke...@collabora.com Date: Wed May 6 12:27:52 2015 +0200 android: More services that are probably needed. Change-Id: Ibc394aa8ae758bbcc478707731cda3b270499ce2 diff --git a/solenv/bin/native-code.py b/solenv/bin/native-code.py index 2bd15f2..676e9c4 100755 --- a/solenv/bin/native-code.py +++ b/solenv/bin/native-code.py @@ -225,9 +225,20 @@ edit_factory_list = [ ] edit_constructor_list = [ +# framework/util/fwk.component com_sun_star_comp_framework_GlobalAcceleratorConfiguration_get_implementation, +# i18npool/util/i18npool.component com_sun_star_i18n_InputSequenceChecker_get_implementation, com_sun_star_i18n_OrdinalSuffix_get_implementation, +# sc/util/sc.component +Calc_XMLOasisContentExporter_get_implementation, +Calc_XMLOasisExporter_get_implementation, +Calc_XMLOasisMetaExporter_get_implementation, +Calc_XMLOasisSettingsExporter_get_implementation, +Calc_XMLOasisStylesExporter_get_implementation, +# starmath/util/sm.component +Math_XMLOasisMetaExporter_get_implementation, +Math_XMLOasisSettingsExporter_get_implementation, # sw/util/sw.component com_sun_star_comp_Writer_XMLOasisContentExporter_get_implementation, com_sun_star_comp_Writer_XMLOasisMetaExporter_get_implementation, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91100] Closing Word count crashes writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91100 Michael Meeks michael.me...@collabora.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Michael Meeks michael.me...@collabora.com --- Thanks ! can't reproduce on master - I assume a duplicate as below; if it recurrs with a recent master for you - please un-mark it as a duplicate =) *** This bug has been marked as a duplicate of bug 91081 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91092] JavaScript macro causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=91092 --- Comment #5 from Matthew Francis fdb...@neosheffield.co.uk --- (In reply to Stephan Bergmann from comment #4) What is the exact problem? Something else than the crash on current master described in comment 3, which happens upon Tools - Macros - Organize Macros - JavaScript... - demo.ods - Language - language.js.js - Edit? I was using Run rather than Edit but it looks like probably the same issue -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/print.hxx |2 +- vcl/source/gdi/print3.cxx | 17 ++--- 2 files changed, 11 insertions(+), 8 deletions(-) New commits: commit 7847a338f13071dcd591617f0e8d8fd69b2b0818 Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 13:01:57 2015 +0100 cancel doesn't cancel printing regression from commit e0ad036eed6b151ea81311fcf9ba46f1726b103c Author: LuboÅ¡ LuÅák l.lu...@collabora.com Date: Thu Feb 19 16:39:06 2015 +0100 mailmerge doesn't need to use the singlefile technique for printing Change-Id: Ib1a7ae3033c03d13ba930cb6b94d85bd8041334c diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx index e6d3b28..7fe9e79 100644 --- a/include/vcl/print.hxx +++ b/include/vcl/print.hxx @@ -408,7 +408,7 @@ public: // These 3 together are more modular PrintJob(), allowing printing more documents as one print job // by repeated calls to ExecutePrintJob(). Used by mailmerge. -static void PreparePrintJob( std::shared_ptrvcl::PrinterController i_pController, +static bool PreparePrintJob( std::shared_ptrvcl::PrinterController i_pController, const JobSetup i_rInitSetup ); static bool ExecutePrintJob( std::shared_ptrvcl::PrinterController i_pController ); static void FinishPrintJob( std::shared_ptrvcl::PrinterController i_pController ); diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx index 6b181b6..e553293 100644 --- a/vcl/source/gdi/print3.cxx +++ b/vcl/source/gdi/print3.cxx @@ -297,7 +297,7 @@ void Printer::PrintJob(const std::shared_ptrPrinterController i_xController, } } -void Printer::PreparePrintJob(std::shared_ptrPrinterController xController, +bool Printer::PreparePrintJob(std::shared_ptrPrinterController xController, const JobSetup i_rInitSetup) { // check if there is a default printer; if not, show an error box (if appropriate) @@ -459,7 +459,7 @@ void Printer::PreparePrintJob(std::shared_ptrPrinterController xController, nullptr, ErrorNoContentDialog, vcl/ui/errornocontentdialog.ui); aBox-Execute(); -return; +return false; } } @@ -476,7 +476,7 @@ void Printer::PreparePrintJob(std::shared_ptrPrinterController xController, if( ! aDlg-Execute() ) { xController-abortJob(); -return; +return false; } if( aDlg-isPrintToFile() ) { @@ -484,7 +484,7 @@ void Printer::PreparePrintJob(std::shared_ptrPrinterController xController, if( aFile.isEmpty() ) { xController-abortJob(); -return; +return false; } xController-setValue( OUString( LocalFileName ), makeAny( aFile ) ); @@ -501,6 +501,7 @@ void Printer::PreparePrintJob(std::shared_ptrPrinterController xController, } xController-pushPropertiesToPrinter(); +return true; } bool Printer::ExecutePrintJob(std::shared_ptrPrinterController xController) @@ -522,9 +523,11 @@ void Printer::FinishPrintJob(std::shared_ptrPrinterController xController) void Printer::ImplPrintJob(std::shared_ptrPrinterController xController, const JobSetup i_rInitSetup) { -PreparePrintJob( xController, i_rInitSetup ); -ExecutePrintJob( xController ); -FinishPrintJob( xController ); +if (PreparePrintJob(xController, i_rInitSetup)) +{ +ExecutePrintJob( xController ); +FinishPrintJob( xController ); +} } bool Printer::StartJob( const OUString i_rJobName, std::shared_ptrvcl::PrinterController i_xController) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/print3.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e5ce36800b1669da08ab6440bc2f8bc2bd305ded Author: Caolán McNamara caol...@redhat.com Date: Wed May 6 13:12:35 2015 +0100 assert on attempt to print after cancel Change-Id: I46dadf9be542990ef18d78a54d7ebce3c3df80f9 diff --git a/vcl/source/gdi/print3.cxx b/vcl/source/gdi/print3.cxx index e553293..b8ed8d5 100644 --- a/vcl/source/gdi/print3.cxx +++ b/vcl/source/gdi/print3.cxx @@ -525,9 +525,9 @@ void Printer::ImplPrintJob(std::shared_ptrPrinterController xController, { if (PreparePrintJob(xController, i_rInitSetup)) { -ExecutePrintJob( xController ); -FinishPrintJob( xController ); +ExecutePrintJob(xController); } +FinishPrintJob(xController); } bool Printer::StartJob( const OUString i_rJobName, std::shared_ptrvcl::PrinterController i_xController) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91073] Crash on insert table split button
https://bugs.documentfoundation.org/show_bug.cgi?id=91073 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Status|RESOLVED|NEW Resolution|DUPLICATE |--- --- Comment #7 from Matthew Francis fdb...@neosheffield.co.uk --- @mmeeks: I can still reproduce this one on a master (dbgutil) build as of 0a6012912f76a6fca7c6aac081b4b2940b8d055c -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/doc/DocumentStylePoolManager.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2c9b7e3304db9d571d15a4ba3732acf8cf40cffe Author: Stephan Bergmann sberg...@redhat.com Date: Wed May 6 15:16:37 2015 +0200 SvxOpaqueItem takes a sal_uInt16 nId as first argument This code was like that ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 initial import. From other uses of SvxOpaqueItem, the best bet appears to be RES_OPAQUE. Change-Id: I19de8fac4f41716d9c2a73bda4a8cea200ae99f8 diff --git a/sw/source/core/doc/DocumentStylePoolManager.cxx b/sw/source/core/doc/DocumentStylePoolManager.cxx index 3276b9f4..8d4fe0e 100644 --- a/sw/source/core/doc/DocumentStylePoolManager.cxx +++ b/sw/source/core/doc/DocumentStylePoolManager.cxx @@ -1318,7 +1318,7 @@ SwFmt* DocumentStylePoolManager::GetFmtFromPool( sal_uInt16 nId ) aSet.Put( SwFmtAnchor( FLY_AT_PAGE )); aSet.Put( SwFmtHoriOrient( 0, text::HoriOrientation::CENTER, text::RelOrientation::FRAME )); aSet.Put( SwFmtVertOrient( 0, text::VertOrientation::CENTER, text::RelOrientation::FRAME )); -aSet.Put( SvxOpaqueItem( sal_False )); +aSet.Put( SvxOpaqueItem( RES_OPAQUE, false )); aSet.Put( SwFmtSurround( SURROUND_THROUGHT )); } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91074] FILEOPEN:RTF FILE OPEN ERROR
https://bugs.documentfoundation.org/show_bug.cgi?id=91074 --- Comment #19 from Joel Madero jmadero@gmail.com --- Please do not report multiple problems in one bug report - the turkish letter issue is a separate problem and should be reported separately. For paid services - it depends on the setup you have with the company/individual. All patches made are upstreamed so the entire community benefits but you get to dictate what is fixed and when as you are paying for the services. For more information please check out: https://www.documentfoundation.org/certification/developers/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89100] FILEOPEN: DOCX - File no longer opens
https://bugs.documentfoundation.org/show_bug.cgi?id=89100 Matthew Francis fdb...@neosheffield.co.uk changed: What|Removed |Added Keywords||bisected CC||mst...@redhat.com --- Comment #4 from Matthew Francis fdb...@neosheffield.co.uk --- Confirmed that it was ebf767eeb2a169ba533e1b2ffccf16f41d95df35 where the visible error started, though as mentioned the commit probably only uncovered another pre-existing issue Adding Cc: to mst...@redhat.com; Any thoughts on this one? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs