[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||sleeping.pil...@gmail.com --- Comment #16 from Julien Nabet serval2...@yahoo.fr --- I must recognize I'm stuck :-( Niklas: since it seems to concern only Swedish language for the user, any thought? Perhaps first, do you reproduce this too? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Writer problem with a dangling SwModify pointer
On 06/01/2015 07:26 PM, Németh László wrote: _ImplAdjustVertRelPos( ) function was for only limiting a numerical value (vertical position of text frames) without any modification of its arguments, but I extended it with a direct modification of a frame attribute using this SetFlyFrmAttr call. I am afraid, this was a bad idea, when _ImplAdjustVertRelPos() is called during a similar modification of an attribute set. Perhaps moving the SetFlyFrmAttr/modification to the calling code part will solve this problem, I will check it. Thanks for your mail! I have now come up with a solution for this that at least makes ASan+UBSan make check happy, http://cgit.freedesktop.org/libreoffice/core/commit/?id=0eb52534de536fbe33585c91f4f173653b184e24 Unlock SwCacheObj before potentially deleting it from SwCache. László, Tamás, please verify that this does not negatively impact your changes http://cgit.freedesktop.org/libreoffice/core/commit/?id=a4dee94afed9ade6ac50237c8d99a6e49d3bebc1 tdf#91260: allow textboxes extending beyond the page bottom etc. and http://cgit.freedesktop.org/libreoffice/core/commit/?id=cb19042f4395c97d123a27c6960d5e30d666c010 New feature: vertical alignment for text frames: Layout part. And I would not mind any Writer expert looking at that The hope is... part, either. 2015-06-01 17:39 GMT+02:00 Stephan Bergmann sberg...@redhat.com: I'm chasing a problem that my UBSan build originally pointed me at, but where I fail to make good progress. Maybe some Writer expert has a clue. I have broken it down to two pieces of information: For one, valgrind reports a dangling SwModify pointer toward the end of CppunitTest_sw_ooxmlexport, Invalid read of size 1 at 0x20FD6659: SwModify::SetInCache(bool) (in /home/sbergman/lo/core/instdir/program/libswlo.so) by 0x215FECD7: SwBorderAttrs::~SwBorderAttrs() (/sw/source/core/layout/frmtool.cxx:1872) by 0x215FED48: SwBorderAttrs::~SwBorderAttrs() (/sw/source/core/layout/frmtool.cxx:1871) by 0x20FFE78B: SwCache::~SwCache() (/sw/source/core/bastyp/swcache.cxx:123) by 0x21640B21: _FrmFinit() (/sw/source/core/layout/newfrm.cxx:369) by 0x20FF86CF: _FinitCore() (/sw/source/core/bastyp/init.cxx:750) by 0x21EDEBC8: SwDLL::~SwDLL() (/sw/source/uibase/app/swdll.cxx:158) by 0x21EE045A: std::default_deleteSwDLL::operator()(SwDLL*) const (/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:76) by 0x21EE0598: std::unique_ptrSwDLL, std::default_deleteSwDLL ::reset(SwDLL*) (/usr/lib/gcc/x86_64-redhat-linux/4.9.2/../../../../include/c++/4.9.2/bits/unique_ptr.h:344) by 0x21EDF5EB: comphelper::unique_disposing_ptrSwDLL::reset(SwDLL*) (/include/comphelper/unique_disposing_ptr.hxx:41) by 0x21EDF02D: comphelper::unique_disposing_solar_mutex_reset_ptrSwDLL::reset(SwDLL*) (/include/comphelper/unique_disposing_ptr.hxx:152) by 0x21EDFFA1: comphelper::unique_disposing_ptrSwDLL::TerminateListener::disposing(com::sun::star::lang::EventObject const) (/include/comphelper/unique_disposing_ptr.hxx:118) by 0x21EE01BB: non-virtual thunk to comphelper::unique_disposing_ptrSwDLL::TerminateListener::disposing(com::sun::star::lang::EventObject const) (/include/comphelper/unique_disposing_ptr.hxx:102) by 0xD4A4561: cppu::OInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const) (/cppuhelper/source/interfacecontainer.cxx:312) by 0xD4A54C3: cppu::OMultiTypeInterfaceContainerHelper::disposeAndClear(com::sun::star::lang::EventObject const) (/cppuhelper/source/interfacecontainer.cxx:485) by 0x2BB8A540: framework::Desktop::disposing() (/framework/source/services/desktop.cxx:1051) by 0xD49EB2E: cppu::WeakComponentImplHelperBase::dispose() (/cppuhelper/source/implbase.cxx:109) by 0x2BB8E710: cppu::WeakComponentImplHelper6com::sun::star::lang::XServiceInfo, com::sun::star::frame::XDesktop2, com::sun::star::frame::XTasksSupplier, com::sun::star::frame::XDispatchResultListener, com::sun::star::task::XInteractionHandler, com::sun::star::frame::XUntitledNumbers::dispose() (in /home/sbergman/lo/core/instdir/program/libfwklo.so) by 0x2BB8E988: non-virtual thunk to cppu::WeakComponentImplHelper6com::sun::star::lang::XServiceInfo, com::sun::star::frame::XDesktop2, com::sun::star::frame::XTasksSupplier, com::sun::star::frame::XDispatchResultListener, com::sun::star::task::XInteractionHandler, com::sun::star::frame::XUntitledNumbers::dispose() (/include/cppuhelper/compbase6.hxx:59) by 0xD4F3BAD: cppuhelper::ServiceManager::disposing() (/cppuhelper/source/servicemanager.cxx:925) by 0xD49EB2E: cppu::WeakComponentImplHelperBase::dispose() (/cppuhelper/source/implbase.cxx:109) by 0xD484A70: cppu::WeakComponentImplHelper8com::sun::star::lang::XServiceInfo, com::sun::star::lang::XMultiServiceFactory, com::sun::star::lang::XMultiComponentFactory, com::sun::star::container::XSet, com::sun::star::container::XContentEnumerationAccess,
Re: LibreOffice Help broken redirects
Hi Adolfo, Am 01.06.2015 um 07:37 schrieb Adolfo Jayme Barrientos: 2015-05-31 20:03 GMT-05:00 Dennis Roczek dennisroc...@gmail.com: -- mainly to 3.6 (so no urgent I guess). … which leads me to a question: why do we keep help content for unsupported releases in the wiki? Why not? Some users have to use (parallel) LibO 3.6 because the StarOffice file format was dropped in LO4. Just for an example. I suggest that we drop any content corresponding to any release older that 4.4, and maintain only those pages corresponding to the Fresh and Still branches at a time. At the moment we do have ~900k Pages - including redirects for all versions (3.3, 3.4, 3.5, 3.6, 4.0, 4.1, 4.2, 4.3, 4.4 - so for 9 versions). Redirects are very cheap. (don't cost server resources) Images are defacto not existent (not many, all small). And 900k pages are not very much for Mediawiki. Moreover as Robinson already said that there are some companies providing long term support for old versions. Adolfo Regards, Dennis Roczek ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #17 from Henrik Jansson henrik_jans...@hotmail.com --- Someone on a Swedish Linux forum tested this on his 64 bit system, and then it worked, so maybe it has to be a 32 bit system to not work. I think it must be something wrong in Linux since I have the same problem on both my 32 bit Linux. One more thing I could try is to reinstall the whole system once again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91462] Menu items hidden when scrolled down
https://bugs.documentfoundation.org/show_bug.cgi?id=91462 László Németh nem...@numbertext.org changed: What|Removed |Added CC||nem...@numbertext.org --- Comment #3 from László Németh nem...@numbertext.org --- Confirmed with Version: 5.1.0.0.alpha1+ Build ID: 9535d5d1fdbd1a529e4d7a6b5e3df6c551465364 Locale: en-US (en_US.UTF-8), too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Mac OS X and pkg-config
On 2015-06-09 11:36 AM, Tor Lillqvist wrote: How hard can it be to make sure to drop some entries from PATH in the shells where one works on LibreOffice? Oh really? I was not aware of that. Perhaps if the error message said something along the lines of we detected pkgconfig in your PATH $HERE$, please remove it and try again it would be vastly more pleasant. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91957] Vertically oriented text should set the same way in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91957 --- Comment #1 from ⚡ Thunde® ⚡ minnigalie...@yandex.ru --- Created attachment 116406 -- https://bugs.documentfoundation.org/attachment.cgi?id=116406action=edit alignment -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91961] New: Should do understandable navigation cursors in vertical text in the table cell in Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91961 Bug ID: 91961 Summary: Should do understandable navigation cursors in vertical text in the table cell in Writer Product: LibreOffice Version: 4.4.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minnigalie...@yandex.ru Created attachment 116409 -- https://bugs.documentfoundation.org/attachment.cgi?id=116409action=edit huge cursor Operate the button just to the left and right. In addition there is a huge cursor over the entire length of the vertical text. Let's see how you can navigate in the vertical text in a table in Microsoft Office 2003. Also see the screenshots. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91960] New: Attached presentation causes impress to crash
https://bugs.documentfoundation.org/show_bug.cgi?id=91960 Bug ID: 91960 Summary: Attached presentation causes impress to crash Product: LibreOffice Version: 4.4.3.2 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marco.crave...@gmail.com Created attachment 116408 -- https://bugs.documentfoundation.org/attachment.cgi?id=116408action=edit Presentation about the interior of Angola When I try to open the attached presentation, Impress first works very slowly; then eventually I get sound, but after a few seconds it crashes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91962] Vertically oriented text in Calc should remain vertical when editing
https://bugs.documentfoundation.org/show_bug.cgi?id=91962 ⚡ Thunde® ⚡ minnigalie...@yandex.ru changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #19 from Björn Michaelsen bjoern.michael...@canonical.com --- If this is using a debian package and not an TDF build we need the full Debian package version and source repository. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89226] The operation Undo after Chinese convertion crashes the Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=89226 Mike Kaganski mikekagan...@hotmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com |desktop.org | --- Comment #7 from Mike Kaganski mikekagan...@hotmail.com --- Posted patch to gerrit: https://gerrit.libreoffice.org/16181 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: vcl::Window::dispose deadlock
On 09.06.2015 10:02, Noel Grandin wrote: On 2015-06-09 09:58 AM, Stephan Bergmann wrote: On Windows, with master as of last night, make check happened to run into a deadlock in soffice.bin as below. The main thread is trying to re-acquire the SolarMutex (after a SolarMutexReleaser) from within the event loop, while an incoming URP thread (apparently holding the SolarMutex) does vcl::Window::dispose which, on Windows, blocks on sending a message into the event loop. this started happening for me in sc_unoapi on a --enable-dbgutil build almost always since half a year or so; before that it was less likely for whatever reason but still did happen. (the deadlock moved from ~Window to Window::dispose due to VclPtr refactoring.) the deadlock does not appear easily fixable; the last slide of my threading talk last year was about it actually. this requires a larger re-design; either handling all VCL stuff only on the main thread so that other threads never call Window methods, or perhaps it would also work to have a dedicated thread that does nothing other than handle the special thread affine Win32 create/destroy-window messages and never takes a lock. Shouldn't something that blocks on sending a message into the event loop drop the SolarMutex while it waits for the reply, and then reacquire it afterwards? no. this is deep inside VCL internals which are very likely not in a consistent state at this point, so other threads must be prevented from calling into VCL. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Mac OS X and pkg-config
Some of us work on other opensource projects on our Mac machines which happen to need MacPorts or HomeBrew. Having LibreOffice simply say I refuse to build on this machine because you've already installed some other stuff is not very friendly. But neither is it very useful to have the already small set of OS X -based developers split into those who use a pure upstream way to build, those who use HomeBrew libjpeg but bundled Python, those who use MacPorts Python and libjpeg, etc. For each, normally bundled, external software package, that could optionally be used from either MacPorts or HomeBrew, the configuration space grows threefold in size. How hard can it be to make sure to drop some entries from PATH in the shells where one works on LibreOffice? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91958] New: zero characters are missing when open a CSV file
https://bugs.documentfoundation.org/show_bug.cgi?id=91958
Bug ID: 91958
Summary: zero characters are missing when open a CSV file
Product: LibreOffice
Version: 4.3.7.2 release
Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Calc
Assignee: libreoffice-bugs@lists.freedesktop.org
Reporter: i+libreoff...@cxbig.info
Our CSV file has a column with numbers are matched the pattern: /^00\d{6}$/
After open this file, Calc treat this column as a number.
All zero in the front are removed.
Even I change the column data type to 'text'. They are not come back.
--
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91959] New: The transition to a new line in the table cell must be the same in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91959 Bug ID: 91959 Summary: The transition to a new line in the table cell must be the same in Calc and Writer Product: LibreOffice Version: 4.4.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minnigalie...@yandex.ru In Calc to go to a new line when filling the cells need to use Ctrl+Enter in Writer when horizontally oriented text is used just Enter, and if vertical need to use Shift+Enter. It's confusing, most people cannot understand this intuitively, and they have to search the Internet how to go onto a new line in the vertically oriented text in a table in Writer. I think it would be appropriate everywhere to make the transition to a new line in a table cell in Writer and in Сalc using Ctrl+Enter and Enter the transition in the cell below, as in Calc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91695] VIEWING: text added above should move textsection down / sometimes overlap between section and text above it..
https://bugs.documentfoundation.org/show_bug.cgi?id=91695 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added Blocks|91488 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - sfx2/source sw/inc sw/qa sw/source
sfx2/source/doc/objstor.cxx|1
sw/inc/dbmgr.hxx |7 ++
sw/qa/extras/uiwriter/uiwriter.cxx |8 ++
sw/source/uibase/app/docsh.cxx | 21 ++
sw/source/uibase/dbui/dbmgr.cxx| 43 +++--
5 files changed, 60 insertions(+), 20 deletions(-)
New commits:
commit 9805ae85eb776fa8f718c1415942c31f2cfc6d9e
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Tue Jun 9 12:07:37 2015 +0200
sfx2: silence warning in SfxObjectShell::CopyStoragesOfUnknownMediaType()
I guess the intention is to catch all own formats, and Base is just
missing from that list.
Change-Id: I064068c2ab17db9109a9a4681775ba8d18292292
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index d431a1e..826d024 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -3484,6 +3484,7 @@ bool SfxObjectShell::CopyStoragesOfUnknownMediaType(
const uno::Reference embed
case SotClipboardFormatId::STARCALC_8:
case SotClipboardFormatId::STARCHART_8:
case SotClipboardFormatId::STARMATH_8:
+case SotClipboardFormatId::STARBASE_8:
break;
default:
commit 2d7ff7aabc1aa8cf5bb4900ae4b00feb8bc0f7f7
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Tue Jun 9 11:40:02 2015 +0200
SwDocShell: custom copy for embedded data source definition on save-as
If EmbeddedDatabase in test.odt refers test.ods in the same directory,
that will be ../../test.ods. Now if we save test.odt in a different
directory, we need to re-save the embedded data source definition,
otherwise the relative reference will resolve to a non-existing path.
Relative references are normally not supported for embedded objects, so
this is not a problem, but for data sources they are, that's why they
are a special case here.
Change-Id: Id138b9cdc38f2de589d9b80c66f1a61174699770
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 666f0ac..d3f08e4 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -1009,6 +1009,14 @@ void SwUiWriterTest::testEmbeddedDataSource()
CPPUNIT_ASSERT(mxComponent.is());
CPPUNIT_ASSERT(xDatabaseContext-hasByName(calc-data-source));
+// Data source has a table named Sheet1 after saving to a different
directory.
+xDataSource.set(xDatabaseContext-getByName(calc-data-source),
uno::UNO_QUERY);
+CPPUNIT_ASSERT(xDataSource.is());
+xConnection.set(xDataSource-getConnection(, ), uno::UNO_QUERY);
+xTables.set(xConnection-getTables(), uno::UNO_QUERY);
+CPPUNIT_ASSERT(xTables.is());
+CPPUNIT_ASSERT(xTables-hasByName(Sheet1));
+
// Close: should not have a data source anymore.
mxComponent-dispose();
mxComponent.clear();
diff --git a/sw/source/uibase/app/docsh.cxx b/sw/source/uibase/app/docsh.cxx
index b4c22ac..1901355 100644
--- a/sw/source/uibase/app/docsh.cxx
+++ b/sw/source/uibase/app/docsh.cxx
@@ -115,12 +115,15 @@
#include com/sun/star/document/XDocumentProperties.hpp
#include com/sun/star/document/XDocumentPropertiesSupplier.hpp
+#include com/sun/star/sdb/DatabaseContext.hpp
+#include com/sun/star/sdb/XDocumentDataSource.hpp
#include unomid.h
#include unotextrange.hxx
#include sfx2/Metadatable.hxx
#include calbck.hxx
+#include dbmgr.hxx
#include sal/log.hxx
#include LibreOfficeKit/LibreOfficeKitEnums.h
@@ -416,6 +419,24 @@ bool SwDocShell::SaveAs( SfxMedium rMedium )
}
CalcLayoutForOLEObjects(); // format for OLE objets
+
+if (!m_pDoc-GetDBManager()-getEmbeddedName().isEmpty())
+{
+// We have an embedded data source definition, need to re-store it,
+// otherwise relative references will break when the new file is in a
+// different directory.
+uno::Referencesdb::XDatabaseContext xDatabaseContext =
sdb::DatabaseContext::create(comphelper::getProcessComponentContext());
+
+const INetURLObject rOldURLObject = GetMedium()-GetURLObject();
+OUString aURL = vnd.sun.star.pkg://;
+aURL +=
INetURLObject::encode(rOldURLObject.GetMainURL(INetURLObject::DECODE_WITH_CHARSET),
INetURLObject::PART_AUTHORITY, INetURLObject::ENCODE_ALL);
+aURL += / +
INetURLObject::encode(m_pDoc-GetDBManager()-getEmbeddedName(),
INetURLObject::PART_FPATH, INetURLObject::ENCODE_ALL);
+
+uno::Referencesdb::XDocumentDataSource
xDataSource(xDatabaseContext-getByName(aURL), uno::UNO_QUERY);
+uno::Referenceframe::XStorable
xStorable(xDataSource-getDatabaseDocument(), uno::UNO_QUERY);
+SwDBManager::StoreEmbeddedDataSource(xStorable,
rMedium.GetOutputStorage(), m_pDoc-GetDBManager()-getEmbeddedName(),
rMedium.GetName());
+}
+
// #i62875#
// reset compatibility flag
[Libreoffice-commits] core.git: 4 commits - libreofficekit/source
libreofficekit/source/gtk/lokdocview.cxx | 22 +++---
libreofficekit/source/gtk/tilebuffer.cxx |4 ++--
libreofficekit/source/gtk/tilebuffer.hxx |6 +-
3 files changed, 14 insertions(+), 18 deletions(-)
New commits:
commit e52bae937032dd5eac14da1d54b045ad9d787b1f
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Jun 9 11:58:24 2015 +0200
-Werror,-Wignored-attributes (attribute declaration must precede
definition)
Change-Id: Iee0e9ef3a623706c33f84c34c1fbbf5b173f7f5d
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 4fb998e..ed3fc5c 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -208,6 +208,7 @@ enum
static guint doc_view_signals[LAST_SIGNAL] = { 0 };
+SAL_DLLPUBLIC_EXPORT GType lok_doc_view_get_type();
#ifdef __GNUC__
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored -Wunused-function
@@ -1196,8 +1197,6 @@ static void lok_doc_view_init (LOKDocView* pDocView)
g_signal_connect(G_OBJECT(pDocView), destroy,
G_CALLBACK(LOKDocView_Impl::destroy), 0);
}
-SAL_DLLPUBLIC_EXPORT GType lok_doc_view_get_type();
-
SAL_DLLPUBLIC_EXPORT GtkWidget* lok_doc_view_new( LibreOfficeKit* pOffice )
{
LOKDocView* pDocView = LOK_DOC_VIEW(gtk_type_new(lok_doc_view_get_type()));
commit 3f0e8bdabed165e09825bc78c55afb968a6d702a
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Jun 9 11:57:56 2015 +0200
loplugin:unreffun
Change-Id: I2011b491012dfd623ece9fd24a265107ac690cba
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 7e50b96..4fb998e 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -208,9 +208,14 @@ enum
static guint doc_view_signals[LAST_SIGNAL] = { 0 };
-
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored -Wunused-function
+#endif
G_DEFINE_TYPE(LOKDocView, lok_doc_view, GTK_TYPE_SCROLLED_WINDOW)
-
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
namespace {
commit 9aa9baa78852dda5c348eb0abdbef98db3e910ed
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Jun 9 11:48:12 2015 +0200
loplugin:literaltoboolconversion
Change-Id: I85fa46de5b864369158d047fd3f7c683f10c822f
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 1d6a8b6..2c0ee90 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -67,7 +67,7 @@ void TileBuffer::setInvalid(int x, int y)
g_info(Setting tile invalid (%d, %d), x, y);
if (m_mTiles.find(index) != m_mTiles.end())
{
-m_mTiles[index].valid = 0;
+m_mTiles[index].valid = false;
m_mTiles[index].release();
m_mTiles.erase(index);
}
@@ -101,7 +101,7 @@ Tile TileBuffer::getTile(int x, int y, float aZoom)
//create a mapping for it
m_mTiles[index].setPixbuf(pPixBuf);
-m_mTiles[index].valid = 1;
+m_mTiles[index].valid = true;
}
return m_mTiles[index];
diff --git a/libreofficekit/source/gtk/tilebuffer.hxx
b/libreofficekit/source/gtk/tilebuffer.hxx
index b9bf71b..42c6d35 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -51,7 +51,7 @@ float twipToPixel(float fInput, float zoom);
class Tile
{
public:
-Tile() : valid(0) {}
+Tile() : valid(false) {}
~Tile() { }
/**
commit 3a1a5b9744eb73f82c28ecfaa39b54587ef8206b
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Jun 9 11:42:41 2015 +0200
-Werror,-Wunused-private-field
Change-Id: I76cf487c66e048b5e9d0877a1b690cd066b73528
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 5f768e7..7e50b96 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -274,7 +274,7 @@ LOKDocView_Impl::CallbackData::CallbackData(int nType,
const std::string rPaylo
LOKDocView_Impl::LOKDocView_Impl(LOKDocView* pDocView)
: m_pDocView(pDocView),
m_pDrawingArea(gtk_drawing_area_new()),
- m_aTileBuffer(TileBuffer(0,0,0)),
+ m_aTileBuffer(TileBuffer(0,0)),
m_fZoom(1),
m_pOffice(0),
m_pDocument(0),
@@ -1230,13 +1230,11 @@ SAL_DLLPUBLIC_EXPORT gboolean
lok_doc_view_open_document( LOKDocView* pDocView,
long nDocumentHeightTwips = pDocView-m_pImpl-m_nDocumentHeightTwips;
long nDocumentWidthPixels = twipToPixel(nDocumentWidthTwips, zoom);
long nDocumentHeightPixels = twipToPixel(nDocumentHeightTwips, zoom);
-// Total number of rows / columns in this document.
-guint nRows = ceil((double)nDocumentHeightPixels / nTileSizePixels);
+// Total number of columns in this document.
guint nColumns = ceil((double)nDocumentWidthPixels /
[Libreoffice-bugs] [Bug 86395] Bookmarks are displayed in alphabetic order in the Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=86395 --- Comment #8 from sophie gautier.sop...@gmail.com --- Tested it again today with Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: fr_FR Bookmarks are sorted by alphabetic order in the Navigator while listed by order of insertion in the status bar. Sophie -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/layout/flylay.cxx | 40 +--
1 file changed, 22 insertions(+), 18 deletions(-)
New commits:
commit 0eb52534de536fbe33585c91f4f173653b184e24
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Jun 9 11:17:13 2015 +0200
Unlock SwCacheObj before potentially deleting it from SwCache
Running e.g. CppunitTest_sw_ooxmlexport under UBSan revealed problems with
SwBorderAttrs instances with dangling pOwner pointers, which caused bad
memory
access during exit when ~SwCache calling ~SwBorderAttrs tried to use pOwner.
The problem started with a4dee94afed9ade6ac50237c8d99a6e49d3bebc1
tdf#91260:
allow textboxes extending beyond the page bottom (and hadn't changed with
follow-up 2f779fc046c9afec04b4a4500b213e77aee51ae1 tdf#91260: cleanup -
textboxes extending beyond the page): The call to
pFrameFormat-SetFormatAttr(aSize);
in SwAnchoredObjectPosition::_ImplAdjustVertRelPos ultimately calls
SwCache::DeleteObj on the SwBorderAttrs instance that is locked by the
SwBorderAttrAccess aAccess( SwFrm::GetCache(), this );
down the call stack in SwFlyFreeFrm::MakeAll. That means that
SwCache::DeleteObj will return early without doing anything (apart from
triggering the OSL_ENSURE SwCache::Delete: object is locked.), leading to
this
leftover SwBorderAttrs instance causing trouble during ~SwCache.
The scope of aAccess in SwFlyFreeFrm::MakeAll had always extended well past
the
uses of rAttrs (= *aAccess.Get()), covering also the
if ( !mbValidPos )
block (that contains the call to MakeObjPos leading to the call of
SwAnchoredObjectPosition::_ImplAdjustVertRelPos), ever since
84a3db80b4fd66c6854b3135b5f69b61fd828e62 initial import.
With cb19042f4395c97d123a27c6960d5e30d666c010 New feature: vertical
alignment
for text frames: Layout part, an additional use of rAttrs (in
MakeContentPos( rAttrs )) had been added after the block calling MakeObjPos.
The hope is that (1) it is OK to release aAccess earlier, after any
(original)
uses of rAttrs, but before the call to MakeObjPos; and (2) it is OK to just
set
up a second aAccess/rAttrs for the later added use of rAttrs in the call to
MakeContentPos. (That is, to punch a hole into the aAccess scope, so that
ultimately SwCache::DeleteObj succeeds on a now-unlocked SwBorderAttrs.)
Change-Id: I7cb9919b1c9d7c87464ac3a0fe1edfed5b46e122
diff --git a/sw/source/core/layout/flylay.cxx b/sw/source/core/layout/flylay.cxx
index a5b27b6..9b351c0 100644
--- a/sw/source/core/layout/flylay.cxx
+++ b/sw/source/core/layout/flylay.cxx
@@ -174,29 +174,33 @@ void SwFlyFreeFrm::MakeAll()
Format( rAttrs );
bFormatHeightOnly = false;
}
+}
-if ( !mbValidPos )
-{
-const Point aOldPos( (Frm().*fnRect-fnGetPos)() );
+if ( !mbValidPos )
+{
+const Point aOldPos( (Frm().*fnRect-fnGetPos)() );
+// #i26791# - use new method MakeObjPos()
+// #i34753# - no positioning, if requested.
+if ( IsNoMakePos() )
+mbValidPos = true;
+else
// #i26791# - use new method MakeObjPos()
-// #i34753# - no positioning, if requested.
-if ( IsNoMakePos() )
+MakeObjPos();
+if( aOldPos == (Frm().*fnRect-fnGetPos)() )
+{
+if( !mbValidPos GetAnchorFrm()-IsInSct()
+!GetAnchorFrm()-FindSctFrm()-IsValid() )
mbValidPos = true;
-else
-// #i26791# - use new method MakeObjPos()
-MakeObjPos();
-if( aOldPos == (Frm().*fnRect-fnGetPos)() )
-{
-if( !mbValidPos GetAnchorFrm()-IsInSct()
-!GetAnchorFrm()-FindSctFrm()-IsValid() )
-mbValidPos = true;
-}
-else
-mbValidSize = false;
}
+else
+mbValidSize = false;
+}
-if ( !m_bValidContentPos )
-MakeContentPos( rAttrs );
+if ( !m_bValidContentPos )
+{
+SwBorderAttrAccess aAccess( SwFrm::GetCache(), this );
+const SwBorderAttrs rAttrs = *aAccess.Get();
+MakeContentPos( rAttrs );
}
if ( mbValidPos mbValidSize )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91535] Version in about dialog blink
https://bugs.documentfoundation.org/show_bug.cgi?id=91535 László Németh nem...@numbertext.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #10 from László Németh nem...@numbertext.org --- No problem under Linux with Version: 5.1.0.0.alpha1+ Build ID: 9535d5d1fdbd1a529e4d7a6b5e3df6c551465364 Locale: en-US (en_US.UTF-8) Blinking during selection is not a regression (checked in 4.2). According to the several feedbacks, the problem has been resolved in the newer master, so I fixed this issue. Thanks for your help! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 Bug 91488 depends on bug 91535, which changed state. Bug 91535 Summary: Version in about dialog blink https://bugs.documentfoundation.org/show_bug.cgi?id=91535 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 5 commits - basic/source chart2/source cppcanvas/source cppuhelper/qa cppuhelper/source cppuhelper/test cppu/source editeng/source rsc/source sw/qa sw/source xmlhelp/so
basic/source/runtime/methods.cxx |3 -
chart2/source/view/axes/VCartesianAxis.cxx |6 --
cppcanvas/source/mtfrenderer/implrenderer.cxx |4 -
cppcanvas/source/wrapper/implbitmapcanvas.hxx |2
cppcanvas/source/wrapper/implcanvas.hxx|2
cppcanvas/source/wrapper/implcolor.hxx |2
cppu/source/AffineBridge/AffineBridge.cxx |4 -
cppu/source/threadpool/current.cxx | 48 ---
cppu/source/typelib/typelib.cxx|2
cppu/source/uno/IdentityMapping.cxx|2
cppu/source/uno/lbenv.cxx |2
cppuhelper/qa/ifcontainer/cppu_ifcontainer.cxx |2
cppuhelper/source/compat.cxx |2
cppuhelper/source/component_context.cxx|8 +--
cppuhelper/source/factory.cxx |2
cppuhelper/source/propshlp.cxx |2
cppuhelper/source/tdmgr.cxx|2
cppuhelper/source/typemanager.cxx |4 -
cppuhelper/source/weak.cxx |4 -
cppuhelper/test/cfg_test.cxx |7 +-
cppuhelper/test/testimplhelper.cxx |2
editeng/source/misc/txtrange.cxx |6 +-
rsc/source/parser/rscibas.cxx |6 --
sw/qa/extras/ooxmlexport/data/ooo47778-4.odt |binary
sw/qa/extras/ooxmlexport/ooxmlexport5.cxx |8 ++-
sw/source/filter/ww8/wrtww8.cxx| 62 +
sw/source/filter/ww8/wrtww8.hxx|4 +
xmlhelp/source/treeview/tvread.cxx |3 -
28 files changed, 102 insertions(+), 99 deletions(-)
New commits:
commit 60f8dd78fa3f19e8bed867f7f5926fcf9a8d8e67
Author: Caolán McNamara caol...@redhat.com
Date: Tue Jun 9 10:11:28 2015 +0100
Resolves: more crash on export of ooo47778-3.sxw to docx
This is more of the horror where the table in the frame has its cells out of
visual sequence, extend the previous fix of this kind to accept cells within
the original unmodified selected range
Change-Id: I6e8220f712fe9de5d4b98fb3cb5ed67e3762e929
diff --git a/sw/qa/extras/ooxmlexport/data/ooo47778-4.odt
b/sw/qa/extras/ooxmlexport/data/ooo47778-4.odt
new file mode 100644
index 000..ae6b56b
Binary files /dev/null and b/sw/qa/extras/ooxmlexport/data/ooo47778-4.odt differ
diff --git a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
index 6b2fb6e..5fe36fd 100644
--- a/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
+++ b/sw/qa/extras/ooxmlexport/ooxmlexport5.cxx
@@ -813,12 +813,18 @@ DECLARE_OOXMLEXPORT_TEST(testSectionHeader,
sectionprot.odt)
}
}
-DECLARE_OOXMLEXPORT_TEST(testOO47778, ooo47778-3.odt)
+DECLARE_OOXMLEXPORT_TEST(testOO47778_1, ooo47778-3.odt)
{
if (xmlDocPtr pXmlDoc = parseExport(word/document.xml))
assertXPathContent(pXmlDoc, (//w:t)[3], c);
}
+DECLARE_OOXMLEXPORT_TEST(testOO47778_2, ooo47778-4.odt)
+{
+if (xmlDocPtr pXmlDoc = parseExport(word/document.xml))
+assertXPathContent(pXmlDoc, (//w:t)[4], c);
+}
+
CPPUNIT_PLUGIN_IMPLEMENT();
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sw/source/filter/ww8/wrtww8.cxx b/sw/source/filter/ww8/wrtww8.cxx
index ba7e714..34af92f 100644
--- a/sw/source/filter/ww8/wrtww8.cxx
+++ b/sw/source/filter/ww8/wrtww8.cxx
@@ -1720,6 +1720,8 @@ void MSWordExportBase::WriteSpecialText( sal_uLong
nStart, sal_uLong nEnd, sal_u
sal_uInt8 nOldTyp = m_nTextTyp;
m_nTextTyp = nTTyp;
SwPaM* pOldPam = m_pCurPam; //!! Simply shifting the PaM without
restoring should do the job too
+sal_uLong nOldStart = m_nCurStart;
+sal_uLong nOldEnd = m_nCurEnd;
SwPaM* pOldEnd = m_pOrigPam;
bool bOldPageDescs = m_bOutPageDescs;
m_bOutPageDescs = false;
@@ -1731,6 +1733,8 @@ void MSWordExportBase::WriteSpecialText( sal_uLong
nStart, sal_uLong nEnd, sal_u
m_bOutPageDescs = bOldPageDescs;
delete m_pCurPam;// delete Pam
m_pCurPam = pOldPam;
+m_nCurStart = nOldStart;
+m_nCurEnd = nOldEnd;
m_pOrigPam = pOldEnd;
m_nTextTyp = nOldTyp;
}
@@ -1791,6 +1795,8 @@ void WW8Export::WriteChar( sal_Unicode c )
void MSWordExportBase::SetCurPam(sal_uLong nStt, sal_uLong nEnd)
{
+m_nCurStart = nStt;
+m_nCurEnd = nEnd;
m_pCurPam = Writer::NewSwPaM( *m_pDoc, nStt, nEnd );
// Recognize tables in special cases
@@ -1842,6 +1848,8 @@ void MSWordExportBase::RestoreData()
delete m_pCurPam;
m_pCurPam = rData.pOldPam;
+m_nCurStart = rData.nOldStart;
+m_nCurEnd = rData.nOldEnd;
m_pOrigPam = rData.pOldEnd;
m_bOutTable = rData.bOldOutTable;
@@ -2530,11 +2538,12 @@ class TrackContentToExport
{
private:
SwPaM *m_pCurPam;
-SwPaM m_aOrigPam;
+sal_uLong m_nStart, m_nEnd;
public:
-TrackContentToExport(SwPaM *pCurPam)
+TrackContentToExport(SwPaM *pCurPam, sal_uLong nCurStart,
[Libreoffice-bugs] [Bug 91955] Interruzione inaspettata programma
https://bugs.documentfoundation.org/show_bug.cgi?id=91955 --- Comment #2 from rosarioferr...@libero.it --- Non credo sia lo stesso problema. Spiego in dettaglio cosa succede. Voglio vedere l'anteprima di stampa. E quindi clicco sull'icona lente ingrandimento sopra la stampante (comando CTRL+Maiusc+O), oppure vado in File -- Anteprima di stampa. A tal punto si apre regolarmente l'anteprima. Chiudo l'anteprima, e ritorno al programma. A tal punto ho bisogno di modificare le impostazioni della pagina. E quindi procedo con: o clicco su Formatta pagina (sulla barra degli strumenti), oppure vado in Formato -- Pagina . Ma anziche aprire la relativa finestra d'impostazioni, il PROGRAMMA SI CHIUDE AUTOMATICAMENTE senza effettuare nessuna operazione. AL RIAVVIO del file interessato, si apre la Finestra di ripristino file, chiedendomi se voglio ripristinare il file. Se accetto il ripristino il file viene ripristinato e si apre regolarmente, ma se ripeto la stessa operazione (mofifica al formato pagina dopo la chiusura della finestra anteprima si ripete lo stesso inconveniente. Questo avviene sempre e con tutti i file di CALC. SPero di ìaver bene descritto l'inconveniente che è molto grave, perchè si deve ripristinare il file, e modificare le impostazioni pagina, ma senza aprire l'anteprima. Grazie per l'attenzione. R.Ferrari -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91957] New: Vertically oriented text should set the same way in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91957 Bug ID: 91957 Summary: Vertically oriented text should set the same way in Calc and Writer Product: LibreOffice Version: 4.4.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minnigalie...@yandex.ru Setting vertical alignment for the text occurs differently in Calc and Writer. And in Calc to make it simpler, clearer, easier. In addition to Calc the alignment of text along the bottom edge occurs correctly - the text is aligned on the bottom edge, and not just descends while remaining aligned in the center relative to the longest line. Yes, I know the way to align the text in the cell through the Paragraph, but it's an extra step that anyone of the users do not need. See attachments. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 Jan Holesovsky ke...@collabora.com changed: What|Removed |Added Depends on|91695 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||bjoern.michaelsen@canonical ||.com --- Comment #18 from Julien Nabet serval2...@yahoo.fr --- It could be a packaging pb of the distrib. I mean, LO is contained in several packages. Perhaps a dependency is lacking and not all the required packages are installed when you install Swedish LO. In this case, it could be a bug from Linux Mint but I'm not sure. Bjoern: since Linux Mint is based on Ubuntu (unless Henrik used the new one based on Debian), I thought you might have some opinion. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91957] Vertically oriented text should set the same way in Calc and Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=91957 --- Comment #2 from ⚡ Thunde® ⚡ minnigalie...@yandex.ru --- Created attachment 116407 -- https://bugs.documentfoundation.org/attachment.cgi?id=116407action=edit examples ods, odt -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91962] New: Vertically oriented text in Calc should remain vertical when editing
https://bugs.documentfoundation.org/show_bug.cgi?id=91962 Bug ID: 91962 Summary: Vertically oriented text in Calc should remain vertical when editing Product: LibreOffice Version: 4.4.2.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minnigalie...@yandex.ru It is convenient to see how they change the appearance when editing, so a vertically oriented text should remain vertical when editing, as implemented, for example, in Microsoft Office 2003. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76526] [writer] loading styles from file corrupts existing styles
https://bugs.documentfoundation.org/show_bug.cgi?id=76526 Milos Sramek msrame...@gmail.com changed: What|Removed |Added Version|4.1.5.3 release |Inherited From OOo --- Comment #3 from Milos Sramek msrame...@gmail.com --- Hi, the bug according to Case 1 is still present in 4.4.3.2 and 5.0.0.0 I cannot however confirm Case 2 - Level 2 remains there even for older versions LO 4.0 4.2 and 4.4. So, this information was probably not correct when reporting the bug) The bug is present in OOo33 -- milos -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp
loolwsd/LOOLSession.cpp |4 ++--
loolwsd/LOOLSession.hpp |6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit a7f2e5aa290c4fcbdba04f8aa7b2902480b35eb9
Author: Tor Lillqvist t...@collabora.com
Date: Mon Jun 8 16:35:52 2015 +0300
The buffer parameter to handleInput() can be const
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 9843832..5b30949 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -123,7 +123,7 @@ MasterProcessSession::~MasterProcessSession()
}
}
-bool MasterProcessSession::handleInput(char *buffer, int length)
+bool MasterProcessSession::handleInput(const char *buffer, int length)
{
Application::instance().logger().information(Util::logPrefix() + Input:
+ getAbbreviatedMessage(buffer, length));
@@ -647,7 +647,7 @@ ChildProcessSession::~ChildProcessSession()
Util::shutdownWebSocket(*_ws);
}
-bool ChildProcessSession::handleInput(char *buffer, int length)
+bool ChildProcessSession::handleInput(const char *buffer, int length)
{
Application app = Application::instance();
diff --git a/loolwsd/LOOLSession.hpp b/loolwsd/LOOLSession.hpp
index 7cac320..8eef54e 100644
--- a/loolwsd/LOOLSession.hpp
+++ b/loolwsd/LOOLSession.hpp
@@ -53,7 +53,7 @@ protected:
const Kind _kind;
-virtual bool handleInput(char *buffer, int length) = 0;
+virtual bool handleInput(const char *buffer, int length) = 0;
void sendBinaryFrame(const char *buffer, int length);
@@ -94,7 +94,7 @@ public:
MasterProcessSession(std::shared_ptrPoco::Net::WebSocket ws, Kind kind);
virtual ~MasterProcessSession();
-virtual bool handleInput(char *buffer, int length) override;
+virtual bool handleInput(const char *buffer, int length) override;
bool haveSeparateProcess();
@@ -152,7 +152,7 @@ public:
ChildProcessSession(std::shared_ptrPoco::Net::WebSocket ws,
LibreOfficeKit *loKit);
virtual ~ChildProcessSession();
-virtual bool handleInput(char *buffer, int length) override;
+virtual bool handleInput(const char *buffer, int length) override;
virtual bool getStatus(const char *buffer, int length);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91947] Calc does not compute a formula (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=91947 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- If I force the recalculation of the cell contents, the correct value is displayed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91947] Calc does not compute a formula (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=91947 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- I notice that change tracking is on for this file. Does it make a difference if you turn that function off ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91719] Line Numbering Selected Paragraphs Clunky and Inefficient
https://bugs.documentfoundation.org/show_bug.cgi?id=91719 Stephen stephenaustinm...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91719] Line Numbering Selected Paragraphs Clunky and Inefficient
https://bugs.documentfoundation.org/show_bug.cgi?id=91719 Stephen stephenaustinm...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91719] Line Numbering Selected Paragraphs Clunky and Inefficient
https://bugs.documentfoundation.org/show_bug.cgi?id=91719 Stephen stephenaustinm...@gmail.com changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91949] StarCenter Recent Files icon's design pattern doesn't follow the rest
https://bugs.documentfoundation.org/show_bug.cgi?id=91949 steve -_- st...@openmailbox.org changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91947] Calc does not compute a formula (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=91947 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=39 ||828 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39828] writer table with acitvated change tracking is not calculating correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=39828 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||947 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91949] StarCenter Recent Files icon's design pattern doesn't follow the rest
https://bugs.documentfoundation.org/show_bug.cgi?id=91949 --- Comment #2 from steve -_- st...@openmailbox.org --- This is currently being worked on and might change a lot due to that. I think I can recall a nightly build where indeed if you had sifr / breeze, you were suddenly seeing an ugly icon (tango?) for recent files which did not fit. But the nightly from today has nice icons for all items when using breeze. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91947] Calc does not compute a formula (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=91947 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- In bug 39828, something similar appears to happen with calculations in Writer when change tracking is activated. Could be that the same root cause is the problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #6 from Rudolf Kollien rudolf.koll...@medas.de --- Created attachment 116400 -- https://bugs.documentfoundation.org/attachment.cgi?id=116400action=edit The content of the template directory offered by LO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 Rudolf Kollien rudolf.koll...@medas.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from Rudolf Kollien rudolf.koll...@medas.de --- The screenshots. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
vcl::Window::dispose deadlock
On Windows, with master as of last night, make check happened to run into a deadlock in soffice.bin as below. The main thread is trying to re-acquire the SolarMutex (after a SolarMutexReleaser) from within the event loop, while an incoming URP thread (apparently holding the SolarMutex) does vcl::Window::dispose which, on Windows, blocks on sending a message into the event loop. Where's the bug? sal3.dll!osl_acquireMutex(_oslMutexImpl * Mutex) Line 72 vcllo.dll!osl::Mutex::acquire() Line 56 vcllo.dll!SalYieldMutex::acquire() Line 140 vcllo.dll!ImplSalAcquireYieldMutex(unsigned long nCount) Line 299 vcllo.dll!WinSalInstance::AcquireYieldMutex(unsigned long nCount) Line 586 vcllo.dll!Application::AcquireSolarMutex(unsigned long nCount) Line 417 tklo.dll!SolarMutexReleaser::~SolarMutexReleaser() Line 1690 tklo.dll!VCLXWindowImpl::OnProcessCallbacks(void * __formal) Line 306 tklo.dll!VCLXWindowImpl::LinkStubOnProcessCallbacks(void * instance, void * data) Line 274 vcllo.dll!Linkvoid *,long::Call(void * data) Line 127 vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 2026 vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalFrame * __formal, unsigned short nEvent, const void * pEvent) Line 2578 vcllo.dll!SalFrame::CallCallback(unsigned short nEvent, const void * pEvent) Line 244 vcllo.dll!ImplHandleUserEvent(HWND__ * hWnd, long lParam) Line 4128 vcllo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned int wParam, long lParam, int rDef) Line 5784 vcllo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned int wParam, long lParam) Line 5943 user32.dll!... vcllo.dll!ImplSalDispatchMessage(tagMSG * pMsg) Line 597 vcllo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 613 vcllo.dll!WinSalInstance::Yield(bool bWait, bool bHandleAllCurrentEvents) Line 669 vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 354 vcllo.dll!Application::Yield() Line 382 vcllo.dll!Application::Execute() Line 336 sofficeapp.dll!desktop::Desktop::Main() Line 1607 vcllo.dll!ImplSVMain() Line 162 vcllo.dll!SVMain() Line 197 sofficeapp.dll!soffice_main() Line 96 soffice.bin!sal_main() Line 48 soffice.bin!main(int argc, char * * argv) Line 47 soffice.bin!WinMain(void * _hinst, void * _dummy, char * _cmdline, int _nshow) Line 47 soffice.bin!__tmainCRTStartup() Line 618 soffice.bin!WinMainCRTStartup() Line 466 vcllo.dll!WinSalInstance::DestroyFrame(SalFrame * pFrame) Line 922 vcllo.dll!vcl::Window::dispose() Line 563 vcllo.dll!ImplBorderWindow::dispose() Line 1850 vcllo.dll!OutputDevice::disposeOnce() Line 204 vcllo.dll!VclPtrvcl::Window::disposeAndClear() Line 209 vcllo.dll!vcl::Window::dispose() Line 548 vcllo.dll!SystemWindow::dispose() Line 124 vcllo.dll!FloatingWindow::dispose() Line 235 vcllo.dll!ImplListBoxFloatingWindow::dispose() Line 2968 vcllo.dll!OutputDevice::disposeOnce() Line 204 vcllo.dll!VclPtrImplListBoxFloatingWindow::disposeAndClear() Line 209 vcllo.dll!ComboBox::dispose() Line 83 svxcorelo.dll!SvxStyleBox_Impl::dispose() Line 354 vcllo.dll!OutputDevice::disposeOnce() Line 204 sfxlo.dll!VclPtrvcl::Window::disposeAndClear() Line 209 sfxlo.dll!SfxToolBoxControl::dispose() Line 286 svxcorelo.dll!SvxStyleToolBoxControl::dispose() Line 2155 fwklo.dll!framework::ToolBarManager::RemoveControllers() Line 759 fwklo.dll!framework::ToolBarManager::dispose() Line 567 fwklo.dll!framework::ToolBarWrapper::dispose() Line 106 fwklo.dll!framework::ToolbarLayoutManager::destroyToolbars() Line 655 fwklo.dll!framework::ToolbarLayoutManager::reset() Line 365 fwklo.dll!framework::LayoutManager::implts_reset(bool bAttached) Line 410 fwklo.dll!framework::LayoutManager::frameAction(const com::sun::star::frame::FrameActionEvent aEvent) Line 2800 fwklo.dll!`anonymous namespace'::Frame::implts_sendFrameActionEvent(const com::sun::star::frame::FrameAction aAction) Line 2856 fwklo.dll!`anonymous namespace'::Frame::setComponent(const com::sun::star::uno::Referencecom::sun::star::awt::XWindow xComponentWindow, const com::sun::star::uno::Referencecom::sun::star::frame::XController xController) Line 1530 fwklo.dll!`anonymous namespace'::Frame::close(unsigned char bDeliverOwnership) Line 1781 sfxlo.dll!SfxFrame::DoClose() Line 134 sfxlo.dll!SfxViewFrame::Notify(SfxBroadcaster __formal, const SfxHint rHint) Line 1290 svllo.dll!SfxBroadcaster::Broadcast(const SfxHint rHint) Line 52 sfxlo.dll!SfxModelListener_Impl::notifyClosing(const com::sun::star::lang::EventObject __formal) Line 170 sfxlo.dll!SfxBaseModel::close(unsigned char bDeliverOwnership) Line 1406 msci_uno.dll!`anonymous namespace'::callVirtualMethod(void * pAdjustedThisPtr, long nVtableIndex, void * pRegisterReturn, _typelib_TypeClass eReturnTypeClass, long * pStackLongs, long nStackLongs) Line 74 msci_uno.dll!`anonymous namespace'::cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy * pThis, bridges::cpp_uno::shared::VtableSlot aVtableSlot, _typelib_TypeDescriptionReference * pReturnTypeRef, long
[Libreoffice-bugs] [Bug 91955] Interruzione inaspettata programma
https://bugs.documentfoundation.org/show_bug.cgi?id=91955 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- Hello, Thank you for reporting the bug. Can you see if bug 90435 is similar to your problem so that I can mark your report as a duplicate of it? (Later bugs are generally marked as duplicates of earlier bugs). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84175] Only one table in Calc document is exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=84175 --- Comment #5 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 116401 -- https://bugs.documentfoundation.org/attachment.cgi?id=116401action=edit Test Case (ODS-Ducument with two versions) There are two versions inside Test2.ods: The first one has the bug, and in the last one just some tables were deleted from the right. Then all tables are exported to PDF. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91861] Black screen in Mission control after closing the window is maximized
https://bugs.documentfoundation.org/show_bug.cgi?id=91861 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- If I type Cmd+Q from fullscreen mode, then I get a black screen, a screwed Mission Control / Spaces, and a hung LO app whose icon remains in the Dock. This then led to a complete inability to remove the app from the Dock, even through forcing Dock restart or Finder restart from the command line. In the end, I had to force reboot the machine. Confirming Tested on my own master build from 07/06/15 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78583] Cannot select (move, resize) floating frame
https://bugs.documentfoundation.org/show_bug.cgi?id=78583 --- Comment #5 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Problem still present in LibreOffice Still (4.3.7.2) with newly created documents. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91578] print format to print 1x wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=91578 j.t.ki...@arcor.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Version|4.3.7.2 release |4.4.3.2 rc Ever confirmed|1 |0 --- Comment #2 from j.t.ki...@arcor.de --- Problem remains at version 4.4.3.2 . I print 1 times 1 envelope and at 2 times the page size is wrong . This inexpensive ribbon is only by restarting L.O. solve . Or do I print at 1 time equal to several pages . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91804] colour dialog shows inactive top bar, dialog cannot be closed easily
https://bugs.documentfoundation.org/show_bug.cgi?id=91804 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Beluga todven...@suomi24.fi --- Looked at bug 84142 and it certainly looks identical. Closing as dupe. *** This bug has been marked as a duplicate of bug 84142 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91719] Line Numbering Selected Paragraphs Clunky and Inefficient
https://bugs.documentfoundation.org/show_bug.cgi?id=91719 Stephen stephenaustinm...@gmail.com changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 84142] UI: Some color pickers pop up with titlebar unless the Kwin/KDE setting forces no titlebar and no frame
https://bugs.documentfoundation.org/show_bug.cgi?id=84142 Beluga todven...@suomi24.fi changed: What|Removed |Added CC||winfrieddonkers@libreoffice ||.org --- Comment #12 from Beluga todven...@suomi24.fi --- *** Bug 91804 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #5 from Rudolf Kollien rudolf.koll...@medas.de --- Created attachment 116399 -- https://bugs.documentfoundation.org/attachment.cgi?id=116399action=edit Path setting in LO for the template directory The root directory for templates are Vorlagen. Beneath this directory are some other directories to sort templates in public, privat, or some other purposes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91578] print format to print 1x wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=91578 Beluga todven...@suomi24.fi changed: What|Removed |Added Version|4.4.3.2 rc |4.3.7.2 release --- Comment #3 from Beluga todven...@suomi24.fi --- Version is earliest affected, reverting change. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77665] Saving files as .doc produces errors
https://bugs.documentfoundation.org/show_bug.cgi?id=77665 steve -_- st...@openmailbox.org changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #4 from steve -_- st...@openmailbox.org --- Since there is no specific commit fixing this issue, setting to WORKSFORME. FIXED is used only when a commit exists. Thanks for the update (: -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang connectivity/source dbaccess/source extensions/source include/svl include/svtools include/svx include/test include/vcl lotuswordpro/source svx/sou
compilerplugins/clang/store/removevirtuals.cxx| 18 +
compilerplugins/clang/store/unnecessaryvirtual.cxx| 199 +++---
connectivity/source/drivers/file/fanalyzer.cxx| 11
connectivity/source/drivers/file/fcode.cxx|5
connectivity/source/drivers/file/fcomp.cxx|2
connectivity/source/inc/file/fanalyzer.hxx|4
connectivity/source/inc/file/fcode.hxx|1
dbaccess/source/core/api/querydescriptor.hxx |2
dbaccess/source/core/dataaccess/commanddefinition.hxx | 22 -
dbaccess/source/core/inc/TableDeco.hxx|2
dbaccess/source/core/inc/definitioncolumn.hxx |2
dbaccess/source/ui/dlg/generalpage.hxx|2
dbaccess/source/ui/dlg/tablespage.hxx |2
extensions/source/propctrlr/commoncontrol.hxx |2
include/svl/svdde.hxx | 37 +--
include/svtools/editbrowsebox.hxx |8
include/svx/fmgridcl.hxx |2
include/svx/fmgridif.hxx |4
include/svx/gridctrl.hxx | 22 -
include/test/beans/xpropertyset.hxx |2
include/vcl/scheduler.hxx |2
include/vcl/window.hxx|4
lotuswordpro/source/filter/lwpoleobject.hxx |2
lotuswordpro/source/filter/lwpparastyle.hxx |4
svx/source/inc/gridcell.hxx |2
vcl/inc/sallayout.hxx |2
26 files changed, 251 insertions(+), 114 deletions(-)
New commits:
commit 81b954718f0cdac6873927e869b3e41f863562e7
Author: Noel Grandin n...@peralex.com
Date: Tue Jun 9 08:55:13 2015 +0200
loplugin:unnecessaryvirtuals
Improve the plugin a little.
Create a python script to process the output.
Run it again.
Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
diff --git a/compilerplugins/clang/store/removevirtuals.cxx
b/compilerplugins/clang/store/removevirtuals.cxx
index c2bf484..18aebb4 100644
--- a/compilerplugins/clang/store/removevirtuals.cxx
+++ b/compilerplugins/clang/store/removevirtuals.cxx
@@ -53,7 +53,7 @@ static size_t getFilesize(const char* filename)
RemoveVirtuals::RemoveVirtuals(InstantiationData const data):
RewritePlugin(data)
{
-static const char sInputFile[] = /home/noel/libo4/result.txt;
+static const char sInputFile[] = /home/noel/libo5/result.txt;
mmapFilesize = getFilesize(sInputFile);
//Open file
mmapFD = open(sInputFile, O_RDONLY, 0);
@@ -120,14 +120,26 @@ bool RemoveVirtuals::VisitCXXMethodDecl( const
CXXMethodDecl* functionDecl )
return true;
}
if (functionDecl-isPure()) {
-removeText(functionDecl-getSourceRange());
+if (!removeText(functionDecl-getSourceRange())) {
+report(
+DiagnosticsEngine::Warning,
+Could not remove unused pure virtual method,
+functionDecl-getLocStart())
+ functionDecl-getSourceRange();
+}
} else {
std::string aOrigText =
rewriter-getRewrittenText(functionDecl-getSourceRange());
size_t iVirtualTokenIndex = aOrigText.find_first_of(virtual );
if (iVirtualTokenIndex == std::string::npos) {
return true;
}
-replaceText(functionDecl-getSourceRange(),
aOrigText.replace(iVirtualTokenIndex, strlen(virtual ), ));
+if (!replaceText(functionDecl-getSourceRange(),
aOrigText.replace(iVirtualTokenIndex, strlen(virtual ), ))) {
+report(
+DiagnosticsEngine::Warning,
+Could not remove virtual qualifier from method,
+functionDecl-getLocStart())
+ functionDecl-getSourceRange();
+}
}
return true;
}
diff --git a/compilerplugins/clang/store/unnecessaryvirtual.cxx
b/compilerplugins/clang/store/unnecessaryvirtual.cxx
index 0ead077..53688cb 100644
--- a/compilerplugins/clang/store/unnecessaryvirtual.cxx
+++ b/compilerplugins/clang/store/unnecessaryvirtual.cxx
@@ -10,6 +10,7 @@
#include cassert
#include string
#include iostream
+#include set
#include plugin.hxx
#include compat.hxx
@@ -20,15 +21,14 @@ Then we will post-process the 2 lists and find the set of
virtual methods which
The process goes something like this:
$ make check
$ make FORCE_COMPILE_ALL=1 COMPILER_PLUGIN_TOOL='unnecessaryvirtual' check
log.txt
- $ grep 'definition' log.txt | cut -f 2 | sort -u definition.txt
- $ grep 'overriding' log.txt | cut -f 2 | sort -u overriding.txt
- $ cat definition.txt overriding.txt | sort | uniq -u result.txt
- $ echo \n result.txt
- $ for dir in *; do make FORCE_COMPILE_ALL=1 UPDATE_FILES=$dir
COMPILER_PLUGIN_TOOL='removevirtuals' $dir; done
+ $
[Libreoffice-bugs] [Bug 91938] Help text stays visible when not relevant
https://bugs.documentfoundation.org/show_bug.cgi?id=91938 raal r...@post.cz changed: What|Removed |Added CC||r...@post.cz --- Comment #1 from raal r...@post.cz --- I can not reproduce with LO 4.4.3, win7. Please could you attach test file? Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91954] By creating a link to open in new tab with _blank it does not open in new tab
https://bugs.documentfoundation.org/show_bug.cgi?id=91954 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||r...@post.cz Ever confirmed|0 |1 --- Comment #1 from raal r...@post.cz --- Hello [user's name], Thank you for filing the bug. Please send us a sample document, as this makes it easier for us to verify the bug. I don't fully understand your explanation of the bug. Tested with LO 4.4.3 and I can create hyperlink without problem. In new tab you mean tab in web browser? I have set the bug's status to 'NEEDINFO', so please do change it back to 'UNCONFIRMED' once you have attached a document. (Please note that the attachment will be public, remove any sensitive information before attaching it.) How can I eliminate confidential data from a sample document? https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91734] Bookmarks not sorted alphabetically
https://bugs.documentfoundation.org/show_bug.cgi?id=91734 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |INVALID --- Comment #5 from Beluga todven...@suomi24.fi --- I don't know why I started talking about bookmarks being sorted by creation when right-clicking the page number. They are sorted by the order they appear in the document. This has been the way since at least 3.3.0. So the right-click view shows: BOXFORD CALC 98 CINVERT ODT TO PDF While the navigator shows the correct alphabetical order: BOXFORD CALC 98 CARLSON I'm closing this as invalid as there was no error. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79695] FILEOPEN: MS Word 2013 ODF shows red question marks after formula
https://bugs.documentfoundation.org/show_bug.cgi?id=79695 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Component|Writer |Formula Editor --- Comment #4 from Yousuf (Jay) Philips philip...@hotmail.com --- Red question marks still present. Version: 5.1.0.0.alpha1+ Build ID: 587006cac508616f486aea45e265a170bcccdc87 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-06_00:16:39 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #13 from Julien Nabet serval2...@yahoo.fr --- The command doesn't change your user name but rename the LO directory profile. So now you can test again LibreOffice with aaa. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] daily dbgutil bibisect: Calc fails since 2015-06-05
Le 08/06/2015 21:22, Terrence Enger a écrit : Hi Terry, This problem first happens with version of 2015-06-05. Has anybody else seen this? Any suggestions? Steve has seen this on OSX too, and I met the same message when testing mmy own master build from 2 days ago. Alex ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 91930] Styles and Formatting: White background when background option is No fill
https://bugs.documentfoundation.org/show_bug.cgi?id=91930 raal r...@post.cz changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Version|5.0.0.0.beta1 |4.4.3.2 rc Ever confirmed|0 |1 --- Comment #2 from raal r...@post.cz --- I can confirm with LO 4.4.3, win7 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78583] Cannot select (move, resize) floating frame
https://bugs.documentfoundation.org/show_bug.cgi?id=78583 --- Comment #6 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 116402 -- https://bugs.documentfoundation.org/attachment.cgi?id=116402action=edit Sample text document to include -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78583] Cannot select (move, resize) floating frame
https://bugs.documentfoundation.org/show_bug.cgi?id=78583 --- Comment #7 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Created attachment 116403 -- https://bugs.documentfoundation.org/attachment.cgi?id=116403action=edit Test Presentation using attachment #116402 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #14 from Henrik Jansson henrik_jans...@hotmail.com --- (In reply to Julien Nabet from comment #13) The command doesn't change your user name but rename the LO directory profile. So now you can test again LibreOffice with aaa. Ok. No it still dont work. The weird thing is that I have a another partition with Linux Mint 17 installed in english, and on that system it works. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #15 from Henrik Jansson henrik_jans...@hotmail.com --- and a even more weird thing is that if I change the language in the system settings in my Swedish Linux Mint to English, then LibreOffice works fine. And if I change the settings in my English installed Linux to Swedish, then Libreoffice still works fine, but on both my computers with Linux Mint 17 installed with Swedish settings from the beginning, LibreOffice does not work with Swedish settings. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #3 from Rudolf Kollien rudolf.koll...@medas.de --- Attached some screenshots from the current version 4.3.7.2 64bit running under Centos 5.11. On the first screenshot you can see six files. Five of them with .ott extension as real templates, one of them as a ordinary document file. The second screenshot verifies, that the path is correct for templates The third screenshot shows the templates provided in this path from LO. As you can see, this are only five and not six files. All shown templates are the files in the directory with .ott extension. The template with the .odt extension is missing -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #4 from Rudolf Kollien rudolf.koll...@medas.de --- Created attachment 116398 -- https://bugs.documentfoundation.org/attachment.cgi?id=116398action=edit Directory view (konqueror) from the content of the template dir -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa writerfilter/source
sw/qa/extras/ooxmlimport/data/tdf8255.docx |binary
sw/qa/extras/ooxmlimport/ooxmlimport.cxx|9 +
writerfilter/source/dmapper/PropertyMap.cxx | 12 +++-
3 files changed, 20 insertions(+), 1 deletion(-)
New commits:
commit 233a52af646f73a9ef0d53dd27f2823e8c362728
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Mon Jun 8 07:48:42 2015 +0200
tdf#82553 DOCX import: handle table margin when converting floattables
Change-Id: I7a3a233a34453153b3e1c0fe3d60bb0ede65dc86
(cherry picked from commit 292ec5fe8d01af6119325f1a426422bb42e58615)
diff --git a/sw/qa/extras/ooxmlimport/data/tdf8255.docx
b/sw/qa/extras/ooxmlimport/data/tdf8255.docx
new file mode 100644
index 000..366e498
Binary files /dev/null and b/sw/qa/extras/ooxmlimport/data/tdf8255.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 89924e4..b16877d 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -2707,6 +2707,15 @@ DECLARE_OOXMLIMPORT_TEST(mathtype, mathtype.docx)
CPPUNIT_ASSERT(xModel-supportsService(com.sun.star.formula.FormulaProperties));
}
+DECLARE_OOXMLIMPORT_TEST(testTdf8255, tdf8255.docx)
+{
+uno::Referencetext::XTextDocument xTextDocument(mxComponent,
uno::UNO_QUERY);
+uno::Referencedrawing::XDrawPageSupplier
xDrawPageSupplier(xTextDocument, uno::UNO_QUERY);
+uno::Referencedrawing::XDrawPage xDrawPage =
xDrawPageSupplier-getDrawPage();
+// This was 1: a full-page-wide multi-page floating table was imported as
a TextFrame.
+CPPUNIT_ASSERT_EQUAL(static_castsal_Int32(0), xDrawPage-getCount());
+}
+
#endif
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/dmapper/PropertyMap.cxx
b/writerfilter/source/dmapper/PropertyMap.cxx
index dcf4f3b..b9f46ff 100644
--- a/writerfilter/source/dmapper/PropertyMap.cxx
+++ b/writerfilter/source/dmapper/PropertyMap.cxx
@@ -1029,6 +1029,16 @@ void SectionPropertyMap::CloseSectionGroup(
DomainMapper_Impl rDM_Impl )
for (size_t i = 0; i rPendingFloatingTables.size(); ++i)
{
FloatingTableInfo rInfo = rPendingFloatingTables[i];
+
+// Count the layout width of the table.
+sal_Int32 nTableWidth = rInfo.m_nTableWidth;
+sal_Int32 nLeftMargin = 0;
+if (rInfo.getPropertyValue(LeftMargin) = nLeftMargin)
+nTableWidth += nLeftMargin;
+sal_Int32 nRightMargin = 0;
+if (rInfo.getPropertyValue(RightMargin) = nRightMargin)
+nTableWidth += nRightMargin;
+
// If the table is wider than the text area, then don't create a fly
// for the table: no wrapping will be performed anyway, but multi-page
// tables will be broken.
@@ -1037,7 +1047,7 @@ void SectionPropertyMap::CloseSectionGroup(
DomainMapper_Impl rDM_Impl )
// If there are columns, always create the fly, otherwise the columns
would
// restrict geometry of the table.
if ( ( rInfo.getPropertyValue(HoriOrientRelation) ==
text::RelOrientation::PAGE_FRAME ) ||
- ( rInfo.m_nTableWidth nTextAreaWidth ) || ColumnCount() + 1 =
2 )
+ nTableWidth nTextAreaWidth || ColumnCount() + 1 = 2 )
xBodyText-convertToTextFrame(rInfo.m_xStart, rInfo.m_xEnd,
rInfo.m_aFrameProperties);
}
rPendingFloatingTables.clear();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: vcl::Window::dispose deadlock
On 2015-06-09 09:58 AM, Stephan Bergmann wrote: On Windows, with master as of last night, make check happened to run into a deadlock in soffice.bin as below. The main thread is trying to re-acquire the SolarMutex (after a SolarMutexReleaser) from within the event loop, while an incoming URP thread (apparently holding the SolarMutex) does vcl::Window::dispose which, on Windows, blocks on sending a message into the event loop. Shouldn't something that blocks on sending a message into the event loop drop the SolarMutex while it waits for the reply, and then reacquire it afterwards? ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 91578] print format to print 1x wrong
https://bugs.documentfoundation.org/show_bug.cgi?id=91578 --- Comment #4 from j.t.ki...@arcor.de --- I have noticed that the problem only when you print with my printer but not for example Fax , Microsoft XPS , PDF Printer ... occurs . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: vcl::Window::dispose deadlock
On 06/09/2015 10:02 AM, Noel Grandin wrote: On 2015-06-09 09:58 AM, Stephan Bergmann wrote: On Windows, with master as of last night, make check happened to run into a deadlock in soffice.bin as below. The main thread is trying to re-acquire the SolarMutex (after a SolarMutexReleaser) from within the event loop, while an incoming URP thread (apparently holding the SolarMutex) does vcl::Window::dispose which, on Windows, blocks on sending a message into the event loop. Shouldn't something that blocks on sending a message into the event loop drop the SolarMutex while it waits for the reply, and then reacquire it afterwards? I'm not sure how this happened to work before introduction of Window::dispose (which got introduced as part of the VclPtr work, IIUC). But doing release/re-acquire of the SolarMutex deep down the call stack has its own perils (and probably creates just as many data races as it helps work around deadlocks). ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/store/unnecessaryvirtual.py | 77 ++ 1 file changed, 77 insertions(+) New commits: commit 56365c650c915120f7a2c4b262458e264b5b352d Author: Noel Grandin n...@peralex.com Date: Tue Jun 9 10:08:10 2015 +0200 forgot to add this - the python file for the unnnecessaryvirtual clang plugin Change-Id: I1392ad1834dc590cec12e379d6478c42b1bbbc20 diff --git a/compilerplugins/clang/store/unnecessaryvirtual.py b/compilerplugins/clang/store/unnecessaryvirtual.py new file mode 100755 index 000..4bce4de --- /dev/null +++ b/compilerplugins/clang/store/unnecessaryvirtual.py @@ -0,0 +1,77 @@ +#!/usr/bin/python + +import sys + +definitionSet = set() +overridingSet = set() +# things we need to exclude for reasons like : +# - we can't see the override because it's a MS-Windows-only thing. +# - they involve function template instantiations, which I can't handle +exclusionSet = set( +basegfx::unotools::UnoPolyPolygon::void-modifying()const, +SalLayout::_Bool-DrawTextSpecial(class SalGraphics ,sal_uInt32,)const, +SalLayout::_Bool-IsKashidaPosValid(int,)const, +SalLayout::void-DisableGlyphInjection(_Bool,), +SalObject::void-Enable(_Bool,), +PropertyWrapperBase::void-SetValue(const ::com::sun::star::uno::Any ,) +canvas::IColorBuffer::enum canvas::IColorBuffer::Format-getFormat()const, +canvas::IColorBuffer::sal_uInt32-getHeight()const, +canvas::IColorBuffer::sal_uInt32-getStride()const, +canvas::IColorBuffer::sal_uInt32-getWidth()const, +canvas::IColorBuffer::sal_uInt8 *-lock()const, +canvas::IColorBuffer::void-unlock()const, +canvas::IRenderModulebasegfx::B2IVector-getPageSize(), +canvas::IRenderModuleboost::shared_ptrISurface-createSurface(const ::basegfx::B2IVector ,), +canvas::IRenderModule::_Bool-isError(), +canvas::IRenderModule::void-beginPrimitive(enum canvas::IRenderModule::PrimitiveType,), +canvas::IRenderModule::void-endPrimitive(), +canvas::IRenderModule::void-lock()const, +canvas::IRenderModule::void-pushVertex(const struct canvas::Vertex ,), +canvas::IRenderModule::void-unlock()const, +canvas::ISurface::_Bool-isValid(), +canvas::ISurface::_Bool-selectTexture(), +canvas::ISurface::_Bool-update(const ::basegfx::B2IPoint ,const ::basegfx::B2IRange ,struct canvas::IColorBuffer ,), +SalFrame::void-Flush(const class Rectangle ,), +SalFrame::void-SetRepresentedURL(const class rtl::OUString ,), +SalLayout::_Bool-DrawTextSpecial(class SalGraphics ,sal_uInt32,)const, +SalLayout::_Bool-GetBoundRect(class SalGraphics ,class Rectangle ,)const, +SalLayout::_Bool-IsKashidaPosValid(int,)const, +SalLayout::void-DisableGlyphInjection(_Bool,), +writerfilter::ooxml::OOXMLFactory_ns::Id-getResourceId(Id,sal_Int32,), +writerfilter::ooxml::OOXMLFactory_ns::_Bool-getElementId(Id,Id,enum writerfilter::ooxml::ResourceType_t ,Id ,), +writerfilter::ooxml::OOXMLFactory_ns::_Bool-getListValue(Id,const class rtl::OUString ,sal_uInt32 ,), +writerfilter::ooxml::OOXMLFactory_ns::const struct writerfilter::ooxml::AttributeInfo *-getAttributeInfoArray(Id,), +sd::ZeroconfService::void-clear(), +sd::ZeroconfService::void-setup(), +slideshow::internal::EnumAnimation::ValueType-getUnderlyingValue()const, +slideshow::internal::EnumAnimation::_Bool-operator()(ValueType,), +basegfx::unotools::UnoPolyPolygon::void-modifying()const, +DdeTopic::_Bool-Execute(const class rtl::OUString *,), +DdeTopic::class DdeData *-Get(enum SotClipboardFormatId,), +DdeTopic::_Bool-Put(const class DdeData *,), +DdeTopic::_Bool-MakeItem(const class rtl::OUString ,), +DdeTopic::_Bool-StartAdviseLoop(), +) + + +with open(sys.argv[1]) as txt: +for line in txt: + +if line.startswith(definition:\t): +idx1 = line.find(\t) +clazzName = line[idx1+1 : len(line)-1] +definitionSet.add(clazzName) + +elif line.startswith(overriding:\t): +idx1 = line.find(\t) +clazzName = line[idx1+1 : len(line)-1] +overridingSet.add(clazzName) + +for clazz in sorted(definitionSet - overridingSet - exclusionSet): +# these involve function template instantiations, which I can't handle +if not clazz.startswith(basebmp::BitmapDevice::): +print clazz + +# add an empty line at the end to make it easier for the removevirtuals plugin to mmap() the output file +print + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #12 from Henrik Jansson henrik_jans...@hotmail.com --- (In reply to Julien Nabet from comment #11) I don't know the user name on your pc. To know it, type this: cd (without quotes) pwd (idem) you'll have a path like this: /home/user name so you'll know your user name I know my username, my question was if I was supposed to change my username on the computer with this command? I wrote as you said and nothing happened. What should have happened? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Changes to 'feature/unocrsrptr'
New branch 'feature/unocrsrptr' available with the following commits: commit dea9f421bdcc77fc1975362f5f06db57f0c412bc Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sun Jun 7 00:10:51 2015 +0200 alias sw::UnoImplPtr to ::std::unique_ptr ... - ... with a custom deleter - and kill homegrown implementation Change-Id: I9babf556dc75772f388d23fd05b916abb4bed497 commit d6f749795b04bb2fb7e9b32122598810bb8c7570 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sat Jun 6 03:38:49 2015 +0200 use new UnoCursorPointer in SwXTextPortionEnumeration Change-Id: If6b64c92d4f6f786767802cc046ccd96bd8367cb commit 3c9f12c0e71314c4367519356e7afab6f07153a3 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sat Jun 6 03:26:12 2015 +0200 use UnoCursorPointer in SwXTextPortion Change-Id: I8628fd1fecb3e2cf54704f9844ff921862da46e5 commit c6c2715373f4ebb79ff0b748e546bd01f0ab8a83 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sat Jun 6 03:07:35 2015 +0200 use UnoCursorPointer in SwXTextTableCursor Change-Id: Ia58e286760e52191edbe968504e3db0967ce09d3 commit 5cd77233d94f1a1137706421be01bfad9b1f4b59 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sat Jun 6 02:46:13 2015 +0200 add comment on possibly memory leak Change-Id: I7e1fc471ca5930ceaff4b1c6c6ba351ff0594639 commit 93f8f92dc0d5318190ead5469a2f6edf68c4d60f Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sat Jun 6 02:38:02 2015 +0200 use UnoCursorPointer in SwXCellRange and SwChartDataSequence Change-Id: I23d75d094c2b2dd8d234b608556a8b2339b7f166 commit acb337a8ca6effe05d229638f7ae77eac8c43454 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Thu Jun 4 22:58:25 2015 +0200 use UnoCursorPointer in SwXTextCursor Change-Id: I46d464405d5de6460b10a2965e0c1f011c8142b2 commit 962f4ab8e9b5e6b01c538c45d48b77a0a3fcded2 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Wed Jun 3 00:36:14 2015 +0200 use UnoCursorPointer in SwNavigationMgr Change-Id: I7c7431edd79cf4527f97c7dc0695d49174b61e2c commit 28b76f95b90637d72cf136b7a078f6f3feb16c75 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Jun 2 23:16:21 2015 +0200 another RAII Change-Id: I11bb3ab21e3434574578cd7fbe03b0b75158e355 commit fbc28955aac539e4f28185e1c48b853a7d3d3fee Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 23:15:02 2015 +0200 refactor out frame collection with layout Change-Id: I977c9915414eedead860622b120f00ad811e18e9 commit 177534c0728f49d3d98dceb4f738182bd2bdfa00 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 22:27:59 2015 +0200 refactor SwXParaFrameEnumerationImpl ctor Change-Id: I017a4b5ccc28d90e1464e8cbf60cffbc96324963 commit 1c99a655eeb197bf34f6374540cbe40fbece5f08 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 21:47:57 2015 +0200 make FillFrames a member Change-Id: I1582705ce3ae9cc7bbe33789a1626e8d7d3853cf commit e16080c9d18e34c0d835f555ad81f97ea66ea1be Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 21:22:53 2015 +0200 make CreateNextObject a member Change-Id: I1bd9668a2567390ceceb1742483a9fdabc025db7 commit 34be2312a39dbeb457448ca86026b89969a98bae Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 20:49:47 2015 +0200 simplify and inline trivial boilerplate Change-Id: Idcf0ef3670209c6b68e4afac8efcd8ab463e4774 commit 1e4dc2aa95350730b48f3f2b75035dc9ef4209d3 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 20:37:51 2015 +0200 use ABC instead of Pimpl for SwXTextRanges - abstract base class reduces boilerplate - Pimpl is pointless here, except for SolarMutex, which is handled by overriding release Change-Id: Ia08dc26104f70411a783ade681be3bcebb3b9acb commit 21061537142308bd03bd176a3281fd3099ea05d1 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 19:50:57 2015 +0200 RAII for ParagraphFrameEnumeration Change-Id: I23d9beabe38587eca2b0620b5c431835ce70d37b commit d466e21d794d5eba75d2b63c828d751a9c31aaa4 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Mon Jun 1 19:43:00 2015 +0200 use UnoCursorPointer in ParagraphFrameEnumeration Change-Id: I5fdf0bdd8609aa07c49b155cc75cade8bdb2c292 commit f80c82eff9c93f77d445cc3d1167531482ce48b2 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sun May 31 02:12:47 2015 +0200 inline trivial oneliners Change-Id: I20b993f1775b2db9865487ed84c60e07fd0a4ced commit a467391a0a87ea6171fd15766f99fb3f4aeba510 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sun May 31 01:58:53 2015 +0200 use ABC instead of Pimpl for
[Libreoffice-bugs] [Bug 91456] Fade smoothly slide transition is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=91456 László Németh nem...@numbertext.org changed: What|Removed |Added Keywords||bisected Blocks|91488 | Whiteboard|bibisectRequest |bibisected --- Comment #4 from László Németh nem...@numbertext.org --- It seems, missing image results the missing fading. Clicking on the second slide, it shows only a missing image icon instead of the image in the bad builds. Bibisected with bibisect-44max: aeb0840ff404a857f6f9e8ea59e1918e6b46b043 is the first bad commit commit aeb0840ff404a857f6f9e8ea59e1918e6b46b043 Author: Matthew Francis mjay.fran...@gmail.com Date: Sun Mar 15 05:55:29 2015 +0800 source-hash-286e2f5c6ec829bc0987b1be7016699f7ef03e5e commit 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Author: Zolnai Tamás tamas.zol...@collabora.com AuthorDate: Sun Nov 16 15:12:54 2014 +0100 Commit: Zolnai Tamás tamas.zol...@collabora.com CommitDate: Sun Nov 16 20:30:57 2014 +0100 Related fdo#82953: Forget package URL of image after it is loaded It causes problems if we handle those imported images differently which are identified by a package URL, so after the first load remove this URL and handle images on the same way as inserted images. Some related bugs: * #i44367# * #i124946# * #i114361# * fdo#73270 The image in the test document has a special ID which is different from that one which is generated by LO internally so after ODF export the new generated image URL is different from the imported one. Change-Id: I4e7d3490674c5f86bec5c7c6e1c975dcafd7c265 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 László Németh nem...@numbertext.org changed: What|Removed |Added Depends on|91456 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 20 commits - include/LibreOfficeKit libreofficekit/Library_libreofficekitgtk.mk libreofficekit/qa libreofficekit/source
include/LibreOfficeKit/LibreOfficeKitGtk.h | 73 +-
libreofficekit/Library_libreofficekitgtk.mk |1
libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx | 52 -
libreofficekit/source/gtk/lokdocview.cxx| 527 ++--
libreofficekit/source/gtk/tilebuffer.cxx| 111
libreofficekit/source/gtk/tilebuffer.hxx| 135 +
6 files changed, 587 insertions(+), 312 deletions(-)
New commits:
commit 2afe94dbfc85cbcde1399267379a466d527998a4
Author: Pranav Kant pran...@gnome.org
Date: Mon Jun 8 15:24:12 2015 +0530
tilebuffer: tileSize as member variable is superfluous
Change-Id: I1eae8c96c12ba4d272341f45fee6c1fd66ab9e28
diff --git a/libreofficekit/source/gtk/lokdocview.cxx
b/libreofficekit/source/gtk/lokdocview.cxx
index 64955f7..5f768e7 100644
--- a/libreofficekit/source/gtk/lokdocview.cxx
+++ b/libreofficekit/source/gtk/lokdocview.cxx
@@ -274,7 +274,7 @@ LOKDocView_Impl::CallbackData::CallbackData(int nType,
const std::string rPaylo
LOKDocView_Impl::LOKDocView_Impl(LOKDocView* pDocView)
: m_pDocView(pDocView),
m_pDrawingArea(gtk_drawing_area_new()),
- m_aTileBuffer(TileBuffer(0,0,0,0)),
+ m_aTileBuffer(TileBuffer(0,0,0)),
m_fZoom(1),
m_pOffice(0),
m_pDocument(0),
@@ -1236,7 +1236,6 @@ SAL_DLLPUBLIC_EXPORT gboolean lok_doc_view_open_document(
LOKDocView* pDocView,
pDocView-m_pImpl-m_aTileBuffer =
TileBuffer(pDocView-m_pImpl-m_pDocument,
- nTileSizePixels,
nRows,
nColumns);
gtk_widget_set_size_request(pDocView-m_pImpl-m_pDrawingArea,
@@ -1263,7 +1262,6 @@ SAL_DLLPUBLIC_EXPORT void lok_doc_view_set_zoom (
LOKDocView* pDocView, float fZ
guint nColumns = ceil((double)nDocumentWidthPixels / nTileSizePixels);
pDocView-m_pImpl-m_aTileBuffer =
TileBuffer(pDocView-m_pImpl-m_pDocument,
- nTileSizePixels,
nRows,
nColumns);
gtk_widget_set_size_request(pDocView-m_pImpl-m_pDrawingArea,
diff --git a/libreofficekit/source/gtk/tilebuffer.cxx
b/libreofficekit/source/gtk/tilebuffer.cxx
index 774806b..1d6a8b6 100644
--- a/libreofficekit/source/gtk/tilebuffer.cxx
+++ b/libreofficekit/source/gtk/tilebuffer.cxx
@@ -79,7 +79,7 @@ Tile TileBuffer::getTile(int x, int y, float aZoom)
if(m_mTiles.find(index) == m_mTiles.end() || !m_mTiles[index].valid)
{
-GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
m_nTileSize, m_nTileSize);
+GdkPixbuf* pPixBuf = gdk_pixbuf_new(GDK_COLORSPACE_RGB, TRUE, 8,
nTileSizePixels, nTileSizePixels);
if (!pPixBuf)
{
g_info (Error allocating memory to pixbuf);
@@ -88,16 +88,16 @@ Tile TileBuffer::getTile(int x, int y, float aZoom)
unsigned char* pBuffer = gdk_pixbuf_get_pixels(pPixBuf);
GdkRectangle aTileRectangle;
-aTileRectangle.x = pixelToTwip(m_nTileSize, aZoom) * y;
-aTileRectangle.y = pixelToTwip(m_nTileSize, aZoom) * x;
+aTileRectangle.x = pixelToTwip(nTileSizePixels, aZoom) * y;
+aTileRectangle.y = pixelToTwip(nTileSizePixels, aZoom) * x;
g_info (Rendering (%d, %d), x, y);
m_pLOKDocument-pClass-paintTile(m_pLOKDocument,
pBuffer,
- m_nTileSize, m_nTileSize,
+ nTileSizePixels, nTileSizePixels,
aTileRectangle.x, aTileRectangle.y,
- pixelToTwip(m_nTileSize, aZoom),
- pixelToTwip(m_nTileSize, aZoom));
+ pixelToTwip(nTileSizePixels, aZoom),
+ pixelToTwip(nTileSizePixels, aZoom));
//create a mapping for it
m_mTiles[index].setPixbuf(pPixBuf);
diff --git a/libreofficekit/source/gtk/tilebuffer.hxx
b/libreofficekit/source/gtk/tilebuffer.hxx
index 5966004..ea8e524 100644
--- a/libreofficekit/source/gtk/tilebuffer.hxx
+++ b/libreofficekit/source/gtk/tilebuffer.hxx
@@ -83,11 +83,9 @@ class TileBuffer
{
public:
TileBuffer(LibreOfficeKitDocument *document,
-int tileSize,
int rows,
int columns)
: m_pLOKDocument(document)
-, m_nTileSize(tileSize)
, m_nWidth(columns)
, m_nHeight(rows)
{ }
@@ -104,10 +102,11 @@ class TileBuffer
@param x the tile along the x-axis of the buffer
@param y the tile along the y-axis of the buffer
+ @param aZoom This function needs the zoom factor to draw the tile using
paintTile()
@return the tile at
[Libreoffice-bugs] [Bug 84175] Only one table in Calc document is exported to PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=84175 Ulrich Windl ulrich.wi...@rz.uni-regensburg.de changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|INVALID |--- Ever confirmed|1 |0 --- Comment #4 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de --- Reproduced with LibreOffice 4.3.7.2: WHen having many tables, only one table is exported to PDF, but when removing some tables, suddenly all tables are exported to PDF. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - package/inc package/source
package/inc/ZipOutputEntry.hxx |4
package/source/zipapi/ZipOutputStream.cxx |6 ++
package/source/zippackage/ZipPackageStream.cxx | 12 ++--
3 files changed, 20 insertions(+), 2 deletions(-)
New commits:
commit c6427d1d5fe398967801ae5f5cd5888afa2a8b14
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jun 5 11:45:36 2015 +0100
uncaught exceptions in parallel deflate threads on re-export of HTB23106
odgs
Change-Id: Ib6aef478b8dcf1c7a7262ab60eef4d44da0de632
(cherry picked from commit 05661623c7e328c536814354bafd8294de0e9ee0)
(cherry picked from commit 56b5b8aac8729a37814f82b83ebba0d16f87e407)
Reviewed-on: https://gerrit.libreoffice.org/16096
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Miklos Vajna vmik...@collabora.co.uk
diff --git a/package/inc/ZipOutputEntry.hxx b/package/inc/ZipOutputEntry.hxx
index 48e33eb..2a5aa04 100644
--- a/package/inc/ZipOutputEntry.hxx
+++ b/package/inc/ZipOutputEntry.hxx
@@ -42,6 +42,7 @@ class ZipOutputEntry
::com::sun::star::uno::Reference
::com::sun::star::xml::crypto::XCipherContext m_xCipherContext;
::com::sun::star::uno::Reference
::com::sun::star::xml::crypto::XDigestContext m_xDigestContext;
+::css::uno::Any m_aParallelDeflateException;
CRC32 m_aCRC;
ZipEntry*m_pCurrentEntry;
@@ -62,6 +63,9 @@ public:
ZipPackageStream* getZipPackageStream() { return m_pCurrentStream; }
bool isEncrypt() { return m_bEncryptCurrentEntry; }
+void setParallelDeflateException(const ::css::uno::Any rAny) {
m_aParallelDeflateException = rAny; }
+::css::uno::Any getParallelDeflateException() const { return
m_aParallelDeflateException; }
+
void closeEntry();
void write(const css::uno::Sequence sal_Int8 rBuffer);
diff --git a/package/source/zipapi/ZipOutputStream.cxx
b/package/source/zipapi/ZipOutputStream.cxx
index 9c56f45..a885340 100644
--- a/package/source/zipapi/ZipOutputStream.cxx
+++ b/package/source/zipapi/ZipOutputStream.cxx
@@ -23,6 +23,7 @@
#include com/sun/star/io/XInputStream.hpp
#include com/sun/star/io/XOutputStream.hpp
#include comphelper/storagehelper.hxx
+#include cppuhelper/exc_hlp.hxx
#include osl/diagnose.h
#include osl/time.h
@@ -101,6 +102,11 @@ void ZipOutputStream::finish()
m_rSharedThreadPool.waitUntilEmpty();
for (size_t i = 0; i m_aEntries.size(); i++)
{
+//Any exceptions thrown in the threads were caught and stored for now
+::css::uno::Any
aCaughtException(m_aEntries[i]-getParallelDeflateException());
+if (aCaughtException.hasValue())
+::cppu::throwException(aCaughtException);
+
writeLOC(m_aEntries[i]-getZipEntry(), m_aEntries[i]-isEncrypt());
sal_Int32 nRead;
diff --git a/package/source/zippackage/ZipPackageStream.cxx
b/package/source/zippackage/ZipPackageStream.cxx
index c34ba01..bd3ab20 100644
--- a/package/source/zippackage/ZipPackageStream.cxx
+++ b/package/source/zippackage/ZipPackageStream.cxx
@@ -46,6 +46,7 @@
#include comphelper/processfactory.hxx
#include comphelper/seekableinput.hxx
#include comphelper/storagehelper.hxx
+#include cppuhelper/exc_hlp.hxx
#include cppuhelper/supportsservice.hxx
#include cppuhelper/typeprovider.hxx
@@ -471,8 +472,15 @@ public:
private:
virtual void doWork() SAL_OVERRIDE
{
-deflateZipEntry(mpEntry, mxInStream);
-mxInStream.clear();
+try
+{
+deflateZipEntry(mpEntry, mxInStream);
+mxInStream.clear();
+}
+catch (const uno::Exception)
+{
+mpEntry-setParallelDeflateException(::cppu::getCaughtException());
+}
}
};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 79342] No Right-Click Menu for the Logo Toolbar
https://bugs.documentfoundation.org/show_bug.cgi?id=79342 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- So there is a context menu now, which was likely fixed in 5.0. Version: 5.1.0.0.alpha1+ Build ID: 587006cac508616f486aea45e265a170bcccdc87 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-06_00:16:39 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91741] absolute or modules does not print correctly as PDF
https://bugs.documentfoundation.org/show_bug.cgi?id=91741 --- Comment #2 from Beluga todven...@suomi24.fi --- Created attachment 116404 -- https://bugs.documentfoundation.org/attachment.cgi?id=116404action=edit Test kit John sent me this test kit. When I export Untitled 1.odt to PDF, I don't get the replacement boxes displayed in Untitled 1.pdf. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ Build ID: d28102b1ed0c31500bbc68453a7b7613bd2bfa06 TinderBox: Win-x86@39, Branch:master, Time: 2015-06-09_01:06:39 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 78352] FILEOPEN: DOCX space between bullet and text
https://bugs.documentfoundation.org/show_bug.cgi?id=78352 --- Comment #3 from Yousuf (Jay) Philips philip...@hotmail.com --- Created attachment 116405 -- https://bugs.documentfoundation.org/attachment.cgi?id=116405action=edit how it looks in 3.3.0 Still present. Screenshot of 3.3.0 is attached and i'm not sure whether it can be considered inherited from OOo or not. I'll let someone more experienced judge. Version: 5.1.0.0.alpha1+ Build ID: 587006cac508616f486aea45e265a170bcccdc87 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-06_00:16:39 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91707] Allow deleting multiple custom styles in all LibO apps
https://bugs.documentfoundation.org/show_bug.cgi?id=91707 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- I am unable to ctrl-select multiple custom styles even in 4.2.8. Please attach a screenshot showing a successful multi-selection. Win 7 Pro 64-bit, Version: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale: fi_FI Version: 5.1.0.0.alpha1+ Build ID: d28102b1ed0c31500bbc68453a7b7613bd2bfa06 TinderBox: Win-x86@39, Branch:master, Time: 2015-06-09_01:06:39 Locale: fi-FI (fi_FI) Ubuntu 15.04 64-bit Version: 4.2.8.2 Build ID: 48d50dbfc06349262c9d50868e5c1f630a573ebd -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 79267] FILEOPEN: DOCX - Callouts rendered as frames and loose callout look
https://bugs.documentfoundation.org/show_bug.cgi?id=79267 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Version|3.6.7.2 release |Inherited From OOo Summary|Callouts lose properties|FILEOPEN: DOCX - Callouts |when reading docx |rendered as frames and |fromMSWord |loose callout look Whiteboard||filter:docx --- Comment #7 from Yousuf (Jay) Philips philip...@hotmail.com --- Confirmed still present. Version: 5.1.0.0.alpha1+ Build ID: 587006cac508616f486aea45e265a170bcccdc87 TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-06_00:16:39 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91947] Calc does not compute a formula (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=91947 maur...@id.ternata.net changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #5 from maur...@id.ternata.net --- In regard to how this file was created: unfortunately, I don't know because I am not the original author of this file. The author asked me to have a look at the file because it was not correct. I analyzed the file and striped down everything from the file that was not causing the bug in order to keep the smallest bugged file as possible. On my side, when I perform a recalculation (Tools Cell Contents Recalculate), it does not recompute correctly but it keeps the 1866 value. On my side, when I disable the change tracking as you mentioned (File Properties... Security Record changes), it does not help, even if I save and reopen the file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #8 from Beluga todven...@suomi24.fi --- Just for completeness, you could test with the latest 4.4.x version. You can install in parallel, if you don't want to replace 4.3 yet: https://wiki.documentfoundation.org/Installing_in_parallel/Linux -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91695] VIEWING: text added above should move textsection down / sometimes overlap between section and text above it..
https://bugs.documentfoundation.org/show_bug.cgi?id=91695 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=64dc505ce180a168798b725423a308207de42c63h=libreoffice-5-0 Resolves: tdf#91695 partially Revert crash on layout of novell622972-2.html It will be available in 5.0.0.0.beta3. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/core/tool/token.cxx | 277 --
1 file changed, 163 insertions(+), 114 deletions(-)
New commits:
commit 38f99a5071bc5f3b68a6833305665b14bd5ba9ed
Author: Eike Rathke er...@redhat.com
Date: Mon Jun 8 15:33:51 2015 +0200
check bounds in RPN tokens, tdf#90694 related and others
Listeners are set up from references in RPN, so check those for bounds
to catch also references resulting from named expressions, database
ranges, tables, ... and references in the token code array that are not
referenced in RPN.
(cherry picked from commit 4baf76ddb39580678cf14019900be78bb9071d7b)
Windows MSVC: cannot specify explicit initializer for arrays
(cherry picked from commit 883ebe0283dc6bdf62f08191dede2a249f777f63)
c42897ba6bb520c931f63e56d0f453ed14cfaa3d
Change-Id: I54770b45818f4c0541a39815278d3271a77b345d
Reviewed-on: https://gerrit.libreoffice.org/16154
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index 9500a28..1462a8b 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -113,6 +113,34 @@ namespace
rRef.SetAbsTab(0);
}
+struct TokenPointerRange
+{
+FormulaToken** mpStart;
+FormulaToken** mpStop;
+
+TokenPointerRange() : mpStart(NULL), mpStop(NULL) {}
+TokenPointerRange( FormulaToken** p, sal_uInt16 n ) :
+mpStart(p), mpStop( p + static_castsize_t(n)) {}
+};
+struct TokenPointers
+{
+TokenPointerRange maPointerRange[2];
+
+TokenPointers( FormulaToken** pCode, sal_uInt16 nLen, FormulaToken**
pRPN, sal_uInt16 nRPN )
+{
+maPointerRange[0] = TokenPointerRange( pCode, nLen);
+maPointerRange[1] = TokenPointerRange( pRPN, nRPN);
+}
+
+static bool skipToken( size_t i, const FormulaToken* const * pp )
+{
+// Handle all tokens in RPN, and code tokens only if they have a
+// reference count of 1, which means they are not referenced in
+// RPN.
+return i == 0 (*pp)-GetRef() 1;
+}
+};
+
} // namespace
// Align MemPools on 4k boundaries - 64 bytes (4k is a MUST for OS/2)
@@ -3670,28 +3698,35 @@ void checkBounds(
void ScTokenArray::CheckRelativeReferenceBounds(
const sc::RefUpdateContext rCxt, const ScAddress rPos, SCROW nGroupLen,
std::vectorSCROW rBounds ) const
{
-FormulaToken** p = pCode;
-FormulaToken** pEnd = p + static_castsize_t(nLen);
-for (; p != pEnd; ++p)
+TokenPointers aPtrs( pCode, nLen, pRPN, nRPN);
+for (size_t j=0; j2; ++j)
{
-switch ((*p)-GetType())
+FormulaToken** p = aPtrs.maPointerRange[j].mpStart;
+FormulaToken** pEnd = aPtrs.maPointerRange[j].mpStop;
+for (; p != pEnd; ++p)
{
-case svSingleRef:
-{
-formula::FormulaToken* pToken = *p;
-checkBounds(rCxt, rPos, nGroupLen, *pToken-GetSingleRef(),
rBounds);
-}
-break;
-case svDoubleRef:
+if (TokenPointers::skipToken(j,p))
+continue;
+
+switch ((*p)-GetType())
{
-formula::FormulaToken* pToken = *p;
-const ScComplexRefData rRef = *pToken-GetDoubleRef();
-checkBounds(rCxt, rPos, nGroupLen, rRef.Ref1, rBounds);
-checkBounds(rCxt, rPos, nGroupLen, rRef.Ref2, rBounds);
+case svSingleRef:
+{
+formula::FormulaToken* pToken = *p;
+checkBounds(rCxt, rPos, nGroupLen,
*pToken-GetSingleRef(), rBounds);
+}
+break;
+case svDoubleRef:
+{
+formula::FormulaToken* pToken = *p;
+const ScComplexRefData rRef = *pToken-GetDoubleRef();
+checkBounds(rCxt, rPos, nGroupLen, rRef.Ref1, rBounds);
+checkBounds(rCxt, rPos, nGroupLen, rRef.Ref2, rBounds);
+}
+break;
+default:
+;
}
-break;
-default:
-;
}
}
}
@@ -3699,29 +3734,36 @@ void ScTokenArray::CheckRelativeReferenceBounds(
void ScTokenArray::CheckRelativeReferenceBounds(
const ScAddress rPos, SCROW nGroupLen, const ScRange rRange,
std::vectorSCROW rBounds ) const
{
-FormulaToken** p = pCode;
-FormulaToken** pEnd = p + static_castsize_t(nLen);
-for (; p != pEnd; ++p)
+TokenPointers aPtrs( pCode, nLen, pRPN, nRPN);
+for (size_t j=0; j2; ++j)
{
-switch ((*p)-GetType())
+FormulaToken** p = aPtrs.maPointerRange[j].mpStart;
+
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/core/tool/sharedformula.cxx | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
New commits:
commit d3a491fcc678bb4a490de79cb7474ef72cf6c35f
Author: Eike Rathke er...@redhat.com
Date: Fri Jun 5 15:51:46 2015 +0200
tdf#90694 reset group area listeners when splitting group
(cherry picked from commit 2f6a06856ad8df0c11a112d1e457b408e9a7af1d)
tdf#90694 reset group area listeners on correct top
Follow-up on 2f6a06856ad8df0c11a112d1e457b408e9a7af1d, rTop is top of
created group, listening needs to be ended on original (previous) group.
(cherry picked from commit 5d6448a5131488eac3a6af16bff06140663c3db4)
1f975a0a6c85e649aa07ce5c6e97bc6e917ff9ce
Change-Id: Ib3e85e1f7e12447fc2998711663ea1e9d1b322e5
Reviewed-on: https://gerrit.libreoffice.org/16104
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sc/source/core/tool/sharedformula.cxx
b/sc/source/core/tool/sharedformula.cxx
index b1cd80d..84025b9 100644
--- a/sc/source/core/tool/sharedformula.cxx
+++ b/sc/source/core/tool/sharedformula.cxx
@@ -55,12 +55,24 @@ void SharedFormulaUtil::splitFormulaCellGroup(const
CellStoreType::position_type
}
xGroup-mnLength = nRow - xGroup-mpTopCell-aPos.Row();
+ScFormulaCell rPrevTop = *sc::formula_block::at(*aPos.first-data,
aPos.second - xGroup-mnLength);
+
+#if USE_FORMULA_GROUP_LISTENER
+// At least group area listeners will have to be adapted. As long as
+// there's no update mechanism and no separated handling of group area and
+// other listeners, all listeners of this group's top cell are to be reset.
+if (nLength2)
+{
+rPrevTop.EndListeningTo( rPrevTop.GetDocument(), NULL, ScAddress(
ScAddress::UNINITIALIZED));
+rPrevTop.SetNeedsListening(true);
+}
+#endif
+
if (xGroup-mnLength == 1)
{
// The top group consists of only one cell. Ungroup this.
ScFormulaCellGroupRef xNone;
-ScFormulaCell rPrev = *sc::formula_block::at(*aPos.first-data,
aPos.second-1);
-rPrev.SetCellGroup(xNone);
+rPrevTop.SetCellGroup(xNone);
}
// Apply the lower group object to the lower cells.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - 2 commits - include/svx sc/source svx/source
include/svx/svdundo.hxx |3 -
sc/source/ui/miscdlgs/scuiautofmt.cxx |2 -
svx/source/svdraw/svdundo.cxx | 66 --
3 files changed, 1 insertion(+), 70 deletions(-)
New commits:
commit 78468b1cd267e3020173b11007922a509d2941ba
Author: Julien Nabet serval2...@yahoo.fr
Date: Sun May 31 15:17:19 2015 +0200
tdf#91726: AutoFormat: Crash when using an existing name
Add a test to check if name already exists
Change-Id: Ie23de04c0b747f58ab61a6e498bf212bf38b346a
Reviewed-on: https://gerrit.libreoffice.org/16000
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit 3807946b5515e943169da907866c93b52a2b3f19)
Reviewed-on: https://gerrit.libreoffice.org/16056
diff --git a/sc/source/ui/miscdlgs/scuiautofmt.cxx
b/sc/source/ui/miscdlgs/scuiautofmt.cxx
index b55b722..0829363 100644
--- a/sc/source/ui/miscdlgs/scuiautofmt.cxx
+++ b/sc/source/ui/miscdlgs/scuiautofmt.cxx
@@ -211,7 +211,7 @@ IMPL_LINK_NOARG(ScAutoFormatDlg, AddHdl)
{
aFormatName = pDlg-GetInputString();
-if ( !aFormatName.isEmpty()
!aFormatName.equals(aStrStandard) )
+if ( !aFormatName.isEmpty()
!aFormatName.equals(aStrStandard) pFormat-find(aFormatName) ==
pFormat-end() )
{
ScAutoFormatData* pNewData
= new ScAutoFormatData( *pSelFmtData );
commit 8fd1fc17fab7ec639e5a9de79db5122113da9ef9
Author: David Tardon dtar...@redhat.com
Date: Wed Jan 28 09:18:51 2015 +0100
tdf#78854 do not crash when undoing layout change
It turns out that the ordinal number adjustment that was added for
fdo#34548 is no longer necessary.
Change-Id: I2c491a008500b6a269b6f05a2a72f5aa70edecb2
(cherry picked from commit c0117fcb3dbd6c2a8d5e7679ee8d6fb29264ff6b)
Reviewed-on: https://gerrit.libreoffice.org/16152
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx
index c3e4861..f72c676 100644
--- a/include/svx/svdundo.hxx
+++ b/include/svx/svdundo.hxx
@@ -242,9 +242,6 @@ protected:
SdrView*pView; // To be able to re-create the
selection for a
SdrPageView*pPageView; // for a ObjDel, Undo
sal_uInt32 nOrdNum;
-// It's possible that the object is re-assigned during a Undo/Redo.
-// The object is deleted in the dtor, if bOwner==TRUE
-ObjListListener*m_pListener;
protected:
SdrUndoObjList(SdrObject rNewObj, bool bOrdNumDirect = false);
diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx
index bde9c51..b901845 100644
--- a/svx/source/svdraw/svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -679,73 +679,11 @@ OUString SdrUndoGeoObj::GetComment() const
-class SdrUndoObjList::ObjListListener : public SfxListener
-{
-public:
-ObjListListener(SdrUndoObjList rThat, SdrObject rObject, SfxBroadcaster
rBroadcaster);
-virtual ~ObjListListener();
-
-private:
-virtual void Notify(SfxBroadcaster rBroadcaster, const SfxHint rHint)
SAL_OVERRIDE;
-
-private:
-SdrUndoObjList m_rThat;
-SdrObject m_rObject;
-SfxBroadcaster* m_pBroadcaster;
-};
-
-SdrUndoObjList::ObjListListener::ObjListListener(SdrUndoObjList rThat,
SdrObject rObject, SfxBroadcaster rBroadcaster)
-: m_rThat(rThat)
-, m_rObject(rObject)
-, m_pBroadcaster(rBroadcaster)
-{
-StartListening(*m_pBroadcaster);
-}
-
-SdrUndoObjList::ObjListListener::~ObjListListener()
-{
-if (m_pBroadcaster)
-EndListening(*m_pBroadcaster);
-}
-
-void SdrUndoObjList::ObjListListener::Notify(SfxBroadcaster, const SfxHint
rHint)
-{
-const SdrHint* const pSdrHint(dynamic_castconst SdrHint*(rHint));
-if (pSdrHint)
-{
-if (pSdrHint-GetObject() == m_rObject)
-{
-switch (pSdrHint-GetKind())
-{
-case HINT_OBJCHG :
-if (IsListening(*m_pBroadcaster))
-{
-const sal_uInt32 nNewOrdNum(m_rObject.GetOrdNum());
-if (nNewOrdNum != m_rThat.GetOrdNum())
-m_rThat.SetOrdNum(nNewOrdNum);
-}
-break;
-case HINT_OBJREMOVED :
-SAL_WARN_IF(!IsListening(*m_pBroadcaster), svx.sdr, Object
is not in any list);
-EndListening(*m_pBroadcaster);
-break;
-case HINT_OBJINSERTED :
-SAL_WARN_IF(IsListening(*m_pBroadcaster), svx.sdr, Object
is already in a list);
-StartListening(*m_pBroadcaster);
-break;
-default :
-break;
-}
-}
-}
-}
-
SdrUndoObjList::SdrUndoObjList(SdrObject rNewObj, bool bOrdNumDirect)
[Libreoffice-bugs] [Bug 84709] In template directory odt files no longer visible
https://bugs.documentfoundation.org/show_bug.cgi?id=84709 --- Comment #9 from Rudolf Kollien rudolf.koll...@medas.de --- Created attachment 116410 -- https://bugs.documentfoundation.org/attachment.cgi?id=116410action=edit Version 4.4.x -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 85131] Style drop down doesn't update styles when paragraph is partially selected and/or not all text has same formatting
https://bugs.documentfoundation.org/show_bug.cgi?id=85131 --- Comment #5 from Cor Nouws c...@nouenoff.nl --- Question is whether this must be changed.. When you have to select a whole paragraph and all formatting must be the same: - it prevents messing up formatting (in at least the selected paragraph) - there is no change that one updates to a font that is not intended. Ideas for WontChange / WorksForMe ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91695] VIEWING: text added above should move textsection down / sometimes overlap between section and text above it..
https://bugs.documentfoundation.org/show_bug.cgi?id=91695 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |caol...@redhat.com |desktop.org | --- Comment #11 from Caolán McNamara caol...@redhat.com --- I reverted the part of the original commit which caused that -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91488] [META] RenderContext related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=91488 László Németh nem...@numbertext.org changed: What|Removed |Added Depends on|91462 | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91462] Menu items hidden when scrolled down
https://bugs.documentfoundation.org/show_bug.cgi?id=91462 László Németh nem...@numbertext.org changed: What|Removed |Added Keywords||bisected, regression CC||caol...@redhat.com Blocks|91488 | Whiteboard||bibisected --- Comment #4 from László Németh nem...@numbertext.org --- Bibisected with bibisect-50max. Perhaps the color of the title of the opened menu is the same, as its background? c2bcaa9db245ffb995908b1cf6d020ca28b79da3 is the first bad commit commit c2bcaa9db245ffb995908b1cf6d020ca28b79da3 Author: Matthew Francis mjay.fran...@gmail.com Date: Wed May 27 23:10:59 2015 +0800 source-hash-186eefd7e2020c65db32dacc3a9389573e7cddeb commit 186eefd7e2020c65db32dacc3a9389573e7cddeb Author: Caolán McNamara caol...@redhat.com AuthorDate: Fri May 15 17:19:24 2015 +0100 Commit: Caolán McNamara caol...@redhat.com CommitDate: Fri May 15 17:21:00 2015 +0100 gtk3: render native menubar and menubaritems this needs the addition of a new MenuBarHighlightTextColor which defaults to MenuHighlightTextColor on other platforms Change-Id: Id0550294f1778229cbbe154857ba16c629dc5a87 @Caolán: I wonder, that Windows Bug 91645 - Menu title turns white when clicked, is related to this bug, or not? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91791] Thickness of hatchings are too thin and is not user selectable
https://bugs.documentfoundation.org/show_bug.cgi?id=91791 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga todven...@suomi24.fi --- Valid request, NEW. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91944] Increase/Decrease indent sidebar buttons aren't working in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=91944 --- Comment #4 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to Maxim Monastirsky from comment #2) Sounds like you prefer the second option (i.e. change the behavior to inc/dec indent). Yes for consistency between apps, the buttons should be inc/dec indent buttons and should be functional. We should also add promote, demote, move up, move down buttons into the paragraph section (bug 87651). In this case, the sidebar code needs to be patched with something like the attached patch. You can test it if you have your own build, but please do not push, as this needs cleanup and verifying that it doesn't break anything else. If that's the route you want to take, just let me know, and I'll try to find some time to finish it in the coming days. I do have my own build but dont know how to apply your patch into the build. When a patch is in gerrit that i want to test, i'm easily able to download the patch into my build with './logerrit cherry-pick'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
