[Libreoffice-bugs] [Bug 92295] Crash: click Start from first slide (Java Error)
https://bugs.documentfoundation.org/show_bug.cgi?id=92295 --- Comment #5 from Stephan Bergmann sberg...@redhat.com --- The A fatal error has been detected by the Java Runtime Environment is a red herring. A JVM happens to be instantiated in-process in LO, and it handles each SIGSEGV in the process, even those unrelated to the JVM, by printing out its blurb. As mentioned in the blurb, the crash is outside the JVM in LO's # Problematic frame: # C [libmergedlo.so+0x2ac0eed] VirtualDevice::InnerImplSetOutputSizePixel(Size const, bool, boost::shared_arrayunsigned char const, bool)+0xd Please re-try by running soffice from a terminal after setting ulimit -c unlimited in the terminal. That should hopefully leave a core.* file in the current directory, from which you can obtain a more meaningful backtrace (gdb /opt/libreofficedev5.1/program/soffice.bin core.*, then in gdb t a a bt and capture the output). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Collabora LibreOffice Vanilla QA on OSX
Le 23/06/2015 20:17, Andras Timar a écrit : Hi all, For the consequences of the build switches, as I understand them, see below : Please find below the build configurations Collabora used: LibreOffice-from-Collabora: --disable-ext-ct2n --disable-ext-google_docs --disable-ext-mariadb-connector --disable-ext-numbertext The above extensions are currently not built by default in master AFAIK or in the default TDF builds. ct2n is an extension to convert a number written as text to digital number display google-docs is the Google Docs extension add-on - this requires Java mariadb-connector is the extension for building a sdbc driver that will allow for native (i.e. internal C++ wrapped around a C connector library, as opposed to calls to a JDBC/ODBC library) connections to a mysql/mariadb database server numbertext is an extension that does the opposite of ct2n ?? --disable-lotuswordpro These are the lwp filters. --disable-lpsolve This is the internal solver code --disable-neon Not sure about this one, but possibly related to network file access ? --disable-opengl No OpenGL support - as I understand, this is/was disabled on Mac master anyway --disable-pdfimport This is the code used to display and edit PDF documents in Writer and Draw, which means that users will not be able to open PDF documents for editing in LibreOffice --disable-postgresql-sdbc This is the postgresql database driver, used to natively connect LO to postgres instances --enable-macosx-retina HiDPI support enabled --enable-mpl-subset No idea what this does --disable-python This switch builds in python support. If it is not present, any and all python-dependent functionality will fail to work - that includes mailmerge, many of the wizards that were rewritten in python (e.g. Fax/Letter template wizards), UNO programming via python, --with-theme=tango Bit surprised not to see the Breeze icon theme here - any particular reason ? --without-help --without-helppack-integration No built-in help, i.e. clicking on the help button or F1 should launch Safari and point to the help wiki --without-java Any and all Java required functionality will not work - this includes a great deal of Base (embedded hsqldb, any and all JDBC driver functionality, Oracle ReportWriter) any and all Java user extensions that people might wish to install, and also some of the remaining wizards that are still written in Java One would hope that a suitably clear explanatory message is given when the user tries to activate any such call to instantiate the JVM, or that the app won't suddenly curl up and die. --without-myspell-dicts I'm not sure what the extent of the effect of this is. My understanding is that the hunspell/myspell dictionaries don't get built with this switch and that by default the Apple spelling correction is used instead ? LibreOffice Vanilla: --enable-extension-integration This enables bundled extension integration in general --disable-online-update Pretty obvious - I'm assuming there is an obligatory update mechanism that needs to be provided when one hosts an app in the AppStore ? --disable-odk --enable-ext-wiki-publisher --enable-report-builder --enable-ext-nlpsolver See above - with these switches on, the corresponding extensions are bundled - note that the report-builder extension requires Java, otherwise it will fail miserably to load and provoke an error message (or worse, the whole app will fail) --enable-symbols This is supposed to provide debugging symbols, although not quite sure how that works without --enable-dbgutil, maybe I have an incomplete understanding --without-java As Andras indicated in his mail, removing the Java switch and including the Report Builder extension is nonsense, it simply won't run, or worse, have other unintended side effects. Alex ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 7 commits - sw/inc sw/source
sw/inc/viewsh.hxx |8 +++-
sw/source/core/doc/notxtfrm.cxx| 21 ++---
sw/source/core/draw/dflyobj.cxx|2 +-
sw/source/core/inc/cellfrm.hxx |2 +-
sw/source/core/inc/flyfrm.hxx |2 +-
sw/source/core/inc/frame.hxx |2 +-
sw/source/core/inc/layfrm.hxx |2 +-
sw/source/core/inc/notxtfrm.hxx|2 +-
sw/source/core/inc/rootfrm.hxx |2 +-
sw/source/core/inc/tabfrm.hxx |2 +-
sw/source/core/inc/txtfrm.hxx |2 +-
sw/source/core/layout/paintfrm.cxx | 26 --
sw/source/core/layout/unusedf.cxx |2 +-
sw/source/core/text/frmpaint.cxx |6 +++---
sw/source/core/text/porfly.cxx |2 +-
sw/source/core/view/viewpg.cxx |2 +-
sw/source/core/view/viewsh.cxx | 30 --
sw/source/core/view/vnew.cxx |2 ++
sw/source/core/view/vprint.cxx | 16
sw/source/uibase/app/docsh.cxx |2 +-
sw/source/uibase/docvw/edtwin2.cxx |4
21 files changed, 79 insertions(+), 60 deletions(-)
New commits:
commit 793cf067532865a728b74d213e567c4d1f196a84
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Jun 24 13:13:41 2015 +0200
SwLayoutFrm::Paint: use vcl::RenderContext
Change-Id: Ibc36078313a9ee2482e392de18abfe77f3d0df48
(cherry picked from commit f640893b8ca6dc8f390dc128ad252693c7d241d9)
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index d0e298a..809a24d 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -3587,11 +3587,9 @@ SwShortCut::SwShortCut( const SwFrm rFrm, const SwRect
rRect )
void SwLayoutFrm::Paint(vcl::RenderContext rRenderContext, SwRect const
rRect, SwPrintData const*const) const
{
-SwViewShell *pSh = getRootFrm()-GetCurrShell();
-
// #i16816# tagged pdf support
Frm_Info aFrmInfo( *this );
-SwTaggedPDFHelper aTaggedPDFHelper( 0, aFrmInfo, 0, *pSh-GetOut() );
+SwTaggedPDFHelper aTaggedPDFHelper( 0, aFrmInfo, 0, rRenderContext );
const SwFrm *pFrm = Lower();
if ( !pFrm )
commit 3261bebe2f809866d698092b3292afbbc5e8b543
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Jun 24 13:12:08 2015 +0200
SwTextFrm::Paint: use vcl::RenderContext
Change-Id: Iede5ae0269a2bb2e4f2e6cef4af50d57e200938d
(cherry picked from commit c4270080798881bdac8392814dfb530e6a974c1e)
diff --git a/sw/source/core/text/frmpaint.cxx b/sw/source/core/text/frmpaint.cxx
index f47dfa3..22ddbd7 100644
--- a/sw/source/core/text/frmpaint.cxx
+++ b/sw/source/core/text/frmpaint.cxx
@@ -575,7 +575,7 @@ bool SwTextFrm::PaintEmpty( const SwRect rRect, bool
bCheck ) const
return false;
}
-void SwTextFrm::Paint(vcl::RenderContext /*rRenderContext*/, SwRect const
rRect, SwPrintData const*const) const
+void SwTextFrm::Paint(vcl::RenderContext rRenderContext, SwRect const rRect,
SwPrintData const*const) const
{
ResetRepaint();
@@ -583,10 +583,10 @@ void SwTextFrm::Paint(vcl::RenderContext
/*rRenderContext*/, SwRect const rRec
SwViewShell *pSh = getRootFrm()-GetCurrShell();
Num_Info aNumInfo( *this );
-SwTaggedPDFHelper aTaggedPDFHelperNumbering( aNumInfo, 0, 0,
*pSh-GetOut() );
+SwTaggedPDFHelper aTaggedPDFHelperNumbering( aNumInfo, 0, 0,
rRenderContext );
Frm_Info aFrmInfo( *this );
-SwTaggedPDFHelper aTaggedPDFHelperParagraph( 0, aFrmInfo, 0,
*pSh-GetOut() );
+SwTaggedPDFHelper aTaggedPDFHelperParagraph( 0, aFrmInfo, 0,
rRenderContext );
if( !IsEmpty() || !PaintEmpty( rRect, true ) )
{
commit 048ad22dba4ee9c62458a2d9560f9b7f24a43510
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Wed Jun 24 11:38:34 2015 +0200
sw: add SwViewShell::mbOutputToWindow
So that we can know if the output is a virtual device that will end up
on the screen (due to double buffering) or a real virtual device.
Change-Id: I1e8eeddfb19c374363b98786c26836e1f3236e7f
(cherry picked from commit f2c84d410cf6df3bb3725d2495e3b6b60b2cf17b)
diff --git a/sw/inc/viewsh.hxx b/sw/inc/viewsh.hxx
index 4bb296fc..5f7a9ce 100644
--- a/sw/inc/viewsh.hxx
+++ b/sw/inc/viewsh.hxx
@@ -199,6 +199,9 @@ protected:
bool mbInLibreOfficeKitCallback;
+/// The virtual device we paint to will end up on the screen.
+bool mbOutputToWindow;
+
public:
TYPEINFO();
@@ -587,6 +590,9 @@ public:
/// Are we doing tiled rendering?
bool isTiledRendering() const;
+void setOutputToWindow(bool bOutputToWindow);
+bool isOutputToWindow() const;
+
};
// manages global ShellPointer
diff --git a/sw/source/core/doc/notxtfrm.cxx b/sw/source/core/doc/notxtfrm.cxx
index 93dbef5..4cd00c5 100644
--- a/sw/source/core/doc/notxtfrm.cxx
+++ b/sw/source/core/doc/notxtfrm.cxx
@@ -935,7 +935,7 @@ void SwNoTextFrm::PaintPicture( vcl::RenderContext* pOut,
const SwRect rGrfArea
[Libreoffice-bugs] [Bug 92263] Inserting chart into table in Writer crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=92263 --- Comment #5 from Maxim Monastirsky momonas...@gmail.com --- Created attachment 116817 -- https://bugs.documentfoundation.org/attachment.cgi?id=116817action=edit dbgutil stacktrace to where it throws This is where it throws for me, because pUnoCrsr in null. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92322] New: Not changing a text field with MySQL
https://bugs.documentfoundation.org/show_bug.cgi?id=92322 Bug ID: 92322 Summary: Not changing a text field with MySQL Product: LibreOffice Version: 4.4.3.2 release Hardware: x86 (IA32) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: p...@realworks.fr System : Yosemite 10.10.3 Java : 1.6.0-65 MySQL Connector : 5.1.35 MySQL Database : no possible to change a field in TEXT format. But, no problem with fields in VARCHAR(n) format. Regards, PJG51 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sal/qa sal/rtl
sal/qa/rtl/strings/test_strings_replace.cxx | 12
sal/rtl/ustring.cxx |4 ++--
2 files changed, 14 insertions(+), 2 deletions(-)
New commits:
commit e36ca8d3c69d0c08ad28ceea278b05a0af81e102
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Jun 25 08:52:08 2015 +0200
Do not forget to actually set newStr to an empty string
(cherry picked from commit f7a7a9dd84d1cd8b49d59e1fb1853ea7e9f40edf)
Conflicts:
sal/qa/rtl/strings/test_strings_replace.cxx
sal/rtl/ustring.cxx
Change-Id: I745b09d8a248f08afdd3387f4cfcf69d71ec3c39
diff --git a/sal/qa/rtl/strings/test_strings_replace.cxx
b/sal/qa/rtl/strings/test_strings_replace.cxx
index 2065078..38c15e6 100644
--- a/sal/qa/rtl/strings/test_strings_replace.cxx
+++ b/sal/qa/rtl/strings/test_strings_replace.cxx
@@ -186,6 +186,9 @@ void Test::ustringReplaceFirstAsciiL() {
rtl::OUString(other), n)));
CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), n);
}
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceFirst(xa, OUString()));
}
void Test::ustringReplaceFirstAsciiLAsciiL() {
@@ -225,6 +228,9 @@ void Test::ustringReplaceFirstAsciiLAsciiL() {
replaceFirst(bar, other, n)));
CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), n);
}
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceFirst(xa, ));
}
void Test::ustringReplaceAll() {
@@ -265,6 +271,9 @@ void Test::ustringReplaceAllAsciiL() {
rtl::OUString(xaa).replaceAll(
xa,
rtl::OUString(xx)));
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceAll(xa, OUString()));
}
void Test::ustringReplaceAllAsciiLAsciiL() {
@@ -282,6 +291,9 @@ void Test::ustringReplaceAllAsciiLAsciiL() {
rtl::OUString(xxa),
(rtl::OUString(xaa).
replaceAll(xa, xx)));
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceAll(xa, ));
}
}
diff --git a/sal/rtl/ustring.cxx b/sal/rtl/ustring.cxx
index 3c9c8b7..940113d 100644
--- a/sal/rtl/ustring.cxx
+++ b/sal/rtl/ustring.cxx
@@ -1154,8 +1154,8 @@ void rtl_uString_newReplaceFirstAsciiL(
}
sal_Int32 n = str-length - fromLength + to-length;
rtl_uString_acquire(str); // in case *newStr == str
+rtl_uString_new_WithLength(newStr, n);
if (n != 0) {
-rtl_uString_new_WithLength(newStr, n);
(*newStr)-length = n;
assert(i = 0 i str-length);
memcpy(
@@ -1197,8 +1197,8 @@ void rtl_uString_newReplaceFirstAsciiLAsciiL(
}
sal_Int32 n = str-length - fromLength + toLength;
rtl_uString_acquire(str); // in case *newStr == str
+rtl_uString_new_WithLength(newStr, n);
if (n != 0) {
-rtl_uString_new_WithLength(newStr, n);
(*newStr)-length = n;
assert(i = 0 i str-length);
memcpy(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92219] Formula bar function wizard button should open the functions pane of sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92219 --- Comment #10 from Philippe Jung phil.j...@free.fr --- My point of view on this: 1) The distance (in term of mouse movement) between the toolbar button and the sidebar is longer than the distance between the toolbar button and the popup. When you will have to select cell ranges, your mouse will have to go to the sheet, back to the sidebar, back to the sheet, back to the sidebar... 2) When you are editing a formula, the use case is rather modal. You select a cell, edit the formula, press enter, go to next cell. You end the action when everything is completed, all parameters given with correct value. From my point of view, the sidebar is more oriented to single, atomic, asynchronous operations such as apply a style (you click, the operation is done). Here we have several consecutive operations: select a function, select parameters by hidding the dialog to select cell ranges and so on. What happens if only half of the parameters are ok when you change cell selection ? I believe the cinetic of the sidebar is not adequate. 3) From a need / use case point of view, my experience with the fx button (if we are really speaking of the fx button :-) ) : - I don't need a dialog box to do completion or pre-evaluation of the parameters - I would like inline completion of the formula in the formula bar, tooltips, syntax coloring - I click fx button when and only when I have no f**ing idea of the name of the function that does what I want to do. My (the?) real need is to type a keyword and get a list of functions that are related to this keyword. Exemple of keyword: regression, loan, average, prediction, total, month, trend -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92219] Formula bar function wizard button should open the functions pane of sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92219 --- Comment #10 from Philippe Jung phil.j...@free.fr --- My point of view on this: 1) The distance (in term of mouse movement) between the toolbar button and the sidebar is longer than the distance between the toolbar button and the popup. When you will have to select cell ranges, your mouse will have to go to the sheet, back to the sidebar, back to the sheet, back to the sidebar... 2) When you are editing a formula, the use case is rather modal. You select a cell, edit the formula, press enter, go to next cell. You end the action when everything is completed, all parameters given with correct value. From my point of view, the sidebar is more oriented to single, atomic, asynchronous operations such as apply a style (you click, the operation is done). Here we have several consecutive operations: select a function, select parameters by hidding the dialog to select cell ranges and so on. What happens if only half of the parameters are ok when you change cell selection ? I believe the cinetic of the sidebar is not adequate. 3) From a need / use case point of view, my experience with the fx button (if we are really speaking of the fx button :-) ) : - I don't need a dialog box to do completion or pre-evaluation of the parameters - I would like inline completion of the formula in the formula bar, tooltips, syntax coloring - I click fx button when and only when I have no f**ing idea of the name of the function that does what I want to do. My (the?) real need is to type a keyword and get a list of functions that are related to this keyword. Exemple of keyword: regression, loan, average, prediction, total, month, trend -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92150] spell checking does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92150 Jacques jacq...@steyn.pro changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #12 from Jacques jacq...@steyn.pro --- Thank you for replies. And thank you very much to the extreme to the volunteers building and fixing LO. I suspect something was changed between Version 4 and previous versions (which did not have the bug). BTW, V4 works fine on Linux and on Apple. I have also experienced problems porting other programs from older Windows versions to Win 7. That was due to the change in the path where user data is stored. This resulted in among other things that Thunderbird email user directories no longer work, as the paths do not match. I have not investigated this for LO - could this perhaps be a similar problem? jq -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92323] New: Libre Office from Collabora crashes when opening an odt-file
https://bugs.documentfoundation.org/show_bug.cgi?id=92323 Bug ID: 92323 Summary: Libre Office from Collabora crashes when opening an odt-file Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jobst.flasb...@gmx.de Libre Office from Collabora 4.3-6 crashes always when I want to open an odt-file that was produced with the simple Libre Office (Vanilla) program -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #7 from Jean-Baptiste Faure jbfa...@libreoffice.org --- (In reply to Adolfo Jayme from comment #6) I don’t know why the Sidebar allows to hide tabs/decks. It’s pointless functionality – it does not help reduce visual clutter, for example. IMHO Sidebar’s “Customization” menu should be killed. I agree, these customization settings are not saved when you close the current file. Best regards. JBF -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 Jean-Baptiste Faure jbfa...@libreoffice.org changed: What|Removed |Added CC||jbfa...@libreoffice.org --- Comment #7 from Jean-Baptiste Faure jbfa...@libreoffice.org --- (In reply to Adolfo Jayme from comment #6) I don’t know why the Sidebar allows to hide tabs/decks. It’s pointless functionality – it does not help reduce visual clutter, for example. IMHO Sidebar’s “Customization” menu should be killed. I agree, these customization settings are not saved when you close the current file. Best regards. JBF -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
Re: [Libreoffice-qa] Collabora LibreOffice Vanilla QA on OSX
Hi Alex, On Thu, Jun 25, 2015 at 9:20 AM, Alexander Thurgood alex.thurg...@gmail.com wrote: Le 23/06/2015 20:17, Andras Timar a écrit : Hi all, For the consequences of the build switches, as I understand them, see below : Generally, you can read configure.ac for the meaning of build switches. It would eliminate the guesswork. --disable-lpsolve This is the internal solver code We use coinmp instead. --disable-neon Not sure about this one, but possibly related to network file access ? We use serf instead. --disable-python This switch builds in python support. If it is not present, any and all python-dependent functionality will fail to work - that includes mailmerge, many of the wizards that were rewritten in python (e.g. Fax/Letter template wizards), UNO programming via python, Regarding Mailmerge, only the emailing script is in Python. --with-theme=tango Bit surprised not to see the Breeze icon theme here - any particular reason ? We plan to switch to Breeze. --without-java Any and all Java required functionality will not work - this includes a great deal of Base (embedded hsqldb, any and all JDBC driver functionality, Oracle ReportWriter) any and all Java user extensions that people might wish to install, and also some of the remaining wizards that are still written in Java One would hope that a suitably clear explanatory message is given when the user tries to activate any such call to instantiate the JVM, or that the app won't suddenly curl up and die. AFAIK there are no more Java Wizards in LO 4.3. Why would the app suddenly die without Java? It does not die. --without-myspell-dicts I'm not sure what the extent of the effect of this is. My understanding is that the hunspell/myspell dictionaries don't get built with this switch and that by default the Apple spelling correction is used instead ? Apple spell checking is used. --enable-ext-wiki-publisher --enable-report-builder --enable-ext-nlpsolver See above - with these switches on, the corresponding extensions are bundled - note that the report-builder extension requires Java, otherwise it will fail miserably to load and provoke an error message (or worse, the whole app will fail) When you build --without-java, these switches have no effect. --enable-symbols This is supposed to provide debugging symbols, although not quite sure how that works without --enable-dbgutil, maybe I have an incomplete understanding On the contrary, --enable-dbgutil cannot be used with --enable-symbols. Regards, Andras ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 92263] Inserting chart into table in Writer crashes LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=92263 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Component|Chart |Writer --- Comment #6 from Maxim Monastirsky momonas...@gmail.com --- And changing the component to Writer, as it seems to me a Writer bug, rather than Chart one. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44419] Allow entire column or entire row ranges in formulae, e.g. A:A or 1:1
https://bugs.documentfoundation.org/show_bug.cgi?id=44419 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 | target:5.1.0 |target:5.0.0.2 |target:5.0.0.2 target:4.4.5 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44419] Allow entire column or entire row ranges in formulae, e.g. A:A or 1:1
https://bugs.documentfoundation.org/show_bug.cgi?id=44419 --- Comment #19 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Eike Rathke committed a patch related to this issue. It has been pushed to libreoffice-4-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7ea962bd8f2e5303b7719add1f47bb79047b0739h=libreoffice-4-4 a singleton must be fully parsed to be valid, tdf#44419 related It will be available in 4.4.5. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/core/tool/address.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7ea962bd8f2e5303b7719add1f47bb79047b0739 Author: Eike Rathke er...@redhat.com Date: Thu Jun 25 20:06:47 2015 +0200 a singleton must be fully parsed to be valid, tdf#44419 related No trailing characters must be present in 1:1 or A:A full row/column references, e.g. 2:2,2 is not valid. The original cause is the lexical analyzer that accepted 2,2 as the second part after the range operator because ',' is also the group separator here, which needs further changes. Change-Id: Iff354469f7dcb4e0b6fa645c39cc1f8ebad4a6ea (cherry picked from commit c48af2b55a60492565b987ee65d98edc6bd94533) Reviewed-on: https://gerrit.libreoffice.org/16490 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index 06e49b7..cbae8d7 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -917,7 +917,7 @@ static sal_uInt16 lcl_ScRange_Parse_XL_A1( ScRange r, tmp1 = lcl_eatWhiteSpace( tmp1 ); tmp2 = lcl_a1_get_row( tmp1, r.aEnd, nFlags2 ); -if( !tmp2 ) +if( !tmp2 || *tmp2 != 0 ) // Must have fully parsed a singleton. return 0; r.aStart.SetCol( 0 ); r.aEnd.SetCol( MAXCOL ); @@ -940,7 +940,7 @@ static sal_uInt16 lcl_ScRange_Parse_XL_A1( ScRange r, tmp1 = lcl_eatWhiteSpace( tmp1 ); tmp2 = lcl_a1_get_col( tmp1, r.aEnd, nFlags2 ); -if( !tmp2 ) +if( !tmp2 || *tmp2 != 0 ) // Must have fully parsed a singleton. return 0; r.aStart.SetRow( 0 ); r.aEnd.SetRow( MAXROW ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92323] Libre Office from Collabora crashes when opening an odt-file
https://bugs.documentfoundation.org/show_bug.cgi?id=92323 --- Comment #3 from Adolfo Jayme f...@libreoffice.org --- Created attachment 116835 -- https://bugs.documentfoundation.org/attachment.cgi?id=116835action=edit This file was sent to me by e-mail -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/breeze
icon-themes/breeze/cmd/lc_drawtext.png|binary icon-themes/breeze/cmd/lc_text.png|binary icon-themes/breeze/cmd/lc_texttoolbox.png |binary 3 files changed New commits: commit 34c006c9a4346bb04fa47fb7dbf008710cdc117a Author: andreask kain...@gmail.com Date: Thu Jun 25 01:31:49 2015 +0200 Breeze: Textbox - It would be good for the top to be closed Change-Id: Iab7a6314017fabc609b17485182dc237ee8afe18 Reviewed-on: https://gerrit.libreoffice.org/16462 Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com Tested-by: Adolfo Jayme Barrientos fit...@ubuntu.com diff --git a/icon-themes/breeze/cmd/lc_drawtext.png b/icon-themes/breeze/cmd/lc_drawtext.png index c0e35c2..b385900 100644 Binary files a/icon-themes/breeze/cmd/lc_drawtext.png and b/icon-themes/breeze/cmd/lc_drawtext.png differ diff --git a/icon-themes/breeze/cmd/lc_text.png b/icon-themes/breeze/cmd/lc_text.png index c0e35c2..b385900 100644 Binary files a/icon-themes/breeze/cmd/lc_text.png and b/icon-themes/breeze/cmd/lc_text.png differ diff --git a/icon-themes/breeze/cmd/lc_texttoolbox.png b/icon-themes/breeze/cmd/lc_texttoolbox.png index c0e35c2..b385900 100644 Binary files a/icon-themes/breeze/cmd/lc_texttoolbox.png and b/icon-themes/breeze/cmd/lc_texttoolbox.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/breeze
icon-themes/breeze/cmd/lc_changecasetolower.png |binary icon-themes/breeze/cmd/lc_changecasetoupper.png |binary icon-themes/breeze/cmd/sc_changecasetolower.png |binary icon-themes/breeze/cmd/sc_changecasetoupper.png |binary 4 files changed New commits: commit 3b1cb077a58c325e5a790f7c6a248a7dc150496b Author: andreask kain...@gmail.com Date: Thu Jun 25 02:07:25 2015 +0200 Breeze: Uppercase and Lowercase adaption Uppercase - âAâ doesnt look capital (lc_ChangeCaseToUpper) Lowercase - âAâ should be lowercase (lc_ChangeCaseToLower) Change-Id: I62befa0205f773a505dad577ad3fc34ac6c1c53a Reviewed-on: https://gerrit.libreoffice.org/16464 Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com Tested-by: Adolfo Jayme Barrientos fit...@ubuntu.com diff --git a/icon-themes/breeze/cmd/lc_changecasetolower.png b/icon-themes/breeze/cmd/lc_changecasetolower.png index 8cb20b9..11cec79 100644 Binary files a/icon-themes/breeze/cmd/lc_changecasetolower.png and b/icon-themes/breeze/cmd/lc_changecasetolower.png differ diff --git a/icon-themes/breeze/cmd/lc_changecasetoupper.png b/icon-themes/breeze/cmd/lc_changecasetoupper.png index ddefbd2..a09bdd4 100644 Binary files a/icon-themes/breeze/cmd/lc_changecasetoupper.png and b/icon-themes/breeze/cmd/lc_changecasetoupper.png differ diff --git a/icon-themes/breeze/cmd/sc_changecasetolower.png b/icon-themes/breeze/cmd/sc_changecasetolower.png index 152605b..db698d0 100644 Binary files a/icon-themes/breeze/cmd/sc_changecasetolower.png and b/icon-themes/breeze/cmd/sc_changecasetolower.png differ diff --git a/icon-themes/breeze/cmd/sc_changecasetoupper.png b/icon-themes/breeze/cmd/sc_changecasetoupper.png index 18538fc..847b5bf 100644 Binary files a/icon-themes/breeze/cmd/sc_changecasetoupper.png and b/icon-themes/breeze/cmd/sc_changecasetoupper.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92269] 5.0.0.1 Win 64 Explorer Crash after single click on any LO file in folder. (shlxthdl.dll / propertyhdl.dll property handler problem?)
https://bugs.documentfoundation.org/show_bug.cgi?id=92269 --- Comment #11 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Thorsten Behrens from comment #10) (In reply to Robinson Tryon (qubit) from comment #9) CONFIRMED on Win8.1 + LO 5.0.0.1 (x64) This is possibly fixed (on master and libreoffice-5-0 branch), any chance to re-test with a daily libreoffice-5-0 build? Yep -- I'm eager to test, but 5.0 RC1 came out on June 22nd, and I don't believe there are any newer 5-0 daily builds: Latest x86-64: Jun 22nd http://dev-builds.libreoffice.org/daily/libreoffice-5-0/Win-x86_64@62-TDF/ Latest x86: Jun 17th http://dev-builds.libreoffice.org/daily/libreoffice-5-0/Win-x86@62-merge-TDF/ I know that TB62 wears multiple hats, so it may have been too busy to produce new 5-0 builds. I'll check with cloph. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92293] Accessibility completely broken with gtk3 plugin
https://bugs.documentfoundation.org/show_bug.cgi?id=92293 --- Comment #6 from Caolán McNamara caol...@redhat.com --- probably somehow need to adapt to https://mail.gnome.org/archives/commits-list/2011-July/msg03824.html -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: icon-themes/breeze
icon-themes/breeze/cmd/lc_addprintarea.png |binary icon-themes/breeze/cmd/lc_addtable.png |binary icon-themes/breeze/cmd/lc_bezierinsert.png |binary icon-themes/breeze/cmd/lc_config.png|binary icon-themes/breeze/cmd/lc_dbnewform.png |binary icon-themes/breeze/cmd/lc_dbnewquery.png|binary icon-themes/breeze/cmd/lc_dbnewreport.png |binary icon-themes/breeze/cmd/lc_dbnewtable.png|binary icon-themes/breeze/cmd/lc_draw.png |binary icon-themes/breeze/cmd/lc_drawchart.png |binary icon-themes/breeze/cmd/lc_edithyperlink.png |binary icon-themes/breeze/cmd/lc_hyperlinkdialog.png |binary icon-themes/breeze/cmd/lc_inscellsctrl.png |binary icon-themes/breeze/cmd/lc_insertctrl.png|binary icon-themes/breeze/cmd/lc_insertdraw.png|binary icon-themes/breeze/cmd/lc_insertgraphic.png |binary icon-themes/breeze/cmd/lc_inserthyperlink.png |binary icon-themes/breeze/cmd/lc_insertmath.png|binary icon-themes/breeze/cmd/lc_insertobjectchart.png |binary icon-themes/breeze/cmd/lc_insertpage.png|binary icon-themes/breeze/cmd/lc_inserttable.png |binary icon-themes/breeze/cmd/lc_morecontrols.png |binary icon-themes/breeze/cmd/lc_newdoc.png|binary icon-themes/breeze/cmd/lc_objectcatalog.png |binary icon-themes/breeze/cmd/lc_verticaltext.png |binary icon-themes/breeze/cmd/sc_config.png|binary icon-themes/breeze/cmd/sc_dbnewform.png |binary icon-themes/breeze/cmd/sc_dbnewquery.png|binary icon-themes/breeze/cmd/sc_dbnewreport.png |binary icon-themes/breeze/cmd/sc_edithyperlink.png |binary icon-themes/breeze/cmd/sc_hyperlinkdialog.png |binary icon-themes/breeze/cmd/sc_inserthyperlink.png |binary icon-themes/breeze/cmd/sc_insertpage.png|binary icon-themes/breeze/cmd/sc_morecontrols.png |binary icon-themes/breeze/cmd/sc_objectcatalog.png |binary 35 files changed New commits: commit 4df981b954da0c02236fdbedf3c37ea36b180cdc Author: andreask kain...@gmail.com Date: Thu Jun 25 01:03:59 2015 +0200 Breeze: insert should be according to the Guidelines in blue Change-Id: I847c0679ec7a9fed49de52da7d3cd4d8b53fe07a Reviewed-on: https://gerrit.libreoffice.org/16461 Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com Tested-by: Adolfo Jayme Barrientos fit...@ubuntu.com diff --git a/icon-themes/breeze/cmd/lc_addprintarea.png b/icon-themes/breeze/cmd/lc_addprintarea.png index cc680ff..a761d0e 100644 Binary files a/icon-themes/breeze/cmd/lc_addprintarea.png and b/icon-themes/breeze/cmd/lc_addprintarea.png differ diff --git a/icon-themes/breeze/cmd/lc_addtable.png b/icon-themes/breeze/cmd/lc_addtable.png index cc680ff..a761d0e 100644 Binary files a/icon-themes/breeze/cmd/lc_addtable.png and b/icon-themes/breeze/cmd/lc_addtable.png differ diff --git a/icon-themes/breeze/cmd/lc_bezierinsert.png b/icon-themes/breeze/cmd/lc_bezierinsert.png index d174553..9e9ed9f 100644 Binary files a/icon-themes/breeze/cmd/lc_bezierinsert.png and b/icon-themes/breeze/cmd/lc_bezierinsert.png differ diff --git a/icon-themes/breeze/cmd/lc_config.png b/icon-themes/breeze/cmd/lc_config.png index d6977e6..354e45e 100644 Binary files a/icon-themes/breeze/cmd/lc_config.png and b/icon-themes/breeze/cmd/lc_config.png differ diff --git a/icon-themes/breeze/cmd/lc_dbnewform.png b/icon-themes/breeze/cmd/lc_dbnewform.png index be88ce0..bfe5ef2 100644 Binary files a/icon-themes/breeze/cmd/lc_dbnewform.png and b/icon-themes/breeze/cmd/lc_dbnewform.png differ diff --git a/icon-themes/breeze/cmd/lc_dbnewquery.png b/icon-themes/breeze/cmd/lc_dbnewquery.png index af22b4c..dfbb1a2 100644 Binary files a/icon-themes/breeze/cmd/lc_dbnewquery.png and b/icon-themes/breeze/cmd/lc_dbnewquery.png differ diff --git a/icon-themes/breeze/cmd/lc_dbnewreport.png b/icon-themes/breeze/cmd/lc_dbnewreport.png index fb2fda4..592d8c8 100644 Binary files a/icon-themes/breeze/cmd/lc_dbnewreport.png and b/icon-themes/breeze/cmd/lc_dbnewreport.png differ diff --git a/icon-themes/breeze/cmd/lc_dbnewtable.png b/icon-themes/breeze/cmd/lc_dbnewtable.png index cc680ff..a761d0e 100644 Binary files a/icon-themes/breeze/cmd/lc_dbnewtable.png and b/icon-themes/breeze/cmd/lc_dbnewtable.png differ diff --git a/icon-themes/breeze/cmd/lc_draw.png b/icon-themes/breeze/cmd/lc_draw.png index 24f978e..4002e97 100644 Binary files a/icon-themes/breeze/cmd/lc_draw.png and b/icon-themes/breeze/cmd/lc_draw.png differ diff --git a/icon-themes/breeze/cmd/lc_drawchart.png b/icon-themes/breeze/cmd/lc_drawchart.png index 54433f4..07b01f6 100644 Binary files a/icon-themes/breeze/cmd/lc_drawchart.png and b/icon-themes/breeze/cmd/lc_drawchart.png differ diff --git a/icon-themes/breeze/cmd/lc_edithyperlink.png b/icon-themes/breeze/cmd/lc_edithyperlink.png index dfe9a2b..c2ce815 100644 Binary files a/icon-themes/breeze/cmd/lc_edithyperlink.png and
[Libreoffice-bugs] [Bug 92341] add AutoCorrect Options... to right click spell checking menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92341 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||philip...@hotmail.com Component|UI |ux-advise -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/compiler.cxx | 12
1 file changed, 12 insertions(+)
New commits:
commit 71dba79c1c84d693a59c53a8965caef0ddd1c2cc
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 22:54:37 2015 +0200
tdf#44419 in second reference part stop number parsing at separator
Change-Id: I70218bc41df0d56ab42d652aa7ac51733dc06f4b
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 3594f0e..9d0a03a 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2483,6 +2483,18 @@ Label_MaskStateMachine:
}
else
{
+// When having parsed a second reference part, ensure that the
+// i18n parser did not mistakingly parse a number that included
+// a separator which happened to be meant as a parameter
+// separator instead.
+if (mnRangeOpPosInSymbol = 0 (aRes.TokenType
KParseType::ASC_NUMBER))
+{
+for (sal_Int32 i = nSrcPos; i aRes.EndPos; ++i)
+{
+if (pStart[i] == cSep)
+aRes.EndPos = i;// also ends for
+}
+}
aSymbol.append( pStart + nSrcPos, aRes.EndPos - nSrcPos);
nSrcPos = aRes.EndPos;
c = pStart[nSrcPos];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92341] New: add AutoCorrect Options... to right click spell checking menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92341 Bug ID: 92341 Summary: add AutoCorrect Options... to right click spell checking menu Product: LibreOffice Version: Inherited From OOo Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ba...@quipo.it Created attachment 116836 -- https://bugs.documentfoundation.org/attachment.cgi?id=116836action=edit screenshot see my screenshot... it describes the situation when you type a misspelled word which is identified as an error by the spell checking engine and you right click on it to get autocorrect suggestions. in the case the misspelled word is auematnate instead of aumentate but as you may see the autocorrect suggestions that LibO provides two non matching items like emanate and anatema. if you wanna set the desired auematnate -- aumentate autocorrect replacement you have to exit the right click menu then go to the toolbar and click Tools/AutoCorrect Options... to open the autocorrect replacement table what I propose it to add an AutoCorrect Option... item in the right click spell checking menu show in the screenshot, under the Always Correct to submenu just below the autocorrect suggestions along with a line separator... I mean something like this: Always correct to emanate anatema -- AutoCorrect Options... this way when there are no satisfying autocorrect suggestion you are already able to open the autocorrect replacement table without going back to the toolbar IMHO it would be a time saver -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92341] add AutoCorrect Options... to right click spell checking menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92341 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it, ||libreoffice-ux-advise@lists ||.freedesktop.org, ||philip...@hotmail.com Component|UI |ux-advise -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92339] Regression when placing the cursor after opening the Find dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=92339 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #1 from tommy27 ba...@quipo.it --- maybe Linux specific issue since I don't reproduce it under Win8.1x64 using a recent LibO 5.1.0.0 alpha daily build -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92341] add AutoCorrect Options... to right click spell checking menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92341 --- Comment #3 from tommy27 ba...@quipo.it --- (In reply to Yousuf (Jay) Philips from comment #2) Hey tommy, If the 'Always Correct to' submenu is related to AutoCorrect, then adding an 'AutoCorrect Options...' as the last entry after a separator would be a suitable thing to do. But i seem to be confused here, as i would assume that correcting a mispelt word should be dictionary related and not autocorrect related. IMHO there's no confusion... misspelled words are related to autocorrection... correct words are instead related to dictionary... as you may see there's a Add to dictionary item just before Always correct to this is needed when you wanna add to dictionary a word that the spellchecker underlines with those squiggly red lines just because it doesn't see it in the dictionary. so the workflow is: - right click on word with red squiggly line - hit add to dictionary if the word is correct - hit the always correct to item if the word is mispelled and accept one of the autocorrect suggestions - my request is to have autocorrect options just below the last suggestion in the case none of them is the desired one On a separate noted, I think changing 'Always Correct to' to 'AutoCorrect to', 'Auto Correct to', or 'Automatically Correct to' would be good, so users looking through the menu would remember seeing that word combination elsewhere. the Always Correct to item has been called that way since OOo era and user already know and remember what is supposed to do. so I don't think this is necessary to rename and have another string change to annoy the translators -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92341] add AutoCorrect Options... to right click spell checking menu
https://bugs.documentfoundation.org/show_bug.cgi?id=92341 --- Comment #3 from tommy27 ba...@quipo.it --- (In reply to Yousuf (Jay) Philips from comment #2) Hey tommy, If the 'Always Correct to' submenu is related to AutoCorrect, then adding an 'AutoCorrect Options...' as the last entry after a separator would be a suitable thing to do. But i seem to be confused here, as i would assume that correcting a mispelt word should be dictionary related and not autocorrect related. IMHO there's no confusion... misspelled words are related to autocorrection... correct words are instead related to dictionary... as you may see there's a Add to dictionary item just before Always correct to this is needed when you wanna add to dictionary a word that the spellchecker underlines with those squiggly red lines just because it doesn't see it in the dictionary. so the workflow is: - right click on word with red squiggly line - hit add to dictionary if the word is correct - hit the always correct to item if the word is mispelled and accept one of the autocorrect suggestions - my request is to have autocorrect options just below the last suggestion in the case none of them is the desired one On a separate noted, I think changing 'Always Correct to' to 'AutoCorrect to', 'Auto Correct to', or 'Automatically Correct to' would be good, so users looking through the menu would remember seeing that word combination elsewhere. the Always Correct to item has been called that way since OOo era and user already know and remember what is supposed to do. so I don't think this is necessary to rename and have another string change to annoy the translators -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92332] SIDEBAR: Customizing the sidebar tabs isn't saved between sessions
https://bugs.documentfoundation.org/show_bug.cgi?id=92332 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Summary|SIDEBAR: Customizing the|SIDEBAR: Customizing the |sidebar tabs isnt saved |sidebar tabs isn't saved |between sessions|between sessions Ever confirmed|0 |1 --- Comment #3 from tommy27 ba...@quipo.it --- confirmed under Win8.1 x64 using LibO 5.1.0.0.alpha1+ Build ID: df7595a5f5871f8343e4ee3869ad153e3ae4a7f3 TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-25_14:29:31 Locale: en-US (it_IT) I agree with Jay... a custom layout per document is non-sense. you should be able to customize the sidebar exactly like other toolbars with permanent changes -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92332] SIDEBAR: Customizing the sidebar tabs isn't saved between sessions
https://bugs.documentfoundation.org/show_bug.cgi?id=92332 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it Summary|SIDEBAR: Customizing the|SIDEBAR: Customizing the |sidebar tabs isnt saved |sidebar tabs isn't saved |between sessions|between sessions Ever confirmed|0 |1 --- Comment #3 from tommy27 ba...@quipo.it --- confirmed under Win8.1 x64 using LibO 5.1.0.0.alpha1+ Build ID: df7595a5f5871f8343e4ee3869ad153e3ae4a7f3 TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-06-25_14:29:31 Locale: en-US (it_IT) I agree with Jay... a custom layout per document is non-sense. you should be able to customize the sidebar exactly like other toolbars with permanent changes -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91361] LibreOffice stopped working XLSX to PDF conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=91361 --- Comment #7 from Martijn m.gr...@globalgassolutions.com --- Yes, also did that. No luck -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - svtools/source
svtools/source/dialogs/PlaceEditDialog.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 842e5d46f1d80c2c83164ff871bca1c325cf6bef Author: Szymon KÅos eszka...@gmail.com Date: Thu Jun 25 12:54:23 2015 +0200 PlaceEditDialog: Encode username Change-Id: Iaedb63df57196ee291f29976f611075289a5255a diff --git a/svtools/source/dialogs/PlaceEditDialog.cxx b/svtools/source/dialogs/PlaceEditDialog.cxx index 26a7e8a..bbc1f43 100644 --- a/svtools/source/dialogs/PlaceEditDialog.cxx +++ b/svtools/source/dialogs/PlaceEditDialog.cxx @@ -79,7 +79,8 @@ PlaceEditDialog::PlaceEditDialog(vcl::Window* pParent, const std::shared_ptrPla // Fill the Username field if ( rUrl.HasUserData( ) ) -m_pEDUsername-SetText( rUrl.GetUser( ) ); +m_pEDUsername-SetText( INetURLObject::decode( rUrl.GetUser( ), + INetURLObject::DECODE_WITH_CHARSET ) ); } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92327] UI: in Draw dialogue 3-D effects are not heading
https://bugs.documentfoundation.org/show_bug.cgi?id=92327 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- Thanks for reporting. Fortunately it's already fixed. *** This bug has been marked as a duplicate of bug 91380 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92310] FILESAVE: [sample] Exporting from OpenDocument to .docx (Office Open XML) adds the character 1 to some headers by turning them into numbered lists
https://bugs.documentfoundation.org/show_bug.cgi?id=92310 Terrence Enger lo_b...@iseries-guru.com changed: What|Removed |Added CC||lo_b...@iseries-guru.com Version|4.4.3.2 release |4.4.0.2 rc --- Comment #2 from Terrence Enger lo_b...@iseries-guru.com --- Thank you for helping us to improve LibreOffice. I see the problem in LibreOffice version 4.4.0.2, so am setting version field accordingly. However, the problem is absent in both 5.0.0.0.beta3 and dbgutil bibisect version 2015-06-25, so am setting status RESOLVED WORKSFORME. Jean-François, when you have a new version of LibreOffice and you see the problem fixed, please advance the bug status to VERIFIED. Thanks, Terry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92323] Libre Office from Collabora crashes when opening an odt-file
https://bugs.documentfoundation.org/show_bug.cgi?id=92323 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||f...@libreoffice.org, ||tima...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Adolfo Jayme f...@libreoffice.org --- Thank you for submitting your report and helping to improve LibreOffice. Can you attach the problematic document to this report? That will help us to replicate the issue. (Note that attachments are public – if applicable, please anonymize it: https://wiki.documentfoundation.org/QA/BugReport/Attachments) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - loleaflet/src
loleaflet/src/layer/tile/TileLayer.js | 235 +-
loleaflet/src/map/Map.js |2
2 files changed, 119 insertions(+), 118 deletions(-)
New commits:
commit 64f6e5647d779e1d51610538aaa24df7521f215e
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Jun 25 15:16:14 2015 +0300
Fixed eslint errors in TileLayer.js
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 1a756ee..b62d1b9 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -5,10 +5,10 @@
// Implement String::startsWith which is non-portable (Firefox only, it seems)
// See
http://stackoverflow.com/questions/646628/how-to-check-if-a-string-startswith-another-string#4579228
-if (typeof String.prototype.startsWith != 'function') {
- String.prototype.startsWith = function (str){
-return this.slice(0, str.length) == str;
- };
+if (typeof String.prototype.startsWith !== 'function') {
+ String.prototype.startsWith = function (str) {
+ return this.slice(0, str.length) === str;
+ };
}
L.TileLayer = L.GridLayer.extend({
@@ -120,24 +120,24 @@ L.TileLayer = L.GridLayer.extend({
// View or edit mode.
this._bEdit = false;
// Position and size of the visible cursor.
- this._aVisibleCursor = new L.LatLngBounds( new L.LatLng(0, 0),
new L.LatLng(0, 0) );
+ this._aVisibleCursor = new L.LatLngBounds(new L.LatLng(0, 0),
new L.LatLng(0, 0));
// Cursor overlay is visible or hidden (for blinking).
this._bCursorOverlayVisible = false;
// Cursor is visible or hidden (e.g. for graphic selection).
this._bCursorVisible = true;
// Rectangle graphic selection
- this._aGraphicSelection = new L.LatLngBounds( new L.LatLng(0,
0), new L.LatLng(0, 0) );
+ this._aGraphicSelection = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
// Position and size of the selection start (as if there would
be a cursor caret there).
- this._aTextSelectionStart = new L.LatLngBounds( new L.LatLng(0,
0), new L.LatLng(0, 0) );
+ this._aTextSelectionStart = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
// Position and size of the selection end.
- this._aTextSelectionEnd = new L.LatLngBounds( new L.LatLng(0,
0), new L.LatLng(0, 0) );
+ this._aTextSelectionEnd = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
// Cursor marker
this._cursorMarker = null;
// Graphic marker
this._graphicMarker = null;
// Handle start marker
- this._startMarker = L.marker( new L.LatLng(0,0), {
+ this._startMarker = L.marker(new L.LatLng(0, 0), {
icon: L.icon({
iconUrl: L.Icon.Default.imagePath +
'/handle_start.png',
iconSize: [30, 44],
@@ -146,7 +146,7 @@ L.TileLayer = L.GridLayer.extend({
draggable: true
});
// Handle end marker
- this._endMarker = L.marker( new L.LatLng(0,0), {
+ this._endMarker = L.marker(new L.LatLng(0, 0), {
icon: L.icon({
iconUrl: L.Icon.Default.imagePath +
'/handle_end.png',
iconSize: [30, 44],
@@ -245,12 +245,12 @@ L.TileLayer = L.GridLayer.extend({
if (textMsg.startsWith('cursorvisible:')) {
var command = textMsg.match('cursorvisible: true');
- this._bCursorVisible = command == undefined ? false :
true;
+ this._bCursorVisible = command === undefined ? false :
true;
this._bCursorOverlayVisible = true;
this._onUpdateCursor();
}
else if (textMsg.startsWith('invalidatecursor:')) {
- strTwips = textMsg.match(/\d+/g);
+ var strTwips = textMsg.match(/\d+/g);
var topLeftTwips = new L.Point(parseInt(strTwips[0]),
parseInt(strTwips[1]));
var offset = new L.Point(parseInt(strTwips[2]),
parseInt(strTwips[3]));
var bottomRightTwips = topLeftTwips.add(offset);
@@ -263,38 +263,40 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('textselectionstart:')) {
strTwips = textMsg.match(/\d+/g);
if (strTwips != null) {
- var topLeftTwips = new
L.Point(parseInt(strTwips[0]), parseInt(strTwips[1]));
- var offset = new
[Libreoffice-commits] core.git: 8 commits - sw/source
sw/source/core/crsr/crsrsh.cxx |4 +--
sw/source/core/draw/dpage.cxx|2 -
sw/source/core/frmedt/fews.cxx |2 -
sw/source/core/inc/layact.hxx|4 +--
sw/source/core/inc/pagefrm.hxx |4 ++-
sw/source/core/inc/viewimp.hxx | 20 ++
sw/source/core/layout/anchoreddrawobject.cxx |4 +--
sw/source/core/layout/layact.cxx | 23 ++--
sw/source/core/layout/pagechg.cxx|4 +--
sw/source/core/layout/paintfrm.cxx | 30 +--
sw/source/core/unocore/unoflatpara.cxx |2 -
sw/source/core/view/pagepreviewlayout.cxx|2 -
sw/source/core/view/viewimp.cxx | 22 ---
sw/source/core/view/viewsh.cxx | 18
sw/source/core/view/vprint.cxx |2 -
sw/source/uibase/docvw/PageBreakWin.cxx |2 -
16 files changed, 74 insertions(+), 71 deletions(-)
New commits:
commit 08b3b6ed6c4d8599c9bb75719974c710462f2764
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Jun 25 14:13:44 2015 +0200
SwLayAction::Action: use vcl::RenderContext
Change-Id: I4fb6c42da0c5defa1d5da4cf6f3a13d11388c88d
diff --git a/sw/source/core/inc/layact.hxx b/sw/source/core/inc/layact.hxx
index e85ff36..53e3c25 100644
--- a/sw/source/core/inc/layact.hxx
+++ b/sw/source/core/inc/layact.hxx
@@ -154,7 +154,7 @@ public:
inline void SetCheckPageNum( sal_uInt16 nNew );
inline void SetCheckPageNumDirect( sal_uInt16 nNew ) { nCheckPageNum =
nNew; }
-void Action(); // here it begins
+void Action(OutputDevice* pRenderContext); // here it begins
void Reset(); // back to CTor-defaults
bool IsAgain() const { return bAgain; }
diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index f140b71..af2dcdc 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -341,7 +341,7 @@ bool SwLayAction::RemoveEmptyBrowserPages()
return bRet;
}
-void SwLayAction::Action()
+void SwLayAction::Action(OutputDevice* pRenderContext)
{
bActionInProgress = true;
@@ -366,12 +366,12 @@ void SwLayAction::Action()
if ( IsCalcLayout() )
SetCheckPages( false );
-InternalAction(pImp-GetShell()-GetOut());
+InternalAction(pRenderContext);
bAgain |= RemoveEmptyBrowserPages();
while ( IsAgain() )
{
bAgain = bNextCycle = false;
-InternalAction(pImp-GetShell()-GetOut());
+InternalAction(pRenderContext);
bAgain |= RemoveEmptyBrowserPages();
}
pRoot-DeleteEmptySct();
@@ -2166,7 +2166,7 @@ SwLayIdle::SwLayIdle( SwRootFrm *pRt, SwViewShellImp *pI
) :
aAction.SetInputType( VCL_INPUT_ANY );
aAction.SetIdle( true );
aAction.SetWaitAllowed( false );
-aAction.Action();
+aAction.Action(pImp-GetShell()-GetOut());
bInterrupt = aAction.IsInterrupt();
}
diff --git a/sw/source/core/layout/paintfrm.cxx
b/sw/source/core/layout/paintfrm.cxx
index 6587b90..017389b 100644
--- a/sw/source/core/layout/paintfrm.cxx
+++ b/sw/source/core/layout/paintfrm.cxx
@@ -3237,7 +3237,7 @@ void SwRootFrm::Paint(vcl::RenderContext rRenderContext,
SwRect const rRect, S
aAction.SetPaint( false );
aAction.SetComplete( false );
aAction.SetReschedule( gProp.pSProgress != nullptr );
-aAction.Action();
+aAction.Action(rRenderContext);
ResetTurboFlag();
if ( !pSh-ActionPend() )
pSh-Imp()-DelRegion();
diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx
index c9ad763..4ace932 100644
--- a/sw/source/core/view/viewsh.cxx
+++ b/sw/source/core/view/viewsh.cxx
@@ -283,7 +283,7 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd )
if ( mnLockPaint )
aAction.SetPaint( false );
aAction.SetInputType( VclInputFlags::KEYBOARD );
-aAction.Action();
+aAction.Action(GetWin());
}
if ( bIsShellForCheckViewLayout )
@@ -948,7 +948,7 @@ void SwViewShell::CalcLayout()
aAction.SetCalcLayout( true );
aAction.SetReschedule( true );
GetDoc()-getIDocumentFieldsAccess().LockExpFields();
-aAction.Action();
+aAction.Action(GetOut());
GetDoc()-getIDocumentFieldsAccess().UnlockExpFields();
//the SetNewFieldLst() on the Doc was cut off and must be fetched again
@@ -964,7 +964,7 @@ void SwViewShell::CalcLayout()
GetDoc()-getIDocumentFieldsAccess().UpdatePageFields( aMsgHint );
GetDoc()-getIDocumentFieldsAccess().UpdateExpFields(NULL, true);
-aAction.Action();
+aAction.Action(GetOut());
}
if ( VisArea().HasArea() )
@@ -1596,7 +1596,7 @@ bool SwViewShell::CheckInvalidForPaint( const SwRect
rRect )
// can't format frames which are locked by
[Libreoffice-bugs] [Bug 91959] Impossible to do paragraph breaks in table cell with vertical text applied through character rotation
https://bugs.documentfoundation.org/show_bug.cgi?id=91959 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW Component|LibreOffice |Writer Summary|The transition to a new |Impossible to do paragraph |line in the table cell must |breaks in table cell with |be the same in Calc and |vertical text applied |Writer |through character rotation Ever confirmed|0 |1 Severity|enhancement |minor --- Comment #5 from Beluga todven...@suomi24.fi --- Ok, rotation through character paragraph styles/formatting only accepts line breaks (shift-enter), but not paragraph breaks (enter). Table properties - Text flow rotation does not have this problem. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91361] LibreOffice stopped working XLSX to PDF conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=91361 --- Comment #8 from Martijn m.gr...@globalgassolutions.com --- Again same error Faulting application name: soffice.bin; version: 4.4.3.2; time stamp: 0x55406b60Faulting module name: KERNELBASE.dll; version: 6.1.7601.18409; time stamp: 0x53159a86Exception code: 0xe06d7363Fault offset: 0xc42dFaulting process id: 0x1a3cFaulting application start time: 0x01d0ae7570f9eba1Faulting application path: D:\Program Files (x86)\LibreOffice 4\program\soffice.binFaulting module path: C:\windows\syswow64\KERNELBASE.dllReport Id: b065a1d6-1a68-11e5-b8c8-6805ca2a1c34 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: oox/source sax/source sd/qa
oox/source/core/xmlfilterbase.cxx|6 --
sax/source/fastparser/fastparser.cxx |6 ++
sd/qa/unit/data/pptx/tdf91378.pptx |binary
sd/qa/unit/export-tests.cxx | 22 ++
4 files changed, 24 insertions(+), 10 deletions(-)
New commits:
commit 16e8ffbd5ec1fe7b81835ea6584547669d55d751
Author: Heena Gupta heena.h.gu...@ericsson.com
Date: Fri May 29 16:42:34 2015 +0530
tdf#91378-Empty Custom Properties are lost while saving in .pptx format
Conflicts:
sd/qa/unit/export-tests.cxx
Reviewed on:
https://gerrit.libreoffice.org/15966
Change-Id: Ibc24ab9633b51fe41ad483121646cc391319fe6f
diff --git a/oox/source/core/xmlfilterbase.cxx
b/oox/source/core/xmlfilterbase.cxx
index 4ef16d0..f1c80df 100644
--- a/oox/source/core/xmlfilterbase.cxx
+++ b/oox/source/core/xmlfilterbase.cxx
@@ -539,8 +539,6 @@ OUString XmlFilterBase::addRelation( const Reference
XOutputStream rOutputSt
static void
writeElement( FSHelperPtr pDoc, sal_Int32 nXmlElement, const OUString sValue )
{
-if( sValue.isEmpty() )
-return;
pDoc-startElement( nXmlElement, FSEND );
pDoc-writeEscaped( sValue );
pDoc-endElement( nXmlElement );
@@ -745,10 +743,6 @@ writeCustomProperties( XmlFilterBase rSelf, Reference
XDocumentProperties xP
{
if ( !aprop[n].Name.isEmpty() )
{
-// Ignore empty string property as well.
-if (aprop[n].Value.hasOUString()
aprop[n].Value.getOUString().isEmpty())
-continue;
-
OString aName = OUStringToOString( aprop[n].Name,
RTL_TEXTENCODING_ASCII_US );
// pid starts from 2 not from 1 as MS supports pid from 2
pAppProps-startElement( XML_property ,
diff --git a/sax/source/fastparser/fastparser.cxx
b/sax/source/fastparser/fastparser.cxx
index f118a5d..79ab899 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -1037,8 +1037,7 @@ void FastSaxParserImpl::parse()
void FastSaxParserImpl::callbackStartElement(const xmlChar *localName , const
xmlChar* prefix, const xmlChar* URI,
int numNamespaces, const xmlChar** namespaces, int numAttributes, int
/*defaultedAttributes*/, const xmlChar **attributes)
{
-if( !pendingCharacters.isEmpty())
-sendPendingCharacters();
+sendPendingCharacters();
Entity rEntity = getEntity();
if( rEntity.maNamespaceCount.empty() )
{
@@ -1145,8 +1144,7 @@ void FastSaxParserImpl::callbackStartElement(const
xmlChar *localName , const xm
void FastSaxParserImpl::callbackEndElement( const xmlChar*, const xmlChar*,
const xmlChar* )
{
-if( !pendingCharacters.isEmpty())
-sendPendingCharacters();
+sendPendingCharacters();
Entity rEntity = getEntity();
SAL_WARN_IF(rEntity.maNamespaceCount.empty(), sax, Empty
NamespaceCount);
if( !rEntity.maNamespaceCount.empty() )
diff --git a/sd/qa/unit/data/pptx/tdf91378.pptx
b/sd/qa/unit/data/pptx/tdf91378.pptx
new file mode 100644
index 000..361be2c
Binary files /dev/null and b/sd/qa/unit/data/pptx/tdf91378.pptx differ
diff --git a/sd/qa/unit/export-tests.cxx b/sd/qa/unit/export-tests.cxx
index d8cd85f..3c72207 100644
--- a/sd/qa/unit/export-tests.cxx
+++ b/sd/qa/unit/export-tests.cxx
@@ -122,6 +122,7 @@ public:
void testTransparentBackground();
void testFdo90607();
+void testTdf91378();
#if !defined WNT
void testBnc822341();
#endif
@@ -155,6 +156,7 @@ public:
CPPUNIT_TEST(testBulletMarginAndIndentation);
CPPUNIT_TEST(testParaMarginAndindentation);
CPPUNIT_TEST(testTransparentBackground);
+CPPUNIT_TEST(testTdf91378);
#if !defined WNT
CPPUNIT_TEST(testBnc822341);
@@ -951,6 +953,26 @@ void SdExportTest::testBulletColor()
CPPUNIT_ASSERT_EQUAL_MESSAGE( Bullet's color is wrong!,
sal_uInt32(0xff),pNumFmt-GetNumRule()-GetLevel(0).GetBulletColor().GetColor());
}
+void SdExportTest::testTdf91378()
+{
+
+//Check For Import and Export Both
+::sd::DrawDocShellRef xDocShRef =
loadURL(getURLFromSrc(/sd/qa/unit/data/pptx/tdf91378.pptx), PPTX);
+for( sal_uInt32 i=0;i2;i++)
+{
+ SdDrawDocument *pDoc = xDocShRef-GetDoc();
+ CPPUNIT_ASSERT_MESSAGE( no document, pDoc != NULL );
+ uno::Referencedocument::XDocumentPropertiesSupplier
xDocumentPropertiesSupplier( xDocShRef-GetModel(), uno::UNO_QUERY );
+ uno::Referencedocument::XDocumentProperties xProps(
xDocumentPropertiesSupplier-getDocumentProperties(), uno::UNO_QUERY );
+ uno::Referencebeans::XPropertySet xUDProps(
xProps-getUserDefinedProperties(), uno::UNO_QUERY );
+ OUString propValue;
+ xUDProps-getPropertyValue(OUString(Testing)) = propValue;
+ CPPUNIT_ASSERT(propValue.isEmpty());
+ xDocShRef = saveAndReload( xDocShRef, PPTX );
+}
+xDocShRef-DoClose();
+}
+
#if !defined WNT
void SdExportTest::testBnc822341()
___
[Libreoffice-bugs] [Bug 92331] FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=92331 John jjst...@mymts.net changed: What|Removed |Added Priority|medium |highest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65138] [META] Sidebar feature related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=65138 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Depends on||92332 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92332] New: SIDEBAR: Customizing the sidebar tabs isnt saved between sessions
https://bugs.documentfoundation.org/show_bug.cgi?id=92332 Bug ID: 92332 Summary: SIDEBAR: Customizing the sidebar tabs isnt saved between sessions Product: LibreOffice Version: 4.2.8.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com Blocks: 65138 Steps: 1) Open Writer 2) Click the customization button in the sidebar tab bar 3) In the context menu, click Customization Navigator to hide Navigator tab button in the tab bar 4) Close Writer 5) Open Writer 6) Navigator tab button is back Version: 5.1.0.0.alpha1+ Build ID: 2135fe0cef7bcf7160719f1f29ad65f2b064984b TinderBox: Linux-rpm_deb-x86_64@46-TDF, Branch:master, Time: 2015-06-24_03:00:35 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/filter/oox/defnamesbuffer.cxx |7 +++ 1 file changed, 7 insertions(+) New commits: commit 420ed9cb1d7f164be88ee2a01f79372744ed5f03 Author: Eike Rathke er...@redhat.com Date: Thu Jun 25 15:37:08 2015 +0200 TableRef: compile named expression into RPN once to populate information Change-Id: Id41ca0bd6adc8152c29be4d89e9361d8fb2ffe4e diff --git a/sc/source/filter/oox/defnamesbuffer.cxx b/sc/source/filter/oox/defnamesbuffer.cxx index a24c96a..fa2a0cf 100644 --- a/sc/source/filter/oox/defnamesbuffer.cxx +++ b/sc/source/filter/oox/defnamesbuffer.cxx @@ -387,6 +387,13 @@ std::unique_ptrScTokenArray DefinedName::getScTokens() ScCompiler aCompiler(getScDocument(), ScAddress(0, 0, mnCalcSheet)); aCompiler.SetGrammar(formula::FormulaGrammar::GRAM_OOXML); std::unique_ptrScTokenArray pArray(aCompiler.CompileString(maModel.maFormula)); +// Compile the tokens into RPN once to populate information into tokens +// where necessary, e.g. for TableRef inner reference. RPN can be discarded +// after, a resulting error must be reset. +sal_uInt16 nErr = pArray-GetCodeError(); +aCompiler.CompileTokenArray(); +pArray-DelRPN(); +pArray-SetCodeError(nErr); return pArray; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js | 12 +++-
loleaflet/src/layer/tile/TileLayer.js |4 +++-
2 files changed, 10 insertions(+), 6 deletions(-)
New commits:
commit e9691e6557ec170654be50ce78d4f1f51f7ded52
Author: Mihai Varga mihai.m...@gmail.com
Date: Thu Jun 25 13:25:03 2015 +0300
Enable fadeAnimated only when zooming/scrolling
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index 1996cad..7961688 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -333,6 +333,7 @@ L.GridLayer = L.Layer.extend({
this._tileZoom = tileZoom;
if (tileZoomChanged) {
+ this._map._fadeAnimated = true;
this._updateTileTwips();
this._updateMaxBounds();
}
@@ -437,6 +438,7 @@ L.GridLayer = L.Layer.extend({
},
_move: function () {
+ this._fadeAnimated = true;
this._update();
},
@@ -673,17 +675,17 @@ L.GridLayer = L.Layer.extend({
if (!tile) { return; }
tile.loaded = +new Date();
- if (tile._skipAnim) {
- this._tiles[key]._skipAnim = null;
- return;
- }
if (this._map._fadeAnimated) {
L.DomUtil.setOpacity(tile.el, 0);
L.Util.cancelAnimFrame(this._fadeFrame);
this._fadeFrame =
L.Util.requestAnimFrame(this._updateOpacity, this);
} else {
tile.active = true;
- this._pruneTiles();
+ if (tile._skipPrune) {
+ // avoid running the algorithm when we just
replace a tile
+ this._pruneTiles();
+ }
+ this._tiles[key]._skipPrune = false;
}
L.DomUtil.addClass(tile.el, 'leaflet-tile-loaded');
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index 2033265..1a756ee 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -309,6 +309,8 @@ L.TileLayer = L.GridLayer.extend({
var bottomRightTwips = topLeftTwips.add(offset);
var invalidBounds = new L.Bounds(topLeftTwips,
bottomRightTwips);
+ this._map._fadeAnimated = false;
+
for (var key in this._tiles) {
var coords = this._tiles[key].coords;
var point1 = this._coordsToTwips(coords);
@@ -370,7 +372,7 @@ L.TileLayer = L.GridLayer.extend({
var tile = this._tiles[key];
if (tile) {
if (tile.el.src) {
- this._tiles[key]._skipAnim = true;
+ this._tiles[key]._skipPrune = true;
}
tile.el.src = 'data:image/png;base64,' +
window.btoa(strBytes);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 505429d50a5764015ae833946555204d06889d54 Author: Caolán McNamara caol...@redhat.com Date: Thu Jun 25 11:23:02 2015 +0100 gtk3: render menu arrows with menuitem style not menu style Change-Id: I35de4ed31bfb9830f52aa5a25ea12bdf719c56ef (cherry picked from commit a469002ab5dfffc108b4329fd7dddfc9b8fcce20) diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx index 7b0617b..080f6cc 100644 --- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx @@ -902,7 +902,8 @@ bool GtkSalGraphics::drawNativeControl( ControlType nType, ControlPart nPart, co renderType = RENDER_MENU_SEPERATOR; break; case PART_MENU_SUBMENU_ARROW: -context = mpMenuStyle; +styleClass = GTK_STYLE_CLASS_ARROW; +context = mpCheckMenuItemStyle; renderType = RENDER_ARROW; break; case PART_ENTIRE_CONTROL: @@ -1288,7 +1289,7 @@ bool GtkSalGraphics::getNativeControlRegion( ControlType nType, ControlPart nPar gfloat arrow_scaling, arrow_size; arrow_scaling = 0; -gtk_style_context_get_style (mpMenuStyle, +gtk_style_context_get_style (mpCheckMenuItemStyle, arrow-scaling, arrow_scaling, NULL); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/html/swhtml.cxx | 62 ++-
1 file changed, 30 insertions(+), 32 deletions(-)
New commits:
commit 707ef3171a096787b2f7a4c221e60962f05e7d01
Author: Matteo Casalin matteo.casa...@yahoo.com
Date: Mon Jun 8 23:32:14 2015 +0200
Just continue to next iteration
Change-Id: I4040dff95dd1718df4cb555c155f7eea723bd2e3
Reviewed-on: https://gerrit.libreoffice.org/16170
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/filter/html/swhtml.cxx b/sw/source/filter/html/swhtml.cxx
index 1f92ffc..9d338a7 100644
--- a/sw/source/filter/html/swhtml.cxx
+++ b/sw/source/filter/html/swhtml.cxx
@@ -2292,7 +2292,7 @@ bool SwHTMLParser::AppendTextNode( SwHTMLAppendMode
eMode, bool bUpdateNum )
{
SwTextAttr *pHt = rHints.GetTextHint( i );
sal_uInt16 nWhich = pHt-Which();
-sal_Int16 nIdx = -1;
+sal_Int16 nIdx = 0;
bool bFont = false;
switch( nWhich )
{
@@ -2345,45 +2345,43 @@ bool SwHTMLParser::AppendTextNode( SwHTMLAppendMode
eMode, bool bUpdateNum )
nIdx = 14;
break;
default:
-break;
+// Skip to next attribute
+continue;
}
-if( nIdx != -1 )
+const sal_Int32 nStt = pHt-GetStart();
+if( nStt = aEndPos[nIdx] )
{
-sal_Int32 nStt = pHt-GetStart();
-if( nStt = aEndPos[nIdx] )
+const SfxPoolItem rItem =
+static_castconst SwContentNode *(pTextNd)-GetAttr(
nWhich );
+if( bFont ? swhtml_css1atr_equalFontItems(rItem,pHt-GetAttr())
+: rItem == pHt-GetAttr() )
{
-const SfxPoolItem rItem =
-static_castconst SwContentNode *(pTextNd)-GetAttr(
nWhich );
-if( bFont ?
swhtml_css1atr_equalFontItems(rItem,pHt-GetAttr())
- : rItem == pHt-GetAttr() )
-{
-// The hint is the same as set in the paragraph and
-// therefore, it can be deleted
-// CAUTION!!! This WILL delete the hint and it MAY
-// also delete the SwpHints!!! To avoid any trouble
-// we leave the loop immediately if this is the last
-// hint.
-pTextNd-DeleteAttribute( pHt );
-if( 1 == nCntAttr )
-break;
-i--;
-nCntAttr--;
-}
-else
-{
-// The hint is different. Therefore all hints within
that
-// hint have to be ignored.
-aEndPos[nIdx] = pHt-GetEnd() ? *pHt-GetEnd() : nStt;
-}
+// The hint is the same as set in the paragraph and
+// therefore, it can be deleted
+// CAUTION!!! This WILL delete the hint and it MAY
+// also delete the SwpHints!!! To avoid any trouble
+// we leave the loop immediately if this is the last
+// hint.
+pTextNd-DeleteAttribute( pHt );
+if( 1 == nCntAttr )
+break;
+i--;
+nCntAttr--;
}
else
{
-// The hint starts before another one ends.
-// The hint in this case is not deleted
-OSL_ENSURE( pHt-GetEnd() *pHt-GetEnd() =
aEndPos[nIdx],
-hints aren't nested properly! );
+// The hint is different. Therefore all hints within that
+// hint have to be ignored.
+aEndPos[nIdx] = pHt-GetEnd() ? *pHt-GetEnd() : nStt;
}
}
+else
+{
+// The hint starts before another one ends.
+// The hint in this case is not deleted
+OSL_ENSURE( pHt-GetEnd() *pHt-GetEnd() = aEndPos[nIdx],
+hints aren't nested properly! );
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92318] html document, that has extension xls, opens in Draw as garbage
https://bugs.documentfoundation.org/show_bug.cgi?id=92318 --- Comment #8 from Cor Nouws c...@nouenoff.nl --- (In reply to Andras Timar from comment #7) Thanks, backported. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 25 commits - basctl/source basic/source compilerplugins/clang connectivity/source cppuhelper/source cppu/source cui/source dbaccess/source editeng/source extensions/sou
basctl/source/basicide/brkdlg.cxx |2
basic/source/comp/codegen.cxx |2
compilerplugins/clang/stringconstant.cxx | 133 +++
connectivity/source/drivers/evoab2/NStatement.cxx |4
cppu/source/typelib/typelib.cxx|3
cppuhelper/source/factory.cxx |3
cui/source/options/optpath.cxx |2
dbaccess/source/core/api/SingleSelectQueryComposer.cxx |4
dbaccess/source/ui/app/AppController.cxx |2
dbaccess/source/ui/browser/unodatbr.cxx|4
dbaccess/source/ui/control/opendoccontrols.cxx |2
dbaccess/source/ui/dlg/DbAdminImpl.cxx |4
editeng/source/editeng/impedit.cxx |2
extensions/source/propctrlr/selectlabeldialog.cxx |4
filter/source/graphic/GraphicExportFilter.cxx |8
filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx|2
filter/source/xsltdialog/xmlfilterjar.cxx |2
framework/inc/queries.h| 38 +-
framework/source/accelerators/storageholder.cxx|4
i18npool/qa/cppunit/test_breakiterator.cxx |4
include/comphelper/string.hxx |2
include/rtl/strbuf.hxx | 28 +
include/rtl/string.hxx | 130 +--
include/rtl/stringconcat.hxx | 13
include/rtl/stringutils.hxx| 87
include/rtl/ustrbuf.hxx| 49 +-
include/rtl/ustring.hxx| 305 +
oox/source/export/chartexport.cxx |2
oox/source/export/vmlexport.cxx|2
sal/qa/rtl/strings/test_oustring_stringliterals.cxx| 14
sc/source/core/tool/compiler.cxx |4
sc/source/ui/docshell/impex.cxx| 12
sc/source/ui/view/gridwin5.cxx |4
sc/source/ui/view/tabvwshe.cxx |2
sd/source/filter/eppt/pptexanimations.cxx |2
sd/source/filter/html/htmlex.cxx |4
svtools/source/misc/ehdl.cxx |9
svx/source/form/navigatortree.cxx |6
sw/qa/core/uwriter.cxx |8
sw/source/core/access/acccontext.cxx |4
sw/source/core/fields/dbfld.cxx|2
sw/source/core/fields/ddefld.cxx |2
sw/source/core/tox/tox.cxx |2
sw/source/filter/ww8/docxexport.cxx|4
sw/source/filter/ww8/ww8par5.cxx |4
sw/source/uibase/dbui/mmconfigitem.cxx |4
sw/source/uibase/docvw/edtwin2.cxx |4
sw/source/uibase/fldui/fldmgr.cxx |8
sw/source/uibase/utlui/initui.cxx |4
ucb/source/ucp/hierarchy/hierarchyuri.cxx |4
ucb/source/ucp/webdav-neon/NeonSession.cxx |3
ucb/source/ucp/webdav-neon/UCBDeadPropertyValue.cxx|3
unotools/source/config/bootstrap.cxx |4
unotools/source/config/dynamicmenuoptions.cxx |2
unotools/source/config/pathoptions.cxx |4
vcl/source/control/field2.cxx |2
xmloff/source/chart/SchXMLExport.cxx |2
57 files changed, 664 insertions(+), 310 deletions(-)
New commits:
commit af333e81037b106702fc4c4d68b0653f80d2fb1b
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Jun 25 12:38:02 2015 +0200
loplugin:stringconstant: Flag more inefficiencies
Change-Id: I47726315f12ef05714bea248d79cc503fb99b23c
diff --git a/compilerplugins/clang/stringconstant.cxx
b/compilerplugins/clang/stringconstant.cxx
index 12bf173..9c86921 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -98,6 +98,9 @@ private:
std::string const qname, std::string const replacement,
TreatEmpty treatEmpty);
+void handleOUStringCtor(
+CallExpr const * expr, unsigned arg, std::string const qname);
+
std::stackExpr const * calls_;
};
@@ -292,6 +295,68 @@ bool StringConstant::VisitCallExpr(CallExpr const * expr) {
TreatEmpty::Error);
return true;
}
+if (qname == rtl::OUString::reverseCompareTo
+ fdecl-getNumParams() == 1)
+{
+handleOUStringCtor(expr, 0, qname);
+return true;
+}
+if (qname == rtl::OUString::equalsIgnoreAsciiCase
+ fdecl-getNumParams() == 1)
+{
+handleOUStringCtor(expr, 0, qname);
+return true;
+}
+if
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - sfx2/source
sfx2/source/appl/appopen.cxx | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
New commits:
commit c1f4ed516a3d415b26920792210f7ea27fa04218
Author: Szymon KÅos eszka...@gmail.com
Date: Thu Jun 25 12:38:25 2015 +0200
open only if RET_OK
Change-Id: Ib9a62d2540ed2d6fad6efedd1fba59bfa4eb635b
diff --git a/sfx2/source/appl/appopen.cxx b/sfx2/source/appl/appopen.cxx
index 9ae4b91..6b607d1 100644
--- a/sfx2/source/appl/appopen.cxx
+++ b/sfx2/source/appl/appopen.cxx
@@ -1123,23 +1123,26 @@ void SfxApplication::OpenDocExec_Impl( SfxRequest rReq
)
void SfxApplication::OpenRemoteExec_Impl( SfxRequest rReq )
{
-ScopedVclPtrInstance RemoteFilesDialog aDlg((vcl::Window*)NULL,
WB_OPEN);
+ScopedVclPtrInstance RemoteFilesDialog aDlg( ( vcl::Window* )NULL,
WB_OPEN );
// Filters for test purposes
aDlg-AddFilter(All files, FILTER_ALL);
aDlg-AddFilter(ODT files, *.odt);
aDlg-AddFilter(ODS files, *.ods);
-aDlg-Execute();
+short nResult = aDlg-Execute();
-OUString sFileName = aDlg-GetPath();
+if( nResult == RET_OK )
+{
+OUString sFileName = aDlg-GetPath();
-rReq.AppendItem( SfxStringItem( SID_TARGETNAME, OUString(_default) ) );
-rReq.AppendItem( SfxStringItem( SID_REFERER, private:user ) );
-rReq.RemoveItem( SID_FILE_NAME );
-rReq.AppendItem( SfxStringItem( SID_FILE_NAME, sFileName ) );
+rReq.AppendItem( SfxStringItem( SID_TARGETNAME, OUString( _default )
) );
+rReq.AppendItem( SfxStringItem( SID_REFERER, private:user ) );
+rReq.RemoveItem( SID_FILE_NAME );
+rReq.AppendItem( SfxStringItem( SID_FILE_NAME, sFileName ) );
-GetDispatcher_Impl()-Execute( SID_OPENDOC, SfxCallMode::SYNCHRON,
*rReq.GetArgs() );
+GetDispatcher_Impl()-Execute( SID_OPENDOC, SfxCallMode::SYNCHRON,
*rReq.GetArgs() );
+}
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92328] Unable to view regional contents boxes are displayed instead of regional content
https://bugs.documentfoundation.org/show_bug.cgi?id=92328 amrit...@mofirst.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92328] New: Unable to view regional contents boxes are displayed instead of regional content
https://bugs.documentfoundation.org/show_bug.cgi?id=92328 Bug ID: 92328 Summary: Unable to view regional contents boxes are displayed instead of regional content Product: LibreOffice Version: 4.4.0.0.alpha0+ Master Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: amrit...@mofirst.com Created attachment 116824 -- https://bugs.documentfoundation.org/attachment.cgi?id=116824action=edit Boxes are displayed instead of regional content Unable to view regional contents boxes are displayed instead of regional content In office cal if i receive a file with regional contents Kannada, Oriya Hindi Marathi etc contents are displayed as boxes even i have tried installing and selecting font it displays till the file is open if we close and launch it again u will see boxes for some file after selecting the font also it displays the box instead of regional content -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - compilerplugins/clang sw/inc sw/source
compilerplugins/clang/stringconstant.cxx |2 +-
sw/inc/index.hxx |4
sw/source/core/bastyp/index.cxx |2 --
sw/source/core/docnode/node.cxx |2 +-
4 files changed, 2 insertions(+), 8 deletions(-)
New commits:
commit 38ea4f018e795aa2b191509d2c1f56b76191f079
Author: Noel Grandin n...@peralex.com
Date: Thu Jun 25 13:48:11 2015 +0200
error: invalid operands to binary expression ('llvm::APSInt' and 'int')
Change-Id: I1a509ce133954a31a504dcc178687427f85f4c1c
diff --git a/compilerplugins/clang/stringconstant.cxx
b/compilerplugins/clang/stringconstant.cxx
index 9c86921..5ffec1b 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -1191,7 +1191,7 @@ void StringConstant::handleOUStringCtor(
e3-getArg(0)-IgnoreParenImpCasts()-isIntegerConstantExpr(
res, compiler.getASTContext()))
{
-if (res 0 res = 127) {
+if (res static_castAPSInt(0) res = static_castAPSInt(127)) {
report(
DiagnosticsEngine::Warning,
(in call of %0, replace OUString constructed from a (non-NUL)
commit 25603e07974d85a7c6b3cebe288068955a0030a1
Author: Noel Grandin n...@peralex.com
Date: Thu Jun 25 13:25:39 2015 +0200
remove custom RTTI from SwIndex
not being used
Change-Id: I615558e3c0abe7284b9abb535ee8f15c844c846e
diff --git a/sw/inc/index.hxx b/sw/inc/index.hxx
index e430fa8..a1d5da7 100644
--- a/sw/inc/index.hxx
+++ b/sw/inc/index.hxx
@@ -131,10 +131,6 @@ public:
SwIndexReg();
virtual ~SwIndexReg();
-/// rtti, derived classes might do the same. If so, one can cast typesavely
-/// via SwIndexReg.
-TYPEINFO();
-
void MoveTo( SwIndexReg rArr );
const SwIndex* GetFirstIndex() const { return m_pFirst; }
};
diff --git a/sw/source/core/bastyp/index.cxx b/sw/source/core/bastyp/index.cxx
index edc2218..c79005b 100644
--- a/sw/source/core/bastyp/index.cxx
+++ b/sw/source/core/bastyp/index.cxx
@@ -24,8 +24,6 @@
#include crossrefbookmark.hxx
-TYPEINIT0(SwIndexReg);
-
SwIndex::SwIndex(SwIndexReg *const pReg, sal_Int32 const nIdx)
: m_nIndex( nIdx )
, m_pIndexReg( pReg )
diff --git a/sw/source/core/docnode/node.cxx b/sw/source/core/docnode/node.cxx
index a7c2055..c776512 100644
--- a/sw/source/core/docnode/node.cxx
+++ b/sw/source/core/docnode/node.cxx
@@ -69,7 +69,7 @@
using namespace ::com::sun::star::i18n;
-TYPEINIT2( SwContentNode, SwModify, SwIndexReg )
+TYPEINIT1( SwContentNode, SwModify )
/*
* Some local helper functions for the attribute set handle of a content node.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] Collabora LibreOffice Vanilla QA on OSX
Alexander Thurgood wrote on 25-06-15 11:35: AFAIK there are no more Java Wizards in LO 4.3. Why would the app suddenly die without Java? It does not die. Because historically, and certainly in my experience, if a call to Java functionality in LO is going to break somewhere badly, it has often done so on OSX. On Ubuntu, I see a simple dialog. (Even sometimes when I do not expect it... see fdo#92153 ) Cor -- Cor Nouws GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28 A038 E49D 7365 B134 80A6 - vrijwilliger http://nl.libreoffice.org - volunteer http://www.libreoffice.org - The Document Foundation Membership Committee Member ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 92325] unable to clone translations
https://bugs.documentfoundation.org/show_bug.cgi?id=92325 Robinson Tryon (qubit) qu...@runcibility.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||qu...@runcibility.com Resolution|--- |NOTOURBUG --- Comment #1 from Robinson Tryon (qubit) qu...@runcibility.com --- (In reply to Rachna from comment #0) I am trying to compile libreoffice on ubuntu 15.04. ... fatal: unable to connect to gerrit.libreoffice.org: gerrit.libreoffice.org[0: 89.238.68.148]: errno=Connection refused Hi Rachna, For any build-related bugs or questions, please send an email to the dev list here: https://wiki.documentfoundation.org/Development/Mailing_List Thanks! Status - RESOLVED NOTOURBUG -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90884] Cannot set up impress remote via bluetooth
https://bugs.documentfoundation.org/show_bug.cgi?id=90884 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #3 from Beluga todven...@suomi24.fi --- WFM per comment 2. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 6 commits - loleaflet/src
loleaflet/src/control/Control.EditView.js| 34 +++
loleaflet/src/control/Control.Parts.js |4 +-
loleaflet/src/control/Control.Search.js | 14 -
loleaflet/src/control/Control.StatusIndicator.js |2 -
loleaflet/src/layer/marker/Cursor.js |2 -
loleaflet/src/layer/tile/GridLayer.js| 12
6 files changed, 34 insertions(+), 34 deletions(-)
New commits:
commit f5c8ec852dec7759b16ea2773409bdcd101ac42a
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Jun 25 15:50:53 2015 +0300
Fixed eslint errors in Control.EditView.js
diff --git a/loleaflet/src/control/Control.EditView.js
b/loleaflet/src/control/Control.EditView.js
index 2baf269..6032017 100644
--- a/loleaflet/src/control/Control.EditView.js
+++ b/loleaflet/src/control/Control.EditView.js
@@ -4,31 +4,31 @@
L.Control.EditViewSwitch = L.Control.extend({
options: {
- position: 'topleft',
+ position: 'topleft'
},
- onAdd: function (map) {
+ onAdd: function () {
var partName = 'leaflet-control-editviewswitch',
- container = L.DomUtil.create('label', partName + '
leaflet-bar');
+ container = L.DomUtil.create('label', partName + '
leaflet-bar');
-this._checkBox = L.DomUtil.create('input', 'editview-cb', container);
-this._checkBox.type = 'checkbox';
-L.DomEvent.on(this._checkBox, 'change', this._onChange, this);
+ this._checkBox = L.DomUtil.create('input', 'editview-cb',
container);
+ this._checkBox.type = 'checkbox';
+ L.DomEvent.on(this._checkBox, 'change', this._onChange, this);
container.appendChild(document.createTextNode('View only'));
return container;
},
-_onChange: function() {
-var className = 'leaflet-viewmode';
-if (this._checkBox.checked) {
-this._map.fire('viewmode');
-L.DomUtil.addClass(this._map._container, className);
-}
-else {
-this._map.fire('editmode');
-L.DomUtil.removeClass(this._map._container, className);
-}
-}
+ _onChange: function() {
+ var className = 'leaflet-viewmode';
+ if (this._checkBox.checked) {
+ this._map.fire('viewmode');
+ L.DomUtil.addClass(this._map._container, className);
+ }
+ else {
+ this._map.fire('editmode');
+ L.DomUtil.removeClass(this._map._container, className);
+ }
+ }
});
L.Map.mergeOptions({
commit a72d66f08b257b6f6f1725c622ca1334f788fbd8
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Jun 25 15:48:51 2015 +0300
Fixed eslint errors in Control.Parts.js
diff --git a/loleaflet/src/control/Control.Parts.js
b/loleaflet/src/control/Control.Parts.js
index 2b198d7..c0e75d9 100644
--- a/loleaflet/src/control/Control.Parts.js
+++ b/loleaflet/src/control/Control.Parts.js
@@ -29,7 +29,7 @@ L.Control.Parts = L.Control.extend({
return container;
},
- _prevPart: function (e) {
+ _prevPart: function () {
this._map.fire('prevpart');
if (this._currentPart 0) {
this._currentPart -= 1;
@@ -37,7 +37,7 @@ L.Control.Parts = L.Control.extend({
this._updateDisabled();
},
- _nextPart: function (e) {
+ _nextPart: function () {
this._map.fire('nextpart');
if (this._currentPart this._parts - 1) {
this._currentPart += 1;
commit fa3a5ab0c123baf5dbdbd51ae9845c35ce9d5854
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Jun 25 15:36:02 2015 +0300
Fixed eslint errors in Control.Search
diff --git a/loleaflet/src/control/Control.Search.js
b/loleaflet/src/control/Control.Search.js
index 5f7c678..c007067 100644
--- a/loleaflet/src/control/Control.Search.js
+++ b/loleaflet/src/control/Control.Search.js
@@ -58,7 +58,7 @@ L.Control.Search = L.Control.extend({
Math.max(viewTopLeftpx.y, docBoundsTopLeft.y)));
var topLeftTwips = this._map._docLayer._latLngToTwips(topLeft);
- if (e.keyCode === 13 this._searchBar.value !== '' ) {
+ if (e.keyCode === 13 this._searchBar.value !== '') {
this._disabled = false;
this._updateDisabled();
this._searchCmd['SearchItem.SearchString'].value =
this._searchBar.value;
@@ -79,25 +79,25 @@ L.Control.Search = L.Control.extend({
if (e.type === 'clearnotfound') {
L.DomUtil.removeClass(this._searchBar,
'search-not-found');
}
- else if (e.type == 'searchnotfound') {
+
[Libreoffice-commits] core.git: 2 commits - dbaccess/source svx/source
dbaccess/source/ui/control/tabletree.cxx |4 ++--
svx/source/inc/svdobjplusdata.hxx|2 --
svx/source/svdraw/svdobjplusdata.cxx |2 --
3 files changed, 2 insertions(+), 6 deletions(-)
New commits:
commit 3f4978f8c660c595773c92b99d45d0631cac04b0
Author: Noel Grandin n...@peralex.com
Date: Thu Jun 25 15:04:59 2015 +0200
loplugin:implicitboolconversion
Change-Id: Ib266bc70a99d84d4e3d845573f39e612dc6595f8
diff --git a/dbaccess/source/ui/control/tabletree.cxx
b/dbaccess/source/ui/control/tabletree.cxx
index 789f774..85ce260 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -262,10 +262,10 @@ void OTableTreeListBox::UpdateTableList( const Reference
XConnection _rxConn
{
OUString sRootEntryText;
if ( ::std::none_of(_rTables.begin(),_rTables.end(),
-[_rTables] (TNames::value_type name) { return
name.second == sal_False; }) )
+[_rTables] (TNames::value_type name) { return
!name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_TABLES);
else if ( ::std::none_of(_rTables.begin(),_rTables.end(),
- [_rTables] (TNames::value_type name) {
return name.second == sal_True; }) )
+ [_rTables] (TNames::value_type name) {
return !name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_VIEWS);
else
sRootEntryText = ModuleRes(STR_ALL_TABLES_AND_VIEWS);
commit 8bd2333e3636bc1e196fb7fccd73a0dc8518fa76
Author: Noel Grandin n...@peralex.com
Date: Thu Jun 25 15:03:31 2015 +0200
remove custom RTTI from SdrObjPlusData
not used anywhere
Change-Id: I72e8f1862dd9075c548d178f93cd72fa32a56809
diff --git a/svx/source/inc/svdobjplusdata.hxx
b/svx/source/inc/svdobjplusdata.hxx
index 7920df3..8f7c1a7 100644
--- a/svx/source/inc/svdobjplusdata.hxx
+++ b/svx/source/inc/svdobjplusdata.hxx
@@ -10,7 +10,6 @@
#ifndef INCLUDED_SVX_SVDOBJPLUSDATA_HXX
#define INCLUDED_SVX_SVDOBJPLUSDATA_HXX
-#include tools/rtti.hxx
#include rtl/ustring.hxx
class SdrObject;
@@ -34,7 +33,6 @@ class SdrObjPlusData
OUString aObjDescription;
public:
-TYPEINFO();
SdrObjPlusData();
virtual ~SdrObjPlusData();
SdrObjPlusData* Clone(SdrObject* pObj1) const;
diff --git a/svx/source/svdraw/svdobjplusdata.cxx
b/svx/source/svdraw/svdobjplusdata.cxx
index cc8fd35..e9d0696 100644
--- a/svx/source/svdraw/svdobjplusdata.cxx
+++ b/svx/source/svdraw/svdobjplusdata.cxx
@@ -14,8 +14,6 @@
#include svl/SfxBroadcaster.hxx
-TYPEINIT0(SdrObjPlusData);
-
SdrObjPlusData::SdrObjPlusData():
pBroadcast(NULL),
pUserDataList(NULL),
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: bin/lint-ui.py
bin/lint-ui.py | 18 ++ 1 file changed, 18 insertions(+) New commits: commit b4a224d1a91232a16b70be4531a3e6fd2d9bc9ae Author: Rosemary rosemarys...@gmail.com Date: Tue Jun 23 14:34:06 2015 +0530 tdf#80387 Extended lint-ui.py to check for UI title labels Change-Id: I47ab882b0d54711050da4fc8fa288b195949eb60 Reviewed-on: https://gerrit.libreoffice.org/16425 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/bin/lint-ui.py b/bin/lint-ui.py index 54e1d27..2ed80c2 100755 --- a/bin/lint-ui.py +++ b/bin/lint-ui.py @@ -11,6 +11,7 @@ import sys import xml.etree.ElementTree as ET +import re DEFAULT_WARNING_STR = 'Lint assertion failed' @@ -23,6 +24,8 @@ ALIGNMENT_TOP_PADDING = '6' MESSAGE_BOX_SPACING = '24' MESSAGE_BORDER_WIDTH = '12' +IGNORED_WORDS = ['the', 'of', 'to', 'for', 'a', 'and', 'as', 'from', 'on', 'into', 'by', 'at', 'or', 'do', 'in', 'when'] + def lint_assert(predicate, warning=DEFAULT_WARNING_STR): if not predicate: print(* + warning) @@ -77,6 +80,19 @@ def check_alignment_top_padding(alignment): lint_assert(top_padding.text == ALIGNMENT_TOP_PADDING, GtkAlignment 'top_padding' should be + ALIGNMENT_TOP_PADDING) +def check_title_labels(root): +labels = root.findall(.//child[@type='label']) +titles = [label.find(.//property[@name='label']) for label in labels] +for title in titles: +if title is None: +continue +words = re.split(r'[^a-zA-Z0-9_-]', title.text) +first = True +for word in words: +if word[0].islower() and (word not in IGNORED_WORDS or first): +lint_assert(False, The word ' + word + ' should be capitalized) +first = False + def main(): print( == + sys.argv[1] + ==) tree = ET.parse(sys.argv[1]) @@ -102,5 +118,7 @@ def main(): check_frames(root) +check_title_labels(root) + if __name__ == __main__: main() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 --- Comment #8 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to Adolfo Jayme from comment #6) I don’t know why the Sidebar allows to hide tabs/decks. It’s pointless functionality – it does not help reduce visual clutter, for example. IMHO Sidebar’s “Customization” menu should be killed. We do allow the same customization of toolbar buttons, but the likelihood of someone actually hiding a tab/deck is very slim. (In reply to Jean-Baptiste Faure from comment #7) I agree, these customization settings are not saved when you close the current file. As it doesnt save it between sessions, it is quite useless (bug 92332). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/.eslintignore
loleaflet/.eslintignore |1 + 1 file changed, 1 insertion(+) New commits: commit 2f6dd8a3e74bb1aad0a79e7102abbd2a251277c2 Author: Mihai Varga mihai.m...@gmail.com Date: Thu Jun 25 13:49:51 2015 +0300 Ignore src/scrollbar when running jake lint diff --git a/loleaflet/.eslintignore b/loleaflet/.eslintignore new file mode 100644 index 000..546fb41 --- /dev/null +++ b/loleaflet/.eslintignore @@ -0,0 +1 @@ +src/scrollbar ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92329] New: we can not go to a specific page via keyboard.
https://bugs.documentfoundation.org/show_bug.cgi?id=92329 Bug ID: 92329 Summary: we can not go to a specific page via keyboard. Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: nasrinkhaks...@gmail.com when i used microsoft office by pressing control g i could go to a specific page. first i pressed control g then typed my desired page and directly i could find it. but in openoffice and libreoffice its not possible. its a very big problem specially in long document for blind people who can use only keyboard. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang
compilerplugins/clang/stringconstant.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit f53c186b8d2f5a13a3a644dbff7f21548c32c4d4
Author: Noel Grandin n...@peralex.com
Date: Thu Jun 25 14:00:26 2015 +0200
my previous fix triggered an assert in clang
Change-Id: I67b8dec0d49032134a1b588363e72fa88f5993f7
diff --git a/compilerplugins/clang/stringconstant.cxx
b/compilerplugins/clang/stringconstant.cxx
index 5ffec1b..20ff2a9 100644
--- a/compilerplugins/clang/stringconstant.cxx
+++ b/compilerplugins/clang/stringconstant.cxx
@@ -1191,7 +1191,7 @@ void StringConstant::handleOUStringCtor(
e3-getArg(0)-IgnoreParenImpCasts()-isIntegerConstantExpr(
res, compiler.getASTContext()))
{
-if (res static_castAPSInt(0) res = static_castAPSInt(127)) {
+if (res.getSExtValue() 0 res.getSExtValue() = 127) {
report(
DiagnosticsEngine::Warning,
(in call of %0, replace OUString constructed from a (non-NUL)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/TileLayer.js | 66 +-
1 file changed, 33 insertions(+), 33 deletions(-)
New commits:
commit 7858402ea4cf738993eaffe6cb1e73f550670225
Author: Mihai Varga mihai.va...@collabora.com
Date: Thu Jun 25 16:15:04 2015 +0300
Removed hungarian notation
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index b62d1b9..740948a 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -118,19 +118,19 @@ L.TileLayer = L.GridLayer.extend({
}
this._documentInfo = '';
// View or edit mode.
- this._bEdit = false;
+ this._editMode = false;
// Position and size of the visible cursor.
- this._aVisibleCursor = new L.LatLngBounds(new L.LatLng(0, 0),
new L.LatLng(0, 0));
+ this._visibleCursor = new L.LatLngBounds(new L.LatLng(0, 0),
new L.LatLng(0, 0));
// Cursor overlay is visible or hidden (for blinking).
- this._bCursorOverlayVisible = false;
+ this._isCursorOverlayVisible = false;
// Cursor is visible or hidden (e.g. for graphic selection).
- this._bCursorVisible = true;
+ this._isCursorVisible = true;
// Rectangle graphic selection
- this._aGraphicSelection = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
+ this._graphicSelection = new L.LatLngBounds(new L.LatLng(0, 0),
new L.LatLng(0, 0));
// Position and size of the selection start (as if there would
be a cursor caret there).
- this._aTextSelectionStart = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
+ this._textSelectionStart = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
// Position and size of the selection end.
- this._aTextSelectionEnd = new L.LatLngBounds(new L.LatLng(0,
0), new L.LatLng(0, 0));
+ this._textSelectionEnd = new L.LatLngBounds(new L.LatLng(0, 0),
new L.LatLng(0, 0));
// Cursor marker
this._cursorMarker = null;
@@ -245,8 +245,8 @@ L.TileLayer = L.GridLayer.extend({
if (textMsg.startsWith('cursorvisible:')) {
var command = textMsg.match('cursorvisible: true');
- this._bCursorVisible = command === undefined ? false :
true;
- this._bCursorOverlayVisible = true;
+ this._isCursorVisible = command === undefined ? false :
true;
+ this._isCursorOverlayVisible = true;
this._onUpdateCursor();
}
else if (textMsg.startsWith('invalidatecursor:')) {
@@ -254,10 +254,10 @@ L.TileLayer = L.GridLayer.extend({
var topLeftTwips = new L.Point(parseInt(strTwips[0]),
parseInt(strTwips[1]));
var offset = new L.Point(parseInt(strTwips[2]),
parseInt(strTwips[3]));
var bottomRightTwips = topLeftTwips.add(offset);
- this._aVisibleCursor = new L.LatLngBounds(
+ this._visibleCursor = new L.LatLngBounds(
this._twipsToLatLng(topLeftTwips, this._map.getZoom()),
this._twipsToLatLng(bottomRightTwips, this._map.getZoom()));
- this._bCursorOverlayVisible = true;
+ this._isCursorOverlayVisible = true;
this._onUpdateCursor();
}
else if (textMsg.startsWith('textselectionstart:')) {
@@ -266,12 +266,12 @@ L.TileLayer = L.GridLayer.extend({
topLeftTwips = new
L.Point(parseInt(strTwips[0]), parseInt(strTwips[1]));
offset = new L.Point(parseInt(strTwips[2]),
parseInt(strTwips[3]));
bottomRightTwips = topLeftTwips.add(offset);
- this._aTextSelectionStart = new L.LatLngBounds(
+ this._textSelectionStart = new L.LatLngBounds(
this._twipsToLatLng(topLeftTwips, this._map.getZoom()),
this._twipsToLatLng(bottomRightTwips, this._map.getZoom()));
}
else {
- this._aTextSelectionStart = new
L.LatLngBounds(new L.LatLng(0, 0), new L.LatLng(0, 0));
+ this._textSelectionStart = new
L.LatLngBounds(new L.LatLng(0, 0), new L.LatLng(0, 0));
}
}
else if (textMsg.startsWith('textselectionend:')) {
@@ -280,24
[Libreoffice-bugs] [Bug 92331] New: FORMATTING
https://bugs.documentfoundation.org/show_bug.cgi?id=92331 Bug ID: 92331 Summary: FORMATTING Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: blocker Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jjst...@mymts.net Open Draw. Press F2 to create a text box. Mouse cursor disappears and text box cannot be created. Same with other features such as line, curve, etc. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92333] New: Vlookup is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=92333 Bug ID: 92333 Summary: Vlookup is broken Product: LibreOffice Version: 4.3.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fpoul...@metrodore.fr Created attachment 116827 -- https://bugs.documentfoundation.org/attachment.cgi?id=116827action=edit The option screen See the .ods attached. I made a very simple list with 3 items. I make three simple research on it. 2 of them give false or unexpected result. Note: the entire cell option is disabled. PS: recherche stands for lookup, in french. Here is my Debian version of LO: $ apt show libreoffice Package: libreoffice Version: 1:4.3.3-2 Installed-Size: 126 kB Maintainer: Debian LibreOffice Maintainers debian-openoff...@lists.debian.org Depends: fonts-sil-gentium-basic, libreoffice-base, libreoffice-calc, libreoffice-core (= 1:4.3.3-2), libreoffice-draw, libreoffice-impress, libreoffice-math, libreoffice-report-builder-bin, libreoffice-writer, libreoffice-avmedia-backend-gstreamer | libreoffice-avmedia-backend-vlc, fonts-dejavu, libreoffice-java-common (= 1:4.3.3~), python3-uno (= 4.0~) | python-uno Recommends: fonts-liberation | ttf-mscorefonts-installer, libpaper-utils Suggests: cups-bsd, hunspell-dictionary, hyphen-hyphenation-patterns, iceweasel | firefox | icedove | thunderbird | iceape-browser | mozilla-browser, imagemagick | graphicsmagick-imagemagick-compat, libgl1, libreoffice-gnome | libreoffice-kde, libreoffice-grammarcheck, libreoffice-help-4.3, libreoffice-l10n-4.3, libsane, libxrender1, myspell-dictionary, mythes-thesaurus, openclipart-libreoffice, pstoedit, unixodbc, gstreamer1.0-plugins-base, gstreamer1.0-plugins-good, gstreamer1.0-plugins-ugly, gstreamer1.0-plugins-bad, gstreamer1.0-ffmpeg, default-jre | gcj-jre | openjdk-7-jre | openjdk-6-jre | sun-java5-jre | sun-java6-jre | java5-runtime | jre, libreoffice-officebean Homepage: http://www.libreoffice.org Tag: role::metapackage Section: metapackages Priority: optional Download-Size: 69,7 kB APT-Manual-Installed: yes APT-Sources: http://ftp.be.debian.org/debian/ jessie/main amd64 Packages Description: office productivity suite (metapackage) LibreOffice is a full-featured office productivity suite that provides a near drop-in replacement for Microsoft(R) Office. . This metapackage installs all components of libreoffice: * libreoffice-writer: Word processor * libreoffice-calc: Spreadsheet * libreoffice-impress: Presentation * libreoffice-draw: Drawing * libreoffice-base: Database * libreoffice-math: Equation editor . You can extend the functionality of LibreOffice by installing these packages: * hunspell-*/myspell-*: Hunspell/Myspell dictionaries for use with LibreOffice * libreoffice-l10n-*: UI interface translation * libreoffice-help-*: User help * mythes-*: Thesauri for the use with LibreOffice * hyphen-*: Hyphenation patterns for LibreOffice * libreoffice-gtk: Gtk UI Plugin, GNOME File Picker support, QuickStarter for GNOMEs notification are * libreoffice-gnome: GIO, GConf backend * libreoffice-kde: KDE UI Plugin and KDE File Picker support * unixodbc: ODBC database support * cups-bsd: Allows LibreOffice to detect your CUPS printer queues automatically * libsane: Use your sane-supported scanner with LibreOffice * libxrender1: Speed up display by using Xrender library * libgl1: OpenGL support * openclipart-libreoffice: Open Clip Art Gallery with LibreOffice index files * iceweasel | firefox | icedove | thunderbird | iceape-browser | mozilla-browser: Mozilla profile with Certificates needed for XML Security... * openjdk-6-jre | gcj-jre | java5-runtime: Java Runtime Environment for use with LibreOffice * pstoedit / imagemagick: helper tools for EPS thumbnails * gstreamer0.10-plugins-*: GStreamer plugins for use with LibreOffices media backend * libpaper-utils: papersize detection support via paperconf * bluez: Bluetooth support for Impress (slideshow remote control -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92333] Vlookup is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=92333 --- Comment #1 from François Poulain fpoul...@metrodore.fr --- Created attachment 116828 -- https://bugs.documentfoundation.org/attachment.cgi?id=116828action=edit The rendered computation -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92333] Vlookup is broken
https://bugs.documentfoundation.org/show_bug.cgi?id=92333 --- Comment #2 from François Poulain fpoul...@metrodore.fr --- Created attachment 116829 -- https://bugs.documentfoundation.org/attachment.cgi?id=116829action=edit The example case -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - svtools/source
svtools/source/dialogs/RemoteFilesDialog.cxx | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
New commits:
commit 16fda0ed618102ecacfbe5a5af1eaed4b4f11ebb
Author: Szymon KÅos eszka...@gmail.com
Date: Thu Jun 25 12:48:27 2015 +0200
RemoteFilesDialog: opening files using double click
Change-Id: Ieea2d757525679b9686629f2d8e75e71cccbf2e0
diff --git a/svtools/source/dialogs/RemoteFilesDialog.cxx
b/svtools/source/dialogs/RemoteFilesDialog.cxx
index 405548e..c89f73f 100644
--- a/svtools/source/dialogs/RemoteFilesDialog.cxx
+++ b/svtools/source/dialogs/RemoteFilesDialog.cxx
@@ -641,9 +641,19 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
IMPL_LINK_NOARG ( RemoteFilesDialog, DoubleClickHdl )
{
-OUString sURL = m_pFileView-GetCurrentURL();
+SvTreeListEntry* pEntry = m_pFileView-FirstSelected();
+SvtContentEntry* pData = static_cast SvtContentEntry* (
pEntry-GetUserData() );
+
+if( pData-mbIsFolder )
+{
+OUString sURL = m_pFileView-GetCurrentURL();
-OpenURL( sURL );
+OpenURL( sURL );
+}
+else
+{
+EndDialog( RET_OK );
+}
return 1;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91361] LibreOffice stopped working XLSX to PDF conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=91361 --- Comment #9 from Cor Nouws c...@nouenoff.nl --- (In reply to Martijn from comment #1) conversion from xlsx to pdf via commandline sometimes endup in Libreoffice has stopped working pop up. Files are converted in a batch file So it happens now and then when converting more documents in one run? Or now and then when converting single documents? But it is always with running from the command line (we shall at least add that to the summary) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/headless
vcl/headless/svpgdi.cxx | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
New commits:
commit 3928a1514c9202a52d698570022c197ecc8703eb
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jun 25 13:41:58 2015 +0100
error: missing binary operator before token '('
Change-Id: Ieafb13245a11347cbda8a33e49ad618bf85d8a89
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 957463b..f5dbaf4 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -138,7 +138,10 @@ void SvpSalGraphics::clipRegion(cairo_t* cr)
bool SvpSalGraphics::drawAlphaRect(long nX, long nY, long nWidth, long
nHeight, sal_uInt8 nTransparency)
{
-#if ENABLE_CAIRO_CANVAS CAIRO_VERSION = CAIRO_VERSION_ENCODE(1, 6, 0)
+#if !ENABLE_CAIRO_CANVAS
+(void)nX; (void)nY; (void)nWidth; (void)nHeight; (void)nTransparency;
+return false;
+#elif CAIRO_VERSION = CAIRO_VERSION_ENCODE(1, 6, 0)
if (m_bUseLineColor || !m_bUseFillColor)
return false;
@@ -192,11 +195,7 @@ bool SvpSalGraphics::drawAlphaRect(long nX, long nY, long
nWidth, long nHeight,
}
return true;
#else
-(void)nX;
-(void)nY;
-(void)nWidth;
-(void)nHeight;
-(void)nTransparency;
+(void)nX; (void)nY; (void)nWidth; (void)nHeight; (void)nTransparency;
return false;
#endif
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 3 commits - sc/source
sc/source/core/tool/compiler.cxx | 16
sc/source/core/tool/dbdata.cxx| 21 -
sc/source/filter/oox/workbookfragment.cxx |1 +
sc/source/filter/oox/worksheethelper.cxx |1 -
4 files changed, 37 insertions(+), 2 deletions(-)
New commits:
commit 53d8b34465e28909491def39bfd11dfb83876939
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:46:55 2015 +0200
TableRef: ScCompiler::IsTableRefColumn() lookup column name in ScDBData
... as a fallback for named expressions during document import when cell
content isn't available yet.
Change-Id: I134ac2aaeb5f336703edbadfd6664d916d2c5885
(cherry picked from commit 4fc13975ad83fd2e95d2383ab0e9af688c47710d)
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 1a63740..04f7c01 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -3496,6 +3496,22 @@ bool ScCompiler::IsTableRefColumn( const OUString rName
) const
}
}
}
+
+// And now a fallback for named expressions during document load time when
+// cell content isn't available yet. This could be the preferred method IF
+// the ScDBData column names were maintained and refreshed on ALL sheet
+// operations, including cell content changes.
+sal_Int32 nOffset = pDBData-GetColumnNameOffset( aName);
+if (nOffset = 0)
+{
+ScSingleRefData aRef;
+ScAddress aAdr( aRange.aStart);
+aAdr.IncCol( nOffset);
+aRef.InitAddress( aAdr);
+maRawToken.SetSingleReference( aRef );
+return true;
+}
+
return false;
}
commit e8e333aa176d613d074b7730d7de4efacfad9bc9
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:45:37 2015 +0200
TableRef: search table column names case insensitive
Change-Id: I753a4511aa2c1e37b83094189902ce7031d68c04
(cherry picked from commit cd3486798496545271baa2cb5d7beb6f0a99dcca)
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index ef39e8b..113fa5f 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -603,10 +603,29 @@ void ScDBData::AdjustTableColumnNames( UpdateRefMode
eUpdateRefMode, SCCOL nDx,
aNewNames.swap( maTableColumnNames);
}
+namespace {
+class TableColumnNameSearch : public unary_functionScDBData, bool
+{
+public:
+explicit TableColumnNameSearch( const OUString rSearchName ) :
+maSearchName( rSearchName )
+{
+}
+
+bool operator()( const OUString rName ) const
+{
+return ScGlobal::GetpTransliteration()-isEqual( maSearchName, rName);
+}
+
+private:
+OUString maSearchName;
+};
+}
+
sal_Int32 ScDBData::GetColumnNameOffset( const OUString rName ) const
{
::std::vectorOUString::const_iterator it(
-::std::find( maTableColumnNames.begin(), maTableColumnNames.end(),
rName));
+::std::find_if( maTableColumnNames.begin(),
maTableColumnNames.end(), TableColumnNameSearch( rName)));
if (it != maTableColumnNames.end())
return it - maTableColumnNames.begin();
commit 3fc8cf504fab9a45c1f9a0dd4ff09949dfbec981
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:43:18 2015 +0200
TableRef: move getTables().applyTableColumns() to the correct position
... in import sequence.
Change-Id: Ib5601af281f0378d283ecd61fa71c41e6c1be254
(cherry picked from commit 58b0c0cf0c1429ec2f7f5ef8fc9ebc4840ace92d)
diff --git a/sc/source/filter/oox/workbookfragment.cxx
b/sc/source/filter/oox/workbookfragment.cxx
index 342be2b..4b37d0f 100644
--- a/sc/source/filter/oox/workbookfragment.cxx
+++ b/sc/source/filter/oox/workbookfragment.cxx
@@ -461,6 +461,7 @@ void WorkbookFragment::finalizeImport()
// create all database ranges and defined names, in that order
getTables().finalizeImport();
+getTables().applyTableColumns();
getDefinedNames().finalizeImport();
// open the VBA project storage
OUString aVbaFragmentPath = getFragmentPathFromFirstType(
CREATE_MSOFFICE_RELATION_TYPE( vbaProject ) );
diff --git a/sc/source/filter/oox/worksheethelper.cxx
b/sc/source/filter/oox/worksheethelper.cxx
index 9875f0e..d74f344 100644
--- a/sc/source/filter/oox/worksheethelper.cxx
+++ b/sc/source/filter/oox/worksheethelper.cxx
@@ -943,7 +943,6 @@ void WorksheetGlobals::finalizeWorksheetImport()
// assumes getTables().finalizeImport ( which creates the DatabaseRanges )
// has been called already
getTables().applyAutoFilters();
-getTables().applyTableColumns();
getCondFormats().finalizeImport();
lclUpdateProgressBar( mxFinalProgress, 0.25 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit a469002ab5dfffc108b4329fd7dddfc9b8fcce20 Author: Caolán McNamara caol...@redhat.com Date: Thu Jun 25 11:23:02 2015 +0100 gtk3: render menu arrows with menuitem style not menu style Change-Id: I35de4ed31bfb9830f52aa5a25ea12bdf719c56ef diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx index 985db9e..f641f53 100644 --- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx @@ -902,7 +902,8 @@ bool GtkSalGraphics::drawNativeControl( ControlType nType, ControlPart nPart, co renderType = RENDER_MENU_SEPERATOR; break; case PART_MENU_SUBMENU_ARROW: -context = mpMenuStyle; +styleClass = GTK_STYLE_CLASS_ARROW; +context = mpCheckMenuItemStyle; renderType = RENDER_ARROW; break; case PART_ENTIRE_CONTROL: @@ -1288,7 +1289,7 @@ bool GtkSalGraphics::getNativeControlRegion( ControlType nType, ControlPart nPar gfloat arrow_scaling, arrow_size; arrow_scaling = 0; -gtk_style_context_get_style (mpMenuStyle, +gtk_style_context_get_style (mpCheckMenuItemStyle, arrow-scaling, arrow_scaling, NULL); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92329] we can not go to a specific page via keyboard.
https://bugs.documentfoundation.org/show_bug.cgi?id=92329 zahra nasrinkhaks...@gmail.com changed: What|Removed |Added Priority|medium |highest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92323] Libre Office from Collabora crashes when opening an odt-file
https://bugs.documentfoundation.org/show_bug.cgi?id=92323 --- Comment #2 from Andras Timar tima...@gmail.com --- Probably it is the same crasher that was reported by many people. The fix (4.3-8) is waiting for review in App-Store. Expected release: end of week. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92311] rise the limit of auto complete entries
https://bugs.documentfoundation.org/show_bug.cgi?id=92311 tommy27 ba...@quipo.it changed: What|Removed |Added CC||qui...@gmail.com --- Comment #6 from tommy27 ba...@quipo.it --- I'm not a developer but it seems it could be a trivial hack to change the 1000 number to something bigger anyway I suspect you cannot set a number higher that 65K if you don't change int16-int32 like Tomaz Vajngerl did in Bug 48729 to rise the number of autocorrect entries from 65K to 4M -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dbaccess/source
dbaccess/source/ui/control/tabletree.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit a8cd99685abf879c56e04a95a5b2881d2adddcb9
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Jun 25 15:51:05 2015 +0200
Remove spurious negation operator again
...which had been introduced with 3f4978f8c660c595773c92b99d45d0631cac04b0
loplugin:implicitboolconversion when changing
return name.second == sal_True;
to
return !name.second;
Change-Id: I3d4cfb613efcc72cf01176556c678a97e5817528
diff --git a/dbaccess/source/ui/control/tabletree.cxx
b/dbaccess/source/ui/control/tabletree.cxx
index 85ce260..feb00aa 100644
--- a/dbaccess/source/ui/control/tabletree.cxx
+++ b/dbaccess/source/ui/control/tabletree.cxx
@@ -265,7 +265,7 @@ void OTableTreeListBox::UpdateTableList( const Reference
XConnection _rxConn
[_rTables] (TNames::value_type name) { return
!name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_TABLES);
else if ( ::std::none_of(_rTables.begin(),_rTables.end(),
- [_rTables] (TNames::value_type name) {
return !name.second; }) )
+ [_rTables] (TNames::value_type name) {
return name.second; }) )
sRootEntryText = ModuleRes(STR_ALL_VIEWS);
else
sRootEntryText = ModuleRes(STR_ALL_TABLES_AND_VIEWS);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[ANN] LibreOffice 4.4.4 RC3 available
Dear Community, The Document Foundation is pleased to announce the third release candidate of LibreOffice 4.4.4. The upcoming 4.4.4 will be the fourth in a sequence of frequent bugfix releases for our feature-packed 4.4 line. Please be aware that LibreOffice 4.4.4 RC3 has not been flagged as ready for production use yet, however feel free to give it a try instead of 4.4.3. A work-in-progress list of new features in LibreOffice 4.4 can be found at https://wiki.documentfoundation.org/ReleaseNotes/4.4 The release is available for Windows, Linux and Mac OS X from our QA builds download page at http://www.libreoffice.org/download/pre-releases/ Developers and QA might also be interested in the symbol server for windows debug information (see the release notes linked below for details) Should you find bugs, please report them to our Bugzilla: https://bugs.documentfoundation.org A good way to assess the release candidate quality is to run some specific manual tests on it, our TCM wiki page has more details: http://wiki.documentfoundation.org/QA/Testing/Regression_Tests#Full_Regression_Test For other ways to get involved with this exciting project - you can e.g. contribute code: http://www.libreoffice.org/community/developers/ translate LibreOffice to your language: http://wiki.documentfoundation.org/LibreOffice_Localization_Guide or help with funding our operations: http://donate.libreoffice.org/ A list of known issues and fixed bugs with 4.4.4 rc3 is available from our wiki: http://wiki.documentfoundation.org/Releases/4.4.4/RC3 Let us close again with a BIG Thank You! to all of you having contributed to the LibreOffice project - this release would not have been possible without your help. On behalf of the Community, Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92330] New: Awkward navigation for vertical text
https://bugs.documentfoundation.org/show_bug.cgi?id=92330 Bug ID: 92330 Summary: Awkward navigation for vertical text Product: LibreOffice Version: 4.4.2.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: minnigalie...@yandex.ru When use vertical text in the table cell can not use Up and Down arrows. Work only Left and Right arrows. It is annoying when working with more than one strings of text. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91961] Vertical text in a table cell rotated through paragraph or character style shows huge cursor at the beginning of the text
https://bugs.documentfoundation.org/show_bug.cgi?id=91961 --- Comment #8 from ⚡ Thunde® ⚡ minnigalie...@yandex.ru --- Just created the report about navigation. https://bugs.documentfoundation.org/show_bug.cgi?id=92330 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - sc/source
sc/source/core/tool/compiler.cxx | 16
sc/source/core/tool/dbdata.cxx| 21 -
sc/source/filter/oox/workbookfragment.cxx |1 +
sc/source/filter/oox/worksheethelper.cxx |1 -
4 files changed, 37 insertions(+), 2 deletions(-)
New commits:
commit 4fc13975ad83fd2e95d2383ab0e9af688c47710d
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:46:55 2015 +0200
TableRef: ScCompiler::IsTableRefColumn() lookup column name in ScDBData
... as a fallback for named expressions during document import when cell
content isn't available yet.
Change-Id: I134ac2aaeb5f336703edbadfd6664d916d2c5885
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 11aa239..3594f0e 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -3495,6 +3495,22 @@ bool ScCompiler::IsTableRefColumn( const OUString rName
) const
}
}
}
+
+// And now a fallback for named expressions during document load time when
+// cell content isn't available yet. This could be the preferred method IF
+// the ScDBData column names were maintained and refreshed on ALL sheet
+// operations, including cell content changes.
+sal_Int32 nOffset = pDBData-GetColumnNameOffset( aName);
+if (nOffset = 0)
+{
+ScSingleRefData aRef;
+ScAddress aAdr( aRange.aStart);
+aAdr.IncCol( nOffset);
+aRef.InitAddress( aAdr);
+maRawToken.SetSingleReference( aRef );
+return true;
+}
+
return false;
}
commit cd3486798496545271baa2cb5d7beb6f0a99dcca
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:45:37 2015 +0200
TableRef: search table column names case insensitive
Change-Id: I753a4511aa2c1e37b83094189902ce7031d68c04
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index ef39e8b..113fa5f 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -603,10 +603,29 @@ void ScDBData::AdjustTableColumnNames( UpdateRefMode
eUpdateRefMode, SCCOL nDx,
aNewNames.swap( maTableColumnNames);
}
+namespace {
+class TableColumnNameSearch : public unary_functionScDBData, bool
+{
+public:
+explicit TableColumnNameSearch( const OUString rSearchName ) :
+maSearchName( rSearchName )
+{
+}
+
+bool operator()( const OUString rName ) const
+{
+return ScGlobal::GetpTransliteration()-isEqual( maSearchName, rName);
+}
+
+private:
+OUString maSearchName;
+};
+}
+
sal_Int32 ScDBData::GetColumnNameOffset( const OUString rName ) const
{
::std::vectorOUString::const_iterator it(
-::std::find( maTableColumnNames.begin(), maTableColumnNames.end(),
rName));
+::std::find_if( maTableColumnNames.begin(),
maTableColumnNames.end(), TableColumnNameSearch( rName)));
if (it != maTableColumnNames.end())
return it - maTableColumnNames.begin();
commit 58b0c0cf0c1429ec2f7f5ef8fc9ebc4840ace92d
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 14:43:18 2015 +0200
TableRef: move getTables().applyTableColumns() to the correct position
... in import sequence.
Change-Id: Ib5601af281f0378d283ecd61fa71c41e6c1be254
diff --git a/sc/source/filter/oox/workbookfragment.cxx
b/sc/source/filter/oox/workbookfragment.cxx
index 342be2b..4b37d0f 100644
--- a/sc/source/filter/oox/workbookfragment.cxx
+++ b/sc/source/filter/oox/workbookfragment.cxx
@@ -461,6 +461,7 @@ void WorkbookFragment::finalizeImport()
// create all database ranges and defined names, in that order
getTables().finalizeImport();
+getTables().applyTableColumns();
getDefinedNames().finalizeImport();
// open the VBA project storage
OUString aVbaFragmentPath = getFragmentPathFromFirstType(
CREATE_MSOFFICE_RELATION_TYPE( vbaProject ) );
diff --git a/sc/source/filter/oox/worksheethelper.cxx
b/sc/source/filter/oox/worksheethelper.cxx
index 9875f0e..d74f344 100644
--- a/sc/source/filter/oox/worksheethelper.cxx
+++ b/sc/source/filter/oox/worksheethelper.cxx
@@ -943,7 +943,6 @@ void WorksheetGlobals::finalizeWorksheetImport()
// assumes getTables().finalizeImport ( which creates the DatabaseRanges )
// has been called already
getTables().applyAutoFilters();
-getTables().applyTableColumns();
getCondFormats().finalizeImport();
lclUpdateProgressBar( mxFinalProgress, 0.25 );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90154] Visio Drawing incorrect overlappings
https://bugs.documentfoundation.org/show_bug.cgi?id=90154 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #3 from Beluga todven...@suomi24.fi --- Confirmed. Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+ (x64) Build ID: a51ac4d2bb8c4f1ea1d4ea7569863e2fb6535b02 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-06-22_21:37:53 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92334] New: Windows Explorer crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92334 Bug ID: 92334 Summary: Windows Explorer crash Product: LibreOffice Version: 5.0.0.1 rc Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: blocker Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: i...@welcrosoft.dk Created attachment 116830 -- https://bugs.documentfoundation.org/attachment.cgi?id=116830action=edit Screendump of the crash pop-up Windows Explorer crashes on mouseover on any LibreOffice file type, .odt, .ods, odg Probably a duplicate bug of 92269 and 92261 Screendump of the crash pop-up attached -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92241] Preview is cut off in Symbols dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=92241 Andras Timar tima...@gmail.com changed: What|Removed |Added Keywords||bisected CC||nem...@numbertext.org, ||qui...@gmail.com --- Comment #3 from Andras Timar tima...@gmail.com --- first bad commit: [e5bb5c52aeaeb60c8592b004efd88c30242e03a1] add RenderContext to Window::PushPaintHelper, use Erase correctly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92329] we can not go to a specific page via keyboard.
https://bugs.documentfoundation.org/show_bug.cgi?id=92329 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||c...@nouenoff.nl Resolution|--- |WORKSFORME --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Hi Zahra, Please try Ctrl+Shft+F5 :) And for questions, there are user support options too. http://www.libreoffice.org/get-help/mailing-lists/ Kind regards, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92325] unable to clone translations
https://bugs.documentfoundation.org/show_bug.cgi?id=92325 Rachna rach...@cdac.in changed: What|Removed |Added Priority|medium |highest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 91824] remove sidebar configuration icon and menu items to view sidebar menu entry
https://bugs.documentfoundation.org/show_bug.cgi?id=91824 --- Comment #8 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to Adolfo Jayme from comment #6) I don’t know why the Sidebar allows to hide tabs/decks. It’s pointless functionality – it does not help reduce visual clutter, for example. IMHO Sidebar’s “Customization” menu should be killed. We do allow the same customization of toolbar buttons, but the likelihood of someone actually hiding a tab/deck is very slim. (In reply to Jean-Baptiste Faure from comment #7) I agree, these customization settings are not saved when you close the current file. As it doesnt save it between sessions, it is quite useless (bug 92332). -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 44419] Allow entire column or entire row ranges in formulae, e.g. A:A or 1:1
https://bugs.documentfoundation.org/show_bug.cgi?id=44419 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #20 from Eike Rathke er...@redhat.com --- More to come.. taking. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92150] spell checking does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=92150 --- Comment #17 from Beluga todven...@suomi24.fi --- Jacques: you could zip up your old, problematic profile and attach it here. Then it might be investigated somehow (personally I have no idea how). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 2 commits - scp2/source vcl/Library_vcl.mk
scp2/source/ooo/file_ooo.scp |2 +- vcl/Library_vcl.mk |6 ++ 2 files changed, 7 insertions(+), 1 deletion(-) New commits: commit 882f8dd06fba025177f8cc1e662c95b01075006d Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Wed Jun 24 12:20:09 2015 +0200 Fixup vcl build with --without-x Fix provided by Abhimanyu Singh Change-Id: I5d87aa76517b1cf9d7464f43b9be236de0e92039 Reviewed-on: https://gerrit.libreoffice.org/16452 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Stahl mst...@redhat.com (cherry picked from commit d2d18465b027fc26af2a170959109d19f107d09b) diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk index 7c99bed..542c8f52 100644 --- a/vcl/Library_vcl.mk +++ b/vcl/Library_vcl.mk @@ -605,6 +605,12 @@ $(eval $(call gb_Library_add_exception_objects,vcl,\ vcl/unx/generic/printer/ppdparser \ vcl/null/printerinfomanager \ vcl/headless/headlessinst \ +$(vcl_headless_code) \ +$(vcl_headless_freetype_code) \ +)) + +$(eval $(call gb_Library_use_libraries,vcl,\ + basebmp \ )) $(eval $(call gb_Library_use_externals,vcl,\ commit 8b5e393e1be96bd2bbd41aa3dca881e1c07ccea9 Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com Date: Wed Jun 24 17:01:56 2015 +0200 Avoid errors with stuff not build on --without-x Reported by by Abhimanyu Singh Change-Id: I02bd2a2b85b9d55f0b237d3a1141801245473cd2 Reviewed-on: https://gerrit.libreoffice.org/16453 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Michael Stahl mst...@redhat.com (cherry picked from commit 64b636b814ddd65b90459c75a49cc5e743a2785c) diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp index a682256..b0f3382 100644 --- a/scp2/source/ooo/file_ooo.scp +++ b/scp2/source/ooo/file_ooo.scp @@ -59,7 +59,7 @@ End #endif -#if defined UNX ! defined MACOSX +#if defined UNX ! defined MACOSX ! defined LIBO_HEADLESS File gid_File_Bin_Gnome_Open_Url BIN_FILE_BODY; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: icon-themes/breeze
icon-themes/breeze/cmd/lc_dataranges.png |binary icon-themes/breeze/cmd/lc_diagramarea.png |binary icon-themes/breeze/cmd/lc_diagramdata.png |binary icon-themes/breeze/cmd/lc_diagramwall.png |binary icon-themes/breeze/cmd/lc_legend.png |binary icon-themes/breeze/cmd/lc_togglelegend.png |binary icon-themes/breeze/cmd/sc_dataranges.png |binary icon-themes/breeze/cmd/sc_diagramarea.png |binary icon-themes/breeze/cmd/sc_diagramwall.png |binary icon-themes/breeze/cmd/sc_legend.png |binary icon-themes/breeze/cmd/sc_togglelegend.png |binary 11 files changed New commits: commit 04f9b75249279efaca3fff832346989d2cbda67e Author: andreask kain...@gmail.com Date: Thu Jun 25 00:25:31 2015 +0200 Breeze: Calc formating toolbar last ones All new entries I added to the formatting toolbar (DiagramArea, DiagramWall, View3D, InsertMenuTitles, DiagramAxisY, DiagramAxisX, DiagramAxisX) new toolbar is finished. xml file is still open. Change-Id: I5ae2a1d8d2990b8aeefdf03366ba2514678d591b Reviewed-on: https://gerrit.libreoffice.org/16460 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Adolfo Jayme Barrientos fit...@ubuntu.com Tested-by: Adolfo Jayme Barrientos fit...@ubuntu.com diff --git a/icon-themes/breeze/cmd/lc_dataranges.png b/icon-themes/breeze/cmd/lc_dataranges.png new file mode 100644 index 000..f447aaa Binary files /dev/null and b/icon-themes/breeze/cmd/lc_dataranges.png differ diff --git a/icon-themes/breeze/cmd/lc_diagramarea.png b/icon-themes/breeze/cmd/lc_diagramarea.png new file mode 100644 index 000..6c9c8eb Binary files /dev/null and b/icon-themes/breeze/cmd/lc_diagramarea.png differ diff --git a/icon-themes/breeze/cmd/lc_diagramdata.png b/icon-themes/breeze/cmd/lc_diagramdata.png index 7f10c12..fc5b8de 100644 Binary files a/icon-themes/breeze/cmd/lc_diagramdata.png and b/icon-themes/breeze/cmd/lc_diagramdata.png differ diff --git a/icon-themes/breeze/cmd/lc_diagramwall.png b/icon-themes/breeze/cmd/lc_diagramwall.png new file mode 100644 index 000..09ea2c6 Binary files /dev/null and b/icon-themes/breeze/cmd/lc_diagramwall.png differ diff --git a/icon-themes/breeze/cmd/lc_legend.png b/icon-themes/breeze/cmd/lc_legend.png new file mode 100644 index 000..38f5265 Binary files /dev/null and b/icon-themes/breeze/cmd/lc_legend.png differ diff --git a/icon-themes/breeze/cmd/lc_togglelegend.png b/icon-themes/breeze/cmd/lc_togglelegend.png index 7eb9f3b..4eb35c4 100644 Binary files a/icon-themes/breeze/cmd/lc_togglelegend.png and b/icon-themes/breeze/cmd/lc_togglelegend.png differ diff --git a/icon-themes/breeze/cmd/sc_dataranges.png b/icon-themes/breeze/cmd/sc_dataranges.png new file mode 100644 index 000..39c68fa Binary files /dev/null and b/icon-themes/breeze/cmd/sc_dataranges.png differ diff --git a/icon-themes/breeze/cmd/sc_diagramarea.png b/icon-themes/breeze/cmd/sc_diagramarea.png new file mode 100644 index 000..1e4b607 Binary files /dev/null and b/icon-themes/breeze/cmd/sc_diagramarea.png differ diff --git a/icon-themes/breeze/cmd/sc_diagramwall.png b/icon-themes/breeze/cmd/sc_diagramwall.png new file mode 100644 index 000..f919ed7 Binary files /dev/null and b/icon-themes/breeze/cmd/sc_diagramwall.png differ diff --git a/icon-themes/breeze/cmd/sc_legend.png b/icon-themes/breeze/cmd/sc_legend.png new file mode 100644 index 000..e0b6fe9 Binary files /dev/null and b/icon-themes/breeze/cmd/sc_legend.png differ diff --git a/icon-themes/breeze/cmd/sc_togglelegend.png b/icon-themes/breeze/cmd/sc_togglelegend.png index 9e9e00b..51c8484 100644 Binary files a/icon-themes/breeze/cmd/sc_togglelegend.png and b/icon-themes/breeze/cmd/sc_togglelegend.png differ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 78642] LibreLogo: return values for functions
https://bugs.documentfoundation.org/show_bug.cgi?id=78642 Gilvan Vilarim gilvan.vila...@gmail.com changed: What|Removed |Added Resolution|FIXED |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/transform/ChartOASISTContext.cxx |2 - xmloff/source/transform/ChartOASISTContext.hxx |2 - xmloff/source/transform/ChartOOoTContext.cxx |2 - xmloff/source/transform/ChartOOoTContext.hxx |2 - xmloff/source/transform/ChartPlotAreaOASISTContext.cxx |6 xmloff/source/transform/ChartPlotAreaOASISTContext.hxx |2 - xmloff/source/transform/ChartPlotAreaOOoTContext.cxx |6 xmloff/source/transform/ChartPlotAreaOOoTContext.hxx |2 - xmloff/source/transform/ControlOASISTContext.cxx |2 - xmloff/source/transform/ControlOASISTContext.hxx |2 - xmloff/source/transform/ControlOOoTContext.cxx |2 - xmloff/source/transform/ControlOOoTContext.hxx |2 - xmloff/source/transform/CreateElemTContext.cxx |2 - xmloff/source/transform/CreateElemTContext.hxx |2 - xmloff/source/transform/DeepTContext.cxx |2 - xmloff/source/transform/DeepTContext.hxx |2 - xmloff/source/transform/DlgOASISTContext.cxx |2 - xmloff/source/transform/DlgOASISTContext.hxx |2 - xmloff/source/transform/DocumentTContext.cxx |2 - xmloff/source/transform/DocumentTContext.hxx |2 - xmloff/source/transform/EventOASISTContext.cxx |2 - xmloff/source/transform/EventOASISTContext.hxx |2 - xmloff/source/transform/EventOOoTContext.cxx |2 - xmloff/source/transform/EventOOoTContext.hxx |2 - xmloff/source/transform/FlatTContext.cxx |2 - xmloff/source/transform/FlatTContext.hxx |2 - xmloff/source/transform/FormPropOASISTContext.cxx |3 -- xmloff/source/transform/FormPropOASISTContext.hxx |2 - xmloff/source/transform/FormPropOOoTContext.cxx|6 xmloff/source/transform/FormPropOOoTContext.hxx|2 - xmloff/source/transform/FrameOASISTContext.cxx |2 - xmloff/source/transform/FrameOASISTContext.hxx |2 - xmloff/source/transform/FrameOOoTContext.cxx |2 - xmloff/source/transform/FrameOOoTContext.hxx |2 - xmloff/source/transform/IgnoreTContext.cxx |2 - xmloff/source/transform/IgnoreTContext.hxx |2 - xmloff/source/transform/MergeElemTContext.cxx | 10 xmloff/source/transform/MergeElemTContext.hxx |2 - xmloff/source/transform/MetaTContext.cxx |2 - xmloff/source/transform/MetaTContext.hxx |2 - xmloff/source/transform/NotesTContext.cxx |2 - xmloff/source/transform/NotesTContext.hxx |2 - xmloff/source/transform/OOo2Oasis.cxx | 21 - xmloff/source/transform/Oasis2OOo.cxx | 21 - xmloff/source/transform/PersAttrListTContext.cxx |2 - xmloff/source/transform/PersAttrListTContext.hxx |2 - xmloff/source/transform/PersMixedContentTContext.cxx |6 xmloff/source/transform/PersMixedContentTContext.hxx |2 - xmloff/source/transform/ProcAddAttrTContext.cxx|2 - xmloff/source/transform/ProcAddAttrTContext.hxx|2 - xmloff/source/transform/ProcAttrTContext.cxx |2 - xmloff/source/transform/ProcAttrTContext.hxx |2 - xmloff/source/transform/RenameElemTContext.cxx |2 - xmloff/source/transform/RenameElemTContext.hxx |2 - xmloff/source/transform/StyleOASISTContext.cxx |6 xmloff/source/transform/StyleOASISTContext.hxx |2 - xmloff/source/transform/StyleOOoTContext.cxx | 12 - xmloff/source/transform/StyleOOoTContext.hxx |4 --- xmloff/source/transform/TransformerContext.cxx |2 - xmloff/source/transform/TransformerContext.hxx |2 - 60 files changed, 1 insertion(+), 198 deletions(-) New commits: commit 4354341159e929bf7d21888ae1083d59cda135ad Author: Noel Grandin n...@peralex.com Date: Wed Jun 24 15:08:07 2015 +0200 remove our custom RTTI from xmloff module not being used, anyhow Change-Id: I0eb0d6377efe324d9a442a70fc2046a58ed2f3c4 diff --git a/xmloff/source/transform/ChartOASISTContext.cxx b/xmloff/source/transform/ChartOASISTContext.cxx index fc319f7..fb2a875 100644 --- a/xmloff/source/transform/ChartOASISTContext.cxx +++ b/xmloff/source/transform/ChartOASISTContext.cxx @@ -30,8 +30,6 @@ using namespace ::com::sun::star::uno; using namespace ::com::sun::star::xml::sax; using namespace ::xmloff::token; -TYPEINIT1( XMLChartOASISTransformerContext, XMLTransformerContext ); - XMLChartOASISTransformerContext::XMLChartOASISTransformerContext( XMLTransformerBase rImp, const OUString rQName ) : diff --git a/xmloff/source/transform/ChartOASISTContext.hxx
[Libreoffice-bugs] [Bug 92256] INDIRECT function lost interoperabilty with calc documents migrated by OOo3.2.1
https://bugs.documentfoundation.org/show_bug.cgi?id=92256 --- Comment #12 from Christoph Lutz chrl...@googlemail.com --- Just want to add some important details regarding approach 3: * The options extras-options-calc/formula formula syntax and all other options on this page (except Custom Settings-reference syntax for string references) have no influence on the INDIRECT function. So we do not do anything with these options. * Custom Settings-reference syntax for string references directly influences the way how INDIRECT is evaluated - so this option needs to be persisted on document level (instead of ony being a global option). So the plan is to store this setting within ODS/OTS documents and restore it on load. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92317] Sidebar size is not constrained by its content
https://bugs.documentfoundation.org/show_bug.cgi?id=92317 --- Comment #1 from Laurent Godard lgodard.li...@laposte.net --- if a user resizes the sidebar it is mainly to gain area regarding its document and work is it something wanted to force him to resize the sidebar every time he switches decks or panels ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92322] EDITING - MEMO (TEXT) fields refuse data entry with MySQL and JDBC connector
https://bugs.documentfoundation.org/show_bug.cgi?id=92322 --- Comment #8 from PJG51 p...@realworks.fr --- So thanks Alex, I think you've been around the problem! But I don't think this bug is completely linked to MySQL Connector, because it works properly with NeoOffice… -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sal/qa sal/rtl
sal/qa/rtl/strings/test_strings_replace.cxx | 13 +
sal/rtl/ustring.cxx |4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
New commits:
commit 24bc22fcb0550c3ebf74db3642ab32b8e818205c
Author: Stephan Bergmann sberg...@redhat.com
Date: Thu Jun 25 08:52:08 2015 +0200
Do not forget to actually set newStr to an empty string
(cherry picked from commit f7a7a9dd84d1cd8b49d59e1fb1853ea7e9f40edf)
Conflicts:
sal/qa/rtl/strings/test_strings_replace.cxx
sal/rtl/ustring.cxx
(cherry picked from commit e36ca8d3c69d0c08ad28ceea278b05a0af81e102)
Conflicts:
sal/qa/rtl/strings/test_strings_replace.cxx
Change-Id: I745b09d8a248f08afdd3387f4cfcf69d71ec3c39
Reviewed-on: https://gerrit.libreoffice.org/16465
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sal/qa/rtl/strings/test_strings_replace.cxx
b/sal/qa/rtl/strings/test_strings_replace.cxx
index 2065078..d26c308 100644
--- a/sal/qa/rtl/strings/test_strings_replace.cxx
+++ b/sal/qa/rtl/strings/test_strings_replace.cxx
@@ -186,6 +186,10 @@ void Test::ustringReplaceFirstAsciiL() {
rtl::OUString(other), n)));
CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), n);
}
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(),
+rtl::OUString(xa).replaceFirst(xa, rtl::OUString()));
}
void Test::ustringReplaceFirstAsciiLAsciiL() {
@@ -225,6 +229,9 @@ void Test::ustringReplaceFirstAsciiLAsciiL() {
replaceFirst(bar, other, n)));
CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), n);
}
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceFirst(xa, ));
}
void Test::ustringReplaceAll() {
@@ -265,6 +272,9 @@ void Test::ustringReplaceAllAsciiL() {
rtl::OUString(xaa).replaceAll(
xa,
rtl::OUString(xx)));
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceAll(xa,
rtl::OUString()));
}
void Test::ustringReplaceAllAsciiLAsciiL() {
@@ -282,6 +292,9 @@ void Test::ustringReplaceAllAsciiLAsciiL() {
rtl::OUString(xxa),
(rtl::OUString(xaa).
replaceAll(xa, xx)));
+
+CPPUNIT_ASSERT_EQUAL(
+rtl::OUString(), rtl::OUString(xa).replaceAll(xa, ));
}
}
diff --git a/sal/rtl/ustring.cxx b/sal/rtl/ustring.cxx
index 5f1c12a..2df10fc 100644
--- a/sal/rtl/ustring.cxx
+++ b/sal/rtl/ustring.cxx
@@ -1118,8 +1118,8 @@ void rtl_uString_newReplaceFirstAsciiL(
}
sal_Int32 n = str-length - fromLength + to-length;
rtl_uString_acquire(str); // in case *newStr == str
+rtl_uString_new_WithLength(newStr, n);
if (n != 0) {
-rtl_uString_new_WithLength(newStr, n);
(*newStr)-length = n;
assert(i = 0 i str-length);
memcpy(
@@ -1161,8 +1161,8 @@ void rtl_uString_newReplaceFirstAsciiLAsciiL(
}
sal_Int32 n = str-length - fromLength + toLength;
rtl_uString_acquire(str); // in case *newStr == str
+rtl_uString_new_WithLength(newStr, n);
if (n != 0) {
-rtl_uString_new_WithLength(newStr, n);
(*newStr)-length = n;
assert(i = 0 i str-length);
memcpy(
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source
sc/inc/dbdata.hxx | 16 +
sc/source/core/tool/dbdata.cxx | 68 +
2 files changed, 83 insertions(+), 1 deletion(-)
New commits:
commit 044f79078ae2776b786f904e5f24a745f8635a18
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 11:52:45 2015 +0200
TableRef: add ScDBData::GetColumnNameOffset()
Change-Id: Id80b9e8d1f54a8b795d0f4209bdf2f980f9a5344
diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index b77e218..4965e94 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -112,6 +112,16 @@ public:
voidSetStripData(bool bSet) { bStripData = bSet; }
voidSetTableColumnNames( const ::std::vector OUString rNames )
{ maTableColumnNames = rNames; }
+/** Finds the column named rName and returns the corresponding offset
+within the table.
+@returns -1 if not found.
+
+XXX NOTE: there is no refresh of names or anything implemented yet, use
+this only during document load time.
+ */
+sal_Int32 GetColumnNameOffset( const OUString rName ) const;
+
+
OUString GetSourceString() const;
OUString GetOperations() const;
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index c99f893..ef39e8b 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -603,6 +603,16 @@ void ScDBData::AdjustTableColumnNames( UpdateRefMode
eUpdateRefMode, SCCOL nDx,
aNewNames.swap( maTableColumnNames);
}
+sal_Int32 ScDBData::GetColumnNameOffset( const OUString rName ) const
+{
+::std::vectorOUString::const_iterator it(
+::std::find( maTableColumnNames.begin(), maTableColumnNames.end(),
rName));
+if (it != maTableColumnNames.end())
+return it - maTableColumnNames.begin();
+
+return -1;
+}
+
namespace {
class FindByTable : public unary_functionScDBData, bool
commit 98ba33677c288ff80c6f2812e85039175b7fcff8
Author: Eike Rathke er...@redhat.com
Date: Thu Jun 25 11:44:46 2015 +0200
TableRef: invalidate table column names on most sheet operations
Kept only on insertions and deletions, but even that may not be useful
as the names aren't updated at any time so even a mere cell change will
bring this out of sync. But serves as a starting point for further
implementation.
Change-Id: Idfede4b03b9f554cd35f984502fce625c725853c
diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index c1d41f9..b77e218 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -110,7 +110,6 @@ public:
voidSetKeepFmt(bool bSet) { bKeepFmt = bSet; }
boolIsStripData() const { return bStripData; }
voidSetStripData(bool bSet) { bStripData = bSet; }
-const ::std::vector OUString GetTableColumnNames() { return
maTableColumnNames; }
voidSetTableColumnNames( const ::std::vector OUString rNames )
{ maTableColumnNames = rNames; }
OUString GetSourceString() const;
@@ -154,6 +153,11 @@ public:
SCsCOL nDx, SCsROW nDy, SCsTAB nDz);
void ExtendDataArea(ScDocument* pDoc);
+
+private:
+
+void AdjustTableColumnNames( UpdateRefMode eUpdateRefMode, SCCOL nDx,
SCCOL nCol1,
+SCCOL nOldCol1, SCCOL nOldCol2, SCCOL nNewCol1, SCCOL nNewCol2 );
};
class SC_DLLPUBLIC ScDBCollection
diff --git a/sc/source/core/tool/dbdata.cxx b/sc/source/core/tool/dbdata.cxx
index 34c2f69..c99f893 100644
--- a/sc/source/core/tool/dbdata.cxx
+++ b/sc/source/core/tool/dbdata.cxx
@@ -276,6 +276,8 @@ void ScDBData::GetArea(ScRange rRange) const
void ScDBData::SetArea(SCTAB nTab, SCCOL nCol1, SCROW nRow1, SCCOL nCol2,
SCROW nRow2)
{
+::std::vectorOUString().swap( maTableColumnNames);// invalidate
column names/offsets
+
nTable = nTab;
nStartCol = nCol1;
nStartRow = nRow1;
@@ -488,8 +490,13 @@ void ScDBData::UpdateMoveTab(SCTAB nOldPos, SCTAB nNewPos)
bool bChanged = ( nTab != aRange.aStart.Tab() );
if (bChanged)
+{
+// Save and restore column names, as SetArea() invalidates them.
+::std::vectorOUString aNames( maTableColumnNames);
SetArea( nTab, aRange.aStart.Col(), aRange.aStart.Row(),
aRange.aEnd.Col(),aRange.aEnd .Row() );
+maTableColumnNames = aNames;
+}
// MoveTo ist nicht noetig, wenn nur die Tabelle geaendert ist
@@ -510,12 +517,20 @@ void ScDBData::UpdateReference(ScDocument* pDoc,
UpdateRefMode eUpdateRefMode,
SCTAB theTab2;
GetArea( theTab1, theCol1, theRow1, theCol2, theRow2 );
theTab2 = theTab1;
+SCCOL nOldCol1 = theCol1, nOldCol2 = theCol2;
bool bDoUpdate = ScRefUpdate::Update( pDoc, eUpdateRefMode,
nCol1,nRow1,nTab1,
nCol2,nRow2,nTab2, nDx,nDy,nDz,
theCol1,theRow1,theTab1,
