[Libreoffice-commits] core.git: editeng/source extensions/source include/editeng include/oox include/svx include/vcl lotuswordpro/source oox/inc sc/source sfx2/source svx/source sw/source tools/inc to
editeng/source/misc/svxacorr.cxx |6 +--- editeng/source/rtf/svxrtf.cxx |2 - extensions/source/bibliography/bibmod.cxx |5 ++- extensions/source/bibliography/bibmod.hxx |3 -- include/editeng/svxrtf.hxx|5 +-- include/oox/drawingml/color.hxx |4 --- include/svx/nbdtmg.hxx|2 - include/vcl/salbtype.hxx | 27 +--- lotuswordpro/source/filter/bencont.cxx|4 +-- lotuswordpro/source/filter/bento.hxx | 12 +++-- lotuswordpro/source/filter/benval.cxx |4 +-- lotuswordpro/source/filter/first.hxx |3 -- lotuswordpro/source/filter/tocread.cxx|2 - lotuswordpro/source/filter/tocread.hxx|4 +-- oox/inc/drawingml/textparagraphproperties.hxx |2 - sc/source/ui/formdlg/formula.cxx |4 +-- sc/source/ui/inc/formula.hxx |4 --- sfx2/source/view/viewimp.hxx |3 -- svx/source/sidebar/nbdtmg.cxx | 20 +++ sw/source/core/doc/acmplwrd.cxx |3 -- sw/source/core/doc/htmltbl.cxx|7 + sw/source/ui/dialog/uiregionsw.cxx| 34 +- sw/source/uibase/inc/redlndlg.hxx |4 --- sw/source/uibase/inc/regionsw.hxx |1 sw/source/uibase/misc/redlndlg.cxx|6 ++-- tools/inc/poly.h |5 +-- tools/source/generic/poly2.cxx| 18 ++--- vcl/generic/glyphs/gcach_ftyp.cxx | 10 +++ vcl/inc/octree.hxx| 21 ++-- vcl/inc/outfont.hxx |3 -- vcl/inc/quartz/salvd.h|3 -- vcl/source/gdi/octree.cxx | 14 +- vcl/source/outdev/text.cxx|6 ++-- 33 files changed, 109 insertions(+), 142 deletions(-) New commits: commit d16d9f950f8cb6d8948875372c9ff1f0aae9fb7a Author: Noel Grandin n...@peralex.com Date: Mon Jun 29 14:04:27 2015 +0200 remove some unnecessary typedefs to pointer that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9 diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx index 426c436..070ab11 100644 --- a/editeng/source/misc/svxacorr.cxx +++ b/editeng/source/misc/svxacorr.cxx @@ -95,8 +95,6 @@ static const sal_Char sImplWordChars[] = -'; OUString EncryptBlockName_Imp(const OUString rName); -typedef SvxAutoCorrectLanguageLists* SvxAutoCorrectLanguageListsPtr; - static inline bool IsWordDelim( const sal_Unicode c ) { return ' ' == c || '\t' == c || 0x0a == c || @@ -1563,7 +1561,7 @@ bool SvxAutoCorrect::CreateLanguageFile( const LanguageTag rLanguageTag, bool b OUString sUserDirFile( GetAutoCorrFileName( rLanguageTag, true, false, false )); OUString sShareDirFile( sUserDirFile ); -SvxAutoCorrectLanguageListsPtr pLists = 0; +SvxAutoCorrectLanguageLists* pLists = 0; tools::Time nMinTime( 0, 2 ), nAktTime( tools::Time::SYSTEM ), nLastCheckTime( tools::Time::EMPTY ); @@ -1692,7 +1690,7 @@ static void GeneratePackageName ( const OUString rShort, OUString rPackageName } static const SvxAutocorrWord* lcl_SearchWordsInList( -SvxAutoCorrectLanguageListsPtr pList, const OUString rTxt, +SvxAutoCorrectLanguageLists* pList, const OUString rTxt, sal_Int32 rStt, sal_Int32 nEndPos) { const SvxAutocorrWordList* pAutoCorrWordList = pList-GetAutocorrWordList(); diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx index 1bc5cf1..c4a8221 100644 --- a/editeng/source/rtf/svxrtf.cxx +++ b/editeng/source/rtf/svxrtf.cxx @@ -420,7 +420,7 @@ void SvxRTFParser::ReadColorTable() { // one color is finished, fill in the table // try to map the values to SV internal names -ColorPtr pColor = new Color( nRed, nGreen, nBlue ); +Color* pColor = new Color( nRed, nGreen, nBlue ); if( aColorTbl.empty() sal_uInt8(-1) == nRed sal_uInt8(-1) == nGreen sal_uInt8(-1) == nBlue ) pColor-SetColor( COL_AUTO ); diff --git a/extensions/source/bibliography/bibmod.cxx b/extensions/source/bibliography/bibmod.cxx index cda8769..df76903 100644 --- a/extensions/source/bibliography/bibmod.cxx +++ b/extensions/source/bibliography/bibmod.cxx @@ -28,10 +28,11 @@ #include bibresid.hxx #include datman.hxx #include bibconfig.hxx -static PtrBibModul pBibModul=NULL; -static sal_uInt32 nBibModulCount=0; #include ucbhelper/content.hxx +static BibModul* pBibModul=NULL;
[Libreoffice-bugs] [Bug 78703] SLIDESHOW: fading slide transitions start with a white 'flash'
https://bugs.documentfoundation.org/show_bug.cgi?id=78703 --- Comment #19 from pieter kristensen pieterkristen...@gmail.com --- I am testing 5.0.0.2 Kubuntu 14.04 32 bit. There has always been a white flash during 3d transitions on this computer. With 5.0.0.2 the flash perhaps got a little shorter. But it clearly is still there. The cpu is not a speed monster on this machine http://www.cpubenchmark.net/cpu_lookup.php?cpu=Intel+Celeron+M+530+%40+1.73GHzid=705 (single core) it is possible that that has something to do with it. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |3 ++- vcl/unx/gtk/window/gtksalframe.cxx | 23 +-- 2 files changed, 23 insertions(+), 3 deletions(-) New commits: commit 02b1e14743fa48b365f80e76ecb713877c990c34 Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 30 08:58:04 2015 +0100 gtk3: listen to state-flags-changed and disable toplevels when in backdrop Change-Id: I173618b2e6a2ad69918da8b85ec0eef7099f1d3d diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx index 5086d14..86cc04f 100644 --- a/vcl/inc/unx/gtk/gtkframe.hxx +++ b/vcl/inc/unx/gtk/gtkframe.hxx @@ -238,6 +238,7 @@ class GtkSalFrame : public SalFrame, public X11WindowProvider static void signalStyleSet( GtkWidget*, GtkStyle* pPrevious, gpointer ); #if GTK_CHECK_VERSION(3,0,0) static gboolean signalDraw( GtkWidget*, cairo_t *cr, gpointer ); +static void signalFlagsChanged( GtkWidget*, GtkStateFlags, gpointer ); #if GTK_CHECK_VERSION(3,14,0) static void gestureSwipe(GtkGestureSwipe* gesture, gdouble velocity_x, gdouble velocity_y, gpointer frame); static void gestureLongPress(GtkGestureLongPress* gesture, gpointer frame); @@ -252,7 +253,7 @@ class GtkSalFrame : public SalFrame, public X11WindowProvider static gboolean signalMotion( GtkWidget*, GdkEventMotion*, gpointer ); static gboolean signalKey( GtkWidget*, GdkEventKey*, gpointer ); static gboolean signalDelete( GtkWidget*, GdkEvent*, gpointer ); -static gboolean signalState( GtkWidget*, GdkEvent*, gpointer ); +static gboolean signalWindowState( GtkWidget*, GdkEvent*, gpointer ); static gboolean signalScroll( GtkWidget*, GdkEvent*, gpointer ); static gboolean signalCrossing( GtkWidget*, GdkEventCrossing*, gpointer ); static gboolean signalVisibility( GtkWidget*, GdkEventVisibility*, gpointer ); diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index d9d57af..f6ef61a 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -1035,6 +1035,7 @@ void GtkSalFrame::InitCommon() g_signal_connect( G_OBJECT(m_pWindow), button-release-event, G_CALLBACK(signalButton), this ); #if GTK_CHECK_VERSION(3,0,0) g_signal_connect( G_OBJECT(m_pWindow), draw, G_CALLBACK(signalDraw), this ); +g_signal_connect( G_OBJECT(m_pWindow), state-flags-changed, G_CALLBACK(signalFlagsChanged), this ); #if GTK_CHECK_VERSION(3,14,0) GtkGesture *pSwipe = gtk_gesture_swipe_new(m_pWindow); g_signal_connect(pSwipe, swipe, G_CALLBACK(gestureSwipe), this); @@ -1060,7 +1061,7 @@ void GtkSalFrame::InitCommon() g_signal_connect( G_OBJECT(m_pWindow), key-press-event, G_CALLBACK(signalKey), this ); g_signal_connect( G_OBJECT(m_pWindow), key-release-event, G_CALLBACK(signalKey), this ); g_signal_connect( G_OBJECT(m_pWindow), delete-event, G_CALLBACK(signalDelete), this ); -g_signal_connect( G_OBJECT(m_pWindow), window-state-event, G_CALLBACK(signalState), this ); +g_signal_connect( G_OBJECT(m_pWindow), window-state-event, G_CALLBACK(signalWindowState), this ); g_signal_connect( G_OBJECT(m_pWindow), scroll-event, G_CALLBACK(signalScroll), this ); g_signal_connect( G_OBJECT(m_pWindow), leave-notify-event, G_CALLBACK(signalCrossing), this ); g_signal_connect( G_OBJECT(m_pWindow), enter-notify-event, G_CALLBACK(signalCrossing), this ); @@ -3442,6 +3443,24 @@ gboolean GtkSalFrame::signalButton( GtkWidget*, GdkEventButton* pEvent, gpointer return true; } +#if GTK_CHECK_VERSION(3,0,0) +void GtkSalFrame::signalFlagsChanged( GtkWidget* , GtkStateFlags state, gpointer frame ) +{ +GtkSalFrame* pThis = static_castGtkSalFrame*(frame); + +bool bOldBackDrop = state GTK_STATE_FLAG_BACKDROP; +bool bNewBackDrop = (gtk_widget_get_state_flags(GTK_WIDGET(pThis-m_pWindow)) GTK_STATE_FLAG_BACKDROP); +if (bNewBackDrop !bOldBackDrop) +{ +pThis-GetWindow()-Disable(); +} +else if (bOldBackDrop !bNewBackDrop) +{ +pThis-GetWindow()-Enable(); +} +} +#endif + gboolean GtkSalFrame::signalScroll( GtkWidget*, GdkEvent* pEvent, gpointer frame ) { GtkSalFrame* pThis = static_castGtkSalFrame*(frame); @@ -4047,7 +4066,7 @@ void GtkSalFrame::signalStyleSet( GtkWidget*, GtkStyle* pPrevious, gpointer fram #endif } -gboolean GtkSalFrame::signalState( GtkWidget*, GdkEvent* pEvent, gpointer frame ) +gboolean GtkSalFrame::signalWindowState( GtkWidget*, GdkEvent* pEvent, gpointer frame ) { GtkSalFrame* pThis = static_castGtkSalFrame*(frame); if( (pThis-m_nState GDK_WINDOW_STATE_ICONIFIED) != (pEvent-window_state.new_window_state GDK_WINDOW_STATE_ICONIFIED ) ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92344] Database connection Fails with -Options -Location update
https://bugs.documentfoundation.org/show_bug.cgi?id=92344 rob...@familiegrosskopf.de changed: What|Removed |Added CC||rob...@familiegrosskopf.de --- Comment #1 from rob...@familiegrosskopf.de --- Couldn't confirm. I have created a new database. I created also a tbale. Then I changed the language for GUI and also the Local Setting from German to English. No problem to open the database again, to see the table, to input data ... There have been problems if there is installed also a newer external HSQLDB. Did you also work with an external HSQLDB? My System: OpenSUSE 13.2 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 71057] Missing redraw - Shadow from comments not removed (win only)
https://bugs.documentfoundation.org/show_bug.cgi?id=71057 --- Comment #18 from steve -_- st...@openmailbox.org --- Yep, would be great to have it retested. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92444] Formatting of docx
https://bugs.documentfoundation.org/show_bug.cgi?id=92444 Marc Kaulisch m...@kaulisch.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||m...@kaulisch.de Ever confirmed|0 |1 --- Comment #1 from Marc Kaulisch m...@kaulisch.de --- Hello mal, Thank you for reporting the bug. I can confirm that the bug is present in LO 5.0.0.2 64bit on Win8.1. It is also a loss of information as the second page is not displayed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92110] UI Button with keyboard focus has invisible label (KDE-specific)
https://bugs.documentfoundation.org/show_bug.cgi?id=92110 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||adr...@fowle.co.uk --- Comment #4 from Maxim Monastirsky momonas...@gmail.com --- *** Bug 92437 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86179] SIDEBAR: Properties tab missing font increase and decrease buttons
https://bugs.documentfoundation.org/show_bug.cgi?id=86179 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | --- Comment #2 from Maxim Monastirsky momonas...@gmail.com --- taking. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 64275] EDITING: Cursor position is lost when moving the cursor up and down
https://bugs.documentfoundation.org/show_bug.cgi?id=64275 tommy27 ba...@quipo.it changed: What|Removed |Added OS|All |Windows (All) --- Comment #10 from tommy27 ba...@quipo.it --- @steve the bug was always reported against Windows so I'll check tonight if it's gone for good... your test was done on Mac so in case of a Windows specific issue we cannot be sure that it's fixed in other O/S as well -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/extras/ww8export/data/tdf92281.doc |binary sw/qa/extras/ww8export/ww8export.cxx |8 sw/source/filter/ww8/ww8par6.cxx |2 ++ 3 files changed, 10 insertions(+) New commits: commit 203e3c0f1190473d2e587a0801dc9f3883a6874a Author: Mark Hung mark...@gmail.com Date: Mon Jun 29 21:59:23 2015 +0800 tdf#92281 - FILEOPEN: Only western font is set for symbols in DOC files Inserting a symbol in Writer set all fonts including CJK and CTL to the same one. This patch makes the behavior consistent with that, allows CJK and CTL user to see the symbols. Change-Id: I7a61868e8078c81c68e471760f080b3ce7df589f Reviewed-on: https://gerrit.libreoffice.org/16604 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Miklos Vajna vmik...@collabora.co.uk diff --git a/sw/qa/extras/ww8export/data/tdf92281.doc b/sw/qa/extras/ww8export/data/tdf92281.doc new file mode 100644 index 000..2893eb3 Binary files /dev/null and b/sw/qa/extras/ww8export/data/tdf92281.doc differ diff --git a/sw/qa/extras/ww8export/ww8export.cxx b/sw/qa/extras/ww8export/ww8export.cxx index e1626cd..cdf6d14 100644 --- a/sw/qa/extras/ww8export/ww8export.cxx +++ b/sw/qa/extras/ww8export/ww8export.cxx @@ -452,6 +452,14 @@ DECLARE_WW8EXPORT_TEST(testWw8Cjklist35, cjklist35.doc) CPPUNIT_ASSERT_EQUAL(style::NumberingType::NUMBER_LOWER_ZH, numFormat); } +DECLARE_WW8EXPORT_TEST(testTdf92281, tdf92281.doc) +{ +uno::Referencebeans::XPropertySet xRun(getRun(getParagraph(1),1), uno::UNO_QUERY); +CPPUNIT_ASSERT_EQUAL(OUString(Wingdings), getPropertyOUString(xRun, CharFontName)); +CPPUNIT_ASSERT_EQUAL(OUString(Wingdings), getPropertyOUString(xRun, CharFontNameAsian)); +CPPUNIT_ASSERT_EQUAL(OUString(Wingdings), getPropertyOUString(xRun, CharFontNameComplex)); +} + DECLARE_WW8EXPORT_TEST(testCommentedTable, commented-table.doc) { // Document has a non-trivial commented text range, as the range contains a table. diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx index 45a41a2..4688fc3 100644 --- a/sw/source/filter/ww8/ww8par6.cxx +++ b/sw/source/filter/ww8/ww8par6.cxx @@ -2779,6 +2779,8 @@ void SwWW8ImplReader::Read_Symbol(sal_uInt16, const sal_uInt8* pData, short nLen //themselves so they don't need to add it to the stack either. if (SetNewFontAttr(SVBT16ToShort( pData ), false, RES_CHRATR_FONT)) { +SetNewFontAttr(SVBT16ToShort( pData ), false, RES_CHRATR_CJK_FONT); +SetNewFontAttr(SVBT16ToShort( pData ), false, RES_CHRATR_CTL_FONT); if( m_bVer67 ) { //convert single byte from MS1252 to Unicode ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92371] REPORT BUILDER: when create spreadsheet report, Number 0 data is not output to report
https://bugs.documentfoundation.org/show_bug.cgi?id=92371 rob...@familiegrosskopf.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||rob...@familiegrosskopf.de Version|5.0.0.1 rc |4.0.0.3 release Ever confirmed|0 |1 --- Comment #1 from rob...@familiegrosskopf.de --- Could confirm '0' isn't shown if the format is Number. Try to change the formatting of the field to Text. The '0' will be shown. The bug appears in all LO-versions I have installed. LO before 4.0 doesn't show any number, if report-output is set to spreadsheet. So could be it exists since the beginning of LO. My system: OpenSUSE 13.2 64bit rpm Linux. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92443] New: And again - no visible menu entrys and empty dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=92443 Bug ID: 92443 Summary: And again - no visible menu entrys and empty dialogs Product: LibreOffice Version: 5.0.0.2 rc Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@mic-consulting.de Created attachment 116941 -- https://bugs.documentfoundation.org/attachment.cgi?id=116941action=edit Exampel file (contains macros!) Again with LibO RC2 (32 bit) on Win 8.1 64 bit. (regression) After opening a complex file (attached) Menu-entrys are empty (see Screenshot) - new Windows/frames are empty too. This is a rendering problem - I have done a similar bug-report some weeks ago - but cannot find him again. After some time (2 to 5 min) sometimes the menues will work as expected - never after opening the file! Test on two different machines (Win 8.1 64 bit) with LibO 5.0.0.2 (32 bit), 5.0.0.1 (32bit), 5.0.0.1 beta (64 bit). Everything works ok with versions 4.4.x (32 bit)!! This is unusable for normal users - cannot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 6 commits - sw/source
sw/source/core/crsr/crsrsh.cxx |2 - sw/source/core/crsr/crstrvl.cxx |6 +-- sw/source/core/crsr/swcrsr.cxx |4 +- sw/source/core/crsr/trvlcol.cxx |2 - sw/source/core/doc/notxtfrm.cxx |2 - sw/source/core/edit/autofmt.cxx |3 + sw/source/core/frmedt/fews.cxx |4 +- sw/source/core/frmedt/tblsel.cxx|4 +- sw/source/core/inc/flyfrm.hxx |2 - sw/source/core/inc/frame.hxx|9 + sw/source/core/layout/anchoreddrawobject.cxx|4 +- sw/source/core/layout/calcmove.cxx | 30 +- sw/source/core/layout/flowfrm.cxx | 16 - sw/source/core/layout/fly.cxx | 17 ++ sw/source/core/layout/flyincnt.cxx |6 +-- sw/source/core/layout/flylay.cxx|4 +- sw/source/core/layout/frmtool.cxx |2 - sw/source/core/layout/ftnfrm.cxx| 40 sw/source/core/layout/hffrm.cxx |2 - sw/source/core/layout/layact.cxx| 27 +--- sw/source/core/layout/objectformatter.cxx |3 + sw/source/core/layout/objectformattertxtfrm.cxx | 11 +++--- sw/source/core/layout/pagechg.cxx | 13 --- sw/source/core/layout/paintfrm.cxx | 10 +++--- sw/source/core/layout/sectfrm.cxx | 31 ++ sw/source/core/layout/tabfrm.cxx| 24 -- sw/source/core/layout/trvlfrm.cxx | 34 +--- sw/source/core/layout/wsfrm.cxx |7 ++-- sw/source/core/text/frmform.cxx | 16 ++--- sw/source/core/text/txtfrm.cxx |3 + sw/source/core/text/txthyph.cxx |3 + sw/source/core/unocore/unotbl.cxx |4 +- sw/source/core/view/pagepreviewlayout.cxx |6 ++- sw/source/core/view/viewsh.cxx | 30 +++--- sw/source/core/view/vprint.cxx |2 - 35 files changed, 221 insertions(+), 162 deletions(-) New commits: commit cc12ac738eeb3e6f1fa7c3dd20febb313dfa33f4 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Jun 29 18:35:12 2015 +0200 SwViewShell::ImplEndAction: avoid direct paint Commit 56dd27d9ed829ea0444b3b5932dcd0d431d6e251 (sw: invalidate after keypresses when we have a callback, 2015-01-13) only enabled invalidate-then-paint for the tiled rendering case, because the main loop had no priorities back then. This limitation went away with 48c2815dd20cf20eeec8bb4e003000f4a3d13291 (tdf#91727 - Unwind non-dispatch of idle handlers., 2015-06-10), so it's not a problem to always do this panting inside the Paint() call. Change-Id: I98ddfcc0f20f1553974b74ec3c859dde315612e4 Reviewed-on: https://gerrit.libreoffice.org/16587 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Jenkins c...@libreoffice.org (cherry picked from commit beb4aa21d61f0d66392d596be86fb57b4b167239) diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index fa443ab..13439a8 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -410,10 +410,7 @@ void SwViewShell::ImplEndAction( const bool bIdleEnd ) if ( bPaintsFromSystem ) PaintDesktop(*GetOut(), aRect); -if (!isTiledRendering()) -pCurrentLayout-Paint( *mpOut, aRect ); -else - pCurrentLayout-GetCurrShell()-InvalidateWindows(aRect.SVRect()); + pCurrentLayout-GetCurrShell()-InvalidateWindows(aRect.SVRect()); // #i75172# end DrawingLayer paint DLPostPaint2(true); commit b265e4e9d63d4603ec6985fedf6941bdbcba4d74 Author: Miklos Vajna vmik...@collabora.co.uk Date: Mon Jun 29 17:05:50 2015 +0200 SwViewShell::Paint: restore old render context at the end The idea is that mpOut is only used for non-drawing purposes outside Paint(), e.g. to do logic - pixel conversion. Change-Id: Ia83cd32dd0a5152dcfc1644e92af08b4ddf4653c Reviewed-on: https://gerrit.libreoffice.org/16584 Reviewed-by: Miklos Vajna vmik...@collabora.co.uk Tested-by: Jenkins c...@libreoffice.org (cherry picked from commit 98d2d985082114ec259c11788af7b8574f2c9b3d) diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 89940c6..fa443ab 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -1664,9 +1664,32 @@ bool SwViewShell::CheckInvalidForPaint( const SwRect rRect ) return bRet; } +namespace +{ +/// Similar to
Power outage
FYI power outage here so Jenkins is going to be blocked due to no Mac slave online ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'feature/unitver' - 2 commits - sc/qa sc/source
sc/qa/unit/units.cxx | 20 sc/source/core/units/unitsimpl.cxx |2 +- 2 files changed, 21 insertions(+), 1 deletion(-) New commits: commit 122874c94da9da8b5a05bef3f883338fb68cd32e Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Jun 30 09:25:29 2015 +0200 add test case for unit conversion Change-Id: I726758c93b25ed16b5708a71645004537f32ac76 diff --git a/sc/qa/unit/units.cxx b/sc/qa/unit/units.cxx index 1dbf74f..ee6af8a 100644 --- a/sc/qa/unit/units.cxx +++ b/sc/qa/unit/units.cxx @@ -14,6 +14,8 @@ #include helper/qahelper.hxx +#include rangelst.hxx + #include com/sun/star/util/NumberFormat.hpp using namespace sc::units; @@ -50,6 +52,7 @@ public: void testUnitsCompatible(); void testCellConversion(); +void testConvertCellUnits(); void testUnitsForRange(); void testRangeConversion(); @@ -64,6 +67,7 @@ public: CPPUNIT_TEST(testUnitsCompatible); CPPUNIT_TEST(testCellConversion); +CPPUNIT_TEST(testConvertCellUnits); CPPUNIT_TEST(testUnitsForRange); CPPUNIT_TEST(testRangeConversion); @@ -877,6 +881,22 @@ void UnitsTest::testRangeConversion() { // 3. actual sensible ranges } +void UnitsTest::testConvertCellUnits() +{ +mpDoc-EnsureTable(0); + +// Set up a column with a normal header and a few data values +ScAddress aAddress(20, 0, 0); +mpDoc-SetString(aAddress, 100km); +ScRange aRange(aAddress); +ScRangeList aRangeList(aRange); +OUString aOutput(miles); +bool bConverted = mpUnitsImpl-convertCellUnits(aRangeList, mpDoc, aOutput); +CPPUNIT_ASSERT(bConverted); +double nVal = mpDoc-GetValue(aAddress); +CPPUNIT_ASSERT_DOUBLES_EQUAL(62.1371192932129, nVal, 1e-14); +} + CPPUNIT_TEST_SUITE_REGISTRATION(UnitsTest); CPPUNIT_PLUGIN_IMPLEMENT(); commit 4f50fc6d1740a47220c4cbafd91af9bde80113b9 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Tue Jun 30 09:25:07 2015 +0200 fix crash when converting units Change-Id: Ic883e13b5c6923c31e65a887597f0910807dc94d diff --git a/sc/source/core/units/unitsimpl.cxx b/sc/source/core/units/unitsimpl.cxx index 7d16ae3..4f0057c 100644 --- a/sc/source/core/units/unitsimpl.cxx +++ b/sc/source/core/units/unitsimpl.cxx @@ -780,7 +780,7 @@ bool UnitsImpl::convertCellUnitsForColumnRange(const ScRange rRange, } } -bool bLocalAnnotationRequired = (!rRange.In(*aHeader.address)) +bool bLocalAnnotationRequired = (aHeader.address !rRange.In(*aHeader.address)) (rOutputUnit != aHeader.unit); double nValue = pDoc-GetValue(aCurrent); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92446] Crash in Windows and Runtime exception on Linux with Basic Clipboard function
https://bugs.documentfoundation.org/show_bug.cgi?id=92446 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added CC||c...@nouenoff.nl --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Created attachment 116946 -- https://bugs.documentfoundation.org/attachment.cgi?id=116946action=edit test document for error / crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92446] Crash in Windows and Runtime exception on Linux with Basic Clipboard function
https://bugs.documentfoundation.org/show_bug.cgi?id=92446 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Keywords||regression Whiteboard||bibisectrequest -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/menu.cxx |9 + vcl/source/window/menubarwindow.cxx |4 2 files changed, 9 insertions(+), 4 deletions(-) New commits: commit 67d0aee921ae7c10bfd823097db73d7f125faa3a Author: Caolán McNamara caol...@redhat.com Date: Tue Jun 30 09:48:39 2015 +0100 gtk3: draw disabled menubars entries with disabled text color Change-Id: I9188c6071f62d13a688c1eb6b14b1ac3f7dc77d4 diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index 7acd139..8f2a93f 100644 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -1878,7 +1878,7 @@ void Menu::ImplPaint(vcl::RenderContext rRenderContext, // contained. The application itself should check for this! // Otherwise it could happen entries are disabled due to // asynchronous loading -if (!pData-bEnabled) +if (!pData-bEnabled || !pWindow-IsEnabled()) { nTextStyle |= DrawTextFlags::Disable; nSymbolStyle |= DrawSymbolFlags::Disable; @@ -1892,7 +1892,7 @@ void Menu::ImplPaint(vcl::RenderContext rRenderContext, if (rRenderContext.IsNativeControlSupported(CTRL_MENU_POPUP, PART_MENU_SEPARATOR)) { ControlState nState = ControlState::NONE; -if (pData-bEnabled) +if (pData-bEnabled !pWindow-IsEnabled()) nState |= ControlState::ENABLED; if (bHighlighted) nState |= ControlState::SELECTED; @@ -1948,7 +1948,7 @@ void Menu::ImplPaint(vcl::RenderContext rRenderContext, if (pData-bChecked) nState |= ControlState::PRESSED; -if (pData-bEnabled) +if (pData-bEnabled !pWindow-IsEnabled()) nState |= ControlState::ENABLED; if (bHighlighted) @@ -2019,6 +2019,7 @@ void Menu::ImplPaint(vcl::RenderContext rRenderContext, aTmpPos.Y() = aPos.Y(); aTmpPos.Y() += nTextOffsetY; DrawTextFlags nStyle = nTextStyle | DrawTextFlags::Mnemonic; + if (pData-bIsTemporary) nStyle |= DrawTextFlags::Disable; MetricVector* pVector = bLayout ? mpLayoutData-m_aUnicodeBoundRects : NULL; @@ -2088,7 +2089,7 @@ void Menu::ImplPaint(vcl::RenderContext rRenderContext, aSpacing = nOuterSpaceX; } -if (pData-bEnabled) +if (pData-bEnabled !pWindow-IsEnabled()) nState |= ControlState::ENABLED; if (bHighlighted) nState |= ControlState::SELECTED; diff --git a/vcl/source/window/menubarwindow.cxx b/vcl/source/window/menubarwindow.cxx index 3bc064a..e6fe646 100644 --- a/vcl/source/window/menubarwindow.cxx +++ b/vcl/source/window/menubarwindow.cxx @@ -993,6 +993,10 @@ void MenuBarWindow::StateChanged( StateChangedType nType ) ApplySettings(*this); Invalidate(); } +else if (nType == StateChangedType::Enable) +{ +Invalidate(); +} else if(pMenu) { pMenu-ImplKillLayoutData(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92429] PATCH: allow generation of install set with PRODUCTNAME != LibreOffice
https://bugs.documentfoundation.org/show_bug.cgi?id=92429 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92110] UI Button with keyboard focus has invisible label (KDE-specific)
https://bugs.documentfoundation.org/show_bug.cgi?id=92110 Beluga todven...@suomi24.fi changed: What|Removed |Added Priority|medium |high --- Comment #6 from Beluga todven...@suomi24.fi --- This is so visible, I'll set priority to high. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92446] New: Crash in Windows and Runtime exception on Linux with Basic Clipboard function
https://bugs.documentfoundation.org/show_bug.cgi?id=92446 Bug ID: 92446 Summary: Crash in Windows and Runtime exception on Linux with Basic Clipboard function Product: LibreOffice Version: 4.4.0.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: c...@nouenoff.nl I'll attach a test document with macro and explanation. Runs fine in for example 4.2.x Does not run in 4.4.x Crash on Windows: Error on Linux: Basic runtime error / An exception occured Type: com.sun.star.uno.RunTimeException Message: type coercion failed: conversion not possible at line 26: oClipContents = oClip.setContents(oTRX, null). on exiting function Function TR_getTransferDataFlavors() As Any (line 46) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 14 commits - sw/inc sw/source
sw/inc/unochart.hxx |2 sw/inc/unotbl.hxx | 24 +-- sw/source/core/unocore/unochart.cxx | 131 +++ sw/source/core/unocore/unotbl.cxx | 240 ++-- 4 files changed, 129 insertions(+), 268 deletions(-) New commits: commit a1b73b37c761a4bea51fb17f1158c98f579eb305 Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Sun Jun 28 13:21:17 2015 +0200 getCells-GetCells(): not an UNO function Change-Id: I89335201083bd68fa199ce52e78d7750c60f8895 diff --git a/sw/inc/unochart.hxx b/sw/inc/unochart.hxx index 580368a..3f59dd3 100644 --- a/sw/inc/unochart.hxx +++ b/sw/inc/unochart.hxx @@ -350,7 +350,7 @@ public: voidFillRangeDesc( SwRangeDescriptor rRangeDesc ) const; boolExtendTo( bool bExtendCol, sal_Int32 nFirstNew, sal_Int32 nCount ); -std::vector css::uno::Reference css::table::XCell getCells(); +std::vector css::uno::Reference css::table::XCell GetCells(); }; typedef cppu::WeakImplHelper diff --git a/sw/inc/unotbl.hxx b/sw/inc/unotbl.hxx index 94fb3bd..e8009a8 100644 --- a/sw/inc/unotbl.hxx +++ b/sw/inc/unotbl.hxx @@ -471,7 +471,7 @@ public: void SetLabels(bool bFirstRowAsLabel, bool bFirstColumnAsLabel) { m_bFirstRowAsLabel = bFirstRowAsLabel, m_bFirstColumnAsLabel = bFirstColumnAsLabel; } virtual ~SwXCellRange() {}; -std::vector css::uno::Reference css::table::XCell getCells(); +std::vector css::uno::Reference css::table::XCell GetCells(); TYPEINFO_OVERRIDE(); diff --git a/sw/source/core/unocore/unochart.cxx b/sw/source/core/unocore/unochart.cxx index b95ec32..ed8d35a 100644 --- a/sw/source/core/unocore/unochart.cxx +++ b/sw/source/core/unocore/unochart.cxx @@ -2135,7 +2135,7 @@ uno::Sequence OUString SAL_CALL SwChartDataSequence::generateLabel( return 0; } -std::vector css::uno::Reference css::table::XCell SwChartDataSequence::getCells() +std::vector css::uno::Reference css::table::XCell SwChartDataSequence::GetCells() { if (bDisposed) throw lang::DisposedException(); @@ -2148,14 +2148,14 @@ std::vector css::uno::Reference css::table::XCell SwChartDataSequence::get SwRangeDescriptor aDesc; if(!FillRangeDescriptor(aDesc, GetCellRangeName(*pTableFormat, *pTableCrsr))) return {}; -return SwXCellRange(pTableCrsr, *pTableFormat, aDesc).getCells(); +return SwXCellRange(pTableCrsr, *pTableFormat, aDesc).GetCells(); } uno::Sequence OUString SAL_CALL SwChartDataSequence::getTextualData() throw (uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; -auto vCells(getCells()); +auto vCells(GetCells()); uno::Sequence OUString vTextData(vCells.size()); std::transform(vCells.begin(), vCells.end(), @@ -2169,7 +2169,7 @@ uno::Sequence uno::Any SAL_CALL SwChartDataSequence::getData() throw (uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; -auto vCells(getCells()); +auto vCells(GetCells()); uno::Sequence uno::Any vAnyData(vCells.size()); std::transform(vCells.begin(), vCells.end(), @@ -2183,7 +2183,7 @@ uno::Sequence double SAL_CALL SwChartDataSequence::getNumericalData() throw (uno::RuntimeException, std::exception) { SolarMutexGuard aGuard; -auto vCells(getCells()); +auto vCells(GetCells()); uno::Sequence double vNumData(vCells.size()); std::transform(vCells.begin(), vCells.end(), diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx index 1b5616d..fd3e489 100644 --- a/sw/source/core/unocore/unotbl.cxx +++ b/sw/source/core/unocore/unotbl.cxx @@ -3180,7 +3180,7 @@ SwXCellRange::SwXCellRange(sw::UnoCursorPointer pCrsr, SwFrameFormat rFrameForm aRgDesc.Normalize(); } -std::vector uno::Reference table::XCell SwXCellRange::getCells() +std::vector uno::Reference table::XCell SwXCellRange::GetCells() { SwFrameFormat* const pFormat = GetFrameFormat(); const sal_Int32 nRowCount(getRowCount()); @@ -3512,7 +3512,7 @@ uno::Sequence uno::Sequence uno::Any SAL_CALL SwXCellRange::getDataArray() throw uno::RuntimeException(Table too complex, static_castcppu::OWeakObject*(this)); lcl_EnsureCoreConnected(GetFrameFormat(), static_castcppu::OWeakObject*(this)); uno::Sequence uno::Sequence uno::Any aRowSeq(nRowCount); -auto vCells(getCells()); +auto vCells(GetCells()); auto pCurrentCell(vCells.begin()); for(auto rRow : aRowSeq) { @@ -3542,7 +3542,7 @@ void SAL_CALL SwXCellRange::setDataArray(const uno::Sequence uno::Sequence uno return; if(rArray.getLength() != nRowCount) throw uno::RuntimeException(Row count mismatch. expected: + OUString::number(nRowCount) + got: + OUString::number(rArray.getLength()), static_castcppu::OWeakObject*(this)); -auto vCells(getCells()); +auto vCells(GetCells());
[Libreoffice-bugs] [Bug 92444] Formatting of docx
https://bugs.documentfoundation.org/show_bug.cgi?id=92444 --- Comment #2 from mal malc...@whsg.info --- Since we are a school and our students seem to have a particular knack at producing documents that look like this one, do you want me to report them as bugs? I could do them individually or batch up a few at a time. Ta Mal -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sw/source
sw/source/core/view/viewsh.cxx | 29 - 1 file changed, 12 insertions(+), 17 deletions(-) New commits: commit 82307b16f89250d5fd724806f51823a38f7e202f Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Jun 30 10:33:50 2015 +0200 sw rendercontext: update drawlayer in SwViewShell::Paint Fixes warnings on startup like: warn:legacy.osl:13026:1:svx/source/svdraw/svdpntv.cxx:813: SdrPaintView::UpdateDrawLayersRegion: No SdrPaintWindow (!) when double buffering is enabled for SwEditWin. Change-Id: I3dd8019a158b7d50c5e460abf504da31aabe72c3 diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index 33e85d1..d65d213 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -1669,17 +1669,23 @@ class RenderContextGuard { VclPtrvcl::RenderContext m_pRef; vcl::RenderContext* m_pOriginalValue; +SwViewShell* m_pShell; public: -RenderContextGuard(VclPtrvcl::RenderContext pRef, vcl::RenderContext* pValue) +RenderContextGuard(VclPtrvcl::RenderContext pRef, vcl::RenderContext* pValue, SwViewShell* pShell) : m_pRef(pRef), -m_pOriginalValue(m_pRef) +m_pOriginalValue(m_pRef), +m_pShell(pShell) { m_pRef = pValue; +if (pValue != m_pShell-GetWin() m_pShell-Imp()-GetDrawView()) +m_pShell-Imp()-GetDrawView()-AddWindowToPaintView(pValue); } ~RenderContextGuard() { +if (m_pRef != m_pShell-GetWin() m_pShell-Imp()-GetDrawView()) +m_pShell-Imp()-GetDrawView()-DeleteWindowFromPaintView(m_pRef); m_pRef = m_pOriginalValue; } }; @@ -1687,7 +1693,7 @@ public: void SwViewShell::Paint(vcl::RenderContext rRenderContext, const Rectangle rRect) { -RenderContextGuard aGuard(mpOut, rRenderContext); +RenderContextGuard aGuard(mpOut, rRenderContext, this); if ( mnLockPaint ) { if ( Imp()-bSmoothUpdate ) @@ -1846,12 +1852,6 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int contextWidth, int contex aMapMode.SetScaleY(scaleY); rDevice.SetMapMode(aMapMode); -// Update this device in DrawLayer -if (Imp()-GetDrawView()) -{ -Imp()-GetDrawView()-AddWindowToPaintView(rDevice); -} - Rectangle aOutRect = Rectangle(Point(tilePosX, tilePosY), rDevice.PixelToLogic(Size(contextWidth, contextHeight))); @@ -1870,12 +1870,6 @@ void SwViewShell::PaintTile(VirtualDevice rDevice, int contextWidth, int contex // draw - works in logic coordinates Paint(rDevice, aOutRect); -// Remove this device in DrawLayer -if (Imp()-GetDrawView()) -{ -Imp()-GetDrawView()-DeleteWindowFromPaintView(rDevice); -} - // SwViewShell's output device tear down mpOut = pSaveOut; mbInLibreOfficeKitCallback = false; commit af9d02a24bc61c9a531157ed6a49b25c47668277 Author: Miklos Vajna vmik...@collabora.co.uk Date: Tue Jun 30 10:15:23 2015 +0200 SwViewShell::DLPrePaint2: paint to mpOut if isOutputToWindow() With this, most of the SwEditWin is painted to the virtual device in case of double buffering, not directly to the screen (avoids flickering). Change-Id: If93aa082daaec6b0e2c417ebc7367e5ab601aa2c diff --git a/sw/source/core/view/viewsh.cxx b/sw/source/core/view/viewsh.cxx index a835373..33e85d1 100644 --- a/sw/source/core/view/viewsh.cxx +++ b/sw/source/core/view/viewsh.cxx @@ -188,8 +188,9 @@ void SwViewShell::DLPrePaint2(const vcl::Region rRegion) if ( !HasDrawView() ) MakeDrawView(); -// Prefer window; if tot available, get mpOut (e.g. printer) -mpPrePostOutDev = (GetWin() !isTiledRendering())? GetWin(): GetOut(); +// Prefer window; if not available, get mpOut (e.g. printer) +const bool bWindow = GetWin() !isTiledRendering() !isOutputToWindow(); +mpPrePostOutDev = bWindow ? GetWin(): GetOut(); // #i74769# use SdrPaintWindow now direct mpTargetPaintWindow = Imp()-GetDrawView()-BeginDrawLayers(mpPrePostOutDev, rRegion); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/TileLayer.js | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) New commits: commit d0f420bc812b59a68f0f7a48ba9c79104b87313b Author: Mihai Varga mihai.va...@collabora.com Date: Tue Jun 30 11:34:24 2015 +0300 Added a set of keys that need to be handled on the keydown event diff --git a/loleaflet/src/layer/tile/TileLayer.js b/loleaflet/src/layer/tile/TileLayer.js index fbe61f6..7a6c19c 100644 --- a/loleaflet/src/layer/tile/TileLayer.js +++ b/loleaflet/src/layer/tile/TileLayer.js @@ -92,6 +92,26 @@ L.TileLayer = L.GridLayer.extend({ 222 : null // single quote : UNKOWN }, + handleOnKeyDown: { + // these keys need to be handled on keydown in order for them + // to work on chrome + 8 : true, // backspace + 9 : true, // tab + 19 : true, // pause/break + 20 : true, // caps lock + 27 : true, // escape + 33 : true, // page up + 34 : true, // page down + 35 : true, // end + 36 : true, // home + 37 : true, // left arrow + 38 : true, // up arrow + 39 : true, // right arrow + 40 : true, // down arrow + 45 : true, // insert + 46 : true // delete + }, + initialize: function (url, options) { this._url = url; @@ -825,16 +845,10 @@ L.TileLayer = L.GridLayer.extend({ var charCode = e.originalEvent.charCode; var keyCode = e.originalEvent.keyCode; - // TODO handle browser differences - if (e.type === 'keydown' keyCode === 8) { - // chrome backspace + if (e.type === 'keydown' this.handleOnKeyDown[keyCode]) { this._postKeyboardEvent('input', charCode, this._toUNOKeyCode(keyCode)); } - else if (e.type === 'keypress') { - if (keyCode === 8) { - // backspace has already been handled - return; - } + else if (e.type === 'keypress' !this.handleOnKeyDown[keyCode]) { if (charCode === keyCode charCode !== 13) { // Chrome sets keyCode = charCode for printable keys // while LO requires it to be 0 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92428] See Attached Fatal Error
https://bugs.documentfoundation.org/show_bug.cgi?id=92428 tommy27 ba...@quipo.it changed: What|Removed |Added Summary|See Attached|See Attached Fatal Error -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92428] See Attached
https://bugs.documentfoundation.org/show_bug.cgi?id=92428 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- please give a more detailed description of the bug... which ecact LibO version do you run (it seems you are on 4.3.x), which O/S and which situation you see that fatal error message also consider upgrading to LibO 4.4.x to see if the bug persists. set status to NEEDINFO -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92447] New: sub-cell text style is removed/misapplied during search/replace
https://bugs.documentfoundation.org/show_bug.cgi?id=92447 Bug ID: 92447 Summary: sub-cell text style is removed/misapplied during search/replace Product: LibreOffice Version: 4.3.3.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: localc...@dispostable.com Steps to reproduce: 1) in a new spreadsheet, enter text AAABBB into a Calc cell 2) select the AAA part of text 3) from toolbar, select Font Color and apply any color to AAA 4) the cell now contains colorAAA/colorBBB 4) press Ctrl-H to open the Search Replace dialog 5) Search for B, Replace with C, press Replace Bug A: Expected behaviour: Cell should contain colorAAA/colorCCC. Actual behaviour: Cell contains AAACCC. This is an errorneous behaviour I was able to reproduce. A similar errorneous behaviour I originally encountered in an .xls file (saved both in Excel and Calc) resulted in colorAAACCC/color after performing the same steps (on different text with the same style). Bug B: Expected behaviour: Press Ctrl-Z to undo. Cell should contain colorAAA/colorBBB. Actual behaviour: Press Ctrl-Z to undo. Cell contains AAABBB. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92443] And again - no visible menu entrys and empty dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=92443 --- Comment #1 from Thomas Krumbein t...@mic-consulting.de --- Created attachment 116942 -- https://bugs.documentfoundation.org/attachment.cgi?id=116942action=edit no visual menu-entrys -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92281] FILEOPEN: Only western font is set for symbols in DOC files
https://bugs.documentfoundation.org/show_bug.cgi?id=92281 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92281] FILEOPEN: Only western font is set for symbols in DOC files
https://bugs.documentfoundation.org/show_bug.cgi?id=92281 --- Comment #1 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Mark Hung committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=203e3c0f1190473d2e587a0801dc9f3883a6874a tdf#92281 - FILEOPEN: Only western font is set for symbols in DOC files It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92443] And again - no visible menu entrys and empty dialogs
https://bugs.documentfoundation.org/show_bug.cgi?id=92443 --- Comment #2 from Thomas Krumbein t...@mic-consulting.de --- Created attachment 116943 -- https://bugs.documentfoundation.org/attachment.cgi?id=116943action=edit empty frame on Win 8.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92110] UI Button with keyboard focus has invisible label (KDE-specific)
https://bugs.documentfoundation.org/show_bug.cgi?id=92110 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #5 from tommy27 ba...@quipo.it --- Bug 92437 reported under opensuse 13.2 x86_64 and KDE Platform Version 4.14.8 using LibO 5.0.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92439] Creating entire column/s or entire row/s ranges in formulae by clicking on column/row heading/s
https://bugs.documentfoundation.org/show_bug.cgi?id=92439 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||468 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||468 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92468] Circular reference in formulae containing entire column/row notation A:A/1:1
https://bugs.documentfoundation.org/show_bug.cgi?id=92468 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=44 ||419, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||439, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||441, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||427, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||426, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||452, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||453 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92269] 5.0.0.1 Win 64 Explorer Crash after single click on any LO file in folder. (shlxthdl.dll / propertyhdl.dll property handler problem?)
https://bugs.documentfoundation.org/show_bug.cgi?id=92269 --- Comment #25 from Eric M siser...@gmail.com --- (In reply to Kevin Suo from comment #24) I encounter the explorer crash after install LibreOffice 5.0.0 version in my Win 7 PC. However my OS is 32bit. Is it the same problem, or should a file a new bug? Does the crash occur in the same way? Does the mentioned workaround stop the crash? If the behaviour you have encountered is the same, you don't need to file a new bug. Confirming that an existing bug is reproducible (as you have done) is enough. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92148] Math: LibreOffice locks up if the bar on the left is resized
https://bugs.documentfoundation.org/show_bug.cgi?id=92148 Terrence Enger lo_b...@iseries-guru.com changed: What|Removed |Added CC||jop...@gmail.com Component|Writer |Formula Editor --- Comment #6 from Terrence Enger lo_b...@iseries-guru.com --- Setting component = Formula Editor. Jonas, Can you help us out on this bug report? I see it as fairly urgent: 5.0.0 RC3 is scheduled within a week. I shall also send an email to juergen.f...@cib.de. Tobias, Thank you for your help. Having added you to the cc, I am leaving it to you to remove yourself if you are so inclined. Terry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92269] 5.0.0.1 Win 64 Explorer Crash after single click on any LO file in folder. (shlxthdl.dll / propertyhdl.dll property handler problem?)
https://bugs.documentfoundation.org/show_bug.cgi?id=92269 Kevin Suo suokunl...@126.com changed: What|Removed |Added CC||suokunl...@126.com --- Comment #24 from Kevin Suo suokunl...@126.com --- I encounter the explorer crash after install LibreOffice 5.0.0 version in my Win 7 PC. However my OS is 32bit. Is it the same problem, or should a file a new bug? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||468 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/core/tool/compiler.cxx | 12 1 file changed, 12 insertions(+) New commits: commit fb799a2f6fc21bde34cd36763f6003b845c6a093 Author: Eike Rathke er...@redhat.com Date: Thu Jun 25 22:54:37 2015 +0200 tdf#44419 in second reference part stop number parsing at separator Change-Id: I70218bc41df0d56ab42d652aa7ac51733dc06f4b (cherry picked from commit 71dba79c1c84d693a59c53a8965caef0ddd1c2cc) Reviewed-on: https://gerrit.libreoffice.org/16496 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx index f192230..cef2cf7 100644 --- a/sc/source/core/tool/compiler.cxx +++ b/sc/source/core/tool/compiler.cxx @@ -2367,6 +2367,18 @@ Label_MaskStateMachine: } else { +// When having parsed a second reference part, ensure that the +// i18n parser did not mistakingly parse a number that included +// a separator which happened to be meant as a parameter +// separator instead. +if (mnRangeOpPosInSymbol = 0 (aRes.TokenType KParseType::ASC_NUMBER)) +{ +for (sal_Int32 i = nSrcPos; i aRes.EndPos; ++i) +{ +if (pStart[i] == cSep) +aRes.EndPos = i;// also ends for +} +} aSymbol.append( pStart + nSrcPos, aRes.EndPos - nSrcPos); nSrcPos = aRes.EndPos; c = pStart[nSrcPos]; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92453] New: Entire column functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92453 Bug ID: 92453 Summary: Entire column functionality in formulae keyboard shortcuts Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ov...@hotmail.com Microsoft Excel entire column notation in formulae functionality 1. In cell A1 enter: =SUM( 2. Press the right arrow once (you should be in cell B1), and the formula in cell A1 should be: =SUM(B1 3. In Microsoft Excel, press Ctrl+SpaceBar (this selects the entire column), and the formula in cell A1 should be: =SUM(B:B 4. Press enter, and the formula in A1 autocompletes the right parentheses: =SUM(B:B) Eike Rathke has done wonderful work in enabling LibreOffice to understand entire row(s)/column(s) 1:1/A:A notation in formulae. However, LibreOffice 5.1.0.0.alpha1+ doesn't understand step 3 above, i.e. the keyboard shortcut: Ctrl+SpaceBar to select an entire column. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90575] DDE LINK does not work between two documents Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=90575 Thomas Krumbein t...@mic-consulting.de changed: What|Removed |Added CC||t...@mic-consulting.de --- Comment #4 from Thomas Krumbein t...@mic-consulting.de --- Same problems using writer-doc as source and calc - doc as target. Result in calc-cell: #NV Tested with 5.0.0.0 beta 3 (64 bit) and 5.0.0.2 (32 bit) on Win 8.1 (64bit). Inserted formula in calc is correct - but result is #NV BTW: using DDE fram calt to writer works correct. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/debug
loleaflet/debug/document/document_simple_example.html |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit fca2f030feea6fa1ef7b0b17f729facfce1bbaf0 Author: Mihai Varga mihai.va...@collabora.com Date: Tue Jun 30 15:05:32 2015 +0300 Just mention that this will be the future toolbar diff --git a/loleaflet/debug/document/document_simple_example.html b/loleaflet/debug/document/document_simple_example.html index d6b4f26..2b4b394 100644 --- a/loleaflet/debug/document/document_simple_example.html +++ b/loleaflet/debug/document/document_simple_example.html @@ -28,8 +28,7 @@ and width, this being inside the smaller document-container will cause the content to overflow, creating scrollbars -- div id=toolbar align=center -p style=margin:0pxThis space is a placeholder for the future toolbar, so far contains -only zoom and search:/p +p style=margin:0pxThis space is a placeholder for the future toolbar/p /div div id=document-container style=top:100px div id=clipboard-containertextarea id=clipboard/textarea/div ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 88196] SLIDESHOW
https://bugs.documentfoundation.org/show_bug.cgi?id=88196 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||959 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87958] VIEWING Spinning writing with shadow and textbox disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=87958 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||959 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87959] VIEWING: Impress Too big Pixels and displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=87959 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||958, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||196 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||426 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||439, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||441, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||427, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||452, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||453 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||426 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92453] Entire column functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92453 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||426 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 --- Comment #1 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Eike Rathke committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=07cd14f1e3ee718e56d063db8c331bec173f4408 tdf#92426 explicitly set valid row/col for entire col/row references It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 Eike Rathke er...@redhat.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/core/tool/address.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 59487150df556457cb3c919b0b0ea5d6b625b185 Author: Eike Rathke er...@redhat.com Date: Tue Jun 30 14:30:20 2015 +0200 tdf#92426 explicitly set valid row/col for entire col/row references ... for callers that individually check for them, like ScRange::ParseAny() Change-Id: I23fc2c178a9c89b59f99f2fb86223324b7e5d378 (cherry picked from commit 07cd14f1e3ee718e56d063db8c331bec173f4408) diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index 0af90d6..fa34c64 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -1491,15 +1491,15 @@ static sal_uInt16 lcl_ScRange_Parse_OOo( ScRange rRange, { rRange.aStart.SetRow(0); rRange.aEnd.SetRow(MAXROW); -nRes1 |= SCA_ROW_ABSOLUTE; -nRes2 |= SCA_ROW_ABSOLUTE; +nRes1 |= SCA_VALID_ROW | SCA_ROW_ABSOLUTE; +nRes2 |= SCA_VALID_ROW | SCA_ROW_ABSOLUTE; } else { rRange.aStart.SetCol(0); rRange.aEnd.SetCol(MAXCOL); -nRes1 |= SCA_COL_ABSOLUTE; -nRes2 |= SCA_COL_ABSOLUTE; +nRes1 |= SCA_VALID_COL | SCA_COL_ABSOLUTE; +nRes2 |= SCA_VALID_COL | SCA_COL_ABSOLUTE; } } else if ((nRes1 SCA_VALID) (nRes2 SCA_VALID)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92451] New: Enhancement: PIVOT TABLES Enable column selection when selecting source
https://bugs.documentfoundation.org/show_bug.cgi?id=92451 Bug ID: 92451 Summary: Enhancement: PIVOT TABLES Enable column selection when selecting source Product: LibreOffice Version: 4.4.3.2 release Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcosti...@gmail.com Related to 44419, but not sure if my request will be covered When creating a Pivot table that is constantly updated with new rows it would be handy to be able to just select the column headers instead of having to define an array. Example: Now $TabX.$A$1:$X$499 This implies you have to worry about not going beyond row 499 otherwise the pivot won't include the data. Suggestion (similar as in Excel): $TabX.$A:$X Something like this will take everything into account that will be included within these columns, without row limit and easy to select by just grabbing the corresponding columns. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] New: Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 Bug ID: 92452 Summary: Entire row functionality in formulae keyboard shortcuts Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ov...@hotmail.com Microsoft Excel entire row notation in formulae functionality 1. In cell A1 enter: =SUM( 2. Press the down arrow once (you should be in cell A2), and the formula in cell A1 should be: =SUM(A2 3. In Microsoft Excel, press Shift+SpaceBar (this selects the entire row), and the formula in cell A1 should be: =SUM(2:2 4. Press enter, and the formula in A1 autocompletes the right parentheses: =SUM(2:2) Eike Rathke has done wonderful work in enabling LibreOffice to understand entire row(s)/column(s) 1:1/A:A notation in formulae. However, LibreOffice 5.1.0.0.alpha1+ doesn't understand step 3 above, i.e. the keyboard shortcut: Shift+SpaceBar to select an entire row. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||452 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||439, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=44 ||419, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||441, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||427 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92439] Creating entire column/s or entire row/s ranges in formulae by clicking on column/row heading/s
https://bugs.documentfoundation.org/show_bug.cgi?id=92439 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||452 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||453 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||453 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92439] Creating entire column/s or entire row/s ranges in formulae by clicking on column/row heading/s
https://bugs.documentfoundation.org/show_bug.cgi?id=92439 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||453 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92453] Entire column functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92453 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||452, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||439, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=44 ||419, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||441, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||427 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 --- Comment #2 from Óvári ov...@hotmail.com --- Please accept my apologies for any confusion. LibreOffice does understand Shift+Space to select an entire row; however, not when it is used when creating a formula. Hence this bug relates to allowing Shift+Space (entire row selection) to be utilised while creating a formula. Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92440] Deadlock in callback to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=92440 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED Assignee|libreoffice-b...@lists.free |sberg...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88196] SLIDESHOW
https://bugs.documentfoundation.org/show_bug.cgi?id=88196 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||958 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87958] VIEWING Spinning writing with shadow and textbox disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=87958 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||196 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92454] New: Incorrect format of the headings
https://bugs.documentfoundation.org/show_bug.cgi?id=92454 Bug ID: 92454 Summary: Incorrect format of the headings Product: LibreOffice Version: unspecified Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mrsl...@gmail.com Created attachment 116950 -- https://bugs.documentfoundation.org/attachment.cgi?id=116950action=edit Document with multiple headings -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92439] Creating entire column/s or entire row/s ranges in formulae by clicking on column/row heading/s
https://bugs.documentfoundation.org/show_bug.cgi?id=92439 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||426 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/address.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 07cd14f1e3ee718e56d063db8c331bec173f4408 Author: Eike Rathke er...@redhat.com Date: Tue Jun 30 14:30:20 2015 +0200 tdf#92426 explicitly set valid row/col for entire col/row references ... for callers that individually check for them, like ScRange::ParseAny() Change-Id: I23fc2c178a9c89b59f99f2fb86223324b7e5d378 diff --git a/sc/source/core/tool/address.cxx b/sc/source/core/tool/address.cxx index 0af90d6..fa34c64 100644 --- a/sc/source/core/tool/address.cxx +++ b/sc/source/core/tool/address.cxx @@ -1491,15 +1491,15 @@ static sal_uInt16 lcl_ScRange_Parse_OOo( ScRange rRange, { rRange.aStart.SetRow(0); rRange.aEnd.SetRow(MAXROW); -nRes1 |= SCA_ROW_ABSOLUTE; -nRes2 |= SCA_ROW_ABSOLUTE; +nRes1 |= SCA_VALID_ROW | SCA_ROW_ABSOLUTE; +nRes2 |= SCA_VALID_ROW | SCA_ROW_ABSOLUTE; } else { rRange.aStart.SetCol(0); rRange.aEnd.SetCol(MAXCOL); -nRes1 |= SCA_COL_ABSOLUTE; -nRes2 |= SCA_COL_ABSOLUTE; +nRes1 |= SCA_VALID_COL | SCA_COL_ABSOLUTE; +nRes2 |= SCA_VALID_COL | SCA_COL_ABSOLUTE; } } else if ((nRes1 SCA_VALID) (nRes2 SCA_VALID)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: ucb/source
ucb/source/ucp/file/bc.cxx|5 ucb/source/ucp/file/bc.hxx| 15 ucb/source/ucp/file/shell.cxx | 16 - ucb/source/ucp/file/shell.hxx | 51 ++ 4 files changed, 22 insertions(+), 65 deletions(-) New commits: commit daf06757009e09e3ecb4a3e91f2d068ca9612fa7 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 30 14:33:43 2015 +0200 Coverity 1308468 etc.: Exception specifications While these functions do not throw any UNO exceptions, no need to specify them as nothrow, and do allow std exceptions to pass through. Also covers Coverity 1308470, 1308476, 1308482, 1308495, 1308496, 1308502, 1308506, and 1308575. Change-Id: I00306f606f3f20462016177eebbd26ed5af76506 diff --git a/ucb/source/ucp/file/bc.cxx b/ucb/source/ucp/file/bc.cxx index 3920d9e..c1e12b6 100644 --- a/ucb/source/ucp/file/bc.cxx +++ b/ucb/source/ucp/file/bc.cxx @@ -834,7 +834,6 @@ Sequence Any SAL_CALL BaseContent::setPropertyValues( sal_Int32 nMyCommandIdentifier, const Sequence beans::PropertyValue Values ) -throw() { if( m_nState Deleted ) { // To do @@ -971,7 +970,6 @@ Reference XDynamicResultSet SAL_CALL BaseContent::open( sal_Int32 nMyCommandIdentifier, const OpenCommandArgument2 aCommandArgument ) -throw() { Reference XDynamicResultSet retValue( 0 ); @@ -1047,7 +1045,6 @@ BaseContent::open( void SAL_CALL BaseContent::deleteContent( sal_Int32 nMyCommandIdentifier ) -throw() { if( m_nState Deleted ) return; @@ -1064,7 +1061,6 @@ BaseContent::deleteContent( sal_Int32 nMyCommandIdentifier ) void SAL_CALL BaseContent::transfer( sal_Int32 nMyCommandIdentifier, const TransferInfo aTransferInfo ) -throw() { if( m_nState Deleted ) return; @@ -1136,7 +1132,6 @@ BaseContent::transfer( sal_Int32 nMyCommandIdentifier, void SAL_CALL BaseContent::insert( sal_Int32 nMyCommandIdentifier, const InsertCommandArgument aInsertArgument ) -throw() { if( m_nState FullFeatured ) { diff --git a/ucb/source/ucp/file/bc.hxx b/ucb/source/ucp/file/bc.hxx index 21b6aca..381880d 100644 --- a/ucb/source/ucp/file/bc.hxx +++ b/ucb/source/ucp/file/bc.hxx @@ -308,29 +308,24 @@ namespace fileaccess { com::sun::star::uno::Sequence com::sun::star::uno::Any SAL_CALL setPropertyValues( sal_Int32 nMyCommandIdentifier, -const com::sun::star::uno::Sequence com::sun::star::beans::PropertyValue Values ) -throw( ); +const com::sun::star::uno::Sequence com::sun::star::beans::PropertyValue Values ); com::sun::star::uno::Reference com::sun::star::ucb::XDynamicResultSet SAL_CALL open( sal_Int32 nMyCommandIdentifier, -const com::sun::star::ucb::OpenCommandArgument2 aCommandArgument ) -throw(); +const com::sun::star::ucb::OpenCommandArgument2 aCommandArgument ); void SAL_CALL -deleteContent( sal_Int32 nMyCommandIdentifier ) -throw(); +deleteContent( sal_Int32 nMyCommandIdentifier ); void SAL_CALL transfer( sal_Int32 nMyCommandIdentifier, - const com::sun::star::ucb::TransferInfo aTransferInfo ) -throw(); + const com::sun::star::ucb::TransferInfo aTransferInfo ); void SAL_CALL insert( sal_Int32 nMyCommandIdentifier, -const com::sun::star::ucb::InsertCommandArgument aInsertArgument ) -throw(); +const com::sun::star::ucb::InsertCommandArgument aInsertArgument ); void SAL_CALL endTask( sal_Int32 CommandId ); diff --git a/ucb/source/ucp/file/shell.cxx b/ucb/source/ucp/file/shell.cxx index 1f352d5..6b0ad35 100644 --- a/ucb/source/ucp/file/shell.cxx +++ b/ucb/source/ucp/file/shell.cxx @@ -570,7 +570,6 @@ shell::deassociate( const OUString aUnqPath, void SAL_CALL shell::page( sal_Int32 CommandId, const OUString aUnqPath, const uno::Reference io::XOutputStream xOutputStream ) -throw() { uno::Reference XContentProvider xProvider( m_pProvider ); osl::File aFile( aUnqPath ); @@ -661,7 +660,6 @@ uno::Reference io::XInputStream SAL_CALL shell::open( sal_Int32 CommandId, const OUString aUnqPath, bool bLock ) -throw() { XInputStream_impl* xInputStream = new XInputStream_impl( this, aUnqPath, bLock ); // from filinpstr.hxx @@ -698,7 +696,6 @@ uno::Reference io::XStream SAL_CALL shell::open_rw( sal_Int32 CommandId, const OUString aUnqPath, bool bLock ) -throw() { XStream_impl* xStream = new XStream_impl( this, aUnqPath, bLock ); // from filstr.hxx @@ -735,7 +732,6 @@ shell::ls( sal_Int32 CommandId,
[Libreoffice-bugs] [Bug 92455] inconsistent unit handling
https://bugs.documentfoundation.org/show_bug.cgi?id=92455 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92455] New: inconsistent unit handling
https://bugs.documentfoundation.org/show_bug.cgi?id=92455 Bug ID: 92455 Summary: inconsistent unit handling Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: markus.mohrh...@googlemail.com The unit handling when it comes to the Data-Convert Units dialog is inconsistent. converting a cell with 3m to mm results in 3000. converting a cell with a header row: length [m] 3 and then converting the cell with the 3 to mm results in 3000mm We should fix the first case to create 3000mm in the cell. Code should be in UnitsImpl::convertCellUnitsForColumnRange -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92454] Incorrect format of the headings
https://bugs.documentfoundation.org/show_bug.cgi?id=92454 Marc Kaulisch m...@kaulisch.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||m...@kaulisch.de Version|unspecified |5.0.0.2 rc Ever confirmed|0 |1 --- Comment #1 from Marc Kaulisch m...@kaulisch.de --- Hi Meroslav Tsaakoff, thanks for reporting this bug. I can confirm that there is something wrong here. I compared the documents between Word 2010 and LO 5.0.0.2 64 bit on Win8.1 and see that the heading is displayed wrongly. Would you be so kind and add some more words on the problem - what does LO not do what it should do. Thank you very much. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92456] Vertical lookup problems with large row
https://bugs.documentfoundation.org/show_bug.cgi?id=92456 Luigi lma...@bwlab.it changed: What|Removed |Added Version|unspecified |4.4.4.3 rc -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/window/gtksalframe.cxx | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) New commits: commit 6c76a0a84785b48c29687e6d31b8229a230563d8 Author: Justin Luth justin_l...@sil.org Date: Fri May 29 10:10:21 2015 +0300 tdf#91641 adjust cursor when deleting preceding characters IMDeleteSurrounding is used by input methods to take multiple keystrokes and convert them into a special character. Then the composing keystrokes are removed. Before this fix, the cursor placement was not adjusted, so the special character was inserted in the wrong position and if 3+ keystrokes were involved, the wrong characters were deleted. Change-Id: I35b97bc150dc68ffe65eebc59450e21e0033bd16 Reviewed-on: https://gerrit.libreoffice.org/15961 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index 9f8e35d..7697eca 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -4655,7 +4655,7 @@ gboolean GtkSalFrame::IMHandler::signalIMDeleteSurrounding( GtkIMContext*, gint uno::Referenceaccessibility::XAccessibleEditableText xText = lcl_GetxText(pFocusWin); if (xText.is()) { -sal_uInt32 nPosition = xText-getCaretPosition(); +sal_Int32 nPosition = xText-getCaretPosition(); // #i111768# range checking sal_Int32 nDeletePos = nPosition + offset; sal_Int32 nDeleteEnd = nDeletePos + nchars; @@ -4667,6 +4667,14 @@ gboolean GtkSalFrame::IMHandler::signalIMDeleteSurrounding( GtkIMContext*, gint nDeleteEnd = xText-getCharacterCount(); xText-deleteText(nDeletePos, nDeleteEnd); +//tdf91641 adjust cursor if deleted chars shift it forward (normal case) +if (nDeletePos nPosition) +{ +if (nDeleteEnd = nPosition) +xText-setCaretPosition( nPosition-(nDeleteEnd-nDeletePos) ); +else +xText-setCaretPosition( nDeletePos ); +} return true; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92452] Entire row functionality in formulae keyboard shortcuts
https://bugs.documentfoundation.org/show_bug.cgi?id=92452 --- Comment #1 from Óvári ov...@hotmail.com --- Please accept my apologies for any confusion. LibreOffice does understand Shift+Space to select an entire row; however, not when it is used when creating a formula. Hence this bug relates to allowing it to be utilised while creating a formula. Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/inc sw/source
sw/inc/unobaseclass.hxx |4 ++ sw/source/core/unocore/unochart.cxx |4 +- sw/source/core/unocore/unoobj2.cxx | 40 +++--- sw/source/core/unocore/unosect.cxx |2 + sw/source/core/unocore/unotbl.cxx | 63 ++-- sw/source/uibase/uno/unotxvw.cxx|2 - 6 files changed, 76 insertions(+), 39 deletions(-) New commits: commit b6cefd5e8b5086619e591385a0d7a6ffcd9783b9 Author: Michael Stahl mst...@redhat.com Date: Tue Jun 30 13:09:32 2015 +0200 sw: avoid layout recursion when loading documents with charts... ... that have a Writer table as data source, such as ooo38798-1.sxw. The problem is that during layouting, the SwWrtShell::CalcAndSetScale() wants to call setVisualAreaSize() on the embedded chart object. This switches the state of the object to RUNNING, which loads it from the file, and during that the ODF filter calls into SwChartDataProvider and that uses a UnoActionRemoveContext; unfortunately that ends all pending Actions, so we get a recursive layout action. Apparently the UnoActionRemoveContext is required to call SwUnoTableCrsr::MakeBoxSels() for old-style tables, which need layout frames for selection?!? Try to avoid the problem by disabling UnoActionRemoveContext in case a new-style table will be selected, which can be done without layout. Change-Id: I097991ffb2e78ddf011db7575f7bb63ae8aa7005 diff --git a/sw/inc/unobaseclass.hxx b/sw/inc/unobaseclass.hxx index bfbc9be..17ac71c 100644 --- a/sw/inc/unobaseclass.hxx +++ b/sw/inc/unobaseclass.hxx @@ -29,6 +29,7 @@ class SfxPoolItem; class SwClient; class SwDoc; +class SwUnoTableCrsr; typedef ::cppu::WeakImplHelper ::com::sun::star::lang::XServiceInfo @@ -70,6 +71,8 @@ class UnoActionContext /* interrupt Actions for a little while +FIXME: this is a vile abomination that may cause recursive layout actions! +C'thulhu fhtagn. */ class UnoActionRemoveContext { @@ -78,6 +81,7 @@ class UnoActionRemoveContext public: UnoActionRemoveContext(SwDoc *const pDoc); +UnoActionRemoveContext(SwUnoTableCrsr const rCursor); ~UnoActionRemoveContext(); }; diff --git a/sw/source/core/unocore/unochart.cxx b/sw/source/core/unocore/unochart.cxx index d03ed3c..c92ccae 100644 --- a/sw/source/core/unocore/unochart.cxx +++ b/sw/source/core/unocore/unochart.cxx @@ -405,8 +405,6 @@ static void GetFormatAndCreateCursorFromRangeRep( pTable ? pTable-GetTableBox( aStartCell, true ) : 0; if(pTLBox) { -// The Actions need to be removed here -UnoActionRemoveContext aRemoveContext(pTableFormat-GetDoc()); const SwStartNode* pSttNd = pTLBox-GetSttNd(); SwPosition aPos(*pSttNd); @@ -425,6 +423,8 @@ static void GetFormatAndCreateCursorFromRangeRep( pUnoCrsr-Move( fnMoveForward, fnGoNode ); SwUnoTableCrsr* pCrsr = dynamic_castSwUnoTableCrsr*(pUnoCrsr.get()); +// HACK: remove pending actions for old style tables +UnoActionRemoveContext aRemoveContext(*pCrsr); pCrsr-MakeBoxSels(); rpUnoCrsr = pUnoCrsr; } diff --git a/sw/source/core/unocore/unoobj2.cxx b/sw/source/core/unocore/unoobj2.cxx index 0c23824..0bab220 100644 --- a/sw/source/core/unocore/unoobj2.cxx +++ b/sw/source/core/unocore/unoobj2.cxx @@ -265,22 +265,50 @@ UnoActionContext::~UnoActionContext() } } -UnoActionRemoveContext::UnoActionRemoveContext(SwDoc *const pDoc) -: m_pDoc(pDoc) +static void lcl_RemoveImpl(SwDoc *const pDoc) { -SwRootFrm *const pRootFrm = m_pDoc-getIDocumentLayoutAccess().GetCurrentLayout(); +assert(pDoc); +SwRootFrm *const pRootFrm = pDoc-getIDocumentLayoutAccess().GetCurrentLayout(); if (pRootFrm) { pRootFrm-UnoRemoveAllActions(); } } +UnoActionRemoveContext::UnoActionRemoveContext(SwDoc *const pDoc) +: m_pDoc(pDoc) +{ +lcl_RemoveImpl(m_pDoc); +} + +static SwDoc * lcl_IsNewStyleTable(SwUnoTableCrsr const rCursor) +{ +SwTableNode *const pTableNode = rCursor.GetNode().FindTableNode(); +return (pTableNode !pTableNode-GetTable().IsNewModel()) +? rCursor.GetDoc() +: nullptr; +} + +UnoActionRemoveContext::UnoActionRemoveContext(SwUnoTableCrsr const rCursor) +: m_pDoc(lcl_IsNewStyleTable(rCursor)) +{ +// this insanity is only necessary for old-style tables +// because SwRootFrm::MakeTableCrsrs() creates the table cursor for these +if (m_pDoc) +{ +lcl_RemoveImpl(m_pDoc); +} +} + UnoActionRemoveContext::~UnoActionRemoveContext() { -SwRootFrm *const pRootFrm = m_pDoc-getIDocumentLayoutAccess().GetCurrentLayout(); -if (pRootFrm) +if (m_pDoc) { -pRootFrm-UnoRestoreAllActions(); +SwRootFrm *const pRootFrm =
[Libreoffice-bugs] [Bug 92440] Deadlock in callback to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=92440 --- Comment #3 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Stephan Bergmann committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=a12db8e9e1960f3f209f1b95547041681566d636 tdf#92440: Reduce code areas covered by mutex It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92440] Deadlock in callback to Python
https://bugs.documentfoundation.org/show_bug.cgi?id=92440 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92321] LibO smashes my Windows 8.1 completely
https://bugs.documentfoundation.org/show_bug.cgi?id=92321 Beluga todven...@suomi24.fi changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||todven...@suomi24.fi Resolution|--- |WORKSFORME --- Comment #1 from Beluga todven...@suomi24.fi --- Thanks for the report, but as this can not be pinpointed to LibreOffice in any way and can not be reproduced, I'll set to WFM. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92403] Web Wizard - no visible Selections in step 3 and 4
https://bugs.documentfoundation.org/show_bug.cgi?id=92403 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|Web-Wizzard - no visible|Web Wizard - no visible |Selections in step 3 and 4 |Selections in step 3 and 4 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: stoc/source
stoc/source/inspect/introspection.cxx | 45 +++--- 1 file changed, 31 insertions(+), 14 deletions(-) New commits: commit a12db8e9e1960f3f209f1b95547041681566d636 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Jun 30 14:10:17 2015 +0200 tdf#92440: Reduce code areas covered by mutex Change-Id: Iec79e088e67e1cddeb8242d069fae911b305f613 diff --git a/stoc/source/inspect/introspection.cxx b/stoc/source/inspect/introspection.cxx index 116b8ed..ca8d99a 100644 --- a/stoc/source/inspect/introspection.cxx +++ b/stoc/source/inspect/introspection.cxx @@ -1537,6 +1537,7 @@ public: private: virtual void SAL_CALL disposing() SAL_OVERRIDE { +osl::MutexGuard g(m_aMutex); reflection_.clear(); classCache_.clear(); typeCache_.clear(); @@ -1572,16 +1573,20 @@ css::uno::Referencecss::beans::XIntrospectionAccess Implementation::inspect( css::uno::Any const aObject) throw (css::uno::RuntimeException, std::exception) { -osl::MutexGuard g(m_aMutex); -if (rBHelper.bDisposed || rBHelper.bInDispose) { -throw css::lang::DisposedException( -getImplementationName(), static_castOWeakObject *(this)); +css::uno::Referencecss::reflection::XIdlReflection reflection; +{ +osl::MutexGuard g(m_aMutex); +if (rBHelper.bDisposed || rBHelper.bInDispose) { +throw css::lang::DisposedException( +getImplementationName(), static_castOWeakObject *(this)); +} +reflection = reflection_; } css::uno::Any aToInspectObj; css::uno::Type t; if (aObject = t) { css::uno::Referencecss::reflection::XIdlClass c( -reflection_-forName(t.getTypeName())); +reflection-forName(t.getTypeName())); if (!c.is()) { SAL_WARN(stoc, cannot reflect type t.getTypeName()); return css::uno::Referencecss::beans::XIntrospectionAccess(); @@ -1632,7 +1637,7 @@ css::uno::Referencecss::beans::XIntrospectionAccess Implementation::inspect( const Type* pTypes = SupportedTypesSeq.getConstArray(); for( sal_Int32 i = 0 ; i nTypeCount ; i++ ) { -pClasses[i] = reflection_-forName(pTypes[i].getTypeName()); +pClasses[i] = reflection-forName(pTypes[i].getTypeName()); } // TODO: Caching! } @@ -1641,7 +1646,7 @@ css::uno::Referencecss::beans::XIntrospectionAccess Implementation::inspect( stoc, object of type \ aToInspectObj.getValueTypeName() \ lacks XTypeProvider); -xImplClass = reflection_-forName(aToInspectObj.getValueTypeName()); +xImplClass = reflection-forName(aToInspectObj.getValueTypeName()); SupportedClassSeq.realloc(1); SupportedClassSeq[0] = xImplClass; } @@ -1651,24 +1656,36 @@ css::uno::Referencecss::beans::XIntrospectionAccess Implementation::inspect( if( xPropSet.is() ) xPropSetInfo = xPropSet-getPropertySetInfo(); } else { -xImplClass = reflection_-forName(aToInspectObj.getValueTypeName()); +xImplClass = reflection-forName(aToInspectObj.getValueTypeName()); } if (xTypeProvider.is()) { TypeKey key(xPropSetInfo, xTypeProvider-getTypes()); + +osl::MutexGuard g(m_aMutex); +if (rBHelper.bDisposed || rBHelper.bInDispose) { +throw css::lang::DisposedException( +getImplementationName(), static_castOWeakObject *(this)); +} pAccess = typeCache_.find(key); if (pAccess.is()) { return new ImplIntrospectionAccess(aToInspectObj, pAccess); } -pAccess = new IntrospectionAccessStatic_Impl(reflection_); +pAccess = new IntrospectionAccessStatic_Impl(reflection); typeCache_.insert(key, pAccess); } else if (xImplClass.is()) { ClassKey key(xPropSetInfo, xImplClass, SupportedClassSeq); + +osl::MutexGuard g(m_aMutex); +if (rBHelper.bDisposed || rBHelper.bInDispose) { +throw css::lang::DisposedException( +getImplementationName(), static_castOWeakObject *(this)); +} pAccess = classCache_.find(key); if (pAccess.is()) { return new ImplIntrospectionAccess(aToInspectObj, pAccess); } -pAccess = new IntrospectionAccessStatic_Impl(reflection_); +pAccess = new IntrospectionAccessStatic_Impl(reflection); classCache_.insert(key, pAccess); } @@ -1681,7 +1698,7 @@ css::uno::Referencecss::beans::XIntrospectionAccess Implementation::inspect( sal_Int32 i; if( !pAccess.is() ) -pAccess = new IntrospectionAccessStatic_Impl( reflection_ ); +pAccess = new IntrospectionAccessStatic_Impl( reflection ); // Referenzen auf wichtige Daten von
[Libreoffice-bugs] [Bug 92404] Web Wizard - no result / crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92404 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it Summary|Web wizzard - no result / |Web Wizard - no result / |crash |crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87960] VIEWING LibreOffice Impress wobble/shake/vibrate of images incorrect
https://bugs.documentfoundation.org/show_bug.cgi?id=87960 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||959, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||958, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=88 ||196 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87958] VIEWING Spinning writing with shadow and textbox disappearing
https://bugs.documentfoundation.org/show_bug.cgi?id=87958 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||960 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89245] FORMATTING, FILESAVE: Header and footer background images are not saved
https://bugs.documentfoundation.org/show_bug.cgi?id=89245 --- Comment #24 from Alex a...@vec4.com --- Hi! Tried 4.4.4.3 and Calc still crashes but it seems a bit more robust than last time. Before all I had to do was: 1. Format Page Header(Tab) 2. More Background As Graphic Add graphic 3. OK OK 4. Format Page 5. Program Crash Now it's the following: 1. Format Page Header(Tab) 2. More Background As Graphic Add graphic 3. OK OK 4. File Export as PDF Export Save 5. Format Page 6. Program Crash Also it's still not saving even if you don't follow these steps. Can anyone confirm this? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88196] SLIDESHOW
https://bugs.documentfoundation.org/show_bug.cgi?id=88196 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||960 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87959] VIEWING: Impress Too big Pixels and displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=87959 Óvári ov...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=87 ||960 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92426] Box not showing for an entire row and entire column notation
https://bugs.documentfoundation.org/show_bug.cgi?id=92426 Eike Rathke er...@redhat.com changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92455] inconsistent unit handling
https://bugs.documentfoundation.org/show_bug.cgi?id=92455 Markus Mohrhard markus.mohrh...@googlemail.com changed: What|Removed |Added CC||benjaminn...@hotmail.com --- Comment #1 from Markus Mohrhard markus.mohrh...@googlemail.com --- @Ben: that would be one for you and might be a simple one for the beginning. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92456] New: Vertical lookup problems with large row
https://bugs.documentfoundation.org/show_bug.cgi?id=92456 Bug ID: 92456 Summary: Vertical lookup problems with large row Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: lma...@bwlab.it Created attachment 116951 -- https://bugs.documentfoundation.org/attachment.cgi?id=116951action=edit vertical lookup performance Hi I have the file in attach I do a vertical look up for all line ~23000 but calc non respond and doesn't give me a result I've Ubuntu 15.04 and libre office 4.4.4.3 thanks in advance regards -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92454] DOCX Import: Incorrect display of the headings
https://bugs.documentfoundation.org/show_bug.cgi?id=92454 Marc Kaulisch m...@kaulisch.de changed: What|Removed |Added Summary|Incorrect format of the |DOCX Import: Incorrect |headings|display of the headings -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92441] Entire row(s)/column(s) formulae ranges not in colour when F2
https://bugs.documentfoundation.org/show_bug.cgi?id=92441 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Eike Rathke er...@redhat.com --- *** This bug has been marked as a duplicate of bug 92426 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/unitver' - 2 commits - sc/qa sc/source
sc/qa/unit/units.cxx | 149 +++ sc/source/ui/miscdlgs/unitsconversiondlg.cxx |7 + 2 files changed, 116 insertions(+), 40 deletions(-) New commits: commit b290ccb0b3979e7ad344709b4d1018fee071f52a Author: Benjamin Ni benjaminn...@hotmail.com Date: Tue Jun 30 06:40:38 2015 +0100 Added more range conversion tests Change-Id: If4898e6c70cb9731af35d51457de28410f808b96 diff --git a/sc/qa/unit/units.cxx b/sc/qa/unit/units.cxx index ee6af8a..28cffa2 100644 --- a/sc/qa/unit/units.cxx +++ b/sc/qa/unit/units.cxx @@ -321,6 +321,13 @@ void UnitsTest::testUnitVerification() { pTokens = pCell-GetCode(); CPPUNIT_ASSERT(mpUnitsImpl-verifyFormula(pTokens, address, mpDoc) == FormulaStatus::VALID); +// SUM(cm,m) +address.IncRow(); +mpDoc-SetFormula(address, =SUM(A1,E1)); +pCell = mpDoc-GetFormulaCell(address); +pTokens = pCell-GetCode(); +CPPUNIT_ASSERT(mpUnitsImpl-verifyFormula(pTokens, address, mpDoc) == FormulaStatus::ERROR_INPUT_SCALING); + // PRODUCT(cm/,s)+cm address.IncRow(); mpDoc-SetFormula(address, =PRODUCT(C1:D1)+A1); @@ -803,82 +810,144 @@ void UnitsTest::testRangeConversion() { mpDoc-EnsureTable(nTab); // Column 1: convert [cm] to [cm]. -ScAddress headerAddress(0, 0, nTab); -mpDoc-SetString(headerAddress, length [cm]); +ScAddress headerAddressCol1(0, 0, nTab); +mpDoc-SetString(headerAddressCol1, length [cm]); -ScAddress address(headerAddress); +ScAddress addressCol1(headerAddressCol1); vectordouble values({10, 20, 30, 40, 1, 0.5, 0.25}); -address.IncRow(); -mpDoc-SetValues(address, values); +addressCol1.IncRow(); +mpDoc-SetValues(addressCol1, values); // Test conversion of range _not_ including header -ScAddress endAddress( address.Col(), address.Row() + values.size() - 1, nTab); +ScAddress endAddressCol1( addressCol1.Col(), addressCol1.Row() + values.size() - 1, nTab); -ScRange aRange(address, endAddress); +ScRange aRange(addressCol1, endAddressCol1); CPPUNIT_ASSERT(mpUnitsImpl-convertCellUnits(aRange, mpDoc, cm)); CPPUNIT_ASSERT(!mpUnitsImpl-convertCellUnits(aRange, mpDoc, kg)); -CPPUNIT_ASSERT(mpDoc-GetString(headerAddress) == length [cm]); +CPPUNIT_ASSERT(mpDoc-GetString(headerAddressCol1) == length [cm]); -for (double d: values) { +for (double d: values) +{ // Test that the value is unchanged -CPPUNIT_ASSERT(mpDoc-GetValue(address) == d); +CPPUNIT_ASSERT(mpDoc-GetValue(addressCol1) == d); // And NO annotation has been added -CPPUNIT_ASSERT(mpDoc-GetString(address) == OUString::number(d)); -address.IncRow(); +CPPUNIT_ASSERT(mpDoc-GetString(addressCol1) == OUString::number(d)); +addressCol1.IncRow(); } // Test conversion of range including header (from cm to cm) -aRange = ScRange(headerAddress, endAddress); +aRange = ScRange(headerAddressCol1, endAddressCol1); CPPUNIT_ASSERT(mpUnitsImpl-convertCellUnits(aRange, mpDoc, cm)); CPPUNIT_ASSERT(!mpUnitsImpl-convertCellUnits(aRange, mpDoc, kg)); -CPPUNIT_ASSERT(mpDoc-GetString(headerAddress) == length [cm]); +CPPUNIT_ASSERT(mpDoc-GetString(headerAddressCol1) == length [cm]); -address = headerAddress; -address.IncRow(); -for (double d: values) { -CPPUNIT_ASSERT_DOUBLES_EQUAL(mpDoc-GetValue(address), d, 1e-7); +addressCol1 = headerAddressCol1; +addressCol1.IncRow(); +for (double d: values) +{ +CPPUNIT_ASSERT_DOUBLES_EQUAL(mpDoc-GetValue(addressCol1), d, 1e-7); // And NO annotation has been added -CPPUNIT_ASSERT(mpDoc-GetString(address) == OUString::number(d)); -address.IncRow(); +CPPUNIT_ASSERT(mpDoc-GetString(addressCol1) == OUString::number(d)); +addressCol1.IncRow(); } // Convert just the values (but not header): [cm] to [m] -address.SetRow(1); -aRange = ScRange(address, endAddress); +addressCol1.SetRow(1); +aRange = ScRange(addressCol1, endAddressCol1); CPPUNIT_ASSERT(mpUnitsImpl-convertCellUnits(aRange, mpDoc, m)); -CPPUNIT_ASSERT(mpDoc-GetString(headerAddress) == length [cm]); +CPPUNIT_ASSERT(mpDoc-GetString(headerAddressCol1) == length [cm]); -for (double d: values) { -CPPUNIT_ASSERT_DOUBLES_EQUAL(mpDoc-GetValue(address), d/100, 1e-7); -// AND test annotation -// Disabled for now until the precision problems are figured out -// CPPUNIT_ASSERT(mpDoc-GetString(address) == OUString::number(d/100) + m); -address.IncRow(); +for (double d: values) +{ +OUString aResultStr = mpDoc-GetString(addressCol1); +OUString aValStr = aResultStr.copy( 0, aResultStr.getLength() - 1 ); // value portion of result +OUString aUnitStr = aResultStr.copy( aResultStr.getLength() - 1, 1 ); // annotation portion of result +
[Libreoffice-commits] core.git: sw/source
sw/source/core/unocore/unotbl.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 8baeb65c2a8179d9b29589e83cfcb45c120e4cec Author: Bjoern Michaelsen bjoern.michael...@canonical.com Date: Tue Jun 30 11:05:22 2015 +0200 remove spurious line (should fix OSX) Change-Id: If422726f83532430f666ae17f6f71e2ccf5733cb diff --git a/sw/source/core/unocore/unotbl.cxx b/sw/source/core/unocore/unotbl.cxx index fd3e489..a82ce75 100644 --- a/sw/source/core/unocore/unotbl.cxx +++ b/sw/source/core/unocore/unotbl.cxx @@ -1222,7 +1222,6 @@ double SwXCell::GetForcedNumericalValue() const uno::Any SwXCell::GetAny() const { -SwTableBox* GetTableBox(); if(!pBox) throw uno::RuntimeException(); // check if table box value item is set ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92249] Checkboxes and radio buttons (in Options screen) too small on HiDPI
https://bugs.documentfoundation.org/show_bug.cgi?id=92249 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Summary|Checkboxes and bulletpoints |Checkboxes and radio |(in Options screen) too |buttons (in Options screen) |small on HiDPI |too small on HiDPI -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs