[Libreoffice-commits] online.git: 2 commits - loleaflet/src
loleaflet/src/layer/tile/GridLayer.js | 104 ++
loleaflet/src/layer/tile/TileLayer.js | 15
2 files changed, 118 insertions(+), 1 deletion(-)
New commits:
commit e1c3426b6e2e621694e2a7ea61c446a55a7b720e
Author: Mihai Varga mihai.va...@collabora.com
Date: Fri Jul 10 09:25:32 2015 +0300
loleaflet: keep prefetch borders if the view didn't change
Also, only prefetch tiles from a 5 tiles widte border. Not more because
it would freeze the UI
diff --git a/loleaflet/src/layer/tile/GridLayer.js
b/loleaflet/src/layer/tile/GridLayer.js
index f77b575..fc67031 100644
--- a/loleaflet/src/layer/tile/GridLayer.js
+++ b/loleaflet/src/layer/tile/GridLayer.js
@@ -104,6 +104,7 @@ L.GridLayer = L.Layer.extend({
getEvents: function () {
var events = {
viewreset: this._viewReset,
+ movestart: this._moveStart,
moveend: this._move
};
@@ -449,8 +450,17 @@ L.GridLayer = L.Layer.extend({
return this.options.tileSize;
},
+ _moveStart: function () {
+ clearInterval(this._tilesPrefetcher);
+ this._tilesPrefetcher = null;
+ this._preFetchBorder = null;
+ },
+
_move: function () {
this._update();
+ if (!this._tilesPreFetcher) {
+ this._tilesPreFetcher =
setInterval(L.bind(this._preFetchTiles, this), 2000);
+ }
},
_update: function (center, zoom) {
@@ -786,36 +796,44 @@ L.GridLayer = L.Layer.extend({
var center = map.getCenter();
var zoom = map.getZoom();
- var pixelBounds = map.getPixelBounds(center, zoom),
- tileRange = this._pxBoundsToTileRange(pixelBounds),
- queue = [],
- finalQueue = [];
- tilesToFetch = 10;
-
- while ((tileRange.min.x = 0 || tileRange.min.y = 0 ||
- tileRange.max.x * this._tileWidthTwips
this._docWidthTwips ||
-tileRange.max.y * this._tileHeightTwips
this._docHeightTwips)
- tilesToFetch 0) {
+ if (!this._preFetchBorder) {
+ var pixelBounds = map.getPixelBounds(center, zoom),
+ tileBorder =
this._pxBoundsToTileRange(pixelBounds);
+ this._preFetchBorder = tileBorder;
+ }
+ else {
+ tileBorder = this._preFetchBorder;
+ }
+ var queue = [],
+ finalQueue = [],
+ tilesToFetch = 10,
+ borderWidth = 0;
+ // don't search on a border wider than 5 tiles because
it will freeze the UI
+
+ while ((tileBorder.min.x = 0 || tileBorder.min.y = 0 ||
+ tileBorder.max.x * this._tileWidthTwips
this._docWidthTwips ||
+tileBorder.max.y * this._tileHeightTwips
this._docHeightTwips)
+ tilesToFetch 0 borderWidth 5) {
// while the bounds do not fully contain the document
- for (var i = tileRange.min.x; i = tileRange.max.x;
i++) {
+ for (var i = tileBorder.min.x; i = tileBorder.max.x;
i++) {
// tiles below the visible area
- var coords = new L.Point(i, tileRange.max.y);
+ var coords = new L.Point(i, tileBorder.max.y);
queue.push(coords);
}
- for (i = tileRange.min.x; i = tileRange.max.x; i++) {
+ for (i = tileBorder.min.x; i = tileBorder.max.x; i++) {
// tiles above the visible area
- coords = new L.Point(i, tileRange.min.y);
+ coords = new L.Point(i, tileBorder.min.y);
queue.push(coords);
}
- for (i = tileRange.min.y; i = tileRange.max.y; i++) {
+ for (i = tileBorder.min.y; i = tileBorder.max.y; i++) {
// tiles to the right of the visible area
- coords = new L.Point(tileRange.max.x, i);
+ coords = new L.Point(tileBorder.max.x, i);
queue.push(coords);
}
- for (i = tileRange.min.y; i = tileRange.max.y; i++) {
+ for (i = tileBorder.min.y; i = tileBorder.max.y; i++) {
// tiles to the left of the visible area
-
[Libreoffice-bugs] [Bug 62860] provide easy way to change common / default FORMATTING STYLES for data series
https://bugs.documentfoundation.org/show_bug.cgi?id=62860 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||725 --- Comment #9 from Cor Nouws c...@nouenoff.nl --- adding a link to a slightly related bug with some rough code pointers, if I may say so -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 62860] provide easy way to change common / default FORMATTING STYLES for data series
https://bugs.documentfoundation.org/show_bug.cgi?id=62860 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Whiteboard||needsDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: compilerplugins/clang cui/source include/vcl vcl/inc vcl/opengl vcl/source vcl/unx vcl/win
compilerplugins/clang/unusedmethods.py |7 +
cui/source/factory/dlgfact.cxx | 15
cui/source/factory/dlgfact.hxx |3
include/vcl/abstdlg.hxx|1
include/vcl/bitmap.hxx |1
include/vcl/bitmapex.hxx |2
include/vcl/btndlg.hxx |5 -
include/vcl/builder.hxx|4 -
include/vcl/button.hxx | 13 ---
include/vcl/ctrl.hxx |1
include/vcl/dialog.hxx |2
include/vcl/dockwin.hxx| 45
include/vcl/edit.hxx |2
include/vcl/fixed.hxx | 13 +--
include/vcl/floatwin.hxx |1
include/vcl/image.hxx |2
include/vcl/layout.hxx | 47 -
include/vcl/menu.hxx | 20 -
include/vcl/outdev.hxx | 21 -
include/vcl/rendersettings.hxx |6 -
include/vcl/scrbar.hxx |2
include/vcl/settings.hxx |1
include/vcl/syswin.hxx |1
include/vcl/tabctrl.hxx|9 --
include/vcl/tabdlg.hxx |3
include/vcl/toolbox.hxx| 35 -
include/vcl/vclmedit.hxx |1
include/vcl/virdev.hxx |1
include/vcl/window.hxx |4 -
include/vcl/wrkwin.hxx |1
vcl/inc/PhysicalFontCollection.hxx |1
vcl/inc/PhysicalFontFace.hxx |1
vcl/inc/brdwin.hxx |2
vcl/inc/openglgdiimpl.hxx |5 -
vcl/inc/outdev.h |3
vcl/inc/outfont.hxx|4 -
vcl/inc/salgdiimpl.hxx |5 -
vcl/inc/salinst.hxx|8 --
vcl/inc/unx/salinst.h |1
vcl/opengl/gdiimpl.cxx |8 --
vcl/source/app/salvtables.cxx |5 -
vcl/source/app/settings.cxx|7 -
vcl/source/gdi/bitmapex.cxx|8 --
vcl/source/outdev/map.cxx | 48 -
vcl/source/outdev/rendersettings.cxx | 29
vcl/unx/generic/app/salinst.cxx| 119 -
vcl/unx/generic/gdi/gdiimpl.cxx|7 -
vcl/unx/generic/gdi/gdiimpl.hxx|5 -
vcl/win/source/gdi/gdiimpl.cxx | 54 --
vcl/win/source/gdi/gdiimpl.hxx |5 -
50 files changed, 16 insertions(+), 578 deletions(-)
New commits:
commit 001e694ecd21095b6fcfb5632ace63d8e0c2b7f8
Author: Noel Grandin n...@peralex.com
Date: Wed Jul 8 10:25:58 2015 +0200
loplugin:unusedmethods vcl(part2)
Change-Id: I12356b3fdce68282a30cae2b270b02e46558860a
Reviewed-on: https://gerrit.libreoffice.org/16847
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/compilerplugins/clang/unusedmethods.py
b/compilerplugins/clang/unusedmethods.py
index 69a253a..05e38b6 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -29,7 +29,7 @@ exclusionSet = set([
void comphelper::IEventProcessor::release(),
void SotMutexHolder::acquire(),
void SotMutexHolder::release(),
-# used by Windows build
+# only used by Windows build
_Bool basegfx::B2ITuple::equalZero() const,
class basegfx::B2DPolyPolygon
basegfx::unotools::UnoPolyPolygon::getPolyPolygonUnsafe() const,
void OpenGLContext::requestSingleBufferedRendering(),
@@ -43,8 +43,13 @@ exclusionSet = set([
void StyleSettings::SetCursorSize(long),
_Bool CommandMediaData::GetPassThroughToOS() const,
void Application::AppEvent(const class ApplicationEvent ),
+int PhysicalFontFace::GetWidth() const,
+void PhysicalFontFace::SetBitmapSize(int,int),
+_Bool SalObject::IsEraseBackgroundEnabled(),
# instantiated from a template in VCL, not sure why it is not being picked
up
class basegfx::B2DPolygon OutputDevice::PixelToLogic(const class
basegfx::B2DPolygon ,const class MapMode ) const,
+# only used by OSX build
+void StyleSettings::SetHideDisabledMenuItems(_Bool),
])
diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx
index 8826c9c..197d795 100644
--- a/cui/source/factory/dlgfact.cxx
+++ b/cui/source/factory/dlgfact.cxx
@@ -449,11 +449,6 @@ void AbstractSearchProgress_Impl::Update()
pDlg-Update();
}
-void AbstractSearchProgress_Impl::Sync()
-{
- pDlg-Sync();
-}
-
void AbstractSearchProgress_Impl::SetFileType( const OUString rType )
{
pDlg-SetFileType( rType );
@@ -473,11 +468,6 @@ void AbstractTakeProgress_Impl::Update()
pDlg-Update();
}
-void AbstractTakeProgress_Impl::Sync()
-{
- pDlg-Sync();
-}
-
void AbstractTakeProgress_Impl::SetFile( const INetURLObject rURL )
{
pDlg-SetFile( rURL );
[Libreoffice-bugs] [Bug 92623] mail merge crashes between step 6 and 7
https://bugs.documentfoundation.org/show_bug.cgi?id=92623 --- Comment #1 from Justin L jl...@mail.com --- Created attachment 117166 -- https://bugs.documentfoundation.org/attachment.cgi?id=117166action=edit mailmerge db connector, spreadsheet data, and merge template Very specific failure case, seemingly related to the writer template. Having trouble isolating the exact regression commit: I clean compiled to the last good position and still had a crash failure. Double-checked bibisect-44 and confirmed the same results. In the writer template, note that the one cell is protect-locked, but you can't unprotect it - which seems to be the element that causes the crash. Unable to reproduce this in a start-from-scratch document. Simply locking a cell does not produce a crash. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #17 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- http://superuser.com/a/24163 says the same. Then it should be disabled completely in OS X, I guess. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #17 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- http://superuser.com/a/24163 says the same. Then it should be disabled completely in OS X, I guess. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92655] CTL/CJK: some Language Script Handling Bugs and Reviving a Dead Horse
https://bugs.documentfoundation.org/show_bug.cgi?id=92655 --- Comment #15 from Cor Nouws c...@nouenoff.nl --- Just as a contrast (not that I dislike variation in peoples styles) what I learned from Synerzip/CloudOn devs at the Bern conference. - For each issue they have one document with often just one work/line/graphic. - Open in A and do/or open in B. - It looks X (see e.g. picture) and should do Y (see picture). That is IMO more inviting to check and handle. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92623] mail merge crashes between step 6 and 7
https://bugs.documentfoundation.org/show_bug.cgi?id=92623 Justin L jl...@mail.com changed: What|Removed |Added Priority|medium |low -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Minutes of the Design Hangout: 2015-07-08
* Present: Heiko, Jay, Marek, Matthias, Kendy, Rishabh, Steve, Stuart * UI changes integrated the last week: + Breeze updates (Andreas) + .ui dialogs improvements (Adolfo) + Improvements in thumbnailing (Maxim) + Fix selecting location in Properties dialog (Szymon) + Sifr updates (Matthias) + Tango updates (Adolfo) + Redraw the last used color after theme change (Maxim) + Make printer was modified status persistent (Bubli) + Fix search in Expert Configuration dialog (Mihály) + Rework start center accelerators (Stuart) + Don't attempt to show commontaskbar in Draw (Maxim) * LibreOffice Conference + September 23-25, 2015, Aarhus, Denmark + http://conference.libreoffice.org/2015/call-for-papers/ + would be great to have you all there :-) - please submit a paper! * Icon Updates / Issues (Jay) + Tango (Alex/Adolfo/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1OErlXIDDGM7V1mOGW8oSCLuhqw5fulT1XhkTik1u2UY/edit?usp=sharing + Sifr (Papamatti/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/15ZpVaTxg7TAFYhOyQUP3mp-cVtKA1vP5uZAT38t-taA/edit?usp=sharing + Papamatti has pushed new icons (Jay) + Breeze (Andreas/Jay) + Latest status of updates available here (Jay) https://docs.google.com/document/d/1dpMFgmkQy4BsyRIKH97ZLPTU6NdvXIYk3Yossj6sSQM/edit?usp=sharing + Andreas has pushed some changes (Jay) + Extra-Large (32x32) Icons for large resolutions + Status - https://docs.google.com/document/d/1mPqD2gGsMkfVCI6ByUd2XYX1NJm26hcGjRVe6gcCSEU/edit?usp=sharing * Templates Competition (Jay) + Wiki page setup https://wiki.documentfoundation.org/Design/Whiteboards/Templates_for_LibreOffice_5.0 + 7 templates submitted so far + went through the templates rated them + added notes recommendations, Jay will follow-up with the authors * GSoC (Rishabh) + going fine (was facing some problesm, but fine now) + finished the slide background section + improving the selection analyzer for Writer * LibreOffice 5.0 splash + start center + about box new theme (Kendy) + polishing is ongoing in the Visual Identity group + implementation of the new colors for the start center done (Kendy) * UI Guidelines (Heiko) + https://docs.google.com/document/d/1hSYOFoG6jnj2G0zWDbUYkrGZoj7YCSI9j3onkTZ65bU/edit + context menus + questions about limitations of the amount of items - seems like a misunderstanding + sidebar + concerns about the fixed size (non-resizability) + position of tabs (at the top) - does not work when closed + dialogs (Heiko) + no good guideline for sidebar vs. tabs in the dialogs (what is better when) + navigation in the sidebar - is that too much efort though? + do the users in fact want changes there? + like, the text properties now have 9 tabs! + seems people like redesigns in general + should icons be used? + resizability + if well designed, no need to resize vs. resize gives freedom to the user + not much interested in redesign it seems though + let's not change without user's complains * Sidebar constrained by content and resizable (Heiko/Jay/Stuart) + https://bugs.documentfoundation.org/show_bug.cgi?id=92317 + https://bugs.documentfoundation.org/show_bug.cgi?id=90374 + concerned that we contstrain the sidebar in the HIG too much (Stuart) + when it is too much in the development + and before its purpose is settled down + like: codifying if it should have fixed size or resizable is a bit premature (Stuart) + example: navigator or gallery are more dialogs (Stuart) + navigator is actually a floating windows (Jay) + sidebar - actually a hybrid between a toolbar and dialog (Stuart) + some consistency issue, but overall sidebar fairly consistent UI as is and how it continues to develop (Stuart) + becomes flexible rich (Stuart) + there were additional ideas (like the accordion) (Heiko) + eg. page size is not necessary in the Sidebar (Heiko) + a cut needs to be found (Heiko) + sidebar should provide access to the most used features (Heiko) + discussion will continue at a future meeting (Jay) * Next Friday's design session (Jay) + Friday session this week + not happening this week as heiko's busy + 1:00pm CEST / 11:00 UTC + List of possible future topics + https://docs.google.com/document/d/1XiJauFHrSmM5LsaV0AlglhfUh8D1IxAg8qistP0KAQA/edit?usp=sharing + Steve wants the sidebar configuration menu icon gone: it's useless confusing, thus user unfriendly, creates frustration and clutters the UI.
[Libreoffice-commits] core.git: include/vcl
include/vcl/ITiledRenderable.hxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 459bcc222f2aee52477cef8f94eb2789ff4ecd9a
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 10 09:11:20 2015 +0200
vcl::ITiledRenderable: getTextSelection() can be pure virtual now
Change-Id: Ifb33ee9a70afeccc01f45996b2953fcd5f3700cc
Reviewed-on: https://gerrit.libreoffice.org/16906
Reviewed-by: Miklos Vajna vmik...@collabora.co.uk
Tested-by: Jenkins c...@libreoffice.org
diff --git a/include/vcl/ITiledRenderable.hxx b/include/vcl/ITiledRenderable.hxx
index d212519..8824361 100644
--- a/include/vcl/ITiledRenderable.hxx
+++ b/include/vcl/ITiledRenderable.hxx
@@ -126,7 +126,7 @@ public:
*
* @see lok::Document::getTextSelection().
*/
-virtual OString getTextSelection(const char* /*pMimeType*/, OString
/*rUsedMimeType*/) { return OString(); }
+virtual OString getTextSelection(const char* pMimeType, OString
rUsedMimeType) = 0;
/**
* Adjusts the graphic selection.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92669] New: Crash when opening corrupt .doc file
https://bugs.documentfoundation.org/show_bug.cgi?id=92669 Bug ID: 92669 Summary: Crash when opening corrupt .doc file Product: LibreOffice Version: 5.0.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mahf...@gmail.com Created attachment 117167 -- https://bugs.documentfoundation.org/attachment.cgi?id=117167action=edit Backtrace of the crash right after opening the file I have a .doc file which is slightly corrupt and latest LibO 5.0.0.2rc opens it, displays the first page and then immediately crashes. I attach a gdb backtrace of this happening. MS Word does a recovery when opening that file and the file ends up just fine. Unfortunately that file contains non-public information, therefore I cannot attach it here. If you happen to be a respected developer around here, I can mail the file to you. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf |binary
vcl/source/filter/wmf/winwmf.cxx | 10 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 55486cf648813bc0c46eaf0df2f0544a5d57ccb2
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 10 08:40:42 2015 +0100
avoid endless loop with busted wmf
Change-Id: I104de360f2e861e959ad2dad434a768440877f6f
(cherry picked from commit fd2749455fe25e24b448a44f9ada6113e5ac0d13)
Reviewed-on: https://gerrit.libreoffice.org/16914
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
new file mode 100644
index 000..7ba05cb
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf differ
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index c7d1315..5e25949 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -1394,9 +1394,13 @@ void WMFReader::ReadWMF()
}
}
}
-nPos += nRecSize * 2;
-if ( nPos = nEndPos )
-pWMF-Seek( nPos );
+const sal_uInt32 nAvailableBytes = nEndPos - nPos;
+const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2;
+if (nRecSize = nMaxPossibleRecordSize)
+{
+nPos += nRecSize * 2;
+pWMF-Seek(nPos);
+}
else
pWMF-SetError( SVSTREAM_FILEFORMAT_ERROR );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf |binary
vcl/source/filter/wmf/winwmf.cxx | 10 +++---
2 files changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 902be1faa4c18b1381e77e4e1630edf6ed301556
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 10 08:40:42 2015 +0100
avoid endless loop with busted wmf
Change-Id: I104de360f2e861e959ad2dad434a768440877f6f
(cherry picked from commit fd2749455fe25e24b448a44f9ada6113e5ac0d13)
Reviewed-on: https://gerrit.libreoffice.org/16915
Reviewed-by: Michael Meeks michael.me...@collabora.com
Tested-by: Michael Meeks michael.me...@collabora.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
new file mode 100644
index 000..7ba05cb
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf differ
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index b7e63d7..bee19b6 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -1372,9 +1372,13 @@ void WMFReader::ReadWMF()
}
}
}
-nPos += nRecSize * 2;
-if ( nPos = nEndPos )
-pWMF-Seek( nPos );
+const sal_uInt32 nAvailableBytes = nEndPos - nPos;
+const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2;
+if (nRecSize = nMaxPossibleRecordSize)
+{
+nPos += nRecSize * 2;
+pWMF-Seek(nPos);
+}
else
pWMF-SetError( SVSTREAM_FILEFORMAT_ERROR );
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92630] GTK+ auto-accelerator functionality missing
https://bugs.documentfoundation.org/show_bug.cgi?id=92630 --- Comment #5 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- Thanks for the patch! More patches are most welcome :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||momonas...@gmail.com, ||sberg...@redhat.com --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- Changed in the following commit: commit 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 Author: Stephan Bergmann sberg...@redhat.com Date: Tue Mar 17 12:25:11 2015 +0100 Fix various XServiceInfo implementations ...to match what is recorded in the .component files Change-Id: Ie548cd37872d3b854001afaac73040e65c8f @Stephan: Thought you might want to comment on this change. Should we worry about it, given that people seem to use it in macros, or it's enough to just document it in the release notes? (And BTW, the old behavior is still documented at least at http://opengrok.libreoffice.org/xref/core/sw/qa/extras/README#160.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 --- Comment #2 from Stephan Bergmann sberg...@redhat.com --- (In reply to pierre-yves samyn from comment #0) I have nothing against this change but it should at least be documented in the release notes for a number of programs and extensions using this feature will not function. Are you aware of any programs or extensions that rely on specific values being returned from getImplementationName()? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92161] GBK encoded Chinese text can't be read
https://bugs.documentfoundation.org/show_bug.cgi?id=92161 Caolán McNamara caol...@redhat.com changed: What|Removed |Added CC|caol...@redhat.com | --- Comment #5 from Caolán McNamara caol...@redhat.com --- IMO non utf-8 text is just archaic at this point -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 --- Comment #3 from pierre-yves samyn pierre-yves.sa...@laposte.net --- Hi (In reply to Stephan Bergmann from comment #2) Are you aware of any programs or extensions that rely on specific values being returned from getImplementationName()? e.g. TemplateChanger I can possibly not understand your question, but we can not list all of them of course. Their developers will have to make updates and include the test version. It is not our bug... But they need to be informed, right? Best regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bridges/Library_cpp_uno.mk bridges/source
bridges/Library_cpp_uno.mk |9
bridges/source/cpp_uno/gcc3_linux_mips64/call.hxx| 38 +
bridges/source/cpp_uno/gcc3_linux_mips64/call.s | 132 +++
bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx | 707 +++
bridges/source/cpp_uno/gcc3_linux_mips64/except.cxx | 300
bridges/source/cpp_uno/gcc3_linux_mips64/share.hxx | 91 ++
bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx | 576 +++
7 files changed, 1853 insertions(+)
New commits:
commit 55b09bd09d1c84de64140949ae9b70e9564a6cd7
Author: Heiher r...@hev.cc
Date: Tue Jul 7 18:19:09 2015 +0800
bridges: Add support for linux mips64.
Change-Id: I71fd2f7d8bfd1b1511dec91f23b61b9f55d21472
Reviewed-on: https://gerrit.libreoffice.org/16845
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Stephan Bergmann sberg...@redhat.com
Tested-by: Stephan Bergmann sberg...@redhat.com
diff --git a/bridges/Library_cpp_uno.mk b/bridges/Library_cpp_uno.mk
index 34ecf04..2f67535 100644
--- a/bridges/Library_cpp_uno.mk
+++ b/bridges/Library_cpp_uno.mk
@@ -99,6 +99,15 @@ bridge_noopt_objects := cpp2uno uno2cpp
bridge_exception_objects := except
endif
+else ifeq ($(CPUNAME),GODSON64)
+
+ifneq ($(filter ANDROID LINUX,$(OS)),)
+bridges_SELECTED_BRIDGE := gcc3_linux_mips64
+bridge_asm_objects := call
+bridge_noopt_objects := cpp2uno uno2cpp
+bridge_exception_objects := except
+endif
+
else ifeq ($(OS)-$(CPUNAME),LINUX-POWERPC)
bridges_SELECTED_BRIDGE := gcc3_linux_powerpc
diff --git a/bridges/source/cpp_uno/gcc3_linux_mips64/call.hxx
b/bridges/source/cpp_uno/gcc3_linux_mips64/call.hxx
new file mode 100644
index 000..0be88ee
--- /dev/null
+++ b/bridges/source/cpp_uno/gcc3_linux_mips64/call.hxx
@@ -0,0 +1,38 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the License); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#ifndef INCLUDED_BRIDGES_SOURCE_CPP_UNO_GCC3_LINUX_MIPS64_CALL_HXX
+#define INCLUDED_BRIDGES_SOURCE_CPP_UNO_GCC3_LINUX_MIPS64_CALL_HXX
+
+#include sal/config.h
+
+#include sal/types.h
+
+namespace {
+
+ extern C typelib_TypeClass cpp_vtable_call(
+ sal_Int32 nFunctionIndex, sal_Int32 nVtableOffset,
+ void ** gpreg, void ** fpreg, void ** ovrflw,
+ sal_uInt64 * pRegisterReturn /* space for register return */ );
+
+}
+
+#endif
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/bridges/source/cpp_uno/gcc3_linux_mips64/call.s
b/bridges/source/cpp_uno/gcc3_linux_mips64/call.s
new file mode 100644
index 000..5787725
--- /dev/null
+++ b/bridges/source/cpp_uno/gcc3_linux_mips64/call.s
@@ -0,0 +1,132 @@
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed
+ * with this work for additional information regarding copyright
+ * ownership. The ASF licenses this file to you under the Apache
+ * License, Version 2.0 (the License); you may not use this file
+ * except in compliance with the License. You may obtain a copy of
+ * the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+.text
+.globl privateSnippetExecutor
+.LFB0 = .
+.cfi_startproc
+.cfi_personality 0x80,DW.ref.__gxx_personality_v0
+.cfi_lsda 0,.LLSDA0
+.ent privateSnippetExecutor
+.type privateSnippetExecutor, @function
+privateSnippetExecutor:
+.set noreorder
+daddiu $sp,$sp,-160
+.cfi_def_cfa_offset 160
+sd $ra,152($sp)
+.cfi_offset 31, -8
+.LEHB0 = .
+// Save the float point registers
+sdc1 $f12,80($sp)
+sdc1 $f13,88($sp)
+sdc1 $f14,96($sp)
+sdc1 $f15,104($sp)
+sdc1 $f16,112($sp)
+sdc1 $f17,120($sp)
+sdc1 $f18,128($sp)
+
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #14 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- This is still open for Windows and Mac. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - starmath/source writerfilter/source
starmath/source/view.cxx| 13 +
writerfilter/source/dmapper/StyleSheetTable.cxx | 16 +---
2 files changed, 10 insertions(+), 19 deletions(-)
New commits:
commit d7194ade91c1ca80065ec6e9ad6f801a097f8cd6
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 10 09:10:21 2015 +0200
Use std::unique_ptr in SmViewShell::Execute()
Change-Id: I8593c87f7a580e09d689df4cfdfecc8947f86159
diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index c5ffc39..f9bb00c 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -1666,7 +1666,7 @@ void SmViewShell::Execute(SfxRequest rReq)
xStrm = aDataHelper.GetInputStream(nId, );
if (xStrm.is())
{
-SfxMedium* pClipboardMedium = new SfxMedium();
+std::unique_ptrSfxMedium pClipboardMedium(new
SfxMedium());
pClipboardMedium-GetItemSet(); //generate initial
itemset, not sure if necessary
const SfxFilter* pMathFilter =
SfxFilter::GetFilterByName(MATHML_XML);
@@ -1674,7 +1674,6 @@ void SmViewShell::Execute(SfxRequest rReq)
pClipboardMedium-setStreamToLoadFrom(xStrm, true
/*bIsReadOnly*/);
InsertFrom(*pClipboardMedium);
GetDoc()-UpdateText();
-delete pClipboardMedium;
}
}
else
@@ -1685,13 +1684,13 @@ void SmViewShell::Execute(SfxRequest rReq)
::rtl::OUString aString;
if (aDataHelper.GetString( nId, aString))
{
-SfxMedium* pClipboardMedium = new SfxMedium();
+std::unique_ptrSfxMedium pClipboardMedium(new
SfxMedium());
pClipboardMedium-GetItemSet(); //generates
initial itemset, not sure if necessary
const SfxFilter* pMathFilter =
SfxFilter::GetFilterByName(MATHML_XML);
pClipboardMedium-SetFilter(pMathFilter);
-SvMemoryStream * pStrm;
+std::unique_ptrSvMemoryStream pStrm;
// The text to be imported might asserts encoding
like 'encoding=utf-8' but FORMAT_STRING is UTF-16.
// Force encoding to UTF-16, if encoding exists.
bool bForceUTF16 = false;
@@ -1709,18 +1708,16 @@ void SmViewShell::Execute(SfxRequest rReq)
if ( bForceUTF16 )
{
OUString aNewString = aString.replaceAt(
nPosL,nPosU-nPosL,UTF-16);
-pStrm = new SvMemoryStream(
const_castsal_Unicode *(aNewString.getStr()), aNewString.getLength() *
sizeof(sal_Unicode), StreamMode::READ);
+pStrm.reset(new SvMemoryStream(
const_castsal_Unicode *(aNewString.getStr()), aNewString.getLength() *
sizeof(sal_Unicode), StreamMode::READ));
}
else
{
-pStrm = new SvMemoryStream(
const_castsal_Unicode *(aString.getStr()), aString.getLength() *
sizeof(sal_Unicode), StreamMode::READ);
+pStrm.reset(new SvMemoryStream(
const_castsal_Unicode *(aString.getStr()), aString.getLength() *
sizeof(sal_Unicode), StreamMode::READ));
}
uno::Referenceio::XInputStream xStrm2( new
::utl::OInputStreamWrapper(*pStrm) );
pClipboardMedium-setStreamToLoadFrom(xStrm2, true
/*bIsReadOnly*/);
InsertFrom(*pClipboardMedium);
GetDoc()-UpdateText();
-delete pClipboardMedium;
-delete pStrm;
}
}
}
commit ebb5068a43c3ac8362225c1762d2a8eb74cf0eba
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 10 09:07:05 2015 +0200
Use std::transform
Change-Id: If3b361d4ba7155547316796265cbd3955a4b8071
diff --git a/writerfilter/source/dmapper/StyleSheetTable.cxx
b/writerfilter/source/dmapper/StyleSheetTable.cxx
index 635b198..bc6d88e 100644
--- a/writerfilter/source/dmapper/StyleSheetTable.cxx
+++ b/writerfilter/source/dmapper/StyleSheetTable.cxx
@@ -891,19 +891,14 @@ void PropValVector::Insert(const beans::PropertyValue
rVal)
}
m_aValues.push_back(rVal);
}
+
uno::Sequence uno::Any PropValVector::getValues()
{
-uno::Sequence uno::Any aRet( m_aValues.size() );
-uno::Any* pValues = aRet.getArray();
-sal_Int32 nVal = 0;
-auto aIt =
[Libreoffice-bugs] [Bug 63955] CRASH on FILEOPEN .sdd/.odp. Bad allocation - Crash. 100% reproducible.
https://bugs.documentfoundation.org/show_bug.cgi?id=63955 Gerry gerry.trep...@googlemail.com changed: What|Removed |Added Summary|Freeze: Opening attached|CRASH on FILEOPEN |.sdd/.odp file freezes |.sdd/.odp. Bad allocation |LibreOffice. Takes 100% of |- Crash. 100% |RAM and never ends |reproducible. --- Comment #9 from Gerry gerry.trep...@googlemail.com --- LibreOffice 5.0 rc2 crashes on this .odp file. 100% reproducible. It first shows bad allocation and then crashes. Tested on Win7. It would be perfect if someone could have a look at this bug. It is an absolutely obvious crasher bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: canvas/source
canvas/source/cairo/cairo_canvas.hxx |6 +++---
canvas/source/cairo/cairo_canvasbitmap.hxx |4 ++--
canvas/source/cairo/cairo_canvascustomsprite.hxx |6 +++---
canvas/source/cairo/cairo_canvasfont.hxx |4 ++--
canvas/source/cairo/cairo_canvashelper.cxx |6 +++---
canvas/source/cairo/cairo_devicehelper.cxx |2 --
canvas/source/cairo/cairo_spritecanvas.hxx |6 +++---
canvas/source/cairo/cairo_spritedevicehelper.cxx |2 --
canvas/source/cairo/cairo_textlayout.hxx |4 ++--
canvas/source/directx/dx_canvas.hxx |7 +++
canvas/source/directx/dx_canvasbitmap.hxx|6 ++
canvas/source/directx/dx_canvascustomsprite.hxx |6 +++---
canvas/source/directx/dx_canvasfont.hxx |4 ++--
canvas/source/directx/dx_devicehelper.cxx|2 --
canvas/source/directx/dx_spritecanvas.hxx|6 +++---
canvas/source/directx/dx_spritedevicehelper.cxx |2 --
canvas/source/directx/dx_textlayout.hxx |4 ++--
canvas/source/factory/cf_service.cxx |4 ++--
canvas/source/opengl/ogl_canvasbitmap.hxx|4 ++--
canvas/source/opengl/ogl_canvascustomsprite.hxx |4 ++--
canvas/source/opengl/ogl_canvasfont.hxx |4 ++--
canvas/source/opengl/ogl_spritecanvas.hxx|4 ++--
canvas/source/opengl/ogl_textlayout.hxx |4 ++--
canvas/source/simplecanvas/simplecanvasimpl.cxx |4 ++--
canvas/source/tools/canvastools.cxx |6 +++---
canvas/source/vcl/canvas.hxx |4 ++--
canvas/source/vcl/canvasbitmap.hxx |4 ++--
canvas/source/vcl/canvascustomsprite.hxx |6 +++---
canvas/source/vcl/canvasfont.hxx |4 ++--
canvas/source/vcl/spritecanvas.hxx |6 +++---
canvas/source/vcl/textlayout.hxx |4 ++--
31 files changed, 64 insertions(+), 75 deletions(-)
New commits:
commit b854086df80b2607a3506bc8d455c98ae58aa295
Author: Takeshi Abe t...@fixedpoint.jp
Date: Mon Jul 6 23:17:44 2015 +0900
tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, in canvas.
Change-Id: I8604e6b6e0f45539e3411c98a166518b837b6758
Reviewed-on: https://gerrit.libreoffice.org/16798
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/canvas/source/cairo/cairo_canvas.hxx
b/canvas/source/cairo/cairo_canvas.hxx
index d3e342e..edaa7f8 100644
--- a/canvas/source/cairo/cairo_canvas.hxx
+++ b/canvas/source/cairo/cairo_canvas.hxx
@@ -34,7 +34,7 @@
#include com/sun/star/rendering/XGraphicDevice.hpp
#include com/sun/star/rendering/XBufferController.hpp
-#include cppuhelper/compbase7.hxx
+#include cppuhelper/compbase.hxx
#include comphelper/uno3.hxx
#include canvas/base/spritecanvasbase.hxx
@@ -53,7 +53,7 @@
namespace cairocanvas
{
-typedef ::cppu::WeakComponentImplHelper7
::com::sun::star::rendering::XBitmapCanvas,
+typedef ::cppu::WeakComponentImplHelper
::com::sun::star::rendering::XBitmapCanvas,
::com::sun::star::rendering::XIntegerBitmap,
::com::sun::star::rendering::XGraphicDevice,
::com::sun::star::lang::XMultiServiceFactory,
@@ -72,7 +72,7 @@ namespace cairocanvas
implement some of those interface methods.
The reason why this appears kinda convoluted is the fact that
-we cannot specify non-IDL types as WeakComponentImplHelperN
+we cannot specify non-IDL types as WeakComponentImplHelper
template args, and furthermore, don't want to derive
::canvas::CanvasBase directly from
SurfaceProvider (because derivees of
diff --git a/canvas/source/cairo/cairo_canvasbitmap.hxx
b/canvas/source/cairo/cairo_canvasbitmap.hxx
index bf1299f..3ad2547 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.hxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.hxx
@@ -20,7 +20,7 @@
#ifndef INCLUDED_CANVAS_SOURCE_CAIRO_CAIRO_CANVASBITMAP_HXX
#define INCLUDED_CANVAS_SOURCE_CAIRO_CAIRO_CANVASBITMAP_HXX
-#include cppuhelper/compbase4.hxx
+#include cppuhelper/compbase.hxx
#include com/sun/star/lang/XServiceInfo.hpp
#include com/sun/star/rendering/XBitmapCanvas.hpp
@@ -44,7 +44,7 @@
namespace cairocanvas
{
-typedef ::cppu::WeakComponentImplHelper4
::com::sun::star::rendering::XBitmapCanvas,
+typedef ::cppu::WeakComponentImplHelper
::com::sun::star::rendering::XBitmapCanvas,
::com::sun::star::rendering::XIntegerBitmap,
::com::sun::star::lang::XServiceInfo,
::com::sun::star::beans::XFastPropertySetCanvasBitmapBase_Base;
diff --git
[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=315afb12853624bdaac553a8528390c3a61c8351 tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added CC||t...@iki.fi --- Comment #6 from Stephan Bergmann sberg...@redhat.com --- (In reply to DavidO from comment #5) @Stephan? Don't know much about that WNT-specific load_msvcr(); Tor once added it with http://cgit.freedesktop.org/libreoffice/core/commit/?id=debf1d0568118f52a23e6c2b2e50c11bd46ed70e Load msvcr71.dll needed by JVM using explicit path, see fdo#32426. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] New: GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 Bug ID: 92668 Summary: GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before Product: LibreOffice Version: unspecified Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: BASIC Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: pierre-yves.sa...@laposte.net Hi GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before. (same for other formats of course : com.sun.star.comp.Calc.SpreadsheetDocument) Steps to reproduce: Execute : print thiscomponent.getImplementationName Platform: Windows 7/64 Version: 5.0.0.2.0+ Build ID: d119b3d45d8075e981ca5c09e987f9445f829971 TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-0, Time: 2015-07-09_11:29:35 Locale: fr-FR (fr_FR) Also reproduced (fr-qa, fr-user) so I set status to New. I have nothing against this change but it should at least be documented in the release notes for a number of programs and extensions using this feature will not function. Regards Pierre-Yves -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91480] allow to build shared libraries in bundled projects on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91480 --- Comment #2 from David Tardon dtar...@redhat.com --- (In reply to Ashod Nakashian from comment #1) After spending some time tackling this, it's clear that it isn't as straightforward as I was led to believe. Sorry I misled you. This was intended to be an exploration-style task, but I see the description does not say that anywhere... Thanks for the analysis, though! The main issue is that, while the compiler (CC and CXX) is replaced by the gcc- and g++-wrapper, the linker isn't replaced. LD isn't used at all, instead, these external projects (the handful I looked into) explicitly use LIBTOOL, which points to a script generated by configure. So defining LIBTOOL doesn't help here. Actually, LD is used. But indirectly by libtool. In all the cases I've checked, setting --enable-shared and --disable-static do not produce the desired result. At least in the case of libwps it's clear that shared libraries are not supported (or are broken if they were at some point). If the project in question compiles successfully, it always generates a static library. So, that is probably because libtool finds no known dynamic linker. It defaults to building static libraries in that case instead of just failing as any sensible tool would do. You can check the build log (in workdir/UnpackedTarball/*/build.log by default); there should be an info message from libtool that it can't build dynamic libs for some reason and that it switches to static. So the solution is to patch configure (in each project) such that shared libraries would be supported. To do that we would most probably need to wrap MS link.exe in the same way that gcc-wrapper wraps cl.exe. But first we need to make sure that Makefile does call LD, which can then be proxied as necessary. I agree that a ld-wrapper seems to be needed. But not with the rest. Dynamic libraries are already supported, through libtool. But libtool either cannot use link.exe directly (- a wrapper) or it needs extra options for building dynamic libs (my first suspect would be -no-undefined, but libwps already passes that one). Another way is to patch the VS projects where they are available to produce DLL, then compile using devenv.com (part of VS) instead of $(MAKE). This should be the simplest solution, but many projects might not even have these VS projects, although those could be created as well. Well, while some of the projects do have VS project files, these are typically out-of-date... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 91480] allow to build shared libraries in bundled projects on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91480 --- Comment #2 from David Tardon dtar...@redhat.com --- (In reply to Ashod Nakashian from comment #1) After spending some time tackling this, it's clear that it isn't as straightforward as I was led to believe. Sorry I misled you. This was intended to be an exploration-style task, but I see the description does not say that anywhere... Thanks for the analysis, though! The main issue is that, while the compiler (CC and CXX) is replaced by the gcc- and g++-wrapper, the linker isn't replaced. LD isn't used at all, instead, these external projects (the handful I looked into) explicitly use LIBTOOL, which points to a script generated by configure. So defining LIBTOOL doesn't help here. Actually, LD is used. But indirectly by libtool. In all the cases I've checked, setting --enable-shared and --disable-static do not produce the desired result. At least in the case of libwps it's clear that shared libraries are not supported (or are broken if they were at some point). If the project in question compiles successfully, it always generates a static library. So, that is probably because libtool finds no known dynamic linker. It defaults to building static libraries in that case instead of just failing as any sensible tool would do. You can check the build log (in workdir/UnpackedTarball/*/build.log by default); there should be an info message from libtool that it can't build dynamic libs for some reason and that it switches to static. So the solution is to patch configure (in each project) such that shared libraries would be supported. To do that we would most probably need to wrap MS link.exe in the same way that gcc-wrapper wraps cl.exe. But first we need to make sure that Makefile does call LD, which can then be proxied as necessary. I agree that a ld-wrapper seems to be needed. But not with the rest. Dynamic libraries are already supported, through libtool. But libtool either cannot use link.exe directly (- a wrapper) or it needs extra options for building dynamic libs (my first suspect would be -no-undefined, but libwps already passes that one). Another way is to patch the VS projects where they are available to produce DLL, then compile using devenv.com (part of VS) instead of $(MAKE). This should be the simplest solution, but many projects might not even have these VS projects, although those could be created as well. Well, while some of the projects do have VS project files, these are typically out-of-date... -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/inc
sc/inc/pch/precompiled_sc.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit f06f06d50393184f1ca2e27db6167b08edc26cb3 Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 10 09:15:31 2015 +0100 formula/random.hxx in pch Change-Id: I0cb650fdaf6608abfab43b145ca8a299f8d4ddb4 diff --git a/sc/inc/pch/precompiled_sc.hxx b/sc/inc/pch/precompiled_sc.hxx index 8ebbb25..d2b620f 100644 --- a/sc/inc/pch/precompiled_sc.hxx +++ b/sc/inc/pch/precompiled_sc.hxx @@ -517,7 +517,6 @@ #include formula/formulahelper.hxx #include formula/grammar.hxx #include formula/opcode.hxx -#include formula/random.hxx #include formula/token.hxx #include formula/vectortoken.hxx #include functional ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92615] bridges: Add support for linux mips64.
https://bugs.documentfoundation.org/show_bug.cgi?id=92615 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Stephan Bergmann sberg...@redhat.com --- (In reply to Heiher from comment #2) OK, This is the changes on gerrit: https://gerrit.libreoffice.org/16845 Integrated as http://cgit.freedesktop.org/libreoffice/core/commit/?id=55b09bd09d1c84de64140949ae9b70e9564a6cd7 bridges: Add support for linux mips64. Thanks a lot for working on this! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- --- Comment #14 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- This is still open for Windows and Mac. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #13 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** Bug 92008 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92008] INTEGRATION: Hide Underline Hotkeys when not set in OS
https://bugs.documentfoundation.org/show_bug.cgi?id=92008 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED CC||s.mehrbr...@gmail.com Resolution|--- |DUPLICATE --- Comment #3 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** This bug has been marked as a duplicate of bug 54169 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #13 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- *** Bug 92008 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] SI-GUI Java help needed (please run a jar file and post the output)
El Viernes, 10 de julio de 2015 08:07:39 Florian Reisinger escribió: Hi again :) The promised new jar (which got incredibly huge :O) http://florei-libo.115.at/rssft/siguitest2.jar [2,3 MB] These are the current dependencies of Java Si-GUI as sad as it may be ^^ Contains Guava and JShortcut (which are not needed for that, but anyway :) ) Please report anything unexpected. keep in mind Java 7 is not intended to be supported :) Ok,so here are the results: --- 1st test (Oracle Java 8 + 32bits) $ java -version java version 1.8.0_45 Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) Server VM (build 25.45-b02, mixed mode) $ java -jar siguitest2.jar Your OS is one of [LinuxDeb, LinuxRPM]. Your architecture is x86 --- 2nd test (Oracle Java 8 + 64bits) $ java -version java version 1.8.0_45 Java(TM) SE Runtime Environment (build 1.8.0_45-b14) Java HotSpot(TM) 64-Bit Server VM (build 25.45-b02, mixed mode) $ java -jar siguitest2.jar Your OS is one of [LinuxDeb, LinuxRPM]. Your architecture is x86_64 Best regards, -- - Carlos Rodríguezcarlos.rodrig...@tegnix.com TEGNIX B-15.990.013 Telf. (+34) 886 122 307 Móvil (+34) 622 337 447 - signature.asc Description: This is a digitally signed message part. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #15 from tommy27 ba...@quipo.it --- let' put it back to NEW then -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #15 from tommy27 ba...@quipo.it --- let' put it back to NEW then -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 tommy27 ba...@quipo.it changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 tommy27 ba...@quipo.it changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #16 from Tor Lillqvist t...@iki.fi --- Is accelerator even a thing on OS X? Shortcuts (like ⌘-F for Find), sure, but I don't think it has accelerators. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 --- Comment #16 from Tor Lillqvist t...@iki.fi --- Is accelerator even a thing on OS X? Shortcuts (like ⌘-F for Find), sure, but I don't think it has accelerators. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b854086df80b2607a3506bc8d455c98ae58aa295 tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #8 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b854086df80b2607a3506bc8d455c98ae58aa295 tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: binaryurp/source bridges/test
binaryurp/source/bridge.hxx |4
++--
binaryurp/source/bridgefactory.hxx|4
++--
bridges/test/java_uno/acquire/testacquire.cxx |4
++--
bridges/test/java_uno/any/transport.cxx |4
++--
bridges/test/java_uno/equals/testequals.cxx |4
++--
bridges/test/java_uno/nativethreadpool/testnativethreadpoolclient.cxx |4
++--
bridges/test/java_uno/nativethreadpool/testnativethreadpoolserver.cxx |4
++--
bridges/test/testserver.cxx |1 -
8 files changed, 14 insertions(+), 15 deletions(-)
New commits:
commit 315afb12853624bdaac553a8528390c3a61c8351
Author: Takeshi Abe t...@fixedpoint.jp
Date: Fri Jul 3 11:41:33 2015 +0900
tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants, in binaryurp / bridges.
Change-Id: I2d158c24e73681907cae5815d4b07b1c74f74335
Reviewed-on: https://gerrit.libreoffice.org/16792
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/binaryurp/source/bridge.hxx b/binaryurp/source/bridge.hxx
index 232b02b..1fe1bd6 100644
--- a/binaryurp/source/bridge.hxx
+++ b/binaryurp/source/bridge.hxx
@@ -31,7 +31,7 @@
#include com/sun/star/lang/XComponent.hpp
#include com/sun/star/uno/Reference.hxx
#include com/sun/star/uno/RuntimeException.hpp
-#include cppuhelper/implbase2.hxx
+#include cppuhelper/implbase.hxx
#include osl/conditn.hxx
#include osl/mutex.hxx
#include rtl/ref.hxx
@@ -67,7 +67,7 @@ namespace rtl { class ByteSequence; }
namespace binaryurp {
class Bridge:
-public cppu::WeakImplHelper2
+public cppu::WeakImplHelper
com::sun::star::bridge::XBridge, com::sun::star::lang::XComponent
{
public:
diff --git a/binaryurp/source/bridgefactory.hxx
b/binaryurp/source/bridgefactory.hxx
index 27ec274..ac13ace 100644
--- a/binaryurp/source/bridgefactory.hxx
+++ b/binaryurp/source/bridgefactory.hxx
@@ -32,7 +32,7 @@
#include com/sun/star/uno/Reference.hxx
#include com/sun/star/uno/RuntimeException.hpp
#include cppuhelper/basemutex.hxx
-#include cppuhelper/compbase2.hxx
+#include cppuhelper/compbase.hxx
#include sal/types.h
namespace com { namespace sun { namespace star {
@@ -49,7 +49,7 @@ namespace binaryurp {
// the implementation does not care about a disposed state:
typedef
-cppu::WeakComponentImplHelper2
+cppu::WeakComponentImplHelper
com::sun::star::lang::XServiceInfo,
com::sun::star::bridge::XBridgeFactory2
BridgeFactoryBase;
diff --git a/bridges/test/java_uno/acquire/testacquire.cxx
b/bridges/test/java_uno/acquire/testacquire.cxx
index 99d0a98..942572b 100644
--- a/bridges/test/java_uno/acquire/testacquire.cxx
+++ b/bridges/test/java_uno/acquire/testacquire.cxx
@@ -34,7 +34,7 @@
#include com/sun/star/uno/XComponentContext.hpp
#include com/sun/star/uno/XInterface.hpp
#include cppuhelper/factory.hxx
-#include cppuhelper/implbase3.hxx
+#include cppuhelper/implbase.hxx
#include cppuhelper/supportsservice.hxx
#include cppuhelper/weak.hxx
#include osl/conditn.hxx
@@ -176,7 +176,7 @@ css::uno::Any Derived::queryInterface(css::uno::Type const
type)
namespace {
-class Service: public cppu::WeakImplHelper3
+class Service: public cppu::WeakImplHelper
css::lang::XServiceInfo, css::lang::XMain, test::javauno::acquire::XTest
{
public:
diff --git a/bridges/test/java_uno/any/transport.cxx
b/bridges/test/java_uno/any/transport.cxx
index 380abf4..e8015c7 100644
--- a/bridges/test/java_uno/any/transport.cxx
+++ b/bridges/test/java_uno/any/transport.cxx
@@ -25,7 +25,7 @@
#include uno/environment.hxx
#include jvmaccess/virtualmachine.hxx
#include jvmaccess/unovirtualmachine.hxx
-#include cppuhelper/implbase1.hxx
+#include cppuhelper/implbase.hxx
#include test/java_uno/anytest/XTransport.hpp
#include test/java_uno/anytest/DerivedInterface.hpp
@@ -37,7 +37,7 @@ using ::test::java_uno::anytest::XTransport;
namespace
{
-class Transport : public ::cppu::WeakImplHelper1 XTransport
+class Transport : public ::cppu::WeakImplHelper XTransport
{
public:
virtual Any SAL_CALL mapAny( Any const any )
diff --git a/bridges/test/java_uno/equals/testequals.cxx
b/bridges/test/java_uno/equals/testequals.cxx
index 34ca8c0..3cfd75f 100644
--- a/bridges/test/java_uno/equals/testequals.cxx
+++ b/bridges/test/java_uno/equals/testequals.cxx
@@ -35,7 +35,7 @@
#include com/sun/star/uno/XComponentContext.hpp
#include com/sun/star/uno/XInterface.hpp
#include cppuhelper/factory.hxx
-#include cppuhelper/implbase2.hxx
+#include cppuhelper/implbase.hxx
#include cppuhelper/supportsservice.hxx
#include cppuhelper/weak.hxx
#include rtl/string.h
@@ -48,7 +48,7 @@
namespace {
-class Service: public cppu::WeakImplHelper2
+class Service: public cppu::WeakImplHelper
css::lang::XServiceInfo,
[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #9 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=315afb12853624bdaac553a8528390c3a61c8351 tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/app/svdata.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit db10a790df13c2d8f108bd829b4b025de2fc07e2 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 10 09:03:05 2015 +0200 loplugin:literaltoboolconversion Change-Id: Iee43daf2f3c5dfe7dd1434ad63ffccc28d165cde diff --git a/vcl/source/app/svdata.cxx b/vcl/source/app/svdata.cxx index 9c2cde1..bfc2bb4 100644 --- a/vcl/source/app/svdata.cxx +++ b/vcl/source/app/svdata.cxx @@ -84,8 +84,8 @@ ImplSVData::ImplSVData() memset( this, 0, sizeof( ImplSVData ) ); maHelpData.mbAutoHelpId = true; maNWFData.maMenuBarHighlightTextColor = Color( COL_TRANSPARENT ); -maNWFData.mbEnableAccel = 1; -maNWFData.mbAutoAccel = 0; +maNWFData.mbEnableAccel = true; +maNWFData.mbAutoAccel = false; } ImplSVGDIData::~ImplSVGDIData() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 63955] CRASH on FILEOPEN .odp presentation. Bad allocation - Crash. 100% reproducible.
https://bugs.documentfoundation.org/show_bug.cgi?id=63955 Gerry gerry.trep...@googlemail.com changed: What|Removed |Added Summary|CRASH on FILEOPEN |CRASH on FILEOPEN .odp |.sdd/.odp. Bad allocation |presentation. Bad |- Crash. 100% |allocation - Crash. 100% |reproducible. |reproducible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/svx
include/svx/sdrpaintwindow.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 37a367a3589302893c237237e4eb98f1e4195f6d Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 10 09:37:13 2015 +0200 loplugin:vclwidgets Change-Id: I4c6623b83f0c21b292aa0178c2ee6478e330eb64 diff --git a/include/svx/sdrpaintwindow.hxx b/include/svx/sdrpaintwindow.hxx index 18a3482..36176e5 100644 --- a/include/svx/sdrpaintwindow.hxx +++ b/include/svx/sdrpaintwindow.hxx @@ -69,7 +69,7 @@ private: OutputDevice mrOutputDevice; /// In case mrOutputDevice is a buffer for a vcl::Window, this is the window. -vcl::Window*mpWindow; +VclPtrvcl::Window mpWindow; // the SdrPaintView this window belongs to SdrPaintView mrPaintView; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 pierre-yves samyn pierre-yves.sa...@laposte.net changed: What|Removed |Added Keywords||regression Status|UNCONFIRMED |NEW Version|unspecified |5.0.0.2 rc Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - comphelper/source formula/Library_for.mk formula/source include/comphelper include/formula scaddins/Library_analysis.mk scaddins/source sc/source vcl/qa vcl
comphelper/source/misc/random.cxx |7 ++
formula/Library_for.mk|1
formula/source/core/api/random.cxx| 56 --
include/comphelper/random.hxx |3
include/formula/random.hxx| 31 -
sc/source/core/opencl/formulagroupcl.cxx |4 -
sc/source/core/tool/interpr1.cxx |3
scaddins/Library_analysis.mk |1
scaddins/source/analysis/analysis.cxx |4 -
vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf |binary
vcl/source/filter/wmf/winwmf.cxx | 10 ++-
11 files changed, 22 insertions(+), 98 deletions(-)
New commits:
commit fd2749455fe25e24b448a44f9ada6113e5ac0d13
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 10 08:40:42 2015 +0100
avoid endless loop with busted wmf
Change-Id: I104de360f2e861e959ad2dad434a768440877f6f
diff --git a/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf
new file mode 100644
index 000..7ba05cb
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/wmf/fail/hang-1.wmf differ
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index 343b74f..7b87f68 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -1394,9 +1394,13 @@ void WMFReader::ReadWMF()
}
}
}
-nPos += nRecSize * 2;
-if ( nPos = nEndPos )
-pWMF-Seek( nPos );
+const sal_uInt32 nAvailableBytes = nEndPos - nPos;
+const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2;
+if (nRecSize = nMaxPossibleRecordSize)
+{
+nPos += nRecSize * 2;
+pWMF-Seek(nPos);
+}
else
pWMF-SetError( SVSTREAM_FILEFORMAT_ERROR );
}
commit 5b2f8231945fedc46425e00f1234dcac90628c1d
Author: Caolán McNamara caol...@redhat.com
Date: Thu Jul 9 14:48:31 2015 +0100
add a SAL_RAND_REPEATABLE for repeatable random nums
merge the formula and comphelper ones together
Change-Id: I2e7e2cdb176afc6982e384fa1e007da5b914e6f0
diff --git a/comphelper/source/misc/random.cxx
b/comphelper/source/misc/random.cxx
index 0c6e83e..a70a73e 100644
--- a/comphelper/source/misc/random.cxx
+++ b/comphelper/source/misc/random.cxx
@@ -39,6 +39,13 @@ struct RandomNumberGenerator
STD_RNG_ALGO global_rng;
RandomNumberGenerator()
{
+bool bRepeatable = (getenv(SAL_RAND_REPEATABLE) != 0);
+if (bRepeatable)
+{
+global_rng.seed(42);
+return;
+}
+
try
{
std::random_device rd;
diff --git a/formula/Library_for.mk b/formula/Library_for.mk
index cbdff46..ad7da5a 100644
--- a/formula/Library_for.mk
+++ b/formula/Library_for.mk
@@ -42,7 +42,6 @@ $(eval $(call gb_Library_add_exception_objects,for,\
formula/source/core/api/FormulaCompiler \
formula/source/core/api/FormulaOpCodeMapperObj \
formula/source/core/api/grammar \
-formula/source/core/api/random \
formula/source/core/api/services \
formula/source/core/api/token \
formula/source/core/api/vectortoken \
diff --git a/formula/source/core/api/random.cxx
b/formula/source/core/api/random.cxx
deleted file mode 100644
index 727262f..000
--- a/formula/source/core/api/random.cxx
+++ /dev/null
@@ -1,56 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#include time.h
-
-#include random
-
-#include formula/random.hxx
-#include rtl/instance.hxx
-
-namespace {
-
-struct CalcFormulaRandomGenerator
-{
-std::mt19937 aRng;
-CalcFormulaRandomGenerator()
-{
-// initialises the state of this RNG.
-// should only be called once.
-bool bRepeatable = (getenv(SC_RAND_REPEATABLE) != 0);
-aRng.seed(bRepeatable ? 42 : time(NULL));
-}
-};
-
-class theCalcFormulaRandomGenerator : public
rtl::StaticCalcFormulaRandomGenerator, theCalcFormulaRandomGenerator {};
-
-}
-
-namespace formula
-{
-
-namespace rng
-{
-
-double fRandom(double a, double b)
-{
-std::uniform_real_distributiondouble dist(a, b);
-return dist(theCalcFormulaRandomGenerator::get().aRng);
-}
-
-sal_Int32 nRandom(sal_Int32 a, sal_Int32 b)
-{
-std::uniform_int_distributionsal_Int32 dist(a, b);
-return dist(theCalcFormulaRandomGenerator::get().aRng);
-}
-
-} // rng
-} //
[Libreoffice-bugs] [Bug 92289] Impress right click context menu is blank in Slide Show
https://bugs.documentfoundation.org/show_bug.cgi?id=92289 --- Comment #17 from Miklos Vajna vmik...@collabora.co.uk --- I tried to reproduce it on my Windows build, still no luck. 32bit Windows 7, 32bit LO, single monitor, no manual enable/disable of presenter console. So, there might be a few more options that may affect if the bug is reproducible: 1) 64bit/32bit Windows 2) 64bit/32bit LO 3) Single/multiple monitors 4) Manually enabled/disabled presenter console If you could experiment with the above (if any of these make the bug appear/disappear), that would be great. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: connectivity/source sal/osl sc/source stoc/source ucb/source writerfilter/source
connectivity/source/drivers/file/fcode.cxx |7 +--
connectivity/source/drivers/postgresql/pq_tools.cxx | 16
sal/osl/all/debugbase.cxx |3 +--
sal/osl/unx/file_stat.cxx |4 +---
sal/osl/w32/file_dirvol.cxx |4 +---
sc/source/filter/oox/workbookhelper.cxx |5 ++---
stoc/source/security/permissions.cxx|6 ++
ucb/source/ucp/file/prov.cxx|2 +-
writerfilter/source/dmapper/PropertyMap.cxx | 15 +--
9 files changed, 18 insertions(+), 44 deletions(-)
New commits:
commit 54013188b24a1a02491a2853f731461253065424
Author: Noel Grandin n...@peralex.com
Date: Wed Jul 8 15:02:31 2015 +0200
cleanup some unnecessary direct usage of the OString/OUString C API.
Change-Id: I6edee95aae1c169ce70063562a0c1b287e0c4735
Reviewed-on: https://gerrit.libreoffice.org/16861
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/connectivity/source/drivers/file/fcode.cxx
b/connectivity/source/drivers/file/fcode.cxx
index 9679391..e4c1426 100644
--- a/connectivity/source/drivers/file/fcode.cxx
+++ b/connectivity/source/drivers/file/fcode.cxx
@@ -305,12 +305,7 @@ bool OOp_COMPARE::operate(const OOperand* pLeft, const
OOperand* pRight) const
case DataType::LONGVARCHAR:
{
OUString sLH = aLH, sRH = aRH;
-sal_Int32 nRes = rtl_ustr_compareIgnoreAsciiCase_WithLength
-(
- sLH.pData-buffer,
- sLH.pData-length,
- sRH.pData-buffer,
- sRH.pData-length );
+sal_Int32 nRes = sLH.compareToIgnoreAsciiCase(sRH);
switch(aPredicateType)
{
case SQLFilterOperator::EQUAL: bResult = (nRes == 0);
break;
diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx
b/connectivity/source/drivers/postgresql/pq_tools.cxx
index 4d75e8c3..ae9b304 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -769,9 +769,7 @@ OString extractSingleTableFromSelect( const OStringVector
vec )
token ++;
}
-if( token vec.size() rtl_str_compare_WithLength(
-vec[token].getStr(), vec[token].getLength(),
-RTL_CONSTASCII_STRINGPARAM(() ) )
+if( token vec.size() vec[token] == ( )
{
// it is a table or a function name
OStringBuffer buf(128);
@@ -783,9 +781,7 @@ OString extractSingleTableFromSelect( const OStringVector
vec )
if( token vec.size() )
{
-if( rtl_str_compare_WithLength(
-vec[token].getStr(), vec[token].getLength(),
-RTL_CONSTASCII_STRINGPARAM( . ) ) == 0 )
+if( vec[token] == . )
{
buf.append( vec[token] );
token ++;
@@ -803,9 +799,7 @@ OString extractSingleTableFromSelect( const OStringVector
vec )
ret = buf.makeStringAndClear();
// now got my table candidate
-if( token vec.size() rtl_str_compare_WithLength(
-vec[token].getStr(), vec[token].getLength(),
-RTL_CONSTASCII_STRINGPARAM( ( ) ) == 0 )
+if( token vec.size() vec[token] == ( )
{
// whoops, it is a function
ret.clear();
@@ -823,9 +817,7 @@ OString extractSingleTableFromSelect( const OStringVector
vec )
if( token vec.size() )
{
-if( rtl_str_compare_WithLength(
-vec[token].getStr(), vec[token].getLength(),
-RTL_CONSTASCII_STRINGPARAM( , ) ) == 0 )
+if( vec[token] == , )
{
// whoops, multiple tables are used
ret.clear();
diff --git a/sal/osl/all/debugbase.cxx b/sal/osl/all/debugbase.cxx
index ae097ee..0f233f8 100644
--- a/sal/osl/all/debugbase.cxx
+++ b/sal/osl/all/debugbase.cxx
@@ -91,8 +91,7 @@ bool SAL_CALL osl_detail_ObjectRegistry_storeAddresses( char
const* pName )
return false;
// check for all:
rtl::OString const rFirst = rVec[0];
-if (rtl_str_compare_WithLength( rFirst.getStr(), rFirst.getLength(),
-RTL_CONSTASCII_STRINGPARAM(all) ) == 0)
+if ( rFirst == all )
return true;
OStringVec::const_iterator const iEnd( rVec.end() );
return std::find_if( rVec.begin(), iEnd,
diff --git a/sal/osl/unx/file_stat.cxx b/sal/osl/unx/file_stat.cxx
index 7818282..72d64f1 100644
--- a/sal/osl/unx/file_stat.cxx
+++ b/sal/osl/unx/file_stat.cxx
@@ -427,9 +427,7 @@ SAL_CALL
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - 5 commits - include/svx sc/source sd/source svx/source sw/source
include/svx/fmview.hxx |2 +-
include/svx/sdrpaintwindow.hxx |6 +-
include/svx/svdedxv.hxx |2 +-
include/svx/svdpntv.hxx |2 +-
sc/source/ui/view/tabview5.cxx |4 ++--
sd/source/ui/inc/OutlineView.hxx |2 +-
sd/source/ui/slideshow/showwin.cxx |2 +-
sd/source/ui/slideshow/slideshowimpl.cxx |4 ++--
sd/source/ui/view/outlview.cxx |4 ++--
svx/source/form/fmview.cxx |4 ++--
svx/source/svdraw/sdrpaintwindow.cxx |3 ++-
svx/source/svdraw/svdedxv.cxx| 15 ---
svx/source/svdraw/svdpntv.cxx|6 +++---
sw/source/core/view/viewsh.cxx |4 ++--
14 files changed, 33 insertions(+), 27 deletions(-)
New commits:
commit 80e06ad135d28380b5ba2b709e6fdcaefed35a46
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jul 10 09:37:13 2015 +0200
loplugin:vclwidgets
Change-Id: I4c6623b83f0c21b292aa0178c2ee6478e330eb64
(cherry picked from commit 37a367a3589302893c237237e4eb98f1e4195f6d)
diff --git a/include/svx/sdrpaintwindow.hxx b/include/svx/sdrpaintwindow.hxx
index 18a3482..36176e5 100644
--- a/include/svx/sdrpaintwindow.hxx
+++ b/include/svx/sdrpaintwindow.hxx
@@ -69,7 +69,7 @@ private:
OutputDevice mrOutputDevice;
/// In case mrOutputDevice is a buffer for a vcl::Window, this is the
window.
-vcl::Window*mpWindow;
+VclPtrvcl::Window mpWindow;
// the SdrPaintView this window belongs to
SdrPaintView mrPaintView;
commit 19f2ded51c7b85d9e87fc2f11ddeb5874ed5ae85
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Jul 9 17:02:09 2015 +0200
tdf#92645 svx rendercontext: fix missing paint on shape text editing
Change-Id: Icb70805969ccf55bd85fb38c03cf70c1e0b16554
(cherry picked from commit 40ade8d04380083e383d6a6e50e5c254fcde2b2f)
diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx
index 148..7d517e2 100644
--- a/svx/source/svdraw/svdedxv.cxx
+++ b/svx/source/svdraw/svdedxv.cxx
@@ -308,7 +308,12 @@ void SdrObjEditView::TextEditDrawing(SdrPaintWindow
rPaintWindow) const
{
OutlinerView* pOLV = pActiveOutliner-GetView(i);
-if(pOLV-GetWindow() == rPaintWindow.GetOutputDevice() ||
GetModel()-isTiledRendering())
+// If rPaintWindow knows that the output device is a render
+// context and is aware of the underlying vcl::Window,
+// compare against that; that's how double-buffering can
+// still find the matching OutlinerView.
+OutputDevice* pOutputDevice = rPaintWindow.GetWindow() ?
rPaintWindow.GetWindow() : rPaintWindow.GetOutputDevice();
+if(pOLV-GetWindow() == pOutputDevice ||
GetModel()-isTiledRendering())
{
ImpPaintOutlinerView(*pOLV, aCheckRect,
rPaintWindow.GetTargetOutputDevice());
return;
commit b0bf7b57f7a311541631295411e9b504d493bc58
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Thu Jul 9 15:24:42 2015 +0200
SdrPaintView::AddWindowToPaintView: take a vcl::Window, too
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38
(cherry picked from commit 9a11e59e5699c5eb0854355d3dd3848bc895545c)
diff --git a/include/svx/fmview.hxx b/include/svx/fmview.hxx
index 165f3c0..92328e1 100644
--- a/include/svx/fmview.hxx
+++ b/include/svx/fmview.hxx
@@ -83,7 +83,7 @@ public:
SdrObject* CreateXFormsControl( const svx::OXFormsDescriptor _rDesc );
virtual void MarkListHasChanged() SAL_OVERRIDE;
-virtual void AddWindowToPaintView(OutputDevice* pNewWin) SAL_OVERRIDE;
+virtual void AddWindowToPaintView(OutputDevice* pNewWin, vcl::Window*
pWindow) SAL_OVERRIDE;
virtual void DeleteWindowFromPaintView(OutputDevice* pOldWin) SAL_OVERRIDE;
static void createControlLabelPair(
diff --git a/include/svx/svdedxv.hxx b/include/svx/svdedxv.hxx
index e422125..005000d 100644
--- a/include/svx/svdedxv.hxx
+++ b/include/svx/svdedxv.hxx
@@ -225,7 +225,7 @@ public:
bool SetStyleSheet(SfxStyleSheet* pStyleSheet, bool bDontRemoveHardAttr);
// Intern: at mounting new OutlinerView...
-virtual void AddWindowToPaintView(OutputDevice* pNewWin) SAL_OVERRIDE;
+virtual void AddWindowToPaintView(OutputDevice* pNewWin, vcl::Window*
pWindow) SAL_OVERRIDE;
virtual void DeleteWindowFromPaintView(OutputDevice* pOldWin) SAL_OVERRIDE;
sal_uInt16 GetSelectionLevel() const;
diff --git a/include/svx/svdpntv.hxx b/include/svx/svdpntv.hxx
index 1b36032..a9c2c45 100644
--- a/include/svx/svdpntv.hxx
+++ b/include/svx/svdpntv.hxx
@@ -350,7 +350,7 @@ public:
// SdrPageView*
[Libreoffice-commits] core.git: include/vcl vcl/generic vcl/inc vcl/source
include/vcl/print.hxx |2 +-
include/vcl/printerinfomanager.hxx |1 +
vcl/generic/print/genprnpsp.cxx|1 +
vcl/generic/print/prtsetup.cxx |9 +
vcl/inc/jobset.h |1 +
vcl/source/gdi/jobset.cxx |2 ++
vcl/source/gdi/print.cxx |6 --
vcl/source/gdi/print3.cxx |2 +-
8 files changed, 20 insertions(+), 4 deletions(-)
New commits:
commit 2a1fe443a8343642292444be19cbd10700e7e01c
Author: Katarina Behrens katarina.behr...@cib.de
Date: Tue Jul 7 12:08:33 2015 +0200
Related tdf#91362: disable paper size orientation selection
Unless 'Use only papersize from printer prefs' is toggled on,
whatever the user sets here doesn't have any effect on the actual
printing (page settings from the document are used instead). It is
misleading to have the user believe otherwise.
It was really challenging to have this one toggle get all the way
down through several layers of abstraction, though ...
Change-Id: If240084ca23b3946a92882a6ee47dbc161b3b86c
Reviewed-on: https://gerrit.libreoffice.org/16812
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Katarina Behrens katarina.behr...@cib.de
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index cc2e80d..ce9dbba 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -320,7 +320,7 @@ public:
boolSetJobSetup( const JobSetup rSetup );
const JobSetup GetJobSetup() const { return maJobSetup; }
-boolSetup( vcl::Window* pWindow = NULL );
+boolSetup( vcl::Window* pWindow = NULL, bool
bPapersizeFromSetup = false );
boolSetPrinterProps( const Printer* pPrinter );
// SetPrinterOptions is used internally only now
diff --git a/include/vcl/printerinfomanager.hxx
b/include/vcl/printerinfomanager.hxx
index ec5c587..52245c4 100644
--- a/include/vcl/printerinfomanager.hxx
+++ b/include/vcl/printerinfomanager.hxx
@@ -50,6 +50,7 @@ struct PrinterInfo : JobData
// a list of special features separated by ',' not used by psprint
// but assigned from the outside (currently for
fax,pdf=,autoqueue,external_dialog)
OUString m_aFeatures;
+bool m_bPapersizeFromSetup;
PrinterInfo() :
JobData()
diff --git a/vcl/generic/print/genprnpsp.cxx b/vcl/generic/print/genprnpsp.cxx
index faaddc9..b64206f 100644
--- a/vcl/generic/print/genprnpsp.cxx
+++ b/vcl/generic/print/genprnpsp.cxx
@@ -560,6 +560,7 @@ bool PspSalInfoPrinter::Setup( SalFrame* pFrame,
ImplJobSetup* pJobSetup )
SetData( ~0, pJobSetup );
JobData::constructFromStreamBuffer( pJobSetup-mpDriverData,
pJobSetup-mnDriverDataLen, aInfo );
}
+aInfo.m_bPapersizeFromSetup = pJobSetup-mbPapersizeFromSetup;
if (SetupPrinterDriver(aInfo))
{
diff --git a/vcl/generic/print/prtsetup.cxx b/vcl/generic/print/prtsetup.cxx
index 25fddc4..0a7ab60 100644
--- a/vcl/generic/print/prtsetup.cxx
+++ b/vcl/generic/print/prtsetup.cxx
@@ -256,6 +256,14 @@ void RTSPaperPage::update()
m_pSlotText-Enable( false );
m_pSlotBox-Enable( false );
}
+
+// disable those, unless user wants to use papersize from printer prefs
+// as they have no influence on what's going to be printed anyway
+if (!m_pParent-m_aJobData.m_bPapersizeFromSetup)
+{
+m_pPaperBox-Enable( false );
+m_pOrientBox-Enable( false );
+}
}
IMPL_LINK( RTSPaperPage, SelectHdl, ListBox*, pBox )
@@ -286,6 +294,7 @@ IMPL_LINK( RTSPaperPage, SelectHdl, ListBox*, pBox )
m_pParent-m_aJobData.m_aContext.setValue( pKey, pValue );
update();
}
+
m_pParent-SetDataModified( true );
return 0;
}
diff --git a/vcl/inc/jobset.h b/vcl/inc/jobset.h
index 9ce9c5c..f0bf8a5 100644
--- a/vcl/inc/jobset.h
+++ b/vcl/inc/jobset.h
@@ -43,6 +43,7 @@ struct ImplJobSetup
longmnPaperHeight; // paper height (100th mm)
sal_uIntPtr mnDriverDataLen;// length of system specific data
sal_uInt8* mpDriverData; // system specific data (will be
streamed a byte block)
+boolmbPapersizeFromSetup;
std::unordered_map OUString, OUString, OUStringHash maValueMap;
ImplJobSetup();
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index 2570800..17fb9c7 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -61,6 +61,7 @@ ImplJobSetup::ImplJobSetup()
mnPaperHeight = 0;
mnDriverDataLen = 0;
mpDriverData= NULL;
+mbPapersizeFromSetup = false;
}
ImplJobSetup::ImplJobSetup( const ImplJobSetup rJobSetup ) :
@@ -83,6 +84,7 @@ ImplJobSetup::ImplJobSetup( const ImplJobSetup rJobSetup ) :
}
else
mpDriverData = NULL;
+mbPapersizeFromSetup =
[Libreoffice-bugs] [Bug 91362] wrong defaults for format/orientation in printsettingsdialogs of printerdrivers
https://bugs.documentfoundation.org/show_bug.cgi?id=91362 --- Comment #12 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Katarina Behrens committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a1fe443a8343642292444be19cbd10700e7e01c Related tdf#91362: disable paper size orientation selection It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 --- Comment #4 from Stephan Bergmann sberg...@redhat.com --- (In reply to pierre-yves samyn from comment #3) (In reply to Stephan Bergmann from comment #2) Are you aware of any programs or extensions that rely on specific values being returned from getImplementationName()? e.g. TemplateChanger I do not find the (case-insensitive) string getimplementationname in any of the zipped files in http://extensions.libreoffice.org/extension-center/template-changer/releases/1.2.6/template-changer-1.2.6? I can possibly not understand your question, but we can not list all of them of course. Their developers will have to make updates and include the test version. It is not our bug... But they need to be informed, right? I was not aware of any code that would rely on specific values returned from getImplementationName, that's why I asked. (It would be an error for code to rely on such specific values.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 --- Comment #7 from Michael Stahl mst...@redhat.com --- (In reply to DavidO from comment #5) So why is msvcr71.dll there as well? And why are we hard code the names and not induce them from _MSC_VER? it is irrelevant what MSVC was used to build LO, what matters is what MSVC was used to build the Oracle JRE. (except that in the corner case of LO and JRE being built with the same MSVC version, as was the case with LO = 4.0 and Oracle JRE 7 it works by accident) the msvcr71.dll was apparently used by Oracle JRE 6, while msvcr100.dll is used by Oracle JRE 7 (and 8, presumably but not sure about that). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92289] Impress right click context menu is blank in Slide Show
https://bugs.documentfoundation.org/show_bug.cgi?id=92289 --- Comment #18 from Óvári ov...@hotmail.com --- Bug 92289 *mostly* appears 1) 64bit Windows 8.1 2) 64bit LO Version: 5.1.0.0.alpha1+ (x64) Build ID: 6f928deb55b5bcff3e8d11a5ace017732176e86a TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-08_21:55:21 3) Multiple (2) monitors 4) Slide Show → Slide Show Settings… → (Multiple Displays) Presentation display: Auto External (Display 2) (bug 92289 appears) Display 1 (bug 92289 appears) Display 2 (external) (bug 92289 appears) All displays (Bug 92289 disappears) Bug 92289 was *not* able to get bug to disappear: 1) 64bit Windows 8.1 2) 64bit LO Version: 5.1.0.0.alpha1+ (x64) Build ID: 6f928deb55b5bcff3e8d11a5ace017732176e86a TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-08_21:55:21 3) Single monitor 4) Slide Show → Slide Show Settings… → (Multiple Displays) Presentation display: not selectable (bug 92289 appears) Bug 92289 *mostly* appears: 1) 64bit Windows 8.1 2) 32bit LO Version: 5.1.0.0.alpha1+ Build ID: 122a15f4a6c09d35db58fe3a7b943b5ea79cbe65 TinderBox: Win-x86@39, Branch:master, Time: 2015-07-09_23:27:20 3) Multiple (2) monitors 4) Slide Show → Slide Show Settings… → (Multiple Displays) Presentation display: Auto External (Display 2) (bug 92289 appears) Display 1 (bug 92289 appears) Display 2 (external) (bug 92289 appears) All displays (Bug 92289 disappears) Bug 92289 disappears: 1) 64bit Windows 8.1 2) 32bit LO Version: 5.1.0.0.alpha1+ Build ID: 122a15f4a6c09d35db58fe3a7b943b5ea79cbe65 TinderBox: Win-x86@39, Branch:master, Time: 2015-07-09_23:27:20 3) Single monitor 4) Slide Show → Slide Show Settings… → (Multiple Displays) Presentation display: not selectable (bug 92289 disappears) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Whiteboard|easyHack skillCpp |easyHack skillCpp |difficultyInteresting |difficultyBeginner topicUI |topicUI | --- Comment #18 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- So, on Windows we need to check the registry for HKEY_CURRENT_USER\Control Panel\Accessibility\Keyboard Preference If the string value On = 1, mnemonics should always be shown. Else they should only be shown when the alt key is pressed. Someone with a Windows build might do this as EasyHack. This is the place where it should be enabled/disabled: http://opengrok.libreoffice.org/xref/core/vcl/win/source/gdi/salnativewidgets-luna.cxx#193 Look here for how to enable/disable mnemonics: http://opengrok.libreoffice.org/xref/core/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx#569 And check this for how to query the Windows registry: http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox.cxx#5649 Should be straight-forward. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 54169] LibO doesn’t obey OS setting “only show the accelerator underline when the Alt key is being pressed”
https://bugs.documentfoundation.org/show_bug.cgi?id=54169 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Whiteboard|easyHack skillCpp |easyHack skillCpp |difficultyInteresting |difficultyBeginner topicUI |topicUI | --- Comment #18 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- So, on Windows we need to check the registry for HKEY_CURRENT_USER\Control Panel\Accessibility\Keyboard Preference If the string value On = 1, mnemonics should always be shown. Else they should only be shown when the alt key is pressed. Someone with a Windows build might do this as EasyHack. This is the place where it should be enabled/disabled: http://opengrok.libreoffice.org/xref/core/vcl/win/source/gdi/salnativewidgets-luna.cxx#193 Look here for how to enable/disable mnemonics: http://opengrok.libreoffice.org/xref/core/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx#569 And check this for how to query the Windows registry: http://opengrok.libreoffice.org/xref/core/vcl/source/window/toolbox.cxx#5649 Should be straight-forward. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/uiconfig
sd/uiconfig/sdraw/toolbar/standardbar.xml |6 -- sd/uiconfig/sdraw/toolbar/toolbar.xml | 19 ++- 2 files changed, 14 insertions(+), 11 deletions(-) New commits: commit 5be82d9765e5fc9bf072f588d02ffa4994ac0312 Author: Yousuf Philips philip...@hotmail.com Date: Thu Jul 9 04:37:30 2015 +0400 tdf#84909 Draw: Drawing toolbar exclusive to shapes Change-Id: I0ac457840a1d9df6d075bdd4e8205c19c5055204 Reviewed-on: https://gerrit.libreoffice.org/16875 Reviewed-by: Yousuf Philips philip...@hotmail.com Tested-by: Yousuf Philips philip...@hotmail.com (cherry picked from commit 240d6c9fb84be66500136e3a2fb8e1ff309d2a54) Reviewed-on: https://gerrit.libreoffice.org/16876 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Jan Holesovsky ke...@collabora.com diff --git a/sd/uiconfig/sdraw/toolbar/standardbar.xml b/sd/uiconfig/sdraw/toolbar/standardbar.xml index 5a6de30..5dcb170 100644 --- a/sd/uiconfig/sdraw/toolbar/standardbar.xml +++ b/sd/uiconfig/sdraw/toolbar/standardbar.xml @@ -49,10 +49,12 @@ toolbar:toolbaritem xlink:href=.uno:GridVisible/ toolbar:toolbaritem xlink:href=.uno:HelplinesMove/ toolbar:toolbarseparator/ - toolbar:toolbaritem xlink:href=.uno:InsertGraphic toolbar:visible=false/ - toolbar:toolbaritem xlink:href=.uno:FontworkGalleryFloater toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:InsertTable toolbar:visible=false/ + toolbar:toolbaritem xlink:href=.uno:InsertGraphic/ toolbar:toolbaritem xlink:href=.uno:InsertObjectChart toolbar:helpid=10140 toolbar:visible=false/ + toolbar:toolbaritem xlink:href=.uno:Text toolbar:style=radio/ + toolbar:toolbaritem xlink:href=.uno:VerticalText toolbar:style=radio/ + toolbar:toolbaritem xlink:href=.uno:FontworkGalleryFloater/ toolbar:toolbaritem xlink:href=.uno:HyperlinkDialog toolbar:helpid=5678 toolbar:visible=false/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:AdvancedMode toolbar:style=radio dropdown/ diff --git a/sd/uiconfig/sdraw/toolbar/toolbar.xml b/sd/uiconfig/sdraw/toolbar/toolbar.xml index ee1ef3d..79c1c7d 100644 --- a/sd/uiconfig/sdraw/toolbar/toolbar.xml +++ b/sd/uiconfig/sdraw/toolbar/toolbar.xml @@ -18,32 +18,33 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . -- toolbar:toolbar xmlns:toolbar=http://openoffice.org/2001/toolbar; xmlns:xlink=http://www.w3.org/1999/xlink; toolbar:id=toolbar - toolbar:toolbaritem xlink:href=.uno:SelectObject toolbar:style=radio toolbar:visible=false/ + toolbar:toolbaritem xlink:href=.uno:SelectObject toolbar:style=radio/ toolbar:toolbaritem xlink:href=.uno:ZoomMode/ toolbar:toolbaritem xlink:href=.uno:ZoomObjects toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:ZoomToolBox toolbar:visible=false/ toolbar:toolbarseparator/ - toolbar:toolbaritem xlink:href=.uno:Text toolbar:style=radio/ - toolbar:toolbaritem xlink:href=.uno:VerticalText toolbar:style=radio/ - toolbar:toolbaritem xlink:href=.uno:InsertGraphic/ + toolbar:toolbaritem xlink:href=.uno:Text toolbar:style=radio toolbar:visible=false/ + toolbar:toolbaritem xlink:href=.uno:VerticalText toolbar:style=radio toolbar:visible=false/ + toolbar:toolbaritem xlink:href=.uno:InsertGraphic toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:InsertToolbox toolbar:style=radio dropdown toolbar:visible=false/ - toolbar:toolbaritem xlink:href=.uno:FontworkGalleryFloater/ + toolbar:toolbaritem xlink:href=.uno:FontworkGalleryFloater toolbar:visible=false/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:XLineColor/ toolbar:toolbaritem xlink:href=.uno:FillColor/ toolbar:toolbaritem xlink:href=.uno:FillStyle toolbar:visible=false/ toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:Line toolbar:style=radio/ - toolbar:toolbaritem xlink:href=.uno:ArrowsToolbox toolbar:style=radio dropdown/ toolbar:toolbaritem xlink:href=.uno:Freeline_Unfilled toolbar:style=radio toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:Bezier_Unfilled toolbar:style=radio toolbar:visible=false/ - toolbar:toolbaritem xlink:href=.uno:LineToolbox toolbar:style=radio dropdown/ - toolbar:toolbaritem xlink:href=.uno:ConnectorToolbox toolbar:style=radio dropdown/ - toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:BasicShapes.rectangle toolbar:style=radio/ toolbar:toolbaritem xlink:href=.uno:Rect toolbar:helpid=10104 toolbar:visible=false/ toolbar:toolbaritem xlink:href=.uno:BasicShapes.ellipse toolbar:style=radio/ toolbar:toolbaritem xlink:href=.uno:Ellipse toolbar:helpid=10110 toolbar:visible=false/ + toolbar:toolbarseparator/ + toolbar:toolbaritem xlink:href=.uno:ArrowsToolbox toolbar:style=radio dropdown/ + toolbar:toolbaritem xlink:href=.uno:LineToolbox toolbar:style=radio dropdown/ + toolbar:toolbaritem xlink:href=.uno:ConnectorToolbox toolbar:style=radio dropdown/ + toolbar:toolbarseparator/ toolbar:toolbaritem xlink:href=.uno:BasicShapes toolbar:style=radio
[Libreoffice-bugs] [Bug 84909] Meta: Enhancing Impress/Draw toolbars and context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=84909 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|target:4.5.0 target:4.4.0.2 |target:4.5.0 target:4.4.0.2 |target:5.1.0 target:5.0.0.2 |target:5.1.0 target:5.0.0.2 |target:5.0.0.3 |target:5.0.0.3 target:5.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 84909] Meta: Enhancing Impress/Draw toolbars and context menu
https://bugs.documentfoundation.org/show_bug.cgi?id=84909 --- Comment #26 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Yousuf Philips committed a patch related to this issue. It has been pushed to libreoffice-5-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5be82d9765e5fc9bf072f588d02ffa4994ac0312h=libreoffice-5-0 tdf#84909 Draw: Drawing toolbar exclusive to shapes It will be available in 5.0.1. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: i18npool/source
i18npool/source/localedata/localedata.cxx | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
New commits:
commit adced867c695d621fae582b36ee0b2bdfe3b8e15
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jul 10 12:10:38 2015 +0200
-fsanitize=function
...similar to 22935ed0a47bfc143303a8084cefd35eae94e6a9 -fsanitize=function
Change-Id: I9000389d648ef918d9639a9d8ca99d82f3684445
diff --git a/i18npool/source/localedata/localedata.cxx
b/i18npool/source/localedata/localedata.cxx
index 19b302a..f831309 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -35,7 +35,7 @@ using namespace com::sun::star::lang;
using namespace com::sun::star;
typedef sal_Unicode** (SAL_CALL * MyFunc_Type)( sal_Int16);
-typedef sal_Unicode*** (SAL_CALL * MyFunc_Type2)( sal_Int16, sal_Int16 );
+typedef sal_Unicode const *** (SAL_CALL * MyFunc_Type2)( sal_Int16,
sal_Int16 );
typedef sal_Unicode const (SAL_CALL * MyFunc_Type3)( sal_Int16,
sal_Int16, sal_Int16 );
typedef sal_Unicode const * const * (SAL_CALL * MyFunc_FormatCode)(
sal_Int16, sal_Unicode const *, sal_Unicode const * );
@@ -1268,7 +1268,7 @@ LocaleDataImpl::getContinuousNumberingLevels( const
lang::Locale rLocale ) thro
// invoke function
sal_Int16 nStyles;
sal_Int16 nAttributes;
-sal_Unicode*** p0 = func( nStyles, nAttributes );
+sal_Unicode const *** p0 = func( nStyles, nAttributes );
// allocate memory for nAttributes attributes for each of the nStyles
styles.
Sequence Sequencebeans::PropertyValue pv( nStyles );
@@ -1276,11 +1276,11 @@ LocaleDataImpl::getContinuousNumberingLevels( const
lang::Locale rLocale ) thro
pv[i] = Sequencebeans::PropertyValue( nAttributes );
}
-sal_Unicode*** pStyle = p0;
+sal_Unicode const *** pStyle = p0;
for( i=0; inStyles; i++ ) {
-sal_Unicode** pAttribute = pStyle[i];
+sal_Unicode const ** pAttribute = pStyle[i];
for( int j=0; jnAttributes; j++ ) { // prefix, numberingtype,
...
-sal_Unicode* pString = pAttribute[j];
+sal_Unicode const * pString = pAttribute[j];
beans::PropertyValue rVal = pv[i][j];
OUString sVal;
if( pString ) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] SI-GUI Java help needed (please run a jar file and post the output)
Hi Pedro, Did you start it via the command line? (Something like hold control and right click - open command line. There input java -jar siguitest2.jar and a single line of text will be omitted to the command line. You won't see anything by double-clicking, but that is meant to be so at this stage :) ) Am 10. Juli 2015 12:21:00 MESZ, schrieb Pedro pedl...@gmail.com: Hi Florian Florian Reisinger wrote The promised new jar (which got incredibly huge :O) http://florei-libo.115.at/rssft/siguitest2.jar [2,3 MB] These are the current dependencies of Java Si-GUI as sad as it may be ^^ Contains Guava and JShortcut (which are not needed for that, but anyway :) ) Please report anything unexpected. keep in mind Java 7 is not intended to be supported :) Is this supposed to work under Windows XP x86? Executing the jar file on a PC running Java build 1.8.0_45-b14 doesn't do anything. There is no window, no dialog, no error, nothing. Am I missing something? Cheers, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-SI-GUI-Java-help-needed-please-run-a-jar-file-and-post-the-output-tp4153946p4154116.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 92673] NEW TABLE FUNCTION: Split table Merge table
https://bugs.documentfoundation.org/show_bug.cgi?id=92673 --- Comment #1 from Sion sebbes...@gmail.com --- I found the Split table function in the right click menu, but could you please add it as an icon too in the toolbar for tables, thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 --- Comment #9 from DavidO d.ostrov...@gmx.de --- As pointed out in :[1], JRE installation actually provides the needed dll. It's only place in $JAVA_HOME/bin and thus is not found by the LO process. There are also number of workarounds provided in this article. Currently, i Don't understand as for how/why this problem doesn't show up on 32bit build. Who tested it, that vanilla LO 32bit installation works on vanilla Windows 10 with only two packages installed: LO 32bit + JRE 32bit? https://www.duckware.com/tech/java6msvcr71.html -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 --- Comment #5 from Maxim Monastirsky momonas...@gmail.com --- (In reply to Stephan Bergmann from comment #4) I do not find the (case-insensitive) string getimplementationname in any of the zipped files in http://extensions.libreoffice.org/extension-center/template-changer/ releases/1.2.6/template-changer-1.2.6? It has this code inside TemplateChanger.xba: If oDoc.ImplementationName SwXTextDocument Then assignTemplateToDoc = ERR_DOC_NOT_WRITER Exit Function EndIf -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92673] New: NEW TABLE FUNCTION: Split table Merge table
https://bugs.documentfoundation.org/show_bug.cgi?id=92673 Bug ID: 92673 Summary: NEW TABLE FUNCTION: Split table Merge table Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sebbes...@gmail.com Currently you can ad/delete a row/column and you can split/merge a cell. The new feature is: Split table (and Merge table). You select a row or column in the table, and click Split table and it cuts the table into 2 separate tables. Why is this useful? * if you happens to delete that last line break between 2 tables (depending on settings, i think) they will merge into one, and it is very hard (if not impossible) to separate the tables again, this feature will solve that * If you suddenly realize that the current table would work better if it was split into 2 (or more) tables it would often require that you make an entirely new table and manually move the data, with this feature you only need to cut the table where it suits best. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] SI-GUI Java help needed (please run a jar file and post the output)
Hi Florian Florian Reisinger wrote The promised new jar (which got incredibly huge :O) http://florei-libo.115.at/rssft/siguitest2.jar [2,3 MB] These are the current dependencies of Java Si-GUI as sad as it may be ^^ Contains Guava and JShortcut (which are not needed for that, but anyway :) ) Please report anything unexpected. keep in mind Java 7 is not intended to be supported :) Is this supposed to work under Windows XP x86? Executing the jar file on a PC running Java build 1.8.0_45-b14 doesn't do anything. There is no window, no dialog, no error, nothing. Am I missing something? Cheers, Pedro -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-SI-GUI-Java-help-needed-please-run-a-jar-file-and-post-the-output-tp4153946p4154116.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/wmf/winwmf.cxx | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
New commits:
commit 7eef63bb2a4d14cb35201f84f38855910f468e20
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 10 11:34:03 2015 +0100
fix potential hang here
Change-Id: Id62cdb90420b9ccf4e98fc1af46c70db6ed60ee0
diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx
index 7b87f68..52f228e 100644
--- a/vcl/source/filter/wmf/winwmf.cxx
+++ b/vcl/source/filter/wmf/winwmf.cxx
@@ -1735,14 +1735,19 @@ bool WMFReader::GetPlaceableBound( Rectangle
rPlaceableBound, SvStream* pStm )
}
break;
}
-nPos += nRSize * 2;
- if ( nPos = nEnd )
- pStm-Seek( nPos );
- else
- {
- pStm-SetError( SVSTREAM_FILEFORMAT_ERROR );
- bRet = false;
- }
+
+const sal_uInt32 nAvailableBytes = nEnd - nPos;
+const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2;
+if (nRSize = nMaxPossibleRecordSize)
+{
+nPos += nRSize * 2;
+pStm-Seek( nPos );
+}
+else
+{
+pStm-SetError( SVSTREAM_FILEFORMAT_ERROR );
+bRet = false;
+}
}
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 4 commits - include/svtools svtools/source
include/svtools/RemoteFilesDialog.hxx|2
svtools/source/dialogs/RemoteFilesDialog.cxx | 52 +++
svtools/source/dialogs/ServerDetailsControls.cxx |4 -
3 files changed, 46 insertions(+), 12 deletions(-)
New commits:
commit dd4b9e587debaf92e2681590405b6dacc8bddb49
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 10 12:58:58 2015 +0200
Add prefix to the name after editing service
Change-Id: Icca2436e5a3782829971bf9e672bbddab81cc97f
diff --git a/svtools/source/dialogs/RemoteFilesDialog.cxx
b/svtools/source/dialogs/RemoteFilesDialog.cxx
index d27fccc..4d5c619 100644
--- a/svtools/source/dialogs/RemoteFilesDialog.cxx
+++ b/svtools/source/dialogs/RemoteFilesDialog.cxx
@@ -643,7 +643,13 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
m_aServices[nPos] = pEditedService;
m_pServices_lb-RemoveEntry( nSelected );
-m_pServices_lb-InsertEntry( pEditedService-GetName(),
nSelected );
+
+OUString sPrefix = lcl_GetServiceType( pEditedService );
+
+if(!sPrefix.isEmpty())
+sPrefix += : ;
+
+m_pServices_lb-InsertEntry( sPrefix +
pEditedService-GetName(), nSelected );
m_pServices_lb-SelectEntryPos( nSelected );
m_bIsUpdated = true;
commit 946079092cf79e49e8d6fd07fe37fb993cbf4464
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 10 12:46:58 2015 +0200
PlaceEditDialog: Remember the repository id if wasn't changed
Change-Id: Ib5e63bec0b6b3c2d7d0dc2c114656737979ef6d0
diff --git a/svtools/source/dialogs/ServerDetailsControls.cxx
b/svtools/source/dialogs/ServerDetailsControls.cxx
index 3fc26c4..46b5b05 100644
--- a/svtools/source/dialogs/ServerDetailsControls.cxx
+++ b/svtools/source/dialogs/ServerDetailsControls.cxx
@@ -329,12 +329,10 @@ bool CmisDetailsContainer::setUrl( const INetURLObject
rUrl )
if ( bSuccess )
{
-OUString sRepositoryId;
-
OUString sDecodedHost = rUrl.GetHost(
INetURLObject::DECODE_WITH_CHARSET );
INetURLObject aHostUrl( sDecodedHost );
m_sBinding = aHostUrl.GetURLNoMark( );
-sRepositoryId = aHostUrl.GetMark( );
+m_sRepoId = aHostUrl.GetMark( );
m_pEDBinding-SetText( m_sBinding );
m_pEDRoot-SetText( rUrl.GetURLPath() );
commit e19670f542a85d4815be03c428eb835935747d20
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 10 11:52:17 2015 +0200
RemoteFilesDialog: safe doubleclick on file view
Change-Id: I651c8274dfb2776e63c32f0b45d9daf57e5970c6
diff --git a/svtools/source/dialogs/RemoteFilesDialog.cxx
b/svtools/source/dialogs/RemoteFilesDialog.cxx
index 869fcdf..d27fccc 100644
--- a/svtools/source/dialogs/RemoteFilesDialog.cxx
+++ b/svtools/source/dialogs/RemoteFilesDialog.cxx
@@ -687,17 +687,24 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
IMPL_LINK_NOARG ( RemoteFilesDialog, DoubleClickHdl )
{
SvTreeListEntry* pEntry = m_pFileView-FirstSelected();
-SvtContentEntry* pData = static_cast SvtContentEntry* (
pEntry-GetUserData() );
-if( pData-mbIsFolder )
+if( pEntry )
{
-OUString sURL = m_pFileView-GetCurrentURL();
+SvtContentEntry* pData = static_cast SvtContentEntry* (
pEntry-GetUserData() );
-OpenURL( sURL );
-}
-else
-{
-EndDialog( RET_OK );
+if( pData )
+{
+if( pData-mbIsFolder )
+{
+OUString sURL = m_pFileView-GetCurrentURL();
+
+OpenURL( sURL );
+}
+else
+{
+EndDialog( RET_OK );
+}
+}
}
return 1;
commit d2120955b794b06c006838979059941aa53cc4d3
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 10 11:33:23 2015 +0200
RemoteFilesDialog: auto file extension in the save mode
Change-Id: I7b1dd5cc330de0c1ad713d68d93e7d12375033c6
diff --git a/include/svtools/RemoteFilesDialog.hxx
b/include/svtools/RemoteFilesDialog.hxx
index 44fce0c..f1dc755 100644
--- a/include/svtools/RemoteFilesDialog.hxx
+++ b/include/svtools/RemoteFilesDialog.hxx
@@ -153,6 +153,8 @@ private:
FileViewResult OpenURL( OUString sURL );
+void AddFileExtension();
+
void EnableControls();
DECL_LINK ( AddServiceHdl, void * );
diff --git a/svtools/source/dialogs/RemoteFilesDialog.cxx
b/svtools/source/dialogs/RemoteFilesDialog.cxx
index 03fa023..869fcdf 100644
--- a/svtools/source/dialogs/RemoteFilesDialog.cxx
+++ b/svtools/source/dialogs/RemoteFilesDialog.cxx
@@ -517,6 +517,23 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString sURL )
return eResult;
}
+void RemoteFilesDialog::AddFileExtension()
+{
+if( m_nCurrentFilter != LISTBOX_ENTRY_NOTFOUND )
+{
+OUString sExt =
[Libreoffice-commits] core.git: include/svl svl/source
include/svl/zformat.hxx |6 ++
svl/source/numbers/zforfind.cxx | 21 +++--
svl/source/numbers/zforlist.cxx |6 +-
svl/source/numbers/zformat.cxx | 16
svl/source/numbers/zforscan.hxx |3 +++
5 files changed, 49 insertions(+), 3 deletions(-)
New commits:
commit f7f4d985ad44ba0c644b2be02d09002b13d749f7
Author: Eike Rathke er...@redhat.com
Date: Fri Jul 10 15:07:59 2015 +0200
Resolves: tdf#92457 handle trailing text subformat if others omitted
Change-Id: I597a5019540cef4700355df4d170c103e973797e
diff --git a/include/svl/zformat.hxx b/include/svl/zformat.hxx
index 21c106c..2858563 100644
--- a/include/svl/zformat.hxx
+++ b/include/svl/zformat.hxx
@@ -277,6 +277,12 @@ public:
return false;
}
+/** Get the scanned type of the specified subformat. */
+short GetNumForInfoScannedType( sal_uInt16 nNumFor ) const
+{
+return (nNumFor 4) ? NumFor[nNumFor].Info().eScannedType :
css::util::NumberFormat::UNDEFINED;
+}
+
// Whether the second subformat code is really for negative numbers
// or another limit set.
bool IsSecondSubformatRealNegative() const
diff --git a/svl/source/numbers/zforfind.cxx b/svl/source/numbers/zforfind.cxx
index f0b08b5..77832ea 100644
--- a/svl/source/numbers/zforfind.cxx
+++ b/svl/source/numbers/zforfind.cxx
@@ -3222,7 +3222,16 @@ bool ImpSvNumberInputScan::IsNumberFormatMain( const
OUString rString,/
}
if ( nMatchedAllStrings )
{
-eScannedType = eSetType;
+// A type DEFINED means that no category could be assigned to the
+// overall format because of mixed type subformats. Use the scan
+// matched subformat's type if any.
+short eForType = eSetType;
+if ((eForType == css::util::NumberFormat::UNDEFINED || eForType ==
css::util::NumberFormat::DEFINED) pFormat)
+eForType = pFormat-GetNumForInfoScannedType(
nStringScanNumFor);
+if (eForType != css::util::NumberFormat::UNDEFINED eForType !=
css::util::NumberFormat::DEFINED)
+eScannedType = eForType;
+else
+eScannedType = css::util::NumberFormat::NUMBER;
}
else if ( bDidMatch )
{
@@ -3250,7 +3259,15 @@ bool ImpSvNumberInputScan::IsNumberFormatMain( const
OUString rString,/
}
if ( nMatchedAllStrings )
{
-eScannedType = eSetType;
+// A type DEFINED means that no category could be assigned to the
+// overall format because of mixed type subformats. Do not override
+// the scanned type in this case. Otherwise in IsNumberFormat() the
+// first numeric particle would be accepted as number.
+short eForType = eSetType;
+if ((eForType == css::util::NumberFormat::UNDEFINED || eForType ==
css::util::NumberFormat::DEFINED) pFormat)
+eForType = pFormat-GetNumForInfoScannedType(
nStringScanNumFor);
+if (eForType != css::util::NumberFormat::UNDEFINED eForType !=
css::util::NumberFormat::DEFINED)
+eScannedType = eForType;
}
else if ( bWasReturn )
{
diff --git a/svl/source/numbers/zforlist.cxx b/svl/source/numbers/zforlist.cxx
index 19c5d95..afca600 100644
--- a/svl/source/numbers/zforlist.cxx
+++ b/svl/source/numbers/zforlist.cxx
@@ -1322,7 +1322,11 @@ void SvNumberFormatter::GetInputLineString(const double
fOutNumber,
short eType = pFormat-GetType() ~css::util::NumberFormat::DEFINED;
if (eType == 0)
{
-eType = css::util::NumberFormat::DEFINED;
+// Mixed types in subformats, use first.
+/* XXX we could choose a subformat according to fOutNumber and
+ * subformat conditions, but they may exist to suppress 0 or negative
+ * numbers so wouldn't be a safe bet. */
+eType = pFormat-GetNumForInfoScannedType(0);
}
sal_uInt16 nOldPrec = pFormatScanner-GetStandardPrec();
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index ec65c7c..e7501ff 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -943,6 +943,22 @@ SvNumberformat::SvNumberformat(OUString rString,
sBuff.insert(nPos, ;);
nPos++;
}
+else
+{
+// The last subformat. If it is a trailing text
+// format the omitted subformats act like they were
+// not specified and inherited the first format,
+// e.g. 0;@ behaves like 0;-0;0;@
+if (pSc-GetScannedType() ==
css::util::NumberFormat::TEXT)
+{
+// Reset conditions,
[Libreoffice-bugs] [Bug 92457] Subformat ; @ changes date input to number
https://bugs.documentfoundation.org/show_bug.cgi?id=92457 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | --- Comment #4 from Eike Rathke er...@redhat.com --- Actually Excel treats this special case different, a trailing ;@ text format acts as if it was entered as the 4th subformat and the 2nd and 3rd subformats inherit from the 1st, so 0;@ acts like 0;-0;0;@ In case of a date format of course not with a negative date.. I'll try to come up with a solution. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92671] New: GTK+3: Tooltips drawn on secondary screen
https://bugs.documentfoundation.org/show_bug.cgi?id=92671 Bug ID: 92671 Summary: GTK+3: Tooltips drawn on secondary screen Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jaragu...@igalia.com CC: caol...@redhat.com Created attachment 117169 -- https://bugs.documentfoundation.org/attachment.cgi?id=117169action=edit Screenshot showing the problem. When the desktop is configured in dual screen mode, the tooltips seem to get attached to the secondary screen. * If LibreOffice window is on the secondary screen: tooltips appear in the correct position. * If LibreOffice window is on the primary screen: tooltips appear in the secondary screen, in the correct Y position. See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/source
vcl/inc/outdev.h |5 ++---
vcl/source/font/PhysicalFontCollection.cxx |2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
New commits:
commit ac46405ca62fcc7d7a7e8004c0c44b330956e39c
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jul 10 12:44:11 2015 +0200
-Werror,-Wunused-private-field
Change-Id: Ie3feae1a6bac2e5a51d38fb402525097483313e2
diff --git a/vcl/inc/outdev.h b/vcl/inc/outdev.h
index 256e19e..a4cc54f 100644
--- a/vcl/inc/outdev.h
+++ b/vcl/inc/outdev.h
@@ -55,12 +55,11 @@ public:
class ImplGetDevSizeList
{
private:
-OUStringmaFontName;
std::vectorintmaSizeList;
public:
-ImplGetDevSizeList( const OUString rFontName )
-: maFontName( rFontName ) { maSizeList.reserve( 32 ); }
+ImplGetDevSizeList()
+{ maSizeList.reserve( 32 ); }
voidAdd( int nHeight ) { maSizeList.push_back(
nHeight ); }
int Count() const { return maSizeList.size(); }
int Get( int nIndex ) const { return maSizeList[ nIndex ];
}
diff --git a/vcl/source/font/PhysicalFontCollection.cxx
b/vcl/source/font/PhysicalFontCollection.cxx
index 942e508..dc4c185 100644
--- a/vcl/source/font/PhysicalFontCollection.cxx
+++ b/vcl/source/font/PhysicalFontCollection.cxx
@@ -983,7 +983,7 @@ ImplGetDevFontList*
PhysicalFontCollection::GetDevFontList() const
ImplGetDevSizeList* PhysicalFontCollection::GetDevSizeList( const OUString
rFontName ) const
{
-ImplGetDevSizeList* pGetDevSizeList = new ImplGetDevSizeList( rFontName );
+ImplGetDevSizeList* pGetDevSizeList = new ImplGetDevSizeList;
PhysicalFontFamily* pFontFamily = FindFontFamily( rFontName );
if( pFontFamily != NULL )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [GSoC] Improve user experience with CMIS – Weekly report #6
Hi Szymon, Szymon Kłos píše v Pá 03. 07. 2015 v 20:00 +0200: To do: * async operations * implement support of context bits * open/save remote buttons on toolbars Thanks so much for your great work! I wonder - you still work in the branch; how would you feel about integrating it now to master, and continue in a rebased branch? I fear there will be many conflicts to sort out, the development is rapid as always :-) - so the later we do that, the harder it is. All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/uiwriter/uiwriter.cxx | 89 +
1 file changed, 89 insertions(+)
New commits:
commit 6a0efa9873b1a5cae4ae0719a7ae1eee97838168
Author: Varun varun.dh...@studentpartner.com
Date: Thu Jul 9 23:33:24 2015 +0530
Added Test for tdf#80663 table row/column delete undo crash
Change-Id: Ica62926486831f126cce54d651e230cee3360074
Reviewed-on: https://gerrit.libreoffice.org/16901
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/sw/qa/extras/uiwriter/uiwriter.cxx
b/sw/qa/extras/uiwriter/uiwriter.cxx
index 0bf5636..92300c8 100644
--- a/sw/qa/extras/uiwriter/uiwriter.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter.cxx
@@ -110,6 +110,7 @@ public:
void testTdf69282();
void testTdf69282WithMirror();
void testSearchWithTransliterate();
+void testTdf80663();
void testTdf90808();
void testTdf75137();
void testTdf83798();
@@ -164,6 +165,7 @@ public:
CPPUNIT_TEST(testTdf69282);
CPPUNIT_TEST(testTdf69282WithMirror);
CPPUNIT_TEST(testSearchWithTransliterate);
+CPPUNIT_TEST(testTdf80663);
CPPUNIT_TEST(testTdf90808);
CPPUNIT_TEST(testTdf75137);
CPPUNIT_TEST(testTdf83798);
@@ -1259,6 +1261,93 @@ void SwUiWriterTest::testSearchWithTransliterate()
CPPUNIT_ASSERT_EQUAL(1,(int)case2);
}
+void SwUiWriterTest::testTdf80663()
+{
+SwDoc* pDoc = createDoc();
+SwWrtShell* pWrtShell = pDoc-GetDocShell()-GetWrtShell();
+//Inserting 2x2 Table
+sw::UndoManager rUndoManager = pDoc-GetUndoManager();
+SwInsertTableOptions TableOpt(tabopts::DEFAULT_BORDER, 0);
+pWrtShell-InsertTable(TableOpt, 2, 2);
+//Checking for the number of rows and columns
+uno::Referencetext::XTextTable xTable(getParagraphOrTable(1),
uno::UNO_QUERY);
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Deleting the first row
+pWrtShell-SttDoc(); //moves the cursor to the start of Doc
+pWrtShell-SelTableRow(); //selects the first row
+pWrtShell-DeleteRow();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Redo changes
+rUndoManager.Redo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Deleting the second row
+pWrtShell-GoNextCell(); //moves the cursor to next cell
+pWrtShell-SelTableRow(); //selects the second row
+pWrtShell-DeleteRow();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Redo changes
+rUndoManager.Redo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Deleting the first column
+pWrtShell-SttDoc(); //moves the cursor to the start of Doc
+pWrtShell-SelTableCol(); //selects first column
+pWrtShell-DeleteCol();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Redo changes
+rUndoManager.Redo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1), xTable-getColumns()-getCount());
+//Undo changes
+rUndoManager.Undo();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getColumns()-getCount());
+//Deleting the second column
+pWrtShell-SttDoc(); //moves the cursor to the start of Doc
+pWrtShell-GoNextCell(); //moves the cursor to next cell
+pWrtShell-SelTableCol(); //selects second column
+pWrtShell-DeleteCol();
+CPPUNIT_ASSERT_EQUAL(sal_Int32(2), xTable-getRows()-getCount());
+CPPUNIT_ASSERT_EQUAL(sal_Int32(1),
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
New commits:
commit 12d1a2a08a8056df2c14ad3e75b309847989bc23
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 10 13:50:16 2015 +0200
tdf#92670 GtkSalGraphics::NWPaintGTKMenubar: fix modified clip rectangle
Happens only with when double buffering is enabled, and e.g. with the
oxygen GTK2 theme, but not with the default one.
Change-Id: Iad9911121e57388c84c25860413763f75e06b0ea
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index 77cac74..c57c27d 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -3184,6 +3184,15 @@ bool GtkSalGraphics::NWPaintGTKToolbar(
return true;
}
+/// Converts a VCL Rectangle to a GdkRectangle.
+static void lcl_rectangleToGdkRectangle(const Rectangle rRectangle,
GdkRectangle rGdkRectangle)
+{
+rGdkRectangle.x = rRectangle.Left();
+rGdkRectangle.y = rRectangle.Top();
+rGdkRectangle.width = rRectangle.GetWidth();
+rGdkRectangle.height = rRectangle.GetHeight();
+}
+
bool GtkSalGraphics::NWPaintGTKMenubar(
GdkDrawable* gdkDrawable,
ControlType, ControlPart nPart,
@@ -3218,10 +3227,7 @@ bool GtkSalGraphics::NWPaintGTKMenubar(
for( clipList::const_iterator it = rClipList.begin(); it !=
rClipList.end(); ++it )
{
-clipRect.x = it-Left();
-clipRect.y = it-Top();
-clipRect.width = it-GetWidth();
-clipRect.height = it-GetHeight();
+lcl_rectangleToGdkRectangle(*it, clipRect);
// handle Menubar
if( nPart == PART_ENTIRE_CONTROL )
@@ -3241,6 +3247,10 @@ bool GtkSalGraphics::NWPaintGTKMenubar(
GTK_WIDGET(m_pWindow),
base,
x, y, w, h );
+
+// Do the conversion again, in case clipRect has been modified.
+lcl_rectangleToGdkRectangle(*it, clipRect);
+
gtk_paint_box( gWidgetData[m_nXScreen].gMenubarWidget-style,
gdkDrawable,
stateType,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 86221] Bug in libreoffice writer if I use Swedish language settings.
https://bugs.documentfoundation.org/show_bug.cgi?id=86221 --- Comment #31 from Niklas Johansson sleeping.pil...@gmail.com --- Good to hear that it worked out. I installed the debug symbols and did a back-trace from the crash. At a glance it looks to me that the crash is in a call to the spell-checker. I suppose part of the problem comes down to, the Swedish dictionary is constructed to be a good spell-checker but has not been prepared for morphological analyses which is what the thesaurus part is trying to do. And nowdays the thesaurus is in the context menu and thus it is called when one right click. I doubt I will have any time to dig into this in the near future but if someone has any idea what might be done to avoid this crash and want me to check something let me know. Below is the back-trace from the crash: Program received signal SIGSEGV, Segmentation fault. 0xabd590fa in AffixMgr::suffix_check(char const*, int, int, PfxEntry*, char**, int, int*, unsigned short, unsigned short, char) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 (gdb) bt #0 0xabd590fa in AffixMgr::suffix_check(char const*, int, int, PfxEntry*, char**, int, int*, unsigned short, unsigned short, char) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #1 0xabd5e028 in AffixMgr::compound_check_morph(char const*, int, short, short, short, short, hentry**, char, char**, char*) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #2 0xabd73000 in SuggestMgr::suggest_morph(char const*) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #3 0xabd6c919 in ?? () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #4 0xabd6d06e in Hunspell::stem(char***, char const*) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #5 0xabd6d9e0 in Hunspell::spellml(char***, char const*) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #6 0xabd6deaf in Hunspell::suggest(char***, char const*) () from /usr/lib/i386-linux-gnu/libhunspell-1.3.so.0 #7 0xad01fd84 in SpellChecker::GetProposals (this=this@entry=0x8f87cb8, rWord=..., rLocale=...) at /build/buildd/libreoffice-4.4.3~rc2/lingucomponent/source/spellcheck/spell/sspellimp.cxx:457 #8 0xad020398 in SpellChecker::spell (this=0x8f87cb8, rWord=..., rLocale=..., rProperties=...) at /build/buildd/libreoffice-4.4.3~rc2/lingucomponent/source/spellcheck/spell/sspellimp.cxx:499 ---Type return to continue, or q return to quit--- -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92681] New: Menu list doesn't always close
https://bugs.documentfoundation.org/show_bug.cgi?id=92681 Bug ID: 92681 Summary: Menu list doesn't always close Product: LibreOffice Version: 4.4.2.2 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sworddrag...@aol.com If I'm starting Writer and going fast to the menu bar - Insert - Fields - More Fields... the menu list from Insert doesn't close then. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 Christian Lohmaier cl...@documentfoundation.org changed: What|Removed |Added URL||https://gerrit.libreoffice. ||org/#/c/16938/ --- Comment #10 from Christian Lohmaier cl...@documentfoundation.org --- submitted https://gerrit.libreoffice.org/#/c/16938/ for review. ptrdiff_t on win64bit is __int64 - as the difference of the smaller types (sections-PointerToRawData - sections-VirtualAddress) is negative, the result is an overflow (or whatever the correct term is). And with that of course it won't read the proper libs from the jvm.dll. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92680] New: Problem with keeeping of content of footnoter
https://bugs.documentfoundation.org/show_bug.cgi?id=92680 Bug ID: 92680 Summary: Problem with keeeping of content of footnoter Product: LibreOffice Version: 5.0.0.2 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: topaz3...@seznam.cz If you put imnage to footnoter in Calc and save file and you restart LO, nothing happened - image is out. It disappears. So Calc don't preserve image content in footnoter. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 4 commits - offapi/com svl/source xmloff/source
offapi/com/sun/star/util/NumberFormat.idl |6 ++
svl/source/numbers/zformat.cxx| 11 ++--
xmloff/source/style/xmlnumfe.cxx | 75 --
xmloff/source/style/xmlnumfi.cxx |6 +-
4 files changed, 67 insertions(+), 31 deletions(-)
New commits:
commit dad6be8af0e670a56d3d399a1b0a35859bd7b093
Author: Eike Rathke er...@redhat.com
Date: Sat Jul 11 02:52:42 2015 +0200
write trailing text subformat also to Excel .xls and .xlsx, tdf#92457
... without generating 0;;;@ from 0;@ that has different semantics.
Introduce css::util::NumberFormat::EMPTY to properly flag empty
subformats and distinguish from UNDEFINED, everything else would be an
ugly hack.
SvNumberformat::GetMappedFormatstring() now correctly supports the
trailing text subformat, so exports using it should get that
automatically.
Change-Id: If9a1bcc5ec5dfcf46688035e2b1428ab4747a68d
diff --git a/offapi/com/sun/star/util/NumberFormat.idl
b/offapi/com/sun/star/util/NumberFormat.idl
index 927bdf8..2bc297a 100644
--- a/offapi/com/sun/star/util/NumberFormat.idl
+++ b/offapi/com/sun/star/util/NumberFormat.idl
@@ -93,6 +93,12 @@ published constants NumberFormat
*/
const short UNDEFINED = 2048;
+
+/** @internal is used to flag an empty sub format.
+@since LibreOffice 5.1
+ */
+const short EMPTY = 4096;
+
};
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index c645034..03c2078 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -893,7 +893,8 @@ SvNumberformat::SvNumberformat(OUString rString,
}
if (sStr.isEmpty())
{
-// empty sub format
+// Empty sub format.
+NumFor[nIndex].Info().eScannedType =
css::util::NumberFormat::EMPTY;
}
else
{
@@ -2202,7 +2203,7 @@ bool SvNumberformat::GetOutputString(double fNumber,
*ppColor = NumFor[nIx].GetColor();
const ImpSvNumberformatInfo rInfo = NumFor[nIx].Info();
const sal_uInt16 nAnz = NumFor[nIx].GetCount();
-if (nAnz == 0 rInfo.eScannedType ==
css::util::NumberFormat::UNDEFINED)
+if (nAnz == 0 rInfo.eScannedType == css::util::NumberFormat::EMPTY)
{
return false; // Empty = nothing
}
@@ -4722,7 +4723,7 @@ OUString SvNumberformat::GetMappedFormatstring( const
NfKeywordTable rKeywords,
eOp1 == NUMBERFORMAT_OP_GE fLimit1 == 0.0
eOp2 == NUMBERFORMAT_OP_NO fLimit2 == 0.0 );
// with 3 or more subformats [0];[0];[=0] is implied if no condition
specified,
-// note that subformats may be empty (;;;) and NumFor[2].GetnAnz()0 is
not checked.
+// note that subformats may be empty (;;;) and NumFor[2].GetCount()0 is
not checked.
bDefault[2] = ( !bDefault[0] !bDefault[1]
eOp1 == NUMBERFORMAT_OP_GT fLimit1 == 0.0
eOp2 == NUMBERFORMAT_OP_LT fLimit2 == 0.0 );
@@ -4762,7 +4763,7 @@ OUString SvNumberformat::GetMappedFormatstring( const
NfKeywordTable rKeywords,
int nSub = 0; // subformats delimited so far
for ( int n=0; n4; n++ )
{
-if ( n 0 )
+if ( n 0 NumFor[n].Info().eScannedType !=
css::util::NumberFormat::UNDEFINED )
{
nSem++;
}
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 3ccf074..d0da09b 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -1006,9 +1006,6 @@ void SvXMLNumFmtExport::ExportPart_Impl( const
SvNumberformat rFormat, sal_uInt
// #101606# An empty subformat is a valid number-style resulting in an
// empty display string for the condition of the subformat.
-if ( nFmtType == css::util::NumberFormat::UNDEFINED
rFormat.GetNumForType( nPart,
-0, false ) == 0 )
-nFmtType = 0;
XMLTokenEnum eType = XML_TOKEN_INVALID;
switch ( nFmtType )
@@ -1016,6 +1013,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const
SvNumberformat rFormat, sal_uInt
// type is 0 if a format contains no recognized elements
// (like text only) - this is handled as a number-style.
case 0:
+case css::util::NumberFormat::EMPTY:
case css::util::NumberFormat::NUMBER:
case css::util::NumberFormat::SCIENTIFIC:
case css::util::NumberFormat::FRACTION:
commit 934e35c62525a7541e6a5b2d05b557a6fcc35abb
Author: Eike Rathke er...@redhat.com
Date: Fri Jul 10 23:49:43 2015 +0200
store trailing text format in ODF, e.g. 0;@ tdf#92457
A clumsy kludge, but since there is no all others condition..
Change-Id: Ie89b786585fdee6688f66f5a7af47ec84409eefa
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- are you still reproducing this issue after restart? have you tried resetting the user profile? https://wiki.documentfoundation.org/UserProfile -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92681] Menu list doesn't always close
https://bugs.documentfoundation.org/show_bug.cgi?id=92681 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #1 from tommy27 ba...@quipo.it --- consider upgrading to 4.4.4.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92661] Add contents of the Table toolbar as a new panel on the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92661 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it, ||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise Summary|Enhancement - Add contents |Add contents of the Table |of the Table toolbar as a |toolbar as a new panel on |new panel on the sidebar. |the sidebar Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- pinging the UX-team about this enhancement request -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 92661] Add contents of the Table toolbar as a new panel on the sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=92661 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||ba...@quipo.it, ||libreoffice-ux-advise@lists ||.freedesktop.org Component|Writer |ux-advise Summary|Enhancement - Add contents |Add contents of the Table |of the Table toolbar as a |toolbar as a new panel on |new panel on the sidebar. |the sidebar Ever confirmed|0 |1 --- Comment #1 from tommy27 ba...@quipo.it --- pinging the UX-team about this enhancement request -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91617] Writer freezes complete fedora rc21 KDE system, requiring reboot to cure.
https://bugs.documentfoundation.org/show_bug.cgi?id=91617 Beluga todven...@suomi24.fi changed: What|Removed |Added Resolution|FIXED |WORKSFORME --- Comment #4 from Beluga todven...@suomi24.fi --- Thanks, I'll tweak the status to be WORKSFORME. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92638] Formatting - Borders disappear when reloading an ods file.
https://bugs.documentfoundation.org/show_bug.cgi?id=92638 --- Comment #2 from Bob r_sanf...@verizon.net --- Resetting the profile folder as advise corrected this issue. Thank you for your quick and accurate response. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92676] New: selection print
https://bugs.documentfoundation.org/show_bug.cgi?id=92676 Bug ID: 92676 Summary: selection print Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: fabria...@alice.it Created attachment 117173 -- https://bugs.documentfoundation.org/attachment.cgi?id=117173action=edit excel format file Setup the printer for an A4 horizontal. Select cells from H66 to M76 Print the selection trying to print on an horizontal A4: there is no way to do it: the page format is always vertical. see attached file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91480] allow to build shared libraries in bundled projects on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91480 --- Comment #3 from Ashod Nakashian ashodnakash...@yahoo.com --- Thanks for the detailed feedback David. So, that is probably because libtool finds no known dynamic linker. At least in the case of libwps shared lib was disabled explicitly for non-gcc compilers (actually, it assumes non-gcc to mean mvs/msc). I have a patch to enable it, but, as you note, it still defaults to static linking. I think I know where to look: libtool. I agree that a ld-wrapper seems to be needed. I'll experiment with a wrapper and investigate how we could get it to cooperate with libtool to create shared libs. Btw, are we waiting for Windows support of shared libs to enable/test on other platforms, or does shared work on Linux? Do we know these libraries can/do link as shared? I haven't tried building on Linux, and it's easier to ask :) But not with the rest. You mean only with some projects? Not sure I get your point here. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 91480] allow to build shared libraries in bundled projects on Windows
https://bugs.documentfoundation.org/show_bug.cgi?id=91480 --- Comment #3 from Ashod Nakashian ashodnakash...@yahoo.com --- Thanks for the detailed feedback David. So, that is probably because libtool finds no known dynamic linker. At least in the case of libwps shared lib was disabled explicitly for non-gcc compilers (actually, it assumes non-gcc to mean mvs/msc). I have a patch to enable it, but, as you note, it still defaults to static linking. I think I know where to look: libtool. I agree that a ld-wrapper seems to be needed. I'll experiment with a wrapper and investigate how we could get it to cooperate with libtool to create shared libs. Btw, are we waiting for Windows support of shared libs to enable/test on other platforms, or does shared work on Linux? Do we know these libraries can/do link as shared? I haven't tried building on Linux, and it's easier to ask :) But not with the rest. You mean only with some projects? Not sure I get your point here. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92676] selection print
https://bugs.documentfoundation.org/show_bug.cgi?id=92676 --- Comment #1 from Timur gti...@gmail.com --- *** Bug 92677 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92677] selection print
https://bugs.documentfoundation.org/show_bug.cgi?id=92677 Timur gti...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Timur gti...@gmail.com --- *** This bug has been marked as a duplicate of bug 92676 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 56899] FILESAVE: Export dialogue should remember settings for consecutive exports (within session)
https://bugs.documentfoundation.org/show_bug.cgi?id=56899 --- Comment #6 from itsGord joeinbox...@hotmail.com --- Tested on another system (LO 4.1.4.2. Win 7 Home Premium SP 1 64 bit). On that system, the export is always pre-selected as EMF, with Automatic file name extension checked, and Selection not checked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: deb packages in wrong path
On Fri, Jul 10, 2015 at 11:15 AM, Marina Latini mar...@studiostorti.com wrote: JFYI something is going wrong here: http://download.documentfoundation.org/libreoffice/testing/4.4.5/deb/x86/ the x86_64 packages are in the wrong path. fixed. Ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/output.hxx|2 -
sc/source/ui/view/gridwin4.cxx |2 -
sc/source/ui/view/output.cxx | 56 -
sc/source/ui/view/printfun.cxx |4 +-
4 files changed, 32 insertions(+), 32 deletions(-)
New commits:
commit dfd7ff70a758061f67d2fce0b09de0d5076ac42a
Author: Krisztian Pinter pin.termina...@gmail.com
Date: Sun Jun 14 16:34:56 2015 +0200
calc mapmode: Add explicit RenderContext passing
Change-Id: I52d9c84bc6658348c249870088c38512ae169a34
Reviewed-on: https://gerrit.libreoffice.org/16277
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Jan Holesovsky ke...@collabora.com
diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index a7b96f7..d577efa 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -304,7 +304,7 @@ public:
Rectangle LayoutStrings(bool bPixelToLogic = false, bool bPaint = true,
const ScAddress rAddress = ScAddress());
voidDrawDocumentBackground();
-voidDrawBackground();
+voidDrawBackground(vcl::RenderContext rRenderContext);
voidDrawShadow();
voidDrawExtraShadow(bool bLeft, bool bTop, bool bRight, bool bBottom);
voidDrawFrame();
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 9a0dfd6..4432653a 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -725,7 +725,7 @@ void ScGridWindow::DrawContent(OutputDevice rDevice, const
ScTableInfo rTableI
MapMode aPrevMapMode = pContentDev-GetMapMode();
pContentDev-SetMapMode(MAP_PIXEL);
-aOutputData.DrawBackground();
+aOutputData.DrawBackground(*pContentDev);
pContentDev-SetMapMode(aPrevMapMode);
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index a2cc326..388b0e8 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -789,7 +789,7 @@ namespace {
static const double lclCornerRectTransparency = 40.0;
-void drawDataBars( const ScDataBarInfo* pOldDataBarInfo, vcl::RenderContext*
pDev, const Rectangle rRect)
+void drawDataBars(vcl::RenderContext rRenderContext, const ScDataBarInfo*
pOldDataBarInfo, const Rectangle rRect)
{
long nPosZero = 0;
Rectangle aPaintRect = rRect;
@@ -825,7 +825,7 @@ void drawDataBars( const ScDataBarInfo* pOldDataBarInfo,
vcl::RenderContext* pDe
if(pOldDataBarInfo-mbGradient)
{
-pDev-SetLineColor(pOldDataBarInfo-maColor);
+rRenderContext.SetLineColor(pOldDataBarInfo-maColor);
Gradient aGradient(GradientStyle_LINEAR, pOldDataBarInfo-maColor,
COL_TRANSPARENT);
if(pOldDataBarInfo-mnLength 0)
@@ -833,14 +833,14 @@ void drawDataBars( const ScDataBarInfo* pOldDataBarInfo,
vcl::RenderContext* pDe
else
aGradient.SetAngle(900);
-pDev-DrawGradient(aPaintRect, aGradient);
+rRenderContext.DrawGradient(aPaintRect, aGradient);
-pDev-SetLineColor();
+rRenderContext.SetLineColor();
}
else
{
-pDev-SetFillColor(pOldDataBarInfo-maColor);
-pDev-DrawRect(aPaintRect);
+rRenderContext.SetFillColor(pOldDataBarInfo-maColor);
+rRenderContext.DrawRect(aPaintRect);
}
//draw axis
@@ -852,11 +852,11 @@ void drawDataBars( const ScDataBarInfo* pOldDataBarInfo,
vcl::RenderContext* pDe
aLineInfo.SetDashCount( 4 );
aLineInfo.SetDistance( 3 );
aLineInfo.SetDashLen( 3 );
-pDev-SetFillColor(pOldDataBarInfo-maAxisColor);
-pDev-SetLineColor(pOldDataBarInfo-maAxisColor);
-pDev-DrawLine(aPoint1, aPoint2, aLineInfo);
-pDev-SetLineColor();
-pDev-SetFillColor();
+rRenderContext.SetFillColor(pOldDataBarInfo-maAxisColor);
+rRenderContext.SetLineColor(pOldDataBarInfo-maAxisColor);
+rRenderContext.DrawLine(aPoint1, aPoint2, aLineInfo);
+rRenderContext.SetLineColor();
+rRenderContext.SetFillColor();
}
}
@@ -865,18 +865,18 @@ BitmapEx getIcon( ScIconSetType eType, sal_Int32 nIndex )
return ScIconSetFormat::getBitmap( eType, nIndex );
}
-void drawIconSets( const ScIconSetInfo* pOldIconSetInfo, vcl::RenderContext*
pDev, const Rectangle rRect )
+void drawIconSets(vcl::RenderContext rRenderContext, const ScIconSetInfo*
pOldIconSetInfo, const Rectangle rRect)
{
//long nSize = 16;
ScIconSetType eType = pOldIconSetInfo-eIconSetType;
sal_Int32 nIndex = pOldIconSetInfo-nIconIndex;
BitmapEx rIcon = getIcon( eType, nIndex );
long aOrigSize = std::maxlong(0,std::min(rRect.GetSize().getWidth() - 4,
rRect.GetSize().getHeight() -4));
-pDev-DrawBitmapEx( Point( rRect.Left() +2, rRect.Top() + 2 ),
Size(aOrigSize, aOrigSize), rIcon );
+rRenderContext.DrawBitmapEx( Point( rRect.Left() +2, rRect.Top() + 2 ),
Size(aOrigSize, aOrigSize), rIcon );
}
-void drawCells(const Color* pColor, const SvxBrushItem* pBackground,
[Libreoffice-bugs] [Bug 92668] GetImplementationName method returns com.sun.star.comp.Writer.TextDocument rather than SwXTextDocument as before
https://bugs.documentfoundation.org/show_bug.cgi?id=92668 Stephan Bergmann sberg...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |sberg...@redhat.com |desktop.org | --- Comment #6 from Stephan Bergmann sberg...@redhat.com --- (In reply to Maxim Monastirsky from comment #5) If oDoc.ImplementationName SwXTextDocument Then assignTemplateToDoc = ERR_DOC_NOT_WRITER Exit Function EndIf Stupid me. So as there's indeed external code depending on those names (as bad as that is), it might be better to redo 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 in the other direction, making .component files match getImplementatName() implementations. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
