[Libreoffice-bugs] [Bug 92651] UI: Navigator resets on opening application
https://bugs.documentfoundation.org/show_bug.cgi?id=92651 Jacques Guilleron guillero...@aol.com changed: What|Removed |Added CC||guillero...@aol.com --- Comment #2 from Jacques Guilleron guillero...@aol.com --- I don't reproduce with LO 5.1.0.0.alpha1+ Build ID: a625cd702700ae1773966a3133d27027d1c4d083 TinderBox: Win-x86@39, Branch:master, Time: 2015-07-07_08:23:06 Locale: fr-FR (fr_FR) Windows 7 Home Premium. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: bridges/source
bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx |2 +-
bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 1f99f4a9c816cc106bfbdf229e4ec2bffb343847
Author: Heiher r...@hev.cc
Date: Tue Jul 14 01:24:52 2015 +0800
bridges: mips64: Fix build failure in new codes.
Change-Id: I17fe0fb0ce9341a638b2687e7690777a8de7fa01
Reviewed-on: https://gerrit.libreoffice.org/16980
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx
index 068bc55..8f510c8 100644
--- a/bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_mips64/cpp2uno.cxx
@@ -544,7 +544,7 @@ namespace
unsigned char * codeSnippet( unsigned char * code,
sal_Int32 functionIndex, sal_Int32 vtableOffset,
- bool bHasHiddenParam) SAL_THROW(())
+ bool bHasHiddenParam )
{
#ifdef BRDEBUG
fprintf(stderr,in codeSnippet functionIndex is %d\n, functionIndex);
diff --git a/bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx
index e7cd63f..859ffe5 100644
--- a/bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_mips64/uno2cpp.cxx
@@ -141,7 +141,7 @@ namespace
sal_uInt32 nREG)
{
// Should not happen, but...
-static_assert( MAX_GP_REGS == MAX_FP_REGS );
+static_assert(MAX_GP_REGS == MAX_FP_REGS, must be the same size);
if ( nREG MAX_GP_REGS )
nREG = MAX_GP_REGS;
@@ -266,7 +266,7 @@ namespace
// return
typelib_TypeDescription * pReturnTypeDescr = 0;
TYPELIB_DANGER_GET( pReturnTypeDescr, pReturnTypeRef );
-assert( pReturnTypeDescr, ### expected return type description! );
+assert(pReturnTypeDescr);
void * pCppReturn = 0; // if != 0 != pUnoReturn, needs reconversion
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/vcl vcl/source
include/vcl/field.hxx |2 --
vcl/source/control/field2.cxx | 14 --
2 files changed, 16 deletions(-)
New commits:
commit 83b072657ef8fb30f369cd4fc9db36d76de4cdd6
Author: Tor Lillqvist t...@collabora.com
Date: Mon Jul 13 13:03:31 2015 +0300
Bin two unused fields
Change-Id: If06753320d34e0e677c9456ddb47bfd3636e8a66
diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx
index fdb09f1..d5503cd 100644
--- a/include/vcl/field.hxx
+++ b/include/vcl/field.hxx
@@ -307,7 +307,6 @@ private:
DatemaLastDate;
DatemaMin;
DatemaMax;
-DatemaCorrectedDate;
boolmbLongFormat;
boolmbShowDateCentury;
sal_uInt16 mnDateFormat;
@@ -400,7 +399,6 @@ private:
tools::Time maLastTime;
tools::Time maMin;
tools::Time maMax;
-tools::Time maCorrectedTime;
TimeFieldFormat meFormat;
sal_uInt16 mnTimeFormat;
boolmbDuration;
diff --git a/vcl/source/control/field2.cxx b/vcl/source/control/field2.cxx
index 6f093e6..7efb8e6 100644
--- a/vcl/source/control/field2.cxx
+++ b/vcl/source/control/field2.cxx
@@ -1117,14 +1117,8 @@ bool DateFormatter::ImplDateReformat( const OUString
rStr, OUString rOutStr, c
if ( GetErrorHdl().IsSet() (aDate != aTempDate) )
{
-maCorrectedDate = aTempDate;
if( !GetErrorHdl().Call( this ) )
-{
-maCorrectedDate = Date( Date::SYSTEM );
return false;
-}
-else
-maCorrectedDate = Date( Date::SYSTEM );
}
rOutStr = ImplGetDateAsText( aTempDate, rSettings );
@@ -1418,7 +1412,6 @@ DateFormatter::DateFormatter() :
maLastDate( 0 ),
maMin( 1, 1, 1900 ),
maMax( 31, 12, 2200 ),
-maCorrectedDate( Date::SYSTEM ),
mbEnforceValidValue( true )
{
ImplInit();
@@ -2169,14 +2162,8 @@ bool TimeFormatter::ImplTimeReformat( const OUString
rStr, OUString rOutStr )
if ( GetErrorHdl().IsSet() (aTime != aTempTime) )
{
-maCorrectedTime = aTempTime;
if ( !GetErrorHdl().Call( this ) )
-{
-maCorrectedTime = tools::Time( tools::Time::SYSTEM );
return false;
-}
-else
-maCorrectedTime = tools::Time( tools::Time::SYSTEM );
}
bool bSecond = false;
@@ -2311,7 +2298,6 @@ TimeFormatter::TimeFormatter() :
maLastTime( 0, 0 ),
maMin( 0, 0 ),
maMax( 23, 59, 59, 9 ),
-maCorrectedTime( tools::Time::SYSTEM ),
mbEnforceValidValue( true ),
maFieldTime( 0, 0 )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92573] Writer crash when attempting to open one file.
https://bugs.documentfoundation.org/show_bug.cgi?id=92573 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92573] Writer crash when attempting to open one file.
https://bugs.documentfoundation.org/show_bug.cgi?id=92573 --- Comment #13 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7de992bcc66c973bb6b247184cac38f01cd1104a fix a11y crash seen on close of tdf#92573 It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/access/accnotextframe.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 7de992bcc66c973bb6b247184cac38f01cd1104a Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 13 12:38:18 2015 +0100 fix a11y crash seen on close of tdf#92573 its not the reported crash, which has gone away which might be a duplicate of tdf#90502 the switch only handled RES_TITLE_CHANGED and RES_DESCRIPTION_CHANGED so if its anything else, e.g. OBJ_DYING, then don't attempt GetNoTextNode Change-Id: I642beb66613481cbc7ee18647f0204a67d670a84 diff --git a/sw/source/core/access/accnotextframe.cxx b/sw/source/core/access/accnotextframe.cxx index 7647b35..58fb53f 100644 --- a/sw/source/core/access/accnotextframe.cxx +++ b/sw/source/core/access/accnotextframe.cxx @@ -102,6 +102,9 @@ void SwAccessibleNoTextFrame::Modify( const SfxPoolItem* pOld, const SfxPoolItem return; // probably was deleted - avoid doing anything } +if (nWhich != RES_TITLE_CHANGED || nWhich != RES_DESCRIPTION_CHANGED) +return; + const SwNoTextNode *pNd = GetNoTextNode(); OSL_ENSURE( pNd == aDepend.GetRegisteredIn(), invalid frame ); switch( nWhich ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - vcl/source
vcl/source/gdi/jobset.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 481240f4ba80c794bc86e1fec7795712f2b08650
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 11:02:56 2015 +0100
min legal size here is 4
(cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3)
Change-Id: I9f68d000b32623db4d949d13284043630f5689f4
(cherry picked from commit 964000d415bcf491704dad57aee7e0656ea60dab)
Reviewed-on: https://gerrit.libreoffice.org/16995
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index ab6d0cd..67109134 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -222,7 +222,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
{
sal_uInt16 nLen = 0;
rIStream.ReadUInt16( nLen );
-if ( !nLen )
+if (nLen = 4)
return rIStream;
sal_uInt16 nSystem = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92380] Style Preview broken some styles in Styles Pane on V5.0
https://bugs.documentfoundation.org/show_bug.cgi?id=92380 --- Comment #18 from David genericinet+libreoffice@gmail.com --- 5.0 rc3 has been released, and even though there is an option in Tools | Options | LibreOffice | View to disable the preview, it is not working. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #5 from Lionel Elie Mamane lio...@mamane.lu --- module jfreereport target UnpackedTarball_jfreereport_libformula or ExternalProject_jfreereport_libformula -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82744] WebDAV LOCK is released when document is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=82744 --- Comment #4 from Samuel Mehrbrodt s.mehrbr...@gmail.com --- If I'm assigned this bug, I'll do the rewriting for LibO for the framework part. Your work would be very welcome - please go ahead :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/source
vcl/source/gdi/jobset.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 964000d415bcf491704dad57aee7e0656ea60dab
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 11:02:56 2015 +0100
min legal size here is 4
(cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3)
Change-Id: I9f68d000b32623db4d949d13284043630f5689f4
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index ab6d0cd..67109134 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -222,7 +222,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
{
sal_uInt16 nLen = 0;
rIStream.ReadUInt16( nLen );
-if ( !nLen )
+if (nLen = 4)
return rIStream;
sal_uInt16 nSystem = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/filter/ww8/ww8scan.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 9f0044e16a42930d447f63e6129e9979f5e186ec
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 10:31:30 2015 +0100
ww8: make sure we don't wrap around
Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2
(cherry picked from commit 755b9320c81948358a1d4104c8875594b5700d39)
Reviewed-on: https://gerrit.libreoffice.org/16981
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 449bef4..8c3d979 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1540,7 +1540,11 @@ WW8PLCFpcd* WW8ScannerBase::OpenPieceTable( SvStream*
pStr, const WW8Fib* pWwF )
if( 2 == clxt ) // PLCFfpcd ?
break; // PLCFfpcd gefunden
if( 1 == clxt ) // clxtGrpprl ?
+{
+if (nGrpprl == SHRT_MAX)
+return NULL;
nGrpprl++;
+}
sal_uInt16 nLen(0);
pStr-ReadUInt16( nLen );
nLeft -= 2 + nLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: Gerrit: Reliability and fidelity of verification results
On Mon, Jul 13, 2015 at 1:22 AM, David Ostrovsky d.ostrov...@gmx.de wrote: I'd like to rise a question about reliability and fidelity of Jenkins Gerrit change verification results. Consider this change: 16877. It is so much easier to blame the tools indeed. * On patch set 8: [1] TB 66 voted VRFY+1 [2]. * On patch set 9: [3] TB 60 voted VRFY1-1 [4]. There weren't any changes in the affected file textdoc.cxx between those two patch sets. that is a bold thing to say when a patch change stuff like uno headers or rtl headers Moreover, while I don't have access to Mac OS X, I verified that the patch set 9 works as expected on Linux, with most recent clang version available. MacOSX rarely use the 'most recent clang version available' tb66 is Yosemite Apple LLVM version 6.1.0 (clang-602.0.49) (based on LLVM 3.6.0svn) Target: x86_64-apple-darwin14.3.0 tb60 is Maverick Apple LLVM version 6.0 (clang-600.0.51) (based on LLVM 3.5svn) Target: x86_64-apple-darwin13.4.0 And your patch 8 would have failed the same way on tb58/tb59/tb60 Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 2 commits - avmedia/Library_avmediavlc.mk avmedia/source
avmedia/Library_avmediavlc.mk |1 - avmedia/source/vlc/vlcframegrabber.cxx | 18 ++ avmedia/source/vlc/vlcframegrabber.hxx |2 ++ avmedia/source/vlc/vlcplayer.cxx | 19 +++ avmedia/source/vlc/vlcwindow.cxx | 18 ++ avmedia/source/vlc/vlcwindow.hxx |2 ++ avmedia/source/vlc/wrapper/Common.cxx |4 +++- avmedia/source/vlc/wrapper/ThreadsafeQueue.cxx |5 - avmedia/source/vlc/wrapper/Types.hxx |7 +++ 9 files changed, 69 insertions(+), 7 deletions(-) New commits: commit 888f51c749bc504f12295433a747dd507723bb56 Author: Michael Stahl mst...@redhat.com Date: Mon Jul 13 12:10:08 2015 +0200 avmedia: add some missing license headers to vlc files Change-Id: Ice9440bec7b0b5a4de2dca1392805130b1048303 diff --git a/avmedia/source/vlc/vlcframegrabber.cxx b/avmedia/source/vlc/vlcframegrabber.cxx index 05a27c2..bc5d03d 100644 --- a/avmedia/source/vlc/vlcframegrabber.cxx +++ b/avmedia/source/vlc/vlcframegrabber.cxx @@ -1,4 +1,22 @@ /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + #include boost/bind.hpp #include iostream #include osl/conditn.hxx diff --git a/avmedia/source/vlc/vlcframegrabber.hxx b/avmedia/source/vlc/vlcframegrabber.hxx index 6a34fe3..493a695 100644 --- a/avmedia/source/vlc/vlcframegrabber.hxx +++ b/avmedia/source/vlc/vlcframegrabber.hxx @@ -56,3 +56,5 @@ public: } #endif // INCLUDED_AVMEDIA_SOURCE_VLC_VLCFRAMEGRABBER_HXX + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/avmedia/source/vlc/vlcplayer.cxx b/avmedia/source/vlc/vlcplayer.cxx index 60d7b87..a8437b2 100644 --- a/avmedia/source/vlc/vlcplayer.cxx +++ b/avmedia/source/vlc/vlcplayer.cxx @@ -1,3 +1,22 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + #include boost/bind.hpp #include vcl/syschild.hxx #include vcl/sysdata.hxx diff --git a/avmedia/source/vlc/vlcwindow.cxx b/avmedia/source/vlc/vlcwindow.cxx index b7b63a8..ffac437 100644 --- a/avmedia/source/vlc/vlcwindow.cxx +++ b/avmedia/source/vlc/vlcwindow.cxx @@ -1,4 +1,22 @@ /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the License); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ + #include iostream #include cppuhelper/supportsservice.hxx #include vlcwindow.hxx diff --git a/avmedia/source/vlc/vlcwindow.hxx b/avmedia/source/vlc/vlcwindow.hxx index 6ce10c4..35f2b1f 100644 ---
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 31880a0c0123f2062bd39a2d0aa928561fa1fc05
Author: Caolán McNamara caol...@redhat.com
Date: Sun Jul 12 21:07:21 2015 +0100
emf: test for negative numbers
Change-Id: I9d9b6f3e9592ca7b85cee5422e43d4ca46b8bb36
(cherry picked from commit 4661b2dd34bd7c56b6d783d49f265e9ecde19caa)
Reviewed-on: https://gerrit.libreoffice.org/16969
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf
new file mode 100644
index 000..bbc0285
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 840f958..dcd802c 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1441,7 +1441,7 @@ bool EnhWMFReader::ReadEnhWMF()
DBG_ASSERT( ( nOptions ( ETO_PDY | ETO_GLYPH_INDEX ) )
== 0, SJ: ETO_PDY || ETO_GLYPH_INDEX in EMF );
Point aPos( ptlReferenceX, ptlReferenceY );
-if ( nLen nLen static_castsal_Int32( SAL_MAX_UINT32
/ sizeof(sal_Int32) ) )
+if ( nLen 0 nLen static_castsal_Int32(
SAL_MAX_UINT32 / sizeof(sal_Int32) ) )
{
if ( offDx (( nCurPos + offDx + nLen * 4 ) =
nNextPos ) )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 75051] Extension: LanguageTool 2.4 not working with stable LO release
https://bugs.documentfoundation.org/show_bug.cgi?id=75051 steve -_- st...@openmailbox.org changed: What|Removed |Added OS|Linux (All) |All --- Comment #10 from steve -_- st...@openmailbox.org --- OS → all since this was reported for OSX as well, so atm Linux + OS X -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Multiselection needs work?
Hi Julien, On Sun, 2015-07-12 at 01:02 +0200, Julien Nabet wrote: Here's a patch: https://gerrit.libreoffice.org/#/c/16959/ I truncated to 1 file in KDE part + Vista part. Heh =) I worry though that the implementation of the KDE Vista bits is doing this over-complicated foo - wrt. storing the directory URL in the first item, and then relative file-names in the next items, so by truncating it to 1x long we end up with just the directory-URL not the first file that was selected =) I'd hope we could rip some complexity out of the implementations there. I'd also suggest killing the comment about multi-selection in the UNO IDL and saying something of the form: This always, only ever returns the first selected file URL or somesuch (?) =) Thanks for persisting with this one ! ATB, Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #8 from Julien Nabet serval2...@yahoo.fr --- make jfreereport.clean in external fails. julien@julienPC:~/compile-libreoffice/libreoffice/external$ make jfreereport.clean make: *** No rule to make target 'jfreereport.clean'. Arrêt. I don't have --with-system(-jfreereport) in my autogen.input I think we both waste our time here. Certainly the time you explain to me all the stuff would be sufficient for you to make this patch at least 3 times. So I give up with this bugtracker, I'll try to patch an external lib when the process to do it will be more appropriate for dumbs like me:-) Also I don't know if patching an old version of jfreereport worth it (see tdf#67832 you had created) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #10 from Lionel Elie Mamane lio...@mamane.lu --- Created attachment 117200 -- https://bugs.documentfoundation.org/attachment.cgi?id=117200action=edit experimental untested patch -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #9 from Lionel Elie Mamane lio...@mamane.lu --- I was sneakily trying to get you familiarised with externals so that you can do extra work in the future ;) Here's what I did after some fumbling around (I myself haven't touched an external since they moved to the subdirectory external/, so there was fumbling associated) from top directory: make jfreereport.clean works edit autogen.input, add --without-system-jfreereport make jfreereport works then: $ make jfreereport.clean $ export patches=t $ make jfreereport $ emacs workdir/UnpackedTarball/jfreereport_libformula/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java ## cd external/freereport make 'UnpackedTarball_jfreereport_libformula' does nothing ## cd external/freereport make 'UnpackedTarball_jfreereport_libformula.rebuild' doesn't seem to rebuild either ## ditto with ExternalProject_jfreereport_libformula and ExternalPackage_jfreereport_libformula ## aaah!!! This works: $ make jfreereport_libformula.rebuild ## the part before rebuild is the name of the directory in workdir/UnpackedTarball/; this seems to be the important part $ make jfreereport_libformula.genpatch ## works also... This created the attached patch, Julien, could you test it? (stick it in external/jfreereport/patches, add it to UnpackedTarball_jfreereport_libformula.mk) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - bridges/source testtools/com testtools/source
bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx |6 ++
bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx | 16 ++--
testtools/com/sun/star/comp/bridge/TestComponent.java |4
testtools/source/bridgetest/bridgetest.cxx |4
testtools/source/bridgetest/cli/cli_cs_testobj.cs |5 +
testtools/source/bridgetest/cppobj.cxx |2 ++
testtools/source/bridgetest/idl/bridgetest.idl |6 ++
7 files changed, 37 insertions(+), 6 deletions(-)
New commits:
commit f31326f623b0be2392b3846f710df75ea8760446
Author: Caolan McNamara caol...@redhat.com
Date: Fri Jul 10 16:36:41 2015 +0100
ppc64: using a fp register also consumes a gp register slot
Change-Id: Idf6f40081f4598c0fa9d1e10bdc208eae49e4cd1
Reviewed-on: https://gerrit.libreoffice.org/16936
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit e8ac3b5bd973054c6fd74db017bb448721e2c3e2)
Reviewed-on: https://gerrit.libreoffice.org/16946
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
index 6b58246..6ac003b 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
@@ -133,6 +133,12 @@ static typelib_TypeClass cpp2uno_call(
}
pCppArgs[nPos] = pUnoArgs[nPos] = fpreg++;
nf++;
+
+if (ng ppc64::MAX_GPR_REGS)
+{
+ng++;
+gpreg++;
+}
}
else
{
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
index 81d3d5c..28dfaf8 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
@@ -229,16 +229,20 @@ static void callVirtualMethod(void * pThis, sal_uInt32
nVtableIndex,
// The value in %xmm register is already prepared to be retrieved as a float,
// thus we treat float and double the same
-#define INSERT_FLOAT( pSV, nr, pFPR, pDS, bOverflow ) \
-if ( nr ppc64::MAX_SSE_REGS ) \
+#define INSERT_FLOAT( pSV, nr, pFPR, nGPR, pDS, bOverflow ) \
+if ( nGPR ppc64::MAX_GPR_REGS ) \
+++nGPR; \
+if ( nr ppc64::MAX_SSE_REGS ) \
pFPR[nr++] = *reinterpret_castfloat *( pSV ); \
else \
bOverflow = true; \
if (bOverflow) \
*pDS++ = *reinterpret_castsal_uInt64 *( pSV ); // verbatim!
-#define INSERT_DOUBLE( pSV, nr, pFPR, pDS, bOverflow ) \
-if ( nr ppc64::MAX_SSE_REGS ) \
+#define INSERT_DOUBLE( pSV, nr, pFPR, nGPR, pDS, bOverflow ) \
+if ( nGPR ppc64::MAX_GPR_REGS ) \
+++nGPR; \
+if ( nr ppc64::MAX_SSE_REGS ) \
pFPR[nr++] = *reinterpret_castdouble *( pSV ); \
else \
bOverflow = true; \
@@ -390,10 +394,10 @@ static void cpp_call(
INSERT_INT8( pCppArgs[nPos], nGPR, pGPR,
pStack, bOverflow );
break;
case typelib_TypeClass_FLOAT:
-INSERT_FLOAT( pCppArgs[nPos], nFPR, pFPR,
pStack, bOverflow );
+INSERT_FLOAT( pCppArgs[nPos], nFPR, pFPR,
nGPR, pStack, bOverflow );
break;
case typelib_TypeClass_DOUBLE:
-INSERT_DOUBLE( pCppArgs[nPos], nFPR, pFPR,
pStack, bOverflow );
+INSERT_DOUBLE( pCppArgs[nPos], nFPR, pFPR,
nGPR, pStack, bOverflow );
break;
default:
break;
diff --git a/testtools/com/sun/star/comp/bridge/TestComponent.java
b/testtools/com/sun/star/comp/bridge/TestComponent.java
index bf1524d..8e07d1a 100644
--- a/testtools/com/sun/star/comp/bridge/TestComponent.java
+++ b/testtools/com/sun/star/comp/bridge/TestComponent.java
@@ -498,6 +498,10 @@ public class TestComponent {
return i2;
}
+public int testPPC64Alignment( double d1, double d2, double d3, int i1
) throws com.sun.star.uno.RuntimeException {
+return i1;
+}
+
public double testTenDoubles( double d1, double d2, double d3, double
d4, double d5, double d6, double d7, double d8, double d9, double d10 ) {
return d1 + d2 + d3 + d4 + d5 + d6 + d7 + d8 + d9 + d10;
}
diff --git
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5ef9b838791ebb7c4d5695dce5e5fd12eddcab96
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:10:12 2015 +0100
emf: fix hang
Change-Id: I2410308ecccb8c5318a718bafadc7b40a98cb82b
(cherry picked from commit 8695633023cc321a095753db98bdc69d2aeee058)
Reviewed-on: https://gerrit.libreoffice.org/16977
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
new file mode 100644
index 000..634fccd
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index d55349f..62ba08b 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -663,7 +663,7 @@ bool EnhWMFReader::ReadEnhWMF()
SAL_INFO(vcl.emf, \tGDI comment, length: length);
-if( pWMF-good() length = 4 ) {
+if( pWMF-good() length = 4 length = pWMF-remainingSize()
) {
sal_uInt32 id;
pWMF-ReadUInt32( id );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: chart2/inc chart2/Library_chartcontroller.mk chart2/source framework/inc framework/Library_fwk.mk framework/source framework/util include/svx officecfg/registry reportd
chart2/Library_chartcontroller.mk |1 chart2/inc/pch/precompiled_chartcontroller.hxx |1 chart2/source/controller/chartcontroller.component |4 chart2/source/controller/main/ShapeToolbarController.cxx| 290 -- chart2/source/controller/main/ShapeToolbarController.hxx| 94 -- framework/Library_fwk.mk|1 framework/inc/uifactory/factoryconfiguration.hxx|4 framework/source/uielement/subtoolbarcontroller.cxx | 458 ++ framework/source/uifactory/factoryconfiguration.cxx |8 framework/source/uifactory/uicontrollerfactory.cxx | 18 framework/util/fwk.component|4 include/svx/tbxcustomshapes.hxx | 59 - officecfg/registry/data/org/openoffice/Office/UI/Controller.xcu | 120 -- reportdesign/inc/pch/precompiled_rptui.hxx |1 reportdesign/source/ui/misc/toolboxcontroller.cxx | 62 - sc/inc/pch/precompiled_sc.hxx |1 sc/source/ui/app/scdll.cxx |7 sd/inc/pch/precompiled_sd.hxx |1 sd/source/ui/app/sddll.cxx |8 sd/source/ui/func/fuconcs.cxx |1 sd/source/ui/view/drviews6.cxx |1 sd/source/ui/view/drvwshrg.cxx |1 svx/Library_svx.mk |1 svx/source/customshapes/tbxcustomshapes.cxx | 157 --- sw/inc/pch/precompiled_sw.hxx |1 sw/source/uibase/app/swmodule.cxx |8 sw/source/uibase/shells/drawsh.cxx |1 27 files changed, 512 insertions(+), 801 deletions(-) New commits: commit 2aea9e37d697ce51efc5fb37ba50f1bf177e0445 Author: Maxim Monastirsky momonas...@gmail.com Date: Sun Jul 12 21:11:17 2015 +0300 Introduce generic sub toolbar controller Currently many toolbar controllers are basically doing the same thing - show some docked toolbar. So the idea here is to have one generic controller that will handle all these cases in a unified way. It will get the name of the toolbar that it's supposed to show from the configuration, based on the command it was registered for. Right now it can handle both simple (i.e. with DROPDOWNONLY bits) and split (i.e. with DROPDOWN bits) scenarios, where for split kind it replaces the function (and the image) of the main part of the button, with the last selected function, for easy reusing. A button is considered to be a split one, if the name of the initial default command was passed along with the sub toolbar name, otherwise it will be a simple button. The core change is in framework/. Other parts are a usage example, in form of converting the custom shapes buttons to this new controller. Change-Id: I087cc58c3db1889ca69a26546d4f00fe07e2a58d Reviewed-on: https://gerrit.libreoffice.org/16967 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Maxim Monastirsky momonas...@gmail.com diff --git a/chart2/Library_chartcontroller.mk b/chart2/Library_chartcontroller.mk index 884404e..1b2b46d 100644 --- a/chart2/Library_chartcontroller.mk +++ b/chart2/Library_chartcontroller.mk @@ -183,7 +183,6 @@ $(eval $(call gb_Library_add_exception_objects,chartcontroller,\ chart2/source/controller/main/PositionAndSizeHelper \ chart2/source/controller/main/SelectionHelper \ chart2/source/controller/main/ShapeController \ -chart2/source/controller/main/ShapeToolbarController \ chart2/source/controller/main/StatusBarCommandDispatch \ chart2/source/controller/main/UndoActions \ chart2/source/controller/main/UndoCommandDispatch \ diff --git a/chart2/inc/pch/precompiled_chartcontroller.hxx b/chart2/inc/pch/precompiled_chartcontroller.hxx index 12b3613..f6ebf36 100644 --- a/chart2/inc/pch/precompiled_chartcontroller.hxx +++ b/chart2/inc/pch/precompiled_chartcontroller.hxx @@ -270,7 +270,6 @@ #include svx/svxdlg.hxx #include svx/svxgrahicitem.hxx #include svx/tabline.hxx -#include svx/tbxcustomshapes.hxx #include svx/unoapi.hxx #include svx/unofill.hxx #include svx/unomodel.hxx diff --git a/chart2/source/controller/chartcontroller.component b/chart2/source/controller/chartcontroller.component index 045d61f..23269ba 100644 --- a/chart2/source/controller/chartcontroller.component +++ b/chart2/source/controller/chartcontroller.component @@ -43,10 +43,6 @@ constructor=com_sun_star_comp_chart2_ChartTypeDialog_get_implementation service name=com.sun.star.chart2.ChartTypeDialog/
[Libreoffice-bugs] [Bug 92676] Cannot change page orientation during selection print (if Page style not changed)
https://bugs.documentfoundation.org/show_bug.cgi?id=92676 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=91 ||362 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: include/xmloff xmloff/source
include/xmloff/xmltoken.hxx |4 ++--
xmloff/source/core/xmltoken.cxx |4 ++--
xmloff/source/style/xmlnumfe.cxx |8
xmloff/source/style/xmlnumfi.cxx | 12 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 9c2a8065add0da1e649633efa0795beddfa68eed
Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net
Date: Fri Jul 10 08:21:23 2015 +0200
tdf#90133 Comply attributes name with OASIS#3860
See https://issues.oasis-open.org/browse/OFFICE-3860
Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062
Reviewed-on: https://gerrit.libreoffice.org/16905
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index bf6ad20..1eea8c1 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -3250,8 +3250,8 @@ namespace xmloff { namespace token {
XML_EXTERNALDATA,
XML_EXPONENT_INTERVAL,
-XML_EXPONENT_SIGN,
-XML_MIN_DECIMAL_DIGITS,
+XML_FORCED_EXPONENT_SIGN,
+XML_MIN_DECIMAL_PLACES,
XML_TOKEN_END
};
diff --git a/xmloff/source/core/xmltoken.cxx b/xmloff/source/core/xmltoken.cxx
index 5e1dd51..63e4aff 100644
--- a/xmloff/source/core/xmltoken.cxx
+++ b/xmloff/source/core/xmltoken.cxx
@@ -3248,8 +3248,8 @@ namespace xmloff { namespace token {
TOKEN( external-data, XML_EXTERNALDATA),
TOKEN( exponent-interval, XML_EXPONENT_INTERVAL ),
-TOKEN( exponent-sign, XML_EXPONENT_SIGN ),
-TOKEN( min-decimal-digits, XML_MIN_DECIMAL_DIGITS ),
+TOKEN( forced-exponent-sign,XML_FORCED_EXPONENT_SIGN ),
+TOKEN( min-decimal-places, XML_MIN_DECIMAL_PLACES ),
#if OSL_DEBUG_LEVEL 0
{ 0, NULL, NULL, XML_TOKEN_END }
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 700113e..535d136 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -570,7 +570,7 @@ void SvXMLNumFmtExport::WriteNumberElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -651,7 +651,7 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -692,11 +692,11 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
// exponent sign
if ( bExpSign )
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_TRUE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_TRUE );
}
else
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_FALSE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_FALSE );
}
SvXMLElementExport aElem( rExport,
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index b1a59ae..700cbae 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -274,7 +274,7 @@ enum SvXMLStyleAttrTokens
enum SvXMLStyleElemAttrTokens
{
XML_TOK_ELEM_ATTR_DECIMAL_PLACES,
-XML_TOK_ELEM_ATTR_MIN_DECIMAL_DIGITS,
+XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_MIN_INTEGER_DIGITS,
XML_TOK_ELEM_ATTR_GROUPING,
XML_TOK_ELEM_ATTR_DISPLAY_FACTOR,
@@ -282,7 +282,7 @@ enum SvXMLStyleElemAttrTokens
XML_TOK_ELEM_ATTR_DENOMINATOR_VALUE,
XML_TOK_ELEM_ATTR_MIN_EXPONENT_DIGITS,
XML_TOK_ELEM_ATTR_EXPONENT_INTERVAL,
-XML_TOK_ELEM_ATTR_EXPONENT_SIGN,
+XML_TOK_ELEM_ATTR_FORCED_EXPONENT_SIGN,
XML_TOK_ELEM_ATTR_MIN_NUMERATOR_DIGITS,
XML_TOK_ELEM_ATTR_MIN_DENOMINATOR_DIGITS,
XML_TOK_ELEM_ATTR_RFC_LANGUAGE_TAG,
@@ -572,7 +572,7 @@ const SvXMLTokenMap
SvXMLNumImpData::GetStyleElemAttrTokenMap()
{
// attributes for an element within a style
{ XML_NAMESPACE_NUMBER, XML_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_DECIMAL_PLACES },
-{ XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
XML_TOK_ELEM_ATTR_MIN_DECIMAL_DIGITS },
+{ XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES },
{ XML_NAMESPACE_NUMBER, XML_MIN_INTEGER_DIGITS,
XML_TOK_ELEM_ATTR_MIN_INTEGER_DIGITS },
{ XML_NAMESPACE_NUMBER,
[Libreoffice-bugs] [Bug 91362] wrong defaults for format/orientation in printsettingsdialogs of printerdrivers
https://bugs.documentfoundation.org/show_bug.cgi?id=91362 Timur gti...@gmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||676 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: editeng/source include/editeng sd/source
editeng/source/outliner/outliner.cxx |4 ++--
include/editeng/outliner.hxx |7 +++
sd/source/ui/inc/OutlineView.hxx |2 +-
sd/source/ui/view/outlview.cxx |6 +++---
4 files changed, 9 insertions(+), 10 deletions(-)
New commits:
commit 4cb59a867f5a306642f3cbf49bd97b5e14c0998a
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 11:21:01 2015 +0200
Fix IndentingPagesHdl type (and GetIndentingPagesHdl is unused)
Change-Id: Ide5398040678a81e032e91e582b39d516e8c08a8
diff --git a/editeng/source/outliner/outliner.cxx
b/editeng/source/outliner/outliner.cxx
index 86725f0..4493f0a 100644
--- a/editeng/source/outliner/outliner.cxx
+++ b/editeng/source/outliner/outliner.cxx
@@ -1251,10 +1251,10 @@ void Outliner::ImpTextPasted( sal_Int32 nStartPara,
sal_Int32 nCount )
DBG_ASSERT(pParaList-GetParagraphCount()==pEditEngine-GetParagraphCount(),ImpTextPasted
failed);
}
-long Outliner::IndentingPagesHdl( OutlinerView* pView )
+bool Outliner::IndentingPagesHdl( OutlinerView* pView )
{
if( !aIndentingPagesHdl.IsSet() )
-return 1;
+return true;
return aIndentingPagesHdl.Call( pView );
}
diff --git a/include/editeng/outliner.hxx b/include/editeng/outliner.hxx
index d1b05ad..d121f01 100644
--- a/include/editeng/outliner.hxx
+++ b/include/editeng/outliner.hxx
@@ -596,7 +596,7 @@ class EDITENG_DLLPUBLIC Outliner : public SfxBroadcaster
LinkOutliner*,void aDepthChangedHdl;
LinkOutliner*,void aBeginMovingHdl;
LinkOutliner*,void aEndMovingHdl;
-LinkOutlinerView*,long aIndentingPagesHdl;
+LinkOutlinerView*,bool aIndentingPagesHdl;
LinkOutlinerView*,bool aRemovingPagesHdl;
LinkEditFieldInfo*,void aFieldClickedHdl;
LinkEditFieldInfo*,void aCalcFieldValueHdl;
@@ -775,9 +775,8 @@ public:
boolRemovingPagesHdl( OutlinerView* );
voidSetRemovingPagesHdl(const LinkOutlinerView*,bool
rLink){aRemovingPagesHdl=rLink;}
LinkOutlinerView*,bool GetRemovingPagesHdl() const { return
aRemovingPagesHdl; }
-longIndentingPagesHdl( OutlinerView* );
-voidSetIndentingPagesHdl(const LinkOutlinerView*,long
rLink){aIndentingPagesHdl=rLink;}
-LinkOutlinerView*,long GetIndentingPagesHdl() const { return
aIndentingPagesHdl; }
+boolIndentingPagesHdl( OutlinerView* );
+voidSetIndentingPagesHdl(const LinkOutlinerView*,bool
rLink){aIndentingPagesHdl=rLink;}
// valid only in the two upper handlers
sal_Int32 GetSelPageCount() const { return
nDepthChangedHdlPrevDepth; }
diff --git a/sd/source/ui/inc/OutlineView.hxx b/sd/source/ui/inc/OutlineView.hxx
index 495a4d7..0daad3d 100644
--- a/sd/source/ui/inc/OutlineView.hxx
+++ b/sd/source/ui/inc/OutlineView.hxx
@@ -102,7 +102,7 @@ public:
DECL_LINK_TYPED( BeginMovingHdl, Outliner *, void );
DECL_LINK_TYPED( EndMovingHdl, Outliner *, void );
DECL_LINK_TYPED( RemovingPagesHdl, OutlinerView *, bool );
-DECL_LINK_TYPED( IndentingPagesHdl, OutlinerView *, long );
+DECL_LINK_TYPED( IndentingPagesHdl, OutlinerView *, bool );
DECL_LINK( BeginDropHdl, void * );
DECL_LINK( EndDropHdl, void * );
DECL_LINK_TYPED( PaintingFirstLineHdl, PaintFirstLineInfo*, void );
diff --git a/sd/source/ui/view/outlview.cxx b/sd/source/ui/view/outlview.cxx
index 076ee48..7685718 100644
--- a/sd/source/ui/view/outlview.cxx
+++ b/sd/source/ui/view/outlview.cxx
@@ -1194,9 +1194,9 @@ IMPL_LINK_NOARG_TYPED(OutlineView, RemovingPagesHdl,
OutlinerView*, bool)
/**
* Handler for indenting level 0 paragraphs (pages): Warning
*/
-IMPL_LINK_TYPED( OutlineView, IndentingPagesHdl, OutlinerView *,
pOutlinerView, long )
+IMPL_LINK_TYPED( OutlineView, IndentingPagesHdl, OutlinerView *,
pOutlinerView, bool )
{
-return RemovingPagesHdl(pOutlinerView) ? 1 : 0;
+return RemovingPagesHdl(pOutlinerView);
}
/** returns the first slide that is selected in the outliner or where
@@ -1371,7 +1371,7 @@ void OutlineView::ResetLinks() const
mrOutliner.SetEndMovingHdl(Link::Outliner*,void());
mrOutliner.SetStatusEventHdl(aEmptyLink);
mrOutliner.SetRemovingPagesHdl(LinkOutlinerView*,bool());
-mrOutliner.SetIndentingPagesHdl(LinkOutlinerView*,long());
+mrOutliner.SetIndentingPagesHdl(LinkOutlinerView*,bool());
mrOutliner.SetDrawPortionHdl(LinkDrawPortionInfo*,void());
mrOutliner.SetBeginPasteOrDropHdl(LinkPasteOrDropInfos*,void());
mrOutliner.SetEndPasteOrDropHdl(LinkPasteOrDropInfos*,void());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 82744] WebDAV LOCK is released when document is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=82744 --- Comment #3 from Giuseppe Castagno (aka beppec56) giuseppe.casta...@acca-esse.eu --- I recently added the WebDAV lock/unlock mechanism in AOO. https://bz.apache.org/ooo/show_bug.cgi?id=126305 it's scheduled to be included in 4.1.2. In AOO the lower WebDAV layer is managed by serf, not by neon, the work there was a little different, but I implemented the framework strategy for lock/unlock. If I'm assigned this bug, I'll do the rewriting for LibO for the framework part. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/gdi/jobset.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 11:02:56 2015 +0100
min legal size here is 4
Change-Id: I9f68d000b32623db4d949d13284043630f5689f4
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index 17fb9c7..4d9b499 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -222,7 +222,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
{
sal_uInt16 nLen = 0;
rIStream.ReadUInt16( nLen );
-if ( !nLen )
+if (nLen = 4)
return rIStream;
sal_uInt16 nSystem = 0;
@@ -236,7 +236,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
}
sal_Size nFirstPos = rIStream.Tell();
std::unique_ptrchar[] pTempBuf(new char[nRead]);
-rIStream.Read(pTempBuf.get(), nRead);
+rIStream.Read(pTempBuf.get(), nRead);
if (nRead = sizeof(ImplOldJobSetupData))
{
ImplOldJobSetupData* pData =
reinterpret_castImplOldJobSetupData*(pTempBuf.get());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=89 ||986 --- Comment #5 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to Manfred from comment #4) Hi Manfred, Thanks will take a look, but I will not upload your sheet to the bug as you request. Bug 89986 might be of interest to you as well, as I have had severe performance issues there too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89986] PaintHelper performance rendering or redrawing graphic objects, e.g. macro button, grids, etc (OSX)
https://bugs.documentfoundation.org/show_bug.cgi?id=89986 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||664 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90502] CRASH - failed assertion in unittest sw_globalfilter in master build OSX (ImplLogicToPixel)
https://bugs.documentfoundation.org/show_bug.cgi?id=90502 --- Comment #18 from Julien Nabet serval2...@yahoo.fr --- (In reply to Caolán McNamara from comment #17) Is this still a problem or is it fixed, I ask because the bt in bug 92573 is similar to this one I've just git updated and it's building right now. However, I can say that with sources updated the 8th of July, it was still crashing with same messages. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #6 from Julien Nabet serval2...@yahoo.fr --- cd module can't work since there's no jfreereport in root LO sources. So I tried cd external/jfreereport make -r gives [build BIN] top level modules: jfreereport [build LOC] top level modules: jfreereport [build ALL] top level modules: build-non-l10n-only build-l10n-only make: Nothing to be done for 'all'. Then, I tried: make -r ExternalProject_jfreereport_libformula.rebuild if [ -f /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula.done ] ; then \ touch /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula.done ; \ make ;\ fi julien@julienPC:~/compile-libreoffice/libreoffice/external/jfreereport$ make ExternalProject_jfreereport_libformula.genpatch if [ -d /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula -a -d /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula.org ] ; then \ ( \ patch_file=$(pwd)/ExternalProject_jfreereport_libformula.new.patch.1; \ cd /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ ; \ diff -ur ExternalProject_jfreereport_libformula.org ExternalProject_jfreereport_libformula $patch_file; \ echo Patch $patch_file generated ; \ ); \ else \ echo Error: No pristine tarball available for ExternalProject_jfreereport_libformula 12 ; \ fi Error: No pristine tarball available for ExternalProject_jfreereport_libformula finally, I tried this: make -r UnpackedTarball_jfreereport_libformula.rebuild if [ -f /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/UnpackedTarball_jfreereport_libformula.done ] ; then \ touch /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/UnpackedTarball_jfreereport_libformula.done ; \ make ;\ fi julien@julienPC:~/compile-libreoffice/libreoffice/external/jfreereport$ make ExternalProject_jfreereport_libformula.genpatch if [ -d /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula -a -d /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ExternalProject_jfreereport_libformula.org ] ; then \ ( \ patch_file=$(pwd)/ExternalProject_jfreereport_libformula.new.patch.1; \ cd /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/ ; \ diff -ur ExternalProject_jfreereport_libformula.org ExternalProject_jfreereport_libformula $patch_file; \ echo Patch $patch_file generated ; \ ); \ else \ echo Error: No pristine tarball available for ExternalProject_jfreereport_libformula 12 ; \ fi Error: No pristine tarball available for ExternalProject_jfreereport_libformula -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82744] WebDAV LOCK is released when document is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=82744 Samuel Mehrbrodt s.mehrbr...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |giuseppe.castagno@acca-esse |desktop.org |.eu -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - jvmfwk/plugins
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 444e9e16524af54d67f6131bba96f2faaa66b078
Author: Christian Lohmaier lohmaier+libreoff...@googlemail.com
Date: Sat Jul 11 02:03:01 2015 +0200
tdf#92483 fix initializing JRE on Win 64bit (load java's msvcr100.dll)
problem is that the offsets/sizes are of different type than ptrdiff_t,
and when using without casting, the resulting address is way off...
Change-Id: I7b1cdd611c8c4b317cd33ca8fbbda2e7e8f5f4fc
Reviewed-on: https://gerrit.libreoffice.org/16938
Reviewed-by: David Ostrovsky da...@ostrovsky.org
Tested-by: Jenkins c...@libreoffice.org
(cherry picked from commit 1b4d27a3ba2648c3f02cd234ca74c5a40e6b)
Reviewed-on: https://gerrit.libreoffice.org/16950
(cherry picked from commit 14bc2d237813b208a176cacece3a27a32145d3b4)
Reviewed-on: https://gerrit.libreoffice.org/16956
Reviewed-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com
Tested-by: Michael Stahl mst...@redhat.com
diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
index 72e17d3..0007975 100644
--- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
+++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx
@@ -591,7 +591,7 @@ static void do_msvcr_magic(rtl_uString *jvm_dll)
if (sections-VirtualAddress = importsVA
importsVA sections-VirtualAddress + sections-SizeOfRawData)
{
-VAtoPhys = sections-PointerToRawData - sections-VirtualAddress;
+VAtoPhys = static_castsize_t(sections-PointerToRawData) -
static_castsize_t(sections-VirtualAddress);
break;
}
++sections;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard| target:5.1.0 target:5.0.1 | target:5.1.0 target:5.0.1 ||target:5.0.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92483] JRE defective message unless user installs Visual C++ 2010 runtimes
https://bugs.documentfoundation.org/show_bug.cgi?id=92483 --- Comment #13 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Christian Lohmaier committed a patch related to this issue. It has been pushed to libreoffice-5-0-0: http://cgit.freedesktop.org/libreoffice/core/commit/?id=444e9e16524af54d67f6131bba96f2faaa66b078h=libreoffice-5-0-0 tdf#92483 fix initializing JRE on Win 64bit (load java's msvcr100.dll) It will be available in 5.0.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - bridges/source
bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx | 61 ++--
1 file changed, 24 insertions(+), 37 deletions(-)
New commits:
commit 3059edbc419e79f964a340b5b0ac828a5e86
Author: Caolan McNamara caol...@redhat.com
Date: Fri Jul 10 16:00:22 2015 +0100
ppc64: simplify this a little
Change-Id: I8166f65625d389a604750852d6d5a4fee25a88fa
Reviewed-on: https://gerrit.libreoffice.org/16935
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit fe14c55f000b9a31d885b411655232e0691e1cd4)
Reviewed-on: https://gerrit.libreoffice.org/16945
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
index 4013076..81d3d5c 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
@@ -124,6 +124,8 @@ void MapReturn(long r3, long r4, double dret,
typelib_TypeDescriptionReference*
if (pReturnType-pType-nSize 8)
pRegisters[1] = r4;
}
+#else
+(void)r4;
#endif
default:
break;
@@ -185,45 +187,29 @@ static void callVirtualMethod(void * pThis, sal_uInt32
nVtableIndex,
// fill registers
__asm__ __volatile__ (
-ld 3, 0(%0)\n\t
-ld 4, 8(%0)\n\t
-ld 5, 16(%0)\n\t
-ld 6, 24(%0)\n\t
-ld 7, 32(%0)\n\t
-ld 8, 40(%0)\n\t
-ld 9, 48(%0)\n\t
-ld 10, 56(%0)\n\t
-lfd 1, 0(%1)\n\t
-lfd 2, 8(%1)\n\t
-lfd 3, 16(%1)\n\t
-lfd 4, 24(%1)\n\t
-lfd 5, 32(%1)\n\t
-lfd 6, 40(%1)\n\t
-lfd 7, 48(%1)\n\t
-lfd 8, 56(%1)\n\t
-lfd 9, 64(%1)\n\t
-lfd 10, 72(%1)\n\t
-lfd 11, 80(%1)\n\t
-lfd 12, 88(%1)\n\t
-lfd 13, 96(%1)\n\t
-: : r (pGPR), r (pFPR)
- : r0, r3, r4, r5, r6, r7, r8, r9, r10,
- fr1, fr2, fr3, fr4, fr5, fr6, fr7, fr8,
fr9,
- fr10, fr11, fr12, fr13
+lfd 1, 0(%0)\n\t
+lfd 2, 8(%0)\n\t
+lfd 3, 16(%0)\n\t
+lfd 4, 24(%0)\n\t
+lfd 5, 32(%0)\n\t
+lfd 6, 40(%0)\n\t
+lfd 7, 48(%0)\n\t
+lfd 8, 56(%0)\n\t
+lfd 9, 64(%0)\n\t
+lfd 10, 72(%0)\n\t
+lfd 11, 80(%0)\n\t
+lfd 12, 88(%0)\n\t
+lfd 13, 96(%0)\n\t
+: : r (pFPR)
+ : fr1, fr2, fr3, fr4, fr5, fr6, fr7, fr8, fr9,
+fr10, fr11, fr12, fr13
);
// tell gcc that r3 to r11 are not available to it for doing the TOC and
exception munge on the func call
register sal_uInt64 r3 asm(r3);
register sal_uInt64 r4 asm(r4);
-register sal_uInt64 r5 asm(r5);
-register sal_uInt64 r6 asm(r6);
-register sal_uInt64 r7 asm(r7);
-register sal_uInt64 r8 asm(r8);
-register sal_uInt64 r9 asm(r9);
-register sal_uInt64 r10 asm(r10);
-register sal_uInt64 r11 asm(r11);
-(*pFunc)(r3, r4, r5, r6, r7, r8, r9, r10);
+(*pFunc)(pGPR[0], pGPR[1], pGPR[2], pGPR[3], pGPR[4], pGPR[5], pGPR[6],
pGPR[7]);
// get return value
__asm__ __volatile__ (
@@ -375,7 +361,6 @@ static void cpp_call(
if (!rParam.bOut bridges::cpp_uno::shared::isSimpleType(
pParamTypeDescr ))
{
-// uno_copyAndConvertData( pCppArgs[nPos] = alloca( 8 ),
pUnoArgs[nPos], pParamTypeDescr,
uno_copyAndConvertData( pCppArgs[nPos] = pStack, pUnoArgs[nPos],
pParamTypeDescr,
pThis-getBridge()-getUno2Cpp() );
switch (pParamTypeDescr-eTypeClass)
@@ -383,7 +368,7 @@ static void cpp_call(
case typelib_TypeClass_HYPER:
case typelib_TypeClass_UNSIGNED_HYPER:
#if OSL_DEBUG_LEVEL 2
-fprintf(stderr, hyper is %lx\n, pCppArgs[nPos]);
+fprintf(stderr, hyper is %lx\n,
pCppArgs[nPos]);
#endif
INSERT_INT64( pCppArgs[nPos], nGPR, pGPR,
pStack, bOverflow );
break;
@@ -391,7 +376,7 @@ static void cpp_call(
case typelib_TypeClass_UNSIGNED_LONG:
case typelib_TypeClass_ENUM:
#if OSL_DEBUG_LEVEL 2
-fprintf(stderr, long is %x\n, pCppArgs[nPos]);
+fprintf(stderr, long is %x\n,
pCppArgs[nPos]);
#endif
INSERT_INT32(
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - bridges/source testtools/com testtools/source
bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx |6 ++
bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx | 16 ++--
testtools/com/sun/star/comp/bridge/TestComponent.java |4
testtools/source/bridgetest/bridgetest.cxx |4
testtools/source/bridgetest/cli/cli_cs_testobj.cs |5 +
testtools/source/bridgetest/cppobj.cxx |2 ++
testtools/source/bridgetest/idl/bridgetest.idl |6 ++
7 files changed, 37 insertions(+), 6 deletions(-)
New commits:
commit 3708b3eb99f9283032e4210946aaf8a57d3bd252
Author: Caolan McNamara caol...@redhat.com
Date: Fri Jul 10 16:36:41 2015 +0100
ppc64: using a fp register also consumes a gp register slot
Change-Id: Idf6f40081f4598c0fa9d1e10bdc208eae49e4cd1
Reviewed-on: https://gerrit.libreoffice.org/16936
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit e8ac3b5bd973054c6fd74db017bb448721e2c3e2)
Reviewed-on: https://gerrit.libreoffice.org/16948
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
index f2e5174..37ea597 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/cpp2uno.cxx
@@ -132,6 +132,12 @@ static typelib_TypeClass cpp2uno_call(
}
pCppArgs[nPos] = pUnoArgs[nPos] = fpreg++;
nf++;
+
+if (ng ppc64::MAX_GPR_REGS)
+{
+ng++;
+gpreg++;
+}
}
else
{
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
index a8ff6b4..c627e2e 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
@@ -229,16 +229,20 @@ static void callVirtualMethod(void * pThis, sal_uInt32
nVtableIndex,
// The value in %xmm register is already prepared to be retrieved as a float,
// thus we treat float and double the same
-#define INSERT_FLOAT( pSV, nr, pFPR, pDS, bOverflow ) \
-if ( nr ppc64::MAX_SSE_REGS ) \
+#define INSERT_FLOAT( pSV, nr, pFPR, nGPR, pDS, bOverflow ) \
+if ( nGPR ppc64::MAX_GPR_REGS ) \
+++nGPR; \
+if ( nr ppc64::MAX_SSE_REGS ) \
pFPR[nr++] = *reinterpret_castfloat *( pSV ); \
else \
bOverflow = true; \
if (bOverflow) \
*pDS++ = *reinterpret_castsal_uInt64 *( pSV ); // verbatim!
-#define INSERT_DOUBLE( pSV, nr, pFPR, pDS, bOverflow ) \
-if ( nr ppc64::MAX_SSE_REGS ) \
+#define INSERT_DOUBLE( pSV, nr, pFPR, nGPR, pDS, bOverflow ) \
+if ( nGPR ppc64::MAX_GPR_REGS ) \
+++nGPR; \
+if ( nr ppc64::MAX_SSE_REGS ) \
pFPR[nr++] = *reinterpret_castdouble *( pSV ); \
else \
bOverflow = true; \
@@ -392,10 +396,10 @@ static void cpp_call(
INSERT_INT8( pCppArgs[nPos], nGPR, pGPR,
pStack, bOverflow );
break;
case typelib_TypeClass_FLOAT:
-INSERT_FLOAT( pCppArgs[nPos], nFPR, pFPR,
pStack, bOverflow );
+INSERT_FLOAT( pCppArgs[nPos], nFPR, pFPR,
nGPR, pStack, bOverflow );
break;
case typelib_TypeClass_DOUBLE:
-INSERT_DOUBLE( pCppArgs[nPos], nFPR, pFPR,
pStack, bOverflow );
+INSERT_DOUBLE( pCppArgs[nPos], nFPR, pFPR,
nGPR, pStack, bOverflow );
break;
default:
break;
diff --git a/testtools/com/sun/star/comp/bridge/TestComponent.java
b/testtools/com/sun/star/comp/bridge/TestComponent.java
index bee487b..7c51a57 100644
--- a/testtools/com/sun/star/comp/bridge/TestComponent.java
+++ b/testtools/com/sun/star/comp/bridge/TestComponent.java
@@ -503,6 +503,10 @@ public class TestComponent {
return i2;
}
+public int testPPC64Alignment( double d1, double d2, double d3, int i1
) throws com.sun.star.uno.RuntimeException {
+return i1;
+}
+
public double testTenDoubles( double d1, double d2, double d3, double
d4, double d5, double d6, double d7, double d8, double d9, double d10 ) {
return d1 + d2 + d3 + d4 + d5 + d6 + d7 + d8 + d9 + d10;
}
diff --git
[Libreoffice-commits] core.git: 2 commits - include/svx
include/svx/grfflt.hxx | 18 -- 1 file changed, 18 deletions(-) New commits: commit 1c263b70cad4ec168279857a0e00d9eea14dd741 Author: Tor Lillqvist t...@collabora.com Date: Mon Jul 13 13:57:41 2015 +0300 Bin pointless comments Change-Id: Ifebb44ce61b920488af52c7ab377c188bd4f9015 diff --git a/include/svx/grfflt.hxx b/include/svx/grfflt.hxx index 6a0ded0..278e093 100644 --- a/include/svx/grfflt.hxx +++ b/include/svx/grfflt.hxx @@ -23,18 +23,10 @@ #include svtools/grfmgr.hxx #include svx/svxdllapi.h - -// - Error codes - - - #define SVX_GRAPHICFILTER_ERRCODE_NONE 0x #define SVX_GRAPHICFILTER_UNSUPPORTED_GRAPHICTYPE 0x0001 #define SVX_GRAPHICFILTER_UNSUPPORTED_SLOT 0x0002 - -// - SvxGraphicFilter - - - class SfxRequest; class SfxItemSet; commit c50f962215e9b09dc37fc319bb821c057a5e349c Author: Tor Lillqvist t...@collabora.com Date: Mon Jul 13 13:55:41 2015 +0300 Bin unneeded includes Change-Id: Id0e63897c9840ef412cf575de0485f2b685aaebc diff --git a/include/svx/grfflt.hxx b/include/svx/grfflt.hxx index ecc5b3a..6a0ded0 100644 --- a/include/svx/grfflt.hxx +++ b/include/svx/grfflt.hxx @@ -20,17 +20,7 @@ #ifndef INCLUDED_SVX_GRFFLT_HXX #define INCLUDED_SVX_GRFFLT_HXX -#include vcl/fixed.hxx -#include vcl/field.hxx -#include vcl/button.hxx -#include vcl/timer.hxx -#include vcl/dialog.hxx -#include vcl/group.hxx -#include vcl/salbtype.hxx #include svtools/grfmgr.hxx -#include svx/graphctl.hxx -#include svx/dlgctrl.hxx -#include svx/rectenum.hxx #include svx/svxdllapi.h ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90502] CRASH - failed assertion in unittest sw_globalfilter in master build OSX (ImplLogicToPixel)
https://bugs.documentfoundation.org/show_bug.cgi?id=90502 --- Comment #17 from Caolán McNamara caol...@redhat.com --- Is this still a problem or is it fixed, I ask because the bt in bug 92573 is similar to this one -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: postprocess/qa sc/source sd/source sw/source
postprocess/qa/services.cxx | 11 +++
sc/source/ui/unoobj/docuno.cxx|5 -
sd/source/ui/unoidl/unomodel.cxx |9 ++---
sw/source/uibase/uno/unotxdoc.cxx | 13 -
4 files changed, 29 insertions(+), 9 deletions(-)
New commits:
commit 61a3be76c221c822b189d20e9269ec5caf1aadcc
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 13:44:06 2015 +0200
tdf#92668: Revert some implementation names, for backwards compatibility
These implementation names of Calc, Draw, Impress, and Writer documents are
the
most likely to be checked by existing third-party code, so revert the
corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 Fix various
XServiceInfo implementations (and instead add fixups in
CppunitTest_serives).
Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
diff --git a/postprocess/qa/services.cxx b/postprocess/qa/services.cxx
index ec26474..35e5b10 100644
--- a/postprocess/qa/services.cxx
+++ b/postprocess/qa/services.cxx
@@ -365,6 +365,17 @@ void Test::createInstance(
expImpl = com.sun.star.svtools.OfficeFolderPicker;
expServs = {com.sun.star.ui.dialogs.OfficeFolderPicker};
#endif
+} else if (expImpl == com.sun.star.comp.Calc.SpreadsheetDocument) {
+expImpl = ScModelObj;
+} else if (expImpl == com.sun.star.comp.Draw.DrawingDocument
+ || expImpl == com.sun.star.comp.Draw.PresentationDocument)
+{
+expImpl = SdXImpressDocument;
+} else if (expImpl == com.sun.star.comp.Writer.GlobalDocument
+ || expImpl == com.sun.star.comp.Writer.TextDocument
+ || expImpl == com.sun.star.comp.Writer.WebDocument)
+{
+expImpl = SwXTextDocument;
}
CPPUNIT_ASSERT_EQUAL_MESSAGE(
(OString(
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 27b72ee..a1bf527 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -2435,7 +2435,10 @@ uno::SequenceOUString SAL_CALL
ScModelObj::getAvailableServiceNames()
// XServiceInfo
OUString SAL_CALL ScModelObj::getImplementationName()
throw(uno::RuntimeException, std::exception)
{
-return OUString( com.sun.star.comp.Calc.SpreadsheetDocument );
+return OUString( ScModelObj );
+/* // Matching the .component information:
+ return OUString( com.sun.star.comp.Calc.SpreadsheetDocument );
+*/
}
sal_Bool SAL_CALL ScModelObj::supportsService( const OUString rServiceName )
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index 04c61c1..b67c321 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -1184,9 +1184,12 @@ uno::Sequence OUString SAL_CALL
SdXImpressDocument::getAvailableServiceNames(
OUString SAL_CALL SdXImpressDocument::getImplementationName()
throw(uno::RuntimeException, std::exception)
{
-return mbImpressDoc
-? OUString(com.sun.star.comp.Draw.PresentationDocument)
-: OUString(com.sun.star.comp.Draw.DrawingDocument);
+return OUString( SdXImpressDocument );
+/* // Matching the .component information:
+ return mbImpressDoc
+ ? OUString(com.sun.star.comp.Draw.PresentationDocument)
+ : OUString(com.sun.star.comp.Draw.DrawingDocument);
+*/
}
sal_Bool SAL_CALL SdXImpressDocument::supportsService( const OUString
ServiceName )
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index 9a31a3b..d453ad8 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1766,11 +1766,14 @@ Sequence OUString
SwXTextDocument::getAvailableServiceNames()
OUString SwXTextDocument::getImplementationName() throw( RuntimeException,
std::exception )
{
-return PTR_CAST(SwGlobalDocShell, pDocShell) != nullptr
-? OUString(com.sun.star.comp.Writer.GlobalDocument)
-: PTR_CAST(SwWebDocShell, pDocShell) != nullptr
-? OUString(com.sun.star.comp.Writer.WebDocument)
-: OUString(com.sun.star.comp.Writer.TextDocument);
+return OUString(SwXTextDocument);
+/* // Matching the .component information:
+ return PTR_CAST(SwGlobalDocShell, pDocShell) != nullptr
+ ? OUString(com.sun.star.comp.Writer.GlobalDocument)
+ : PTR_CAST(SwWebDocShell, pDocShell) != nullptr
+ ? OUString(com.sun.star.comp.Writer.WebDocument)
+ : OUString(com.sun.star.comp.Writer.TextDocument);
+*/
}
sal_Bool SwXTextDocument::supportsService(const OUString rServiceName) throw(
RuntimeException, std::exception )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |4 ++--
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit fe20502c86ef6156a54bb37ba2560c8b64d129a4
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:45:55 2015 +0100
emf: fix another hang
Change-Id: I971ba5f422827f3b8fcdb86c447fc48415225eca
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
new file mode 100644
index 000..e3baf3b
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index 62d7b5e..d8292ac 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1728,9 +1728,9 @@ bool EnhWMFReader::ReadHeader()
pWMF-ReadInt32(nRecordCount);
-if (nRecordCount == 0)
+if (nRecordCount = 0)
{
-SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
0! This shouldn't
+SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
= 0! This shouldn't
be possible... indicator of possible file
corruption?);
return false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92630] GTK+ auto-accelerator functionality missing
https://bugs.documentfoundation.org/show_bug.cgi?id=92630 --- Comment #6 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Eike Rathke committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=5a247505a36ccdb911e48f0d859572f56ec4b171 don't crash on Shift+F10, men can be null, tdf#92630 follow-up It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/source
vcl/source/window/menufloatingwindow.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 5a247505a36ccdb911e48f0d859572f56ec4b171
Author: Eike Rathke er...@redhat.com
Date: Mon Jul 13 11:33:27 2015 +0200
don't crash on Shift+F10, men can be null, tdf#92630 follow-up
... and actually make this work with a context menu..
Change-Id: I9a9bcdccae859cb2a54ec7db442435215e21e0e0
diff --git a/vcl/source/window/menufloatingwindow.cxx
b/vcl/source/window/menufloatingwindow.cxx
index 3fb24dd..a9fc9b4 100644
--- a/vcl/source/window/menufloatingwindow.cxx
+++ b/vcl/source/window/menufloatingwindow.cxx
@@ -1116,9 +1116,9 @@ void MenuFloatingWindow::KeyInput( const KeyEvent
rKEvent )
if (pData accel)
{
Menu *men = pMenu;
-while (!men-IsMenuBar())
+while (men !men-IsMenuBar())
men = men-pStartedFrom;
-bConsume =
(static_castMenuBarWindow*(men-pWindow.get()))-GetMBWMenuKey();
+bConsume = !men ||
(static_castMenuBarWindow*(men-pWindow.get()))-GetMBWMenuKey();
}
if (bConsume)
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #11 from Lionel Elie Mamane lio...@mamane.lu --- FWIW, the latest sources on github (of libformula) still have this bug. If we can localise a bugtracker... 't would be nice to give that upstream, too. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/source
vcl/source/gdi/jobset.cxx | 29 +
1 file changed, 17 insertions(+), 12 deletions(-)
New commits:
commit 81d1123ac317d9dad9872a9d2feda8cc6bd32492
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jan 26 11:26:41 2015 +
coverity#1266485 Untrusted value as argument
Change-Id: I7708ecaf5412535055584ed6c71beaa9cd71c10c
(cherry picked from commit 0934ed1a40c59c169354b177d7dab4228de66171)
min legal size here is 4
(cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3)
Change-Id: I9f68d000b32623db4d949d13284043630f5689f4
(cherry picked from commit 964000d415bcf491704dad57aee7e0656ea60dab)
Reviewed-on: https://gerrit.libreoffice.org/16983
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index ec1f44f..c67255e 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -218,19 +218,24 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
DBG_ASSERTWARNING( rIStream.GetVersion(), JobSetup:: - Solar-Version
not set on rOStream );
{
-sal_Size nFirstPos = rIStream.Tell();
-
sal_uInt16 nLen = 0;
rIStream.ReadUInt16( nLen );
-if ( !nLen )
+if (nLen = 4)
return rIStream;
sal_uInt16 nSystem = 0;
rIStream.ReadUInt16( nSystem );
-
-boost::scoped_arraychar pTempBuf(new char[nLen]);
-rIStream.Read( pTempBuf.get(), nLen - sizeof( nLen ) - sizeof(
nSystem ) );
-if ( nLen = sizeof(ImplOldJobSetupData)+4 )
+const size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem);
+if (nRead rIStream.remainingSize())
+{
+SAL_WARN(vcl, Parsing error: rIStream.remainingSize()
+ max possible entries, but nRead claimed,
truncating);
+return rIStream;
+}
+sal_Size nFirstPos = rIStream.Tell();
+boost::scoped_arraychar pTempBuf(new char[nRead]);
+rIStream.Read(pTempBuf.get(), nRead);
+if (nRead = sizeof(ImplOldJobSetupData))
{
ImplOldJobSetupData* pData = (ImplOldJobSetupData*)pTempBuf.get();
if ( rJobSetup.mpData )
@@ -255,7 +260,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
nSystem == JOBSET_FILE605_SYSTEM )
{
Impl364JobSetupData* pOldJobData=
(Impl364JobSetupData*)(pTempBuf.get() + sizeof( ImplOldJobSetupData ));
-sal_uInt16 nOldJobDataSize = SVBT16ToShort(
pOldJobData-nSize );
+sal_uInt16 nOldJobDataSize = SVBT16ToShort(
pOldJobData-nSize );
pJobData-mnSystem = SVBT16ToShort(
pOldJobData-nSystem );
pJobData-mnDriverDataLen = SVBT32ToUInt32(
pOldJobData-nDriverDataLen );
pJobData-meOrientation =
(Orientation)SVBT16ToShort( pOldJobData-nOrientation );
@@ -272,8 +277,8 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
}
if( nSystem == JOBSET_FILE605_SYSTEM )
{
-rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) +
4 + sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen );
-while( rIStream.Tell() nFirstPos + nLen )
+rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) +
sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen );
+while( rIStream.Tell() nFirstPos + nRead )
{
OUString aKey =
read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8);
OUString aValue =
read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8);
@@ -291,9 +296,9 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup
rJobSetup )
else
pJobData-maValueMap[ aKey ] = aValue;
}
-DBG_ASSERT( rIStream.Tell() == nFirstPos+nLen, corrupted
job setup );
+DBG_ASSERT( rIStream.Tell() == nFirstPos+nRead, corrupted
job setup );
// ensure correct stream position
-rIStream.Seek( nFirstPos + nLen );
+rIStream.Seek(nFirstPos + nRead);
}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bcf9f7c7e06ee97106b5a555a97599e6b0ed1c13
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:10:12 2015 +0100
emf: fix hang
Change-Id: I2410308ecccb8c5318a718bafadc7b40a98cb82b
(cherry picked from commit 8695633023cc321a095753db98bdc69d2aeee058)
Reviewed-on: https://gerrit.libreoffice.org/16976
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf
new file mode 100644
index 000..634fccd
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-1.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index f02871d..de78559 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -663,7 +663,7 @@ bool EnhWMFReader::ReadEnhWMF()
SAL_INFO(vcl.emf, \tGDI comment, length: length);
-if( pWMF-good() length = 4 ) {
+if( pWMF-good() length = 4 length = pWMF-remainingSize()
) {
sal_uInt32 id;
pWMF-ReadUInt32( id );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: xmloff/source
xmloff/source/style/xmlnumfe.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 5af8cf2e94a07821e9058ed7541b80dd6693 Author: Eike Rathke er...@redhat.com Date: Mon Jul 13 13:28:15 2015 +0200 use the DBL_MAX constant that we also use elsewhere, tdf#92457 Change-Id: Ibc48d12ca6b8eb33b2be29f485aa906c513f0591 diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx index d0da09b..700113e 100644 --- a/xmloff/source/style/xmlnumfe.cxx +++ b/xmloff/source/style/xmlnumfe.cxx @@ -1664,8 +1664,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const SvNumberformat rFormat, sal_uInt case NUMBERFORMAT_OP_LE: eOp3 = NUMBERFORMAT_OP_GT; break; case NUMBERFORMAT_OP_GT: eOp3 = NUMBERFORMAT_OP_LE; break; case NUMBERFORMAT_OP_GE: eOp3 = NUMBERFORMAT_OP_LT; break; -case NUMBERFORMAT_OP_NO: eOp3 = NUMBERFORMAT_OP_LE; - fLimit3 = ::std::numeric_limitsdouble::max(); break; +case NUMBERFORMAT_OP_NO: eOp3 = NUMBERFORMAT_OP_LE; fLimit3 = DBL_MAX; break; } if ( fLimit1 == fLimit2 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - include/xmloff xmloff/source
include/xmloff/xmltoken.hxx |4 ++--
xmloff/source/core/xmltoken.cxx |4 ++--
xmloff/source/style/xmlnumfe.cxx |8
xmloff/source/style/xmlnumfi.cxx | 12 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 818d9bb2d1c7db06402a8a1cb5ab378b81ddeecb
Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net
Date: Fri Jul 10 08:21:23 2015 +0200
tdf#90133 Comply attributes name with OASIS#3860
See https://issues.oasis-open.org/browse/OFFICE-3860
Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062
Reviewed-on: https://gerrit.libreoffice.org/16905
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
(cherry picked from commit 9c2a8065add0da1e649633efa0795beddfa68eed)
Reviewed-on: https://gerrit.libreoffice.org/17005
(cherry picked from commit 0149261bd1cf5df9907022e04cabc275fc9422f7)
Reviewed-on: https://gerrit.libreoffice.org/17006
Reviewed-by: Caolán McNamara caol...@redhat.com
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index bf6ad20..1eea8c1 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -3250,8 +3250,8 @@ namespace xmloff { namespace token {
XML_EXTERNALDATA,
XML_EXPONENT_INTERVAL,
-XML_EXPONENT_SIGN,
-XML_MIN_DECIMAL_DIGITS,
+XML_FORCED_EXPONENT_SIGN,
+XML_MIN_DECIMAL_PLACES,
XML_TOKEN_END
};
diff --git a/xmloff/source/core/xmltoken.cxx b/xmloff/source/core/xmltoken.cxx
index 5e1dd51..63e4aff 100644
--- a/xmloff/source/core/xmltoken.cxx
+++ b/xmloff/source/core/xmltoken.cxx
@@ -3248,8 +3248,8 @@ namespace xmloff { namespace token {
TOKEN( external-data, XML_EXTERNALDATA),
TOKEN( exponent-interval, XML_EXPONENT_INTERVAL ),
-TOKEN( exponent-sign, XML_EXPONENT_SIGN ),
-TOKEN( min-decimal-digits, XML_MIN_DECIMAL_DIGITS ),
+TOKEN( forced-exponent-sign,XML_FORCED_EXPONENT_SIGN ),
+TOKEN( min-decimal-places, XML_MIN_DECIMAL_PLACES ),
#if OSL_DEBUG_LEVEL 0
{ 0, NULL, NULL, XML_TOKEN_END }
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 6b7142f..6c9d360 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -572,7 +572,7 @@ void SvXMLNumFmtExport::WriteNumberElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -653,7 +653,7 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -694,11 +694,11 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
// exponent sign
if ( bExpSign )
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_TRUE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_TRUE );
}
else
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_FALSE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_FALSE );
}
SvXMLElementExport aElem( rExport,
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index a422b25..cbafde7 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -274,7 +274,7 @@ enum SvXMLStyleAttrTokens
enum SvXMLStyleElemAttrTokens
{
XML_TOK_ELEM_ATTR_DECIMAL_PLACES,
-XML_TOK_ELEM_ATTR_MIN_DECIMAL_DIGITS,
+XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_MIN_INTEGER_DIGITS,
XML_TOK_ELEM_ATTR_GROUPING,
XML_TOK_ELEM_ATTR_DISPLAY_FACTOR,
@@ -282,7 +282,7 @@ enum SvXMLStyleElemAttrTokens
XML_TOK_ELEM_ATTR_DENOMINATOR_VALUE,
XML_TOK_ELEM_ATTR_MIN_EXPONENT_DIGITS,
XML_TOK_ELEM_ATTR_EXPONENT_INTERVAL,
-XML_TOK_ELEM_ATTR_EXPONENT_SIGN,
+XML_TOK_ELEM_ATTR_FORCED_EXPONENT_SIGN,
XML_TOK_ELEM_ATTR_MIN_NUMERATOR_DIGITS,
XML_TOK_ELEM_ATTR_MIN_DENOMINATOR_DIGITS,
XML_TOK_ELEM_ATTR_RFC_LANGUAGE_TAG,
@@ -572,7 +572,7 @@ const SvXMLTokenMap
SvXMLNumImpData::GetStyleElemAttrTokenMap()
{
// attributes for an element within a style
{ XML_NAMESPACE_NUMBER, XML_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_DECIMAL_PLACES },
-
[Libreoffice-bugs] [Bug 67832] upgrade our jfreereport libraries
https://bugs.documentfoundation.org/show_bug.cgi?id=67832 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||693 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=67 ||832 --- Comment #4 from Julien Nabet serval2...@yahoo.fr --- Lionel: I tried to apply this https://wiki.documentfoundation.org/Development/Patching_External_Libraries but it failed. (what's target, what's module for jfreereport?) The few times I made a patch for an external lib, it was after several tries and I had only succeeded by chance. This time, it doesn't work. If you know a better way/url which always works, just tell me! :-) BTW, I put tdf#67832 since perhaps an upgrade of this lib may already fix this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 67832] upgrade our jfreereport libraries
https://bugs.documentfoundation.org/show_bug.cgi?id=67832 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||693 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #7 from Lionel Elie Mamane lio...@mamane.lu --- Sorry, module external/jfreereport The error is probably because you have --with-system(-jfreereport) Then, do the make commands from the toplevel, it should automatically download the tarballs. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 75662] All of LibO 4.x hangs if Base is running when switching between video console and RDP session
https://bugs.documentfoundation.org/show_bug.cgi?id=75662 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||ba...@quipo.it Summary|All of LibreOffice 4.x |All of LibO 4.x hangs if |hangs if LibreOffice Base |Base is running when |4.x is running when |switching between video |switching between video |console and RDP session |console and RDP session | Ever confirmed|0 |1 --- Comment #10 from tommy27 ba...@quipo.it --- try LibreOffice 4.4 a portable release is available here: http://www.winpenpack.com/main/download.php?view.1354 so you don't have to uninstall the 4.3.5 version. if the portable 4.4 works fine you may consider to upgrade to the standard install version please give feedback if this fixes things status NEEDINFO until then -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Multiselection needs work?
On 13/07/2015 10:44, Michael Meeks wrote: Hi Julien, On Sun, 2015-07-12 at 01:02 +0200, Julien Nabet wrote: Here's a patch: https://gerrit.libreoffice.org/#/c/16959/ I truncated to 1 file in KDE part + Vista part. Heh =) I worry though that the implementation of the KDE Vista bits is doing this over-complicated foo - wrt. storing the directory URL in the first item, and then relative file-names in the next items, so by truncating it to 1x long we end up with just the directory-URL not the first file that was selected =) I'd hope we could rip some complexity out of the implementations there. For kde4, it seems ok, see http://opengrok.libreoffice.org/xref/core/vcl/unx/kde4/KDE4FilePicker.cxx#337 but KDE4FilePicker::getSelectedFiles(), some lines bellow, uses getFiles! So it'll quickly need some fix, I thought about a copy paste of the original version of getFiles. In this case perhaps getFiles should use getSelectedFiles() then truncate? For kde, it seems there are 2 implementations: - http://opengrok.libreoffice.org/xref/core/vcl/unx/kde/fpicker/kdefilepicker.cxx#322 - http://opengrok.libreoffice.org/xref/core/vcl/unx/kde/UnxCommandThread.cxx#103 a bit confused here, should I blindly the same logic? aqua: it seems you were right yo be worried http://opengrok.libreoffice.org/xref/core/fpicker/source/aqua/SalAquaFilePicker.mm#304 I submitted a patch to review (blindly because building on Mac still fails for me, see https://bugs.documentfoundation.org/show_bug.cgi?id=90502 ), see fpicker/source/aqua/SalAquaFilePicker.mm Windows world: CNonExecuteFilePickerState::getFiles (http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/filepickerstate.cxx#226) CExecuteFilePickerState::getFiles (http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/filepickerstate.cxx#510) I could apply the same logic. + already indicated http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/VistaFilePicker.cxx#255 and already dealt with this patch http://cgit.freedesktop.org/libreoffice/core/diff/fpicker/source/win32/filepicker/VistaFilePicker.cxx?id=d11b244bf9b9115f5384d6ff43bdffc7f1289d71 There are also wrappers like: http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/WinFileOpenImpl.cxx#172 http://opengrok.libreoffice.org/xref/core/fpicker/source/win32/filepicker/FilePicker.cxx#365 Perhaps just a comment there should be sufficient. Others: http://opengrok.libreoffice.org/xref/core/desktop/source/migration/services/basicmigration.cxx#73 http://opengrok.libreoffice.org/xref/core/desktop/source/migration/services/wordbookmigration.cxx#93 officefilepicker: http://opengrok.libreoffice.org/xref/core/fpicker/source/office/OfficeFilePicker.cxx#589 what's this? If it's really used, it should be indeed patched. Hope I spotted them all. May we suppose too that one of them is used for macro Basic language since it seems public API? I'd also suggest killing the comment about multi-selection in the UNO IDL and saying something of the form: This always, only ever returns the first selected file URL or somesuch (?) =) Here's the patch waiting for review: https://gerrit.libreoffice.org/16985 Julien ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0-0' - sw/source
sw/source/filter/ww8/ww8scan.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit b59f8b33f44d834ac6c946f4524a106f09eb8364
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 10:31:30 2015 +0100
ww8: make sure we don't wrap around
Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2
(cherry picked from commit 755b9320c81948358a1d4104c8875594b5700d39)
(cherry picked from commit cd3e5ddeb4100bab2a39cf9913e14eb371edbbcc)
Reviewed-on: https://gerrit.libreoffice.org/16994
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 0446bfc..c97db22 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1542,7 +1542,11 @@ WW8PLCFpcd* WW8ScannerBase::OpenPieceTable( SvStream*
pStr, const WW8Fib* pWwF )
if( 2 == clxt ) // PLCFfpcd ?
break; // PLCFfpcd gefunden
if( 1 == clxt ) // clxtGrpprl ?
+{
+if (nGrpprl == SHRT_MAX)
+return NULL;
nGrpprl++;
+}
sal_uInt16 nLen(0);
pStr-ReadUInt16( nLen );
nLeft -= 2 + nLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/srcedtw.cxx | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
New commits:
commit 59f58350e49068b78f8a7426bfc08ee4d722b4b4
Author: Arnaud Versini arnaud.vers...@gmail.com
Date: Sat Jul 11 15:26:41 2015 +0200
swui: avoid name conflict with SwTextPortion for LTO optimisation
Change-Id: Iaf6fec2e19af2cf393bc547c3ba439010819238f
Reviewed-on: https://gerrit.libreoffice.org/16949
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/sw/source/uibase/docvw/srcedtw.cxx
b/sw/source/uibase/docvw/srcedtw.cxx
index 98bea25..b67fb36 100644
--- a/sw/source/uibase/docvw/srcedtw.cxx
+++ b/sw/source/uibase/docvw/srcedtw.cxx
@@ -47,19 +47,24 @@
#include helpid.h
#include deque
-struct SwTextPortion
+namespace
+{
+
+struct TextPortion
{
sal_uInt16 nLine;
sal_uInt16 nStart, nEnd;
svtools::ColorConfigEntry eType;
};
+}
+
#define MAX_SYNTAX_HIGHLIGHT 20
#define MAX_HIGHLIGHTTIME 200
-typedef std::dequeSwTextPortion SwTextPortions;
+typedef std::dequeTextPortion TextPortions;
-static void lcl_Highlight(const OUString rSource, SwTextPortions
aPortionList)
+static void lcl_Highlight(const OUString rSource, TextPortions aPortionList)
{
const sal_Unicode cOpenBracket = '';
const sal_Unicode cCloseBracket= '';
@@ -77,7 +82,7 @@ static void lcl_Highlight(const OUString rSource,
SwTextPortions aPortionList)
sal_uInt16 nOffset = 0; // Offset of nActPos to ''
sal_uInt16 nPortStart = USHRT_MAX; // for the TextPortion
sal_uInt16 nPortEnd = 0;
-SwTextPortion aText;
+TextPortion aText;
while(nActPos nStrLen)
{
svtools::ColorConfigEntry eFoundType = svtools::HTMLUNKNOWN;
@@ -179,7 +184,7 @@ static void lcl_Highlight(const OUString rSource,
SwTextPortions aPortionList)
if(bFound ||(eFoundType == svtools::HTMLCOMMENT))
{
-SwTextPortion aTextPortion;
+TextPortion aTextPortion;
aTextPortion.nLine = 0;
aTextPortion.nStart = nPortStart + 1;
aTextPortion.nEnd = nPortEnd;
@@ -679,14 +684,14 @@ void SwSrcEditWindow::DoDelayedSyntaxHighlight(
sal_uInt16 nPara )
void SwSrcEditWindow::ImpDoHighlight( const OUString rSource, sal_uInt16
nLineOff )
{
-SwTextPortions aPortionList;
+TextPortions aPortionList;
lcl_Highlight(rSource, aPortionList);
size_t nCount = aPortionList.size();
if ( !nCount )
return;
-SwTextPortion rLast = aPortionList[nCount-1];
+TextPortion rLast = aPortionList[nCount-1];
if ( rLast.nStart rLast.nEnd )// Only until Bug from MD is resolved
{
nCount--;
@@ -703,7 +708,7 @@ void SwSrcEditWindow::ImpDoHighlight( const OUString
rSource, sal_uInt16 nLineO
for ( size_t i = 0; i nCount; i++ )
{
-SwTextPortion r = aPortionList[i];
+TextPortion r = aPortionList[i];
SAL_WARN_IF(
r.nLine != aPortionList[0].nLine, sw.level2,
multiple lines after all?);
@@ -724,7 +729,7 @@ void SwSrcEditWindow::ImpDoHighlight( const OUString
rSource, sal_uInt16 nLineO
for ( size_t i = 0; i aPortionList.size(); i++ )
{
-SwTextPortion r = aPortionList[i];
+TextPortion r = aPortionList[i];
if ( r.nStart r.nEnd )// only until Bug from MD is resolved
continue;
if(r.eType != svtools::HTMLSGML
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - include/xmloff xmloff/source
include/xmloff/xmltoken.hxx |4 ++--
xmloff/source/core/xmltoken.cxx |4 ++--
xmloff/source/style/xmlnumfe.cxx |8
xmloff/source/style/xmlnumfi.cxx | 12 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 0149261bd1cf5df9907022e04cabc275fc9422f7
Author: Laurent Balland-Poirier laurent.balland-poir...@laposte.net
Date: Fri Jul 10 08:21:23 2015 +0200
tdf#90133 Comply attributes name with OASIS#3860
See https://issues.oasis-open.org/browse/OFFICE-3860
Change-Id: I707b2e86633bc66df03dba8c43879aa6d5153062
Reviewed-on: https://gerrit.libreoffice.org/16905
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
(cherry picked from commit 9c2a8065add0da1e649633efa0795beddfa68eed)
Reviewed-on: https://gerrit.libreoffice.org/17005
diff --git a/include/xmloff/xmltoken.hxx b/include/xmloff/xmltoken.hxx
index bf6ad20..1eea8c1 100644
--- a/include/xmloff/xmltoken.hxx
+++ b/include/xmloff/xmltoken.hxx
@@ -3250,8 +3250,8 @@ namespace xmloff { namespace token {
XML_EXTERNALDATA,
XML_EXPONENT_INTERVAL,
-XML_EXPONENT_SIGN,
-XML_MIN_DECIMAL_DIGITS,
+XML_FORCED_EXPONENT_SIGN,
+XML_MIN_DECIMAL_PLACES,
XML_TOKEN_END
};
diff --git a/xmloff/source/core/xmltoken.cxx b/xmloff/source/core/xmltoken.cxx
index 5e1dd51..63e4aff 100644
--- a/xmloff/source/core/xmltoken.cxx
+++ b/xmloff/source/core/xmltoken.cxx
@@ -3248,8 +3248,8 @@ namespace xmloff { namespace token {
TOKEN( external-data, XML_EXTERNALDATA),
TOKEN( exponent-interval, XML_EXPONENT_INTERVAL ),
-TOKEN( exponent-sign, XML_EXPONENT_SIGN ),
-TOKEN( min-decimal-digits, XML_MIN_DECIMAL_DIGITS ),
+TOKEN( forced-exponent-sign,XML_FORCED_EXPONENT_SIGN ),
+TOKEN( min-decimal-places, XML_MIN_DECIMAL_PLACES ),
#if OSL_DEBUG_LEVEL 0
{ 0, NULL, NULL, XML_TOKEN_END }
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 6b7142f..6c9d360 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -572,7 +572,7 @@ void SvXMLNumFmtExport::WriteNumberElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -653,7 +653,7 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
if ( nMinDecimals = 0 ) // negative = automatic
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
OUString::number( nMinDecimals ) );
}
@@ -694,11 +694,11 @@ void SvXMLNumFmtExport::WriteScientificElement_Impl(
// exponent sign
if ( bExpSign )
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_TRUE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_TRUE );
}
else
{
-rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_EXPONENT_SIGN,
XML_FALSE );
+rExport.AddAttribute( XML_NAMESPACE_LO_EXT, XML_FORCED_EXPONENT_SIGN,
XML_FALSE );
}
SvXMLElementExport aElem( rExport,
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index 5b8ad3f..e9e25f4 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -274,7 +274,7 @@ enum SvXMLStyleAttrTokens
enum SvXMLStyleElemAttrTokens
{
XML_TOK_ELEM_ATTR_DECIMAL_PLACES,
-XML_TOK_ELEM_ATTR_MIN_DECIMAL_DIGITS,
+XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_MIN_INTEGER_DIGITS,
XML_TOK_ELEM_ATTR_GROUPING,
XML_TOK_ELEM_ATTR_DISPLAY_FACTOR,
@@ -282,7 +282,7 @@ enum SvXMLStyleElemAttrTokens
XML_TOK_ELEM_ATTR_DENOMINATOR_VALUE,
XML_TOK_ELEM_ATTR_MIN_EXPONENT_DIGITS,
XML_TOK_ELEM_ATTR_EXPONENT_INTERVAL,
-XML_TOK_ELEM_ATTR_EXPONENT_SIGN,
+XML_TOK_ELEM_ATTR_FORCED_EXPONENT_SIGN,
XML_TOK_ELEM_ATTR_MIN_NUMERATOR_DIGITS,
XML_TOK_ELEM_ATTR_MIN_DENOMINATOR_DIGITS,
XML_TOK_ELEM_ATTR_RFC_LANGUAGE_TAG,
@@ -572,7 +572,7 @@ const SvXMLTokenMap
SvXMLNumImpData::GetStyleElemAttrTokenMap()
{
// attributes for an element within a style
{ XML_NAMESPACE_NUMBER, XML_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_DECIMAL_PLACES },
-{ XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_DIGITS,
XML_TOK_ELEM_ATTR_MIN_DECIMAL_DIGITS },
+{ XML_NAMESPACE_LO_EXT, XML_MIN_DECIMAL_PLACES,
XML_TOK_ELEM_ATTR_MIN_DECIMAL_PLACES },
{
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf |binary
vcl/source/filter/wmf/winmtf.cxx | 26 +
2 files changed, 15 insertions(+), 11 deletions(-)
New commits:
commit 1eb5b896c366e270d5a09918b9f857ee90b37ad7
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 08:33:50 2015 +0100
emf: test for empty polygons
Change-Id: I3c8896230e3d48a37f4b8d702b0f673e44f45ba4
(cherry picked from commit 7df4d8544c6b12e31bcb81d9389d03ae7c11bfea)
Reviewed-on: https://gerrit.libreoffice.org/16973
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf
new file mode 100644
index 000..6adabec
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf differ
diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx
index f14f934..20e2b5c 100644
--- a/vcl/source/filter/wmf/winmtf.cxx
+++ b/vcl/source/filter/wmf/winmtf.cxx
@@ -1294,18 +1294,22 @@ void WinMtfOutput::DrawPolyLine( Polygon rPolygon,
bool bTo, bool bRecordPath )
{
UpdateClipRegion();
-ImplMap( rPolygon );
-if ( bTo )
-{
-rPolygon[ 0 ] = maActPos;
-maActPos = rPolygon[ rPolygon.GetSize() - 1 ];
-}
-if ( bRecordPath )
-aPathObj.AddPolyLine( rPolygon );
-else
+sal_uInt16 nPoints = rPolygon.GetSize();
+if (nPoints = 1)
{
-UpdateLineStyle();
-mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon,
maLineStyle.aLineInfo ) );
+ImplMap( rPolygon );
+if ( bTo )
+{
+rPolygon[ 0 ] = maActPos;
+maActPos = rPolygon[ rPolygon.GetSize() - 1 ];
+}
+if ( bRecordPath )
+aPathObj.AddPolyLine( rPolygon );
+else
+{
+UpdateLineStyle();
+mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon,
maLineStyle.aLineInfo ) );
+}
}
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: compilerplugins/clang include/vcl vcl/inc vcl/source
compilerplugins/clang/unusedmethods.cxx |1
compilerplugins/clang/unusedmethods.py |1
include/vcl/builder.hxx | 10 -
include/vcl/ctrl.hxx|1
include/vcl/field.hxx |8 ---
include/vcl/fixedhyper.hxx |7 --
include/vcl/i18nhelp.hxx|1
include/vcl/image.hxx |5
include/vcl/menu.hxx|1
include/vcl/menubtn.hxx |3 --
include/vcl/msgbox.hxx |4 ---
include/vcl/print.hxx | 22 +
include/vcl/rendersettings.hxx |2 -
include/vcl/scrbar.hxx |1
include/vcl/seleng.hxx |1
include/vcl/slider.hxx |9
include/vcl/spinfld.hxx |3 --
include/vcl/split.hxx |7 --
include/vcl/splitwin.hxx| 33 +---
include/vcl/status.hxx | 12 ---
include/vcl/tabctrl.hxx |4 ---
include/vcl/toolbox.hxx |1
vcl/inc/displayconnectiondispatch.hxx |2 -
vcl/inc/printdlg.hxx|2 -
vcl/inc/xconnection.hxx |1
vcl/source/control/ctrl.cxx |5
vcl/source/gdi/print.cxx|5
vcl/source/helper/xconnection.cxx | 19 --
vcl/source/outdev/rendersettings.cxx| 12 ---
vcl/source/window/scrwnd.hxx|1
30 files changed, 14 insertions(+), 170 deletions(-)
New commits:
commit a6fed7a19befa5673403ec5fe3ab69a91475da3a
Author: Noel Grandin n...@peralex.com
Date: Mon Jul 13 09:55:03 2015 +0200
loplugin:unusedmethods vcl
Change-Id: I53c66b7898f4e0a66e6172d22c6f782dadaf6589
Reviewed-on: https://gerrit.libreoffice.org/16975
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Noel Grandin noelgran...@gmail.com
diff --git a/compilerplugins/clang/unusedmethods.cxx
b/compilerplugins/clang/unusedmethods.cxx
index 2868334..655dfe2 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -40,6 +40,7 @@ TODO need to handle places where the code takes the address
of a method, that ne
as a use-site.
TODO deal with free functions and static methods
TODO track instantiations of template class constructor methods
+TODO track instantiation of overridden methods when a template class is
instantiated
*/
namespace {
diff --git a/compilerplugins/clang/unusedmethods.py
b/compilerplugins/clang/unusedmethods.py
index 05e38b6..ef2beb9 100755
--- a/compilerplugins/clang/unusedmethods.py
+++ b/compilerplugins/clang/unusedmethods.py
@@ -29,6 +29,7 @@ exclusionSet = set([
void comphelper::IEventProcessor::release(),
void SotMutexHolder::acquire(),
void SotMutexHolder::release(),
+class Rectangle ComboBox::GetDropDownPosSizePixel() const
# only used by Windows build
_Bool basegfx::B2ITuple::equalZero() const,
class basegfx::B2DPolyPolygon
basegfx::unotools::UnoPolyPolygon::getPolyPolygonUnsafe() const,
diff --git a/include/vcl/builder.hxx b/include/vcl/builder.hxx
index baf523d..26b5d8c 100644
--- a/include/vcl/builder.hxx
+++ b/include/vcl/builder.hxx
@@ -70,8 +70,6 @@ public:
vcl::Window*get_widget_root();
-PopupMenu* get_menu(PopupMenu* ret, const OString sID);
-
//sID may not exist
PopupMenu* get_menu(const OString sID);
@@ -432,13 +430,7 @@ inline T* VclBuilder::get(const OString sID)
return static_castT*(w);
}
-inline PopupMenu* VclBuilder::get_menu(PopupMenu* ret, const OString sID)
-{
-ret = get_menu(sID);
-SAL_WARN_IF(!ret, vcl.layout, menu \ sID.getStr() \ not found
in .ui);
-assert(ret);
-return ret;
-}
+
//helper baseclass to ease retro fitting dialogs/tabpages that load a resource
//to load a .ui file instead
diff --git a/include/vcl/ctrl.hxx b/include/vcl/ctrl.hxx
index 038d445..d33982b 100644
--- a/include/vcl/ctrl.hxx
+++ b/include/vcl/ctrl.hxx
@@ -185,7 +185,6 @@ public:
vcl::Font GetUnzoomedControlPointFont() const;
voidSetShowAccelerator (bool val);
-boolGetShowAccelerator (void) const;
};
#endif // INCLUDED_VCL_CTRL_HXX
diff --git a/include/vcl/field.hxx b/include/vcl/field.hxx
index dc461b7..fdb09f1 100644
--- a/include/vcl/field.hxx
+++ b/include/vcl/field.hxx
@@ -83,7 +83,6 @@ public:
const AllSettings GetFieldSettings() const;
-voidSetErrorHdl( const Link rLink ) { maErrorLink
= rLink; }
const Link GetErrorHdl() const { return
maErrorLink; }
voidSetEmptyFieldValue();
@@ -127,12 +126,10 @@ public:
const OString GetEditMask() const { return m_aEditMask; }
const OUString
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 Manfred trolli...@t-online.de changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 --- Comment #4 from Manfred trolli...@t-online.de --- Hi Alex, I send you the Spreadsheet as a personal message. Please do not upload it. Just open it and change any date in sheet Kasse in column C after line 30. Format has to be german: 15.7. (There is a validity inside.) After installing 4.4.4.3 it need lots of seconds at the first time I change the date. The next go faster. But if I change to a different file and go back to this one, the first entry lasts very long again. But as I wrote, maybe I destroyed something by emptying the last years sheet? Could this be a problem with any cache? Greetings from Germany Manfred -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - xmloff/source
xmloff/source/style/xmlnumfi.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit cdb2d6aa33a409994c3033cf621847d1552ce8cd
Author: Eike Rathke er...@redhat.com
Date: Fri Jul 10 23:20:28 2015 +0200
the last condition is all other numbers, not the third, tdf#92457 related
(cherry picked from commit b3c11e2b3ef4bad8c2b5f92ba00ac805fb68786f)
So we'll properly strip the value()lt;=1.79769313486232E+308
condition that 5.1 will write.
This will not enable the handling of the style, but at least it is fed
correctly as intended to the number formatter.
Change-Id: Ic9571d938c4a8837c5712bafbfb2ebf9f32011df
Reviewed-on: https://gerrit.libreoffice.org/16990
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index 6c84c5a..99b030d 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -2060,10 +2060,10 @@ void SvXMLNumFormatContext::AddCondition( const
sal_Int32 nIndex )
if ( aConditions.isEmpty() aMyConditions.size() == 1
sRealCond.equalsAscii( =0 ) )
bDefaultCond = true;
-if ( nType == XML_TOK_STYLES_TEXT_STYLE nIndex == 2 )
+if ( nType == XML_TOK_STYLES_TEXT_STYLE static_castsize_t(nIndex)
== aMyConditions.size() - 1 )
{
-// The third condition in a number format with a text part can
only be
-// all other numbers, the condition string must be empty.
+// The last condition in a number format with a text part can only
+// be all other numbers, the condition string must be empty.
bDefaultCond = true;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - xmloff/source
xmloff/source/style/xmlnumfi.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 9d23401109f93fcff37f35f708af7ec33e690ed4
Author: Eike Rathke er...@redhat.com
Date: Fri Jul 10 23:20:28 2015 +0200
the last condition is all other numbers, not the third, tdf#92457 related
(cherry picked from commit b3c11e2b3ef4bad8c2b5f92ba00ac805fb68786f)
So we'll properly strip the value()lt;=1.79769313486232E+308
condition that 5.1 will write.
This will not enable the handling of the style, but at least it is fed
correctly as intended to the number formatter.
Change-Id: Ic9571d938c4a8837c5712bafbfb2ebf9f32011df
Reviewed-on: https://gerrit.libreoffice.org/16988
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index a422b25..5b8ad3f 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -2129,10 +2129,10 @@ void SvXMLNumFormatContext::AddCondition( const
sal_Int32 nIndex )
if ( aConditions.isEmpty() aMyConditions.size() == 1 sRealCond
== =0 )
bDefaultCond = true;
-if ( nType == XML_TOK_STYLES_TEXT_STYLE nIndex == 2 )
+if ( nType == XML_TOK_STYLES_TEXT_STYLE static_castsize_t(nIndex)
== aMyConditions.size() - 1 )
{
-// The third condition in a number format with a text part can
only be
-// all other numbers, the condition string must be empty.
+// The last condition in a number format with a text part can only
+// be all other numbers, the condition string must be empty.
bDefaultCond = true;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configmgr/qa configmgr/source
configmgr/qa/unit/test.cxx |5 +++--
configmgr/source/access.cxx | 12 ++--
2 files changed, 9 insertions(+), 8 deletions(-)
New commits:
commit e80df0d58ba32e3041ff9c8cdea9c617ea7e633b
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 14:07:38 2015 +0200
tdf#92639: Slashes are allowed in set member names, of course
Change-Id: I30944fe9611e83566c891a7d1461ad02979daddd
diff --git a/configmgr/qa/unit/test.cxx b/configmgr/qa/unit/test.cxx
index 544a808..a9f609b 100644
--- a/configmgr/qa/unit/test.cxx
+++ b/configmgr/qa/unit/test.cxx
@@ -315,8 +315,9 @@ void Test::testInsertSetMember() {
} catch (css::lang::IllegalArgumentException ) {}
try {
access-insertByName(a/b, css::uno::makeAny(member));
-CPPUNIT_FAIL(expected IllegalArgumentException);
-} catch (css::lang::IllegalArgumentException ) {}
+} catch (css::lang::IllegalArgumentException ) {
+CPPUNIT_FAIL(unexpected IllegalArgumentException);
+}
css::uno::Referencecss::util::XChangesBatch(
access, css::uno::UNO_QUERY_THROW)-commitChanges();
css::uno::Referencecss::lang::XComponent(
diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index b8fadbc..fa2930a 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -109,12 +109,12 @@ namespace {
// Conservatively forbid what is either not an XML Char (including lone
// surrogates, even though they should not appear in well-formed UNO OUString
// instances anyway), or is a slash (as it causes problems in path syntax):
-bool isValidName(OUString const name) {
+bool isValidName(OUString const name, bool setMember) {
for (sal_Int32 i = 0; i != name.getLength();) {
sal_uInt32 c = name.iterateCodePoints(i);
if ((c 0x20 !(c == 0x09 || c == 0x0A || c == 0x0D))
|| rtl::isHighSurrogate(c) || rtl::isLowSurrogate(c) || c == 0xFFFE
-|| c == 0x || c == '/')
+|| c == 0x || (!setMember c == '/'))
{
return false;
}
@@ -669,7 +669,7 @@ void Access::setName(OUString const aName)
if (node-getMandatory() == Data::NO_LAYER
!(other.is() other-isFinalized()))
{
-if (!isValidName(aName)) {
+if (!isValidName(aName, true)) {
throw css::uno::RuntimeException(
invalid element name + aName);
}
@@ -1188,7 +1188,7 @@ void Access::insertByName(
Modifications localMods;
switch (getNode()-kind()) {
case Node::KIND_LOCALIZED_PROPERTY:
-if (!isValidName(aName)) {
+if (!isValidName(aName, false)) {
throw css::lang::IllegalArgumentException(
aName, static_castcppu::OWeakObject *(this), 0);
}
@@ -1196,7 +1196,7 @@ void Access::insertByName(
break;
case Node::KIND_GROUP:
{
-if (!isValidName(aName)) {
+if (!isValidName(aName, false)) {
throw css::lang::IllegalArgumentException(
aName, static_castcppu::OWeakObject *(this), 0);
}
@@ -1212,7 +1212,7 @@ void Access::insertByName(
break;
case Node::KIND_SET:
{
-if (!isValidName(aName)) {
+if (!isValidName(aName, true)) {
throw css::lang::IllegalArgumentException(
aName, static_castcppu::OWeakObject *(this), 0);
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/printdlg.hxx |3 --- 1 file changed, 3 deletions(-) New commits: commit a5db487caaf026e648b34d0fab58376230c1cc47 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jul 13 14:22:51 2015 +0200 -Werror,-Wunused-private-field Change-Id: I35749d468d126084a518bcd423f8a081c7382d80 diff --git a/vcl/inc/printdlg.hxx b/vcl/inc/printdlg.hxx index a82dcdc..1f4f555 100644 --- a/vcl/inc/printdlg.hxx +++ b/vcl/inc/printdlg.hxx @@ -219,9 +219,6 @@ namespace vcl OUString maPrintText; OUString maDefPrtText; -SizemaDetailsCollapsedSize; -SizemaDetailsExpandedSize; - boolmbShowLayoutPage; Size getJobPageSize(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: connectivity/source
connectivity/source/drivers/ado/AColumn.cxx| 14 --
connectivity/source/drivers/ado/AColumns.cxx | 14 --
connectivity/source/drivers/ado/AConnection.cxx| 14 +-
connectivity/source/drivers/hsqldb/HDriver.cxx | 16 ++--
connectivity/source/drivers/hsqldb/HStorageMap.cxx | 18 ++
connectivity/source/drivers/odbc/OResultSet.cxx|4 +++-
6 files changed, 36 insertions(+), 44 deletions(-)
New commits:
commit 6e7c923d632c757c9a38a724cad2d55a84755570
Author: Jorenz Paragas j.paragas@gmail.com
Date: Fri Jul 10 21:07:51 2015 -0700
tdf#91112 replace o3tl::compose1 with lambdas in connectivity
Change-Id: I8f61471e08fe7f620d76bdcd72eb7f5c35931388
Reviewed-on: https://gerrit.libreoffice.org/16940
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: Michael Stahl mst...@redhat.com
diff --git a/connectivity/source/drivers/ado/AColumn.cxx
b/connectivity/source/drivers/ado/AColumn.cxx
index 7a9769f..81e18c5 100644
--- a/connectivity/source/drivers/ado/AColumn.cxx
+++ b/connectivity/source/drivers/ado/AColumn.cxx
@@ -215,16 +215,10 @@ void OAdoColumn::fillPropertyValues()
else if ( eType == adVarBinary
ADOS::isJetEngine(m_pConnection-getEngineType()) )
{
::comphelper::UStringMixEqual aCase(sal_False);
-OTypeInfoMap::const_iterator aFind =
::std::find_if(pTypeInfoMap-begin(),
-
pTypeInfoMap-end(),
-::o3tl::compose1(
-
::std::bind2nd(aCase, OUString(VarBinary)),
-
::o3tl::compose1(
-
::std::mem_fun(OExtendedTypeInfo::getDBName),
-
::o3tl::select2ndOTypeInfoMap::value_type())
-)
-
-);
+OTypeInfoMap::const_iterator aFind =
::std::find_if(pTypeInfoMap-begin(), pTypeInfoMap-end(),
+[aCase] (OTypeInfoMap::value_type typeInfo) {
+return aCase(typeInfo.second-getDBName(),
OUString(VarBinary));
+});
if ( aFind != pTypeInfoMap-end() ) // change column type if
necessary
{
diff --git a/connectivity/source/drivers/ado/AColumns.cxx
b/connectivity/source/drivers/ado/AColumns.cxx
index 936510f1..66af0bc 100644
--- a/connectivity/source/drivers/ado/AColumns.cxx
+++ b/connectivity/source/drivers/ado/AColumns.cxx
@@ -88,16 +88,10 @@ sdbcx::ObjectType OColumns::appendObject( const OUString,
const Reference XPro
const OTypeInfoMap* pTypeInfoMap = m_pConnection-getTypeInfo();
::comphelper::UStringMixEqual aCase(sal_False);
// search for typeinfo where the typename is equal sTypeName
-OTypeInfoMap::const_iterator aFind = ::std::find_if(pTypeInfoMap-begin(),
-pTypeInfoMap-end(),
-::o3tl::compose1(
-
::std::bind2nd(aCase, sTypeName),
-::o3tl::compose1(
-
::std::mem_fun(OExtendedTypeInfo::getDBName),
-
::o3tl::select2ndOTypeInfoMap::value_type())
-)
-
-);
+OTypeInfoMap::const_iterator aFind = ::std::find_if(pTypeInfoMap-begin(),
pTypeInfoMap-end(),
+[aCase, sTypeName] (OTypeInfoMap::value_type typeInfo) {
+return aCase(typeInfo.second-getDBName(), sTypeName);
+});
if ( aFind != pTypeInfoMap-end() ) // change column type if necessary
aColumn.put_Type(aFind-first);
diff --git a/connectivity/source/drivers/ado/AConnection.cxx
b/connectivity/source/drivers/ado/AConnection.cxx
index 319bc68..463db7f 100644
--- a/connectivity/source/drivers/ado/AConnection.cxx
+++ b/connectivity/source/drivers/ado/AConnection.cxx
@@ -598,15 +598,11 @@ const OExtendedTypeInfo*
OConnection::getTypeInfoFromType(const OTypeInfoMap _r
{
::comphelper::UStringMixEqual aCase(sal_False);
// search for typeinfo where the typename is equal _sTypeName
-OTypeInfoMap::const_iterator aFind = ::std::find_if(_rTypeInfo.begin(),
-_rTypeInfo.end(),
-::o3tl::compose1(
-
[Bug 91112] replace use of o3tl::compose1 by lambdas
https://bugs.documentfoundation.org/show_bug.cgi?id=91112 --- Comment #5 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Jorenz Paragas committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e7c923d632c757c9a38a724cad2d55a84755570 tdf#91112 replace o3tl::compose1 with lambdas in connectivity It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf |binary
vcl/source/filter/wmf/enhwmf.cxx |4 ++--
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 5966b7cc69123da2c267917f5e82a5b1c6985aaf
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 09:45:55 2015 +0100
emf: fix another hang
Change-Id: I971ba5f422827f3b8fcdb86c447fc48415225eca
(cherry picked from commit fe20502c86ef6156a54bb37ba2560c8b64d129a4)
Reviewed-on: https://gerrit.libreoffice.org/16978
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf
new file mode 100644
index 000..e3baf3b
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf differ
diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx
index de78559..840f958 100644
--- a/vcl/source/filter/wmf/enhwmf.cxx
+++ b/vcl/source/filter/wmf/enhwmf.cxx
@@ -1728,9 +1728,9 @@ bool EnhWMFReader::ReadHeader()
pWMF-ReadInt32(nRecordCount);
-if (nRecordCount == 0)
+if (nRecordCount = 0)
{
-SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
0! This shouldn't
+SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as
= 0! This shouldn't
be possible... indicator of possible file
corruption?);
return false;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: offapi/com
offapi/com/sun/star/ui/XSidebarProvider.idl |2 ++ 1 file changed, 2 insertions(+) New commits: commit 51e848095a8ff07153d0e928b130658d5d5e93ce Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jul 13 10:58:49 2015 +0200 Missing @since tag Change-Id: Id8309575cbde56d5eacfc96586b4c91173256519 diff --git a/offapi/com/sun/star/ui/XSidebarProvider.idl b/offapi/com/sun/star/ui/XSidebarProvider.idl index 5786550..8392bea 100644 --- a/offapi/com/sun/star/ui/XSidebarProvider.idl +++ b/offapi/com/sun/star/ui/XSidebarProvider.idl @@ -56,6 +56,8 @@ interface XSidebarProvider: com::sun::star::uno::XInterface /** * Returns the sidebar object + * + * @since LibreOffice 5.1 */ com::sun::star::ui::XSidebar getSidebar(); } ; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/source
sw/source/filter/ww8/ww8scan.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit cd3e5ddeb4100bab2a39cf9913e14eb371edbbcc
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 10:31:30 2015 +0100
ww8: make sure we don't wrap around
Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2
(cherry picked from commit 755b9320c81948358a1d4104c8875594b5700d39)
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 0446bfc..c97db22 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1542,7 +1542,11 @@ WW8PLCFpcd* WW8ScannerBase::OpenPieceTable( SvStream*
pStr, const WW8Fib* pWwF )
if( 2 == clxt ) // PLCFfpcd ?
break; // PLCFfpcd gefunden
if( 1 == clxt ) // clxtGrpprl ?
+{
+if (nGrpprl == SHRT_MAX)
+return NULL;
nGrpprl++;
+}
sal_uInt16 nLen(0);
pStr-ReadUInt16( nLen );
nLeft -= 2 + nLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/source
sw/source/filter/ww8/ww8scan.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 755b9320c81948358a1d4104c8875594b5700d39
Author: Caolán McNamara caol...@redhat.com
Date: Mon Jul 13 10:31:30 2015 +0100
ww8: make sure we don't wrap around
Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 6354f1b..1dc8806 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -1524,7 +1524,11 @@ WW8PLCFpcd* WW8ScannerBase::OpenPieceTable( SvStream*
pStr, const WW8Fib* pWwF )
if( 2 == clxt ) // PLCFfpcd ?
break; // PLCFfpcd gefunden
if( 1 == clxt ) // clxtGrpprl ?
+{
+if (nGrpprl == SHRT_MAX)
+return NULL;
nGrpprl++;
+}
sal_uInt16 nLen(0);
pStr-ReadUInt16( nLen );
nLeft -= 2 + nLen;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 82744] WebDAV LOCK is released when document is saved
https://bugs.documentfoundation.org/show_bug.cgi?id=82744 --- Comment #5 from Giuseppe Castagno (aka beppec56) giuseppe.casta...@acca-esse.eu --- (In reply to Samuel Mehrbrodt from comment #4) Ok, work in progress. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90502] CRASH - failed assertion in unittest sw_globalfilter in master build OSX (ImplLogicToPixel)
https://bugs.documentfoundation.org/show_bug.cgi?id=90502 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Summary|CRASH - failed assertion in |CRASH - failed assertion in |unittest sw_globalfilter in |unittest sw_globalfilter in |master build OSX|master build OSX ||(ImplLogicToPixel) --- Comment #16 from Julien Nabet serval2...@yahoo.fr --- I just changed the title to retrieve it more quickly. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - bridges/source
bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx | 61 ++--
1 file changed, 24 insertions(+), 37 deletions(-)
New commits:
commit 23599fa36015259ef5f84fc827d4569ca548c2ab
Author: Caolan McNamara caol...@redhat.com
Date: Fri Jul 10 16:00:22 2015 +0100
ppc64: simplify this a little
Change-Id: I8166f65625d389a604750852d6d5a4fee25a88fa
Reviewed-on: https://gerrit.libreoffice.org/16935
Reviewed-by: Caolán McNamara caol...@redhat.com
Tested-by: Caolán McNamara caol...@redhat.com
(cherry picked from commit fe14c55f000b9a31d885b411655232e0691e1cd4)
Reviewed-on: https://gerrit.libreoffice.org/16947
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
index 01bb74a..a8ff6b4 100644
--- a/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_powerpc64/uno2cpp.cxx
@@ -124,6 +124,8 @@ void MapReturn(long r3, long r4, double dret,
typelib_TypeDescriptionReference*
if (pReturnType-pType-nSize 8)
pRegisters[1] = r4;
}
+#else
+(void)r4;
#endif
default:
break;
@@ -185,45 +187,29 @@ static void callVirtualMethod(void * pThis, sal_uInt32
nVtableIndex,
// fill registers
__asm__ __volatile__ (
-ld 3, 0(%0)\n\t
-ld 4, 8(%0)\n\t
-ld 5, 16(%0)\n\t
-ld 6, 24(%0)\n\t
-ld 7, 32(%0)\n\t
-ld 8, 40(%0)\n\t
-ld 9, 48(%0)\n\t
-ld 10, 56(%0)\n\t
-lfd 1, 0(%1)\n\t
-lfd 2, 8(%1)\n\t
-lfd 3, 16(%1)\n\t
-lfd 4, 24(%1)\n\t
-lfd 5, 32(%1)\n\t
-lfd 6, 40(%1)\n\t
-lfd 7, 48(%1)\n\t
-lfd 8, 56(%1)\n\t
-lfd 9, 64(%1)\n\t
-lfd 10, 72(%1)\n\t
-lfd 11, 80(%1)\n\t
-lfd 12, 88(%1)\n\t
-lfd 13, 96(%1)\n\t
-: : r (pGPR), r (pFPR)
- : r0, r3, r4, r5, r6, r7, r8, r9, r10,
- fr1, fr2, fr3, fr4, fr5, fr6, fr7, fr8,
fr9,
- fr10, fr11, fr12, fr13
+lfd 1, 0(%0)\n\t
+lfd 2, 8(%0)\n\t
+lfd 3, 16(%0)\n\t
+lfd 4, 24(%0)\n\t
+lfd 5, 32(%0)\n\t
+lfd 6, 40(%0)\n\t
+lfd 7, 48(%0)\n\t
+lfd 8, 56(%0)\n\t
+lfd 9, 64(%0)\n\t
+lfd 10, 72(%0)\n\t
+lfd 11, 80(%0)\n\t
+lfd 12, 88(%0)\n\t
+lfd 13, 96(%0)\n\t
+: : r (pFPR)
+ : fr1, fr2, fr3, fr4, fr5, fr6, fr7, fr8, fr9,
+fr10, fr11, fr12, fr13
);
// tell gcc that r3 to r11 are not available to it for doing the TOC and
exception munge on the func call
register sal_uInt64 r3 asm(r3);
register sal_uInt64 r4 asm(r4);
-register sal_uInt64 r5 asm(r5);
-register sal_uInt64 r6 asm(r6);
-register sal_uInt64 r7 asm(r7);
-register sal_uInt64 r8 asm(r8);
-register sal_uInt64 r9 asm(r9);
-register sal_uInt64 r10 asm(r10);
-register sal_uInt64 r11 asm(r11);
-(*pFunc)(r3, r4, r5, r6, r7, r8, r9, r10);
+(*pFunc)(pGPR[0], pGPR[1], pGPR[2], pGPR[3], pGPR[4], pGPR[5], pGPR[6],
pGPR[7]);
// get return value
__asm__ __volatile__ (
@@ -377,7 +363,6 @@ static void cpp_call(
if (!rParam.bOut bridges::cpp_uno::shared::isSimpleType(
pParamTypeDescr ))
{
-// uno_copyAndConvertData( pCppArgs[nPos] = alloca( 8 ),
pUnoArgs[nPos], pParamTypeDescr,
uno_copyAndConvertData( pCppArgs[nPos] = pStack, pUnoArgs[nPos],
pParamTypeDescr,
pThis-getBridge()-getUno2Cpp() );
switch (pParamTypeDescr-eTypeClass)
@@ -385,7 +370,7 @@ static void cpp_call(
case typelib_TypeClass_HYPER:
case typelib_TypeClass_UNSIGNED_HYPER:
#if OSL_DEBUG_LEVEL 2
-fprintf(stderr, hyper is %lx\n, pCppArgs[nPos]);
+fprintf(stderr, hyper is %lx\n,
pCppArgs[nPos]);
#endif
INSERT_INT64( pCppArgs[nPos], nGPR, pGPR,
pStack, bOverflow );
break;
@@ -393,7 +378,7 @@ static void cpp_call(
case typelib_TypeClass_UNSIGNED_LONG:
case typelib_TypeClass_ENUM:
#if OSL_DEBUG_LEVEL 2
-fprintf(stderr, long is %x\n, pCppArgs[nPos]);
+fprintf(stderr, long is %x\n,
pCppArgs[nPos]);
#endif
INSERT_INT32(
[Libreoffice-bugs] [Bug 35836] Writer form does not save control data properties
https://bugs.documentfoundation.org/show_bug.cgi?id=35836 Óvári ovar...@gmail.com changed: What|Removed |Added CC||ovar...@gmail.com --- Comment #15 from Óvári ovar...@gmail.com --- Created attachment 117221 -- https://bugs.documentfoundation.org/attachment.cgi?id=117221action=edit Save button does not show when changing properties Save button does not show in File menu or Standard toolbar when changing the properties of a form control -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92717] New: VIEWING UI LibreOffice Impress Presentation WebRTC
https://bugs.documentfoundation.org/show_bug.cgi?id=92717 Bug ID: 92717 Summary: VIEWING UI LibreOffice Impress Presentation WebRTC Product: LibreOffice Version: 5.0.0.3 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ovar...@gmail.com Please view “Screensharing with WebRTC” at: http://hancke.name/webrtc/screenshare/#/ Slides state that WebRTC enables capturing: 1. Desktops; 2. Windows; and 3. Chrome Tabs (since Mozilla Firefox 33 thanks to Cisco in particular Matt Miller). An enhancement to LO Impress would be to enable a presentation to be shown in a webbrowser tab. This enhancement could benefit people with single monitors as: 1. a presentation could be shown in a webbrowser tab and shared over the internet; and 2. notes could be shown on the single monitor. This enhancement could benefit people with multiple monitors as: 1. a presentation could be shown in a webbrowser tab and shared over the internet; 2. a presentation could also be shown on an external monitor; and 3. notes could be shown on another monitor. Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92718] New: Printing only works with Print Quality NORMAL. Otherwise shoots out blank pages
https://bugs.documentfoundation.org/show_bug.cgi?id=92718 Bug ID: 92718 Summary: Printing only works with Print Quality NORMAL. Otherwise shoots out blank pages Product: LibreOffice Version: 4.4.4.3 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Printing and PDF export Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: zazu88h...@yahoo.com Recent clean Windows 7 (64bit) install. Using LibreOffice 4.4.4.3 with HP psc2100 all-in-one printer. If I choose to print a document (in LibreOffice Writer) with Print Quality Normal, the document will print fine. If I choose another quality such as Fast Normal (to save ink), it will either shoot out blank pages or print out the first line of the page in huge letters and the rest blank. Used to not have this problem. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92357] Tab type switcher in ruler does not clear previous icon when clicking it
https://bugs.documentfoundation.org/show_bug.cgi?id=92357 --- Comment #2 from Óvári ovar...@gmail.com --- Confirmed in Windows 8.1 LO version: 5.0.0.3 (x64) Build ID: f79b5ba13f5e6cbad23f8038060e556217e66632 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif |binary
vcl/source/filter/igif/decode.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit bca56c8bc261cd52969fc7e05d6bd2ed9ef72ea6
Author: Caolán McNamara caol...@redhat.com
Date: Sat Jul 11 15:31:19 2015 +0100
fix gif import crash
Change-Id: I3a5e0efef6843fb8f8b485fa2369ac5b99513c31
(cherry picked from commit 839e051c658a638a259be6a6bb091b654fac405f)
Reviewed-on: https://gerrit.libreoffice.org/16952
Tested-by: Jenkins c...@libreoffice.org
Reviewed-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
new file mode 100644
index 000..860f9e1
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif differ
diff --git a/vcl/source/filter/igif/decode.cxx
b/vcl/source/filter/igif/decode.cxx
index 105eab9..2b445e9 100644
--- a/vcl/source/filter/igif/decode.cxx
+++ b/vcl/source/filter/igif/decode.cxx
@@ -200,6 +200,8 @@ bool GIFLZWDecompressor::ProcessOneCode()
pE = pTable + nCode;
do
{
+if (pOutBufData == pOutBuf) //can't go back past start
+return false;
nOutBufDataLen++;
*(--pOutBufData) = pE-nData;
pE = pE-pPrev;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- On LO master 5.1 alpha, trying to change the date to say 21.07.2015 and pressing enter in cell C32 causes LO to enter an infinte lopp / hang / beachball spinning mode. Confirming -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm | 12
vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm | 2011 +
vcl/qa/cppunit/graphicfilter/filters-test.cxx |4
vcl/source/filter/ixbm/xbmread.cxx |2
4 files changed, 2028 insertions(+), 1 deletion(-)
New commits:
commit 16ba215eb912043cd3a400ed17c1a68e2f70f7f2
Author: Caolán McNamara caol...@redhat.com
Date: Sat Jul 11 17:23:06 2015 +0100
fix and test for xbm import crash
Change-Id: I47e7cb259908ffc6a00475369af1a841acda1da7
(cherry picked from commit 7eb693f87b6a01044999564cce0a18fefca11c99)
Reviewed-on: https://gerrit.libreoffice.org/16955
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
new file mode 100644
index 000..9d2a434
--- /dev/null
+++ b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm
@@ -0,0 +1,12 @@
+#define?te_width 31
+#define te_height = {
+ 0x0e, 0x20, 0x02, 0x38, 0x11, 0x70, 0x07, 0x 0x44,
+ 0x11, 1x2e, 0x3a, 0x44, 0x8e, 0x24, 0x92, 0x38, 0xdf, 0x25, 0xd2,0x7d,
+ 0x91, 0x24 0x92, 0x44, 0x95: 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff, 0x57,
+ 0x95, 0x24, 0x92, 0x54, 0x95, 0x 4,54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24,x54, 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92,0x54, 0x95, 0x24, 0x92, 0x54,
+ 0x95, 0x24,ÏÏÏ 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff,
0x57,
+ 0x95,0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0, 0x54, 0xf5, 0xd= {
+ 25, 0xd2, 0x7d,
+0x00, 0x7c };
\ No newline at end of file
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore
b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore
new file mode 100644
index 000..e69de29
diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
new file mode 100755
index 000..aad9f03
--- /dev/null
+++ b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm
@@ -0,0 +1,2011 @@
+#define Grafix1_width 485
+#define Grafix1_height 395
+static char Grafix1_bits[] = {
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0xc0, 0x01, 0x00, 0x00,
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif |binary
vcl/source/filter/igif/decode.cxx |2 ++
2 files changed, 2 insertions(+)
New commits:
commit 6bdca73d186ab1c01129c094acaa8b261e092fcc
Author: Caolán McNamara caol...@redhat.com
Date: Sat Jul 11 15:31:19 2015 +0100
fix gif import crash
Change-Id: I3a5e0efef6843fb8f8b485fa2369ac5b99513c31
(cherry picked from commit 839e051c658a638a259be6a6bb091b654fac405f)
Reviewed-on: https://gerrit.libreoffice.org/16954
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif
new file mode 100644
index 000..860f9e1
Binary files /dev/null and
b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-1.gif differ
diff --git a/vcl/source/filter/igif/decode.cxx
b/vcl/source/filter/igif/decode.cxx
index d50ac7c..4d278d9 100644
--- a/vcl/source/filter/igif/decode.cxx
+++ b/vcl/source/filter/igif/decode.cxx
@@ -197,6 +197,8 @@ bool GIFLZWDecompressor::ProcessOneCode()
pE = pTable + nCode;
do
{
+if (pOutBufData == pOutBuf) //can't go back past start
+return false;
nOutBufDataLen++;
*(--pOutBufData) = pE-nData;
pE = pE-pPrev;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #15 from Julien Nabet serval2...@yahoo.fr --- Same result with: $(eval $(call gb_UnpackedTarball_add_patches,jfreereport_libformula,\ external/jfreereport/patches/common_build.patch \ external/jfreereport/patches/libformula-time-notz.patch \ external/jfreereport/patches/tdf92693_fix.patch.1 \ )) julien@julienPC:~/compile-libreoffice/libreoffice/external/jfreereport$ ls -1 patches common_build.patch flow-engine.patch libbase-1.1.6-deprecated.patch libfonts-1.1.6-deprecated.patch libformula-time-notz.patch liblayout.patch libloader-1.1.6-deprecated.patch librepository-1.1.6-deprecated.patch sac.patch tdf92693_fix.patch.1 [build PRJ] jfreereport_libserializer 1 out of 1 hunk FAILED -- saving rejects to file source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java.rej Patch FAILED: /home/julien/compile-libreoffice/libreoffice/external/jfreereport/patches/tdf92693_fix.patch.1 /home/julien/compile-libreoffice/libreoffice/solenv/gbuild/UnpackedTarball.mk:166: recipe for target '/home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/jfreereport_libformula.done' failed make[1]: *** [/home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/jfreereport_libformula.done] Error 1 make[1]: *** Attente des tâches non terminées Makefile:104: recipe for target 'jfreereport' failed make: *** [jfreereport] Error 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87813] SIDEBAR: Incorporating the effects list into the animation tab
https://bugs.documentfoundation.org/show_bug.cgi?id=87813 Rishabh kris.kr...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |kris.kr...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 Rishabh kris.kr...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |kris.kr...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90554] Charter BT font not displayed properly with large spacing
https://bugs.documentfoundation.org/show_bug.cgi?id=90554 Timur gti...@gmail.com changed: What|Removed |Added Version|unspecified |Inherited From OOo OS|All |Windows (All) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92701] Saving with embed fonts option enabled embeds unused fonts in the saved document.
https://bugs.documentfoundation.org/show_bug.cgi?id=92701 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||momonas...@gmail.com Resolution|--- |DUPLICATE --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- Hi, Thank you for this report. It's a known issue. *** This bug has been marked as a duplicate of bug 65353 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 65353] FILESAVE: LO embeds non-used fonts
https://bugs.documentfoundation.org/show_bug.cgi?id=65353 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added CC||wouter...@gmail.com --- Comment #14 from Maxim Monastirsky momonas...@gmail.com --- *** Bug 92701 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 5 commits - fpicker/Library_fps_office.mk fpicker/source include/svtools officecfg/registry svtools/Library_svt.mk sv
fpicker/Library_fps_office.mk|1
fpicker/source/office/OfficeFilePicker.cxx |2
fpicker/source/office/RemoteFilesDialog.cxx | 959 +
fpicker/source/office/RemoteFilesDialog.hxx | 170 ++
fpicker/source/office/iodlg.hxx |3
include/svtools/PlaceEditDialog.hxx |2
include/svtools/RemoteFilesDialog.hxx| 182 --
include/svtools/foldertree.hxx | 56
officecfg/registry/data/org/openoffice/Office/Common.xcu |4
svtools/Library_svt.mk |2
svtools/source/contnr/foldertree.cxx | 116 +
svtools/source/dialogs/PlaceEditDialog.cxx | 12
svtools/source/dialogs/RemoteFilesDialog.cxx | 1062 ---
13 files changed, 1323 insertions(+), 1248 deletions(-)
New commits:
commit 0c5f7163fdf0306d46573974a2f279b659ed66b2
Author: Szymon KÅos eszka...@gmail.com
Date: Mon Jul 13 16:32:07 2015 +0200
Separators between services types
Change-Id: Ibd26abdb83b86256197311bc7a120b4b025ae814
diff --git a/include/svtools/PlaceEditDialog.hxx
b/include/svtools/PlaceEditDialog.hxx
index de321a2..9cba4d5 100644
--- a/include/svtools/PlaceEditDialog.hxx
+++ b/include/svtools/PlaceEditDialog.hxx
@@ -51,6 +51,8 @@ private :
*/
std::vector std::shared_ptr DetailsContainer m_aDetailsContainers;
+unsigned int m_nCurrentType;
+
public :
PlaceEditDialog( vcl::Window* pParent);
diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index a9b1bf7..6394722 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -573,6 +573,7 @@
ithttps://www.googleapis.com/drive/v2/it
ithttps://apis.live.net/v5.0/it
ithttps://api.alfresco.com/cmis/versions/1.0/atom//it
+it/it
ithttp://lt;host:portgt;/alfresco/cmisatom/it
ithttp://lt;hostgt;/p8cmis/wsdl/it
ithttps://apps.lotuslive.com/files/basic/cmis/my/servicedoc/it
@@ -583,6 +584,7 @@
ithttp://lt;hostgt;/_vti_bin/CMISSoapwsdl.aspx/it
ithttp://lt;hostgt;/_api/Web/it
ithttp://lt;hostgt;//it
+it/it
/value
/prop
prop oor:name=CmisServersNames
@@ -590,6 +592,7 @@
itGoogle Drive/it
itOneDrive/it
itAlfresco Cloud/it
+it/it
itAlfresco 4/it
itIBM FileNet P8/it
itLotus Live Files/it
@@ -600,6 +603,7 @@
itSharePoint 2010/it
itSharePoint 2013/it
itOther CMIS/it
+it/it
/value
/prop
/node
diff --git a/svtools/source/dialogs/PlaceEditDialog.cxx
b/svtools/source/dialogs/PlaceEditDialog.cxx
index 0d1dced..482b763 100644
--- a/svtools/source/dialogs/PlaceEditDialog.cxx
+++ b/svtools/source/dialogs/PlaceEditDialog.cxx
@@ -20,6 +20,7 @@ using namespace com::sun::star::uno;
PlaceEditDialog::PlaceEditDialog(vcl::Window* pParent)
: ModalDialog(pParent, PlaceEditDialog, svt/ui/placeedit.ui)
, m_xCurrentDetails()
+, m_nCurrentType( 0 )
{
get( m_pEDServerName, name );
get( m_pLBServerType, type );
@@ -249,11 +250,22 @@ IMPL_LINK_NOARG( PlaceEditDialog, EditUsernameHdl )
IMPL_LINK_NOARG( PlaceEditDialog, SelectTypeHdl )
{
+if ( m_pLBServerType-GetSelectEntry() == )
+{
+if( !m_pLBServerType-IsTravelSelect() )
+m_pLBServerType-SelectEntryPos( m_nCurrentType );
+else
+m_pLBServerType-SetNoSelection();
+
+return 0;
+}
+
if (m_xCurrentDetails.get())
m_xCurrentDetails-show(false);
sal_uInt16 nPos = m_pLBServerType-GetSelectEntryPos( );
m_xCurrentDetails = m_aDetailsContainers[nPos];
+m_nCurrentType = nPos;
m_xCurrentDetails-show(true);
commit 2e2b107a4251e7c08c7c9f39a26d00c1f6b65ae3
Author: Szymon KÅos eszka...@gmail.com
Date: Mon Jul 13 14:31:15 2015 +0200
removed comment
Change-Id: Ia74226be5f7d0776d60f04945c23a5b94cdc11b6
diff --git a/fpicker/source/office/iodlg.hxx b/fpicker/source/office/iodlg.hxx
index 2312a0a..80febee 100644
--- a/fpicker/source/office/iodlg.hxx
+++ b/fpicker/source/office/iodlg.hxx
@@ -57,8 +57,7 @@ class SvtFileDialogFilter_Impl;
class SvtExpFileDlg_Impl;
class CustomContainer;
-class SvtFileDialog : //public ModalDialog, public
::svt::IFilePickerController,
-public SvtFileDialog_Base
+class SvtFileDialog : public SvtFileDialog_Base
{
private:
VclPtrCheckBox _pCbReadOnly;
commit 0103a14020057fa118d97e3a0a50a06efcc5c08b
Author: Szymon KÅos eszka...@gmail.com
Date: Mon Jul 13 14:29:09 2015 +0200
RemoteFilesDialog moved to fpicker
Change-Id:
[Libreoffice-bugs] [Bug 92702] Toolbar: Visible Buttons can't be en-/disabled if they are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=92702 Regina Henschel rb.hensc...@t-online.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||rb.hensc...@t-online.de Ever confirmed|0 |1 --- Comment #1 from Regina Henschel rb.hensc...@t-online.de --- I have seen this with the Standard toolbar on Windows 7 starter. Right-click into the bar gives the context menu and this is so long, that it extends the screen height. I scroll down to see the last items. But clicking on them have no action although they are enabled. The toolbar does not show the arrows on the right side, although it cannot show all items. I can solve the problem in two ways: 1. Use Tools Customize and delete a lot of items, not only disable them but really delete them. 2. In Tools Customize use the Toolbar drop-down and click on item Restore Default Settings. Then the arrows on the right side exist and all active items react. I agree, that it looks like missing initialization. I have made a fresh installation without existing user profile. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Selection.js | 49 +
1 file changed, 49 insertions(+)
New commits:
commit f6a9a8ce0435927bf4dc6f2001675870829eb275
Author: Mihai Varga mihai.va...@collabora.com
Date: Mon Jul 13 16:01:18 2015 +0300
loleaflet: selection control for viewing modes
diff --git a/loleaflet/src/control/Control.Selection.js
b/loleaflet/src/control/Control.Selection.js
new file mode 100644
index 000..abe3237
--- /dev/null
+++ b/loleaflet/src/control/Control.Selection.js
@@ -0,0 +1,49 @@
+/*
+ * L.Control.Selection enables by mouse drag selection in viewing mode
+ */
+
+L.Control.Selection = L.Control.extend({
+ options: {
+ position: 'topleft'
+ },
+
+ onAdd: function (map) {
+ var partName = 'leaflet-control-editviewswitch',
+ container = L.DomUtil.create('label', partName + '
leaflet-bar');
+
+ this._checkBox = L.DomUtil.create('input', 'editview-cb',
container);
+ this._checkBox.type = 'checkbox';
+ L.DomEvent.on(this._checkBox, 'change', this._onChange, this);
+ map.on('updatepermission', this._onUpdatePermission, this);
+ container.appendChild(document.createTextNode('Enable
Selection'));
+ return container;
+ },
+
+ _onChange: function () {
+ if (this._checkBox.checked) {
+ this._map.enableSelection();
+ }
+ else {
+ this._map.disableSelection();
+ }
+ },
+
+ _onUpdatePermission: function (e) {
+ if (e.perm === 'edit') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = true;
+ }
+ else if (e.perm === 'view') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = false;
+ }
+ else if (e.perm === 'readonly') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = false;
+ }
+ }
+});
+
+L.control.selection = function (options) {
+ return new L.Control.Selection(options);
+};
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 --- Comment #7 from Alex Thurgood ipla...@yahoo.co.uk --- (In reply to Alex Thurgood from comment #6) On LO master 5.1 alpha, trying to change the date to say 21.07.2015 and pressing enter in cell C32 causes LO to enter an infinte lopp / hang / beachball spinning mode. Confirming Actually, it took more than 3 minutes to complete the update. Undoing the update with Cmd-Z does the same thing - occupies the processor for at least 3 minutes, in fact far more than 3 minutes, more like 5 !! Context switching seems to help speed up (marginally) the process. Performance is just as bad for me with ersion: 4.4.3.2 Build ID: 88805f81e9fe61362df02b9941de8e38a9b5fd16 Locale : fr_ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92702] New: Toolbar: Visible Buttons can't be en-/disabled if they are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=92702 Bug ID: 92702 Summary: Toolbar: Visible Buttons can't be en-/disabled if they are not displayed Product: LibreOffice Version: 5.0.0.3 rc Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: o...@sophia-louise.de Buttons of a toolbar can't be en-/disabled by right click on toolbar Visible Buttons if they are out of display by starting the context menu. Procedure: Right click on toolbar Standard Visible Buttons Scrolling to button which isn't displayed at the first time. E.g. Line, Data Base. It can't be en- or disabled. It depends on the display size. Tried it with WIN10Preview and WIN8.1 64bit. It seems that it is an initial problem. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - postprocess/qa sc/source sd/source sw/source
postprocess/qa/services.cxx | 11 +++
sc/source/ui/unoobj/docuno.cxx|5 -
sd/source/ui/unoidl/unomodel.cxx |9 ++---
sw/source/uibase/uno/unotxdoc.cxx | 13 -
4 files changed, 29 insertions(+), 9 deletions(-)
New commits:
commit 3b3dbb84cd0d80af230e6751303408750a7f4815
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Jul 13 13:44:06 2015 +0200
tdf#92668: Revert some implementation names, for backwards compatibility
These implementation names of Calc, Draw, Impress, and Writer documents are
the
most likely to be checked by existing third-party code, so revert the
corresponding parts of 3099c70b11c7e5b80fe4dbe3dc99171fb38c6fc2 Fix various
XServiceInfo implementations (and instead add fixups in
CppunitTest_serives).
Change-Id: I1a760adbf4c89a1b4477d6e628abba8d2028ccfe
(cherry picked from commit 61a3be76c221c822b189d20e9269ec5caf1aadcc)
Reviewed-on: https://gerrit.libreoffice.org/17010
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/postprocess/qa/services.cxx b/postprocess/qa/services.cxx
index ec26474..35e5b10 100644
--- a/postprocess/qa/services.cxx
+++ b/postprocess/qa/services.cxx
@@ -365,6 +365,17 @@ void Test::createInstance(
expImpl = com.sun.star.svtools.OfficeFolderPicker;
expServs = {com.sun.star.ui.dialogs.OfficeFolderPicker};
#endif
+} else if (expImpl == com.sun.star.comp.Calc.SpreadsheetDocument) {
+expImpl = ScModelObj;
+} else if (expImpl == com.sun.star.comp.Draw.DrawingDocument
+ || expImpl == com.sun.star.comp.Draw.PresentationDocument)
+{
+expImpl = SdXImpressDocument;
+} else if (expImpl == com.sun.star.comp.Writer.GlobalDocument
+ || expImpl == com.sun.star.comp.Writer.TextDocument
+ || expImpl == com.sun.star.comp.Writer.WebDocument)
+{
+expImpl = SwXTextDocument;
}
CPPUNIT_ASSERT_EQUAL_MESSAGE(
(OString(
diff --git a/sc/source/ui/unoobj/docuno.cxx b/sc/source/ui/unoobj/docuno.cxx
index 5375176..6d148da 100644
--- a/sc/source/ui/unoobj/docuno.cxx
+++ b/sc/source/ui/unoobj/docuno.cxx
@@ -2435,7 +2435,10 @@ uno::SequenceOUString SAL_CALL
ScModelObj::getAvailableServiceNames()
// XServiceInfo
OUString SAL_CALL ScModelObj::getImplementationName()
throw(uno::RuntimeException, std::exception)
{
-return OUString( com.sun.star.comp.Calc.SpreadsheetDocument );
+return OUString( ScModelObj );
+/* // Matching the .component information:
+ return OUString( com.sun.star.comp.Calc.SpreadsheetDocument );
+*/
}
sal_Bool SAL_CALL ScModelObj::supportsService( const OUString rServiceName )
diff --git a/sd/source/ui/unoidl/unomodel.cxx b/sd/source/ui/unoidl/unomodel.cxx
index ff4bb93..7a9bf2a 100644
--- a/sd/source/ui/unoidl/unomodel.cxx
+++ b/sd/source/ui/unoidl/unomodel.cxx
@@ -1184,9 +1184,12 @@ uno::Sequence OUString SAL_CALL
SdXImpressDocument::getAvailableServiceNames(
OUString SAL_CALL SdXImpressDocument::getImplementationName()
throw(uno::RuntimeException, std::exception)
{
-return mbImpressDoc
-? OUString(com.sun.star.comp.Draw.PresentationDocument)
-: OUString(com.sun.star.comp.Draw.DrawingDocument);
+return OUString( SdXImpressDocument );
+/* // Matching the .component information:
+ return mbImpressDoc
+ ? OUString(com.sun.star.comp.Draw.PresentationDocument)
+ : OUString(com.sun.star.comp.Draw.DrawingDocument);
+*/
}
sal_Bool SAL_CALL SdXImpressDocument::supportsService( const OUString
ServiceName )
diff --git a/sw/source/uibase/uno/unotxdoc.cxx
b/sw/source/uibase/uno/unotxdoc.cxx
index b7cdf1d..c19976c 100644
--- a/sw/source/uibase/uno/unotxdoc.cxx
+++ b/sw/source/uibase/uno/unotxdoc.cxx
@@ -1768,11 +1768,14 @@ Sequence OUString
SwXTextDocument::getAvailableServiceNames()
OUString SwXTextDocument::getImplementationName() throw( RuntimeException,
std::exception )
{
-return PTR_CAST(SwGlobalDocShell, pDocShell) != nullptr
-? OUString(com.sun.star.comp.Writer.GlobalDocument)
-: PTR_CAST(SwWebDocShell, pDocShell) != nullptr
-? OUString(com.sun.star.comp.Writer.WebDocument)
-: OUString(com.sun.star.comp.Writer.TextDocument);
+return OUString(SwXTextDocument);
+/* // Matching the .component information:
+ return PTR_CAST(SwGlobalDocShell, pDocShell) != nullptr
+ ? OUString(com.sun.star.comp.Writer.GlobalDocument)
+ : PTR_CAST(SwWebDocShell, pDocShell) != nullptr
+ ? OUString(com.sun.star.comp.Writer.WebDocument)
+ : OUString(com.sun.star.comp.Writer.TextDocument);
+*/
}
sal_Bool SwXTextDocument::supportsService(const OUString rServiceName) throw(
RuntimeException, std::exception )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #18 from Julien Nabet serval2...@yahoo.fr --- Sorry, I meant at last! not at least! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90061] improve rendering of parametrized shapes
https://bugs.documentfoundation.org/show_bug.cgi?id=90061 David Tardon dtar...@redhat.com changed: What|Removed |Added Assignee|gsoumyad...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: 2 commits - loleaflet/build loleaflet/debug loleaflet/src
loleaflet/build/deps.js |7 ++
loleaflet/debug/document/document_simple_example.html |1
loleaflet/src/control/Permission.js | 18 +
loleaflet/src/layer/tile/TileLayer.js | 58 --
4 files changed, 52 insertions(+), 32 deletions(-)
New commits:
commit 0d41a804eb7d696b7ebca1f0ed34fcb85ce4aeca
Author: Mihai Varga mihai.va...@collabora.com
Date: Mon Jul 13 15:50:02 2015 +0300
loleaflet: enabled mouse selection in viewing mode
Mouse selection is enabled by by calling
map.enableSelection() which disables dragging and selection
can be disabled to re-enable dragging by calling
map.disableSelection()
The above only work for 'view' and 'readonly' mode
diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index d656c7a..7f22db1 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -228,6 +228,13 @@ var deps = {
desc: 'Switches edit, view and readOnly modes'
},
+ ControlSelection: {
+ src: ['control/Control.js',
+ 'control/Control.Selection.js'],
+ heading: 'Controls',
+ desc: 'Enables selection in view mode'
+ },
+
ControlButtons: {
src: ['control/Control.js',
'control/Control.Buttons.js'],
diff --git a/loleaflet/debug/document/document_simple_example.html
b/loleaflet/debug/document/document_simple_example.html
index bb00203..446bb00 100644
--- a/loleaflet/debug/document/document_simple_example.html
+++ b/loleaflet/debug/document/document_simple_example.html
@@ -71,6 +71,7 @@
map.addControl(L.control.buttons());
map.addControl(L.control.search());
map.addControl(L.control.permissionSwitch());
+map.addControl(L.control.selection());
map.addControl(L.control.zoom());
map.addControl(L.control.parts());
map.addControl(L.control.statusIndicator());
diff --git a/loleaflet/src/control/Permission.js
b/loleaflet/src/control/Permission.js
index 6933f64..f48d2e4 100644
--- a/loleaflet/src/control/Permission.js
+++ b/loleaflet/src/control/Permission.js
@@ -18,6 +18,24 @@ L.Map.include({
L.DomUtil.removeClass(this._container, className);
}
this.fire('updatepermission', {perm : perm});
+ },
+
+ enableSelection: function () {
+ if (this._docLayer._permission === 'edit') {
+ return;
+ }
+ var className = 'leaflet-editmode';
+ this.dragging.disable();
+ L.DomUtil.addClass(this._container, className);
+ },
+
+ disableSelection: function () {
+ if (this._docLayer._permission === 'edit') {
+ return;
+ }
+ var className = 'leaflet-editmode';
+ this.dragging.enable();
+ L.DomUtil.removeClass(this._container, className);
}
});
diff --git a/loleaflet/src/layer/tile/TileLayer.js
b/loleaflet/src/layer/tile/TileLayer.js
index fb69720..8c88a36 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -738,10 +738,6 @@ L.TileLayer = L.GridLayer.extend({
return;
}
- if (this._permission === 'readonly') {
- return;
- }
-
if (e.type === 'mousedown') {
this._mouseDown = true;
if (this._holdMouseEvent) {
@@ -754,7 +750,7 @@ L.TileLayer = L.GridLayer.extend({
}
else if (e.type === 'mouseup') {
this._mouseDown = false;
- if (this._permission !== 'edit') {
+ if (this._map.dragging.enabled()) {
if (this._mouseEventsQueue.length === 0) {
// mouse up after panning
return;
@@ -779,7 +775,7 @@ L.TileLayer = L.GridLayer.extend({
if (this._mouseEventsQueue.length 1) {
// it's a click, fire mousedown
this._mouseEventsQueue[0]();
- if (this._permission !==
'edit') {
+ if (this._permission ===
'view') {
this._map.setPermission('edit');
}
}
@@ -801,7 +797,7 @@ L.TileLayer = L.GridLayer.extend({
if (this._holdMouseEvent) {
clearTimeout(this._holdMouseEvent);
this._holdMouseEvent = null;
-
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif |binary vcl/source/filter/igif/decode.cxx |3 +++ 2 files changed, 3 insertions(+) New commits: commit b657d6c484ed75f7db4497c720caaffcc519b88c Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 12 10:56:48 2015 +0100 fix another gif import crash Change-Id: I0ffa569e0c4240e11184df7dd56b95d87a12425d (cherry picked from commit ee35b72064d8d1333709b102b051360018f8044b) Reviewed-on: https://gerrit.libreoffice.org/16961 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif new file mode 100644 index 000..b7265f8 Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif differ diff --git a/vcl/source/filter/igif/decode.cxx b/vcl/source/filter/igif/decode.cxx index 46a666f..105eab9 100644 --- a/vcl/source/filter/igif/decode.cxx +++ b/vcl/source/filter/igif/decode.cxx @@ -193,6 +193,9 @@ bool GIFLZWDecompressor::ProcessOneCode() nOldCode = nCode; +if (nCode 4096) +return false; + // write character(/-sequence) of code nCode in the output buffer: pE = pTable + nCode; do ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-3' - 2 commits - loleaflet/build loleaflet/debug loleaflet/src
loleaflet/build/deps.js |7 ++
loleaflet/debug/document/document_simple_example.html |1
loleaflet/src/control/Control.Selection.js| 49 +++
loleaflet/src/control/Permission.js | 18 +
loleaflet/src/layer/tile/TileLayer.js | 58 --
5 files changed, 101 insertions(+), 32 deletions(-)
New commits:
commit d605b501df466801517b70c24afecd0d93a4548e
Author: Mihai Varga mihai.va...@collabora.com
Date: Mon Jul 13 15:50:02 2015 +0300
loleaflet: enabled mouse selection in viewing mode
Mouse selection is enabled by by calling
map.enableSelection() which disables dragging and selection
can be disabled to re-enable dragging by calling
map.disableSelection()
The above only work for 'view' and 'readonly' mode
Conflicts:
loleaflet/build/deps.js
diff --git a/loleaflet/build/deps.js b/loleaflet/build/deps.js
index 65d5452..b3ce61c 100644
--- a/loleaflet/build/deps.js
+++ b/loleaflet/build/deps.js
@@ -228,6 +228,13 @@ var deps = {
desc: 'Switches edit, view and readOnly modes'
},
+ ControlSelection: {
+ src: ['control/Control.js',
+ 'control/Control.Selection.js'],
+ heading: 'Controls',
+ desc: 'Enables selection in view mode'
+ },
+
ControlStatusIndicator: {
src: ['control/Control.js',
'control/Control.StatusIndicator.js'],
diff --git a/loleaflet/debug/document/document_simple_example.html
b/loleaflet/debug/document/document_simple_example.html
index 7d90824..d259531 100644
--- a/loleaflet/debug/document/document_simple_example.html
+++ b/loleaflet/debug/document/document_simple_example.html
@@ -70,6 +70,7 @@
// Controls /
map.addControl(L.control.search());
map.addControl(L.control.permissionSwitch());
+map.addControl(L.control.selection());
map.addControl(L.control.zoom());
map.addControl(L.control.parts());
map.addControl(L.control.statusIndicator());
diff --git a/loleaflet/src/control/Control.Selection.js
b/loleaflet/src/control/Control.Selection.js
new file mode 100644
index 000..abe3237
--- /dev/null
+++ b/loleaflet/src/control/Control.Selection.js
@@ -0,0 +1,49 @@
+/*
+ * L.Control.Selection enables by mouse drag selection in viewing mode
+ */
+
+L.Control.Selection = L.Control.extend({
+ options: {
+ position: 'topleft'
+ },
+
+ onAdd: function (map) {
+ var partName = 'leaflet-control-editviewswitch',
+ container = L.DomUtil.create('label', partName + '
leaflet-bar');
+
+ this._checkBox = L.DomUtil.create('input', 'editview-cb',
container);
+ this._checkBox.type = 'checkbox';
+ L.DomEvent.on(this._checkBox, 'change', this._onChange, this);
+ map.on('updatepermission', this._onUpdatePermission, this);
+ container.appendChild(document.createTextNode('Enable
Selection'));
+ return container;
+ },
+
+ _onChange: function () {
+ if (this._checkBox.checked) {
+ this._map.enableSelection();
+ }
+ else {
+ this._map.disableSelection();
+ }
+ },
+
+ _onUpdatePermission: function (e) {
+ if (e.perm === 'edit') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = true;
+ }
+ else if (e.perm === 'view') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = false;
+ }
+ else if (e.perm === 'readonly') {
+ this._checkBox.checked = false;
+ this._checkBox.disabled = false;
+ }
+ }
+});
+
+L.control.selection = function (options) {
+ return new L.Control.Selection(options);
+};
diff --git a/loleaflet/src/control/Permission.js
b/loleaflet/src/control/Permission.js
index 6933f64..f48d2e4 100644
--- a/loleaflet/src/control/Permission.js
+++ b/loleaflet/src/control/Permission.js
@@ -18,6 +18,24 @@ L.Map.include({
L.DomUtil.removeClass(this._container, className);
}
this.fire('updatepermission', {perm : perm});
+ },
+
+ enableSelection: function () {
+ if (this._docLayer._permission === 'edit') {
+ return;
+ }
+ var className = 'leaflet-editmode';
+ this.dragging.disable();
+ L.DomUtil.addClass(this._container, className);
+ },
+
+ disableSelection: function () {
+ if (this._docLayer._permission === 'edit') {
+ return;
+ }
+
