[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #17 from Julien Nabet serval2...@yahoo.fr --- At least! :-) https://gerrit.libreoffice.org/#/c/17012/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sc/source
sc/source/ui/app/inputhdl.cxx | 51 +++--- sc/source/ui/inc/inputhdl.hxx |3 -- 2 files changed, 20 insertions(+), 34 deletions(-) New commits: commit 865afb6ed25891129efb6907595c892e417a191a Author: Winfried Donkers winfrieddonk...@libreoffice.org Date: Thu Jun 25 17:26:20 2015 +0200 tdf#89031 remove agressiveness from Calc function suggestions Change-Id: I7751a038f8482addc0e45c0461666bbd1c959d12 Reviewed-on: https://gerrit.libreoffice.org/16478 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com (cherry picked from commit f3d748937a177cbbc0033bcf54d0d0fd57a1b409) Reviewed-on: https://gerrit.libreoffice.org/17009 Reviewed-on: https://gerrit.libreoffice.org/17013 diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index c44257b..3b7dddb 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -799,8 +799,7 @@ void ScInputHandler::HideTipBelow() aManualTip.clear(); } -void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSelText, const ESelection rSel, -bool bTryFirstSel ) +void ScInputHandler::ShowArgumentsTip( OUString rSelText ) { ScDocShell* pDocSh = pActiveViewSh-GetViewData().GetDocShell(); const sal_Unicode cSep = ScCompiler::GetNativeSymbolChar(ocSep); @@ -927,34 +926,6 @@ void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSe } } } -else if (bTryFirstSel) -{ -sal_Int32 nPosition = 0; -OUString aText = pEngine-GetWord( 0, rSel.nEndPos-1 ); -/* XXX: dubious, what is this condition supposed to exactly match? */ -if (rSel.nEndPos = aText.getLength() aText[ rSel.nEndPos-1 ] == '=') -{ -break; -} -OUString aNew; -nPosition = aText.getLength()+1; -ScTypedCaseStrSet::const_iterator it = -findText(*pFormulaDataPara, pFormulaDataPara-end(), aText, aNew, false); -if (it != pFormulaDataPara-end()) -{ -if( nPosition rParagraph.getLength() rParagraph[ nPosition ] =='(' ) -{ -ShowTipBelow( aNew ); -bFound = true; -} -else -break; -} -else -{ -break; -} -} else { break; @@ -981,7 +952,7 @@ void ScInputHandler::ShowTipCursor() { OUString aSelText( aParagraph.copy( 0, aSel.nEndPos )); -ShowArgumentsTip( aParagraph, aSelText, aSel, true); +ShowArgumentsTip( aSelText ); } } } @@ -1077,6 +1048,12 @@ void ScInputHandler::UseFormulaData() if ( aSel.nEndPos aParagraph.getLength() ) return; +if ( aParagraph.getLength() aSel.nEndPos + ( ScGlobal::pCharClass-isLetterNumeric( aParagraph, aSel.nEndPos ) || + aParagraph[ aSel.nEndPos ] == '_' || + aParagraph[ aSel.nEndPos ] == '.' ) ) +return; + // Is the cursor at the end of a word? if ( aSel.nEndPos 0 ) { @@ -1092,6 +1069,16 @@ void ScInputHandler::UseFormulaData() miAutoPosFormula = findText(*pFormulaData, miAutoPosFormula, aText, aNew, false); if (miAutoPosFormula != pFormulaData-end()) { +// check if partial function name is not Between quotes +bool bBetweenQuotes = false; +for ( int n = 0; n aSelText.getLength(); n++ ) +{ +if ( aSelText[ n ] == '' ) +bBetweenQuotes = !bBetweenQuotes; +} +if ( bBetweenQuotes ) +return; // we're between quotes + if (aNew[aNew.getLength()-1] == cParenthesesReplacement) aNew = aNew.copy( 0, aNew.getLength()-1) + (); ShowTip( aNew ); @@ -1102,7 +1089,7 @@ void ScInputHandler::UseFormulaData() // function name is complete: // show tip below the cell with function name and arguments of function -ShowArgumentsTip( aParagraph, aSelText, aSel, false); +ShowArgumentsTip( aSelText ); } } } diff --git a/sc/source/ui/inc/inputhdl.hxx b/sc/source/ui/inc/inputhdl.hxx index 65ea47c..b03be18 100644 --- a/sc/source/ui/inc/inputhdl.hxx +++ b/sc/source/ui/inc/inputhdl.hxx @@ -156,8 +156,7 @@ private: boolCursorAtClosingPar(); voidSkipClosingPar(); boolGetFuncName( OUString aStart, OUString aResult ); // fdo75264 -void
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #12 from Julien Nabet serval2...@yahoo.fr --- I renamed the patch tdf92693_fix.patch, changed UnpackedTarball_jfreereport_libformula.mk to have this: 18 $(eval $(call gb_UnpackedTarball_add_patches,jfreereport_libformula,\ 19 external/jfreereport/patches/common_build.patch \ 20 external/jfreereport/patches/libformula-time-notz.patch \ 21 external/jfreereport/patches/tdf92693_fix.patch \ 22 )) then make jfreereport.clean make jfreereport.build, it failed with this: [build PAT] jfreereport_libserializer The text leading up to this was: -- |diff -ur jfreereport_libformula.org/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java jfreereport_libformula/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java |--- jfreereport_libformula.org/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java 2015-07-13 12:26:32.731046395 +0200 |+++ jfreereport_libformula/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java 2015-07-13 12:28:54.359003561 +0200 -- No file to patch. Skipping patch. 1 out of 1 hunk ignored Patch FAILED: /home/julien/compile-libreoffice/libreoffice/external/jfreereport/patches/tdf92693_fix.patch /home/julien/compile-libreoffice/libreoffice/solenv/gbuild/UnpackedTarball.mk:166: recipe for target '/home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/jfreereport_libformula.done' failed make[1]: *** [/home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/jfreereport_libformula.done] Error 1 make[1]: *** Attente des tâches non terminées Makefile:104: recipe for target 'jfreereport.build' failed make: *** [jfreereport.build] Error 2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm | 12 vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm | 2011 + vcl/qa/cppunit/graphicfilter/filters-test.cxx |4 vcl/source/filter/ixbm/xbmread.cxx |2 4 files changed, 2028 insertions(+), 1 deletion(-) New commits: commit 2799db6d3ee548cce639d6c717ed80387852fec0 Author: Caolán McNamara caol...@redhat.com Date: Sat Jul 11 17:23:06 2015 +0100 fix and test for xbm import crash Change-Id: I47e7cb259908ffc6a00475369af1a841acda1da7 (cherry picked from commit 7eb693f87b6a01044999564cce0a18fefca11c99) Reviewed-on: https://gerrit.libreoffice.org/16953 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/.gitignore new file mode 100644 index 000..e69de29 diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm new file mode 100644 index 000..9d2a434 --- /dev/null +++ b/vcl/qa/cppunit/graphicfilter/data/xbm/fail/crash-1.xbm @@ -0,0 +1,12 @@ +#define?te_width 31 +#define te_height = { + 0x0e, 0x20, 0x02, 0x38, 0x11, 0x70, 0x07, 0x 0x44, + 0x11, 1x2e, 0x3a, 0x44, 0x8e, 0x24, 0x92, 0x38, 0xdf, 0x25, 0xd2,0x7d, + 0x91, 0x24 0x92, 0x44, 0x95: 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff, 0x57, + 0x95, 0x24, 0x92, 0x54, 0x95, 0x 4,54, 0x95, 0x24, 0x92, 0x54, + 0x95, 0x24,x54, 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, + 0x95, 0x24, 0x92, 0x54, 0x95, 0x24, 0x92,0x54, 0x95, 0x24, 0x92, 0x54, + 0x95, 0x24,ÏÏÏ 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0xf5, 0x7f, 0xff, 0x57, + 0x95,0x24, 0x92, 0x54, 0x95, 0x24, 0x92, 0x54, 0, 0x54, 0xf5, 0xd= { + 25, 0xd2, 0x7d, +0x00, 0x7c }; \ No newline at end of file diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore b/vcl/qa/cppunit/graphicfilter/data/xbm/indeterminate/.gitignore new file mode 100644 index 000..e69de29 diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/.gitignore new file mode 100644 index 000..e69de29 diff --git a/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm new file mode 100755 index 000..aad9f03 --- /dev/null +++ b/vcl/qa/cppunit/graphicfilter/data/xbm/pass/grafix4.xbm @@ -0,0 +1,2011 @@ +#define Grafix1_width 485 +#define Grafix1_height 395 +static char Grafix1_bits[] = { + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x20, 0x00, 0x00, 0xc0, 0x01, 0x00, 0x00,
[Libreoffice-bugs] [Bug 92605] Format for editing Time does not match the format assigned to a cell.
https://bugs.documentfoundation.org/show_bug.cgi?id=92605 Jacques Guilleron guillero...@aol.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||guillero...@aol.com Ever confirmed|0 |1 --- Comment #1 from Jacques Guilleron guillero...@aol.com --- Hi Aprax, I don't reproduce with LO 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 windows 7 Home Premium Can you provide a spreadsheet showing this behaviour? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90554] Charter BT font not displayed properly with large spacing
https://bugs.documentfoundation.org/show_bug.cgi?id=90554 --- Comment #3 from Timur gti...@gmail.com --- Created attachment 117202 -- https://bugs.documentfoundation.org/attachment.cgi?id=117202action=edit Compare fileopen in Windows and Linux APPLICATION FORM in Windows and Linux is marked as Charter BT; Cambria Math and font size is 20. Apart for the font substitution issue, look is different. In Windows, font is too large, why? while in Linux, it is acceptable. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-4.3' - 2 commits - sw/source vcl/source
sw/source/filter/ww8/ww8scan.cxx |4 vcl/source/gdi/jobset.cxx| 29 + 2 files changed, 21 insertions(+), 12 deletions(-) New commits: commit d4f07cdd244a6aa69de1fde0df4163b27a65556c Author: Caolán McNamara caol...@redhat.com Date: Mon Jan 26 11:26:41 2015 + coverity#1266485 Untrusted value as argument Change-Id: I7708ecaf5412535055584ed6c71beaa9cd71c10c (cherry picked from commit 0934ed1a40c59c169354b177d7dab4228de66171) min legal size here is 4 (cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3) Change-Id: I9f68d000b32623db4d949d13284043630f5689f4 (cherry picked from commit 964000d415bcf491704dad57aee7e0656ea60dab) diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx index ec1f44f..c67255e 100644 --- a/vcl/source/gdi/jobset.cxx +++ b/vcl/source/gdi/jobset.cxx @@ -218,19 +218,24 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) DBG_ASSERTWARNING( rIStream.GetVersion(), JobSetup:: - Solar-Version not set on rOStream ); { -sal_Size nFirstPos = rIStream.Tell(); - sal_uInt16 nLen = 0; rIStream.ReadUInt16( nLen ); -if ( !nLen ) +if (nLen = 4) return rIStream; sal_uInt16 nSystem = 0; rIStream.ReadUInt16( nSystem ); - -boost::scoped_arraychar pTempBuf(new char[nLen]); -rIStream.Read( pTempBuf.get(), nLen - sizeof( nLen ) - sizeof( nSystem ) ); -if ( nLen = sizeof(ImplOldJobSetupData)+4 ) +const size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); +if (nRead rIStream.remainingSize()) +{ +SAL_WARN(vcl, Parsing error: rIStream.remainingSize() + max possible entries, but nRead claimed, truncating); +return rIStream; +} +sal_Size nFirstPos = rIStream.Tell(); +boost::scoped_arraychar pTempBuf(new char[nRead]); +rIStream.Read(pTempBuf.get(), nRead); +if (nRead = sizeof(ImplOldJobSetupData)) { ImplOldJobSetupData* pData = (ImplOldJobSetupData*)pTempBuf.get(); if ( rJobSetup.mpData ) @@ -255,7 +260,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) nSystem == JOBSET_FILE605_SYSTEM ) { Impl364JobSetupData* pOldJobData= (Impl364JobSetupData*)(pTempBuf.get() + sizeof( ImplOldJobSetupData )); -sal_uInt16 nOldJobDataSize = SVBT16ToShort( pOldJobData-nSize ); +sal_uInt16 nOldJobDataSize = SVBT16ToShort( pOldJobData-nSize ); pJobData-mnSystem = SVBT16ToShort( pOldJobData-nSystem ); pJobData-mnDriverDataLen = SVBT32ToUInt32( pOldJobData-nDriverDataLen ); pJobData-meOrientation = (Orientation)SVBT16ToShort( pOldJobData-nOrientation ); @@ -272,8 +277,8 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) } if( nSystem == JOBSET_FILE605_SYSTEM ) { -rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) + 4 + sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen ); -while( rIStream.Tell() nFirstPos + nLen ) +rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) + sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen ); +while( rIStream.Tell() nFirstPos + nRead ) { OUString aKey = read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8); OUString aValue = read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8); @@ -291,9 +296,9 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) else pJobData-maValueMap[ aKey ] = aValue; } -DBG_ASSERT( rIStream.Tell() == nFirstPos+nLen, corrupted job setup ); +DBG_ASSERT( rIStream.Tell() == nFirstPos+nRead, corrupted job setup ); // ensure correct stream position -rIStream.Seek( nFirstPos + nLen ); +rIStream.Seek(nFirstPos + nRead); } } } commit 1877e2a1d0092fea5cc0ea4676f6eca578521911 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 13 10:31:30 2015 +0100 ww8: make sure we don't wrap around Change-Id: I667bb264f92024b72f230c2ddbba3887471345f2 (cherry picked from commit 755b9320c81948358a1d4104c8875594b5700d39) diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx index 3491b5d..4562ffc 100644 --- a/sw/source/filter/ww8/ww8scan.cxx +++ b/sw/source/filter/ww8/ww8scan.cxx @@ -1540,7 +1540,11 @@ WW8PLCFpcd*
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif |binary vcl/source/filter/igif/decode.cxx |3 +++ 2 files changed, 3 insertions(+) New commits: commit 86247d7236cd38a8ae29c66c13e06356fb170b34 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 12 10:56:48 2015 +0100 fix another gif import crash Change-Id: I0ffa569e0c4240e11184df7dd56b95d87a12425d (cherry picked from commit ee35b72064d8d1333709b102b051360018f8044b) Reviewed-on: https://gerrit.libreoffice.org/16962 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif new file mode 100644 index 000..b7265f8 Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/gif/pass/crash-2.gif differ diff --git a/vcl/source/filter/igif/decode.cxx b/vcl/source/filter/igif/decode.cxx index 4d278d9..24b25ac 100644 --- a/vcl/source/filter/igif/decode.cxx +++ b/vcl/source/filter/igif/decode.cxx @@ -193,6 +193,9 @@ bool GIFLZWDecompressor::ProcessOneCode() nOldCode = nCode; +if (nCode 4096) +return false; + // write character(/-sequence) of code nCode in the output buffer: pE = pTable + nCode; do ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/ui/app/inputhdl.cxx | 51 +++--- sc/source/ui/inc/inputhdl.hxx |3 -- 2 files changed, 20 insertions(+), 34 deletions(-) New commits: commit f3d748937a177cbbc0033bcf54d0d0fd57a1b409 Author: Winfried Donkers winfrieddonk...@libreoffice.org Date: Thu Jun 25 17:26:20 2015 +0200 tdf#89031 remove agressiveness from Calc function suggestions Change-Id: I7751a038f8482addc0e45c0461666bbd1c959d12 Reviewed-on: https://gerrit.libreoffice.org/16478 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 001aa27..09308b8 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -804,8 +804,7 @@ void ScInputHandler::HideTipBelow() aManualTip.clear(); } -void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSelText, const ESelection rSel, -bool bTryFirstSel ) +void ScInputHandler::ShowArgumentsTip( OUString rSelText ) { ScDocShell* pDocSh = pActiveViewSh-GetViewData().GetDocShell(); const sal_Unicode cSep = ScCompiler::GetNativeSymbolChar(ocSep); @@ -932,34 +931,6 @@ void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSe } } } -else if (bTryFirstSel) -{ -sal_Int32 nPosition = 0; -OUString aText = pEngine-GetWord( 0, rSel.nEndPos-1 ); -/* XXX: dubious, what is this condition supposed to exactly match? */ -if (rSel.nEndPos = aText.getLength() aText[ rSel.nEndPos-1 ] == '=') -{ -break; -} -OUString aNew; -nPosition = aText.getLength()+1; -ScTypedCaseStrSet::const_iterator it = -findText(*pFormulaDataPara, pFormulaDataPara-end(), aText, aNew, false); -if (it != pFormulaDataPara-end()) -{ -if( nPosition rParagraph.getLength() rParagraph[ nPosition ] =='(' ) -{ -ShowTipBelow( aNew ); -bFound = true; -} -else -break; -} -else -{ -break; -} -} else { break; @@ -986,7 +957,7 @@ void ScInputHandler::ShowTipCursor() { OUString aSelText( aParagraph.copy( 0, aSel.nEndPos )); -ShowArgumentsTip( aParagraph, aSelText, aSel, true); +ShowArgumentsTip( aSelText ); } } } @@ -1087,6 +1058,12 @@ void ScInputHandler::UseFormulaData() if ( aSel.nEndPos aParagraph.getLength() ) return; +if ( aParagraph.getLength() aSel.nEndPos + ( ScGlobal::pCharClass-isLetterNumeric( aParagraph, aSel.nEndPos ) || + aParagraph[ aSel.nEndPos ] == '_' || + aParagraph[ aSel.nEndPos ] == '.' ) ) +return; + // Is the cursor at the end of a word? if ( aSel.nEndPos 0 ) { @@ -1102,6 +1079,16 @@ void ScInputHandler::UseFormulaData() miAutoPosFormula = findText(*pFormulaData, miAutoPosFormula, aText, aNew, false); if (miAutoPosFormula != pFormulaData-end()) { +// check if partial function name is not Between quotes +bool bBetweenQuotes = false; +for ( int n = 0; n aSelText.getLength(); n++ ) +{ +if ( aSelText[ n ] == '' ) +bBetweenQuotes = !bBetweenQuotes; +} +if ( bBetweenQuotes ) +return; // we're between quotes + if (aNew[aNew.getLength()-1] == cParenthesesReplacement) aNew = aNew.copy( 0, aNew.getLength()-1) + (); ShowTip( aNew ); @@ -1112,7 +1099,7 @@ void ScInputHandler::UseFormulaData() // function name is complete: // show tip below the cell with function name and arguments of function -ShowArgumentsTip( aParagraph, aSelText, aSel, false); +ShowArgumentsTip( aSelText ); } } } diff --git a/sc/source/ui/inc/inputhdl.hxx b/sc/source/ui/inc/inputhdl.hxx index 9cdf44c..e53d7de 100644 --- a/sc/source/ui/inc/inputhdl.hxx +++ b/sc/source/ui/inc/inputhdl.hxx @@ -157,8 +157,7 @@ private: boolCursorAtClosingPar(); voidSkipClosingPar(); boolGetFuncName( OUString aStart, OUString aResult ); // fdo75264 -voidShowArgumentsTip( const OUString rParagraph, OUString rSelText, const ESelection rSel, - bool bTryFirstSel ); +void
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf |binary vcl/source/filter/wmf/enhwmf.cxx |2 +- 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit b7bcf8ccc15f7d80a3966a340b987dfa9fd41bd0 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 12 21:07:21 2015 +0100 emf: test for negative numbers Change-Id: I9d9b6f3e9592ca7b85cee5422e43d4ca46b8bb36 (cherry picked from commit 4661b2dd34bd7c56b6d783d49f265e9ecde19caa) Reviewed-on: https://gerrit.libreoffice.org/16970 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf new file mode 100644 index 000..bbc0285 Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/emf/pass/crash-1.emf differ diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx index 62ba08b..bd48610 100644 --- a/vcl/source/filter/wmf/enhwmf.cxx +++ b/vcl/source/filter/wmf/enhwmf.cxx @@ -1425,7 +1425,7 @@ bool EnhWMFReader::ReadEnhWMF() DBG_ASSERT( ( nOptions ( ETO_PDY | ETO_GLYPH_INDEX ) ) == 0, SJ: ETO_PDY || ETO_GLYPH_INDEX in EMF ); Point aPos( ptlReferenceX, ptlReferenceY ); -if ( nLen nLen static_castsal_Int32( SAL_MAX_UINT32 / sizeof(sal_Int32) ) ) +if ( nLen 0 nLen static_castsal_Int32( SAL_MAX_UINT32 / sizeof(sal_Int32) ) ) { if ( offDx (( nCurPos + offDx + nLen * 4 ) = nNextPos ) ) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf |binary vcl/source/filter/wmf/winmtf.cxx | 26 + 2 files changed, 15 insertions(+), 11 deletions(-) New commits: commit bd7b37b8fcf193e2ce20a84ac68bdb22ed8a9ade Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 13 08:33:50 2015 +0100 emf: test for empty polygons Change-Id: I3c8896230e3d48a37f4b8d702b0f673e44f45ba4 (cherry picked from commit 7df4d8544c6b12e31bcb81d9389d03ae7c11bfea) Reviewed-on: https://gerrit.libreoffice.org/16974 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf new file mode 100644 index 000..6adabec Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/emf/fail/crash-2.emf differ diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx index e15f2e0..afa11a0 100644 --- a/vcl/source/filter/wmf/winmtf.cxx +++ b/vcl/source/filter/wmf/winmtf.cxx @@ -1283,18 +1283,22 @@ void WinMtfOutput::DrawPolyLine( Polygon rPolygon, bool bTo, bool bRecordPath ) { UpdateClipRegion(); -ImplMap( rPolygon ); -if ( bTo ) -{ -rPolygon[ 0 ] = maActPos; -maActPos = rPolygon[ rPolygon.GetSize() - 1 ]; -} -if ( bRecordPath ) -aPathObj.AddPolyLine( rPolygon ); -else +sal_uInt16 nPoints = rPolygon.GetSize(); +if (nPoints = 1) { -UpdateLineStyle(); -mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon, maLineStyle.aLineInfo ) ); +ImplMap( rPolygon ); +if ( bTo ) +{ +rPolygon[ 0 ] = maActPos; +maActPos = rPolygon[ rPolygon.GetSize() - 1 ]; +} +if ( bRecordPath ) +aPathObj.AddPolyLine( rPolygon ); +else +{ +UpdateLineStyle(); +mpGDIMetaFile-AddAction( new MetaPolyLineAction( rPolygon, maLineStyle.aLineInfo ) ); +} } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/qa vcl/source
vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf |binary vcl/source/filter/wmf/enhwmf.cxx |4 ++-- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 776618f628ea6302374c90722c3dbd0a6dac1c19 Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 13 09:45:55 2015 +0100 emf: fix another hang Change-Id: I971ba5f422827f3b8fcdb86c447fc48415225eca (cherry picked from commit fe20502c86ef6156a54bb37ba2560c8b64d129a4) Reviewed-on: https://gerrit.libreoffice.org/16979 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf new file mode 100644 index 000..e3baf3b Binary files /dev/null and b/vcl/qa/cppunit/graphicfilter/data/emf/fail/hang-2.emf differ diff --git a/vcl/source/filter/wmf/enhwmf.cxx b/vcl/source/filter/wmf/enhwmf.cxx index bd48610..553f871 100644 --- a/vcl/source/filter/wmf/enhwmf.cxx +++ b/vcl/source/filter/wmf/enhwmf.cxx @@ -1712,9 +1712,9 @@ bool EnhWMFReader::ReadHeader() pWMF-ReadInt32(nRecordCount); -if (nRecordCount == 0) +if (nRecordCount = 0) { -SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as 0! This shouldn't +SAL_WARN(vcl.emf, EMF\t\tEMF Header object shows record counter as = 0! This shouldn't be possible... indicator of possible file corruption?); return false; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice-qa] No 5.0.0.3 rc in Bugzilla
On Mon, Jul 13, 2015 at 4:55 AM, klaus-jürgen weghorn ol o...@sophia-louise.de wrote: Hi all, there is no version 5.0.0.3 rc in bugzilla. Fixed! Thanks, --R -- Grüße k-j ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Robinson Tryon QA Engineer - The Document Foundation LibreOffice Community Outreach Herald qu...@libreoffice.org 802-379-9482 | IRC: colonelqubit on Freenode ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-commits] core.git: chart2/uiconfig
chart2/uiconfig/ui/sidebarelements.ui |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit e82951a858530a05f3ceb66157baf60bbc2d09eb Author: Maxim Monastirsky momonas...@gmail.com Date: Mon Jul 13 16:27:26 2015 +0300 chart2: Fix .ui widget names warn:vcl.layout:13283:1:include/vcl/builder.hxx:413: widget checkbutton_x_axis_title not found in .ui warn:vcl.layout:14352:1:include/vcl/builder.hxx:413: widget checkbutton_y_axis_title not found in .ui Change-Id: I5a6e29b24706df0925038e869be94b0f6a8d232f diff --git a/chart2/uiconfig/ui/sidebarelements.ui b/chart2/uiconfig/ui/sidebarelements.ui index 0f92814..2432c6e2 100644 --- a/chart2/uiconfig/ui/sidebarelements.ui +++ b/chart2/uiconfig/ui/sidebarelements.ui @@ -90,7 +90,7 @@ /packing /child child - object class=GtkCheckButton id=checkbuttonx_axis_title + object class=GtkCheckButton id=checkbutton_x_axis_title property name=label translatable=yesX-axis title/property property name=visibleTrue/property property name=can_focusTrue/property @@ -131,7 +131,7 @@ /packing /child child - object class=GtkCheckButton id=checkbuttony_y_axis_title + object class=GtkCheckButton id=checkbutton_y_axis_title property name=label translatable=yesY-axis title/property property name=visibleTrue/property property name=can_focusTrue/property ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/LOOLWSD.cpp loolwsd/LOOLWSD.hpp
loolwsd/LOOLSession.cpp | 245 +++--- loolwsd/LOOLSession.hpp |7 loolwsd/LOOLWSD.cpp | 528 loolwsd/LOOLWSD.hpp | 14 + 4 files changed, 454 insertions(+), 340 deletions(-) New commits: commit bb3611399be37ba545421198ae0d7a2016fb45ea Author: Henry Castro hcas...@collabora.com Date: Mon Jul 13 10:13:06 2015 -0400 loolwsd: Use fork but no execve diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp index 982a95f..0fdf4d8 100644 --- a/loolwsd/LOOLSession.cpp +++ b/loolwsd/LOOLSession.cpp @@ -43,6 +43,9 @@ #include Poco/URIStreamOpener.h #include Poco/Util/Application.h #include Poco/Exception.h +#include Poco/Net/NetException.h +#include Poco/Net/DialogSocket.h +#include Poco/Net/SocketAddress.h #include LOKitHelper.hpp #include LOOLProtocol.hpp @@ -70,6 +73,9 @@ using Poco::URI; using Poco::URIStreamOpener; using Poco::Util::Application; using Poco::Exception; +using Poco::Net::DialogSocket; +using Poco::Net::SocketAddress; +using Poco::Net::WebSocketException; const std::string LOOLSession::jailDocumentURL = /user/thedocument; @@ -215,13 +221,22 @@ bool MasterProcessSession::handleInput(const char *buffer, int length) sendTextFrame(error: cmd=child kind=syntax); return false; } + UInt64 childId = std::stoull(tokens[1]); -if (_pendingPreSpawnedChildren.find(childId) == _pendingPreSpawnedChildren.end()) +// TODO. rework, the desktop and its childrem is jail root same folder +/*if (_pendingPreSpawnedChildren.find(childId) == _pendingPreSpawnedChildren.end()) { +std::cout Util::logPrefix() Error _pendingPreSpawnedChildren.find(childId) this id= childId std::endl; + sendTextFrame(error: cmd=child kind=notfound); return false; +}*/ + +if (_pendingPreSpawnedChildren.size() 0) +{ +std::setUInt64::iterator it = _pendingPreSpawnedChildren.begin(); +_pendingPreSpawnedChildren.erase(it); } -_pendingPreSpawnedChildren.erase(childId); std::unique_lockstd::mutex lock(_availableChildSessionMutex); _availableChildSessions.insert(shared_from_this()); std::cout Util::logPrefix() Inserted this id= childId into _availableChildSessions, size= _availableChildSessions.size() std::endl; @@ -306,176 +321,22 @@ Path MasterProcessSession::getJailPath(UInt64 childId) return Path::forDirectory(LOOLWSD::childRoot + Path::separator() + std::to_string(childId)); } -namespace +void MasterProcessSession::addPendingChildrem(UInt64 childId) { -ThreadLocalstd::string sourceForLinkOrCopy; -ThreadLocalPath destinationForLinkOrCopy; - -int linkOrCopyFunction(const char *fpath, - const struct stat *sb, - int typeflag, - struct FTW *ftwbuf) -{ -if (strcmp(fpath, sourceForLinkOrCopy-c_str()) == 0) -return 0; - -assert(fpath[strlen(sourceForLinkOrCopy-c_str())] == '/'); -const char *relativeOldPath = fpath + strlen(sourceForLinkOrCopy-c_str()) + 1; - -#ifdef __APPLE__ -if (strcmp(relativeOldPath, PkgInfo) == 0) -return 0; -#endif - -Path newPath(*destinationForLinkOrCopy, Path(relativeOldPath)); - -switch (typeflag) -{ -case FTW_F: -File(newPath.parent()).createDirectories(); -if (link(fpath, newPath.toString().c_str()) == -1) -{ -Application::instance().logger().error(Util::logPrefix() + - link(\ + fpath + \,\ + newPath.toString() + \) failed: + - strerror(errno)); -exit(1); -} -break; -case FTW_DP: -{ -struct stat st; -if (stat(fpath, st) == -1) -{ -Application::instance().logger().error(Util::logPrefix() + - stat(\ + fpath + \) failed: + - strerror(errno)); -return 1; -} -File(newPath).createDirectories(); -struct utimbuf ut; -ut.actime = st.st_atime; -ut.modtime = st.st_mtime; -if (utime(newPath.toString().c_str(), ut) == -1) -{ -Application::instance().logger().error(Util::logPrefix() + - utime(\ + newPath.toString() + \, ut) failed: + - strerror(errno)); -return 1; -} -} -break; -
[Libreoffice-commits] online.git: 2 commits - loleaflet/src
loleaflet/src/control/Buttons.js |6 -- loleaflet/src/control/Control.Buttons.js | 10 +- 2 files changed, 5 insertions(+), 11 deletions(-) New commits: commit c23aa66e54b5cfbd2dd049853e62ab4f72a92579 Author: Mihai Varga mihai.va...@collabora.com Date: Mon Jul 13 18:01:42 2015 +0300 loleaflet: don't toggle buttons on click diff --git a/loleaflet/src/control/Control.Buttons.js b/loleaflet/src/control/Control.Buttons.js index 1115004..1663f3c 100644 --- a/loleaflet/src/control/Control.Buttons.js +++ b/loleaflet/src/control/Control.Buttons.js @@ -51,14 +51,6 @@ L.Control.Buttons = L.Control.extend({ _onButtonClick: function (e) { var id = e.target.id; var button = this._buttons[id]; - if (button.active) { - L.DomUtil.removeClass(e.target, 'leaflet-control-buttons-active'); - button.active = false; - } - else { - L.DomUtil.addClass(e.target, 'leaflet-control-buttons-active'); - button.active = true; - } this._map.toggleCommandState(button.uno); }, commit 3bd2e8f778e04c36401b8a95ed88f2d1e230c20f Author: Mihai Varga mihai.va...@collabora.com Date: Mon Jul 13 17:08:48 2015 +0300 loleaflet: renamed toggleState to toggleCommandState diff --git a/loleaflet/src/control/Buttons.js b/loleaflet/src/control/Buttons.js index 2d7e806..07a37e2 100644 --- a/loleaflet/src/control/Buttons.js +++ b/loleaflet/src/control/Buttons.js @@ -2,7 +2,9 @@ * Toolbar buttons handler */ L.Map.include({ - toggleState: function (unoState) { - this.socket.send('uno .uno:' + unoState); + toggleCommandState: function (unoState) { + if (this._docLayer._permission === 'edit') { + this.socket.send('uno .uno:' + unoState); + } } }); diff --git a/loleaflet/src/control/Control.Buttons.js b/loleaflet/src/control/Control.Buttons.js index d4a08c2..1115004 100644 --- a/loleaflet/src/control/Control.Buttons.js +++ b/loleaflet/src/control/Control.Buttons.js @@ -59,7 +59,7 @@ L.Control.Buttons = L.Control.extend({ L.DomUtil.addClass(e.target, 'leaflet-control-buttons-active'); button.active = true; } - this._map.toggleState(button.uno); + this._map.toggleCommandState(button.uno); }, _onStateChange: function (e) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #13 from Julien Nabet serval2...@yahoo.fr --- Lionel: just for information, I created a pull request, see https://github.com/pentaho/pentaho-reporting/pull/637 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92701] New: Saving with embed fonts option enabled embeds unused fonts in the saved document.
https://bugs.documentfoundation.org/show_bug.cgi?id=92701 Bug ID: 92701 Summary: Saving with embed fonts option enabled embeds unused fonts in the saved document. Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: trivial Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wouter...@gmail.com Created attachment 117201 -- https://bugs.documentfoundation.org/attachment.cgi?id=117201action=edit Test file without the fonts embedded When saving a document with the embed fonts checkbox enabled in the file properties screen embeds unused fonts, creating very big document files. I wrote a document with the line TEST TEST text using the Ubuntu system font Ubuntu. the resulting document file with the embeded fonts creates a 36.3MB! file versus without embeding fonts: 9.3KB. When unpacking the file and inspecting the content.xml file, it lists the following unused fonts: Mangal1 Liberation Mono NSimSun Liberation Serif Liberation Sans Mangal Microsoft YaHei SimSun attached: file without fonts embedded. Link to file with fonts embedded: (Mega) https://mega.nz/#!gxJmyRyR!O98wvBVYzo37NU5PRJFQLd6UlqsgmxvTTmElZoDlPZs without fonts embedded: (Mega) https://mega.nz/#!V5QinBqJ!ny9QORs3k5pvDI-F_uPtFuQjCltmfOp7HNTkDguXt5c -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=89466 Rishabh kris.kr...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |kris.kr...@gmail.com |desktop.org | -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 92674] Cannot remove one page break after Contents Heading
https://bugs.documentfoundation.org/show_bug.cgi?id=92674 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #7 from Joel Madero jmadero@gmail.com --- New is wrong as it implies it was confirmed by a third party, this was not. Moving to UNCONFIRMED again. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #14 from Lionel Elie Mamane lio...@mamane.lu --- (In reply to Julien Nabet from comment #12) I renamed the patch tdf92693_fix.patch, then make jfreereport.clean make jfreereport.build, it failed with this: Try tdf92693_fix.patch.1, according to https://wiki.documentfoundation.org/Development/Patching_External_Libraries the end of the name (when a digit) is significaant, else 3 is assumed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - vcl/source
vcl/source/filter/wmf/winwmf.cxx | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) New commits: commit f202ff6ba07a75e0423fa8e5be2e0f41dc7f056d Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 10 11:34:03 2015 +0100 fix potential hang here Change-Id: Id62cdb90420b9ccf4e98fc1af46c70db6ed60ee0 (cherry picked from commit 7eef63bb2a4d14cb35201f84f38855910f468e20) Reviewed-on: https://gerrit.libreoffice.org/16923 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx index bee19b6..4667844 100644 --- a/vcl/source/filter/wmf/winwmf.cxx +++ b/vcl/source/filter/wmf/winwmf.cxx @@ -1713,14 +1713,19 @@ bool WMFReader::GetPlaceableBound( Rectangle rPlaceableBound, SvStream* pStm ) } break; } -nPos += nRSize * 2; - if ( nPos = nEnd ) - pStm-Seek( nPos ); - else - { - pStm-SetError( SVSTREAM_FILEFORMAT_ERROR ); - bRet = false; - } + +const sal_uInt32 nAvailableBytes = nEnd - nPos; +const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2; +if (nRSize = nMaxPossibleRecordSize) +{ +nPos += nRSize * 2; +pStm-Seek( nPos ); +} +else +{ +pStm-SetError( SVSTREAM_FILEFORMAT_ERROR ); +bRet = false; +} } } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91825] Libroffice Calc locks up with paste column
https://bugs.documentfoundation.org/show_bug.cgi?id=91825 --- Comment #13 from Timur gti...@gmail.com --- (In reply to Carlos Mendes from comment #10) (In reply to Timur from comment #8) Looks like a duplicate of Bug 60021, because of 'if the receiving sheet is all selected..'. Please confirm and mark so. Close but not a duplicate. I'm running LO in linux mint 17.1 x64 and i get no freeze if i select only a column or a row in the receiving worksheet. That tells me it is a duplicate. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[GSoC15] Chained Text Boxes - Report Week 7
Hi, Last week focus was on cursor motion and fixing some odd behavior. What we got is that cursor can move from one box to another after an Overflow and most of the code for positioning correctly exists. What does not work and/or should be done next: - the odd behavior I mentioned above is probably due, or at least includes, the mysterious creation of empty paragraphs by the dozens after text transfer. This is still an open issue. - cursor transfer for pasting has not been handled yet. - after transferring to the next box we are repositioned to the beginning of the box after setting it to the right index. - Backspace and arrow keys should be handled for cursor motion too. Matteo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92573] Writer crash when attempting to open one file.
https://bugs.documentfoundation.org/show_bug.cgi?id=92573 --- Comment #14 from Robinson Tryon (qubit) qu...@runcibility.com --- The content of attachment 117081 has been deleted for the following reason: Uploader request -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 58470] Cant write U_GE
https://bugs.documentfoundation.org/show_bug.cgi?id=58470 --- Comment #3 from tomas.bendor...@gmail.com tomas.bendor...@gmail.com --- There is a lot of things we cannot write without , so it should (preferably - MUST) be mentioned somwhere in help or ... somwhere.Last 6 months I tried to write formula LtF=1/sqrt{Lt} and allways got upset-down question mark with no explanation why and what to. More upset-down question mark: Le, Ll, gt, maybe much more. So, please, explain such behavior of LO. Is it reserved symbols/acronyms/constants? so document all reserved symbols/acronyms/constants. Is it a bug? so correct it. Is it an undocumented feature? so document it. Many thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - include/vcl
include/vcl/printerinfomanager.hxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit b78b90732b3089c865773efab362038bd913dac5 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 12 15:56:40 2015 +0100 coverity#1311653 Uninitialized scalar field Change-Id: Ib1cc81ce30752a3794a009ee8cae826abdb9fc03 (cherry picked from commit ca1a5ebf49d377d93c6c8c57a14d64460babf176) Reviewed-on: https://gerrit.libreoffice.org/16966 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: David Tardon dtar...@redhat.com diff --git a/include/vcl/printerinfomanager.hxx b/include/vcl/printerinfomanager.hxx index 52245c4..3f1debf 100644 --- a/include/vcl/printerinfomanager.hxx +++ b/include/vcl/printerinfomanager.hxx @@ -52,8 +52,9 @@ struct PrinterInfo : JobData OUString m_aFeatures; bool m_bPapersizeFromSetup; -PrinterInfo() : -JobData() +PrinterInfo() +: JobData() +, m_bPapersizeFromSetup(false) {} }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/source
vcl/source/filter/wmf/winwmf.cxx | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) New commits: commit e0d7f9a7ca24f06b393f37a34c099cd10b9d2da0 Author: Caolán McNamara caol...@redhat.com Date: Fri Jul 10 11:34:03 2015 +0100 fix potential hang here Change-Id: Id62cdb90420b9ccf4e98fc1af46c70db6ed60ee0 (cherry picked from commit 7eef63bb2a4d14cb35201f84f38855910f468e20) Reviewed-on: https://gerrit.libreoffice.org/16922 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: David Tardon dtar...@redhat.com diff --git a/vcl/source/filter/wmf/winwmf.cxx b/vcl/source/filter/wmf/winwmf.cxx index 5e25949..7c153c7 100644 --- a/vcl/source/filter/wmf/winwmf.cxx +++ b/vcl/source/filter/wmf/winwmf.cxx @@ -1735,14 +1735,19 @@ bool WMFReader::GetPlaceableBound( Rectangle rPlaceableBound, SvStream* pStm ) } break; } -nPos += nRSize * 2; - if ( nPos = nEnd ) - pStm-Seek( nPos ); - else - { - pStm-SetError( SVSTREAM_FILEFORMAT_ERROR ); - bRet = false; - } + +const sal_uInt32 nAvailableBytes = nEnd - nPos; +const sal_uInt32 nMaxPossibleRecordSize = nAvailableBytes/2; +if (nRSize = nMaxPossibleRecordSize) +{ +nPos += nRSize * 2; +pStm-Seek( nPos ); +} +else +{ +pStm-SetError( SVSTREAM_FILEFORMAT_ERROR ); +bRet = false; +} } } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sc/source
sc/source/ui/app/inputhdl.cxx | 51 +++--- sc/source/ui/inc/inputhdl.hxx |3 -- 2 files changed, 20 insertions(+), 34 deletions(-) New commits: commit 579f5cbfc4636ae28e545b0d2e456e100b08b4ad Author: Winfried Donkers winfrieddonk...@libreoffice.org Date: Thu Jun 25 17:26:20 2015 +0200 tdf#89031 remove agressiveness from Calc function suggestions Change-Id: I7751a038f8482addc0e45c0461666bbd1c959d12 Reviewed-on: https://gerrit.libreoffice.org/16478 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Eike Rathke er...@redhat.com Tested-by: Eike Rathke er...@redhat.com (cherry picked from commit f3d748937a177cbbc0033bcf54d0d0fd57a1b409) Reviewed-on: https://gerrit.libreoffice.org/17009 diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx index 2b6be65..fe9ef00 100644 --- a/sc/source/ui/app/inputhdl.cxx +++ b/sc/source/ui/app/inputhdl.cxx @@ -804,8 +804,7 @@ void ScInputHandler::HideTipBelow() aManualTip.clear(); } -void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSelText, const ESelection rSel, -bool bTryFirstSel ) +void ScInputHandler::ShowArgumentsTip( OUString rSelText ) { ScDocShell* pDocSh = pActiveViewSh-GetViewData().GetDocShell(); const sal_Unicode cSep = ScCompiler::GetNativeSymbolChar(ocSep); @@ -932,34 +931,6 @@ void ScInputHandler::ShowArgumentsTip( const OUString rParagraph, OUString rSe } } } -else if (bTryFirstSel) -{ -sal_Int32 nPosition = 0; -OUString aText = pEngine-GetWord( 0, rSel.nEndPos-1 ); -/* XXX: dubious, what is this condition supposed to exactly match? */ -if (rSel.nEndPos = aText.getLength() aText[ rSel.nEndPos-1 ] == '=') -{ -break; -} -OUString aNew; -nPosition = aText.getLength()+1; -ScTypedCaseStrSet::const_iterator it = -findText(*pFormulaDataPara, pFormulaDataPara-end(), aText, aNew, false); -if (it != pFormulaDataPara-end()) -{ -if( nPosition rParagraph.getLength() rParagraph[ nPosition ] =='(' ) -{ -ShowTipBelow( aNew ); -bFound = true; -} -else -break; -} -else -{ -break; -} -} else { break; @@ -986,7 +957,7 @@ void ScInputHandler::ShowTipCursor() { OUString aSelText( aParagraph.copy( 0, aSel.nEndPos )); -ShowArgumentsTip( aParagraph, aSelText, aSel, true); +ShowArgumentsTip( aSelText ); } } } @@ -1087,6 +1058,12 @@ void ScInputHandler::UseFormulaData() if ( aSel.nEndPos aParagraph.getLength() ) return; +if ( aParagraph.getLength() aSel.nEndPos + ( ScGlobal::pCharClass-isLetterNumeric( aParagraph, aSel.nEndPos ) || + aParagraph[ aSel.nEndPos ] == '_' || + aParagraph[ aSel.nEndPos ] == '.' ) ) +return; + // Is the cursor at the end of a word? if ( aSel.nEndPos 0 ) { @@ -1102,6 +1079,16 @@ void ScInputHandler::UseFormulaData() miAutoPosFormula = findText(*pFormulaData, miAutoPosFormula, aText, aNew, false); if (miAutoPosFormula != pFormulaData-end()) { +// check if partial function name is not Between quotes +bool bBetweenQuotes = false; +for ( int n = 0; n aSelText.getLength(); n++ ) +{ +if ( aSelText[ n ] == '' ) +bBetweenQuotes = !bBetweenQuotes; +} +if ( bBetweenQuotes ) +return; // we're between quotes + if (aNew[aNew.getLength()-1] == cParenthesesReplacement) aNew = aNew.copy( 0, aNew.getLength()-1) + (); ShowTip( aNew ); @@ -1112,7 +1099,7 @@ void ScInputHandler::UseFormulaData() // function name is complete: // show tip below the cell with function name and arguments of function -ShowArgumentsTip( aParagraph, aSelText, aSel, false); +ShowArgumentsTip( aSelText ); } } } diff --git a/sc/source/ui/inc/inputhdl.hxx b/sc/source/ui/inc/inputhdl.hxx index 5b0e837..bfb8e62 100644 --- a/sc/source/ui/inc/inputhdl.hxx +++ b/sc/source/ui/inc/inputhdl.hxx @@ -157,8 +157,7 @@ private: boolCursorAtClosingPar(); voidSkipClosingPar(); boolGetFuncName( OUString aStart, OUString aResult ); // fdo75264 -voidShowArgumentsTip( const OUString rParagraph,
[Libreoffice-bugs] [Bug 66507] CALC: serious performance problems in ods file, primarily in sheets with charts
https://bugs.documentfoundation.org/show_bug.cgi?id=66507 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=92 ||664 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 --- Comment #8 from Alex Thurgood ipla...@yahoo.co.uk --- On LO 4142, the file Manfred sent me takes 10 minutes to load ! At least the update only took a few seconds to execute. This performance problem seems to stem from the multiple recalculations that seem to be carried out when the date is changed. In this regard, it is similar to bug 66507 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92664] Calc very slow since 4.4.4.3 - compared to 4.4.3.2
https://bugs.documentfoundation.org/show_bug.cgi?id=92664 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=66 ||507 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Multiselection needs work?
On Mon, 2015-07-13 at 13:33 +0200, Julien Nabet wrote: In this case perhaps getFiles should use getSelectedFiles() then truncate? Heh - actually that's a pretty good solution for the general case. Call the more powerful method from XFilePicker2 and then just truncate it =) Then again - these problems whereby one uses the other need unwinding of course. Hope I spotted them all. It'd be nice to switch all 'getFiles' for the above, and ensure that we are not using getFiles for the impl. of getSelectedFiles ;-) is that possible ? Here's the patch waiting for review: https://gerrit.libreoffice.org/16985 Will grok; currently off-line =) Thanks ! Michael. -- michael.me...@collabora.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #16 from Julien Nabet serval2...@yahoo.fr --- I tried again your process, I could check your fix is ok. I genereted a patch, I'm testing right now. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92703] New: RTF Control \ulw does not stop
https://bugs.documentfoundation.org/show_bug.cgi?id=92703 Bug ID: 92703 Summary: RTF Control \ulw does not stop Product: LibreOffice Version: 3.6.7.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wp...@gte.net I tried using Word underline (\ulw - and it did turned on), but it would not turn off! :-( \ulw* Word underline + Another thing I noticed is the spaces are not underlined, but punctuation is underlined (comma, colon, semi-colon, etc). If possible, just alpha and/or alpha and numeric characters should be underlined Not punctuation except maybe hyphens in hyphenated words and a period/dot after an abbreviation like Mr., Mrs., Miss., etc. Just my 2 cents FWIW, Tracey + Thanks, Tracey Windows 2000sp4 and LibreOffice Version 3.6.7.2 (Build ID: e183d5b) I successfully tested other forms of underlining: \ul (single), \uldb (double), \uth (thick), and \ulwave (wave). They turned on and off per the applicable control Document: \ulw*Word underline. Document Index: \ulw 87 Font(Character) Formatting.Properties Flag I would like to thank those that geatly enhanced/fixed the RTF functionality in LibreOffice Writer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92666] Base Form/Database Closed When Report Window Closed If Database Browser Window .SetVisible(False)
https://bugs.documentfoundation.org/show_bug.cgi?id=92666 --- Comment #4 from Doug dougt901-2...@yahoo.com --- I would tick the importance of the bug down a notch because there is a partial workaround by watching the state of the Writer window via macro and hiding the Base application window again when the Writer window is closed. Base macros seem to be multi-threaded, allowing the applications to continue normally while the Base macro loops looking for the size.width of the writer window to go to 0 or the .isVisible to go to false, at which time it hides the application window. The need for the first `Wait 50` below illustrates another oddity of LO Basic, which is that sometimes instituting a `Wait` is necessary to allow the application to finish reaching the desired state before continuing. appWindow.setVisible(True) appWindow.isMinimized = True Wait 50 writerRept = reportContainer.open writerCntrllr = writerRept.CurrentController writerFrame = writerCntrllr.Frame writerWindow = writerFrame.getComponentWindow i = 0 sz = writerWindow.getSize.Width vis = writerWindow.isVisible Do While sz 0 And vis = True And i 10 sz = writerWindow.getSize.width vis = writerWindow.isVisible i = i + 1 Wait 10 Loop appWindow.setVisible(False) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #9 from Michael Fiedler michael.fiedle...@gmx.de --- (In reply to Gordo from comment #8) I did not install the fonts so the placement of the text was different for me. I entered a whole column's worth of paragraphs to get the effect in the screenshot. I cannot reproduce it even by more than a page of paragraphs. However, deleting all sections seems to help, at least I cannot see a problem as I had described it any more. The problem was not really good to reproduce after having done changes, so I cannot definitely say that removing the sections certainly fixed the issue, but it sounds at least quite plausible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92708] On Windows x64 with Nvidia GPU, with OpenGL enabled, screen refresh is chaotic with elements showing and hiding with mouse movement
https://bugs.documentfoundation.org/show_bug.cgi?id=92708 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Summary|On Windows x64 with Nvidia |On Windows x64 with Nvidia |GPU, With OpenGL enabled, |GPU, with OpenGL enabled, |screen refresh is chaotic |screen refresh is chaotic |with elements showing and |with elements showing and |hiding with mouse movement |hiding with mouse movement -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Gerrit: Reliability and fidelity of verification results
On Mon, 2015-07-13 at 06:29 -0500, Norbert Thiebaud wrote: On Mon, Jul 13, 2015 at 1:22 AM, David Ostrovsky d.ostrov...@gmx.de wrote: There weren't any changes in the affected file textdoc.cxx between those two patch sets. that is a bold thing to say when a patch change stuff like uno headers or rtl headers I see how uno and rtl headers changes look suspicious, but the removal of get_pointer() function there is completely unrelated. tb66 is Yosemite Apple LLVM version 6.1.0 (clang-602.0.49) (based on LLVM 3.6.0svn) Target: x86_64-apple-darwin14.3.0 tb60 is Maverick Apple LLVM version 6.0 (clang-600.0.51) (based on LLVM 3.5svn) Target: x86_64-apple-darwin13.4.0 This is a known compiler bug; now with access to Mavericks: $ clang++ --version Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn) Target: x86_64-apple-darwin13.4.0 and with this reproducer: [1] it's failing in the same way as on TB 60: __functional_03:43:11: note: candidate function not viable: 'this' argument has type 'const std::__1::__mem_fnint foo::*', but method is not marked const operator() (_A0 __a0) To rectify it: 1. Upgrade Mavericks to Yosemite 2. Upgrade Xcode to Xcode 6.3.2 (Build version 6D2105) $ clang++ --version Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) Target: x86_64-apple-darwin14.3.0 And now it works: $ clang++ -Wno-c++11-extensions mem_fn_const_problem.cxx ./a.out 42 Before new Xcode activation this diff shows the culprit: $ diff /Applications/.prepare-Xcode.app/reloc/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/functional /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/functional 1224c1224 operator() (_ArgTypes... __args) const --- operator() (_ArgTypes... __args) And your patch 8 would have failed the same way on tb58/tb59/tb60 It requires a lot of efforts and time to upgrade all TBs to the newest baseline: 18 min. for OS + 22 min. for XCode. And we don't have time to do that. I understand all that. But what is the value of having conflicting tool chain versions verifying the Gerrit changes? So that change owners couldn't really trust the verification results, or if they do and submit changes that were approved by TB with up-to-date tool chain, they jeopardize green master or even stable release branch, because the same change is identified as breakage by a TB with stale tool chain? My suggestion is either to downgrade TB66 or upgrade all other Mac OS X TBs to the same baseline. [1] http://paste.openstack.org/show/371884 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92711] Autosave blocks all uses for new, but unsaved files
https://bugs.documentfoundation.org/show_bug.cgi?id=92711 --- Comment #2 from Balaco balacob...@imap.cc --- Really? I'm using Fedora, and they (people who takes cares of some computers I use) updated LibreOffice today. And it was just 4.1.2 before this update. I'll see what I can do to update and retest this with a newer LO version, but it may not be possible (I don't choose the Fedora version I use here, for example). Just with the current version of L.O. the bug reports can be accepted? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - editeng/source
editeng/source/outliner/overflowingtxt.cxx | 55 ++--- 1 file changed, 50 insertions(+), 5 deletions(-) New commits: commit 5694e32c7cbfb9079585502fae14ba7a583db999 Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 14:53:14 2015 -0400 Add rough algorithm for deep merging. Not all attrbs saved. Change-Id: I369f0e2c9e56e0257284a038bfe707dd37a88421 diff --git a/editeng/source/outliner/overflowingtxt.cxx b/editeng/source/outliner/overflowingtxt.cxx index 6a73775..ecb69d3 100644 --- a/editeng/source/outliner/overflowingtxt.cxx +++ b/editeng/source/outliner/overflowingtxt.cxx @@ -54,18 +54,63 @@ OutlinerParaObject *impGetJuxtaposedParaObject(Outliner *pOutl, return pPObj; } +// In a deep merge parts of text are not only juxtaposed but the last and first para become the same OutlinerParaObject *impGetDeeplyMergedParaObject(Outliner *pOutl, OutlinerParaObject *pPObj1, OutlinerParaObject *pPObj2) -{ // XXX: For now just the same - +{ assert(pOutl pPObj1 pPObj2); +const EditTextObject rTObj1 = pPObj1-GetTextObject(); +const EditTextObject rTObj2 = pPObj2-GetTextObject(); +sal_Int32 nParaCount1 = rTObj1.GetParagraphCount(); + +// If no paras in the first text, just use second text +if (nParaCount1 == 0) { +pOutl-SetText(*pPObj2); +return pOutl-CreateParaObject(); +} + + +sal_Int32 nLastPara1 = nParaCount1 - 1; + +// If last para of first text is empty, discard it and just juxtapose +if (rTObj1.GetText(nLastPara1) == nParaCount1 = 2) { +pOutl-SetText(*pPObj1); +return impGetJuxtaposedParaObject( +pOutl, +pOutl-CreateParaObject(0, nLastPara1 - 1), +pPObj2); +} + +/* --- Standard procedure: when pPObj1 is 'fine' --- */ + + +// Cut first para of second object +OUString aFirstParaTxt2 = rTObj2.GetText(0); + +// Prepare remainder for text 2 +OutlinerParaObject *pRemainderPObj2 = NULL; +if (rTObj2.GetParagraphCount() 1) { +pOutl-SetText(*pPObj2); +pRemainderPObj2 = pOutl-CreateParaObject(1); // from second para on +} else { // No text to append +pRemainderPObj2 = NULL; +} + +// Set first object as text pOutl-SetText(*pPObj1); -pOutl-AddText(*pPObj2); -OutlinerParaObject *pPObj = pOutl-CreateParaObject(); -return pPObj; +// Merges LastPara(pPObj1) with FirstPara(pPObj2) +Paragraph *pLastPara1 = pOutl-GetParagraph(nLastPara1); +OUString aLastParaTxt1 = pOutl-GetText(pLastPara1); +pOutl-SetText(aLastParaTxt1 + aFirstParaTxt2, pLastPara1); // XXX: This way it screws up attributes! + +// add the remainder of the second text +if (pRemainderPObj2) +pOutl-AddText(*pRemainderPObj2); + +return pOutl-CreateParaObject(); } // class OverflowingText ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91497] When column is too narrow - autofit does not expand the column.
https://bugs.documentfoundation.org/show_bug.cgi?id=91497 Edmund Laugasson edmund.laugas...@gmail.com changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - editeng/source
editeng/source/outliner/outliner.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7aae39ef5679db0299c34095781187546cbedff2 Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 15:12:48 2015 -0400 Fix wrong definition of bLastParaIsInterrupted Change-Id: Ib0b65afa6c44e9b6b83c2acef5044d8cd3182a00 diff --git a/editeng/source/outliner/outliner.cxx b/editeng/source/outliner/outliner.cxx index a8e5be0..148efa7 100644 --- a/editeng/source/outliner/outliner.cxx +++ b/editeng/source/outliner/outliner.cxx @@ -2161,9 +2161,9 @@ NonOverflowingText *Outliner::GetNonOverflowingText() const } EditTextObject *pTObj = pEditEngine-CreateTextObject(aNonOverflowingTextSelection); -sal_Int32 nLastLine = GetLineCount(nOverflowingPara)-1; +//sal_Int32 nLastLine = GetLineCount(nOverflowingPara)-1; bool bLastParaInterrupted = -pEditEngine-GetOverflowingLineNum() nLastLine; +pEditEngine-GetOverflowingLineNum() 0; return new NonOverflowingText(pTObj, bLastParaInterrupted); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92711] Autosave blocks all uses for new, but unsaved files
https://bugs.documentfoundation.org/show_bug.cgi?id=92711 --- Comment #3 from Maxim Monastirsky momonas...@gmail.com --- (In reply to Balaco from comment #2) Just with the current version of L.O. the bug reports can be accepted? Currently bug reports are accepted only for 4.4/5.0/master (and also 4.3 for Mac users downloading from the App Store). -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91497] When column is too narrow - autofit does not expand the column.
https://bugs.documentfoundation.org/show_bug.cgi?id=91497 --- Comment #8 from Edmund Laugasson edmund.laugas...@gmail.com --- Created attachment 117214 -- https://bugs.documentfoundation.org/attachment.cgi?id=117214action=edit Bug still exist - autofit columns does not work Hereby I tested with current dev version LibreOffice 5.0.0 RC3 and I have to admit that bug still exist. Version: 5.0.0.3 ID: f79b5ba13f5e6cbad23f8038060e556217e66632 Locale: et-EE (et_EE.UTF-8) OS: 64-bit Linux Mint 17.2 with Cinnamon desktop, kernel 4.0.8-040008-generic I created table with 2 rows and columns, entered text and used autofit. So far so good. Then I added some words so the text went to two rows. Now autofit does not work. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87485] Writer: embedded PNG results in slow scrolling
https://bugs.documentfoundation.org/show_bug.cgi?id=87485 --- Comment #26 from just-me h...@chemie.uni-leipzig.de --- Update: Few problems with PNG noted. But SVG, 2 page-wide images per page causes extreme slowdowns again. The SVGs are b/w (transparent) only, just lines (NMR spectra, looks a bit like a garden fence) and some font text. They do have several vertex points, though (SVG file size 80 ... 200 KB). Scrolling and text editing becomes unbearable often. As soon as these are off screen things become better. Messing with the memory reserved per graphic object settings didn't seem to help (yet). Also closing browsers (might block 2d accel resources??) on other virtual desktops didn't change things. Any suggestions for possible traces to run during such a work? (current LibO 4.4.3.2; will compile 4.4.4.3 probably this night, AMD FOSS driver stack ist quite up to date) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92471] FILESAVE: New DOCX export of text with highlighting works not for all colors
https://bugs.documentfoundation.org/show_bug.cgi?id=92471 --- Comment #6 from ralf.kr...@bluewin.ch --- I see. Because not everyone is an expert in exporting, Shading would be possibly the better default setting? Cheers -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - editeng/source include/editeng
editeng/source/outliner/overflowingtxt.cxx | 78 +++-- include/editeng/overflowingtxt.hxx |3 + 2 files changed, 65 insertions(+), 16 deletions(-) New commits: commit d35ecc609fa55835f3942656dcd9330c24dc4521 Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 14:08:00 2015 -0400 Add impGetDeeplyMergedParaObject. But with juxtaposition semantics Change-Id: Idd8d8d39d7ddabc9bdfe416250c6611b21f74e11 diff --git a/editeng/source/outliner/overflowingtxt.cxx b/editeng/source/outliner/overflowingtxt.cxx index eb6bfe5..6a73775 100644 --- a/editeng/source/outliner/overflowingtxt.cxx +++ b/editeng/source/outliner/overflowingtxt.cxx @@ -26,7 +26,7 @@ #include editeng/editobj.hxx -// Helper function for *OverflowingText classes +/* Helper functions for *OverflowingText classes */ ESelection getLastPositionSel(const EditTextObject *pTObj) { @@ -40,6 +40,34 @@ ESelection getLastPositionSel(const EditTextObject *pTObj) return aEndPos; } +// Put a para next to each other in the same OutlinerParaObject +OutlinerParaObject *impGetJuxtaposedParaObject(Outliner *pOutl, + OutlinerParaObject *pPObj1, + OutlinerParaObject *pPObj2) +{ +assert(pOutl pPObj1 pPObj2); + +pOutl-SetText(*pPObj1); +pOutl-AddText(*pPObj2); +OutlinerParaObject *pPObj = pOutl-CreateParaObject(); + +return pPObj; +} + +OutlinerParaObject *impGetDeeplyMergedParaObject(Outliner *pOutl, + OutlinerParaObject *pPObj1, + OutlinerParaObject *pPObj2) +{ // XXX: For now just the same + +assert(pOutl pPObj1 pPObj2); + +pOutl-SetText(*pPObj1); +pOutl-AddText(*pPObj2); +OutlinerParaObject *pPObj = pOutl-CreateParaObject(); + +return pPObj; +} + // class OverflowingText OverflowingText::OverflowingText(EditTextObject *pTObj) @@ -89,24 +117,35 @@ OutlinerParaObject *OverflowingText::GetJuxtaposedParaObject(Outliner *pOutl, Ou return NULL; } -// Simply Juxtaposing; no within-para merging OutlinerParaObject *pOverflowingPObj = new OutlinerParaObject(*mpContentTextObj); // the OutlinerParaObject constr. at the prev line gives no valid outliner mode, so we set it pOverflowingPObj-SetOutlinerMode(pOutl-GetOutlinerMode()); -/* Actual Text Setting */ -pOutl-SetText(*pOverflowingPObj); +// Simply Juxtaposing; no within-para merging +return impGetJuxtaposedParaObject(pOutl, pOverflowingPObj, pNextPObj); +} -// Set selection position between new and old text -//maInsertionPointSel = impGetEndSelection(pOutl); // XXX: Maybe setting in the constructor is just right +OutlinerParaObject *OverflowingText::impMakeOverflowingParaObject(Outliner *pOutliner) +{ +if (mpContentTextObj == NULL) { +fprintf(stderr, [Chaining] OverflowingText's mpContentTextObj is NULL!\n); +return NULL; +} + +// Simply Juxtaposing; no within-para merging +OutlinerParaObject *pOverflowingPObj = new OutlinerParaObject(*mpContentTextObj); +// the OutlinerParaObject constr. at the prev line gives no valid outliner mode, so we set it +pOverflowingPObj-SetOutlinerMode(pOutliner-GetOutlinerMode()); -pOutl-AddText(*pNextPObj); +return pOverflowingPObj; +} -// End Text Setting -OutlinerParaObject *pPObj = pOutl-CreateParaObject(); -//pPObj-SetOutlinerMode(pOutl-GetOutlinerMode()); -return pPObj; +OutlinerParaObject *OverflowingText::GetDeeplyMergedParaObject(Outliner *pOutliner, OutlinerParaObject *pNextPObj) +{ +OutlinerParaObject *pOverflowingPObj = impMakeOverflowingParaObject(pOutliner); + +return impGetDeeplyMergedParaObject(pOutliner, pOverflowingPObj, pNextPObj); } // class OFlowChainedText @@ -135,9 +174,13 @@ OutlinerParaObject *OFlowChainedText::CreateOverflowingParaObject(Outliner *pOut if (mpOverflowingTxt == NULL || pTextToBeMerged == NULL) return NULL; -return mpOverflowingTxt-GetJuxtaposedParaObject(pOutliner, pTextToBeMerged ); +if (mbIsDeepMerge) +return mpOverflowingTxt-GetJuxtaposedParaObject(pOutliner, pTextToBeMerged ); +else +return mpOverflowingTxt-GetDeeplyMergedParaObject(pOutliner, pTextToBeMerged ); } + OutlinerParaObject *OFlowChainedText::CreateNonOverflowingParaObject(Outliner *pOutliner) { if (mpNonOverflowingTxt == NULL) @@ -162,12 +205,15 @@ UFlowChainedText::UFlowChainedText(Outliner *pOutl, bool bIsDeepMerge) OutlinerParaObject *UFlowChainedText::CreateMergedUnderflowParaObject(Outliner *pOutl, OutlinerParaObject *pNextLinkWholeText) { +OutlinerParaObject *pNewText = NULL; OutlinerParaObject *pCurText = mpUnderflowPObj; -// NewTextForCurBox = Txt(CurBox) ++ Txt(NextBox) -pOutl-SetText(*pCurText); -
[Libreoffice-bugs] [Bug 92605] Format for editing Time does not match the format assigned to a cell.
https://bugs.documentfoundation.org/show_bug.cgi?id=92605 Aprax r...@jwcca.com changed: What|Removed |Added CC||r...@jwcca.com --- Comment #2 from Aprax r...@jwcca.com --- Created attachment 117213 -- https://bugs.documentfoundation.org/attachment.cgi?id=117213action=edit Sample of issue It is pretty easy to create the attached sample that demonstrates the issue. The attachment contains a cell with Notes that may help understand the issue. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92711] Autosave blocks all uses for new, but unsaved files
https://bugs.documentfoundation.org/show_bug.cgi?id=92711 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||momonas...@gmail.com Ever confirmed|0 |1 --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- Hi, (In reply to Balaco from comment #0) I can't figure out what I should/could do! The first thing I would do is to upgrade to a newer version. 4.1.6 is old and unsupported for a very long time now, and it's known to have a bug similar to what you're describing here. So please retest with a newer version, and report back whether it solves the bug for you. Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: chart2/source
chart2/source/controller/main/ChartController.cxx |4 1 file changed, 4 insertions(+) New commits: commit f90307a9372579b15b837dc83d959b394c6a0537 Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Jul 13 19:43:59 2015 +0200 disable that code for now Change-Id: I9f65babd0314498145746c452180ccf4fab64720 Reviewed-on: https://gerrit.libreoffice.org/17020 Reviewed-by: Michael Stahl mst...@redhat.com Tested-by: Michael Stahl mst...@redhat.com diff --git a/chart2/source/controller/main/ChartController.cxx b/chart2/source/controller/main/ChartController.cxx index d548ba3..d884262 100644 --- a/chart2/source/controller/main/ChartController.cxx +++ b/chart2/source/controller/main/ChartController.cxx @@ -376,9 +376,11 @@ void SAL_CALL ChartController::attachFrame( mpSelectionChangeHandler-Connect(); +/* uno::Referenceui::XSidebar xSidebar = getSidebarFromModel(getModel()); sfx2::sidebar::SidebarController* pSidebar = dynamic_castsfx2::sidebar::SidebarController*(xSidebar.get()); sfx2::sidebar::SidebarController::registerSidebarForFrame(pSidebar, this); +*/ if(m_xFrame.is()) //what happens, if we do have a Frame already?? { @@ -747,12 +749,14 @@ void SAL_CALL ChartController::dispose() { mpSelectionChangeHandler-Disconnect(); +/* if (getModel().is()) { uno::Referenceui::XSidebar xSidebar = getSidebarFromModel(getModel()); sfx2::sidebar::SidebarController* pSidebar = dynamic_castsfx2::sidebar::SidebarController*(xSidebar.get()); sfx2::sidebar::SidebarController::unregisterSidebarForFrame(pSidebar, this); } +*/ try { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92511] Incorrect work of GetByName method
https://bugs.documentfoundation.org/show_bug.cgi?id=92511 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||c...@nouenoff.nl Resolution|--- |WORKSFORME --- Comment #1 from Cor Nouws c...@nouenoff.nl --- Hi vlad, Thanks for your post, but I think the macro is not correct. Please try the following: Sub Main Dim oForm As Object Dim n% 'Globalscope.BasicLibraries.LoadLibrary(XrayTool) 'xray ThisComponent.DrawPage.Forms For n = 0 to ThisComponent.DrawPage.Forms.Count -1 oForm=ThisComponent.DrawPage.Forms.getByIndex(n) '(oFormName) MsgBox The value of oFormName const is - oFormName Chr(13) _ The name of getting form is - oForm.Name Next End Sub I set this as worksForMe. Regards, Cor -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91548] FEATURE REQUEST: analysis toolpak for Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=91548 --- Comment #9 from Edmund Laugasson edmund.laugas...@gmail.com --- Why then MS Excel has it? As much as I have heard, a lot of scientists are using MS Excel in this reason that it has statistics inside and avoiding with same reason LibreOffice. R might be good but not all scientists are not ready to learn the code inside R. By the way there are many of such scientists. Therefore I started current feature request that there is strong requirement by such scientists. As common output is .csv from different programs, it is quite logical to import them into spreadsheet program. Why not use spreadsheet if the learning curve is much smaller than in case of R. There are many universities which still do not teach R but will teach spreadsheets (also statistics part in spreadsheets). This would reasonably increase LibreOffice chances to spread more widely if it would have good statistics features. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source sw/source
sc/source/ui/view/tabvwsh2.cxx | 12 sw/source/uibase/uiview/viewstat.cxx |5 - 2 files changed, 16 insertions(+), 1 deletion(-) New commits: commit 107a4740f63860f0901f51217b16cefa62a827ac Author: Maxim Monastirsky momonas...@gmail.com Date: Mon Jul 13 20:23:39 2015 +0300 tdf#39478 Fix custom shapes status update In sw it was still returning a string item, although the slot type was changed to boolean back in 2005 with 4cce2a2f08238e1e03055877aa89bc755ec06f59. In sc the status update was simply missing. Change-Id: I8a6dd157d1e401754b3a9a93dc83458dcdd4f089 diff --git a/sc/source/ui/view/tabvwsh2.cxx b/sc/source/ui/view/tabvwsh2.cxx index 1efe8d6..fefe124 100644 --- a/sc/source/ui/view/tabvwsh2.cxx +++ b/sc/source/ui/view/tabvwsh2.cxx @@ -434,6 +434,18 @@ void ScTabViewShell::GetDrawState(SfxItemSet rSet) case SID_OBJECT_SELECT: // wichtig fuer den ollen Control-Controller rSet.Put( SfxBoolItem( nWhich, nDrawSfxId == SID_OBJECT_SELECT IsDrawSelMode() ) ); break; + +case SID_DRAWTBX_CS_BASIC: +case SID_DRAWTBX_CS_SYMBOL: +case SID_DRAWTBX_CS_ARROW: +case SID_DRAWTBX_CS_FLOWCHART: +case SID_DRAWTBX_CS_CALLOUT: +case SID_DRAWTBX_CS_STAR: +{ +bool bCurrentActive = (nDrawSfxId == nWhich) (aCurrShapeEnumCommand[ nWhich - SID_DRAWTBX_CS_BASIC ] == sDrawCustom); +rSet.Put( SfxBoolItem( nWhich, bCurrentActive ) ); +} +break; } nWhich = aIter.NextWhich(); } diff --git a/sw/source/uibase/uiview/viewstat.cxx b/sw/source/uibase/uiview/viewstat.cxx index cfc2f02..aabd463 100644 --- a/sw/source/uibase/uiview/viewstat.cxx +++ b/sw/source/uibase/uiview/viewstat.cxx @@ -550,7 +550,10 @@ void SwView::GetDrawState(SfxItemSet rSet) if ( bWeb ) rSet.DisableItem( nWhich ); else -rSet.Put(SfxStringItem(nWhich, m_aCurrShapeEnumCommand[ nWhich - SID_DRAWTBX_CS_BASIC ] )); +{ +bool bCurrentActive = (m_nDrawSfxId == nWhich) (m_aCurrShapeEnumCommand[ nWhich - SID_DRAWTBX_CS_BASIC ] == m_sDrawCustom); +rSet.Put( SfxBoolItem( nWhich, bCurrentActive ) ); +} } break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/inc sc/source
sc/inc/globstr.hrc| 1123 +- sc/source/ui/namedlg/namemgrtable.cxx |2 sc/source/ui/src/globstr.src |6 3 files changed, 568 insertions(+), 563 deletions(-) New commits: commit baffa3e3768df1d016d79349ed074ba20b34d5c1 Author: Eike Rathke er...@redhat.com Date: Mon Jul 13 19:40:50 2015 +0200 renumber globstr.hrc STR_... and move STR_HEADER_RANGE_OR_EXPR and STR_HEADER_RANGE to proper positions. Renumbered sc/inc/globstr.hrc consecutively using sc/util/number-defines-consecutively.awk which closed a gap of six strings. Change-Id: Ibf643ad5b243caf7b01226af399e60bbe0433a15 diff --git a/sc/inc/globstr.hrc b/sc/inc/globstr.hrc index 6ca1fd7..f37110f 100644 --- a/sc/inc/globstr.hrc +++ b/sc/inc/globstr.hrc @@ -89,620 +89,619 @@ #define STR_MSSG_INSERTCELLS_0 50 #define STR_MSSG_DELETECELLS_0 51 #define STR_MSSG_MERGECELLS_0 52 -#define STR_MSSG_SOLVE_054 -#define STR_MSSG_SOLVE_155 -#define STR_MSSG_SOLVE_256 -#define STR_MSSG_SOLVE_357 -#define STR_MSSG_SOLVE_458 - -#define STR_TABLE_GESAMTERGEBNIS59 -#define STR_TABLE_ERGEBNIS 60 -#define STR_UNDO_SPELLING 61 -#define STR_TABLE_UND 62 -#define STR_TABLE_ODER 63 -#define STR_UNDO_INSERTCELLS64 -#define STR_TABLE_DEF 65 -#define STR_MOVE_TO_END 66 -#define STR_BOX_YNI 67 -#define STR_NO_REF_TABLE68 - -#define STR_PIVOTFUNC_SUM 69 // pivot.cxx -#define STR_PIVOTFUNC_COUNT 70 -#define STR_PIVOTFUNC_AVG 71 -#define STR_PIVOTFUNC_MAX 72 -#define STR_PIVOTFUNC_MIN 73 -#define STR_PIVOTFUNC_PROD 74 -#define STR_PIVOTFUNC_COUNT275 -#define STR_PIVOTFUNC_STDDEV76 -#define STR_PIVOTFUNC_STDDEV2 77 -#define STR_PIVOTFUNC_VAR 78 -#define STR_PIVOTFUNC_VAR2 79 -#define STR_PIVOT_TOTAL 80 -#define STR_PIVOT_DATA 81 - -#define STR_PIVOT_INVALID_DBAREA82 // tabvwsh3.cxx - -#define STR_TABLE 83 -#define STR_COLUMN 84 -#define STR_ROW 85 -#define STR_LOAD_DOC86 -#define STR_SAVE_DOC87 - -#define STR_ERR_INVALID_TABREF 88 -#define STR_AREA_ALREADY_INSERTED 89 -#define STR_INVALID_TABREF 90 -#define STR_INVALID_QUERYAREA 91 - -#define STR_REIMPORT_EMPTY 92 -#define STR_NOMULTISELECT 93 -#define STR_FILL_SERIES_PROGRESS94 // documen3.cxx - -#define STR_UNKNOWN_FILTER 95 - -#define STR_DATABASE_NOTFOUND 96 -#define STR_DATABASE_ABORTED97 - -#define STR_UNDO_PRINTRANGES98 - -#define STR_UNDO_DEC_INDENT 99 -#define STR_UNDO_INC_INDENT 100 -#define STR_UNDO_THESAURUS 101 - -#define STR_FILL_TAB102 -#define STR_NO_VALUE103 /* moved to compiler.src, keep define! */ -#define STR_UPDATE_SCENARIO 104 -#define STR_ERR_NEWSCENARIO 105 -#define STR_SCENARIO106 -#define STR_PIVOT_TABLE 107 -#define STR_NEWTABNAMENOTUNIQUE 108 - -#define STR_FUN_TEXT_SUM109 -#define STR_FUN_TEXT_COUNT 110 -#define STR_FUN_TEXT_AVG111 -#define STR_FUN_TEXT_MAX112 -#define STR_FUN_TEXT_MIN113 -#define STR_FUN_TEXT_PRODUCT114 -#define STR_FUN_TEXT_STDDEV 115 -#define STR_FUN_TEXT_VAR116 -#define STR_DOC_STAT117 - -#define STR_DBNAME_IMPORT 118 - -#define STR_NOCHARTATCURSOR 119 -#define STR_NOAREASELECTED 120 -#define STR_INVALIDTABNAME 121 - -#define STR_PIVOT_NOTFOUND 122 -#define STR_ERROR_STR 123 -#define STR_NV_STR 124 /* moved to compiler.src, keep define! */ -#define STR_EMPTYDATA 125 -#define STR_PIVOT_NODATA126 -#define STR_PIVOT_MOVENOTALLOWED127 - -#define STR_PRINT_INVALID_AREA 128 - -#define STR_PAGESTYLE 129 -#define STR_HEADER 130 -#define STR_FOOTER 131 - -#define STR_TEXTATTRS 132 - -#define STR_HFCMD_DELIMITER 133 -#define STR_HFCMD_PAGE 134 -#define STR_HFCMD_PAGES 135 -#define STR_HFCMD_DATE 136 -#define STR_HFCMD_TIME 137 -#define STR_HFCMD_FILE 138 -#define STR_HFCMD_TABLE 139 - -#define STR_PROTECTIONERR 140 - -#define STR_PAGEHEADER 141 -#define STR_PAGEFOOTER 142 -#define STR_PAGE143 -#define STR_LONG_ERR_ILL_ARG144 -#define STR_LONG_ERR_ILL_PAR145 -#define STR_LONG_ERR_ILL_FPO146 -#define STR_LONG_ERR_ILL_CHAR 147 -#define STR_LONG_ERR_ILL_SEP
[Libreoffice-bugs] [Bug 92580] Crash: when creating a table via wizard, go back then forth in a step
https://bugs.documentfoundation.org/show_bug.cgi?id=92580 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #6 from Alex Thurgood ipla...@yahoo.co.uk --- OK, so no crash for me in Version: 5.1.0.0.alpha1+ Build ID: 7f0161d88e3a496361e2209d31cc7e9ef42a677e Locale: fr-FR (fr.UTF-8) this is from yesterday, so more recent than your build on Debian. I'll reset this to unconfirmed and make my previous attachment obsolete, will open new bug report for that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92706] CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89561] Unsigned Language Packs not passing OS X Gatekeeper security -- disrupting LO installation on 10.9.x and later
https://bugs.documentfoundation.org/show_bug.cgi?id=89561 --- Comment #6 from mi...@filmsi.net --- Seems to work with LO50RC1-3 so I guess I can close it? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91981] LO50b2/3: New Start Center folder icons too big
https://bugs.documentfoundation.org/show_bug.cgi?id=91981 mi...@filmsi.net changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from mi...@filmsi.net --- Seems to be fixed in LO50RC3. Closing. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92707] New: Libreoffice Crashes Windows Explorer
https://bugs.documentfoundation.org/show_bug.cgi?id=92707 Bug ID: 92707 Summary: Libreoffice Crashes Windows Explorer Product: LibreOffice Version: 5.0.0.2 rc Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mjsu...@gmail.com Windows Explorer stops responding and restarts after moving the cursor over the icon or file name for an .odt, .odf, or .odb file. This occurs when using Windows Explorer or on the Windows Desktop. Steps to produce bug: (1) Navigate to a directory containing an .odt, .odf, or .odb file using Windows Explorer. (2) Move cursor over the file name or icon of the .odt or .odf file. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - editeng/source include/editeng include/svx svx/source
editeng/source/outliner/overflowingtxt.cxx |9 +-- include/editeng/overflowingtxt.hxx |8 +- include/svx/textchainflow.hxx |2 - svx/source/svdraw/textchainflow.cxx| 34 + 4 files changed, 33 insertions(+), 20 deletions(-) New commits: commit 0c01a319097cc79e3860d1ac3d760de912bbe887 Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 12:32:43 2015 -0400 Move logic for para merging to editeng Change-Id: I10ed532d8a42dbcb2f4c5aaa52f1848dde6745e6 diff --git a/editeng/source/outliner/overflowingtxt.cxx b/editeng/source/outliner/overflowingtxt.cxx index 45e8f51..eb6bfe5 100644 --- a/editeng/source/outliner/overflowingtxt.cxx +++ b/editeng/source/outliner/overflowingtxt.cxx @@ -111,10 +111,12 @@ OutlinerParaObject *OverflowingText::GetJuxtaposedParaObject(Outliner *pOutl, Ou // class OFlowChainedText -OFlowChainedText::OFlowChainedText(Outliner *pOutl) +OFlowChainedText::OFlowChainedText(Outliner *pOutl, bool bIsDeepMerge) { mpOverflowingTxt = pOutl-GetOverflowingText(); mpNonOverflowingTxt = pOutl-GetNonOverflowingText(); + +mbIsDeepMerge = bIsDeepMerge; } ESelection OFlowChainedText::GetInsertionPointSel() const @@ -129,7 +131,7 @@ ESelection OFlowChainedText::GetOverflowPointSel() const OutlinerParaObject *OFlowChainedText::CreateOverflowingParaObject(Outliner *pOutliner, OutlinerParaObject *pTextToBeMerged) { -// Just return the roughly merged paras fpr now +// Just return the roughly merged paras for now if (mpOverflowingTxt == NULL || pTextToBeMerged == NULL) return NULL; @@ -152,9 +154,10 @@ bool OFlowChainedText::IsLastParaInterrupted() const // classes UFlowChainedText -UFlowChainedText::UFlowChainedText(Outliner *pOutl) +UFlowChainedText::UFlowChainedText(Outliner *pOutl, bool bIsDeepMerge) { mpUnderflowPObj = pOutl-CreateParaObject(); +mbIsDeepMerge = bIsDeepMerge; } OutlinerParaObject *UFlowChainedText::CreateMergedUnderflowParaObject(Outliner *pOutl, OutlinerParaObject *pNextLinkWholeText) diff --git a/include/editeng/overflowingtxt.hxx b/include/editeng/overflowingtxt.hxx index 2f63cea..345daa8 100644 --- a/include/editeng/overflowingtxt.hxx +++ b/include/editeng/overflowingtxt.hxx @@ -81,7 +81,7 @@ private: class EDITENG_DLLPUBLIC OFlowChainedText { public: -OFlowChainedText(Outliner *); +OFlowChainedText(Outliner *, bool ); OutlinerParaObject *CreateOverflowingParaObject(Outliner *, OutlinerParaObject *); OutlinerParaObject *CreateNonOverflowingParaObject(Outliner *); @@ -99,18 +99,22 @@ class EDITENG_DLLPUBLIC OFlowChainedText { NonOverflowingText *mpNonOverflowingTxt; OverflowingText *mpOverflowingTxt; +bool mbIsDeepMerge; + }; // UFlowChainedText is a simpler class than OFlowChainedText: it almost only joins para-objects class EDITENG_DLLPUBLIC UFlowChainedText { public: -UFlowChainedText(Outliner *); +UFlowChainedText(Outliner *, bool); OutlinerParaObject *CreateMergedUnderflowParaObject(Outliner *, OutlinerParaObject *); protected: private: OutlinerParaObject *mpUnderflowPObj; + +bool mbIsDeepMerge; }; #endif diff --git a/include/svx/textchainflow.hxx b/include/svx/textchainflow.hxx index 8e8ad62..f96ce59 100644 --- a/include/svx/textchainflow.hxx +++ b/include/svx/textchainflow.hxx @@ -104,8 +104,6 @@ class TextChainFlow { OFlowChainedText *mpOverflChText; UFlowChainedText *mpUnderflChText; -bool mbMustMergeParaAmongLinks; - }; diff --git a/svx/source/svdraw/textchainflow.cxx b/svx/source/svdraw/textchainflow.cxx index 50bddb5..57147d3 100644 --- a/svx/source/svdraw/textchainflow.cxx +++ b/svx/source/svdraw/textchainflow.cxx @@ -41,7 +41,6 @@ TextChainFlow::TextChainFlow(SdrTextObj *pChainTarget) maCursorEvent = CursorChainingEvent::NULL_EVENT; mbPossiblyCursorOut = false; -mbMustMergeParaAmongLinks = false; } @@ -90,11 +89,26 @@ void TextChainFlow::impCheckForFlowEvents(SdrOutliner *pFlowOutl, SdrOutliner *p pFlowOutl-SetUpdateMode(bOldUpdateMode); } +// Get old state on whether to merge para-s or not +// NOTE: We handle UF/OF using the _old_ state. The new one is simply saved +bool bMustMergeParaAmongLinks = GetTextChain()-GetIsPartOfLastParaInNextLink(mpTargetLink); + // Set (Non)OverflowingTxt here (if any) -mpOverflChText = bOverflow ? new OFlowChainedText(pFlowOutl) : NULL; +mpOverflChText = bOverflow ? new OFlowChainedText(pFlowOutl, bMustMergeParaAmongLinks) : NULL; // Set current underflowing text (if any) -mpUnderflChText = bUnderflow ? new UFlowChainedText(pFlowOutl) : NULL; +mpUnderflChText = bUnderflow ? new UFlowChainedText(pFlowOutl, bMustMergeParaAmongLinks) : NULL; + +// update new state on paragraph merging +if (bOverflow) { +
[Libreoffice-bugs] [Bug 92269] 5.0.0.1 Win 64 Explorer Crash after single click on any LO file in folder. (shlxthdl.dll / propertyhdl.dll property handler problem?)
https://bugs.documentfoundation.org/show_bug.cgi?id=92269 mjsu...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #34 from mjsu...@gmail.com --- Resolved in 5.0.0.3 RC on 32-bit Windows 7, but can't speak to 64-bit versions of Windows. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/layer/tile/GridLayer.js |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 449c0a387f59ad075cb880d1cb688ec9586120a9 Author: Mihai Varga mihai.va...@collabora.com Date: Mon Jul 13 20:06:30 2015 +0300 loleaflet: check already visited tiles when prefetching In order to avoid duplicate tiles diff --git a/loleaflet/src/layer/tile/GridLayer.js b/loleaflet/src/layer/tile/GridLayer.js index fc67031..7a59ae4 100644 --- a/loleaflet/src/layer/tile/GridLayer.js +++ b/loleaflet/src/layer/tile/GridLayer.js @@ -546,8 +546,8 @@ L.GridLayer = L.Layer.extend({ if (coords.x 0 || coords.y 0) { return false; } - if (coords.x * this._tileWidthTwips this._docWidthTwips || - coords.y * this._tileHeightTwips this._docHeightTwips) { + if (coords.x * this._tileWidthTwips = this._docWidthTwips || + coords.y * this._tileHeightTwips = this._docHeightTwips) { return false; } return true; @@ -806,6 +806,7 @@ L.GridLayer = L.Layer.extend({ } var queue = [], finalQueue = [], + visitedTiles = {}, tilesToFetch = 10, borderWidth = 0; // don't search on a border wider than 5 tiles because it will freeze the UI @@ -845,10 +846,12 @@ L.GridLayer = L.Layer.extend({ if (!this._isValidTile(coords) || this._tiles[key] || - this._tileCache[key]) { + this._tileCache[key] || + visitedTiles[key]) { continue; } + visitedTiles[key] = true; finalQueue.push(coords); tilesToFetch -= 1; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/jmux/kde4-vcl-5-0-fix' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92710] New: LibreOffice 5.0.0.3 RC for Mac
https://bugs.documentfoundation.org/show_bug.cgi?id=92710 Bug ID: 92710 Summary: LibreOffice 5.0.0.3 RC for Mac Product: LibreOffice Version: 5.0.0.3 rc Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: rah...@aol.com Right-t-Left direction for Arabic is not working in the the latest release, 5.0.0.3. It works fine in the earlier release, 5.0.0.2. Something happened in this release to break the support for Arabic. When you switching the direction to RTL, the cursor goes to the right but the direction of the text does not change! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 Michael Fiedler michael.fiedle...@gmx.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |NOTABUG -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92709] New: UI: Manage Conditional Formatting column header reads Range or formula expression instead of Range
https://bugs.documentfoundation.org/show_bug.cgi?id=92709 Bug ID: 92709 Summary: UI: Manage Conditional Formatting column header reads Range or formula expression instead of Range Product: LibreOffice Version: 5.0.0.0.beta1 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: er...@redhat.com Conditional formats are applied to ranges, not expressions. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92709] UI: Manage Conditional Formatting column header reads Range or formula expression instead of Range
https://bugs.documentfoundation.org/show_bug.cgi?id=92709 Eike Rathke er...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4-5' - vcl/source
vcl/source/gdi/jobset.cxx | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) New commits: commit 9051d3b59cf6e5fd590506bb86bfb8929d3024c3 Author: Caolán McNamara caol...@redhat.com Date: Mon Jan 26 11:26:41 2015 + coverity#1266485 Untrusted value as argument Change-Id: I7708ecaf5412535055584ed6c71beaa9cd71c10c (cherry picked from commit 0934ed1a40c59c169354b177d7dab4228de66171) min legal size here is 4 (cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3) Change-Id: I9f68d000b32623db4d949d13284043630f5689f4 (cherry picked from commit 964000d415bcf491704dad57aee7e0656ea60dab) Reviewed-on: https://gerrit.libreoffice.org/16984 Reviewed-by: David Tardon dtar...@redhat.com Reviewed-by: Björn Michaelsen bjoern.michael...@canonical.com Reviewed-by: Eike Rathke er...@redhat.com Reviewed-by: Michael Meeks michael.me...@collabora.com Tested-by: Michael Meeks michael.me...@collabora.com diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx index ec1f44f..c67255e 100644 --- a/vcl/source/gdi/jobset.cxx +++ b/vcl/source/gdi/jobset.cxx @@ -218,19 +218,24 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) DBG_ASSERTWARNING( rIStream.GetVersion(), JobSetup:: - Solar-Version not set on rOStream ); { -sal_Size nFirstPos = rIStream.Tell(); - sal_uInt16 nLen = 0; rIStream.ReadUInt16( nLen ); -if ( !nLen ) +if (nLen = 4) return rIStream; sal_uInt16 nSystem = 0; rIStream.ReadUInt16( nSystem ); - -boost::scoped_arraychar pTempBuf(new char[nLen]); -rIStream.Read( pTempBuf.get(), nLen - sizeof( nLen ) - sizeof( nSystem ) ); -if ( nLen = sizeof(ImplOldJobSetupData)+4 ) +const size_t nRead = nLen - sizeof(nLen) - sizeof(nSystem); +if (nRead rIStream.remainingSize()) +{ +SAL_WARN(vcl, Parsing error: rIStream.remainingSize() + max possible entries, but nRead claimed, truncating); +return rIStream; +} +sal_Size nFirstPos = rIStream.Tell(); +boost::scoped_arraychar pTempBuf(new char[nRead]); +rIStream.Read(pTempBuf.get(), nRead); +if (nRead = sizeof(ImplOldJobSetupData)) { ImplOldJobSetupData* pData = (ImplOldJobSetupData*)pTempBuf.get(); if ( rJobSetup.mpData ) @@ -255,7 +260,7 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) nSystem == JOBSET_FILE605_SYSTEM ) { Impl364JobSetupData* pOldJobData= (Impl364JobSetupData*)(pTempBuf.get() + sizeof( ImplOldJobSetupData )); -sal_uInt16 nOldJobDataSize = SVBT16ToShort( pOldJobData-nSize ); +sal_uInt16 nOldJobDataSize = SVBT16ToShort( pOldJobData-nSize ); pJobData-mnSystem = SVBT16ToShort( pOldJobData-nSystem ); pJobData-mnDriverDataLen = SVBT32ToUInt32( pOldJobData-nDriverDataLen ); pJobData-meOrientation = (Orientation)SVBT16ToShort( pOldJobData-nOrientation ); @@ -272,8 +277,8 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) } if( nSystem == JOBSET_FILE605_SYSTEM ) { -rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) + 4 + sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen ); -while( rIStream.Tell() nFirstPos + nLen ) +rIStream.Seek( nFirstPos + sizeof( ImplOldJobSetupData ) + sizeof( Impl364JobSetupData ) + pJobData-mnDriverDataLen ); +while( rIStream.Tell() nFirstPos + nRead ) { OUString aKey = read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8); OUString aValue = read_uInt16_lenPrefixed_uInt8s_ToOUString(rIStream, RTL_TEXTENCODING_UTF8); @@ -291,9 +296,9 @@ SvStream ReadJobSetup( SvStream rIStream, JobSetup rJobSetup ) else pJobData-maValueMap[ aKey ] = aValue; } -DBG_ASSERT( rIStream.Tell() == nFirstPos+nLen, corrupted job setup ); +DBG_ASSERT( rIStream.Tell() == nFirstPos+nRead, corrupted job setup ); // ensure correct stream position -rIStream.Seek( nFirstPos + nLen ); +rIStream.Seek(nFirstPos + nRead); } } } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 91452] Assigning Formats by Formula Help
https://bugs.documentfoundation.org/show_bug.cgi?id=91452 --- Comment #3 from Valter Mura valterm...@gmail.com --- These imperfections are due to imperfect synchronization between online help and web help. All of these are to be checked, but most likely will disappear once all web pages will be synchronized again. I do not close the issue, and will have a look once the new LibreOffice version will be issued. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92711] New: Autosave blocks all uses for new, but unsaved files
https://bugs.documentfoundation.org/show_bug.cgi?id=92711 Bug ID: 92711 Summary: Autosave blocks all uses for new, but unsaved files Product: LibreOffice Version: 4.1.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: blocker Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: balacob...@imap.cc Configure LibreOffice to autosave every 2 minutes (or less, if you don't want to wait as much to reproduce this like it happened to me now). I did: Window: Tools-Options -- Load/Save-General Check the options as showed: [V] Save autorc. every 2 minutes [V] Auto save documento too [ ] Edit doc. properties before saving [ ] Always create backup [V] Save URLs relat. to f.s. [V] Save URLs relat. to Internet Open any existing .odt document. Open a new window with a new document (or just do CTRL+N, if you prefer). Start writing the document, but DO NOT save it yet. After the 2 minutes time expires, the program will quickly show that progress bar on its status line (lower window part), that it always shows before saving, and will start flickering, repetitively and quickly. You cannot edit the document anymore, neither save it (menus don't open, as most thing are unresponsive). I can't figure out what I should/could do! This will usually result in the loss of many unsaved works, depending on how much time the person had it configured to autosave (it happened to me at least 3 times in the last two weeks...). If you cannot reproduce it with the steps I gave, I'll try it again. If there are other configurations that should affect this behaviour, please tell me and I'll check and add them to this report. Thank you -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #1 from Michael Fiedler michael.fiedle...@gmx.de --- Created attachment 117205 -- https://bugs.documentfoundation.org/attachment.cgi?id=117205action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92350] VSDX gradient fills are not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=92350 David Tardon dtar...@redhat.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |dtar...@redhat.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loleaflet/src
loleaflet/src/control/Control.Parts.js |2 +- loleaflet/src/control/Parts.js |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 786432b9848e22c81a6f2f4c7e8178d83e1166b8 Author: Mihai Varga mihai.va...@collabora.com Date: Mon Jul 13 19:16:46 2015 +0300 loleaflet: renamed 'previous' to 'prev' diff --git a/loleaflet/src/control/Control.Parts.js b/loleaflet/src/control/Control.Parts.js index 07f67f1..cc36f80 100644 --- a/loleaflet/src/control/Control.Parts.js +++ b/loleaflet/src/control/Control.Parts.js @@ -26,7 +26,7 @@ L.Control.Parts = L.Control.extend({ }, _prevPart: function () { - this._map.setPart('previous'); + this._map.setPart('prev'); }, _nextPart: function () { diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js index 69d9e83..84e9014 100644 --- a/loleaflet/src/control/Parts.js +++ b/loleaflet/src/control/Parts.js @@ -4,7 +4,7 @@ L.Map.include({ setPart: function (part) { var docLayer = this._docLayer - if (part === 'previous') { + if (part === 'prev') { if (docLayer._currentPart 0) { docLayer._currentPart -= 1; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92350] VSDX gradient fills are not imported
https://bugs.documentfoundation.org/show_bug.cgi?id=92350 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|dtar...@redhat.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92706] CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 --- Comment #3 from Julien Nabet serval2...@yahoo.fr --- Created attachment 117209 -- https://bugs.documentfoundation.org/attachment.cgi?id=117209action=edit bt with debug symbols on Linux On pc Debian x86-64 with master sources updated today, I could reproduce this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #4 from Gordo gordon1dr...@yahoo.com --- Created attachment 117210 -- https://bugs.documentfoundation.org/attachment.cgi?id=117210action=edit simple test document This attachment shows keep with next paragraph not working between sections. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89178] Mail merge does not change the merge fields in files to plain text
https://bugs.documentfoundation.org/show_bug.cgi?id=89178 --- Comment #7 from Valdir Barbosa valdir.barbos...@gmail.com --- Created attachment 117212 -- https://bugs.documentfoundation.org/attachment.cgi?id=117212action=edit mailmege -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: shell/source
shell/source/win32/ooofilereader/basereader.cxx |2 +- shell/source/win32/ooofilereader/contentreader.cxx |4 ++-- shell/source/win32/ooofilereader/metainforeader.cxx |4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 18f3cefd507461784003a10ab9699f7cf5b678c0 Author: Stephan Bergmann sberg...@redhat.com Date: Mon Jul 13 18:57:35 2015 +0200 warning C4101: unreferenced local variable Change-Id: I3d2d46c7b722557f3dbfd95eb2b8649f8078d4df diff --git a/shell/source/win32/ooofilereader/basereader.cxx b/shell/source/win32/ooofilereader/basereader.cxx index f4568aa..7035c8d 100644 --- a/shell/source/win32/ooofilereader/basereader.cxx +++ b/shell/source/win32/ooofilereader/basereader.cxx @@ -74,7 +74,7 @@ void CBaseReader::Initialize( const std::string ContentName) parser.parse(m_ZipContent[0], m_ZipContent.size()); } } -catch(std::exception ex) +catch(std::exception) { // OSL_ENSURE( false, ex.what() ); } diff --git a/shell/source/win32/ooofilereader/contentreader.cxx b/shell/source/win32/ooofilereader/contentreader.cxx index 8157abb..24c420a 100644 --- a/shell/source/win32/ooofilereader/contentreader.cxx +++ b/shell/source/win32/ooofilereader/contentreader.cxx @@ -34,7 +34,7 @@ CBaseReader( DocumentName ) m_DefaultLocale = DocumentLocale; Initialize( DOC_CONTENT_NAME ); } -catch(xml_parser_exception ex) +catch(xml_parser_exception) { // OSL_ENSURE(false, ex.what()); } @@ -52,7 +52,7 @@ try m_DefaultLocale = DocumentLocale; Initialize( DOC_CONTENT_NAME ); } -catch(xml_parser_exception ex) +catch(xml_parser_exception) { // OSL_ENSURE(false, ex.what()); } diff --git a/shell/source/win32/ooofilereader/metainforeader.cxx b/shell/source/win32/ooofilereader/metainforeader.cxx index d9c08c7..b45b850 100644 --- a/shell/source/win32/ooofilereader/metainforeader.cxx +++ b/shell/source/win32/ooofilereader/metainforeader.cxx @@ -53,7 +53,7 @@ CBaseReader( DocumentName ) Initialize( META_CONTENT_NAME ); } -catch(xml_parser_exception ex) +catch(xml_parser_exception) { // OSL_ENSURE(false, ex.what()); } @@ -90,7 +90,7 @@ try Initialize( META_CONTENT_NAME ); } -catch(xml_parser_exception ex) +catch(xml_parser_exception) { // OSL_ENSURE(false, ex.what()); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - include/svx svx/source
include/svx/textchain.hxx |7 +-- svx/source/svdraw/textchain.cxx |9 + 2 files changed, 6 insertions(+), 10 deletions(-) New commits: commit afe335ac3bf0bcd79ee58699f132cf4ad7e5aefe Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 11:12:05 2015 -0400 Add IsPartOfLastParaInNextLink Property Change-Id: I0410c4417bebb7ffb9cd162a1ecf3d5028f513fa diff --git a/include/svx/textchain.hxx b/include/svx/textchain.hxx index 6a70c8b..8d0ae47 100644 --- a/include/svx/textchain.hxx +++ b/include/svx/textchain.hxx @@ -117,6 +117,7 @@ class ImpChainLinkProperties INIT_CHAIN_PROP(CursorEvent, CursorChainingEvent::NULL_EVENT) INIT_CHAIN_PROP(PreChainingSel, ESelection(0,0,0,0)); INIT_CHAIN_PROP(PostChainingSel, ESelection(0,0,0,0)); +INIT_CHAIN_PROP(IsPartOfLastParaInNextLink, false) } private: @@ -125,6 +126,7 @@ class ImpChainLinkProperties DECL_CHAIN_PROP(CursorEvent, CursorChainingEvent) DECL_CHAIN_PROP(PreChainingSel, ESelection) DECL_CHAIN_PROP(PostChainingSel, ESelection) +DECL_CHAIN_PROP(IsPartOfLastParaInNextLink, bool) }; @@ -147,9 +149,10 @@ class TextChain { DECL_CHAIN_PROP_INTERFACE(NilChainingEvent, bool) DECL_CHAIN_PROP_INTERFACE(PreChainingSel, ESelection) DECL_CHAIN_PROP_INTERFACE(PostChainingSel, ESelection) +// return whether a paragraph is split between this box and the next +DECL_CHAIN_PROP_INTERFACE(IsPartOfLastParaInNextLink, bool) + -// return whether a paragraph is split between the two links in the argument -bool GetLinksHaveMergeableFirstPara(SdrTextObj *, SdrTextObj *); protected: LinkPropertiesMap maLinkPropertiesMap; diff --git a/svx/source/svdraw/textchain.cxx b/svx/source/svdraw/textchain.cxx index 36966bb..25b75ae 100644 --- a/svx/source/svdraw/textchain.cxx +++ b/svx/source/svdraw/textchain.cxx @@ -28,6 +28,7 @@ IMPL_CHAIN_PROP_INTERFACE(CursorEvent, CursorChainingEvent) IMPL_CHAIN_PROP_INTERFACE(NilChainingEvent, bool) IMPL_CHAIN_PROP_INTERFACE(PreChainingSel, ESelection) IMPL_CHAIN_PROP_INTERFACE(PostChainingSel, ESelection) +IMPL_CHAIN_PROP_INTERFACE(IsPartOfLastParaInNextLink, bool) /* End Definition of Properties Interface */ @@ -59,14 +60,6 @@ SdrTextObj *TextChain::GetNextLink(SdrTextObj *) const return NULL; // XXX: To be changed. It'd be a mess to implement now } - -bool TextChain::GetLinksHaveMergeableFirstPara(SdrTextObj* /* pPrevLink */, SdrTextObj* /* pNextLink */) -{ -// XXX -return false; -} - - ImpChainLinkProperties *TextChain::GetLinkProperties(const SdrTextObj *pLink) { // if the guy does not already have properties in the map make them ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92705] New: FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 Bug ID: 92705 Summary: FORMATTING: Keep with next paragraph not working reliably Product: LibreOffice Version: 4.4.2.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: michael.fiedle...@gmx.de Created attachment 117204 -- https://bugs.documentfoundation.org/attachment.cgi?id=117204action=edit Document that has the described problem on page 4 Environment: Debian GNU/Linux 7.8 (wheezy), x86, LibreOffice 4.4.2.2-2 or 4.4.4.3-3 from http://www.libreoffice.org/ Steps to reproduce: 0. start with a new LibreOffice configuration (may not be necessary), for Linux delete ~/.config/libreoffice 1. extract and install the font in the attached archive, for Linux cd ~ tar xf fonts.tar.gz should be enough 2. open the attached document 3. go to page 4 4. the Heading 1-formatted Faust: Der Tragödie erster Teil is placed at the end of the left column, although its paragraph style's and paragraph's text flow option Keep with next paragraph[1] is set (see attached screenshot). [1] https://help.libreoffice.org/Writer/Text_Flow#Keep_with_next_paragraph expected behaviour: The paragraph should be placed to the beginning of the next column as it must not be separate from the next one according to the format setting. workarounds: a) apply the paragraph formatting again, then the expected behaviour occurs b) add a paragraph before the affected one and delete it immediately, then the expected behaviour occurs and remains. However, the problem possibly may occur later again and one would have to check every page for such problems. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk/window/gtksalframe.cxx | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) New commits: commit 74f9d9808fce14f015d56a2aaa4ec5616ed7aa3e Author: Caolán McNamara caol...@redhat.com Date: Mon Jul 13 16:18:41 2015 +0100 Resolves: tdf#92671 union each monitor workarea to find best screen workarea Change-Id: Ia77063f7008f960373861b8b59710abe9918865c diff --git a/vcl/unx/gtk/window/gtksalframe.cxx b/vcl/unx/gtk/window/gtksalframe.cxx index 5496bf6..3bedf78 100644 --- a/vcl/unx/gtk/window/gtksalframe.cxx +++ b/vcl/unx/gtk/window/gtksalframe.cxx @@ -2157,10 +2157,16 @@ void GtkSalFrame::GetWorkArea( Rectangle rRect ) rRect = GetGtkSalData()-GetGtkDisplay()-getWMAdaptor()-getWorkArea( 0 ); #else GdkScreen *pScreen = gtk_window_get_screen(GTK_WINDOW(m_pWindow)); -gint nMonitor = gdk_screen_get_monitor_at_window(pScreen, widget_get_window(m_pWindow)); -GdkRectangle aRect; -gdk_screen_get_monitor_workarea(pScreen, nMonitor, aRect); -rRect = Rectangle(aRect.x, aRect.y, aRect.width, aRect.height); +Rectangle aRetRect; +int max = gdk_screen_get_n_monitors (pScreen); +for (int i = 0; i max; ++i) +{ +GdkRectangle aRect; +gdk_screen_get_monitor_workarea(pScreen, i, aRect); +Rectangle aMonitorRect(aRect.x, aRect.y, aRect.x+aRect.width, aRect.y+aRect.height); +aRetRect.Union(aMonitorRect); +} +rRect = aRetRect; #endif } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92671] GTK+3: Tooltips drawn on secondary screen
https://bugs.documentfoundation.org/show_bug.cgi?id=92671 --- Comment #2 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=74f9d9808fce14f015d56a2aaa4ec5616ed7aa3e Resolves: tdf#92671 union each monitor workarea to find best screen workarea It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92671] GTK+3: Tooltips drawn on secondary screen
https://bugs.documentfoundation.org/show_bug.cgi?id=92671 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 --- Comment #19 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Julien Nabet committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=429280541ff1fbbbf3f0482211a659c96c3347d2 tdf#92693: ReportBuilder: MINUTES() rounded to nearest for fractional minutes It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92693] EDITING: Function MINUTE() always 1 minute greater than minute in timefield/timestampfield in ReportDesigner
https://bugs.documentfoundation.org/show_bug.cgi?id=92693 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39478] Writer / Calc: Drawing toolbar buttons do not show as depressed
https://bugs.documentfoundation.org/show_bug.cgi?id=39478 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |momonas...@gmail.com |desktop.org | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92706] CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added Keywords||have-backtrace Priority|medium |high Status|UNCONFIRMED |NEW Ever confirmed|0 |1 OS|Mac OS X (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #5 from Gordo gordon1dr...@yahoo.com --- Created attachment 117211 -- https://bugs.documentfoundation.org/attachment.cgi?id=117211action=edit screenshot of overlapping text With the original document, if I enter empty paragraphs before the Faust heading to force it into the next column then the text overlaps. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #7 from Michael Fiedler michael.fiedle...@gmx.de --- (In reply to Gordo from comment #5) Created attachment 117211 [details] screenshot of overlapping text With the original document, if I enter empty paragraphs before the Faust heading to force it into the next column then the text overlaps. Hm, I cannot reproduce this here, if I add new paragraphs at the line So menschlich mit dem Teufel selbst zu sprechen. by pressing ENTER, the Faust: Der Tragödie Erster Teil paragraphs moves down just as it would happen without sections. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'private/jmux/trac#12015' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'private/jmux/libreoffice-4-2+kde4' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92705] FORMATTING: Keep with next paragraph not working reliably
https://bugs.documentfoundation.org/show_bug.cgi?id=92705 --- Comment #2 from Michael Fiedler michael.fiedle...@gmx.de --- Created attachment 117206 -- https://bugs.documentfoundation.org/attachment.cgi?id=117206action=edit Fonts needed to display the document correctly -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92671] GTK+3: Tooltips drawn on secondary screen
https://bugs.documentfoundation.org/show_bug.cgi?id=92671 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92580] Crash: when creating a table via wizard, go back then forth in a step
https://bugs.documentfoundation.org/show_bug.cgi?id=92580 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- @Julien : I get an immediate crash after registering the db on OSX, after having previously selected to proceed straight to the table creation wizard at the time the database is saved. In my trace, it looks like a VCL listener is being removed without checking the status of the radio buttons that had selected the launch of the table creation wizard. One for MM ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - editeng/source include/editeng
editeng/source/outliner/outliner.cxx | 10 -- editeng/source/outliner/overflowingtxt.cxx | 10 -- include/editeng/overflowingtxt.hxx |4 +++- 3 files changed, 19 insertions(+), 5 deletions(-) New commits: commit 1f71d4b088f43611094ae95d53c6bea44bf7a9ad Author: matteocam matteo.campane...@gmail.com Date: Mon Jul 13 11:29:58 2015 -0400 Add bLastParaInterrupted to NonOverflowingText Change-Id: Ie6864bfbce088fabd3fba65c3e1313bc2fafcbac diff --git a/editeng/source/outliner/outliner.cxx b/editeng/source/outliner/outliner.cxx index 2b03d26..a8e5be0 100644 --- a/editeng/source/outliner/outliner.cxx +++ b/editeng/source/outliner/outliner.cxx @@ -2131,7 +2131,8 @@ NonOverflowingText *Outliner::GetNonOverflowingText() const { ESelection aEmptySel(0,0,0,0); EditTextObject *pTObj = pEditEngine-CreateTextObject(aEmptySel); -return new NonOverflowingText(pTObj); +bool bLastParaInterrupted = true; // Last Para was interrupted since everything overflew +return new NonOverflowingText(pTObj, bLastParaInterrupted); } else { // Get the lines that of the overflowing para fit in the box sal_Int32 nOverflowingPara = nCount; @@ -2159,7 +2160,12 @@ NonOverflowingText *Outliner::GetNonOverflowingText() const ESelection(nStartPara, nStartPos, nOverflowingPara, nLen); } EditTextObject *pTObj = pEditEngine-CreateTextObject(aNonOverflowingTextSelection); -return new NonOverflowingText(pTObj); + +sal_Int32 nLastLine = GetLineCount(nOverflowingPara)-1; +bool bLastParaInterrupted = +pEditEngine-GetOverflowingLineNum() nLastLine; + +return new NonOverflowingText(pTObj, bLastParaInterrupted); } } diff --git a/editeng/source/outliner/overflowingtxt.cxx b/editeng/source/outliner/overflowingtxt.cxx index 339a335..9b6da0a 100644 --- a/editeng/source/outliner/overflowingtxt.cxx +++ b/editeng/source/outliner/overflowingtxt.cxx @@ -55,12 +55,18 @@ ESelection OverflowingText::GetInsertionPointSel() const // class NonOverflowingText -NonOverflowingText::NonOverflowingText(const EditTextObject *pTObj) -: mpContentTextObj(pTObj-Clone()) +NonOverflowingText::NonOverflowingText(const EditTextObject *pTObj, bool bLastParaInterrupted) +: mpContentTextObj(pTObj-Clone()), + mbLastParaInterrupted(bLastParaInterrupted) { // XXX: may have to delete pTObj } +bool NonOverflowingText::IsLastParaInterrupted() const +{ +return mbLastParaInterrupted; +} + OutlinerParaObject *NonOverflowingText::ToParaObject(Outliner *pOutliner) const { diff --git a/include/editeng/overflowingtxt.hxx b/include/editeng/overflowingtxt.hxx index 72d2355..449ca5a 100644 --- a/include/editeng/overflowingtxt.hxx +++ b/include/editeng/overflowingtxt.hxx @@ -60,13 +60,15 @@ class NonOverflowingText { public: OutlinerParaObject *ToParaObject(Outliner *) const; ESelection GetOverflowPointSel() const; +bool IsLastParaInterrupted() const; private: // Constructor -NonOverflowingText(const EditTextObject *pTObj); +NonOverflowingText(const EditTextObject *pTObj, bool bLastParaInterrupted); friend class Outliner; const EditTextObject *mpContentTextObj; +const bool mbLastParaInterrupted; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: external/jfreereport
external/jfreereport/UnpackedTarball_jfreereport_libformula.mk |1 external/jfreereport/patches/libformula-minutes_truncation.patch.1 | 17 ++ 2 files changed, 18 insertions(+) New commits: commit 429280541ff1fbbbf3f0482211a659c96c3347d2 Author: Julien Nabet serval2...@yahoo.fr Date: Mon Jul 13 16:03:15 2015 +0200 tdf#92693: ReportBuilder: MINUTES() rounded to nearest for fractional minutes ... instead of the correct truncation. Thanks to Lionel for the idea of the fix and his patience for newbies like me! Change-Id: Iae9ec9251c0beb0c1856a6573f6ff7963d216256 Reviewed-on: https://gerrit.libreoffice.org/17012 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Lionel Elie Mamane lio...@mamane.lu diff --git a/external/jfreereport/UnpackedTarball_jfreereport_libformula.mk b/external/jfreereport/UnpackedTarball_jfreereport_libformula.mk index 2bc3229..bb78966 100644 --- a/external/jfreereport/UnpackedTarball_jfreereport_libformula.mk +++ b/external/jfreereport/UnpackedTarball_jfreereport_libformula.mk @@ -18,6 +18,7 @@ $(eval $(call gb_UnpackedTarball_fix_end_of_line,jfreereport_libformula,\ $(eval $(call gb_UnpackedTarball_add_patches,jfreereport_libformula,\ external/jfreereport/patches/common_build.patch \ external/jfreereport/patches/libformula-time-notz.patch \ + external/jfreereport/patches/libformula-minutes_truncation.patch.1 \ )) # vim: set noet sw=4 ts=4: diff --git a/external/jfreereport/patches/libformula-minutes_truncation.patch.1 b/external/jfreereport/patches/libformula-minutes_truncation.patch.1 new file mode 100644 index 000..0df98db --- /dev/null +++ b/external/jfreereport/patches/libformula-minutes_truncation.patch.1 @@ -0,0 +1,17 @@ +Seulement dans jfreereport_libformula: bin +Seulement dans jfreereport_libformula: build.log +Seulement dans jfreereport_libformula: dist +diff -ur jfreereport_libformula.org/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java jfreereport_libformula/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java +--- jfreereport_libformula.org/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java 2015-07-13 15:55:31.752539618 +0200 jfreereport_libformula/source/org/pentaho/reporting/libraries/formula/function/datetime/MinuteFunction.java 2015-07-13 15:56:27.084394065 +0200 +@@ -74,7 +74,7 @@ + + // Multiply the minutes with 60 to get the minutes as ints + final BigDecimal minutes = minutesFraction.multiply(MINUTES); +-final BigDecimal minutesAsInt = minutes.setScale(0, BigDecimal.ROUND_HALF_UP); ++final BigDecimal minutesAsInt = NumberUtil.performIntRounding(minutes); + return new TypeValuePair(NumberType.GENERIC_NUMBER, minutesAsInt); + } +-} +\ Pas de fin de ligne à la fin du fichier ++} ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92706] New: CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 Bug ID: 92706 Summary: CRASH - when autmatically launching table creation wizard after registration of database Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ipla...@yahoo.co.uk Version: 5.1.0.0.alpha1+ Build ID: 7f0161d88e3a496361e2209d31cc7e9ef42a677e Locale: fr-FR (fr.UTF-8) 1) Start LO Base 2) Select Create new database (embedde hsqldb) 3) Click on Next. 4) In the following wizard screen , tick the box create table using the table wizard 5) Save the database 6) Crash -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92706] CRASH - when autmatically launching table creation wizard after registration of database
https://bugs.documentfoundation.org/show_bug.cgi?id=92706 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 117208 -- https://bugs.documentfoundation.org/attachment.cgi?id=117208action=edit Full bt -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source cli_ure/source connectivity/source cppu/source cui/source dbaccess/source dtrans/source editeng/source extensions/source filter/source forms/source fpicker
UnoControls/source/controls/progressmonitor.cxx|3 -- UnoControls/source/inc/progressmonitor.hxx |4 -- basic/source/basmgr/basicmanagerrepository.cxx | 10 +- basic/source/basmgr/basmgr.cxx | 14 ++--- cli_ure/source/uno_bridge/cli_environment.cxx |2 + connectivity/source/manager/mdrivermanager.cxx |5 --- cppu/source/uno/lbenv.cxx |2 - cui/source/dialogs/cuifmsearch.cxx |5 --- cui/source/tabpages/chardlg.cxx|2 - dbaccess/source/core/api/RowSetBase.cxx|2 - dbaccess/source/core/misc/dsntypes.cxx |2 + dbaccess/source/ext/macromigration/progressmixer.cxx |3 -- dbaccess/source/ui/browser/unodatbr.cxx| 12 +--- dbaccess/source/ui/dlg/DbAdminImpl.cxx |3 -- dbaccess/source/ui/dlg/DbAdminImpl.hxx |2 - dbaccess/source/ui/inc/unodatbr.hxx|2 - dbaccess/source/ui/misc/TokenWriter.cxx|2 + dbaccess/source/ui/tabledesign/FieldDescGenWin.cxx |2 - dbaccess/source/ui/tabledesign/FieldDescGenWin.hxx |3 -- dtrans/source/win32/clipb/MtaOleClipb.cxx |5 --- dtrans/source/win32/dtobj/APNDataObject.cxx|2 - editeng/source/editeng/textconv.cxx|2 + editeng/source/misc/hangulhanja.cxx|5 --- extensions/source/abpilot/fieldmappingimpl.cxx |6 +--- extensions/source/logging/filehandler.cxx |9 +- extensions/source/propctrlr/cellbindinghandler.cxx | 10 +- filter/source/config/cache/filtercache.cxx |2 + filter/source/xmlfilteradaptor/XmlFilterAdaptor.cxx|8 - filter/source/xsltfilter/XSLTFilter.cxx|4 -- forms/source/component/Columns.cxx |2 - forms/source/runtime/formoperations.cxx|4 ++ forms/source/xforms/propertysetbase.cxx|4 -- fpicker/source/office/commonpicker.cxx |4 -- fpicker/source/office/iodlgimp.cxx |5 --- fpicker/source/win32/filepicker/dibpreview.cxx |6 include/osl/diagnose.h |6 include/tools/debug.hxx| 22 ++ reportdesign/source/filter/xml/xmlControlProperty.cxx | 10 -- reportdesign/source/ui/report/dlgedclip.cxx|9 +- sal/osl/w32/security.c |6 +--- sax/source/tools/converter.cxx |5 --- sc/source/core/tool/interpr3.cxx |2 - sd/source/core/drawdoc3.cxx|5 --- sd/source/ui/slidesorter/controller/SlsSlotManager.cxx |2 - sd/source/ui/view/drviews2.cxx |5 --- sd/source/ui/view/sdview2.cxx |5 --- sfx2/source/doc/objstor.cxx|6 shell/source/win32/ooofilereader/basereader.cxx|6 shell/source/win32/ooofilereader/contentreader.cxx | 12 +--- shell/source/win32/ooofilereader/metainforeader.cxx| 12 +--- shell/source/win32/simplemail/senddoc.cxx |6 sot/source/sdstor/stg.cxx |6 svl/source/items/poolitem.cxx |6 svl/source/misc/urihelper.cxx |2 - svtools/source/brwbox/editbrowsebox2.cxx |6 svtools/source/contnr/svimpbox.cxx |5 --- svtools/source/contnr/treelist.cxx |2 - svtools/source/contnr/treelistbox.cxx |9 -- svtools/source/control/asynclink.cxx |6 svtools/source/dialogs/addresstemplate.cxx |4 -- svtools/source/svrtf/parrtf.cxx|5 --- svtools/source/uno/addrtempuno.cxx | 15 ++ svx/source/fmcomp/dbaexchange.cxx | 22 +++--- svx/source/fmcomp/dbaobjectex.cxx |9 +- svx/source/fmcomp/gridctrl.cxx |2 - svx/source/form/fmpgeimp.cxx |6 svx/source/form/navigatortree.cxx |8 +++-- svx/source/svdraw/svdundo.cxx | 25 +++-- svx/source/unodraw/unoshape.cxx|2 - sw/source/filter/xml/XMLRedlineImportHelper.cxx| 10 +- toolkit/source/controls/accessiblecontrolcontext.cxx |6 tools/source/ref/pstm.cxx |2 + tools/source/stream/stream.cxx |2 + unotools/source/config/bootstrap.cxx