[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/output.hxx|4 +--
sc/source/ui/view/gridwin4.cxx |2 -
sc/source/ui/view/output.cxx | 52 -
sc/source/ui/view/printfun.cxx |7 +++--
4 files changed, 33 insertions(+), 32 deletions(-)
New commits:
commit c7350070cca3e68013b3e481d90855ab6f8344ec
Author: Krisztian Pinter pin.termina...@gmail.com
Date: Fri Jun 19 22:55:50 2015 +0200
calc mapmode: Pass RenderContext as reference in DrawFrame
Change-Id: I6c9a476a8dea5266868c94d6a1203cfe840171cf
diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index d577efa..77d50f6 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -239,7 +239,7 @@ private:
double GetStretch();
-voidDrawRotatedFrame( const Color* pForceColor ); //
pixel
+voidDrawRotatedFrame(vcl::RenderContext rRenderContext, const
Color* pForceColor); // pixel
drawinglayer::processor2d::BaseProcessor2D* CreateProcessor2D( );
@@ -307,7 +307,7 @@ public:
voidDrawBackground(vcl::RenderContext rRenderContext);
voidDrawShadow();
voidDrawExtraShadow(bool bLeft, bool bTop, bool bRight, bool bBottom);
-voidDrawFrame();
+voidDrawFrame(vcl::RenderContext rRenderContext);
// with logic MapMode set!
voidDrawEdit(bool bPixelToLogic);
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index b2e76c4..26ed6ae 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -743,7 +743,7 @@ void ScGridWindow::DrawContent(OutputDevice rDevice, const
ScTableInfo rTableI
}
aOutputData.DrawShadow();
-aOutputData.DrawFrame();
+aOutputData.DrawFrame(*pContentDev);
// Show Note Mark
if ( rOpts.GetOption( VOPT_NOTES ) )
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 388b0e8..de67cc3 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -1286,9 +1286,9 @@ size_t lclGetArrayColFromCellInfoX( sal_uInt16
nCellInfoX, sal_uInt16 nCellInfoF
return static_cast size_t ( bRTL ? (nCellInfoLastX + 2 - nCellInfoX) :
(nCellInfoX - nCellInfoFirstX) );
}
-void ScOutputData::DrawFrame()
+void ScOutputData::DrawFrame(vcl::RenderContext rRenderContext)
{
-DrawModeFlags nOldDrawMode = mpDev-GetDrawMode();
+DrawModeFlags nOldDrawMode = rRenderContext.GetDrawMode();
Color aSingleColor;
bool bUseSingleColor = false;
@@ -1302,13 +1302,13 @@ void ScOutputData::DrawFrame()
if ( ( nOldDrawMode DrawModeFlags::WhiteFill ) ( nOldDrawMode
DrawModeFlags::BlackLine ) )
{
-mpDev-SetDrawMode( nOldDrawMode (~DrawModeFlags::WhiteFill) );
+rRenderContext.SetDrawMode( nOldDrawMode (~DrawModeFlags::WhiteFill)
);
aSingleColor.SetColor( COL_BLACK );
bUseSingleColor = true;
}
else if ( ( nOldDrawMode DrawModeFlags::SettingsFill ) ( nOldDrawMode
DrawModeFlags::SettingsLine ) )
{
-mpDev-SetDrawMode( nOldDrawMode (~DrawModeFlags::SettingsFill) );
+rRenderContext.SetDrawMode( nOldDrawMode
(~DrawModeFlags::SettingsFill) );
aSingleColor = rStyleSettings.GetWindowTextColor(); // same as
used in VCL for DrawModeFlags::SettingsLine
bUseSingleColor = true;
}
@@ -1321,12 +1321,12 @@ void ScOutputData::DrawFrame()
const Color* pForceColor = bUseSingleColor ? aSingleColor : 0;
if (bAnyRotated)
-DrawRotatedFrame( pForceColor );// removes the lines that must
not be painted here
+DrawRotatedFrame(rRenderContext, pForceColor);// removes the
lines that must not be painted here
long nInitPosX = nScrX;
if ( bLayoutRTL )
{
-Size aOnePixel = mpDev-PixelToLogic(Size(1,1));
+Size aOnePixel = rRenderContext.PixelToLogic(Size(1,1));
long nOneX = aOnePixel.Width();
nInitPosX += nMirrorW - nOneX;
}
@@ -1343,12 +1343,12 @@ void ScOutputData::DrawFrame()
// row 0 is not visible (dummy for borders from top) - subtract its height
from initial position
// subtract 1 unit more, because position 0 is first *in* cell, grid line
is one unit before
long nOldPosY = nScrY - 1 - pRowInfo[ 0 ].nHeight;
-long nOldSnapY = lclGetSnappedY( *mpDev, nOldPosY, bSnapPixel );
+long nOldSnapY = lclGetSnappedY( rRenderContext, nOldPosY, bSnapPixel );
rArray.SetYOffset( nOldSnapY );
for( size_t nRow = 0; nRow nRowCount; ++nRow )
{
long nNewPosY = nOldPosY + pRowInfo[ nRow ].nHeight;
-long nNewSnapY = lclGetSnappedY( *mpDev, nNewPosY, bSnapPixel );
+long nNewSnapY = lclGetSnappedY( rRenderContext, nNewPosY, bSnapPixel
);
rArray.SetRowHeight( nRow, nNewSnapY - nOldSnapY );
nOldPosY = nNewPosY;
nOldSnapY = nNewSnapY;
@@ -1359,7 +1359,7 @@ void ScOutputData::DrawFrame()
[Libreoffice-commits] core.git: sc/source
sc/source/ui/inc/output.hxx|2 +-
sc/source/ui/view/gridwin4.cxx |2 +-
sc/source/ui/view/output.cxx | 10 +-
3 files changed, 7 insertions(+), 7 deletions(-)
New commits:
commit f1cf05d81d80c87b9942daff5d60dc0ebdd474b5
Author: Krisztian Pinter pin.termina...@gmail.com
Date: Tue Jun 23 22:30:57 2015 +0200
calc mapmode: Pass RenderContext as reference in DrawNoteMarks
Change-Id: Id47f4001943bd40fb8476c7e6a81f257b34c2c7d
diff --git a/sc/source/ui/inc/output.hxx b/sc/source/ui/inc/output.hxx
index 77d50f6..861faf9 100644
--- a/sc/source/ui/inc/output.hxx
+++ b/sc/source/ui/inc/output.hxx
@@ -340,7 +340,7 @@ public:
voidDrawChangeTrack();
voidDrawClipMarks();
-voidDrawNoteMarks();
+voidDrawNoteMarks(vcl::RenderContext rRenderContext);
voidAddPDFNotes();
};
diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 26ed6ae..7282b90 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -747,7 +747,7 @@ void ScGridWindow::DrawContent(OutputDevice rDevice, const
ScTableInfo rTableI
// Show Note Mark
if ( rOpts.GetOption( VOPT_NOTES ) )
-aOutputData.DrawNoteMarks();
+aOutputData.DrawNoteMarks(*pContentDev);
if ( !bLogicText )
aOutputData.DrawStrings(false); // in pixel MapMode
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index de67cc3..ce60133 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -2291,7 +2291,7 @@ void ScOutputData::DrawChangeTrack()
}
//TODO: moggi Need to check if this can't be written simpler
-void ScOutputData::DrawNoteMarks()
+void ScOutputData::DrawNoteMarks(vcl::RenderContext rRenderContext)
{
bool bFirst = true;
@@ -2329,13 +2329,13 @@ void ScOutputData::DrawNoteMarks()
{
if (bFirst)
{
-mpDev-SetLineColor(COL_WHITE);
+rRenderContext.SetLineColor(COL_WHITE);
const StyleSettings rStyleSettings =
Application::GetSettings().GetStyleSettings();
if ( mbUseStyleColor
rStyleSettings.GetHighContrastMode() )
-mpDev-SetFillColor(
SC_MOD()-GetColorConfig().GetColorValue(svtools::FONTCOLOR).nColor );
+rRenderContext.SetFillColor(
SC_MOD()-GetColorConfig().GetColorValue(svtools::FONTCOLOR).nColor );
else
-mpDev-SetFillColor(COL_LIGHTRED);
+rRenderContext.SetFillColor(COL_LIGHTRED);
bFirst = false;
}
@@ -2352,7 +2352,7 @@ void ScOutputData::DrawNoteMarks()
}
}
if ( bLayoutRTL ? ( nMarkX = 0 ) : ( nMarkX nScrX+nScrW
) )
-mpDev-DrawRect( Rectangle(
nMarkX-5*nLayoutSign,nPosY,nMarkX+1*nLayoutSign,nPosY+6 ) );
+rRenderContext.DrawRect( Rectangle(
nMarkX-5*nLayoutSign,nPosY,nMarkX+1*nLayoutSign,nPosY+6 ) );
}
nPosX += pRowInfo[0].pCellInfo[nX+1].nWidth * nLayoutSign;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92841] FILESAVE: some .xlsx files can't be opened with MS FileFormatConverter or older LibO
https://bugs.documentfoundation.org/show_bug.cgi?id=92841 --- Comment #6 from Andrej andrej...@gmail.com --- Created attachment 117409 -- https://bugs.documentfoundation.org/attachment.cgi?id=117409action=edit Original; saved from Office2010; saved from LibreOffice again. Save as... from MS Office 2010 partially fixed file and FileFormatConverter can open it. Would be good, if LibreOffice could repair file in same way (of course, if this will not take too much development resources from other and more important tasks) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Hardware|x86 (IA32) |x86-64 (AMD64) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- AFAIK, there are no other testers on OSX Beta El Cap, so if it is OS-specifc (although it seems to me that the problem is there already in Yosemite), then it is unlikely to get fixed until / unless a developer can get their hands on a beta copy, install it and set it up, to be able to confirm. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92903] Base: text displayed offset in table edit UI listbox dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=92903 --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Can not reproduce on Version: 5.1.0.0.alpha1+ Build ID: 74d7136325ca00534bbb76351bf79cf43afc8a56 Locale: fr-FR (fr.UTF-8) OSX 10.10.4 Maybe KDE/Suse specific ? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92908] New: Viewing: scrolling breaks , rectangles, basic shapes, arrows, etc
https://bugs.documentfoundation.org/show_bug.cgi?id=92908 Bug ID: 92908 Summary: Viewing: scrolling breaks , rectangles, basic shapes, arrows, etc Product: LibreOffice Version: 4.4.3.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: myaravi...@gmail.com Created attachment 117410 -- https://bugs.documentfoundation.org/attachment.cgi?id=117410action=edit Open and scroll up and down to test. The screen is not refreshing properly during scrolling. So scrolling breaks , rectangles, basic shapes, arrows, etc OS: Linux mint 17.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [GSoC] Integrating LO with GNOME - WR#8
Hi,
After a bit of research and discussion with Miklos, I decided to go
with ThreadPool instead of using async queue approach, since I could
not find any downsides of using this approach. Though, this approach
seems to be working fine for the little testing that I have done, we
might want to switch to async queue approach because of a possible
optimization.
I don't know how much optimize this would make the process. Currently
we keep pushing the tasks (paintTile requests) on to the queue, and no
matter what, once its pushed to the queue, it will get processed
anyways. But sometimes, I think, the user does a lot of operations in
very short interval of time, and we might not need some pending
operations in the queue to get processed at all. For example, when the
user quickly zooms in and zooms out.
There doesn't seem to be any way to manipulate the queue that thread
pool internally has, hence making it impossible to do this task
compression. We can switch to using async queue approach as mentioned
by Tomaz, if this optimization is worth it, otherwise we can just
stick to the existing implemented approach for the time being.
On Mon, Jul 20, 2015 at 6:05 PM, Pranav Kant pranav...@gmail.com wrote:
Hi Tomaz,
On Mon, Jul 20, 2015 at 4:14 PM, Tomaž Vajngerl qui...@gmail.com wrote:
Hi,
On Mon, Jul 20, 2015 at 7:02 PM, Pranav Kant pranav...@gmail.com wrote:
I am making use of thread pool, but this pool consists of only single
thread. All the LOK calls will be queued and can reuse this thread,
hence saving me the time that it would take to create a new thread
(expensive process) for each LOK call.
This was the reason behind making use of thread pool. I had no
intention of using more than one thread for LOK calls.
You can create only one thread on start and put the processing of
async queue in a loop there:
while (message = async_queue.pop())
{
...process message...
}
from other thread just push the messages that you want to process in
the other thread into the queue (btw. this is what is done in Android
implementation).
The queue will block if you pop and there are no messages in th
queue - which means the thread will sleep until a new message arrives.
Look at:
https://developer.gnome.org/glib/stable/glib-Asynchronous-Queues.html
Yeah, we can use this too.
As you can see the thread pool uses it also - but using thread pool
with only one thread is kind of a hack to me, but it works too..
Yeah, it works. I saw it in some of the gnome modules also, for
example, gnome-photos.
I don't know, but it looks easier to me, to implement and to read. I
will research more over this, and see what we can do.
--
Regards,
Pranav Kant
http://pranavk.me
--
Regards,
Pranav Kant
http://pranavk.me
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/source
sw/source/filter/ww8/types.hxx |1 +
sw/source/filter/ww8/ww8scan.cxx | 16
2 files changed, 5 insertions(+), 12 deletions(-)
New commits:
commit c39242b8bb8079d917f5d99b84add827dab4e9a9
Author: Caolán McNamara caol...@redhat.com
Date: Wed Jul 22 14:52:58 2015 +0100
read block in one swoop, rather than char by char
(cherry picked from commit a64c48f523d148cd4750bc9bd26d2349fc8a3c7c)
Change-Id: Ic879c096c6b3167a123cee352361da6c39e57de2
Reviewed-on: https://gerrit.libreoffice.org/17295
Reviewed-by: David Tardon dtar...@redhat.com
Tested-by: David Tardon dtar...@redhat.com
diff --git a/sw/source/filter/ww8/types.hxx b/sw/source/filter/ww8/types.hxx
index a57b99b..4d0a49a 100644
--- a/sw/source/filter/ww8/types.hxx
+++ b/sw/source/filter/ww8/types.hxx
@@ -28,6 +28,7 @@ namespace ww
{
public:
const sal_uInt8* data() const { return empty() ? 0 : front(); }
+sal_uInt8* data() { return empty() ? 0 : front(); }
};
enum WordVersion {eWW1 = 1, eWW2 = 2, eWW6 = 6, eWW7 = 7, eWW8 = 8};
diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx
index 8c3d979..5fae570 100644
--- a/sw/source/filter/ww8/ww8scan.cxx
+++ b/sw/source/filter/ww8/ww8scan.cxx
@@ -3897,12 +3897,8 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm,
sal_uInt32 nStart, sal_Int32 nLen
if (pExtraArray)
{
ww::bytes extraData;
-for (sal_uInt16 j = 0; j nExtraLen; ++j)
-{
-sal_uInt8 iTmp(0);
-rStrm.ReadUChar( iTmp );
-extraData.push_back(iTmp);
-}
+extraData.resize(nExtraLen);
+rStrm.Read(extraData.data(), nExtraLen);
pExtraArray-push_back(extraData);
}
else
@@ -3958,12 +3954,8 @@ void WW8ReadSTTBF(bool bVer8, SvStream rStrm,
sal_uInt32 nStart, sal_Int32 nLen
if (pExtraArray)
{
ww::bytes extraData;
-for (sal_uInt16 i=0;i nExtraLen;++i)
-{
-sal_uInt8 iTmp(0);
-rStrm.ReadUChar( iTmp );
-extraData.push_back(iTmp);
-}
+extraData.resize(nExtraLen);
+rStrm.Read(extraData.data(), nExtraLen);
pExtraArray-push_back(extraData);
}
else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||ipla...@yahoo.co.uk --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- @Michael : how long did you wait for the file open dialog ? What did you do to open the file ? Double-clic, Cmd-O, or File Open It sounds like bug 90913 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92901] PDF export convert Justified formatting to Align Left on OS X
https://bugs.documentfoundation.org/show_bug.cgi?id=92901 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- It hasn't reappeared in LO 4443, the fix in bug 88941 hasn't been backported to 4.4.x. A request for backport has already been made in bug 88941. *** This bug has been marked as a duplicate of bug 88941 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88941] Writer/Calc/Draw/Impress lose formatting for justified text when exporting to PDF on OS X builds
https://bugs.documentfoundation.org/show_bug.cgi?id=88941 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||wu.mi...@icloud.com --- Comment #54 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 92901 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92907] New: Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard
https://bugs.documentfoundation.org/show_bug.cgi?id=92907 Bug ID: 92907 Summary: Exiting LibreOffice takes a long time with much spreadsheet data in the clipboard Product: LibreOffice Version: 4.4.4.3 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: t...@iki.fi When you have a large spreadsheet with, say, 100K rows of a dozen columns or so, and have done Control-A Control-C (which also take a long time), when exiting LibreOffice it takes a very long time (like several minutes) for the soffice.bin process to actually finish, even if the LibreOffice GUI has already gone away. During that time you can't start a new LibreOffice instance either. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||lio...@mamane.lu, ||rob...@familiegrosskopf.de, ||serval2...@yahoo.fr --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- Unlikely, that this bug affects other OSes, but you never know, so CC'ing the usual crew. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92909] New: UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Bug ID: 92909 Summary: UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Base Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ipla...@yahoo.co.uk How to reproduce : 1) Open a database file 2) Create a new table in Table Design mode 3) In the grid view of Table Design mode, one selects the field data type in the second column. This used to be a drop down list of the data types that the underlying database engine supported, and which totally filled the cell. In current master, the suggested datatypes are now bounded by a rounded border, which no longer fills the cell (because the widget is rounded). This is a regression (visual, but still a regression). After all, what is the point of having a cell border if we are going to draw a rounded button in it ? Confirming myself since it would appear that no one else QAs Base bugs on OSX. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: writerfilter/source
writerfilter/source/dmapper/ThemeTable.cxx |1 -
writerfilter/source/dmapper/ThemeTable.hxx |3 ++-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 724249cebb5793fb3d46e011269cabb03e3aa1b9
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 24 09:54:19 2015 +0200
writerfilter: use std::shared_ptr in ThemeTable
Change-Id: I9d632ed036b1d94c29adfc79df4c920791b0c0fa
diff --git a/writerfilter/source/dmapper/ThemeTable.cxx
b/writerfilter/source/dmapper/ThemeTable.cxx
index 9e4d8f7..657753c 100644
--- a/writerfilter/source/dmapper/ThemeTable.cxx
+++ b/writerfilter/source/dmapper/ThemeTable.cxx
@@ -52,7 +52,6 @@ ThemeTable::ThemeTable()
ThemeTable::~ThemeTable()
{
-delete m_pImpl;
}
void ThemeTable::lcl_attribute(Id Name, Value val)
diff --git a/writerfilter/source/dmapper/ThemeTable.hxx
b/writerfilter/source/dmapper/ThemeTable.hxx
index 34a4aa4..0bc0a47 100644
--- a/writerfilter/source/dmapper/ThemeTable.hxx
+++ b/writerfilter/source/dmapper/ThemeTable.hxx
@@ -25,6 +25,7 @@
#include com/sun/star/lang/XComponent.hpp
#include i18nlangtag/languagetag.hxx
#include map
+#include memory
namespace writerfilter {
namespace dmapper
@@ -34,7 +35,7 @@ struct ThemeTable_Impl;
class ThemeTable : public LoggedProperties, public LoggedTable
{
-ThemeTable_Impl *m_pImpl;
+std::unique_ptrThemeTable_Impl m_pImpl;
public:
ThemeTable();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92899] Cannot paste text into Find field
https://bugs.documentfoundation.org/show_bug.cgi?id=92899 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Alex Thurgood ipla...@yahoo.co.uk --- *** This bug has been marked as a duplicate of bug 49853 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49853] EDITING: Attempting paste into find bar with Cmd-V on OS X pastes into document
https://bugs.documentfoundation.org/show_bug.cgi?id=49853 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added CC||brockmcnuggets@gallopingins ||anity.com --- Comment #102 from Alex Thurgood ipla...@yahoo.co.uk --- *** Bug 92899 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91987] Fileopen via file manager right-click crashes in (Kubuntu 15.04)
https://bugs.documentfoundation.org/show_bug.cgi?id=91987 Beluga todven...@suomi24.fi changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=347252 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 10 commits - filter/source include/filter include/svtools include/svx sd/source svtools/inc svtools/source svx/source sw/source
filter/source/msfilter/msdffimp.cxx| 53 ---
filter/source/msfilter/svdfppt.cxx | 116 -
include/filter/msfilter/msdffimp.hxx | 46 +
include/filter/msfilter/svdfppt.hxx| 34 +
include/svtools/ctrltool.hxx | 10 +-
include/svtools/parhtml.hxx|4 -
include/svx/PaletteManager.hxx |8 +-
sd/source/filter/ppt/pptin.cxx |6 -
svtools/inc/pch/precompiled_svt.hxx|1
svtools/source/control/ctrltool.cxx| 25 +++
svtools/source/svhtml/parhtml.cxx |6 -
svx/source/tbxctrls/PaletteManager.cxx | 20 ++---
sw/source/filter/ww8/ww8graf.cxx |6 -
sw/source/filter/ww8/ww8graf2.cxx |4 -
sw/source/filter/ww8/ww8par.cxx|6 -
15 files changed, 175 insertions(+), 170 deletions(-)
New commits:
commit 22fd35f5987e3fed40d5b2ad0df35f7d89f842f8
Author: Michael Stahl mst...@redhat.com
Date: Thu Jul 23 23:47:46 2015 +0200
filter: replace boost::ptr_vector with std::vectorstd::unique_ptr
Change-Id: I9aa0543edf3f0aef3a0a376aa0f82f51c6d93313
diff --git a/filter/source/msfilter/msdffimp.cxx
b/filter/source/msfilter/msdffimp.cxx
index 1a49e87..05fd7ea 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -5470,10 +5470,10 @@ void SvxMSDffManager::StoreShapeOrder(sal_uLong
nId,
SwFlyFrameFormat* pFly,
short nHdFtSection) const
{
-sal_uInt16 nShpCnt = pShapeOrders-size();
+sal_uInt16 nShpCnt = m_pShapeOrders-size();
for (sal_uInt16 nShapeNum=0; nShapeNum nShpCnt; nShapeNum++)
{
-SvxMSDffShapeOrder rOrder = (*pShapeOrders)[ nShapeNum ];
+SvxMSDffShapeOrder rOrder = *(*m_pShapeOrders)[ nShapeNum ];
if( rOrder.nShapeId == nId )
{
@@ -5491,10 +5491,10 @@ void SvxMSDffManager::ExchangeInShapeOrder( SdrObject*
pOldObject,
SwFlyFrameFormat* pFly,
SdrObject* pObject) const
{
-sal_uInt16 nShpCnt = pShapeOrders-size();
+sal_uInt16 nShpCnt = m_pShapeOrders-size();
for (sal_uInt16 nShapeNum=0; nShapeNum nShpCnt; nShapeNum++)
{
-SvxMSDffShapeOrder rOrder = (*pShapeOrders)[ nShapeNum ];
+SvxMSDffShapeOrder rOrder = *(*m_pShapeOrders)[ nShapeNum ];
if( rOrder.pObj == pOldObject )
{
@@ -5508,10 +5508,10 @@ void SvxMSDffManager::ExchangeInShapeOrder( SdrObject*
pOldObject,
void SvxMSDffManager::RemoveFromShapeOrder( SdrObject* pObject ) const
{
-sal_uInt16 nShpCnt = pShapeOrders-size();
+sal_uInt16 nShpCnt = m_pShapeOrders-size();
for (sal_uInt16 nShapeNum=0; nShapeNum nShpCnt; nShapeNum++)
{
-SvxMSDffShapeOrder rOrder = (*pShapeOrders)[ nShapeNum ];
+SvxMSDffShapeOrder rOrder = *(*m_pShapeOrders)[ nShapeNum ];
if( rOrder.pObj == pObject )
{
@@ -5523,12 +5523,8 @@ void SvxMSDffManager::RemoveFromShapeOrder( SdrObject*
pObject ) const
}
-
-
-
// exported class: Public Methods
-
SvxMSDffManager::SvxMSDffManager(SvStream rStCtrl_,
const OUString rBaseURL,
sal_uInt32 nOffsDgg_,
@@ -5542,7 +5538,7 @@ SvxMSDffManager::SvxMSDffManager(SvStream rStCtrl_,
pFormModel( NULL ),
m_pBLIPInfos( new SvxMSDffBLIPInfos ),
m_xShapeInfosByTxBxComp( new SvxMSDffShapeInfos_ByTxBxComp ),
- pShapeOrders( new SvxMSDffShapeOrders ),
+ m_pShapeOrders( new SvxMSDffShapeOrders ),
nOffsDgg( nOffsDgg_ ),
nBLIPCount( USHRT_MAX ), // initialize with error, since we
fist check if the
nGroupShapeFlags(0), // ensure initialization here, as
some corrupted
@@ -5591,7 +5587,7 @@ SvxMSDffManager::SvxMSDffManager( SvStream rStCtrl_,
const OUString rBaseURL )
pFormModel( NULL ),
m_pBLIPInfos( new SvxMSDffBLIPInfos ),
m_xShapeInfosByTxBxComp( new SvxMSDffShapeInfos_ByTxBxComp ),
- pShapeOrders( new SvxMSDffShapeOrders ),
+ m_pShapeOrders( new SvxMSDffShapeOrders ),
nOffsDgg( 0 ),
nBLIPCount( USHRT_MAX ), // initialize with error, since we
first have to check
nGroupShapeFlags(0),
@@ -5616,7 +5612,7 @@ SvxMSDffManager::~SvxMSDffManager()
{
delete pSecPropSet;
delete m_pBLIPInfos;
-delete pShapeOrders;
+delete m_pShapeOrders;
delete pFormModel;
}
@@ -6146,7 +6142,8 @@ bool SvxMSDffManager::GetShapeContainerData( SvStream
rSt,
}
m_xShapeInfosByTxBxComp-insert(std::shared_ptrSvxMSDffShapeInfo(
new SvxMSDffShapeInfo(aInfo)));
-pShapeOrders-push_back( new SvxMSDffShapeOrder( aInfo.nShapeId ) );
+m_pShapeOrders-push_back(std::unique_ptrSvxMSDffShapeOrder(
+new SvxMSDffShapeOrder(
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - svx/source
svx/source/svdraw/svdedxv.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 1dc670f0c3768e10bb35815242f5fd2f8077b97e Author: matteocam matteo.campane...@gmail.com Date: Fri Jul 24 11:15:21 2015 +0200 Remove test for next link in chain before moving cursor Change-Id: I37a22ab3ca02d6105d632a6cd08521f7bc5ee431 diff --git a/svx/source/svdraw/svdedxv.cxx b/svx/source/svdraw/svdedxv.cxx index c9428dc..ad35d29 100644 --- a/svx/source/svdraw/svdedxv.cxx +++ b/svx/source/svdraw/svdedxv.cxx @@ -533,7 +533,7 @@ void SdrObjEditView::ImpMoveCursorAfterChainingEvent() SdrTextObj* pTextObj = dynamic_castSdrTextObj*(mxTextEditObj.get()); -if (!pTextObj-IsChainable() || !pTextObj-GetNextLinkInChain()) +if (!pTextObj-IsChainable()) return; TextChain *pTextChain = pTextObj-GetTextChain(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: include/filter
include/filter/msfilter/svdfppt.hxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 79ebd13ffa69b6076d663089ba13f814aa80bcff Author: Michael Stahl mst...@redhat.com Date: Fri Jul 24 11:13:49 2015 +0200 filter: MSVC wants to generate unnecessary copy assignment again Change-Id: I273b47a6d30e6fcb597e43188f93e0e8f834c929 diff --git a/include/filter/msfilter/svdfppt.hxx b/include/filter/msfilter/svdfppt.hxx index e355d65..6dc7d3d 100644 --- a/include/filter/msfilter/svdfppt.hxx +++ b/include/filter/msfilter/svdfppt.hxx @@ -1160,6 +1160,9 @@ class MSFILTER_DLLPUBLIC PPTParagraphObj const PPTStyleSheetmrStyleSheet; sal_uInt32 mnInstance; +PPTParagraphObj(PPTParagraphObj const) = delete; +void operator=(PPTParagraphObj const) = delete; + public: boolmbTab; // if true, this paragraph has tabulators in text ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 --- Comment #3 from wj_hark...@hotmail.com --- Created attachment 117413 -- https://bugs.documentfoundation.org/attachment.cgi?id=117413action=edit Sample taken using OSX Activity Monitor Same problem with Openoffice 5.0.0.3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 --- Comment #4 from tele...@surfxs.nl --- It happens already when opening a new file in Libreoffice Writer and adding a table -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Build LibreOffice without unit tests
On 2015-07-23 01:32 PM, Jack wrote: Can somebody help me building LibreOffice(Ubuntu) without running any tests? $ make build-nocheck ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 6 commits - dbaccess/source drawinglayer/source editeng/source framework/source include/tools include/vcl reportdesign/source rsc/inc rsc/source sd/source sfx2/source s
dbaccess/source/ui/control/opendoccontrols.cxx |2
drawinglayer/source/primitive2d/metafileprimitive2d.cxx |4
drawinglayer/source/primitive2d/wallpaperprimitive2d.cxx | 28 ++---
editeng/source/items/frmitems.cxx| 50 -
framework/source/layoutmanager/helpers.cxx | 10 -
framework/source/layoutmanager/toolbarlayoutmanager.cxx | 20 +--
framework/source/uielement/popuptoolbarcontroller.cxx|2
include/tools/wintypes.hxx | 12 +-
include/vcl/splitwin.hxx |2
include/vcl/toolbox.hxx |2
include/vcl/wall.hxx | 51 ++---
reportdesign/source/ui/report/DesignView.cxx |2
rsc/inc/rscdb.hxx|2
rsc/source/parser/rscicpx.cxx|8 -
sd/source/ui/app/optsitem.cxx| 31 +
sd/source/ui/dlg/dlgass.cxx |2
sd/source/ui/dlg/navigatr.cxx|3
sd/source/ui/inc/navigatr.hxx|1
sd/source/ui/inc/optsitem.hxx| 14 --
sfx2/source/dialog/backingwindow.cxx |2
sfx2/source/dialog/splitwin.cxx | 28 ++---
sfx2/source/doc/frmdescr.cxx |2
sfx2/source/sidebar/SidebarController.cxx|8 -
svtools/source/contnr/ivctrl.cxx |4
svtools/source/dialogs/roadmapwizard.cxx |2
svtools/source/dialogs/wizdlg.cxx| 26 ++--
svx/source/form/fmshimp.cxx | 44 +++-
svx/source/inc/fmshimp.hxx | 23 +++-
svx/source/mnuctrls/clipboardctl.cxx |2
sw/source/ui/index/cnttab.cxx|2
sw/source/uibase/ribbar/workctrl.cxx |4
toolkit/source/awt/vclxwindows.cxx |6 -
toolkit/source/controls/unocontrolmodel.cxx |2
toolkit/source/helper/imagealign.cxx | 80 +++
vcl/source/control/button.cxx| 78 +++---
vcl/source/control/morebtn.cxx |2
vcl/source/gdi/pdfwriter_impl.cxx| 24 ++--
vcl/source/gdi/wall.cxx | 32 +++---
vcl/source/outdev/outdevstate.cxx|2
vcl/source/outdev/wallpaper.cxx | 26 ++--
vcl/source/window/builder.cxx|6 -
vcl/source/window/dockingarea.cxx| 24 ++--
vcl/source/window/menubarwindow.cxx |6 -
vcl/source/window/splitwin.cxx | 74 ++---
vcl/source/window/tabdlg.cxx | 10 -
vcl/source/window/toolbox.cxx| 80 +++
vcl/source/window/toolbox2.cxx | 10 -
vcl/workben/vcldemo.cxx |2
48 files changed, 407 insertions(+), 450 deletions(-)
New commits:
commit 9582380ebc2dd241ee90951c3b28d420e140bcde
Author: Noel Grandin n...@peralex.com
Date: Fri Jul 24 09:41:55 2015 +0200
convert ImageAlign to enum class
Change-Id: I22e2e66a1f0b230403ad1d9c1f5b7f34a6ee6ea5
diff --git a/dbaccess/source/ui/control/opendoccontrols.cxx
b/dbaccess/source/ui/control/opendoccontrols.cxx
index 05d9480..35792db 100644
--- a/dbaccess/source/ui/control/opendoccontrols.cxx
+++ b/dbaccess/source/ui/control/opendoccontrols.cxx
@@ -177,7 +177,7 @@ namespace dbaui
SetModeImage( GetCommandIcon( .uno:Open, m_sModule ) );
EnableImageDisplay( true );
EnableTextDisplay( true );
-SetImageAlign( IMAGEALIGN_LEFT );
+SetImageAlign( ImageAlign::Left );
SetStyle( GetStyle() | WB_CENTER );
}
diff --git a/include/tools/wintypes.hxx b/include/tools/wintypes.hxx
index 01a04d9..781865d 100644
--- a/include/tools/wintypes.hxx
+++ b/include/tools/wintypes.hxx
@@ -287,10 +287,10 @@ WinBits const WB_EXT_DOCMODIFIED = 0x0002;
enum class WindowAlign { Left, Top, Right, Bottom };
-enum ImageAlign { IMAGEALIGN_LEFT, IMAGEALIGN_TOP, IMAGEALIGN_RIGHT,
IMAGEALIGN_BOTTOM,
- IMAGEALIGN_LEFT_TOP, IMAGEALIGN_LEFT_BOTTOM,
IMAGEALIGN_TOP_LEFT,
- IMAGEALIGN_TOP_RIGHT, IMAGEALIGN_RIGHT_TOP,
IMAGEALIGN_RIGHT_BOTTOM,
- IMAGEALIGN_BOTTOM_LEFT, IMAGEALIGN_BOTTOM_RIGHT,
IMAGEALIGN_CENTER };
+enum class ImageAlign { Left, Top, Right, Bottom,
+ LeftTop, LeftBottom, TopLeft,
+ TopRight, RightTop, RightBottom,
+ BottomLeft,
[Libreoffice-bugs] [Bug 90575] DDE LINK does not work between two documents Writer
https://bugs.documentfoundation.org/show_bug.cgi?id=90575 Miklos Vajna vmik...@collabora.co.uk changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | --- Comment #5 from Miklos Vajna vmik...@collabora.co.uk --- I'll take care of this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92878] Opening Word Perfect File Destroys formatting loses text
https://bugs.documentfoundation.org/show_bug.cgi?id=92878 --- Comment #2 from osnola alo...@loria.fr --- Created attachment 117412 -- https://bugs.documentfoundation.org/attachment.cgi?id=117412action=edit file converted with wpd2odt I can not reproduce this problem on OSX. Normally on OSX, Courier is used to display most of the text while Courier New is almost only used to display the footer's text OPERATIVE REPORT. So if you see OPERATIVE REPORT and not the other text, this may indicate a problem with the font Courier on Windows. Note: - I convert test.wpd with wpd2odt on OSX and attach the result, just in case... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/qa
sc/qa/unit/data/xlsx/empty.xlsx|binary
sc/qa/unit/subsequent_filters-test.cxx | 18 ++
2 files changed, 18 insertions(+)
New commits:
commit a41140d7573aef6fd9a86a38e2a8e07de7afb007
Author: Katarina Behrens katarina.behr...@cib.de
Date: Fri Jul 24 10:56:30 2015 +0200
Add test for OOXML part of tdf#99256
Change-Id: If5e56109f0bf9281be74c17965b047a50f8b55d3
diff --git a/sc/qa/unit/data/xlsx/empty.xlsx b/sc/qa/unit/data/xlsx/empty.xlsx
new file mode 100644
index 000..c186485
Binary files /dev/null and b/sc/qa/unit/data/xlsx/empty.xlsx differ
diff --git a/sc/qa/unit/subsequent_filters-test.cxx
b/sc/qa/unit/subsequent_filters-test.cxx
index 9ab7f16..206c750 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -204,6 +204,7 @@ public:
void testEmbeddedImageXLS();
void testEditEngStrikeThroughXLSX();
void testRefStringXLSX();
+void testRefStringConfigXLSX();
CPPUNIT_TEST_SUITE(ScFiltersTest);
CPPUNIT_TEST(testBooleanFormatXLSX);
@@ -299,6 +300,7 @@ public:
CPPUNIT_TEST(testErrorOnExternalReferences);
CPPUNIT_TEST(testEditEngStrikeThroughXLSX);
CPPUNIT_TEST(testRefStringXLSX);
+CPPUNIT_TEST(testRefStringConfigXLSX);
CPPUNIT_TEST_SUITE_END();
private:
@@ -3108,6 +3110,22 @@ void ScFiltersTest::testRefStringXLSX()
xDocSh-DoClose();
}
+void ScFiltersTest::testRefStringConfigXLSX()
+{
+ScDocShellRef xDocSh = loadDoc(empty., XLSX);
+CPPUNIT_ASSERT_MESSAGE(Failed to open doc, xDocSh.Is());
+
+xDocSh = saveAndReload( (*xDocSh), XLSX);
+CPPUNIT_ASSERT_MESSAGE(Failed to reload doc, xDocSh.Is());
+
+ScDocument rDoc = xDocSh-GetDocument();
+ScCalcConfig aConfig = rDoc.GetCalcConfig();
+CPPUNIT_ASSERT_EQUAL_MESSAGE(String ref syntax doesn't match,
formula::FormulaGrammar::CONV_OOO,
+aConfig.meStringRefAddressSyntax);
+
+xDocSh-DoClose();
+}
+
ScFiltersTest::ScFiltersTest()
: ScBootstrapFixture( sc/qa/unit/data )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [GSoC] Integrating LO with GNOME - WR#8
Hi Pranav, On Fri, Jul 24, 2015 at 11:36:29AM +0530, Pranav Kant pranav...@gmail.com wrote: There doesn't seem to be any way to manipulate the queue that thread pool internally has, hence making it impossible to do this task compression. We can switch to using async queue approach as mentioned by Tomaz, if this optimization is worth it, otherwise we can just stick to the existing implemented approach for the time being. Given that a thread pool with one thread is basically such an async queue, I see no problems with this. Let's get back to this when we want to implement such a cancel tile requests feature in gtktiledviewer, which is not a priority at the moment. Regards, Miklos signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 82135] Cell references don't resolve in imported Excel sheet, but do after edit
https://bugs.documentfoundation.org/show_bug.cgi?id=82135 Marcus Bointon marcus...@synchromedia.co.uk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Marcus Bointon marcus...@synchromedia.co.uk --- Opening the attached doc in LibreOffice 4.4.4.3, you will see cell A1 on sheet 1 contains a zero value. It's actually a formula: =$sheet2!A1 (converted from the Excel formula ='sheet2'!A1) referring to cell A1 on the second sheet, which contains the literal value 123, which is not the same as the displayed 0. Forcing a recalculation (via F9 or menu command) does NOT update the value. If you edit cell A1 on sheet 1, select the last 1 and then retype it and hit return (i.e. not actually making a change), it updates to show the correct referenced value. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 --- Comment #2 from Alex Thurgood ipla...@yahoo.co.uk --- Created attachment 117411 -- https://bugs.documentfoundation.org/attachment.cgi?id=117411action=edit screenshot of data type widget as displayed on OSX -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92910] New: Search and Replace on large PDF causes crash
https://bugs.documentfoundation.org/show_bug.cgi?id=92910 Bug ID: 92910 Summary: Search and Replace on large PDF causes crash Product: LibreOffice Version: 4.4.4.3 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Draw Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: b...@orbit.me.uk * Open a 500+ page PDF document * Run search and replace * Searching a string and replacing it with nothing * Searched string is once on every page (footer) * LibreOffice Draw crashes and enters document recovery options Recovered document shows search and replace completed but Draw must have died at the end of the search. Machine, and consequently LibreOffice, is slow due to system constraints like RAM and HDD (but not particularly CPU bound). Reproduced twice on the same document, can't supply the document due to NDA. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 2 commits - fpicker/source fpicker/uiconfig
fpicker/source/office/RemoteFilesDialog.cxx |3 +++ fpicker/uiconfig/ui/remotefilesdialog.ui|1 + 2 files changed, 4 insertions(+) New commits: commit d9f062a31a2b35e113338040db8d0c2036d594fe Author: Szymon KÅos eszka...@gmail.com Date: Fri Jul 24 10:46:02 2015 +0200 the dialog width independent from a filters length Change-Id: If945bafe2f230bf1ede9a12782b6a487b7b08099 diff --git a/fpicker/uiconfig/ui/remotefilesdialog.ui b/fpicker/uiconfig/ui/remotefilesdialog.ui index 631d289..c9a6ac0 100644 --- a/fpicker/uiconfig/ui/remotefilesdialog.ui +++ b/fpicker/uiconfig/ui/remotefilesdialog.ui @@ -214,6 +214,7 @@ /child child object class=GtkComboBox id=filter_lb +property name=width_request200/property property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property commit af3f222cde3a01f361af79af379389de465a66a6 Author: Szymon KÅos eszka...@gmail.com Date: Fri Jul 24 10:44:36 2015 +0200 fixed some refresh problems (after resize) Change-Id: If140a8c9680ac30f5d26f0a034b8a7c7dea4bf64 diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index a263c3f..8607af6 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -321,6 +321,7 @@ void RemoteFilesDialog::Resize() Size aSize = m_pContainer-GetSizePixel(); m_pFileView-SetSizePixel( aSize ); } +Invalidate(InvalidateFlags::Update); } short RemoteFilesDialog::Execute() @@ -559,6 +560,8 @@ void RemoteFilesDialog::EnableControls() m_pPath-EnableFields( true ); m_pAddService_btn-Enable( true ); + +Invalidate(InvalidateFlags::Update); } void RemoteFilesDialog::DisableControls() ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'feature/gsoc14-draw-chained-text-boxes' - include/svx svx/source
include/svx/textchaincursor.hxx |3 ++-
svx/source/svdraw/textchaincursor.cxx | 24 +++-
2 files changed, 21 insertions(+), 6 deletions(-)
New commits:
commit 50e6f53542903e7e17385a4be2679b2ba51d6371
Author: matteocam matteo.campane...@gmail.com
Date: Fri Jul 24 11:00:27 2015 +0200
Handle Backspace
Change-Id: Ied9802481595f1f823ccd1abe6b6ccc97897a856
diff --git a/include/svx/textchaincursor.hxx b/include/svx/textchaincursor.hxx
index b56dd72..1d9c4de 100644
--- a/include/svx/textchaincursor.hxx
+++ b/include/svx/textchaincursor.hxx
@@ -42,7 +42,8 @@ private:
void impChangeEditingTextObj(SdrTextObj *pTargetTextObj, ESelection
aNewSel) const;
void impDetectEvent(const KeyEvent rKEvt,
CursorChainingEvent *pOutCursorEvt,
-ESelection *pOutSel) const;
+ESelection *pOutSel,
+bool *bOutHandled) const;
};
diff --git a/svx/source/svdraw/textchaincursor.cxx
b/svx/source/svdraw/textchaincursor.cxx
index 3952d8b..af2af7c 100644
--- a/svx/source/svdraw/textchaincursor.cxx
+++ b/svx/source/svdraw/textchaincursor.cxx
@@ -41,19 +41,22 @@ bool TextChainCursorManager::HandleKeyEvent( const
KeyEvent rKEvt ) const
CursorChainingEvent aCursorEvent;
// check what the cursor/event situation looks like
-impDetectEvent(rKEvt, aCursorEvent, aNewSel);
+bool bCompletelyHandled = false;
+impDetectEvent(rKEvt, aCursorEvent, aNewSel, bCompletelyHandled);
if (aCursorEvent == CursorChainingEvent::NULL_EVENT)
return false;
else {
HandleCursorEvent(aCursorEvent, aNewSel);
-return true;
+// return value depends on the situation we are in
+return bCompletelyHandled;
}
}
void TextChainCursorManager::impDetectEvent(const KeyEvent rKEvt,
CursorChainingEvent *pOutCursorEvt,
-ESelection *pOutSel) const
+ESelection *pOutSel,
+bool *bOutHandled) const
{
SdrOutliner *pOutl = mpEditView-GetTextEditOutliner();
OutlinerView *pOLV = mpEditView-GetTextEditOutlinerView();
@@ -80,22 +83,33 @@ void TextChainCursorManager::impDetectEvent(const KeyEvent
rKEvt,
ESelection aEndSel = ESelection(nLastPara, nLastParaLen);
bool bAtEndOfTextContent = aCurSel.IsEqual(aEndSel);
-// Are we pushing at the end of the object?
+// Possibility: Are we pushing at the end of the object?
if (nCode == KEY_RIGHT bAtEndOfTextContent pNextLink)
{
*pOutCursorEvt = CursorChainingEvent::TO_NEXT_LINK;
// Selection unchanged: we are at the beginning of the box
+*bOutHandled = true; // Nothing more to do than move cursor
return;
}
ESelection aStartSel = ESelection(0, 0);
bool bAtStartOfTextContent = aCurSel.IsEqual(aStartSel);
-// Are we pushing at the start of the object?
+// Possibility: Are we pushing at the start of the object?
if (nCode == KEY_LEFT bAtStartOfTextContent pPrevLink)
{
*pOutCursorEvt = CursorChainingEvent::TO_PREV_LINK;
*pOutSel = ESelection(10, 10); // Set at end of selection
+*bOutHandled = true; // Nothing more to do than move cursor
+return;
+}
+
+// Possibility: Are we pushing at the start of the object and deleting
left?
+if (nCode == KEY_BACKSPACE bAtStartOfTextContent pPrevLink)
+{
+*pOutCursorEvt = CursorChainingEvent::TO_PREV_LINK;
+*pOutSel = ESelection(10, 10); // Set at end of selection
+*bOutHandled = false; // We need to delete characters after moving
cursor
return;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Build LibreOffice without unit tests
Hi, Can somebody help me building LibreOffice(Ubuntu) without running any tests? Thanks, jack___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 --- Comment #4 from rob...@familiegrosskopf.de --- Couldn't reproduce it with OpenSUSE 13.2, LO Version: 5.1.0.0.alpha1+ Build ID: e412e16d56caf426bac04c7e5966e2a9efa7c408 TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-07-23_03:23:29 Locale: de-DE (de_DE.UTF-8) So a special Mac-problem? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88941] Writer/Calc/Draw/Impress lose formatting for justified text when exporting to PDF on OS X builds
https://bugs.documentfoundation.org/show_bug.cgi?id=88941 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Whiteboard|noRepro:4.5.0.0alpha+:Win7 |noRepro:4.5.0.0alpha+:Win7 |noRepro:4.4.0.3:Win7|noRepro:4.4.0.3:Win7 |noRepo:4.4.1.0alpha+:Linux |noRepo:4.4.1.0alpha+:Linux |bibisected target:5.1.0 |bibisected target:5.1.0 |target:5.0.0.3 |target:5.0.0.3 ||request-backport -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 55 commits - accessibility/source bin/find-unused-defines.awk comphelper/source configure.ac dbaccess/source desktop/
Rebased ref, commits from common ancestor:
commit 2c33d7ed71172609fabe692166d95ec850c8d0ce
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 09:47:18 2015 +0200
handle the delete button from PlaceEditDialog
Change-Id: Idb3257d1c106821a6e86182bca79c1aff8bfaea3
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index a810ff8..a263c3f 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -658,6 +658,9 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
m_bIsUpdated = true;
break;
}
+case RET_NO:
+sIdent = delete_service;
+break;
case RET_CANCEL :
default :
// Do Nothing
@@ -665,7 +668,7 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
};
}
}
-else if( sIdent == delete_service m_pServices_lb-GetEntryCount()
0 )
+if( sIdent == delete_service m_pServices_lb-GetEntryCount() 0 )
{
unsigned int nSelected = m_pServices_lb-GetSelectEntryPos();
int nPos = GetSelectedServicePos();
commit 7b7873261f7cc66ef63ba4f1103dd9792574b54f
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 09:39:09 2015 +0200
don't show edit/delete menu when there is no service
Change-Id: Ia53c9e3f6a4bcaab5e68fbbff6d2ec8cfe5cd702
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index ab11f2f..a810ff8 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -176,6 +176,7 @@ RemoteFilesDialog::RemoteFilesDialog( vcl::Window* pParent,
WinBits nBits )
, m_pSplitter( NULL )
, m_pFileView( NULL )
, m_pContainer( NULL )
+, m_pAddMenu( NULL )
{
get( m_pCancel_btn, cancel );
get( m_pAddService_btn, add_service_btn );
@@ -252,6 +253,7 @@ RemoteFilesDialog::RemoteFilesDialog( vcl::Window* pParent,
WinBits nBits )
m_pName_ed-SetModifyHdl( LINK( this, RemoteFilesDialog, FileNameModifyHdl
) );
m_pAddService_btn-SetMenuMode( MENUBUTTON_MENUMODE_TIMED );
+m_pAddMenu = m_pAddService_btn-GetPopupMenu();
m_pAddService_btn-SetClickHdl( LINK( this, RemoteFilesDialog,
AddServiceHdl ) );
m_pAddService_btn-SetSelectHdl( LINK( this, RemoteFilesDialog,
EditServiceMenuHdl ) );
@@ -413,7 +415,10 @@ void RemoteFilesDialog::FillServicesListbox()
if( m_pServices_lb-GetEntryCount() 0 )
{
m_pServices_lb-SelectEntryPos( nPos );
+m_pAddService_btn-SetPopupMenu( m_pAddMenu );
}
+else
+m_pAddService_btn-SetPopupMenu( NULL );
EnableControls();
}
@@ -588,6 +593,7 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, AddServiceHdl )
m_pServices_lb-InsertEntry( sPrefix + newService-GetName() );
m_pServices_lb-SelectEntryPos( m_pServices_lb-GetEntryCount() -
1 );
+m_pAddService_btn-SetPopupMenu( m_pAddMenu );
SelectServiceHdl( NULL );
m_bIsUpdated = true;
@@ -682,6 +688,7 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
else
{
m_pServices_lb-SetNoSelection();
+m_pAddService_btn-SetPopupMenu( NULL );
}
m_bIsUpdated = true;
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx
b/fpicker/source/office/RemoteFilesDialog.hxx
index a62b4cf..63fbd94 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -144,6 +144,7 @@ private:
VclPtr FileViewContainer m_pContainer;
VclPtr ListBox m_pFilter_lb;
VclPtr Edit m_pName_ed;
+PopupMenu* m_pAddMenu;
std::vector ServicePtr m_aServices;
std::vector std::pair OUString, OUString m_aFilters;
commit 16ccf865fcd75448ff3d85a43d75db6e53e5ddfa
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 09:18:17 2015 +0200
working busy pointer
Change-Id: I8c5e9e155a1854a670961fa67aa2aa6944604177
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index 7106366..ab11f2f 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -470,6 +470,7 @@ FileViewResult RemoteFilesDialog::OpenURL( OUString const
sURL )
EnableChildPointerOverwrite( true );
SetPointer( PointerStyle::Wait );
+Invalidate(InvalidateFlags::Update);
if( !sURL.isEmpty() )
{
commit 70952076827a5e270d3c6fc375f3d9abecf88c9e
Author: Szymon KÅos eszka...@gmail.com
Date: Thu Jul 23 16:22:33 2015 +0200
RemoteFilesDialog integration with AsyncPickerAction
Change-Id:
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Lionel Elie Mamane lio...@mamane.lu changed: What|Removed |Added CC||t...@libreoffice.org --- Comment #3 from Lionel Elie Mamane lio...@mamane.lu --- Adding Thorsten as the documented Mac FindTheExpert -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 45834] PgSQL: if no SELECT privilege on table at startup, auto increment field zero in new data
https://bugs.documentfoundation.org/show_bug.cgi?id=45834 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- Confirming -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92903] Base: text displayed offset in table edit UI listbox dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=92903 Katarina Behrens (CIB) katarina.behr...@cib.de changed: What|Removed |Added Whiteboard||needsKDE --- Comment #2 from Katarina Behrens (CIB) katarina.behr...@cib.de --- Looks like KDE specific indeed. Unfortunately I've never really used Base in my whole life :P so I can't really reproduce, as I don't know what 'create table in edit mode' means -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
ka mata kaha me??
Https://www.reddit.com/3ef02v/ http://www.reddit.com/3eez7l/ -- View this message in context: http://nabble.documentfoundation.org/ka-mata-kaha-me-tp4155283.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
sundang na daku
http://www.reddit.com/3ef02v/ http://www.reddit.com/3eez7l/ -- View this message in context: http://nabble.documentfoundation.org/sundang-na-daku-tp4155284.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92906] VIEWING: badly rendered Elements Dock after hide and show
https://bugs.documentfoundation.org/show_bug.cgi?id=92906 tommy27 ba...@quipo.it changed: What|Removed |Added Priority|medium |highest Status|UNCONFIRMED |NEW CC||ba...@quipo.it Ever confirmed|0 |1 --- Comment #2 from tommy27 ba...@quipo.it --- confirmed under Win7x64 using LibO 5.1.0.0.alpha1+ (x64) Build ID: e92a8b92072284fd7c37d7bb3e1e8fe72a185f35 TinderBox: Win-x86_64@62-TDF, Branch:MASTER, Time: 2015-07-22_21:46:26 Locale: it-IT (it_IT) status NEW. I also raise priority to highest. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/ui/view/gridwin4.cxx |5 --
sc/source/ui/view/output.cxx | 87 +
2 files changed, 62 insertions(+), 30 deletions(-)
New commits:
commit 7c927b64fa42ea1b0ddf97ce6b6aa400f2e30d5b
Author: Jan Holesovsky ke...@collabora.com
Date: Fri Jul 24 10:31:17 2015 +0200
calc mapmode: Cleanup DrawBackground + fix one pixel size.
Change-Id: I2ff1aa1d83a3228ee76eda7cd2e411cf084079f6
diff --git a/sc/source/ui/view/output.cxx b/sc/source/ui/view/output.cxx
index 6cc3d60..cef48f9 100644
--- a/sc/source/ui/view/output.cxx
+++ b/sc/source/ui/view/output.cxx
@@ -327,8 +327,21 @@ void ScOutputData::DrawGrid(vcl::RenderContext
rRenderContext, bool bGrid, bool
// It is a big mess to distinguish when we are using pixels and when logic
// units for drawing. Ultimately we want to work only in the logic units,
// but until that happens, we need to special-case:
-// * metafile
-// * drawing to the screen - everything is internally counted in pixels
there
+//
+// * metafile
+// * drawing to the screen - everything is internally counted in pixels
there
+//
+// 'Internally' in the above means the pCellInfo[...].nWidth and
+// pRowInfo[...]-nHeight:
+//
+// * when bWorksInPixels is true: these are in pixels
+// * when bWorksInPixels is false: these are in the logic units
+//
+// This is where all the confusion comes from, ultimately we want them
+// always in the logic units (100th of milimiters), but we need to get
+// there gradually (get rid of setting MAP_PIXEL first), otherwise we'd
+// break all the drawing by one change.
+// So until that happens, we need to special case.
bool bWorksInPixels = bMetaFile;
if ( eType == OUTTYPE_WINDOW )
@@ -956,20 +969,21 @@ void ScOutputData::DrawBackground(vcl::RenderContext
rRenderContext)
{
FindRotated(); //! from the outside?
-bool bWorksInPixels = bMetaFile;
+Size aOnePixel = rRenderContext.PixelToLogic(Size(1,1));
+long nOneXLogic = aOnePixel.Width();
+long nOneYLogic = aOnePixel.Height();
-if ( eType == OUTTYPE_WINDOW )
-{
+// See more about bWorksInPixels in ScOutputData::DrawGrid
+bool bWorksInPixels = false;
+if (eType == OUTTYPE_WINDOW)
bWorksInPixels = true;
-}
long nOneX = 1;
long nOneY = 1;
if (!bWorksInPixels)
{
-Size aOnePixel = rRenderContext.PixelToLogic(Size(1,1));
-nOneX = aOnePixel.Width();
-nOneY = aOnePixel.Height();
+nOneX = nOneXLogic;
+nOneY = nOneYLogic;
}
Rectangle aRect;
@@ -1014,6 +1028,8 @@ void ScOutputData::DrawBackground(vcl::RenderContext
rRenderContext)
nPosX += nMirrorW - nOneX;
aRect = Rectangle(nPosX, nPosY - nOneY, nPosX, nPosY - nOneY +
nRowHeight);
+if (bWorksInPixels)
+aRect = rRenderContext.PixelToLogic(aRect); // internal
data in pixels, but we'll be drawing in logic units
const SvxBrushItem* pOldBackground = NULL;
const SvxBrushItem* pBackground;
@@ -1067,18 +1083,11 @@ void ScOutputData::DrawBackground(vcl::RenderContext
rRenderContext)
const ScDataBarInfo* pDataBarInfo = pInfo-pDataBar.get();
const ScIconSetInfo* pIconSetInfo = pInfo-pIconSet.get();
-Rectangle aRectC = aRect;
-long nPosXC = nPosX;
+long nPosXLogic = nPosX;
+if (bWorksInPixels)
+nPosXLogic = rRenderContext.PixelToLogic(Point(nPosX,
0)).X();
-if(bWorksInPixels)
-{
-aRectC = rRenderContext.PixelToLogic(aRect);
-nPosXC = rRenderContext.PixelToLogic(Point(nPosX,
0)).X();
-}
-drawCells(rRenderContext, pColor, pBackground, pOldColor,
pOldBackground, aRectC, nPosXC, nLayoutSign, nOneX, nOneY, pDataBarInfo,
pOldDataBarInfo, pIconSetInfo, pOldIconSetInfo);
-
-if(bWorksInPixels)
-aRect = rRenderContext.LogicToPixel(aRectC);
+drawCells(rRenderContext, pColor, pBackground, pOldColor,
pOldBackground, aRect, nPosXLogic, nLayoutSign, nOneXLogic, nOneYLogic,
pDataBarInfo, pOldDataBarInfo, pIconSetInfo, pOldIconSetInfo);
// extend for all merged cells
nMergedCells = 1;
@@ -1095,19 +1104,11 @@ void ScOutputData::DrawBackground(vcl::RenderContext
rRenderContext)
}
}
-Rectangle aRectC = aRect;
-long nPosXC = nPosX;
-
-if(bWorksInPixels)
-{
-aRectC = rRenderContext.PixelToLogic(aRect);
-nPosXC = rRenderContext.PixelToLogic(Point(nPosX,
[Libreoffice-bugs] [Bug 80175] FILEOPEN: error message opening particular .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=80175 --- Comment #16 from Carlos Rodriguez carlos.rodrig...@tegnix.com --- (In reply to Terrence Enger from comment #15) (In reply to Carlos Rodriguez from comment #13) On the following versions it opens normally as expected but getting no formula. Is there any? The .png attached to this bug report shows the lack of a formula in footnote 43. In one case, we see following footnotes; in the other we see the numbers for subsequent footnotes, but no content. Ok. What I'm getting is the lack of the formula. The subsequent footnotes appears correctly. If you see a problem with the formula, it should be a separate bug report. Please add me to the cc if you file a new one or find an existing one. Sorry but don't know if the lack of the formula means actually that I need to create a new bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: desktop/source
desktop/source/deployment/gui/dp_gui.hrc |1 -
desktop/source/deployment/gui/dp_gui_dialog2.cxx |1 -
desktop/source/deployment/gui/dp_gui_dialog2.hxx |1 -
desktop/source/deployment/gui/dp_gui_updatedialog.cxx |1 -
desktop/source/deployment/gui/dp_gui_updatedialog.hxx |3 ---
desktop/source/deployment/gui/dp_gui_updatedialog.src |4
desktop/source/migration/migration_impl.hxx |1 -
7 files changed, 12 deletions(-)
New commits:
commit ddc642dd270c3cdae01f387049fcf5c2ab23519b
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jul 24 11:07:46 2015 +0200
-Werror,-Wunused-private-field
Change-Id: Ia1eb84b72cc9aa61639c3efbd55685d781196401
diff --git a/desktop/source/deployment/gui/dp_gui.hrc
b/desktop/source/deployment/gui/dp_gui.hrc
index 7ccd459..ddee13a 100644
--- a/desktop/source/deployment/gui/dp_gui.hrc
+++ b/desktop/source/deployment/gui/dp_gui.hrc
@@ -32,7 +32,6 @@
#define RID_STR_WARNING_INSTALL_EXTENSION
(RID_DEPLOYMENT_GUI_START + 9)
#define RID_DLG_UPDATE_NORMALALERT (RID_DEPLOYMENT_GUI_START + 11)
-#define RID_DLG_UPDATE_ERROR(RID_DEPLOYMENT_GUI_START + 12)
#define RID_DLG_UPDATE_NONE (RID_DEPLOYMENT_GUI_START + 13)
#define RID_DLG_UPDATE_NOINSTALLABLE(RID_DEPLOYMENT_GUI_START + 14)
#define RID_DLG_UPDATE_FAILURE (RID_DEPLOYMENT_GUI_START + 15)
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
index 3ff60b1..96c1097 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx
@@ -1184,7 +1184,6 @@ bool ExtMgrDialog::Close()
UpdateRequiredDialog::UpdateRequiredDialog(vcl::Window *pParent,
TheExtensionManager *pManager)
: ModalDialog(pParent, UpdateRequiredDialog,
desktop/ui/updaterequireddialog.ui)
, DialogHelper(pManager-getContext(), static_castDialog*(this))
-, m_sAddPackages(getResourceString(RID_STR_ADD_PACKAGES))
, m_sCloseText(getResourceString(RID_STR_CLOSE_BTN))
, m_bHasProgress(false)
, m_bProgressChanged(false)
diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.hxx
b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
index e0a4f1a..2344351 100644
--- a/desktop/source/deployment/gui/dp_gui_dialog2.hxx
+++ b/desktop/source/deployment/gui/dp_gui_dialog2.hxx
@@ -183,7 +183,6 @@ class UpdateRequiredDialog : public ModalDialog,
VclPtrCancelButtonm_pCancelBtn;
VclPtrFixedText m_pProgressText;
VclPtrProgressBar m_pProgressBar;
-const OUString m_sAddPackages;
const OUString m_sCloseText;
OUString m_sProgressText;
::osl::Mutex m_aMutex;
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
index 7227adc..8178fc0 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.cxx
@@ -492,7 +492,6 @@ UpdateDialog::UpdateDialog(
std::vector dp_gui::UpdateData * updateData):
ModalDialog(parent, UpdateDialog, desktop/ui/updatedialog.ui),
m_context(context),
-m_error(DPGUI_RESSTR(RID_DLG_UPDATE_ERROR)),
m_none(DPGUI_RESSTR(RID_DLG_UPDATE_NONE)),
m_noInstallable(DPGUI_RESSTR(RID_DLG_UPDATE_NOINSTALLABLE)),
m_failure(DPGUI_RESSTR(RID_DLG_UPDATE_FAILURE)),
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
index 806fd98..c3e7acf 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx
@@ -182,7 +182,6 @@ private:
VclPtrHelpButton m_pHelp;
VclPtrPushButton m_pOk;
VclPtrPushButton m_pClose;
-OUString m_error;
OUString m_none;
OUString m_noInstallable;
OUString m_failure;
@@ -203,8 +202,6 @@ private:
rtl::Reference UpdateDialog::Thread m_thread;
::com::sun::star::uno::Reference
::com::sun::star::deployment::XExtensionManager m_xExtensionManager;
-Point m_aFirstLinePos;
-Sizem_aFirstLineSize;
sal_uInt16 m_nLastID;
boolm_bModified;
};
diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.src
b/desktop/source/deployment/gui/dp_gui_updatedialog.src
index 6cead51..4f0f5de 100644
--- a/desktop/source/deployment/gui/dp_gui_updatedialog.src
+++ b/desktop/source/deployment/gui/dp_gui_updatedialog.src
@@ -27,10 +27,6 @@ Image RID_DLG_UPDATE_NORMALALERT {
};
};
-String RID_DLG_UPDATE_ERROR {
-Text[en-US] = Error;
-};
-
String RID_DLG_UPDATE_NONE {
Text[en-US] = No new updates are available.;
};
diff --git a/desktop/source/migration/migration_impl.hxx
b/desktop/source/migration/migration_impl.hxx
index f55c543..ee8d2cd 100644
--- a/desktop/source/migration/migration_impl.hxx
+++
DrawBackground
Hi Krisztian, I've pushed your DrawBackground patch, together with a small follow-up patch that fixes the overlaps. The follow-up patch is this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7c927b64fa42ea1b0ddf97ce6b6aa400f2e30d5b I've extended the documentation of the bWorksInPixels, please check it, hopefully it is now even more understandable what is the issue there, and where the confusion comes from when we are painting to the screen :-) Also now I know where the bMetaFile comes into play. When we were using that in DrawBackground, it was breaking the generation of thumbnails in the startcenter - so that is where it is used. Given that, now I am a bit unsure if we should use that in ScOutputData::DrawGrid at all; but so far I don't see any harm in doing that; and it was there originally, so... To summarize all the test cases that need checking for every change there: * normal painting to the screen * PDF export * bin/run gtktiledviewer /local/libreoffice/master/instdir/program file * thumbnail in the startcenter Hope that helps! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 82135] Cell references don't resolve in imported Excel sheet, but do after edit
https://bugs.documentfoundation.org/show_bug.cgi?id=82135 --- Comment #6 from Marcus Bointon marcus...@synchromedia.co.uk --- Created attachment 117414 -- https://bugs.documentfoundation.org/attachment.cgi?id=117414action=edit Spreadsheet to demonstrate uncalculated value -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92903] Base: text displayed offset in table edit UI listbox dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=92903 --- Comment #3 from rob...@familiegrosskopf.de --- Can't confirm for OpenSUSE 13.2 64bit rpm Linux and LO Version: 5.0.0.3 Build-ID: f79b5ba13f5e6cbad23f8038060e556217e66632 Gebietsschema: de-DE (de_DE.UTF-8) KDE: 4.14.9 I don't see any listbox in the screenshot. Seems the listbox itself isn't shown. Did you activate something like OpenGL? I couldn't test it here, because it seem I can't activate it ... -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80175] FILEOPEN: error message opening particular .docx
https://bugs.documentfoundation.org/show_bug.cgi?id=80175 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #17 from tommy27 ba...@quipo.it --- if the original problem was the error message opening the file, and this is gone in recent LibO release, we should mark this -- RESOLVED WORKSFORME then open a CLEAN, NEW report about the new or residual issues about that file and the formula. this report already has many comments, so it's better to start from zero to focus on the actual problem . -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Docker container for building LibreOffice
Hi Eike, On Fri, Jul 24, 2015 at 1:03 PM, Eike Rathke er...@redhat.com wrote: Hi Dashamir, On Thursday, 2015-07-23 18:42:23 +0200, Dashamir Hoxha wrote: /compile/libreoffice-5-0/workdir/CxxObject/svtools/source/dialogs/prnsetup.o: In function `PrinterSetupDialog::ImplPropertiesHdl(void*)': prnsetup.cxx:(.text+0x1e67): undefined reference to `Printer::Setup(vcl::Window*)' prnsetup.cxx:(.text+0x1ee5): undefined reference to `Printer::Setup(vcl::Window*)' indeed include/vcl/print.hxx declares Setup( vcl::Window* pWindow = NULL, bool bPapersizeFromSetup = false); since 6779b46796c93cbb4293a400f57c29e8ae85811b on branch libreoffice-5-0 of Jul-7 so workdir/CxxObject/svtools/source/dialogs/prnsetup.o should had been build with a reference to a two parameter Printer::Setup() as well. Are you mixing sources or builds of different checkouts somehow? I have tried to compile libreoffice-4-4-4 before, and maybe I forgot to cleanup properly. I use this script to cleanup git: - https://github.com/FreeSoft-AL/libreoffice-compile/blob/master/compile/git-clean.sh (because I didn't know about `g`) I will try it again and I will let you know. Thanks, Dashamir Excute ./g pull -r in your source tree and then make. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Build LibreOffice without unit tests
On Fri, Jul 24, 2015 at 6:18 AM, Bjoern Michaelsen bjoern.michael...@canonical.com wrote: On Fri, Jul 24, 2015 at 11:52:54AM +0200, Noel Grandin wrote: On 2015-07-23 01:32 PM, Jack wrote: Can somebody help me building LibreOffice(Ubuntu) without running any tests? $ make build-nocheck Yes, but ... why?[1] Obviously not a good thing to do by default, but there are some reasonable cases for it. (These are my reasons, not necessarily the OP's.) If you don't expect the tests to pass (yet) then there is no point in running them after every build cycle. Also, if someone else broke the tests (a recent experience) but you need to work on some unrelated patch (or build a branch to play with a feature or patch). Another reason is when debugging or bisecting. For the former, I often add specialized code to help me debug or find/discover something. I want fast build/debug cycles in this case, without waiting for unit-tests. Ditto for bisecting. The unittests take a considerable time to run, and selectively excluding them when running them won't help can help productivity. Otherwise, the defaults are great. Best, Bjoern [1] Not running tests is not suppossed to be a desireable build scenario. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: toolkit/source
toolkit/source/awt/vclxfont.cxx |2 ++
1 file changed, 2 insertions(+)
New commits:
commit 442b788bc80e20783bdb881aa0cbbc253f1a47b0
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 24 13:09:28 2015 +0100
Resolves: tdf#90609 SolarMutex assert on threaded load
Change-Id: I81a784ab506d0d3ae266d7341b8ff7a163dcd8d2
diff --git a/toolkit/source/awt/vclxfont.cxx b/toolkit/source/awt/vclxfont.cxx
index 9aece8b..a4b0c73 100644
--- a/toolkit/source/awt/vclxfont.cxx
+++ b/toolkit/source/awt/vclxfont.cxx
@@ -29,6 +29,7 @@
#include sal/alloca.h
#include vcl/outdev.hxx
+#include vcl/svapp.hxx
// class VCLXFont
@@ -200,6 +201,7 @@ sal_Bool VCLXFont::hasGlyphs( const OUString aText )
throw(::com::sun::star::uno::RuntimeException, std::exception)
{
::osl::Guard ::osl::Mutex aGuard( GetMutex() );
+SolarMutexGuard aSolarGuard;
OutputDevice* pOutDev = VCLUnoHelper::GetOutputDevice( mxDevice );
if ( pOutDev )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 --- Comment #11 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Caolán McNamara committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=442b788bc80e20783bdb881aa0cbbc253f1a47b0 Resolves: tdf#90609 SolarMutex assert on threaded load It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|| target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |2 +-
vcl/unx/gtk/window/gtksalframe.cxx | 35 ++-
2 files changed, 19 insertions(+), 18 deletions(-)
New commits:
commit c19e079bc1a2cce977bd0e2bbba5901108180615
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 24 12:22:14 2015 +0100
gtk3: draw/paint to the fixed container
which fills the toplevel window, rather than directly to the toplevel
window.
It makes no difference for X, but for wayland the window decorations are
part
of the toplevel window, dropping down a level means we don't draw out menu
bar
under the window decoration space
Change-Id: Icec400efacd16b5d901107c13b6fa90c59cad0e6
(cherry picked from commit 298c089df77d9afe2cf86bb7a6a8544a0151e8c5)
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 6797ea82..4977a7c 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -173,6 +173,7 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
SalX11Screenm_nXScreen;
GtkWidget* m_pWindow;
+GtkFixed* m_pFixedContainer;
GdkWindow* m_pForeignParent;
GdkNativeWindow m_aForeignParentWindow;
GdkWindow* m_pForeignTopLevel;
@@ -180,7 +181,6 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
Pixmap m_hBackgroundPixmap;
sal_uLong m_nStyle;
SalExtStyle m_nExtStyle;
-GtkFixed* m_pFixedContainer;
GtkSalFrame*m_pParent;
std::list GtkSalFrame*m_aChildren;
GdkWindowState m_nState;
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index ba2f79b..b99d48d 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -414,7 +414,7 @@ void GtkSalFrame::doKeyCallback( guint state,
if (keyval == GDK_0)
{
fprintf( stderr, force widget_queue_draw\n);
-gtk_widget_queue_draw (m_pWindow);
+gtk_widget_queue_draw (m_pFixedContainer);
return;
}
else if (keyval == GDK_1)
@@ -1034,12 +1034,25 @@ void GtkSalFrame::updateScreenNumber()
void GtkSalFrame::InitCommon()
{
+// add the fixed container child,
+// fixed is needed since we have to position plugin windows
+m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), NULL ));
+gtk_container_add( GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pFixedContainer)
);
+
+gtk_widget_set_app_paintable(GTK_WIDGET(m_pFixedContainer), true);
+/*non-X11 displays won't show anything at all without double-buffering
+ enabled*/
+if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
+gtk_widget_set_double_buffered(GTK_WIDGET(m_pFixedContainer), false);
+gtk_widget_set_redraw_on_allocate(GTK_WIDGET(m_pFixedContainer), false);
+
+
// connect signals
g_signal_connect( G_OBJECT(m_pWindow), style-set,
G_CALLBACK(signalStyleSet), this );
g_signal_connect( G_OBJECT(m_pWindow), button-press-event,
G_CALLBACK(signalButton), this );
g_signal_connect( G_OBJECT(m_pWindow), button-release-event,
G_CALLBACK(signalButton), this );
#if GTK_CHECK_VERSION(3,0,0)
-g_signal_connect( G_OBJECT(m_pWindow), draw, G_CALLBACK(signalDraw),
this );
+g_signal_connect( G_OBJECT(m_pFixedContainer), draw,
G_CALLBACK(signalDraw), this );
//g_signal_connect( G_OBJECT(m_pWindow), state-flags-changed,
G_CALLBACK(signalFlagsChanged), this );
#if GTK_CHECK_VERSION(3,14,0)
GtkGesture *pSwipe = gtk_gesture_swipe_new(m_pWindow);
@@ -1055,7 +1068,7 @@ void GtkSalFrame::InitCommon()
#endif
#else
-g_signal_connect( G_OBJECT(m_pWindow), expose-event,
G_CALLBACK(signalExpose), this );
+g_signal_connect( G_OBJECT(m_pFixedContainer), expose-event,
G_CALLBACK(signalExpose), this );
#endif
g_signal_connect( G_OBJECT(m_pWindow), focus-in-event,
G_CALLBACK(signalFocus), this );
g_signal_connect( G_OBJECT(m_pWindow), focus-out-event,
G_CALLBACK(signalFocus), this );
@@ -1097,24 +1110,12 @@ void GtkSalFrame::InitCommon()
m_nAppActionGroupExportId = 0;
m_nHudAwarenessId = 0;
-gtk_widget_set_app_paintable( m_pWindow, TRUE );
-/*non-X11 displays won't show anything at all without double-buffering
- enabled*/
-if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
-gtk_widget_set_double_buffered( m_pWindow, FALSE );
-gtk_widget_set_redraw_on_allocate( m_pWindow, FALSE );
-
gtk_widget_add_events( m_pWindow,
GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK |
GDK_POINTER_MOTION_MASK |
GDK_POINTER_MOTION_HINT_MASK |
GDK_VISIBILITY_NOTIFY_MASK | GDK_SCROLL_MASK
);
-
[Libreoffice-bugs] [Bug 90609] FILEOPEN XML XLSX causes Calc to terminate
https://bugs.documentfoundation.org/show_bug.cgi?id=90609 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |2 +-
vcl/unx/gtk/window/gtksalframe.cxx | 35 +--
2 files changed, 18 insertions(+), 19 deletions(-)
New commits:
commit b882eef32392b6ac027063135476ec8eec3fd2a2
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 24 14:05:39 2015 +0100
Revert gtk3: draw/paint to the fixed container
bah, didn't mean to push directly without review
This reverts commit c19e079bc1a2cce977bd0e2bbba5901108180615.
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 4977a7c..6797ea82 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -173,7 +173,6 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
SalX11Screenm_nXScreen;
GtkWidget* m_pWindow;
-GtkFixed* m_pFixedContainer;
GdkWindow* m_pForeignParent;
GdkNativeWindow m_aForeignParentWindow;
GdkWindow* m_pForeignTopLevel;
@@ -181,6 +180,7 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
Pixmap m_hBackgroundPixmap;
sal_uLong m_nStyle;
SalExtStyle m_nExtStyle;
+GtkFixed* m_pFixedContainer;
GtkSalFrame*m_pParent;
std::list GtkSalFrame*m_aChildren;
GdkWindowState m_nState;
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index b99d48d..ba2f79b 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -414,7 +414,7 @@ void GtkSalFrame::doKeyCallback( guint state,
if (keyval == GDK_0)
{
fprintf( stderr, force widget_queue_draw\n);
-gtk_widget_queue_draw (m_pFixedContainer);
+gtk_widget_queue_draw (m_pWindow);
return;
}
else if (keyval == GDK_1)
@@ -1034,25 +1034,12 @@ void GtkSalFrame::updateScreenNumber()
void GtkSalFrame::InitCommon()
{
-// add the fixed container child,
-// fixed is needed since we have to position plugin windows
-m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), NULL ));
-gtk_container_add( GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pFixedContainer)
);
-
-gtk_widget_set_app_paintable(GTK_WIDGET(m_pFixedContainer), true);
-/*non-X11 displays won't show anything at all without double-buffering
- enabled*/
-if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
-gtk_widget_set_double_buffered(GTK_WIDGET(m_pFixedContainer), false);
-gtk_widget_set_redraw_on_allocate(GTK_WIDGET(m_pFixedContainer), false);
-
-
// connect signals
g_signal_connect( G_OBJECT(m_pWindow), style-set,
G_CALLBACK(signalStyleSet), this );
g_signal_connect( G_OBJECT(m_pWindow), button-press-event,
G_CALLBACK(signalButton), this );
g_signal_connect( G_OBJECT(m_pWindow), button-release-event,
G_CALLBACK(signalButton), this );
#if GTK_CHECK_VERSION(3,0,0)
-g_signal_connect( G_OBJECT(m_pFixedContainer), draw,
G_CALLBACK(signalDraw), this );
+g_signal_connect( G_OBJECT(m_pWindow), draw, G_CALLBACK(signalDraw),
this );
//g_signal_connect( G_OBJECT(m_pWindow), state-flags-changed,
G_CALLBACK(signalFlagsChanged), this );
#if GTK_CHECK_VERSION(3,14,0)
GtkGesture *pSwipe = gtk_gesture_swipe_new(m_pWindow);
@@ -1068,7 +1055,7 @@ void GtkSalFrame::InitCommon()
#endif
#else
-g_signal_connect( G_OBJECT(m_pFixedContainer), expose-event,
G_CALLBACK(signalExpose), this );
+g_signal_connect( G_OBJECT(m_pWindow), expose-event,
G_CALLBACK(signalExpose), this );
#endif
g_signal_connect( G_OBJECT(m_pWindow), focus-in-event,
G_CALLBACK(signalFocus), this );
g_signal_connect( G_OBJECT(m_pWindow), focus-out-event,
G_CALLBACK(signalFocus), this );
@@ -1110,12 +1097,24 @@ void GtkSalFrame::InitCommon()
m_nAppActionGroupExportId = 0;
m_nHudAwarenessId = 0;
+gtk_widget_set_app_paintable( m_pWindow, TRUE );
+/*non-X11 displays won't show anything at all without double-buffering
+ enabled*/
+if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
+gtk_widget_set_double_buffered( m_pWindow, FALSE );
+gtk_widget_set_redraw_on_allocate( m_pWindow, FALSE );
+
gtk_widget_add_events( m_pWindow,
GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK |
GDK_POINTER_MOTION_MASK |
GDK_POINTER_MOTION_HINT_MASK |
GDK_VISIBILITY_NOTIFY_MASK | GDK_SCROLL_MASK
);
+// add the fixed container child,
+// fixed is needed since we have to position plugin windows
+m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), NULL ));
+gtk_container_add( GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pFixedContainer)
);
+
// show the widgets
[Libreoffice-commits] core.git: include/svx svx/source
include/svx/dlgctl3d.hxx |2 --
include/svx/fontworkgallery.hxx |1 -
include/svx/pagectrl.hxx |3 ---
svx/source/accessibility/svxpixelctlaccessiblecontext.cxx | 10 --
svx/source/dialog/dlgctl3d.cxx|2 --
svx/source/dialog/pagectrl.cxx|5 +
svx/source/inc/svxpixelctlaccessiblecontext.hxx |2 --
svx/source/sidebar/graphic/GraphicPropertyPanel.hxx |5 -
svx/source/tbxctrls/fontworkgallery.cxx |1 -
9 files changed, 1 insertion(+), 30 deletions(-)
New commits:
commit 6246755d1cd82a9a16509dd766c1a8b80e8e
Author: Stephan Bergmann sberg...@redhat.com
Date: Fri Jul 24 12:16:33 2015 +0200
-Werror,-Wunused-private-field
Change-Id: Ib32a73e4f74ce7ccd19327ecaed84c16b5c60779
diff --git a/include/svx/dlgctl3d.hxx b/include/svx/dlgctl3d.hxx
index c6f5315..669154b 100644
--- a/include/svx/dlgctl3d.hxx
+++ b/include/svx/dlgctl3d.hxx
@@ -66,8 +66,6 @@ public:
class SVX_DLLPUBLIC SAL_WARN_UNUSED Svx3DLightControl : public
Svx3DPreviewControl
{
// Callback for interactive changes
-Link maUserInteractiveChangeCallback;
-Link maUserSelectionChangeCallback;
Link maChangeCallback;
Link maSelectionChangeCallback;
diff --git a/include/svx/fontworkgallery.hxx b/include/svx/fontworkgallery.hxx
index b415f35..f570f82 100644
--- a/include/svx/fontworkgallery.hxx
+++ b/include/svx/fontworkgallery.hxx
@@ -68,7 +68,6 @@ class SVX_DLLPUBLIC SAL_WARN_UNUSED FontWorkGalleryDialog :
public ModalDialog
sal_uInt16 mnThemeId;
SdrView*mpSdrView;
-FmFormModel*mpModel;
DECL_LINK( DoubleClickFavoriteHdl, void * );
DECL_LINK( ClickOKHdl, void * );
diff --git a/include/svx/pagectrl.hxx b/include/svx/pagectrl.hxx
index 3d7475b..7fb124a 100644
--- a/include/svx/pagectrl.hxx
+++ b/include/svx/pagectrl.hxx
@@ -68,9 +68,6 @@ private:
sal_uInt16 eUsage;
-OUString aLeftText;
-OUString aRightText;
-
protected:
virtual void Paint(vcl::RenderContext rRenderContext, const Rectangle
rRect) SAL_OVERRIDE;
diff --git a/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
b/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
index 5357656..70dab35 100644
--- a/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
+++ b/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
@@ -482,19 +482,11 @@ void SvxPixelCtlAccessible::NotifyChild(long nIndex,bool
bSelect ,bool bCheck)
uno::ReferenceXAccessible SvxPixelCtlAccessible::CreateChild (long
nIndex,Point mPoint)
{
-long nX = mPoint.X();
-long nY = mPoint.Y();
-if( AllSettings::GetLayoutRTL())
-{
-nX = (sal_uInt16) mrPixelCtl.GetWidth() - 1 - nX;
-}
-
bool bPixelColorOrBG = mrPixelCtl.GetBitmapPixel(sal_uInt16(nIndex)) != 0;
Size size(mrPixelCtl.GetWidth() /
mrPixelCtl.GetLineCount(),mrPixelCtl.GetHeight() / mrPixelCtl.GetLineCount());
uno::ReferenceXAccessible xChild;
xChild = new SvxPixelCtlAccessibleChild(mrPixelCtl,
bPixelColorOrBG,
-Point(nX,nY),
Rectangle(mPoint,size),
this,
nIndex);
@@ -557,7 +549,6 @@ void SvxPixelCtlAccessibleChild::FireAccessibleEvent (
SvxPixelCtlAccessibleChild::SvxPixelCtlAccessibleChild(
SvxPixelCtl rWindow,
bool bPixelColorOrBG,
-const Point aPoint,
const Rectangle rBoundingBox,
const uno::ReferenceXAccessible rxParent,
long nIndexInParent ) :
@@ -565,7 +556,6 @@ SvxPixelCtlAccessibleChild::SvxPixelCtlAccessibleChild(
mrParentWindow( rWindow ),
mxParent(rxParent),
m_bPixelColorOrBG(bPixelColorOrBG),
-maPoint(aPoint),
mpBoundingBox( new Rectangle( rBoundingBox ) ),
mnIndexInParent( nIndexInParent ),
mnClientId( 0 )
diff --git a/svx/source/dialog/dlgctl3d.cxx b/svx/source/dialog/dlgctl3d.cxx
index b4b8bea..37d0b6e 100644
--- a/svx/source/dialog/dlgctl3d.cxx
+++ b/svx/source/dialog/dlgctl3d.cxx
@@ -252,8 +252,6 @@ void Svx3DPreviewControl::Set3DAttributes( const
SfxItemSet rAttr )
Svx3DLightControl::Svx3DLightControl(vcl::Window* pParent, WinBits nStyle)
: Svx3DPreviewControl(pParent, nStyle),
-maUserInteractiveChangeCallback(),
-maUserSelectionChangeCallback(),
maChangeCallback(),
maSelectionChangeCallback(),
maSelectedLight(NO_LIGHT_SELECTED),
diff --git a/svx/source/dialog/pagectrl.cxx b/svx/source/dialog/pagectrl.cxx
index ed61268..2e73bef 100644
--- a/svx/source/dialog/pagectrl.cxx
+++ b/svx/source/dialog/pagectrl.cxx
@@ -73,10 +73,7 @@ SvxPageWindow::SvxPageWindow(vcl::Window* pParent)
bTable(false),
bHorz(false),
bVert(false),
-eUsage(SVX_PAGE_ALL),
-
-aLeftText(),
-
[Libreoffice-bugs] [Bug 82135] Cell references don't resolve in imported Excel sheet, but do after edit
https://bugs.documentfoundation.org/show_bug.cgi?id=82135 --- Comment #8 from Marcus Bointon marcus...@synchromedia.co.uk --- Just FYI, the spreadsheets that trigger this problem are generated using PHPExcel. That the cached values are not set correctly is a bug in PHPExcel which has been fixed here: https://github.com/PHPOffice/PHPExcel/issues/433 but LibreOffice's behaviour when dealing with them is still a bug. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [libreoffice-design] Re: [GSoC] Improve user experience with CMIS – Weekly report #6
Dnia 2015-07-23, czw o godzinie 12:15 +0200, Heiko Tietze pisze:
On Monday 20 July 2015, 08:32:49 Jan Holesovsky wrote:
* when opening the Open Remote, and there is no service added yet, the
Add service dialog should open directly
I wouldn't do so. It's pretty clear that no service has been configured.
I've already implemented this and rest of kendy's proposals (not marked
as 'to be discussed') :) I will push my changes to the master branch
then you will be able to try it.
* when opening the Open Remote dialog, either the list of files should
be populated (using the currently selected service), or some feedback
should be given that some user action is expected first
+1 for showing the list of files
(currently the list is updated when an item from the service dropdown is
selected)
Most of services needs authorization, so first the login box appears and
then files will be shown (if password isn't remembered). Problem I have
is: if password is no needed, dialog will appear only after getting
files from remote server. During this time LO is not responsive.
* in the Open Remote, some kind of feedback something is happening
is necessary in when reading the list of files from the remote
Yes, a throbber or even better progress bar makes sense here.
When something is happening, mouse pointer is changed to 'Wait' status.
I can add also throbber (but where?). Progress bar probably is harder to
implement.
* Label: in the Add service dialog should pre-file according to the
user name; like when the user name is 'johndoe', and the service is
GDrive, the Label: should pre-file with Johndoe's GDrive or
something (with the possibility to change this by the user if he/she
wants)
Would be a nice-to-have. But...
Now the default label is just a service type and when user typing own
login, the label is changed with pattern {user}'s {service name} (if
label wasn't changed before by user).
* opening file from the recent documents in the start center asks for
the user name (would be good to remember that or have that as part of
the URL it remembers), and then does not open the file - only the busy
mouse pointer keeps rolling
I started from WriterRecent documents: Remote and after the first dialog
with user name and password I wasn't asked again (edit: but after restart).
As
well at the start center.
Fixed.
BTW: Save works but 'Save as' gives me a 'The folder contents could not be
displayed. Operation not supported' error message. Guess it comes from an
undefined local place (I'm on Linux/KDE). Question here is whether we should
'save as' locally (/home/user; c:\users\name\Documents; /Users/name) or
remotely with a different name.
The same on Linux/GNOME.
+ dialog width restriction is too conservative
I'd like to resize it somewhat smaller to have it in a 4:3 dimension. But
that's not possible due to minimum width of ~800px.
This was caused by long filter names. Now dialog width is independent
and minimum/default width is shorter.
+ 'add/delete service' should be disabled when no service is selected
Both menu entries are enabled even when no service has been defined.
Done.
+ preselection of file type depending on app
Filter is set to 'all files' but could adopted to the running app such as
presentations in case of Impress.
This behaviour is inherited from standard file picker. I will try to do
this.
+ menu
Users might not look for remote files at the recent files menu.
This wasn't intentionally, and now this entry is removed.
However I have
no idea how to solve this problem. 'Open...' and the default open dialog
should stay as it is. And another menu entry on the top level doesn't reflect
the low relevance of CMIS for the average user.
I forgot to add menu entries and I did this during last days. I've added
both open and save.
+ speed
At least WebDAV is slow to an unusable extend.
Now all operations are executed two times (file list and tree), I must
think how to reuse the same data.
+ info/app title
Might be good to know that a document is opened remotely. I suggest to add
this info to the title, like 'Foo.odt (Remote) - LibreofficeDev Writer'.
I will try do this.
I am sorry if this feedback comes too early, and all this is actually on
your todo :-) Either way - great stuff, love the work done so far!
+1 Impressive progress!
Thanks
I also have a proposal to add New Folder button in the save mode. Now
it is possible to save files in the existing directories only. When user
want to save in a folder other than root, must create it using other
tools.
Regards,
Szymon
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88941] Writer/Calc/Draw/Impress lose formatting for justified text when exporting to PDF on OS X builds
https://bugs.documentfoundation.org/show_bug.cgi?id=88941 --- Comment #55 from wu.mi...@icloud.com --- Print to PDF is not a option from Impress because doesn't use native print dialogs and page format is fixed to Portrait. Impress is generally Landscape. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'feature/gsoc15-open-remote-files-dialog' - 63 commits - dbaccess/source desktop/source drawinglayer/source editeng/source filter/source fpicker/source fpicker/u
Rebased ref, commits from common ancestor:
commit 2c6ad5343de947f1646536c539b116346adb8fdc
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 10:46:02 2015 +0200
the dialog width independent from a filters length
Change-Id: If945bafe2f230bf1ede9a12782b6a487b7b08099
diff --git a/fpicker/uiconfig/ui/remotefilesdialog.ui
b/fpicker/uiconfig/ui/remotefilesdialog.ui
index 631d289..c9a6ac0 100644
--- a/fpicker/uiconfig/ui/remotefilesdialog.ui
+++ b/fpicker/uiconfig/ui/remotefilesdialog.ui
@@ -214,6 +214,7 @@
/child
child
object class=GtkComboBox id=filter_lb
+property name=width_request200/property
property name=visibleTrue/property
property name=can_focusFalse/property
property name=hexpandTrue/property
commit 9ef305a1ff535bfa5513dca56aeeb2f6322e2d32
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 10:44:36 2015 +0200
fixed some refresh problems (after resize)
Change-Id: If140a8c9680ac30f5d26f0a034b8a7c7dea4bf64
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index a263c3f..8607af6 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -321,6 +321,7 @@ void RemoteFilesDialog::Resize()
Size aSize = m_pContainer-GetSizePixel();
m_pFileView-SetSizePixel( aSize );
}
+Invalidate(InvalidateFlags::Update);
}
short RemoteFilesDialog::Execute()
@@ -559,6 +560,8 @@ void RemoteFilesDialog::EnableControls()
m_pPath-EnableFields( true );
m_pAddService_btn-Enable( true );
+
+Invalidate(InvalidateFlags::Update);
}
void RemoteFilesDialog::DisableControls()
commit b11f521c56cba07a7b8a0568ca76d48461e08a5f
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 09:47:18 2015 +0200
handle the delete button from PlaceEditDialog
Change-Id: Idb3257d1c106821a6e86182bca79c1aff8bfaea3
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index a810ff8..a263c3f 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -658,6 +658,9 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
m_bIsUpdated = true;
break;
}
+case RET_NO:
+sIdent = delete_service;
+break;
case RET_CANCEL :
default :
// Do Nothing
@@ -665,7 +668,7 @@ IMPL_LINK_TYPED ( RemoteFilesDialog, EditServiceMenuHdl,
MenuButton *, pButton,
};
}
}
-else if( sIdent == delete_service m_pServices_lb-GetEntryCount()
0 )
+if( sIdent == delete_service m_pServices_lb-GetEntryCount() 0 )
{
unsigned int nSelected = m_pServices_lb-GetSelectEntryPos();
int nPos = GetSelectedServicePos();
commit 2c6ffb2c758f70e7259f8285703c22d32f47f7ab
Author: Szymon KÅos eszka...@gmail.com
Date: Fri Jul 24 09:39:09 2015 +0200
don't show edit/delete menu when there is no service
Change-Id: Ia53c9e3f6a4bcaab5e68fbbff6d2ec8cfe5cd702
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx
b/fpicker/source/office/RemoteFilesDialog.cxx
index ab11f2f..a810ff8 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -176,6 +176,7 @@ RemoteFilesDialog::RemoteFilesDialog( vcl::Window* pParent,
WinBits nBits )
, m_pSplitter( NULL )
, m_pFileView( NULL )
, m_pContainer( NULL )
+, m_pAddMenu( NULL )
{
get( m_pCancel_btn, cancel );
get( m_pAddService_btn, add_service_btn );
@@ -252,6 +253,7 @@ RemoteFilesDialog::RemoteFilesDialog( vcl::Window* pParent,
WinBits nBits )
m_pName_ed-SetModifyHdl( LINK( this, RemoteFilesDialog, FileNameModifyHdl
) );
m_pAddService_btn-SetMenuMode( MENUBUTTON_MENUMODE_TIMED );
+m_pAddMenu = m_pAddService_btn-GetPopupMenu();
m_pAddService_btn-SetClickHdl( LINK( this, RemoteFilesDialog,
AddServiceHdl ) );
m_pAddService_btn-SetSelectHdl( LINK( this, RemoteFilesDialog,
EditServiceMenuHdl ) );
@@ -413,7 +415,10 @@ void RemoteFilesDialog::FillServicesListbox()
if( m_pServices_lb-GetEntryCount() 0 )
{
m_pServices_lb-SelectEntryPos( nPos );
+m_pAddService_btn-SetPopupMenu( m_pAddMenu );
}
+else
+m_pAddService_btn-SetPopupMenu( NULL );
EnableControls();
}
@@ -588,6 +593,7 @@ IMPL_LINK_NOARG ( RemoteFilesDialog, AddServiceHdl )
m_pServices_lb-InsertEntry( sPrefix + newService-GetName() );
m_pServices_lb-SelectEntryPos( m_pServices_lb-GetEntryCount() -
1 );
+m_pAddService_btn-SetPopupMenu( m_pAddMenu );
SelectServiceHdl( NULL );
m_bIsUpdated = true;
@@
Re: Docker container for building LibreOffice
Hi Dashamir, On Thursday, 2015-07-23 18:42:23 +0200, Dashamir Hoxha wrote: /compile/libreoffice-5-0/workdir/CxxObject/svtools/source/dialogs/prnsetup.o: In function `PrinterSetupDialog::ImplPropertiesHdl(void*)': prnsetup.cxx:(.text+0x1e67): undefined reference to `Printer::Setup(vcl::Window*)' prnsetup.cxx:(.text+0x1ee5): undefined reference to `Printer::Setup(vcl::Window*)' indeed include/vcl/print.hxx declares Setup( vcl::Window* pWindow = NULL, bool bPapersizeFromSetup = false); since 6779b46796c93cbb4293a400f57c29e8ae85811b on branch libreoffice-5-0 of Jul-7 so workdir/CxxObject/svtools/source/dialogs/prnsetup.o should had been build with a reference to a two parameter Printer::Setup() as well. Are you mixing sources or builds of different checkouts somehow? Excute ./g pull -r in your source tree and then make. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack pgpchBCEj_cIY.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] online.git: loolwsd/debian
loolwsd/debian/control |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5bee6f71a2048dabe699f9cb5bf5a03a3c1de6b0
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 13:39:43 2015 +0300
Add more synthetic dependencies per customer wish
Not sure why they want to depend on those dev packages!?
diff --git a/loolwsd/debian/control b/loolwsd/debian/control
index a15e63e..178761f 100644
--- a/loolwsd/debian/control
+++ b/loolwsd/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.2
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libpng12-0, libxinerama-dev, libcairo2-dev, libgl1-mesa-dev,
libcups2-dev, libdbus-glib-1-dev, cpio
Description: LibreOffice On-Line WebSocket Daemon
LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
services.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-3' - 3 commits - loolwsd/configure.ac loolwsd/debian
loolwsd/configure.ac |2 +-
loolwsd/debian/control |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 67e56dbb711f743805b142cbb228bdc8ad0e142d
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 14:02:29 2015 +0300
Bump version to 1.1.9 after tarball
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 6a777bd..d8946ea 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.69])
-AC_INIT([loolwsd], [1.1.8], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.1.9], [libreoff...@collabora.com])
AM_INIT_AUTOMAKE([1.11 silent-rules])
commit c3368a87ed1e94c062969acd262bb5db6815e8e8
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 13:40:33 2015 +0300
Bump version to 1.1.8 for tarball (and packaging)
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index cfcc00a..6a777bd 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.69])
-AC_INIT([loolwsd], [1.1.7], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.1.8], [libreoff...@collabora.com])
AM_INIT_AUTOMAKE([1.11 silent-rules])
commit 0f3e07729d2e52f8f80de0543bc4be8869075f78
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 13:39:43 2015 +0300
Add more synthetic dependencies per customer wish
Not sure why they want to depend on those dev packages!?
diff --git a/loolwsd/debian/control b/loolwsd/debian/control
index a15e63e..178761f 100644
--- a/loolwsd/debian/control
+++ b/loolwsd/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.2
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}
+Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libpng12-0, libxinerama-dev, libcairo2-dev, libgl1-mesa-dev,
libcups2-dev, libdbus-glib-1-dev, cpio
Description: LibreOffice On-Line WebSocket Daemon
LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
services.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92242] UI - StartCenter and Application windows can not be resized diagonally with mouse after initial window size increase and covers OSX Dock
https://bugs.documentfoundation.org/show_bug.cgi?id=92242 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|UI - StartCenter can not be |UI - StartCenter and |resized diagonally with |Application windows can not |mouse after initial window |be resized diagonally with |size increase and covers|mouse after initial window |OSX Dock|size increase and covers ||OSX Dock --- Comment #3 from Alex Thurgood ipla...@yahoo.co.uk --- The problem of resizing the StartCenter window spreads to the other application windows, so, e.g. Calc window can not be resized diagonally, even if I make the Dock disappear. The only solution I have found to this is to delete the profile and restart LO. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/uibase/docvw/AnnotationWin.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit dcf94ab56d9e5e9864965f56d27045e67b093fa4
Author: Miklos Vajna vmik...@collabora.co.uk
Date: Fri Jul 24 12:34:19 2015 +0200
tdf#92911 SwAnnotationWin rendercontext: fix missing comment contents
The problem was that when inserting a post-it comment, the Paint() is
triggered for SwEditWin, which then shares a RenderContext with its
children, and at the end paints the buffer to the vcl::Window of
SwEditWin. When painting this buffer, the contents of SwAnnotationWin
was missing, as the parent SwEditWin was not allowed to paint on that
area. No explicit clipping is set at the OutputDevice level, but
vcl::Window::ImplClipChildren() still calculates a clip region based on
the child windows for the underlying SalGraphics, and that prevented
SwEditWin to paint its buffer fully.
Fix the problem by explicitly disabling this clipping for
SwAnnotationWin in its ctor in the rendercontext case.
Change-Id: I5eb47c20070057a79297d91242624fc2057e2dfb
diff --git a/sw/source/uibase/docvw/AnnotationWin.cxx
b/sw/source/uibase/docvw/AnnotationWin.cxx
index 9ce682a..efe8876 100644
--- a/sw/source/uibase/docvw/AnnotationWin.cxx
+++ b/sw/source/uibase/docvw/AnnotationWin.cxx
@@ -66,6 +66,10 @@ SwAnnotationWin::SwAnnotationWin( SwEditWin rEditWin,
, mpField( static_castSwPostItField*(aField-GetField()))
, mpButtonPopup(0)
{
+if (SupportsDoubleBuffering())
+// When double-buffering, allow parents to paint on our area. That's
+// necessary when parents paint the complete buffer.
+SetParentClipMode(ParentClipMode::NoClip);
}
SwAnnotationWin::~SwAnnotationWin()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92850] Autocorrection of single quotation marks is disabled by default
https://bugs.documentfoundation.org/show_bug.cgi?id=92850 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Keywords||regression Whiteboard||bibisectRequest --- Comment #2 from Adolfo Jayme f...@libreoffice.org --- Sure – thanks for testing, Tommy. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 5 commits - include/o3tl include/vcl o3tl/CppunitTest_o3tl_tests.mk o3tl/qa scp2/source vcl/inc vcl/opengl vcl/unx
include/o3tl/lru_map.hxx | 141 ++
include/vcl/salnativewidgets.hxx | 42 +
o3tl/CppunitTest_o3tl_tests.mk |1
o3tl/qa/test-lru_map.cxx | 239 +++
scp2/source/ooo/directory_ooo.scp|5
scp2/source/ooo/file_extra_ooo.scp |7
scp2/source/ooo/module_ooo.scp |1
vcl/inc/opengl/x11/gdiimpl.hxx | 11 +
vcl/inc/unx/salgdi.h |6
vcl/inc/unx/x11/x11gdiimpl.h |6
vcl/opengl/x11/gdiimpl.cxx | 95 ++--
vcl/unx/generic/gdi/gdiimpl.cxx | 11 +
vcl/unx/generic/gdi/gdiimpl.hxx |5
vcl/unx/generic/gdi/salgdi2.cxx | 15 +
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx | 23 +-
15 files changed, 587 insertions(+), 21 deletions(-)
New commits:
commit 6c853a986444294dd937cd570a4dc0a31943e432
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Fri Jul 24 16:54:44 2015 +0900
Add styles template folder + content to installation
Change-Id: Ibb674e17eedfc325d3e335aa074391ad7b2b2aa2
diff --git a/scp2/source/ooo/directory_ooo.scp
b/scp2/source/ooo/directory_ooo.scp
index 1337098..0f76c94 100644
--- a/scp2/source/ooo/directory_ooo.scp
+++ b/scp2/source/ooo/directory_ooo.scp
@@ -588,6 +588,11 @@ Directory gid_Dir_Template_Common_Presnt
DosName = presnt;
End
+Directory gid_Dir_Template_Common_Styles
+ParentID = gid_Dir_Template_Common;
+DosName = styles;
+End
+
Directory gid_Brand_Dir_Program_Services
#if defined MACOSX
ParentID = gid_Brand_Dir_Share;
diff --git a/scp2/source/ooo/file_extra_ooo.scp
b/scp2/source/ooo/file_extra_ooo.scp
index c2cc985..f56c028 100644
--- a/scp2/source/ooo/file_extra_ooo.scp
+++ b/scp2/source/ooo/file_extra_ooo.scp
@@ -192,6 +192,13 @@ File gid_File_Extra_Tplpresnt
Name = extras_tplpresnt.filelist;
End
+File gid_File_Extra_Tpl_styles
+Dir = FILELIST_DIR;
+TXT_FILE_BODY;
+Styles = (FILELIST);
+Name = extras_tpl_styles.filelist;
+End
+
File gid_File_Extra_Tplpersonal
Dir = FILELIST_DIR;
TXT_FILE_BODY;
diff --git a/scp2/source/ooo/module_ooo.scp b/scp2/source/ooo/module_ooo.scp
index 50066d3..9acfbe8 100644
--- a/scp2/source/ooo/module_ooo.scp
+++ b/scp2/source/ooo/module_ooo.scp
@@ -80,6 +80,7 @@ Module gid_Module_Root
gid_File_Extra_Tplofficorr,
gid_File_Extra_Tploffimisc,
gid_File_Extra_Tplpresnt,
+ gid_File_Extra_Tpl_styles,
gid_File_Extra_Tplpersonal,
gid_File_Extra_Tplwizbitmap,
gid_File_Extra_Tplwizletter,
commit 1c28c59f927361ef85c8aea8b575d274c532a34d
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Fri Jul 24 16:08:01 2015 +0900
opengl: don't cache checkboxes for now
Change-Id: I67d0dcb48d1843587abbc1dc0f7da1f8057b281e
diff --git a/vcl/opengl/x11/gdiimpl.cxx b/vcl/opengl/x11/gdiimpl.cxx
index 2114419..bf5e6f6 100644
--- a/vcl/opengl/x11/gdiimpl.cxx
+++ b/vcl/opengl/x11/gdiimpl.cxx
@@ -238,8 +238,15 @@ bool
X11OpenGLSalGraphicsImpl::RenderAndCacheNativeControl(X11Pixmap* pPixmap, X
{
std::unique_ptrTextureCombo pCombo(new TextureCombo);
bool bResult = RenderPixmap(pPixmap, pMask, nX, nY, *pCombo);
+if (!bResult)
+return false;
+
+if (aControlCacheKey.mnType == CTRL_CHECKBOX)
+return true;
+
ControlCachePair pair(aControlCacheKey, std::move(pCombo));
gTextureCache.insert(std::move(pair));
+
return bResult;
}
commit 3bc00eca4acf9dfc3b2834077cee552f32c8f107
Author: Tomaž Vajngerl tomaz.vajng...@collabora.co.uk
Date: Fri Jul 24 14:19:35 2015 +0900
Use LRU map for caching of native widgets
Change-Id: Ia0423dac5309aabc5e81357cf4f67b5ee14bab31
diff --git a/vcl/opengl/x11/gdiimpl.cxx b/vcl/opengl/x11/gdiimpl.cxx
index 3890b64..2114419 100644
--- a/vcl/opengl/x11/gdiimpl.cxx
+++ b/vcl/opengl/x11/gdiimpl.cxx
@@ -25,6 +25,8 @@
#include vcl/opengl/OpenGLContext.hxx
#include vcl/opengl/OpenGLHelper.hxx
+#include o3tl/lru_map.hxx
+
X11OpenGLSalGraphicsImpl::X11OpenGLSalGraphicsImpl( X11SalGraphics rParent ):
OpenGLSalGraphicsImpl(rParent,rParent.GetGeometryProvider()),
mrParent(rParent)
@@ -117,9 +119,10 @@ struct TextureCombo
std::unique_ptrOpenGLTexture mpMask;
};
-typedef std::unordered_mapControlCacheKey, std::unique_ptrTextureCombo,
ControlCacheHashFunction ControlCacheType;
+typedef typename std::pairControlCacheKey, std::unique_ptrTextureCombo
ControlCachePair;
+typedef o3tl::lru_mapControlCacheKey, std::unique_ptrTextureCombo,
ControlCacheHashFunction ControlCacheType;
-ControlCacheType gTextureCache;
+ControlCacheType gTextureCache(200);
bool X11OpenGLSalGraphicsImpl::RenderPixmap(X11Pixmap* pPixmap, X11Pixmap*
pMask, int nX, int nY, TextureCombo rCombo)
{
@@ -235,7 +238,8 @@ bool
[Libreoffice-bugs] [Bug 92018] Implement caching for native widget rendering in OpenGL rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=92018 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack|EasyHack |DifficultyInteresting |DifficultyInteresting |SkillCpp|SkillCpp target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 92018] Implement caching for native widget rendering in OpenGL rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=92018 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|EasyHack|EasyHack |DifficultyInteresting |DifficultyInteresting |SkillCpp|SkillCpp target:5.1.0 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 92018] Implement caching for native widget rendering in OpenGL rendering
https://bugs.documentfoundation.org/show_bug.cgi?id=92018 --- Comment #1 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Tomaž Vajngerl committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=450727fdffa4a0dc3b2d4e635a5c1bc0411b3c36 tdf#92018 cache native controls for X11 OpenGL backend (for now) It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92749] VLOOKUP not calculated correctly in the large file from Calc 4.4 (hard recalc helps)
https://bugs.documentfoundation.org/show_bug.cgi?id=92749 --- Comment #11 from Eike Rathke er...@redhat.com --- Geez.. that will take a week alone to figure out the calculation chain and another 2 weeks to analyse what's going wrong... ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 30 commits - fpicker/source fpicker/uiconfig framework/source icon-themes/breeze icon-themes/galaxy icon-themes/hicontrast icon-themes/human icon-themes/tango include/s
fpicker/source/office/RemoteFilesDialog.cxx | 389 +++--- fpicker/source/office/RemoteFilesDialog.hxx | 16 fpicker/source/office/asyncfilepicker.cxx|2 fpicker/source/office/asyncfilepicker.hxx|6 fpicker/source/office/fpdialogbase.hxx |7 fpicker/source/office/iodlg.hxx | 12 fpicker/source/office/iodlg.src |5 fpicker/uiconfig/ui/remotefilesdialog.ui |1 framework/source/classes/resource.src|2 framework/source/uielement/recentfilesmenucontroller.cxx | 62 + icon-themes/breeze/links.txt |3 icon-themes/galaxy/links.txt |3 icon-themes/hicontrast/links.txt |4 icon-themes/human/links.txt |3 icon-themes/tango/links.txt |1 include/svtools/PlaceEditDialog.hxx |6 include/svtools/breadcrumb.hxx |2 include/svtools/foldertree.hxx |1 include/svtools/svtools.hrc |4 include/vcl/fpicker.hrc |1 officecfg/registry/data/org/openoffice/Office/UI/GenericCommands.xcu |8 sc/uiconfig/scalc/menubar/menubar.xml|2 sd/source/ui/app/sddll.cxx |2 sd/uiconfig/sdraw/menubar/menubar.xml|2 sd/uiconfig/sdraw/toolbar/standardbar.xml|3 sd/uiconfig/simpress/menubar/menubar.xml |2 sd/uiconfig/simpress/toolbar/standardbar.xml |3 sfx2/source/toolbox/tbxitem.cxx |6 svtools/source/contnr/fileview.src |6 svtools/source/contnr/foldertree.cxx | 12 svtools/source/control/breadcrumb.cxx| 22 svtools/source/dialogs/PlaceEditDialog.cxx | 48 + svtools/source/dialogs/filedlg2.src |6 sw/uiconfig/swriter/menubar/menubar.xml |2 vcl/unx/gtk/window/gtksalframe.cxx | 17 35 files changed, 542 insertions(+), 129 deletions(-) New commits: commit 2c6ad5343de947f1646536c539b116346adb8fdc Author: Szymon KÅos eszka...@gmail.com Date: Fri Jul 24 10:46:02 2015 +0200 the dialog width independent from a filters length Change-Id: If945bafe2f230bf1ede9a12782b6a487b7b08099 diff --git a/fpicker/uiconfig/ui/remotefilesdialog.ui b/fpicker/uiconfig/ui/remotefilesdialog.ui index 631d289..c9a6ac0 100644 --- a/fpicker/uiconfig/ui/remotefilesdialog.ui +++ b/fpicker/uiconfig/ui/remotefilesdialog.ui @@ -214,6 +214,7 @@ /child child object class=GtkComboBox id=filter_lb +property name=width_request200/property property name=visibleTrue/property property name=can_focusFalse/property property name=hexpandTrue/property commit 9ef305a1ff535bfa5513dca56aeeb2f6322e2d32 Author: Szymon KÅos eszka...@gmail.com Date: Fri Jul 24 10:44:36 2015 +0200 fixed some refresh problems (after resize) Change-Id: If140a8c9680ac30f5d26f0a034b8a7c7dea4bf64 diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index a263c3f..8607af6 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++ b/fpicker/source/office/RemoteFilesDialog.cxx @@ -321,6 +321,7 @@ void RemoteFilesDialog::Resize() Size aSize = m_pContainer-GetSizePixel(); m_pFileView-SetSizePixel( aSize ); } +Invalidate(InvalidateFlags::Update); } short RemoteFilesDialog::Execute() @@ -559,6 +560,8 @@ void RemoteFilesDialog::EnableControls() m_pPath-EnableFields( true ); m_pAddService_btn-Enable( true ); + +Invalidate(InvalidateFlags::Update); } void RemoteFilesDialog::DisableControls() commit b11f521c56cba07a7b8a0568ca76d48461e08a5f Author: Szymon KÅos eszka...@gmail.com Date: Fri Jul 24 09:47:18 2015 +0200 handle the delete button from PlaceEditDialog Change-Id: Idb3257d1c106821a6e86182bca79c1aff8bfaea3 diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx index a810ff8..a263c3f 100644 --- a/fpicker/source/office/RemoteFilesDialog.cxx +++
[Libreoffice-commits] core.git: accessibility/inc avmedia/source basctl/source basic/qa codemaker/source compilerplugins/clang configmgr/source dbaccess/source editeng/source embeddedobj/source extens
accessibility/inc/accessibility/extended/AccessibleGridControl.hxx | 15 -- avmedia/source/gstreamer/gstplayer.cxx |2 avmedia/source/gstreamer/gstwindow.cxx |4 avmedia/source/gstreamer/gstwindow.hxx | 10 - basctl/source/basicide/baside2.hxx |3 basctl/source/basicide/bastype2.hxx|5 basctl/source/basicide/bastype3.hxx|1 basctl/source/basicide/iderdll.cxx |1 basctl/source/basicide/iderdll2.hxx|6 - basctl/source/basicide/moduldlg.hxx|2 basctl/source/inc/basidesh.hxx |3 basctl/source/inc/bastypes.hxx | 13 -- basctl/source/inc/dlged.hxx|1 basctl/source/inc/dlgedobj.hxx |3 basctl/source/inc/propbrw.hxx |1 basic/qa/cppunit/basictest.hxx |9 - codemaker/source/cppumaker/dependencies.hxx| 16 -- codemaker/source/cppumaker/includes.hxx|2 compilerplugins/clang/unusedmethods.cxx| 34 ++ compilerplugins/clang/unusedmethods.py |5 configmgr/source/nodemap.hxx |1 configmgr/source/writemodfile.cxx |2 configmgr/source/writemodfile.hxx |2 dbaccess/source/core/api/CacheSet.cxx |6 - dbaccess/source/core/api/CacheSet.hxx |1 dbaccess/source/core/api/KeySet.cxx| 10 - dbaccess/source/core/api/KeySet.hxx|1 dbaccess/source/core/api/StaticSet.cxx |9 - dbaccess/source/core/api/StaticSet.hxx |1 dbaccess/source/core/api/query.hxx |1 dbaccess/source/core/inc/ContentHelper.hxx |3 editeng/source/items/numitem.cxx |4 editeng/source/outliner/outlin2.cxx|5 editeng/source/outliner/outliner.cxx | 11 -- editeng/source/uno/unoipset.cxx|4 embeddedobj/source/commonembedding/miscobj.cxx | 40 --- embeddedobj/source/commonembedding/specialobject.cxx | 23 embeddedobj/source/inc/commonembobj.hxx|5 embeddedobj/source/inc/docholder.hxx |3 embeddedobj/source/inc/oleembobj.hxx | 29 ++--- embeddedobj/source/inc/specialobject.hxx |4 extensions/source/abpilot/abspilot.hxx |5 extensions/source/bibliography/bibcont.hxx |3 extensions/source/bibliography/datman.hxx |2 extensions/source/dbpilots/gridwizard.hxx |3 extensions/source/propctrlr/browserview.hxx|1 extensions/source/propctrlr/formmetadata.cxx |7 - extensions/source/propctrlr/formmetadata.hxx |1 extensions/source/propctrlr/propertyeditor.hxx |2 extensions/source/propctrlr/propertyinfo.hxx |3 extensions/source/scanner/scanner.hxx |5 include/basebmp/colormisc.hxx | 12 -- include/basegfx/pixel/bpixel.hxx |3 include/basegfx/point/b3dpoint.hxx |5 include/basegfx/range/basicbox.hxx | 55 -- include/editeng/numitem.hxx|1 include/editeng/outliner.hxx | 12 -- include/editeng/unoipset.hxx |6 - sw/inc/numrule.hxx |1 sw/source/core/doc/number.cxx |6 - 60 files changed, 49 insertions(+), 385 deletions(-) New commits: commit 38023af6c13602ae1856bea11693c18c0c3efa36 Author: Noel Grandin n...@peralex.com Date: Thu Jul 23 09:49:57 2015 +0200 loplugin:unusedmethods Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins c...@libreoffice.org
[Libreoffice-commits] core.git: 5 commits - include/linguistic include/sfx2 include/tools include/vcl linguistic/source sfx2/source svtools/source
include/linguistic/lngprops.hxx | 24
include/sfx2/frame.hxx |4 --
include/sfx2/frmdescr.hxx| 24
include/tools/urlobj.hxx | 18 -
include/vcl/gdimtf.hxx |8
linguistic/source/lngopt.cxx | 74 +++
sfx2/source/doc/frmdescr.cxx | 11 ++---
svtools/source/misc/imagemgr.cxx |4 +-
8 files changed, 52 insertions(+), 115 deletions(-)
New commits:
commit 1aab6c8e3d314d601923dd18e252ab30020d0105
Author: Noel Grandin n...@peralex.com
Date: Fri Jul 24 11:32:09 2015 +0200
remove unused define TF_NEWDESKTOP
Change-Id: Ibab48696036d0e7d23c87f11e1e800782dddb366
diff --git a/include/sfx2/frame.hxx b/include/sfx2/frame.hxx
index 5768a3b..a47ad2b 100644
--- a/include/sfx2/frame.hxx
+++ b/include/sfx2/frame.hxx
@@ -19,10 +19,6 @@
#ifndef INCLUDED_SFX2_FRAME_HXX
#define INCLUDED_SFX2_FRAME_HXX
-#ifndef TF_NEWDESKTOP
-#define TF_NEWDESKTOP 1
-#endif
-
#include sal/config.h
#include sfx2/dllapi.h
#include sal/types.h
commit e8c3b599237b915cfdd5df2dedb1b4b4a46f0e47
Author: Noel Grandin n...@peralex.com
Date: Fri Jul 24 11:23:55 2015 +0200
in SfxFrameDescriptor, use normal bool
instead of hard to understand bitmasking
Change-Id: I5f694285af87223b8ccaa50031cbb3c09924e1a8
diff --git a/include/sfx2/frmdescr.hxx b/include/sfx2/frmdescr.hxx
index fbc14c7..34db792 100644
--- a/include/sfx2/frmdescr.hxx
+++ b/include/sfx2/frmdescr.hxx
@@ -57,9 +57,6 @@ enum SizeSelector
SIZE_REL
};
-#define BORDER_SET 2
-#define BORDER_YES 1
-#define BORDER_NO 0
#define SPACING_NOT_SET -1L
#define SIZE_NOT_SET-1L
@@ -75,7 +72,8 @@ class SFX2_DLLPUBLIC SfxFrameDescriptor
longnWidth;
ScrollingMode eScroll;
SizeSelectoreSizeSelector;
-sal_uInt16 nHasBorder;
+boolbHasBorder;
+boolbHasBorderSet;
sal_uInt16 nItemId;
boolbResizeHorizontal;
boolbResizeVertical;
@@ -119,23 +117,19 @@ public:
voidSetScrollingMode( ScrollingMode eMode )
{ eScroll = eMode; }
-// FrameBorder
voidSetWallpaper( const Wallpaper rWallpaper );
-boolHasFrameBorder() const;
+// FrameBorder
+boolHasFrameBorder() const
+{ return bHasBorder; }
boolIsFrameBorderOn() const
-{ return ( nHasBorder BORDER_YES ) != 0; }
-
+{ return bHasBorder; }
voidSetFrameBorder( bool bBorder )
-{
-nHasBorder = bBorder ?
-BORDER_YES | BORDER_SET :
-BORDER_NO | BORDER_SET;
-}
+{ bHasBorder = bBorder; bHasBorderSet = true; }
boolIsFrameBorderSet() const
-{ return (nHasBorder BORDER_SET) != 0; }
+{ return bHasBorderSet; }
voidResetBorder()
-{ nHasBorder = 0; }
+{ bHasBorder = false; bHasBorderSet = false; }
// Copy for example for Views
SfxFrameDescriptor* Clone( bool bWithIds = true ) const;
diff --git a/sfx2/source/doc/frmdescr.cxx b/sfx2/source/doc/frmdescr.cxx
index d3a2ba0..8ce26e5 100644
--- a/sfx2/source/doc/frmdescr.cxx
+++ b/sfx2/source/doc/frmdescr.cxx
@@ -45,7 +45,8 @@ SfxFrameDescriptor::SfxFrameDescriptor() :
nWidth( 0L ),
eScroll( ScrollingAuto ),
eSizeSelector( SIZE_ABS ),
-nHasBorder( BORDER_YES ),
+bHasBorder( true ),
+bHasBorderSet( false ),
nItemId( 0 ),
bResizeHorizontal( true ),
bResizeVertical( true ),
@@ -109,7 +110,8 @@ SfxFrameDescriptor* SfxFrameDescriptor::Clone( bool
bWithIds ) const
pFrame-eScroll = eScroll;
pFrame-bResizeHorizontal = bResizeHorizontal;
pFrame-bResizeVertical = bResizeVertical;
-pFrame-nHasBorder = nHasBorder;
+pFrame-bHasBorder = bHasBorder;
+pFrame-bHasBorderSet = bHasBorderSet;
pFrame-bHasUI = bHasUI;
pFrame-SetReadOnly( IsReadOnly() );
pFrame-SetEditable( IsEditable() );
@@ -130,11 +132,6 @@ SfxFrameDescriptor* SfxFrameDescriptor::Clone( bool
bWithIds ) const
return pFrame;
}
-bool SfxFrameDescriptor::HasFrameBorder() const
-{
-return (nHasBorder BORDER_YES) != 0;
-}
-
void SfxFrameDescriptor::SetWallpaper( const Wallpaper rWallpaper )
{
DELETEZ( pImp-pWallpaper );
commit 93774f29ec42e86b55e89e3f13c011673a55c3ce
[Libreoffice-bugs] [Bug 92912] New: EDITING: Not possible to reference a named range in another sheet
https://bugs.documentfoundation.org/show_bug.cgi?id=92912 Bug ID: 92912 Summary: EDITING: Not possible to reference a named range in another sheet Product: LibreOffice Version: 4.4.4.3 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: marcus...@synchromedia.co.uk Created attachment 117416 -- https://bugs.documentfoundation.org/attachment.cgi?id=117416action=edit Demonstrate cross-sheet named references not working This bug is mentioned in https://bugs.documentfoundation.org/show_bug.cgi?id=82135, and I'm posting it as a separate report as requested. Imported Excel 2007 spreadsheets that contains a formula that refers to a named range on another sheet of the same workbook display a zero value or #NAME? error. In the attached Excel file, cell A1 on sheet2 contains the value 123. That cell is named 'namedthing' and is listed in the named ranges manager. Cell A1 on sheet1 contains a formula that refers to it: ='sheet2'!namedthing. On opening the file, instead of showing the referenced value, it shows a 0 (which may be a symptom of the above linked bug). If I edit the formula, delete the last char and retype it (i.e. not changing it), it changes to a #NAME? error. If I choose insert - names - insert... I can see it defines the name, including which sheet it is defined on, but selecting that inserts only an unqualified name reference (just namedthing) which does not resolve on sheet1. I don't know if this is specific to Excel imports, but I couldn't find any working syntax for cross-sheet named references, for example while =$sheet1.A1 works, =$sheet1.namedthing does not. I also note that the Excel import does not convert references from single-quotes and ! to $ and . syntax. I assume this is supposed to work? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: cui/source
cui/source/inc/cfg.hxx |1 - 1 file changed, 1 deletion(-) New commits: commit 28bc82d8dcc7a65e9c88ff311ac981d556a4896e Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 24 12:57:21 2015 +0200 -Werror,-Wunused-private-field Change-Id: Ie88293e847a3f9a49d34166a1518ba8fe31577b8 diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx index e42a10e..70584ba 100644 --- a/cui/source/inc/cfg.hxx +++ b/cui/source/inc/cfg.hxx @@ -216,7 +216,6 @@ private: OUStringaHelpText; OUStringaLabel; OUStringaCommand; -OUStringaHelpURL; boolbPopUp; boolbStrEdited; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 --- Comment #6 from Michael Cook mco...@mymts.net --- A different hang occurs even if the spreadsheet loads (for example by running the soffice.xcodeproj file in sub-folder OSX of the source code bundle libreoffice-4.4.4.3.tar. In this case, just pick a cell and right-click to copy it: the sub-menu appears but the screen freezes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Build LibreOffice without unit tests
On Fri, Jul 24, 2015 at 11:52:54AM +0200, Noel Grandin wrote: On 2015-07-23 01:32 PM, Jack wrote: Can somebody help me building LibreOffice(Ubuntu) without running any tests? $ make build-nocheck Yes, but ... why?[1] Best, Bjoern [1] Not running tests is not suppossed to be a desireable build scenario. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 92909] UI - Table creation field data types are displayed in rounded buttons that do not fill grid cell (OSX only)
https://bugs.documentfoundation.org/show_bug.cgi?id=92909 Alex Thurgood ipla...@yahoo.co.uk changed: What|Removed |Added Summary|UI - Table creation field |UI - Table creation field |data types are displayed in |data types are displayed in |rounded buttons that do not |rounded buttons that do not |fill grid cell |fill grid cell (OSX only) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92898] LibreOffice Vanilla 100% CPU and have to Force Quit after installing OSX 10.11 Public Beta 2
https://bugs.documentfoundation.org/show_bug.cgi?id=92898 Michael Cook mco...@mymts.net changed: What|Removed |Added Status|NEEDINFO|UNCONFIRMED CC||mco...@mymts.net Ever confirmed|1 |0 --- Comment #5 from Michael Cook mco...@mymts.net --- Michael : how long did you wait for the file open dialog ? -- Forever, but it goes into very high CPU almost straight away. -- A visual clue that NOTHING is happening is that the thermometer at the bottom of the screen never appears - not even a whisker of it. What did you do to open the file ? Double-clic, Cmd-O, or File Open -- I have tried: File Open as well as Double-Clicking on the file I want. -- I did not try Cmd+O. Obviously something changed in OS X 10.11 Public Beta 2 and that change might get reverted for the next iteration Public Beta 3, which could be out within 10 days or so (i.e. around August 1st), or not. The problem has been reported to Apple's Beta Program too. I have Xcode on my system here if you want me to try anything. To keep up with my spreadsheets I just boot back into OS X 10.10.4 once a day. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92242] UI - StartCenter and Application windows can not be resized diagonally with mouse after initial window size increase and covers OSX Dock
https://bugs.documentfoundation.org/show_bug.cgi?id=92242 --- Comment #4 from Alex Thurgood ipla...@yahoo.co.uk --- How to reproduce: 1) Delete LOdev profile from /Users/myuser/Library/Application Support/ 2) Start LOdev 3) Note how StartCenter does not display all launchers. 4) Put mouse cursor at bottom right hand corner of start center window, hover until the diagonal stretch icon is displayed, click and start to drag diagonally outwards and downwards. 5) The StartCenter window automatically expands the window to below the Dock. There is no way to resize that window once that maximum position has been reached, other than shrinking the width - no diagonal shhrinkage is possible. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Crash test update
New crashtest update available at http://dev-builds.libreoffice.org/crashtest/ba39c9dd6a990ebc6dcba8e472c0d7d213de9412/ exportCrashes.csv Description: Binary data importCrash.csv Description: Binary data validationErrors.csv Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 35019] charset autodetection for csv imports
https://bugs.documentfoundation.org/show_bug.cgi?id=35019 --- Comment #4 from li...@whitehouse.kiwi.nz --- Still an issue in Version: 4.4.2.2. I actually ended up using Excel for a bunch of CSV files because when I tried to open them in LibreOffice, the import screen (defaulting to UTF-16) showed the file as a string of unintelligible Asian characters and I was in a hurry. Once I had a bit more time, I realised that making them work in LO was as simple as changing the charset to UTF-8. Excel just worked. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkframe.hxx |2 +-
vcl/unx/gtk/window/gtksalframe.cxx | 35 ++-
2 files changed, 19 insertions(+), 18 deletions(-)
New commits:
commit 298c089df77d9afe2cf86bb7a6a8544a0151e8c5
Author: Caolán McNamara caol...@redhat.com
Date: Fri Jul 24 12:22:14 2015 +0100
gtk3: draw/paint to the fixed container
which fills the toplevel window, rather than directly to the toplevel
window.
It makes no difference for X, but for wayland the window decorations are
part
of the toplevel window, dropping down a level means we don't draw out menu
bar
under the window decoration space
Change-Id: Icec400efacd16b5d901107c13b6fa90c59cad0e6
diff --git a/vcl/inc/unx/gtk/gtkframe.hxx b/vcl/inc/unx/gtk/gtkframe.hxx
index 86cc04f..2e1a5e9 100644
--- a/vcl/inc/unx/gtk/gtkframe.hxx
+++ b/vcl/inc/unx/gtk/gtkframe.hxx
@@ -173,6 +173,7 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
SalX11Screenm_nXScreen;
GtkWidget* m_pWindow;
+GtkFixed* m_pFixedContainer;
GdkWindow* m_pForeignParent;
GdkNativeWindow m_aForeignParentWindow;
GdkWindow* m_pForeignTopLevel;
@@ -180,7 +181,6 @@ class GtkSalFrame : public SalFrame, public
X11WindowProvider
Pixmap m_hBackgroundPixmap;
sal_uLong m_nStyle;
SalExtStyle m_nExtStyle;
-GtkFixed* m_pFixedContainer;
GtkSalFrame*m_pParent;
std::list GtkSalFrame*m_aChildren;
GdkWindowState m_nState;
diff --git a/vcl/unx/gtk/window/gtksalframe.cxx
b/vcl/unx/gtk/window/gtksalframe.cxx
index 6280d37..cf9abac 100644
--- a/vcl/unx/gtk/window/gtksalframe.cxx
+++ b/vcl/unx/gtk/window/gtksalframe.cxx
@@ -415,7 +415,7 @@ void GtkSalFrame::doKeyCallback( guint state,
if (keyval == GDK_0)
{
fprintf( stderr, force widget_queue_draw\n);
-gtk_widget_queue_draw (m_pWindow);
+gtk_widget_queue_draw (m_pFixedContainer);
return;
}
else if (keyval == GDK_1)
@@ -1034,12 +1034,25 @@ void GtkSalFrame::updateScreenNumber()
void GtkSalFrame::InitCommon()
{
+// add the fixed container child,
+// fixed is needed since we have to position plugin windows
+m_pFixedContainer = GTK_FIXED(g_object_new( ooo_fixed_get_type(), NULL ));
+gtk_container_add( GTK_CONTAINER(m_pWindow), GTK_WIDGET(m_pFixedContainer)
);
+
+gtk_widget_set_app_paintable(GTK_WIDGET(m_pFixedContainer), true);
+/*non-X11 displays won't show anything at all without double-buffering
+ enabled*/
+if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
+gtk_widget_set_double_buffered(GTK_WIDGET(m_pFixedContainer), false);
+gtk_widget_set_redraw_on_allocate(GTK_WIDGET(m_pFixedContainer), false);
+
+
// connect signals
g_signal_connect( G_OBJECT(m_pWindow), style-set,
G_CALLBACK(signalStyleSet), this );
g_signal_connect( G_OBJECT(m_pWindow), button-press-event,
G_CALLBACK(signalButton), this );
g_signal_connect( G_OBJECT(m_pWindow), button-release-event,
G_CALLBACK(signalButton), this );
#if GTK_CHECK_VERSION(3,0,0)
-g_signal_connect( G_OBJECT(m_pWindow), draw, G_CALLBACK(signalDraw),
this );
+g_signal_connect( G_OBJECT(m_pFixedContainer), draw,
G_CALLBACK(signalDraw), this );
//g_signal_connect( G_OBJECT(m_pWindow), state-flags-changed,
G_CALLBACK(signalFlagsChanged), this );
#if GTK_CHECK_VERSION(3,14,0)
GtkGesture *pSwipe = gtk_gesture_swipe_new(m_pWindow);
@@ -1055,7 +1068,7 @@ void GtkSalFrame::InitCommon()
#endif
#else
-g_signal_connect( G_OBJECT(m_pWindow), expose-event,
G_CALLBACK(signalExpose), this );
+g_signal_connect( G_OBJECT(m_pFixedContainer), expose-event,
G_CALLBACK(signalExpose), this );
#endif
g_signal_connect( G_OBJECT(m_pWindow), focus-in-event,
G_CALLBACK(signalFocus), this );
g_signal_connect( G_OBJECT(m_pWindow), focus-out-event,
G_CALLBACK(signalFocus), this );
@@ -1097,24 +1110,12 @@ void GtkSalFrame::InitCommon()
m_nAppActionGroupExportId = 0;
m_nHudAwarenessId = 0;
-gtk_widget_set_app_paintable( m_pWindow, TRUE );
-/*non-X11 displays won't show anything at all without double-buffering
- enabled*/
-if (GDK_IS_X11_DISPLAY(getGdkDisplay()))
-gtk_widget_set_double_buffered( m_pWindow, FALSE );
-gtk_widget_set_redraw_on_allocate( m_pWindow, FALSE );
-
gtk_widget_add_events( m_pWindow,
GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK |
GDK_POINTER_MOTION_MASK |
GDK_POINTER_MOTION_HINT_MASK |
GDK_VISIBILITY_NOTIFY_MASK | GDK_SCROLL_MASK
);
-// add the fixed container child,
-// fixed is needed since we have
[Libreoffice-bugs] [Bug 92702] Toolbar: Visible Buttons can't be en-/disabled if they are not displayed
https://bugs.documentfoundation.org/show_bug.cgi?id=92702 Laurent BP jumbo4...@yahoo.fr changed: What|Removed |Added Keywords||regression CC||jumbo4...@yahoo.fr Version|5.0.0.3 rc |5.0.0.0.beta3 --- Comment #2 from Laurent BP jumbo4...@yahoo.fr --- Confirmed with: - Version: 5.0.0.0.beta3 Build ID: 96345c15d8ab19c49014f055fe41ba8e1f421e5c Locale : fr-FR (fr_FR) - Version: 5.1.0.0.alpha1+ Build ID: 698b344fdf42cc9738d5e91cd27876ce1ff39daf TinderBox: Win-x86@39, Branch:master, Time: 2015-06-10_02:24:19 Locale: fr-FR (fr_FR) - Version: 5.1.0.0.alpha1+ Build ID: 8cfdd81b70ef37927b40497ffd10034f28335034 TinderBox: Win-x86@39, Branch:master, Time: 2015-07-24_02:47:18 Locale: fr-FR (fr_FR) NO bug with: - Version: 5.0.0.0.beta1 Build ID: 0a16c3dda4150008d9be6f24cbd15ac198d116d3 Locale : fr-FR (fr_FR) - Version: 5.0.0.0.beta1+ Build ID: 5490bf204e2b1841e72ba0f906b2cf3cd12f583c TinderBox: Win-x86@62-merge-TDF, Branch:libreoffice-5-0, Time: 2015-05-28_21:56:25 Locale: fr-FR (fr_FR) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: loolwsd/debian
loolwsd/debian/control |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit bbd5e54785b3d2f504520879d1f58b06ba6f1c2e
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 14:21:49 2015 +0300
Let's try to have a bit saner dependencies
Surely loolwsd shouldn't depend on dev packages. And libpng12 gets included
automatically.
diff --git a/loolwsd/debian/control b/loolwsd/debian/control
index 178761f..6a204c7 100644
--- a/loolwsd/debian/control
+++ b/loolwsd/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.2
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libpng12-0, libxinerama-dev, libcairo2-dev, libgl1-mesa-dev,
libcups2-dev, libdbus-glib-1-dev, cpio
+Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libxinerama1, libcairo2, libgl1-mesa-glx, libcups2, libdbus-glib-1-2,
cpio
Description: LibreOffice On-Line WebSocket Daemon
LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
services.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 85891] Symbols too small in Formulas
https://bugs.documentfoundation.org/show_bug.cgi?id=85891 Adolfo Jayme f...@libreoffice.org changed: What|Removed |Added Summary|Symbols to small in |Symbols too small in |Formulas|Formulas -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-3' - 3 commits - loolwsd/configure.ac loolwsd/debian
loolwsd/configure.ac |2 +-
loolwsd/debian/control |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 8bca709a2ea98fd538e1e98988c7730b41ac1f2c
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 14:31:11 2015 +0300
Bump version to 1.1.11 after tarball
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index dfcd79b..a6404fc 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.69])
-AC_INIT([loolwsd], [1.1.10], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.1.11], [libreoff...@collabora.com])
AM_INIT_AUTOMAKE([1.11 silent-rules])
commit e53fa7d6ece3fd94c4410dd0300452c9e3397812
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 14:22:29 2015 +0300
Bump version to 1.1.10 for tarball (and packaging)
diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index d8946ea..dfcd79b 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
AC_PREREQ([2.69])
-AC_INIT([loolwsd], [1.1.9], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.1.10], [libreoff...@collabora.com])
AM_INIT_AUTOMAKE([1.11 silent-rules])
commit 089ee2c92bbcbb00cba09fb7403d1b4c99532fef
Author: Tor Lillqvist t...@collabora.com
Date: Fri Jul 24 14:21:49 2015 +0300
Let's try to have a bit saner dependencies
Surely loolwsd shouldn't depend on dev packages. And libpng12 gets included
automatically.
diff --git a/loolwsd/debian/control b/loolwsd/debian/control
index 178761f..6a204c7 100644
--- a/loolwsd/debian/control
+++ b/loolwsd/debian/control
@@ -8,7 +8,7 @@ Standards-Version: 3.9.2
Package: loolwsd
Section: web
Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libpng12-0, libxinerama-dev, libcairo2-dev, libgl1-mesa-dev,
libcups2-dev, libdbus-glib-1-dev, cpio
+Depends: ${shlibs:Depends}, ${misc:Depends}, libssl1.0.0, libmysqlclient18,
libodbc1, libxinerama1, libcairo2, libgl1-mesa-glx, libcups2, libdbus-glib-1-2,
cpio
Description: LibreOffice On-Line WebSocket Daemon
LOOLWSD is a daemon that talks to web browser clients and provides LibreOffice
services.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/inc sc/qa sc/source
sc/inc/calcconfig.hxx |2 +
sc/qa/unit/ucalc_formula.cxx | 11
sc/source/core/tool/calcconfig.cxx | 12 -
sc/source/core/tool/interpr1.cxx |7 -
sc/source/ui/optdlg/calcoptionsdlg.cxx |2 -
sc/source/ui/unoobj/confuno.cxx| 43 ++---
6 files changed, 50 insertions(+), 27 deletions(-)
New commits:
commit 738be269bfc795400fcb10d4eefb6c33b17bded4
Author: Katarina Behrens katarina.behr...@cib.de
Date: Thu Jul 23 09:52:59 2015 +0200
tdf#92256: Handle case when string ref syntax is unknown
i.e. the document doesn't have that property. Use CONV_A1_XL_A1
pseudoconvention for interpreting INDIRECT in such case
Change-Id: If9bac9053029b4b8f79d3ac7ac0759adbb25803f
Reviewed-on: https://gerrit.libreoffice.org/17311
Reviewed-by: Eike Rathke er...@redhat.com
Tested-by: Eike Rathke er...@redhat.com
diff --git a/sc/inc/calcconfig.hxx b/sc/inc/calcconfig.hxx
index d10154c..18aab21 100644
--- a/sc/inc/calcconfig.hxx
+++ b/sc/inc/calcconfig.hxx
@@ -43,6 +43,7 @@ struct SC_DLLPUBLIC ScCalcConfig
formula::FormulaGrammar::AddressConvention meStringRefAddressSyntax;
StringConversion meStringConversion;
bool mbEmptyStringAsZero:1;
+bool mbHasStringRefSyntax:1;
bool mbOpenCLSubsetOnly:1;
bool mbOpenCLAutoSelect:1;
@@ -59,6 +60,7 @@ struct SC_DLLPUBLIC ScCalcConfig
void reset();
void MergeDocumentSpecific( const ScCalcConfig r );
+void SetStringRefSyntax( formula::FormulaGrammar::AddressConvention eConv
);
bool operator== (const ScCalcConfig r) const;
bool operator!= (const ScCalcConfig r) const;
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 8610c54..b7c4fd7 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -4396,9 +4396,10 @@ void Test::testFuncINDIRECT()
m_pDoc-CalcAll();
{
-// Default is to use the current formula syntax, which is Calc A1.
+// Default is to use compatibility mode, accept both Calc A1 and
+// Excel A1 syntax
const OUString* aChecks[] = {
-aTest, aRefErr, aRefErr, aTest
+aTest, aTest, aRefErr, aTest
};
for (size_t i = 0; i SAL_N_ELEMENTS(aChecks); ++i)
@@ -4409,7 +4410,7 @@ void Test::testFuncINDIRECT()
}
ScCalcConfig aConfig;
-aConfig.meStringRefAddressSyntax = formula::FormulaGrammar::CONV_OOO;
+aConfig.SetStringRefSyntax( formula::FormulaGrammar::CONV_OOO );
m_pDoc-SetCalcConfig(aConfig);
m_pDoc-CalcAll();
{
@@ -4425,7 +4426,7 @@ void Test::testFuncINDIRECT()
}
}
-aConfig.meStringRefAddressSyntax = formula::FormulaGrammar::CONV_XL_A1;
+aConfig.SetStringRefSyntax( formula::FormulaGrammar::CONV_XL_A1 );
m_pDoc-SetCalcConfig(aConfig);
m_pDoc-CalcAll();
{
@@ -4441,7 +4442,7 @@ void Test::testFuncINDIRECT()
}
}
-aConfig.meStringRefAddressSyntax = formula::FormulaGrammar::CONV_XL_R1C1;
+aConfig.SetStringRefSyntax( formula::FormulaGrammar::CONV_XL_R1C1 );
m_pDoc-SetCalcConfig(aConfig);
m_pDoc-CalcAll();
{
diff --git a/sc/source/core/tool/calcconfig.cxx
b/sc/source/core/tool/calcconfig.cxx
index 6fd4345..cc52ad7 100644
--- a/sc/source/core/tool/calcconfig.cxx
+++ b/sc/source/core/tool/calcconfig.cxx
@@ -23,7 +23,8 @@
ScCalcConfig::ScCalcConfig() :
meStringRefAddressSyntax(formula::FormulaGrammar::CONV_UNSPECIFIED),
meStringConversion(StringConversion::LOCALE), // old LibreOffice
behavior
-mbEmptyStringAsZero(false)
+mbEmptyStringAsZero(false),
+mbHasStringRefSyntax(false)
{
setOpenCLConfigToDefault();
@@ -85,6 +86,13 @@ void ScCalcConfig::MergeDocumentSpecific( const
ScCalcConfig r )
mbEmptyStringAsZero = r.mbEmptyStringAsZero;
// INDIRECT ref syntax is per document.
meStringRefAddressSyntax = r.meStringRefAddressSyntax;
+mbHasStringRefSyntax = r.mbHasStringRefSyntax;
+}
+
+void ScCalcConfig::SetStringRefSyntax(
formula::FormulaGrammar::AddressConvention eConv )
+{
+meStringRefAddressSyntax = eConv;
+mbHasStringRefSyntax = true;
}
bool ScCalcConfig::operator== (const ScCalcConfig r) const
@@ -92,6 +100,7 @@ bool ScCalcConfig::operator== (const ScCalcConfig r) const
return meStringRefAddressSyntax == r.meStringRefAddressSyntax
meStringConversion == r.meStringConversion
mbEmptyStringAsZero == r.mbEmptyStringAsZero
+ mbHasStringRefSyntax == r.mbHasStringRefSyntax
mbOpenCLSubsetOnly == r.mbOpenCLSubsetOnly
mbOpenCLAutoSelect == r.mbOpenCLAutoSelect
maOpenCLDevice == r.maOpenCLDevice
@@ -127,6 +136,7 @@ std::ostream operator(std::ostream rStream, const
ScCalcConfig rConfig)
StringRefAddressSyntax= rConfig.meStringRefAddressSyntax ,
StringConversion=
[Libreoffice-bugs] [Bug 92904] Insert character dialog grid doesn't update the list of symbols
https://bugs.documentfoundation.org/show_bug.cgi?id=92904 --- Comment #7 from Francisco franciscoadriansanc...@gmail.com --- (In reply to V Stuart Foote from comment #6) Reopened bug 91748, which included issue of refreshing the grid of glyphs when changing font selection. Which, despite c#15 there was apparently not fixed. Understood. I though it was simply relatos to it. Thanks for all, Stuart. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92256] INDIRECT function lost interoperabilty with calc documents migrated by OOo3.2.1
https://bugs.documentfoundation.org/show_bug.cgi?id=92256 --- Comment #26 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Katarina Behrens committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=738be269bfc795400fcb10d4eefb6c33b17bded4 tdf#92256: Handle case when string ref syntax is unknown It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 82135] Cell references don't resolve in imported Excel sheet, but do after edit
https://bugs.documentfoundation.org/show_bug.cgi?id=82135 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEW |UNCONFIRMED Ever confirmed|1 |0 --- Comment #9 from Joel Madero jmadero@gmail.com --- Never independently confirmed - setting to UNCONFIRMED. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
