[Libreoffice-commits] core.git: include/oox oox/inc oox/source
include/oox/core/contexthandler.hxx |4 ++-- include/oox/core/fasttokenhandler.hxx |4 ++-- include/oox/core/filterbase.hxx |4 ++-- include/oox/core/filterdetect.hxx |7 +++ include/oox/core/fragmenthandler.hxx |4 ++-- include/oox/vml/vmlinputstream.hxx|4 ++-- oox/inc/pch/precompiled_oox.hxx |3 +-- oox/source/core/recordparser.cxx |4 ++-- oox/source/crypto/DocumentDecryption.cxx |6 +++--- oox/source/docprop/docprophandler.hxx |4 ++-- oox/source/docprop/ooxmldocpropimport.hxx |4 ++-- oox/source/export/ColorPropertySet.cxx|4 ++-- oox/source/export/ColorPropertySet.hxx|4 ++-- oox/source/helper/propertymap.cxx |4 ++-- oox/source/helper/textinputstream.cxx |4 ++-- oox/source/ole/olestorage.cxx |4 ++-- oox/source/ole/vbamodule.cxx |1 - oox/source/shape/ShapeContextHandler.hxx |4 ++-- 18 files changed, 35 insertions(+), 38 deletions(-) New commits: commit 7f4e0d6aa29da640408cf4cc84b2fc1a0c11f8ba Author: Takeshi Abe t...@fixedpoint.jp Date: Sat Aug 22 17:06:40 2015 +0900 oox: tdf#88206 replace cppu::WeakImplHelper* etc. with the variadic variants. Change-Id: I8a82df7ea24874d8e246dc983418d872f1943c8e Reviewed-on: https://gerrit.libreoffice.org/17919 Reviewed-by: Noel Grandin noelgran...@gmail.com Tested-by: Noel Grandin noelgran...@gmail.com diff --git a/include/oox/core/contexthandler.hxx b/include/oox/core/contexthandler.hxx index 85f1552..a6de85d 100644 --- a/include/oox/core/contexthandler.hxx +++ b/include/oox/core/contexthandler.hxx @@ -21,7 +21,7 @@ #define INCLUDED_OOX_CORE_CONTEXTHANDLER_HXX #include com/sun/star/xml/sax/XFastContextHandler.hpp -#include cppuhelper/implbase1.hxx +#include cppuhelper/implbase.hxx #include rtl/ref.hxx #include oox/token/namespaces.hxx #include oox/token/tokens.hxx @@ -48,7 +48,7 @@ typedef ::rtl::Reference ContextHandler ContextHandlerRef; struct FragmentBaseData; typedef std::shared_ptr FragmentBaseData FragmentBaseDataRef; -typedef ::cppu::WeakImplHelper1 ::com::sun::star::xml::sax::XFastContextHandler ContextHandler_BASE; +typedef ::cppu::WeakImplHelper ::com::sun::star::xml::sax::XFastContextHandler ContextHandler_BASE; class OOX_DLLPUBLIC ContextHandler : public ContextHandler_BASE { diff --git a/include/oox/core/fasttokenhandler.hxx b/include/oox/core/fasttokenhandler.hxx index cdb9682..ff6fd2c 100644 --- a/include/oox/core/fasttokenhandler.hxx +++ b/include/oox/core/fasttokenhandler.hxx @@ -23,7 +23,7 @@ #include oox/dllapi.h #include com/sun/star/lang/XServiceInfo.hpp #include com/sun/star/xml/sax/XFastTokenHandler.hpp -#include cppuhelper/implbase2.hxx +#include cppuhelper/implbase.hxx #include sax/fastattribs.hxx namespace oox { class TokenMap; } @@ -37,7 +37,7 @@ namespace core { that provides access to the tokens generated from the internal token name list. */ class OOX_DLLPUBLIC FastTokenHandler : -public ::cppu::WeakImplHelper2 ::com::sun::star::lang::XServiceInfo, +public ::cppu::WeakImplHelper ::com::sun::star::lang::XServiceInfo, ::com::sun::star::xml::sax::XFastTokenHandler , public sax_fastparser::FastTokenHandlerBase { diff --git a/include/oox/core/filterbase.hxx b/include/oox/core/filterbase.hxx index 0273716..471377f 100644 --- a/include/oox/core/filterbase.hxx +++ b/include/oox/core/filterbase.hxx @@ -30,7 +30,7 @@ #include com/sun/star/lang/XInitialization.hpp #include com/sun/star/lang/XServiceInfo.hpp #include cppuhelper/basemutex.hxx -#include cppuhelper/implbase5.hxx +#include cppuhelper/implbase.hxx #include comphelper/sequenceashashmap.hxx #include oox/helper/binarystreambase.hxx #include oox/helper/storagebase.hxx @@ -82,7 +82,7 @@ enum OoxmlVersion struct FilterBaseImpl; -typedef ::cppu::WeakImplHelper5 +typedef ::cppu::WeakImplHelper ::com::sun::star::lang::XServiceInfo, ::com::sun::star::lang::XInitialization, ::com::sun::star::document::XImporter, diff --git a/include/oox/core/filterdetect.hxx b/include/oox/core/filterdetect.hxx index 23bd36e..622027f 100644 --- a/include/oox/core/filterdetect.hxx +++ b/include/oox/core/filterdetect.hxx @@ -24,8 +24,7 @@ #include com/sun/star/document/XExtendedFilterDetection.hpp #include com/sun/star/lang/XServiceInfo.hpp #include com/sun/star/xml/sax/XFastDocumentHandler.hpp -#include cppuhelper/implbase1.hxx -#include cppuhelper/implbase2.hxx +#include cppuhelper/implbase.hxx #include oox/dllapi.h namespace com { namespace sun { namespace star { @@ -47,7 +46,7 @@ namespace core { It takes a reference to the filter string object via its constructor, and puts the name of the detected filter to it, if it successfully finds one. */ -class FilterDetectDocHandler : public ::cppu::WeakImplHelper1
[Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #69 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9beb2bedc0f65b90cd35f7fa6c9b53ee6729a0c4 tdf#39440 sc: reduce scope of local variables It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: sc/source
sc/source/core/tool/interpr2.cxx |2 +- sc/source/core/tool/interpr5.cxx | 15 +-- sc/source/filter/qpro/qproform.cxx |2 +- sc/source/ui/docshell/dbdocimp.cxx |7 +++ sc/source/ui/docshell/docfunc.cxx |8 +++- sc/source/ui/docshell/docsh4.cxx |4 ++-- 6 files changed, 15 insertions(+), 23 deletions(-) New commits: commit 9beb2bedc0f65b90cd35f7fa6c9b53ee6729a0c4 Author: Michael Weghorn m.wegh...@posteo.de Date: Sat Aug 22 14:10:55 2015 +0200 tdf#39440 sc: reduce scope of local variables This addresses some cppcheck warnings. Change-Id: Ia7f58c24429310b66f4464d8ba8b4f2e5c6fef38 Reviewed-on: https://gerrit.libreoffice.org/17922 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Noel Grandin noelgran...@gmail.com diff --git a/sc/source/core/tool/interpr2.cxx b/sc/source/core/tool/interpr2.cxx index 9df3a90..0596782 100644 --- a/sc/source/core/tool/interpr2.cxx +++ b/sc/source/core/tool/interpr2.cxx @@ -1194,7 +1194,6 @@ void ScInterpreter::ScIRR() while (fEps SCdEpsilon nItCount nIterationsMax) { // Newtons method: sp = sPos; // reset stack -double nCount = 0.0; double fNom = 0.0; double fDenom = 0.0; sal_uInt16 nErr = 0; @@ -1202,6 +1201,7 @@ void ScInterpreter::ScIRR() ScValueIterator aValIter(pDok, aRange, mnSubTotalFlags); if (aValIter.GetFirst(fValue, nErr)) { +double nCount = 0.0; fNom += fValue / pow(1.0+x,(double)nCount); fDenom += -nCount * fValue / pow(1.0+x,nCount+1.0); nCount++; diff --git a/sc/source/core/tool/interpr5.cxx b/sc/source/core/tool/interpr5.cxx index 907ce8d..6861e93 100644 --- a/sc/source/core/tool/interpr5.cxx +++ b/sc/source/core/tool/interpr5.cxx @@ -1956,16 +1956,11 @@ double lcl_GetSign(double fValue) bool lcl_CalculateQRdecomposition(ScMatrixRef pMatA, ::std::vector double pVecR, SCSIZE nK, SCSIZE nN) { -double fScale ; -double fEuclid ; -double fFactor ; -double fSignum ; -double fSum ; // ScMatrix matrices are zero based, index access (column,row) for (SCSIZE col = 0; col nK; col++) { // calculate vector u of the householder transformation -fScale = lcl_GetColumnMaximumNorm(pMatA, col, col, nN); +const double fScale = lcl_GetColumnMaximumNorm(pMatA, col, col, nN); if (fScale == 0.0) { // A is singular @@ -1974,16 +1969,16 @@ bool lcl_CalculateQRdecomposition(ScMatrixRef pMatA, for (SCSIZE row = col; row nN; row++) pMatA-PutDouble( pMatA-GetDouble(col,row)/fScale, col, row); -fEuclid = lcl_GetColumnEuclideanNorm(pMatA, col, col, nN); -fFactor = 1.0/fEuclid/(fEuclid + fabs(pMatA-GetDouble(col,col))); -fSignum = lcl_GetSign(pMatA-GetDouble(col,col)); +const double fEuclid = lcl_GetColumnEuclideanNorm(pMatA, col, col, nN); +const double fFactor = 1.0/fEuclid/(fEuclid + fabs(pMatA-GetDouble(col,col))); +const double fSignum = lcl_GetSign(pMatA-GetDouble(col,col)); pMatA-PutDouble( pMatA-GetDouble(col,col) + fSignum*fEuclid, col,col); pVecR[col] = -fSignum * fScale * fEuclid; // apply Householder transformation to A for (SCSIZE c=col+1; cnK; c++) { -fSum =lcl_GetColumnSumProduct(pMatA, col, pMatA, c, col, nN); +const double fSum =lcl_GetColumnSumProduct(pMatA, col, pMatA, c, col, nN); for (SCSIZE row = col; row nN; row++) pMatA-PutDouble( pMatA-GetDouble(c,row) - fSum * fFactor * pMatA-GetDouble(col,row), c, row); } diff --git a/sc/source/filter/qpro/qproform.cxx b/sc/source/filter/qpro/qproform.cxx index 4a70e87..95e4db3 100644 --- a/sc/source/filter/qpro/qproform.cxx +++ b/sc/source/filter/qpro/qproform.cxx @@ -189,7 +189,6 @@ ConvErr QProToSc::Convert( const ScTokenArray* pArray, sal_uInt16 /*nLen*/, con FUNC_TYPE eType; DefTokenId eOc; double nFloatArray[ nBufSize ] = {0}; -double nFloat; const sal_Char* pExtString = 0; aCRD.InitFlags(); @@ -212,6 +211,7 @@ ConvErr QProToSc::Convert( const ScTokenArray* pArray, sal_uInt16 /*nLen*/, con if( nFmla[ i ] == 0x00 ) { +double nFloat; maIn.ReadDouble( nFloat ); nFloatArray[ nFloatCount ] = nFloat; SAFEDEC_OR_RET(nRef, 8, ConvErrCount); diff --git a/sc/source/ui/docshell/dbdocimp.cxx b/sc/source/ui/docshell/dbdocimp.cxx index b7ea4ca..bb48cd0 100644 --- a/sc/source/ui/docshell/dbdocimp.cxx +++ b/sc/source/ui/docshell/dbdocimp.cxx @@ -152,7 +152,6 @@ bool ScDBDocFunc::DoImport( SCTAB nTab, const ScImportParam rParam, SCROW nRow = rParam.nRow1; SCCOL nEndCol = nCol; // end of
[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #69 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9beb2bedc0f65b90cd35f7fa6c9b53ee6729a0c4 tdf#39440 sc: reduce scope of local variables It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sc/source
sc/source/ui/navipi/content.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 90b086e480a83c62edafaf13bdf4a02079a7860c Author: Michael Weghorn m.wegh...@posteo.de Date: Sat Aug 22 14:31:09 2015 +0200 tdf#39440 reduce variable scope, adapt indentation This addresses a cppcheck variableScope warning and adapts the indentation of some code lines according to the surrounding code. Change-Id: I76eca59a808740ab0366dd41c889a6ef19a2436d Reviewed-on: https://gerrit.libreoffice.org/17923 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Noel Grandin noelgran...@gmail.com diff --git a/sc/source/ui/navipi/content.cxx b/sc/source/ui/navipi/content.cxx index 5dd7d76..204e312 100644 --- a/sc/source/ui/navipi/content.cxx +++ b/sc/source/ui/navipi/content.cxx @@ -154,7 +154,6 @@ void ScContentTree::dispose() // helper function for GetEntryAltText and GetEntryLongDescription OUString ScContentTree::getAltLongDescText( SvTreeListEntry* pEntry, bool isAltText) const { -SdrObject* pFound = NULL; sal_uInt16 nType; sal_uLong nChild; @@ -165,6 +164,7 @@ OUString ScContentTree::getAltLongDescText( SvTreeListEntry* pEntry, bool isAltT case SC_CONTENT_GRAPHIC: case SC_CONTENT_DRAWING: { +SdrObject* pFound = NULL; ScDocument* pDoc = ( const_cast ScContentTree* (this) )-GetSourceDocument(); SdrIterMode eIter = ( nType == SC_CONTENT_DRAWING ) ? IM_FLAT : IM_DEEPNOGROUPS; ScDrawLayer* pDrawLayer = pDoc-GetDrawLayer(); @@ -192,13 +192,13 @@ OUString ScContentTree::getAltLongDescText( SvTreeListEntry* pEntry, bool isAltT } } } - if( pFound ) - { +if( pFound ) +{ if( isAltText ) return pFound-GetTitle(); else return pFound-GetDescription(); - } +} } break; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #68 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=90b086e480a83c62edafaf13bdf4a02079a7860c tdf#39440 reduce variable scope, adapt indentation It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #68 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=90b086e480a83c62edafaf13bdf4a02079a7860c tdf#39440 reduce variable scope, adapt indentation It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #33 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f4e0d6aa29da640408cf4cc84b2fc1a0c11f8ba oox: tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 88206] Change uses of cppu::WeakImplHelper* and cppu::ImplInheritanceHelper* to use variadic variants instead
https://bugs.documentfoundation.org/show_bug.cgi?id=88206 --- Comment #33 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Takeshi Abe committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=7f4e0d6aa29da640408cf4cc84b2fc1a0c11f8ba oox: tdf#88206 replace cppu::WeakImplHelper* etc. It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #67 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b712b1f63492a311e4a51cffd516b3e202a140e6 tdf#39440 cppcheck: redundantAssignment It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: dtrans/test onlineupdate/source registry/source sal/qa sal/workben shell/source
dtrans/test/win32/dnd/dndTest.cxx |3 +-- onlineupdate/source/update/updater/progressui_win.cxx |3 +-- registry/source/regimpl.cxx |6 ++ sal/qa/rtl/locale/rtl_locale.cxx |3 +-- sal/workben/testfile.cxx |4 +--- shell/source/win32/simplemail/smplmailclient.cxx |3 +-- 6 files changed, 7 insertions(+), 15 deletions(-) New commits: commit b712b1f63492a311e4a51cffd516b3e202a140e6 Author: Michael Weghorn m.wegh...@posteo.de Date: Sat Aug 22 16:50:56 2015 +0200 tdf#39440 cppcheck: redundantAssignment This addresses some of cppcheck's redundantAssignment warnings (Variable 'varName' is reassigned a value before the old one has been used). Change-Id: I8fd2950d5aa1a3f4bd9e1c4c336abe465d1f657e Reviewed-on: https://gerrit.libreoffice.org/17926 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Noel Grandin noelgran...@gmail.com diff --git a/dtrans/test/win32/dnd/dndTest.cxx b/dtrans/test/win32/dnd/dndTest.cxx index d026132..aae5851 100644 --- a/dtrans/test/win32/dnd/dndTest.cxx +++ b/dtrans/test/win32/dnd/dndTest.cxx @@ -122,8 +122,7 @@ HRESULT doTest() extern ReferenceXMultiServiceFactory MultiServiceFactory; DWORD WINAPI MTAFunc( void* threadData) { -HRESULT hr= S_OK; -hr= CoInitializeEx( NULL, COINIT_MULTITHREADED); +HRESULT hr= CoInitializeEx( NULL, COINIT_MULTITHREADED); ATLASSERT( FAILED(hr) ); MSG msg; // force the creation of a message queue diff --git a/onlineupdate/source/update/updater/progressui_win.cxx b/onlineupdate/source/update/updater/progressui_win.cxx index 3cbbc6b..49ae81e 100644 --- a/onlineupdate/source/update/updater/progressui_win.cxx +++ b/onlineupdate/source/update/updater/progressui_win.cxx @@ -284,8 +284,7 @@ ShowProgressUI(bool indeterminate, bool initUIStrings) actx.lpSource = appPath; actx.lpResourceName = MAKEINTRESOURCE(IDR_COMCTL32_MANIFEST); - HANDLE hactx = INVALID_HANDLE_VALUE; - hactx = CreateActCtxW(actx); + HANDLE hactx = CreateActCtxW(actx); ULONG_PTR actxCookie = NULL; if (hactx != INVALID_HANDLE_VALUE) { // Push the specified activation context to the top of the activation stack. diff --git a/registry/source/regimpl.cxx b/registry/source/regimpl.cxx index 3499a5a..92a4187 100644 --- a/registry/source/regimpl.cxx +++ b/registry/source/regimpl.cxx @@ -904,11 +904,10 @@ RegError ORegistry::deleteSubkeysAndValues(ORegKey* pKey) RegError ORegistry::loadKey(RegKeyHandle hKey, const OUString regFileName, bool bWarnings, bool bReport) { -RegError _ret = RegError::NO_ERROR; ORegKey* pKey = static_cast ORegKey* (hKey); std::unique_ptr ORegistry pReg (new ORegistry()); -_ret = pReg-initRegistry(regFileName, RegAccessMode::READONLY); +RegError _ret = pReg-initRegistry(regFileName, RegAccessMode::READONLY); if (_ret != RegError::NO_ERROR) return _ret; ORegKey* pRootKey = pReg-getRootKey(); @@ -952,11 +951,10 @@ RegError ORegistry::loadKey(RegKeyHandle hKey, const OUString regFileName, RegError ORegistry::saveKey(RegKeyHandle hKey, const OUString regFileName, bool bWarnings, bool bReport) { -RegError _ret = RegError::NO_ERROR; ORegKey* pKey = static_cast ORegKey* (hKey); std::unique_ptr ORegistry pReg (new ORegistry()); -_ret = pReg-initRegistry(regFileName, RegAccessMode::READWRITE, true/*bCreate*/); +RegError _ret = pReg-initRegistry(regFileName, RegAccessMode::READWRITE, true/*bCreate*/); if (_ret != RegError::NO_ERROR) return _ret; ORegKey* pRootKey = pReg-getRootKey(); diff --git a/sal/qa/rtl/locale/rtl_locale.cxx b/sal/qa/rtl/locale/rtl_locale.cxx index ef8d7e3..f2b03fe 100644 --- a/sal/qa/rtl/locale/rtl_locale.cxx +++ b/sal/qa/rtl/locale/rtl_locale.cxx @@ -269,8 +269,7 @@ public: rtl_Locale* pData1 = rtl_locale_register(rtl::OUString(en).getStr(), rtl::OUString(US).getStr(), rtl::OUString().getStr()); rtl_Locale* pData2 = rtl_locale_register(rtl::OUString(en).getStr(), rtl::OUString(US).getStr(), rtl::OUString().getStr()); -bool bLocaleAreEqual = false; -bLocaleAreEqual = (pData1 == pData2); +bool bLocaleAreEqual = (pData1 == pData2); CPPUNIT_ASSERT_MESSAGE(check operator ==(), bLocaleAreEqual); } diff --git a/sal/workben/testfile.cxx b/sal/workben/testfile.cxx index addb1b6..dd9448b 100644 --- a/sal/workben/testfile.cxx +++ b/sal/workben/testfile.cxx @@ -2455,10 +2455,8 @@ void print_error( const ::rtl::OString str, FileBase::RC rc ) int MAIN( int argc, char* argv[] ) { -sal_Bool fSuccess=sal_False; - //Initialization -fSuccess=Initialize(); +sal_Bool fSuccess=Initialize(); if ( !fSuccess ) { printf(Error during Initialization); diff --git a/shell/source/win32/simplemail/smplmailclient.cxx
[Libreoffice-commits] core.git: bin/gbuild-to-ide
bin/gbuild-to-ide | 28 1 file changed, 16 insertions(+), 12 deletions(-) New commits: commit 93cd7b78c29c11ccc87c19c845c6617acb834630 Author: brinzing oliver.brinz...@gmx.de Date: Sat Aug 22 21:51:01 2015 +0200 exclude unnamed Library/Executable from ide integration unnamed (None) Library/Executable will prevent correct vs 2013 ide integration Change-Id: Ia00c02609a83b5f891995e54fd3f365cd63cb7a4 Reviewed-on: https://gerrit.libreoffice.org/17933 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: Noel Grandin noelgran...@gmail.com diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide index 4ad7d4b..865a0b8 100755 --- a/bin/gbuild-to-ide +++ b/bin/gbuild-to-ide @@ -116,21 +116,25 @@ class GbuildParser: libmatch = GbuildParser.libpattern.match(line) if libmatch: libname = self.libnames.get(state.ilib, None) -self.libs.append( -GbuildLib(libmatch.group(2), libname, libmatch.group(1), - state.include, state.include_sys, state.defs, state.cxxobjects, - state.cxxflags, state.linked_libs)) -state = GbuildParserState() -return state +if libname != None: +print('add Library: %s' % libname, end='\n') +self.libs.append( +GbuildLib(libmatch.group(2), libname, libmatch.group(1), + state.include, state.include_sys, state.defs, state.cxxobjects, + state.cxxflags, state.linked_libs)) +state = GbuildParserState() +return state exematch = GbuildParser.exepattern.match(line) if exematch: exename = self.exenames.get(state.target, None) -self.exes.append( -GbuildExe(exematch.group(2), exename, exematch.group(1), - state.include, state.include_sys, state.defs, state.cxxobjects, - state.cxxflags, state.linked_libs)) -state = GbuildParserState() -return state +if exename != None: +print('add Executable: %s' % exename, end='\n') +self.exes.append( +GbuildExe(exematch.group(2), exename, exematch.group(1), + state.include, state.include_sys, state.defs, state.cxxobjects, + state.cxxflags, state.linked_libs)) +state = GbuildParserState() +return state if line.find('# INCLUDE :=') == 0: isystemmatch = GbuildParser.isystempattern.findall(line) if isystemmatch: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #67 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Michael Weghorn committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=b712b1f63492a311e4a51cffd516b3e202a140e6 tdf#39440 cppcheck: redundantAssignment It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93601] New: Change of anchor to page feature für pictures, frames etc. could be helpful
https://bugs.documentfoundation.org/show_bug.cgi?id=93601 Bug ID: 93601 Summary: Change of anchor to page feature für pictures, frames etc. could be helpful Product: LibreOffice Version: 3.3.0 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wilfriedk...@gmx.de This description comes from writing several books (200... 300 pages) with OpenOffice / LibreOffice I use anchoring to page in the final step of the document production in order bind pictures etc. firmly to a certain place of the document. I tried and discussed al lot of other methods of anchoring but all of them are very sensitive against minor changes in formatting and do not gurantee reliable results. Anchoring an object to the page of a document means in fact anchoring it to the page number. If I have picture anchored to page 2 of my document at a fine place in the text and I add a new page after the actual page one then the pictute is still anchored to page 2 which now is a new empty page and the tect is on page 3 far away from the picture belonging to it. In my opinion it would be a better and more useful solution to keep the picture on the new page 3. The same would apply for deleting pages. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93603] New: No separator line when toolbars are vertical
https://bugs.documentfoundation.org/show_bug.cgi?id=93603 Bug ID: 93603 Summary: No separator line when toolbars are vertical Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Created attachment 118103 -- https://bugs.documentfoundation.org/attachment.cgi?id=118103action=edit screenshot There isnt a separator line when toolbars are moved to the left and right of the UI. This should be based on whether a user's theme has this separator line. At the moment, this enhancement would improve the current drawing toolbar in 5.0. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93603] New: No separator line when toolbars are vertical
https://bugs.documentfoundation.org/show_bug.cgi?id=93603 Bug ID: 93603 Summary: No separator line when toolbars are vertical Product: LibreOffice Version: Inherited From OOo Hardware: Other OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-b...@lists.freedesktop.org Reporter: philip...@hotmail.com CC: libreoffice-ux-advise@lists.freedesktop.org Created attachment 118103 -- https://bugs.documentfoundation.org/attachment.cgi?id=118103action=edit screenshot There isnt a separator line when toolbars are moved to the left and right of the UI. This should be based on whether a user's theme has this separator line. At the moment, this enhancement would improve the current drawing toolbar in 5.0. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 79452] Themes with a separator line per toolbar incorrectly places separator line when toolbar is on bottom
https://bugs.documentfoundation.org/show_bug.cgi?id=79452 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||603 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93603] No separator line when toolbars are vertical
https://bugs.documentfoundation.org/show_bug.cgi?id=93603 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists | |.freedesktop.org| Component|ux-advise |UI See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||452 Ever confirmed|0 |1 --- Comment #1 from Yousuf (Jay) Philips philip...@hotmail.com --- Setting to NEW as enhancement. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 91969] FORMATTING: Parts of Paragraph Border missing when Border around more than one Paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=91969 Commit Notification libreoffice-comm...@lists.freedesktop.org changed: What|Removed |Added Whiteboard|bibisected |bibisected target:5.1.0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 91969] FORMATTING: Parts of Paragraph Border missing when Border around more than one Paragraph
https://bugs.documentfoundation.org/show_bug.cgi?id=91969 --- Comment #6 from Commit Notification libreoffice-comm...@lists.freedesktop.org --- Zolnai Tamás committed a patch related to this issue. It has been pushed to master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d933132ab01f0070225fae6cf704c9a1982e8f8 tdf#91969: Parts of paragraph border is missing It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - vcl/workben xmlsecurity/source
vcl/workben/fftester.cxx |8 ++-- xmlsecurity/source/helper/xsecsign.cxx |6 +++--- 2 files changed, 5 insertions(+), 9 deletions(-) New commits: commit 63cbf8fb02c3c53acc31c56a79c3f39e02c92f7b Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 19:58:58 2015 +0100 fail on exception Change-Id: Ib48c6b05b7002db19e47d07fcfc0241468452190 diff --git a/vcl/workben/fftester.cxx b/vcl/workben/fftester.cxx index b50df80..adf03b9 100644 --- a/vcl/workben/fftester.cxx +++ b/vcl/workben/fftester.cxx @@ -377,13 +377,9 @@ try_again: /* If AFL_PERSISTENT not set or PERSIST_MAX exceeded, exit normally. */ } -catch (const Exception e) +catch (...) { -SAL_WARN(vcl.app, Fatal exception: e.Message); -} -catch (const std::exception e) -{ -SAL_WARN(vcl.app, Fatal exception: e.what()); +abort(); } _exit(ret); commit e903601e636bcec8bdb7d1a4acb4bab27bf87533 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 17:21:16 2015 +0100 can replace sequence with simple array here Change-Id: I1b5125f5354dc2a1f4b4312dbe2b921d5cf13b49 diff --git a/xmlsecurity/source/helper/xsecsign.cxx b/xmlsecurity/source/helper/xsecsign.cxx index cfa312e..70149ce 100644 --- a/xmlsecurity/source/helper/xsecsign.cxx +++ b/xmlsecurity/source/helper/xsecsign.cxx @@ -43,14 +43,14 @@ namespace cssxs = com::sun::star::xml::sax; /* protected: for signature generation */ OUString XSecController::createId() { -cssu::Sequence sal_Int8 aSeq( 16 ); -rtl_createUuid (reinterpret_castsal_uInt8 *(aSeq.getArray()), 0, sal_True); +sal_uInt8 aSeq[16]; +rtl_createUuid( aSeq, 0, true ); char str[68]=ID_; int length = 3; for (int i=0; i16; ++i) { -length += sprintf(str+length, %04x, (unsigned char)aSeq[i]); +length += sprintf(str+length, %04x, aSeq[i]); } return OUString::createFromAscii(str); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93598] Saving causes a table frames loss.
https://bugs.documentfoundation.org/show_bug.cgi?id=93598 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #1 from Joel Madero jmadero@gmail.com --- Hi - Can you please describe the steps clearer - you said after selecting a table frame style - please enumerate (1. do x, 2. do y..etc...) what that means and then set the bug to UNCONFIRMED. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93579] Formulas Don't Update After Removing Content of Related Cells
https://bugs.documentfoundation.org/show_bug.cgi?id=93579 Joel Madero jmadero@gmail.com changed: What|Removed |Added Keywords||regression Priority|medium |high Status|UNCONFIRMED |NEW Hardware|Other |All Summary|Delete cell contents but|Formulas Don't Update After |formulas, some numbers |Removing Content of Related |remains |Cells Ever confirmed|0 |1 Whiteboard||bibisectRequest --- Comment #5 from Joel Madero jmadero@gmail.com --- @Grobe - great instructions :) Thanks Confirmed Ubuntu 15.04 x64 LibreOffice 4.4.5.2, 5.0.0.5 (both confirmed) LibreOffice 3.3 seems okay New; Minor - can slow down professional quality work but won't prevent it; High - an error can slip through on a more complicated file that a user would not reasonably see without quite a bit of inspection of the file @Grobe - if you have some time to help out - QA would love to see you in the chat http://webchat.freenode.net/?channels=libreoffice-qa -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - javaunohelper/com xmerge/source
javaunohelper/com/sun/star/lib/uno/helper/InterfaceContainer.java |2 + javaunohelper/com/sun/star/lib/uno/helper/PropertySet.java | 17 -- javaunohelper/com/sun/star/lib/uno/helper/PropertySetMixin.java |2 - xmerge/source/aportisdoc/java/org/openoffice/xmerge/converter/xml/sxw/aportisdoc/DocumentMergerImpl.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/BeginningOfFile.java | 11 -- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/BlankCell.java |5 +- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/BoolErrCell.java |6 +-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/BoundSheet.java |6 +-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/CellValue.java |6 +-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/ColInfo.java |6 +-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefColWidth.java | 14 xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefRowHeight.java |6 --- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/DefinedName.java |9 + xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/ExtendedFormat.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/FloatNumber.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/FontDescription.java |9 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Formula.java |7 +--- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/LabelCell.java |4 +- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Row.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Selection.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/StringValue.java |6 +-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Window1.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Window2.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Workbook.java |8 xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/Worksheet.java | 15 ++-- xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/FormulaCompiler.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/FormulaParser.java | 12 +++ xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/SymbolLookup.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/formula/TokenEncoder.java |4 +- xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentDeserializerImpl.java |2 - xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentMergerImpl.java |2 - xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/DocumentSerializerImpl.java |4 +- xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/PluginFactoryImpl.java |4 +- xmerge/source/pocketword/java/org/openoffice/xmerge/converter/xml/sxw/pocketword/PocketWordDocument.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentDeserializerFactory.java |4 +- xmerge/source/xmerge/java/org/openoffice/xmerge/converter/palm/PalmDocument.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/converter/palm/PdbEncoder.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/converter/palm/Record.java |4 +- xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/EmbeddedXMLObject.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java |6 +--
[Libreoffice-bugs] [Bug 93147] Check for Updates feature fails immediately in Win 10
https://bugs.documentfoundation.org/show_bug.cgi?id=93147 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu --- Created attachment 118102 -- https://bugs.documentfoundation.org/attachment.cgi?id=118102action=edit clip of the check for updates dialog running on Windows 10 Can not confirm, working from Windows 10 Pro 64-bit with Version: 4.3.0.4 Build ID: 62ad5818884a2fc2e5780dd45466868d41009ec0 Version: 4.4.1.2 Build ID: 45e2de17089c24a1fa810c8f975a7171ba4cd432 Locale: en_US The download correctly takes you to the LibreOffice downloads Still site on the default browser, FF in my case. Not using edge, so that might be an issue for folks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Alternate link for pushing commits
Hey, On Sun, Aug 23, 2015 at 6:45 PM, Shreyansh Gandhi gandhish...@gmail.com wrote: Hi, Apparently the git:// protocol doesn't work on my network. Is there an alternate link such as the http lik for pulling? Pushing happens through the ssh protocol. Please have a look at https://wiki.documentfoundation.org/Development/gerrit. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |INVALID --- Comment #4 from V Stuart Foote vstuart.fo...@utsa.edu --- It is exactly the issue of bug 93550, and yes I did. Not my first rodeo dude. I know that it will install to a non-default, non-system disk as I said proven in bug 93550. The solution for you is exactly the same. Remove your prior installs of LibreOffice, clean your system. Then when using the Custom installation that is required, *be sure* that your specified disk remains set at the end of the customization. Problem is on your end. So I'll get heavy handed Resolved Invalid, but once you do what was suggested--feel free to change to Resolved Works for Me. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93606] The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||vstuart.fo...@utsa.edu --- Comment #2 from V Stuart Foote vstuart.fo...@utsa.edu --- Created attachment 118104 -- https://bugs.documentfoundation.org/attachment.cgi?id=118104action=edit clip of LO 5.0.1.2 Windows installer dialog configured for non-system folder It is a little unclear what you are trying to achieve. Custom install dialogs for both the 32-bit and 64-bit MSInstaller packages will allow and honor setting a non-system drive and non-Program Files or Program Files (x86) location. If you have residual elements from prior LibreOffice installations still registered in the Windows regsitry or global cache they can cause issues on a full install of a recent build. If what you are attempting is to have multiple installations--you have to install in parallel, using the MSInstaller /a administrative installation. Only one install can be a full installation registered in the Windows registry. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa sw/source
sw/qa/core/data/ww6/pass/crash-7.doc |binary sw/source/filter/basflt/fltshell.cxx | 26 ++ 2 files changed, 18 insertions(+), 8 deletions(-) New commits: commit e1276f7bd5a396f23856d039f3e79e20aa8232fc Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 17:13:23 2015 +0100 check for bad locations (cherry picked from commit b164d08f0c12a3434fad1b40900ddc8cb510370c) Change-Id: I635585f664e700047d92821fb965d42b803a8a15 Reviewed-on: https://gerrit.libreoffice.org/17939 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/core/data/ww6/pass/crash-7.doc b/sw/qa/core/data/ww6/pass/crash-7.doc new file mode 100644 index 000..5a9dab3 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/crash-7.doc differ diff --git a/sw/source/filter/basflt/fltshell.cxx b/sw/source/filter/basflt/fltshell.cxx index 549731a..ef46c21 100644 --- a/sw/source/filter/basflt/fltshell.cxx +++ b/sw/source/filter/basflt/fltshell.cxx @@ -419,25 +419,33 @@ SwFltStackEntry* SwFltControlStack::SetAttr(const SwPosition rPos, return pRet; } -static void MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion) { // the anchor is the Pam's Point. It's modified when inserting // text, etc.; therefore it is kept on the stack. Only the // attribute's format needs to be set. rRegion.DeleteMark(); -rRegion.GetPoint()-nNode = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; + +sal_uLong nMk = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; +const SwNodes rMkNodes = rEntry.m_aMkPos.m_nNode.GetNodes(); +if (nMk = rMkNodes.Count()) +return false; + +rRegion.GetPoint()-nNode = nMk; SwCntntNode* pCNd = GetCntntNode(pDoc, rRegion.GetPoint()-nNode, true); rRegion.GetPoint()-nContent.Assign(pCNd, rEntry.m_aMkPos.m_nCntnt); +return true; } // MakeBookRegionOrPoint() behaves like MakeRegionOrPoint, except that // it adheres to certain restrictions on bookmarks in tables (cannot // span more than one cell) -static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion, bool bCheck ) { -if (rEntry.MakeRegion(pDoc, rRegion, bCheck )){ +if (rEntry.MakeRegion(pDoc, rRegion, bCheck )) +{ // sal_Bool b1 = rNds[rRegion.GetPoint()-nNode]-FindTableNode() != 0; if (rRegion.GetPoint()-nNode.GetNode().FindTableBoxStartNode() != rRegion.GetMark()-nNode.GetNode().FindTableBoxStartNode()) @@ -445,9 +453,9 @@ static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, rRegion.Exchange(); // invalid range rRegion.DeleteMark(); // - both to mark } -}else{ -MakePoint(rEntry, pDoc, rRegion); +return true; } +return MakePoint(rEntry, pDoc, rRegion); } // IterateNumrulePiece() looks for the first range valid for Numrules @@ -596,8 +604,10 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition rTmpPos, break; case RES_FLTR_ANNOTATIONMARK: { -MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true); -pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +if (MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true)) +pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +else +SAL_WARN(sw, failed to make book region or point); } break; case RES_FLTR_TOX: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa sw/source
sw/qa/core/data/ww6/pass/crash-6.doc |binary sw/source/filter/basflt/fltshell.cxx | 13 ++--- 2 files changed, 10 insertions(+), 3 deletions(-) New commits: commit 4efb0056f24698516aa5550ec926255da45a2381 Author: Caolán McNamara caol...@redhat.com Date: Sat Aug 22 10:31:35 2015 +0100 check that src index is in doc range (cherry picked from commit 3230c8cf1cf2dc486f038d369e7f4f44ffd6b0a7) check that dest index is in doc range (cherry picked from commit cd6c9aef7468120dd5ea5c747f35c98baf214613) Change-Id: Ic81e7a14701ff30aa46a9293dd6db351bd350ba5 3006cf03cf97399a6c418162178acdb1d41c3b23 Reviewed-on: https://gerrit.libreoffice.org/17928 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/core/data/ww6/pass/crash-6.doc b/sw/qa/core/data/ww6/pass/crash-6.doc new file mode 100644 index 000..08c8791 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/crash-6.doc differ diff --git a/sw/source/filter/basflt/fltshell.cxx b/sw/source/filter/basflt/fltshell.cxx index 53a9b66..549731a 100644 --- a/sw/source/filter/basflt/fltshell.cxx +++ b/sw/source/filter/basflt/fltshell.cxx @@ -120,8 +120,11 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM rRegion, bool bCheck, // The only position of 0x0D will not be able to make region in the old logic // because it is beyond the length of para...need special consideration here. -SwCntntNode *const pCntntNode( -SwNodeIndex(rMkPos.m_nNode, +1).GetNode().GetCntntNode()); +sal_uLong nMk = rMkPos.m_nNode.GetIndex() + 1; +const SwNodes rMkNodes = rMkPos.m_nNode.GetNodes(); +if (nMk = rMkNodes.Count()) +return false; +SwCntntNode *const pCntntNode(rMkNodes[nMk]-GetCntntNode()); if (rMkPos == rPtPos ((0 != rPtPos.m_nCntnt) || (pCntntNode (0 != pCntntNode-Len( ( RES_TXTATR_FIELD != nWhich @@ -138,7 +141,11 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM rRegion, bool bCheck, rRegion.SetMark(); if (rMkPos.m_nNode != rPtPos.m_nNode) { -rRegion.GetPoint()-nNode = rPtPos.m_nNode.GetIndex() + 1; +sal_uLong n = rPtPos.m_nNode.GetIndex() + 1; +SwNodes rNodes = rRegion.GetPoint()-nNode.GetNodes(); +if (n = rNodes.Count()) +return false; +rRegion.GetPoint()-nNode = n; pCNd = GetCntntNode(pDoc, rRegion.GetPoint()-nNode, false); } rRegion.GetPoint()-nContent.Assign(pCNd, rPtPos.m_nCntnt); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93606] The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |WORKSFORME --- Comment #5 from Joel Madero jmadero@gmail.com --- I am actually going to go ahead and close this as WFM. I just tested this on Windows 8.1. What I did: 1. Completely removed LibreOffice; 2. Did custom install of LibreOffice 5 and installed to D drive It works as expected so I'm relatively positive that this is about parallel install and that wiki will explain how to do that. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93601] Change of anchor to page feature für pictures, frames etc. could be helpful
https://bugs.documentfoundation.org/show_bug.cgi?id=93601 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #1 from Joel Madero jmadero@gmail.com --- Please attach a simple test case (simple as in 2-3 pages, not a 200 page book :) ) and then set the bug to UNCONFIRMED. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: jvmfwk/plugins
jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c571bcd775ebcb3ad69099bdc0c326d28c00c78c Author: Stephan Bergmann sberg...@redhat.com Date: Sun Aug 23 21:55:05 2015 +0200 loplugin:defaultparams Change-Id: I797b986b227381bc066ea3aa305c0abf78cd156a diff --git a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx index 634f65b..90bcd37 100644 --- a/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx +++ b/jvmfwk/plugins/sunmajor/pluginlib/sunjavaplugin.cxx @@ -669,7 +669,7 @@ javaPluginError jfw_plugin_startJavaVirtualMachine( #if defined(WNT) do_msvcr_magic(sRuntimeLib.pData); #endif -if (!moduleRt.load(sRuntimeLib, SAL_LOADMODULE_DEFAULT)) +if (!moduleRt.load(sRuntimeLib)) #endif { JFW_ENSURE(false, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Alternate link for pushing commits
Hi, Apparently the git:// protocol doesn't work on my network. Is there an alternate link such as the http lik for pulling? -Shreyansh -- Regards, Shreyansh Gandhi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93147] Check for Updates feature fails immediately in Win 10
https://bugs.documentfoundation.org/show_bug.cgi?id=93147 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added URL||http://cgit.freedesktop.org ||/libreoffice/website/log/ch ||eck.php?h=update See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=90 ||456 --- Comment #5 from V Stuart Foote vstuart.fo...@utsa.edu --- Also getting correct check for update referrals, opening with FireFox, to Still branch 4.4.5 release loaded on Windows 10 Pro 64-bit with Version: 4.4.2.2 Build ID: c4c7d32d0d49397cad38d62472b0bc8acff48dd6 Locale: en_US and Version: 4.4.4.3 Build ID: 2c39ebcf046445232b798108aa8a7e7d89552ea8 Locale: en_US This is all correct, as the 4.4 branch will not receive cross upgrade suggestion to a 5.x branch until at least 5.0.3 release, if not later--as the cross upgrade offer logic 4.y.z - 5.y.z still has to be worked out. And these all remain manual download, manual uninstall and manual upgrade to next release chosen until a something with the ref issues can be accomplished. =-Refs-= bug 54242 -- Incremental update support (small partial diff updates) bug 74934 -- 'Install' button in update dialog is never activated -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 90456] Check for updates on Windows release builds responding ... up to Date
https://bugs.documentfoundation.org/show_bug.cgi?id=90456 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=93 ||147 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93604] New: Envelop Addresses Print, but not on the Envelop.
https://bugs.documentfoundation.org/show_bug.cgi?id=93604 Bug ID: 93604 Summary: Envelop Addresses Print, but not on the Envelop. Product: LibreOffice Version: unspecified Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mike_pi...@hotmail.com So when did this start to occur? Since pre-historic times. Since Libre got forked or before. And now with version 5. Libre Writer has never printed envelops correctly on an Epson R2000 or R1900 or 1280 or...? I have tried dozens of times, and have selected all of the options and oriented the envelop every way possible, L/R, V/H, including upside down, but that was a mistake. I have only tried 2 envelop sizes, not that it matters: #10 and 1/4 A. How do I know that it's possible to print envelops at all? Because MS Office 2002 prints them easily, and with no fuss! On the first try! And the addresses are exactly where they're supposed to be, not missing the envelop completely, or printed in some other unusual place. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 3 commits - filter/CppunitTest_filter_msfilter.mk filter/CppunitTest_filter_utils.mk filter/Module_filter.mk filter/qa filter/source sw/source
filter/CppunitTest_filter_msfilter.mk | 46 filter/CppunitTest_filter_utils.mk| 46 filter/Module_filter.mk |2 filter/qa/cppunit/msfilter-test.cxx | 77 ++ filter/qa/cppunit/utils-test.cxx | 77 -- filter/source/msfilter/util.cxx | 12 ++--- sw/source/core/layout/paintfrm.cxx|4 - 7 files changed, 132 insertions(+), 132 deletions(-) New commits: commit 8d933132ab01f0070225fae6cf704c9a1982e8f8 Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Sun Aug 23 19:15:14 2015 +0200 tdf#91969: Parts of paragraph border is missing ...when border is around more than one paragraph Regression from: 16f637dab3c1b5f7ac9eacf2c57347800d3fdf09 Change-Id: Iea9455dd7cc3c301c3e2d5d7903c98d98e515595 diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx index b3e1f77..db70553 100644 --- a/sw/source/core/layout/paintfrm.cxx +++ b/sw/source/core/layout/paintfrm.cxx @@ -487,13 +487,13 @@ static sal_uInt8 lcl_TryMergeLines( { double const fMergeGap(properties.nSPixelSzW + properties.nSHalfPixelSzW); // NOT static! // A is above/before B -if( mergeA.second = mergeB.second +if( mergeA.second = mergeB.first mergeA.second + fMergeGap = mergeB.first ) { return 1; } // B is above/before A -else if( mergeB.second = mergeA.second +else if( mergeB.second = mergeA.first mergeB.second + fMergeGap = mergeA.first ) { return 2; commit 9a23428ff030106c4d91ba8b6f3a68ce56b7c428 Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Fri Jul 24 04:23:30 2015 +0200 Use less operator here to be consistent with the original idea (see comment) This doesn't change the result of the BestIndex method Change-Id: If1efc04feac3d4966c126b1fa93d017a4beafbe1 diff --git a/filter/source/msfilter/util.cxx b/filter/source/msfilter/util.cxx index f7e44c0..ce51d20 100644 --- a/filter/source/msfilter/util.cxx +++ b/filter/source/msfilter/util.cxx @@ -1361,17 +1361,17 @@ namespace static void CalculateScheme(const BitmapColor rBitmapColor, std::vectorint vScheme, sal_uInt16 nVariance) { vScheme.resize(3,1); -if( rBitmapColor.GetRed() rBitmapColor.GetGreen() + nVariance ) +if( rBitmapColor.GetRed() rBitmapColor.GetGreen() + nVariance ) ++vScheme[0]; -if( rBitmapColor.GetRed() rBitmapColor.GetBlue() + nVariance ) +if( rBitmapColor.GetRed() rBitmapColor.GetBlue() + nVariance ) ++vScheme[0]; -if( rBitmapColor.GetGreen() rBitmapColor.GetRed() + nVariance ) +if( rBitmapColor.GetGreen() rBitmapColor.GetRed() + nVariance ) ++vScheme[1]; -if( rBitmapColor.GetGreen() rBitmapColor.GetBlue() + nVariance ) +if( rBitmapColor.GetGreen() rBitmapColor.GetBlue() + nVariance ) ++vScheme[1]; -if( rBitmapColor.GetBlue() rBitmapColor.GetRed() + nVariance ) +if( rBitmapColor.GetBlue() rBitmapColor.GetRed() + nVariance ) ++vScheme[2]; -if( rBitmapColor.GetBlue() rBitmapColor.GetGreen() + nVariance ) +if( rBitmapColor.GetBlue() rBitmapColor.GetGreen() + nVariance ) ++vScheme[2]; } commit 3f339c5e77881a0680552c05997db03a7587bf4b Author: Zolnai Tamás zolnaitamas2...@gmail.com Date: Thu Jul 16 21:49:55 2015 +0200 Better to call this msfilter test Change-Id: I2abd6aedb16303d8988c17e7204c9607bf8336a3 diff --git a/filter/CppunitTest_filter_utils.mk b/filter/CppunitTest_filter_msfilter.mk similarity index 56% rename from filter/CppunitTest_filter_utils.mk rename to filter/CppunitTest_filter_msfilter.mk index 1d042a9..aa567cd 100644 --- a/filter/CppunitTest_filter_utils.mk +++ b/filter/CppunitTest_filter_msfilter.mk @@ -7,18 +7,18 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. # -$(eval $(call gb_CppunitTest_CppunitTest,filter_utils)) +$(eval $(call gb_CppunitTest_CppunitTest,filter_msfilter)) -$(eval $(call gb_CppunitTest_use_sdk_api,filter_utils)) -$(eval $(call gb_CppunitTest_use_ure,filter_utils)) +$(eval $(call gb_CppunitTest_use_sdk_api,filter_msfilter)) +$(eval $(call gb_CppunitTest_use_ure,filter_msfilter)) -$(eval $(call gb_CppunitTest_use_configuration,filter_utils)) +$(eval $(call gb_CppunitTest_use_configuration,filter_msfilter)) -$(eval $(call gb_CppunitTest_use_externals,filter_utils, \ +$(eval $(call gb_CppunitTest_use_externals,filter_msfilter, \ boost_headers \ )) -$(eval $(call gb_CppunitTest_use_libraries,filter_utils, \ +$(eval $(call gb_CppunitTest_use_libraries,filter_msfilter, \ tl \ comphelper \ unotest \ @@ -29,7 +29,7 @@ $(eval $(call gb_CppunitTest_use_libraries,filter_utils, \ $(gb_UWINAPI) \ )) -$(eval $(call gb_CppunitTest_use_components,filter_utils,\ +$(eval $(call gb_CppunitTest_use_components,filter_msfilter,\
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added CC||f...@libreoffice.org, ||heiko.tie...@user-prompt.co ||m --- Comment #11 from Yousuf (Jay) Philips philip...@hotmail.com --- (In reply to V Stuart Foote from comment #5) When a Shape is added to the Writer document, you have to also give it a name. Once named it will show in Navigator for Writer in the Draw objects section. Why all this inconsistency with behaviour. We dont ask users to name an image or OLE for it to appear in navigator, so why are we making it mandatory for shapes. Atleast in impress/draw, you have a toggle to allow you to see unnamed shapes, but that options isnt available in writer and calc. (In reply to V Stuart Foote from comment #6) Regards renaming--Adolfo is correct it should be Drawing objects as that is the name for the Toolbar in both Writer and Calc, e.g. Drawing and Drawing Object Properties. The toolbar entry to show the draw toolbar is tooltipped as 'Show Draw Functions'. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - javaunohelper/com ridljar/com xmerge/source
javaunohelper/com/sun/star/comp/helper/Bootstrap.java | 12 ++ ridljar/com/sun/star/uno/IMethodDescription.java |4 +-- ridljar/com/sun/star/uno/Type.java |4 +-- ridljar/com/sun/star/uno/Union.java |2 - xmerge/source/pexcel/java/org/openoffice/xmerge/converter/xml/sxc/pexcel/records/ExtendedFormat.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/Convert.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/DocumentDeserializer.java |6 ++--- xmerge/source/xmerge/java/org/openoffice/xmerge/converter/palm/PdbDecoder.java | 10 xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java |4 +-- xmerge/source/xmerge/java/org/openoffice/xmerge/merger/MergeAlgorithm.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/merger/NodeMergeAlgorithm.java |2 - xmerge/source/xmerge/java/org/openoffice/xmerge/merger/diff/TextNodeIterator.java |2 - 12 files changed, 28 insertions(+), 24 deletions(-) New commits: commit 01aadc965ca97f28505418c6fb95a0c4c1f0d160 Author: Damjan Jovanovic dam...@apache.org Date: Sun Aug 23 17:26:31 2015 + Fix some of the many javadoc 8 errors. diff --git a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java index eb9bf0c..66ae01f 100644 --- a/javaunohelper/com/sun/star/comp/helper/Bootstrap.java +++ b/javaunohelper/com/sun/star/comp/helper/Bootstrap.java @@ -97,6 +97,7 @@ public class Bootstrap { @param context_entries the hash table contains mappings of entry names (type string) to context entries (type class ComponentContextEntry). @return a new context. +@throws java.lang.Exception */ static public XComponentContext createInitialComponentContext( Hashtable context_entries ) throws Exception @@ -149,6 +150,7 @@ public class Bootstrap { * p * @return a freshly boostrapped service manager * @seecom.sun.star.lang.ServiceManager + * @throws java.lang.Exception */ static public XMultiServiceFactory createSimpleServiceManager() throws Exception { @@ -157,10 +159,12 @@ public class Bootstrap { } -/** Bootstraps the initial component context from a native UNO installation. - -@see cppuhelper/defaultBootstrap_InitialComponentContext() -*/ +/** + * Bootstraps the initial component context from a native UNO installation. + * p + * @return + * @see cppuhelper/defaultBootstrap_InitialComponentContext() + */ static public final XComponentContext defaultBootstrap_InitialComponentContext() throws Exception { diff --git a/ridljar/com/sun/star/uno/IMethodDescription.java b/ridljar/com/sun/star/uno/IMethodDescription.java index f712556..0c1aad5 100644 --- a/ridljar/com/sun/star/uno/IMethodDescription.java +++ b/ridljar/com/sun/star/uno/IMethodDescription.java @@ -52,7 +52,7 @@ public interface IMethodDescription extends IMemberDescription { boolean isConst(); /** - * Gives any array of codeITypeDescription of + * Gives any array of codeITypeDescription/code of * the [in] parameters. * p * @return the in parameters @@ -60,7 +60,7 @@ public interface IMethodDescription extends IMemberDescription { ITypeDescription[] getInSignature(); /** - * Gives any array of codeITypeDescription of + * Gives any array of codeITypeDescription/code of * the [out] parameters. * p * @return the out parameters diff --git a/ridljar/com/sun/star/uno/Type.java b/ridljar/com/sun/star/uno/Type.java index f3a55f4..411db96 100644 --- a/ridljar/com/sun/star/uno/Type.java +++ b/ridljar/com/sun/star/uno/Type.java @@ -33,7 +33,7 @@ import java.util.HashMap; * SHORT/code) do not have a matching Java class. For another, it can be * necessary to describe a type which is unknown to the Java runtime system * (for example, for delaying the need of a class, so that it is possible to - * generate it on the fly.)/p + * generate it on the fly.) * * pA codeType/code is uniquely determined by its type class (a * codeTypeClass/code) and its type name (a codeString/code); these two @@ -204,7 +204,7 @@ public class Type { * * pIn certain cases, one Java class corresponds to two UNO types (e.g., * the Java class codeshort[].class/code corresponds to both a sequence - * of coddeSHORT/code and a sequence of codeUNSIGNED SHORT/code in + * of codeSHORT/code and a sequence of
[Libreoffice-bugs] [Bug 93607] New: text:id in text:alphabetical-index-mark-start/ changes when saving
https://bugs.documentfoundation.org/show_bug.cgi?id=93607 Bug ID: 93607 Summary: text:id in text:alphabetical-index-mark-start/ changes when saving Product: LibreOffice Version: 5.0.0.5 release Hardware: Other OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: j...@vandenoever.info Created attachment 118105 -- https://bugs.documentfoundation.org/attachment.cgi?id=118105action=edit A file with text:alphabetical-index-mark-start/ and text:alphabetical-index-mark-end/. Loading and saving this file gives new values for the attribute text:id. Saving a document with text:alphabetical-index-mark-start/ and text:alphabetical-index-mark-end/ give a new value for the text:id attribute. This is inconvenient when comparing different version of the document. The diff is larger than it needs to be. The value of the text:id attribute should not change when the file is edited. The values of the text:id attribute can be quickly seen: xmlstarlet fo test.fodt | xmlstarlet sel -t -m '//text:alphabetical-index-mark-start/@text:id' -v . -n -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC||vstuart.fo...@utsa.edu Resolution|--- |DUPLICATE --- Comment #1 from V Stuart Foote vstuart.fo...@utsa.edu --- Not valid, works on non-system drives but you may have to clean out old residuals. Just went through this for similar bug 93550 for installation on a Windows G:\ drive. *** This bug has been marked as a duplicate of bug 93550 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - basic/source vcl/workben
basic/source/classes/image.cxx | 14 - vcl/workben/fftester.cxx | 526 - 2 files changed, 280 insertions(+), 260 deletions(-) New commits: commit de26ef857bf3b39a02192289a374605ca9491721 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 12:52:52 2015 +0100 coverity#1242865 Untrusted loop bound Change-Id: I9c6f821f7bd1e9bd3eb8f47e269e62a792523f1a diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx index ef468dc..703dbd4 100644 --- a/basic/source/classes/image.cxx +++ b/basic/source/classes/image.cxx @@ -241,6 +241,17 @@ bool SbiImage::Load( SvStream r, sal_uInt32 nVersion ) break; } case B_SBXOBJECTS: +{ +//assuming an empty string with just the lead 32bit/16bit len indicator +const size_t nMinStringSize = (eCharSet == RTL_TEXTENCODING_UNICODE) ? 4 : 2; +const size_t nMinRecordSize = nMinStringSize + sizeof(sal_Int16); +const size_t nMaxRecords = r.remainingSize() / nMinRecordSize; +if (nCount nMinRecordSize) +{ +SAL_WARN(basic, Parsing error: nMaxRecords + max possible entries, but nCount claimed, truncating); +nCount = nMaxRecords; +} // User defined types for (sal_uInt16 i = 0; i nCount; i++) @@ -319,9 +330,8 @@ bool SbiImage::Load( SvStream r, sal_uInt32 nVersion ) AddType(pType); } - break; - +} case B_MODEND: goto done; default: commit ca09871bc0c2672370d23c66148afe25006962f8 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 10:31:15 2015 +0100 coverity#1317301 Uncaught exception Change-Id: I580c1c873b440d5230a0c9e6a2a2af5d5d8c0e0e diff --git a/vcl/workben/fftester.cxx b/vcl/workben/fftester.cxx index cb41af9..b50df80 100644 --- a/vcl/workben/fftester.cxx +++ b/vcl/workben/fftester.cxx @@ -76,305 +76,315 @@ unsigned int persist_cnt; SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv) { int ret = -1; - -if (argc 3) +try { -fprintf(stderr, Usage: fftester filename wmf|jpg\n); -return -1; -} +if (argc 3) +{ +fprintf(stderr, Usage: fftester filename wmf|jpg\n); +return -1; +} -OUString in(argv[1], strlen(argv[1]), RTL_TEXTENCODING_UTF8); -OUString out; -osl::File::getFileURLFromSystemPath(in, out); +OUString in(argv[1], strlen(argv[1]), RTL_TEXTENCODING_UTF8); +OUString out; +osl::File::getFileURLFromSystemPath(in, out); -tools::extendApplicationEnvironment(); +tools::extendApplicationEnvironment(); -Reference XComponentContext xContext = defaultBootstrap_InitialComponentContext(); -Reference XMultiServiceFactory xServiceManager( xContext-getServiceManager(), UNO_QUERY ); -if( !xServiceManager.is() ) -Application::Abort( Failed to bootstrap ); -comphelper::setProcessServiceFactory( xServiceManager ); -utl::ConfigManager::EnableAvoidConfig(); -InitVCL(); +Reference XComponentContext xContext = defaultBootstrap_InitialComponentContext(); +Reference XMultiServiceFactory xServiceManager( xContext-getServiceManager(), UNO_QUERY ); +if( !xServiceManager.is() ) +Application::Abort( Failed to bootstrap ); +comphelper::setProcessServiceFactory( xServiceManager ); +utl::ConfigManager::EnableAvoidConfig(); +InitVCL(); try_again: -{ -if (strcmp(argv[2], wmf) == 0 || strcmp(argv[2], emf) == 0) -{ -GDIMetaFile aGDIMetaFile; -SvFileStream aFileStream(out, StreamMode::READ); -ret = (int) ReadWindowMetafile(aFileStream, aGDIMetaFile); -} -else if (strcmp(argv[2], jpg) == 0) -{ -Graphic aGraphic; -SvFileStream aFileStream(out, StreamMode::READ); -ret = (int) ImportJPEG(aFileStream, aGraphic, NULL, GraphicFilterImportFlags::NONE); -} -else if (strcmp(argv[2], gif) == 0) -{ -SvFileStream aFileStream(out, StreamMode::READ); -Graphic aGraphic; -ret = (int) ImportGIF(aFileStream, aGraphic); -} -else if (strcmp(argv[2], xbm) == 0) -{ -Graphic aGraphic; -SvFileStream aFileStream(out, StreamMode::READ); -ret = (int) ImportXBM(aFileStream, aGraphic); -} -else if (strcmp(argv[2], xpm) == 0) -{ -Graphic aGraphic; -SvFileStream aFileStream(out, StreamMode::READ); -ret = (int) ImportXPM(aFileStream, aGraphic); -} -else if (strcmp(argv[2], png) == 0) -{ -
[Libreoffice-bugs] [Bug 93550] Will not run following installation of 5.0.0 - reports missing dll
https://bugs.documentfoundation.org/show_bug.cgi?id=93550 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added CC||je...@smartechhomes.com --- Comment #8 from V Stuart Foote vstuart.fo...@utsa.edu --- *** Bug 93596 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93600] Condition Formatting: Entering = in comparison value crashes program
https://bugs.documentfoundation.org/show_bug.cgi?id=93600 Mike Bell mb...@albionresearch.com changed: What|Removed |Added CC||mb...@albionresearch.com Hardware|Other |x86 (IA32) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: Trouble pulling from git
Hey, Will the http link work for git push too? Regards, Shreyansh On Fri, Aug 21, 2015 at 9:54 PM Eike Rathke er...@redhat.com wrote: Hi Shreyansh, On Friday, 2015-08-21 11:35:02 -0400, Ashod Nakashian wrote: On Fri, Aug 21, 2015 at 10:44 AM, Shreyansh Gandhi gandhish...@gmail.com I have been facing trouble while running git pull. The connection always times out. url = git://gerrit.libreoffice.org/core url = git://anongit.freedesktop.org/libreoffice/core Both should work, unless your firewall or proxy blocks the git protocol or one of the servers is temporarily unavailable.. which may have been the case with gerrit yesterday during some time frame. http://anongit.freedesktop.org/git/libreoffice/core.git would also be possible if the git protocol doesn't work for some reason, the http protocol is just less effective than the git protocol. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GPG key ID 0x65632D3A - 2265 D7F3 A7B0 95CC 3918 630B 6A6C D5B7 6563 2D3A Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/ Care about Free Software, support the FSFE https://fsfe.org/support/?erack -- Regards, Shreyansh Gandhi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: Branch 'libreoffice-4-4' - sw/qa sw/source
sw/qa/core/data/ww6/pass/hang-1.doc |binary sw/source/filter/ww8/ww8par.cxx |2 +- 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 44c27bfb62ee9e820b659132ad9f8799b67064cc Author: Caolán McNamara caol...@redhat.com Date: Fri Aug 21 14:01:03 2015 +0100 avoid hang in certain ww6 docs (cherry picked from commit d0813b432f94d214a6961cb6a1eb11f65399e59b) Change-Id: Ife15f6a6e4b31c6e226a154dd708290266e86a2e Reviewed-on: https://gerrit.libreoffice.org/17927 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/core/data/ww6/pass/hang-1.doc b/sw/qa/core/data/ww6/pass/hang-1.doc new file mode 100644 index 000..825283d Binary files /dev/null and b/sw/qa/core/data/ww6/pass/hang-1.doc differ diff --git a/sw/source/filter/ww8/ww8par.cxx b/sw/source/filter/ww8/ww8par.cxx index 8f8c00b..e922037 100644 --- a/sw/source/filter/ww8/ww8par.cxx +++ b/sw/source/filter/ww8/ww8par.cxx @@ -3880,7 +3880,7 @@ void SwWW8ImplReader::ReadAttrs(WW8_CP rTxtPos, WW8_CP rNext, long nTextEnd, b { maCurrAttrCP = rTxtPos; rNext = ReadTextAttr(rTxtPos, nTextEnd, rbStartLine); -if (rTxtPos == rNext rTxtPos == WW8_CP_MAX) +if (rTxtPos == rNext rTxtPos = nTextEnd) break; } while( rTxtPos = rNext ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source
sw/qa/core/data/ww6/pass/crash-7.doc |binary sw/source/filter/basflt/fltshell.cxx | 26 ++ 2 files changed, 18 insertions(+), 8 deletions(-) New commits: commit 4ff8b3a353b1d042e9c47c4f82a3a1f74bcea6e8 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 17:13:23 2015 +0100 check for bad locations Change-Id: I635585f664e700047d92821fb965d42b803a8a15 (cherry picked from commit b164d08f0c12a3434fad1b40900ddc8cb510370c) Reviewed-on: https://gerrit.libreoffice.org/17938 Tested-by: Jenkins c...@libreoffice.org Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/core/data/ww6/pass/crash-7.doc b/sw/qa/core/data/ww6/pass/crash-7.doc new file mode 100644 index 000..5a9dab3 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/crash-7.doc differ diff --git a/sw/source/filter/basflt/fltshell.cxx b/sw/source/filter/basflt/fltshell.cxx index 2427161..eb1e45f 100644 --- a/sw/source/filter/basflt/fltshell.cxx +++ b/sw/source/filter/basflt/fltshell.cxx @@ -419,25 +419,33 @@ SwFltStackEntry* SwFltControlStack::SetAttr(const SwPosition rPos, return pRet; } -static void MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion) { // the anchor is the Pam's Point. It's modified when inserting // text, etc.; therefore it is kept on the stack. Only the // attribute's format needs to be set. rRegion.DeleteMark(); -rRegion.GetPoint()-nNode = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; + +sal_uLong nMk = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; +const SwNodes rMkNodes = rEntry.m_aMkPos.m_nNode.GetNodes(); +if (nMk = rMkNodes.Count()) +return false; + +rRegion.GetPoint()-nNode = nMk; SwContentNode* pCNd = GetContentNode(pDoc, rRegion.GetPoint()-nNode, true); rRegion.GetPoint()-nContent.Assign(pCNd, rEntry.m_aMkPos.m_nContent); +return true; } // MakeBookRegionOrPoint() behaves like MakeRegionOrPoint, except that // it adheres to certain restrictions on bookmarks in tables (cannot // span more than one cell) -static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion, bool bCheck ) { -if (rEntry.MakeRegion(pDoc, rRegion, bCheck )){ +if (rEntry.MakeRegion(pDoc, rRegion, bCheck )) +{ // sal_Bool b1 = rNds[rRegion.GetPoint()-nNode]-FindTableNode() != 0; if (rRegion.GetPoint()-nNode.GetNode().FindTableBoxStartNode() != rRegion.GetMark()-nNode.GetNode().FindTableBoxStartNode()) @@ -445,9 +453,9 @@ static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, rRegion.Exchange(); // invalid range rRegion.DeleteMark(); // - both to mark } -}else{ -MakePoint(rEntry, pDoc, rRegion); +return true; } +return MakePoint(rEntry, pDoc, rRegion); } // IterateNumrulePiece() looks for the first range valid for Numrules @@ -596,8 +604,10 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition rTmpPos, break; case RES_FLTR_ANNOTATIONMARK: { -MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true); -pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +if (MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true)) +pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +else +SAL_WARN(sw, failed to make book region or point); } break; case RES_FLTR_TOX: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93605] [Request] Rename opened file from File Rename?
https://bugs.documentfoundation.org/show_bug.cgi?id=93605 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Component|UI |ux-advise Ever confirmed|0 |1 Severity|normal |enhancement --- Comment #1 from Joel Madero jmadero@gmail.com --- I'm not a fan but this is left for UX team - setting to enhancement, NEW and requesting their input. You can just do file - save as and then later delete the original file...same result without adding yet one more thing to our menus. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 93605] [Request] Rename opened file from File Rename?
https://bugs.documentfoundation.org/show_bug.cgi?id=93605 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com, ||libreoffice-ux-advise@lists ||.freedesktop.org Component|UI |ux-advise Ever confirmed|0 |1 Severity|normal |enhancement --- Comment #1 from Joel Madero jmadero@gmail.com --- I'm not a fan but this is left for UX team - setting to enhancement, NEW and requesting their input. You can just do file - save as and then later delete the original file...same result without adding yet one more thing to our menus. -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 01/aadc965ca97f28505418c6fb95a0c4c1f0d160
01/aadc965ca97f28505418c6fb95a0c4c1f0d160 |1 + 1 file changed, 1 insertion(+) New commits: commit 6e1031cb6a8a3a04bfb65b0c806b3e1a706a1198 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 20:03:58 2015 +0100 Notes added by 'git notes add' diff --git a/01/aadc965ca97f28505418c6fb95a0c4c1f0d160 b/01/aadc965ca97f28505418c6fb95a0c4c1f0d160 new file mode 100644 index 000..363c920 --- /dev/null +++ b/01/aadc965ca97f28505418c6fb95a0c4c1f0d160 @@ -0,0 +1 @@ +prefer: 3a05aabe4190fc948ebdc94a14a15872f977ba0c ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 Joel Madero jmadero@gmail.com changed: What|Removed |Added CC||jmadero@gmail.com --- Comment #5 from Joel Madero jmadero@gmail.com --- Agreed - please don't mess with settings again. You've been given the options - those are the options, there are no other ones and messing with the status of the bug won't help you and will just waste our time. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/printaccessoryview.mm |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a401cf33b2e05d1778faef8e4fdd1043d3eb9b2e Author: Stephan Bergmann sberg...@redhat.com Date: Sun Aug 23 22:17:18 2015 +0200 loplugin:defaultparams Change-Id: I0db404b84f62db9636fa30f9af1b9cc0d70a2624 diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm index 3958bb1..7f7c826 100644 --- a/vcl/osx/printaccessoryview.mm +++ b/vcl/osx/printaccessoryview.mm @@ -298,14 +298,14 @@ class ControllerProperties if( i_nPage = 0 nPages i_nPage ) { GDIMetaFile aMtf; -PrinterController::PageSize aPageSize( mpController-getFilteredPageFile( i_nPage, aMtf, false ) ); +PrinterController::PageSize aPageSize( mpController-getFilteredPageFile( i_nPage, aMtf ) ); auto aDev(VclPtrVirtualDevice::Create()); if( mpController-getPrinter()-GetPrinterOptions().IsConvertToGreyscales() ) aDev-SetDrawMode( aDev-GetDrawMode() | ( DrawModeFlags::GrayLine | DrawModeFlags::GrayFill | DrawModeFlags::GrayText | DrawModeFlags::GrayBitmap | DrawModeFlags::GrayGradient ) ); // see salprn.cxx, currently we pretend to be a 720dpi device on printers aDev-SetReferenceDevice( 720, 720 ); -aDev-EnableOutput( TRUE ); +aDev-EnableOutput(); Size aLogicSize( aDev-PixelToLogic( aPixelSize, MapMode( MAP_100TH_MM ) ) ); double fScaleX = double(aLogicSize.Width())/double(aPageSize.aSize.Width()); double fScaleY = double(aLogicSize.Height())/double(aPageSize.aSize.Height()); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Remotely management advertising player / Attn: Technical Manager与您共享了相册。
Dear Sirs, After visiting your web-site I decided to contact your esteemed company as one of the leaders of digital signage field . CMP-web1 is a low cost digital signage solution, consist of digital signage player and content management software. The solution offer local and central scheduling via internet or TF card. Zone type displays and full screen digital posters are available also. I would appreciate if you forward this letter to Technical Manager or to other expert responsible for technical integration of new products in your company, or provide me with his contact for we could discuss all the details of our future cooperation. Your early reply is highly appreciated . Anna https://picasaweb.google.com/lh/sredir?uname=101488099794642952864target=ALBUMid=6166792858629771729authkey=Gv1sRgCIjFz8yIgsv8wwEinvite=CLW52q8Gfeat=email ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 63877] FILESAVE: Save screen freezes under Windows 8 and Windows 7
https://bugs.documentfoundation.org/show_bug.cgi?id=63877 --- Comment #10 from domi dmou...@free.fr --- some more info i'm confronted with de freeze problem since V4 en still in V5 under windows seven cpu is idle, memory is free but the libreoffice windows are freezed after a while (some minutes) i've got a windows msg that says something like appli is not responding wait for it or close it if you wait most often libreofice wake up afer 5 or 10 minutes waiting (about) if you close the libreoffice windows most of the time it will be damaged * the files are mainly microsoft type (doc.docx, xls) because of team workers * several files open (3 or more) with calc or writer when the freeze come ? i think the freeze is linked with the autosave feature ?? maybe the popup warnig about potentiel format losses wich asking to change the file type or not doesn't display and so lock the save process == il will try to uncheck the box ask before saving if format is not odf or default format sorry the wording if not exactly that, i tried a translation from my language -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93598] New: Saving causes a table frames loss.
https://bugs.documentfoundation.org/show_bug.cgi?id=93598 Bug ID: 93598 Summary: Saving causes a table frames loss. Product: LibreOffice Version: unspecified Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: filip.c...@gmail.com Created attachment 118098 -- https://bugs.documentfoundation.org/attachment.cgi?id=118098action=edit The file I'm working on that causes a bug. After selecting a table frame style and saving it to the file (*.odt) and reopening the file a table style is lost. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 V Stuart Foote vstuart.fo...@utsa.edu changed: What|Removed |Added Attachment #118099|ODT deocument with various |ODT document with various description|elements named for |elements named for |Navigator |Navigator -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 --- Comment #7 from V Stuart Foote vstuart.fo...@utsa.edu --- Created attachment 118099 -- https://bugs.documentfoundation.org/attachment.cgi?id=118099action=edit ODT deocument with various elements named for Navigator -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 --- Comment #8 from V Stuart Foote vstuart.fo...@utsa.edu --- Created attachment 118100 -- https://bugs.documentfoundation.org/attachment.cgi?id=118100action=edit ODs document with various elements named for Navigator -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/qa sw/source
sw/qa/core/data/ww6/pass/crash-7.doc |binary sw/source/filter/basflt/fltshell.cxx | 26 ++ 2 files changed, 18 insertions(+), 8 deletions(-) New commits: commit b164d08f0c12a3434fad1b40900ddc8cb510370c Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 17:13:23 2015 +0100 check for bad locations Change-Id: I635585f664e700047d92821fb965d42b803a8a15 diff --git a/sw/qa/core/data/ww6/pass/crash-7.doc b/sw/qa/core/data/ww6/pass/crash-7.doc new file mode 100644 index 000..5a9dab3 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/crash-7.doc differ diff --git a/sw/source/filter/basflt/fltshell.cxx b/sw/source/filter/basflt/fltshell.cxx index 6c722d3..6ef14e5 100644 --- a/sw/source/filter/basflt/fltshell.cxx +++ b/sw/source/filter/basflt/fltshell.cxx @@ -419,25 +419,33 @@ SwFltStackEntry* SwFltControlStack::SetAttr(const SwPosition rPos, return pRet; } -static void MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakePoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion) { // the anchor is the Pam's Point. It's modified when inserting // text, etc.; therefore it is kept on the stack. Only the // attribute's format needs to be set. rRegion.DeleteMark(); -rRegion.GetPoint()-nNode = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; + +sal_uLong nMk = rEntry.m_aMkPos.m_nNode.GetIndex() + 1; +const SwNodes rMkNodes = rEntry.m_aMkPos.m_nNode.GetNodes(); +if (nMk = rMkNodes.Count()) +return false; + +rRegion.GetPoint()-nNode = nMk; SwContentNode* pCNd = GetContentNode(pDoc, rRegion.GetPoint()-nNode, true); rRegion.GetPoint()-nContent.Assign(pCNd, rEntry.m_aMkPos.m_nContent); +return true; } // MakeBookRegionOrPoint() behaves like MakeRegionOrPoint, except that // it adheres to certain restrictions on bookmarks in tables (cannot // span more than one cell) -static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, +static bool MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, SwPaM rRegion, bool bCheck ) { -if (rEntry.MakeRegion(pDoc, rRegion, bCheck )){ +if (rEntry.MakeRegion(pDoc, rRegion, bCheck )) +{ // sal_Bool b1 = rNds[rRegion.GetPoint()-nNode]-FindTableNode() != 0; if (rRegion.GetPoint()-nNode.GetNode().FindTableBoxStartNode() != rRegion.GetMark()-nNode.GetNode().FindTableBoxStartNode()) @@ -445,9 +453,9 @@ static void MakeBookRegionOrPoint(const SwFltStackEntry rEntry, SwDoc* pDoc, rRegion.Exchange(); // invalid range rRegion.DeleteMark(); // - both to mark } -}else{ -MakePoint(rEntry, pDoc, rRegion); +return true; } +return MakePoint(rEntry, pDoc, rRegion); } // IterateNumrulePiece() looks for the first range valid for Numrules @@ -596,8 +604,10 @@ void SwFltControlStack::SetAttrInDoc(const SwPosition rTmpPos, break; case RES_FLTR_ANNOTATIONMARK: { -MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true); -pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +if (MakeBookRegionOrPoint(rEntry, pDoc, aRegion, true)) +pDoc-getIDocumentMarkAccess()-makeAnnotationMark(aRegion, OUString()); +else +SAL_WARN(sw, failed to make book region or point); } break; case RES_FLTR_TOX: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 --- Comment #3 from je...@smartechhomes.com --- I should also add - it should not be necessary to run a third-party product to clean the registry. If the registry is not cleaned up properly on an uninstall, then that is a problem with the uninstaller. The installer must honor the change of directory. Anything else is broken. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93602] New: Switching between picture and its frame takes some time
https://bugs.documentfoundation.org/show_bug.cgi?id=93602 Bug ID: 93602 Summary: Switching between picture and its frame takes some time Product: LibreOffice Version: unspecified Hardware: All OS: Windows (All) Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: wilfriedk...@gmx.de User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 Build Identifier: LibreOffice 5.0.0.5 I have a picture and a frame around it containing a picture numbering and a description. The frame is marked (green handles). On right click the popup-menu of the frame comes up. I change and mark the picture which is in the frame. On right click the popup-menu of the frame still comes up. it takes several clicks (5-10 sec) on the picture until the correct pupup menu appears. Reproducible: Always Steps to Reproduce: Just put a picture with numbering on the document and try. Error appears in big and small documents. My computer is very fast so speed can't be a problem. Actual Results: see above Expected Results: switch to the correct pupup menu after the first click [Information automatically included from LibreOffice] Locale: de Module: TextDocument [Information guessed from browser] OS: Windows (All) OS is 64bit: yes Reset User Profile?No -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sw/qa sw/source
sw/qa/core/data/ww6/pass/crash-6.doc |binary sw/source/filter/basflt/fltshell.cxx | 13 ++--- 2 files changed, 10 insertions(+), 3 deletions(-) New commits: commit 4d1b6057627c1fbee8cceefe77f9fb1c0af836d5 Author: Caolán McNamara caol...@redhat.com Date: Sat Aug 22 10:31:35 2015 +0100 check that src index is in doc range Change-Id: Ic81e7a14701ff30aa46a9293dd6db351bd350ba5 (cherry picked from commit 3230c8cf1cf2dc486f038d369e7f4f44ffd6b0a7) check that dest index is in doc range Change-Id: I3006cf03cf97399a6c418162178acdb1d41c3b23 (cherry picked from commit cd6c9aef7468120dd5ea5c747f35c98baf214613) Reviewed-on: https://gerrit.libreoffice.org/17925 Reviewed-by: David Tardon dtar...@redhat.com Tested-by: David Tardon dtar...@redhat.com diff --git a/sw/qa/core/data/ww6/pass/crash-6.doc b/sw/qa/core/data/ww6/pass/crash-6.doc new file mode 100644 index 000..08c8791 Binary files /dev/null and b/sw/qa/core/data/ww6/pass/crash-6.doc differ diff --git a/sw/source/filter/basflt/fltshell.cxx b/sw/source/filter/basflt/fltshell.cxx index be5d9eb..2427161 100644 --- a/sw/source/filter/basflt/fltshell.cxx +++ b/sw/source/filter/basflt/fltshell.cxx @@ -120,8 +120,11 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM rRegion, bool bCheck, // The only position of 0x0D will not be able to make region in the old logic // because it is beyond the length of para...need special consideration here. -SwContentNode *const pContentNode( -SwNodeIndex(rMkPos.m_nNode, +1).GetNode().GetContentNode()); +sal_uLong nMk = rMkPos.m_nNode.GetIndex() + 1; +const SwNodes rMkNodes = rMkPos.m_nNode.GetNodes(); +if (nMk = rMkNodes.Count()) +return false; +SwContentNode *const pContentNode(rMkNodes[nMk]-GetContentNode()); if (rMkPos == rPtPos ((0 != rPtPos.m_nContent) || (pContentNode (0 != pContentNode-Len( ( RES_TXTATR_FIELD != nWhich @@ -138,7 +141,11 @@ bool SwFltStackEntry::MakeRegion(SwDoc* pDoc, SwPaM rRegion, bool bCheck, rRegion.SetMark(); if (rMkPos.m_nNode != rPtPos.m_nNode) { -rRegion.GetPoint()-nNode = rPtPos.m_nNode.GetIndex() + 1; +sal_uLong n = rPtPos.m_nNode.GetIndex() + 1; +SwNodes rNodes = rRegion.GetPoint()-nNode.GetNodes(); +if (n = rNodes.Count()) +return false; +rRegion.GetPoint()-nNode = n; pCNd = GetContentNode(pDoc, rRegion.GetPoint()-nNode, false); } rRegion.GetPoint()-nContent.Assign(pCNd, rPtPos.m_nContent); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93605] New: [Request] Rename opened file from File Rename?
https://bugs.documentfoundation.org/show_bug.cgi?id=93605 Bug ID: 93605 Summary: [Request] Rename opened file from File Rename? Product: LibreOffice Version: unspecified Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: orsch...@gmail.com Dear all, I would like to ask you for your opinion on a feature to rename the opened file directly from the File menu. At least on Linux, the dialog window of GTK does not allow the direct renaming of files. What is then necessary is to open a file manager and navigate to the file to rename it. Having a renaming option directly implemented in LO would speed up the process of renaming files. What do you think? Thankfully, Robert -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93606] New: The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 Bug ID: 93606 Summary: The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom Product: LibreOffice Version: 5.0.0.5 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Installation Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: floortes...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93600] Condition Formatting: Entering = in comparison value crashes program
https://bugs.documentfoundation.org/show_bug.cgi?id=93600 Joel Madero jmadero@gmail.com changed: What|Removed |Added Priority|medium |highest Status|UNCONFIRMED |NEW Keywords||regression, want-backtrace Hardware|x86 (IA32) |All CC||jmadero@gmail.com Ever confirmed|0 |1 Whiteboard||bibisectRequest Severity|normal |major OS|Windows (All) |All --- Comment #1 from Joel Madero jmadero@gmail.com --- Confirmed Ubuntu 15.04 x64 LibreOffice 5.0.0.5 LibreOffice 4.4 (works fine) Marking as: NEW: MAJOR: Crash Highest (regression) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67544] FILESAVE: Slide transistion sound(other sound) is not included in presentation file
https://bugs.documentfoundation.org/show_bug.cgi?id=67544 Vishv vishvbrahmbhat...@gmail.com changed: What|Removed |Added Assignee|vishvbrahmbhat...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93583] EDITING formatted text on embedded SVG file displayed incorrectly
https://bugs.documentfoundation.org/show_bug.cgi?id=93583 Joel Madero jmadero@gmail.com changed: What|Removed |Added Priority|medium |low Status|UNCONFIRMED |NEW Component|Draw|LibreOffice Hardware|x86-64 (AMD64) |All Version|5.0.0.5 release |4.4.5.2 release Ever confirmed|0 |1 --- Comment #5 from Joel Madero jmadero@gmail.com --- @Sawik - Thanks! Confirmed Ubuntu 15.04 x64 LibreOffice 4.4.5.2 5.0.0.5 Setting Component to LibreOffice because it's any component that you insert it into. Updating version - version is oldest version that demonstrates the issue. Setting as: New - Normal - can prevent high quality work; Low - This isn't going to impact a ton of users, it's specific to particular types of svg files. Already inserting images are not going to be incredibly common, inserting svg's less common, inserting svg's that have the characteristics of this file, less common. Please know that these settings don't prevent developers from taking interest, it's just an objective criteria that we use to indicate how many users are affected and how serious the bug is (loss of data, etc..). One useful thing would be to determine if this is a regression by going through older versions of LibreOffice: http://downloadarchive.documentfoundation.org/libreoffice/old/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93600] New: Condition Formatting: Entering = in comparison value crashes program
https://bugs.documentfoundation.org/show_bug.cgi?id=93600 Bug ID: 93600 Summary: Condition Formatting: Entering = in comparison value crashes program Product: LibreOffice Version: 5.0.0.5 release Hardware: Other OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: mb...@albionresearch.com Steps to reproduce: 1. Select a cell with a formula or value in. 2. Select menu Format / Conditional Formatting / Condition... 3. Under Condition 1, Cell value is, equal to type = into the empty text field. 4. Program crashes immediately and initiates document recovery. (Was expecting to be able to enter an expression at this point) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93599] New: Personalization and themes
https://bugs.documentfoundation.org/show_bug.cgi?id=93599 Bug ID: 93599 Summary: Personalization and themes Product: LibreOffice Version: 5.0.0.5 release Hardware: Other OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: UI Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: heiko.tie...@user-prompt.com Created attachment 118101 -- https://bugs.documentfoundation.org/attachment.cgi?id=118101action=edit Dialog after search for plain themes, selection of the middle theme from the bottom, and finalizing per okay. By default LO comes with some gradient, which does not fit my design in Breeze Dark (resp. Breeze-gtk). Options Personalization is set to Default look, do not use Themes but the right side is bright and left dark. (That's the first bug, IMHO.) So I tried to change it and wanted to select another theme. This dialog shows nothing unless I search. I'd assess this as another bug but maybe its by design. But when I searach for 'plain' and select one of the resulting themes and want to apply it per okay the dialog shows the complete URL without any ellipsis. Luckily my resolution is high enough. How to solve: 1. Ensure the default is the default. 2. Make the 'pre-installed' option a way to select something from the local drive (or get rid of this). 3a. Prefil the themes dialog and make the search a filter. 3b. Speed up the processing/communication or whatever; the dialog must be filled with items - otherwise show an indicator for proecssing 3c. Error messages shouldn't be part of the UI; use ellipsis or line breaks in case of long text Personally, I wouldn't implement Mozilla Persona like features at all. Office suits are not intended to be entertaining. But obviously there was a request for this feature, or not? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 je...@smartechhomes.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- Ever confirmed|0 |1 --- Comment #2 from je...@smartechhomes.com --- This is not a duplicate of bug 93550. This is a valid bug, and one which only occurs on LibreOffice. Did you actually attempt to follow the instructions I laid out and install the latest version on another drive? Or did you just close it as a duplicate because it sounds similar? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Shreyansh Gandhi License Statement
Hi, All of my past future contributions to Libreoffice may be licensed under the MLPv2/LGPLv3 license. Regards,Shreyansh Gandhi___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93603] No separator line when toolbars are vertical
https://bugs.documentfoundation.org/show_bug.cgi?id=93603 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEW CC|libreoffice-ux-advise@lists | |.freedesktop.org| Component|ux-advise |UI See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=79 ||452 Ever confirmed|0 |1 --- Comment #1 from Yousuf (Jay) Philips philip...@hotmail.com --- Setting to NEW as enhancement. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93147] Check for Updates feature fails immediately in Win 10
https://bugs.documentfoundation.org/show_bug.cgi?id=93147 --- Comment #6 from V Stuart Foote vstuart.fo...@utsa.edu --- And, since Cloph has included it in the update script ref URL, I checked behavior on Windows 10 Pro 64-bit with 5.0.0.2 Version: 5.0.0.2 (x64) Build ID: a26d58f11b99b6aeddf7f7884effea188cc6e512 Locale: en-US (en_US) It correctly checks and opens link to Fresh version download page for the 5.0.0 (5.0.0.5) release. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93606] The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 Peter Raynor floortes...@gmail.com changed: What|Removed |Added CC||floortes...@gmail.com --- Comment #1 from Peter Raynor floortes...@gmail.com --- I have tried it twice, and it would not use D:\Libre Office 5 as an installation folder, at some stage either at removal or installation it removed my 4.04 version from another directory -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93606] The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 --- Comment #4 from Joel Madero jmadero@gmail.com --- @VSF - looks like we're both confused as to what is trying to be accomplished - tossed this to NEEDINFO. @Peter - if you're trying to parallel install you can do so in a couple ways: https://wiki.documentfoundation.org/Installing_in_parallel/Windows In other words, if you want both 4.4 and 5.0, this is not a bug, it's just how the software is designed and you'll have to read that wiki to learn how to install both in different directories. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93606] The file LibreOffice_5.0.0_Win_x86.msi will only install in C:\Program Files(x86) not on the path given when selecting Custom
https://bugs.documentfoundation.org/show_bug.cgi?id=93606 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #3 from Joel Madero jmadero@gmail.com --- I don't fully understand the issue. You're trying to parallel install? You want to have 4.4 on C:/ and 5.0 on D:/ Please describe your situation a little better and then mark the bug as UNCONFIRMED. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93602] Switching between picture and its frame takes some time
https://bugs.documentfoundation.org/show_bug.cgi?id=93602 Joel Madero jmadero@gmail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jmadero@gmail.com Ever confirmed|0 |1 --- Comment #1 from Joel Madero jmadero@gmail.com --- Please attach a sample document and then set the bug to UNCONFIRMED. Thanks -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93597] FILEOPEN:Roundtrip pie chart causes chart to disappear (loses color theme in Excel)
https://bugs.documentfoundation.org/show_bug.cgi?id=93597 Joel Madero jmadero@gmail.com changed: What|Removed |Added Priority|medium |high Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Hardware|Other |All Version|unspecified |4.4.5.2 release Ever confirmed|0 |1 Severity|normal |critical --- Comment #2 from Joel Madero jmadero@gmail.com --- In the future please include: Your operating system; Version of LibreOffice. Confirmed: Ubuntu 15.04 x64 LibreOffice 5.0.0.5 LibreOffice 4.4.5.2 (it's even worse) Setting as: NEW; Critical: Loss of data doing a relatively common task (pie chart in xlsx) - it's not technically a loss because the data is there but for an avg. user, as far as they are concerned the data is gone; High: Default seems fine here Would be nice to know if this is a regression - if it is then: 1) We should bump it to highest; 2) We should request a bibisect (bibisectRequest in whiteboard); 3) regression in keyboard; http://downloadarchive.documentfoundation.org/libreoffice/old/ -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 2 commits - vcl/source vcl/unx
vcl/source/gdi/salgdilayout.cxx |4 ++- vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 29 +++--- 2 files changed, 25 insertions(+), 8 deletions(-) New commits: commit e2582341af9f6b756e5d95c8ddd99652b62d1a41 Author: Khaled Hosny khaledho...@eglug.org Date: Mon Aug 17 04:00:49 2015 +0200 Fix GTK3 right-to-left rendering of spin buttons The button were not drawn at all Change-Id: I51dfa30a6daa1034b5e978b09bcdfcc83e859f3d Reviewed-on: https://gerrit.libreoffice.org/17790 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx index 8ee0d0a..7344423 100644 --- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx +++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx @@ -139,25 +139,40 @@ Rectangle GtkSalGraphics::NWGetSpinButtonRect( ControlPart nPart, Rectangle aAre buttonRect.SetSize(Size(buttonWidth, buttonHeight)); buttonRect.setY(aAreaRect.Top()); buttonRect.Bottom() = buttonRect.Top() + aAreaRect.GetHeight(); +Rectangle partRect(buttonRect); if ( nPart == PART_BUTTON_UP ) { -buttonRect.setX(aAreaRect.Left() + (aAreaRect.GetWidth() - buttonRect.GetWidth())); +if (AllSettings::GetLayoutRTL()) +partRect.setX(aAreaRect.Left()); +else +partRect.setX(aAreaRect.Left() + (aAreaRect.GetWidth() - buttonRect.GetWidth())); } else if( nPart == PART_BUTTON_DOWN ) { -buttonRect.setX(aAreaRect.Left() + (aAreaRect.GetWidth() - 2*buttonRect.GetWidth())); +if (AllSettings::GetLayoutRTL()) +partRect.setX(aAreaRect.Left() + buttonRect.GetWidth()); +else +partRect.setX(aAreaRect.Left() + (aAreaRect.GetWidth() - 2 * buttonRect.GetWidth())); } else { -buttonRect.Right() = (aAreaRect.Left() + (aAreaRect.GetWidth() - 2*buttonRect.GetWidth()))-1; -buttonRect.Left() = aAreaRect.Left(); -buttonRect.Top()= aAreaRect.Top(); -buttonRect.Bottom() = aAreaRect.Bottom(); +if (AllSettings::GetLayoutRTL()) +{ +partRect.Right() = aAreaRect.Left() + aAreaRect.GetWidth(); +partRect.Left() = aAreaRect.Left() + (2 * buttonRect.GetWidth()) - 1; +} +else +{ +partRect.Right() = (aAreaRect.Left() + (aAreaRect.GetWidth() - 2 * buttonRect.GetWidth())) - 1; +partRect.Left() = aAreaRect.Left(); +} +partRect.Top()= aAreaRect.Top(); +partRect.Bottom() = aAreaRect.Bottom(); } gtk_style_context_restore(mpSpinStyle); -return buttonRect; +return partRect; } Rectangle GtkSalGraphics::NWGetScrollButtonRect( ControlPart nPart, Rectangle aAreaRect ) commit fff3c9d6e56ae380437333f9c15ff63742904f25 Author: Caolán McNamara caol...@redhat.com Date: Sun Aug 23 20:46:53 2015 +0100 don't mirror 0, RECT_EMPTY, 0, RECT_EMPTY rectangle leave it untouched to make gtk3 rtl spin buttons possible where the additional mirrorValue contains the region of the spinbuttons to render within this rectangle Change-Id: I2648d98ed36373c95947cc4d78e2e54797f01155 Reviewed-on: https://gerrit.libreoffice.org/17940 Reviewed-by: Caolán McNamara caol...@redhat.com Tested-by: Caolán McNamara caol...@redhat.com diff --git a/vcl/source/gdi/salgdilayout.cxx b/vcl/source/gdi/salgdilayout.cxx index 2771c9d6..df124a9 100644 --- a/vcl/source/gdi/salgdilayout.cxx +++ b/vcl/source/gdi/salgdilayout.cxx @@ -703,7 +703,9 @@ bool SalGraphics::DrawNativeControl( ControlType nType, ControlPart nPart, const if( (m_nLayout SalLayoutFlags::BiDiRtl) || (pOutDev pOutDev-IsRTLEnabled()) ) { Rectangle rgn( rControlRegion ); -mirror( rgn, pOutDev ); +Rectangle aNull; +if (rgn != aNull) +mirror(rgn, pOutDev); std::unique_ptr ImplControlValue mirrorValue( aValue.clone()); mirror( *mirrorValue, pOutDev ); bool bRet = drawNativeControl( nType, nPart, rgn, nState, *mirrorValue, aCaption ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 93596] Installer does not allow installation to a different disk
https://bugs.documentfoundation.org/show_bug.cgi?id=93596 je...@smartechhomes.com changed: What|Removed |Added Status|RESOLVED|CLOSED Resolution|INVALID |WONTFIX --- Comment #6 from je...@smartechhomes.com --- It's not my first rodeo either. dude. In fact, I suspect I've been programming longer than most people here have been alive (well over 45 years). And I've written any number of installation scripts during that time, for multiple OS's. And I've run into guys like you before. Your answer is pure bull manure. Guys like you give the product a bad reputation. Needless to say, I'm telling my client not to use LibreOffice. They need one with support from people who understand and are willing to fix problems. And no, I'm changing this to Won't Fix. Because that's the answer you are giving. If I could change it to Bull Manure I would. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Bug 67544] FILESAVE: Slide transistion sound(other sound) is not included in presentation file
https://bugs.documentfoundation.org/show_bug.cgi?id=67544 Vishv vishvbrahmbhat...@gmail.com changed: What|Removed |Added Assignee|vishvbrahmbhat...@gmail.com |libreoffice-b...@lists.free ||desktop.org -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93145] Icon themes are not self-contained in 5.0 any more (was: the icon on Sidebar and Bottom right corner cannot display on Ubuntu 14.04)
https://bugs.documentfoundation.org/show_bug.cgi?id=93145 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Component|Writer |LibreOffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93576] Crash with dialog Insert Special character
https://bugs.documentfoundation.org/show_bug.cgi?id=93576 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Resolution|WORKSFORME |DUPLICATE --- Comment #4 from Cor Nouws c...@nouenoff.nl --- *** This bug has been marked as a duplicate of bug 93113 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93141] AutoCorrect leaves behind colon in Calc and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=93141 tommy27 ba...@quipo.it changed: What|Removed |Added Component|LibreOffice |Linguistic -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93141] AutoCorrect leaves behind colon in Calc and Impress
https://bugs.documentfoundation.org/show_bug.cgi?id=93141 tommy27 ba...@quipo.it changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #2 from tommy27 ba...@quipo.it --- status NEEDINFO until receiving feedback from user. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Uncompress LiberOffice EXE installer files
Hi guys, Sorry for the last mail, just saw, that I got auto corrected badly :P Managed to do a silent install, but the msi files starts after the installation. How to prevent this? Cloph? Sorry for duplicate mail Am 23. August 2015 13:09:29 MESZ, schrieb Florian Reisinger flo...@libreoffice.org: Hi, Manager to do a siolent installiert, but the MSI starts. How to prevent this? Cloph? Am 22. August 2015 20:25:07 MESZ, schrieb Florian Reisinger flo...@libreoffice.org: Hi, As I want to automate it and 7z can open this file I tried with JDK and apache commons.compress to unzip it, but it won't work... Can you help me to do it? libo33.exe /unzip C:\testfolder. Thanls -- Liebe Grüße, / Yours, Florian Reisinger ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 89381] ValueSet has rendering issues in RTL interface
https://bugs.documentfoundation.org/show_bug.cgi?id=89381 Yousuf (Jay) Philips philip...@hotmail.com changed: What|Removed |Added Keywords||bisected CC||chris.sherloc...@gmail.com Whiteboard||bibisected --- Comment #20 from Yousuf (Jay) Philips philip...@hotmail.com --- CCing Chris to see if he can give his input on this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32848] LibreOffice for OS X should be available in the Mac App Store
https://bugs.documentfoundation.org/show_bug.cgi?id=32848 steve -_- st...@openmailbox.org changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93353] Master document does not show diagrams included and properly shown in documents linked into the master
https://bugs.documentfoundation.org/show_bug.cgi?id=93353 Björn Michaelsen bjoern.michael...@canonical.com changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |bjoern.michaelsen@canonical |desktop.org |.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93534] Bug when trying to change the color palette
https://bugs.documentfoundation.org/show_bug.cgi?id=93534 MM plokk...@fastmail.fm changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from MM plokk...@fastmail.fm --- Confirmed with v5.0.1.1 under mint 17.2 x64. Standard colors are always shown after step 6. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
Re: [Libreoffice-qa] Uncompress LiberOffice EXE installer files
Hi, Manager to do a siolent installiert, but the MSI starts. How to prevent this? Cloph? Am 22. August 2015 20:25:07 MESZ, schrieb Florian Reisinger flo...@libreoffice.org: Hi, As I want to automate it and 7z can open this file I tried with JDK and apache commons.compress to unzip it, but it won't work... Can you help me to do it? libo33.exe /unzip C:\testfolder. Thanls -- Liebe Grüße, / Yours, Florian Reisinger ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ -- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 --- Comment #6 from V Stuart Foote vstuart.fo...@utsa.edu --- Regards renaming--Adolfo is correct it should be Drawing objects as that is the name for the Toolbar in both Writer and Calc, e.g. Drawing and Drawing Object Properties. The shapes prepared with the toolbar really have little to do with the Draw module--they are not Draw objects, those come in as OLE. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 32848] LibreOffice for OS X should be available in the Mac App Store
https://bugs.documentfoundation.org/show_bug.cgi?id=32848 Cor Nouws c...@nouenoff.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #15 from Cor Nouws c...@nouenoff.nl --- in the mean time it is available there https://itunes.apple.com/us/app/libreoffice-vanilla/id921923693?mt=12 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80843] Exported chart PNG contains rendering artifacts
https://bugs.documentfoundation.org/show_bug.cgi?id=80843 tommy27 ba...@quipo.it changed: What|Removed |Added Summary|Other: Exported chart PNG |Exported chart PNG contains |contains rendering |rendering artifacts |artifacts | -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80843] Other: Exported chart PNG contains rendering artifacts
https://bugs.documentfoundation.org/show_bug.cgi?id=80843 tommy27 ba...@quipo.it changed: What|Removed |Added CC||ba...@quipo.it --- Comment #3 from tommy27 ba...@quipo.it --- not reproducible under Win8.1 x64 using LibO 4.2.2.1 and recent 5.1.0.0 alpha probably a Linux specific issue. would you please guys retest? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
ahelp/ahelp - Extended tips in Helpcontent VCL + Glade
Hi all Just playing with a new linux master build today and I found that the property name=tooltip_markup translatable=yes bla bla bla/property of a widget in a UI dialog, edited by Glade, indeed acts like an extended tip (ahelp/ahelp) for help content for the widget, provided the extented tips in Tools - Options - General - Extended tips is unmarked. In other words, it is possible to have extended tips moved into these dialogs. The benefits I see are * Have the text of the e.t. in the UI and facilitate translation job (context) * fix the e.t. of the wikihelp. The issues I see are * a quite large work of moving e.t. from helpcontent to UI. * An impact in the translations of the UI (not sure it can be automated). * when unmarking Extended tips in the Options, we loose e.t. of toolbars and other non-Glade UI objects. * by filling the tooltip_markup property, e.t. are always enabled in a dialog. The last two may require an Option of e.t for toolbars and another Option or dialogs. bin/lint-ui.py can be adapted to check if the widget have a e.t. Regards -- Olivier Hallot Comunidade LibreOffice http://ask.libreoffice.org/pt-br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 --- Comment #5 from V Stuart Foote vstuart.fo...@utsa.edu --- (In reply to Yousuf (Jay) Philips from comment #3) Cor, Stuart: Any idea how to populate drawing objects in navigator. When a Shape is added to the Writer document, you have to also give it a name. Once named it will show in Navigator for Writer in the Draw objects section. Also, a Draw session can be OLE embedded (from File or newly created), it will show in the OLE objects section of Navigator named a generic Object# but can be renamed as well. And of course any image/graphic inserted from file will show in the Images section, also with generic Image# that can be renamed. So, OLE and Image will show with generic names for the class, but Shapes entered with the Drawing toolbar have to be specifically named to show in the Draw Object/Drawing Objects -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86142] font gallery
https://bugs.documentfoundation.org/show_bug.cgi?id=86142 Maxim Monastirsky momonas...@gmail.com changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Maxim Monastirsky momonas...@gmail.com --- Please translate to English. Once done, set the status to UNCONFIRMED. (You should never set your own bugs to NEW.) Thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 93562] Rename 'Drawing objects' or 'Draw objects' in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=93562 --- Comment #9 from Cor Nouws c...@nouenoff.nl --- (In reply to V Stuart Foote from comment #5) When a Shape is added to the Writer document, you have to also give it a name. Once named it will show in Navigator for Writer in the Draw objects section. Ah, the same as in Impress/Draw.. should have thought of that ;) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs