[Libreoffice-commits] core.git: vcl/source
vcl/source/filter/sgvspln.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit d31844da975b75e0a45121f990dee9d7cde30b30
Author: Takeshi Abe
Date: Mon Oct 26 15:45:47 2015 +0900
It's a constant
Change-Id: I2315b580f8c786cc41d3cd43cdec485717785d5c
diff --git a/vcl/source/filter/sgvspln.cxx b/vcl/source/filter/sgvspln.cxx
index 58a7a3e..cb10ef1 100644
--- a/vcl/source/filter/sgvspln.cxx
+++ b/vcl/source/filter/sgvspln.cxx
@@ -694,7 +694,7 @@ bool Spline2Poly(tools::Polygon& rSpln, bool Periodic,
tools::Polygon& rPoly)
sal_uInt16 n; // number of partial polynoms to draw
sal_uInt16 i; // actual partial polynom
boolbOk; // all still ok?
-sal_uInt16 PolyMax=16380; // max number of polygon points
+const sal_uInt16 PolyMax=16380; // max number of polygon points
bOk=CalcSpline(rSpln,Periodic,n,ax,ay,bx,by,cx,cy,dx,dy,tv);
if (bOk) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: remotebridges/examples remotebridges/source reportdesign/inc reportdesign/source
remotebridges/examples/officeclient.cxx |2 remotebridges/source/unourl_resolver/unourl_resolver.cxx| 12 reportdesign/inc/PropertyForward.hxx| 26 reportdesign/inc/ReportDefinition.hxx | 335 +--- reportdesign/inc/ReportHelperDefines.hxx| 308 +-- reportdesign/inc/ReportVisitor.hxx | 28 - reportdesign/inc/RptDef.hxx | 10 reportdesign/inc/RptModel.hxx | 10 reportdesign/inc/RptObject.hxx | 65 +- reportdesign/inc/RptPage.hxx| 14 reportdesign/inc/UndoActions.hxx| 88 +-- reportdesign/inc/UndoEnv.hxx| 36 - reportdesign/source/core/api/Functions.cxx |2 reportdesign/source/core/api/Group.cxx |4 reportdesign/source/core/api/Groups.cxx |2 reportdesign/source/core/api/ReportControlModel.cxx |2 reportdesign/source/core/api/ReportDefinition.cxx | 12 reportdesign/source/core/api/Section.cxx|6 reportdesign/source/core/api/Shape.cxx |4 reportdesign/source/core/api/Tools.cxx |2 reportdesign/source/core/inc/FixedLine.hxx | 114 ++-- reportdesign/source/core/inc/FixedText.hxx | 90 +-- reportdesign/source/core/inc/FormatCondition.hxx| 58 +- reportdesign/source/core/inc/FormattedField.hxx | 96 +-- reportdesign/source/core/inc/Function.hxx | 82 +- reportdesign/source/core/inc/Functions.hxx | 46 - reportdesign/source/core/inc/Group.hxx | 114 ++-- reportdesign/source/core/inc/Groups.hxx | 48 - reportdesign/source/core/inc/ImageControl.hxx | 98 +-- reportdesign/source/core/inc/ReportComponent.hxx| 31 - reportdesign/source/core/inc/ReportControlModel.hxx | 58 +- reportdesign/source/core/inc/ReportDrawPage.hxx |8 reportdesign/source/core/inc/ReportEngineJFree.hxx | 86 +-- reportdesign/source/core/inc/ReportHelperImpl.hxx | 182 +++--- reportdesign/source/core/inc/RptObjectListener.hxx |6 reportdesign/source/core/inc/Section.hxx| 184 +++--- reportdesign/source/core/inc/Shape.hxx | 119 ++-- reportdesign/source/core/inc/Tools.hxx | 46 - reportdesign/source/core/inc/conditionupdater.hxx |4 reportdesign/source/core/inc/core_resource.hxx |4 reportdesign/source/core/sdr/PropertyForward.cxx|2 reportdesign/source/core/sdr/RptObject.cxx |2 reportdesign/source/core/sdr/RptObjectListener.cxx |4 reportdesign/source/core/sdr/formatnormalizer.cxx |4 reportdesign/source/core/sdr/formatnormalizer.hxx | 12 reportdesign/source/filter/xml/dbloader2.cxx|2 reportdesign/source/filter/xml/dbloader2.hxx| 18 reportdesign/source/filter/xml/xmlCell.hxx | 12 reportdesign/source/filter/xml/xmlColumn.hxx|4 reportdesign/source/filter/xml/xmlComponent.hxx |6 reportdesign/source/filter/xml/xmlCondPrtExpr.hxx |6 reportdesign/source/filter/xml/xmlControlProperty.cxx | 28 - reportdesign/source/filter/xml/xmlControlProperty.hxx | 20 reportdesign/source/filter/xml/xmlExport.hxx| 68 +- reportdesign/source/filter/xml/xmlExportDocumentHandler.hxx | 62 +- reportdesign/source/filter/xml/xmlFixedContent.hxx |2 reportdesign/source/filter/xml/xmlFormatCondition.hxx |6 reportdesign/source/filter/xml/xmlFormattedField.hxx|4 reportdesign/source/filter/xml/xmlFunction.hxx | 10 reportdesign/source/filter/xml/xmlGroup.hxx |8 reportdesign/source/filter/xml/xmlHelper.cxx|4 reportdesign/source/filter/xml/xmlHelper.hxx|4 reportdesign/source/filter/xml/xmlImage.hxx |4 reportdesign/source/filter/xml/xmlImportDocumentHandler.hxx | 68 +- reportdesign/source/filter/xml/xmlMasterFields.hxx |4 reportdesign/source/filter/xml/xmlReport.hxx|8 reportdesign/source/filter/xml/xmlReportElement.hxx |8 reportdesign/source/filter/xml/xmlReportElementBase.hxx |8 reportdesign/source/filter/xml/xmlSection.hxx |8 reportdesign/source/filter/xml/xmlStyleImport.hxx | 30 - reportdesign/source/filter/xml/xmlSubDocument.hxx |6 reportdesign/so
[Libreoffice-commits] core.git: 2 commits - basegfx/test sal/rtl
basegfx/test/boxclipper.cxx |3 +--
sal/rtl/math.cxx|8
2 files changed, 5 insertions(+), 6 deletions(-)
New commits:
commit cc906ec47eaaad247e8fbed5c9e6f3604a8b64c7
Author: Tor Lillqvist
Date: Mon Oct 26 08:13:43 2015 +0200
The Android NDK for some reason don't have these math functions in std::
Not even if one includes instead of . So just use the
C functions then.
Change-Id: Ic8499bc7bcd5c84b6e52e1d5dc799f9f058db816
diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 05a1033..e0154f7 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -972,12 +972,12 @@ double SAL_CALL rtl_math_approxValue( double fValue )
SAL_THROW_EXTERN_C()
double SAL_CALL rtl_math_expm1( double fValue ) SAL_THROW_EXTERN_C()
{
-return ::std::expm1(fValue);
+return expm1(fValue);
}
double SAL_CALL rtl_math_log1p( double fValue ) SAL_THROW_EXTERN_C()
{
-return ::std::log1p(fValue);
+return log1p(fValue);
}
double SAL_CALL rtl_math_atanh( double fValue ) SAL_THROW_EXTERN_C()
@@ -988,13 +988,13 @@ double SAL_CALL rtl_math_atanh( double fValue )
SAL_THROW_EXTERN_C()
/** Parent error function (erf) */
double SAL_CALL rtl_math_erf( double x ) SAL_THROW_EXTERN_C()
{
-return ::std::erf(x);
+return erf(x);
}
/** Parent complementary error function (erfc) */
double SAL_CALL rtl_math_erfc( double x ) SAL_THROW_EXTERN_C()
{
-return ::std::erfc(x);
+return erfc(x);
}
/** improved accuracy of asinh for |x| large and for x near zero
commit cf35dbd17abefd50cca2e9219e72787ccd2889f0
Author: Tor Lillqvist
Date: Mon Oct 26 07:55:52 2015 +0200
WaE: loplugin:defaultparams
Change-Id: Ibb93059d4adab6b672cb9122b2dc8fe8af5bbbd6
diff --git a/basegfx/test/boxclipper.cxx b/basegfx/test/boxclipper.cxx
index 92edbdb..7e0bfa5 100644
--- a/basegfx/test/boxclipper.cxx
+++ b/basegfx/test/boxclipper.cxx
@@ -167,8 +167,7 @@ public:
std::for_each(randomPoly.begin(),
randomPoly.end(),
[this](const B2DPolygon& aPolygon) mutable {
-
this->aRandomIntersections.appendElement(aPolygon.getB2DRange(),
- B2VectorOrientation::Negative, 1); } );
+
this->aRandomIntersections.appendElement(aPolygon.getB2DRange(),
B2VectorOrientation::Negative); } );
#endif
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sw/qa
sw/qa/extras/ww8export/ww8export.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 5bc759b3ad86ce3c413707b740028cf88364b4da
Author: Jan Holesovsky
Date: Fri Oct 23 09:33:55 2015 +0200
tdf#94386: Small stylistic change based on gerrit#19371 comments.
Change-Id: If0e97269043addb7a1659e34c0b286d7ac32428a
diff --git a/sw/qa/extras/ww8export/ww8export.cxx
b/sw/qa/extras/ww8export/ww8export.cxx
index c3091eb..53a1513 100644
--- a/sw/qa/extras/ww8export/ww8export.cxx
+++ b/sw/qa/extras/ww8export/ww8export.cxx
@@ -609,7 +609,7 @@ DECLARE_WW8EXPORT_TEST(testTdf94386, "tdf94386.odt")
OUString firstPageStyleName = getProperty(xCursor,
"PageStyleName");
xCursor->jumpToLastPage();
OUString lastPageStyleName = getProperty(xCursor,
"PageStyleName");
-CPPUNIT_ASSERT_EQUAL(false, firstPageStyleName.equals(lastPageStyleName));
+CPPUNIT_ASSERT(firstPageStyleName != lastPageStyleName);
uno::Reference
xFirstPropertySet(getStyles("PageStyles")->getByName(firstPageStyleName),
uno::UNO_QUERY);
awt::Size fSize;
@@ -618,8 +618,8 @@ DECLARE_WW8EXPORT_TEST(testTdf94386, "tdf94386.odt")
uno::Reference
xNextPropertySet(getStyles("PageStyles")->getByName(lastPageStyleName),
uno::UNO_QUERY);
awt::Size lSize;
xNextPropertySet->getPropertyValue("Size") >>= lSize;
-bool isEqual = (fSize.Width == lSize.Width) || (fSize.Height ==
lSize.Height);
-CPPUNIT_ASSERT_EQUAL(false, isEqual);
+
+CPPUNIT_ASSERT((fSize.Width != lSize.Width) && (fSize.Height !=
lSize.Height));
}
CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - sc/source
sc/source/ui/docshell/docsh.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 0440f4f03791dade49565c87d8e06bc5385d98f0
Author: Mike Kaganski
Date: Sat Oct 24 19:03:33 2015 +1000
tdf#95220: Check if DrawingLayer is not nullptr
bool ScDocShell::isTiledRendering() const crashed without this check
Change-Id: Idb7ace05eb1aa37cbc3d956503c046b0e9b9d0e5
Reviewed-on: https://gerrit.libreoffice.org/19570
Tested-by: Jenkins
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sc/source/ui/docshell/docsh.cxx b/sc/source/ui/docshell/docsh.cxx
index ad3b6bf..a93aea4 100644
--- a/sc/source/ui/docshell/docsh.cxx
+++ b/sc/source/ui/docshell/docsh.cxx
@@ -3185,7 +3185,7 @@ void ScDocShell::libreOfficeKitCallback(int nType, const
char* pPayload) const
bool ScDocShell::isTiledRendering() const
{
-return aDocument.GetDrawLayer()->isTiledRendering();
+return aDocument.GetDrawLayer() &&
aDocument.GetDrawLayer()->isTiledRendering();
}
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/math.cxx |1 +
1 file changed, 1 insertion(+)
New commits:
commit c3acead32e1d844b81e3e90c72549281d4bc73a2
Author: Noel Grandin
Date: Mon Oct 26 08:03:26 2015 +0200
attempted fix for android build
Change-Id: I47e5e3ebbbf55ae1fbbf2df85f9efbdd8bca1322
diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 10faec3..05a1033 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -36,6 +36,7 @@
#include
#include
#include
+#include
static int const n10Count = 16;
static double const n10s[2][n10Count] = {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: unoxml/source
unoxml/source/dom/node.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 96a6ab886f6d3e726fe54f6dc18c6c6769c27716 Author: Mario J. Rugiero Date: Sun Oct 25 18:06:43 2015 -0300 Remove unneeded boost/bind include from unoxml/source/dom/node.cxx Change-Id: Ia97d9a24ffd455a135c44bba250fd0c27df7f910 Reviewed-on: https://gerrit.libreoffice.org/19591 Tested-by: Jenkins Reviewed-by: Noel Grandin diff --git a/unoxml/source/dom/node.cxx b/unoxml/source/dom/node.cxx index a01296e..bf378c0 100644 --- a/unoxml/source/dom/node.cxx +++ b/unoxml/source/dom/node.cxx @@ -26,8 +26,6 @@ #include -#include - #include #include #include ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: basegfx/source basegfx/test
basegfx/source/range/b2dpolyrange.cxx|5 +
basegfx/source/range/b2drangeclipper.cxx | 23 +++
basegfx/test/boxclipper.cxx | 24 ++--
3 files changed, 14 insertions(+), 38 deletions(-)
New commits:
commit 32b54f97d1be1257090437a3e959aa618ace6018
Author: Mario J. Rugiero
Date: Sun Oct 25 20:00:08 2015 -0300
Replace boost::bind by lambdas in basegfx tree.
Change-Id: I8f72bec11b5dfd71cc60a18b980629c176d43f49
Reviewed-on: https://gerrit.libreoffice.org/19595
Tested-by: Jenkins
Reviewed-by: Noel Grandin
diff --git a/basegfx/source/range/b2dpolyrange.cxx
b/basegfx/source/range/b2dpolyrange.cxx
index 95982a6..25117cb 100644
--- a/basegfx/source/range/b2dpolyrange.cxx
+++ b/basegfx/source/range/b2dpolyrange.cxx
@@ -24,7 +24,6 @@
#include
#include
-#include
#include
#include
@@ -80,9 +79,7 @@ namespace basegfx
const std::vector::const_iterator aEnd( maRanges.end() );
return std::any_of( maRanges.begin(),
aEnd,
- boost::bind( boost::mem_fn(
&B2DRange::overlaps ),
-_1,
-boost::cref(rRange) ) );
+ [&rRange](const B2DRange& aRange) { return
aRange.overlaps(rRange); } );
}
B2DPolyPolygon solveCrossovers() const
diff --git a/basegfx/source/range/b2drangeclipper.cxx
b/basegfx/source/range/b2drangeclipper.cxx
index d39c33c..7ddc85c 100644
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@@ -29,7 +29,6 @@
#include
#include
-#include
#include
#include
@@ -496,11 +495,7 @@ namespace basegfx
B2DPolygon aRes;
std::for_each( maPoints.begin(),
maPoints.end(),
- boost::bind(
- &B2DPolygon::append,
- boost::ref(aRes),
- _1,
- 1 ) );
+ [&aRes](const B2DPoint& aPoint) mutable {
aRes.append(aPoint, 1); });
aRes.setClosed( true );
return aRes;
}
@@ -748,10 +743,7 @@ namespace basegfx
// rect is regarded _outside_ any rects whose events have
// started earlier
first = std::find_if(first, last,
- boost::bind(
- &isSameRect,
- _1,
- boost::cref(rCurrRect)));
+ [&rCurrRect](ActiveEdge& anEdge) { return
isSameRect(anEdge, rCurrRect); });
if(first == last)
return;
@@ -907,12 +899,11 @@ namespace basegfx
std::for_each( aSweepLineEvents.begin(),
aSweepLineEvents.end(),
- boost::bind(
- &handleSweepLineEvent,
- _1,
- boost::ref(aActiveEdgeList),
- boost::ref(aPolygonPool),
- boost::ref(aRes)) );
+ [&](SweepLineEvent& aSweepLineEvent) mutable {
handleSweepLineEvent(
+ aSweepLineEvent,
+ aActiveEdgeList,
+ aPolygonPool,
+ aRes); } );
return aRes;
}
diff --git a/basegfx/test/boxclipper.cxx b/basegfx/test/boxclipper.cxx
index c6770d3..92edbdb 100644
--- a/basegfx/test/boxclipper.cxx
+++ b/basegfx/test/boxclipper.cxx
@@ -35,8 +35,6 @@
#include
#include
-#include
-
#include
using namespace ::basegfx;
@@ -168,14 +166,9 @@ public:
OUString::createFromAscii(randomSvg), false, 0);
std::for_each(randomPoly.begin(),
randomPoly.end(),
- boost::bind(
- &B2DPolyRange::appendElement,
- boost::ref(aRandomIntersections),
- boost::bind(
- &B2DPolygon::getB2DRange,
- _1),
- B2VectorOrientation::Negative,
- 1));
+ [this](const B2DPolygon& aPolygon) mutable {
+
this->aRandomIntersections.appendElement(aPolygon.getB2DRange(),
+ B2VectorOrientation::Negative, 1); } );
#endif
}
@@ -223,14 +216,9 @@ public:
// now, sort all polygons with increasing 0th point
std::sort(aRes.begin(),
aRes.end(),
- boost::bind(
- &compare,
- boost::bind(
-
[Libreoffice-commits] core.git: sd/source
sd/source/core/CustomAnimationEffect.cxx| 6 +++--- sd/source/core/PageListWatcher.hxx | 6 +++--- sd/source/core/annotations/Annotation.cxx | 2 +- sd/source/core/annotations/AnnotationEnumeration.cxx| 2 +- sd/source/core/drawdoc3.cxx | 2 +- sd/source/core/stlpool.cxx | 2 +- sd/source/core/stlsheet.cxx | 2 +- sd/source/core/text/textapi.cxx | 2 +- sd/source/filter/eppt/eppt.hxx | 2 +- sd/source/filter/eppt/epptbase.hxx | 6 +++--- sd/source/filter/eppt/grouptable.hxx| 4 ++-- sd/source/filter/eppt/pptx-text.cxx | 2 +- sd/source/filter/grf/sdgrffilter.cxx| 2 +- sd/source/filter/html/buttonset.cxx | 2 +- sd/source/filter/html/htmlex.cxx| 2 +- sd/source/filter/html/htmlex.hxx| 2 +- sd/source/filter/ppt/ppt97animations.hxx| 2 +- sd/source/filter/ppt/propread.hxx | 2 +- sd/source/filter/xml/sdtransform.cxx| 2 +- sd/source/ui/animations/CustomAnimationDialog.hxx | 4 ++-- sd/source/ui/animations/CustomAnimationList.cxx | 4 ++-- sd/source/ui/animations/CustomAnimationList.hxx | 2 +- sd/source/ui/animations/SlideTransitionPane.cxx | 2 +- sd/source/ui/animations/motionpathtag.cxx | 2 +- sd/source/ui/annotations/annotationmanagerimpl.hxx | 2 +- sd/source/ui/dlg/RemoteDialog.hxx | 2 +- sd/source/ui/dlg/RemoteDialogClientBox.hxx | 4 ++-- sd/source/ui/dlg/dlgass.cxx | 2 +- sd/source/ui/dlg/headerfooterdlg.cxx| 2 +- sd/source/ui/framework/configuration/ConfigurationControllerBroadcaster.hxx | 2 +- sd/source/ui/framework/configuration/ConfigurationUpdater.cxx | 2 +- sd/source/ui/framework/configuration/ResourceFactoryManager.hxx | 2 +- sd/source/ui/framework/factories/BasicPaneFactory.hxx | 2 +- sd/source/ui/framework/factories/BasicToolBarFactory.hxx| 2 +- sd/source/ui/framework/factories/BasicViewFactory.hxx | 2 +- sd/source/ui/framework/factories/PresentationFactory.cxx| 4 ++-- sd/source/ui/framework/module/CenterViewFocusModule.hxx | 2 +- sd/source/ui/framework/module/ShellStackGuard.hxx | 2 +- sd/source/ui/framework/module/ToolBarModule.hxx | 2 +- sd/source/ui/framework/tools/FrameworkHelper.cxx| 6 +++--- sd/source/ui/inc/DrawController.hxx | 4 ++-- sd/source/ui/inc/TabControl.hxx | 2 +- sd/source/ui/inc/optsitem.hxx | 10 +- sd/source/ui/presenter/PresenterHelper.hxx | 2 +- sd/source/ui/presenter/PresenterPreviewCache.hxx| 2 +- sd/source/ui/remotecontrol/BluetoothServer.hxx | 2 +- sd/source/ui/remotecontrol/BufferedStreamSocket.hxx | 4 ++-- sd/source/ui/remotecontrol/Communicator.hxx | 2 +- sd/source/ui/remotecontrol/Receiver.hxx | 2 +- sd/source/ui/remotecontrol/Transmitter.hxx | 2 +- sd/source/ui/sidebar/MasterPageContainerFiller.hxx | 2 +- sd/source/ui/sidebar/MasterPageContainerProviders.hxx | 6 +++--- sd/source/ui/sidebar/MasterPageContainerQueue.cxx | 4 ++-- sd/source/ui/sidebar/MasterPageContainerQueue.hxx | 2 +- sd/source/ui/slideshow/slideshowimpl.hxx| 2 +- sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx | 2 +- sd/source/ui/slidesorter/c
[Libreoffice-commits] core.git: formula/source
formula/source/ui/dlg/formula.cxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit bebc20c62be2df2cf2741fb82945ce6b631d2fe5
Author: Julien Nabet
Date: Sun Oct 25 16:55:28 2015 +0100
tdf#90695: In function Wizard Array box cannot be unchecked
Just remove the disabling
Change-Id: Ia03591610ba1b60a66d9962169383c4ab85288ca
Reviewed-on: https://gerrit.libreoffice.org/19590
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard
Tested-by: Markus Mohrhard
diff --git a/formula/source/ui/dlg/formula.cxx
b/formula/source/ui/dlg/formula.cxx
index 831d54b..71d87a8 100644
--- a/formula/source/ui/dlg/formula.cxx
+++ b/formula/source/ui/dlg/formula.cxx
@@ -1572,7 +1572,6 @@ bool FormulaDlg_Impl::CheckMatrix(OUString& aFormula)
{
aFormula = aFormula.copy( 1, aFormula.getLength()-2 );
m_pBtnMatrix->Check( bMatrix );
-m_pBtnMatrix->Disable();
} // if ( bMatrix )
m_pTabCtrl->SetCurPageId(TP_STRUCT);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] help.git: AllLangHelp_scalc.mk source/text
AllLangHelp_scalc.mk | 11 +++
source/text/scalc/01/04060116.xhp| 110 +--
source/text/scalc/01/ODFF.xhp|2
source/text/scalc/01/ful_func.xhp| 67 +
source/text/scalc/01/func_imcos.xhp | 76
source/text/scalc/01/func_imcosh.xhp | 76
source/text/scalc/01/func_imcot.xhp | 78
source/text/scalc/01/func_imcsc.xhp | 80 +
source/text/scalc/01/func_imcsch.xhp | 80 +
source/text/scalc/01/func_imsec.xhp | 80 +
source/text/scalc/01/func_imsech.xhp | 80 +
source/text/scalc/01/func_imsin.xhp | 76
source/text/scalc/01/func_imsinh.xhp | 77
source/text/scalc/01/func_imtan.xhp | 78
14 files changed, 940 insertions(+), 31 deletions(-)
New commits:
commit 5d7d8ae940137262e8fd575a2214bf0baf0e9c1f
Author: tagezi
Date: Fri Oct 23 00:59:22 2015 +0300
A description of trigonometric function IM*
In ODFF a phrase was rewrote
in func_imsec.xhp and func_imsinh.xhp typos are corrected
in AllLangHelp_scalc.mk typo is correctedo
Change-Id: Ieecb11deae5a8b1da56cdaadc9f75ef08b211e3c
Reviewed-on: https://gerrit.libreoffice.org/19429
Reviewed-by: Olivier Hallot
Tested-by: Olivier Hallot
diff --git a/AllLangHelp_scalc.mk b/AllLangHelp_scalc.mk
index 09735b8..975c527 100644
--- a/AllLangHelp_scalc.mk
+++ b/AllLangHelp_scalc.mk
@@ -181,6 +181,7 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
helpcontent2/source/text/scalc/01/12120300 \
helpcontent2/source/text/scalc/01/ex_data_stat_func \
helpcontent2/source/text/scalc/01/format_graphic \
+helpcontent2/source/text/scalc/01/ful_func \
helpcontent2/source/text/scalc/01/func_aggregate \
helpcontent2/source/text/scalc/01/func_averageif \
helpcontent2/source/text/scalc/01/func_averageifs \
@@ -196,6 +197,16 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,scalc,\
helpcontent2/source/text/scalc/01/func_eomonth \
helpcontent2/source/text/scalc/01/func_error_type \
helpcontent2/source/text/scalc/01/func_hour \
+helpcontent2/source/text/scalc/01/func_imcot \
+helpcontent2/source/text/scalc/01/func_imcos \
+helpcontent2/source/text/scalc/01/func_imcosh \
+helpcontent2/source/text/scalc/01/func_imcsc \
+helpcontent2/source/text/scalc/01/func_imcsch \
+helpcontent2/source/text/scalc/01/func_imsec \
+helpcontent2/source/text/scalc/01/func_imsech \
+helpcontent2/source/text/scalc/01/func_imsin \
+helpcontent2/source/text/scalc/01/func_imsinh \
+helpcontent2/source/text/scalc/01/func_imtan \
helpcontent2/source/text/scalc/01/func_minute \
helpcontent2/source/text/scalc/01/func_month \
helpcontent2/source/text/scalc/01/func_networkdays \
diff --git a/source/text/scalc/01/04060116.xhp
b/source/text/scalc/01/04060116.xhp
index 92448cf..0a9872e 100644
--- a/source/text/scalc/01/04060116.xhp
+++ b/source/text/scalc/01/04060116.xhp
@@ -105,21 +105,46 @@
=IMARGUMENT("3+4j") returns
0.927295.
-
-IMCOS function
-
-
-IMCOS
- The result is the cosine
of a complex number.
- Syntax
- IMCOS("ComplexNumber")
-
- Example
-
-=IMCOS("3+4j") returns -27.03-3.85i
(rounded).
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
IMDIV function
@@ -241,21 +266,46 @@
=IMREAL("1+3j") returns 1.
-
-IMSIN function
-
-
-IMSIN
- The result is the sine of
a complex number.
- Syntax
- IMSIN("ComplexNumber")
-
- Example
-
-=IMSIN("3+4j") returns 3.85+27.02j
(rounded).
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
[Libreoffice-commits] core.git: helpcontent2
helpcontent2 |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4e049fc892b57ca4f3013dc8d6d33d3c1a416e3e Author: tagezi Date: Fri Oct 23 00:59:22 2015 +0300 Updated core Project: help 5d7d8ae940137262e8fd575a2214bf0baf0e9c1f A description of trigonometric function IM* In ODFF a phrase was rewrote in func_imsec.xhp and func_imsinh.xhp typos are corrected in AllLangHelp_scalc.mk typo is correctedo Change-Id: Ieecb11deae5a8b1da56cdaadc9f75ef08b211e3c Reviewed-on: https://gerrit.libreoffice.org/19429 Reviewed-by: Olivier Hallot Tested-by: Olivier Hallot diff --git a/helpcontent2 b/helpcontent2 index 4b80c47..5d7d8ae 16 --- a/helpcontent2 +++ b/helpcontent2 @@ -1 +1 @@ -Subproject commit 4b80c476bf665bdafe7f35003df9b42e3f721564 +Subproject commit 5d7d8ae940137262e8fd575a2214bf0baf0e9c1f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: lessons learned from hackfests
Riccardo Magliocchetti wrote: > Given such a short time frame how is this time better spent from > your own experience? > Hi Riccardo, as others said, try to push as much deliberation/setup/preps in front of the event. TDF provides a number of cloud VMs with a pre-built libreoffice for hackfests, so don't waste time with that during the event. Try to have them pre-select an Easy Hack beforehand, or pick one for them if you have an idea about their skill sets. For keeping people involved, of course a working libreoffice compile on their laptops is sortof nice, so this could be something to do in the background while working on the cloud instances. Don't expect all builds to be finished after 4 hours though... > What do you think is more important to tackle? helping people > getting setting up their machines, explaining libo tools / > development, going straight to easy hacks or something else? > The gratification of having an Easy Hack submitted to gerrit & merged is hard to beat. I'd go with that. My 2 cents at least, -- Thorsten signature.asc Description: Digital signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39440] cppcheck cleanliness
https://bugs.documentfoundation.org/show_bug.cgi?id=39440 --- Comment #70 from Commit Notification --- Serge Krot committed a patch related to this issue. It has been pushed to "master": http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b018d202dfcf4bb16b708e10085a4146243b0a0 tdf#39440: fix several warnings reported by cppcheck It will be available in 5.1.0. The patch should be included in the daily builds available at http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: http://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: bridges/source bridges/test comphelper/source compilerplugins/clang cui/source drawinglayer/source dtrans/source dtrans/test jvmfwk/source sal/osl
bridges/source/cpp_uno/gcc3_linux_mips/cpp2uno.cxx |2 +-
bridges/source/cpp_uno/gcc3_linux_sparc/cpp2uno.cxx |2 +-
bridges/test/testoffice.cxx |2 +-
comphelper/source/misc/configuration.cxx|3 +--
compilerplugins/clang/automem.cxx |2 +-
compilerplugins/clang/badvectorinit.cxx |2 +-
compilerplugins/clang/staticmethods.cxx |2 +-
cui/source/options/optlingu.cxx |9 +
drawinglayer/source/processor2d/vclprocessor2d.cxx |4 ++--
drawinglayer/source/texture/texture.cxx |4 ++--
dtrans/source/win32/workbench/test_wincb.cxx|2 +-
dtrans/source/win32/workbench/testmarshal.cxx |2 +-
dtrans/test/win32/dnd/atlwindow.cxx |1 -
jvmfwk/source/fwkutil.cxx |4 ++--
sal/osl/w32/profile.cxx |2 +-
15 files changed, 21 insertions(+), 22 deletions(-)
New commits:
commit 0b018d202dfcf4bb16b708e10085a4146243b0a0
Author: Serge Krot
Date: Sun Oct 25 14:37:11 2015 +0300
tdf#39440: fix several warnings reported by cppcheck
Change-Id: I560d28b7cc67740c6479494d0e5aa62d2ac6ffae
Reviewed-on: https://gerrit.libreoffice.org/19587
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens
diff --git a/bridges/source/cpp_uno/gcc3_linux_mips/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_mips/cpp2uno.cxx
index 167b4ad..6e0a7dc 100644
--- a/bridges/source/cpp_uno/gcc3_linux_mips/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_mips/cpp2uno.cxx
@@ -385,7 +385,7 @@ namespace
#ifdef BRDEBUG
fprintf(stderr,"cpp_mediate1 gp=%p,fp=%p,ov=%p\n",gpreg,fpreg,ovrflw);
-fprintf(stderr,"gp=%x,%x,%x,%x\n",gpreg[0],gpreg[1],gpreg[2],gpreg[3]);
+fprintf(stderr,"gp=%p,%p,%p,%p\n",gpreg[0],gpreg[1],gpreg[2],gpreg[3]);
#endif
// gpreg: [ret *], this, [other gpr params]
diff --git a/bridges/source/cpp_uno/gcc3_linux_sparc/cpp2uno.cxx
b/bridges/source/cpp_uno/gcc3_linux_sparc/cpp2uno.cxx
index 93b10de..f0fa890 100644
--- a/bridges/source/cpp_uno/gcc3_linux_sparc/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_sparc/cpp2uno.cxx
@@ -377,7 +377,7 @@ void * pRegReturn = &nRegReturn;
// fprintf(stderr,"cpp_mediate nFunctionIndex=%x\n",nFunctionIndex);
// fflush(stderr);
-sal_Bool bComplex = nFunctionIndex & 0x8000 ? sal_True : sal_False;
+const sal_Bool bComplex = (nFunctionIndex & 0x8000) ? sal_True :
sal_False;
typelib_TypeClass aType =
cpp_mediate( nFunctionIndex, vTableOffset, pCallStack+17,
(sal_Int64*)&nRegReturn );
diff --git a/bridges/test/testoffice.cxx b/bridges/test/testoffice.cxx
index 5d17a00..9e34602 100644
--- a/bridges/test/testoffice.cxx
+++ b/bridges/test/testoffice.cxx
@@ -112,7 +112,7 @@ void testWriter( const Reference < XComponent > & rCmp )
printf( "pleast type any text\n" );
while( true )
{
-scanf( "%s" , pcText );
+scanf( "%1023s" , pcText );
if( !strcmp( pcText , "end" ) )
{
diff --git a/comphelper/source/misc/configuration.cxx
b/comphelper/source/misc/configuration.cxx
index ea01cea..bb00475 100644
--- a/comphelper/source/misc/configuration.cxx
+++ b/comphelper/source/misc/configuration.cxx
@@ -220,8 +220,7 @@ void
comphelper::ConfigurationListener::addListener(ConfigurationListenerPropert
void
comphelper::ConfigurationListener::removeListener(ConfigurationListenerPropertyBase
*pListener)
{
-auto it = maListeners.begin();
-it = std::find( maListeners.begin(), maListeners.end(), pListener );
+auto it = std::find( maListeners.begin(), maListeners.end(), pListener );
if ( it != maListeners.end() )
{
maListeners.erase( it );
diff --git a/compilerplugins/clang/automem.cxx
b/compilerplugins/clang/automem.cxx
index 7981c7a..dfa3525 100644
--- a/compilerplugins/clang/automem.cxx
+++ b/compilerplugins/clang/automem.cxx
@@ -26,7 +26,7 @@ class AutoMem:
public RecursiveASTVisitor, public loplugin::Plugin
{
public:
-explicit AutoMem(InstantiationData const & data): Plugin(data) {}
+explicit AutoMem(InstantiationData const & data): Plugin(data),
mbInsideDestructor(false) {}
virtual void run() override
{
diff --git a/compilerplugins/clang/badvectorinit.cxx
b/compilerplugins/clang/badvectorinit.cxx
index 709a65d..7f67ffc 100644
--- a/compilerplugins/clang/badvectorinit.cxx
+++ b/compilerplugins/clang/badvectorinit.cxx
@@ -89,7 +89,7 @@ class BadVectorInit:
public RecursiveASTVisitor, public loplugin::Plugin
{
public:
-explicit BadVectorInit(InstantiationData const & data): Plugin(data) {}
+explicit BadVectorInit(InstantiationData const & data): Plugin(data),
mbInsideFunction(false) {}
virtual void run() override
{
diff --git a/compilerplugins/clang/staticmethods.cxx
b/compilerplugins/clang/staticmethods.cxx
index 42c958d..1d9313f 100644
--- a/comp
[Libreoffice-commits] core.git: Branch 'aoo/trunk' - odk/pack
odk/pack/gendocu/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 493bb354291470ce9ef88ad039023fe1453e3fbc Author: Damjan Jovanovic Date: Sun Oct 25 18:28:46 2015 + Passing both -u and -o to unzip is ambiguous, as -u only overwrites files that are older while -o always overwrites them. What's worse, on FreeBSD using -u and -o together is an error that breaks the build. Tests show Info-ZIP's unzip treats -u and -o together as just -u, so let's call unzip with just -u. diff --git a/odk/pack/gendocu/makefile.mk b/odk/pack/gendocu/makefile.mk index a05c00f..d5c4e39 100644 --- a/odk/pack/gendocu/makefile.mk +++ b/odk/pack/gendocu/makefile.mk @@ -100,7 +100,7 @@ $(CPP_DOCU_INDEX_FILE) : $(CPP_DOCU_CLEANUP_FLAG) $(JAVA_SRC_FILES) : $(SOLARCOMMONBINDIR)$/$$(@:f) -$(MKDIRHIER) $(@:d) $(MY_COPY) $< $@ -cd $(JAVA_SRC_DIR) && unzip -quo $(@:f) +cd $(JAVA_SRC_DIR) && unzip -qu $(@:f) #$(JAVA_SRC_DIR)$/com$/sun$/star$/beans$/%.java : $(PRJ)$/source$/bean$/com$/sun$/star$/beans$/%.java # -$(MKDIRHIER) $(@:d) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salprn.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit ce463679a5a362d5c3f7c146f70b6be838ddbb2d Author: Stephan Bergmann Date: Sun Oct 25 20:28:16 2015 +0100 loplugin:simplifybool Change-Id: I609e3dffeee6cde33fcbab71c15020434fe1a136 diff --git a/vcl/osx/salprn.cxx b/vcl/osx/salprn.cxx index 3cb9a93..9ef6d8e 100644 --- a/vcl/osx/salprn.cxx +++ b/vcl/osx/salprn.cxx @@ -501,7 +501,7 @@ bool AquaSalInfoPrinter::StartJob( const OUString* i_pFileName, pInst->startedPrintJob(); BOOL wasSuccessful = [pPrintOperation runOperation]; pInst->endedPrintJob(); -bSuccess = wasSuccessful ? true : false; +bSuccess = wasSuccessful; bWasAborted = [[[pPrintOperation printInfo] jobDisposition] compare: NSPrintCancelJob] == NSOrderedSame; mbJob = false; if( pReleaseAfterUse ) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/salinst.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit fb3ca9626fd143006dbf709a65e56fa55c2dd52f
Author: Stephan Bergmann
Date: Sun Oct 25 20:27:30 2015 +0100
loplugin:defaultparams
Change-Id: I0aefe45eb06ac9d63fa79c33fd63f120c0258470
diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index bee5024..0ae4ff6 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -93,7 +93,7 @@ class AquaDelayedSettingsChanged : public Idle
it != pSalData->maFrames.end(); ++it )
{
if( (*it)->mbShown )
-(*it)->SendPaintEvent( NULL );
+(*it)->SendPaintEvent();
}
}
Stop();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: vcl/osx
vcl/osx/printaccessoryview.mm |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 4415c9f54d8e723343c90561377ea4b8b4654a8a
Author: Stephan Bergmann
Date: Sun Oct 25 20:26:37 2015 +0100
loplugin:simplifybool
Change-Id: Ice6dfc7b8e295f322f38f8bc8f01d6776c742e54
diff --git a/vcl/osx/printaccessoryview.mm b/vcl/osx/printaccessoryview.mm
index b4042d2..22a61a9 100644
--- a/vcl/osx/printaccessoryview.mm
+++ b/vcl/osx/printaccessoryview.mm
@@ -1085,7 +1085,7 @@ static void addEdit( NSView* pCurParent, long& rCurX,
long& rCurY, long nAttachO
{
sal_Bool bValue = sal_True;
rEntry.Value >>= bValue;
-bEnabled = bValue ? true : false;
+bEnabled = bValue;
}
else if(
rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("MinValue")) )
{
@@ -1103,7 +1103,7 @@ static void addEdit( NSView* pCurParent, long& rCurX,
long& rCurY, long nAttachO
{
sal_Bool bValue = sal_False;
rEntry.Value >>= bValue;
-bIgnore = bValue ? true : false;
+bIgnore = bValue;
}
else if(
rEntry.Name.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("GroupingHint")) )
{
@@ -1182,7 +1182,7 @@ static void addEdit( NSView* pCurParent, long& rCurX,
long& rCurY, long nAttachO
if( pVal )
pVal->Value >>= bVal;
addBool( pCurParent, nCurX, nCurY, nAttachOffset,
- aText, true, aPropertyName, bVal?true:false,
+ aText, true, aPropertyName, bVal,
aRightColumn, pControllerProperties, pCtrlTarget );
}
else if(
aCtrlType.equalsAsciiL(RTL_CONSTASCII_STRINGPARAM("Radio")) && pCurParent )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: 2 commits - sc/source
sc/source/filter/oox/workbookhelper.cxx |4
1 file changed, 4 deletions(-)
New commits:
commit 129f814f6a18bf474f22a1ea9c9aa92677a8e6a5
Author: Tor Lillqvist
Date: Sun Oct 25 19:12:05 2015 +0200
WaE: Unreferenced function declaration [loplugin:unreffun]
Change-Id: Ia6baf94ada92ecd134587ed1148a2543c8c17614
diff --git a/sc/source/filter/oox/workbookhelper.cxx
b/sc/source/filter/oox/workbookhelper.cxx
index 5c573a8..d236b70 100644
--- a/sc/source/filter/oox/workbookhelper.cxx
+++ b/sc/source/filter/oox/workbookhelper.cxx
@@ -236,8 +236,6 @@ private:
/** Finalizes the filter process (sets some needed document properties). */
voidfinalize();
-void recalcFormulaCells();
-
private:
typedef ::std::unique_ptr< ScEditEngineDefaulter >
EditEngineDefaulterPtr;
typedef ::std::unique_ptr< FormulaBuffer > FormulaBufferPtr;
commit aed77f656b8a5067cf740e5af57eaf4e7b4c02db
Author: Tor Lillqvist
Date: Sun Oct 25 19:11:00 2015 +0200
WaE: Unreferenced externally visible function definition [loplugin:unreffun]
Change-Id: I4adb1c6f3eb978429768640ca25eff7d8a5ce23e
diff --git a/sc/source/filter/oox/workbookhelper.cxx
b/sc/source/filter/oox/workbookhelper.cxx
index ce4f54b..5c573a8 100644
--- a/sc/source/filter/oox/workbookhelper.cxx
+++ b/sc/source/filter/oox/workbookhelper.cxx
@@ -148,8 +148,6 @@ public:
ScDocument& getScDocument() { return *mpDoc; }
-ScDocShell& getDocShell() { return *mpDocShell; }
-
ScDocumentImport& getDocImport();
/** Returns a reference to the source/target spreadsheet document model. */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: sc/source
sc/source/filter/inc/workbookfragment.hxx |2
sc/source/filter/oox/workbookfragment.cxx | 79 +++---
sc/source/filter/oox/workbookhelper.cxx | 51 ---
3 files changed, 75 insertions(+), 57 deletions(-)
New commits:
commit d4743045a0b320449d07a957463a76bb8b13f939
Author: Markus Mohrhard
Date: Sat Oct 24 09:45:58 2015 +0200
the cells need to be imported before we handle charts, tdf#81396
Change-Id: Ic0dc47b71e76aa4825a867fc171406d126ae0518
Reviewed-on: https://gerrit.libreoffice.org/19568
Tested-by: Jenkins
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sc/source/filter/inc/workbookfragment.hxx
b/sc/source/filter/inc/workbookfragment.hxx
index 4a28034..4e22b7b 100644
--- a/sc/source/filter/inc/workbookfragment.hxx
+++ b/sc/source/filter/inc/workbookfragment.hxx
@@ -55,6 +55,8 @@ private:
voidimportExternalLinkFragment( ExternalLink& rExtLink );
voidimportPivotCacheDefFragment( const OUString& rRelId,
sal_Int32 nCacheId );
+void recalcFormulaCells();
+
private:
DefinedNameRef mxCurrName;
};
diff --git a/sc/source/filter/oox/workbookfragment.cxx
b/sc/source/filter/oox/workbookfragment.cxx
index 08ca758..abd63b07 100644
--- a/sc/source/filter/oox/workbookfragment.cxx
+++ b/sc/source/filter/oox/workbookfragment.cxx
@@ -52,9 +52,11 @@
#include "document.hxx"
#include "docsh.hxx"
#include "calcconfig.hxx"
+#include "globstr.hrc"
#include
#include
+#include
#include
#include
@@ -68,6 +70,9 @@
#include
+#include
+#include
+
namespace oox {
namespace xls {
@@ -482,6 +487,19 @@ void WorkbookFragment::finalizeImport()
// load all worksheets
importSheetFragments(*this, aSheetFragments);
+sal_Int16 nActiveSheet = getViewSettings().getActiveCalcSheet();
+getWorksheets().finalizeImport( nActiveSheet );
+
+// final conversions, e.g. calculation settings and view settings
+finalizeWorkbookImport();
+//
+//stop preventing establishment of listeners as is done in
+//ScDocShell::AfterXMLLoading() for ods
+getScDocument().SetInsertingFromOtherDoc(false);
+getDocImport().finalize();
+
+recalcFormulaCells();
+
for( std::vector::iterator aIt = maHelpers.begin(), aEnd
= maHelpers.end(); aIt != aEnd; ++aIt )
{
(*aIt)->finalizeDrawingImport();
@@ -494,12 +512,6 @@ void WorkbookFragment::finalizeImport()
aIt->first.reset();
}
-sal_Int16 nActiveSheet = getViewSettings().getActiveCalcSheet();
-getWorksheets().finalizeImport( nActiveSheet );
-
-// final conversions, e.g. calculation settings and view settings
-finalizeWorkbookImport();
-
OUString aRevHeadersPath =
getFragmentPathFromFirstType(CREATE_OFFICEDOC_RELATION_TYPE("revisionHeaders"));
if (!aRevHeadersPath.isEmpty())
{
@@ -509,6 +521,61 @@ void WorkbookFragment::finalizeImport()
}
}
+namespace {
+
+ScDocShell& getDocShell(ScDocument& rDoc)
+{
+return static_cast(*rDoc.GetDocumentShell());
+}
+
+}
+
+void WorkbookFragment::recalcFormulaCells()
+{
+// Recalculate formula cells.
+ScDocument& rDoc = getScDocument();
+ScDocShell& rDocSh = getDocShell(rDoc);
+Reference< XComponentContext > xContext =
comphelper::getProcessComponentContext();
+ScRecalcOptions nRecalcMode =
+
static_cast(officecfg::Office::Calc::Formula::Load::OOXMLRecalcMode::get(xContext));
+bool bHardRecalc = false;
+if (nRecalcMode == RECALC_ASK)
+{
+if (rDoc.IsUserInteractionEnabled())
+{
+// Ask the user if full re-calculation is desired.
+ScopedVclPtrInstance aBox(
+ScDocShell::GetActiveDialogParent(), WinBits(WB_YES_NO |
WB_DEF_YES),
+ScGlobal::GetRscString(STR_QUERY_FORMULA_RECALC_ONLOAD_XLS));
+
aBox->SetCheckBoxText(ScGlobal::GetRscString(STR_ALWAYS_PERFORM_SELECTED));
+
+sal_Int32 nRet = aBox->Execute();
+bHardRecalc = nRet == RET_YES;
+
+if (aBox->GetCheckBoxState())
+{
+// Always perform selected action in the future.
+std::shared_ptr
batch(comphelper::ConfigurationChanges::create());
+
officecfg::Office::Calc::Formula::Load::OOXMLRecalcMode::set(sal_Int32(0),
batch);
+ScFormulaOptions aOpt = SC_MOD()->GetFormulaOptions();
+aOpt.SetOOXMLRecalcOptions(bHardRecalc ? RECALC_ALWAYS :
RECALC_NEVER);
+/* XXX is this really supposed to set the ScModule options?
+ * Not the ScDocShell options? */
+SC_MOD()->SetFormulaOptions(aOpt);
+
+batch->commit();
+}
+}
+}
+else if (nRecalcMode == RECALC_ALWAYS)
+bHardRecalc = true;
+
+if (bHardRecalc)
+rDocSh.DoHardRecalc(false);
+else
+rDoc.CalcFormulaTree(false, true, false);
[Libreoffice-commits] core.git: sal/rtl
sal/rtl/math.cxx | 61 +--
1 file changed, 2 insertions(+), 59 deletions(-)
New commits:
commit 5ce68783148aa77d77086aac220fabdfa211429d
Author: Eike Rathke
Date: Sun Oct 25 16:04:50 2015 +0100
replace implementation of rtl_math_expm1() and rtl_math_log1p()
... with ::std::expm1() and ::std::log1p() of C++11
Change-Id: I0d119958152ea372c136d28705686b44b39015bf
Reviewed-on: https://gerrit.libreoffice.org/19588
Tested-by: Jenkins
Reviewed-by: Eike Rathke
Tested-by: Eike Rathke
diff --git a/sal/rtl/math.cxx b/sal/rtl/math.cxx
index 5a624e1..10faec3 100644
--- a/sal/rtl/math.cxx
+++ b/sal/rtl/math.cxx
@@ -971,69 +971,12 @@ double SAL_CALL rtl_math_approxValue( double fValue )
SAL_THROW_EXTERN_C()
double SAL_CALL rtl_math_expm1( double fValue ) SAL_THROW_EXTERN_C()
{
-// See http://en.cppreference.com/w/cpp/numeric/math/expm1
-
-if (fValue == 0.0)
-return fValue;
-
-if (!::rtl::math::isFinite(fValue))
-{
-if (::rtl::math::isInf(fValue))
-{
-if (::rtl::math::isSignBitSet(fValue))
-return -1.0;
-else
-return fValue;
-}
-// It is a NaN.
-return fValue;
-}
-
-double fe = exp( fValue );
-if (fe == 1.0)
-return fValue;
-if (fe-1.0 == -1.0)
-return -1.0;
-return (fe-1.0) * fValue / log(fe);
+return ::std::expm1(fValue);
}
double SAL_CALL rtl_math_log1p( double fValue ) SAL_THROW_EXTERN_C()
{
-// See http://en.cppreference.com/w/cpp/numeric/math/log1p
-
-if (fValue == 0.0)
-return fValue;
-
-if (fValue == -1.0)
-{
-rtl::math::setInf( &fValue, true);
-return fValue;
-}
-
-if (fValue < -1.0) // includes -Inf
-{
-rtl::math::setNan( &fValue);
-return fValue;
-}
-
-if (!::rtl::math::isFinite(fValue))
-{
-if (::rtl::math::isInf(fValue))
-return fValue;
-// It is a NaN.
-return fValue;
-}
-
-// Use volatile because a compiler may be too smart "optimizing" the
-// condition such that in certain cases the else path was called even if
-// (fp==1.0) was true, where the term (fp-1.0) then resulted in 0.0 and
-// hence the entire expression resulted in NaN.
-// Happened with g++ 3.4.1 and an input value of 9.87E-18
-volatile double fp = 1.0 + fValue;
-if (fp == 1.0)
-return fValue;
-else
-return log(fp) * fValue / (fp-1.0);
+return ::std::log1p(fValue);
}
double SAL_CALL rtl_math_atanh( double fValue ) SAL_THROW_EXTERN_C()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 46259] rewrite mysql connector to use mariadb client library
https://bugs.documentfoundation.org/show_bug.cgi?id=46259 Lionel Elie Mamane changed: What|Removed |Added CC||zaxe...@gmail.com --- Comment #21 from Lionel Elie Mamane --- *** Bug 88965 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: 7 commits - qadevOOo/tests scripting/java testtools/com xmerge/source
qadevOOo/tests/java/ifc/sheet/_XSheetCellCursor.java
| 32 --
qadevOOo/tests/java/ifc/text/_NumberingLevel.java
| 13 +---
qadevOOo/tests/java/ifc/util/_XModifyBroadcaster.java
|2
scripting/java/com/sun/star/script/framework/container/ParcelContainer.java
|2
scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
| 22 +++---
testtools/com/sun/star/comp/bridge/TestComponentMain.java
|1
xmerge/source/xmerge/java/org/openoffice/xmerge/converter/palm/PdbDecoder.java
|7 +-
7 files changed, 25 insertions(+), 54 deletions(-)
New commits:
commit 21679f7e0d5c53cc9f18be0447f78091e61ca961
Author: Caolán McNamara
Date: Sun Oct 25 15:19:12 2015 +
coverity#1326344 Infinite loop is deliberate
Change-Id: Ieeae14607127c442b987afc51f2b59692f5334ca
diff --git a/testtools/com/sun/star/comp/bridge/TestComponentMain.java
b/testtools/com/sun/star/comp/bridge/TestComponentMain.java
index e394f19..2c83161 100644
--- a/testtools/com/sun/star/comp/bridge/TestComponentMain.java
+++ b/testtools/com/sun/star/comp/bridge/TestComponentMain.java
@@ -99,6 +99,7 @@ public class TestComponentMain
XAcceptor xAcceptor = Acceptor.create(ctx);
+// coverity[loop_top] - deliberate 'infinite' loop.
while( true )
{
System.err.println("waiting for connect...");
commit 2f9bd9ac4dfe31ba58a660fd341be03648a8c9b7
Author: Caolán McNamara
Date: Sun Oct 25 15:15:14 2015 +
cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I5578dc3885945c013064cecf2ca86e7ca734368f
diff --git
a/scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
b/scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
index 7c28efb..b77394d 100644
---
a/scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
+++
b/scripting/java/com/sun/star/script/framework/provider/javascript/ScriptEditorForJavaScript.java
@@ -50,9 +50,9 @@ public class ScriptEditorForJavaScript implements
ScriptEditor {
private static Main rhinoWindow;
private URL scriptURL;
-// global list of ScriptEditors, key is URL of file being edited
-private static Map BEING_EDITED = new
-HashMap();
+// global list of ScriptEditors, key is [external form of URL] of file
being edited
+private static Map BEING_EDITED = new
+HashMap();
static {
try {
@@ -98,7 +98,7 @@ public class ScriptEditorForJavaScript implements
ScriptEditor {
*/
public static ScriptEditorForJavaScript getEditor(URL url) {
synchronized (BEING_EDITED) {
-return BEING_EDITED.get(url);
+return BEING_EDITED.get(url.toExternalForm());
}
}
@@ -168,11 +168,11 @@ public class ScriptEditorForJavaScript implements
ScriptEditor {
new Runnable() {
public void run() {
synchronized (BEING_EDITED) {
-ScriptEditorForJavaScript editor =
BEING_EDITED.get(url);
+ScriptEditorForJavaScript editor =
BEING_EDITED.get(url.toExternalForm());
if (editor == null) {
editor = new ScriptEditorForJavaScript(context,
url);
-BEING_EDITED.put(url, editor);
+BEING_EDITED.put(url.toExternalForm(), editor);
}
}
@@ -264,11 +264,11 @@ public class ScriptEditorForJavaScript implements
ScriptEditor {
// remove all scripts from BEING_EDITED
synchronized (BEING_EDITED) {
-java.util.Iterator iter = BEING_EDITED.keySet().iterator();
-java.util.ArrayList keysToRemove = new
java.util.ArrayList();
+java.util.Iterator iter = BEING_EDITED.keySet().iterator();
+java.util.ArrayList keysToRemove = new
java.util.ArrayList();
while (iter.hasNext()) {
-URL key = iter.next();
+String key = iter.next();
keysToRemove.add(key);
}
@@ -304,8 +304,8 @@ public class ScriptEditorForJavaScript implements
ScriptEditor {
public void run() {
synchronized (BEING_EDITED) {
-BEING_EDITED.remove(this.url);
+BEING_EDITED.remove(this.url.toExternalForm());
}
}
}
-}
\ No newline at end of file
+}
commit 1db8bc211fba3759769db6698bb73a74da742512
Author: Caolán McNamara
Date: Sun Oct 25 15:08:52 2015 +
coverity#1326137 Logically dead code
Change-Id: Ib0dcae05793927ecca4e8031e66b6ca1bf4721f7
diff
[Libreoffice-commits] core.git: config_host.mk.in configure.ac connectivity/Configuration_mozab.mk connectivity/Library_mozabdrv.mk connectivity/Library_mozab.mk connectivity/Library_mozbootstrap.mk c
Makefile.fetch |5 Repository.mk | 10 RepositoryExternal.mk | 87 config_host.mk.in |3 configure.ac | 38 connectivity/Configuration_mozab.mk | 20 connectivity/Library_mozab.mk | 37 connectivity/Library_mozabdrv.mk | 70 connectivity/Library_mozbootstrap.mk |4 connectivity/Module_connectivity.mk | 10 connectivity/registry/mozab/org/openoffice/Office/DataAccess/Drivers.xcu | 145 connectivity/source/drivers/mozab/MCatalog.cxx | 111 connectivity/source/drivers/mozab/MCatalog.hxx | 55 connectivity/source/drivers/mozab/MColumnAlias.cxx | 180 connectivity/source/drivers/mozab/MColumnAlias.hxx | 79 connectivity/source/drivers/mozab/MColumns.cxx | 95 connectivity/source/drivers/mozab/MColumns.hxx | 51 connectivity/source/drivers/mozab/MConfigAccess.cxx | 258 - connectivity/source/drivers/mozab/MConfigAccess.hxx | 33 connectivity/source/drivers/mozab/MConnection.cxx | 594 --- connectivity/source/drivers/mozab/MConnection.hxx | 225 - connectivity/source/drivers/mozab/MDatabaseMetaData.cxx | 1019 - connectivity/source/drivers/mozab/MDatabaseMetaData.hxx | 200 - connectivity/source/drivers/mozab/MDriver.cxx | 319 - connectivity/source/drivers/mozab/MDriver.hxx | 106 connectivity/source/drivers/mozab/MExtConfigAccess.hxx | 40 connectivity/source/drivers/mozab/MPreparedStatement.cxx | 526 -- connectivity/source/drivers/mozab/MPreparedStatement.hxx | 157 connectivity/source/drivers/mozab/MResultSet.cxx | 1966 -- connectivity/source/drivers/mozab/MResultSet.hxx | 359 - connectivity/source/drivers/mozab/MResultSetMetaData.cxx | 203 - connectivity/source/drivers/mozab/MResultSetMetaData.hxx | 93 connectivity/source/drivers/mozab/MServices.cxx | 148 connectivity/source/drivers/mozab/MStatement.cxx | 563 -- connectivity/source/drivers/mozab/MStatement.hxx | 204 - connectivity/source/drivers/mozab/MTable.cxx | 80 connectivity/source/drivers/mozab/MTable.hxx | 62 connectivity/source/drivers/mozab/MTables.cxx | 86 connectivity/source/drivers/mozab/MTables.hxx | 48 connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx | 68 connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx |2 connectivity/source/drivers/mozab/bootstrap/MNSInit.cxx | 329 - connectivity/source/drivers/mozab/bootstrap/MNSInit.hxx | 40 connectivity/source/drivers/mozab/bootstrap/MNSProfile.cxx | 624 --- connectivity/source/drivers/mozab/bootstrap/MNSProfile.hxx | 71 connectivity/source/drivers/mozab/bootstrap/MNSProfileDirServiceProvider.cxx | 232 - connectivity/source/drivers/mozab/bootstrap/MNSProfileDirServiceProvider.hxx | 80 connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx | 193 connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx | 23 connectivity/source/drivers/mozab/bootstrap/MNSProfileManager.cxx | 105 connectivity/source/drivers/mozab/bootstrap/MNSProfileManager.hxx | 65 connectivity/source/drivers/mozab/bootstrap/MNSRunnable.cxx | 90 connectivity/source/drivers/mozab/bootstrap/MNSRunnable.hxx | 62 connectivity/source/drivers/mozab/bootstrap/mozilla_nsinit.h | 4
Re: lessons learned from hackfests
Il 25/10/2015 12:26, Wols Lists ha scritto: On 25/10/15 10:50, Riccardo Magliocchetti wrote: Hello, during the next libreitalia conference we are going to host a 4 hours development session. The plan is to help more people getting started hacking on libo. Given such a short time frame how is this time better spent from your own experience? What do you think is more important to tackle? helping people getting setting up their machines, explaining libo tools / development, going straight to easy hacks or something else? How long is a piece of string? Can you have multiple streams? I'm not following you here :) Personally, I'd focus on the point after doing a "git pull", and how to set up your machine ready to push to gerrit, then how to use the bugzilla and easy hacks through to actually pushing your first trivial fixes. this sounds like a plan The thing is, different people are going to hit different roadblocks. You'll get people who need hand-holding through git, people who struggle with C++, etc etc. It'd be nice to cater for them, but there are other avenues open to them. Focus on the LO-specific stuff. Yeah, hopefully people with different skills can talk to and help each other. After that, try and explain the background as to how writer, calc, etc work internally - give people an overview so they can program easier. I don't think we have enough time for that, but of course we can provide pointers. thanks -- Riccardo Magliocchetti @rmistaken http://menodizero.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: lessons learned from hackfests
Il 25/10/2015 13:34, Olivier Hallot ha scritto: Hi Em 25/10/2015 08:50, Riccardo Magliocchetti escreveu: Hello, during the next libreitalia conference we are going to host a 4 hours development session. The plan is to help more people getting started hacking on libo. Given such a short time frame how is this time better spent from your own experience? What do you think is more important to tackle? helping people getting setting up their machines, explaining libo tools / development, going straight to easy hacks or something else? thanks in advance Our experience in Brazil told us that there is a lot of time spent in the first pull, dependecies download & setup and make (with make fetch). With 4 hours and several people doing the same thing will likely clogg the network and waste time. You can possibly download the source tarball to spare time in a pen drive (just do a pull to update), but the other dependencies will be affected by each ones computer. The first "make all" will also take a lot of time. We ask to git clone and do apt-get build-dep libreoffice as documented in the tdf wiki beforehand. The suggestion of the pen with a compressed git archive is a good one. Ideally people should come with a sucessfull first compilation: then the fun begins. To do that, a preparation beforehand with the attendees is necessary. I'd like to consider this first gathering the preparation event to a proper hackfest Whish you all a fun hacking anyway. Thanks -- Riccardo Magliocchetti @rmistaken http://menodizero.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: solenv/gbuild
solenv/gbuild/Package.mk |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit be114fd49371beb8877c1cf34b48319967458c8a Author: David Tardon Date: Sun Oct 25 14:13:17 2015 +0100 fix typo Change-Id: I06373679497ffc3472905251327073c878b48342 diff --git a/solenv/gbuild/Package.mk b/solenv/gbuild/Package.mk index 5cbe70c..a23728c 100644 --- a/solenv/gbuild/Package.mk +++ b/solenv/gbuild/Package.mk @@ -79,7 +79,7 @@ $(call gb_Package_get_preparation_target,%) : # Package_foo makefiles. $(call gb_Package_get_target,%) : $(call gb_Output_announce,$*,$(true),PKG,2) - $(if $(PACAKGE_DEFINED),,$(call gb_Output_error,Something depends on package $* which does not exist.)) + $(if $(PACKAGE_DEFINED),,$(call gb_Output_error,Something depends on package $* which does not exist.)) rm -f $@ && \ mv $(call var2file,$@.tmp,100,$(sort $(FILES))) $@ @@ -87,7 +87,7 @@ $(call gb_Package_get_target,%) : define gb_Package_Package_internal gb_Package_SOURCEDIR_$(1) := $(2) gb_Package_OUTDIR_$(1) := $(INSTROOT) -$(call gb_Package_get_target,$(1)) : PACAKGE_DEFINED := $(true) +$(call gb_Package_get_target,$(1)) : PACKAGE_DEFINED := $(true) $(call gb_Package_get_target,$(1)) : FILES := $(call gb_Package_get_clean_target,$(1)) : FILES := $(call gb_Package_get_target,$(1)) $(call gb_Package_get_preparation_target,$(1)) $(call gb_Package_get_target,$(1)) : $(call gb_Package_get_preparation_target,$(1)) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: lessons learned from hackfests
Hi Em 25/10/2015 08:50, Riccardo Magliocchetti escreveu: > Hello, > > during the next libreitalia conference we are going to host a 4 hours > development session. The plan is to help more people getting started > hacking on libo. > > Given such a short time frame how is this time better spent from your > own experience? What do you think is more important to tackle? helping > people getting setting up their machines, explaining libo tools / > development, going straight to easy hacks or something else? > > thanks in advance > Our experience in Brazil told us that there is a lot of time spent in the first pull, dependecies download & setup and make (with make fetch). With 4 hours and several people doing the same thing will likely clogg the network and waste time. You can possibly download the source tarball to spare time in a pen drive (just do a pull to update), but the other dependencies will be affected by each ones computer. The first "make all" will also take a lot of time. Ideally people should come with a sucessfull first compilation: then the fun begins. To do that, a preparation beforehand with the attendees is necessary. Whish you all a fun hacking anyway. -- Olivier Hallot Comunidade LibreOffice http://ask.libreoffice.org/pt-br ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 57751] Link from cgit to opengrok
https://bugs.documentfoundation.org/show_bug.cgi?id=57751 Dennis Roczek changed: What|Removed |Added Status|NEW |RESOLVED CC||dennisroc...@gmail.com Resolution|--- |MOVED --- Comment #2 from Dennis Roczek --- ticket moved to redmine, see https://redmine.documentfoundation.org/issues/1547 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 39439] Web search for UI strings
https://bugs.documentfoundation.org/show_bug.cgi?id=39439 Dennis Roczek changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|--- |MOVED --- Comment #14 from Dennis Roczek --- Ticket moved to Redmine (migrating www component tickets) see https://redmine.documentfoundation.org/issues/1546 -- You are receiving this mail because: You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: lessons learned from hackfests
On 25/10/15 10:50, Riccardo Magliocchetti wrote: > Hello, > > during the next libreitalia conference we are going to host a 4 hours > development session. The plan is to help more people getting started > hacking on libo. > > Given such a short time frame how is this time better spent from your > own experience? What do you think is more important to tackle? helping > people getting setting up their machines, explaining libo tools / > development, going straight to easy hacks or something else? > How long is a piece of string? Can you have multiple streams? Personally, I'd focus on the point after doing a "git pull", and how to set up your machine ready to push to gerrit, then how to use the bugzilla and easy hacks through to actually pushing your first trivial fixes. The thing is, different people are going to hit different roadblocks. You'll get people who need hand-holding through git, people who struggle with C++, etc etc. It'd be nice to cater for them, but there are other avenues open to them. Focus on the LO-specific stuff. After that, try and explain the background as to how writer, calc, etc work internally - give people an overview so they can program easier. Cheers, Wol ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
New Defects reported by Coverity Scan for LibreOffice
Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
1 new defect(s) introduced to LibreOffice found with Coverity Scan.
17 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)
** CID 1328719: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC)
/qadevOOo/tests/java/ifc/util/_XModifyBroadcaster.java: 45 in ()
*** CID 1328719: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC)
/qadevOOo/tests/java/ifc/util/_XModifyBroadcaster.java: 45 in ()
39 * Test is NOT multithread compliant.
40 * @see com.sun.star.util.XModifyBroadcaster
41 */
42 public class _XModifyBroadcaster extends MultiMethodTest {
43 public XModifyBroadcaster oObj = null;
44
>>> CID 1328719: FindBugs: Performance (FB.SIC_INNER_SHOULD_BE_STATIC)
>>> Should ifc.util._XModifyBroadcaster$TestModifyListener be a _static_
>>> inner class?
45 protected class TestModifyListener implements XModifyListener {
46 public void disposing ( EventObject oEvent ) {}
47 public void modified (EventObject aEvent ) {}
48 }
49
50 private final TestModifyListener listener = new TestModifyListener();
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
To manage Coverity Scan email notifications for
"libreoffice@lists.freedesktop.org", click
https://scan.coverity.com/subscriptions/edit?email=libreoffice%40lists.freedesktop.org&token=d6481d718a775246b2340f282ebe5939
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
lessons learned from hackfests
Hello, during the next libreitalia conference we are going to host a 4 hours development session. The plan is to help more people getting started hacking on libo. Given such a short time frame how is this time better spent from your own experience? What do you think is more important to tackle? helping people getting setting up their machines, explaining libo tools / development, going straight to easy hacks or something else? thanks in advance -- Riccardo Magliocchetti @rmistaken http://menodizero.it ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] core.git: external/python3
external/python3/ExternalPackage_python3.mk |2 -- 1 file changed, 2 deletions(-) New commits: commit c2e4e74138c0a816f6aace4d336c7d8cb611d4fa Author: David Ostrovsky Date: Sun Oct 25 11:17:30 2015 +0100 Python3.5: Remove external dependencies: readline and lzma Change-Id: Ie5cd1c0e186920f3b34d3986aa995a5c3be9c58a diff --git a/external/python3/ExternalPackage_python3.mk b/external/python3/ExternalPackage_python3.mk index e132aab..4f03524 100644 --- a/external/python3/ExternalPackage_python3.mk +++ b/external/python3/ExternalPackage_python3.mk @@ -82,7 +82,6 @@ $(eval $(call gb_ExternalPackage_add_files,python3,$(LIBO_BIN_FOLDER)/python-cor LO_lib/_heapq.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/_json.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/_lsprof.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ - LO_lib/_lzma.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/math.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/mmap.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/_multibytecodec.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ @@ -95,7 +94,6 @@ $(eval $(call gb_ExternalPackage_add_files,python3,$(LIBO_BIN_FOLDER)/python-cor LO_lib/_posixsubprocess.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/pyexpat.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/_random.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ - LO_lib/readline.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/resource.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/select.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ LO_lib/_sha1.cpython-$(PYTHON_VERSION_MAJOR).$(PYTHON_VERSION_MINOR)m.so \ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: configure.ac download.lst external/Module_external.mk external/python3 external/python33 pyuno/source
configure.ac| 11
download.lst|7
external/Module_external.mk |2
external/python3/ExternalPackage_python3.mk | 160 +-
external/python3/ExternalProject_python3.mk |3
external/python3/UnpackedTarball_python3.mk | 12
external/python3/i100492-freebsd.patch.1| 36
external/python3/python-3.3.0-darwin.patch.1| 100 -
external/python3/python-3.3.0-gcc-4.8.patch.1 |7
external/python3/python-3.3.0-msvc-disable.patch.1 | 22
external/python3/python-3.3.0-ssl.patch.1 | 196 --
external/python3/python-3.3.3-aix.patch.1 | 50
external/python3/python-3.3.3-elf-rpath.patch.1 | 13
external/python3/python-3.3.3-py17797.patch.1 | 38
external/python3/python-3.5.0-tcltk.disable.patch | 16
external/python3/python-3.5.tweak.strip.soabi.patch | 12
external/python3/ubsan.patch.0 | 49
external/python33/ExternalPackage_python3.mk| 829 ++
external/python33/ExternalProject_python3.mk| 148 +
external/python33/GeneratedPackage_python3.mk | 18
external/python33/Makefile |7
external/python33/Module_python33.mk| 24
external/python33/README|1
external/python33/UnpackedTarball_python3.mk| 60
external/python33/i100492-freebsd.patch.1 | 80 +
external/python33/python-3.3.0-clang.patch.1| 13
external/python33/python-3.3.0-darwin.patch.1 | 85 +
external/python33/python-3.3.0-gcc-4.8.patch.1 | 15
external/python33/python-3.3.0-i42553.patch.2 | 18
external/python33/python-3.3.0-msvc-disable.patch.1 | 47
external/python33/python-3.3.0-msvc-x64.patch.1 | 289 +++
external/python33/python-3.3.0-msvc2012.patch.1 | 72
external/python33/python-3.3.0-pythreadstate.patch.1| 15
external/python33/python-3.3.0-ssl.patch.1 | 208 ++
external/python33/python-3.3.3-aix.patch.1 | 145 +
external/python33/python-3.3.3-disable-obmalloc.patch.0 | 21
external/python33/python-3.3.3-elf-rpath.patch.1| 13
external/python33/python-3.3.3-msvc2012-winxp.patch.1 | 117 +
external/python33/python-3.3.3-py17797.patch.1 | 45
external/python33/python-3.3.5-darwin-gnu-xargs.patch.1 | 12
external/python33/python-3.3.5-pyexpat-symbols.patch.1 | 28
external/python33/python-3.3.5-vs2013.patch.1 | 14
external/python33/python-lsan.patch.0 | 19
external/python33/python-msvc-disable-sse2.patch.1 | 23
external/python33/python-vc2013.patch.1 | 1213
external/python33/ubsan.patch.0 | 79 +
pyuno/source/module/pyuno.cxx |4
47 files changed, 3985 insertions(+), 411 deletions(-)
New commits:
commit 147cb6a2ae63debed3dd500e19b2776cebbc0031
Author: David Ostrovsky
Date: Sun Jul 26 21:38:38 2015 +0200
Bump python to 3.5
3.5 release is needed for MSVC 14.0 (aka VS 2015) support. Python 3.5
removed build toolchain support for MSVC 2013. Because we still need
to support it, we duplicate the Python directory in externals and
copy old patches and dispatch to this directory for MSVC 2013. Once
the support for MSVC 2013 is dropped on master, this directory can be
removed again.
Change-Id: Idf7bc351239582f583ecbdb53c923cbdcf968089
Reviewed-on: https://gerrit.libreoffice.org/17352
Reviewed-by: Michael Stahl
Tested-by: Michael Stahl
diff --git a/configure.ac b/configure.ac
index cd3b983..7f81a2e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -8055,8 +8055,15 @@ int main(int argc, char **argv) {
internal)
SYSTEM_PYTHON=
PYTHON_VERSION_MAJOR=3
-PYTHON_VERSION_MINOR=3
-PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.5
+# On windows we are supporting two different python versions: 3.3 and 3.5.
+# We msut do it as long as we support MSVC 2013. Python 3.3 can be removed
+# when MSVC 2013 support was dropped.
+if test "$COM" = "MSC" -a $VCVER = 120; then
+PYTHON_VERSION_MINOR=3
+else
+PYTHON_VERSION_MINOR=5
+fi
+PYTHON_VERSION=${PYTHON_VERSION_MAJOR}.${PYTHON_VERSION_MINOR}.0
AC_DEFINE_UNQUOTED([PYTHON_VERSION_STRING], [L"${PYTHON_VERSION}"])
BUILD_TYPE="$BUILD_TYPE PYTHON"
# Embedded Python dies without Home set
diff --git a/download.lst b/download.lst
old mode 100644
new mode 100755
index 62d93da..b1ebb89
--- a/download.lst
+++ b/download.lst
@@ -123,8 +123,15 @@ export PNG_TARBALL := libpng-1.5.18.tar.gz
export POPPLER_MD5SUM := 35c0660065d023365e9854c
