[Libreoffice-commits] core.git: sc/source
sc/source/filter/xml/xmlexprt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 53bf6ef85c09717369074e6fd0f1ae1fbe54405c Author: Miklos VajnaDate: Tue Dec 22 16:00:30 2015 +0100 sc: loplugin:defaultparams Change-Id: Ibd58037fe3cdb52cc4514a6c5ff92399fc302bd8 diff --git a/sc/source/filter/xml/xmlexprt.cxx b/sc/source/filter/xml/xmlexprt.cxx index 3822f76..a3eb865 100644 --- a/sc/source/filter/xml/xmlexprt.cxx +++ b/sc/source/filter/xml/xmlexprt.cxx @@ -1191,7 +1191,7 @@ const SvxFieldData* toXMLPropertyStates( const SvxEscapementItem* pEsc = static_cast(p); -pEsc->QueryValue(aAny, MID_ESC); +pEsc->QueryValue(aAny); rPropStates.push_back(XMLPropertyState(nIndexEsc, aAny)); pEsc->QueryValue(aAny, MID_ESC_HEIGHT); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96671] New: Correctly detect windows 64-bit OS
https://bugs.documentfoundation.org/show_bug.cgi?id=96671 Bug ID: 96671 Summary: Correctly detect windows 64-bit OS Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: philip...@hotmail.com CC: michael.me...@collabora.com Steps: 1) Open a 32-bit version of LO on a windows 64-bit OS 2) Open the about dialog screenshot - attachment 121497 Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 2; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: en-US (en_US) In order to correctly determine if its 64-bit, the registry key BuildLabEx needs to be examined from HKEY_LOCAL_MACHINE\Software\Microsoft\Windows NT\CurrentVersion. If it has amd64 in it (e.g. 7601.18717.amd64fre.win7sp1_gdr.150113-1808) it is a 64-bit system and if it has x86 in it (e.g. 6001.17387.x86fre.vistasp1_gdr.070927-1921) its a 32-bit system. It might be useful to also grab EditionID (e.g. 'Professional') and/or CSDVersion (e.g. 'Service Pack 1') to include it as part of the 'OS Version' string. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96670] LibreOffice logo missing from About dialog
https://bugs.documentfoundation.org/show_bug.cgi?id=96670 Miklos Vajnachanged: What|Removed |Added CC||noelgran...@gmail.com --- Comment #1 from Miklos Vajna --- Adding Cc: to Noel Grandin, he said on IRC that he's aware of this and he suspects it's caused by his uno sequence -> std vector changes in the drawinglayer. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55529] .doc and .docx triggers X process 100% CPU usage
https://bugs.documentfoundation.org/show_bug.cgi?id=55529 Germano Massullochanged: What|Removed |Added Version|unspecified |5.0.3.2 release --- Comment #8 from Germano Massullo --- (In reply to QA Administrators from comment #6) > > Please DO NOT > > Update the version field I updated it because previously was setted as "unspecified" -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 55529] .doc and .docx triggers X process 100% CPU usage
https://bugs.documentfoundation.org/show_bug.cgi?id=55529 --- Comment #7 from Germano Massullo--- Can reproduce the bug with "File one" attachment: soffice.bin goes to 100% CPU usage libreoffice-writer-5.0.3.2-12.fc23.x86_64 Fedora 23 64bit -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96581] Some of the text disappears on a high resolution window
https://bugs.documentfoundation.org/show_bug.cgi?id=96581 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Beluga --- Is it the same, if you launch it with SAL_USE_VCLPLUGIN=gtk soffice -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/text/EnhancedPDFExportHelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0ac742298f61d24af4ceb26ea99cb3cfef1570b1 Author: Stephan BergmannDate: Tue Dec 22 15:58:44 2015 +0100 loplugin:simplifybool Change-Id: I0d15e52100e154bb3681e0092ee663ceeef61f9d diff --git a/sw/source/core/text/EnhancedPDFExportHelper.cxx b/sw/source/core/text/EnhancedPDFExportHelper.cxx index 00b544b..5ae9240 100644 --- a/sw/source/core/text/EnhancedPDFExportHelper.cxx +++ b/sw/source/core/text/EnhancedPDFExportHelper.cxx @@ -1748,7 +1748,7 @@ void SwEnhancedPDFExportHelper::EnhancedPDFExport() static_cast( mrSh.GetLayout()->Lower() ); OUString aURL( static_cast(pItem)->GetURL() ); -const bool bIntern = !aURL.isEmpty() ? '#' == aURL[0] : false; +const bool bIntern = !aURL.isEmpty() && '#' == aURL[0]; // Create the destination for internal links: sal_Int32 nDestId = -1; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96215] LibreOffice hangs/won't start if some mounted shares are inaccessible
https://bugs.documentfoundation.org/show_bug.cgi?id=96215 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #2 from Beluga --- https://en.wikipedia.org/wiki/Kerberos_%28protocol%29 Liam: are you also using Kerberos? Or maybe this has the same root cause as bug 41987? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 87013] LO performance when network drive is mounted over slow link
https://bugs.documentfoundation.org/show_bug.cgi?id=87013 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #22 from Beluga --- Same as or different from bug 81640? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96584] UI Conditional Formatting: icon resizing when changes row height
https://bugs.documentfoundation.org/show_bug.cgi?id=96584 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga --- Please attach example file. Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the document. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96647] i18n: Please add Interlingue [ie]
https://bugs.documentfoundation.org/show_bug.cgi?id=96647 Hiddenchanged: What|Removed |Added Assignee|libreoffice-b...@lists.free |er...@redhat.com |desktop.org | Summary|Please add Interlingue [ie] |i18n: Please add ||Interlingue [ie] -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96593] Duplex printing OK but not for multiple copies!
https://bugs.documentfoundation.org/show_bug.cgi?id=96593 Belugachanged: What|Removed |Added Keywords||regression CC||todven...@suomi24.fi --- Comment #1 from Beluga --- Have you tested how it behaves with LibreOffice 5.x? https://wiki.documentfoundation.org/Installing_in_parallel/Linux Brother is known to be problematic, lots of different bug reports. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96674] drawingML import: fully vertical lines are imported as horizontal ones
https://bugs.documentfoundation.org/show_bug.cgi?id=96674 --- Comment #1 from Miklos Vajna--- Created attachment 121506 --> https://bugs.documentfoundation.org/attachment.cgi?id=121506=edit How it looks like currently -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96674] drawingML import: fully vertical lines are imported as horizontal ones
https://bugs.documentfoundation.org/show_bug.cgi?id=96674 --- Comment #2 from Miklos Vajna--- Created attachment 121507 --> https://bugs.documentfoundation.org/attachment.cgi?id=121507=edit How it should look like -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96629] FILESAVE: equations change positioning after saving and opening particular DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=96629 --- Comment #5 from MM--- Notice that if you anchor it 'To Page' or 'To Paragraph', on the RT it *also* gets set 'As Character'. So it's not only 'To Character' that's wrong here. And it doesn't only affect the normal docx, but also OOXML. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: reportdesign/source
reportdesign/source/ui/dlg/Navigator.cxx |6 ++ reportdesign/source/ui/inc/Navigator.hxx |1 + 2 files changed, 7 insertions(+) New commits: commit a0839a85e0f1b9a60a49c12359e8e56e813e0bc6 Author: Maxim MonastirskyDate: Tue Dec 22 21:57:35 2015 +0200 Fix VclPtr issue in rptui::ONavigator Window ( 7VclVBox()) with live children destroyed: N5rptui13NavigatorTreeE() Change-Id: I974f73afd7dd259135d9bfcd47dd6bc8e7cc0d40 diff --git a/reportdesign/source/ui/dlg/Navigator.cxx b/reportdesign/source/ui/dlg/Navigator.cxx index 1d757c7..b5e3335 100644 --- a/reportdesign/source/ui/dlg/Navigator.cxx +++ b/reportdesign/source/ui/dlg/Navigator.cxx @@ -911,6 +911,12 @@ void ONavigator::GetFocus() m_pImpl->m_pNavigatorTree->GrabFocus(); } +void ONavigator::dispose() +{ +m_pImpl->m_pNavigatorTree.disposeAndClear(); +FloatingWindow::dispose(); +} + } // rptui diff --git a/reportdesign/source/ui/inc/Navigator.hxx b/reportdesign/source/ui/inc/Navigator.hxx index ef31fa2..29f6e28 100644 --- a/reportdesign/source/ui/inc/Navigator.hxx +++ b/reportdesign/source/ui/inc/Navigator.hxx @@ -38,6 +38,7 @@ namespace rptui // window virtual void GetFocus() override; +virtual void dispose() override; }; } // namespace rptui ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 82396] Sidebar: Incorrect behavior regarding real-time update of values in "Position and Size"
https://bugs.documentfoundation.org/show_bug.cgi?id=82396 --- Comment #7 from Jérôme Borme--- Created attachment 121503 --> https://bugs.documentfoundation.org/attachment.cgi?id=121503=edit strace for the crash After compiling with debug info activated I could get this warning on the console before it crashed: warn:vcl:24775:1:vcl/unx/x11/xlimits.cxx:23: overlarge pixmap: 34772 x 34771 Complete strace attached. Corresponds to the following: 1. open any existing document that contains an image 2. in the sidebar, change size to 1 cm 3. wait 1-2 seconds. It then crashes. (I could not get useful backtraces yet.) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96519] bad file chooser without kde integration installed, bad taskbar icons with it installed
https://bugs.documentfoundation.org/show_bug.cgi?id=96519 --- Comment #6 from Maxim Monastirsky--- (In reply to JPJ from comment #5) > I'm not sure this is a KDE bug or a duplicate because I don't have this > issue in LibreOffice 5.0.x. Upstream builds before 5.1 didn't have KDE4 integration (the *-kde-integration package *was* for KDE3), that's why you didn't see it before. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89236] FILESAVE Error opening password protected calc files
https://bugs.documentfoundation.org/show_bug.cgi?id=89236 raalchanged: What|Removed |Added Keywords||bibisected, bisected CC||ma...@libreoffice.org, ||r...@post.cz OS|Windows (All) |All --- Comment #19 from raal --- This seems to have begun at the below commit. Adding Cc: to Matúš Kukan ; Could you possibly take a look at this one? Thanks b89a610ba4db766795068aa7f5c93adc4e78eaeb is the first bad commit commit b89a610ba4db766795068aa7f5c93adc4e78eaeb Author: Matthew Francis Date: Sun Mar 15 05:57:15 2015 +0800 source-hash-fbf714b45625c50bb1c736ef231b5dbbab0016a1 commit fbf714b45625c50bb1c736ef231b5dbbab0016a1 Author: Matúš Kukan AuthorDate: Tue Oct 21 15:17:13 2014 +0200 Commit: Matúš Kukan CommitDate: Mon Nov 17 10:49:23 2014 +0100 package: Finally implement parallel zip entries deflating For that: 1, create ZipPackageStream::successfullyWritten to be called after the content is written 2, Do not take mutex when reading from WrapStreamForShare - threads should be using different streams anyway, but there is only one common mutex. :-/ Change-Id: I90303e49206b19454dd4141e24cc8be29c433045 :04 04 67383437fb16f4a24d936859ff4cdfa3a577ab76 9106ff29b6ddb6c66d9e2b516896e74c912cd27a Mopt bibisect-44max$ git bisect log # bad: [cf6ea17155fabb2a120ba07c150735591ac861d7] source-hash-3f94c9e9ddfd807b449f3bb9b232cf2041fa12d2 # good: [fc71ac001f16209654d15ef8c1c4018aa55769f5] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e git bisect start 'latest' 'oldest' # good: [8cf60cc706948588e2f33a6d98b7c55d454e362a] source-hash-f340f0454627939f1830826fb5cc53a90e6c62a4 git bisect good 8cf60cc706948588e2f33a6d98b7c55d454e362a # good: [7beddf3808dadd525d7e55c00a5a90a2b44c23d3] source-hash-2f10386ce577f52e139aa23d41bc787d8e0b4d59 git bisect good 7beddf3808dadd525d7e55c00a5a90a2b44c23d3 # good: [fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676] source-hash-0516d123f53917d1833c7e8a8c528a619c71a0af git bisect good fb3ec529b3f37f0c7eab2e9b7a9cc695c0f27676 # good: [47a64818ddfe63bbb8e6448fcc476f55996d61b1] source-hash-d12efada389643ab0e13a280246d14caed273029 git bisect good 47a64818ddfe63bbb8e6448fcc476f55996d61b1 # bad: [8f2027699192b7f2aaf83f95a02c817f2e0c8d50] source-hash-eb6d27321d2d5f9d069c4a3cbcc9bc6e5b4c98ab git bisect bad 8f2027699192b7f2aaf83f95a02c817f2e0c8d50 # good: [5705bc95b469b4b7696309fba80ea590cabe8ff1] source-hash-90742105a5d95d175a89b5a253584fa1676ab02a git bisect good 5705bc95b469b4b7696309fba80ea590cabe8ff1 # good: [6022bfdffd46392ccd506f679d9b6605005c8b49] source-hash-a6e2e54c7e9ec5b852db3b3be578d79fda01 git bisect good 6022bfdffd46392ccd506f679d9b6605005c8b49 # bad: [d06fd023188b2424a4954f522299ca5449bd7a64] source-hash-a42aa52acbbff738a00299de172ca85cb001d840 git bisect bad d06fd023188b2424a4954f522299ca5449bd7a64 # good: [220693b7b9b63600d402b3abe4862748b0b3ec2b] source-hash-e186db5257956a88ed5ed7a9db1867b44324252d git bisect good 220693b7b9b63600d402b3abe4862748b0b3ec2b # good: [e5388f18f8d7fd2d731a3f3ee8244065710f3395] source-hash-ad91cfdcf256f5af159f2f18d3b83f17b91849dc git bisect good e5388f18f8d7fd2d731a3f3ee8244065710f3395 # good: [99a6ccca1ee95f2561bc0085f3ce9d33bfa48672] source-hash-3e3b8483d7866e96bc75ddda283416c6829714af git bisect good 99a6ccca1ee95f2561bc0085f3ce9d33bfa48672 # good: [24db9952a5ed70772216b87b1a8d199f910881cc] source-hash-30f80f12fb1db4c9c6f19fcfda4e796891b6e03c git bisect good 24db9952a5ed70772216b87b1a8d199f910881cc # bad: [b89a610ba4db766795068aa7f5c93adc4e78eaeb] source-hash-fbf714b45625c50bb1c736ef231b5dbbab0016a1 git bisect bad b89a610ba4db766795068aa7f5c93adc4e78eaeb # good: [32815bb3ab0a9dd2b4c2b7e800103d4c1537b7a1] source-hash-db5552631b13e5a1d330929cd5093bd0f9894ec8 git bisect good 32815bb3ab0a9dd2b4c2b7e800103d4c1537b7a1 # first bad commit: [b89a610ba4db766795068aa7f5c93adc4e78eaeb] source-hash-fbf714b45625c50bb1c736ef231b5dbbab0016a1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96616] FILESAVE: Generatin a report as "Microsoft Word 2007-2013 XML" creates .odt with .docx extension
https://bugs.documentfoundation.org/show_bug.cgi?id=96616 Sparrowbechanged: What|Removed |Added Status|NEEDINFO|UNCONFIRMED Ever confirmed|1 |0 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96616] FILESAVE: Generatin a report as "Microsoft Word 2007-2013 XML" creates .odt with .docx extension
https://bugs.documentfoundation.org/show_bug.cgi?id=96616 --- Comment #2 from Sparrowbe--- Created attachment 121504 --> https://bugs.documentfoundation.org/attachment.cgi?id=121504=edit a database and created reports Thank you for fast response. Here are some files that may give a better view of the problem: a very small database with one table and simple report generator plus three report files (one created as "ODF text document", second as "Microsoft Word 2007-2013" and the last one as "Microsoft Word 97-2003") - all of them with the same content but different extension given by the LO itself. Thanks, Tom -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: sw/source
sw/source/core/attr/format.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 9f87ccc854885ed4ee65e6e278b735ea051a027a Author: Stephan BergmannDate: Tue Dec 22 20:50:17 2015 +0100 Avoid bad downcast during destruction ...as reported by UBSan in CppunitTest_sw_filters_test: > /sw/inc/format.hxx:110:73: runtime error: downcast of address 0x2af2d8024000 which does not point to an object of type 'const SwFormat' > 0x2af2d8024000: note: object is of type 'SwModify' > f2 2a 00 00 70 33 2f 87 f2 2a 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~ > vptr for 'SwModify' > #0 0x2af27bbe8083 in SwFormat::DerivedFrom() const /sw/inc/format.hxx:110:73 > #1 0x2af27bbc8401 in SwFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/format.cxx:282:21 > #2 0x2af27e9934a3 in SwFrameFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/layout/atrfrm.cxx:2597:5 > #3 0x2af27f8207d5 in SwTableBoxFormat::Modify(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/table/swtable.cxx:2353:5 > #4 0x2af27bb9cd52 in SwClient::SwClientNotify(SwModify const&, SfxHint const&) /sw/source/core/attr/calbck.cxx:68:9 > #5 0x2af27bba4bee in SwModify::CallSwClientNotify(SfxHint const&) const /sw/inc/calbck.hxx:349:9 > #6 0x2af27bba290b in SwModify::ModifyBroadcast(SfxPoolItem const*, SfxPoolItem const*) /sw/inc/calbck.hxx:173:11 > #7 0x2af27bb9fbc0 in SwModify::NotifyClients(SfxPoolItem const*, SfxPoolItem const*) /sw/source/core/attr/calbck.cxx:143:5 > #8 0x2af27bb9e0e7 in SwModify::~SwModify() /sw/source/core/attr/calbck.cxx:101:5 > #9 0x2af27bbc6bb4 in SwFormat::~SwFormat() /sw/source/core/attr/format.cxx:251:1 > #10 0x2af27e98fdf3 in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2534:1 > #11 0x2af27e9900af in SwFrameFormat::~SwFrameFormat() /sw/source/core/layout/atrfrm.cxx:2525:1 > #12 0x2af27cb1646e in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:592:5 > #13 0x2af27cb1993f in SwDoc::~SwDoc() /sw/source/core/doc/docnew.cxx:385:1 > #14 0x2af282d45bb0 in SwDocShell::RemoveLink() /sw/source/uibase/app/docshini.cxx:472:13 > #15 0x2af282d43596 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:394:5 > #16 0x2af282d45f46 in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:384:1 > #17 0x2af282d4637f in SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:384:1 > #18 0x2af282d464c6 in virtual thunk to SwDocShell::~SwDocShell() /sw/source/uibase/app/docshini.cxx:383:13 > #19 0x2af27420aade in SvRefBase::ReleaseRef() /include/tools/ref.hxx:138:29 > #20 0x2af27420195a in tools::SvRef::~SvRef() /include/tools/ref.hxx:49:30 > #21 0x2af2741f6663 in SwFiltersTest::filter(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /sw/qa/core/filters-test.cxx:130:1 > #22 0x2af2741f368e in SwFiltersTest::load(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int) /sw/qa/core/filters-test.cxx:69:12 > #23 0x2af29a05d1fb in test::FiltersTest::recursiveScan(test::filterStatus, rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:129:20 > #24 0x2af29a060741 in test::FiltersTest::testDir(rtl::OUString const&, rtl::OUString const&, rtl::OUString const&, SfxFilterFlags, SotClipboardFormatId, unsigned int, bool) /unotest/source/cpp/filters-test.cxx:154:5 > #25 0x2af2741fa8fa in SwFiltersTest::testCVEs() /sw/qa/core/filters-test.cxx:174:5 > #26 0x2af27421631d in CppUnit::TestCaller::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:166:6 > #27 0x2af23644866d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #28 0x2af24e66d0d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:57:14 > #29 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #30 0x2af2458a1926 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:88:12 > #31 0x2af236403bb7 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #32
[Libreoffice-commits] core.git: include/svx sc/source sd/source svx/source sw/source
include/svx/svdobj.hxx |2 -- include/svx/svdoole2.hxx |3 +-- include/svx/svdxcgv.hxx |3 +-- include/svx/view3d.hxx |3 +-- sc/source/ui/app/drwtrans.cxx|2 +- sc/source/ui/view/viewfun7.cxx |2 +- sd/source/core/drawdoc3.cxx |2 +- sd/source/ui/inc/View.hxx|3 +-- sd/source/ui/view/sdview2.cxx|5 ++--- sd/source/ui/view/sdview3.cxx| 10 +- svx/source/engine3d/view3d.cxx |5 ++--- svx/source/svdraw/svdobj.cxx |5 - svx/source/svdraw/svdoole2.cxx | 21 +++-- svx/source/svdraw/svdxcgv.cxx|5 ++--- sw/source/core/frmedt/fecopy.cxx |2 +- sw/source/core/ole/ndole.cxx |4 ++-- 16 files changed, 24 insertions(+), 53 deletions(-) New commits: commit 0f02bc189b6e89ca2e62d4bd6a2f407a9fd4ec3b Author: Caolán McNamaraDate: Mon Dec 21 21:16:08 2015 + crashtesting: CreateShellID returns the mediums base url... when it works the way we want it to work, so presumably we can cut out the middle man and use getDocumentBaseURL directly which does the same thing. This has the advantage of being in the IEmbeddedHelper api so assignFrom can be tweaked to pull the src and dest ids arguments to CopyAndGetEmbeddedObject from the src and dest IEmbeddedHelpers always available there. So we ensure we have some ids to present to CopyAndGetEmbeddedObject, avoiding the assert on converting documents such as ooo89433-1.ppt to pdf So the explicit args can apparently be dropped, bubbling up then means we don't need a CloneWithShellIDs (introduced with tdf#71076 and tdf#71767) as normal Clone should now do the right thing. And various other arguments in various callers of these, which are typically filled in with an unhelpful empty OUString placeholder, can go Change-Id: I9c0be0340e72f98b10ee87ada7d2a021fcc39e23 diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx index a76cb71..8ce2fd7 100644 --- a/include/svx/svdobj.hxx +++ b/include/svx/svdobj.hxx @@ -530,8 +530,6 @@ public: // Note that this function uses operator= internally. virtual SdrObject* Clone() const; -virtual SdrObject* CloneWithShellIDs( const OUString& rSrcShellID, const OUString& rDestShellID ) const; - // implemented mainly for the purposes of Clone() SdrObject& operator=(const SdrObject& rObj); diff --git a/include/svx/svdoole2.hxx b/include/svx/svdoole2.hxx index 2d0b49d..0db2563 100644 --- a/include/svx/svdoole2.hxx +++ b/include/svx/svdoole2.hxx @@ -128,9 +128,8 @@ public: virtual OUString TakeObjNamePlural() const override; virtual SdrOle2Obj* Clone() const override; -virtual SdrOle2Obj* CloneWithShellIDs( const OUString& rSrcShellID, const OUString& rDestShellID ) const override; -SdrOle2Obj& assignFrom( const SdrOle2Obj& rObj, const OUString& rSrcShellID, const OUString& rDestShellID ); +SdrOle2Obj& assignFrom(const SdrOle2Obj& rObj); SdrOle2Obj& operator=(const SdrOle2Obj& rObj); virtual void NbcMove(const Size& rSize) override; diff --git a/include/svx/svdxcgv.hxx b/include/svx/svdxcgv.hxx index 2faccca..0ad977b 100644 --- a/include/svx/svdxcgv.hxx +++ b/include/svx/svdxcgv.hxx @@ -107,8 +107,7 @@ public: // Valid values for nOptions are SDRINSERT_DONTMARK and SDRINSERT_ADDMARK // (@see svdedtv.hxx). virtual bool Paste( -const SdrModel& rMod, const Point& rPos, SdrObjList* pLst, SdrInsertFlags nOptions, -const OUString& rSrcShellID, const OUString& rDestShellID ); +const SdrModel& rMod, const Point& rPos, SdrObjList* pLst, SdrInsertFlags nOptions); boolPaste(const OUString& rStr, const Point& rPos, SdrObjList* pLst=nullptr, SdrInsertFlags nOptions=SdrInsertFlags::NONE); boolPaste(SvStream& rInput, const OUString& rBaseURL, sal_uInt16 eFormat, const Point& rPos, SdrObjList* pLst=nullptr, SdrInsertFlags nOptions=SdrInsertFlags::NONE); diff --git a/include/svx/view3d.hxx b/include/svx/view3d.hxx index 63da660..2f2fe08 100644 --- a/include/svx/view3d.hxx +++ b/include/svx/view3d.hxx @@ -98,8 +98,7 @@ public: // On Paste: We need to insert the objects of the Scene, but not the Scene itself using SdrView::Paste; virtual bool Paste( -const SdrModel& rMod, const Point& rPos, SdrObjList* pLst, SdrInsertFlags nOptions, -const OUString& rSrcShellID, const OUString& rDestShellID ) override; +const SdrModel& rMod, const Point& rPos, SdrObjList* pLst, SdrInsertFlags nOptions) override; // #83403# Service routine used from local Clone() and from SdrCreateView::EndCreateObj(...) bool ImpCloneAll3DObjectsToDestScene(E3dScene* pSrcScene, E3dScene* pDstScene, Point aOffset); diff --git a/sc/source/ui/app/drwtrans.cxx b/sc/source/ui/app/drwtrans.cxx index a257bc5..56b33d1 100644 ---
[Libreoffice-bugs] [Bug 96528] [ANIMATION] Animation Stretchy in does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=96528 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #2 from Beluga --- Same result as with bug 96526. 5.0.4 works, 5.2 doesn't. OpenGL doesn't affect 5.0.4. Win 7 Pro 64-bit, Version: 5.0.4.2 (x64) Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Locale: fi-FI (fi_FI) Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96590] UI: after saving file, save icon is not greyed out
https://bugs.documentfoundation.org/show_bug.cgi?id=96590 rob...@familiegrosskopf.de changed: What|Removed |Added CC||rob...@familiegrosskopf.de OS|Windows (All) |All --- Comment #9 from rob...@familiegrosskopf.de --- Don't know why this one is set to "Wontfix". The normal behavior in every program is to set only one function to the save button - no submenue. And the normal behavior is to grey this button out to show the user: The content of this document has been saved. Why isn't there a submenue set to the button "Save As", which would be never greyed out, because this function would make sense more than one time. OK, you could change this per expert config. For non-experts the normal way would be: Never install LO 5.1, because the non-expert wouldn't see any more if the content has been saved. Don't say: There is a little sign in the bottom of your Writer-window, which shows with a very little star: This document has been changed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: lotuswordpro/source
lotuswordpro/source/filter/lwpfribtable.cxx | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit 8a05b74eeb8d5e0955fbe3cefd945cdc9bffa3f5 Author: Caolán McNamaraDate: Tue Dec 22 20:09:17 2015 + guard against missing ContentContainer Change-Id: I4f2c5d53148deb02d990edc42140c23f02409cea diff --git a/lotuswordpro/source/filter/lwpfribtable.cxx b/lotuswordpro/source/filter/lwpfribtable.cxx index e76c25d..d14ea31 100644 --- a/lotuswordpro/source/filter/lwpfribtable.cxx +++ b/lotuswordpro/source/filter/lwpfribtable.cxx @@ -111,7 +111,7 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) pXFContentContainer = m_pPara->GetXFContainer(); //delete the additional blank para XFParagraph* pCurrPara = m_pPara->GetFribs().GetXFPara(); -if(!pCurrPara->HasContents()) +if (pXFContentContainer && !pCurrPara->HasContents()) { if(pXFContentContainer->GetLastContent() == pCurrPara) { @@ -142,18 +142,20 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) LwpGlobalMgr* pGlobal = LwpGlobalMgr::GetInstance(); LwpChangeMgr* pChangeMgr = pGlobal->GetLwpChangeMgr(); sChangeID = pChangeMgr->GetChangeID(this); -if (!sChangeID.isEmpty()) +if (!sChangeID.isEmpty() && pXFContentContainer) { XFChangeStart* pChangeStart = new XFChangeStart; pChangeStart->SetChangeID(sChangeID); pXFContentContainer->Add(pChangeStart); } } -pSuper->XFConvert(pXFContentContainer); + +if (pXFContentContainer) +pSuper->XFConvert(pXFContentContainer); if(m_bRevisionFlag) { -if (!sChangeID.isEmpty()) +if (!sChangeID.isEmpty() && pXFContentContainer) { XFChangeEnd* pChangeEnd = new XFChangeEnd; pChangeEnd->SetChangeID(sChangeID); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96521] [ANIMATION] Animation "Put on the Brakes" hangs presentation
https://bugs.documentfoundation.org/show_bug.cgi?id=96521 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #2 from Beluga --- Not reproduced. What operating system are you using? OpenGL setting? Same with 5.0.4? Win 7 Pro 64-bit, Version: 5.0.4.2 (x64) Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Locale: fi-FI (fi_FI) Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 88241] Sidebar: Undocked sidebar opened by call to Styles and Formatting is not dismissed with another call
https://bugs.documentfoundation.org/show_bug.cgi?id=88241 --- Comment #8 from tmacalp--- (In reply to Harald Koester from comment #7) > I checked the behaviour with version 5.0.3. To my opinion the bug still > exists when using F11. It works for me when the menu item "Styles and > Formating" is used. I guess it depends on what behavior you expect. F11 has always been associated with showing/hiding the "styles and formatting" dialog. As far as I can tell, it does exactly what it is supposed to do if you define the behavior as show/hide the styles and formatting dialog. When the sidebar is on another pane, F11 will switch to the styles and formatting pane. What you seem to be describing is pretty much the change to map it instead to enable/disable sidebar. You can actually make this change already by Tools->Customize->Keyboard and binding View->Sidebar to F11. Of course, what you've described is a combination of the above behaviors? You want F11 to always dismiss the sidebar, but always spawn it up opened to Styles and Formatting? > What is the right action in this case if the bug has not been verified: Set > status to REOPENED according lifecycle diagram [2] or writing a new bug > report according ([1], How to reopen Bugs)? > > [1] https://wiki.documentfoundation.org/QA/BSA/BugReport_Details > [2] https://wiki.documentfoundation.org/File:BzLifecycleold.png If you still feel this is worthy of reporting, I would open a new report. You can then link to this one with a "see also." Again, as I understand it, this is not a bug, but a change in behavior, so it'd probably be labelled as an enhancement request. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96674] New: drawingML import: fully vertical lines are imported as horizontal ones
https://bugs.documentfoundation.org/show_bug.cgi?id=96674 Bug ID: 96674 Summary: drawingML import: fully vertical lines are imported as horizontal ones Product: LibreOffice Version: 5.1.0.0.alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vmik...@collabora.co.uk Created attachment 121505 --> https://bugs.documentfoundation.org/attachment.cgi?id=121505=edit Reproducer document See the attached bugdoc, the vertical line is imported as a horizontal one. This worked in 4.2, as there the VML filter handles the zero-width/zero-height line special case, but since 4.3 we read the drawingML branch, which lacks support for this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96519] bad file chooser without kde integration installed, bad taskbar icons with it installed
https://bugs.documentfoundation.org/show_bug.cgi?id=96519 --- Comment #5 from JPJ--- I'm not sure this is a KDE bug or a duplicate because I don't have this issue in LibreOffice 5.0.x. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96526] [ANIMATION] Animation Swivel in does not work
https://bugs.documentfoundation.org/show_bug.cgi?id=96526 Belugachanged: What|Removed |Added CC||todven...@suomi24.fi --- Comment #1 from Beluga --- It works for me in 5.0.4, but not in 5.2. Maybe it is because it is an OpenGL effect (?) and I am unable to use OGL in 5.1 or 5.2. Waiting for further information on your system. Win 7 Pro 64-bit, Version: 5.0.4.2 (x64) Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Locale: fi-FI (fi_FI) Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: fi-FI (fi_FI) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96597] When printing and pdf export cells with formula that have a "" value are still printed and exported
https://bugs.documentfoundation.org/show_bug.cgi?id=96597 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||todven...@suomi24.fi Ever confirmed|0 |1 --- Comment #1 from Beluga --- Could you attach an example file (perhaps a reduced version of your monthly sheet)? Set to NEEDINFO. Change back to UNCONFIRMED after you have provided the document. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: jurt/com
jurt/com/sun/star/lib/uno/protocols/urp/urp.java |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 7653682c35eca35415aa0131c3df4a3d104d8c5d Author: Caolán McNamaraDate: Tue Dec 22 20:30:34 2015 + coverity#1326730 DMI: Dubious method invocation Change-Id: Icf44c82fc485d0172df2a9fb2cbe6b2be61630a1 diff --git a/jurt/com/sun/star/lib/uno/protocols/urp/urp.java b/jurt/com/sun/star/lib/uno/protocols/urp/urp.java index b527e64..5e7b328 100644 --- a/jurt/com/sun/star/lib/uno/protocols/urp/urp.java +++ b/jurt/com/sun/star/lib/uno/protocols/urp/urp.java @@ -199,7 +199,7 @@ public final class urp implements IProtocol { if (propertiesTid == null) { propertiesTid = ThreadId.createFresh(); } -random = new Random().nextInt(); +random = randomGenerator.nextInt(); writeRequest( true, PROPERTIES_OID, TypeDescription.getTypeDescription(XProtocolProperties.class), @@ -723,6 +723,8 @@ public final class urp implements IProtocol { private static final int MAX_RELEASE_QUEUE_SIZE = 100; +private static final Random randomGenerator = new Random(); + private final DataInput input; private final DataOutputStream output; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96675] New: Writer: Undo insertion of cols or rows crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=96675 Bug ID: 96675 Summary: Writer: Undo insertion of cols or rows crashes LO Product: LibreOffice Version: 5.1.0.1 rc Hardware: x86-64 (AMD64) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: reporter_of_b...@yahoo.com Version: 5.1.0.1 Build ID: bcace328aabc4c8c10b56daa87da0a2ee6579b5a Threads 4; Ver: Linux 4.1; Render: default; Locale: en-NZ (en_NZ.utf8) Steps to recreate: 1. Open a new writer doc 2. create a 2x2 table 3. insert a new row or column 4. undo 5. LO crashes Possibly related to: https://bugs.documentfoundation.org/show_bug.cgi?id=57197 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/PhysicalFontCollection.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit eeabf90ed497d1694b036475e02455b582d07651 Author: Chris SherlockDate: Tue Dec 22 15:41:15 2015 +1100 vcl: make PhysicalFontFamily::InitMatchData private Change-Id: I668012226264ce6986ea81815527d32e40645321 Reviewed-on: https://gerrit.libreoffice.org/20862 Reviewed-by: Chris Sherlock Tested-by: Chris Sherlock diff --git a/vcl/inc/PhysicalFontCollection.hxx b/vcl/inc/PhysicalFontCollection.hxx index e52e752..427660c 100644 --- a/vcl/inc/PhysicalFontCollection.hxx +++ b/vcl/inc/PhysicalFontCollection.hxx @@ -65,8 +65,6 @@ public: PhysicalFontFamily* FindByTokenNames(const OUString& rTokenStr) const; protected: -voidInitMatchData() const; - PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName, const OUString& rShortName) const; PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& ) const; @@ -90,6 +88,8 @@ private: mutable int mnFallbackCount; PhysicalFontFamily* ImplFindBySearchName( const OUString& ) const; + +voidInitMatchData() const; }; #endif // INCLUDED_VCL_INC_PHYSICALFONTCOLLECTION_HXX ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] core.git: unusedcode.easy unusedcode.exclude
unusedcode.easy|1 - unusedcode.exclude |1 + 2 files changed, 1 insertion(+), 1 deletion(-) New commits: commit 27450bc72d88b8490d17cb506f85fb4d838df0ea Author: Juergen FunkDate: Wed Dec 23 00:09:50 2015 +0100 unused code SvpSalFrame::enableDamageTracker(bool) used here http://opengrok.libreoffice.org/xref/core/vcl/android/androidinst.cxx#127 Change-Id: If1b0ff8ef4c585e4b36c4735d7928361fb41b238 Reviewed-on: https://gerrit.libreoffice.org/20885 Reviewed-by: Thorsten Behrens Tested-by: Thorsten Behrens diff --git a/unusedcode.easy b/unusedcode.easy index 988b371..f71ba6d 100644 --- a/unusedcode.easy +++ b/unusedcode.easy @@ -25,7 +25,6 @@ StyleSettings::SetSpinSize(long) StyleSettings::SetTitleHeight(long) StyleSettings::SetUseFlatBorders(bool) StyleSettings::SetUseFlatMenus(bool) -SvpSalFrame::enableDamageTracker(bool) SvpSalInstance::PostedEventsInQueue() SvtAccessibilityOptions::IsModified() const SvtListener::IsListening(SvtBroadcaster&) const diff --git a/unusedcode.exclude b/unusedcode.exclude index 42f2776..d8a8054 100644 --- a/unusedcode.exclude +++ b/unusedcode.exclude @@ -29,4 +29,5 @@ comphelper::detail::ConfigurationWrapper::getLocalizedPropertyValue(rtl::OUStrin comphelper::detail::ConfigurationWrapper::setLocalizedPropertyValue(boost::shared_ptr const&, rtl::OUString const&, com::sun::star::uno::Any const&) const FontCharMap::GetDefaultMap(bool) OutputDevice::LogicToLogic(basegfx::B2DPolyPolygon const&, MapMode const&, MapMode const&) +SvpSalFrame::enableDamageTracker(bool) ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96666] EDITING: Address Function incorrectly resolves when Sheet names is given to #REF
https://bugs.documentfoundation.org/show_bug.cgi?id=9 m.a.riosvchanged: What|Removed |Added CC||miguelangelrv@libreoffice.o ||rg --- Comment #1 from m.a.riosv --- Created attachment 121508 --> https://bugs.documentfoundation.org/attachment.cgi?id=121508=edit Sample test Hi, thanks for reporting. As I see the issue in your formula is that a space is not an empty parameter. Please see the attached file, works for me with 5.0.4.2 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96676] New: EMF+ not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=96676 Bug ID: 96676 Summary: EMF+ not displaying correctly Product: LibreOffice Version: 5.0.2.2 release Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: graphics stack Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: chris.sherloc...@gmail.com In fdo#77229 the EMF+ file with the red triangle and green star is not displaying correctly in LibreOffice. Instead, we get: - With the red triangle: + on the far left side the black line is too thick + the black line is not black, but grey + the red fill should be an intense red, but instead shows as a very light red - the green star does not show at all Test cases will be attached. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96676] EMF+ not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=96676 Chris Sherlockchanged: What|Removed |Added CC||chris.sherloc...@gmail.com --- Comment #1 from Chris Sherlock --- Created attachment 121509 --> https://bugs.documentfoundation.org/attachment.cgi?id=121509=edit EMF with red filled triangle with black lines and green filled star with black lines The EMF from bug 77229. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96676] EMF+ not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=96676 --- Comment #4 from Chris Sherlock--- Created attachment 121512 --> https://bugs.documentfoundation.org/attachment.cgi?id=121512=edit docx file with imported EMF testcase Inserted via Word 2014 on OS X -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96676] EMF+ not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=96676 --- Comment #3 from Chris Sherlock--- Created attachment 121511 --> https://bugs.documentfoundation.org/attachment.cgi?id=121511=edit ODG file with imported EMF testcase -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96675] Writer: Undo insertion of cols or rows crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=96675 Davidchanged: What|Removed |Added Keywords||regression --- Comment #2 from David --- I have experienced this bug on 5.1.0.1 also. Priority should be critical as per Prioritizing Bugs Flowchart, since it is a consistent crash that can cause loss of data. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/inc starmath/source
starmath/inc/cursor.hxx|5 +++-- starmath/source/cursor.cxx | 36 +--- 2 files changed, 12 insertions(+), 29 deletions(-) New commits: commit 4753d78cf93bad974f062d8cfe75b4b610385b7e Author: Takeshi AbeDate: Wed Dec 16 18:02:30 2015 +0900 starmath: Assert that a parent always finds its child Change-Id: I6cb75e0d62141dba2809aaec62761cedd8c3257a Reviewed-on: https://gerrit.libreoffice.org/20733 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/starmath/inc/cursor.hxx b/starmath/inc/cursor.hxx index 9de6b53..6962cf5 100644 --- a/starmath/inc/cursor.hxx +++ b/starmath/inc/cursor.hxx @@ -12,6 +12,7 @@ #include "node.hxx" #include "caret.hxx" +#include #include #include @@ -268,8 +269,8 @@ private: SmNode* pNode = rpNode; if(rpNode && rpNode->GetParent()){//Don't remove this, correctness relies on it int index = rpNode->GetParent()->IndexOfSubNode(rpNode); -if(index != -1) -rpNode->GetParent()->SetSubNode(index, nullptr); +assert(index >= 0); +rpNode->GetParent()->SetSubNode(index, nullptr); } rpNode = nullptr; //Create line from node diff --git a/starmath/source/cursor.cxx b/starmath/source/cursor.cxx index 8efa931..355336c 100644 --- a/starmath/source/cursor.cxx +++ b/starmath/source/cursor.cxx @@ -12,6 +12,7 @@ #include "view.hxx" #include "accessibility.hxx" #include +#include void SmCursor::Move(OutputDevice* pDev, SmMovementDirection direction, bool bMoveAnchor){ SmCaretPosGraphEntry* NewPos = nullptr; @@ -176,6 +177,7 @@ void SmCursor::DeletePrev(OutputDevice* pDev){ SmNode* pLine = FindTopMostNodeInLine(mpPosition->CaretPos.pSelectedNode); SmStructureNode* pLineParent = pLine->GetParent(); int nLineOffset = pLineParent->IndexOfSubNode(pLine); +assert(nLineOffset >= 0); //If we're in front of a node who's parent is a TABLE if(pLineParent->GetType() == NTABLE && mpPosition->CaretPos.Index == 0 && nLineOffset > 0){ @@ -262,11 +264,7 @@ void SmCursor::Delete(){ SmStructureNode* pLineParent = pLine->GetParent(); //Find line offset in parent int nLineOffset = pLineParent->IndexOfSubNode(pLine); -if (nLineOffset == -1) -{ -SAL_WARN("starmath", "pLine must be a child of its parent!"); -return; -} +assert(nLineOffset >= 0); //Position after delete SmCaretPos PosAfterDelete; @@ -304,12 +302,7 @@ void SmCursor::InsertNodes(SmNodeList* pNewNodes){ //Find line parent and line index in parent SmStructureNode* pLineParent = pLine->GetParent(); int nParentIndex = pLineParent->IndexOfSubNode(pLine); -OSL_ENSURE(nParentIndex != -1, "pLine must be a subnode of pLineParent!"); -if (nParentIndex == -1) -{ -delete pNewNodes; -return; -} +assert(nParentIndex >= 0); //Convert line to list SmNodeList* pLineList = NodeToList(pLine); @@ -506,7 +499,7 @@ void SmCursor::InsertSubSup(SmSubSup eSubSup) { //Find Parent and offset in parent SmStructureNode *pLineParent = pLine->GetParent(); int nParentIndex = pLineParent->IndexOfSubNode(pLine); -OSL_ENSURE(nParentIndex != -1, "pLine must be a subnode of pLineParent!"); +assert(nParentIndex >= 0); //TODO: Consider handling special cases where parent is an SmOperNode, // Maybe this method should be able to add limits to an SmOperNode... @@ -677,9 +670,7 @@ void SmCursor::InsertBrackets(SmBracketType eBracketType) { //Find parent and offset in parent SmStructureNode *pLineParent = pLine->GetParent(); int nParentIndex = pLineParent->IndexOfSubNode(pLine); -OSL_ENSURE( nParentIndex != -1, "pLine must be a subnode of pLineParent!"); -if (nParentIndex < 0) -return; +assert(nParentIndex >= 0); //Convert line to list SmNodeList *pLineList = NodeToList(pLine); @@ -814,12 +805,7 @@ bool SmCursor::InsertRow() { //Find parent and offset in parent SmStructureNode *pLineParent = pLine->GetParent(); int nParentIndex = pLineParent->IndexOfSubNode(pLine); - -if (nParentIndex == -1) -{ -SAL_WARN("starmath", "pLine must be a subnode of pLineParent!"); -return false; -} +assert(nParentIndex >= 0); //Discover the context of this command SmTableNode *pTable = nullptr; @@ -834,7 +820,7 @@ bool SmCursor::InsertRow() { //NOTE: This hack might give problems if we stop ignoring SmAlignNode pTable = static_cast (pLineParent->GetParent()); nTableIndex = pTable->IndexOfSubNode(pLineParent); -OSL_ENSURE(nTableIndex != -1, "pLineParent must be a child of its parent!"); +assert(nTableIndex >= 0); } if(pLineParent->GetType() == NMATRIX) pMatrix =
[Libreoffice-commits] core.git: starmath/source
starmath/source/visitors.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 7ecfdc8b97543fd50ee037632454b3c51e33e4bf Author: Takeshi AbeDate: Tue Dec 22 17:11:25 2015 +0900 starmath: Avoid warning C4819 Change-Id: I051b2058e7c7f0424faf49f027330b1bbc93c2d9 Reviewed-on: https://gerrit.libreoffice.org/20869 Reviewed-by: Kohei Yoshida Tested-by: Kohei Yoshida diff --git a/starmath/source/visitors.cxx b/starmath/source/visitors.cxx index 2d45b23..8612dc5 100644 --- a/starmath/source/visitors.cxx +++ b/starmath/source/visitors.cxx @@ -1319,7 +1319,7 @@ void SmCaretPosGraphBuildingVisitor::Visit( SmFontNode* pNode ) * n6 -> n7 [label="0"]; * n7 [label="SmTextNode: i"]; * n5 -> n8 [label="1"]; - * n8 [label="SmMathSymbolNode: â£"]; + * n8 [label="SmMathSymbolNode: "]; // Unicode "VERTICAL LINE" * n5 -> n9 [label="2"]; * n9 [label="SmExpressionNode"]; * n9 -> n10 [label="0"]; @@ -1327,9 +1327,9 @@ void SmCaretPosGraphBuildingVisitor::Visit( SmFontNode* pNode ) * n10 -> n11 [label="0"]; * n11 [label="SmTextNode: i"]; * n10 -> n12 [label="1"]; - * n12 [label="SmMathSymbolNode: â"]; + * n12 [label="SmMathSymbolNode: "]; // Unicode "ELEMENT OF" * n10 -> n13 [label="2"]; - * n13 [label="SmMathSymbolNode: â¤"]; + * n13 [label="SmMathSymbolNode: "]; // Unicode "DOUBLE-STRUCK CAPITAL Z" * n3 -> n14 [label="2"]; * n14 [label="SmMathSymbolNode: }"]; * } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96676] EMF+ not displaying correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=96676 --- Comment #2 from Chris Sherlock--- Created attachment 121510 --> https://bugs.documentfoundation.org/attachment.cgi?id=121510=edit Differences between Word (correct) and LibreOffice (incorrect rendering) On OS X -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: starmath/source
starmath/source/accessibility.cxx | 13 + starmath/source/accessibility.hxx |5 +++-- 2 files changed, 12 insertions(+), 6 deletions(-) New commits: commit 8d94017289885efe6c128849e0739b81173289db Author: Takeshi AbeDate: Mon Dec 21 18:17:36 2015 +0900 starmath: Manage SmEditAccessible's pTextHelper via std::unique_ptr Change-Id: Iefd4314823efec28a8497b5a993fdd01ed12811e Reviewed-on: https://gerrit.libreoffice.org/20849 Tested-by: Jenkins Reviewed-by: Kohei Yoshida diff --git a/starmath/source/accessibility.cxx b/starmath/source/accessibility.cxx index 2e81b18..d5e8217 100644 --- a/starmath/source/accessibility.cxx +++ b/starmath/source/accessibility.cxx @@ -1601,7 +1601,7 @@ bool SmEditViewForwarder::Paste() SmEditAccessible::SmEditAccessible( SmEditWindow *pEditWin ) : aAccName(SM_RESSTR(STR_CMDBOXWINDOW)), -pTextHelper (nullptr), +pTextHelper (), pWin(pEditWin) { OSL_ENSURE( pWin, "SmEditAccessible: window missing" ); @@ -1609,7 +1609,11 @@ SmEditAccessible::SmEditAccessible( SmEditWindow *pEditWin ) : SmEditAccessible::~SmEditAccessible() { -delete pTextHelper; +} + +::accessibility::AccessibleTextHelper *SmEditAccessible::GetTextHelper() +{ +return pTextHelper.get(); } void SmEditAccessible::Init() @@ -1623,7 +1627,8 @@ void SmEditAccessible::Init() { ::std::unique_ptr< SvxEditSource > pEditSource( new SmEditSource( pWin, *this ) ); -pTextHelper = new ::accessibility::AccessibleTextHelper( std::move(pEditSource) ); +assert(!pTextHelper); +pTextHelper.reset(new ::accessibility::AccessibleTextHelper( std::move(pEditSource) )); pTextHelper->SetEventSource( this ); } } @@ -1644,7 +1649,7 @@ void SmEditAccessible::ClearWin() //! make TextHelper release references //! (e.g. the one set by the 'SetEventSource' call) pTextHelper->Dispose(); -delete pTextHelper; pTextHelper = nullptr; +pTextHelper.reset(); } // XAccessible diff --git a/starmath/source/accessibility.hxx b/starmath/source/accessibility.hxx index c4cd3c3..953e447 100644 --- a/starmath/source/accessibility.hxx +++ b/starmath/source/accessibility.hxx @@ -37,6 +37,7 @@ #include #include #include +#include class SmGraphicWindow; class SmEditWindow; @@ -314,7 +315,7 @@ class SmEditAccessible : public SmEditAccessibleBaseClass { OUStringaAccName; -::accessibility::AccessibleTextHelper*pTextHelper; +std::unique_ptr<::accessibility::AccessibleTextHelper> pTextHelper; VclPtrpWin; SmEditAccessible( const SmEditAccessible & ) = delete; @@ -324,7 +325,7 @@ public: explicit SmEditAccessible( SmEditWindow *pEditWin ); virtual ~SmEditAccessible(); -::accessibility::AccessibleTextHelper * GetTextHelper() { return pTextHelper; } +::accessibility::AccessibleTextHelper * GetTextHelper(); voidInit(); voidClearWin(); // to be called when view is destroyed ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96666] EDITING: Address Function incorrectly resolves when Sheet names is given to #REF
https://bugs.documentfoundation.org/show_bug.cgi?id=9 m.a.riosvchanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #2 from m.a.riosv --- Seems the use of space is available again with: Version: 5.1.0.1 (x64) Build ID: bcace328aabc4c8c10b56daa87da0a2ee6579b5a Threads 4; Ver: Windows 6.19; Render: GL; Be aware that 5.1 is not ready for daily use, only for testing. OTOH, is that formula is used intensively, can make slow the spreadsheet, because INDIRECT() is a volatile function. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 86926] page format not readed in DOCX
https://bugs.documentfoundation.org/show_bug.cgi?id=86926 Timurchanged: What|Removed |Added Keywords||bibisectRequest CC||gti...@gmail.com Version|4.3.4.1 release |3.6.0.4 release Summary|page format not readed in |page format not readed in |docx|DOCX OS|Linux (All) |All -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - lotuswordpro/source
lotuswordpro/source/filter/lwpfribtable.cxx | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) New commits: commit e439aebde0f60e7fe9bb19e96964eb3d26e50e3c Author: Caolán McNamaraDate: Tue Dec 22 20:09:17 2015 + guard against missing ContentContainer Change-Id: I4f2c5d53148deb02d990edc42140c23f02409cea (cherry picked from commit 8a05b74eeb8d5e0955fbe3cefd945cdc9bffa3f5) diff --git a/lotuswordpro/source/filter/lwpfribtable.cxx b/lotuswordpro/source/filter/lwpfribtable.cxx index e76c25d..d14ea31 100644 --- a/lotuswordpro/source/filter/lwpfribtable.cxx +++ b/lotuswordpro/source/filter/lwpfribtable.cxx @@ -111,7 +111,7 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) pXFContentContainer = m_pPara->GetXFContainer(); //delete the additional blank para XFParagraph* pCurrPara = m_pPara->GetFribs().GetXFPara(); -if(!pCurrPara->HasContents()) +if (pXFContentContainer && !pCurrPara->HasContents()) { if(pXFContentContainer->GetLastContent() == pCurrPara) { @@ -142,18 +142,20 @@ void LwpFribTable::XFConvert(XFContentContainer* pCont) LwpGlobalMgr* pGlobal = LwpGlobalMgr::GetInstance(); LwpChangeMgr* pChangeMgr = pGlobal->GetLwpChangeMgr(); sChangeID = pChangeMgr->GetChangeID(this); -if (!sChangeID.isEmpty()) +if (!sChangeID.isEmpty() && pXFContentContainer) { XFChangeStart* pChangeStart = new XFChangeStart; pChangeStart->SetChangeID(sChangeID); pXFContentContainer->Add(pChangeStart); } } -pSuper->XFConvert(pXFContentContainer); + +if (pXFContentContainer) +pSuper->XFConvert(pXFContentContainer); if(m_bRevisionFlag) { -if (!sChangeID.isEmpty()) +if (!sChangeID.isEmpty() && pXFContentContainer) { XFChangeEnd* pChangeEnd = new XFChangeEnd; pChangeEnd->SetChangeID(sChangeID); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 46842] Corrupted enummeration in RTF format
https://bugs.documentfoundation.org/show_bug.cgi?id=46842 Miklos Vajnachanged: What|Removed |Added Assignee|vmik...@collabora.co.uk |libreoffice-b...@lists.free ||desktop.org --- Comment #15 from Miklos Vajna --- Reset Assignee to default till I actually start looking into this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89147] Calc comment text invisible when using missing font in .xls file
https://bugs.documentfoundation.org/show_bug.cgi?id=89147 Belugachanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||todven...@suomi24.fi Summary|Calc comments missing |Calc comment text invisible ||when using missing font in ||.xls file Ever confirmed|0 |1 Severity|normal |minor --- Comment #7 from Beluga --- Ok, you are using .xls format. I see the comment boxes without text in your example file. These boxes use the font MS Sans Serif, which is missing in my system. I confirm 4.3 displays the text with a replacement font just fine. However, I could not reproduce this from scratch by inserting a comment and changing the font to be some made-up one, saving as .xls and reloading. Win 7 Pro 64-bit, Version: 5.0.4.2 (x64) Build ID: 2b9802c1994aa0b7dc6079e128979269cf95bc78 Locale: fi-FI (fi_FI) Version: 5.2.0.0.alpha0+ Build ID: 014633f83e44ae8ba33087b6f38e8e253e281969 CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-12-15_06:21:44 Locale: fi-FI (fi_FI) 4.3.0.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96674] drawingML import: fully vertical lines are imported as horizontal ones
https://bugs.documentfoundation.org/show_bug.cgi?id=96674 Miklos Vajnachanged: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk |desktop.org | Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44986] FILEOPEN: Imported RTF - table cell/row widths wrongly imported
https://bugs.documentfoundation.org/show_bug.cgi?id=44986 Miklos Vajnachanged: What|Removed |Added Assignee|vmik...@collabora.co.uk |libreoffice-b...@lists.free ||desktop.org --- Comment #9 from Miklos Vajna --- Reset Assignee to default till I actually start looking into this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37161] FILESAVE RTF: Vertical cell merging in tables not exported correctly
https://bugs.documentfoundation.org/show_bug.cgi?id=37161 Miklos Vajnachanged: What|Removed |Added Assignee|vmik...@collabora.co.uk |libreoffice-b...@lists.free ||desktop.org --- Comment #19 from Miklos Vajna --- Reset Assignee to default till I actually start looking into this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96675] Writer: Undo insertion of cols or rows crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=96675 --- Comment #1 from reporter_of_b...@yahoo.com --- replicated on: Version: 5.2.0.0.alpha0+ Build ID: 0b1da98da44bc9acb9e42a5cd1842adf9d82a415 CPU Threads: 4; OS Version: Linux 4.1; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-12-13_23:55:22 Locale: en-NZ (en_NZ.utf8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96673] New: LO 5.1.0.0 Beta Quick Launcher Does Not Start
https://bugs.documentfoundation.org/show_bug.cgi?id=96673 Bug ID: 96673 Summary: LO 5.1.0.0 Beta Quick Launcher Does Not Start Product: LibreOffice Version: 5.0.0.0.beta2 Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: timothy.m.butterwo...@gmail.com The Quick Launcher in all development versions of LO 5.1.0.x I have tested so far on Fedora 23 x86_64 with KDE Plasma 5 does not start! I have tried starting this manually from the command line as well with no success. The LO Quick Starter System Tray Applet is a major component that needs to be fixed. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92117] Crash/hang after deleting column in XLSX or deleting and saving
https://bugs.documentfoundation.org/show_bug.cgi?id=92117 Timurchanged: What|Removed |Added Keywords||bibisectRequest CC||gti...@gmail.com Hardware|x86-64 (AMD64) |All Version|4.4.3.2 release |4.2.0.4 release Summary|FILESAVE: crash/hang after |Crash/hang after deleting |deleting column or deleting |column in XLSX or deleting |and saving |and saving Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 76296] FILEOPEN: Open or import of MathML file does not write ~ or ` for the element
https://bugs.documentfoundation.org/show_bug.cgi?id=76296 Regina Henschelchanged: What|Removed |Added Summary|FILEOPEN: Upside Down "?" |FILEOPEN: Open or import of |at beginning when open |MathML file does not write |MathML file |~ or ` for the ||element --- Comment #5 from Regina Henschel --- The ~ is not in the cell, because the method SmBlankNode::CreateTextFromNode() is not yet implemented. The export of ~ and ` was corrected in bug 66075, but the import of is not corrected. It adds only one ~ , independent of the attribute "width". I change the subject to the underlying reason. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92117] Crash/hang after deleting column in XLSX or deleting and saving
https://bugs.documentfoundation.org/show_bug.cgi?id=92117 --- Comment #8 from Timur--- Created attachment 121502 --> https://bugs.documentfoundation.org/attachment.cgi?id=121502=edit debug with LO 5.2alpha0 Crash on delete H column in Win7x64 reproduced from 4.2 to current 5.2alpha0. Fault Module Name in previous versions also MSVCR.. Problem Event Name:APPCRASH Application Name:soffice.bin Application Version:5.0.4.2 Application Timestamp:566ad0aa Fault Module Name:MSVCR120.dll Fault Module Version:12.0.21005.1 Fault Module Timestamp:524f7ce6 Exception Code:4015 Exception Offset:000a7676 OS Version:6.1.7601.2.1.0.256.48 Locale ID:4122 But later on not reproduced again. Not sure about the regression, I'll let someone decide on bibisect request. Fileopen problem from Comment 1 not reproduced. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46967] RTF lists don't inherit style of their paragraph (leveltext doesn't scale bullet point with font size)
https://bugs.documentfoundation.org/show_bug.cgi?id=46967 Miklos Vajnachanged: What|Removed |Added Status|ASSIGNED|NEW Assignee|vmik...@collabora.co.uk |libreoffice-b...@lists.free ||desktop.org --- Comment #6 from Miklos Vajna --- Reset Assignee to default till I actually start looking into this. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 80612] 'Font Effects' tab of Character dialog has incorrect/missing accelerators
https://bugs.documentfoundation.org/show_bug.cgi?id=80612 Joel Maderochanged: What|Removed |Added Status|NEW |RESOLVED CC||jmadero@gmail.com Resolution|--- |WORKSFORME Severity|normal |minor --- Comment #4 from Joel Madero --- Bodhi Moksha Version: 5.2.0.0.alpha0+ Build ID: 5df326438fd3a5613a52b4de1935426911ff1301 It's pretty hard to bibisect issues when it's 4 bugs reported in one reportsome of which are actually enhancement requests that aren't actually regressions at all. I'm addressing them in turn. 1) Getting to Effects *Basically works the same was as 3.3. You have to use the mouse *once* to select the right tab (Font Effects) and then from that point forward that tab is selected by default when you go through the keyboard strokes. So to be clear: 1st time: alt+o -> c (no longer h) -> mouse select Font Effects -> Tab as needed to get to Effects -> down key to select small caps Subsequent times: alt+o -> c -> tab as needed to get to Effects -> down key to select small caps Based on this I'm closing this as WFM. Now the other list of issues: 2) Bug 96677 3) Bug 96678 4) Bug 96679 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects
https://bugs.documentfoundation.org/show_bug.cgi?id=96679 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Ever confirmed|0 |1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96679] New: Add Ability to Assign Keyboard Shortcuts for All Font Effects
https://bugs.documentfoundation.org/show_bug.cgi?id=96679 Bug ID: 96679 Summary: Add Ability to Assign Keyboard Shortcuts for All Font Effects Product: LibreOffice Version: 4.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: ux-advise Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com CC: libreoffice-ux-adv...@lists.freedesktop.org Bodhi Moksha Version: 5.2.0.0.alpha0+ Build ID: 5df326438fd3a5613a52b4de1935426911ff1301 To see all font effects: 1) alt + o; 2) c (or h depending on your version of LibreOffice) 3) Select Font Effects tab Many of these are not available to assign shortcuts but it would be really useful to have an easy way to assign a shortcut to each of these options. Requesting UX advise here as I think it might be somewhat tricky to do (for instance, if you assign a shortcut to strikethroughwhat type of strikethrough is applied) Thanks UX in advance. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38274] Find & Next Page/ Next Find problem
https://bugs.documentfoundation.org/show_bug.cgi?id=38274 --- Comment #9 from kitsune6...@yahoo.com --- Bug still present. The interface has changed since it was originally lodged. Originally, problem was on "next page" & "previous page" buttons on scroll bar. Now the same function is performed by "next element" & "previous element" buttons on tool bar that appears on bottom of screen. Verision of LibreOffice : 5.0.4.2 Operation System: Windows XP SP3 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96680] New: Inserting a column or row in a table and then undo'ing it crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=96680 Bug ID: 96680 Summary: Inserting a column or row in a table and then undo'ing it crashes LO Product: LibreOffice Version: 5.1.0.1 rc Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: gaurangar...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 92049] icon changes do not affect drop-down icons in New menu until close
https://bugs.documentfoundation.org/show_bug.cgi?id=92049 Yousuf (Jay) Philipschanged: What|Removed |Added CC||momonas...@gmail.com Whiteboard||bibisectRequest --- Comment #4 from Yousuf (Jay) Philips --- Still present - Linux Mint 17.2 XFCE. Version: 5.2.0.0.alpha0+ Build ID: 0b1da98da44bc9acb9e42a5cd1842adf9d82a415 CPU Threads: 2; OS Version: Linux 3.13; UI Render: default; TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time: 2015-12-22_05:54:37 Locale: en-US (en_US.UTF-8) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: 11 commits - connectivity/source cui/source dbaccess/source desktop/source editeng/source embeddedobj/source eventattacher/source extensions/source filter/source forms/
connectivity/source/drivers/file/FDriver.cxx|1 connectivity/source/drivers/file/FResultSet.cxx |1 connectivity/source/drivers/jdbc/PreparedStatement.cxx |2 connectivity/source/drivers/jdbc/ResultSet.cxx |2 connectivity/source/drivers/jdbc/ResultSetMetaData.cxx |3 connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx | 11 +- connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx |5 - connectivity/source/drivers/odbc/OResultSet.cxx |1 connectivity/source/drivers/odbc/OStatement.cxx |1 connectivity/source/drivers/postgresql/pq_sequenceresultset.cxx |2 connectivity/source/drivers/postgresql/pq_sequenceresultsetmetadata.cxx |2 connectivity/source/drivers/postgresql/pq_sequenceresultsetmetadata.hxx |3 connectivity/source/drivers/postgresql/pq_statics.cxx | 40 -- connectivity/source/drivers/postgresql/pq_xindex.hxx|1 connectivity/source/drivers/postgresql/pq_xkey.hxx |1 connectivity/source/drivers/postgresql/pq_xtable.hxx|1 connectivity/source/inc/RowFunctionParser.hxx |5 - connectivity/source/inc/file/FResultSet.hxx |1 connectivity/source/inc/file/fcode.hxx |3 connectivity/source/inc/java/sql/ResultSetMetaData.hxx |3 connectivity/source/inc/odbc/OBoundParam.hxx|9 -- connectivity/source/inc/odbc/OConnection.hxx|5 - connectivity/source/inc/odbc/ODatabaseMetaDataResultSet.hxx |2 connectivity/source/inc/odbc/OPreparedStatement.hxx | 13 --- connectivity/source/inc/odbc/OResultSet.hxx |1 connectivity/source/inc/odbc/OStatement.hxx |1 cui/source/dialogs/colorpicker.cxx | 10 +- cui/source/factory/dlgfact.cxx |8 -- cui/source/factory/dlgfact.hxx |4 - cui/source/inc/border.hxx |2 cui/source/inc/cfg.hxx |5 - cui/source/inc/insdlg.hxx |3 cui/source/inc/optdict.hxx | 13 --- cui/source/options/optdict.cxx | 13 --- cui/source/options/optlingu.cxx |5 - cui/source/options/personalization.hxx |1 dbaccess/source/core/api/CacheSet.hxx |1 dbaccess/source/core/inc/SingleSelectQueryComposer.hxx |1 dbaccess/source/ext/macromigration/migrationengine.cxx |4 - dbaccess/source/filter/xml/xmlExport.hxx|1 dbaccess/source/filter/xml/xmlHelper.hxx|1 dbaccess/source/filter/xml/xmlHierarchyCollection.cxx |1 dbaccess/source/filter/xml/xmlHierarchyCollection.hxx |1 dbaccess/source/filter/xml/xmlfilter.hxx|1 dbaccess/source/ui/inc/DExport.hxx |1 dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx|1 dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx |2 desktop/source/deployment/gui/dp_gui.h | 16 desktop/source/deployment/gui/dp_gui_dialog2.cxx|2 desktop/source/deployment/gui/dp_gui_dialog2.hxx|1 desktop/source/deployment/gui/dp_gui_updateinstalldialog.cxx|3 desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx|1 desktop/source/deployment/gui/license_dialog.cxx| 11 -- desktop/source/deployment/manager/dp_commandenvironments.hxx|1 desktop/source/migration/services/oo3extensionmigration.hxx |2 desktop/source/splash/unxsplash.cxx |9 +- desktop/source/splash/unxsplash.hxx |3 editeng/source/editeng/edtspell.cxx |3 editeng/source/editeng/edtspell.hxx |2 editeng/source/editeng/impedit4.cxx |2 editeng/source/misc/splwrap.cxx |
[Libreoffice-bugs] [Bug 96681] New: Lack of UI to change the text background color of a style
https://bugs.documentfoundation.org/show_bug.cgi?id=96681 Bug ID: 96681 Summary: Lack of UI to change the text background color of a style Product: LibreOffice Version: 5.0.3.2 release Hardware: x86 (IA32) OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Impress Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: vdragon.tai...@gmail.com As title, there's no UI to configure a style's text background color, it should be one under the "font effect" tab. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/PhysicalFontCollection.hxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit bfb32ea784b92f8cde0986b8724160ba7570080c Author: Chris Sherlock Date: Wed Dec 23 10:38:58 2015 +1100 vcl: make PhysicalFontFamily::ImplFindByAliasName private Change-Id: Idb0df528beb9551431fe32a69b54fe8a51cba2eb Reviewed-on: https://gerrit.libreoffice.org/20863 Reviewed-by: Chris SherlockTested-by: Chris Sherlock diff --git a/vcl/inc/PhysicalFontCollection.hxx b/vcl/inc/PhysicalFontCollection.hxx index 427660c..5494374 100644 --- a/vcl/inc/PhysicalFontCollection.hxx +++ b/vcl/inc/PhysicalFontCollection.hxx @@ -65,8 +65,6 @@ public: PhysicalFontFamily* FindByTokenNames(const OUString& rTokenStr) const; protected: -PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName, -const OUString& rShortName) const; PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& ) const; PhysicalFontFamily* ImplFindByAttributes(ImplFontAttrs nSearchType, FontWeight, FontWidth, FontItalic, const OUString& rSearchFamily) const; @@ -88,6 +86,8 @@ private: mutable int mnFallbackCount; PhysicalFontFamily* ImplFindBySearchName( const OUString& ) const; +PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName, +const OUString& rShortName) const; voidInitMatchData() const; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 96677] Alt+s Hot Key At Effects Dialog Incorrectly Mapped
https://bugs.documentfoundation.org/show_bug.cgi?id=96677 Joel Maderochanged: What|Removed |Added Keywords||bibisected, regression Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Ever confirmed|0 |1 Whiteboard||needsDevEval --- Comment #1 from Joel Madero --- Important: At some point "alt+s" was used to trigger "shadow" instead of "strikethrough" - but it worked as expected (did not select effects instead). So "good" was valid for "shadow". If a second bibisect is needed to determine when strikethrough changed to shadow for alt+s just request it and I'll do it. It seems *very* likely that when s was moved back from shadow to strikethrough...the problems occurred. Bibisect 1: Alt+s incorrectly mapped to effects f076560b5b9947a5b316efb4764d697f80e53afb is the first bad commit commit f076560b5b9947a5b316efb4764d697f80e53afb Author: Bjoern Michaelsen Date: Thu Oct 17 18:00:51 2013 + source-hash-420aa16af0bbab4bdef80ceeb8d44cabe65840e0 commit 420aa16af0bbab4bdef80ceeb8d44cabe65840e0 Author: Michael Stahl AuthorDate: Fri Jul 12 19:04:21 2013 +0200 Commit: Michael Stahl CommitDate: Fri Jul 12 19:23:06 2013 +0200 fdo#66745: drawinglayer: properly restore anti-aliasing mode VclPixelProcessor2D: the constructor changes the anti-aliasing mode of the given output device, and the destructor restores a hard-coded mode instead of what was there before. Due to this commit 5913506b2193e93ca2767ab7365ab2e76ed7848f turned off anti-aliasing for FontWork objects simply by creating a temporary VclPixelProcessor2D. Change-Id: I7f7fcbf86b0dd425f599cd8e62fce3c69a2744bb :100644 100644 e77d6562a032ab72f4f6687b79ee3ddb0a8b9ac7 cf818efc4efa98dc54c53ec32be6b8413e1538d8 Mccache.log :100644 100644 440acef13e7e01f69e2e977deeded3b1f85c14c2 b2b4cae57b151f1949a6a8aceca17a54686d0076 Mcommitmsg :100644 100644 b8596aef3d1c51c964a23adfd6c9e3a188d0d57b 90cc6f203d87a733288a1e3fd816324b62c25e45 Mdev-install.log :100644 100644 bef4904693793b8ab0e56f05a36436b3a4155fd4 911329c9e7f5014dd76c62bfbf78e1b260884f17 Mmake.log :04 04 a81dc7173b6b8a0d4f48d0cdaacedfb3af9c29b2 854f5173fa9f68a863965820d7bc55a592050424 Mopt # bad: [423a84c4f7068853974887d98442bc2a2d0cc91b] source-hash-c15927f20d4727c3b8de68497b6949e72f9e6e9e # good: [65fd30f5cb4cdd37995a33420ed8273c0a29bf00] source-hash-d6cde02dbce8c28c6af836e2dc1120f8a6ef9932 git bisect start 'latest' 'oldest' # good: [e02439a3d6297a1f5334fa558ddec5ef4212c574] source-hash-6b8393474974d2af7a2cb3c47b3d5c081b550bdb git bisect good e02439a3d6297a1f5334fa558ddec5ef4212c574 # bad: [4850941efe43ae800be5c76e1102ab80ac2c085d] source-hash-980a6e552502f02f12c15bfb1c9f8e6269499f4b git bisect bad 4850941efe43ae800be5c76e1102ab80ac2c085d # skip: [a043626b542eb8314218d7439534dce2fc325304] source-hash-9379a922c07df3cdb7d567cc88dfaaa39ead3681 git bisect skip a043626b542eb8314218d7439534dce2fc325304 # skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6 # skip: [aba65c3e4c0df07e4909aeefb758cdb688242bf6] source-hash-827524abfb4b577d08276fde40929a9adfb7ff1a git bisect skip aba65c3e4c0df07e4909aeefb758cdb688242bf6 # bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930 git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31 # bad: [c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31] source-hash-c69ed33628ec0b7abf6296539cf280d6c4265930 git bisect bad c81a8a0dcfc1ed095a80e4485c89dd0fcaf73f31 # bad: [1d4980621741d3050a5fe61b247c157d769988f2] source-hash-89d01a7d8028ddb765e02c116d202a2435894217 git bisect bad 1d4980621741d3050a5fe61b247c157d769988f2 # bad: [ba096f438393091574da98fe7b8e6b05182a8971] source-hash-8499e78ca03c792f4fa2650e02b519094ba0baa8 git bisect bad ba096f438393091574da98fe7b8e6b05182a8971 # good: [9daa289e178460daaafa4b3911031df5b8736218] source-hash-704292996a3731a61339b1a4a5c90c9403aa095f git bisect good 9daa289e178460daaafa4b3911031df5b8736218 # good: [34eab3946c46bb7273ba4ca395db9c4421dd232f] source-hash-e962805b31074d6b6a2ed0db6452769448337553 git bisect good 34eab3946c46bb7273ba4ca395db9c4421dd232f # bad: [a8577b9049e085140768f97f7d4ff555a8a447cb] source-hash-98ded3e42011b060368899018c07cbd32e7993f1 git bisect bad a8577b9049e085140768f97f7d4ff555a8a447cb # bad: [e128a0b9bd133d989b87354bd271ef25c642b7bc] source-hash-7be71336862204f0763fc2f8cf62a6f48f341114 git bisect bad e128a0b9bd133d989b87354bd271ef25c642b7bc # bad:
[Libreoffice-bugs] [Bug 96677] Alt+s Hot Key At Effects Dialog Incorrectly Mapped
https://bugs.documentfoundation.org/show_bug.cgi?id=96677 --- Comment #2 from Joel Madero--- Note: The missing underline might be a feature (weird?) but if you HOLD alt then they all appear...makes more sense for them to always be visible but I leave that for UX to decide. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 89147] Calc comment text invisible when using missing font in .xls file
https://bugs.documentfoundation.org/show_bug.cgi?id=89147 raalchanged: What|Removed |Added Keywords||regression -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 77658] No grid between 1st & 2nd line changing font of the default template
https://bugs.documentfoundation.org/show_bug.cgi?id=77658 Joel Maderochanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #12 from Joel Madero --- Closing as WFM then as we don't have independent confirmation at this point and have two experienced QA members unable to repro. @Leopold - if you can still reproduce with 5.0 or later please set the bug back to UNCONFIRMED. Thanks! -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96677] New: Alt+s Hot Key At Effects Dialog Incorrectly Mapped
https://bugs.documentfoundation.org/show_bug.cgi?id=96677 Bug ID: 96677 Summary: Alt+s Hot Key At Effects Dialog Incorrectly Mapped Product: LibreOffice Version: 4.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: minor Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com Bodhi Moksha Version: 5.2.0.0.alpha0+ Build ID: 5df326438fd3a5613a52b4de1935426911ff1301 1) Open writer; 2) alt+o -> c (opens character dialog); 3) Select "Font Effects" tab Observed: No underline for any of the options available (for instance strikethrough should have an underline under "s") 4) Push "alt" Observed: See underlines under appropriate letters (for instance under "s" in strikethrough) 5) alt + s Expected: Get to strikethrough options; Observed: Gets to "Effects" instead Note: I did not test each and every options. Based on a part of bug 80612 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96678] New: Add Hotkeys to Each Font Effect Option
https://bugs.documentfoundation.org/show_bug.cgi?id=96678 Bug ID: 96678 Summary: Add Hotkeys to Each Font Effect Option Product: LibreOffice Version: 4.0.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: jmadero@gmail.com BOdhi Moksha Version: 5.2.0.0.alpha0+ Build ID: 5df326438fd3a5613a52b4de1935426911ff1301 1) alt + o; 2) alt + c; 3) Font Effect tab Observed: No underlines under any character indicating hotkeys (might be a bug..not sure) 4) push and hold alt Observed: Many of the options have hotkeys (available by pushing alt+[relevant key]) but some do not. Examples of one that does is strikethrough (s is underlined) Request: Add hotkeys for following: *Font Color; *Effects; *Relief *Overlining; *Underlining *Overline Color Requesting dev eval to see if it can be an easy hack. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96678] Add Hotkeys to Each Font Effect Option
https://bugs.documentfoundation.org/show_bug.cgi?id=96678 Joel Maderochanged: What|Removed |Added Status|UNCONFIRMED |NEW CC||jmadero@gmail.com Ever confirmed|0 |1 Whiteboard||needDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-ux-advise] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects
https://bugs.documentfoundation.org/show_bug.cgi?id=96679 Joel Maderochanged: What|Removed |Added Keywords||needsDevEval -- You are receiving this mail because: You are on the CC list for the bug. ___ Libreoffice-ux-advise mailing list Libreoffice-ux-advise@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise
[Libreoffice-bugs] [Bug 96677] Alt+s Hot Key At Effects Dialog Incorrectly Mapped
https://bugs.documentfoundation.org/show_bug.cgi?id=96677 Joel Maderochanged: What|Removed |Added Keywords||needsDevEval Whiteboard|needsDevEval| -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96679] Add Ability to Assign Keyboard Shortcuts for All Font Effects
https://bugs.documentfoundation.org/show_bug.cgi?id=96679 Joel Maderochanged: What|Removed |Added Keywords||needsDevEval -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96680] Inserting a column or row in a table and then undo'ing it crashes LO
https://bugs.documentfoundation.org/show_bug.cgi?id=96680 --- Comment #1 from Gaurang--- In an existing table, if you add a column or a row, and then hit 'undo', libreoffice crashes. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 67829] Misplaced open Drop-down boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=67829 tommy27changed: What|Removed |Added CC||ba...@quipo.it --- Comment #6 from tommy27 --- (In reply to A (Andy) from comment #3) > for me not reproducible with LO 4.3.2.2 (Win 8.1) no repro too on Win8.1 x64 using LibO 5.0.3.1 -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96682] New: sumary of multiple lines
https://bugs.documentfoundation.org/show_bug.cgi?id=96682 Bug ID: 96682 Summary: sumary of multiple lines Product: LibreOffice Version: 5.0.3.2 release Hardware: x86 (IA32) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: akcq_...@sina.com Created attachment 121513 --> https://bugs.documentfoundation.org/attachment.cgi?id=121513=edit sumary of multiple lines In Simple Chinese Edition , when chose multiple lines ,the sum of the lines is covered. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc
vcl/inc/PhysicalFontCollection.hxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit fc1d9e3496492d9cfec491887f8007d0e42dd368 Author: Chris Sherlock Date: Wed Dec 23 10:39:28 2015 +1100 vcl: make PhysicalFontFamily::ImplFindBySubstFontAttr private Change-Id: I2e066393b5ee90c96cea0871c68a72b408a8d0b2 Reviewed-on: https://gerrit.libreoffice.org/20864 Reviewed-by: Chris SherlockTested-by: Chris Sherlock diff --git a/vcl/inc/PhysicalFontCollection.hxx b/vcl/inc/PhysicalFontCollection.hxx index 5494374..6eb77ae 100644 --- a/vcl/inc/PhysicalFontCollection.hxx +++ b/vcl/inc/PhysicalFontCollection.hxx @@ -65,7 +65,6 @@ public: PhysicalFontFamily* FindByTokenNames(const OUString& rTokenStr) const; protected: -PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& ) const; PhysicalFontFamily* ImplFindByAttributes(ImplFontAttrs nSearchType, FontWeight, FontWidth, FontItalic, const OUString& rSearchFamily) const; PhysicalFontFamily* FindDefaultFont() const; @@ -88,6 +87,7 @@ private: PhysicalFontFamily* ImplFindBySearchName( const OUString& ) const; PhysicalFontFamily* ImplFindByAliasName(const OUString& rSearchName, const OUString& rShortName) const; +PhysicalFontFamily* ImplFindBySubstFontAttr( const utl::FontNameAttr& ) const; voidInitMatchData() const; }; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-bugs] [Bug 92049] icon changes do not affect drop-down icons in New menu until close
https://bugs.documentfoundation.org/show_bug.cgi?id=92049 Joel Maderochanged: What|Removed |Added Version|4.3.7.2 release |PreBibisect Whiteboard|bibisectRequest | --- Comment #5 from Joel Madero --- Oh oops - messed up on this one. Tested with bibisect and it must have started between 3.3 and 3.5.beta0 Thanks Jay for re-testing. P.S. bibisectRequest is now keyword not whiteboard :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win
vcl/inc/PhysicalFontCollection.hxx |5 ++--- vcl/source/font/PhysicalFontCollection.cxx |6 +++--- vcl/win/gdi/salgdi3.cxx| 10 +- 3 files changed, 10 insertions(+), 11 deletions(-) New commits: commit 395815caa6be493d0831a61ba3de4e7d5ba4ae1d Author: Chris Sherlock Date: Wed Dec 23 10:39:37 2015 +1100 vcl: Make ImplFindByAttributes public and rename Renamed PhysicalFontCollection::ImplFindByAttributes to FindByAttributes. This function is actually useful for finding a font within the collection, so I'm moving it from being a protected function to public because it is actually useful in its own right, not just for PhysicalFontCollection. Note that ImplFontAttrs is a mess anyway, so not going to touch that (yet). Change-Id: I884ddd5118cbbb0f92b157540f7ffcf1bf35609b Reviewed-on: https://gerrit.libreoffice.org/20865 Reviewed-by: Chris SherlockTested-by: Chris Sherlock diff --git a/vcl/inc/PhysicalFontCollection.hxx b/vcl/inc/PhysicalFontCollection.hxx index 6eb77ae..2e4825f 100644 --- a/vcl/inc/PhysicalFontCollection.hxx +++ b/vcl/inc/PhysicalFontCollection.hxx @@ -63,10 +63,9 @@ public: ImplGetDevSizeList* GetDevSizeList( const OUString& rFontName ) const; PhysicalFontFamily* FindByTokenNames(const OUString& rTokenStr) const; - +PhysicalFontFamily* FindByAttributes(ImplFontAttrs nSearchType, FontWeight, FontWidth, + FontItalic, const OUString& rSearchFamily) const; protected: -PhysicalFontFamily* ImplFindByAttributes(ImplFontAttrs nSearchType, FontWeight, FontWidth, - FontItalic, const OUString& rSearchFamily) const; PhysicalFontFamily* FindDefaultFont() const; private: diff --git a/vcl/source/font/PhysicalFontCollection.cxx b/vcl/source/font/PhysicalFontCollection.cxx index 02c85cb..39bcb26 100644 --- a/vcl/source/font/PhysicalFontCollection.cxx +++ b/vcl/source/font/PhysicalFontCollection.cxx @@ -421,7 +421,7 @@ PhysicalFontFamily* PhysicalFontCollection::ImplFindBySubstFontAttr( const utl:: const FontItalic eSearchSlant = ITALIC_DONTKNOW; const OUString aSearchName; -pFoundData = ImplFindByAttributes( nSearchType, +pFoundData = FindByAttributes( nSearchType, eSearchWeight, eSearchWidth, eSearchSlant, aSearchName ); if( pFoundData ) @@ -454,7 +454,7 @@ void PhysicalFontCollection::InitMatchData() const } } -PhysicalFontFamily* PhysicalFontCollection::ImplFindByAttributes( ImplFontAttrs nSearchType, +PhysicalFontFamily* PhysicalFontCollection::FindByAttributes( ImplFontAttrs nSearchType, FontWeight eSearchWeight, FontWidth eSearchWidth, FontItalic eSearchItalic, @@ -1271,7 +1271,7 @@ PhysicalFontFamily* PhysicalFontCollection::FindByFont( FontSelectPattern& rFSD } PhysicalFontFamily::CalcType( nSearchType, eSearchWeight, eSearchWidth, rFSD.GetFamilyType(), pFontAttr ); -PhysicalFontFamily* pFoundData = ImplFindByAttributes( nSearchType, +PhysicalFontFamily* pFoundData = FindByAttributes( nSearchType, eSearchWeight, eSearchWidth, rFSD.GetSlant(), aSearchFamilyName ); if( pFoundData ) diff --git a/vcl/win/gdi/salgdi3.cxx b/vcl/win/gdi/salgdi3.cxx index d091764..02982f6d 100644 --- a/vcl/win/gdi/salgdi3.cxx +++ b/vcl/win/gdi/salgdi3.cxx @@ -543,11 +543,11 @@ bool WinGlyphFallbackSubstititution::FindFontSubstitute( FontSelectPattern& rFon } // are the missing characters symbols? -pFontFamily = pFontCollection->ImplFindByAttributes( ImplFontAttrs::Symbol, - rFontSelData.GetWeight(), - rFontSelData.GetWidthType(), - rFontSelData.GetSlant(), - rFontSelData.maSearchName ); +pFontFamily = pFontCollection->FindByAttributes( ImplFontAttrs::Symbol, + rFontSelData.GetWeight(), + rFontSelData.GetWidthType(), + rFontSelData.GetSlant(), + rFontSelData.maSearchName ); if( pFontFamily ) { PhysicalFontFace* pFace = pFontFamily->FindBestFontFace( rFontSelData ); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org
[Libreoffice-bugs] [Bug 96671] Correctly detect windows 64-bit OS
https://bugs.documentfoundation.org/show_bug.cgi?id=96671 Michael Meekschanged: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 --- Comment #1 from Michael Meeks --- Ah - this is a good point; pwrt. 64bit builds on 32bit systems etc. I think we're more interested in the build than the system from a bug filing perspective; though prolly both are interesting. Hmm =) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96599] Some arrows not visible in the gallery sidebar
https://bugs.documentfoundation.org/show_bug.cgi?id=96599 Maxim Monastirskychanged: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 96541 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96541] dialog "About LibreOfficeDev" has lost its logo
https://bugs.documentfoundation.org/show_bug.cgi?id=96541 Maxim Monastirskychanged: What|Removed |Added CC||gabs...@gmail.com --- Comment #4 from Maxim Monastirsky --- *** Bug 96599 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96660] The "save file" button in the main toolbar has now a strange and incoherent behaviour
https://bugs.documentfoundation.org/show_bug.cgi?id=96660 Maxim Monastirskychanged: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Maxim Monastirsky --- *** This bug has been marked as a duplicate of bug 96590 *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96590] UI: after saving file, save icon is not greyed out
https://bugs.documentfoundation.org/show_bug.cgi?id=96590 Maxim Monastirskychanged: What|Removed |Added CC||silva...@katamail.com --- Comment #7 from Maxim Monastirsky --- *** Bug 96660 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96590] UI: after saving file, save icon is not greyed out
https://bugs.documentfoundation.org/show_bug.cgi?id=96590 --- Comment #8 from bugzi...@rhynas.com --- Perhaps something along the lines of how Notepad++ treats this - when a document is modified the FD icon goes red. Once saved the icon returns to normal. AllanR -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-commits] core.git: basic/source
basic/source/comp/exprnode.cxx | 342 + basic/source/inc/expr.hxx |6 2 files changed, 189 insertions(+), 159 deletions(-) New commits: commit 4251e676bb818cde1989b9077b1497f1d9b0cbdc Author: Arnaud VersiniDate: Sun Jul 12 13:52:53 2015 +0200 BASIC : Refactor FoldConstants for extracting it from SwExprNode. Change-Id: Ia47597b26d63db216dd3ab71acbb18449ece7b1a Reviewed-on: https://gerrit.libreoffice.org/16963 Reviewed-by: Arnaud Versini Tested-by: Arnaud Versini diff --git a/basic/source/comp/exprnode.cxx b/basic/source/comp/exprnode.cxx index 52c2211..9d77f6d 100644 --- a/basic/source/comp/exprnode.cxx +++ b/basic/source/comp/exprnode.cxx @@ -231,182 +231,206 @@ void SbiExprNode::CollectBits() void SbiExprNode::FoldConstants(SbiParser* pParser) { if( IsOperand() || eTok == LIKE ) return; -if( pLeft ) -pLeft->FoldConstants(pParser); -if (pLeft && pRight) + +if (IsUnary()) +FoldConstantsUnaryNode(pParser); +else if (IsBinary()) +FoldConstantsBinaryNode(pParser); + +if( eNodeType == SbxNUMVAL ) { -pRight->FoldConstants(pParser); -if( pLeft->IsConstant() && pRight->IsConstant() -&& pLeft->eNodeType == pRight->eNodeType ) +// Potentially convolve in INTEGER (because of better opcode)? +if( eType == SbxSINGLE || eType == SbxDOUBLE ) { -CollectBits(); -if( eTok == CAT ) -// CAT affiliate also two numbers! -eType = SbxSTRING; -if( pLeft->eType == SbxSTRING ) -// No Type Mismatch! +double x; +if( nVal >= SbxMINLNG && nVal <= SbxMAXLNG +&& !modf( nVal, ) ) +eType = SbxLONG; +} +if( eType == SbxLONG && nVal >= SbxMININT && nVal <= SbxMAXINT ) +eType = SbxINTEGER; +} +} + +void SbiExprNode::FoldConstantsBinaryNode(SbiParser* pParser) +{ +pLeft->FoldConstants(pParser); +pRight->FoldConstants(pParser); +if( pLeft->IsConstant() && pRight->IsConstant() +&& pLeft->eNodeType == pRight->eNodeType ) +{ +CollectBits(); +if( eTok == CAT ) +// CAT affiliate also two numbers! +eType = SbxSTRING; +if( pLeft->eType == SbxSTRING ) +// No Type Mismatch! +eType = SbxSTRING; +if( eType == SbxSTRING ) +{ +OUString rl( pLeft->GetString() ); +OUString rr( pRight->GetString() ); +pLeft.reset(); +pRight.reset(); +if( eTok == PLUS || eTok == CAT ) +{ +eTok = CAT; +// Linking: +aStrVal = rl; +aStrVal += rr; eType = SbxSTRING; -if( eType == SbxSTRING ) +eNodeType = SbxSTRVAL; +} +else { -OUString rl( pLeft->GetString() ); -OUString rr( pRight->GetString() ); -pLeft.reset(); -pRight.reset(); -if( eTok == PLUS || eTok == CAT ) +eType = SbxDOUBLE; +eNodeType = SbxNUMVAL; +int eRes = rr.compareTo( rl ); +switch( eTok ) { -eTok = CAT; -// Linking: -aStrVal = rl; -aStrVal += rr; -eType = SbxSTRING; -eNodeType = SbxSTRVAL; +case EQ: +nVal = ( eRes == 0 ) ? SbxTRUE : SbxFALSE; +break; +case NE: +nVal = ( eRes != 0 ) ? SbxTRUE : SbxFALSE; +break; +case LT: +nVal = ( eRes < 0 ) ? SbxTRUE : SbxFALSE; +break; +case GT: +nVal = ( eRes > 0 ) ? SbxTRUE : SbxFALSE; +break; +case LE: +nVal = ( eRes <= 0 ) ? SbxTRUE : SbxFALSE; +break; +case GE: +nVal = ( eRes >= 0 ) ? SbxTRUE : SbxFALSE; +break; +default: +pParser->Error( ERRCODE_BASIC_CONVERSION ); +bError = true; +break; } -else +} +} +else +{ +double nl = pLeft->nVal; +double nr = pRight->nVal; +long ll = 0, lr = 0; +long llMod = 0, lrMod = 0; +if( ( eTok >= AND && eTok <= IMP ) + || eTok == IDIV || eTok == MOD ) +{ +// Integer operations +bool bErr = false; +
[Libreoffice-commits] core.git: sd/inc sd/source svx/inc
sd/inc/sdcommands.h |1 sd/source/ui/app/menuids_tmpl.src | 63 ++ sd/source/ui/app/popup2_tmpl.src | 28 +++- svx/inc/globlmn_tmpl.hrc | 36 + 4 files changed, 60 insertions(+), 68 deletions(-) New commits: commit 7edfee8e4f81c17ec95a03843c509b95b8e404b2 Author: Yousuf PhilipsDate: Fri Dec 11 18:53:15 2015 +0400 Rearrangement of various context menus in Impress Change-Id: I6674254898dc6d7351ec4450e2aa5ac3f177bdbf Reviewed-on: https://gerrit.libreoffice.org/20640 Tested-by: Jenkins Reviewed-by: Yousuf Philips diff --git a/sd/inc/sdcommands.h b/sd/inc/sdcommands.h index 4642124..77d6531 100644 --- a/sd/inc/sdcommands.h +++ b/sd/inc/sdcommands.h @@ -93,6 +93,7 @@ #define CMD_SID_SAVE_BACKGROUND ".uno:SaveBackground" #define CMD_SID_DISPLAY_MASTER_BACKGROUND ".uno:DisplayMasterBackground" #define CMD_SID_DISPLAY_MASTER_OBJECTS ".uno:DisplayMasterObjects" +#define CMD_SID_MASTER_LAYOUTS ".uno:MasterLayouts" #define CMD_SID_TABLE_DISTRIBUTE_COLUMNS".uno:DistributeColumns" #define CMD_SID_TABLE_DISTRIBUTE_ROWS ".uno:DistributeRows" #define CMD_SID_TP_APPLY_TO_ALL_SLIDES ".uno:TaskPaneApplyToAllSlides" diff --git a/sd/source/ui/app/menuids_tmpl.src b/sd/source/ui/app/menuids_tmpl.src index c32cd2d..a41c102 100644 --- a/sd/source/ui/app/menuids_tmpl.src +++ b/sd/source/ui/app/menuids_tmpl.src @@ -89,7 +89,7 @@ {\ Identifier = SID_PAGESETUP ; \ HelpId = CMD_SID_PAGESETUP ; \ -Text [ en-US ] = "Format ~Slide..." ; \ +Text [ en-US ] = "~Slide Properties..." ; \ }; #define MN_INSERT_SLIDE \ @@ -142,14 +142,21 @@ {\ Identifier = SID_DISPLAY_MASTER_BACKGROUND ; \ HelpId = CMD_SID_DISPLAY_MASTER_BACKGROUND ; \ -Text [ en-US ] = "Display Background of Master" ; \ +Text [ en-US ] = "Display Master Background" ; \ }; #define MN_DISPLAY_MASTER_OBJECTS \ MenuItem\ {\ Identifier = SID_DISPLAY_MASTER_OBJECTS ; \ HelpId = CMD_SID_DISPLAY_MASTER_OBJECTS ; \ -Text [ en-US ] = "Display Objects from Master" ; \ +Text [ en-US ] = "Display Master Objects" ; \ +}; +#define MN_MASTER_ELEMENTS \ +MenuItem\ +{\ +Identifier = SID_MASTER_LAYOUTS ; \ +HelpId = CMD_SID_MASTER_LAYOUTS ; \ +Text [ en-US ] = "Master Elements" ; \ }; #define MN_PAGE_MENU \ @@ -175,33 +182,29 @@ }; #define MN_SLIDE_MENU \ -MN_SELECT_BACKGROUND\ -MN_INSERT_GRAPHIC\ MN_FORMAT_SLIDE\ +MN_SELECT_BACKGROUND\ +MN_SAVE_BACKGROUND\ MenuItem\ {\ Identifier = DUMMY + 8 ; \ Command = ".uno:PageMenu" ; \ -Text [ en-US ] = "Slid~e" ; \ +Text [ en-US ] = "Slid~e Features" ; \ SubMenu = Menu\ {\ ItemList = \ {\ -MN_INSERT_SLIDE\ -MN_DUPLICATE_SLIDE\ -MN_DELETE_SLIDE\ -SEPARATOR\ -MN_RENAME_SLIDE\ MN_HIDE_SLIDE\ MN_SHOW_SLIDE\ SEPARATOR\ -MN_PRESENTATION_LAYOUT\ MN_DISPLAY_MASTER_BACKGROUND\ MN_DISPLAY_MASTER_OBJECTS\ +MN_MASTER_ELEMENTS\ +SEPARATOR\ +MN_PRESENTATION_LAYOUT\ };\ };\ -}; \ -MN_SAVE_BACKGROUND +}; // Layer #define MN_RENAME_LAYER \ @@ -575,22 +578,6 @@ Text [ en-US ] = "~Ungroup" ; \ }; -#define MN_COMBINE \ -MenuItem\ -{\ -Identifier = SID_COMBINE ; \ -HelpId = CMD_SID_COMBINE ; \ -Text [ en-US ] = "Comb~ine" ; \ -}; - -#define MN_DISMANTLE \ -MenuItem\ -{\ -Identifier = SID_DISMANTLE ; \ -HelpId = CMD_SID_DISMANTLE ; \ -Text [ en-US ] = "~Split" ; \ -}; - #define MN_ENTER_GROUP \ MenuItem\ {\ @@ -917,22 +904,6 @@ };\ }; -#define MN_CONNECT \ -MenuItem\ -{\ -Identifier = SID_CONNECT ; \ -HelpId = CMD_SID_CONNECT ; \ -Text [ en-US ] = "C~onnect" ; \ -}; - -#define MN_BREAK \ -MenuItem\ -{\ -Identifier = SID_BREAK ; \ -HelpId = CMD_SID_BREAK ; \ -Text [ en-US ] = "~Break" ; \ -}; - #define MN_STYLEDT \ MenuItem\ {\ diff --git a/sd/source/ui/app/popup2_tmpl.src b/sd/source/ui/app/popup2_tmpl.src index 28c858f..9c0d9ca 100644 --- a/sd/source/ui/app/popup2_tmpl.src +++ b/sd/source/ui/app/popup2_tmpl.src @@ -103,11 +103,6 @@ MN_TRANSFORM MN_LINE MN_AREA -MN_TEXTATTR -SEPARATOR -MN_EDIT_POINTS -SEPARATOR -MN_CHAR_PARAGRAPH SEPARATOR
[Libreoffice-commits] core.git: Branch 'private/jmux/kde5' - 426 commits - accessibility/inc accessibility/Library_acc.mk accessibility/source avmedia/Library_avmediaogl.mk avmedia/source basctl/inc b
Rebased ref, commits from common ancestor: commit fc66ef9fc9e0c00fe7f7a62889b201b3479c02ce Author: Jan-Marek GlogowskiDate: Wed Jul 8 17:59:14 2015 + KDE4: Switch default image color to transparent... and just fill the painted image once at the beginning. Change-Id: I39c03b2ca779381920e2597b4bea7973fea6ae2a diff --git a/vcl/unx/kde4/KDESalGraphics.cxx b/vcl/unx/kde4/KDESalGraphics.cxx index a05f358..d1998d9 100644 --- a/vcl/unx/kde4/KDESalGraphics.cxx +++ b/vcl/unx/kde4/KDESalGraphics.cxx @@ -233,13 +233,39 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, { m_image.reset(new QImage( widgetRect.width(), widgetRect.height(), QImage::Format_ARGB32 ) ); } -m_image->fill(KApplication::palette().color(QPalette::Window).rgb()); + +// Default image color - just once +switch (type) +{ +case CTRL_MENU_POPUP: +if( part == PART_MENU_ITEM_CHECK_MARK || part == PART_MENU_ITEM_RADIO_MARK ) +{ +// it is necessary to fill the background transparently first, as this +// is painted after menuitem highlight, otherwise there would be a grey area +m_image->fill( Qt::transparent ); +break; +} +// fallthrough QPalette::Window +case CTRL_MENUBAR: +case CTRL_WINDOW_BACKGROUND: +m_image->fill( KApplication::palette().color(QPalette::Window).rgb() ); +break; +case CTRL_SCROLLBAR: +if ((part == PART_DRAW_BACKGROUND_VERT) || (part == PART_DRAW_BACKGROUND_HORZ)) +{ +m_image->fill( KApplication::palette().color(QPalette::Window).rgb() ); +break; +} +// fallthrough Qt::transparent +default: +m_image->fill( Qt::transparent ); +break; +} QRegion* clipRegion = nullptr; if (type == CTRL_PUSHBUTTON) { -m_image->fill( Qt::transparent ); QStyleOptionButton option; draw( QStyle::CE_PushButton, , m_image.get(), vclStateValue2StateFlag(nControlState, value) ); @@ -314,15 +340,12 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, ? QStyleOptionMenuItem::NonExclusive : QStyleOptionMenuItem::Exclusive; option.checked = bool( nControlState & ControlState::PRESSED ); // widgetRect is now the rectangle for the checkbox/radiobutton itself, but Qt -// paints the whole menu item, so translate position (and it'll be clipped); -// it is also necessary to fill the background transparently first, as this -// is painted after menuitem highlight, otherwise there would be a grey area +// paints the whole menu item, so translate position (and it'll be clipped) assert( value.getType() == CTRL_MENU_POPUP ); const MenupopupValue* menuVal = static_cast(); QRect menuItemRect( region2QRect( menuVal->maItemRect )); QRect rect( menuItemRect.topLeft() - widgetRect.topLeft(), widgetRect.size().expandedTo( menuItemRect.size())); -m_image->fill( Qt::transparent ); draw( QStyle::CE_MenuItem, , m_image.get(), vclStateValue2StateFlag(nControlState, value), rect ); } @@ -341,7 +364,6 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, } else if ( (type == CTRL_TOOLBAR) && (part == PART_BUTTON) ) { -m_image->fill( Qt::transparent ); QStyleOptionToolButton option; option.arrowType = Qt::NoArrow; @@ -409,7 +431,6 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, vclStateValue2StateFlag(nControlState, value) ); break; case PART_BUTTON_DOWN: -m_image->fill( Qt::transparent ); option.subControls = QStyle::SC_ComboBoxArrow; draw( QStyle::CC_ComboBox, , m_image.get(), vclStateValue2StateFlag(nControlState, value) ); @@ -418,7 +439,6 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, } else if (type == CTRL_LISTNODE) { -m_image->fill( Qt::transparent ); QStyleOption option; option.state = QStyle::State_Item | QStyle::State_Children; @@ -430,7 +450,6 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, } else if (type == CTRL_CHECKBOX) { -m_image->fill( Qt::transparent ); QStyleOptionButton option; draw( QStyle::CE_CheckBox, , m_image.get(), vclStateValue2StateFlag(nControlState, value) ); @@ -499,7 +518,6 @@ bool KDESalGraphics::drawNativeControl( ControlType type, ControlPart part, } else if (type
[Libreoffice-bugs] [Bug 95957] LibreOffice 5.0.3.2 - crashes with std::bad_alloc
https://bugs.documentfoundation.org/show_bug.cgi?id=95957 --- Comment #9 from Beluga--- Ah, now I linked to pre-releases even though 5.0.4 is stable.. well, test with 5.1 RC1 while you're at it :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 83066] [METABUG] Tracking bug for CJK issues
https://bugs.documentfoundation.org/show_bug.cgi?id=83066 Bug 83066 depends on bug 91288, which changed state. Bug 91288 Summary: Does not display traditional Chinese variant of Noto fonts correctly https://bugs.documentfoundation.org/show_bug.cgi?id=91288 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96655] OPENGL: Zoom slider visualization is corruputed
https://bugs.documentfoundation.org/show_bug.cgi?id=96655 --- Comment #2 from Andy--- Thanks for the hint, but if it is a problem making openGL work with such a simple thing, that has worked for years, why use it then?? -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 95792] Lock missing when saving a file (save as) on some webdav server
https://bugs.documentfoundation.org/show_bug.cgi?id=95792 --- Comment #14 from Giuseppe Castagno (aka beppec56)--- Hi Licinia, a bug. I'll report it after I tested with current daily. You should be able to select the File service type using the arrow (up/down) keys. -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96477] vlookup array selection with mouse hanged Calc
https://bugs.documentfoundation.org/show_bug.cgi?id=96477 --- Comment #8 from Beluga--- (In reply to Ari Latvala from comment #7) > Red Hat Enterprise Linux Workstation, release 6.7 (Santiago) > Kernel Linux 2.6.32-573.8.1.el6.x86_64 > GNOME 2.28.2 > > RAM 16GB, CPU i7-3720QM @ 2.60GHz Any plans to upgrade to RHEL 7? :) -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 96629] FILESAVE: equations change positioning after saving and opening particular DOCX file
https://bugs.documentfoundation.org/show_bug.cgi?id=96629 Timurchanged: What|Removed |Added CC||gti...@gmail.com --- Comment #3 from Timur --- *** Bug 96641 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs