[Libreoffice-bugs] [Bug 54933] EDITING Report builder: mouse-move control: gap between mouse position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54933

Roberto  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/inc

[Chris Sherlock]

 vcl/inc/fontattributes.hxx |  130 ++---
 1 file changed, 65 insertions(+), 65 deletions(-)

New commits:
commit 6b65a0e83c4798f117be61af91dbaebdc85e94b7
Author: Chris Sherlock 
Date:   Thu Jan 21 14:31:01 2016 +1100

vcl: tabify fontattributes.hxx

Change-Id: I309f900abc105d7bcdfbcef5a41eb41c59d62190
Reviewed-on: https://gerrit.libreoffice.org/21648
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/fontattributes.hxx b/vcl/inc/fontattributes.hxx
index 0168a32..b94f4be 100644
--- a/vcl/inc/fontattributes.hxx
+++ b/vcl/inc/fontattributes.hxx
@@ -27,89 +27,89 @@
 class FontAttributes
 {
 public:
-explicitFontAttributes();
+explicitFontAttributes();
 
 // device independent font functions
-const OUString& GetFamilyName() const   { return 
maFamilyName; }
-FontFamily  GetFamilyType() const   { return 
meFamily; }
-const OUString& GetStyleName() const{ return 
maStyleName; }
+const OUString& GetFamilyName() const   { return 
maFamilyName; }
+FontFamily  GetFamilyType() const   { return 
meFamily; }
+const OUString& GetStyleName() const{ return 
maStyleName; }
 
-FontWeight  GetWeight() const   { return 
meWeight; }
-FontItalic  GetItalic() const   { return 
meItalic; }
-FontPitch   GetPitch() const{ return 
mePitch; }
-FontWidth   GetWidthType() const{ return 
meWidthType; }
-rtl_TextEncoding GetCharSet() const { return 
meCharSet; }
+FontWeight  GetWeight() const   { return 
meWeight; }
+FontItalic  GetItalic() const   { return 
meItalic; }
+FontPitch   GetPitch() const{ return 
mePitch; }
+FontWidth   GetWidthType() const{ return 
meWidthType; }
+rtl_TextEncodingGetCharSet() const { return 
meCharSet; }
 
-boolIsSymbolFont() const{ return 
mbSymbolFlag; }
+boolIsSymbolFont() const{ return 
mbSymbolFlag; }
 
-voidSetFamilyName(const OUString& sFamilyName)  { maFamilyName 
= sFamilyName; }
-voidSetStyleName( const OUString& sStyleName)   { maStyleName 
= sStyleName; }
-voidSetFamilyType(const FontFamily eFontFamily) { meFamily = 
eFontFamily; }
+voidSetFamilyName(const OUString& sFamilyName)  { 
maFamilyName = sFamilyName; }
+voidSetStyleName( const OUString& sStyleName)   { 
maStyleName = sStyleName; }
+voidSetFamilyType(const FontFamily eFontFamily) { meFamily 
= eFontFamily; }
 
-voidSetPitch(const FontPitch ePitch )   { mePitch = 
ePitch; }
-voidSetItalic(const FontItalic eItalic ){ meItalic = 
eItalic; }
-voidSetWeight(const FontWeight eWeight ){ meWeight = 
eWeight; }
-voidSetWidthType(const FontWidth eWidthType){ meWidthType 
= eWidthType; }
-voidSetCharSet( const rtl_TextEncoding );
+voidSetPitch(const FontPitch ePitch )   { mePitch 
= ePitch; }
+voidSetItalic(const FontItalic eItalic ){ meItalic 
= eItalic; }
+voidSetWeight(const FontWeight eWeight ){ meWeight 
= eWeight; }
+voidSetWidthType(const FontWidth eWidthType){ 
meWidthType = eWidthType; }
+voidSetCharSet( const rtl_TextEncoding );
 
-voidSetSymbolFlag(const bool );
+voidSetSymbolFlag(const bool );
 
-boolCompareDeviceIndependentFontAttributes(const 
FontAttributes& rOther) const;
+boolCompareDeviceIndependentFontAttributes(const 
FontAttributes& rOther) const;
 
 // Device dependent functions
-int GetQuality() const  { return 
mnQuality; }
-OUStringGetMapNames() const { return 
maMapNames; }
-
-boolIsBuiltInFont() const   { return 
mbDevice; }
-boolCanEmbed() const{ return 
mbEmbeddable; }
-boolCanSubset() const   { return 
mbSubsettable; }
-boolCanRotate() const   { return 
mbOrientation; }
-boolHasMapNames() const { return 
(maMapNames.getLength() > 0); }
-
-void   

[Libreoffice-bugs] [Bug 91291] EDITING: Crash when moving rtl text with footnote with continuation onto the next page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91291

--- Comment #5 from Ali Yousuf  ---
Now I work on this bug ,but I need right behavior of libroffice to remove this
crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: accessibility/source chart2/source cui/source editeng/source extensions/source filter/source forms/source include/vcl sc/source sd/source starmath/source svx/source sw/

[Chris Sherlock]

 accessibility/source/helper/characterattributeshelper.cxx  |2 +-
 chart2/source/controller/main/ChartController_TextEdit.cxx |2 +-
 chart2/source/tools/CharacterProperties.cxx|6 +++---
 cui/source/dialogs/cuicharmap.cxx  |2 +-
 cui/source/tabpages/chardlg.cxx|4 ++--
 editeng/source/editeng/editeng.cxx |2 +-
 editeng/source/editeng/eehtml.cxx  |6 +++---
 editeng/source/editeng/eertfpar.cxx|2 +-
 editeng/source/editeng/impedit4.cxx|2 +-
 editeng/source/editeng/textconv.cxx|2 +-
 editeng/source/items/bulitem.cxx   |4 ++--
 editeng/source/items/textitem.cxx  |4 ++--
 editeng/source/misc/acorrcfg.cxx   |4 ++--
 editeng/source/rtf/rtfitem.cxx |4 ++--
 editeng/source/uno/unofdesc.cxx|2 +-
 extensions/source/propctrlr/fontdialog.cxx |4 ++--
 filter/source/graphicfilter/eps/eps.cxx|2 +-
 filter/source/svg/svgwriter.cxx|4 ++--
 forms/source/richtext/richtextengine.cxx   |2 +-
 include/vcl/font.hxx   |4 ++--
 sc/source/core/data/docpool.cxx|2 +-
 sc/source/core/data/stlpool.cxx|2 +-
 sc/source/core/tool/autoform.cxx   |6 +++---
 sc/source/filter/excel/xlstyle.cxx |2 +-
 sc/source/ui/Accessibility/AccessibleCsvControl.cxx|2 +-
 sc/source/ui/drawfunc/drtxtob.cxx  |2 +-
 sc/source/ui/view/cellsh1.cxx  |2 +-
 sc/source/ui/view/editsh.cxx   |2 +-
 sc/source/ui/view/viewfun2.cxx |2 +-
 sd/source/core/drawdoc4.cxx|   12 ++--
 sd/source/core/stlpool.cxx |6 +++---
 sd/source/ui/annotations/annotationmanager.cxx |2 +-
 sd/source/ui/func/fubullet.cxx |2 +-
 sd/source/ui/func/fuhhconv.cxx |2 +-
 sd/source/ui/presenter/PresenterTextView.cxx   |2 +-
 starmath/source/cfgitem.cxx|2 +-
 starmath/source/document.cxx   |2 +-
 starmath/source/unomodel.cxx   |2 +-
 starmath/source/utility.cxx|8 
 svx/source/fmcomp/fmgridif.cxx |2 +-
 svx/source/svdraw/svdfmtf.cxx  |6 +++---
 svx/source/svdraw/svdmodel.cxx |6 +++---
 svx/source/tbxctrls/tbcontrl.cxx   |4 ++--
 sw/source/core/doc/DocumentStylePoolManager.cxx|8 
 sw/source/core/edit/autofmt.cxx|2 +-
 sw/source/core/text/txtfld.cxx |2 +-
 sw/source/core/txtnode/txtedt.cxx  |2 +-
 sw/source/filter/ascii/parasc.cxx  |2 +-
 sw/source/filter/html/htmlform.cxx |2 +-
 sw/source/filter/writer/writer.cxx |2 +-
 sw/source/filter/ww8/wrtw8num.cxx  |2 +-
 sw/source/ui/config/optpage.cxx|4 ++--
 sw/source/uibase/app/docshini.cxx  |6 +++---
 sw/source/uibase/lingu/hhcwrp.cxx  |4 ++--
 sw/source/uibase/shells/annotsh.cxx|2 +-
 sw/source/uibase/shells/drwtxtsh.cxx   |2 +-
 sw/source/uibase/shells/textsh.cxx |2 +-
 toolkit/source/helper/vclunohelper.cxx |2 +-
 vcl/source/components/fontident.cxx|2 +-
 vcl/source/filter/wmf/emfwr.cxx|2 +-
 vcl/source/filter/wmf/wmfwr.cxx|2 +-
 vcl/source/font/font.cxx   |4 ++--
 vcl/source/gdi/cvtsvm.cxx  |2 +-
 63 files changed, 100 insertions(+), 100 deletions(-)

New commits:
commit 5659b68be3acc08a1c70f1be05c99658f2b04e34
Author: Chris Sherlock 
Date:   Thu Jan 21 03:30:10 2016 +1100

vcl: rename Font::GetFamily to Font::GetFamilyType

Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254
Reviewed-on: https://gerrit.libreoffice.org/21633
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git 

[Libreoffice-commits] core.git: vcl/inc vcl/source

[Chris Sherlock]

 vcl/inc/impfont.hxx  |6 ++
 vcl/source/font/font.cxx |   10 +-
 2 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit 078194f6d0ede81042f38fb687f5cc3180a48ad0
Author: Chris Sherlock 
Date:   Thu Jan 21 14:41:01 2016 +1100

vcl: remove Font::GetFamily and Font::GetFamilyNoAsk (obsolete functions)

Change-Id: I345fe86b5cfe1dde1aa4082a7943e8a9f228fe03
Reviewed-on: https://gerrit.libreoffice.org/21649
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index 4cd79dc..cc87b2e 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -37,10 +37,8 @@ public:
 
 // device independent font functions
 const OUString& GetFamilyName() const   { 
return maFamilyName; }
-FontFamily  GetFamily() { 
if(meFamily==FAMILY_DONTKNOW)  AskConfig(); return meFamily; }
-FontFamily  GetFamilyNoAsk() const  { 
return meFamily; }
-FontFamily  GetFamilyType() { 
return GetFamily(); }
-FontFamily  GetFamilyTypeNoAsk() const  { 
return GetFamilyNoAsk(); }
+FontFamily  GetFamilyType() { 
if(meFamily==FAMILY_DONTKNOW)  AskConfig(); return meFamily; }
+FontFamily  GetFamilyTypeNoAsk() const  { 
return meFamily; }
 const OUString& GetStyleName() const{ 
return maStyleName; }
 
 FontWeight  GetWeight() { 
if(meWeight==WEIGHT_DONTKNOW)  AskConfig(); return meWeight; }
diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx
index ad38744..aa85d05 100644
--- a/vcl/source/font/font.cxx
+++ b/vcl/source/font/font.cxx
@@ -417,7 +417,7 @@ void Font::Merge( const vcl::Font& rFont )
 SetLanguageTag( rFont.GetLanguageTag() );
 SetCJKContextLanguageTag( rFont.GetCJKContextLanguageTag() );
 // don't use access methods here, might lead to AskConfig(), if 
DONTKNOW
-SetFamily( rFont.mpImplFont->GetFamilyNoAsk() );
+SetFamily( rFont.mpImplFont->GetFamilyTypeNoAsk() );
 SetPitch( rFont.mpImplFont->GetPitchNoAsk() );
 }
 
@@ -461,7 +461,7 @@ void Font::GetFontAttributes( FontAttributes& rAttrs ) const
 {
 rAttrs.SetFamilyName( mpImplFont->GetFamilyName() );
 rAttrs.SetStyleName( mpImplFont->maStyleName );
-rAttrs.SetFamilyType( mpImplFont->GetFamilyNoAsk() );
+rAttrs.SetFamilyType( mpImplFont->GetFamilyTypeNoAsk() );
 rAttrs.SetPitch( mpImplFont->GetPitchNoAsk() );
 rAttrs.SetItalic( mpImplFont->GetItalicNoAsk() );
 rAttrs.SetWeight( mpImplFont->GetWeightNoAsk() );
@@ -522,7 +522,7 @@ SvStream& WriteImplFont( SvStream& rOStm, const ImplFont& 
rImplFont )
 WritePair( rOStm, rImplFont.maSize );
 
 rOStm.WriteUInt16( GetStoreCharSet( rImplFont.GetCharSet() ) );
-rOStm.WriteUInt16( rImplFont.GetFamilyNoAsk() );
+rOStm.WriteUInt16( rImplFont.GetFamilyTypeNoAsk() );
 rOStm.WriteUInt16( rImplFont.GetPitchNoAsk() );
 rOStm.WriteUInt16( rImplFont.GetWeightNoAsk() );
 rOStm.WriteUInt16( rImplFont.meUnderline );
@@ -800,13 +800,13 @@ FontPitch Font::GetPitch() { return 
mpImplFont->GetPitch(); }
 FontWeight Font::GetWeight() { return mpImplFont->GetWeight(); }
 FontWidth Font::GetWidthType() { return mpImplFont->GetWidthType(); }
 FontItalic Font::GetItalic() { return mpImplFont->GetItalic(); }
-FontFamily Font::GetFamilyType() { return mpImplFont->GetFamily(); }
+FontFamily Font::GetFamilyType() { return mpImplFont->GetFamilyType(); }
 
 FontPitch Font::GetPitch() const { return mpImplFont->GetPitchNoAsk(); }
 FontWeight Font::GetWeight() const { return mpImplFont->GetWeightNoAsk(); }
 FontWidth Font::GetWidthType() const { return mpImplFont->GetWidthTypeNoAsk(); 
}
 FontItalic Font::GetItalic() const { return mpImplFont->GetItalicNoAsk(); }
-FontFamily Font::GetFamilyType() const { return mpImplFont->GetFamilyNoAsk(); }
+FontFamily Font::GetFamilyType() const { return 
mpImplFont->GetFamilyTypeNoAsk(); }
 
 int Font::GetQuality() const { return mpImplFont->GetQuality(); }
 void Font::SetQuality( int nQuality ) { mpImplFont->SetQuality( nQuality ); }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/qa vcl/source

[Chris Sherlock]

 include/vcl/font.hxx |2 ++
 vcl/inc/impfont.hxx  |   11 ++-
 vcl/qa/cppunit/font.cxx  |   13 +
 vcl/source/font/font.cxx |4 
 4 files changed, 25 insertions(+), 5 deletions(-)

New commits:
commit a5372932f787534d15d4e36ee8c297f3c6ac0888
Author: Chris Sherlock 
Date:   Thu Jan 21 15:13:22 2016 +1100

vcl: add subsettable flag property functions to Font class

Added getter and setter for subsettable flag property to the
Font class.

See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.

Unit test added to vcl/qa/cppunit/font.cxx to test this flag.

Change-Id: I2a66f1c4876698e1ffeaf260b2b43d5308b71191
Reviewed-on: https://gerrit.libreoffice.org/21651
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/include/vcl/font.hxx b/include/vcl/font.hxx
index 8cb34b6..498c6a5 100644
--- a/include/vcl/font.hxx
+++ b/include/vcl/font.hxx
@@ -87,6 +87,7 @@ public:
 
 boolIsBuiltInFont() const;
 boolCanEmbed() const;
+boolCanSubset() const;
 
 voidSetQuality(int);
 voidIncreaseQualityBy(int);
@@ -94,6 +95,7 @@ public:
 
 voidSetBuiltInFontFlag(bool);
 voidSetEmbeddableFlag(bool);
+voidSetSubsettableFlag(bool);
 
 // setting the color on the font is obsolete, the only remaining
 // valid use is for keeping backward compatibility with old MetaFiles
diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index cc87b2e..e522c28 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -37,8 +37,8 @@ public:
 
 // device independent font functions
 const OUString& GetFamilyName() const   { 
return maFamilyName; }
-FontFamily  GetFamilyType() { 
if(meFamily==FAMILY_DONTKNOW)  AskConfig(); return meFamily; }
-FontFamily  GetFamilyTypeNoAsk() const  { 
return meFamily; }
+FontFamily  GetFamilyType() { 
if(meFamily==FAMILY_DONTKNOW)  AskConfig(); return meFamily; }
+FontFamily  GetFamilyTypeNoAsk() const  { 
return meFamily; }
 const OUString& GetStyleName() const{ 
return maStyleName; }
 
 FontWeight  GetWeight() { 
if(meWeight==WEIGHT_DONTKNOW)  AskConfig(); return meWeight; }
@@ -75,7 +75,7 @@ public:
 
 boolIsBuiltInFont() const   { 
return mbDevice; }
 boolCanEmbed() const{ 
return mbEmbeddable; }
-/* Missing function: bool CanSubSet() const; */
+boolCanSubset() const   { 
return mbSubsettable; }
 /* Missing function: bool CanRotate() const; */
 /* Missing function: bool HasMapNames() const; */
 
@@ -84,7 +84,7 @@ public:
 
 voidSetBuiltInFontFlag( bool bIsBuiltInFont )   { 
mbDevice = bIsBuiltInFont; }
 voidSetEmbeddableFlag( bool bEmbeddable )   { 
mbEmbeddable = bEmbeddable; }
-/* Missing function: void SetSettableFlag( bool ); */
+voidSetSubsettableFlag( bool bSubsettable ) { 
mbSubsettable = bSubsettable; }
 /* missing function: void SetOrientationFlag( bool ); */
 
 booloperator==( const ImplFont& ) const;
@@ -123,7 +123,8 @@ private:
 mbVertical:1,
 mbTransparent:1,// compatibility, now on output 
device
 mbDevice:1,
-mbEmbeddable:1;
+mbEmbeddable:1,
+mbSubsettable:1;
 int mnQuality;
 
 friend SvStream&ReadImplFont( SvStream& rIStm, ImplFont& );
diff --git a/vcl/qa/cppunit/font.cxx b/vcl/qa/cppunit/font.cxx
index a57395c0..656d089 100644
--- a/vcl/qa/cppunit/font.cxx
+++ b/vcl/qa/cppunit/font.cxx
@@ -29,6 +29,7 @@ public:
 void testQuality();
 void testBuiltInFontFlag();
 void testEmbeddableFontFlag();
+void testSubsettableFontFlag();
 void testSymbolFlagAndCharSet();
 
 CPPUNIT_TEST_SUITE(VclFontTest);
@@ -40,6 +41,7 @@ public:
 CPPUNIT_TEST(testQuality);
 CPPUNIT_TEST(testBuiltInFontFlag);
 CPPUNIT_TEST(testEmbeddableFontFlag);
+CPPUNIT_TEST(testSubsettableFontFlag);
 CPPUNIT_TEST(testSymbolFlagAndCharSet);
 CPPUNIT_TEST_SUITE_END();
 };
@@ -133,6 +135,17 @@ void VclFontTest::testEmbeddableFontFlag()
 CPPUNIT_ASSERT_EQUAL( true, aFont.CanEmbed() );
 }
 
+
+void VclFontTest::testSubsettableFontFlag()
+{
+vcl::Font 

[Libreoffice-bugs] [Bug 97154] Partially wrong size for formulae in table cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97154

--- Comment #3 from Jean-Baptiste Faure  ---
Not reproducible for me means:
"When I reopen the document, some - and always the same - cells display a
different size." --> Idem for me
"When I click on the too small formula, they increase to the desired size." -->
Idem for me
"At reopening, the sizes are too small again." Not for me. Of course I assume
you saved the file before you closed and reopened it.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/qa vcl/source

[Chris Sherlock]

 include/vcl/font.hxx |2 ++
 vcl/inc/impfont.hxx  |9 +
 vcl/qa/cppunit/font.cxx  |   12 
 vcl/source/font/font.cxx |4 
 4 files changed, 23 insertions(+), 4 deletions(-)

New commits:
commit abf04f6b0ad0dd83b4d479723144593e2f83ede0
Author: Chris Sherlock 
Date:   Thu Jan 21 15:00:08 2016 +1100

vcl: add embeddable font property functions to Font class

Added setter and getter for embeddable font property to the
Font class.

See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.

Unit test added to vcl/qa/cppunit/font.cxx to test this flag.

Change-Id: I7f4ddf09d4a122c7c335b017efcb95f1774ae0d8
Reviewed-on: https://gerrit.libreoffice.org/21650
Tested-by: Jenkins 
Reviewed-by: Chris Sherlock 

diff --git a/include/vcl/font.hxx b/include/vcl/font.hxx
index 51ce742..dc7ab9e 100644
--- a/include/vcl/font.hxx
+++ b/include/vcl/font.hxx
@@ -86,12 +86,14 @@ public:
 int GetQuality() const;
 
 boolIsBuiltInFont() const;
+boolCanEmbed() const;
 
 voidSetQuality(int);
 voidIncreaseQualityBy(int);
 voidDecreaseQualityBy(int);
 
 voidSetBuiltInFontFlag(bool);
+voidSetEmbeddableFlag(bool);
 
 // setting the color on the font is obsolete, the only remaining
 // valid use is for keeping backward compatibility with old MetaFiles
diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index e7475e1..4cd79dc 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -63,6 +63,7 @@ public:
 voidSetItalic( const FontItalic eItalic )   { 
meItalic = eItalic; }
 voidSetWeight( const FontWeight eWeight )   { 
meWeight = eWeight; }
 voidSetWidthType( const FontWidth eWidthType )  { 
meWidthType = eWidthType; }
+voidSetCharSet( const rtl_TextEncoding eCharSet )   { 
meCharSet = eCharSet; }
 
 voidSetSymbolFlag( const bool bSymbolFlag ) { 
mbSymbol = bSymbolFlag; }
 
@@ -75,7 +76,7 @@ public:
 /* Missing function: OUString GetMapNames() const; */
 
 boolIsBuiltInFont() const   { 
return mbDevice; }
-/* Missing function: bool CanEmbed() const; */
+boolCanEmbed() const{ 
return mbEmbeddable; }
 /* Missing function: bool CanSubSet() const; */
 /* Missing function: bool CanRotate() const; */
 /* Missing function: bool HasMapNames() const; */
@@ -84,10 +85,9 @@ public:
 /* Missing function: void AddMapName( OUString const& ); */
 
 voidSetBuiltInFontFlag( bool bIsBuiltInFont )   { 
mbDevice = bIsBuiltInFont; }
-/* Missing function: void SetEmbeddableFlag( bool ); */
+voidSetEmbeddableFlag( bool bEmbeddable )   { 
mbEmbeddable = bEmbeddable; }
 /* Missing function: void SetSettableFlag( bool ); */
 /* missing function: void SetOrientationFlag( bool ); */
-voidSetCharSet( const rtl_TextEncoding eCharSet )   { 
meCharSet = eCharSet; }
 
 booloperator==( const ImplFont& ) const;
 
@@ -124,7 +124,8 @@ private:
 mbShadow:1,
 mbVertical:1,
 mbTransparent:1,// compatibility, now on output 
device
-mbDevice:1;
+mbDevice:1,
+mbEmbeddable:1;
 int mnQuality;
 
 friend SvStream&ReadImplFont( SvStream& rIStm, ImplFont& );
diff --git a/vcl/qa/cppunit/font.cxx b/vcl/qa/cppunit/font.cxx
index 224c8cd..a57395c0 100644
--- a/vcl/qa/cppunit/font.cxx
+++ b/vcl/qa/cppunit/font.cxx
@@ -28,6 +28,7 @@ public:
 void testItalic();
 void testQuality();
 void testBuiltInFontFlag();
+void testEmbeddableFontFlag();
 void testSymbolFlagAndCharSet();
 
 CPPUNIT_TEST_SUITE(VclFontTest);
@@ -38,6 +39,7 @@ public:
 CPPUNIT_TEST(testItalic);
 CPPUNIT_TEST(testQuality);
 CPPUNIT_TEST(testBuiltInFontFlag);
+CPPUNIT_TEST(testEmbeddableFontFlag);
 CPPUNIT_TEST(testSymbolFlagAndCharSet);
 CPPUNIT_TEST_SUITE_END();
 };
@@ -121,6 +123,16 @@ void VclFontTest::testBuiltInFontFlag()
 CPPUNIT_ASSERT_EQUAL( true, aFont.IsBuiltInFont() );
 }
 
+void VclFontTest::testEmbeddableFontFlag()
+{
+vcl::Font aFont;
+
+CPPUNIT_ASSERT_EQUAL( false, aFont.CanEmbed() );
+
+aFont.SetEmbeddableFlag( true );
+CPPUNIT_ASSERT_EQUAL( true, aFont.CanEmbed() );
+}
+
 void VclFontTest::testSymbolFlagAndCharSet()
 {
 // default constructor should set scalable flag to false
diff --git 

[Libreoffice-bugs] [Bug 91291] EDITING: Crash when moving rtl text with footnote with continuation onto the next page

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91291

--- Comment #6 from Ali Yousuf  ---

(In reply to Beluga from comment #2)
> Reproduced with example document.
> Debug message appearing with 5.0 crash:
> 
> warn:legacy.osl:3119:1:sw/source/core/text/txtftn.cxx:1100: Quo Vadis, rest
> of QuoVadisPortion
if you look at the file :libreoffice/sw/source/core/text/porlin.cxx:250
if you comment this two line below,no crash.
250   //Height( pLast->Height() );
251   //SetAscent( pLast->GetAscent() )
;
so, The problem on the "pLast->Height()" and "pLast->GetAscent()"
> 
> I daresay, that is a smashing warning message.
> 
> Ubuntu 15.04 64-bit 
> Version: 5.0.0.0.alpha1+
> Build ID: 51d16cc69d8ad9065f61d108ea25d6a025a2e228
> TinderBox: Linux-rpm_deb-x86_64@46-TDF-dbg, Branch:master, Time:
> 2015-05-17_03:58:58
> Locale: en-US (en_US.UTF-8)
> 
> OpenOffice.org 3.3.0
> OOO330m20 (Build:9567)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Problem in build: make check stuck in vcl_filters_test

[Chris Sherlock]

I saw something similar when I submitted a patch to Jenkins. 

The Console output is here:

http://ci.libreoffice.org/job/lo_gerrit_master/10748/Gerrit=Gerrit,Platform=Linux/console

The build actually aborted after 30 minutes, and it doesn’t appear to have 
aborted on a unit test (unless I’m misreading the output).

Gerrit commit is:

https://gerrit.libreoffice.org/#/c/21627/

Not sure if it’s the same thing though, but figure I should mention it here.

Chris


> On 21 Jan 2016, at 7:53 AM, Giuseppe Castagno 
>  wrote:
> 
> Hi all,
> 
> Ubuntu 14.04
> master ca27812
> 
> autogen.lastrun:
> 
> CC=clang-3.6
> CXX=clang++-3.6
> CLANGDIR=/usr/lib/llvm-3.6
> --disable-ccache
> --with-vendor=Acca Esse, I-10067
> --with-external-tar=/srv5/git/LO/externals
> --with-lang=en-US
> --enable-sal-log
> --enable-compiler-plugins
> 
> after a successful build with:
> 
> make build-nocheck
> 
> trying with:
> 
> PARALLELISM=1 make check
> 
> I got:
> 
> [build CUT] vcl_complextext
> [build CUT] vcl_filters_test
> 
> stuck on HDU access, actually freezing the PC
> 
> After around 10 minutes waiting, I killed the build.
> 
> Thanks,
> 
> -- 
> Kind Regards,
> Giuseppe Castagno aka beppec56
> Acca Esse http://www.acca-esse.eu
> giuseppe.castagno at acca-esse.eu
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

web site

[alfieri morillo]

Hello good evening, I am responsible for libreoffice Venezuela and its web, I
wonder if the theme used on its official website available for the use of
the web that we work through our websites occurs to me that we can all
use a single
subject as the default, I hope not bother, thank you very much! Reference I
leave the place I've been




http://libreoffice-ve.net/

  github.com/cyberthrone/
  https://launchpad.net/~alfierimorillo
  Ubuntu User number is # 35087
  Public profile linux for user #97
  Cofundador de OpenHack-Ve
  Fundador de Gimp-Ve
  https://wiki.ubuntu.com/Alfierimorillo 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97271] LO 5.0 is installed alongside LO 4.4.7.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97271

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jbfa...@libreoffice.org
 Resolution|--- |NOTABUG

--- Comment #2 from Jean-Baptiste Faure  ---
(In reply to MM from comment #1)
> This is normal: https://wiki.documentfoundation.org/Installing_in_parallel
> If something isn't working on a newer version, you always try a previous
> version and continue working.
> If you don't wanna have the old version, just uninstall it.

Indeed. Closing as NotABug.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96981] After starting formula in Sheet1, we are unable to select all cells in Sheet2 with the row and column heading corner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96981

Beluga  changed:

   What|Removed |Added

Summary|Select Entire Sheet |After starting formula in
   |creating formula|Sheet1, we are unable to
   ||select all cells in Sheet2
   ||with the row and column
   ||heading corner

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svgio/source

[Xisco Fauli]

 svgio/source/svgreader/svgcharacternode.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e941434d98fa1500ad85be3ff59117d62ac8bc24
Author: Xisco Fauli 
Date:   Wed Jan 20 18:43:03 2016 +0100

tdf#85770 reuse variable instead of getting it again

Change-Id: I268fd695e4cfd91dc8aba2b098911dbd9cf02ad7
Reviewed-on: https://gerrit.libreoffice.org/21639
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/svgio/source/svgreader/svgcharacternode.cxx 
b/svgio/source/svgreader/svgcharacternode.cxx
index e5bc0a5..b50aedc 100644
--- a/svgio/source/svgreader/svgcharacternode.cxx
+++ b/svgio/source/svgreader/svgcharacternode.cxx
@@ -510,7 +510,7 @@ namespace svgio
 rSvgTextPosition,
 rSvgStyleAttributes));
 
-if(xRef.is() && (Visibility_visible == 
getSvgStyleAttributes()->getVisibility()))
+if(xRef.is() && (Visibility_visible == 
rSvgStyleAttributes.getVisibility()))
 {
 if(!rSvgTextPosition.isRotated())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97253] Cell function lost when copying chart from Calc to Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97253

--- Comment #7 from Walter Cheuk  ---
If I need all the functionalities of the original chart, why can't I do it in a
simple 'copy & paste' action? Also there is no easy way to create chart from
the data of an inserted spreadsheet (I can't find it yet).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 85770] In svg image, visibility does not work for tspan

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=85770

--- Comment #7 from Commit Notification 
 ---
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=e941434d98fa1500ad85be3ff59117d62ac8bc24

tdf#85770 reuse variable instead of getting it again

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 84416] 3-D slide transitions not working on Windows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=84416

--- Comment #17 from kompilainenn <79045_79...@mail.ru> ---
> We should identify which of the transitions require 3.2+ and also mention
> that in the release notes.

easier to write that all transitions requires version 3.2+

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Failures in OS X builds - too many errors?

[Chris Sherlock]

Hi all, 

I think that something odd is happening in the compilation of the boost 
library, I’m getting an error on Jenkins that there are too many failures in 
the compilation process. 

I think it’s normal to have the errors, is it just that we need to add a switch 
to clang to not limit errors? Don’t know the impact this would have 
unfortunately. 

Gerrit submission is:

https://gerrit.libreoffice.org/#/c/21633/ 


Console log output is here:

http://ci.libreoffice.org/job/lo_gerrit_master/10759/Gerrit=Gerrit,Platform=MacOSX/console
 


Oddly enough, when I build on my own OS X system (which I *finally* managed to 
get working… sort of), I don’t get the same error. 

I think someone mentioned on IRC last night that this might only occur on 
systems where make clean was run, or something along those lines. 

Apologies if this is something already fixed, I thought I’d just ask on the 
list because OS X is not my strong-suit (yet). 

Oh, I should note that I am currently getting a failure in 
Cppunittest_sw_ooxmlimport:

Test name: testGroupshapeChildRotation::Import
equality assertion failed
- Expected: 686
- Actual  : 688

Failures !!!
Run: 208   Failure total: 1   Failures: 1   Errors: 0

Maybe it’s related? Though that seems a bit unlikely. I didn’t see any 
tinderbox failures, so I’m a bit surprised it’s happening on my system though!

Chris

---

A snippet of the log is:

In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/sal/cppunittester/cppunittester.cxx:57:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/algorithm/string.hpp:23:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/algorithm/string/split.hpp:16:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/algorithm/string/iter_find.hpp:27:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/algorithm/string/find_iterator.hpp:24:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/algorithm/string/detail/find_iterator.hpp:18:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/function.hpp:64:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/preprocessor/iteration/detail/iter/forward1.hpp:87:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/function/detail/function_iterate.hpp:14:
In file included from 
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/function/detail/maybe_include.hpp:53:
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/UnpackedTarball/boost/boost/function/function_template.hpp:574:32:
 error: unknown warning group '-Wpragmas', ignored [-Werror,-Wunknown-pragmas]
#pragma GCC diagnostic ignored "-Wpragmas"
   ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
[build CXX] sal/qa/rtl/strings/test_oustring_compare.cxx
20 errors generated.
/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/solenv/gbuild/LinkTarget.mk:189:
 recipe for target 
'/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/CxxObject/sal/cppunittester/cppunittester.o'
 failed
make[1]: *** 
[/Users/tdf/lode/jenkins/workspace/lo_gerrit_master/Gerrit/Gerrit/Platform/MacOSX/workdir/CxxObject/sal/cppunittester/cppunittester.o]
 Error 1
make[1]: *** Waiting for unfinished jobs
Makefile:247: recipe for target 'build' failed
make: *** [build] Error 2
Build step 'Execute shell' marked build as failure
Finished: FAILURE



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

--- Comment #6 from Samuel Mehrbrodt  ---
(In reply to Wolfgang Jäger from comment #5)
> You surely can help me to find it.

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b0fb87fbac36ef9fbf3dfeac0f1372617f4b3e4
has a reference to a wiki article which contains an analysis of options which
are not necessary to have in the UI, because they are too advanced. All of them
are available in expert config though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97287] New: Sending eMailing fails and crashes Libreoffice

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97287

Bug ID: 97287
   Summary: Sending eMailing fails and crashes Libreoffice
   Product: LibreOffice
   Version: 5.0.4.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: fchampr...@gmail.com

Created attachment 122122
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122122=edit
Screen shot and failing documents

I am trying to send eMails resulting from the mailing assistant. Merged files
are generated as PDF.
The document is correctly prepared and generates only 1 eMail for the test.
When I press "Envoyer les documents" (send documents) an error is raised. When
I press OK, LibreOffice closes.
Note : I just upgraded to 5.0 because the problem was already present in 4.4.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54933] EDITING Report builder: mouse-move control: gap between mouse position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=54933

Roberto  changed:

   What|Removed |Added

   Severity|enhancement |normal

--- Comment #35 from Roberto  ---
Just informing that I accidentally changed the importance to 'enhancement' for
a while (I am really sorry, I didn't realize that I was editing the wrong bug).
I don't remember the original status, so I'm changing it back to 'normal', just
like Joel Madero did, according to Comment 11.

Finally, I sincerely offer you my apologies for the troubles this mistake might
cause to you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: android/Bootstrap

[Peter Foley]

 android/Bootstrap/Makefile.shared |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 2879dceaf56df81734bf36e1d20c973de0a5aa29
Author: Peter Foley 
Date:   Mon Jan 18 17:08:47 2016 -0500

improve android build status reporting

Change-Id: I29f404dc5aee27b592eac7585c5142b91060fe5c
Reviewed-on: https://gerrit.libreoffice.org/21589
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/android/Bootstrap/Makefile.shared 
b/android/Bootstrap/Makefile.shared
index 2edf7c3..e265305 100644
--- a/android/Bootstrap/Makefile.shared
+++ b/android/Bootstrap/Makefile.shared
@@ -44,6 +44,7 @@ WHOLELIBS = \
 
 
 $(OBJLOCAL)/liblo-native-code.so : native-code.cxx $(ALL_STATIC_LIBS)
+   @echo "Linking $@"
mkdir -p $(OBJLOCAL)
$(CXX) -Wl,--build-id=sha1 -Wl,--gc-sections 
-Wl,--version-script=../Bootstrap/version.map -Wl,--no-keep-files-mapped 
-Wl,--no-undefined -DANDROID -DDISABLE_DYNLOADING -shared -o 
$(OBJLOCAL)/liblo-native-code.so -I$(BUILDDIR)/config_host -I$(SRCDIR)/include 
native-code.cxx -L$(INSTDIR)/$(LIBO_LIB_FOLDER) $(WHOLELIBS) $(LIBS) 
-lgnustl_static -lGLESv2 -landroid -ljnigraphics -llog -lz
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - desktop/qa sc/sdi sc/source

[Jan Holesovsky]

 desktop/qa/data/sheets.ods  |binary
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   34 
 sc/sdi/scalc.sdi|4 -
 sc/source/core/data/document.cxx|9 +++
 sc/source/ui/view/tabvwshf.cxx  |   77 
 5 files changed, 100 insertions(+), 24 deletions(-)

New commits:
commit 77c677a41d4bc9a2cd71ea1cc17e6c836387a6c5
Author: Jan Holesovsky 
Date:   Thu Jan 21 00:42:59 2016 +0100

sc lok: Implement unit test for .uno:{Insert,Name,Remove} for sheets.

And fix indexing when at that - the inserting is 1-based, so let's be
consistent in the .uno:Name and .uno:Remove too.

Change-Id: Ib854e81551ae0a39d3ba7c68512e81ea227e9eb1

diff --git a/desktop/qa/data/sheets.ods b/desktop/qa/data/sheets.ods
new file mode 100644
index 000..42226b2
Binary files /dev/null and b/desktop/qa/data/sheets.ods differ
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index dc870bf..abda86b 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -83,6 +83,7 @@ public:
 void testCommandResult();
 void testWriterComments();
 void testModifiedStatus();
+void testSheetOperations();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testGetStyles);
@@ -102,6 +103,7 @@ public:
 CPPUNIT_TEST(testCommandResult);
 CPPUNIT_TEST(testWriterComments);
 CPPUNIT_TEST(testModifiedStatus);
+CPPUNIT_TEST(testSheetOperations);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
@@ -640,6 +642,38 @@ void DesktopLOKTest::testModifiedStatus()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+void DesktopLOKTest::testSheetOperations()
+{
+comphelper::LibreOfficeKit::setActive(true);
+LibLODocument_Impl* pDocument = loadDoc("sheets.ods");
+
+// insert the last sheet
+pDocument->pClass->postUnoCommand(pDocument, ".uno:Insert",
+  "{ \"Name\": { \"type\": \"string\", \"value\": \"LastSheet\" }, 
\"Index\": { \"type\": \"long\", \"value\": 0 } }", false);
+
+// insert the first sheet
+pDocument->pClass->postUnoCommand(pDocument, ".uno:Insert",
+  "{ \"Name\": { \"type\": \"string\", \"value\": \"FirstSheet\" }, 
\"Index\": { \"type\": \"long\", \"value\": 1 } }", false);
+
+// rename the \"Sheet1\" (2nd now) to \"Renamed\"
+pDocument->pClass->postUnoCommand(pDocument, ".uno:Name",
+  "{ \"Name\": { \"type\": \"string\", \"value\": \"Renamed\" }, 
\"Index\": { \"type\": \"long\", \"value\": 2 } }", false);
+
+// delete the \"Sheet2\" (3rd)
+pDocument->pClass->postUnoCommand(pDocument, ".uno:Remove",
+  "{ \"Index\": { \"type\": \"long\", \"value\": 3 } }", false);
+
+CPPUNIT_ASSERT_EQUAL(pDocument->pClass->getParts(pDocument), 6);
+
+std::vector pExpected = { "FirstSheet", "Renamed", "Sheet3", 
"Sheet4", "Sheet5", "LastSheet" };
+for (int i = 0; i < 6; ++i)
+{
+CPPUNIT_ASSERT_EQUAL(pExpected[i], 
OString(pDocument->pClass->getPartName(pDocument, i)));
+}
+
+comphelper::LibreOfficeKit::setActive(false);
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/sc/source/ui/view/tabvwshf.cxx b/sc/source/ui/view/tabvwshf.cxx
index d22ece2..8a56bfd 100644
--- a/sc/source/ui/view/tabvwshf.cxx
+++ b/sc/source/ui/view/tabvwshf.cxx
@@ -332,8 +332,14 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
 OUString  aName;
 
 if( pReqArgs->HasItem( FN_PARAM_1,  ) )
+{
 nTabNr = static_cast(pItem)->GetValue();
 
+// inserting is 1-based, let's be consistent
+if (nTabNr > 0)
+--nTabNr;
+}
+
 if( pReqArgs->HasItem( nSlot,  ) )
 aName = static_cast(pItem)->GetValue();
 
@@ -570,12 +576,18 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )
 bool bHasIndex = (pReqArgs != nullptr);
 
 // allow removing via the Index/FID_DELETE_TABLE parameter
-SCTAB nIndexTab = nCurrentTab;
+SCTAB nTabNr = nCurrentTab;
 if (bHasIndex)
 {
 const SfxPoolItem* pItem;
 if (pReqArgs->HasItem(FID_DELETE_TABLE, ))
-nIndexTab = static_cast(pItem)->GetValue();
+{
+nTabNr = static_cast(pItem)->GetValue();
+
+// inserting is 1-based, let's be consistent
+if (nTabNr > 0)
+--nTabNr;
+}
 }
 
 bool bDoIt = bHasIndex;
@@ -597,8 +609,8 @@ void ScTabViewShell::ExecuteTable( SfxRequest& rReq )

[Libreoffice-bugs] [Bug 96948] Application background doesn't update

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96948

raal  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected, bisected
 CC||r...@post.cz

--- Comment #4 from raal  ---
This seems to have begun at the below commit.

3661beb825a44983b9380c7ff688bd38cc58e5ad is the first bad commit
commit 3661beb825a44983b9380c7ff688bd38cc58e5ad
Author: Norbert Thiebaud 
Date:   Tue Jul 21 20:10:59 2015 -0700

source sha:1c481fe6522f4c7d883e77a4ac32f855b9bcb323

source sha:1c481fe6522f4c7d883e77a4ac32f855b9bcb323

:04 04 53042d72617e6aa7d58de6e6d1c5d64763459316
b3cf12aca9adb1e53ee51a787421844e21660651 M  instdir

authorKatarina Behrens 2015-06-25 07:47:37
(GMT)
committerKatarina Behrens 2015-06-26 09:56:15
(GMT)
commit1c481fe6522f4c7d883e77a4ac32f855b9bcb323 (patch)
tdf#87905: Use darker background colour for master view

/bibisect-win32-5.1latest
$ git bisect log
# bad: [91e9e2012e13c47548965e3b0626eb9ca9ba68d1] source
sha:ff2bdd52f54db24f867957a3293fae08e6a431a3
# good: [c1efd324c6ad448ac9edb030dc9738b9e6899e4d] source
sha:ab465b90f6c6da5595393a0ba73f33a1e71a2b65
git bisect start 'origin/master' 'c1efd324c6ad448ac9edb030dc9738b9e6899e4d'
# bad: [99ec4939f7e2ca3f43b4c7c5b077abfbe676d128] source
sha:a01a0785e61d230cc8e2fb15cc1936f1fd29458a
git bisect bad 99ec4939f7e2ca3f43b4c7c5b077abfbe676d128
# bad: [097c0df425db205a1549d3102eb0e219ed2be6eb] source
sha:4d0e9102d890ce0085986ca3946aeb8d99769b4a
git bisect bad 097c0df425db205a1549d3102eb0e219ed2be6eb
# good: [295cf5c3b1d518448568eaefa74e3e50fff8b238] source
sha:fd29a623e7c7b4d859c55f1f04463b5705ad47bf
git bisect good 295cf5c3b1d518448568eaefa74e3e50fff8b238
# good: [ef3f297d418dc76f42d03379c0871c5ffdd0a6f8] source
sha:0c33e10b594aa07c4e9adadae59e5c03a4fdc29c
git bisect good ef3f297d418dc76f42d03379c0871c5ffdd0a6f8
# bad: [fb136c3e7b407e6a16a9470862aa11d17ba8a24e] source
sha:8c30d8bbb8a0b3682160252ee065befabf613a7b
git bisect bad fb136c3e7b407e6a16a9470862aa11d17ba8a24e
# bad: [55b8c7cb68981258f1decdd8697baca11f24b9fd] source
sha:e159201777cbae736c7890ca3c0f5a98614e9161
git bisect bad 55b8c7cb68981258f1decdd8697baca11f24b9fd
# bad: [b03039284b9f36a72d14e095dea67d576264b274] source
sha:c1e12b15e55a82f062960f40921e0c97afda2078
git bisect bad b03039284b9f36a72d14e095dea67d576264b274
# bad: [67ed2c3a55d0c717aec4ebf61a705326cf2a86ae] source
sha:6aa627c662fd83b64b48d4e7647d768915d1f746
git bisect bad 67ed2c3a55d0c717aec4ebf61a705326cf2a86ae
# good: [542378626b94e5b1b236a8c86751ce23b6d1788f] source
sha:682e35944391f7f467636ee273290ee894c0f2a0
git bisect good 542378626b94e5b1b236a8c86751ce23b6d1788f
# bad: [2ba2e52250ae61a203a4a2d2a4514336819328d0] source
sha:05e50b570f602c17218bb6e82bcaac2fbdd943c1
git bisect bad 2ba2e52250ae61a203a4a2d2a4514336819328d0
# good: [cc9128ce4d6ae71d373798bb22af5ee6a42b9231] source
sha:eab89b7f024a8c86decdcb3362c40c40a7df37df
git bisect good cc9128ce4d6ae71d373798bb22af5ee6a42b9231
# bad: [3661beb825a44983b9380c7ff688bd38cc58e5ad] source
sha:1c481fe6522f4c7d883e77a4ac32f855b9bcb323
git bisect bad 3661beb825a44983b9380c7ff688bd38cc58e5ad
# good: [86000d4f245969e6ccaf5bfc97e17fbe197d0d5e] source
sha:af8143bc40cf2cfbc12e77c9bb7de01b655f7b30
git bisect good 86000d4f245969e6ccaf5bfc97e17fbe197d0d5e
# first bad commit: [3661beb825a44983b9380c7ff688bd38cc58e5ad] source
sha:1c481fe6522f4c7d883e77a4ac32f855b9bcb323

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - xmloff/source

[Laurent Balland-Poirier]

 xmloff/source/style/xmlnumfe.cxx |   16 ++--
 xmloff/source/style/xmlnumfi.cxx |   19 +--
 2 files changed, 27 insertions(+), 8 deletions(-)

New commits:
commit 50a3c6b2f3b849885580b304929eabe4a71b9162
Author: Laurent Balland-Poirier 
Date:   Wed Dec 30 23:32:15 2015 +0100

tdf#40517 Export/Import in ODF decimal replacement with space

Number format such as "0.???" is saved in ODF with 
number:decimal-replacement=" "

Change-Id: I0dd19b5ea126f380bcf17a3ccc5d8c355119e23b
Reviewed-on: https://gerrit.libreoffice.org/21021
Tested-by: Jenkins 
Reviewed-by: jan iversen 
(cherry picked from commit 3ee66e306cf0ca9c2b56de26c28e8130d7b72f64)
Reviewed-on: https://gerrit.libreoffice.org/21613
Tested-by: jan iversen 

diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 136c3d2..41c549d 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -1179,6 +1179,7 @@ void SvXMLNumFmtExport::ExportPart_Impl( const 
SvNumberformat& rFormat, sal_uInt
 bool bCurrFound  = false;
 bool bInInteger  = true;
 bool bExpSign = true;
+bool bDecAlign   = false;   // decimal alignment with "?"
 sal_Int32 nExpDigits = 0;
 sal_Int32 nIntegerSymbols = 0;  // for embedded-text, 
including "#"
 sal_Int32 nTrailingThousands = 0;   // thousands-separators after 
all digits
@@ -1207,9 +1208,17 @@ void SvXMLNumFmtExport::ExportPart_Impl( const 
SvNumberformat& rFormat, sal_uInt
 }
 else if ( !bInInteger && pElemStr )
 {
-for ( sal_Int32 i = pElemStr->getLength()-1; i >= 0 && 
(*pElemStr)[i] == '#'; i-- )
+for ( sal_Int32 i = pElemStr->getLength()-1; i >= 0 ; 
i-- )
 {
-nMinDecimals --;
+sal_Unicode aChar = (*pElemStr)[i];
+if ( aChar == '#' || aChar == '?' )
+{
+nMinDecimals --;
+if ( aChar == '?' )
+bDecAlign = true;
+}
+else
+break;
 }
 }
 if ( bInInteger && pElemStr )
@@ -1429,6 +1438,9 @@ void SvXMLNumFmtExport::ExportPart_Impl( const 
SvNumberformat& rFormat, sal_uInt
 OUStringBuffer sDashStr;
 if (bDecDashes && nPrecision > 0)
 
comphelper::string::padToLength(sDashStr, nPrecision, '-');
+// "?" in decimal part are replaced by 
space character
+if (bDecAlign && nPrecision > 0)
+sDashStr = " ";
 
 WriteNumberElement_Impl(nDecimals, 
nMinDecimals, nInteger, sDashStr.makeStringAndClear(),
 bThousand, nTrailingThousands, 
aEmbeddedEntries);
diff --git a/xmloff/source/style/xmlnumfi.cxx b/xmloff/source/style/xmlnumfi.cxx
index db1edc7..bb8f97f 100644
--- a/xmloff/source/style/xmlnumfi.cxx
+++ b/xmloff/source/style/xmlnumfi.cxx
@@ -102,6 +102,7 @@ struct SvXMLNumberInfo
 boolbGrouping;
 boolbDecReplace;
 boolbExpSign;
+boolbDecAlign;
 double  fDisplayFactor;
 std::map m_EmbeddedElements;
 
@@ -109,7 +110,7 @@ struct SvXMLNumberInfo
 {
 nDecimals = nInteger = nExpDigits = nExpInterval = nNumerDigits = 
nDenomDigits =
 nFracDenominator = nMinDecimalDigits = -1;
-bGrouping = bDecReplace = false;
+bGrouping = bDecReplace = bDecAlign = false;
 bExpSign = true;
 fDisplayFactor = 1.0;
 }
@@ -948,10 +949,16 @@ SvXMLNumFmtElementContext::SvXMLNumFmtElementContext( 
SvXMLImport& rImport,
 aNumInfo.fDisplayFactor = fAttrDouble;
 break;
 case XML_TOK_ELEM_ATTR_DECIMAL_REPLACEMENT:
-if ( !sValue.isEmpty() )
-aNumInfo.bDecReplace = true;// only a default string 
is supported
+if ( sValue == " " )
+{
+aNumInfo.bDecAlign = true; // space replacement for "?"
+bVarDecimals = true;
+}
 else
-bVarDecimals = true;   // empty replacement string: 
variable decimals
+if ( sValue.isEmpty() )
+bVarDecimals = true;   // empty replacement string: 
variable decimals
+ 

[Libreoffice-bugs] [Bug 93478] HSQLDB doesn't support newlines in column name in a database connected to a spreadsheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93478

Alex Thurgood (retired)  changed:

   What|Removed |Added

Summary|5.0.0 RC5/HSQLDB doesn't|HSQLDB doesn't support
   |support newlines in column  |newlines in column name in
   |name in a database  |a database connected to a
   |connected to a spreadsheet  |spreadsheet

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: lotuswordpro/source lotuswordpro/util

[kripton]

 lotuswordpro/source/filter/LotusWordProImportFilter.cxx |7 
 lotuswordpro/source/filter/genericfilter.cxx|   25 
 lotuswordpro/util/lwpfilter.component   |3 +
 3 files changed, 9 insertions(+), 26 deletions(-)

New commits:
commit ea6fdbaeeb51ad695f1c3754b796b7273eb4baad
Author: kripton 
Date:   Tue Jan 19 23:42:38 2016 +0200

tdf#74608 lotuswordpro: Constructor feature for LotusWordProImportFilter

Change-Id: I51aba68e1a220f7cf953978a10b6b62a922c989b
Reviewed-on: https://gerrit.libreoffice.org/21614
Tested-by: Jenkins 
Reviewed-by: jan iversen 
Tested-by: jan iversen 

diff --git a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx 
b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
index ce185d2..3f7cab5 100644
--- a/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
+++ b/lotuswordpro/source/filter/LotusWordProImportFilter.cxx
@@ -97,6 +97,13 @@ extern "C" SAL_DLLPUBLIC_EXPORT bool SAL_CALL 
TestImportLWP(const OUString 
 return ( ReadWordproFile(aFileStream, xHandler) == 0 );
 }
 
+extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface * SAL_CALL
+LotusWordProImportFilter_get_implementation(
+css::uno::XComponentContext *context)
+ {
+return cppu::acquire(new LotusWordProImportFilter(context));
+ }
+
 sal_Bool SAL_CALL LotusWordProImportFilter::filter( const Sequence< 
css::beans::PropertyValue >& aDescriptor )
 throw (RuntimeException, std::exception)
 {
diff --git a/lotuswordpro/source/filter/genericfilter.cxx 
b/lotuswordpro/source/filter/genericfilter.cxx
index 862f332..837ba1a 100644
--- a/lotuswordpro/source/filter/genericfilter.cxx
+++ b/lotuswordpro/source/filter/genericfilter.cxx
@@ -11,30 +11,5 @@ using namespace ::com::sun::star::uno;
 using namespace ::com::sun::star::lang;
 using namespace ::com::sun::star::registry;
 
-extern "C"
-{
-SAL_DLLPUBLIC_EXPORT void * SAL_CALL lotuswordpro_component_getFactory(
-const sal_Char * pImplName, void * pServiceManager, void * 
/*pRegistryKey*/ )
-{
-void * pRet = nullptr;
-
-OUString implName = OUString::createFromAscii( pImplName );
-if ( pServiceManager && 
implName.equals(LotusWordProImportFilter_getImplementationName()) )
-{
-Reference< XSingleServiceFactory > xFactory( createSingleFactory(
-static_cast< XMultiServiceFactory * >( pServiceManager ),
-OUString::createFromAscii( pImplName ),
-LotusWordProImportFilter_createInstance, 
LotusWordProImportFilter_getSupportedServiceNames() ) );
-
-if (xFactory.is())
-{
-xFactory->acquire();
-pRet = xFactory.get();
-}
-}
-
-return pRet;
-}
-}
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/lotuswordpro/util/lwpfilter.component 
b/lotuswordpro/util/lwpfilter.component
index 5ead1c8..bd007fb 100644
--- a/lotuswordpro/util/lwpfilter.component
+++ b/lotuswordpro/util/lwpfilter.component
@@ -1,7 +1,8 @@
 
 http://openoffice.org/2010/uno-components;>
-  
+  
 
 
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 74608] Constructor functions for UNO component implementations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74608

--- Comment #22 from Commit Notification 
 ---
kripton committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea6fdbaeeb51ad695f1c3754b796b7273eb4baad

tdf#74608 lotuswordpro: Constructor feature for LotusWordProImportFilter

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: basegfx/source canvas/source compilerplugins/clang connectivity/source desktop/inc desktop/source fpicker/source include/basegfx include/vcl sc/source sd/source sfx2/so

[Noel Grandin]

 basegfx/source/polygon/b2dpolypolygontools.cxx|   29 -
 basegfx/source/tools/canvastools.cxx  |8 -
 canvas/source/vcl/canvasbitmaphelper.hxx  |2 
 canvas/source/vcl/canvashelper.hxx|2 
 compilerplugins/clang/unusedmethods.py|   11 +
 connectivity/source/drivers/jdbc/DriverPropertyInfo.cxx   |   56 
--
 connectivity/source/drivers/mork/MPreparedStatement.cxx   |6 -
 connectivity/source/drivers/mork/MPreparedStatement.hxx   |2 
 connectivity/source/inc/java/sql/DriverPropertyInfo.hxx   |4 
 desktop/inc/app.hxx   |4 
 desktop/source/app/app.cxx|3 
 fpicker/source/office/OfficeFilePicker.cxx|7 -
 include/basegfx/color/bcolor.hxx  |3 
 include/basegfx/polygon/b2dpolypolygontools.hxx   |4 
 include/basegfx/range/b2ibox.hxx  |   18 ---
 include/basegfx/tools/canvastools.hxx |   13 --
 include/basegfx/tools/rectcliptools.hxx   |   18 ---
 include/vcl/pdfwriter.hxx |   35 +-
 include/vcl/slider.hxx|4 
 include/vcl/svapp.hxx |4 
 sc/source/filter/html/htmlexp.cxx |4 
 sc/source/filter/inc/htmlexp.hxx  |2 
 sc/source/filter/inc/rtfexp.hxx   |2 
 sc/source/filter/rtf/rtfexp.cxx   |3 
 sd/source/ui/slidesorter/controller/SlideSorterController.cxx |   14 --
 sd/source/ui/slidesorter/inc/controller/SlideSorterController.hxx |4 
 sfx2/source/dialog/templdlg.cxx   |6 -
 sfx2/source/inc/templdgi.hxx  |2 
 svtools/source/contnr/svimpbox.cxx|6 -
 svtools/source/inc/svimpbox.hxx   |2 
 svtools/source/uno/treecontrolpeer.cxx|8 -
 sw/inc/dbmgr.hxx  |7 -
 sw/inc/doc.hxx|4 
 sw/inc/editsh.hxx |4 
 sw/inc/expfld.hxx |2 
 sw/inc/fesh.hxx   |2 
 sw/inc/ndtxt.hxx  |2 
 sw/inc/node.hxx   |2 
 sw/inc/pam.hxx|2 
 sw/inc/shellio.hxx|2 
 sw/inc/tox.hxx|6 -
 sw/inc/txtftn.hxx |2 
 sw/inc/view.hxx   |2 
 sw/inc/viewsh.hxx |2 
 sw/source/core/crsr/pam.cxx   |3 
 sw/source/core/doc/docruby.cxx|4 
 sw/source/core/doc/doctxm.cxx |9 -
 sw/source/core/docnode/node.cxx   |3 
 sw/source/core/edit/editsh.cxx|3 
 sw/source/core/edit/edtox.cxx |4 
 sw/source/core/fields/expfld.cxx  |7 -
 sw/source/core/frmedt/feshview.cxx|5 
 sw/source/core/inc/SwXMLBlockExport.hxx   |2 
 sw/source/core/inc/frmtool.hxx|4 
 sw/source/core/inc/scriptinfo.hxx |3 
 sw/source/core/inc/txtfrm.hxx |2 
 sw/source/core/layout/frmtool.cxx |6 -
 sw/source/core/swg/SwXMLBlockExport.cxx   |3 
 sw/source/core/swg/swblocks.cxx   |5 
 sw/source/core/text/frmform.cxx   |4 
 sw/source/core/text/itrtxt.cxx|3 
 sw/source/core/text/itrtxt.hxx|2 
 sw/source/core/text/porlay.cxx|3 
 sw/source/core/tox/tox.cxx|4 
 sw/source/core/txtnode/atrftn.cxx |   10 -
 sw/source/core/txtnode/ndtxt.cxx  |4 
 

[Bug 74608] Constructor functions for UNO component implementations

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=74608

--- Comment #22 from Commit Notification 
 ---
kripton committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=ea6fdbaeeb51ad695f1c3754b796b7273eb4baad

tdf#74608 lotuswordpro: Constructor feature for LotusWordProImportFilter

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Haidong.Wu license statement

[jan iversen]

WELCOME

Thanks for your license statement.

I have added you to our wiki:
https://wiki.documentfoundation.org/Development/Developers

If you want help to get started or have any questions, then please contact me. 
I am here to help you (and others) in getting their first patch submitted.

LibreOffice is a very big program and getting it built, setting up gerrit, and 
getting the first patch right can be a bit challenging, therefore do not 
hesitate to email me if you want help.

We have made a step by step guide to help you get started:
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

rgds
Jan Iversen.

Sent from my iPad, please excuse any misspellings 

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97288] New: Difficulty to scroll down

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97288

Bug ID: 97288
   Summary: Difficulty to scroll down
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hamidi.massini...@yahoo.fr

Hi,

Scrolling down is practically impossible or difficult. When I try to scroll
down, the document and the scroll bar tend to get back to their initial
position and a warning message in the console is displayed :

warn:legacy.osl:2916:1:sw/source/core/access/acccontext.cxx:305: Vis area of
child is wrong. Did it exist already?

On contrary, scrolling up works fine.


Version: 5.2.0.0.alpha0+
OS Version: Linux 3.16

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: external/boost external/clucene

[Stephan Bergmann]

 external/boost/gcc6-warnings.patch.0|   16 ++--
 external/clucene/patches/clucene-warnings.patch |8 +++-
 2 files changed, 21 insertions(+), 3 deletions(-)

New commits:
commit dda3fc05a2900539836f9748d418dc56247a2ddc
Author: Stephan Bergmann 
Date:   Wed Jan 20 19:20:23 2016 +0100

Fix for Jenkins Gerrit Mac builds

...which choke on

  #pragma GCC diagnostic ignored "-Wpragmas"

Change-Id: I40100b43078320b79cb9e3d4e3fb369db0bed9fe

diff --git a/external/boost/gcc6-warnings.patch.0 
b/external/boost/gcc6-warnings.patch.0
index e5f7b2d..66ea135 100644
--- a/external/boost/gcc6-warnings.patch.0
+++ b/external/boost/gcc6-warnings.patch.0
@@ -1,14 +1,20 @@
 --- boost/function/function_base.hpp
 +++ boost/function/function_base.hpp
-@@ -305,7 +305,15 @@
+@@ -305,7 +305,21 @@
if (op == clone_functor_tag || op == move_functor_tag) {
  const functor_type* in_functor = 
static_cast(static_cast(_buffer.data));
 +#if defined __GNUC__
 +#pragma GCC diagnostic push
++#if defined __clang__
++#if __has_warning("-Wplacement-new")
++#pragma GCC diagnostic ignored "-Wplacement-new"
++#endif
++#else
 +#pragma GCC diagnostic ignored "-Wpragmas"
 +#pragma GCC diagnostic ignored "-Wplacement-new"
 +#endif
++#endif
  new (reinterpret_cast(_buffer.data)) 
functor_type(*in_functor);
 +#if defined __GNUC__
 +#pragma GCC diagnostic pop
@@ -18,15 +24,21 @@
functor_type* f = 
static_cast(static_cast(_buffer.data));
 --- boost/function/function_template.hpp
 +++ boost/function/function_template.hpp
-@@ -569,7 +569,15 @@
+@@ -569,7 +569,21 @@
  void 
  assign_functor(FunctionObj f, function_buffer& functor, mpl::true_) 
const
  {
 +#if defined __GNUC__
 +#pragma GCC diagnostic push
++#if defined __clang__
++#if __has_warning("-Wplacement-new")
++#pragma GCC diagnostic ignored "-Wplacement-new"
++#endif
++#else
 +#pragma GCC diagnostic ignored "-Wpragmas"
 +#pragma GCC diagnostic ignored "-Wplacement-new"
 +#endif
++#endif
new (reinterpret_cast()) FunctionObj(f);
 +#if defined __GNUC__
 +#pragma GCC diagnostic pop
diff --git a/external/clucene/patches/clucene-warnings.patch 
b/external/clucene/patches/clucene-warnings.patch
index 270451d..6326f6c 100644
--- a/external/clucene/patches/clucene-warnings.patch
+++ b/external/clucene/patches/clucene-warnings.patch
@@ -69,7 +69,7 @@
  #endif
 --- src/core/CLucene/util/Array.h  2012-02-22 12:37:22.510637696 +
 +++ src/core/CLucene/util/Array.h  2012-02-22 12:38:33.71884 +
-@@ -7,6 +7,14 @@
+@@ -7,6 +7,20 @@
  #ifndef _lucene_util_Array_
  #define _lucene_util_Array_
  
@@ -77,9 +77,15 @@
 +# pragma GCC diagnostic push
 +# pragma GCC diagnostic ignored "-Wshadow"
 +# pragma GCC diagnostic ignored "-Wunused-parameter"
++#if defined __clang__
++#if __has_warning("-Wmisleading-indentation")
++#pragma GCC diagnostic ignored "-Wmisleading-indentation"
++#endif
++#else
 +# pragma GCC diagnostic ignored "-Wpragmas"
 +# pragma GCC diagnostic ignored "-Wmisleading-indentation"
 +#endif
++#endif
 +
  #include 
  #include 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: configure.ac

[Peter Foley]

 configure.ac |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f78de4441508fc81b1e013b907903df9ac4fe664
Author: Peter Foley 
Date:   Mon Jan 18 14:40:59 2016 -0500

Fix visibility check for lto on android

Change-Id: I5eea41feca7d5ab8b9d104e8356dce8831883a48
Reviewed-on: https://gerrit.libreoffice.org/21585
Tested-by: Jenkins 
Reviewed-by: jan iversen 

diff --git a/configure.ac b/configure.ac
index d5ae425..0f9fa82 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6513,7 +6513,7 @@ __attribute__ ((visibility ("default"))) void TestFunc() {
   TestStruct::Init();
 }
 _ACEOF
-if ! $CXX $CXXFLAGS $CPPFLAGS -fpic -S visibility.cxx 2>/dev/null > 
/dev/null; then
+if ! $CXX $CXXFLAGS $CPPFLAGS -fpic -S visibility.cxx; then
 gccvisbroken=yes
 else
 case "$host_cpu" in
@@ -6521,7 +6521,7 @@ _ACEOF
 if test "$_os" = "Darwin" -o "$WITH_MINGW" = "yes"; then
 gccvisbroken=no
 else
-if $EGREP -q '@PLT|@GOT' visibility.s; then
+if $EGREP -q '@PLT|@GOT' visibility.s || test 
"$ENABLE_LTO" = "TRUE"; then
 gccvisbroken=no
 else
 gccvisbroken=yes
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [Libreoffice-commits] core.git: scp2/InstallModule_ooo.mk

[Pranav Kant]

Hi Thorsten,

Sorry for responding late. I hope things are fixed now after Miklos and
yours patch.

On Wed, Jan 20, 2016 at 6:39 AM, Thorsten Behrens <
t...@documentfoundation.org> wrote:

> Hi Pranav,
>
> can you review the below commit - your scp2 changes broke Windows
> packaging.
>
> Thanks, Thorsten
>
> libreoffice-comm...@lists.freedesktop.org wrote:
> >  scp2/InstallModule_ooo.mk |4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > New commits:
> > commit 8a99e4b0de7a516b8577d34dd39296afda604290
> > Author: Thorsten Behrens 
> > Date:   Wed Jan 20 01:47:37 2016 +0100
> >
> > No LOKDocView packaging for Win/Mac for the while
> >
> > This unbreaks Windows packaging after
> > 85b46f51928dc17cda1bc974bca9159de9221b4d - I guess this should be
> > Linux-only for the moment.
> >
> > Change-Id: Ie19f7f3e4b611e2884e3fdb1a64c63927b018989
> >
> > diff --git a/scp2/InstallModule_ooo.mk b/scp2/InstallModule_ooo.mk
> > index 47c8cc6..2f4320b 100644
> > --- a/scp2/InstallModule_ooo.mk
> > +++ b/scp2/InstallModule_ooo.mk
> > @@ -103,7 +103,9 @@ $(eval $(call
> gb_InstallModule_add_scpfiles,scp2/ooo,\
> >   scp2/source/ooo/mingw_dlls \
> >   ) \
> >  scp2/source/ooo/module_filter \
> > -scp2/source/ooo/module_libreofficekit \
> > +$(if $(filter-out MACOSX WNT,$(OS)), \
> > + scp2/source/ooo/module_libreofficekit \
> > + ) \
> >  ))
> >
> >  $(eval $(call gb_InstallModule_add_localized_scpfiles,scp2/ooo,\
>
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>


-- 
Regards,
Pranav Kant
http://pranavk.me
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

Maxim Monastirsky  changed:

   What|Removed |Added

 CC||momonas...@gmail.com

--- Comment #1 from Maxim Monastirsky  ---
The UI for this was removed intentionally in
0b0fb87fbac36ef9fbf3dfeac0f1372617f4b3e4. You can still set the value you want
using the Expert Configuration dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||samuel.mehrbr...@cib.de
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97137] Slow and different rendering of SVG graphics in attached document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97137

--- Comment #9 from V Stuart Foote  ---
(In reply to Tor Lillqvist from comment #6)
> Note that the pictures might have been SVG initially, but there is no SVG in
> the .odt file, as far as I see.

Your right, very sorry I missed that there were no SVGs as claimed in the
summary.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #4 from Kohei Yoshida  ---
I'm the original author of the part of the detection code that handles generic
text file type.

We need to be careful not to confuse format "types" and "filters".  A type only
refers to a format type such as HTML, plain text etc, and is not tied to a
specific application such as Writer or Calc.  A filter OTOH is tied to a single
application.  We have one plain text filter for Writer and one plain text
filter for Calc.  The one for Writer treats all plain text files equally
whereas the one for Calc treats all plain text files equally as CSV, regardless
of extension.  OTOH, we only have one generic text type that's application
agnostic.  During detection phase, when a plain text "type" is detected, it
does its best to tie that to a specific filter which in turn determines which
application the file will be opened.

Part of the confusion comes from the fact that we do list all available
"filters" as file "types" in the UI, which IMO is not correct.  As such, if you
specify in the UI the "Text" type which really is a text filter for Writer, the
file will be opened in Writer even if you do this from Calc window before what
that "Text type" represents is the plain text "filter" for Writer.

Perhaps the right solution would be to change the UI label from "file types" to
"file filters"?  Either way, we do need to make the correct distinction between
file types and file filters and do understand the differences between the two
before trying to come up with what would be the right solution for this.

Just my 2 cents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #4 from Kohei Yoshida  ---
I'm the original author of the part of the detection code that handles generic
text file type.

We need to be careful not to confuse format "types" and "filters".  A type only
refers to a format type such as HTML, plain text etc, and is not tied to a
specific application such as Writer or Calc.  A filter OTOH is tied to a single
application.  We have one plain text filter for Writer and one plain text
filter for Calc.  The one for Writer treats all plain text files equally
whereas the one for Calc treats all plain text files equally as CSV, regardless
of extension.  OTOH, we only have one generic text type that's application
agnostic.  During detection phase, when a plain text "type" is detected, it
does its best to tie that to a specific filter which in turn determines which
application the file will be opened.

Part of the confusion comes from the fact that we do list all available
"filters" as file "types" in the UI, which IMO is not correct.  As such, if you
specify in the UI the "Text" type which really is a text filter for Writer, the
file will be opened in Writer even if you do this from Calc window before what
that "Text type" represents is the plain text "filter" for Writer.

Perhaps the right solution would be to change the UI label from "file types" to
"file filters"?  Either way, we do need to make the correct distinction between
file types and file filters and do understand the differences between the two
before trying to come up with what would be the right solution for this.

Just my 2 cents.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

Samuel Mehrbrodt  changed:

   What|Removed |Added

 CC||palenik.mih...@gmail.com

--- Comment #2 from Samuel Mehrbrodt  ---
@Mihaly Palenik: As you removed those options, would you mind adding a note to
the release notes about that? 
https://wiki.documentfoundation.org/ReleaseNotes/5.1

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #5 from Kohei Yoshida  ---
And I swear this UI label used to be "file filters" not "file types" though
my memory is a bit hazy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #5 from Kohei Yoshida  ---
And I swear this UI label used to be "file filters" not "file types" though
my memory is a bit hazy.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

Wolfgang Jäger  changed:

   What|Removed |Added

 CC||j...@psilosoph.de
 Resolution|NOTABUG |FIXED

--- Comment #3 from Wolfgang Jäger  ---
"...was removed intentionally..."
Who on earth decided to do so? I want to plead for an openly accessible UI
option to set a parameter for the scope (number of steps / memory usage) of
'Undo'?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #6 from jan iversen  ---
Do not trust your memory, trust the version control system :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #6 from jan iversen  ---
Do not trust your memory, trust the version control system :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

--- Comment #4 from Samuel Mehrbrodt  ---
(In reply to Wolfgang Jäger from comment #3)
> "...was removed intentionally..."
> Who on earth decided to do so?

Please read the commit message for rationale.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - loleaflet/reference.html

[Jan Holesovsky]

 loleaflet/reference.html |   26 +-
 1 file changed, 25 insertions(+), 1 deletion(-)

New commits:
commit 6aecb8ed24d943c33866f4c6c4dd99ac4a8104bd
Author: Jan Holesovsky 
Date:   Wed Jan 20 19:17:39 2016 +0100

loleaflet: Document the spreadsheet-related rows / columns commands.

diff --git a/loleaflet/reference.html b/loleaflet/reference.html
index eb68f94..deb4b53 100644
--- a/loleaflet/reference.html
+++ b/loleaflet/reference.html
@@ -8545,7 +8545,7 @@ var unoCommands = [
 },
 
 {
-header: 'Tables',
+header: 'Tables (in a text document)',
 },
 
 {
@@ -8610,6 +8610,18 @@ var unoCommands = [
 },
 
 {
+uno: '.uno:DeleteColumns',
+parameter: null,
+description: 'Delete the current column.'
+},
+
+{
+uno: '.uno:DeleteRows',
+parameter: null,
+description: 'Delete the current row.'
+},
+
+{
 uno: '.uno:EnterString',
 parameter: {
 'StringName': {
@@ -8636,6 +8648,18 @@ var unoCommands = [
 },
 
 {
+uno: '.uno:InsertColumns',
+parameter: null,
+description: 'Insert column after the current cursor position.',
+},
+
+{
+uno: '.uno:InsertRows',
+parameter: null,
+description: 'Insert row before the current cursor position.',
+},
+
+{
 header: 'Appearance options',
 },
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97280] New: Add support for layers to LibreOffice Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97280

Bug ID: 97280
   Summary: Add support for layers to LibreOffice Writer
   Product: LibreOffice
   Version: 5.0.4.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: m...@samtuke.com

Managing documents with background images and text boxes is hard -- selecting
the correct object is challenging. Introducing lockable layers, similar to Draw
already supports, would make this much easier.

Specific use case: A4 page with a full background image (zero margin) and text
boxes in the foreground of the page with solid colour background. Selecting
text for editing, instead of selecting text box or background image, requires
many clicks and sometimes workarounds.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

Cor Nouws  changed:

   What|Removed |Added

 Resolution|FIXED   |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91017] [Regression] Black squares hide content of WMF image

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=91017

--- Comment #6 from Armin Le Grand  ---
Quick check: The bitmaps with the WMF are imported correctly. Painting these
adds them to a Metafile twice with RasterOp's R2_XORPEN and R2_COPYPEN, see
WinMtfOutput::ResolveBitmapActions. This may be problematic - we are not good
with xor stuff ;-(
Need to check deeper...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source

[Stephan Bergmann]

 sc/source/ui/dbgui/validate.cxx |5 +
 sc/source/ui/inc/validate.hxx   |2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

New commits:
commit a6a65ecdef3a577b537b5d9fccb9d41e585b9f14
Author: Stephan Bergmann 
Date:   Tue Jan 19 10:58:44 2016 +0100

Make virtual ~ScValidationDlg non-inline

...otherwise, GCC 6 would aggressively inline ScValidationDlg destruction 
of the
VclPtr in ScValidityRefChildWin::ScValidityRefChildWin
(sc/source/ui/view/reffact.cxx, in sc library), checking whether the vtable
points at ~ScValidationDlg (instead of a derived class dtor) to directly 
inline
the ~ScValidationDlg code, which requires the ScValidateionDlg vtable (to 
store
it in the object's vtable during destruction), which requires the code of 
inline
virtual ScValidationDlg::dispose and ScValidationDlg::Close, which in turn 
need
the addresses of (non-inline) ScValidationDlg::RemoveRefDlg and
ScTPValidationValue::RemoveRefDlg, both defined in the scui library and not
exported from there.

Change-Id: I7eb96f42deb5edd844d91e999aa5511679302c01
(cherry picked from commit 8d1a24dae03690b576310e3539369916f31ac475)
Reviewed-on: https://gerrit.libreoffice.org/21637
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx
index 459c5d7..db73012 100644
--- a/sc/source/ui/dbgui/validate.cxx
+++ b/sc/source/ui/dbgui/validate.cxx
@@ -96,6 +96,11 @@ ScValidationDlg::ScValidationDlg(vcl::Window* pParent, const 
SfxItemSet* pArgSet
 get(m_pHBox, "refinputbox");
 }
 
+ScValidationDlg::~ScValidationDlg()
+{
+disposeOnce();
+}
+
 void ScTPValidationValue::SetReferenceHdl( const ScRange , ScDocument* 
pDoc )
 {
 if ( rRange.aStart != rRange.aEnd )
diff --git a/sc/source/ui/inc/validate.hxx b/sc/source/ui/inc/validate.hxx
index d39b99b..1e785b7 100644
--- a/sc/source/ui/inc/validate.hxx
+++ b/sc/source/ui/inc/validate.hxx
@@ -182,7 +182,7 @@ class ScValidationDlg
 
 public:
 explicit ScValidationDlg( vcl::Window* pParent, const SfxItemSet* pArgSet, 
ScTabViewShell * pTabViewSh, SfxBindings *pB = nullptr );
-virtual ~ScValidationDlg() { disposeOnce(); }
+virtual ~ScValidationDlg();
 virtual voiddispose() override
 {
 if( m_bOwnRefHdlr )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 51605] Field add corrupts table

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51605

--- Comment #8 from rob...@familiegrosskopf.de ---
Bug still exists with LO 5.1.0.2, OpenSUSE 42.1 Leap, 64bit rpm Linux.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97274] Frames borders are not correctly exported in .docx format

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97274

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
Created attachment 122119
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122119=edit
printscreen

Hello, 
seems to be fixed in dev version. Please could you test with dev version?
http://dev-builds.libreoffice.org/daily/master/
Thank you


Version: 5.2.0.0.alpha0+
Build ID: d95d9d7f908419f397941ef60ac6ced3261c9b87
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-19_00:40:21

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] LibreOffice 5.0.5 RC1 test builds available

[Christian Lohmaier]

Hello all,

For the upcoming version 5.0.5 the builds for RC1 are now available on
pre-releases.

It is a build in release-configuration, meaning that it will update a
previous version of LibreOffice on Windows.
Linux and Mac users can install alongside LibreOffice 4.4

For the complete schedule., see
https://wiki.documentfoundation.org/ReleasePlan/5.0#5.0.5_release

Grab the builds from here here:
http://dev-builds.libreoffice.org/pre-releases/

The list of fixed bugs relative to 5.0.4 final (rc2) is here:
http://dev-builds.libreoffice.org/pre-releases/src/bugs-libreoffice-5-0-5-release-5.0.5.1.log

Testing against the areas touched and the bugs fixed since the last
tag is greatly appreciated, as it helps us to confirm the stability of
this build.

Thanks a lot for your help!
Christian
___
List Name: Libreoffice-qa mailing list
Mail address: Libreoffice-qa@lists.freedesktop.org
Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://lists.freedesktop.org/archives/libreoffice-qa/

[Libreoffice-bugs] [Bug 97283] New: merge unit tests in sal module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97283

Bug ID: 97283
   Summary: merge unit tests in sal module
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dtar...@redhat.com

There are 33 separate test libraries in sal module. These should be merged into
3: one for each of osl, rtl and sal.

Most of the tests have the right category already in the name, e.g.,
CppunitTest_sal_osl_file should be merged into a (new) CppunitTest_sal_osl. For
these few that do not follow that naming scheme, check the source files for
what class they are testing (sal::Foo, rtl_Foo,...) and categorize them by
that. It might be a good idea to move the sources into the right subdir of
sal/qa as well, if they are not already there.

The easiest way is to rename one of the makefiles of the selected group (do not
forget to also change the name used inside the makefile and in Module_sal.mk)
and copy source files (and other extra stuff: used libraries, extra
dependencies, etc.) from the other makefiles to it. Then remove
CPPUNIT_PLUGIN_IMPLEMENT() from all source files from the group but one (you
will get linker error if you do not do this). Then remove the now unnecessary
makefiles.

It would be best to do this in 3 separate patches, one for each group.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97282] Enhanced Change Tracking/collaboration proposal - immutable XML

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97282

--- Comment #1 from Patrick Durusau  ---
I tried to include change tracking and collaboration as keywords but ran afoul
of a filter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78558] FILEOPEN: Excel chart with transparent background imported over blue frame

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78558

Luke  changed:

   What|Removed |Added

   See Also|https://bz.apache.org/ooo/s |https://bz.apache.org/ooo/s
   |how_bug.cgi?id=121334   |how_bug.cgi?id=119287

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97180] parenthesis in text are randomly bold

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97180

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Version|5.0.2.2 release |3.5.0 release
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97283] merge unit tests in sal module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97283

David Tardon  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, topicQA
 Status|UNCONFIRMED |NEW
 CC||libreoffice@lists.freedeskt
   ||op.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97283] merge unit tests in sal module

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97283

David Tardon  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, topicQA
 Status|UNCONFIRMED |NEW
 CC||libreoffice@lists.freedeskt
   ||op.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97281] FILEOPEN: Page Margins, Border Settings changed when the document is saved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97281

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||r...@post.cz
Summary|Page Margins, Border|FILEOPEN: Page Margins,
   |Settings changed when the   |Border Settings changed
   |document is saved   |when the document is saved
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
I can confirm Version: 5.2.0.0.alpha0+
Build ID: d95d9d7f908419f397941ef60ac6ced3261c9b87
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-19_00:40:21

When I open this saved file in word2010, the margins are correct - fileopen
problem.

Reproducible with LibreOffice 3.5.0 
Build ID: d6cde02

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97180] parenthesis in text are randomly bold

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97180

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #4 from raal  ---
Created attachment 122120
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122120=edit
printscreen

I can confirm with Version: 5.2.0.0.alpha0+
Build ID: d95d9d7f908419f397941ef60ac6ced3261c9b87
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-19_00:40:21
LibreOffice 3.5.0 
Build ID: d6cde02

C- same as B, but they do remain bold forever after you are finished editing

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - vcl/unx

[Caolán McNamara]

 vcl/unx/generic/printer/jobdata.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 01c60a8452bf991bb5e09e9780d05a8376979255
Author: Caolán McNamara 
Date:   Wed Jan 20 15:17:09 2016 +

Related: rhbz#1149116 collateEquals was set with OString::boolean

but extracted with toInt32()

since

commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed

fdo#41524: CUPS printing: use "collate" option when PDF is available

though actual reported problem works fine for me with default f23
configuration already, this looks suspicious however

Change-Id: I6fcb5df8039296c0e8b0fe931cb490396182de38
Reviewed-on: https://gerrit.libreoffice.org/21629
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit e220ba8610f8315af473a230565daa978ca6a16c)
Reviewed-on: https://gerrit.libreoffice.org/21631

diff --git a/vcl/unx/generic/printer/jobdata.cxx 
b/vcl/unx/generic/printer/jobdata.cxx
index 778961f..7e25fdc 100644
--- a/vcl/unx/generic/printer/jobdata.cxx
+++ b/vcl/unx/generic/printer/jobdata.cxx
@@ -251,7 +251,7 @@ bool JobData::constructFromStreamBuffer( void* pData, int 
bytes, JobData& rJobDa
 }
 else if (aLine.startsWith(collateEquals))
 {
-rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toInt32();
+rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toBoolean();
 }
 else if (aLine.startsWith(margindajustmentEquals))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 86652] links to cells in different sheet of the same calc file break when copying the sheet with links inside the same calc file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=86652

--- Comment #12 from Renovatio  ---
For me this is bug.

The copy should not change the 'sheet reference' inside the formula
independently if it's an absolute or an relative reference. 

Despite being relative, before or after, at the end of the copy it continues to
exist and to be valid.

See other spreadsheets, the 'sheet reference' is never destroyed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #7 from Kohei Yoshida  ---
(In reply to jan iversen from comment #6)
> Do not trust your memory, trust the version control system :-)

Absolutely right.  Would you mind looking into that? :-)  I might do it later
when I find time but I'm a bit short on time at the moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 97080] FILEOPEN: Need broader filter for delimited text files ("Text CSV" only includes *.csv)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97080

--- Comment #7 from Kohei Yoshida  ---
(In reply to jan iversen from comment #6)
> Do not trust your memory, trust the version control system :-)

Absolutely right.  Would you mind looking into that? :-)  I might do it later
when I find time but I'm a bit short on time at the moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: vcl/unx

[Caolán McNamara]

 vcl/unx/generic/printer/jobdata.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e220ba8610f8315af473a230565daa978ca6a16c
Author: Caolán McNamara 
Date:   Wed Jan 20 15:17:09 2016 +

Related: rhbz#1149116 collateEquals was set with OString::boolean

but extracted with toInt32()

since

commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed

fdo#41524: CUPS printing: use "collate" option when PDF is available

though actual reported problem works fine for me with default f23
configuration already, this looks suspicious however

Change-Id: I6fcb5df8039296c0e8b0fe931cb490396182de38
Reviewed-on: https://gerrit.libreoffice.org/21629
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 

diff --git a/vcl/unx/generic/printer/jobdata.cxx 
b/vcl/unx/generic/printer/jobdata.cxx
index a9f7c30..309309e 100644
--- a/vcl/unx/generic/printer/jobdata.cxx
+++ b/vcl/unx/generic/printer/jobdata.cxx
@@ -251,7 +251,7 @@ bool JobData::constructFromStreamBuffer( void* pData, 
sal_uInt32 bytes, JobData&
 }
 else if (aLine.startsWith(collateEquals))
 {
-rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toInt32();
+rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toBoolean();
 }
 else if (aLine.startsWith(margindajustmentEquals))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97278] Windows: SEH and crash-handling / OpenGLZone

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97278

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||c...@nouenoff.nl
 Resolution|--- |DUPLICATE

--- Comment #1 from Cor Nouws  ---


*** This bug has been marked as a duplicate of bug 97277 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97277] Windows: SEH and crash-handling / OpenGLZone

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97277

--- Comment #4 from Cor Nouws  ---
*** Bug 97278 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97270] copying styles does not copy line spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97270

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1

--- Comment #1 from Cor Nouws  ---
Hi Daniel,

Thanks for your report!

Can you please attach a sample document to test this?

Ciao,
Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97282] New: Enhanced Change Tracking/collaboration proposal - immutable XML

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97282

Bug ID: 97282
   Summary: Enhanced Change Tracking/collaboration proposal -
immutable XML
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: patr...@durusau.net

One of the problems that plagues efforts to enable collaboration across editors
is the fragility of the underlying markup. By that I mean that if I insert a
new paragraph 3 at the same time you have transmitted a new paragraph 2, when
both changes arrive, my intended location for paragraph 3 no longer exists. 

There are some character offset implementations that offer some "lite" markup
but nothing approaching the richness of ODF.

I have recently posted a proposal to the change-tracking list at OASIS
suggesting that a change in ODF change tracking could:

1) Enable auditability for all of the applications in the Libre Office suite,

2) Enable collaboration, whether with a central server, a workgroup or selected
collaborators,

3) Enable authoring app flexibility, where an authoring app need only support
the markup it where it will offer changes. 

All of those benefits arise from declaring an ODF document as immutable at the
time of collaboration and/or change tracking.

Once it is treated as immutable, any application can reliably address the
document using XPath for example, without conflict or the document changing due
to another change.

For collaboration/change tracking, all changes should be written as XPath
statements against the immutable original ODF document and stored as immutable
statements themselves. The application, using its own internal run time model,
projects the changes onto the document and enables the user to chose which
changes to accept. (acceptance also being an XPath statement). If and when the
user chooses to create a new version of the document, then the accepted changes
are integrated with the original document and a new document is produced.

With the document and all changes being immutable, whether for graphic objects,
documents and/or spreadsheets, each of those documents becomes an auditable
record of the work. Such capabilities are available now, but only in very high
end and specialized applications, such as:
http://www.ibm.com/developerworks/aix/library/au-gpfs/index1.html.

Enabling small governments, businesses, individuals to have auditability,
collaboration/change tracking and authoring flexibility would be a major step
forward for a large number of users.

Hope everyone is having a great week!

Patrick

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: FastSaxSerializer::write ...

[Chris Sherlock]

> On 21 Jan 2016, at 2:37 AM, David Tardon  wrote:
> 
> Hi,
> 
> On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote:
>> I think a unit test might be helpful. They are actually quite easy to write 
>> - in fact, I wrote a very simple one the other day. 
>> 
>> Have a look on master at vcl/qa/cppunit/font.cxx
> 
> Note that you don't have to create a whole new CppunitTest every time.
> You can add new source files to an existing one. You just have to make
> sure that only one of the sources contains CPPUNIT_PLUGIN_IMPLEMENT(),
> otherwise you'd get a linker error.
> 
> Speaking about excessively granular tests: would anyone protest against
> an Easy Hack to merge the tests in sal module into bigger groups, e.g.,
> just one test for osl, one for rtl and another one for sal? I.e.,
> reduction of the number of CppunitTest makefiles from 33 to 3.
> 
> D.

That sounds like it would make managing the unit tests a lot easier. Sure, why 
not?

Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] dev-tools.git: 2 commits - scripts/esc-bug-stats.pl

[Robinson Tryon]

 scripts/esc-bug-stats.pl |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 56830328e5f500787db7be4649ef51dbea55e464
Author: Robinson Tryon 
Date:   Mon Dec 21 20:23:15 2015 -0600

esc-bug-stats: Whiteboard -> Keywords migration

We haven't made a decision about migrating the bibisected36 /
bibisected40 tags to Keywords, so we've tweaked the queries to include
the ~100 bugs for which this detail is applicable.

diff --git a/scripts/esc-bug-stats.pl b/scripts/esc-bug-stats.pl
index 23277ed..496b79c 100755
--- a/scripts/esc-bug-stats.pl
+++ b/scripts/esc-bug-stats.pl
@@ -102,8 +102,8 @@ $reg_open = Bugzilla::get_query($regression_open_query);
 $reg_high = Bugzilla::get_query($regression_high_query);
 
 print STDERR "Querying for bibisection:\n";
-my $bibisect_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f1=keywords=status_whiteboard_name=BibisectedAll_id=578080=1=substring=substring=LibreOffice_based_on=BibisectedAll_format=advanced=---=FIXED=INVALID=WONTFIX=DUPLICATE=WORKSFORME=MOVED=NOTABUG=NOTOURBUG=bibisected=bibisected35older;;
-my $bibisect_open_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f1=keywords=status_whiteboard_name=Bibisected_id=578082=1=substring=substring=LibreOffice_based_on=Bibisected_format=advanced=---=bibisected=bibisected35older;;
+my $bibisect_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f2=status_whiteboard=OP=keywords=status_whiteboard=OR_name=BibisectedAll=0_id=579989=1=substring=substring=substring=substring=changeddate
 
DESC%2Cop_sys%2Cbug_status%2Cpriority%2Cassigned_to%2Cbug_id=LibreOffice_format=advanced=---=FIXED=INVALID=WONTFIX=DUPLICATE=WORKSFORME=MOVED=NOTABUG=NOTOURBUG=bibisected=bibisected35older=bibisected=bibisected";
+my $bibisect_open_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f2=status_whiteboard=OP=keywords=status_whiteboard=OR_name=Bibisected_id=579994=1=substring=substring=substring=substring=LibreOffice_based_on=Bibisected_format=advanced=---=bibisected=bibisected35older=bibisected=bibisected;;
 
 my ($all, $open);
 $all = Bugzilla::get_query($bibisect_query);
commit e5cb2cdabbb1e7cdf5682c0506671d865fd2cc84
Author: Robinson Tryon 
Date:   Thu Dec 17 08:56:53 2015 -0600

esc-bug-stats: Update queries to reflect Whiteboard -> Keywords migration

Updating the Bugzilla queries used to generate stats. We've been
migrating many Whiteboard tags to the Keywords field.

diff --git a/scripts/esc-bug-stats.pl b/scripts/esc-bug-stats.pl
index b5645be..23277ed 100755
--- a/scripts/esc-bug-stats.pl
+++ b/scripts/esc-bug-stats.pl
@@ -102,14 +102,14 @@ $reg_open = Bugzilla::get_query($regression_open_query);
 $reg_high = Bugzilla::get_query($regression_high_query);
 
 print STDERR "Querying for bibisection:\n";
-my $bibisect_query = 
"https://$Bugzilla::bugserver/buglist.cgi?n2=1=status_whiteboard_id=267679=substring=---=FIXED=INVALID=WONTFIX=DUPLICATE=WORKSFORME=MOVED=NOTABUG=NOTOURBUG_based_on=BibisectedAll=substring_format=advanced=status_whiteboard=bibisected=bibisected35older=LibreOffice_name=BibisectedAll=0;;
-my $bibisect_open_query = 
"https://$Bugzilla::bugserver/buglist.cgi?n2=1=status_whiteboard_id=267685=substring=---_based_on=Bibisected=substring_format=advanced=status_whiteboard=bibisected=bibisected35older=LibreOffice_name=Bibisected=0;;
+my $bibisect_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f1=keywords=status_whiteboard_name=BibisectedAll_id=578080=1=substring=substring=LibreOffice_based_on=BibisectedAll_format=advanced=---=FIXED=INVALID=WONTFIX=DUPLICATE=WORKSFORME=MOVED=NOTABUG=NOTOURBUG=bibisected=bibisected35older;;
+my $bibisect_open_query = 
"https://$Bugzilla::bugserver/buglist.cgi?f1=keywords=status_whiteboard_name=Bibisected_id=578082=1=substring=substring=LibreOffice_based_on=Bibisected_format=advanced=---=bibisected=bibisected35older;;
 
 my ($all, $open);
 $all = Bugzilla::get_query($bibisect_query);
 $open = Bugzilla::get_query($bibisect_open_query);
 print STDERR "\n";
-print STDERR "* Bibisected bugs open: whiteboard 'bibsected'\n";
+print STDERR "* Bibisected bugs open: keyword 'bibisected'\n";
 print STDERR "\t+ $open (of $all) older ?\n";
 print STDERR "\t\t+ http://bit.ly/VQfF3Q\n;;
 print STDERR "\n";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Yogesh Desai]

 sc/source/ui/view/output2.cxx |   28 +---
 1 file changed, 21 insertions(+), 7 deletions(-)

New commits:
commit 812ebe795219966a05baca5719b528c186a0baf6
Author: Yogesh Desai 
Date:   Tue Jan 5 21:26:47 2016 +0530

tdf#96822 : Make cell contents left align when number formatting is text

Change-Id: I9754db93f4cf71a6001d5b3f39ee2bc2b01889cc
Reviewed-on: https://gerrit.libreoffice.org/21134
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 39577bb..3021961 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -278,6 +278,14 @@ bool lcl_GetBoolValue(const ScPatternAttr& rPattern, 
sal_uInt16 nWhich, const Sf
 
 }
 
+bool lcl_isNumberFormatText(const ScDocument* pDoc, SCCOL nCellX, SCROW 
nCellY, SCTAB nTab )
+{
+sal_uInt32 nCurrentNumberFormat;
+pDoc->GetNumberFormat( nCellX, nCellY, nTab, nCurrentNumberFormat);
+SvNumberFormatter* pNumberFormatter = pDoc->GetFormatTable();
+return(pNumberFormatter->GetType( nCurrentNumberFormat ) == 
css::util::NumberFormat::TEXT);
+}
+
 void ScDrawStringsVars::SetPattern(
 const ScPatternAttr* pNew, const SfxItemSet* pSet, const ScRefCellValue& 
rCell,
 SvtScriptType nScript )
@@ -1391,7 +1399,7 @@ bool beginsWithRTLCharacter(const OUString& rStr)
 static SvxCellHorJustify getAlignmentFromContext( SvxCellHorJustify eInHorJust,
 bool bCellIsValue, const OUString& rText,
 const ScPatternAttr& rPattern, const SfxItemSet* pCondSet,
-const ScDocument* pDoc, SCTAB nTab )
+const ScDocument* pDoc, SCTAB nTab, const bool  bNumberFormatIsText )
 {
 SvxCellHorJustify eHorJustContext = eInHorJust;
 bool bUseWritingDirection = false;
@@ -1399,10 +1407,14 @@ static SvxCellHorJustify getAlignmentFromContext( 
SvxCellHorJustify eInHorJust,
 {
 // fdo#32530: Default alignment depends on value vs
 // string, and the direction of the 1st letter.
-if (beginsWithRTLCharacter( rText))
-eHorJustContext = bCellIsValue ? SVX_HOR_JUSTIFY_LEFT : 
SVX_HOR_JUSTIFY_RIGHT;
-else if (bCellIsValue)
-eHorJustContext = SVX_HOR_JUSTIFY_RIGHT;
+if (beginsWithRTLCharacter( rText)) //If language is RTL
+{
+if (bCellIsValue)
+   eHorJustContext = bNumberFormatIsText ? SVX_HOR_JUSTIFY_RIGHT : 
SVX_HOR_JUSTIFY_LEFT;
+else
+eHorJustContext = SVX_HOR_JUSTIFY_RIGHT;
+}else if (bCellIsValue) //If language is not RTL
+eHorJustContext = bNumberFormatIsText ? SVX_HOR_JUSTIFY_LEFT : 
SVX_HOR_JUSTIFY_RIGHT;
 else
 bUseWritingDirection = true;
 }
@@ -1693,8 +1705,9 @@ Rectangle ScOutputData::LayoutStrings(bool bPixelToLogic, 
bool bPaint, const ScA
 bCellIsValue = pFCell->IsRunning() || 
pFCell->IsValue();
 }
 
+const bool bNumberFormatIsText = lcl_isNumberFormatText( 
mpDoc, nCellX, nCellY, nTab );
 eOutHorJust = getAlignmentFromContext( aVars.GetHorJust(), 
bCellIsValue, aVars.GetString(),
-*pPattern, pCondSet, mpDoc, nTab);
+*pPattern, pCondSet, mpDoc, nTab, 
bNumberFormatIsText );
 
 bool bBreak = ( aVars.GetLineBreak() || aVars.GetHorJust() 
== SVX_HOR_JUSTIFY_BLOCK );
 // #i111387# #o11817313# disable automatic line breaks 
only for "General" number format
@@ -4571,8 +4584,9 @@ void ScOutputData::DrawEdit(bool bPixelToLogic)
 OUString aStr = mpDoc->GetString(nCellX, nCellY, nTab);
 
 DrawEditParam aParam(pPattern, pCondSet, 
lcl_SafeIsValue(aCell));
+const bool bNumberFormatIsText = 
lcl_isNumberFormatText( mpDoc, nCellX, nCellY, nTab );
 aParam.meHorJustContext = getAlignmentFromContext( 
aParam.meHorJustAttr,
-aParam.mbCellIsValue, aStr, *pPattern, 
pCondSet, mpDoc, nTab);
+aParam.mbCellIsValue, aStr, *pPattern, 
pCondSet, mpDoc, nTab, bNumberFormatIsText);
 aParam.meHorJustResult = (aParam.meHorJustAttr == 
SVX_HOR_JUSTIFY_BLOCK) ?
 SVX_HOR_JUSTIFY_BLOCK : 
aParam.meHorJustContext;
 aParam.mbPixelToLogic = bPixelToLogic;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Hackathon

[Bjoern Michaelsen]

Hi Gülşah,

On Wed, Jan 20, 2016 at 04:23:50PM +0200, Gülşah Köse wrote:
> And we have two team and need one or two idea more. Do you have a
> suggestion can be done in one day?

Here are the beginner UI EasyHacks:

 
https://wiki.documentfoundation.org/Development/Easy_Hacks/lists/by_Topic#Skill_Level:_Beginner

They are supposed to be reasonably easy and user visible. If they are not,
please let us know, as EasyHacks that are not easy are not how it should be and
we should fix that then ;)

Best,

Bjoern
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: qadevOOo/tests

[Caolán McNamara]

 qadevOOo/tests/java/ifc/io/_XOutputStream.java |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ca27812e67663574cbc8a56b43e482dfaf3debc0
Author: Caolán McNamara 
Date:   Wed Jan 20 16:36:05 2016 +

logic inverted

thanks to noelg for noticing

Change-Id: I0e8bdb1e10bc8341b4f38d93c08ff77ea9aadf9b

diff --git a/qadevOOo/tests/java/ifc/io/_XOutputStream.java 
b/qadevOOo/tests/java/ifc/io/_XOutputStream.java
index c183002..9f619f3 100644
--- a/qadevOOo/tests/java/ifc/io/_XOutputStream.java
+++ b/qadevOOo/tests/java/ifc/io/_XOutputStream.java
@@ -85,7 +85,7 @@ public class _XOutputStream extends MultiMethodTest {
 
 byte[][] readData = new byte[1][data.length];
 XInputStream xInStream = checker.getInStream();
-if (xInStream == null) {
+if (xInStream != null) {
 try {
 xInStream.readBytes(readData, data.length);
 } catch(com.sun.star.io.IOException e) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/ui/view/output2.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit e172d2e300e600d53975a39161ceed0c7158e1e0
Author: Eike Rathke 
Date:   Wed Jan 20 18:13:24 2016 +0100

nitpicks, tdf#96822 follow-up

Change-Id: Ic745433a870c70c09afa953a4ebef86f4363f9f4

diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx
index 3021961..3331a62 100644
--- a/sc/source/ui/view/output2.cxx
+++ b/sc/source/ui/view/output2.cxx
@@ -283,7 +283,7 @@ bool lcl_isNumberFormatText(const ScDocument* pDoc, SCCOL 
nCellX, SCROW nCellY,
 sal_uInt32 nCurrentNumberFormat;
 pDoc->GetNumberFormat( nCellX, nCellY, nTab, nCurrentNumberFormat);
 SvNumberFormatter* pNumberFormatter = pDoc->GetFormatTable();
-return(pNumberFormatter->GetType( nCurrentNumberFormat ) == 
css::util::NumberFormat::TEXT);
+return pNumberFormatter->GetType( nCurrentNumberFormat ) == 
css::util::NumberFormat::TEXT;
 }
 
 void ScDrawStringsVars::SetPattern(
@@ -1413,7 +1413,8 @@ static SvxCellHorJustify getAlignmentFromContext( 
SvxCellHorJustify eInHorJust,
eHorJustContext = bNumberFormatIsText ? SVX_HOR_JUSTIFY_RIGHT : 
SVX_HOR_JUSTIFY_LEFT;
 else
 eHorJustContext = SVX_HOR_JUSTIFY_RIGHT;
-}else if (bCellIsValue) //If language is not RTL
+}
+else if (bCellIsValue) //If language is not RTL
 eHorJustContext = bNumberFormatIsText ? SVX_HOR_JUSTIFY_LEFT : 
SVX_HOR_JUSTIFY_RIGHT;
 else
 bUseWritingDirection = true;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: FastSaxSerializer::write ...

[David Tardon]

Hi,

On Mon, Jan 18, 2016 at 12:53:07PM +1100, Chris Sherlock wrote:
> I think a unit test might be helpful. They are actually quite easy to write - 
> in fact, I wrote a very simple one the other day. 
> 
> Have a look on master at vcl/qa/cppunit/font.cxx

Note that you don't have to create a whole new CppunitTest every time.
You can add new source files to an existing one. You just have to make
sure that only one of the sources contains CPPUNIT_PLUGIN_IMPLEMENT(),
otherwise you'd get a linker error.

Speaking about excessively granular tests: would anyone protest against
an Easy Hack to merge the tests in sal module into bigger groups, e.g.,
just one test for osl, one for rtl and another one for sal? I.e.,
reduction of the number of CppunitTest makefiles from 33 to 3.

D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97261] Colored font char, alignment changes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97261

--- Comment #1 from enrico.dellaqu...@gmail.com ---
In LO 5.0.4/Win10 the problem doesn't seem to appear.
It seems an OSX version issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - vcl/unx

[Caolán McNamara]

 vcl/unx/generic/printer/jobdata.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5761c6bc24fa4d20fccef8e89435c0e32c922ade
Author: Caolán McNamara 
Date:   Wed Jan 20 15:17:09 2016 +

Related: rhbz#1149116 collateEquals was set with OString::boolean

but extracted with toInt32()

since

commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed

fdo#41524: CUPS printing: use "collate" option when PDF is available

though actual reported problem works fine for me with default f23
configuration already, this looks suspicious however

Change-Id: I6fcb5df8039296c0e8b0fe931cb490396182de38
Reviewed-on: https://gerrit.libreoffice.org/21629
Reviewed-by: Michael Stahl 
Tested-by: Michael Stahl 
(cherry picked from commit e220ba8610f8315af473a230565daa978ca6a16c)
Reviewed-on: https://gerrit.libreoffice.org/21630
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 

diff --git a/vcl/unx/generic/printer/jobdata.cxx 
b/vcl/unx/generic/printer/jobdata.cxx
index 9169b01..2c344cc 100644
--- a/vcl/unx/generic/printer/jobdata.cxx
+++ b/vcl/unx/generic/printer/jobdata.cxx
@@ -250,7 +250,7 @@ bool JobData::constructFromStreamBuffer( void* pData, int 
bytes, JobData& rJobDa
 }
 else if (aLine.startsWith(collateEquals))
 {
-rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toInt32();
+rJobData.m_bCollate = 
aLine.copy(RTL_CONSTASCII_LENGTH(collateEquals)).toBoolean();
 }
 else if (aLine.startsWith(margindajustmentEquals))
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 3 commits - include/sfx2 officecfg/registry sfx2/source sw/sdi sw/source sw/uiconfig sw/UIConfig_sglobal.mk sw/UIConfig_sweb.mk sw/UIConfig_swform.mk sw/UIConfig_swrepo

[Maxim Monastirsky]

 include/sfx2/dispatch.hxx| 
   2 
 include/sfx2/mnumgr.hxx  | 
  11 -
 officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu  | 
   3 
 officecfg/registry/data/org/openoffice/Office/UI/WriterFormWindowState.xcu   | 
   5 
 officecfg/registry/data/org/openoffice/Office/UI/WriterGlobalWindowState.xcu | 
   5 
 officecfg/registry/data/org/openoffice/Office/UI/WriterReportWindowState.xcu | 
   5 
 officecfg/registry/data/org/openoffice/Office/UI/WriterWebWindowState.xcu| 
   5 
 officecfg/registry/data/org/openoffice/Office/UI/WriterWindowState.xcu   | 
   5 
 officecfg/registry/data/org/openoffice/Office/UI/XFormsWindowState.xcu   | 
   5 
 sfx2/source/control/dispatch.cxx | 
  24 
 sfx2/source/menu/mnumgr.cxx  | 
  56 --
 sw/UIConfig_sglobal.mk   | 
   1 
 sw/UIConfig_sweb.mk  | 
   1 
 sw/UIConfig_swform.mk| 
   1 
 sw/UIConfig_swreport.mk  | 
   1 
 sw/UIConfig_swriter.mk   | 
   1 
 sw/UIConfig_swxform.mk   | 
   1 
 sw/sdi/swriter.sdi   | 
   6 +
 sw/source/ui/app/app.src | 
  10 +
 sw/source/ui/app/mn.src  | 
   8 -
 sw/source/uibase/docvw/SidebarTxtControl.cxx | 
  35 --
 sw/source/uibase/docvw/SidebarTxtControl.hxx | 
   2 
 sw/source/uibase/inc/app.hrc | 
  15 --
 sw/source/uibase/inc/popup.hrc   | 
   7 -
 sw/source/uibase/shells/annotsh.cxx  | 
  30 -
 sw/uiconfig/sglobal/popupmenu/annotation.xml | 
  23 
 sw/uiconfig/sweb/popupmenu/annotation.xml| 
  23 
 sw/uiconfig/swform/popupmenu/annotation.xml  | 
  23 
 sw/uiconfig/swreport/popupmenu/annotation.xml| 
  23 
 sw/uiconfig/swriter/popupmenu/annotation.xml | 
  23 
 sw/uiconfig/swxform/popupmenu/annotation.xml | 
  23 
 31 files changed, 225 insertions(+), 158 deletions(-)

New commits:
commit ad236a3e1b456531ea758c2a3c5075860d823109
Author: Maxim Monastirsky 
Date:   Wed Jan 20 14:39:22 2016 +0200

i#107205 Remove SfxDispatcher::Popup and SfxPopupMenuManager::Popup

Change-Id: I1a8bee75a2dbfb039ec32faf001b75b26ea1f3fe

diff --git a/include/sfx2/dispatch.hxx b/include/sfx2/dispatch.hxx
index c6bc458..47be2d7 100644
--- a/include/sfx2/dispatch.hxx
+++ b/include/sfx2/dispatch.hxx
@@ -154,8 +154,6 @@ public:
 SfxShell*   GetShell(sal_uInt16 nIdx) const;
 SfxViewFrame*   GetFrame() const;
 SfxModule*  GetModule() const;
-// caller has to clean up the Manager on his own
-static SfxPopupMenuManager* Popup( sal_uInt16 nConfigId, vcl::Window 
*pWin, const Point *pPos );
 
 voidExecutePopup( const ResId , vcl::Window *pWin = 
nullptr, const Point *pPos = nullptr );
 voidExecutePopup( const OUString , vcl::Window 
*pWin = nullptr, const Point *pPos = nullptr );
diff --git a/include/sfx2/mnumgr.hxx b/include/sfx2/mnumgr.hxx
index 7682fc6..a1607b9 100644
--- a/include/sfx2/mnumgr.hxx
+++ b/include/sfx2/mnumgr.hxx
@@ -68,12 +68,6 @@ class SAL_DLLPUBLIC_EXPORT SfxPopupMenuManager : public 
SfxMenuManager
 {
 private:
 Menu*   pSVMenu;
-
-// when #i107205 gets fixed this one should be superfluous.
-// But right now we want to avoid the memory leak that would otherwise 
occur,
-// if we don't delete the pointer that got created in 
SfxPopupMenuManager::Popup
-static PopupMenu *  pStaticThesSubMenu;
-
 SfxPopupMenuManager( const SfxPopupMenuManager& ) = delete;
 SfxPopupMenuManager& operator=( const SfxPopupMenuManager& ) = delete;
 
@@ -81,11 +75,6 @@ public:
 SfxPopupMenuManager( PopupMenu*, SfxBindings& );
 ~SfxPopupMenuManager();
 static void ExecutePopup( const ResId&, SfxViewFrame* pViewFrame, 
const Point& rPoint, vcl::Window* pWindow );
-// @deprecated!!
-// Don't use this method any longer. The whole class will be removed in 
the future.
-// Changing code which relies on Popup would need much more effort.
- 

[Libreoffice-bugs] [Bug 97270] copying styles does not copy line spacing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97270

--- Comment #2 from Daniel  ---
Created attachment 122118
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122118=edit
Test case for styles not being copied using brush

First clear direct formatting for the line "try to change line spacing for this
two lines by copying styles from below" and then copy/apply styles using brush
form the lines below that paragraph with the line "try to change line spacing
for this two lines by copying styles from below".

It won't work, signle line spacing will be kept even when 1.5 line spacing is
copied from below.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97281] New: Page Margins, Border Settings changed when the document is saved

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97281

Bug ID: 97281
   Summary: Page Margins, Border Settings changed when the
document is saved
   Product: LibreOffice
   Version: 5.0.3.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo...@skofic.eu

Created attachment 122117
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122117=edit
Doc demonstrating the problem

i) Change the Page Format of enclosed document:

Format > Page > 

Page > Margins: set all to 0 cm
Apply 
Answer the “... out of print range!” message with Yes

Borders > Default: full border
Spacing to Contents: set borders as desired, e.g. all to 3 cm
Apply

You can see: The page is displayed correctly (full page colored, text area with
correct margins).


ii) Save this document, close Writer, open document again:

Settings are completely changed (page margins, borders spacing)!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97269] Linux portable edition

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97269

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl
Version|5.2.0.0.alpha0+ Master  |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/qa vcl/source

[Chris Sherlock]

 include/vcl/font.hxx |4 
 vcl/inc/impfont.hxx  |7 ---
 vcl/qa/cppunit/font.cxx  |   11 +++
 vcl/source/font/font.cxx |4 
 4 files changed, 23 insertions(+), 3 deletions(-)

New commits:
commit 137c440ccddbc9b41b8a8997820b7c0253b4de64
Author: Chris Sherlock 
Date:   Wed Jan 20 23:41:06 2016 +1100

vcl: add built in font property functions to Font class

Added setter for built-in font property and IsBuiltInFontFlag to
Font class.

See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.

Unit test added to vcl/qa/cppunit/font.cxx to test this flag.

Change-Id: I61ce33fe6ffb31be22c68ce8a94d0886ebdc8fcf
Reviewed-on: https://gerrit.libreoffice.org/21627
Reviewed-by: Chris Sherlock 
Tested-by: Chris Sherlock 

diff --git a/include/vcl/font.hxx b/include/vcl/font.hxx
index 19acdc6..51ce742 100644
--- a/include/vcl/font.hxx
+++ b/include/vcl/font.hxx
@@ -85,10 +85,14 @@ public:
 // Device dependent functions
 int GetQuality() const;
 
+boolIsBuiltInFont() const;
+
 voidSetQuality(int);
 voidIncreaseQualityBy(int);
 voidDecreaseQualityBy(int);
 
+voidSetBuiltInFontFlag(bool);
+
 // setting the color on the font is obsolete, the only remaining
 // valid use is for keeping backward compatibility with old MetaFiles
 const Color&GetColor() const;
diff --git a/vcl/inc/impfont.hxx b/vcl/inc/impfont.hxx
index 26616930..e7475e1 100644
--- a/vcl/inc/impfont.hxx
+++ b/vcl/inc/impfont.hxx
@@ -74,7 +74,7 @@ public:
 voidDecreaseQualityBy( int nQualityAmount ) { 
mnQuality -= nQualityAmount; }
 /* Missing function: OUString GetMapNames() const; */
 
-/* Missing function: bool IsBuiltInFont() const; */
+boolIsBuiltInFont() const   { 
return mbDevice; }
 /* Missing function: bool CanEmbed() const; */
 /* Missing function: bool CanSubSet() const; */
 /* Missing function: bool CanRotate() const; */
@@ -83,7 +83,7 @@ public:
 /* Missing function: void SetNames( OUString const& ); */
 /* Missing function: void AddMapName( OUString const& ); */
 
-/* Missing function: void SetBuiltInFontFlag( bool ); */
+voidSetBuiltInFontFlag( bool bIsBuiltInFont )   { 
mbDevice = bIsBuiltInFont; }
 /* Missing function: void SetEmbeddableFlag( bool ); */
 /* Missing function: void SetSettableFlag( bool ); */
 /* missing function: void SetOrientationFlag( bool ); */
@@ -123,7 +123,8 @@ private:
 mbConfigLookup:1,   // there was a config lookup
 mbShadow:1,
 mbVertical:1,
-mbTransparent:1;// compatibility, now on output 
device
+mbTransparent:1,// compatibility, now on output 
device
+mbDevice:1;
 int mnQuality;
 
 friend SvStream&ReadImplFont( SvStream& rIStm, ImplFont& );
diff --git a/vcl/qa/cppunit/font.cxx b/vcl/qa/cppunit/font.cxx
index 5649b32..224c8cd 100644
--- a/vcl/qa/cppunit/font.cxx
+++ b/vcl/qa/cppunit/font.cxx
@@ -27,6 +27,7 @@ public:
 void testPitch();
 void testItalic();
 void testQuality();
+void testBuiltInFontFlag();
 void testSymbolFlagAndCharSet();
 
 CPPUNIT_TEST_SUITE(VclFontTest);
@@ -36,6 +37,7 @@ public:
 CPPUNIT_TEST(testPitch);
 CPPUNIT_TEST(testItalic);
 CPPUNIT_TEST(testQuality);
+CPPUNIT_TEST(testBuiltInFontFlag);
 CPPUNIT_TEST(testSymbolFlagAndCharSet);
 CPPUNIT_TEST_SUITE_END();
 };
@@ -109,6 +111,15 @@ void VclFontTest::testQuality()
 CPPUNIT_ASSERT_EQUAL( (int)50, aFont.GetQuality() );
 }
 
+void VclFontTest::testBuiltInFontFlag()
+{
+vcl::Font aFont;
+
+CPPUNIT_ASSERT_EQUAL( false, aFont.IsBuiltInFont() );
+
+aFont.SetBuiltInFontFlag( true );
+CPPUNIT_ASSERT_EQUAL( true, aFont.IsBuiltInFont() );
+}
 
 void VclFontTest::testSymbolFlagAndCharSet()
 {
diff --git a/vcl/source/font/font.cxx b/vcl/source/font/font.cxx
index e24eb8a..7c9e9a2 100644
--- a/vcl/source/font/font.cxx
+++ b/vcl/source/font/font.cxx
@@ -813,6 +813,8 @@ void Font::SetQuality( int nQuality ) { 
mpImplFont->SetQuality( nQuality ); }
 void Font::IncreaseQualityBy( int nQualityAmount ) { 
mpImplFont->IncreaseQualityBy( nQualityAmount ); }
 void Font::DecreaseQualityBy( int nQualityAmount ) { 
mpImplFont->DecreaseQualityBy( nQualityAmount ); }
 
+bool Font::IsBuiltInFont() const { return mpImplFont->IsBuiltInFont(); }
+void Font::SetBuiltInFontFlag( bool bIsBuiltInFontFlag ) { 
mpImplFont->SetBuiltInFontFlag( bIsBuiltInFontFlag ); }
 bool Font::IsOutline() const { 

[Libreoffice-bugs] [Bug 97240] FORMATTING: Some scrolling lists don't allow selection with the mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97240

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #2 from raal  ---
I can not confirm with Version: 5.2.0.0.alpha0+
Build ID: d95d9d7f908419f397941ef60ac6ced3261c9b87
CPU Threads: 4; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-01-19_00:40:21

Please could you test with dev version?
http://dev-builds.libreoffice.org/daily/master/
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97279] Section 'Undo' vanished from the Options dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97279

--- Comment #5 from Wolfgang Jäger  ---
(In reply to Samuel Mehrbrodt from comment #4)
> 
> Please read the commit message for rationale.

You surely can help me to find it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97229] Tables are split after saving as .doc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97229

raal  changed:

   What|Removed |Added

 CC||r...@post.cz

--- Comment #1 from raal  ---
Where can I see this parameter in Microsoft Word? Can you post a printscreen?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97251] Unhide text direction cell attribute

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97251

--- Comment #2 from Yousuf (Jay) Philips  ---
I seem to be confused that LTR users would find the text direction feature
confusing when LTR users can set a cell contents to align right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - qadevOOo/runner qadevOOo/tests

[Caolán McNamara]

 qadevOOo/runner/util/utils.java|   11 +---
 qadevOOo/tests/java/ifc/frame/_XDocumentTemplates.java |   21 -
 2 files changed, 13 insertions(+), 19 deletions(-)

New commits:
commit 16255e485e985a139240a09c78a489e14786
Author: Caolán McNamara 
Date:   Wed Jan 20 17:36:52 2016 +

coverity#1326418 Dereference null return value

Change-Id: I5910518d0ae672232b00915a2437a5881dfa5f16

diff --git a/qadevOOo/tests/java/ifc/frame/_XDocumentTemplates.java 
b/qadevOOo/tests/java/ifc/frame/_XDocumentTemplates.java
index 2031ca3..60d5562 100644
--- a/qadevOOo/tests/java/ifc/frame/_XDocumentTemplates.java
+++ b/qadevOOo/tests/java/ifc/frame/_XDocumentTemplates.java
@@ -188,19 +188,20 @@ public class _XDocumentTemplates extends MultiMethodTest {
  * Returns the string representation of content passed as parameter.
  */
 protected String getContentList(XContent content) {
-XResultSet statRes = getStatResultSet(content);
 StringBuilder ret = new StringBuilder();
-try {
-statRes.first();
-XRow row = UnoRuntime.queryInterface(XRow.class, statRes);
-while(! statRes.isAfterLast()) {
-ret.append("\n").append(row.getString(1));
-statRes.next();
+XResultSet statRes = getStatResultSet(content);
+if (statRes != null) {
+try {
+statRes.first();
+XRow row = UnoRuntime.queryInterface(XRow.class, statRes);
+while(! statRes.isAfterLast()) {
+ret.append("\n").append(row.getString(1));
+statRes.next();
+}
+} catch (com.sun.star.sdbc.SQLException e) {
+log.println("Exception occurred:" + e);
 }
-} catch (com.sun.star.sdbc.SQLException e) {
-log.println("Exception occurred:" + e);
 }
-
 return ret.toString();
 }
 
commit 13b1c4a684b2c344660e1e9caaa4b4e667ca65a9
Author: Caolán McNamara 
Date:   Wed Jan 20 17:35:06 2016 +

coverity#1326388 Dereference null return value

Change-Id: Ifad565e1548a9564196bfcd7b77d81ebb97231f6

diff --git a/qadevOOo/runner/util/utils.java b/qadevOOo/runner/util/utils.java
index 914b066..c3f3458 100644
--- a/qadevOOo/runner/util/utils.java
+++ b/qadevOOo/runner/util/utils.java
@@ -203,15 +203,8 @@ public class utils {
  *
  */
 public static String getOfficeUserPath(XMultiServiceFactory msf) {
-String userPath = null;
-
 // get a folder located in the user dir
-try {
-userPath = getOfficeSettingsValue(msf, "UserConfig");
-} catch (Exception e) {
-System.out.println("Couldn't get Office User Path");
-e.printStackTrace();
-}
+String userPath = getOfficeSettingsValue(msf, "UserConfig");
 
 // strip the returned folder to the user dir
 if (userPath.charAt(userPath.length() - 1) == '/') {
commit 960acbfdee1bcd2053a84c95f1c7ed046d3ade23
Author: Caolán McNamara 
Date:   Wed Jan 20 17:33:49 2016 +

coverity#1326387 Dereference null return value

Change-Id: I150d3df8926a547b8ecf4324303dc4520ee2e899

diff --git a/qadevOOo/runner/util/utils.java b/qadevOOo/runner/util/utils.java
index 3acbb55..914b066 100644
--- a/qadevOOo/runner/util/utils.java
+++ b/qadevOOo/runner/util/utils.java
@@ -82,7 +82,7 @@ public class utils {
 }
 });
 
-if (list[0] != null) {
+if (list != null && list[0] != null) {
 String tDoc = 
srcRoot.concat(pthSep).concat(list[0]).concat(pthSep).concat("testdocs");
 
 if (new File(tDoc).exists()) {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97240] FORMATTING: Some scrolling lists don't allow selection with the mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97240

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||momonas...@gmail.com
 Ever confirmed|0   |1

--- Comment #3 from Maxim Monastirsky  ---
Hi Jean-Luc,

Do you use the gtk3 backend? What happens if you do "export
SAL_USE_VCLPLUGIN=gtk" and then start LO from the same terminal?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97225] Orientation changes in columns

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97225

raal  changed:

   What|Removed |Added

   Keywords||regression
 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

--- Comment #1 from raal  ---
Hello Christian,

Thank you for filing the bug. Please send us a sample document, as this makes
it easier for us to verify the bug. 
I have set the bug's status to 'NEEDINFO', so please do change it back to
'UNCONFIRMED' once you have attached a document.
(Please note that the attachment will be public, remove any sensitive
information before attaching it.)
How can I eliminate confidential data from a sample document?
https://wiki.documentfoundation.org/QA/FAQ#How_can_I_eliminate_confidential_data_from_a_sample_document.3F
Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97247] Focus goes strange when typing UP/LEFT at merged cell at top-left corner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97247

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Eike Rathke]

 sc/source/ui/view/tabview3.cxx |   78 +++--
 1 file changed, 52 insertions(+), 26 deletions(-)

New commits:
commit 24b9f873a691f4cfe4b3fa2c2a48f79a41a12417
Author: Eike Rathke 
Date:   Wed Jan 20 22:07:08 2016 +0100

there's no reason to be sparing with new lines

Change-Id: Id8334694aec17ec61490460b0917514beebd94a3

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 6aa1139..0dd373c 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -832,13 +832,15 @@ void ScTabView::AlignToCursor( SCsCOL nCurX, SCsROW 
nCurY, ScFollowMode eMode,
 if ( nCurX < nDeltaX || nCurX >= nDeltaX+nSizeX )
 {
 nNewDeltaX = nCurX - 
static_cast(aViewData.CellsAtX( nCurX, -1, eAlignX, 
static_cast(nSpaceX) ));
-if (nNewDeltaX < 0) nNewDeltaX = 0;
+if (nNewDeltaX < 0)
+nNewDeltaX = 0;
 nSizeX = (SCsCOL) aViewData.CellsAtX( nNewDeltaX, 1, 
eAlignX );
 }
 if ( nCurY < nDeltaY || nCurY >= nDeltaY+nSizeY || bForceNew )
 {
 nNewDeltaY = nCurY - 
static_cast(aViewData.CellsAtY( nCurY, -1, eAlignY, 
static_cast(nSpaceY) ));
-if (nNewDeltaY < 0) nNewDeltaY = 0;
+if (nNewDeltaY < 0)
+nNewDeltaY = 0;
 nSizeY = (SCsROW) aViewData.CellsAtY( nNewDeltaY, 1, 
eAlignY );
 }
 bDoLine = true;
@@ -852,13 +854,15 @@ void ScTabView::AlignToCursor( SCsCOL nCurX, SCsROW 
nCurY, ScFollowMode eMode,
 if ( nCurX < nDeltaX || nCurX >= nDeltaX+nSizeX )
 {
 nNewDeltaX = nDeltaX + nCurX - aViewData.GetCurX();
-if (nNewDeltaX < 0) nNewDeltaX = 0;
+if (nNewDeltaX < 0)
+nNewDeltaX = 0;
 nSizeX = (SCsCOL) aViewData.CellsAtX( nNewDeltaX, 1, 
eAlignX );
 }
 if ( nCurY < nDeltaY || nCurY >= nDeltaY+nSizeY )
 {
 nNewDeltaY = nDeltaY + nCurY - aViewData.GetCurY();
-if (nNewDeltaY < 0) nNewDeltaY = 0;
+if (nNewDeltaY < 0)
+nNewDeltaY = 0;
 nSizeY = (SCsROW) aViewData.CellsAtY( nNewDeltaY, 1, 
eAlignY );
 }
 
@@ -867,13 +871,15 @@ void ScTabView::AlignToCursor( SCsCOL nCurX, SCsROW 
nCurY, ScFollowMode eMode,
 if ( nCurX < nNewDeltaX || nCurX >= nNewDeltaX+nSizeX )
 {
 nNewDeltaX = nCurX - (nSizeX / 2);
-if (nNewDeltaX < 0) nNewDeltaX = 0;
+if (nNewDeltaX < 0)
+nNewDeltaX = 0;
 nSizeX = (SCsCOL) aViewData.CellsAtX( nNewDeltaX, 1, 
eAlignX );
 }
 if ( nCurY < nNewDeltaY || nCurY >= nNewDeltaY+nSizeY )
 {
 nNewDeltaY = nCurY - (nSizeY / 2);
-if (nNewDeltaY < 0) nNewDeltaY = 0;
+if (nNewDeltaY < 0)
+nNewDeltaY = 0;
 nSizeY = (SCsROW) aViewData.CellsAtY( nNewDeltaY, 1, 
eAlignY );
 }
 
@@ -907,22 +913,30 @@ void ScTabView::AlignToCursor( SCsCOL nCurX, SCsROW 
nCurY, ScFollowMode eMode,
 ++nNewDeltaY;
 nSizeY = (SCsROW) aViewData.CellsAtY( nNewDeltaY, 1, eAlignY );
 }
-if ( nCurX < nNewDeltaX ) nNewDeltaX = nCurX;
-if ( nCurY < nNewDeltaY ) nNewDeltaY = nCurY;
+if ( nCurX < nNewDeltaX )
+nNewDeltaX = nCurX;
+if ( nCurY < nNewDeltaY )
+nNewDeltaY = nCurY;
 }
 
 if ( nNewDeltaX != nDeltaX )
 nSizeX = (SCsCOL) aViewData.CellsAtX( nNewDeltaX, 1, eAlignX );
-if (nNewDeltaX+nSizeX-1 > MAXCOL) nNewDeltaX = MAXCOL-nSizeX+1;
-if (nNewDeltaX < 0) nNewDeltaX = 0;
+if (nNewDeltaX+nSizeX-1 > MAXCOL)
+nNewDeltaX = MAXCOL-nSizeX+1;
+if (nNewDeltaX < 0)
+nNewDeltaX = 0;
 
 if ( nNewDeltaY != nDeltaY )
 nSizeY = (SCsROW) aViewData.CellsAtY( nNewDeltaY, 1, eAlignY );
-if (nNewDeltaY+nSizeY-1 > MAXROW) nNewDeltaY = MAXROW-nSizeY+1;
-if (nNewDeltaY < 0) nNewDeltaY = 0;
+if (nNewDeltaY+nSizeY-1 > MAXROW)
+nNewDeltaY = MAXROW-nSizeY+1;
+if (nNewDeltaY < 0)
+nNewDeltaY = 0;
 
-if ( nNewDeltaX != nDeltaX ) ScrollX( nNewDeltaX - nDeltaX, eAlignX );
-if ( nNewDeltaY != nDeltaY ) ScrollY( nNewDeltaY - nDeltaY, eAlignY );
+if ( nNewDeltaX != nDeltaX )
+ScrollX( nNewDeltaX - nDeltaX, eAlignX );
+if ( nNewDeltaY != nDeltaY )
+

[Libreoffice-bugs] [Bug 97219] libreoffice calc crashed frequently.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97219

raal  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||r...@post.cz
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Takeshi Abe]

 sc/source/ui/view/tabview3.cxx |   11 +++
 1 file changed, 11 insertions(+)

New commits:
commit c13226bcc5b298dacfe32340711bdfd4d15d8b3b
Author: Takeshi Abe 
Date:   Wed Jan 20 22:13:12 2016 +0900

tdf#97247 Keep focus on merged cell at top-left corner

... when typing either UP or LEFT key.

Change-Id: I7bc0e7eb0cba322bcc26c35d0474ea558d3bdd6e
Reviewed-on: https://gerrit.libreoffice.org/21599
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 10de038..6aa1139 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -1067,6 +1067,17 @@ void ScTabView::MoveCursorRel( SCsCOL nMovX, SCsROW 
nMovY, ScFollowMode eMode,
 nCurY = (nMovY != 0) ? nOldY+nMovY : (SCsROW) aViewData.GetOldCurY();
 }
 
+if (nMovX < 0 && nOldX == 0)
+{ // trying to go left from 1st column
+if (nMovY == 0) // done, because no vertical move is requested
+return;
+}
+if (nMovY < 0 && nOldY == 0)
+{ // trying to go up from 1st row
+if (nMovX == 0) // done, because no horizontal move is requested
+return;
+}
+
 aViewData.ResetOldCursor();
 
 if (nMovX != 0 && ValidColRow(nCurX,nCurY))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97247] Focus goes strange when typing UP/LEFT at merged cell at top-left corner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97247

--- Comment #3 from Commit Notification 
 ---
Takeshi Abe committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=c13226bcc5b298dacfe32340711bdfd4d15d8b3b

tdf#97247 Keep focus on merged cell at top-left corner

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97240] FORMATTING: Some scrolling lists don't allow selection with the mouse

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97240

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Maxim Monastirsky  ---
(In reply to Jean-Luc Coulon from comment #4)
> Yes, I was using gtk3 backend
Thanks. It's a duplicate of Bug 96604 then.

> Depending the versions I've had to choose gtk3/gnome/gtk
Note that "gnome" isn't a valid value for SAL_USE_VCLPLUGIN. Don't confuse it
with OOO_FORCE_DESKTOP.

> artefacts on the screen: e.g. right large vertical band on the working area.
Sounds like (the already fixed) Bug 93373.

*** This bug has been marked as a duplicate of bug 96604 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97247] Focus goes strange when typing UP/LEFT at merged cell at top-left corner

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97247

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
Version|4.3.3.2 release |Inherited From OOo
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |t...@fixedpoint.jp
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs