date:20160124

[Libreoffice-bugs] [Bug 96590] UI: after saving file, save icon is not greyed out

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96590

--- Comment #17 from t...@tim-passingham.co.uk ---
(In reply to tommy27 from comment #16)
> (In reply to tim from comment #14)
> > As a normal user just moved on to 5.0.1.2
> > ...
> 
> I suppose you meant 5.1.0.2
> 
> a s a "normal user" you should keep using 5.0.4.2 for production
> the 5.1.0.2 is a "release candidate" of a development branch
> 
> as clearly stated in the download page:
> http://www.libreoffice.org/download/pre-releases/
> 
> These are pre-release versions and are not recommended for production use.
> Interested in helping out? Please read the release notes and visit our
> Testers page.
> 
> -
> 
> so it's great if you download a pre-release and test it, but do not get
> upset if you find bugs that alter your workflow during production.
> 
> moreover as Maxim said, a visual hint about saving will be featured in
> 5.1.0.3 RC
> 
> you can already test a 5.1.x daily build here
> http://dev-builds.libreoffice.org/daily/
> 
> and tell if the change is satisfying
Yes - sorry - I meant 5.1.0.2.

I wanted to try this release because of several bugs in to 5.0.4.2 that made it
unusable for my purposes.  I'm not a 'production ' user, but a home user for
some databases, spreadsheets and so on.  

I don't mind being on a beta release, provide that when I make a comment it's
received in the spirit intended.   The WONTFIX status is a little misleading,
since it seems 'SOMEFIX' will be made :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86609] TOOLBAR: Paste no longer has paste special drop down in Impress/Draw

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86609

Maxim Monastirsky  changed:

   What|Removed |Added

   Keywords|needsDevEval, topicUI   |
 Status|NEW |ASSIGNED
Version|4.4.0.0.alpha2  |Inherited From OOo
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

--- Comment #5 from Maxim Monastirsky  ---
Regression from 2005, it seems...

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97228] Split up include files in include/vcl where possible into separate public and internal parts

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97228

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97144] DataRaces in WeakReferenceHelper

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97144

Beluga  changed:

   What|Removed |Added

 CC||todven...@suomi24.fi

--- Comment #4 from Beluga  ---
Please submit your patch to gerrit:
https://wiki.documentfoundation.org/Development/gerrit/setup
Patches are not collected from Bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2016-01-24 Thread Stanislav Horacek

 source/text/scalc/main0210.xhp |2 +-
 source/text/shared/00/0403.xhp |2 +-
 source/text/shared/01/0311.xhp |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ae5a04169dd5c9e523eacbaa4c401aea3b4b5231
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:05:21 2016 +0100

full screen button label has no "on/off" anymore

Change-Id: Icc37109d829d6ca150af6daa518ee36cf3225b79
Reviewed-on: https://gerrit.libreoffice.org/21747
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/source/text/scalc/main0210.xhp b/source/text/scalc/main0210.xhp
index c856699..c25cc9d 100644
--- a/source/text/scalc/main0210.xhp
+++ b/source/text/scalc/main0210.xhp
@@ -49,7 +49,7 @@
 
 
 Full Screen
-Hides the menus and toolbars. To exit the full screen mode, click 
the Full Screen On/Off button.
+Hides the menus 
and toolbars. To exit the full screen mode, click the Full Screen 
button.
 Format Page
 
 Margins
diff --git a/source/text/shared/00/0403.xhp 
b/source/text/shared/00/0403.xhp
index dabbf85..c8cd774 100644
--- a/source/text/shared/00/0403.xhp
+++ b/source/text/shared/00/0403.xhp
@@ -82,7 +82,7 @@

 
 
-Full Screen On/Off (in Print Preview)
+Full Screen 
(in Print Preview)
 
 
 
diff --git a/source/text/shared/01/0311.xhp 
b/source/text/shared/01/0311.xhp
index ddff2a7..d2e2b62 100644
--- a/source/text/shared/01/0311.xhp
+++ b/source/text/shared/01/0311.xhp
@@ -41,7 +41,7 @@
 
 
 Full 
Screen
-Shows or hides the menus and toolbars in Writer or Calc. To exit the 
full screen mode, click the Full Screen On/Off button or press the 
Esc key.
+Shows or hides the menus and toolbars in Writer or Calc. To exit the 
full screen mode, click the Full Screen button or press the Esc 
key.
 
 
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-01-24 Thread Stanislav Horacek

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ae14dd6016ae084efc13e02fa0ffc14f859e31f7
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:05:21 2016 +0100

Updated core
Project: help  ae5a04169dd5c9e523eacbaa4c401aea3b4b5231

full screen button label has no "on/off" anymore

Change-Id: Icc37109d829d6ca150af6daa518ee36cf3225b79
Reviewed-on: https://gerrit.libreoffice.org/21747
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index 6fadb77..ae5a041 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 6fadb77956def42d1bd221e2af10f68e53207b8a
+Subproject commit ae5a04169dd5c9e523eacbaa4c401aea3b4b5231
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97225] Orientation changes in columns

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97225

raal  changed:

   What|Removed |Added

   Keywords|regression  |corruptProfile
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #9 from raal  ---
(In reply to christian from comment #8)
> This was it: After renaming the directory profile the table behaved
> normally. After re-renaming the directory profile, the bug was there again. 
> 
> What shall I do now? Work with a new directory profile? Would I lose
> personal data?
> 
> Thank you very much for your effort - I don't think that M$ would do
> something like that...;-)

Hello,
you can work with new profile. No personal data lost, in profile are stored LO
setting (Tools - options; last used files etc.).
Closing bug as WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 3 commits - loleaflet/src

2016-01-24 Thread Marco Cecchetti

 loleaflet/src/control/Parts.js |1 
 loleaflet/src/control/Search.js|8 
 loleaflet/src/dom/DomEvent.js  |   15 ++--
 loleaflet/src/dom/Draggable.js |9 
 loleaflet/src/layer/tile/TileLayer.js  |   61 -
 loleaflet/src/map/Map.js   |   28 ++-
 loleaflet/src/map/handler/Map.Mouse.js |   36 ++-
 7 files changed, 152 insertions(+), 6 deletions(-)

New commits:
commit a698d6a2d11cbc1190519793eaad3cde75526ca8
Author: Marco Cecchetti 
Date:   Sun Jan 24 14:56:51 2016 +0100

loleaflet - fix for multi-line text selection issues

Steps for reproducing the problem:
1) try to select some multi-line text
2) still holding the mouse button pressed move the mouse pointer
outside the browser window
3) release the mouse button
4) move the cursor back over the map.

Expected result: the selection should not change any more after the
mouse button has been released.
Real result: the selection changes when you move the mouse.

The same happens when you move the mouse pointer out of the tiles
covering, even if we are still inside the html document element area
where the map is embedded.

A similar issue occurs in view only mode when you drag the document: in
this case the problem occurs only when you move the mouse pointer out of
the tiles covering, but still inside the html document element area
where the map is embedded.

The behaviour described above is due to the fact that the map container
receives mouse events only when the mouse pointer is over the map.
The implemented fix checks for mouseout events which occur between a
tile element and a non-tile element (such as the the resize-detector
iframe, the scroll-bar container, the selection cursor marker). When
such an event occurs handlers for mousemove and mouseup events are
attached to the HTML document element and to the resize-detector iframe.
In the same way when a mouseover event occurs between a tile element and
a non-tile element such handlers are removed.

It was needed to attach handlers to the resize-detector iframe too since
the HTML document element seems to not be able to receive mouse events
that occur inside the iframe area.

A side effect of this fix is that now the text selection goes on
changing as far as the mouse button is not released even when the mouse
pointer is moved out of the tiles covering.

Since for an iframe the coordinates embedded in a mouse event are
relative to the iframe area, it was needed to implement a workaround in
order to avoid sudden changes in the current selection or in the
document position when the mouse pointer moves out of the map.

diff --git a/loleaflet/src/dom/DomEvent.js b/loleaflet/src/dom/DomEvent.js
index a83a5ac..d1f9141 100644
--- a/loleaflet/src/dom/DomEvent.js
+++ b/loleaflet/src/dom/DomEvent.js
@@ -180,11 +180,20 @@ L.DomEvent = {
return new L.Point(e.clientX, e.clientY);
}
 
-   var rect = container.getBoundingClientRect();
+   var rect = container.getBoundingClientRect(), // constant object
+   left = rect.left,
+   top = rect.top;
+
+   // iframe mouse coordinates are relative to the frame area
+   // `target`: body element of the iframe; `currentTarget`: 
content window of the iframe
+   if (e.currentTarget && e.currentTarget.frameElement
+   && L.DomUtil.hasClass(e.currentTarget.frameElement, 
'resize-detector')) {
+   left = top = 0;
+   }
 
return new L.Point(
-   e.clientX - rect.left - container.clientLeft,
-   e.clientY - rect.top - container.clientTop);
+   e.clientX - left - container.clientLeft,
+   e.clientY - top - container.clientTop);
},
 
getWheelDelta: function (e) {
diff --git a/loleaflet/src/dom/Draggable.js b/loleaflet/src/dom/Draggable.js
index 3eaafa7..4e7280d 100644
--- a/loleaflet/src/dom/Draggable.js
+++ b/loleaflet/src/dom/Draggable.js
@@ -90,6 +90,15 @@ L.Draggable = L.Evented.extend({
offset = newPoint.subtract(this._startPoint);
 
if (this._map) {
+   // needed in order to avoid a jump when the document is 
dragged and the mouse pointer move
+   // from over the map into the html document element 
area which is not covered by tiles
+   // (resize-detector iframe)
+   if (e.currentTarget && e.currentTarget.frameElement
+   && 
L.DomUtil.hasClass(e.currentTarget.frameElement, 'resize-detector')) {
+

[Libreoffice-bugs] [Bug 92132] Erratic VIEWING of Calc Cells contents

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92132

--- Comment #3 from Ian  ---
Hi, sorry to leave this for so long.
i have been using version 4.4.5.2. since 23 Jul 15, and the issue still occurs.
 (In fact I use LibreOffice less often now because of it - but I would really
lie to be using it much more, if only it was reliable for me.)

I have since discovered that resizing the Libre Office window - even by the
slightest amount - appears to rectify the erratic display.  But you can
appreciate that this is far from ideal.

I will try and use the programme more often over the next few weeks and provide
some images.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97260] UI: gtk3 keyboard shortcuts not working in all dialog boxes

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97260

--- Comment #9 from Luke  ---
Adolfo,
You solution is not acceptable. That is a global variable. And we should not
force users to make changes like that just to keep the workflow consistent. The
GTK3 workflow should be the same as the GTK2 and Windows by default. 

We should only use the accelerators in menu items ONLY.  By using them in the
dialog buttons, we force the user to use different shortcuts for differ
toolkits.
Ctrl+W, S -> Ctrl+W, Alt+S

This is a bug. Shortcut should not change between widget toolkits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97346] Copy table to Calc. Lost character encoding

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97346

Urmas  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Urmas  ---


*** This bug has been marked as a duplicate of bug 37859 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 37859] Odb data copied to Calc showed wrong encoding in Windows

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=37859

Urmas  changed:

   What|Removed |Added

 CC||deep...@list.ru

--- Comment #31 from Urmas  ---
*** Bug 97346 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95441] Typed text not confirmed with Enter or Tab will move to newly added sheet

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95441

Beluga  changed:

   What|Removed |Added

   Keywords||needsDevEval
 Status|NEEDINFO|NEW
Version|5.1.0.0.alpha1  |3.5.0 release
Summary|Crash when openning |Typed text not confirmed
   |Multiple Sheets |with Enter or Tab will move
   ||to newly added sheet
 OS|Linux (All) |All

--- Comment #4 from Beluga  ---
(In reply to aybuke from comment #3)
> here, I can't copy on Sheet1. sheet1's content "abcd" looks to sheet2.
> sheet1 is blank after step 3.
> (ubuntu15.04)

You mean you enter abcd, but do not confirm it by pressing enter or tab.

I can reproduce that.

I guess that is not the intended result as formulas do stay alive in the first
sheet after adding sheets.

Win 7 Pro 64-bit Version: 5.2.0.0.alpha0+
Build ID: 6b65a0e83c4798f117be61af91dbaebdc85e94b7
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@39, Branch:master, Time: 2016-01-21_03:41:08
Locale: fi-FI (fi_FI)

LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97140] Connection to Google Drive not avaible

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97140

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #6 from Beluga  ---
(In reply to Peter Dreyer from comment #4)
> Done, but same Problem.
> 
> After clicking the marked Button LibreOffice is freezing.

Did you try with 5.1 like MM asked?

http://www.libreoffice.org/download/pre-releases/

Set to NEEDINFO.
Change back to UNCONFIRMED, if the problem persists. Change to RESOLVED
WORKSFORME, if the problem went away in 5.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97225] Orientation changes in columns

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97225

--- Comment #10 from christ...@ludwig.nrw ---
Thanks again - you are great!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97260] UI: gtk3 keyboard shortcuts not working in all dialog boxes

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97260

Luke  changed:

   What|Removed |Added

   See Also||https://bugzilla.gnome.org/
   ||show_bug.cgi?id=761058

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - loleaflet/src

2016-01-24 Thread Marco Cecchetti

 loleaflet/src/dom/DomEvent.js  |   15 +++--
 loleaflet/src/dom/Draggable.js |9 
 loleaflet/src/map/Map.js   |   28 -
 loleaflet/src/map/handler/Map.Mouse.js |   36 -
 4 files changed, 83 insertions(+), 5 deletions(-)

New commits:
commit c2d0e6cd7abb5d525696a64b4ed3c001f537d3ca
Author: Marco Cecchetti 
Date:   Sun Jan 24 14:56:51 2016 +0100

loleaflet - fix for multi-line text selection issues

Steps for reproducing the problem:
1) try to select some multi-line text
2) still holding the mouse button pressed move the mouse pointer
outside the browser window
3) release the mouse button
4) move the cursor back over the map.

Expected result: the selection should not change any more after the
mouse button has been released.
Real result: the selection changes when you move the mouse.

The same happens when you move the mouse pointer out of the tiles
covering, even if we are still inside the html document element area
where the map is embedded.

A similar issue occurs in view only mode when you drag the document: in
this case the problem occurs only when you move the mouse pointer out of
the tiles covering, but still inside the html document element area
where the map is embedded.

The behaviour described above is due to the fact that the map container
receives mouse events only when the mouse pointer is over the map.
The implemented fix checks for mouseout events which occur between a
tile element and a non-tile element (such as the the resize-detector
iframe, the scroll-bar container, the selection cursor marker). When
such an event occurs handlers for mousemove and mouseup events are
attached to the HTML document element and to the resize-detector iframe.
In the same way when a mouseover event occurs between a tile element and
a non-tile element such handlers are removed.

It was needed to attach handlers to the resize-detector iframe too since
the HTML document element seems to not be able to receive mouse events
that occur inside the iframe area.

A side effect of this fix is that now the text selection goes on
changing as far as the mouse button is not released even when the mouse
pointer is moved out of the tiles covering.

Since for an iframe the coordinates embedded in a mouse event are
relative to the iframe area, it was needed to implement a workaround in
order to avoid sudden changes in the current selection or in the
document position when the mouse pointer moves out of the map.

diff --git a/loleaflet/src/dom/DomEvent.js b/loleaflet/src/dom/DomEvent.js
index a83a5ac..d1f9141 100644
--- a/loleaflet/src/dom/DomEvent.js
+++ b/loleaflet/src/dom/DomEvent.js
@@ -180,11 +180,20 @@ L.DomEvent = {
return new L.Point(e.clientX, e.clientY);
}
 
-   var rect = container.getBoundingClientRect();
+   var rect = container.getBoundingClientRect(), // constant object
+   left = rect.left,
+   top = rect.top;
+
+   // iframe mouse coordinates are relative to the frame area
+   // `target`: body element of the iframe; `currentTarget`: 
content window of the iframe
+   if (e.currentTarget && e.currentTarget.frameElement
+   && L.DomUtil.hasClass(e.currentTarget.frameElement, 
'resize-detector')) {
+   left = top = 0;
+   }
 
return new L.Point(
-   e.clientX - rect.left - container.clientLeft,
-   e.clientY - rect.top - container.clientTop);
+   e.clientX - left - container.clientLeft,
+   e.clientY - top - container.clientTop);
},
 
getWheelDelta: function (e) {
diff --git a/loleaflet/src/dom/Draggable.js b/loleaflet/src/dom/Draggable.js
index 3eaafa7..4e7280d 100644
--- a/loleaflet/src/dom/Draggable.js
+++ b/loleaflet/src/dom/Draggable.js
@@ -90,6 +90,15 @@ L.Draggable = L.Evented.extend({
offset = newPoint.subtract(this._startPoint);
 
if (this._map) {
+   // needed in order to avoid a jump when the document is 
dragged and the mouse pointer move
+   // from over the map into the html document element 
area which is not covered by tiles
+   // (resize-detector iframe)
+   if (e.currentTarget && e.currentTarget.frameElement
+   && 
L.DomUtil.hasClass(e.currentTarget.frameElement, 'resize-detector')) {
+   var rect = 
this._map._container.getBoundingClientRect(),
+   correction = new L.Point(rect.left,

Re: Setting data in Writer chart from Basic

2016-01-24 Thread Regina Henschel


Hi Jan,

it might work for you as
oXCOEO = xChart.ExtendedControlOverEmbeddedObject
oXCOEO.update()

If you sent me a document including the macro and the chart, I can try it.

Or you try it with event, as described here 
https://forum.openoffice.org/en/forum/viewtopic.php?f=45=28327


It is a typical question for a forum.

Kind regards
Regina


Jan Rheinländer schrieb:

Hi,

with this code I can change the data in a Writer chart:

 set doc = thisComponent
 set ctrl = thisComponent.CurrentController
 xChart = ctrl.getModel().getEmbeddedObjects.getByName("Objekt1")
 set cDoc = xChart.getEmbeddedObject
 set cDataArray = cDoc.getDataProvider
 data = cDataArray.getData
 ' Do something with the data
 cDataArray.setData(data)

But I can't get the chart to update. The only way I see is to
double-click on the chart in the document, then it will update.

What is the right way to force an update via code?

Thank!
 Jan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97256] Printview prompt in wrong place

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97256

Beluga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #2 from Beluga  ---
Yeah, screenshot + more details.
Please also verify you still have the problem in 5.0.4.

Set to NEEDINFO.
Change back to UNCONFIRMED after you have provided the information.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 75354] EDITING: Base TABLE Editor not updating table FIELDS properly when both FIELD NAME and FILED TYPE are changed

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=75354

--- Comment #5 from rob...@familiegrosskopf.de ---
The bug still exists. 
Note: The fieldname has been changed, but isn't shown right while editing the
table, only shown right while input new data.

The fieldtype couldn't be changed. Internal HSQLDB could not change a type from
Tiny Integer to Date.

If you only want to change the fieldname this will work. So the dialog, which
appears, is misleading.
Tested with LO 5.1.0.2 OpenSUSE 42.1 Leap 64bit rpm Linux

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97093] Backspace changes font to standard if it is not the same

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97093

--- Comment #4 from birqu...@web.de ---
Interesting: If I use the "undo"-button after deleteing something, the font is
switched back to the template font, also if the whole word was changed to the
"new" font. In the undo-list appear "Attribute anwenden" ("apply attributes"
...?) twice - it seems that deleteing by "backspace" calls some other functions
as well.
The font is also changed if all standard fonts within the writer options are
switched to the same as in the template or file. Some of the not used and not
listed styles may still have connection to the former standard font. (I found
the "character style" still in the "old" standard font. But it can't be
switched.)

The changes to the whole word appear if a letter from the middle of the word is
deleted useing "backspace".

I hope this helps to figure out where "the happy font switching" is coming
from.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97341] Width for comments aside the margin of the document is too narrow / can't be re-sized

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97341

Cor Nouws  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
   Hardware|x86-64 (AMD64)  |All
  Component|LibreOffice |Writer
 CC||c...@nouenoff.nl
 Ever confirmed|0   |1
Summary|Comment box is too narrow   |Width for comments aside
   |in LibreOffice Writer   |the margin of the document
   ||is too narrow / can't be
   ||re-sized
   Severity|normal  |enhancement
 OS|Linux (All) |All

--- Comment #1 from Cor Nouws  ---
Thanks for filing this issue Claudio.
Looks as an interesting improvement to me > New enhancement. 
Ciao - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2016-01-24 Thread Stanislav Horacek

 source/text/swriter/01/0213.xhp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit f14ca713a989a677f6a2b00a9c5a405df6204d1d
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:09:05 2016 +0100

correct button label in Edit bibliography entry dialog

Change-Id: Iad3b2fcfca9d97e24b6848475e8f37cd45195b1d
Reviewed-on: https://gerrit.libreoffice.org/21748
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/source/text/swriter/01/0213.xhp 
b/source/text/swriter/01/0213.xhp
index 75deb92..a4980a0 100644
--- a/source/text/swriter/01/0213.xhp
+++ b/source/text/swriter/01/0213.xhp
@@ -45,7 +45,7 @@
 Author, 
Title
 Displays the 
author and title information contained in the bibliography entry.
 
-Modify
+Apply
 Applies the 
changes that you made, and then closes the Edit Bibliography Entry 
dialog.
 
 Close
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-01-24 Thread Stanislav Horacek

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit d86503eab6547fa8023ecaff9889988504a36fe8
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:09:05 2016 +0100

Updated core
Project: help  f14ca713a989a677f6a2b00a9c5a405df6204d1d

correct button label in Edit bibliography entry dialog

Change-Id: Iad3b2fcfca9d97e24b6848475e8f37cd45195b1d
Reviewed-on: https://gerrit.libreoffice.org/21748
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index ae5a041..f14ca71 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit ae5a04169dd5c9e523eacbaa4c401aea3b4b5231
+Subproject commit f14ca713a989a677f6a2b00a9c5a405df6204d1d
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97347] updating

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97347

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
  Component|BASIC   |Installation

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 45789] automatic row height in reports

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45789

--- Comment #48 from kerem  ---
I sent following new patch for this bug;

https://gerrit.libreoffice.org/#/c/21761/1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 45789] automatic row height in reports

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=45789

--- Comment #48 from kerem  ---
I sent following new patch for this bug;

https://gerrit.libreoffice.org/#/c/21761/1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97260] UI: gtk3 keyboard shortcuts not working in all dialog boxes

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97260

--- Comment #11 from Simon Long  ---
I've also just checked running LO with the GTK plugin disabled (by setting
environment variable SAL_USE_VCLPLUGIN to "gen", and this re-enables the use of
shortcut keys on dialogs without a modifier key.

So as far as I can see, behaviour of dialog shortcuts is now correct for both
non-GTK (no modifier required) and GTK (modified needed) operation of LO.

As my comment above - GTK requires a modifier key for shortcuts, both in
dialogs and menus - this is by design and not a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94199] PDF Export Mangles Unicode Char U+1D546

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=94199

--- Comment #5 from Bob Smith  ---
Excellent! Many thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97319] Unicode SEP codepoints no longer rendered

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97319

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 82577] get rid of prex.h / postx.h wrapper headers

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82577

Jorenz Paragas  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |j.paragas@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 82577] get rid of prex.h / postx.h wrapper headers

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82577

Jorenz Paragas  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |j.paragas@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] help.git: source/text

2016-01-24 Thread Stanislav Horacek

 source/text/shared/00/00040500.xhp |2 +-
 source/text/swriter/guide/text_capital.xhp |6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 5ca73073d54e8594e36e0390eb763e4246ac7faa
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:15:33 2016 +0100

adjust menu navigation to the Change Case command

Change-Id: Ia41251f96afac87e23f141d69be032c4d46c6853
Reviewed-on: https://gerrit.libreoffice.org/21749
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/source/text/shared/00/00040500.xhp 
b/source/text/shared/00/00040500.xhp
index c545d22..9528d29 100644
--- a/source/text/shared/00/00040500.xhp
+++ b/source/text/shared/00/00040500.xhp
@@ -325,7 +325,7 @@
 
 
 
-Choose 
Format - Change Case 
+Choose 
Format - Text - Change Case
 Open context 
menu (text) - choose Change Case 
 
 
diff --git a/source/text/swriter/guide/text_capital.xhp 
b/source/text/swriter/guide/text_capital.xhp
index 757e3bb..0dcc06f 100644
--- a/source/text/swriter/guide/text_capital.xhp
+++ b/source/text/swriter/guide/text_capital.xhp
@@ -39,7 +39,7 @@
 Changing the Case of Text
 
   You can change the case of text, format text with small capitals, or 
capitalize the first letter of each word in a selection.
-  When you apply a formatting to your text by Format - 
Character, the text stays the same, it is only displayed in another way. 
On the other hand, when you choose Format - Change Case, the text 
is permanently changed.
+  When you apply 
formatting to your text by Format - Character, the text stays the 
same, it is only displayed in another way. On the other hand, when you choose 
Format - Text - Change Case, the text is permanently 
changed.
   To Capitalize Text
   
  
@@ -47,7 +47,7 @@
  
  
 Do one of the following:
-Choose Format - Change Case - 
Uppercase.
+Choose Format - Text - Change Case - 
Uppercase.
 Choose Format - 
Character, click the Font Effects tab, then select the type of 
capitalization in the Effects box. "Capitals" capitalizes all letters. "Title" 
capitalizes the first letter of each word. "Small capitals" capitalizes all 
letters, but in a reduced font size.
  
   
@@ -59,7 +59,7 @@
  
  
 Do one of the following:
-Choose Format - Change Case - 
Lowercase.
+Choose Format - Text - Change Case - 
Lowercase.
 Choose Format - 
Character, click the Font Effects tab, then select "Lowercase" in the 
Effects box.
  
   
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-01-24 Thread Stanislav Horacek

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9db004bc47a3bde410b369cbdee8e8ae02a08462
Author: Stanislav Horacek 
Date:   Sun Jan 24 19:15:33 2016 +0100

Updated core
Project: help  5ca73073d54e8594e36e0390eb763e4246ac7faa

adjust menu navigation to the Change Case command

Change-Id: Ia41251f96afac87e23f141d69be032c4d46c6853
Reviewed-on: https://gerrit.libreoffice.org/21749
Reviewed-by: Adolfo Jayme Barrientos 
Tested-by: Adolfo Jayme Barrientos 

diff --git a/helpcontent2 b/helpcontent2
index f14ca71..5ca7307 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit f14ca713a989a677f6a2b00a9c5a405df6204d1d
+Subproject commit 5ca73073d54e8594e36e0390eb763e4246ac7faa
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 97191] Entry of time in format HH:MM:SS is corrupt when entering some values in Writer and Calc

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97191

--- Comment #9 from V Stuart Foote  ---
@László, * 

Any comment on feasibility/need to change the EMOJI delimiter from a single ":"
to a double "::" and avoiding this conflict with date/time formats?  

Would changing the input to require two extra characters detract from using
EMOJI feature? IMHO seems reasonable adjustment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp loolwsd/Util.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLBroker.cpp |  150 -
 loolwsd/Util.cpp   |5 -
 2 files changed, 76 insertions(+), 79 deletions(-)

New commits:
commit ef2ec0b2e2197d64dc563dcaa856ec60eb39e1dc
Author: Ashod Nakashian 
Date:   Fri Jan 22 09:49:05 2016 -0500

loolwsd: fixes to broker threading and communication

Broker cache clean up is now done only during searching
as there we loop over processes and request status
from each child.

Internal helpers simplified and termination is done
in a single removeChild helper.

Change-Id: I31f7df5429f0737d352842d5c0f6a02b91b8078f
Reviewed-on: https://gerrit.libreoffice.org/21751
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 62ae29e..7647dcc 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -87,6 +87,14 @@ namespace
 return (it != _childProcesses.end() ? it->second : -1);
 }
 
+void requestAbnormalTermination(const Process::PID aPID)
+{
+if (kill(aPID, SIGTERM) != 0 && kill(aPID, 0) != 0)
+{
+Log::info("Cannot terminate lokit [" + std::to_string(aPID) + 
"].");
+}
+}
+
 /// Safely removes a child process and
 /// invalidates the URL cache.
 void removeChild(const Process::PID pid)
@@ -96,6 +104,7 @@ namespace
 if (it != _childProcesses.end())
 {
 // Close the write pipe.
+requestAbnormalTermination(pid);
 close(it->second);
 _childProcesses.erase(it);
 _cacheURL.clear();
@@ -178,14 +187,6 @@ namespace
 if (nftw(source.c_str(), linkOrCopyFunction, 10, FTW_DEPTH) == -1)
 Log::error("linkOrCopy: nftw() failed for '" + source + "'");
 }
-
-void requestAbnormalTermination(const Process::PID aPID)
-{
-if (kill(aPID, SIGTERM) != 0)
-{
-Log::info("Cannot terminate lokit [" + std::to_string(aPID) + "]");
-}
-}
 }
 
 class PipeRunnable: public Runnable
@@ -238,21 +239,27 @@ public:
 }
 catch (const std::exception& exc)
 {
-Log::error(std::string("Exception: ") + exc.what());
+Log::error() << "Exception while reading from pipe ["
+ << nPipeReader << "]: " << exc.what() << Log::end;
 return -1;
 }
 
 return nBytes;
 }
 
-bool isOKResponse(int nPID)
+bool createThread(const Process::PID nPID, const std::string& aTID, const 
std::string& aURL)
 {
+const std::string aMessage = "thread " + aTID + " " + aURL + "\r\n";
+if (Util::writeFIFO(getChildPipe(nPID), aMessage) < 0)
+{
+Log::error("Error sending thread message to child [" + 
std::to_string(nPID) + "].");
+return false;
+}
+
 std::string aResponse;
 if (getResponseLine(readerChild, aResponse) < 0)
 {
-Log::error("Error reading child response: " + std::to_string(nPID) 
+ ". Clearing cache.");
-requestAbnormalTermination(nPID);
-_cacheURL.clear();
+Log::error("Error reading response to thread message from child [" 
+ std::to_string(nPID) + "].");
 return false;
 }
 
@@ -260,51 +267,40 @@ public:
 return (tokens.count() == 2 && tokens[1] == "ok");
 }
 
-ssize_t sendMessage(int nPipeWriter, const std::string& aMessage)
-{
-const ssize_t nBytes = Util::writeFIFO(nPipeWriter, aMessage);
-if ( nBytes < 0 )
-Log::error("Error writting to child pipe.");
-
-return nBytes;
-}
-
-ssize_t createThread(const Process::PID nPID, const std::string& aTID, 
const std::string& aURL)
-{
-const std::string aMessage = "thread " + aTID + " " + aURL + "\r\n";
-return sendMessage(getChildPipe(nPID), aMessage);
-}
-
 void verifyChilds()
 {
 std::lock_guard lock(forkMutex);
 
+// Sanitize cache.
 Log::trace("Verifying Childs.");
-std::string aMessage;
-bool bError = false;
-
-// sanity cache
 for (auto it = _cacheURL.cbegin(); it != _cacheURL.cend(); )
 {
-aMessage = "search " + it->first + "\r\n";
-if (sendMessage(getChildPipe(it->second), aMessage) < 0)
+const auto aMessage = "search " + it->first + "\r\n";
+if (Util::writeFIFO(getChildPipe(it->second), aMessage) < 0)
+{
+Log::error("Error sending search message to child [" + 
std::to_string(it->second) + "]. Clearing cache.");
+_cacheURL.clear();
+break;
+}
+
+std::string aResponse;
+if (getResponseLine(readerChild, aResponse) < 0)
 {
-bError =

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/LOOLBroker.cpp loolwsd/LOOLKit.cpp loolwsd/LOOLSession.cpp loolwsd/LOOLWSD.cpp loolwsd/MasterProcessSession.cpp loolwsd/QueueH

2016-01-24 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp  |2 +-
 loolwsd/LOOLBroker.cpp   |2 +-
 loolwsd/LOOLKit.cpp  |4 ++--
 loolwsd/LOOLSession.cpp  |4 ++--
 loolwsd/LOOLWSD.cpp  |2 +-
 loolwsd/MasterProcessSession.cpp |3 ++-
 loolwsd/QueueHandler.hpp |2 +-
 7 files changed, 10 insertions(+), 9 deletions(-)

New commits:
commit 55f2105f007e99edfd39dd4bd3c75bf6b5f5b36a
Author: Ashod Nakashian 
Date:   Sat Jan 23 17:32:09 2016 -0500

loolwsd: logging improvements

Change-Id: I77844a2b549c1f497c2d44f054169bf11d9227d8
Reviewed-on: https://gerrit.libreoffice.org/21752
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 54a689f..5edc7b5 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -71,7 +71,7 @@ void ChildProcessSession::disconnect(const std::string& 
reason)
 {
 if (!isDisconnected())
 {
-std::unique_lock lock(Mutex);
+std::unique_lock lock(Mutex);
 
 if (_multiView)
 _loKitDocument->pClass->setView(_loKitDocument, _viewId);
diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 7647dcc..ae2a5a7 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -471,7 +471,7 @@ public:
 {
 pStart++;
 
-Log::trace("Recv: " + aMessage);
+Log::trace("BrokerFromMaster: " + aMessage);
 const auto duration = (std::chrono::steady_clock::now() - 
lastMaintenanceTime);
 if (duration >= std::chrono::seconds(10))
 {
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 5fac3eb..67966ef 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -386,7 +386,7 @@ public:
 std::string firstLine = getFirstLine(buffer, n);
 if (firstLine == "eof")
 {
-Log::info("Recieved EOF. Finishing.");
+Log::info("Received EOF. Finishing.");
 break;
 }
 
@@ -905,7 +905,7 @@ void lokit_main(const std::string , const 
std::string& jailId, const s
 aResponse = "bad \r\n";
 }
 
-Log::trace("Send: " + aResponse);
+Log::trace("KitToBroker: " + aResponse);
 Util::writeFIFO(writerBroker, aResponse);
 aMessage.clear();
 }
diff --git a/loolwsd/LOOLSession.cpp b/loolwsd/LOOLSession.cpp
index 92d8f85..821835d 100644
--- a/loolwsd/LOOLSession.cpp
+++ b/loolwsd/LOOLSession.cpp
@@ -197,10 +197,10 @@ bool LOOLSession::handleInput(const char *buffer, int 
length)
 {
 assert(buffer != nullptr);
 
-Log::trace(getName() + " Recv: " + getAbbreviatedMessage(buffer, length));
-
 try
 {
+Log::trace(getName() + " Recv: " + getAbbreviatedMessage(buffer, 
length));
+
 return _handleInput(buffer, length);
 }
 catch (const Exception& exc)
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index edfcb7d..91da2f9 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -236,7 +236,7 @@ void SocketProcessor(std::shared_ptr ws,
 const std::string firstLine = getFirstLine(buffer, n);
 if (firstLine == "eof")
 {
-Log::info("Recieved EOF. Finishing.");
+Log::info("Received EOF. Finishing.");
 break;
 }
 
diff --git a/loolwsd/MasterProcessSession.cpp b/loolwsd/MasterProcessSession.cpp
index efb07b8..4d62d9b 100644
--- a/loolwsd/MasterProcessSession.cpp
+++ b/loolwsd/MasterProcessSession.cpp
@@ -435,7 +435,7 @@ bool MasterProcessSession::loadDocument(const char* 
/*buffer*/, int /*length*/,
 
 // request new URL session
 const std::string aMessage = "request " + getId() + " " + _docURL + 
"\r\n";
-Log::debug("Sending to Broker: " + aMessage);
+Log::trace("MasterToBroker: " + aMessage);
 Util::writeFIFO(LOOLWSD::BrokerWritePipe, aMessage);
 }
 catch (const Poco::SyntaxException&)
@@ -748,6 +748,7 @@ void MasterProcessSession::dispatchChild()
 Log::info() << "Retrying child permission... " << nRequest << 
Log::end;
 // request again new URL session
 const std::string aMessage = "request " + getId() + " " + _docURL 
+ "\r\n";
+Log::trace("MasterToBroker: " + aMessage);
 Util::writeFIFO(LOOLWSD::BrokerWritePipe, aMessage);
 }
 }
diff --git a/loolwsd/QueueHandler.hpp b/loolwsd/QueueHandler.hpp
index 7a1eb45..97c70d8 100644
--- a/loolwsd/QueueHandler.hpp
+++ b/loolwsd/QueueHandler.hpp
@@ -41,7 +41,7 @@

[Libreoffice-commits] core.git: vcl/source

2016-01-24 Thread Caolán McNamara

 vcl/source/gdi/dibtools.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 05e078fd9578a63a302fce616227f3bd1bdbea6a
Author: CaolÃ¡n McNamara 
Date:   Sun Jan 24 20:59:59 2016 +

fix build

Change-Id: I3c8874787c1828ef3d3f02684384bd5634545d18

diff --git a/vcl/source/gdi/dibtools.cxx b/vcl/source/gdi/dibtools.cxx
index cfc31e9..f9258ce 100644
--- a/vcl/source/gdi/dibtools.cxx
+++ b/vcl/source/gdi/dibtools.cxx
@@ -798,7 +798,7 @@ bool ImplReadDIBBody( SvStream& rIStm, Bitmap& rBmp, 
Bitmap* pBmpAlpha, sal_uLon
 while (nUncodedSize > nDataPos)
 {
 assert(aData.size() > nDataPos);
-const size_t nToRead((std::min)(nUncodedSize - nDataPos, 
aData.size() - nDataPos));
+const size_t nToRead(std::min(nUncodedSize - 
nDataPos, aData.size() - nDataPos));
 assert(nToRead > 0);
 assert(!aData.empty());
 const long nRead = aCodec.Read(rIStm, () + 
nDataPos, sal_uInt32(nToRead));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

2016-01-24 Thread Maxim Monastirsky

 sd/source/ui/view/drviews7.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 12f11aa2ff0fd2ec8ecccf47501b9a6b1636b4ba
Author: Maxim Monastirsky 
Date:   Sun Jan 24 22:36:46 2016 +0200

tdf#86609 sd: Fill Paste Special on initial update too

Regression of:

commit d51d59296d65e8ace8f2d898e757267d25f871b2
Date:   Tue Nov 8 08:06:05 2005 +

INTEGRATION: CWS impress73 (1.59.32); FILE MERGED

Change-Id: I1a10957d36c38d559d69224ec744dbd8d446b8c2

diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx
index 6ae5994..a4d3366 100644
--- a/sd/source/ui/view/drviews7.cxx
+++ b/sd/source/ui/view/drviews7.cxx
@@ -618,6 +618,7 @@ void DrawViewShell::GetMenuState( SfxItemSet  )
 // get initial state
 TransferableDataHelper aDataHelper( 
TransferableDataHelper::CreateFromSystemClipboard( GetActiveWindow() ) );
 mbPastePossible = ( aDataHelper.GetFormatCount() != 0 );
+mpCurrentClipboardFormats = GetSupportedClipboardFormats( 
aDataHelper );
 }
 else
 mbPastePossible = false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 84909] Meta: Enhancing Impress/Draw toolbars and context menu

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=84909
Bug 84909 depends on bug 86609, which changed state.

Bug 86609 Summary: TOOLBAR: Paste no longer has paste special drop down in 
Impress/Draw
https://bugs.documentfoundation.org/show_bug.cgi?id=86609

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp loolwsd/MasterProcessSession.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLWSD.cpp  |   89 ++-
 loolwsd/MasterProcessSession.cpp |3 +
 2 files changed, 55 insertions(+), 37 deletions(-)

New commits:
commit b85b4423b0e189d24d0374f5c0511011ee58780c
Author: Ashod Nakashian 
Date:   Sat Jan 23 19:41:01 2016 -0500

loolwsd: break the wait on save-as queue and better failure handling

Change-Id: Ifee252b3c189ee0b1287bda891b38c5abddb7440
Reviewed-on: https://gerrit.libreoffice.org/21755
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 4db32fb..138fde7 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -344,9 +344,11 @@ public:
 
 if (!(request.find("Upgrade") != request.end() && 
Poco::icompare(request["Upgrade"], "websocket") == 0))
 {
+Log::info("Post request.");
 StringTokenizer tokens(request.getURI(), "/?");
 if (tokens.count() >= 2 && tokens[1] == "convert-to")
 {
+Log::info("Conversion request.");
 std::string fromPath;
 ConvertToPartHandler handler(fromPath);
 Poco::Net::HTMLForm form(request, request.stream(), handler);
@@ -354,51 +356,61 @@ public:
 if (form.has("format"))
 format = form.get("format");
 
-if (!fromPath.empty() && !format.empty())
+bool sent = false;
+if (!fromPath.empty())
 {
-// Load the document.
-std::shared_ptr ws;
-const LOOLSession::Kind kind = LOOLSession::Kind::ToClient;
-auto session = std::make_shared(id, 
kind, ws);
-const std::string filePrefix("file://");
-std::string encodedFrom;
-URI::encode(filePrefix + fromPath, std::string(), 
encodedFrom);
-const std::string load = "load url=" + encodedFrom;
-session->handleInput(load.data(), load.size());
-
-// Convert it to the requested format.
-Path toPath(fromPath);
-toPath.setExtension(format);
-std::string toJailURL = filePrefix + JailedDocumentRoot + 
toPath.getFileName();
-std::string encodedTo;
-URI::encode(toJailURL, std::string(), encodedTo);
-std::string saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
-session->handleInput(saveas.data(), saveas.size());
-
-std::string toURL = session->getSaveAs();
-std::string resultingURL;
-URI::decode(toURL, resultingURL);
-
-// Send it back to the client.
-std::string mimeType = "application/octet-stream";
-if (resultingURL.find(filePrefix) == 0)
-resultingURL = 
resultingURL.substr(filePrefix.length());
-response.sendFile(resultingURL, mimeType);
+if (!format.empty())
+{
+// Load the document.
+std::shared_ptr ws;
+const LOOLSession::Kind kind = 
LOOLSession::Kind::ToClient;
+auto session = 
std::make_shared(id, kind, ws);
+const std::string filePrefix("file://");
+std::string encodedFrom;
+URI::encode(filePrefix + fromPath, std::string(), 
encodedFrom);
+const std::string load = "load url=" + encodedFrom;
+session->handleInput(load.data(), load.size());
+
+// Convert it to the requested format.
+Path toPath(fromPath);
+toPath.setExtension(format);
+std::string toJailURL = filePrefix + 
JailedDocumentRoot + toPath.getFileName();
+std::string encodedTo;
+URI::encode(toJailURL, std::string(), encodedTo);
+std::string saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
+session->handleInput(saveas.data(), saveas.size());
+
+std::string toURL = session->getSaveAs();
+std::string resultingURL;
+URI::decode(toURL, resultingURL);
+
+// Send it back to the client.
+if (resultingURL.find(filePrefix) == 0)
+resultingURL = 
resultingURL.substr(filePrefix.length());
+if (!resultingURL.empty())
+{
+const

[Libreoffice-bugs] [Bug 56540] Draw and Impress fail to enable the paste button's arrow after starting

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=56540

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Maxim Monastirsky  ---


*** This bug has been marked as a duplicate of bug 86609 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLWSD.cpp |  337 +++-
 1 file changed, 175 insertions(+), 162 deletions(-)

New commits:
commit f9fd4c917a3acb75ee86dfca29e084542a77f756
Author: Ashod Nakashian 
Date:   Sun Jan 24 14:48:09 2016 -0500

loolwsd: refactored HTTP Request Handler

Change-Id: I84685910afa04664639ae674fd66ff888962387e
Reviewed-on: https://gerrit.libreoffice.org/21757
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 138fde7..bbb4c84 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -329,206 +329,219 @@ void SocketProcessor(std::shared_ptr ws,
 /// Handle a public connection from a client.
 class ClientRequestHandler: public HTTPRequestHandler
 {
-public:
+private:
 
-void handleRequest(HTTPServerRequest& request, HTTPServerResponse& 
response) override
+void handlePostRequest(HTTPServerRequest& request, HTTPServerResponse& 
response, const std::string& id)
 {
-const auto id = LOOLWSD::GenSessionId();
-const std::string thread_name = "client_ws_" + id;
-
-#ifdef __linux
-if (prctl(PR_SET_NAME, reinterpret_cast(thread_name.c_str()), 0, 0, 0) != 0)
-Log::error("Cannot set thread name to " + thread_name + ".");
-#endif
-Log::debug("Thread [" + thread_name + "] started.");
-
-if (!(request.find("Upgrade") != request.end() && 
Poco::icompare(request["Upgrade"], "websocket") == 0))
+Log::info("Post request.");
+StringTokenizer tokens(request.getURI(), "/?");
+if (tokens.count() >= 2 && tokens[1] == "convert-to")
 {
-Log::info("Post request.");
-StringTokenizer tokens(request.getURI(), "/?");
-if (tokens.count() >= 2 && tokens[1] == "convert-to")
+Log::info("Conversion request.");
+std::string fromPath;
+ConvertToPartHandler handler(fromPath);
+Poco::Net::HTMLForm form(request, request.stream(), handler);
+std::string format;
+if (form.has("format"))
+format = form.get("format");
+
+bool sent = false;
+if (!fromPath.empty())
 {
-Log::info("Conversion request.");
-std::string fromPath;
-ConvertToPartHandler handler(fromPath);
-Poco::Net::HTMLForm form(request, request.stream(), handler);
-std::string format;
-if (form.has("format"))
-format = form.get("format");
-
-bool sent = false;
-if (!fromPath.empty())
+if (!format.empty())
 {
-if (!format.empty())
-{
-// Load the document.
-std::shared_ptr ws;
-const LOOLSession::Kind kind = 
LOOLSession::Kind::ToClient;
-auto session = 
std::make_shared(id, kind, ws);
-const std::string filePrefix("file://");
-std::string encodedFrom;
-URI::encode(filePrefix + fromPath, std::string(), 
encodedFrom);
-const std::string load = "load url=" + encodedFrom;
-session->handleInput(load.data(), load.size());
-
-// Convert it to the requested format.
-Path toPath(fromPath);
-toPath.setExtension(format);
-std::string toJailURL = filePrefix + 
JailedDocumentRoot + toPath.getFileName();
-std::string encodedTo;
-URI::encode(toJailURL, std::string(), encodedTo);
+// Load the document.
+std::shared_ptr ws;
+const LOOLSession::Kind kind = LOOLSession::Kind::ToClient;
+auto session = std::make_shared(id, 
kind, ws);
+const std::string filePrefix("file://");
+std::string encodedFrom;
+URI::encode(filePrefix + fromPath, std::string(), 
encodedFrom);
+const std::string load = "load url=" + encodedFrom;
+session->handleInput(load.data(), load.size());
+
+// Convert it to the requested format.
+Path toPath(fromPath);
+toPath.setExtension(format);
+std::string toJailURL = filePrefix + JailedDocumentRoot + 
toPath.getFileName();
+std::string encodedTo;
+URI::encode(toJailURL, std::string(), encodedTo);
 std::string saveas = "saveas url=" + encodedTo + " 
format=" + format + " options=";
-session->handleInput(saveas.data(),

[Libreoffice-commits] online.git: loleaflet/spec

2016-01-24 Thread Ashod Nakashian

 loleaflet/spec/loadtest/LoadTestSpec.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 22e129702ecc4a5bd1c81878080df47c78989a4c
Author: Ashod Nakashian 
Date:   Sun Jan 24 14:33:18 2016 -0500

loleaflet: extended loadtest timeout to 6s

Change-Id: I6779cf37a9e320369b6dc06be2c691e9f6b99088
Reviewed-on: https://gerrit.libreoffice.org/21756
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/spec/loadtest/LoadTestSpec.js 
b/loleaflet/spec/loadtest/LoadTestSpec.js
index e4e9984..0099b63 100644
--- a/loleaflet/spec/loadtest/LoadTestSpec.js
+++ b/loleaflet/spec/loadtest/LoadTestSpec.js
@@ -59,7 +59,7 @@ describe('LoadTest', function () {
checkTimeOut = setTimeout(function () {

expect(map._docLayer._emptyTilesCount).to.eql(0);
done();
-   }, 2000);
+   }, 6000);
});
 
it('Scroll to the bottom', function (done) {
@@ -73,7 +73,7 @@ describe('LoadTest', function () {
checkTimeOut = setTimeout(function () {

expect(map._docLayer._emptyTilesCount).to.eql(0);
done();
-   }, 2000);
+   }, 6000);
});
 
});
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp loolwsd/MasterProcessSession.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp  |   28 
 loolwsd/ChildProcessSession.hpp  |   31 +++
 loolwsd/LOOLKit.cpp  |   13 +++--
 loolwsd/MasterProcessSession.cpp |1 -
 4 files changed, 70 insertions(+), 3 deletions(-)

New commits:
commit 904bf929f19084d3b71be758bfdde89d1c55d8ac
Author: Ashod Nakashian 
Date:   Sun Jan 24 15:24:11 2016 -0500

loolwsd: throttle traffic for inactive sessions

Sessions that have been inactive for a certain duration,
currently set at 120 seconds, will not receive updates.

A new statistics class tracks the activity of every
session and blocks callback updates from reaching
inactive clients.

Change-Id: I64296488b2c0be0598b218ba89a6d02f057a5f7e
Reviewed-on: https://gerrit.libreoffice.org/21760
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 5edc7b5..e89eb82 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -90,6 +90,34 @@ bool 
ChildProcessSession::handleDisconnect(Poco::StringTokenizer& tokens)
 
 bool ChildProcessSession::_handleInput(const char *buffer, int length)
 {
+if (isInactive() && _loKitDocument != nullptr)
+{
+Log::debug("Handling message after inactivity of " + 
std::to_string(_stats.getInactivityMS()) + "ms.");
+
+// Client is getting active again.
+// Send invalidation and other sync-up messages.
+std::unique_lock lock(Mutex);
+
+if (_multiView)
+_loKitDocument->pClass->setView(_loKitDocument, _viewId);
+
+int curPart = _loKitDocument->pClass->getPart(_loKitDocument);
+sendTextFrame("curpart: part=" + std::to_string(curPart));
+if (getDocType() == "text")
+{
+curPart = 0;
+}
+
+sendTextFrame("invalidatetiles:"
+   " part=" + std::to_string(curPart) +
+   " x=0 y=0"
+   " width=" + std::to_string(INT_MAX) +
+   " height=" + std::to_string(INT_MAX));
+
+//TODO: Sync cursor.
+}
+
+_stats.updateLastActivityTime();
 const std::string firstLine = getFirstLine(buffer, length);
 StringTokenizer tokens(firstLine, " ", StringTokenizer::TOK_IGNORE_EMPTY | 
StringTokenizer::TOK_TRIM);
 
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 6d9f326..f0b47b3 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -24,6 +24,30 @@ static int ClientPortNumber = DEFAULT_CLIENT_PORT_NUMBER;
 class ChildProcessSession final : public LOOLSession
 {
 public:
+class Statistics
+{
+public:
+Statistics() :
+_lastActivityTime(std::chrono::steady_clock::now())
+{
+}
+
+void updateLastActivityTime()
+{
+_lastActivityTime = std::chrono::steady_clock::now();
+}
+
+double getInactivityMS() const
+{
+const auto duration = (std::chrono::steady_clock::now() - 
_lastActivityTime);
+return 
std::chrono::duration_cast(duration).count();
+}
+
+private:
+std::chrono::steady_clock::time_point _lastActivityTime;
+};
+
+public:
 /// Create a new ChildProcessSession
 /// ws The socket between master and kit (jailed).
 /// loKit The LOKit instance.
@@ -57,6 +81,9 @@ public:
 
 std::unique_lock getLock() { return 
std::unique_lock(Mutex); }
 
+const Statistics& getStatistics() const { return _stats; }
+bool isInactive() const { return _stats.getInactivityMS() >= 
InactivityThresholdMS; }
+
  protected:
 virtual bool loadDocument(const char *buffer, int length, 
Poco::StringTokenizer& tokens) override;
 
@@ -96,10 +123,14 @@ private:
 int _clientPart;
 std::function _onLoad;
 std::function _onUnload;
+/// Statistics and activity tracking.
+Statistics _stats;
 
 /// Synchronize _loKitDocument acess.
 /// This should be inside LoKit.
 static std::recursive_mutex Mutex;
+
+static constexpr auto InactivityThresholdMS = 120 * 1000;
 };
 
 #endif
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 67966ef..f542ec2 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -144,6 +144,16 @@ public:
 Log::trace() << "Callback [" << pSession->getViewId() << "] "
  << callbackTypeToString(nType)
  << " [" << rPayload << "]." << Log::end;
+if (pSession->isDisconnected())
+{
+Log::trace("Skipping callback on disconnected session " + 
pSession->getName());
+return;
+}
+else if (pSession->isInactive())

[Libreoffice-bugs] [Bug 97093] Backspace changes font to standard if it is not the same

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97093

birqu...@web.de changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #5 from birqu...@web.de ---
Sorry for the irritation - I searched within the "customize" window for the
keys and found, that Backspace was changed by the last update of
Dmaths-extension.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86896] FRAMEWORK: Command line help not translated

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86896

--- Comment #4 from Jean-Baptiste Faure  ---
Still not translated in master.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96860] SAVE After save as DOC file of some Writer document with illustrations in frames some illustrations are missing

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96860

--- Comment #7 from Krasimir Ivanov  ---
Hi Beluga,

Today I manage to test all this problems again.
This time I had used openSUSE Leap 42.1 with LibreOffice 4.4.7.2 from The
Document Foundation and MS Windows 8.1 with 

I have created some drawings in Draw, to use them as illustrations and save
them.
Then I have created a document in Writer and put inside some random text using
Edit - Auto text in Writer. Then I try to put inside some part from the
drawing.
I have opened the drawing file and select some images from there.
First part was some grouped images and second part I just select 2 images
without to group them.

Then I put them in the document using all available possibilities.
Then I put explanation to all inserted images to inform how they are inserted.

Then I made a PDF export to the file 'The test document Before save.pdf'. After
that I have saved the document as .doc closed it and reopen it.
Please see the document 'The test document after save.doc'

Then I open this document with Writer again.
This way I have got a mess with the illustrations - many of them have got bad
quality and many of them have got different position in the document. This way
I have got visible destroyed layout - different than the initial document
before the save operation.

Then I have done another export to PDF and so created the 'The test document
After save close and reopen again.pdf'.

I need to inform that all above operations I have made in openSUSE Linux.
Then I try to open the file I have got after the save operation in LibreOffice
5.0.3.2 in MS Windows 8.1.

The result was not much better. So I did export to PDF creating the file 'The
test document after save and open with LO5.0.3.2.pdf' in order to fix what is
visible on the screen in the LibreOffice 5.0.3.2 in MS Windows 8.1.

So my opinion is that some thing is wrong in LibreOffice when one creates
Writer documents with illustrations created by Draw.

At this stage as now I believe it will be very difficult to create reach
documents with good quality by LibreOffice Draw and Writer.

Please see the attached PDF file with my last experiments.

With best regards,

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96860] SAVE After save as DOC file of some Writer document with illustrations in frames some illustrations are missing

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96860

--- Comment #9 from Krasimir Ivanov  ---
Created attachment 122196
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122196=edit
The PDF exported from LO in Windows 8.1

The PDF exported from LO in Windows 8.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

local build slow in opening a big file

2016-01-24 Thread Yury

Hello, any chance of getting an advice on an obscure kind of problem?

I've made a local build of 5.1.0.2 on my 64-bit linux box and it's showing a
peculiar behaviour when opening a 'big' file (~150 pages, bare text with
headings three levels deep).

After the (quick completing) unpacking the interface the interface goes
blank and there's a very noticeable delay before all sidebars/toolbars/*bars
and the doc show up. Over 10 seconds on my system from the start. Very annoying!

I'm comparing this with the 'stock' 5.1.0.1 build shared on the
libreoffice.org. This build shows the framework for the *bars almost
immediately after the unpacking, and the same doc comes up like in 4 seconds.

I'm not at all competent with debugger, so I could only try strace'ing the
run -- and that big time difference occurs after the swriter module is exec'ed.

So, how could I diagnose this? I rather need this local build.

At the very least, could I know the options' set with which the 'stock'
build is configured? Thanks!

For my build, I've used

./configure \
--with-external-tar=${HOME}/c/libo/ext5 \
\
--with-krb5=no \
--with-gssapi=no \
\
--disable-gstreamer-1-0 \
--disable-gstreamer-0-10 \
\
--without-fonts \
--without-junit \
--with-system-libs=no \
\
--with-system-libxml=no \
--with-system-zlib=no \




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Setting data in Writer chart from Basic

2016-01-24 Thread Fernand Vanrie


 Jan,

please find some code who works fine for me,

maybe its locking and unlocking whor provoke the refresh or its becuase 
i change some more things after setting the data ?


 oChart.lockControllers()
  oChart.Data.setData(DataArray())
 oChart.Data.setrowDescriptions(LabelsArray())

dim columnLabelsArray(2)

 columnLabelsArray(0) = "20" & mid(sjaarmin2,len(sjaarmin2)-4,2)
columnLabelsArray(1) = "20" & mid(sjaarmin1,len(sjaarmin2)-4,2)
 columnLabelsArray(2) = "20" & mid(sjaarnu,len(sjaarmin2)-4,2)

 oChart.Data.setColumnDescriptions(columnLabelsArray())
' Title
 oChart.HasMainTitle=false
oChart.Title.string = sTitel
' Labels
 oChart.DataSourceLabelsInFirstColumn = true
 oChart.DataSourceLabelsInFirstRow= false
' Legend
 ochart.hasLegend = true
' oSheet.getCharts.getByName("CHART1").getEmbeddedObject.hasLegend 
= true


 ochart.area.fillcolor = rgb(240,240,240)
 oChart.unlockControllers()

i resently found out that using the "dispatcher" also can provocke the 
refresh of some doc ellements


document = odoc.CurrentController.Frame
dispatcher = createUnoService("com.sun.star.frame.DispatchHelper")
'here do changing the rowheigt in calc document the repositoning of 'all 
shapes in a doc

dim args1(0) as new com.sun.star.beans.PropertyValue
args1(0).Name = "RowHeight"
args1(0).Value = 500
dispatcher.executeDispatch(document , ".uno:RowHeight", "", 0, args1())


Hi,

with this code I can change the data in a Writer chart:

 set doc = thisComponent
 set ctrl = thisComponent.CurrentController
 xChart = ctrl.getModel().getEmbeddedObjects.getByName("Objekt1")
 set cDoc = xChart.getEmbeddedObject
 set cDataArray = cDoc.getDataProvider
 data = cDataArray.getData
 ' Do something with the data
 cDataArray.setData(data)

But I can't get the chart to update. The only way I see is to
double-click on the chart in the document, then it will update.

What is the right way to force an update via code?

Thank!
 Jan

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97319] Unicode SEP codepoints no longer rendered

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97319

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
Summary|All unicode SEP codepoints  |Unicode SEP codepoints no
   |no longer rendered  |longer rendered
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
For now Windows only, but can someone check Linux and OS X.

Attaching test document authored on Windows with both Symbola and Code 2001
fonts installed to a Windows 10 Pro 64-bit en-US (10586 build) system.

http://cgit.freedesktop.org/libreoffice/core/log/?id=fefd1221be844a033e409a18e05e8c6e98f6d1a7=range=6b65a0e83c4798f117be61af91dbaebdc85e94b7..c81eddbb20c84280aa64c712e34c829380b24527

Unfortunately several pieces in movement in this range... sorry.

Michael S.'s work on i18n Unicode support for StarMath
Tor's work reintroducing SimpleWinLayout (bug 96420)
Chris' work on FontFamily

Also, somewhere in the mix of this and handling fallback font we have lost
ability to handle the SEP and higher plane codepages in the Special Symbol
dialog.

=-biset results-=
OK
22e5170af74c635cf55d089f97946b6dc86f82ad - 2016-01-06
813a319fe836d1ed1c967928bc044643d0b4c07d - 2016-01-12
c71b5b4d2ec76c0a204f9515dece1e0e0689ce3c - 2016-01-13
70ea14baf7d43c00f73807bce13629ca25320558 - 2016-01-14
f0841c6c86c8c8403eb1d78a1bd43a8adac75e3a - 2016-01-15
0174562fa9e49bf989a571c6ccd51e558109b561 - 2016-01-16
49b5eed56c470975927bb7b0328337ab8a76a910 - 2016-01-17
000df1832b54ba8f48c7f1c4c1cd92b70f6402da - 2016-01-18
447c313586e9b36acff393feae15f5e1b63861ae - 2016-01-19
029ce852c2f67e06d60e0ce50fff936c8e2ce9f4 - 2016-01-20
6b65a0e83c4798f117be61af91dbaebdc85e94b7 - 2016-01-21

Bad
c81eddbb20c84280aa64c712e34c829380b24527 - 2016-01-22
3fc292f7b32f30b98dad208eb03e086b927d38a2 - 2016-01-23
49b5eed56c470975927bb7b0328337ab8a76a910 - 2016-01-24

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97319] Unicode SEP codepoints no longer rendered

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97319

--- Comment #2 from V Stuart Foote  ---
Created attachment 122194
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122194=edit
odt with multiple fonts and both BMP and SEP codepage use

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82577] get rid of prex.h / postx.h wrapper headers

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82577

--- Comment #17 from Jorenz Paragas  ---
I'm going to work on this task.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Bug 82577] get rid of prex.h / postx.h wrapper headers

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=82577

--- Comment #17 from Jorenz Paragas  ---
I'm going to work on this task.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97319] Unicode SEP codepoints no longer rendered

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97319

V Stuart Foote  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=71
   ||603

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLKit.cpp |   30 --
 1 file changed, 20 insertions(+), 10 deletions(-)

New commits:
commit 4dc9fa7eb7563ff1d2013ad6d3bd22d3512f0cf9
Author: Ashod Nakashian 
Date:   Fri Jan 22 09:27:03 2016 -0500

loolwsd: prevent deadlock when purging sessions

Change-Id: I293e28674ed721741fa0afc57b37a636833d2e0e
Reviewed-on: https://gerrit.libreoffice.org/21750
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index e474efa..5fac3eb 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -581,21 +581,31 @@ public:
 /// the remaining number of clients.
 size_t purgeSessions()
 {
-std::unique_lock lock(_mutex);
-
-for (auto it =_connections.cbegin(); it != _connections.cend(); )
+std::vector deadSessions;
 {
-if (!it->second->isRunning())
-{
-onUnload(it->second->getSession()->getId());
-it = _connections.erase(it);
-}
-else
+std::unique_lock lock(_mutex);
+
+for (auto it =_connections.cbegin(); it != _connections.cend(); )
 {
-++it;
+if (!it->second->isRunning())
+{
+deadSessions.push_back(it->second->getSession());
+it = _connections.erase(it);
+}
+else
+{
+++it;
+}
 }
 }
 
+// Don't destroy sessions while holding our lock.
+// We may deadlock if a session is waiting on us
+// during callback initiated while handling a command
+// and the dtor tries to take its lock (which is taken).
+deadSessions.clear();
+
+std::unique_lock lock(_mutex);
 return _connections.size();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/Common.hpp loolwsd/LOOLWSD.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/Common.hpp  |2 +-
 loolwsd/LOOLWSD.cpp |   13 +
 2 files changed, 10 insertions(+), 5 deletions(-)

New commits:
commit 9593ec5720704c910d3e2a733d092625f23fed68
Author: Ashod Nakashian 
Date:   Sat Jan 23 17:35:16 2016 -0500

loolwsd: improved polling and pong with client

Change-Id: I17c4f7685d23b6e4c84a7f8b34fcb7dbcaf959f9
Reviewed-on: https://gerrit.libreoffice.org/21754
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Common.hpp b/loolwsd/Common.hpp
index ff98222..f85f76d 100644
--- a/loolwsd/Common.hpp
+++ b/loolwsd/Common.hpp
@@ -18,7 +18,7 @@ constexpr int MASTER_PORT_NUMBER = 9981;
 constexpr int INTERVAL_PROBES = 10;
 constexpr int MAINTENANCE_INTERVAL = 1;
 constexpr int CHILD_TIMEOUT_SECS = 10;
-constexpr int POLL_TIMEOUT_MS = 500;
+constexpr int POLL_TIMEOUT_MS = 1000;
 
 /// Pipe and Socket read buffer size.
 /// Should be large enough for ethernet packets
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 91da2f9..4db32fb 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -200,7 +200,7 @@ void SocketProcessor(std::shared_ptr ws,
 {
 Log::info("Starting Socket Processor.");
 
-const Poco::Timespan waitTime(POLL_TIMEOUT_MS);
+const Poco::Timespan waitTime(POLL_TIMEOUT_MS * 1000);
 try
 {
 int flags = 0;
@@ -217,17 +217,22 @@ void SocketProcessor(std::shared_ptr ws,
 if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PING)
 {
 // Echo back the ping payload as pong.
-ws->sendFrame(buffer, n, WebSocket::FRAME_OP_PONG);
-continue;
+// Technically, we should send back a PONG control frame.
+// However Firefox (probably) or Node.js (possibly) doesn't
+// like that and closes the socket when we do.
+// Echoing the payload as a normal frame works with 
Firefox.
+ws->sendFrame(buffer, n /*, WebSocket::FRAME_OP_PONG*/);
 }
 else if ((flags & WebSocket::FRAME_OP_BITMASK) == 
WebSocket::FRAME_OP_PONG)
 {
 // In case we do send pings in the future.
-continue;
 }
 else if (n <= 0)
 {
 // Connection closed.
+Log::warn() << "Received " << n
+<< " bytes. Connection closed. Flags: "
+<< std::hex << flags << Log::end;
 break;
 }
 else
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLProtocol.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLProtocol.cpp |   11 +--
 1 file changed, 9 insertions(+), 2 deletions(-)

New commits:
commit 2bb2e2aec1291468e3e03cff963fffbaad4b0241
Author: Ashod Nakashian 
Date:   Sat Jan 23 17:33:19 2016 -0500

loolwsd: protect against empty messages

Change-Id: Ic60c1abf85268c9ad629bc1f981e53688fc6267a
Reviewed-on: https://gerrit.libreoffice.org/21753
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLProtocol.cpp b/loolwsd/LOOLProtocol.cpp
index 20c5d8e..993ef61 100644
--- a/loolwsd/LOOLProtocol.cpp
+++ b/loolwsd/LOOLProtocol.cpp
@@ -152,6 +152,9 @@ namespace LOOLProtocol
 
 std::string getFirstLine(const char *message, int length)
 {
+if (message == nullptr || length <= 0)
+return "";
+
 const char *endOfLine = static_cast(std::memchr(message, 
'\n', length));
 if (endOfLine == nullptr)
 return std::string(message, length);
@@ -161,8 +164,12 @@ namespace LOOLProtocol
 
 std::string getAbbreviatedMessage(const char *message, int length)
 {
-std::string result = "'" + getFirstLine(message, length) + "'";
-if (result.size() < static_cast(length))
+if (message == nullptr || length <= 0)
+return "";
+
+const auto firstLine = getFirstLine(message, length);
+std::string result = "'" + firstLine + "'";
+if (firstLine.size() < static_cast(length))
 result += "...";
 return result;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/LOOLBroker.cpp |   19 +--
 1 file changed, 13 insertions(+), 6 deletions(-)

New commits:
commit 75ede04cd7fd88e1113625f6497c00e485fa28dc
Author: Ashod Nakashian 
Date:   Sun Jan 24 14:49:45 2016 -0500

loolwsd: improved child forking

Change-Id: Ic05b412bb9c467659c24cba12f385ed9c0c67b84
Reviewed-on: https://gerrit.libreoffice.org/21758
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index ae2a5a7..77e8708 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -318,7 +318,7 @@ public:
 if ( nBytes < 0 )
 {
 Log::error("Error sending search message to child pipe: " + 
std::to_string(it->first) + ". Terminating.");
-removeChild(it->second);
+removeChild(it->first);
 it = _childProcesses.cbegin();
 continue;
 }
@@ -329,7 +329,7 @@ public:
 if ( nBytes < 0 )
 {
 Log::error("Error reading response to search message from 
child [" + std::to_string(it->first) + "]. Terminating.");
-removeChild(it->second);
+removeChild(it->first);
 it = _childProcesses.cbegin();
 continue;
 }
@@ -591,7 +591,7 @@ static int createLibreOfficeKit(const bool sharePages,
 
 Log::info() << "Adding Kit #" << childCounter << ", PID: " << child << 
Log::end;
 _childProcesses[child] = nFIFOWriter;
-++forkCounter;
+--forkCounter;
 return child;
 }
 
@@ -847,17 +847,24 @@ int main(int argc, char** argv)
 {
 std::lock_guard lock(forkMutex);
 
+pipeHandler.verifyChilds();
+
 // Figure out how many children we need.
 const signed total = _childProcesses.size();
 const signed used = _cacheURL.size();
 const signed extra = total - used;
-if (extra < numPreSpawnedChildren)
+signed spawn = std::min(static_cast(forkCounter), 
numPreSpawnedChildren);
+Log::debug() << "Spawning " << spawn << " children. Current Total: 
" << total
+ << ", used: " << used << ", extra: " << extra << 
Log::end;
+do
 {
 if (createLibreOfficeKit(sharePages, loSubPath, jailId) < 0)
 Log::error("Error: fork failed.");
 }
-else
-forkCounter = 0;
+while (--spawn > 0);
+
+// We've done our best. If need more, retrying will bump the 
counter.
+forkCounter = 0;
 }
 
 int status;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

2016-01-24 Thread Ashod Nakashian

 loolwsd/test/httpwstest.cpp |   33 -
 1 file changed, 24 insertions(+), 9 deletions(-)

New commits:
commit 11e8a9bb4f9413bd50859b555d2f20fd182fc448
Author: Ashod Nakashian 
Date:   Sun Jan 24 14:58:08 2016 -0500

loolwsd: test improvements

Change-Id: Ieeef1019063636cef171cc360f523810f6f989d2
Reviewed-on: https://gerrit.libreoffice.org/21759
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 79dedf9..4228d53 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -23,7 +23,7 @@
 /// Tests the HTTP WebSocket API of loolwsd. The server has to be started 
manually before running this test.
 class HTTPWSTest : public CPPUNIT_NS::TestFixture
 {
-Poco::URI _uri;
+const Poco::URI _uri;
 Poco::Net::HTTPClientSession _session;
 Poco::Net::HTTPRequest _request;
 Poco::Net::HTTPResponse _response;
@@ -39,15 +39,28 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testLargePaste();
 void testRenderingOptions();
 
+static
 void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& 
string);
+
 public:
 HTTPWSTest()
 : _uri("http://127.0.0.1:; + std::to_string(ClientPortNumber)),
   _session(_uri.getHost(), _uri.getPort()),
-  _request(Poco::Net::HTTPRequest::HTTP_POST, "/ws"),
+  _request(Poco::Net::HTTPRequest::HTTP_GET, "/ws"),
   _socket(_session, _request, _response)
 {
 }
+
+void setUp()
+{
+_socket.shutdown();
+_socket = Poco::Net::WebSocket(_session, _request, _response);
+}
+
+void tearDown()
+{
+_socket.shutdown();
+}
 };
 
 void HTTPWSTest::testPaste()
@@ -70,7 +83,7 @@ void HTTPWSTest::testPaste()
 int n;
 do
 {
-char buffer[10];
+char buffer[READ_BUFFER_SIZE];
 n = _socket.receiveFrame(buffer, sizeof(buffer), flags);
 if (n > 0)
 {
@@ -111,9 +124,9 @@ void HTTPWSTest::testLargePaste()
 int n;
 do
 {
-char buffer[10];
+char buffer[READ_BUFFER_SIZE];
 n = _socket.receiveFrame(buffer, sizeof(buffer), flags);
-if (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE)
+if (n > 0)
 {
 std::string line = LOOLProtocol::getFirstLine(buffer, n);
 std::string prefix = "textselectioncontent: ";
@@ -122,6 +135,7 @@ void HTTPWSTest::testLargePaste()
 }
 }
 while (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE);
+sendTextFrame(_socket, "disconnect");
 _socket.shutdown();
 }
 
@@ -139,7 +153,7 @@ void HTTPWSTest::testRenderingOptions()
 int n;
 do
 {
-char buffer[10];
+char buffer[READ_BUFFER_SIZE];
 n = _socket.receiveFrame(buffer, sizeof(buffer), flags);
 if (n > 0)
 {
@@ -158,10 +172,11 @@ void HTTPWSTest::testRenderingOptions()
 // Expected format is something like 'type=text parts=2 current=0 
width=12808 height=1142'.
 Poco::StringTokenizer tokens(status, " ", 
Poco::StringTokenizer::TOK_IGNORE_EMPTY | Poco::StringTokenizer::TOK_TRIM);
 CPPUNIT_ASSERT_EQUAL(static_cast(5), tokens.count());
-std::string token = tokens[4];
-std::string prefix = "height=";
+
+const std::string token = tokens[4];
+const std::string prefix = "height=";
 CPPUNIT_ASSERT_EQUAL(static_cast(0), token.find(prefix));
-int height = std::stoi(token.substr(prefix.size()));
+const int height = std::stoi(token.substr(prefix.size()));
 // HideWhitespace was ignored, this was 32532, should be around 16706.
 CPPUNIT_ASSERT(height < 2);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Getting a click on a reference mark

2016-01-24 Thread X Roemer


Hi,

does anyone know if it's possible to catch a click on a reference mark?
Can a listener be attached to a textfield to receive a onclick message 
somehow?


Thanks for help,
Xaver
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97260] UI: gtk3 keyboard shortcuts not working in all dialog boxes

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97260

--- Comment #10 from Simon Long  ---
Standard behaviour in GTK applications is that buttons in dialogs with
accelerators defined only operate when the shortcut key is pressed along with a
modifier; they do not operate when the shortcut key is pressed on its own.
LibreOffice may have worked otherwise in the past, but the requirement to press
a modifier key to access an accelerator for a dialog button is standard GTK
behaviour, not an error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97343] Image resizing

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=97343

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #1 from MM  ---
Think it's a duplicate of bug 95587 
Should then be fixed in a next release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96860] SAVE After save as DOC file of some Writer document with illustrations in frames some illustrations are missing

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96860

--- Comment #8 from Krasimir Ivanov  ---
Created attachment 122195
  --> https://bugs.documentfoundation.org/attachment.cgi?id=122195=edit
Some more examples

Some more examples about this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 86567] TOOLBAR: Split/group button for conditional formatting

2016-01-24 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=86567

Maxim Monastirsky  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |momonas...@gmail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 2 commits - framework/source sc/inc

2016-01-24 Thread Maxim Monastirsky

 framework/source/uielement/menubarmanager.cxx |8 
 sc/inc/sc.hrc |2 --
 2 files changed, 4 insertions(+), 6 deletions(-)

New commits:
commit c37e66fac7d23989c1fb9c46372e2efe96036514
Author: Maxim Monastirsky 
Date:   Mon Jan 25 00:56:09 2016 +0200

Drop unused defines

Change-Id: I99b505fe59adc095bb55fc983dade23150fc5d75

diff --git a/sc/inc/sc.hrc b/sc/inc/sc.hrc
index 9dc55b9..dc049a5 100644
--- a/sc/inc/sc.hrc
+++ b/sc/inc/sc.hrc
@@ -1037,8 +1037,6 @@
 #define RID_SCPAGE_CALC (SC_DIALOGS_START + 56)
 #define RID_SCDLG_NAVIGATOR (SC_DIALOGS_START + 57)
 
-#define RID_POPUP_ROWHEADER (SC_DIALOGS_START + 60)
-#define RID_POPUP_COLHEADER (SC_DIALOGS_START + 61)
 #define RID_SCDLG_HFEDIT_SHDR   (SC_DIALOGS_START + 62)
 #define RID_SCDLG_HFEDIT_SFTR   (SC_DIALOGS_START + 63)
 #define RID_SCDLG_HFEDIT_LEFTHEADER (SC_DIALOGS_START + 64)
commit 954d7adb391e179e06d941eb31f8dcfe0bc4b298
Author: Maxim Monastirsky 
Date:   Mon Jan 25 00:55:23 2016 +0200

MenuBarManager: Pass the module identifier to the factory

Change-Id: I681054715e943791bddb4b33f01c903c78b717d7

diff --git a/framework/source/uielement/menubarmanager.cxx 
b/framework/source/uielement/menubarmanager.cxx
index f9e94ba..a1ac05c 100644
--- a/framework/source/uielement/menubarmanager.cxx
+++ b/framework/source/uielement/menubarmanager.cxx
@@ -870,7 +870,7 @@ IMPL_LINK_TYPED( MenuBarManager, Activate, Menu *, pMenu, 
bool )
 
 bool bPopupMenu( false );
 if ( !pMenuItemHandler->xPopupMenuController.is() 
&&
- m_xPopupMenuControllerFactory->hasController( 
aItemCommand, OUString() ))
+ m_xPopupMenuControllerFactory->hasController( 
aItemCommand, m_aModuleIdentifier ) )
 {
 bPopupMenu = CreatePopupMenuController( 
pMenuItemHandler );
 }
@@ -1220,7 +1220,7 @@ void MenuBarManager::FillMenuManager( Menu* pMenu, const 
Reference< XFrame >& rF
 
 if ( m_xPopupMenuControllerFactory.is() &&
  pPopup->GetItemCount() == 0 &&
- m_xPopupMenuControllerFactory->hasController( aItemCommand, 
OUString() )
+ m_xPopupMenuControllerFactory->hasController( aItemCommand, 
m_aModuleIdentifier )
   )
 {
 // Check if we have to create a popup menu for a uno based 
popup menu controller.
@@ -1352,7 +1352,7 @@ void MenuBarManager::FillMenuManager( Menu* pMenu, const 
Reference< XFrame >& rF
 pItemHandler->aMenuItemURL = aItemCommand;
 
 if ( m_xPopupMenuControllerFactory.is() &&
- m_xPopupMenuControllerFactory->hasController( aItemCommand, 
OUString() ))
+ m_xPopupMenuControllerFactory->hasController( aItemCommand, 
m_aModuleIdentifier ) )
 {
 // Check if we have to create a popup menu for a uno based 
popup menu controller.
 // We have to set an empty popup menu into our menu structure 
so the controller also
@@ -1959,7 +1959,7 @@ void MenuBarManager::Init(const Reference< XFrame >& 
rFrame,Menu* pAddonMenu,boo
 // We have to set an empty popup menu into our menu 
structure so the controller also
 // works with inplace OLE.
 if ( m_xPopupMenuControllerFactory.is() &&
-m_xPopupMenuControllerFactory->hasController( 
aItemCommand, OUString() ))
+ m_xPopupMenuControllerFactory->hasController( 
aItemCommand, m_aModuleIdentifier ) )
 {
 VCLXPopupMenu* pVCLXPopupMenu = new VCLXPopupMenu;
 PopupMenu* pCtlPopupMenu = static_cast(pVCLXPopupMenu->GetMenu());
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

2016-01-24 Thread Ashod Nakashian

 loolwsd/ChildProcessSession.cpp |  276 +++-
 loolwsd/ChildProcessSession.hpp |   11 +
 loolwsd/LOOLKit.cpp |  275 ---
 3 files changed, 287 insertions(+), 275 deletions(-)

New commits:
commit 65e06c1db7d494f23e9219295b4c6adf8012dbff
Author: Ashod Nakashian 
Date:   Sun Jan 24 18:25:02 2016 -0500

loolwsd: per ChildProcessSession callback queue and thread

By giving dedicated queue to each session we eliminate
the bottleneck that a slow client will introduce
on every other session on the same document.

Change-Id: I715b80a8cd7bbef1268dc472d0b32e35f3dd6444
Reviewed-on: https://gerrit.libreoffice.org/21763
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index e89eb82..7291d99 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -7,12 +7,16 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
 #include 
 
+#include 
 #include 
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 #include 
@@ -28,10 +32,13 @@
 
 using namespace LOOLProtocol;
 
+using Poco::Exception;
 using Poco::File;
 using Poco::IOException;
 using Poco::JSON::Object;
 using Poco::JSON::Parser;
+using Poco::Notification;
+using Poco::NotificationQueue;
 using Poco::Net::WebSocket;
 using Poco::Path;
 using Poco::Process;
@@ -39,6 +46,260 @@ using Poco::ProcessHandle;
 using Poco::StringTokenizer;
 using Poco::URI;
 
+class CallbackNotification: public Poco::Notification
+{
+public:
+typedef Poco::AutoPtr Ptr;
+
+CallbackNotification(const int nType, const std::string& rPayload)
+  : _nType(nType),
+_aPayload(rPayload)
+{
+}
+
+const int _nType;
+const std::string _aPayload;
+};
+
+// This thread handles callbacks from the
+// lokit instance.
+class CallbackWorker: public Poco::Runnable
+{
+public:
+CallbackWorker(NotificationQueue& queue, ChildProcessSession& session):
+_queue(queue),
+_session(session),
+_stop(false)
+{
+}
+
+std::string callbackTypeToString (const int nType)
+{
+switch (nType)
+{
+case LOK_CALLBACK_INVALIDATE_TILES:
+return std::string("LOK_CALLBACK_INVALIDATE_TILES");
+case LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR:
+return std::string("LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR");
+case LOK_CALLBACK_TEXT_SELECTION:
+return std::string("LOK_CALLBACK_TEXT_SELECTION");
+case LOK_CALLBACK_TEXT_SELECTION_START:
+return std::string("LOK_CALLBACK_TEXT_SELECTION_START");
+case LOK_CALLBACK_TEXT_SELECTION_END:
+return std::string("LOK_CALLBACK_TEXT_SELECTION_END");
+case LOK_CALLBACK_CURSOR_VISIBLE:
+return std::string("LOK_CALLBACK_CURSOR_VISIBLE");
+case LOK_CALLBACK_GRAPHIC_SELECTION:
+return std::string("LOK_CALLBACK_GRAPHIC_SELECTION");
+case LOK_CALLBACK_CELL_CURSOR:
+return std::string("LOK_CALLBACK_CELL_CURSOR");
+case LOK_CALLBACK_CELL_FORMULA:
+return std::string("LOK_CALLBACK_CELL_FORMULA");
+case LOK_CALLBACK_MOUSE_POINTER:
+return std::string("LOK_CALLBACK_MOUSE_POINTER");
+case LOK_CALLBACK_SEARCH_RESULT_SELECTION:
+return std::string("LOK_CALLBACK_SEARCH_RESULT_SELECTION");
+case LOK_CALLBACK_UNO_COMMAND_RESULT:
+return std::string("LOK_CALLBACK_UNO_COMMAND_RESULT");
+case LOK_CALLBACK_HYPERLINK_CLICKED:
+return std::string("LOK_CALLBACK_HYPERLINK_CLICKED");
+case LOK_CALLBACK_STATE_CHANGED:
+return std::string("LOK_CALLBACK_STATE_CHANGED");
+case LOK_CALLBACK_STATUS_INDICATOR_START:
+return std::string("LOK_CALLBACK_STATUS_INDICATOR_START");
+case LOK_CALLBACK_STATUS_INDICATOR_SET_VALUE:
+return std::string("LOK_CALLBACK_STATUS_INDICATOR_SET_VALUE");
+case LOK_CALLBACK_STATUS_INDICATOR_FINISH:
+return std::string("LOK_CALLBACK_STATUS_INDICATOR_FINISH");
+case LOK_CALLBACK_SEARCH_NOT_FOUND:
+return std::string("LOK_CALLBACK_SEARCH_NOT_FOUND");
+case LOK_CALLBACK_DOCUMENT_SIZE_CHANGED:
+return std::string("LOK_CALLBACK_DOCUMENT_SIZE_CHANGED");
+case LOK_CALLBACK_SET_PART:
+return std::string("LOK_CALLBACK_SET_PART");
+}
+return std::to_string(nType);
+}
+
+void callback(const int nType, const std::string& rPayload)
+{
+auto lock = _session.getLock();
+
+Log::trace() << "Callback [" << _session.getViewId() << "] "
+ << callbackTypeToString(nType)
+ << " [" << rPayload << "]." <<

< 1 2

101 - 168 of 168 matches

Mail list logo