[Libreoffice-commits] core.git: icon-themes/galaxy

[Regina Henschel]

 icon-themes/galaxy/cmd/lc_insertcolumnsafter.png  |binary
 icon-themes/galaxy/cmd/lc_insertcolumnsbefore.png |binary
 icon-themes/galaxy/cmd/lc_insertrowsafter.png |binary
 icon-themes/galaxy/cmd/lc_insertrowsbefore.png|binary
 icon-themes/galaxy/cmd/sc_insertcolumnsafter.png  |binary
 icon-themes/galaxy/cmd/sc_insertcolumnsbefore.png |binary
 icon-themes/galaxy/cmd/sc_insertrowsafter.png |binary
 icon-themes/galaxy/cmd/sc_insertrowsbefore.png|binary
 icon-themes/galaxy/links.txt  |9 -
 9 files changed, 9 deletions(-)

New commits:
commit a6238f8222714465fe7a11477706ad19a1b3bebb
Author: Regina Henschel 
Date:   Wed Feb 3 17:10:30 2016 +0100

tdf#97116 Icons for theme Galaxy for new commands insertbefore and 
insertafter

This adds eight icons for the commands insertrowsbefore, insertrowsafter, 
insertcolumnsbefore and insertcolumnsafter in lc_ and sc_, and it adapts file 
links.txt

Change-Id: Id9f32797f97c38b57869bc9f729b1f2a679d1330
Reviewed-on: https://gerrit.libreoffice.org/22084
Tested-by: jan iversen 
Reviewed-by: jan iversen 

diff --git a/icon-themes/galaxy/cmd/lc_insertcolumnsafter.png 
b/icon-themes/galaxy/cmd/lc_insertcolumnsafter.png
new file mode 100755
index 000..6fdcfa2
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_insertcolumnsafter.png 
differ
diff --git a/icon-themes/galaxy/cmd/lc_insertcolumnsbefore.png 
b/icon-themes/galaxy/cmd/lc_insertcolumnsbefore.png
new file mode 100755
index 000..35e9179
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_insertcolumnsbefore.png 
differ
diff --git a/icon-themes/galaxy/cmd/lc_insertrowsafter.png 
b/icon-themes/galaxy/cmd/lc_insertrowsafter.png
new file mode 100755
index 000..6a70006
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_insertrowsafter.png 
differ
diff --git a/icon-themes/galaxy/cmd/lc_insertrowsbefore.png 
b/icon-themes/galaxy/cmd/lc_insertrowsbefore.png
new file mode 100755
index 000..15f95ce
Binary files /dev/null and b/icon-themes/galaxy/cmd/lc_insertrowsbefore.png 
differ
diff --git a/icon-themes/galaxy/cmd/sc_insertcolumnsafter.png 
b/icon-themes/galaxy/cmd/sc_insertcolumnsafter.png
new file mode 100755
index 000..e4b4959
Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_insertcolumnsafter.png 
differ
diff --git a/icon-themes/galaxy/cmd/sc_insertcolumnsbefore.png 
b/icon-themes/galaxy/cmd/sc_insertcolumnsbefore.png
new file mode 100755
index 000..ece07d6
Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_insertcolumnsbefore.png 
differ
diff --git a/icon-themes/galaxy/cmd/sc_insertrowsafter.png 
b/icon-themes/galaxy/cmd/sc_insertrowsafter.png
new file mode 100755
index 000..4448f07
Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_insertrowsafter.png 
differ
diff --git a/icon-themes/galaxy/cmd/sc_insertrowsbefore.png 
b/icon-themes/galaxy/cmd/sc_insertrowsbefore.png
new file mode 100755
index 000..32b3111
Binary files /dev/null and b/icon-themes/galaxy/cmd/sc_insertrowsbefore.png 
differ
diff --git a/icon-themes/galaxy/links.txt b/icon-themes/galaxy/links.txt
index 6539986..cbeef58 100644
--- a/icon-themes/galaxy/links.txt
+++ b/icon-themes/galaxy/links.txt
@@ -19,15 +19,6 @@ cmd/sc_objectforwardone.png cmd/sc_forward.png
 cmd/lc_objectbackone.png cmd/lc_backward.png
 cmd/sc_objectbackone.png cmd/sc_backward.png
 
-cmd/lc_insertrowsbefore.png cmd/lc_insertrows.png
-cmd/sc_insertrowsbefore.png cmd/sc_insertrows.png
-cmd/lc_insertcolumnsbefore.png cmd/lc_insertcolumns.png
-cmd/sc_insertcolumnsbefore.png cmd/sc_insertcolumns.png
-cmd/lc_insertrowsafter.png cmd/lc_insertrows.png
-cmd/sc_insertrowsafter.png cmd/sc_insertrows.png
-cmd/lc_insertcolumnsafter.png cmd/lc_insertcolumns.png
-cmd/sc_insertcolumnsafter.png cmd/sc_insertcolumns.png
-
 cmd/sc_graphicdialog.png cmd/sc_insertgraphic.png
 cmd/sc_templatemenu.png cmd/sc_newdoc.png
 cmd/lc_pagesetup.png cmd/lc_setdocumentproperties.png
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #43 from Commit Notification 
 ---
Ras-al-Ghul committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=881c1c961ea3c0f651a74f637786caf1367a26f3

tdf#96888 - Kill internal vcl dog-tags ...

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: include/vcl vcl/inc vcl/source

[Ras-al-Ghul]

 include/vcl/window.hxx   |1 -
 vcl/inc/svdata.hxx   |   11 ---
 vcl/inc/window.h |3 ---
 vcl/source/window/window.cxx |   10 --
 4 files changed, 25 deletions(-)

New commits:
commit 881c1c961ea3c0f651a74f637786caf1367a26f3
Author: Ras-al-Ghul 
Date:   Thu Feb 4 10:38:41 2016 +0530

tdf#96888 - Kill internal vcl dog-tags ...

Finally removed struct ImplDelData

Change-Id: Ib2bb4a51b94886b95bca0c84adffc8fd4123e8b8
Reviewed-on: https://gerrit.libreoffice.org/22093
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index d69de6d..11a8106 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -40,7 +40,6 @@
 #include 
 
 class VirtualDevice;
-struct ImplDelData;
 struct ImplSVEvent;
 struct ImplWinData;
 struct ImplFrameData;
diff --git a/vcl/inc/svdata.hxx b/vcl/inc/svdata.hxx
index e43b0d4..628f45d 100644
--- a/vcl/inc/svdata.hxx
+++ b/vcl/inc/svdata.hxx
@@ -366,17 +366,6 @@ bool ImplInitAccessBridge();
 FieldUnitStringList* ImplGetFieldUnits();
 FieldUnitStringList* ImplGetCleanedFieldUnits();
 
-// ImplDelData is used as a "dog tag" by a window when it
-// does something that could indirectly destroy the window
-// TODO: wild destruction of a window should not be possible
-
-struct ImplDelData
-{
-ImplDelData*mpNext;
-VclPtr mpWindow;
-boolmbDel;
-};
-
 struct ImplSVEvent
 {
 void*   mpData;
diff --git a/vcl/inc/window.h b/vcl/inc/window.h
index 5203564..db8bdfb 100644
--- a/vcl/inc/window.h
+++ b/vcl/inc/window.h
@@ -28,8 +28,6 @@
 #include 
 #include 
 
-struct ImplDelData;
-
 namespace vcl {
 class Window;
 }
@@ -209,7 +207,6 @@ public:
 // The canvas interface for this VCL window. Is persistent after the first 
GetCanvas() call
 css::uno::WeakReference< css::rendering::XCanvas >mxCanvas;
 
-ImplDelData*mpFirstDel;
 void*   mpUserData;
 vcl::Cursor*mpCursor;
 Pointer maPointer;
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index fbe6496..1d04005 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -510,15 +510,6 @@ void Window::dispose()
 OutputDevice *pOutDev = GetOutDev();
 pOutDev->ReleaseGraphics();
 
-// notify ImplDelData subscribers of this window about the window deletion
-ImplDelData* pDelData = mpWindowImpl->mpFirstDel;
-while ( pDelData )
-{
-pDelData->mbDel = true;
-pDelData->mpWindow.clear();  // #112873# pDel is not associated with a 
Window anymore
-pDelData = pDelData->mpNext;
-}
-
 // remove window from the lists
 ImplRemoveWindow( true );
 
@@ -628,7 +619,6 @@ WindowImpl::WindowImpl( WindowType nType )
 mpLastFocusWindow   = nullptr;  // 
window for focus restore
 mpDlgCtrlDownWindow = nullptr;  // 
window for dialog control
 mnChildEventListenersIteratingCount = 0;
-mpFirstDel  = nullptr;  // 
Dtor notification list
 mpUserData  = nullptr;  // 
user data
 mpCursor= nullptr;  // 
cursor
 mpControlFont   = nullptr;  // 
font properties
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: basic/source

[Noel Grandin]

 basic/source/classes/sbunoobj.cxx |2 +-
 basic/source/sbx/sbxdate.cxx  |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 4fa4b9addfaa4291096cb6de5d98c6612c36757c
Author: Noel Grandin 
Date:   Wed Jan 27 11:07:06 2016 +0200

loplugin:fpcomparison in basic/

Change-Id: I76ffac6a0f0b1525c85d1995277d3ca22ef268e1
Reviewed-on: https://gerrit.libreoffice.org/21869
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basic/source/classes/sbunoobj.cxx 
b/basic/source/classes/sbunoobj.cxx
index da309e7..4a15411 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -1028,7 +1028,7 @@ Any sbxToUnoValueImpl( const SbxValue* pVar, bool 
bBlockConversionToSmallestType
 case TypeClass_DOUBLE:
 {
 double d = pVar->GetDouble();
-if( d == floor( d ) )
+if( rtl::math::approxEqual(d, floor( d )) )
 {
 if( d >= -128 && d <= 127 )
 aType = ::cppu::UnoType::get();
diff --git a/basic/source/sbx/sbxdate.cxx b/basic/source/sbx/sbxdate.cxx
index ebe574d..b678f22 100644
--- a/basic/source/sbx/sbxdate.cxx
+++ b/basic/source/sbx/sbxdate.cxx
@@ -281,7 +281,7 @@ start:
 if( n <= -1.0 || n >= 1.0 )
 {
 // Time only if != 00:00:00
-if( floor( n ) == n )
+if( rtl::math::approxEqual(floor( n ), n) )
 {
 switch( eDate )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang libreofficekit/source sw/source

[Noel Grandin]

 compilerplugins/clang/fpcomparison.cxx   |  146 +++
 libreofficekit/source/gtk/lokdocview.cxx |2 
 sw/source/core/layout/paintfrm.cxx   |4 
 3 files changed, 149 insertions(+), 3 deletions(-)

New commits:
commit 4e9b528dccdfc438394b1ffe029f1fc8178a6086
Author: Noel Grandin 
Date:   Mon Feb 1 14:55:56 2016 +0200

new loplugin fpcomparison

Find code that compares floating point values with == or !=
It should rather use rtl::math::approxEqual

Change-Id: I9026e08823340fa1d6a042c430515344c93215bd
Reviewed-on: https://gerrit.libreoffice.org/21997
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/compilerplugins/clang/fpcomparison.cxx 
b/compilerplugins/clang/fpcomparison.cxx
new file mode 100644
index 000..b374da7
--- /dev/null
+++ b/compilerplugins/clang/fpcomparison.cxx
@@ -0,0 +1,146 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include "plugin.hxx"
+#include "compat.hxx"
+
+/**
+comparing floating point numbers using == or != is a bad idea.
+*/
+
+namespace {
+
+class FpComparison:
+public RecursiveASTVisitor, public loplugin::Plugin
+{
+public:
+explicit FpComparison(InstantiationData const & data): Plugin(data) {}
+
+virtual void run() override
+{
+TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
+}
+
+bool VisitBinaryOperator(const BinaryOperator* );
+bool TraverseFunctionDecl(FunctionDecl* );
+private:
+bool ignore(FunctionDecl* );
+enum class EState { None, TraverseProcess, TraverseIgnore };
+EState meState = EState::None;
+};
+
+static const std::set whitelist {
+"rtl::math::approxEqual",
+"(anonymous namespace)::doubleToString",
+"(anonymous namespace)::stringToDouble",
+"rtl_math_round",
+"rtl_math_approxValue",
+"rtl_math_asinh",
+"rtl_math_acosh",
+"cppu::_equalSequence", // cppu/source/uno/eq.hxx
+"cppu::_equalData", // cppu/source/uno/eq.hxx
+"xmlscript::equalFont", // xmlscript/source/xmldlg_imexp/xmldlg_export.cxx
+
+// these might need fixing
+"basegfx::tools::getSmallestDistancePointToPolygon", // 
basegfx/source/polygon/b2dpolygontools.cxx
+"basegfx::tools::getSmallestDistancePointToPolyPolygon", // 
basegfx/source/polygon/b2dpolypolygontools.cxx
+"bridge_test::performTest", // testtools/source/bridgetest/bridgetest.cxx
+"bridge_test::equals",
+"(anonymous namespace)::lcl_getNANInsteadDBL_MIN", // 
chart2/source/controller/chartapiwrapper/ChartDataWrapper.cxx
+};
+bool FpComparison::TraverseFunctionDecl(FunctionDecl* function)
+{
+bool bIgnore = ignore(function);
+meState = bIgnore ? EState::TraverseIgnore : EState::TraverseProcess;
+bool bRet = RecursiveASTVisitor::TraverseFunctionDecl(function);
+meState = EState::None;
+return bRet;
+}
+
+bool FpComparison::ignore(FunctionDecl* function)
+{
+if (ignoreLocation(function)) {
+return true;
+}
+// we assume that these modules know what they are doing with FP stuff
+StringRef aFileName = 
compiler.getSourceManager().getFilename(compiler.getSourceManager().getSpellingLoc(function->getLocStart()));
+if (aFileName.startswith(SRCDIR "/sc/")) {
+return true;
+}
+if (!function->doesThisDeclarationHaveABody()) {
+return true;
+}
+ // Ignore operator== and operator!=
+if (function->getOverloadedOperator() == OO_EqualEqual
+|| function->getOverloadedOperator() == OO_ExclaimEqual) {
+return true;
+}
+// ignore known good functions
+std::string s = function->getQualifiedNameAsString();
+if (whitelist.find(s) != whitelist.end()) {
+return true;
+}
+//cout << "xxx " + function->getQualifiedNameAsString() << endl;
+return false;
+}
+
+static bool isZeroConstant(ASTContext& context, const Expr* expr)
+{
+// calling isCXX11ConstantExpr with non-arithmetic types sometimes results 
in a crash
+if (!expr->getType()->isArithmeticType()) {
+return false;
+}
+// prevent clang crash
+if (!context.getLangOpts().CPlusPlus) {
+return false;
+}
+APValue result;
+if (expr->isCXX11ConstantExpr(context, &result)
+&& result.isFloat() && result.getFloat().isZero())
+{
+return true;
+}
+return false;
+}
+bool FpComparison::VisitBinaryOperator(const BinaryOperator* binaryOp)
+{
+if (meState != EState::TraverseProcess || ignoreLocation(binaryOp)) {
+return true;
+}
+if (binaryOp->getOpcode() != BO_EQ && binaryOp->getOpcode() != BO_NE) {
+return true;
+}
+// 

[Libreoffice-commits] core.git: accessibility/inc

[Chris Sherlock]

 accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx  |
2 
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx |   
21 ++
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxTableBase.hxx |   
26 +++
 accessibility/inc/accessibility/extended/AccessibleGridControlBase.hxx|   
33 --
 accessibility/inc/accessibility/extended/AccessibleGridControlHeader.hxx  |   
22 +++---
 accessibility/inc/accessibility/extended/AccessibleGridControlTable.hxx   |   
24 +++
 6 files changed, 60 insertions(+), 68 deletions(-)

New commits:
commit 5569a65ea4984f72212a44679f2125843a855a80
Author: Chris Sherlock 
Date:   Thu Feb 4 17:36:41 2016 +1100

accessibility: cleanup doxygen errors

Change-Id: I6abc6e84edc461e8fa20f9c9689e0a66e26980af

diff --git 
a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx 
b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
index 66b49a8..fe30065 100644
--- a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
+++ b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
@@ -73,7 +73,7 @@ typedef ::cppu::WeakAggComponentImplHelper5<
 
 /** The BrowseBox accessible objects inherit from this base class. It
 implements basic functionality for various Accessibility interfaces and
-the event broadcaster and contains the ::osl::Mutex. */
+the event broadcaster and contains the osl::Mutex. */
 class AccessibleBrowseBoxBase :
 public ::comphelper::OBaseMutex,
 public AccessibleBrowseBoxImplHelper
diff --git 
a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx 
b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx
index b9a3fcc..df52d7b 100644
--- a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx
+++ b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxTable.hxx
@@ -24,11 +24,8 @@
 #include "accessibility/extended/AccessibleBrowseBoxTableBase.hxx"
 
 
-
 namespace accessibility {
 
-
-
 /** This class represents the accessible object of the data table of a
 BrowseBox control. */
 class AccessibleBrowseBoxTable : public AccessibleBrowseBoxTableBase
@@ -44,7 +41,7 @@ protected:
 virtual ~AccessibleBrowseBoxTable();
 
 public:
-// XAccessibleContext -
+// XAccessibleContext
 
 /** @return  The XAccessible interface of the specified child. */
 virtual css::uno::Reference< css::accessibility::XAccessible > SAL_CALL
@@ -56,7 +53,7 @@ public:
 virtual sal_Int32 SAL_CALL getAccessibleIndexInParent()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-// XAccessibleComponent ---
+// XAccessibleComponent
 
 /** @return  The accessible child rendered under the given point. */
 virtual css::uno::Reference< css::accessibility::XAccessible > SAL_CALL
@@ -67,7 +64,7 @@ public:
 virtual void SAL_CALL grabFocus()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-// XAccessibleTable ---
+// XAccessibleTable
 
 /** @return  The description text of the specified row. */
 virtual OUString SAL_CALL getAccessibleRowDescription( sal_Int32 nRow )
@@ -99,12 +96,12 @@ public:
 getSelectedAccessibleColumns()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-/** @return  , if the specified row is completely selected. */
+/** @return  TRUE, if the specified row is completely selected. */
 virtual sal_Bool SAL_CALL isAccessibleRowSelected( sal_Int32 nRow )
 throw ( css::lang::IndexOutOfBoundsException,
 css::uno::RuntimeException, std::exception ) override;
 
-/** @return  , if the specified column is completely selected. */
+/** @return  TRUE, if the specified column is completely selected. */
 virtual sal_Bool SAL_CALL isAccessibleColumnSelected( sal_Int32 nColumn )
 throw ( css::lang::IndexOutOfBoundsException,
 css::uno::RuntimeException, std::exception ) override;
@@ -116,19 +113,19 @@ public:
 throw ( css::lang::IndexOutOfBoundsException,
 css::uno::RuntimeException, std::exception ) override;
 
-/** @return  , if the specified cell is selected. */
+/** @return  TRUE, if the specified cell is selected. */
 virtual sal_Bool SAL_CALL isAccessibleSelected( sal_Int32 nRow, sal_Int32 
nColumn )
 throw ( css::lang::IndexOutOfBoundsException,
 css::uno::RuntimeException, std::exception ) override;
 
-// XServiceInfo ---
+// XServiceInfo
 
 /** @return  The name of this class. */
 virtual OUString SAL_CALL getImplementationName()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
 p

[Libreoffice-commits] core.git: cppcanvas/source

[Noel Grandin]

 cppcanvas/source/mtfrenderer/mtftools.cxx |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 27a114e73f9ce64f360b045233e1c9c74c207880
Author: Noel Grandin 
Date:   Wed Jan 27 11:06:52 2016 +0200

loplugin:fpcomparison in cppcanvas/

Change-Id: I23d7e217f2616b488579be0617dbc14cd407540f
Reviewed-on: https://gerrit.libreoffice.org/21868
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/cppcanvas/source/mtfrenderer/mtftools.cxx 
b/cppcanvas/source/mtfrenderer/mtftools.cxx
index 32c0af7..85fc5c8 100644
--- a/cppcanvas/source/mtfrenderer/mtftools.cxx
+++ b/cppcanvas/source/mtfrenderer/mtftools.cxx
@@ -126,8 +126,8 @@ namespace cppcanvas
 {
 const bool bOffsetting( !rOffset.equalZero() );
 const bool bScaling( pScaling &&
- pScaling->getX() != 1.0 &&
- pScaling->getY() != 1.0 );
+ !rtl::math::approxEqual(pScaling->getX(), 
1.0) &&
+ !rtl::math::approxEqual(pScaling->getY(), 
1.0) );
 const bool bRotation( pRotation &&
   *pRotation != 0.0 );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: opencl/source

[Noel Grandin]

 opencl/source/opencl_device.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 4fccc4376cd253648bf0dd1d49dd80bc76148f08
Author: Noel Grandin 
Date:   Wed Jan 27 11:06:31 2016 +0200

loplugin:fpcomparison in opencl/

Change-Id: Ia5b4a5010afd72ce59629dbc9b2045177a155182
Reviewed-on: https://gerrit.libreoffice.org/21867
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/opencl/source/opencl_device.cxx b/opencl/source/opencl_device.cxx
index 9a10d36..32a94df 100644
--- a/opencl/source/opencl_device.cxx
+++ b/opencl/source/opencl_device.cxx
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #include "opencl_device.hxx"
 
@@ -175,7 +176,7 @@ double timerCurrent(timer* mytimer)
 /* Random number generator */
 double random(double min, double max)
 {
-if (min == max)
+if (rtl::math::approxEqual(min, max))
 return min;
 return comphelper::rng::uniform_real_distribution(min, max);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: accessibility/inc accessibility/source solenv/inc

[Chris Sherlock]

 accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx|  
  6 
 accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx   |  
 30 ++--
 accessibility/inc/accessibility/standard/vclxaccessiblebox.hxx  |  
 15 --
 accessibility/inc/accessibility/standard/vclxaccessiblecombobox.hxx |  
  4 
 accessibility/inc/accessibility/standard/vclxaccessibledropdowncombobox.hxx |  
  4 
 accessibility/inc/accessibility/standard/vclxaccessibledropdownlistbox.hxx  |  
  4 
 accessibility/inc/accessibility/standard/vclxaccessiblelist.hxx |  
 13 -
 accessibility/inc/accessibility/standard/vclxaccessiblelistbox.hxx  |  
  2 
 accessibility/inc/accessibility/standard/vclxaccessibletextfield.hxx|  
 10 -
 accessibility/source/extended/AccessibleBrowseBox.cxx   |  
 73 --
 accessibility/source/extended/AccessibleBrowseBoxBase.cxx   |  
 68 -
 accessibility/source/extended/AccessibleGridControl.cxx |  
 64 
 accessibility/source/extended/AccessibleGridControlBase.cxx |  
 64 
 accessibility/source/extended/AccessibleGridControlTableCell.cxx|  
 26 +--
 accessibility/source/extended/accessiblebrowseboxcell.cxx   |  
  9 -
 accessibility/source/extended/accessibleeditbrowseboxcell.cxx   |  
 44 +++---
 accessibility/source/extended/accessibleiconchoicectrlentry.cxx |  
  2 
 solenv/inc/doxygen.cfg  |  
  2 
 18 files changed, 214 insertions(+), 226 deletions(-)

New commits:
commit 777ad8f5d5b140af0b6959995b8838bf50a578ec
Author: Chris Sherlock 
Date:   Thu Feb 4 14:54:41 2016 +1100

accessibility: fix doxygen errors

Change-Id: Ib1bed3e4df91ad00ecf2deb5c3d135cc2f5561b5

diff --git 
a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx 
b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
index 8951322..66b49a8 100644
--- a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
+++ b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxBase.hxx
@@ -169,7 +169,7 @@ public:
 // XAccessibleComponent ---
 
 /** @return
-, if the point lies within the bounding box of this object. */
+TRUE, if the point lies within the bounding box of this object. */
 virtual sal_Bool SAL_CALL containsPoint( const css::awt::Point& rPoint )
 throw ( css::uno::RuntimeException, std::exception ) override;
 
@@ -255,7 +255,7 @@ public:
 sal_Int16 nEventId,
 const css::uno::Any& rNewValue,
 const css::uno::Any& rOldValue );
-/** @return  , if the object is not disposed or disposing. */
+/** @return  TRUE, if the object is not disposed or disposing. */
 bool isAlive() const;
 
 protected:
@@ -265,7 +265,7 @@ protected:
 its parent accessible window. Derived classes may implement different
 behaviour.
 @attention  This method requires locked mutex's and a living object.
-@return  , if the object is really showing. */
+@return  TRUE, if the object is really showing. */
 bool implIsShowing();
 
 /** Derived classes return the bounding box relative to the parent window.
diff --git 
a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx 
b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx
index 544ba07..3b1260c 100644
--- a/accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx
+++ b/accessibility/inc/accessibility/extended/AccessibleBrowseBoxHeaderBar.hxx
@@ -54,7 +54,7 @@ protected:
 virtual ~AccessibleBrowseBoxHeaderBar();
 
 public:
-// XAccessibleContext -
+// XAccessibleContext
 
 /** @return
 The XAccessible interface of the specified child.
@@ -69,7 +69,7 @@ public:
 getAccessibleIndexInParent()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-// XAccessibleComponent ---
+// XAccessibleComponent
 
 /** @return  The accessible child rendered under the given point. */
 virtual css::uno::Reference< css::accessibility::XAccessible > SAL_CALL
@@ -80,7 +80,7 @@ public:
 virtual void SAL_CALL grabFocus()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-// XAccessibleTable ---
+// XAccessibleTable
 
 /** @return  The description text of the specified row. */
 virtual OUString SAL_CALL
@@ -113,12 +113,12 @@ public:
 getSelectedAccessibleColumns()
 throw ( css::uno::RuntimeException, std::exception ) override;
 
-/** @return  , if the specified row is completely selected. */
+/** @retur

[Libreoffice-commits] core.git: registry/tools

[Noel Grandin]

 registry/tools/regcompare.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 0e414e1433acf775c17063cc748818ee7dd822e3
Author: Noel Grandin 
Date:   Wed Jan 27 11:06:24 2016 +0200

loplugin:fpcomparison in registry/

Change-Id: Ifdc2df9ba51ce8ef2c8793bb51c28a547f22214f
Reviewed-on: https://gerrit.libreoffice.org/21866
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/registry/tools/regcompare.cxx b/registry/tools/regcompare.cxx
index d5e33c7..901f719 100644
--- a/registry/tools/regcompare.cxx
+++ b/registry/tools/regcompare.cxx
@@ -25,6 +25,7 @@
 #include "options.hxx"
 
 #include 
+#include 
 #include 
 
 #include 
@@ -584,7 +585,7 @@ static sal_uInt32 checkConstValue(Options_Impl const & 
options,
 }
 break;
 case RT_TYPE_FLOAT:
-if (constValue1.m_value.aFloat != constValue2.m_value.aFloat)
+if (!rtl::math::approxEqual(constValue1.m_value.aFloat, 
constValue2.m_value.aFloat))
 {
 if ( options.forceOutput() && !options.unoTypeCheck() )
 {
@@ -596,7 +597,7 @@ static sal_uInt32 checkConstValue(Options_Impl const & 
options,
 }
 break;
 case RT_TYPE_DOUBLE:
-if (constValue1.m_value.aDouble != constValue2.m_value.aDouble)
+if (!rtl::math::approxEqual(constValue1.m_value.aDouble, 
constValue2.m_value.aDouble))
 {
 if ( options.forceOutput() && !options.unoTypeCheck() )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: scaddins/source

[Noel Grandin]

 scaddins/source/analysis/analysishelper.cxx |8 
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 318a23b4f4e3e02b664437044de833b9a8e4f85f
Author: Noel Grandin 
Date:   Wed Jan 27 11:06:10 2016 +0200

loplugin:fpcomparison in scaddins/

Change-Id: I9a303a92f5531d549faf6d86ea0ce6360e115567
Reviewed-on: https://gerrit.libreoffice.org/21865
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/scaddins/source/analysis/analysishelper.cxx 
b/scaddins/source/analysis/analysishelper.cxx
index b820606..b0af04e 100644
--- a/scaddins/source/analysis/analysishelper.cxx
+++ b/scaddins/source/analysis/analysishelper.cxx
@@ -1123,15 +1123,15 @@ double getYield_( sal_Int32 nNullDate, sal_Int32 
nSettle, sal_Int32 nMat, double
 double  fPrice2 = getPrice_( nNullDate, nSettle, nMat, fRate, fYield2, 
fRedemp, nFreq, nBase );
 double  fYieldN = ( fYield2 - fYield1 ) * 0.5;
 
-for( sal_uInt32 nIter = 0 ; nIter < 100 && fPriceN != fPrice ; nIter++ )
+for( sal_uInt32 nIter = 0 ; nIter < 100 && 
!rtl::math::approxEqual(fPriceN, fPrice) ; nIter++ )
 {
 fPriceN = getPrice_( nNullDate, nSettle, nMat, fRate, fYieldN, 
fRedemp, nFreq, nBase );
 
-if( fPrice == fPrice1 )
+if( rtl::math::approxEqual(fPrice, fPrice1) )
 return fYield1;
-else if( fPrice == fPrice2 )
+else if( rtl::math::approxEqual(fPrice, fPrice2) )
 return fYield2;
-else if( fPrice == fPriceN )
+else if( rtl::math::approxEqual(fPrice, fPriceN) )
 return fYieldN;
 else if( fPrice < fPrice2 )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sdext/source

[Noel Grandin]

 sdext/source/pdfimport/misc/pdfihelper.cxx   |2 +-
 sdext/source/pdfimport/tree/drawtreevisiting.cxx |   11 +--
 2 files changed, 6 insertions(+), 7 deletions(-)

New commits:
commit 8ffd2c8dd032e718bc8c3d574cd47e82a2c07261
Author: Noel Grandin 
Date:   Wed Jan 27 11:05:54 2016 +0200

loplugin:fpcomparison in sdext/

Change-Id: If2ae6c3399ef3aceffc2080fcd790e91dc594d9b
Reviewed-on: https://gerrit.libreoffice.org/21864
Reviewed-by: Noel Grandin 
Tested-by: Noel Grandin 

diff --git a/sdext/source/pdfimport/misc/pdfihelper.cxx 
b/sdext/source/pdfimport/misc/pdfihelper.cxx
index c1f7c41..65b4a85 100644
--- a/sdext/source/pdfimport/misc/pdfihelper.cxx
+++ b/sdext/source/pdfimport/misc/pdfihelper.cxx
@@ -54,7 +54,7 @@ void pdfi::FillDashStyleProps(PropertyMap& props, const 
std::vector& das
 
 for (size_t i = 0; i < pairCount; i++)
 {
-if (dotLengths[dotStage] != dashArray[i * 2])
+if (!rtl::math::approxEqual(dotLengths[dotStage], dashArray[i * 2]))
 {
 dotStage++;
 if (dotStage == 3)
diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx 
b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
index a38050a..46ed9b4 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
@@ -663,12 +663,11 @@ bool isSpaces(TextElement* pTextElem)
 
 bool notTransformed(const GraphicsContext& GC)
 {
-return (
-GC.Transformation.get(0,0) ==  100.00 &&
-GC.Transformation.get(1,0) ==0.00 &&
-GC.Transformation.get(0,1) ==0.00 &&
-GC.Transformation.get(1,1) == -100.00
-   );
+return
+rtl::math::approxEqual(GC.Transformation.get(0,0), 100.00) &&
+GC.Transformation.get(1,0) == 0.00 &&
+GC.Transformation.get(0,1) == 0.00 &&
+rtl::math::approxEqual(GC.Transformation.get(1,1), -100.00);
 }
 
 void DrawXmlOptimizer::optimizeTextElements(Element& rParent)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: slideshow/source

[Noel Grandin]

 slideshow/source/engine/color.cxx |6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit dc889a9a3054e99f997c2377b7e312396366f4ba
Author: Noel Grandin 
Date:   Wed Jan 27 11:04:56 2016 +0200

loplugin:fpcomparison in slideshow/

Change-Id: Ic910deea47065d1f69748b95e59d19c6cda5d29b
Reviewed-on: https://gerrit.libreoffice.org/21863
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/slideshow/source/engine/color.cxx 
b/slideshow/source/engine/color.cxx
index 17b1e3c..f31c36c 100644
--- a/slideshow/source/engine/color.cxx
+++ b/slideshow/source/engine/color.cxx
@@ -69,11 +69,11 @@ namespace slideshow
 nDelta/(2.0-nMax-nMin) :
 nDelta/(nMax + nMin);
 
-if( nRed == nMax )
+if( rtl::math::approxEqual(nRed, nMax) )
 aRes.mnHue = (nGreen - nBlue)/nDelta;
-else if( nGreen == nMax )
+else if( rtl::math::approxEqual(nGreen, nMax) )
 aRes.mnHue = 2.0 + (nBlue - nRed)/nDelta;
-else if( nBlue == nMax )
+else if( rtl::math::approxEqual(nBlue, nMax) )
 aRes.mnHue = 4.0 + (nRed - nGreen)/nDelta;
 
 aRes.mnHue *= 60.0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: svtools/source

[Noel Grandin]

 svtools/source/control/ctrlbox.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e2bada96d5d6242e3dc6a957e90b73feb9fc0765
Author: Noel Grandin 
Date:   Wed Jan 27 11:04:45 2016 +0200

loplugin:fpcomparison in svtools/

Change-Id: I8dc3cc128dc97b429e714c4837dd6cb81fa358d0
Reviewed-on: https://gerrit.libreoffice.org/21862
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/svtools/source/control/ctrlbox.cxx 
b/svtools/source/control/ctrlbox.cxx
index eb32450..6697d3f 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -372,7 +372,7 @@ static double lcl_getGuessedWidth( long nTested, double 
nRate, bool bChanging )
 nWidth = double( nTested ) / nRate;
 else
 {
-if ( double( nTested ) == nRate )
+if ( rtl::math::approxEqual(double( nTested ), nRate) )
 nWidth = nRate;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: cannot fetch from gerrit git://

[Norbert Thiebaud]

On Wed, Feb 3, 2016 at 11:52 PM, Lionel Elie Mamane  wrote:
> $ egrep -A2 '^\[remote "origin"\]' .git/config
> [remote "origin"]
> fetch = +refs/heads/*:refs/remotes/origin/*
> url = git://gerrit.libreoffice.org/core
> $ git fetch origin
[...]
> remote: error: unable to open object pack directory: ./objects/pack: Too many 
> open files
> remote: fatal: failed to read object 
> 198f20238330e60172f67e9c6a21aeefc50136c4: Too many open files
> remote: aborting due to possible repository corruption on the remote side.
> fatal: protocol error: bad pack header
>

prolly too long since the last git gc on core.git, leaving many
'loose' objects => needing too many open file descriptors...
/me taking care of that...

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Program Committee for LibOCon

[Thorsten Behrens]

Sophie Gautier wrote:
> As each year, it's time to form the Program Committee. We need at least
> 3 or 4 persons available to review the talks proposed by the community,
> sort and organize them and then manage the conference program.
> 
> *Important note*: you need to be available during July and August as
> these are the months during which we set the program.
> 
I can help, as in the past. :)

Cheers,

-- Thorsten


signature.asc
Description: Digital signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

cannot fetch from gerrit git://

[Lionel Elie Mamane]

$ egrep -A2 '^\[remote "origin"\]' .git/config
[remote "origin"]
fetch = +refs/heads/*:refs/remotes/origin/*
url = git://gerrit.libreoffice.org/core
$ git fetch origin
remote: Counting objects: 704, done.
remote: Compressing objects: 100% (27/27), done.
remote: warning: packfile 
./objects/pack/pack-8b907b026227f51dc9234d7a40128b19a6bfc40c.pack cannot be 
accessed
remote: error: refs/tags/cp-5.0-18 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-c56a30ae5f41aa55d060bd441b59eeb2e0a48a7d.pack cannot be 
accessed
remote: error: refs/tags/cp-5.0-19 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-05c73a3f601967129220b30648feb10876ab07cb.pack cannot be 
accessed
remote: error: refs/tags/cp-5.0-20 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-d0127a6f2741ef2a8d443b625405e16574e156bd.pack cannot be 
accessed
remote: error: refs/tags/cp-5.0-21 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-b021cf6c06b0e46bf526ba7680b1e940863d5f44.pack cannot be 
accessed
remote: error: refs/tags/libreoffice-5.0.5.1 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-d8f99aef820301e9510f57a94b47399b0da57c7a.pack cannot be 
accessed
remote: error: refs/tags/libreoffice-5.1.0.2 does not point to a valid object!
remote: warning: packfile 
./objects/pack/pack-c95e01b5f74371dfdc8a7f6e97f542b8419ed90f.pack cannot be 
accessed
remote: error: refs/tags/libreoffice-5.1.0.3 does not point to a valid object!
remote: error: unable to open object pack directory: ./objects/pack: Too many 
open files
remote: fatal: failed to read object 198f20238330e60172f67e9c6a21aeefc50136c4: 
Too many open files
remote: aborting due to possible repository corruption on the remote side.
fatal: protocol error: bad pack header


By contrast, fetching from
git://anongit.freedesktop.org/git/libreoffice/core
works. 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/firebird

[Lionel Elie Mamane]

 external/firebird/ExternalProject_firebird.mk |   29 +-
 1 file changed, 15 insertions(+), 14 deletions(-)

New commits:
commit 198f20238330e60172f67e9c6a21aeefc50136c4
Author: Lionel Elie Mamane 
Date:   Thu Feb 4 01:21:09 2016 +0100

firebird: avoid using ignored -m option to make

Change-Id: Ic24c295a84f402ec5478bafbdebc54f976b1a72c
Reviewed-on: https://gerrit.libreoffice.org/22092
Tested-by: Jenkins 
Reviewed-by: Lionel Elie Mamane 

diff --git a/external/firebird/ExternalProject_firebird.mk 
b/external/firebird/ExternalProject_firebird.mk
index 6aa992f..cd89dfb 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -25,19 +25,22 @@ $(eval $(call gb_ExternalProject_register_targets,firebird,\
 # note: this can intentionally only build against internal tommath
 
 ifneq ($(OS),WNT)
-SET_FCA=&& FB_CPU_ARG='$(filter --jobserver-fds=%,$(MAKEFLAGS))'
+INVOKE_FPA:="CPU=\$$(EMPTY) $${FB_CPU_ARG}"
 endif
 
+MAKE_PRE=$(if $(filter WNT,$(OS)),\
+  PATH="$(shell cygpath -u $(call 
gb_UnpackedTarball_get_dir,icu)/source/lib):$$PATH",\
+  $(gb_Helper_set_ld_path))
+
+MAKE_POST=$(if $(filter MACOSX,$(OS)),&& $(PERL) \
+   $(SRCDIR)/solenv/bin/macosx-change-install-names.pl shl 
OOO \
+   
$(gb_Package_SOURCEDIR_firebird)/gen/firebird/lib/libfbembed.dylib.2.5.5)
+
 # do not set LDFLAGS - it is mysteriously not used by firebird on MacOSX
 $(call gb_ExternalProject_get_state_target,firebird,build):
$(call gb_ExternalProject_run,build,\
unset MAKEFLAGS \
-   $(SET_FCA) \
-   && if [ -n "$${FB_CPU_ARG}" ]; then \
- FB_PRLL_ARG="CPU=\$$(EMPTY) $${FB_CPU_ARG}"; \
-   else \
- FB_PRLL_ARG="-m"; \
-   fi \
+   && FB_CPU_ARG='$(filter --jobserver-fds=%,$(MAKEFLAGS))' \
&& export PKG_CONFIG="" \
&& export CPPFLAGS=" \
$(if $(SYSTEM_LIBATOMIC_OPS),$(LIBATOMIC_OPS_CFLAGS), \
@@ -67,12 +70,10 @@ $(call gb_ExternalProject_get_state_target,firebird,build):
, \
--enable-shared --disable-static \
) \
-   && $(if $(filter WNT,$(OS)),\
-  PATH="$(shell cygpath -u $(call 
gb_UnpackedTarball_get_dir,icu)/source/lib):$$PATH",\
-  $(gb_Helper_set_ld_path)) \
-  $(MAKE) "$${FB_PRLL_ARG}" SHELL='$(SHELL)' firebird_embedded 
\
-   $(if $(filter MACOSX,$(OS)),&& $(PERL) \
-   $(SRCDIR)/solenv/bin/macosx-change-install-names.pl shl 
OOO \
-   
$(gb_Package_SOURCEDIR_firebird)/gen/firebird/lib/libfbembed.dylib.2.5.5) \
+   && if [ -n "$${FB_CPU_ARG}" ]; then \
+  $(MAKE_PRE) $(MAKE) $(INVOKE_FPA) SHELL='$(SHELL)' 
firebird_embedded $(MAKE_POST); \
+   else \
+  $(MAKE_PRE) $(MAKE) SHELL='$(SHELL)' 
firebird_embedded $(MAKE_POST); \
+   fi \
)
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
30 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1351758:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/unx/gtk/gtkinst.hxx: 140 in GtkDragSource::GtkDragSource()()



*** CID 1351758:  Uninitialized members  (UNINIT_CTOR)
/vcl/inc/unx/gtk/gtkinst.hxx: 140 in GtkDragSource::GtkDragSource()()
134 osl::Mutex m_aMutex;
135 GtkSalFrame* m_pFrame;
136 css::uno::Reference 
m_xListener;
137 css::uno::Reference m_xTrans;
138 VclToGtkHelper m_aConversionHelper;
139 public:
>>> CID 1351758:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "m_pFrame" is not initialized in this 
>>> constructor nor in any functions that it calls.
140 GtkDragSource() : WeakComponentImplHelper( m_aMutex ) {}
141 virtual ~GtkDragSource();
142 
143 // XDragSource
144 virtual sal_BoolSAL_CALL isDragImageSupported() 
throw(std::exception) override;
145 virtual sal_Int32   SAL_CALL getDefaultCursor(sal_Int8 dragAction) 
throw(std::exception) override;

** CID 1351757:  Uninitialized members  (UNINIT_CTOR)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 168 in 
TiledWindow::TiledWindow()()



*** CID 1351757:  Uninitialized members  (UNINIT_CTOR)
/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx: 168 in 
TiledWindow::TiledWindow()()
162 m_pFindbarEntry(nullptr),
163 m_pFindbarLabel(nullptr),
164 m_bFindAll(false)
165 {
166 struct passwd* pPasswd = getpwuid(getuid());
167 m_aAuthor = std::string(pPasswd->pw_gecos);
>>> CID 1351757:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "m_pDeleteComment" is not initialized in this 
>>> constructor nor in any functions that it calls.
168 }
169 };
170 
171 static std::map g_aWindows;
172 
173 static void setupDocView(GtkWidget* pDocView);

** CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
/wizards/com/sun/star/wizards/document/Control.java: 217 in 
com.sun.star.wizards.document.Control.getPreferredHeight()()



*** CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
/wizards/com/sun/star/wizards/document/Control.java: 217 in 
com.sun.star.wizards.document.Control.getPreferredHeight()()
211 return 2000;
212 }
213 else
214 {
215 Size aPeerSize = getPeerSize();
216 int nHeight = aPeerSize.Height;
>>> CID 1351756:  Null pointer dereferences  (REVERSE_INULL)
>>> Null-checking "aPeerSize" suggests that it may be null, but it has 
>>> already been dereferenced on all paths leading to the check.
217 if (aPeerSize == null)
218  nHeight = 0;
219 else
220  nHeight = aPeerSize.Height;
221 
222 // We increase the preferred Height a bit so that the 
control does not become too small

** CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 527 in 
ScPivotLayoutDialog::ApplyChanges()()



*** CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/ui/dbgui/PivotLayoutDialog.cxx: 527 in 
ScPivotLayoutDialog::ApplyChanges()()
521// range or to a new sheet
522// FIXME: if the new range overlaps with the old one, the 
table actually doesn't move
523// and shouldn't therefore be deleted
524if ( !rOldRange.In( aDestinationRange )
525 || (bToNewSheet && !mbNewPivotTable) )
526{
>>> CID 1351755:  Null pointer dereferences  (NULL_RETURNS)
>>> Assigning: "pDPObj" = null return value from "GetDPAtCursor".
527ScDPObject *pDPObj = mpDocument->GetDPAtCursor( 
maPivotParameters.nCol, maPivotParameters.nRow, maPivotParameters.nTab);
528ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
529aFunc.RemovePivotTable( *pDPObj, true, false);
530mpViewData->GetView()->CursorPosChanged();
531}
532return;



To 

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp loolwsd/LOOLWSD.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |2 +-
 loolwsd/LOOLWSD.cpp|4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5848cff63409f6d708d562e2c702425f65647d7a
Author: Henry Castro 
Date:   Wed Feb 3 19:51:27 2016 -0400

loolwsd: wait for loolbroker process to change state

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 858009f..41305d6 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -965,7 +965,7 @@ int main(int argc, char** argv)
 else
 if (WIFSIGNALED(status))
 {
-nChildExitCode = Util::getSignalStatus(WEXITSTATUS(status));
+nChildExitCode = Util::getSignalStatus(WTERMSIG(status));
 std::string fate = "died";
 #ifdef WCOREDUMP
 if (WCOREDUMP(status))
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index eeb3d2d..02482d9 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1000,7 +1000,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 unsigned timeoutCounter = 0;
 while (!TerminationFlag && !LOOLWSD::DoTest)
 {
-const pid_t pid = waitpid(-1, &status, WUNTRACED | WNOHANG);
+const pid_t pid = waitpid(pidBroker, &status, WUNTRACED | WNOHANG);
 if (pid > 0)
 {
 if (pidBroker == pid)
@@ -1084,7 +1084,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 Process::requestTermination(pidBroker);
 
 // wait broker process finish
-waitpid(-1, &status, WUNTRACED);
+waitpid(pidBroker, &status, WUNTRACED);
 
 close(BrokerWritePipe);
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: external/firebird

[Lionel Elie Mamane]

 external/firebird/ExternalProject_firebird.mk |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 91a7580e03d5b47c6e2513afce85ddee45e730b6
Author: Lionel Elie Mamane 
Date:   Thu Feb 4 00:23:33 2016 +0100

apparently breaks Win-x86@42 tinderbox... disable on Windows.

Note it works well on the Windows Jenkins build check. Go figure.

Change-Id: I05990274d85b1044a94ec7371130bf918f8fd09e

diff --git a/external/firebird/ExternalProject_firebird.mk 
b/external/firebird/ExternalProject_firebird.mk
index 0e80811..6aa992f 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -24,11 +24,15 @@ $(eval $(call gb_ExternalProject_register_targets,firebird,\
 # note: this can intentionally only build against internal atomic_op
 # note: this can intentionally only build against internal tommath
 
+ifneq ($(OS),WNT)
+SET_FCA=&& FB_CPU_ARG='$(filter --jobserver-fds=%,$(MAKEFLAGS))'
+endif
+
 # do not set LDFLAGS - it is mysteriously not used by firebird on MacOSX
 $(call gb_ExternalProject_get_state_target,firebird,build):
$(call gb_ExternalProject_run,build,\
unset MAKEFLAGS \
-   && FB_CPU_ARG='$(filter --jobserver-fds=%,$(MAKEFLAGS))' \
+   $(SET_FCA) \
&& if [ -n "$${FB_CPU_ARG}" ]; then \
  FB_PRLL_ARG="CPU=\$$(EMPTY) $${FB_CPU_ARG}"; \
else \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 5 commits - oox/inc oox/source reportbuilder/java reportdesign/source sc/inc sc/source

[Michael Stahl]

 oox/inc/pch/precompiled_oox.hxx
  |1 
 oox/source/drawingml/diagram/diagram.cxx   
  |5 
 oox/source/drawingml/diagram/diagramlayoutatoms.cxx
  |   23 ---
 reportbuilder/java/org/libreoffice/report/pentaho/OfficeNamespaces.java
  |1 
 
reportbuilder/java/org/libreoffice/report/pentaho/output/OfficeDocumentReportTarget.java
 |1 
 reportdesign/source/core/api/ReportDefinition.cxx  
  |   18 ++
 reportdesign/source/core/inc/ReportComponent.hxx   
  |   65 +-
 reportdesign/source/filter/xml/xmlExport.cxx   
  |7 +
 sc/inc/pch/precompiled_sc.hxx  
  |1 
 sc/inc/pch/precompiled_scfilt.hxx  
  |1 
 sc/source/core/tool/userlist.cxx   
  |5 
 sc/source/filter/excel/excimp8.cxx 
  |2 
 sc/source/filter/lotus/lotattr.cxx 
  |2 
 sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx   
  |1 
 sc/source/ui/sidebar/ScPanelFactory.cxx
  |1 
 sc/source/ui/unoobj/fmtuno.cxx 
  |8 -
 16 files changed, 74 insertions(+), 68 deletions(-)

New commits:
commit 0ab1a87f0dc5b65624dfcf19f59542bab7dfb670
Author: Michael Stahl 
Date:   Wed Feb 3 23:19:40 2016 +0100

reportdesign: reformat that

Change-Id: Iec06e09d0051ab53bbded0759abb041ff764abef

diff --git a/reportdesign/source/core/inc/ReportComponent.hxx 
b/reportdesign/source/core/inc/ReportComponent.hxx
index cfdd64d..b9e4f1d 100644
--- a/reportdesign/source/core/inc/ReportComponent.hxx
+++ b/reportdesign/source/core/inc/ReportComponent.hxx
@@ -37,44 +37,45 @@ namespace reportdesign
 class OReportComponentProperties
 {
 public:
-css::uno::WeakReference< css::container::XChild >  
 m_xParent;
-css::uno::Reference< css::uno::XComponentContext > 
 m_xContext;
-css::uno::Reference< css::lang::XMultiServiceFactory > 
 m_xFactory;
-css::uno::Reference< css::drawing::XShape >
 m_xShape;
-css::uno::Reference< css::uno::XAggregation >  
 m_xProxy;
-css::uno::Reference< css::beans::XPropertySet >
 m_xProperty;
-css::uno::Reference< css::lang::XTypeProvider >
 m_xTypeProvider;
-css::uno::Reference< css::lang::XUnoTunnel >   
 m_xUnoTunnel;
-css::uno::Reference< css::lang::XServiceInfo > 
 m_xServiceInfo;
-css::uno::Sequence< OUString > 
 m_aMasterFields;
-css::uno::Sequence< OUString > 
 m_aDetailFields;
-OUString   
 m_sName;
-::sal_Int32
 m_nHeight;
-::sal_Int32
 m_nWidth;
-::sal_Int32
 m_nPosX;
-::sal_Int32
 m_nPosY;
-::sal_Int32
 m_nBorderColor;
-::sal_Int16
 m_nBorder;
-bool   
 m_bPrintRepeatedValues;
+css::uno::WeakReference m_xParent;
+css::uno::Reference m_xContext;
+css::uno::Reference m_xFactory;
+css::uno::Reference m_xShape;
+css::uno::Reference m_xProxy;
+css::uno::Reference m_xProperty;
+css::uno::Reference m_xTypeProvider;
+css::uno::Reference m_xUnoTunnel;
+css::uno::Reference m_xServiceInfo;
+css::uno::Sequence m_aMasterFields;
+css::uno::Sequence m_aDetailFields;
+OUString m_sName;
+::sal_Int32 m_nHeight;
+::sal_Int32 m_nWidth;
+::sal_Int32 m_nPosX;
+::sal_Int32 m_nPosY;
+::sal_Int32 m_nBorderColor;
+::sal_Int16 m_nBorder;
+bool m_bPrintRepeatedValues;
 
-OReportComponentProperties(css::uno::Reference< 
css::uno::XComponentContext > const & _xContext
-)
-:m_xContext(_xContext)
- 

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 8469343da1004a71669c406ae4facc7e3ec95ed7
Author: Henry Castro 
Date:   Wed Feb 3 18:34:27 2016 -0400

loolwsd: avoid fork a new child when its exit code is not success

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 5776ab9..858009f 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -946,6 +946,7 @@ int main(int argc, char** argv)
 
 Log::info("loolbroker is ready.");
 
+int nChildExitCode = Application::EXIT_OK;
 unsigned timeoutCounter = 0;
 while (!TerminationFlag)
 {
@@ -955,6 +956,7 @@ int main(int argc, char** argv)
 {
 if (WIFEXITED(status))
 {
+nChildExitCode = Util::getChildStatus(WEXITSTATUS(status));
 Log::info() << "Child process [" << pid << "] exited with 
code: "
 << WEXITSTATUS(status) << "." << Log::end;
 
@@ -963,6 +965,7 @@ int main(int argc, char** argv)
 else
 if (WIFSIGNALED(status))
 {
+nChildExitCode = Util::getSignalStatus(WEXITSTATUS(status));
 std::string fate = "died";
 #ifdef WCOREDUMP
 if (WCOREDUMP(status))
@@ -994,6 +997,7 @@ int main(int argc, char** argv)
 }
 
 pipeHandler.syncChilds();
+timeoutCounter = 0;
 }
 else if (pid < 0)
 {
@@ -1006,7 +1010,7 @@ int main(int argc, char** argv)
 }
 }
 
-if (forkCounter > 0)
+if (forkCounter > 0 && nChildExitCode == Application::EXIT_OK)
 {
 std::lock_guard lock(forkMutex);
 
@@ -1032,6 +1036,7 @@ int main(int argc, char** argv)
 if (timeoutCounter++ == INTERVAL_PROBES)
 {
 timeoutCounter = 0;
+nChildExitCode = Application::EXIT_OK;
 sleep(MAINTENANCE_INTERVAL);
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 87743] Pack LibreOffice for PlayOnLinux for QA

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87743

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 CC||philip...@hotmail.com

--- Comment #18 from Yousuf (Jay) Philips  ---
With the 'LibreOffice 5' installation script installing 5.0.4 and 5.1.0 coming
out shortly, would the script be upgraded to 5.1 or would a new 5.1
installation script be done?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp loolwsd/LOOLWSD.cpp loolwsd/Util.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |6 --
 loolwsd/LOOLWSD.cpp|6 --
 loolwsd/Util.cpp   |2 ++
 3 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit 70ff592624f69c9c3804022bd6cb527f3b8022c3
Author: Henry Castro 
Date:   Wed Feb 3 18:08:16 2016 -0400

loolwsd: use strsignal

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index a9af6cd..5776ab9 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -970,7 +970,8 @@ int main(int argc, char** argv)
 #endif
 Log::error() << "Child process [" << pid << "] " << fate
  << " with " << Util::signalName(WTERMSIG(status))
- << " signal. " << Log::end;
+ << " signal: " << strsignal(WTERMSIG(status))
+ << Log::end;
 
 removeChild(pid);
 }
@@ -978,7 +979,8 @@ int main(int argc, char** argv)
 {
 Log::info() << "Child process [" << pid << "] stopped with "
 << Util::signalName(WSTOPSIG(status))
-<< " signal. " << Log::end;
+<< " signal: " << strsignal(WTERMSIG(status))
+<< Log::end;
 }
 else if (WIFCONTINUED(status))
 {
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index f382758..eeb3d2d 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1022,7 +1022,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 #endif
 Log::error() << "Child process [" << pid << "] " << fate
  << " with " << 
Util::signalName(WTERMSIG(status))
- << " signal. " << Log::end;
+ << " signal: " << strsignal(WTERMSIG(status))
+ << Log::end;
 
 break;
 }
@@ -1030,7 +1031,8 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 {
 Log::info() << "Child process [" << pid << "] stopped with 
"
 << Util::signalName(WSTOPSIG(status))
-<< " signal. " << Log::end;
+<< " signal: " << strsignal(WTERMSIG(status))
+<< Log::end;
 }
 else if (WIFCONTINUED(status))
 {
diff --git a/loolwsd/Util.cpp b/loolwsd/Util.cpp
index a764ff4..e4ae391 100644
--- a/loolwsd/Util.cpp
+++ b/loolwsd/Util.cpp
@@ -427,6 +427,7 @@ namespace Util
 TerminationState = ( aSignal == SIGTERM ? LOOLState::LOOL_ABNORMAL 
: LOOLState::LOOL_STOPPING );
 
 Log::info() << "Termination signal received: "
+<< Util::signalName(aSignal) << " "
 << strsignal(aSignal) << Log::end;
 }
 }
@@ -451,6 +452,7 @@ namespace Util
 void handleFatalSignal(const int aSignal)
 {
 Log::error() << "Fatal signal received: "
+ << Util::signalName(aSignal) << " "
  << strsignal(aSignal) << Log::end;
 
 if (getenv("LOOL_DEBUG"))
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp loolwsd/LOOLWSD.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |8 
 loolwsd/LOOLWSD.cpp|8 
 2 files changed, 16 insertions(+)

New commits:
commit 661ae622599e450152d298eb9b114a9ad0dc9175
Author: Henry Castro 
Date:   Wed Feb 3 17:43:04 2016 -0400

loolwsd: exit when error no child process

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 6c3b3f8..a9af6cd 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -994,7 +994,15 @@ int main(int argc, char** argv)
 pipeHandler.syncChilds();
 }
 else if (pid < 0)
+{
 Log::error("Error: waitpid failed.");
+// No child processes
+if (errno == ECHILD)
+{
+TerminationFlag = true;
+continue;
+}
+}
 
 if (forkCounter > 0)
 {
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 35b8cff..f382758 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1049,7 +1049,15 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 }
 }
 else if (pid < 0)
+{
 Log::error("Error: waitpid failed.");
+// No child processes
+if (errno == ECHILD)
+{
+TerminationFlag = true;
+continue;
+}
+}
 
 if (timeoutCounter++ == INTERVAL_PROBES)
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

[Katarina Behrens]

 sc/source/ui/dbgui/PivotLayoutDialog.cxx |   25 ++---
 1 file changed, 14 insertions(+), 11 deletions(-)

New commits:
commit c0fa223db5f5c55ffb76dbb10b0e8187962f0cd8
Author: Katarina Behrens 
Date:   Tue Feb 2 17:35:03 2016 +0100

tdf#97437: Don't crash when creating new pivot table

regression from 0b9dd2446c33fda77 -- *sigh* most of the time is
the old pivot table not there.

Change-Id: I85ea03780f175aa6e4fb6859497b6dda12fa7d11
Reviewed-on: https://gerrit.libreoffice.org/22057
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/sc/source/ui/dbgui/PivotLayoutDialog.cxx 
b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
index f52fe4d..1ed0e93 100644
--- a/sc/source/ui/dbgui/PivotLayoutDialog.cxx
+++ b/sc/source/ui/dbgui/PivotLayoutDialog.cxx
@@ -492,7 +492,6 @@ void ScPivotLayoutDialog::ApplyChanges()
 ApplyLabelData(aSaveData);
 
 ScDPObject *pOldDPObj = mpDocument->GetDPAtCursor( maPivotParameters.nCol, 
maPivotParameters.nRow, maPivotParameters.nTab);
-const ScRange& rOldRange = pOldDPObj->GetOutRange();
 ScRange aDestinationRange;
 bool bToNewSheet = false;
 
@@ -517,17 +516,21 @@ void ScPivotLayoutDialog::ApplyChanges()
 
 if (pItem)
 {
-   // User wants to move existing pivot table to another 
(non-overlapping)
-   // range or to a new sheet
-   // FIXME: if the new range overlaps with the old one, the table 
actually doesn't move
-   // and shouldn't therefore be deleted
-   if ( !rOldRange.In( aDestinationRange )
-|| (bToNewSheet && !mbNewPivotTable) )
+   // existing pivot table might have moved to a new range or a new 
sheet
+   if ( pOldDPObj != nullptr  )
{
-   ScDPObject *pDPObj = mpDocument->GetDPAtCursor( 
maPivotParameters.nCol, maPivotParameters.nRow, maPivotParameters.nTab);
-   ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
-   aFunc.RemovePivotTable( *pDPObj, true, false);
-   mpViewData->GetView()->CursorPosChanged();
+   const ScRange& rOldRange = pOldDPObj->GetOutRange();
+
+   // FIXME: if the new range overlaps with the old one, the table 
actually doesn't move
+   // and shouldn't therefore be deleted
+   if ( ( ( rOldRange != aDestinationRange ) && !rOldRange.In( 
aDestinationRange ) )
+|| bToNewSheet )
+   {
+   ScDPObject *pDPObj = mpDocument->GetDPAtCursor( 
maPivotParameters.nCol, maPivotParameters.nRow, maPivotParameters.nTab);
+   ScDBDocFunc aFunc( *(mpViewData->GetDocShell() ));
+   aFunc.RemovePivotTable( *pDPObj, true, false);
+   mpViewData->GetView()->CursorPosChanged();
+   }
}
return;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |   46 +++---
 1 file changed, 23 insertions(+), 23 deletions(-)

New commits:
commit b7ee46f729e102c9a09070c75f9385c942aa96b7
Author: Henry Castro 
Date:   Wed Feb 3 17:35:35 2016 -0400

loolwsd: child exit codes are required before fork new lokit process

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index df278a5..6c3b3f8 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -949,29 +949,6 @@ int main(int argc, char** argv)
 unsigned timeoutCounter = 0;
 while (!TerminationFlag)
 {
-if (forkCounter > 0)
-{
-std::lock_guard lock(forkMutex);
-
-const signed empty = pipeHandler.syncChilds();
-const signed total = _childProcesses.size();
-
-// Figure out how many children we need. Always create at least as 
many
-// as configured pre-spawn or one more than requested (whichever 
is larger).
-signed spawn = std::max(static_cast(forkCounter) + 1, 
numPreSpawnedChildren);
-Log::debug() << "Creating " << spawn << " childs. Current Total: "
- << total << ", Empty: " << empty << Log::end;
-do
-{
-if (createLibreOfficeKit(sharePages, loSubPath, jailId) < 0)
-Log::error("Error: fork failed.");
-}
-while (--spawn > 0);
-
-// We've done our best. If need more, retrying will bump the 
counter.
-forkCounter = 0;
-}
-
 int status;
 const pid_t pid = waitpid(-1, &status, WUNTRACED | WNOHANG);
 if (pid > 0)
@@ -1019,6 +996,29 @@ int main(int argc, char** argv)
 else if (pid < 0)
 Log::error("Error: waitpid failed.");
 
+if (forkCounter > 0)
+{
+std::lock_guard lock(forkMutex);
+
+const signed empty = pipeHandler.syncChilds();
+const signed total = _childProcesses.size();
+
+// Figure out how many children we need. Always create at least as 
many
+// as configured pre-spawn or one more than requested (whichever 
is larger).
+signed spawn = std::max(static_cast(forkCounter) + 1, 
numPreSpawnedChildren);
+Log::debug() << "Creating " << spawn << " childs. Current Total: "
+ << total << ", Empty: " << empty << Log::end;
+do
+{
+if (createLibreOfficeKit(sharePages, loSubPath, jailId) < 0)
+Log::error("Error: fork failed.");
+}
+while (--spawn > 0);
+
+// We've done our best. If need more, retrying will bump the 
counter.
+forkCounter = 0;
+}
+
 if (timeoutCounter++ == INTERVAL_PROBES)
 {
 timeoutCounter = 0;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

New commits:
commit 1fc3d06e378bc97edb15673ffbcb11124b2f28de
Author: Henry Castro 
Date:   Wed Feb 3 17:15:20 2016 -0400

loolwsd: fix iterator erase

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index 181c52c..df278a5 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -374,12 +374,13 @@ public:
 log << "Error querying child [" << 
std::to_string(it->second->getPid()) << "].";
 if (it->second->getUrl().empty())
 {
-log << " Removing empty child.";
+log << " Removing empty child." << Log::end;
 it = _childProcesses.erase(it);
 }
-
-log << Log::end;
-++it;
+else
+{
+++it;
+}
 continue;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |   25 -
 1 file changed, 20 insertions(+), 5 deletions(-)

New commits:
commit 3cda7993289b3b97e5ea5714e6ff16f5c892f8b5
Author: Henry Castro 
Date:   Wed Feb 3 17:07:36 2016 -0400

loolwsd: avoid the loolbroker block forever before lokit launch

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index d824eb7..181c52c 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -898,12 +898,32 @@ int main(int argc, char** argv)
 dropCapability();
 #endif
 
+int nFlags = O_RDONLY | O_NONBLOCK;
 if (mkfifo(FIFO_BROKER.c_str(), 0666) == -1)
 {
 Log::error("Error: Failed to create pipe FIFO [" + FIFO_BROKER + "].");
 exit(Application::EXIT_SOFTWARE);
 }
 
+if ((readerChild = open(FIFO_BROKER.c_str(), nFlags) ) < 0)
+{
+Log::error("Error: pipe opened for reading.");
+exit(Application::EXIT_SOFTWARE);
+}
+
+if ((nFlags = fcntl(readerChild, F_GETFL, 0)) < 0)
+{
+Log::error("Error: failed to get pipe flags [" + FIFO_BROKER + "].");
+exit(Application::EXIT_SOFTWARE);
+}
+
+nFlags &= ~O_NONBLOCK;
+if (fcntl(readerChild, F_SETFL, nFlags) < 0)
+{
+Log::error("Error: failed to set pipe flags [" + FIFO_BROKER + "].");
+exit(Application::EXIT_SOFTWARE);
+}
+
 // Initialize LoKit and hope we can fork and save memory by sharing pages.
 const bool sharePages = globalPreinit(loSubPath);
 
@@ -917,11 +937,6 @@ int main(int argc, char** argv)
 if (numPreSpawnedChildren > 1)
 forkCounter = numPreSpawnedChildren - 1;
 
-if ( (readerChild = open(FIFO_BROKER.c_str(), O_RDONLY) ) < 0 )
-{
-Log::error("Error: pipe opened for reading.");
-exit(Application::EXIT_SOFTWARE);
-}
 
 PipeRunnable pipeHandler;
 Poco::Thread aPipe;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLBroker.cpp

[Henry Castro]

 loolwsd/LOOLBroker.cpp |   45 -
 1 file changed, 44 insertions(+), 1 deletion(-)

New commits:
commit 58fa747bb421bdca9e431185b59dca916a6a3305
Author: Henry Castro 
Date:   Wed Feb 3 16:59:09 2016 -0400

loolwsd: avoid a broken lokit process block the loolbroker forever

diff --git a/loolwsd/LOOLBroker.cpp b/loolwsd/LOOLBroker.cpp
index aa9d07a..d824eb7 100644
--- a/loolwsd/LOOLBroker.cpp
+++ b/loolwsd/LOOLBroker.cpp
@@ -574,6 +574,7 @@ static int createLibreOfficeKit(const bool sharePages,
 {
 Poco::UInt64 childPID;
 int nFIFOWriter = -1;
+int nFlags = O_WRONLY | O_NONBLOCK;
 
 const std::string pipe = BROKER_PREFIX + std::to_string(childCounter++) + 
BROKER_SUFIX;
 
@@ -625,13 +626,55 @@ static int createLibreOfficeKit(const bool sharePages,
 }
 }
 
-if ( (nFIFOWriter = open(pipe.c_str(), O_WRONLY)) < 0 )
+// open non-blocking to make sure that a broken lokit process will not
+// block the loolbroker forever
+{
+short nRetries = 5;
+std::mutex aFIFOMutex;
+std::condition_variable aFIFOCV;
+std::unique_lock lock(aFIFOMutex);
+
+while(nRetries && nFIFOWriter < 0)
+{
+aFIFOCV.wait_for(
+lock,
+std::chrono::microseconds(8),
+[&nFIFOWriter, &pipe, nFlags]
+{
+return (nFIFOWriter = open(pipe.c_str(), nFlags)) > 0;
+});
+
+if (nFIFOWriter < 0)
+{
+Log::debug("Retrying to establish pipe connection: " + 
std::to_string(nRetries));
+}
+
+--nRetries;
+}
+}
+
+if (nFIFOWriter < 0)
 {
 Log::error("Error: failed to open write pipe [" + pipe + "] with kit. 
Abandoning child.");
 ChildProcess(childPID, -1, -1);
 return -1;
 }
 
+if ((nFlags = fcntl(nFIFOWriter, F_GETFL, 0)) < 0)
+{
+Log::error("Error: failed to get pipe flags [" + pipe + "].");
+ChildProcess(childPID, -1, -1);
+return -1;
+}
+
+nFlags &= ~O_NONBLOCK;
+if (fcntl(nFIFOWriter, F_SETFL, nFlags) < 0)
+{
+Log::error("Error: failed to set pipe flags [" + pipe + "].");
+ChildProcess(childPID, -1, -1);
+return -1;
+}
+
 Log::info() << "Adding Kit #" << childCounter << ", PID: " << childPID << 
Log::end;
 
 _childProcesses[childPID] = std::make_shared(childPID, -1, 
nFIFOWriter);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Maya Rashish license statement

[coypu]

All of my past & future contributions to LibreOffice may be
licensed under the MPLv2/LGPLv3+ dual license.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 90290] reduce some copy&paste code in ucalc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90290

--- Comment #20 from Commit Notification 
 ---
Markus Mohrhard committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=aaa7b7c87dc0d685e2a0edf2763aaeacd2d6e579

tdf#90290, add custom asserter for formula

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 90290] reduce some copy&paste code in ucalc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90290

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/qa

[Markus Mohrhard]

 sc/qa/unit/helper/qahelper.cxx |   29 +
 sc/qa/unit/helper/qahelper.hxx |8 
 sc/qa/unit/ucalc_formula.cxx   |3 +--
 3 files changed, 38 insertions(+), 2 deletions(-)

New commits:
commit aaa7b7c87dc0d685e2a0edf2763aaeacd2d6e579
Author: Markus Mohrhard 
Date:   Wed Feb 3 14:59:47 2016 +0100

tdf#90290, add custom asserter for formula

Change-Id: Id584b9ba5955e56f9ee0dacb2534b7365cdce380
Reviewed-on: https://gerrit.libreoffice.org/22080
Reviewed-by: Markus Mohrhard 
Tested-by: Markus Mohrhard 

diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index 1e34890..cd9aae6 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -19,6 +19,9 @@
 #include 
 #include 
 
+#include 
+#include 
+
 #include 
 
 #if ENABLE_ORCUS
@@ -734,4 +737,30 @@ void ScBootstrapFixture::miscRowHeightsTest( TestParam* 
aTestValues, unsigned in
 }
 }
 
+namespace {
+
+std::string to_std_string(const OUString& rStr)
+{
+return std::string(rStr.toUtf8().getStr());
+}
+
+}
+
+void checkFormula(ScDocument& rDoc, const ScAddress& rPos, const char* 
expected, const char* msg, CppUnit::SourceLine sourceLine)
+{
+ScTokenArray* pCode = getTokens(rDoc, rPos);
+if (!pCode)
+{
+CppUnit::Asserter::fail("empty token array", sourceLine);
+}
+
+OUString aFormula = toString(rDoc, rPos, *pCode, rDoc.GetGrammar());
+OUString aExpectedFormula = OUString::createFromAscii(expected);
+if (aFormula != aExpectedFormula)
+{
+CppUnit::Asserter::failNotEqual(to_std_string(aExpectedFormula),
+to_std_string(aFormula), sourceLine, 
CppUnit::AdditionalMessage(msg));
+}
+}
+
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index cce409c..083e2d1 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -15,6 +15,8 @@
 #include "docsh.hxx"
 #include "address.hxx"
 
+#include 
+
 #include 
 #include 
 
@@ -244,6 +246,12 @@ public:
 #define ASSERT_EQUAL_TYPE( type, expected, result ) \
 CPPUNIT_ASSERT_EQUAL( static_cast(expected), 
static_cast(result) );
 
+SCQAHELPER_DLLPUBLIC void checkFormula(ScDocument& rDoc, const ScAddress& rPos,
+const char* expected, const char* msg, CppUnit::SourceLine sourceLine);
+
+#define ASSERT_FORMULA_EQUAL(doc, pos, expected, msg) \
+checkFormula(doc, pos, expected, msg, CPPUNIT_SOURCELINE())
+
 SCQAHELPER_DLLPUBLIC void testFormats(ScBootstrapFixture* pTest, ScDocument* 
pDoc, sal_Int32 nFormat);
 
 #endif
diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index 4b41261..d8ba5ce 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -1295,8 +1295,7 @@ void Test::testFormulaRefUpdateRange()
 m_pDoc->SetString(ScAddress(0,6,0), "=SUM(B2:C5)");
 m_pDoc->SetString(ScAddress(0,7,0), "=SUM($B$2:$C$5)");
 
-if (!checkFormula(*m_pDoc, ScAddress(0,6,0), "SUM(B2:C5)"))
-CPPUNIT_FAIL("Wrong formula in A7.");
+ASSERT_FORMULA_EQUAL(*m_pDoc, ScAddress(0,6,0), "SUM(B2:C5)", "Wrong 
formula in A7.");
 
 if (!checkFormula(*m_pDoc, ScAddress(0,7,0), "SUM($B$2:$C$5)"))
 CPPUNIT_FAIL("Wrong formula in A8.");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 51358] SVG: Add support for more slide transitions to svg documents exported by Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51358

--- Comment #6 from Marco Cecchetti  ---

Oh well, indeed I don't remember the reason for opening 2 bugs. Maybe because
of some different referenced file.

When one implements a new transition effect by following the illustrated steps,
he *should* get the new effect working for both shapes and slides. However some
small differences could still occur.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/firebird

[Lionel Elie Mamane]

 external/firebird/ExternalProject_firebird.mk |   10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

New commits:
commit 1487b9ddc80ff0e5449fc6e26f7529ed293eed89
Author: Lionel Elie Mamane 
Date:   Tue Feb 2 16:49:54 2016 +0100

better integrate parallelisation of firebird builds

Change-Id: If9bf9d2a36aa564700b032c417869a8cfac65f88

diff --git a/external/firebird/ExternalProject_firebird.mk 
b/external/firebird/ExternalProject_firebird.mk
index 939b29d..0e80811 100644
--- a/external/firebird/ExternalProject_firebird.mk
+++ b/external/firebird/ExternalProject_firebird.mk
@@ -21,8 +21,6 @@ $(eval $(call gb_ExternalProject_register_targets,firebird,\
build \
 ))
 
-FB_PRLL_ARG:=$(shell if [ "0$(PARALLELISM)" -gt 0 ]; then echo 
"CPU=$(PARALLELISM)"; fi)
-
 # note: this can intentionally only build against internal atomic_op
 # note: this can intentionally only build against internal tommath
 
@@ -30,6 +28,12 @@ FB_PRLL_ARG:=$(shell if [ "0$(PARALLELISM)" -gt 0 ]; then 
echo "CPU=$(PARALLELIS
 $(call gb_ExternalProject_get_state_target,firebird,build):
$(call gb_ExternalProject_run,build,\
unset MAKEFLAGS \
+   && FB_CPU_ARG='$(filter --jobserver-fds=%,$(MAKEFLAGS))' \
+   && if [ -n "$${FB_CPU_ARG}" ]; then \
+ FB_PRLL_ARG="CPU=\$$(EMPTY) $${FB_CPU_ARG}"; \
+   else \
+ FB_PRLL_ARG="-m"; \
+   fi \
&& export PKG_CONFIG="" \
&& export CPPFLAGS=" \
$(if $(SYSTEM_LIBATOMIC_OPS),$(LIBATOMIC_OPS_CFLAGS), \
@@ -62,7 +66,7 @@ $(call gb_ExternalProject_get_state_target,firebird,build):
&& $(if $(filter WNT,$(OS)),\
   PATH="$(shell cygpath -u $(call 
gb_UnpackedTarball_get_dir,icu)/source/lib):$$PATH",\
   $(gb_Helper_set_ld_path)) \
-  $(MAKE) $(FB_PRLL_ARG) SHELL=$(SHELL) firebird_embedded \
+  $(MAKE) "$${FB_PRLL_ARG}" SHELL='$(SHELL)' firebird_embedded 
\
$(if $(filter MACOSX,$(OS)),&& $(PERL) \
$(SRCDIR)/solenv/bin/macosx-change-install-names.pl shl 
OOO \

$(gb_Package_SOURCEDIR_firebird)/gen/firebird/lib/libfbembed.dylib.2.5.5) \
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: starmath/source

[Takeshi Abe]

 starmath/source/view.cxx |   21 +++--
 1 file changed, 11 insertions(+), 10 deletions(-)

New commits:
commit 1e4ac9a98a919bd8c0f2526f68b5c089ec89b93b
Author: Takeshi Abe 
Date:   Wed Feb 3 17:39:29 2016 +0900

starmath: Avoid C-style cast

Change-Id: I1599c7d62f9b5ff43eecf9f11bbb173c4faeeb15
Reviewed-on: https://gerrit.libreoffice.org/22067
Tested-by: Jenkins 
Reviewed-by: Björn Michaelsen 

diff --git a/starmath/source/view.cxx b/starmath/source/view.cxx
index 416d415..547acf7 100644
--- a/starmath/source/view.cxx
+++ b/starmath/source/view.cxx
@@ -77,8 +77,8 @@
 #include "ElementsDockingWindow.hxx"
 #include 
 
-#define MINZOOM 25
-#define MAXZOOM 800
+#define MINZOOM sal_uInt16(25)
+#define MAXZOOM sal_uInt16(800)
 
 // space around the edit window, in pixels
 // fdo#69111: Increased border on the top so that the window is
@@ -601,7 +601,7 @@ void SmGraphicWindow::Command(const CommandEvent& rCEvt)
 
 void SmGraphicWindow::SetZoom(sal_uInt16 Factor)
 {
-nZoom = std::min(std::max((sal_uInt16) Factor, (sal_uInt16) MINZOOM), 
(sal_uInt16) MAXZOOM);
+nZoom = std::min(std::max(Factor, MINZOOM), MAXZOOM);
 Fraction   aFraction (nZoom, 100);
 SetMapMode( MapMode(MAP_100TH_MM, Point(), aFraction, aFraction) );
 SetTotalSize();
@@ -954,7 +954,7 @@ void SmViewShell::QueryObjAreaPixel( Rectangle& rRect ) 
const
 void SmViewShell::SetZoomFactor( const Fraction &rX, const Fraction &rY )
 {
 const Fraction &rFrac = rX < rY ? rX : rY;
-GetGraphicWindow().SetZoom( (sal_uInt16) long(rFrac * Fraction( 100, 1 )) 
);
+GetGraphicWindow().SetZoom(sal::static_int_cast(long(rFrac * 
Fraction( 100, 1 ;
 
 //To avoid rounding errors base class regulates crooked values too
 //if necessary
@@ -1238,9 +1238,10 @@ void SmViewShell::Impl_Print(OutputDevice &rOutDev, 
const SmPrintUIOptions &rPri
 Size OutputSize 
(rOutDev.LogicToPixel(Size(aOutRect.GetWidth(),
 
aOutRect.GetHeight()), MapMode(MAP_100TH_MM)));
 Size GraphicSize (rOutDev.LogicToPixel(aSize, 
MapMode(MAP_100TH_MM)));
-sal_uInt16   nZ = (sal_uInt16) 
std::min((long)Fraction(OutputSize.Width()  * 100L, GraphicSize.Width()),
-  
(long)Fraction(OutputSize.Height() * 100L, GraphicSize.Height()));
-Fraction aFraction ((sal_uInt16) std::max ((sal_uInt16) 
MINZOOM, std::min((sal_uInt16) MAXZOOM, (sal_uInt16) (nZ - 10))), (sal_uInt16) 
100);
+sal_uInt16 nZ = 
sal::static_int_cast(std::min(long(Fraction(OutputSize.Width()  * 
100L, GraphicSize.Width())),
+  
long(Fraction(OutputSize.Height() * 100L, GraphicSize.Height();
+nZ -= 10;
+Fraction aFraction (std::max(MINZOOM, std::min(MAXZOOM, nZ)), 
100);
 
 OutputMapMode = MapMode(MAP_100TH_MM, aZeroPoint, aFraction, 
aFraction);
 }
@@ -1780,7 +1781,7 @@ void SmViewShell::Execute(SfxRequest& rReq)
 switch( rZoom.GetType() )
 {
 case SvxZoomType::PERCENT:
-aGraphic->SetZoom((sal_uInt16)rZoom.GetValue ());
+
aGraphic->SetZoom(sal::static_int_cast(rZoom.GetValue ()));
 break;
 
 case SvxZoomType::OPTIMAL:
@@ -1797,8 +1798,8 @@ void SmViewShell::Execute(SfxRequest& rReq)
 Size   
OutputSize(pPrinter->LogicToPixel(Size(OutputRect.GetWidth(),
   
OutputRect.GetHeight()), aMap));
 Size   
GraphicSize(pPrinter->LogicToPixel(GetDoc()->GetSize(), aMap));
-sal_uInt16 nZ = (sal_uInt16) 
std::min((long)Fraction(OutputSize.Width()  * 100L, GraphicSize.Width()),
- 
(long)Fraction(OutputSize.Height() * 100L, GraphicSize.Height()));
+sal_uInt16 nZ = 
sal::static_int_cast(std::min(long(Fraction(OutputSize.Width()  * 
100L, GraphicSize.Width())),
+   
   long(Fraction(OutputSize.Height() * 100L, GraphicSize.Height();
 aGraphic->SetZoom (nZ);
 break;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 51358] SVG: Add support for more slide transitions to svg documents exported by Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51358

Björn Michaelsen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=51
   ||357

--- Comment #5 from Björn Michaelsen  ---
Possible dupes? Please clarify bug 51358 vs. 51357.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 51357] SVG: Add support for more shape transition effects to svg documents exported by Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=51357

Björn Michaelsen  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=51
   ||358

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Avoid opening the Spreadsheet file when use OpenOffice UNO API to load it

[Oliver Brinzing]

Hi William,


If execute the next line, the related file will be opened automatically,
but we do not want to open it. What we want is change value for some cells and 
work as background.


do you want to load the file "hidden"?
something like this should work:

PropertyValue[] mProps = new PropertyValue[1];
mProps[0] = new PropertyValue();

mProps[0].Name = "Hidden";
mProps[0].Value = new Boolean(true);

XComponent component = loader.loadComponentFromURL(url, "_default", 0, mProps);

Regards
Oliver


Am 02.02.2016 um 10:48 schrieb Zhang, William:

Hi Team members,

Does anyone know how to do it as the subject describes?  Thanks a lot!

LibreOffice version: 4.1.4.2
OS:RedHat7
Java1.7

My code is as follow:
XComponentContext xContext = OOoConnector.bootstrap(ooExeFolder);
XMultiComponentFactory xMCF = xContext.getServiceManager();
Object desktop = xMCF.createInstanceWithContext("com.sun.star.frame.Desktop", 
xContext);
XComponentLoader loader = 
(XComponentLoader)UnoRuntime.queryInterface(XComponentLoader.class, desktop);
String url = "file://" + targetFile;
// If execute the next line, the related file will be opened automatically, but 
we do not want to open it. What we want is change value for some cells and work 
as background.
XComponent component = loader.loadComponentFromURL(url, "_default", 0, new 
PropertyValue[0]);
 ……

The default options for the ‘soffice’ command is as follow.
ArrayList options = new ArrayList();
options.add("--nologo");
options.add("--nodefault");
options.add("--norestore");
options.add("--nocrashreport");
options.add("--nolockcheck");
…….

Anyone who knows the solution is much appreciated!

Best Regards
William
From: Zhang, William
Sent: 2015年12月25日 13:08
To: 'libreoffice@lists.freedesktop.org'
Subject: How to decrypt ods file

Hi Team members,

Does anyone know how to decrypt an encrypted Libreoffice Calc file with Java or 
other languages? Or even some workarounds. Thanks a lot!

LibreOffice version: 4.1.4.2

What I’ve tried.

1.   Try some common decrypt API such as javax.crypto.Cipher, failed.

2.   Change the ‘ods’ extension to ‘zip’, unzip it and try to parse file to 
get the content, failed.

Then try to get xml content with Java IO, failed.
……

Best Regards
William



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice





___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 89290] HTML export: replace tabulator characters with double spaces or ellipses (three dot leader) in Table of Contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89290

--- Comment #7 from jan iversen  ---
To me, that sound very much like the right track.

If you also take a lot at
https://wiki.documentfoundation.org/Development/GetInvolved/DeveloperStepByStep

Then it is just happy hacking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 38835] strip out non-trivial globals before main

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=38835

--- Comment #22 from Stephan Bergmann  ---
(In reply to Björn Michaelsen from comment #21)
> Note that constants (currently either #defines or "static const ..." can --
> with C++11 -- be turned into constexprs:
> 
>  http://en.cppreference.com/w/cpp/language/constexpr
> 
> which should be generally preferable.

...but isn't available in MSVC 2013 (and reportedly only partially in MSVC
2015, aka MSVC 14, ). 
That's why SAL_CONSTEXPR (include/sal/types.h), and can only use it in ways
that do not /require/ it to expand to "constexpr".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 89290] HTML export: replace tabulator characters with double spaces or ellipses (three dot leader) in Table of Contents

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89290

--- Comment #6 from Martin Nathansen  ---
I would like to take this Easy Hack and have a few questions:

I tested the HTML export with two different *.odt documents and found that the
HTML output for the “Table of contents” depends on how the document was
originally created:

1) When the document was created with OpenOffice 4.2 the HTML export of
LibreOffice 5.2 for the “Table of Contents” looks like expected (ugly
formatted, but without missing anything):

Table of Contents
Heading1  1
Heading2  1
  Heading21  1
  Heading22  2


2) When the document was created with LibreOffice 5.2 the HTML is exported
without page numbers:

Table of Contents
Heading1
Heading2
  Heading21
  Heading22

There are also differences in the generated HTML Source:
In 1)  HTML paragraphs  are used and 
in 2)  it is a HTML table ..  ... …..

So the missing page numbers of 2) needs to be fixed as well?
Probably the “Table of Content” is not detected in the right way?


3) I also tested the HTML export when using the “Save as” dialog. This was
working with all documents without any problems:

Table of Contents
Heading1...1
Heading2...1
  Heading211
  Heading222

Here for the formatting HTML Spans are added for the Headings and for the page
numbers respectively:
Heading11

Now from my understanding there are two tasks to be done:
1. Fix the missing page numbers bug
2. Implement a better “Table of Content” formatting for the “Export” dialog,
therefore parts of the “Save as” HTML export might be reused.

Am I on the right track?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: xmlsecurity/source

[Miklos Vajna]

 xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx |   18 
+-
 1 file changed, 17 insertions(+), 1 deletion(-)

New commits:
commit 9c3ddf43bfaff9e21a52001a333e87fad397d465
Author: Miklos Vajna 
Date:   Wed Feb 3 18:04:12 2016 +0100

xmlsecurity: validate OOXML  references on Windows

This is the mscrypto equivalent of what was done in commit
e6aaf64cfc378d0daa0709c40c85ee1e9c0fd151 (xmlsecurity: validate OOXML
 references, 2016-02-01) for NSS.

Change-Id: I7ee713fb5c7b55ded38100a0f25f718f2f323e08

diff --git a/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx 
b/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
index 98ba662..84fb6d2 100644
--- a/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
+++ b/xmlsecurity/source/xmlsec/mscrypt/xmlsignature_mscryptimpl.cxx
@@ -224,7 +224,23 @@ SAL_CALL XMLSignature_MSCryptImpl::validate(
 //error recorder feature to get the ONE error that made the verification 
fail, because there is no
 //documentation/specification as to how to interpret the number of 
recorded errors and what is the initial
 //error.
-if( xmlSecDSigCtxVerify( pDsigCtx , pNode ) == 0 )
+int rs = xmlSecDSigCtxVerify(pDsigCtx , pNode);
+
+// Also verify manifest: this is empty for ODF, but contains everything 
(except signature metadata) for OOXML.
+xmlSecSize nReferenceCount = 
xmlSecPtrListGetSize(&pDsigCtx->manifestReferences);
+// Require that all manifest references are also good.
+xmlSecSize nReferenceGood = 0;
+for (xmlSecSize nReference = 0; nReference < nReferenceCount; ++nReference)
+{
+xmlSecDSigReferenceCtxPtr pReference = 
static_cast(xmlSecPtrListGetItem(&pDsigCtx->manifestReferences,
 nReference));
+if (pReference)
+{
+ if (pReference->status == xmlSecDSigStatusSucceeded)
+ ++nReferenceGood;
+}
+}
+
+if (rs == 0 && nReferenceCount == nReferenceGood)
 {
 if (pDsigCtx->status == xmlSecDSigStatusSucceeded)
 
aTemplate->setStatus(com::sun::star::xml::crypto::SecurityOperationStatus_OPERATION_SUCCEEDED);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Avoid opening the Spreadsheet file when use OpenOffice UNO API to load it

[Zhang, William]

Hi Team members,

Does anyone know how to do it as the subject describes?  Thanks a lot!

LibreOffice version: 4.1.4.2
OS:RedHat7
Java1.7

My code is as follow:
XComponentContext xContext = OOoConnector.bootstrap(ooExeFolder);
XMultiComponentFactory xMCF = xContext.getServiceManager();
Object desktop = xMCF.createInstanceWithContext("com.sun.star.frame.Desktop", 
xContext);
XComponentLoader loader = 
(XComponentLoader)UnoRuntime.queryInterface(XComponentLoader.class, desktop);
String url = "file://" + targetFile;
// If execute the next line, the related file will be opened automatically, but 
we do not want to open it. What we want is change value for some cells and work 
as background.
XComponent component = loader.loadComponentFromURL(url, "_default", 0, new 
PropertyValue[0]);
……

The default options for the ‘soffice’ command is as follow.
ArrayList options = new ArrayList();
options.add("--nologo");
options.add("--nodefault");
options.add("--norestore");
options.add("--nocrashreport");
options.add("--nolockcheck");
…….

Anyone who knows the solution is much appreciated!

Best Regards
William
From: Zhang, William
Sent: 2015年12月25日 13:08
To: 'libreoffice@lists.freedesktop.org'
Subject: How to decrypt ods file

Hi Team members,

Does anyone know how to decrypt an encrypted Libreoffice Calc file with Java or 
other languages? Or even some workarounds. Thanks a lot!

LibreOffice version: 4.1.4.2

What I’ve tried.

1.   Try some common decrypt API such as javax.crypto.Cipher, failed.

2.   Change the ‘ods’ extension to ‘zip’, unzip it and try to parse file to 
get the content, failed.

Then try to get xml content with Java IO, failed.
……

Best Regards
William

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

RE: mdds code examples

[nicholas ferguson]

>FYI, I've added some code examples for mdds::multi_type_vector
>
>http://kohei.us/files/mdds/doc/multi_type_vector.html#example
>
>which hopefully some people find useful.  I'm planning to add more code 
>examples for multi_type_vector as well as other data >structures in mdds, but 
>I'd like to see if there are any specific use cases for which people want to 
>see some code examples.
>
>I'd like to hear from you if that's the case.

multi indexing.


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - vcl/source

[Caolán McNamara]

 vcl/source/gdi/pdfwriter_impl.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit ad116f4d0048473887708900af41c7b15afb16b5
Author: Caolán McNamara 
Date:   Wed Feb 3 12:36:09 2016 +

Resolves: tdf#96653 distorted images on export to pdf

regression from:

commit ffe150ce903d9cdc62c25ad3437e61d24ede17d6
Date:   Fri Dec 4 18:19:08 2015 +0100

tdf#94739 use GetScanlineSize instead of calculating it

which was on the right track in the sense that the original
code was wrong and only worked for <= 8 bit depth images

Change-Id: Iee54a9f29dd0fdaf3e1f2aeb7b9898cecb453e37
(cherry picked from commit 384c815eda697d75706f686dc2ceb227b4d3f245)

diff --git a/vcl/source/gdi/pdfwriter_impl.cxx 
b/vcl/source/gdi/pdfwriter_impl.cxx
index e509b1a..f2974a2 100644
--- a/vcl/source/gdi/pdfwriter_impl.cxx
+++ b/vcl/source/gdi/pdfwriter_impl.cxx
@@ -11426,7 +11426,8 @@ bool PDFWriterImpl::writeBitmapObject( BitmapEmit& 
rObject, bool bMask )
 beginCompression();
 if( ! bTrueColor || pAccess->GetScanlineFormat() == 
BMP_FORMAT_24BIT_TC_RGB )
 {
-const int nScanLineBytes = pAccess->GetScanlineSize();
+//With PDF bitmaps, each row is padded to a BYTE boundary 
(multiple of 8 bits).
+const int nScanLineBytes = ((pAccess->GetBitCount() * 
pAccess->Width()) + 7U) / 8U;
 
 for( int i = 0; i < pAccess->Height(); i++ )
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: DPI and screen resolution on OS X

[SOS]

hallo Armin
new comments inline on your remarks
On 3/02/2016 14:10, Armin Le Grand wrote:

Hi,

comments inline

Am 03.02.2016 um 12:35 schrieb SOS:


On 3/02/2016 11:32, Chris Sherlock wrote:

On 3 Feb 2016, at 7:24 PM, SOS  wrote:


On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask). So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which 
worked
just fine because the monitors used back in the day had the same 
screen

resolution.
Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about 
the needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is 
a definition used by output devices. Screens need a PIXEL par DOT 
but for print devices there is no precise correlation between the 
number of dots used by the device and the pixels needed in  the 
image for having a maximum image-view quality.

The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)
Definitely true :-) Only in OS X’s case, it doesn’t actually report 
back the correct resolution unless you ask for the backing 
coordinate system.


The PPI business is a red herring I think I’ve introduced into this 
discussion I’m afraid. We calculate the PPI ourselves (and call it 
DPI) based on the reported pixels, and the size of the screen in mm 
(which we obviously convert to inches).
its a bit the wrong discussion: what we see on screen has no 
relevance: the user can "zoom" the document until he is happy with 
the image quality on screen
But in the current situation, LO users has no idea how big (size) he 
can place a image in a document.
When the doc is intented for online use (email and Web) then there is 
a minimum of 96 pixels par inch needed. More is no problem but is in 
many cases a overkill.
Who is editing a "book" or a "magazine" need minimal 254 pixels par 
inch to has a good image quality after printing.
When using less pixels the book pages  are looking fine on screen put 
shall have a creepy print quality
So having a new "DocumentProperty" indicating the needed pixels (for 
printing)  make it possible to make the "size" calculations before 
inserting.


It is relevant. If you have a vector graphic and it gets converted to 
bitmap, the DPI from the system is used to define the resulting pixel 
size. Conversion to bitmap happens more often than it might seem. 
Examples:

- user chooses to do so (context menu, convert to bitmap)
- some exporters who are not capable using vector graphics
- PDF, e.g. PDF/1A which is not allowed to use transprencies and 
solves by creating bitmaps where graphics and transparent parts overlap

- 3D renderer which targets to bitmaps (chart, 3D objects)
Thus, the system DPI is essential. If on Mac, the bigger DPI will be 
used, it will enlarge all these conversions.

Thats the problem withn this "system DPI"
for screen viewing is 96 DPI OK  but far to less when the document needs 
to be printed
we need a replacement for the system DPI who is a value who must can 
differ par document


HTH!



I guess I’m curious as to what is relying on the screen resolution 
and PPI.


Although… it’s funny that we have the function 
SalGraphics::GetResolution, but that returns the PPI!


Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Apple Numbers application and format.

[Tor Lillqvist]

> Seems we already support numbers:
>

Yes, for import only (and only to some extent), I assumed you knew that;)

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sd/qa svx/source

[Xisco Fauli]

 sd/qa/unit/import-tests.cxx|3 +--
 svx/source/table/cell.cxx  |2 +-
 svx/source/table/tablelayouter.cxx |   12 +++-
 3 files changed, 13 insertions(+), 4 deletions(-)

New commits:
commit f0649d4a752a1fbdf69c38740ac05c5219609f49
Author: Xisco Fauli 
Date:   Thu Jan 21 20:56:31 2016 +0100

tdf#91762: Check wether the row and the cell have text...

... in order to set the row's min height

Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c
After this commit, the row's min height was set based only on
the cells containing text in the row, but the problem appeared
when the row didn't have any cell with text.
Change logic to check wether there's text in the cell and in the row.

Now, height in SdImportTest::testRowHeight() is 507 instead of
508 but I can't figure it out why. However, I believe there's
no harm in change the test from 508 to 507 as, visually speaking,
the difference can't be distinguish.

Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce
Reviewed-on: https://gerrit.libreoffice.org/21692
Tested-by: Jenkins 
Reviewed-by: jan iversen 
(cherry picked from commit 13d4398820ded5914f635757865e258db2db2b57)
Reviewed-on: https://gerrit.libreoffice.org/22008
Reviewed-by: Katarina Behrens 

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 3fb64ff..42a9866 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1093,9 +1093,8 @@ void SdImportTest::testRowHeight()
 uno::Reference< css::table::XTableRows > xRows( xTable->getRows(), 
uno::UNO_QUERY_THROW);
 uno::Reference< beans::XPropertySet > xRefRow( xRows->getByIndex(0), 
uno::UNO_QUERY_THROW );
 xRefRow->getPropertyValue( sHeight ) >>= nHeight;
-CPPUNIT_ASSERT_EQUAL( sal_Int32(508), nHeight);
+CPPUNIT_ASSERT_EQUAL( sal_Int32(507), nHeight);
 }
-
 void SdImportTest::testTdf93830()
 {
 // Text shape offset was ignored
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 6b70d08..b2d1604 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -718,7 +718,7 @@ sal_Int32 Cell::getMinimumHeight()
 pEditOutliner->SetMaxAutoPaperSize(aSize);
 nMinimumHeight = pEditOutliner->GetTextHeight()+1;
 }
-else if ( hasText() )
+else
 {
 Outliner& rOutliner=rTableObj.ImpGetDrawOutliner();
 rOutliner.SetPaperSize(aSize);
diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 892b0d9..1df1378 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -688,6 +688,7 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 sal_Int32 nMinHeight = 0;
 
 bool bIsEmpty = true; // check if all cells in this row are merged
+bool bRowHasText = false;
 
 for( nCol = 0; nCol < nColCount; ++nCol )
 {
@@ -704,7 +705,16 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 }
 else
 {
-nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+bool bCellHasText = xCell->hasText();
+if ( (!bRowHasText && !bCellHasText) || ( bRowHasText && 
bCellHasText ) )
+{
+nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+}
+else if ( !bRowHasText && bCellHasText )
+{
+bRowHasText = true;
+nMinHeight = xCell->getMinimumHeight();
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: Apple Numbers application and format.

[jan iversen]

Seems we already support numbers:

https://www.phoronix.com/scan.php?page=news_item&px=LibreOffice-Apple-Pages-Numbers

that might explain, why .numbers files are silently ignored on a mac. 

If anybody is actually working on this, please let me know.

jan i.



--
View this message in context: 
http://nabble.documentfoundation.org/Apple-Numbers-application-and-format-tp4174002p4174047.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sc/source

[kumar]

 sc/source/ui/app/inputhdl.cxx |   18 ++
 1 file changed, 14 insertions(+), 4 deletions(-)

New commits:
commit 94aff0c21989e8be46b1676cef4d2a1db61752d3
Author: kumar 
Date:   Thu Jan 21 18:41:50 2016 +0530

tdf#93936:while creating formula comma appends incorrectly using Ctrl key

Change-Id: I6d0e210f11e52dd16cbd61b1da22d79064796efc
Reviewed-on: https://gerrit.libreoffice.org/21667
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index 98783dc..d567842 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -2975,10 +2975,20 @@ void ScInputHandler::AddRefEntry()
 DataChanging(); // Cannot be new
 
 RemoveSelection();
-if (pTableView)
-pTableView->InsertText( OUString(cSep) );
-if (pTopView)
-pTopView->InsertText( OUString(cSep) );
+OUString aText = GetEditText(pEngine);
+sal_Unicode cLastChar = 0;
+sal_Int32 nPos = aText.getLength() - 1;
+while (nPos >= 0 && ((cLastChar = aText[nPos]) == ' ')) //checking space
+--nPos;
+
+bool bAppendSeparator = (cLastChar != '(' && cLastChar != cSep && 
cLastChar != '=');
+if (bAppendSeparator)
+{
+if (pTableView)
+pTableView->InsertText( OUString(cSep) );
+if (pTopView)
+pTopView->InsertText( OUString(cSep) );
+}
 
 DataChanged();
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'libreoffice-5-0' - sd/qa svx/source

[Xisco Fauli]

 sd/qa/unit/import-tests.cxx|3 +--
 svx/source/table/cell.cxx  |2 +-
 svx/source/table/tablelayouter.cxx |   12 +++-
 3 files changed, 13 insertions(+), 4 deletions(-)

New commits:
commit 7583d19a58f9aa0fed51c248c1773285e2cb39cf
Author: Xisco Fauli 
Date:   Thu Jan 21 20:56:31 2016 +0100

tdf#91762: Check wether the row and the cell have text...

... in order to set the row's min height

Regression from 4f2c8194f485b1527fb4f4dfe23ce804937f1f9c
After this commit, the row's min height was set based only on
the cells containing text in the row, but the problem appeared
when the row didn't have any cell with text.
Change logic to check wether there's text in the cell and in the row.

Now, height in SdImportTest::testRowHeight() is 507 instead of
508 but I can't figure it out why. However, I believe there's
no harm in change the test from 508 to 507 as, visually speaking,
the difference can't be distinguish.

Change-Id: I0b3a14c34eaeaa8e77227860ca290fb79a0302ce
Reviewed-on: https://gerrit.libreoffice.org/21692
Tested-by: Jenkins 
Reviewed-by: jan iversen 
(cherry picked from commit 13d4398820ded5914f635757865e258db2db2b57)
Reviewed-on: https://gerrit.libreoffice.org/22009
Reviewed-by: Katarina Behrens 

diff --git a/sd/qa/unit/import-tests.cxx b/sd/qa/unit/import-tests.cxx
index 53f14e8..3c9f720 100644
--- a/sd/qa/unit/import-tests.cxx
+++ b/sd/qa/unit/import-tests.cxx
@@ -1232,9 +1232,8 @@ void SdImportTest::testRowHeight()
 uno::Reference< com::sun::star::table::XTableRows > xRows( 
xTable->getRows(), uno::UNO_QUERY_THROW);
 uno::Reference< beans::XPropertySet > xRefRow( xRows->getByIndex(0), 
uno::UNO_QUERY_THROW );
 xRefRow->getPropertyValue( sHeight ) >>= nHeight;
-CPPUNIT_ASSERT_EQUAL( sal_Int32(508), nHeight);
+CPPUNIT_ASSERT_EQUAL( sal_Int32(507), nHeight);
 }
-
 void SdImportTest::testTdf93830()
 {
 // Text shape offset was ignored
diff --git a/svx/source/table/cell.cxx b/svx/source/table/cell.cxx
index 71da0f1..26b66bd 100644
--- a/svx/source/table/cell.cxx
+++ b/svx/source/table/cell.cxx
@@ -727,7 +727,7 @@ sal_Int32 Cell::getMinimumHeight()
 pEditOutliner->SetMaxAutoPaperSize(aSize);
 nMinimumHeight = pEditOutliner->GetTextHeight()+1;
 }
-else if ( hasText() )
+else
 {
 Outliner& rOutliner=rTableObj.ImpGetDrawOutliner();
 rOutliner.SetPaperSize(aSize);
diff --git a/svx/source/table/tablelayouter.cxx 
b/svx/source/table/tablelayouter.cxx
index 0793e77..ee66352 100644
--- a/svx/source/table/tablelayouter.cxx
+++ b/svx/source/table/tablelayouter.cxx
@@ -688,6 +688,7 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 sal_Int32 nMinHeight = 0;
 
 bool bIsEmpty = true; // check if all cells in this row are merged
+bool bRowHasText = false;
 
 for( nCol = 0; nCol < nColCount; ++nCol )
 {
@@ -704,7 +705,16 @@ void TableLayouter::LayoutTableHeight( Rectangle& rArea, 
bool bFit )
 }
 else
 {
-nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+bool bCellHasText = xCell->hasText();
+if ( (!bRowHasText && !bCellHasText) || ( bRowHasText && 
bCellHasText ) )
+{
+nMinHeight = std::max( nMinHeight, 
xCell->getMinimumHeight() );
+}
+else if ( !bRowHasText && bCellHasText )
+{
+bRowHasText = true;
+nMinHeight = xCell->getMinimumHeight();
+}
 }
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: [libreoffice-website] Re: Can no longer login to ask.libreoffice.org

[Florian Effenberger]

Hi,

Sophie wrote on 2016-02-03 at 16:00:

I'm adding the website list on copy, I get the same issue and can't do
the moderation, I don't know what is happening.


I just tried and can login without a problem - does this problem still 
exist? Maybe it was just temporary?


Florian
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 90855] DIALOG: Improve the 'Insert Bookmark' dialog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90855

Samuel Mehrbrodt  changed:

   What|Removed |Added

   Keywords|needsDevEval|difficultyInteresting,
   ||easyHack, skillCpp
 CC|libreoffice-ux-advise@lists |libreoffice@lists.freedeskt
   |.freedesktop.org|op.org,
   ||samuel.mehrbr...@cib.de

--- Comment #5 from Samuel Mehrbrodt  ---
EasyHack:
The ui file is in sw/uiconfig/swriter/ui/insertbookmark.ui and the code in
sw/source/ui/misc/bookmark.cxx .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Can no longer login to ask.libreoffice.org

[Sophie]

Hi Regina,

I'm adding the website list on copy, I get the same issue and can't do
the moderation, I don't know what is happening.

Cheers
Sophie
Le 03/02/2016 15:53, Regina Henschel a écrit :
> Hi,
> 
> I try to login with my AskLibO user name and password. Neither the user
> name regina nor the email rb.hensc...@t-online.de works.
> 
> When I do "Recover account" I get an email with a link. I click the link
> and I reach my account to enter a new password. I can enter the password
> and then login is done. I can see my account informations. But when I
> then logout and try to login again, the same happens. No login possible.
> 
> I have tried it with different browsers and different PCs.
> 
> I need help for login. Who is responsible for ask.libreoffice.org and
> can look what is wrong with my account?
> 
> Kind regards
> Regina
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


-- 
Sophie Gautier sophie.gaut...@documentfoundation.org
GSM: +33683901545
IRC: sophi
Co-founder - Release coordinator
The Document Foundation
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Can no longer login to ask.libreoffice.org

[Regina Henschel]

Hi,

I try to login with my AskLibO user name and password. Neither the user 
name regina nor the email rb.hensc...@t-online.de works.


When I do "Recover account" I get an email with a link. I click the link 
and I reach my account to enter a new password. I can enter the password 
and then login is done. I can see my account informations. But when I 
then logout and try to login again, the same happens. No login possible.


I have tried it with different browsers and different PCs.

I need help for login. Who is responsible for ask.libreoffice.org and 
can look what is wrong with my account?


Kind regards
Regina
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

--- Comment #4 from NURHAK ALTIN  ---
Now, I'm on that bug thanks for orientation =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Changes to 'refs/tags/cp-5.0-21'

[Andras Timar]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-20-33:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: Branch 'distro/collabora/milestone-7' - 2 commits - loolwsd/configure.ac

[Andras Timar]

 loolwsd/configure.ac |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c69535b67cb597b6b2f978a41f6a3b7b5789f205
Author: Andras Timar 
Date:   Wed Feb 3 15:19:16 2016 +0100

loolwsd: bump version after tarball

diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 87f2180..c7516d5 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.4.38], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.4.39], [libreoff...@collabora.com])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
 
commit b1e4f210bc85c899b9602995f582276ae5fdccbf
Author: Andras Timar 
Date:   Wed Feb 3 15:08:18 2016 +0100

loolwsd: bump version before tarball

diff --git a/loolwsd/configure.ac b/loolwsd/configure.ac
index 6eccd77..87f2180 100644
--- a/loolwsd/configure.ac
+++ b/loolwsd/configure.ac
@@ -3,7 +3,7 @@
 
 AC_PREREQ([2.69])
 
-AC_INIT([loolwsd], [1.4.37], [libreoff...@collabora.com])
+AC_INIT([loolwsd], [1.4.38], [libreoff...@collabora.com])
 
 AM_INIT_AUTOMAKE([1.11 silent-rules subdir-objects])
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: Changes to 'refs/tags/cp-5.0-21'

[Christian Lohmaier]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-18:
Christian Lohmaier (1):
   should not be empty/self-closing element ()

---
 source/text/shared/01/0222.xhp  |2 +-
 source/text/swriter/01/04020100.xhp |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] translations.git: Changes to 'refs/tags/cp-5.0-21'

[Christian Lohmaier]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-14-23:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/cp-5.0-21'

[Ricardo Palomares]

Tag 'cp-5.0-21' created by Andras Timar  at 
2016-02-03 14:22 -0800

cp-5.0-21

Changes since cp-5.0-18-2:
---
 0 files changed
---
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Arul]

 sc/inc/table.hxx   |2 +-
 sc/source/core/data/document10.cxx |2 +-
 sc/source/core/data/table7.cxx |5 -
 sc/source/ui/view/viewfun3.cxx |   22 --
 4 files changed, 22 insertions(+), 9 deletions(-)

New commits:
commit 403ca446458268ae04d42f666223974f525e8df8
Author: Arul 
Date:   Thu Jan 21 18:22:51 2016 +0530

tdf#89140:Calc row paste doesn't keep row height

Change-Id: Ibf9a5674711cf496706c4d3ac9d3133016aea39d
Reviewed-on: https://gerrit.libreoffice.org/21665
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d2672fe..0e84a70 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -428,7 +428,7 @@ public:
 sc::CopyFromClipContext& rCxt, const ScTable& rClipTab, 
sc::ColumnSpanSet& rBroadcastSpans );
 
 void CopyOneCellFromClip(
-sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2 );
+sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab );
 
 void CopyFromClip(
 sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2,
diff --git a/sc/source/core/data/document10.cxx 
b/sc/source/core/data/document10.cxx
index 8b0..a2f13920 100644
--- a/sc/source/core/data/document10.cxx
+++ b/sc/source/core/data/document10.cxx
@@ -117,7 +117,7 @@ bool ScDocument::CopyOneCellFromClip(
 SCTAB nTabEnd = rCxt.getTabEnd();
 for (SCTAB i = rCxt.getTabStart(); i <= nTabEnd && i < 
static_cast(maTabs.size()); ++i)
 {
-maTabs[i]->CopyOneCellFromClip(rCxt, nCol1, nRow1, nCol2, nRow2);
+maTabs[i]->CopyOneCellFromClip(rCxt, nCol1, nRow1, nCol2, nRow2,  
aClipRange.aStart.Row(), pSrcTab);
 if (rCxt.getInsertFlag() & InsertDeleteFlags::ATTRIB)
 for (SCROW nRow = nRow1; nRow <= nRow2; ++nRow)
 {
diff --git a/sc/source/core/data/table7.cxx b/sc/source/core/data/table7.cxx
index f940ee5..6c0cefa 100644
--- a/sc/source/core/data/table7.cxx
+++ b/sc/source/core/data/table7.cxx
@@ -52,7 +52,7 @@ void ScTable::DeleteBeforeCopyFromClip(
 }
 
 void ScTable::CopyOneCellFromClip(
-sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2 )
+sc::CopyFromClipContext& rCxt, SCCOL nCol1, SCROW nRow1, SCCOL nCol2, 
SCROW nRow2, SCROW nSrcRow, ScTable* pSrcTab )
 {
 ScRange aSrcRange = rCxt.getClipDoc()->GetClipParam().getWholeRange();
 SCCOL nSrcColSize = aSrcRange.aEnd.Col() - aSrcRange.aStart.Col() + 1;
@@ -64,6 +64,9 @@ void ScTable::CopyOneCellFromClip(
 assert(nColOffset >= 0);
 aCol[nCol].CopyOneCellFromClip(rCxt, nRow1, nRow2, nColOffset);
 }
+
+if (nCol1 == 0 && nCol2 == MAXCOL && mpRowHeights)
+mpRowHeights->setValue(nRow1, nRow2, 
pSrcTab->GetOriginalHeight(nSrcRow));
 }
 
 void ScTable::SetValues( SCCOL nCol, SCROW nRow, const std::vector& 
rVals )
diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx
index 1e6a216..77b0fad 100644
--- a/sc/source/ui/view/viewfun3.cxx
+++ b/sc/source/ui/view/viewfun3.cxx
@@ -1505,11 +1505,12 @@ bool ScViewFunc::PasteMultiRangesFromClip(
 return false;
 }
 
+bool bRowInfo = ( aMarkedRange.aStart.Col()==0 && 
aMarkedRange.aEnd.Col()==MAXCOL );
 ::std::unique_ptr pUndoDoc;
 if (pDoc->IsUndoEnabled())
 {
 pUndoDoc.reset(new ScDocument(SCDOCMODE_UNDO));
-pUndoDoc->InitUndoSelected(pDoc, aMark);
+pUndoDoc->InitUndoSelected(pDoc, aMark, false, bRowInfo);
 pDoc->CopyToDocument(aMarkedRange, nUndoFlags, false, pUndoDoc.get(), 
&aMark);
 }
 
@@ -1549,10 +1550,15 @@ bool ScViewFunc::PasteMultiRangesFromClip(
  true, false, false, true);
 }
 
-ScRange aTmp = aMarkedRange;
-aTmp.aStart.SetTab(nTab1);
-aTmp.aEnd.SetTab(nTab1);
-pDocSh->PostPaint(aTmp, PAINT_GRID);
+if (bRowInfo)
+pDocSh->PostPaint(aMarkedRange.aStart.Col(), 
aMarkedRange.aStart.Row(), nTab1, MAXCOL, MAXROW, nTab1, PAINT_GRID|PAINT_LEFT);
+else
+{
+ScRange aTmp = aMarkedRange;
+aTmp.aStart.SetTab(nTab1);
+aTmp.aEnd.SetTab(nTab1);
+pDocSh->PostPaint(aTmp, PAINT_GRID);
+}
 
 if (pDoc->IsUndoEnabled())
 {
@@ -1712,7 +1718,11 @@ bool ScViewFunc::PasteFromClipToMultiRanges(
 
 // Refresh the range that includes all pasted ranges.  We only need to
 // refresh the current sheet.
-pDocSh->PostPaint(aRanges, PAINT_GRID);
+sal_uInt16 nPaint = PAINT_GRID;
+bool bRowInfo = (aSrcRange.aStart.Col()==0 &&  
aSrcRange.aEnd.Col()==MAXCOL);
+if (bRowInfo)
+nPaint |= PAINT_LEFT;
+pDocSh->PostPaint(aRanges, nPaint);
 
 if (pDoc->IsUndoEnabled())
 {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #8 from Samuel Mehrbrodt  ---
(In reply to Markus Mohrhard (retired) from comment #5)
> That is actually not completely true.
> 
> There are many experimental features that work without a restart. The better
> question is which ones don't and then check if they can't be made to work
> without it. Especially as we now have a configuration change listener.

Closing this bug. Markus, maybe you can create a new bug where you describe
your idea?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96132] Enabling Experimental Features in the UI doesn't inform the user that LibO needs to be restarted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96132

--- Comment #7 from Commit Notification 
 ---
akki95 committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5008b9a692296ab72e08d397a49d11d0f83c

tdf#96132 Enabling Experimental Features in UI doesn't warn about restart

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: cui/source

[akki95]

 cui/source/options/optjava.cxx |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 5008b9a692296ab72e08d397a49d11d0f83c
Author: akki95 
Date:   Wed Feb 3 04:54:01 2016 +0530

tdf#96132 Enabling Experimental Features in UI doesn't warn about restart

Change-Id: I2efafee4f8ebd4cd7ba2b7a23f68ca08022eb659
Reviewed-on: https://gerrit.libreoffice.org/22064
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 

diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index ed32628..6c8e805 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -665,6 +665,8 @@ bool SvxJavaOptionsPage::FillItemSet( SfxItemSet* 
/*rCoreSet*/ )
 SvtMiscOptions aMiscOpt;
 aMiscOpt.SetExperimentalMode( m_pExperimentalCB->IsChecked() );
 bModified = true;
+ScopedVclPtrInstance< MessageDialog > aWarnBox( this, CUI_RES( 
RID_SVXSTR_OPTIONS_RESTART ), VCL_MESSAGE_INFO );
+aWarnBox->Execute();
 }
 
 if ( m_pMacroCB->IsValueChangedFromSaved() )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Bug 97527] vcl: reference-count Menu ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97527

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |

--- Comment #1 from Chris Sherlock  ---
I'll take this one. This is going to be interesting :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

--- Comment #3 from Michael Meeks  ---
Heh - my hope was that Nurhak might do this one =)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97527] vcl: reference-count Menu ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97527

Michael Meeks  changed:

   What|Removed |Added

   Keywords||difficultyInteresting,
   ||easyHack, skillCpp,
   ||topicCleanup
 Status|UNCONFIRMED |NEW
 CC||chris.sherloc...@gmail.com,
   ||libreoffice@lists.freedeskt
   ||op.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - include/LibreOfficeKit libreofficekit/qa libreofficekit/source

[Pranav Kant]

 include/LibreOfficeKit/LibreOfficeKitGtk.h  |   12 ++
 libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx |   50 +
 libreofficekit/source/gtk/lokdocview.cxx|  109 +++-
 3 files changed, 166 insertions(+), 5 deletions(-)

New commits:
commit 89a3c1b4d69aac447606dc6f0e661b2ef4dddc8c
Author: Pranav Kant 
Date:   Wed Jan 27 16:56:14 2016 +0530

lokdocview: Handle password protected documents

Reviewed-on: https://gerrit.libreoffice.org/21861
Tested-by: Jenkins 
Reviewed-by: Caolán McNamara 
Tested-by: Caolán McNamara 
(cherry picked from commit 18fbddcca569c109ca2f46f7d791187e672d4d83)
Signed-off-by: Michael Stahl 

Change-Id: I606a1112c8eb4c1cc4596d6947ce1223543cc87c

diff --git a/include/LibreOfficeKit/LibreOfficeKitGtk.h 
b/include/LibreOfficeKit/LibreOfficeKitGtk.h
index e06d154..1df27c1 100644
--- a/include/LibreOfficeKit/LibreOfficeKitGtk.h
+++ b/include/LibreOfficeKit/LibreOfficeKitGtk.h
@@ -275,6 +275,18 @@ gbooleanlok_doc_view_paste 
(LOKDocView*
 gsize 
nSize);
 
 /**
+ * lok_doc_view_set_document_password:
+ * @pDocView: The #LOKDocView instance
+ * @pUrl: the URL of the document to set password for, as sent with signal 
`password-required`
+ * @pPassword: (nullable): the password, NULL for no password
+ *
+ * Set the password for password protected documents
+ */
+voidlok_doc_view_set_document_password 
(LOKDocView* pDocView,
+const 
gchar* pURL,
+const 
gchar* pPassword);
+
+/**
  * lok_doc_view_pixel_to_twip:
  * @pDocView: The #LOKDocView instance
  * @fInput: The value in pixels to convert to twips
diff --git a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx 
b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
index ebf0559..fb97af1 100644
--- a/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtktiledviewer.cxx
@@ -462,10 +462,20 @@ static void toggleFindbar(GtkWidget* pButton, gpointer 
/*pItem*/)
 }
 }
 
+static void
+setLOKFeatures (GtkWidget* pDocView)
+{
+g_object_set(G_OBJECT(pDocView),
+ "doc-password", TRUE,
+ "doc-password-to-modify", TRUE,
+ nullptr);
+}
+
 /// Common initialization, regardless if it's just a new view or a full init.
 static TiledWindow& setupWidgetAndCreateWindow(GtkWidget* pDocView)
 {
 setupDocView(pDocView);
+setLOKFeatures(pDocView);
 TiledWindow aWindow;
 aWindow.m_pDocView = pDocView;
 GtkWidget* pWindow = createWindow(aWindow);
@@ -798,6 +808,45 @@ static void formulaChanged(LOKDocView* pLOKDocView, char* 
pPayload, gpointer /*p
 gtk_entry_set_text(GTK_ENTRY(rWindow.m_pFormulabarEntry), pPayload);
 }
 
+/// LOKDocView password is requried to open the document
+static void passwordRequired(LOKDocView* pLOKDocView, gchar* pUrl, gboolean 
bModify, gpointer /*pData*/)
+{
+GtkWidget* pPasswordDialog = gtk_dialog_new_with_buttons ("Password 
required",
+  GTK_WINDOW 
(gtk_widget_get_toplevel(GTK_WIDGET(pLOKDocView))),
+  GTK_DIALOG_MODAL,
+  "OK",
+  GTK_RESPONSE_OK,
+  nullptr);
+g_object_set(G_OBJECT(pPasswordDialog), "resizable", FALSE, nullptr);
+GtkWidget* pDialogMessageArea = gtk_dialog_get_content_area (GTK_DIALOG 
(pPasswordDialog));
+GtkWidget* pPasswordEntry = gtk_entry_new ();
+gtk_entry_set_visibility (GTK_ENTRY(pPasswordEntry), FALSE);
+gtk_entry_set_invisible_char (GTK_ENTRY(pPasswordEntry), '*');
+gtk_box_pack_end(GTK_BOX(pDialogMessageArea), pPasswordEntry, TRUE, TRUE, 
2);
+if (bModify)
+{
+GtkWidget* pSecondaryLabel = gtk_label_new ("Document requires 
password to edit");
+gtk_box_pack_end(GTK_BOX(pDialogMessageArea), pSecondaryLabel, TRUE, 
TRUE, 2);
+gtk_dialog_add_button (GTK_DIALOG (pPasswordDialog), "Open as 
read-only", GTK_RESPONSE_ACCEPT);
+}
+gtk_widget_show_all(pPasswordDialog);
+
+gint res = gtk_dialog_run (GTK_DIALOG(pPasswordDialog));
+switch (res)
+{
+case GTK_RESPONSE_OK:
+lok_doc_view_set_document_password (pLOKDocView, pUrl, 
gtk_entry_get_text(GTK_ENTRY(pPasswordEntry)));
+break;
+case GTK_RESPONSE_ACCEPT:
+// User accepts to open this document as read-only
+case GTK_RESPONSE_DELETE_EVENT:
+lok_doc_view_set_document_password (pLOKDocView, pUrl, nullptr);
+break;
+}
+
+gtk_widget_destroy(pPasswordDialog);
+}
+
 static vo

[Bug 87743] Pack LibreOffice for PlayOnLinux for QA

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=87743

Björn Michaelsen  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #17 from Björn Michaelsen  ---
(In reply to Gouchi from comment #16)
> Scripts have been submitted. Waiting for approval.

Aaand they are apparently approved. Awesome stuff! Will tell the LibreOffice QA
list about it right away!

http://nabble.documentfoundation.org/QA-f3613148.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|chris.sherloc...@gmail.com  |libreoffice-b...@lists.free
   ||desktop.org

--- Comment #2 from Chris Sherlock  ---
On second thoughts, I might welsh on this one :-)

Some other lucky person can have the pleasure! Sorry all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #42 from Dipankar Niranjan  ---
(In reply to Michael Meeks from comment #41)
Sure.. Will do it once Grok gets updated.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #41 from Michael Meeks  ---
Oh - true ! =) not quite done - would love another patch to finally kill those.

Thanks !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Chris Sherlock  changed:

   What|Removed |Added

   Assignee|libreoffice-b...@lists.free |chris.sherloc...@gmail.com
   |desktop.org |

--- Comment #1 from Chris Sherlock  ---
I'm happy to take this one. 

I'll try to give it to you in one patch :-) No more little patches I promise
Michael!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

--- Comment #40 from Dipankar Niranjan  ---
There are some remnants though..(Maybe two or three usages..)
ImplDelData is still used at those places..
But ImplAddDel and ImplRemoveDel along with IsDead are completely gone..
So, if the cleanup is finished I would like to say I learned a lot during this
cleanup!
Thanks for all the help..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||525

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 97525] vcl: make DeletionListener internal ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97525

Michael Meeks  changed:

   What|Removed |Added

   Keywords||difficultyBeginner,
   ||easyHack, skillCpp,
   ||topicCleanup
 Status|UNCONFIRMED |NEW
 CC||libreoffice@lists.freedeskt
   ||op.org
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||888
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Bug 96888] Kill internal vcl dog-tags ...

[Chris Sherlock]

Finally! The fix is in - no more dog tags!

Thanks from me as well :-)

Chris

> On 4 Feb 2016, at 12:24 AM, bugzilla-dae...@bugs.documentfoundation.org wrote:
> 
> Michael Meeks  changed bug 96888 
>  
> What  Removed Added
> StatusREOPENEDRESOLVED
> Resolution--- FIXED
> 
> Comment # 39  
> on bug 96888  from 
> Michael Meeks 
> Great work - this is finally gone =)
> 
> Thanks Dipankar !
> 
> You are receiving this mail because:
> You are on the CC list for the bug.
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

Samuel Mehrbrodt  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 45168] Add Option to crop (reduce size of) Images in PDF Export

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45168

--- Comment #13 from Cor Nouws  ---
So for renewing my understanding of this:
 - it is when images are croped in the document, that then at PDF-export only
that part of the image ?
 - so not the same as setting the resolution in the dialog PDF Options..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

Chris Sherlock  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||chris.sherloc...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|| target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 96414] Remove feature to show Navigator during slideshow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96414

--- Comment #11 from Commit Notification 
 ---
Bryan Quigley committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=2503a1e99df463aef1bf87c94b7b4a8ee3554efe

tdf#96414 Remove showing navigator during slideshow

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.1.0|target:5.1.0 target:5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 94269] Replace "n" prefix for bool variables with "b"

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94269

--- Comment #9 from Commit Notification 
 ---
Chris Sherlock committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=8db902785ed40ef388218bd5068f14f5d4bedd69

tdf#94269 Replace "n" prefix for bool variables with "b"

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sd/inc sd/source sd/uiconfig

[Bryan Quigley]

 sd/inc/drawdoc.hxx|1 
 sd/source/core/drawdoc.cxx|6 -
 sd/source/ui/dlg/present.cxx  |4 -
 sd/source/ui/func/fusldlg.cxx |8 --
 sd/source/ui/slideshow/slideshow.cxx  |   25 ---
 sd/source/ui/slideshow/slideshowimpl.cxx  |   85 --
 sd/source/ui/view/drviewsd.cxx|   41 ++--
 sd/uiconfig/simpress/ui/presentationdialog.ui |   15 
 8 files changed, 10 insertions(+), 175 deletions(-)

New commits:
commit 2503a1e99df463aef1bf87c94b7b4a8ee3554efe
Author: Bryan Quigley 
Date:   Wed Jan 27 12:19:28 2016 -0500

tdf#96414 Remove showing navigator during slideshow

This isn't very user-friendly and the presenter console
does a much better job of this.

Change-Id: I621863b585d763fb65ed8637c3dab7b7f5ea7aed
Reviewed-on: https://gerrit.libreoffice.org/22062
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 9208e6c..f3a599a 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -126,7 +126,6 @@ namespace sd
 bool mbAnimationAllowed;
 sal_Int32 mnPauseTimeout;
 bool mbShowPauseLogo;
-bool mbStartWithNavigator;
 
 PresentationSettings();
 PresentationSettings( const PresentationSettings& r );
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx
index 6702e9d..62235b5 100644
--- a/sd/source/core/drawdoc.cxx
+++ b/sd/source/core/drawdoc.cxx
@@ -126,8 +126,7 @@ PresentationSettings::PresentationSettings()
 mbFullScreen( true ),
 mbAnimationAllowed( true ),
 mnPauseTimeout( 10 ),
-mbShowPauseLogo( false ),
-mbStartWithNavigator(false)
+mbShowPauseLogo( false )
 {
 }
 
@@ -144,8 +143,7 @@ PresentationSettings::PresentationSettings( const 
PresentationSettings& r )
 mbFullScreen( r.mbFullScreen ),
 mbAnimationAllowed( r.mbAnimationAllowed ),
 mnPauseTimeout( r.mnPauseTimeout ),
-mbShowPauseLogo( r.mbShowPauseLogo ),
-mbStartWithNavigator( r.mbStartWithNavigator )
+mbShowPauseLogo( r.mbShowPauseLogo )
 {
 }
 
diff --git a/sd/source/ui/dlg/present.cxx b/sd/source/ui/dlg/present.cxx
index 3fe2206..14ee529 100644
--- a/sd/source/ui/dlg/present.cxx
+++ b/sd/source/ui/dlg/present.cxx
@@ -58,7 +58,6 @@ SdStartPresentationDlg::SdStartPresentationDlg( vcl::Window* 
pWindow,
 get( aCbxManuel,"manualslides"  );
 get( aCbxMousepointer,  "pointervisible");
 get( aCbxPen,   "pointeraspen"  );
-get( aCbxNavigator, "navigatorvisible"  );
 get( aCbxAnimationAllowed,  "animationsallowed" );
 get( aCbxChangePage,"changeslidesbyclick"   );
 get( aCbxAlwaysOnTop,   "alwaysontop"   );
@@ -118,7 +117,6 @@ SdStartPresentationDlg::SdStartPresentationDlg( 
vcl::Window* pWindow,
 aCbxManuel->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_MANUEL ) ).GetValue() );
 aCbxMousepointer->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_MOUSE ) ).GetValue() );
 aCbxPen->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_PEN ) ).GetValue() );
-aCbxNavigator->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_NAVIGATOR ) ).GetValue() );
 aCbxAnimationAllowed->Check( static_cast( 
rOutAttrs.Get( ATTR_PRESENT_ANIMATION_ALLOWED ) ).GetValue() );
 aCbxChangePage->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_CHANGE_PAGE ) ).GetValue() );
 aCbxAlwaysOnTop->Check( static_cast( rOutAttrs.Get( 
ATTR_PRESENT_ALWAYS_ON_TOP ) ).GetValue() );
@@ -170,7 +168,6 @@ void SdStartPresentationDlg::dispose()
 aCbxManuel.clear();
 aCbxMousepointer.clear();
 aCbxPen.clear();
-aCbxNavigator.clear();
 aCbxAnimationAllowed.clear();
 aCbxChangePage.clear();
 aCbxAlwaysOnTop.clear();
@@ -301,7 +298,6 @@ void SdStartPresentationDlg::GetAttr( SfxItemSet& rAttr )
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_MANUEL, aCbxManuel->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_MOUSE, aCbxMousepointer->IsChecked() 
) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_PEN, aCbxPen->IsChecked() ) );
-rAttr.Put( SfxBoolItem ( ATTR_PRESENT_NAVIGATOR, 
aCbxNavigator->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_ANIMATION_ALLOWED, 
aCbxAnimationAllowed->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_CHANGE_PAGE, 
aCbxChangePage->IsChecked() ) );
 rAttr.Put( SfxBoolItem ( ATTR_PRESENT_ALWAYS_ON_TOP, 
aCbxAlwaysOnTop->IsChecked() ) );
diff --git a/sd/source/ui/func/fusldlg.cxx b/sd/source/ui/func/fusldlg.cxx
index f3c2f09..8cf501b 100644
--- a/sd/source/ui/func/fusldlg.cxx
+++ b/sd/source/ui/func/fusldlg.cxx
@@ -97,7 +97,6 @@ void FuSlideShowDlg::DoExecute( SfxRequest& )
 aDlgSet.Put( SfxBoolItem( ATTR_PRESENT_MANUEL, 
rPresentationSettings.mbManual ) );
 aDlgSet.Put( SfxBoolItem( ATTR_PRESENT_MOUSE, 
rPresentationSetti

[Bug 96888] Kill internal vcl dog-tags ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96888

Michael Meeks  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #39 from Michael Meeks  ---
Great work - this is finally gone =)

Thanks Dipankar !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: editeng/source filter/source idl/inc sc/source sd/source vcl/source

[Chris Sherlock]

 editeng/source/outliner/outlundo.hxx  |2 +-
 filter/source/graphicfilter/ipcx/ipcx.cxx |   24 
 idl/inc/bastype.hxx   |   26 +-
 sc/source/core/tool/rangeutl.cxx  |8 
 sc/source/filter/inc/xcl97rec.hxx |2 +-
 sc/source/filter/xcl97/xcl97rec.cxx   |6 +++---
 sd/source/ui/dlg/navigatr.cxx |   10 +-
 vcl/source/window/winproc.cxx |6 +++---
 8 files changed, 42 insertions(+), 42 deletions(-)

New commits:
commit 8db902785ed40ef388218bd5068f14f5d4bedd69
Author: Chris Sherlock 
Date:   Thu Feb 4 00:23:52 2016 +1100

tdf#94269 Replace "n" prefix for bool variables with "b"

Change-Id: I8999dc2701010424ea4d2504e99ed429030d7d4e

diff --git a/editeng/source/outliner/outlundo.hxx 
b/editeng/source/outliner/outlundo.hxx
index cb36c57..adc1554 100644
--- a/editeng/source/outliner/outlundo.hxx
+++ b/editeng/source/outliner/outlundo.hxx
@@ -69,7 +69,7 @@ private:
 public:
 OutlinerUndoChangeParaNumberingRestart( Outliner* pOutliner, sal_Int32 
nPara,
 sal_Int16 nOldNumberingStartValue, sal_Int16 mnNewNumberingStartValue,
-bool  nOldbParaIsNumberingRestart, bool nbNewParaIsNumberingRestart );
+bool  bOldbParaIsNumberingRestart, bool bNewParaIsNumberingRestart );
 
 virtual voidUndo() override;
 virtual voidRedo() override;
diff --git a/filter/source/graphicfilter/ipcx/ipcx.cxx 
b/filter/source/graphicfilter/ipcx/ipcx.cxx
index 33308a0..6710f5d 100644
--- a/filter/source/graphicfilter/ipcx/ipcx.cxx
+++ b/filter/source/graphicfilter/ipcx/ipcx.cxx
@@ -43,7 +43,7 @@ private:
 sal_uInt16  nResX, nResY;   // resolution in pixel per inch 
oder 0,0
 sal_uInt16  nDestBitsPerPixel;  // bits per pixel in destination 
bitmap 1,4,8 or 24
 sal_uInt8*  pPalette;
-boolnStatus;// from now on do not read status 
from stream ( SJ )
+boolbStatus;// from now on do not read status 
from stream ( SJ )
 
 
 voidImplReadBody(BitmapWriteAccess * pAcc);
@@ -72,7 +72,7 @@ PCXReader::PCXReader(SvStream &rStream)
 , nResX(0)
 , nResY(0)
 , nDestBitsPerPixel(0)
-, nStatus(false)
+, bStatus(false)
 {
 pPalette = new sal_uInt8[ 768 ];
 }
@@ -91,12 +91,12 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 
 // read header:
 
-nStatus = true;
+bStatus = true;
 
 ImplReadHeader();
 
 // Write BMP header and conditionally (maybe invalid for now) color 
palette:
-if ( nStatus )
+if ( bStatus )
 {
 aBmp = Bitmap( Size( nWidth, nHeight ), nDestBitsPerPixel );
 Bitmap::ScopedWriteAccess pAcc(aBmp);
@@ -118,7 +118,7 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 
 // If an extended color palette exists at the end of the file, then 
read it and
 // and write again in palette:
-if ( nDestBitsPerPixel == 8 && nStatus )
+if ( nDestBitsPerPixel == 8 && bStatus )
 {
 sal_uInt8* pPal = pPalette;
 m_rPCX.SeekRel(1);
@@ -136,7 +136,7 @@ bool PCXReader::ReadPCX(Graphic & rGraphic)
 rBitmap.SetPrefMapMode(aMapMode);
 rBitmap.SetPrefSize(Size(nWidth,nHeight));
 }
-*/  if ( nStatus )
+*/  if ( bStatus )
 {
 rGraphic = aBmp;
 return true;
@@ -151,7 +151,7 @@ void PCXReader::ImplReadHeader()
 m_rPCX.ReadUChar( nbyte ).ReadUChar( nVersion ).ReadUChar( nEncoding );
 if ( nbyte!=0x0a || (nVersion != 0 && nVersion != 2 && nVersion != 3 && 
nVersion != 5) || nEncoding > 1 )
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -162,7 +162,7 @@ void PCXReader::ImplReadHeader()
 
 if ((nMinX > nMaxX) || (nMinY > nMaxY))
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -191,7 +191,7 @@ void PCXReader::ImplReadHeader()
 if ( ( nDestBitsPerPixel != 1 && nDestBitsPerPixel != 4 && 
nDestBitsPerPixel != 8 && nDestBitsPerPixel != 24 )
 || nPlanes > 4 || nBytesPerPlaneLin < ( ( nWidth * nBitsPerPlanePix+7 
) >> 3 ) )
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -214,7 +214,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 //sanity check there is enough data before trying allocation
 if (nBytesPerPlaneLin > m_rPCX.remainingSize() / nPlanes)
 {
-nStatus = false;
+bStatus = false;
 return;
 }
 
@@ -226,7 +226,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 {
 if (!m_rPCX.good())
 {
-nStatus = false;
+bStatus = false;
 break;
 }
 nPercent = ny * 60 / nHeight + 10;
@@ -378,7 +378,7 @@ void PCXReader::ImplReadBody(BitmapWriteAccess * pAcc)
 }
 break;
 defa

[Libreoffice-commits] core.git: starmath/source

[Michael Stahl]

 starmath/source/mathmlimport.cxx |4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 4a2824e72aae407f5f2a86e6ef45278ef864d437
Author: Michael Stahl 
Date:   Wed Feb 3 14:02:22 2016 +0100

starmath: tdf#97190: don't assert on missing base URL

There are valid scenarios where we don't have a URL at all, such as when
importing MathML from the clipboard.  Also there probably isn't much of
a problem caused by missing base URLs in Math anyway since RDF import is
currently not implemented and i'm not sure if hyperlinks in Math
documents are possible at all.

Change-Id: I13b70ac62542364f329875e292c574883255af5e

diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index ca557ae..36884c9 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -142,7 +142,9 @@ sal_uLong SmXMLImportWrapper::Import(SfxMedium &rMedium)
 
 // Set base URI
 OUString const baseURI(rMedium.GetBaseURL());
-assert(!baseURI.isEmpty()); // needed for relative URLs
+// needed for relative URLs; but it's OK to import e.g. MathML from the
+// clipboard without one
+SAL_INFO_IF(baseURI.isEmpty(), "starmath", "SmXMLImportWrapper: no base 
URL");
 xInfoSet->setPropertyValue("BaseURI", makeAny(baseURI));
 
 sal_Int32 nSteps=3;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/inc sc/source

[Dennis Francis]

 sc/inc/dbdata.hxx  |3 ++
 sc/inc/table.hxx   |   11 ---
 sc/source/core/data/documen3.cxx   |   32 +
 sc/source/core/data/table1.cxx |1 
 sc/source/core/data/table2.cxx |   54 -
 sc/source/core/data/table5.cxx |   31 -
 sc/source/core/tool/dbdata.cxx |   26 +++--
 sc/source/ui/docshell/dbdocfun.cxx |1 
 8 files changed, 29 insertions(+), 130 deletions(-)

New commits:
commit 1e619fdf9e79cb49895d83fe7f5a1f373495b915
Author: Dennis Francis 
Date:   Fri Jan 22 22:14:54 2016 +0530

tdf#34873 : Better way to show autofilter count

This patch modifies the commit 3536fe8f4cdbacf5702e743407f34d918b6f4d38
by keeping the filtered row count inside ScDBData instead of
ScTable as suggested by Eike Rathke. This significantly reduced the
code complexity involved.

Change-Id: I30ac26061d9665ce7a749e23a636f7fb3f69b176
Reviewed-on: https://gerrit.libreoffice.org/21720
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/inc/dbdata.hxx b/sc/inc/dbdata.hxx
index bab0608..6778a94 100644
--- a/sc/inc/dbdata.hxx
+++ b/sc/inc/dbdata.hxx
@@ -97,6 +97,7 @@ private:
 
 ::std::vector< OUString > maTableColumnNames;   ///< names of table columns
 boolmbTableColumnNamesDirty;
+SCSIZE  nFilteredRowCount;
 
 using ScRefreshTimer::operator==;
 
@@ -214,6 +215,8 @@ public:
 SCsCOL nDx, SCsROW nDy, SCsTAB nDz);
 
 void ExtendDataArea(ScDocument* pDoc);
+void CalcSaveFilteredCount(SCSIZE nNonFilteredRowCount);
+void GetFilterSelCount(SCSIZE& nSelected, SCSIZE& nTotal);
 
 private:
 
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index d6111dd..d2672fe 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -117,16 +117,6 @@ class ScHint;
 class ScTable : private boost::noncopyable
 {
 private:
-// To store an Autofilter's filtered row count
-struct FilteredRowCountData {
-SCROW nStartRow;
-SCROW nEndRow;
-SCSIZE nCount;
-FilteredRowCountData(SCROW nRow1, SCROW nRow2, SCSIZE nVal) :
-nStartRow(nRow1), nEndRow(nRow2), nCount(nVal)
-{}
-};
-
 typedef ::std::vector< ScRange > ScRangeVec;
 
 ScColumnaCol[MAXCOLCOUNT];
@@ -161,7 +151,6 @@ private:
 std::unique_ptr  mpHiddenRows;
 std::unique_ptr  mpFilteredCols;
 std::unique_ptr  mpFilteredRows;
-FilteredRowCountDatamaFilteredRowCount;
 
 ::std::set  maRowPageBreaks;
 ::std::set  maRowManualBreaks;
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 5f632d9..aa9fbb7 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -1470,37 +1470,9 @@ void ScDocument::GetFilterSelCount( SCCOL nCol, SCROW 
nRow, SCTAB nTab, SCSIZE&
 nTotal = 0;
 if ( ValidTab(nTab) && nTab < static_cast(maTabs.size()) && 
maTabs[nTab] )
 {
-const ScDBData* pDBData = GetDBAtCursor( nCol, nRow, nTab, 
ScDBDataPortion::AREA );
+ScDBData* pDBData = GetDBAtCursor( nCol, nRow, nTab, 
ScDBDataPortion::AREA );
 if( pDBData && pDBData->HasAutoFilter() )
-{
-SCTAB nAreaTab;
-SCCOL nStartCol;
-SCROW nStartRow;
-SCCOL nEndCol;
-SCROW nEndRow;
-pDBData->GetArea( nAreaTab, nStartCol, nStartRow, nEndCol, nEndRow 
);
-
-if( pDBData->HasHeader() )
-++nStartRow;
-
-nTotal = nEndRow - nStartRow + 1;
-
-ScTable::FilteredRowCountData* pFilteredRowCount = 
&(maTabs[nTab]->maFilteredRowCount);
-// Exact range match, cache hit, early exit
-if( ( pFilteredRowCount->nStartRow == nStartRow ) && ( 
pFilteredRowCount->nEndRow == nEndRow ) &&
-( pFilteredRowCount->nCount != SCSIZE_MAX ) )
-{
-nSelected = nTotal - pFilteredRowCount->nCount;
-return;
-}
-
-// Compute the count
-nSelected = CountNonFilteredRows( nStartRow, nEndRow, nTab );
-// and store it in the cache
-pFilteredRowCount->nStartRow = nStartRow;
-pFilteredRowCount->nEndRow   = nEndRow;
-pFilteredRowCount->nCount= nTotal - nSelected;
-}
+pDBData->GetFilterSelCount( nSelected, nTotal );
 }
 }
 
diff --git a/sc/source/core/data/table1.cxx b/sc/source/core/data/table1.cxx
index e09018d..2bc2705 100644
--- a/sc/source/core/data/table1.cxx
+++ b/sc/source/core/data/table1.cxx
@@ -245,7 +245,6 @@ ScTable::ScTable( ScDocument* pDoc, SCTAB nNewTab, const 
OUString& rNewName,
 mpHiddenRows(new ScFlatBoolRowSegments),
 mpFilteredCols(new ScFlatBoolColSegments),
 mpFilteredRows(new ScFlatBoolRowSegments),
-maFilteredRowCount(

Re: Apple Numbers application and format.

[Tor Lillqvist]

> We have documents describing the ODF file formats, it is the similar
thing for numbers I look for.

It is not publicly documented.

--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: DPI and screen resolution on OS X

[Armin Le Grand]

Hi,

comments inline

Am 03.02.2016 um 12:35 schrieb SOS:


On 3/02/2016 11:32, Chris Sherlock wrote:

On 3 Feb 2016, at 7:24 PM, SOS  wrote:


On 3/02/2016 3:55, Kohei Yoshida wrote:

On Wed, 2016-02-03 at 10:52 +1100, Chris Sherlock wrote:

The other question is: why would we not want to the actual DPI and
screen resolution?

My understanding is that, historically, the OS provided a function to
query DPI but what gets returned from such function was not always
accurate (or always not accurate depending on who you ask). So, the
workaround at the time was to assume that DPI is always 96 (and
hard-code that value) regardless of what the OS told you, which worked
just fine because the monitors used back in the day had the same 
screen

resolution.
Mostly DPI is found in the header of a pixelfile (taken by camera). 
Unfortunately it's not the photographer who gets to decide about the 
needed DPI.
DPI is actually a wrong definition for documents, Dots Per Inch is a 
definition used by output devices. Screens need a PIXEL par DOT but 
for print devices there is no precise correlation between the number 
of dots used by the device and the pixels needed in  the image for 
having a maximum image-view quality.

The print industry has come to some standards by trial and error.
- monitor screens need 96 - (220-retina) pixels per inch
- laser printers need 150 pixels per inch (up tot 2000 + dots)
- offset printers need 254 -300 pixels per inch (up to 3000 dots)
Definitely true :-) Only in OS X’s case, it doesn’t actually report 
back the correct resolution unless you ask for the backing coordinate 
system.


The PPI business is a red herring I think I’ve introduced into this 
discussion I’m afraid. We calculate the PPI ourselves (and call it 
DPI) based on the reported pixels, and the size of the screen in mm 
(which we obviously convert to inches).
its a bit the wrong discussion: what we see on screen has no 
relevance: the user can "zoom" the document until he is happy with the 
image quality on screen
But in the current situation, LO users has no idea how big (size) he 
can place a image in a document.
When the doc is intented for online use (email and Web) then there is 
a minimum of 96 pixels par inch needed. More is no problem but is in 
many cases a overkill.
Who is editing a "book" or a "magazine" need minimal 254 pixels par 
inch to has a good image quality after printing.
When using less pixels the book pages  are looking fine on screen put 
shall have a creepy print quality
So having a new "DocumentProperty" indicating the needed pixels (for 
printing)  make it possible to make the "size" calculations before 
inserting.


It is relevant. If you have a vector graphic and it gets converted to 
bitmap, the DPI from the system is used to define the resulting pixel 
size. Conversion to bitmap happens more often than it might seem. Examples:

- user chooses to do so (context menu, convert to bitmap)
- some exporters who are not capable using vector graphics
- PDF, e.g. PDF/1A which is not allowed to use transprencies and solves 
by creating bitmaps where graphics and transparent parts overlap

- 3D renderer which targets to bitmaps (chart, 3D objects)
Thus, the system DPI is essential. If on Mac, the bigger DPI will be 
used, it will enlarge all these conversions.


HTH!



I guess I’m curious as to what is relying on the screen resolution 
and PPI.


Although… it’s funny that we have the function 
SalGraphics::GetResolution, but that returns the PPI!


Chris
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice


--
--
ALG (PGP Key: EE1C 4B3F E751 D8BC C485 DEC1 3C59 F953 D81C F4A2)

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Apple Numbers application and format.

[jan iversen]

Sent from my iPad, please excuse any misspellings 

> I may have misunderstood you, but you might find answers here: 
> https://bugs.documentfoundation.org/show_bug.cgi?id=97334
> 
Thanks, Dennis really did a super job with that, which is very helpful, but it 
missed the essential part, how does the raw file look like. We have documents 
describing the ODF file formats, it is the similar thing for numbers I look for.

rgds
jan i.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: idl/inc idl/source sc/sdi sd/sdi sfx2/sdi starmath/sdi svx/sdi sw/sdi

[Noel Grandin]

 idl/inc/globals.hxx |2 
 idl/inc/slot.hxx|2 
 idl/source/objects/slot.cxx |8 
 idl/source/prj/command.cxx  |1 
 idl/source/prj/globals.cxx  |1 
 sc/sdi/scalc.sdi|  360 -
 sd/sdi/sdnew.sdi|3 
 sd/sdi/sdraw.sdi|  283 ---
 sfx2/sdi/sfx.sdi|  302 -
 starmath/sdi/smath.sdi  |   36 --
 svx/sdi/svx.sdi |  626 
 sw/sdi/swriter.sdi  |  419 -
 12 files changed, 2043 deletions(-)

New commits:
commit d9e362e4516a5df77f3edd12d57ce224a0a4979d
Author: Noel Grandin 
Date:   Wed Feb 3 13:23:09 2016 +0200

remove unused HasCoreId from SDI files

Change-Id: I4aca4b8a79ce92d64ce004ccdb7e9a0f408dc768

diff --git a/idl/inc/globals.hxx b/idl/inc/globals.hxx
index b748244..ab12cb7 100644
--- a/idl/inc/globals.hxx
+++ b/idl/inc/globals.hxx
@@ -43,7 +43,6 @@ struct SvGlobalHashNames
 SvStringHashEntryRef MM_Get;
 SvStringHashEntryRef MM_Set;
 SvStringHashEntryRef MM_SlotId;
-SvStringHashEntryRef MM_HasCoreId;
 SvStringHashEntryRef MM_Cachable;
 SvStringHashEntryRef MM_Volatile;
 SvStringHashEntryRef MM_Toggle;
@@ -148,7 +147,6 @@ HASH_INLINE(shell)
 HASH_INLINE(Get)
 HASH_INLINE(Set)
 HASH_INLINE(SlotId)
-HASH_INLINE(HasCoreId)
 HASH_INLINE(Cachable)
 HASH_INLINE(Volatile)
 HASH_INLINE(Toggle)
diff --git a/idl/inc/slot.hxx b/idl/inc/slot.hxx
index 8ed5d39..165388b 100644
--- a/idl/inc/slot.hxx
+++ b/idl/inc/slot.hxx
@@ -28,7 +28,6 @@ class SvMetaSlot : public SvMetaAttribute
 SvMetaTypeRef   aSlotType;
 SvMetaAttributeRef aMethod;
 SvIdentifieraGroupId;
-SvBOOL  aHasCoreId;
 SvIdentifieraConfigId;
 SvIdentifieraExecMethod;
 SvIdentifieraStateMethod;
@@ -158,7 +157,6 @@ public:
 
 SvMetaAttribute *   GetMethod() const;
 SvMetaType *GetSlotType() const;
-boolGetHasCoreId() const;
 const OString& GetGroupId() const;
 const OString& GetConfigId() const;
 const OString& GetExecMethod() const;
diff --git a/idl/source/objects/slot.cxx b/idl/source/objects/slot.cxx
index 9876016..9f0e036 100644
--- a/idl/source/objects/slot.cxx
+++ b/idl/source/objects/slot.cxx
@@ -98,11 +98,6 @@ SvMetaAttribute * SvMetaSlot::GetMethod() const
 if( aMethod.Is() || !GetRef() ) return aMethod;
 return static_cast(GetRef())->GetMethod();
 }
-bool SvMetaSlot::GetHasCoreId() const
-{
-if( aHasCoreId.IsSet() || !GetRef() ) return aHasCoreId;
-return static_cast(GetRef())->GetHasCoreId();
-}
 const OString& SvMetaSlot::GetGroupId() const
 {
 if( !aGroupId.getString().isEmpty() || !GetRef() ) return 
aGroupId.getString();
@@ -281,7 +276,6 @@ void SvMetaSlot::ReadAttributesSvIdl( SvIdlDataBase & rBase,
 bool bOk = false;
 bOk |= aDefault.ReadSvIdl( SvHash_Default(), rInStm );
 bOk |= aPseudoSlots.ReadSvIdl( SvHash_PseudoSlots(), rInStm );
-bOk |= aHasCoreId.ReadSvIdl( SvHash_HasCoreId(), rInStm );
 bOk |= aGroupId.ReadSvIdl( SvHash_GroupId(), rInStm );
 bOk |= aExecMethod.ReadSvIdl( SvHash_ExecMethod(), rInStm );
 bOk |= aStateMethod.ReadSvIdl( SvHash_StateMethod(), rInStm );
@@ -832,8 +826,6 @@ void SvMetaSlot::WriteSlot( const OString& rShellName, 
sal_uInt16 nCount,
 WriteTab( rOutStm, 4 );
 
 // write flags
-if( GetHasCoreId() )
-rOutStm.WriteCharPtr( MakeSlotName( SvHash_HasCoreId() ).getStr() 
).WriteChar( '|' );
 if( GetCachable() )
 rOutStm.WriteCharPtr( MakeSlotName( SvHash_Cachable() ).getStr() 
).WriteChar( '|' );
 if( GetVolatile() )
diff --git a/idl/source/prj/command.cxx b/idl/source/prj/command.cxx
index 1ccade4..b1c8708 100644
--- a/idl/source/prj/command.cxx
+++ b/idl/source/prj/command.cxx
@@ -84,7 +84,6 @@ char const * SyntaxStrings[] = {
 "\t\tFastCall",
 "\t\tGet, Set",
 "\t\tGroupId= Identifier",
-"\t\tHasCoreId",
 "\t\tHasDialog",
 "\t\tIsCollection",
 "\t\tImageRotation",
diff --git a/idl/source/prj/globals.cxx b/idl/source/prj/globals.cxx
index 68dba1c..6665fcc 100644
--- a/idl/source/prj/globals.cxx
+++ b/idl/source/prj/globals.cxx
@@ -71,7 +71,6 @@ SvGlobalHashNames::SvGlobalHashNames()
 , MM_Get( INS( "Get" ) )
 , MM_Set( INS( "Set" ) )
 , MM_SlotId( INS( "SlotId" ) )
-, MM_HasCoreId( INS( "HasCoreId" ) )
 , MM_Cachable( INS( "Cachable" ) )
 , MM_Toggle( INS( "Toggle" ) )
 , MM_AutoUpdate( INS( "AutoUpdate" ) )
diff --git a/sc/sdi/scalc.sdi b/sc/sdi/scalc.sdi
index fda341a..0372daf 100644
--- a/sc/sdi/scalc.sdi
+++ b/sc/sdi/scalc.sdi
@@ -23,7 +23,6 @@ SfxVoidItem AcceptChanges FID_CHG_ACCEPT
 AutoUpdate = FALSE,
 Cachable = Cachable,
 FastCall = FALSE,
-HasCoreId = FALSE,
 HasDialog = FALSE,
 ReadOnlyDoc = TRUE,
 Toggle = FALSE,
@@ -48,7 +47,6 @@ SfxVoidItem ActivateOLE SID_OLE_ACTIVATE
 AutoUp

RE: Apple Numbers application and format.

[Winfried Donkers]

Hi Jan,

> With a little help in IRC (Thanks) I managed to convert a ods (calc) file
> to apple's number application using .xlsx as an intermidiate format.
> 
> Does anybody know, where I can find a specificition of the numbers file
> format ?

I may have misunderstood you, but you might find answers here: 
https://bugs.documentfoundation.org/show_bug.cgi?id=97334

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Apple Numbers application and format.

[Chris Sherlock]

What exactly are you trying to do?

Chris

> On 3 Feb 2016, at 11:58 PM, jan iversen  wrote:
> 
> Hi.
> 
> With a little help in IRC (Thanks) I managed to convert a ods (calc) file to 
> apple's number application using .xlsx as an intermidiate format.
> 
> Does anybody know, where I can find a specificition of the numbers file 
> format ?
> 
> if the format is known, it cannot be that hard to write import/export 
> functions, and my time would be better spend than converting file formats.
> 
> thanks in advance
> rgds
> jan i.
> 
> 
> Sent from my iPad, please excuse any misspellings 
> ___
> LibreOffice mailing list
> LibreOffice@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice