[Libreoffice-bugs] [Bug 39641] Clean up document type association on Linux

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39641

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88796] Enhancement - Mysql native connector extension - add automatic reconnect to server capability in connector code after idle timeout

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88796

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90834] Turn in-line version control history comments into meaningful good comments

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90834

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed target:5.2.0   |target:5.2.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96971] SetXORMode - remove un-needed parameter ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96971

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39625] make sal/qa/systools/test_comtools.cxx work (Windows only) ....

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39625

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 33467] Mac: Default printer should be taken from the OS when printing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=33467

jan iversen  changed:

   What|Removed |Added

   Keywords|easyHack|
 Whiteboard|ToBeReviewed|

--- Comment #14 from jan iversen  ---
NEEDINFO is also used to get code pointers, but no problem.

Removed easy hack keyword, due to missing code pointers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67741] EDITING: Date entry with numeric keypad

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=67741

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 39596] use the CLang++ static analyser to find bugs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=39596

jan iversen  changed:

   What|Removed |Added

 Whiteboard|ToBeReviewed|

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/uiconfig

[Stanislav Horacek]

 sw/uiconfig/swriter/ui/mmresultemaildialog.ui |2 +-
 sw/uiconfig/swriter/ui/mmresultprintdialog.ui |2 +-
 sw/uiconfig/swriter/ui/mmresultsavedialog.ui  |2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 16777b6bb0267c2b0602f1007a1e1fecac81329b
Author: Stanislav Horacek 
Date:   Thu Apr 28 22:37:53 2016 +0200

mark numbers in mail merge dialogs as untranslatable

Change-Id: I4dd5d8914e637ee3e8c89752e2daf563222cc494
Reviewed-on: https://gerrit.libreoffice.org/24467
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sw/uiconfig/swriter/ui/mmresultemaildialog.ui 
b/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
index 9717550..61494df 100644
--- a/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
+++ b/sw/uiconfig/swriter/ui/mmresultemaildialog.ui
@@ -370,7 +370,7 @@
   
 True
 True
-1
+1
 
   
 
diff --git a/sw/uiconfig/swriter/ui/mmresultprintdialog.ui 
b/sw/uiconfig/swriter/ui/mmresultprintdialog.ui
index 7168b67..a19a207 100644
--- a/sw/uiconfig/swriter/ui/mmresultprintdialog.ui
+++ b/sw/uiconfig/swriter/ui/mmresultprintdialog.ui
@@ -230,7 +230,7 @@
   
 True
 True
-1
+1
 1
 
   
diff --git a/sw/uiconfig/swriter/ui/mmresultsavedialog.ui 
b/sw/uiconfig/swriter/ui/mmresultsavedialog.ui
index 639be9f..db75e48 100644
--- a/sw/uiconfig/swriter/ui/mmresultsavedialog.ui
+++ b/sw/uiconfig/swriter/ui/mmresultsavedialog.ui
@@ -163,7 +163,7 @@
   
 True
 True
-1
+1
 
   
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-ux-advise] [Bug 95357] TRACK CHANGES: Change tracking movement/action are inconsistent for replacements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95357

jan iversen  changed:

   What|Removed |Added

 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - officecfg/registry

[Guillaume Smaha]

 officecfg/registry/data/org/openoffice/Office/Common.xcu |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 6ca35a05e8f5f41482535ecab307dc393dacc5cc
Author: Guillaume Smaha 
Date:   Wed Apr 27 14:51:05 2016 +0200

Specify Alfresco 5 in the list, it also compatible

Change-Id: I29d32253259c296e2e5fedcff241573479b2d4a3
Reviewed-on: https://gerrit.libreoffice.org/24426
Reviewed-by: Samuel Mehrbrodt 
Tested-by: Samuel Mehrbrodt 
(cherry picked from commit 2c47053e7edd062e6a7abd3ff889b756018ff7c3)
Reviewed-on: https://gerrit.libreoffice.org/24462
Tested-by: Jenkins 

diff --git a/officecfg/registry/data/org/openoffice/Office/Common.xcu 
b/officecfg/registry/data/org/openoffice/Office/Common.xcu
index 7cf3e97..074c475 100644
--- a/officecfg/registry/data/org/openoffice/Office/Common.xcu
+++ b/officecfg/registry/data/org/openoffice/Office/Common.xcu
@@ -583,7 +583,7 @@
 OneDrive
 Alfresco Cloud
 
-Alfresco 4
+Alfresco 4/5
 IBM FileNet P8
 Lotus Live Files
 Lotus Quickr Domino
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit 0e4c624f0b8dda80e1a0c4f848a35de8826d453e
Author: Ashod Nakashian 
Date:   Thu Apr 28 23:33:24 2016 -0400

loolwsd: minor improvement to test assertions

Change-Id: I40da725919ae775d039217c258ecd28a743b5bc1
Reviewed-on: https://gerrit.libreoffice.org/24484
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index e052b99..1880ab6 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -232,27 +232,27 @@ void HTTPWSTest::testHandShake()
 socket.setReceiveTimeout(0);
 bytes = socket.receiveFrame(buffer, sizeof(buffer), flags);
 CPPUNIT_ASSERT_EQUAL(std::string(payload), std::string(buffer, bytes));
-CPPUNIT_ASSERT(flags == Poco::Net::WebSocket::FRAME_TEXT);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags);
 
 bytes = socket.receiveFrame(buffer, sizeof(buffer), flags);
 if (!std::strstr(buffer, fail))
 {
 payload = "statusindicator: connect";
 CPPUNIT_ASSERT_EQUAL(payload, std::string(buffer, bytes));
-CPPUNIT_ASSERT(flags == Poco::Net::WebSocket::FRAME_TEXT);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags);
 
 bytes = socket.receiveFrame(buffer, sizeof(buffer), flags);
 if (!std::strstr(buffer, fail))
 {
 payload = "statusindicator: ready";
 CPPUNIT_ASSERT_EQUAL(payload, std::string(buffer, bytes));
-CPPUNIT_ASSERT(flags == Poco::Net::WebSocket::FRAME_TEXT);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags);
 }
 else
 {
 // check error message
 CPPUNIT_ASSERT(std::strstr(buffer, 
SERVICE_UNAVALABLE_INTERNAL_ERROR) != nullptr);
-CPPUNIT_ASSERT(flags == Poco::Net::WebSocket::FRAME_TEXT);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags);
 
 // close frame message
 bytes = socket.receiveFrame(buffer, sizeof(buffer), flags);
@@ -264,7 +264,7 @@ void HTTPWSTest::testHandShake()
 {
 // check error message
 CPPUNIT_ASSERT(std::strstr(buffer, 
SERVICE_UNAVALABLE_INTERNAL_ERROR) != nullptr);
-CPPUNIT_ASSERT(flags == Poco::Net::WebSocket::FRAME_TEXT);
+
CPPUNIT_ASSERT_EQUAL(static_cast(Poco::Net::WebSocket::FRAME_TEXT), flags);
 
 // close frame message
 bytes = socket.receiveFrame(buffer, sizeof(buffer), flags);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/LOOLWSD.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit afa3e7c4ed6d1d23f182d18882d2b20fd7f8eabe
Author: Ashod Nakashian 
Date:   Thu Apr 28 23:32:33 2016 -0400

loolwsd: log error on failure, not success

Change-Id: Iac417c3779f3879697d056b5e402e91902bfd168
Reviewed-on: https://gerrit.libreoffice.org/24483
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 395770f..5de9afc 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -607,7 +607,7 @@ private:
 // Use auto-save to save only when there are modifications 
since last save.
 // We also need to wait until the save notification reaches us
 // and Storage persists the document.
-if (docBroker->autoSave(true, COMMAND_TIMEOUT_MS))
+if (!docBroker->autoSave(true, COMMAND_TIMEOUT_MS))
 {
 Log::error("Auto-save before closing failed.");
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   16 
 1 file changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 42a88e2362e78509d2ad7341b1d5f48086138430
Author: Ashod Nakashian 
Date:   Thu Apr 28 22:48:19 2016 -0400

loolwsd: fix load test regression

Change-Id: Icadd22306f61338698aedb1b6b5d4e02246d9a4e
Reviewed-on: https://gerrit.libreoffice.org/24482
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 9994f92..e052b99 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -332,25 +332,25 @@ void HTTPWSTest::loadDoc(const std::string& documentURL)
 // Load a document and get its status.
 auto socket = loadDocAndGetSocket(_uri, documentURL);
 
-std::string status;
-std::string editlock;
 SocketProcessor("", socket, [&](const std::string& msg)
 {
 const std::string prefix = "status: ";
 if (msg.find(prefix) == 0)
 {
-status = msg.substr(prefix.length());
+const auto status = msg.substr(prefix.length());
+// Might be too strict, consider something flexible 
instread.
+CPPUNIT_ASSERT_EQUAL(std::string("type=text parts=1 
current=0 width=12808 height=16408"), status);
+}
+else if (msg.find("editlock") == 0)
+{
+// First session always gets the lock.
+CPPUNIT_ASSERT_EQUAL(std::string("editlock: 1"), msg);
 return false;
 }
 
 return true;
 });
 
-// Might be too strict, consider something flexible instread.
-CPPUNIT_ASSERT_EQUAL(std::string("type=text parts=1 current=0 
width=12808 height=16408"), status);
-// First session always gets the lock.
-CPPUNIT_ASSERT_EQUAL(std::string("editlock: 1"), editlock);
-
 socket->shutdown();
 }
 catch (const Poco::Exception& exc)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/helpers.hpp |   34 ++
 1 file changed, 22 insertions(+), 12 deletions(-)

New commits:
commit c6380f5820a85968d3d29023ae64c9b918cda27d
Author: Ashod Nakashian 
Date:   Thu Apr 28 22:44:40 2016 -0400

loolwsd: test logging cleanup

Change-Id: Ie2fa40eab6fec4cfe9819d75f1c35efd835b11b7
Reviewed-on: https://gerrit.libreoffice.org/24480
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index 3933f38..b7dae3d 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -56,15 +56,20 @@ void getDocumentPathAndURL(const char* document, 
std::string& documentPath, std:
 std::cerr << "Test file: " << documentPath << std::endl;
 }
 
-static
+inline
 void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& string)
 {
 socket.sendFrame(string.data(), string.size());
 }
 
-static
-bool isDocumentLoaded(Poco::Net::WebSocket& ws)
+inline
+bool isDocumentLoaded(Poco::Net::WebSocket& ws, std::string name = "")
 {
+if (!name.empty())
+{
+name += ' ';
+}
+
 bool isLoaded = false;
 try
 {
@@ -74,7 +79,6 @@ bool isDocumentLoaded(Poco::Net::WebSocket& ws)
 const Poco::Timespan waitTime(100);
 
 ws.setReceiveTimeout(0);
-std::cout << "==> isDocumentLoaded\n";
 do
 {
 char buffer[READ_BUFFER_SIZE];
@@ -82,10 +86,9 @@ bool isDocumentLoaded(Poco::Net::WebSocket& ws)
 if (ws.poll(waitTime, Poco::Net::Socket::SELECT_READ))
 {
 bytes = ws.receiveFrame(buffer, sizeof(buffer), flags);
-std::cout << "Got " << bytes << " bytes, flags: " << std::hex 
<< flags << std::dec << '\n';
 if (bytes > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE)
 {
-std::cout << "Received message: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << '\n';
+std::cout << name << "Got " << bytes << " bytes: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << std::endl;
 const std::string line = 
LOOLProtocol::getFirstLine(buffer, bytes);
 const std::string prefixIndicator = 
"statusindicatorfinish:";
 const std::string prefixStatus = "status:";
@@ -95,6 +98,11 @@ bool isDocumentLoaded(Poco::Net::WebSocket& ws)
 break;
 }
 }
+else
+{
+std::cerr << name << "Got " << bytes << " bytes, flags: " 
<< std::hex << flags << std::dec << std::endl;
+}
+
 retries = 10;
 }
 else
@@ -118,7 +126,7 @@ bool isDocumentLoaded(Poco::Net::WebSocket& ws)
 // jobs to establish the bridge connection between the Client and Kit process,
 // The result, it is mostly time outs to get messages in the unit test and it 
could fail.
 // connectLOKit ensures the websocket is connected to a kit process.
-static
+inline
 std::shared_ptr
 connectLOKit(Poco::URI uri,
  Poco::Net::HTTPRequest& request,
@@ -172,7 +180,7 @@ connectLOKit(Poco::URI uri,
 return ws;
 }
 
-static
+inline
 void getResponseMessage(Poco::Net::WebSocket& ws, const std::string& prefix, 
std::string& response, const bool isLine)
 {
 try
@@ -184,7 +192,6 @@ void getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix, std
 
 response.clear();
 ws.setReceiveTimeout(0);
-std::cout << "==> getResponseMessage(" << prefix << ")\n";
 do
 {
 char buffer[READ_BUFFER_SIZE];
@@ -192,10 +199,9 @@ void getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix, std
 if (ws.poll(waitTime, Poco::Net::Socket::SELECT_READ))
 {
 bytes = ws.receiveFrame(buffer, sizeof(buffer), flags);
-std::cout << "Got " << bytes << " bytes, flags: " << std::hex 
<< flags << std::dec << '\n';
 if (bytes > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE)
 {
-std::cout << "Received message: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << '\n';
+std::cout << "Got " << bytes << " bytes: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << std::endl;
 const std::string message = isLine ?
 
LOOLProtocol::getFirstLine(buffer, bytes) :
 std::string(buffer, bytes);
@@ -206,6 +212,10 @@ void getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix, std
 break;
 }
  

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpcrashtest.cpp |  133 +
 1 file changed, 5 insertions(+), 128 deletions(-)

New commits:
commit 472f959bec565734a8270100dfac22197c67ee8f
Author: Ashod Nakashian 
Date:   Thu Apr 28 22:47:09 2016 -0400

loolwsd: more sharing of common test code

Change-Id: Id49118eb38633127327fc16e5f49137255e78425
Reviewed-on: https://gerrit.libreoffice.org/24481
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpcrashtest.cpp b/loolwsd/test/httpcrashtest.cpp
index 68f8ccc..7615677 100644
--- a/loolwsd/test/httpcrashtest.cpp
+++ b/loolwsd/test/httpcrashtest.cpp
@@ -42,6 +42,9 @@
 #include 
 #include 
 #include 
+#include "helpers.hpp"
+
+using namespace helpers;
 
 /// Tests the HTTP WebSocket API of loolwsd. The server has to be started 
manually before running this test.
 class HTTPCrashTest : public CPPUNIT_NS::TestFixture
@@ -62,16 +65,6 @@ class HTTPCrashTest : public CPPUNIT_NS::TestFixture
 static
 void killLoKitProcesses();
 
-static
-void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& 
string);
-
-static
-bool isDocumentLoaded(Poco::Net::WebSocket& socket);
-
-std::shared_ptr
-connectLOKit(Poco::Net::HTTPRequest& request,
- Poco::Net::HTTPResponse& response);
-
 public:
 HTTPCrashTest()
 #if ENABLE_SSL
@@ -118,7 +111,7 @@ void HTTPCrashTest::testBarren()
 const std::string documentURL = "file://" + 
Poco::Path(documentPath).makeAbsolute().toString();
 
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-Poco::Net::WebSocket socket = *connectLOKit(request, _response);
+Poco::Net::WebSocket socket = *connectLOKit(_uri, request, _response);
 
 sendTextFrame(socket, "load url=" + documentURL);
 sendTextFrame(socket, "status");
@@ -172,7 +165,7 @@ void HTTPCrashTest::testCrashKit()
 const std::string documentURL = "file://" + 
Poco::Path(documentPath).makeAbsolute().toString();
 
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-Poco::Net::WebSocket socket = *connectLOKit(request, _response);
+Poco::Net::WebSocket socket = *connectLOKit(_uri, request, _response);
 
 sendTextFrame(socket, "load url=" + documentURL);
 sendTextFrame(socket, "status");
@@ -243,122 +236,6 @@ void HTTPCrashTest::killLoKitProcesses()
 }
 }
 
-void HTTPCrashTest::sendTextFrame(Poco::Net::WebSocket& socket, const 
std::string& string)
-{
-socket.sendFrame(string.data(), string.size());
-}
-
-bool HTTPCrashTest::isDocumentLoaded(Poco::Net::WebSocket& ws)
-{
-bool isLoaded = false;
-try
-{
-int flags;
-int bytes;
-int retries = 30;
-const Poco::Timespan waitTime(100);
-
-ws.setReceiveTimeout(0);
-std::cout << "==> isDocumentLoaded\n";
-do
-{
-char buffer[READ_BUFFER_SIZE];
-
-if (ws.poll(waitTime, Poco::Net::Socket::SELECT_READ))
-{
-bytes = ws.receiveFrame(buffer, sizeof(buffer), flags);
-std::cout << "Got " << bytes << " bytes, flags: " << std::hex 
<< flags << std::dec << '\n';
-if (bytes > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE)
-{
-std::cout << "Received message: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << '\n';
-const std::string line = 
LOOLProtocol::getFirstLine(buffer, bytes);
-const std::string prefixIndicator = 
"statusindicatorfinish:";
-const std::string prefixStatus = "status:";
-if (line.find(prefixIndicator) == 0 || 
line.find(prefixStatus) == 0)
-{
-isLoaded = true;
-break;
-}
-}
-retries = 10;
-}
-else
-{
-std::cout << "Timeout\n";
---retries;
-}
-}
-while (retries > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) 
!= Poco::Net::WebSocket::FRAME_OP_CLOSE);
-}
-catch (const Poco::Net::WebSocketException& exc)
-{
-std::cout << exc.message();
-}
-
-return isLoaded;
-}
-
-// Connecting to a Kit process is managed by document broker, that it does 
several
-// jobs to establish the bridge connection between the Client and Kit process,
-// The result, it is mostly time outs to get messages in the unit test and it 
could fail.
-// connectLOKit ensures the websocket is connected to a kit process.
-
-std::shared_ptr
-HTTPCrashTest::connectLOKit(Poco::Net::HTTPRequest& request,
-

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/helpers.hpp |   22 --
 1 file changed, 16 insertions(+), 6 deletions(-)

New commits:
commit 7f17561f7aae52148f2778e71e10fd67df7f6376
Author: Ashod Nakashian 
Date:   Thu Apr 28 22:43:59 2016 -0400

loolwsd: test SocketProcessor supports timeout

Change-Id: I1cf277c67840f35a0f79884c9b1c644b0769b5fd
Reviewed-on: https://gerrit.libreoffice.org/24479
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index 24ba1ac..3933f38 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -47,7 +47,7 @@
 /// These are supposed to be testing the latter.
 namespace helpers
 {
-static
+inline
 void getDocumentPathAndURL(const char* document, std::string& documentPath, 
std::string& documentURL)
 {
 documentPath = Util::getTempFilePath(TDOC, document);
@@ -246,25 +246,35 @@ std::shared_ptr 
loadDocAndGetSocket(const Poco::URI& uri,
 return nullptr;
 }
 
-static
+inline
 void SocketProcessor(std::string name,
  const std::shared_ptr& socket,
- std::function handler)
+ std::function handler,
+ const size_t timeoutMs = 1)
 {
 if (!name.empty())
 {
 name += ' ';
 }
 
+socket->setReceiveTimeout(0);
+
+const Poco::Timespan waitTime(timeoutMs * 1000);
 int flags;
 int n;
+char buffer[READ_BUFFER_SIZE];
 do
 {
-char buffer[READ_BUFFER_SIZE];
+if (!socket->poll(waitTime, Poco::Net::Socket::SELECT_READ))
+{
+std::cerr << "Timeout." << std::endl;
+break;
+}
+
 n = socket->receiveFrame(buffer, sizeof(buffer), flags);
 if (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE)
 {
-std::cout << name + "Got " << n << " bytes: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, n) << std::endl;
+std::cout << name << "Got " << n << " bytes: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, n) << std::endl;
 if (!handler(std::string(buffer, n)))
 {
 break;
@@ -272,7 +282,7 @@ void SocketProcessor(std::string name,
 }
 else
 {
-std::cerr << name + "Got " << n << " bytes, flags: " << std::hex 
<< flags << std::dec << std::endl;
+std::cerr << name << "Got " << n << " bytes, flags: " << std::hex 
<< flags << std::dec << std::endl;
 }
 }
 while (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/countloolkits.hpp   |   76 ++-
 loolwsd/test/httpwstest.cpp  |   64 ++
 loolwsd/test/integration-http-server.cpp |4 -
 3 files changed, 82 insertions(+), 62 deletions(-)

New commits:
commit 40d694d9ef089988296e01ed4c011642d445491b
Author: Ashod Nakashian 
Date:   Thu Apr 28 22:01:05 2016 -0400

loolwsd: moved loolkit process counting to own file and minimized wait

Change-Id: Ib7950fe7d97ca3484aadb1d7a7492ad1a88e375a
Reviewed-on: https://gerrit.libreoffice.org/24478
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/countloolkits.hpp b/loolwsd/test/countloolkits.hpp
index 1fb1ba5..2490f22 100644
--- a/loolwsd/test/countloolkits.hpp
+++ b/loolwsd/test/countloolkits.hpp
@@ -10,7 +10,81 @@
 #ifndef INCLUDED_COUNTLOOLKITPROCESSES_HPP
 #define INCLUDED_COUNTLOOLKITPROCESSES_HPP
 
-extern int countLoolKitProcesses();
+#include 
+#include 
+
+/// Counts the number of LoolKit process instances without wiating.
+static
+int getLoolKitProcessCount()
+{
+int result = 0;
+for (auto i = Poco::DirectoryIterator(std::string("/proc")); i != 
Poco::DirectoryIterator(); ++i)
+{
+try
+{
+Poco::Path procEntry = i.path();
+const std::string& fileName = procEntry.getFileName();
+int pid;
+std::size_t endPos = 0;
+try
+{
+pid = std::stoi(fileName, );
+}
+catch (const std::invalid_argument&)
+{
+pid = 0;
+}
+if (pid > 1 && endPos == fileName.length())
+{
+Poco::FileInputStream stat(procEntry.toString() + "/stat");
+std::string statString;
+Poco::StreamCopier::copyToString(stat, statString);
+Poco::StringTokenizer tokens(statString, " ");
+if (tokens.count() > 3 && tokens[1] == "(loolkit)")
+{
+switch (tokens[2].c_str()[0])
+{
+case 'x':
+case 'X': // Kinds of dead-ness.
+case 'Z': // zombies
+break; // ignore
+default:
+result++;
+break;
+}
+// std::cout << "Process:" << pid << ", '" << tokens[1] << 
"'" << " state: " << tokens[2] << std::endl;
+}
+}
+}
+catch (const Poco::Exception&)
+{
+}
+}
+
+// std::cout << "Number of loolkit processes: " << result << std::endl;
+return result;
+}
+
+static
+int countLoolKitProcesses(const int expected, const int timeoutMs = 
POLL_TIMEOUT_MS * 5)
+{
+const size_t repeat = (timeoutMs + POLL_TIMEOUT_MS - 1) / POLL_TIMEOUT_MS;
+auto count = getLoolKitProcessCount();
+for (size_t i = 0; i < repeat; ++i)
+{
+if (count == expected)
+{
+return count;
+}
+
+// Give polls in the lool processes time to time out etc
+Poco::Thread::sleep(POLL_TIMEOUT_MS);
+
+count = getLoolKitProcessCount();
+}
+
+return count;
+}
 
 #endif
 
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index f57d710..9994f92 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -15,7 +15,6 @@
 #include 
 #include 
 
-#include 
 #include 
 #include 
 #include 
@@ -160,6 +159,7 @@ public:
 
 void tearDown()
 {
+testNoExtraLoolKitsLeft();
 }
 };
 
@@ -167,7 +167,7 @@ int HTTPWSTest::_initialLoolKitCount = 0;
 
 void HTTPWSTest::testCountHowManyLoolkits()
 {
-_initialLoolKitCount = countLoolKitProcesses();
+_initialLoolKitCount = getLoolKitProcessCount();
 CPPUNIT_ASSERT(_initialLoolKitCount > 0);
 }
 
@@ -520,7 +520,7 @@ void HTTPWSTest::testReloadWhileDisconnecting()
 sendTextFrame(socket, "uno .uno:Delete");
 sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa 
bbb ccc");
 
-kitcount = countLoolKitProcesses();
+kitcount = getLoolKitProcessCount();
 
 // Shutdown abruptly.
 socket.shutdown();
@@ -542,7 +542,7 @@ void HTTPWSTest::testReloadWhileDisconnecting()
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket));
 
 // Should have no new instances.
-CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses());
+CPPUNIT_ASSERT_EQUAL(kitcount, getLoolKitProcessCount());
 
 // Check if the document contains the pasted text.
 sendTextFrame(socket, "uno .uno:SelectAll");
@@ -1225,7 +1225,7 @@ void HTTPWSTest::testEditLock()
 
 void HTTPWSTest::testNoExtraLoolKitsLeft()
 {
-int countNow = countLoolKitProcesses();
+

[Libreoffice-bugs] [Bug 96320] Enhancement request: Colors of hyperlinks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96320

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #2 from Kumāra  ---
ma...@posteo.de, for what you want to do, you may find the workaround in Bug
69565.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/helpers.hpp|  283 ++
 loolwsd/test/httpwstest.cpp |  294 +++-
 2 files changed, 307 insertions(+), 270 deletions(-)

New commits:
commit c164096c539775e15e96ddcc4f11ff3cb19d60e6
Author: Ashod Nakashian 
Date:   Thu Apr 28 21:41:00 2016 -0400

loolwsd: factored out common test helpers

Change-Id: Iad2794f1b458f04bdd1fb9d3f965afd91adbade8
Reviewed-on: https://gerrit.libreoffice.org/24477
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
new file mode 100644
index 000..24ba1ac
--- /dev/null
+++ b/loolwsd/test/helpers.hpp
@@ -0,0 +1,283 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include "config.h"
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#include 
+#include 
+#include 
+#include 
+
+/// Common helper testing functions.
+/// Avoid the temptation to reuse from LOOL code!
+/// These are supposed to be testing the latter.
+namespace helpers
+{
+static
+void getDocumentPathAndURL(const char* document, std::string& documentPath, 
std::string& documentURL)
+{
+documentPath = Util::getTempFilePath(TDOC, document);
+documentURL = "file://" + 
Poco::Path(documentPath).makeAbsolute().toString();
+
+std::cerr << "Test file: " << documentPath << std::endl;
+}
+
+static
+void sendTextFrame(Poco::Net::WebSocket& socket, const std::string& string)
+{
+socket.sendFrame(string.data(), string.size());
+}
+
+static
+bool isDocumentLoaded(Poco::Net::WebSocket& ws)
+{
+bool isLoaded = false;
+try
+{
+int flags;
+int bytes;
+int retries = 30;
+const Poco::Timespan waitTime(100);
+
+ws.setReceiveTimeout(0);
+std::cout << "==> isDocumentLoaded\n";
+do
+{
+char buffer[READ_BUFFER_SIZE];
+
+if (ws.poll(waitTime, Poco::Net::Socket::SELECT_READ))
+{
+bytes = ws.receiveFrame(buffer, sizeof(buffer), flags);
+std::cout << "Got " << bytes << " bytes, flags: " << std::hex 
<< flags << std::dec << '\n';
+if (bytes > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != Poco::Net::WebSocket::FRAME_OP_CLOSE)
+{
+std::cout << "Received message: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, bytes) << '\n';
+const std::string line = 
LOOLProtocol::getFirstLine(buffer, bytes);
+const std::string prefixIndicator = 
"statusindicatorfinish:";
+const std::string prefixStatus = "status:";
+if (line.find(prefixIndicator) == 0 || 
line.find(prefixStatus) == 0)
+{
+isLoaded = true;
+break;
+}
+}
+retries = 10;
+}
+else
+{
+std::cout << "Timeout\n";
+--retries;
+}
+}
+while (retries > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) 
!= Poco::Net::WebSocket::FRAME_OP_CLOSE);
+}
+catch (const Poco::Net::WebSocketException& exc)
+{
+std::cout << exc.message();
+}
+
+return isLoaded;
+}
+
+
+// Connecting to a Kit process is managed by document broker, that it does 
several
+// jobs to establish the bridge connection between the Client and Kit process,
+// The result, it is mostly time outs to get messages in the unit test and it 
could fail.
+// connectLOKit ensures the websocket is connected to a kit process.
+static
+std::shared_ptr
+connectLOKit(Poco::URI uri,
+ Poco::Net::HTTPRequest& request,
+ Poco::Net::HTTPResponse& response)
+{
+int flags;
+int received = 0;
+int retries = 3;
+bool ready = false;
+char buffer[READ_BUFFER_SIZE];
+std::shared_ptr ws;
+
+do
+{
+#if ENABLE_SSL
+Poco::Net::HTTPSClientSession session(uri.getHost(), uri.getPort());
+#else
+Poco::Net::HTTPClientSession session(uri.getHost(), uri.getPort());
+#endif
+std::cerr << "Connecting... ";
+ws = std::make_shared(session, request, 
response);
+
+do
+{
+try
+{
+

[Libreoffice-bugs] [Bug 41429] font color formatting of hyperlinks in calc does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41429

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #7 from Kumāra  ---
This may be related to Bug 69565.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69565] FORMATTING: cannot remove underlining or change color of hyperlinks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69565

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #7 from Kumāra  ---
Still (annoyingly) present in 5.1.1.3. (Much thanks to Ernestas for reporting
and for showing a workaround.)

For most people who likely wouldn't even think there's a workaround, it's a
major accessibility issue when you need to use a dark background.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82251] EDITING: Crash Draw upon past of graphic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82251

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Resolution|--- |WORKSFORME

--- Comment #13 from V Stuart Foote  ---
Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: en-US (en_US)

Was this ever confirmed as an issue?

Anyhow, in both test documents comment 2 and comment 6 no issues with copy
paste, paste move, paste--nor the select and move, nor select and hold in
place.

Seems pretty stable at 5.1.2.2 resolved WFM.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99560] Windows 10 AMD Libreoffice unuseable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99560

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||vstuart.fo...@utsa.edu
 Ever confirmed|0   |1

--- Comment #1 from V Stuart Foote  ---
Try it with the OpenGL rendering disabled...

Tools -> Options -> View: Use OpenGL for all rendering (on restart)

If that clears things up a bit, post details from your opengl_device.log in the
case directory of your user profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99546] "Save As Template..." broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99546

--- Comment #2 from Kumāra  ---
(In reply to Regina Henschel from comment #1)
> The step "highlighted the template file (set as default)" is wrong in your
> workflow. Instead use the 'save' icon in the Template Manager without
> selecting any existing template, and then enter the name of the existing
> default template into the name box.

I see. Thanks. The current way is not user-friendly though. Now I see what Bug
95402 is all about.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95402] TEMPLATE MANAGER: Improve Save as Template workflow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95402

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #8 from Kumāra  ---
I fully agree on the need for a better workflow. Currently it confuses me. I
couldn't get it to work, causing me to think there's a bug. See Bug 99546.

I'd say this is more than just an enhancement. It's somewhat a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 95402] TEMPLATE MANAGER: Improve Save as Template workflow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95402

Kumāra  changed:

   What|Removed |Added

 CC||kumara.bhik...@gmail.com

--- Comment #8 from Kumāra  ---
I fully agree on the need for a better workflow. Currently it confuses me. I
couldn't get it to work, causing me to think there's a bug. See Bug 99546.

I'd say this is more than just an enhancement. It's somewhat a bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] online.git: loolwsd/Makefile.am loolwsd/test

[Ashod Nakashian]

 loolwsd/Makefile.am |2 
 loolwsd/test/Makefile.am|2 
 loolwsd/test/httpwstest.cpp |  122 
 3 files changed, 124 insertions(+), 2 deletions(-)

New commits:
commit 575e09307675c68f95ccea17dacfe04894601606
Author: Ashod Nakashian 
Date:   Thu Apr 28 17:02:45 2016 -0400

loolwsd: editlock and takeedit tests

Change-Id: Ie2458aed1da0624f1769b6b75f134cb0fed0db75
Reviewed-on: https://gerrit.libreoffice.org/24475
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/Makefile.am b/loolwsd/Makefile.am
index 8c34c85..5ba1681 100644
--- a/loolwsd/Makefile.am
+++ b/loolwsd/Makefile.am
@@ -49,7 +49,7 @@ loolwsd_SOURCES = Admin.cpp \
 
 noinst_PROGRAMS = connect \
   lokitclient \
- loolforkit-nocaps
+  loolforkit-nocaps
 
 connect_SOURCES = Connect.cpp \
   Log.cpp \
diff --git a/loolwsd/test/Makefile.am b/loolwsd/test/Makefile.am
index 4a7663b..7c26f38 100644
--- a/loolwsd/test/Makefile.am
+++ b/loolwsd/test/Makefile.am
@@ -10,7 +10,7 @@ noinst_LTLIBRARIES = \
 unit-admin.la
 
 MAGIC_TO_FORCE_SHLIB_CREATION = -rpath /dummy
-AM_LDFLAGS = -module $(MAGIC_TO_FORCE_SHLIB_CREATION)
+AM_LDFLAGS = -pthread -module $(MAGIC_TO_FORCE_SHLIB_CREATION)
 AM_CPPFLAGS = -pthread -I$(top_srcdir)
 
 test_CPPFLAGS = -DTDOC=\"$(top_srcdir)/test/data\"
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 9f9d9b0..c594c0d 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -10,6 +10,9 @@
 #include "config.h"
 
 #include 
+#include 
+#include 
+#include 
 #include 
 
 #include 
@@ -71,6 +74,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testPasswordProtectedDocumentWithCorrectPassword);
 CPPUNIT_TEST(testPasswordProtectedDocumentWithCorrectPasswordAgain);
 CPPUNIT_TEST(testInsertDelete);
+CPPUNIT_TEST(testEditLock);
 CPPUNIT_TEST(testClientPartImpress);
 CPPUNIT_TEST(testClientPartCalc);
 #if ENABLE_DEBUG
@@ -104,6 +108,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testClientPartCalc();
 void testSimultaneousTilesRenderedJustOnce();
 void testNoExtraLoolKitsLeft();
+void testEditLock();
 
 void loadDoc(const std::string& documentURL);
 
@@ -1130,6 +1135,123 @@ void HTTPWSTest::testSimultaneousTilesRenderedJustOnce()
 socket2.shutdown();
 }
 
+void HTTPWSTest::testEditLock()
+{
+const std::string documentPath = Util::getTempFilePath(TDOC, "hello.odt");
+const std::string documentURL = "file://" + 
Poco::Path(documentPath).makeAbsolute().toString();
+
+std::mutex mutex;
+std::condition_variable cv;
+volatile bool second_client_died = false;
+
+// The first client loads the document and checks that it has the lock.
+// It then waits until the lock is taken away.
+std::thread first_client([&]()
+{
+try
+{
+std::cerr << "First client loading." << std::endl;
+auto socket = loadDocAndGetSocket(documentURL);
+std::string editlock1;
+SocketProcessor("First", socket, [&](const std::string& msg)
+{
+if (msg.find("editlock") == 0)
+{
+if (editlock1.empty())
+{
+std::cerr << "First client has the lock." 
<< std::endl;
+
CPPUNIT_ASSERT_EQUAL(std::string("editlock: 1"), msg);
+editlock1 = msg;
+
+// Initial condition met, connect second 
client.
+std::cerr << "Starting second client." << 
std::endl;
+cv.notify_one();
+}
+else if (editlock1 == "editlock: 1")
+{
+if (second_client_died)
+{
+// We had lost the lock to the second 
client,
+// but we should get it back once they 
die.
+std::cerr << "First client is given 
the lock." << std::endl;
+
CPPUNIT_ASSERT_EQUAL(std::string("editlock: 1"), msg);
+return false; // Done!
+}
+else
+{
+// Normal broadcast when the second 
client joins.
+std::cerr << "First client still has 
the lock." << 

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/MasterProcessSession.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp  |1 +
 loolwsd/MasterProcessSession.cpp |   11 +--
 2 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit e2cf1a5b52f261394f7989122e79356a69128de9
Author: Ashod Nakashian 
Date:   Thu Apr 28 07:31:55 2016 -0400

loolwsd: always send status before other messages

Except for loading progress messages (statusindicator).

Change-Id: I42f79167c3ff953fc4e283854468cd7e8bd54bc3
Reviewed-on: https://gerrit.libreoffice.org/24474
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index cc7b603..f159ca8 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -587,6 +587,7 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 }
 
 // Respond by the document status, which has no arguments.
+Log::debug("Sending status after load.");
 if (!getStatus(nullptr, 0))
 return false;
 
diff --git a/loolwsd/MasterProcessSession.cpp b/loolwsd/MasterProcessSession.cpp
index f8e321f..c1fa22d 100644
--- a/loolwsd/MasterProcessSession.cpp
+++ b/loolwsd/MasterProcessSession.cpp
@@ -202,7 +202,10 @@ bool MasterProcessSession::_handleInput(const char 
*buffer, int length)
 {
 _docBroker->tileCache().saveTextFile(std::string(buffer, 
length), "status.txt");
 
-// let clients know if they hold the edit lock
+// Forward the status response to the client.
+forwardToPeer(buffer, length);
+
+// And let clients know if they hold the edit lock.
 std::string message = "editlock: ";
 message += std::to_string(peer->isEditLocked());
 Log::debug("Forwarding [" + message + "] in response to 
status.");
@@ -397,13 +400,9 @@ bool MasterProcessSession::loadDocument(const char* 
/*buffer*/, int /*length*/,
 bool MasterProcessSession::getStatus(const char *buffer, int length)
 {
 const std::string status = 
_docBroker->tileCache().getTextFile("status.txt");
-if (status.size() > 0)
+if (!status.empty())
 {
 sendTextFrame(status);
-// let clients know if they hold the edit lock
-std::string message = "editlock: ";
-message += std::to_string(isEditLocked());
-sendTextFrame(message);
 return true;
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   39 ---
 1 file changed, 24 insertions(+), 15 deletions(-)

New commits:
commit f44660aa99f8f325aa4e8b58e299d7b210906556
Author: Ashod Nakashian 
Date:   Thu Apr 28 07:27:17 2016 -0400

loolwsd: unittest cleanups

Change-Id: Ib9b915c7ca2df03afba7f4e1fb37b8fff846a474
Reviewed-on: https://gerrit.libreoffice.org/24473
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 31350a2..9f9d9b0 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -120,7 +120,8 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 const bool isLine);
 
 static
-void SocketProcessor(const std::shared_ptr& socket,
+void SocketProcessor(std::string name,
+ const std::shared_ptr& socket,
  std::function handler);
 
 void checkTiles(Poco::Net::WebSocket& socket,
@@ -357,7 +358,7 @@ void HTTPWSTest::loadDoc(const std::string& documentURL)
 
 std::string status;
 std::string editlock;
-SocketProcessor(socket, [&](const std::string& msg)
+SocketProcessor("", socket, [&](const std::string& msg)
 {
 const std::string prefix = "status: ";
 if (msg.find(prefix) == 0)
@@ -467,6 +468,8 @@ void HTTPWSTest::testSaveOnDisconnect()
 sendTextFrame(socket, "uno .uno:Delete");
 sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa 
bbb ccc");
 
+std::cerr << "Closing connection after pasting." << std::endl;
+
 // Shutdown abruptly.
 socket.shutdown();
 }
@@ -477,7 +480,7 @@ void HTTPWSTest::testSaveOnDisconnect()
 
 // Allow time to save and destroy before we connect again.
 sleep(5);
-std::cout << "Loading again." << std::endl;
+std::cerr << "Loading again." << std::endl;
 try
 {
 // Load the same document and check that the last changes (pasted 
text) is saved.
@@ -1509,7 +1512,6 @@ HTTPWSTest::connectLOKit(Poco::Net::HTTPRequest& request,
 int retries = 3;
 bool ready = false;
 char buffer[READ_BUFFER_SIZE];
-const std::string success("ready");
 std::shared_ptr ws;
 
 do
@@ -1519,6 +1521,7 @@ HTTPWSTest::connectLOKit(Poco::Net::HTTPRequest& request,
 #else
 Poco::Net::HTTPClientSession session(_uri.getHost(), _uri.getPort());
 #endif
+std::cerr << "Connecting... ";
 ws = std::make_shared(session, request, 
response);
 
 do
@@ -1530,7 +1533,7 @@ HTTPWSTest::connectLOKit(Poco::Net::HTTPRequest& request,
 {
 const std::string message = 
LOOLProtocol::getFirstLine(buffer, received);
 std::cerr << message << std::endl;
-if (message.find(success) != std::string::npos)
+if (message.find("ready") != std::string::npos)
 {
 ready = true;
 break;
@@ -1539,11 +1542,7 @@ HTTPWSTest::connectLOKit(Poco::Net::HTTPRequest& request,
 }
 catch (const Poco::TimeoutException& exc)
 {
-std::cout << exc.displayText();
-}
-catch(...)
-{
-throw;
+std::cout << exc.displayText() << std::endl;
 }
 }
 while (received > 0 && (flags & 
Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE);
@@ -1562,10 +1561,10 @@ std::shared_ptr 
HTTPWSTest::loadDocAndGetSocket(const std:
 {
 // Load a document and get its status.
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-auto socket = connectLOKit(request, _response);
+Poco::Net::HTTPResponse response;
+auto socket = connectLOKit(request, response);
 
 sendTextFrame(*socket, "load url=" + documentURL);
-sendTextFrame(*socket, "status");
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(*socket));
 
 return socket;
@@ -1580,23 +1579,33 @@ std::shared_ptr 
HTTPWSTest::loadDocAndGetSocket(const std:
 }
 
 
-void HTTPWSTest::SocketProcessor(const std::shared_ptr& 
socket, std::function handler)
+void HTTPWSTest::SocketProcessor(std::string name,
+ const std::shared_ptr& 
socket,
+ std::function 
handler)
 {
+if (!name.empty())
+{
+name += ' ';
+}
+
 int flags;
 int n;
 do
 {
 char buffer[READ_BUFFER_SIZE];
 n = socket->receiveFrame(buffer, sizeof(buffer), flags);
-

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 2efaa6e06b212740abcb89ce26ad9ab8d585d204
Author: Ashod Nakashian 
Date:   Wed Apr 27 20:52:32 2016 -0400

loolwsd: save documents when timestamp is within 10 seconds

Due to filesystem timestamp precision and other factors
we assume a timestamp match within 10 seconds to mean
the document has been recently saved and store it.

A document has to have an older than 10 seconds
modified timestamp compared to our last timestamp
to be deemed unchanged in the interim and skipped
from storing again.

Change-Id: I39b4bf64b221ba30dc7b818a330e779a2d0ecbd4
Reviewed-on: https://gerrit.libreoffice.org/24472
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 69728cb..ac1ed91 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -152,8 +152,11 @@ bool DocumentBroker::save()
 std::unique_lock lock(_saveMutex);
 
 const auto uri = _uriPublic.toString();
+
+// If the file hasn't been modified within the past 10 seconds, skip 
saving.
 const auto newFileModifiedTime = 
Poco::File(_storage->getLocalRootPath()).getLastModified();
-if (newFileModifiedTime == _lastFileModifiedTime)
+const auto elapsed = newFileModifiedTime - _lastFileModifiedTime;
+if (std::abs(elapsed) > 10 * 1000 * 1000)
 {
 // Nothing to do.
 Log::debug("Skipping unnecessary saving to URI [" + uri + "].");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp loolwsd/LOOLSession.cpp loolwsd/LOOLSession.hpp loolwsd/MasterProcessSession.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp  |   12 ++--
 loolwsd/ChildProcessSession.hpp  |   10 ++
 loolwsd/LOOLKit.cpp  |   30 +++---
 loolwsd/LOOLSession.cpp  |4 ++--
 loolwsd/LOOLSession.hpp  |2 +-
 loolwsd/MasterProcessSession.cpp |2 +-
 6 files changed, 31 insertions(+), 29 deletions(-)

New commits:
commit 1dd88e68ea6e39c5785b61001e2388a886bfeb7b
Author: Ashod Nakashian 
Date:   Wed Apr 27 20:51:54 2016 -0400

loolwsd: shortened some long identifiers

Change-Id: I87809f5ad2a6d8f546cf3abaf646672d2d8168dc
Reviewed-on: https://gerrit.libreoffice.org/24471
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index d727cfd..cc7b603 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -277,8 +277,8 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  std::shared_ptr ws,
  LibreOfficeKitDocument * 
loKitDocument,
  const std::string& jailId,
- 
std::function onLoad,
- std::function onUnload) :
+ OnLoadCallback onLoad,
+ OnUnloadCallback onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
 _multiView(std::getenv("LOK_VIEW_CALLBACK")),
@@ -554,19 +554,19 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 std::string timestamp;
 parseDocOptions(tokens, part, timestamp);
 
-std::string renderingOptions;
+std::string renderOpts;
 if (!_docOptions.empty())
 {
 Parser parser;
 Poco::Dynamic::Var var = parser.parse(_docOptions);
 Object::Ptr object = var.extract();
-renderingOptions = object->get("rendering").toString();
+renderOpts = object->get("rendering").toString();
 }
 
 assert(!_docURL.empty());
 assert(!_jailedFilePath.empty());
 
-_loKitDocument = _onLoad(getId(), _jailedFilePath, _docPassword, 
renderingOptions, _isDocPasswordProvided);
+_loKitDocument = _onLoad(getId(), _jailedFilePath, _docPassword, 
renderOpts, _haveDocPassword);
 if (!_loKitDocument)
 {
 Log::error("Failed to get LoKitDocument instance.");
@@ -578,7 +578,7 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 if (_multiView)
 {
 _viewId = _loKitDocument->pClass->getView(_loKitDocument);
-_loKitDocument->pClass->initializeForRendering(_loKitDocument, 
(renderingOptions.empty() ? nullptr : renderingOptions.c_str()));
+_loKitDocument->pClass->initializeForRendering(_loKitDocument, 
(renderOpts.empty() ? nullptr : renderOpts.c_str()));
 }
 
 if (_docType != "text" && part != -1)
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index b614195..77710fe 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -23,6 +23,8 @@
 #include "LOOLSession.hpp"
 
 class CallbackWorker;
+typedef std::function OnLoadCallback;
+typedef std::function OnUnloadCallback;
 
 class ChildProcessSession final : public LOOLSession
 {
@@ -38,8 +40,8 @@ public:
 std::shared_ptr ws,
 LibreOfficeKitDocument * loKitDocument,
 const std::string& jailId,
-std::function onLoad,
-std::function onUnload);
+OnLoadCallback onLoad,
+OnUnloadCallback onUnload);
 virtual ~ChildProcessSession();
 
 virtual bool getStatus(const char *buffer, int length) override;
@@ -100,8 +102,8 @@ private:
 /// View ID, returned by createView() or 0 by default.
 int _viewId;
 std::map _lastDocStates;
-std::function _onLoad;
-std::function _onUnload;
+OnLoadCallback _onLoad;
+OnUnloadCallback _onUnload;
 
 std::unique_ptr _callbackWorker;
 Poco::Thread _callbackThread;
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 624eb98..cb3446a 100644

[Libreoffice-commits] online.git: loolwsd/ChildProcessSession.cpp loolwsd/ChildProcessSession.hpp loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/ChildProcessSession.cpp |   29 -
 loolwsd/ChildProcessSession.hpp |4 ++--
 loolwsd/LOOLKit.cpp |   19 +++
 3 files changed, 33 insertions(+), 19 deletions(-)

New commits:
commit 7ff5be1f701f44dbec70bbbaeac50b9ba654b074
Author: Ashod Nakashian 
Date:   Wed Apr 27 20:42:45 2016 -0400

loolwsd: document rendering options should be set once

When loading a document first we set the rendering
options. Beyond that, the document is shared and
we shouldn't change the rendering options.

Change-Id: I0d2ac6fc43553b8395111ba2b8a3cc2796d2f0a4
Reviewed-on: https://gerrit.libreoffice.org/24470
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/ChildProcessSession.cpp b/loolwsd/ChildProcessSession.cpp
index 45ac69d..d727cfd 100644
--- a/loolwsd/ChildProcessSession.cpp
+++ b/loolwsd/ChildProcessSession.cpp
@@ -277,7 +277,7 @@ ChildProcessSession::ChildProcessSession(const std::string& 
id,
  std::shared_ptr ws,
  LibreOfficeKitDocument * 
loKitDocument,
  const std::string& jailId,
- 
std::function onLoad,
+ 
std::function onLoad,
  std::function onUnload) :
 LOOLSession(id, Kind::ToMaster, ws),
 _loKitDocument(loKitDocument),
@@ -554,30 +554,33 @@ bool ChildProcessSession::loadDocument(const char * 
/*buffer*/, int /*length*/,
 std::string timestamp;
 parseDocOptions(tokens, part, timestamp);
 
+std::string renderingOptions;
+if (!_docOptions.empty())
+{
+Parser parser;
+Poco::Dynamic::Var var = parser.parse(_docOptions);
+Object::Ptr object = var.extract();
+renderingOptions = object->get("rendering").toString();
+}
+
 assert(!_docURL.empty());
 assert(!_jailedFilePath.empty());
 
-_loKitDocument = _onLoad(getId(), _jailedFilePath, _docPassword, 
_isDocPasswordProvided);
-
+_loKitDocument = _onLoad(getId(), _jailedFilePath, _docPassword, 
renderingOptions, _isDocPasswordProvided);
 if (!_loKitDocument)
+{
+Log::error("Failed to get LoKitDocument instance.");
 return false;
+}
 
 std::unique_lock lock(Mutex);
 
 if (_multiView)
-_viewId = _loKitDocument->pClass->getView(_loKitDocument);
-
-std::string renderingOptions;
-if (!_docOptions.empty())
 {
-Parser parser;
-Poco::Dynamic::Var var = parser.parse(_docOptions);
-Object::Ptr object = var.extract();
-renderingOptions = object->get("rendering").toString();
+_viewId = _loKitDocument->pClass->getView(_loKitDocument);
+_loKitDocument->pClass->initializeForRendering(_loKitDocument, 
(renderingOptions.empty() ? nullptr : renderingOptions.c_str()));
 }
 
-_loKitDocument->pClass->initializeForRendering(_loKitDocument, 
(renderingOptions.empty() ? nullptr : renderingOptions.c_str()));
-
 if (_docType != "text" && part != -1)
 {
 _loKitDocument->pClass->setPart(_loKitDocument, part);
diff --git a/loolwsd/ChildProcessSession.hpp b/loolwsd/ChildProcessSession.hpp
index 39b6d51..b614195 100644
--- a/loolwsd/ChildProcessSession.hpp
+++ b/loolwsd/ChildProcessSession.hpp
@@ -38,7 +38,7 @@ public:
 std::shared_ptr ws,
 LibreOfficeKitDocument * loKitDocument,
 const std::string& jailId,
-std::function onLoad,
+std::function onLoad,
 std::function onUnload);
 virtual ~ChildProcessSession();
 
@@ -100,7 +100,7 @@ private:
 /// View ID, returned by createView() or 0 by default.
 int _viewId;
 std::map _lastDocStates;
-std::function _onLoad;
+std::function _onLoad;
 std::function _onUnload;
 
 std::unique_ptr _callbackWorker;
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 5af4248..624eb98 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -464,7 

[Libreoffice-bugs] [Bug 99561] New: CALC seems to duplicate items during sort

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99561

Bug ID: 99561
   Summary: CALC seems to duplicate items during sort
   Product: LibreOffice
   Version: unspecified
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: roadapa...@gmail.com

User-Agent:   Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Ubuntu Chromium/49.0.2623.108 Chrome/49.0.2623.108 Safari/537.36
Build Identifier: LibreOffice 5.1.2.2

I had copied glossaries into Calc and then sorting them when I noticed that 2-3
terms were showing up, each identical to the other. However, the original list
does not have duplicates. 

Reproducible: Always

Steps to Reproduce:
1. Take a glossary of any kind (I used sociology terms)
2. Paste into Calc
3. I process the first term by adding a column (a space between term and
definition)
4. I sort.
I do this 4-5 times during the whole process.

Actual Results:  
Sorting works, but mysteriously there are extra rows that appear with duplicate
terms.

Expected Results:  
NO DUPLICATES. Should be impossible.

[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 82251] EDITING: Crash Draw upon past of graphic

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=82251

--- Comment #12 from MarjaE  ---
Could not reproduce in OSX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 69401] Crash after copy & pasting a large number of shapes and saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=69401

--- Comment #10 from MarjaE  ---
Slightly different behavior on the Mac.

I was able to take the test file, copy, paste, and save, but had LOO freeze and
go unresponsive when I tried to quite. I was able to force quit. I found that
the sample document had retained the saved changes after reopening.

I just lost an hours worth of work, which I thought I had saved, when Loo
crashed on me.

I don't know if that was the same bug, or something else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99560] New: Windows 10 AMD Libreoffice unuseable

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99560

Bug ID: 99560
   Summary: Windows 10 AMD Libreoffice unuseable
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: daniel.schwer...@googlemail.com

System: AMD A4-5000 (internal graphics)
OS: Windows 10 x64 Build 10586
AMD Driver: 16.3.2
(LibreOffice 4.4.7.2 is running perfectly fine)

I tested LO 5.1.2.2. There were always some graphical glitches with text and
draw files.

And I couldn't open more than one of my old files on this new version. The
second window keeps crashing. I tested different file type combinations(odt,
ods, odg).
I also removed the %AppData% Folders of LO and reinstalled. 

For my work setup I need 5 LO files constantly opened. One ods file, 2 odt and
2 odg. 

So I recreated those files with placeholder text and my layout (one jpg
embedded).
I got nasty text glitches when I created odg aside of odt files on the other
file while it was opened. ods files were fine tough.

I'll gladly help on debugging this. 
I think this problem is a bit obscure. My old file layout dates back to 2011,
so they're pretty old. And got constantly changed and saved every day.

(Also I had problems while installing: the installer said, that the process
'Explorer.exe' locks up files. Maybe this is a hint.)

Thanks. 
Daniel

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99512] Calc don't display correctly time cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99512

--- Comment #21 from Tomaz Vajngerl  ---
Maybe the latest dev build of LibreOffice still doesn't have this code.. it is
rather new.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] Meta: VCL/OpenGL tracker bug for 5.0+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93529

--- Comment #28 from V Stuart Foote  ---
adding bug 99521 - UI Menu problems on multi-monitor system

nVidia GeForce GTX 560 with current 10.18.13.6472 driver on Windows 7

Blank menu elements when LibreOffice 5.1.2.2 open on secondary monitory, OK on
primary display. No issue when OpenGL disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93529] Meta: VCL/OpenGL tracker bug for 5.0+

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93529

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||99521

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 Blocks||93529

--- Comment #10 from V Stuart Foote  ---
Given support level for the GPU/driver mix, to me this is a legitimate bug. 

But testing the mix to confirm could prove a challenge--Windows 7 and a GTX 560
GPU. I've moved my nVidia systems to Windows 8.1 and 10--dual monitor but I
don't get the same issue.

Adding to the OpenGL meta issue bug 93529 for visibility, one of the devs
working on the numerous OpenGL glitches may get back to you with specific
questions.

Meanwhile if you need to use the second monitor, disable OpenGL or just try to
stay on the primary display ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99556] CRASH: NULL pointer dereference in MathML node.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99556

--- Comment #4 from Sergey Zelenyuk  ---
Sorry, I'm a bad programmer and I try to do the best I can. My position is that
a programmer is responsible for a code that he write, even it is only a bug
fix. If the one cannot maintain the code after he had wrote it, the one should
not do it at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #9 from Richard  ---
Created attachment 124710
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124710=edit
Opengl Viewer report

Capture of report information from the OpenGL Extensions viewer. Note that my
card is listed as 100% compatible up through 4.4.  The only items listed as not
fully compatible are 4.5 (90%) and ARB 2015 (30%).

If there is anything else I can provide let me know  As a Firmware Engr.
myself I know how helpful any "good" :-) information is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #8 from V Stuart Foote  ---
@Richard,

The driver string is passing the balcklist--which is why 5.1.2.2 is opening for
you with OpenGL rendering enabled.

http://opengrok.libreoffice.org/xref/core/vcl/opengl/opengl_blacklist_windows.xml

which cuts off with the nVidia 353.62 driver release. 

You can see we don't currently track GPU/driver combos for black-listing OpenGL
support on Windows (its worse on Linux) and just set the threshold by driver.

If you grab the OpenGL Extension Viewer utility from RealTech-VR

http://www.realtech-vr.com/glview/

you can test and post up the summary of just what your GPU/driver pairing
support, especially if you are getting 100% 4.4 support on your GTX560 based
card.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #7 from Richard  ---
Thanks for your assist...  

Also is there a link to the blacklist so I can check potential cards before I
purchase?  Tried searching google (libreoffice opengl blacklist) but all I got
were links to other bugs or unrelated items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #6 from Richard  ---
Created attachment 124709
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124709=edit
opengl_device.log

Requested opengl_device.log file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/LOOLProtocol.cpp

[Ashod Nakashian]

 loolwsd/LOOLProtocol.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 466ffc25dba5a893de8faaaecebd600b950027a0
Author: Ashod Nakashian 
Date:   Wed Apr 27 20:30:20 2016 -0400

Use [] around messages as they are more readable than ''

Change-Id: Id172bb03e8fa9dd148612d756d4a74fc501ea95c
Reviewed-on: https://gerrit.libreoffice.org/24469
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLProtocol.cpp b/loolwsd/LOOLProtocol.cpp
index 9420be8..a11d6d0 100644
--- a/loolwsd/LOOLProtocol.cpp
+++ b/loolwsd/LOOLProtocol.cpp
@@ -192,10 +192,10 @@ namespace LOOLProtocol
 // If first line is less than the length (minus newline), add eclipes.
 if (firstLine.size() < static_cast(length) - 1)
 {
-return std::string('\'' + firstLine + "'...");
+return std::string('[' + firstLine + "]...");
 }
 
-return std::string('\'' + firstLine + '\'');
+return std::string('[' + firstLine + ']');
 }
 };
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   97 +++-
 1 file changed, 69 insertions(+), 28 deletions(-)

New commits:
commit cf54d0d87e9acd38e5541959105bdfec1493d875
Author: Ashod Nakashian 
Date:   Tue Apr 26 23:46:09 2016 -0400

loolwsd: test helpers and more code sharing

Change-Id: I87e4ad23f9c2761a7a2acab4139b458696e07e64
Reviewed-on: https://gerrit.libreoffice.org/24468
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 5755a8d..31350a2 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -119,6 +119,10 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 std::string& response,
 const bool isLine);
 
+static
+void SocketProcessor(const std::shared_ptr& socket,
+ std::function handler);
+
 void checkTiles(Poco::Net::WebSocket& socket,
 const std::string& type);
 
@@ -137,6 +141,8 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 connectLOKit(Poco::Net::HTTPRequest& request,
  Poco::Net::HTTPResponse& response);
 
+std::shared_ptr loadDocAndGetSocket(const 
std::string& documentURL);
+
 public:
 HTTPWSTest()
 #if ENABLE_SSL
@@ -347,38 +353,28 @@ void HTTPWSTest::loadDoc(const std::string& documentURL)
 try
 {
 // Load a document and get its status.
-Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
-Poco::Net::WebSocket socket = *connectLOKit(request, _response);
-
-sendTextFrame(socket, "load url=" + documentURL);
-sendTextFrame(socket, "status");
-CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket));
+auto socket = loadDocAndGetSocket(documentURL);
 
 std::string status;
-int flags;
-int n;
-do
-{
-char buffer[READ_BUFFER_SIZE];
-n = socket.receiveFrame(buffer, sizeof(buffer), flags);
-std::cout << "Got " << n << " bytes, flags: " << std::hex << flags 
<< std::dec << std::endl;
-if (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE)
-{
-std::cout << "Received message: " << 
LOOLProtocol::getAbbreviatedMessage(buffer, n) << std::endl;
-const std::string line = LOOLProtocol::getFirstLine(buffer, n);
-const std::string prefix = "status: ";
-if (line.find(prefix) == 0)
+std::string editlock;
+SocketProcessor(socket, [&](const std::string& msg)
 {
-status = line.substr(prefix.length());
-// Might be too strict, consider something flexible 
instread.
-CPPUNIT_ASSERT_EQUAL(std::string("type=text parts=1 
current=0 width=12808 height=16408"), status);
-break;
-}
-}
-}
-while (n > 0 && (flags & Poco::Net::WebSocket::FRAME_OP_BITMASK) != 
Poco::Net::WebSocket::FRAME_OP_CLOSE);
+const std::string prefix = "status: ";
+if (msg.find(prefix) == 0)
+{
+status = msg.substr(prefix.length());
+return false;
+}
 
-socket.shutdown();
+return true;
+});
+
+// Might be too strict, consider something flexible instread.
+CPPUNIT_ASSERT_EQUAL(std::string("type=text parts=1 current=0 
width=12808 height=16408"), status);
+// First session always gets the lock.
+CPPUNIT_ASSERT_EQUAL(std::string("editlock: 1"), editlock);
+
+socket->shutdown();
 }
 catch (const Poco::Exception& exc)
 {
@@ -1560,6 +1556,51 @@ HTTPWSTest::connectLOKit(Poco::Net::HTTPRequest& request,
 return ws;
 }
 
+std::shared_ptr HTTPWSTest::loadDocAndGetSocket(const 
std::string& documentURL)
+{
+try
+{
+// Load a document and get its status.
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
+auto socket = connectLOKit(request, _response);
+
+sendTextFrame(*socket, "load url=" + documentURL);
+sendTextFrame(*socket, "status");
+CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(*socket));
+
+return socket;
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+
+// Really couldn't reach here, but the compiler doesn't know any better.
+return nullptr;
+}
+
+
+void HTTPWSTest::SocketProcessor(const std::shared_ptr& 
socket, std::function

[Libreoffice-bugs] [Bug 49853] Cmd-V or Cmd-A inside toolbar-hosted edit fields paste into document instead (OS X only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49853

--- Comment #146 from Paul Oranje  ---
(In reply to V Stuart Foote from comment #145)
> (In reply to Maxim Monastirsky from comment #142)
> > Well, the root cause seems
> ...
> > Now we only need to figure out what's the right way to fix this...
> 
> check out Matthew F's similar work for bug 62054
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=0350bcde37edb1f25cca68cb1447ba8f759aea15
> 
> and refs to
> http://stackoverflow.com/questions/970707/cocoa-keyboard-shortcuts-in-dialog-
> without-an-edit-menu

sendEvent() is kind of de-multiplexer. pKeyWin is assigned the keyWindow
property value (window that currently receives keyboard events).
The search bar is a SalFrameWindow; true?

If so, then the fix would be to add handling of the Cmd-A|C|V|X|z|Z events for
this window - currently no special handling for these cases exists. That these
events end up being handled by the document window is obviously the wrong
handler is dispatched.

Where would these dispatch statements be inserted in the code ?
Already the needed dispatch statement can be found in sendEvent() and just
changing but the conditions for these statements to be executed may be all
that's required. Currently the condition is that the window is not a
SalFrameWindow, it should probably be "if (! bHandled)" and the test for
pKeyWin 

The current code does things like "if (cond) { ... return;} else if {...}".
When the if true clause always causes a return, then "else" should be omitted
IMHO. Applied to the code of sendEvent() the control flow will be easier to
grasp.

Question: can sendEvent() recurse ? (possibly via pushback of event)
That would allow for kind of FSM style of code (though I would not dare to open
a Pandorra's box).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99559] New: If table has bad header (made in MS Word) LO Writer doesn't show the first row of data.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99559

Bug ID: 99559
   Summary: If table has bad header (made in MS Word) LO Writer
doesn't show the first row of data.
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: inforb...@gmail.com

Created attachment 124708
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124708=edit
File where Writer hides the first string of data in the table.

Sometimes users of MS Office create tables, where a long text is present in the
header, and part of that text is hidden in MS-Word representation. The header
of such a bad table looks different in LO Writer. (And I have no objections
against this.) But the strange and insidious thing in the Writer is that it
hides the first string of data in such tables. See the example file. Writer
doesn't show the first string "String1". Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - sc/inc sc/source

[Eike Rathke]

 sc/inc/document.hxx |   83 
 sc/source/core/data/document10.cxx  |  356 ++
 sc/source/core/data/formulacell.cxx |  372 
 3 files changed, 444 insertions(+), 367 deletions(-)

New commits:
commit 37b071c9330d28f08d5a9f7bf11e577040925684
Author: Eike Rathke 
Date:   Thu Apr 28 22:42:14 2016 +0200

move to ScDocument::CopyAdjustRangeName() and namespace

Change-Id: I1ec3c8cc1b8d3cb899d49192295b14ffac02849a

diff --git a/sc/inc/document.hxx b/sc/inc/document.hxx
index bb46e2d..a38279f 100644
--- a/sc/inc/document.hxx
+++ b/sc/inc/document.hxx
@@ -600,6 +600,40 @@ public:
 SCTAB nGlobalRefTab, SCTAB nLocalRefTab, SCTAB nOldTokenTab, SCTAB 
nOldTokenTabReplacement,
 bool bSameDoc, int nRecursion ) const;
 
+/** If necessary (name references sheet rOldPos.Tab()) copy and adjust
+named expression/range from sheet-local to sheet-local, or global to
+sheet-local if bGlobalNamesToLocal==true.
+
+Also copies nested names and adjusts the ocName tokens of the calling 
name.
+
+@param  rSheet
+On entry, the original sheet of the named expression/range, <0 
global.
+On return TRUE, the new sheet. Else unchanged.
+
+@param  rIndex
+On entry, the original index of the named expression/range.
+On return TRUE, the new index, or 0 if a new copied name 
couldn't be inserted. Else unchanged.
+
+@param  rpRangeData
+On entry, the pointer to the original named expression/range.
+On return TRUE, the pointer to the new copied name, or nullptr 
if hit shappened.
+
+@param  rNewPos
+New position of formula cell if called for that, else new base
+position of a to be created new name adjusted for Tab.
+rNewPos.nTab MUST point to the new sheet copied to.
+
+@param  rOldPos
+Old position of formula cell if called for that, else base
+position of the existing name adjusted for Tab.
+rOldPos.nTab MUST point to the old sheet copied from.
+
+@return TRUE if copied and caller may need to evaluate rpRangeData and 
rSheet and rIndex.
+FALSE if nothing to be done.
+ */
+bool CopyAdjustRangeName( SCTAB& rSheet, sal_uInt16& rIndex, ScRangeData*& 
rpRangeData, ScDocument& rNewDoc,
+const ScAddress& rNewPos, const ScAddress& rOldPos, const bool 
bGlobalNamesToLocal) const;
+
 /**
  * Call this immediately before updating all named ranges.
  */
diff --git a/sc/source/core/data/document10.cxx 
b/sc/source/core/data/document10.cxx
index 80375b8..f7ed6e8 100644
--- a/sc/source/core/data/document10.cxx
+++ b/sc/source/core/data/document10.cxx
@@ -513,4 +513,296 @@ bool ScDocument::FindRangeNamesReferencingSheet( 
sc::UpdatedRangeNames& rIndexes
 return bRef;
 }
 
+namespace {
+
+enum MightReferenceSheet
+{
+UNKNOWN,
+NONE,
+CODE,
+NAME
+};
+
+MightReferenceSheet mightRangeNameReferenceSheet( ScRangeData* pData, SCTAB 
nRefTab)
+{
+ScTokenArray* pCode = pData->GetCode();
+if (!pCode)
+return MightReferenceSheet::NONE;
+
+for (const formula::FormulaToken* p = pCode->First(); p; p = pCode->Next())
+{
+if (p->GetOpCode() == ocName)
+return MightReferenceSheet::NAME;
+}
+
+return pCode->ReferencesSheet( nRefTab, pData->GetPos().Tab()) ?
+MightReferenceSheet::CODE : MightReferenceSheet::NONE;
+}
+
+ScRangeData* copyRangeName( const ScRangeData* pOldRangeData, ScDocument& 
rNewDoc, const ScDocument* pOldDoc,
+const ScAddress& rNewPos, const ScAddress& rOldPos, bool 
bGlobalNamesToLocal,
+SCTAB nOldSheet, const SCTAB nNewSheet, bool bSameDoc)
+{
+ScAddress aRangePos( pOldRangeData->GetPos());
+if (nNewSheet >= 0)
+aRangePos.SetTab( nNewSheet);
+ScRangeData* pRangeData = new ScRangeData(*pOldRangeData, , 
);
+pRangeData->SetIndex(0);// needed for insert to assign a new index
+ScTokenArray* pRangeNameToken = pRangeData->GetCode();
+if (bSameDoc && nNewSheet >= 0)
+{
+if (bGlobalNamesToLocal && nOldSheet < 0)
+{
+nOldSheet = rOldPos.Tab();
+if (rNewPos.Tab() <= nOldSheet)
+// Sheet was inserted before and references already updated.
+++nOldSheet;
+}
+pRangeNameToken->AdjustSheetLocalNameReferences( nOldSheet, nNewSheet);
+}
+if (!bSameDoc)
+{
+pRangeNameToken->ReadjustAbsolute3DReferences(pOldDoc, , 
pRangeData->GetPos(), true);
+pRangeNameToken->AdjustAbsoluteRefs(pOldDoc, rOldPos, rNewPos, true);
+}
+
+bool bInserted;
+if (nNewSheet < 0)
+bInserted = rNewDoc.GetRangeName()->insert(pRangeData);
+else
+bInserted = 

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #6 from Michael Stahl  ---
Created attachment 124707
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124707=edit
stack trace of the premature idle invocation

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99383] Problem with toolbar in LO Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99383

--- Comment #5 from Michael Stahl  ---
the problem is apparently caused by TransferableHelper::CopyToSelection using
SolarMutexReleaser.

... [ the message being dispatched there is SAL_MSG_TIMER_CALLBACK ... actually
no the message isn't dispatched there usually only when the debugger messes up
the timing ]

... real problem is an Idle being dispatched - SfxDispatcher::EventHdl_Impl
- this pops a SwTextShell, SwNavigationShell off the stack and pushes
SwNavigationShell and then it calls SfxDispatcher::Update_Impl which apparently
updates the toolbar.

... this is happening inside SwView::SelectShell, here:

eShellMode = SHELL_MODE_DRAW;
m_pShell = new SwDrawShell( *this );
rDispatcher.Push( *m_pShell );

the SwDrawBaseShell constructor calls the CopyToSelection stuff...
clearly it's not intended that the SfxDispatcher idle handler runs before
the new shell is pushed onto the SfxDispatcher.

the SfxDispatcher::xImp->aIdle is started from SfxDispatcher::Pop().

so either we shouldn't run the idle handler via SolarMutexReleaser,
or something needs to prevent execution of the SfxDispatcher idle handler until
the stack manipulation is finished.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95658] Repagination caused by changing print settings in File > Print .. under "Range and Copies" is too slow

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95658

--- Comment #17 from Aron Budea  ---
I tested this in Windows, and the cultprit seems to be ImplScaleConvolution
(+called functions). It's far from an exact measure, but adding a breakpoint to
the beginning and the end of the function can confirm noticeable time is spent
in there.
http://opengrok.libreoffice.org/xref/core/vcl/source/bitmap/BitmapScaleConvolution.cxx#268

Also, just as a vague pointer, the issue appeared somewhere between 4.0 and
4.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97774] From Tools SQL - Insert Works in Windows not on Linux – easily reproducible.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97774

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||854

--- Comment #3 from Julien Nabet  ---
I can't give it a try because of tdf#97854 (crash when deleting a
relationship).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97854] BASE crash on deleting inner join relationship

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97854

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||774

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99541] '.uno:GoToCell' call selects an entire column IF the target cell is in column C.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99541

--- Comment #5 from Fred Hamilton  ---
Created attachment 124706
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124706=edit
macro suitable for launching from macro menu inside calc

example_menu_launch.py will reproduce bug when launched via macro menu in calc.

example.py (earlier attachment) does not work when launched via macro menu in
calc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99258] Windows builds of master 5.2.0alpha1+ failing in Extension Manager on launch

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99258

--- Comment #31 from Luke  ---
Bisect result:

The first bad commit could be any of:
40e9ed91bd8bbfecfc3832d73a81741d0aa97d3a
80d0b2916db81a7f47bb1d368677016bbb870df6

Tomaž,
Could you please take a look at this? These are both your commits.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99541] '.uno:GoToCell' call selects an entire column IF the target cell is in column C.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99541

--- Comment #4 from Fred Hamilton  ---
The instructions for reproducing the bug will not work with the original
example.py.  I was launching from a button on my toolbar.  When launched from
toolbar, main function needs an argument: def StartHere(dummy):

When launched via menu, main function requires no argument: def StartHere():

To reproduce, use new example_menu_launch.py file
Steps to reproduce:
1) put example_menu_launch.py in ~/.config/libreoffice/4/user/Scripts/python
directory
2) open up an empty/new calc document
3) run this script as a macro (Tools/Macro/Run Macro/Macro Selector/My
Macros/example_menu_launch/StartHere)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99556] CRASH: NULL pointer dereference in MathML node.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99556

--- Comment #3 from Regina Henschel  ---
You have already analyzed the problem so deep; what do you think about
contributing to LibreOffice and fixing the bug yourself?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99541] '.uno:GoToCell' call selects an entire column IF the target cell is in column C.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99541

Fred Hamilton  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #3 from Fred Hamilton  ---
Changed status to unconfirmed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99541] '.uno:GoToCell' call selects an entire column IF the target cell is in column C.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99541

Fred Hamilton  changed:

   What|Removed |Added

 CC||f...@yonkitime.com

--- Comment #2 from Fred Hamilton  ---
Created attachment 124705
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124705=edit
python code to reproduce column bug in calc

I'm not sure what you asked for by "sample document".  I've attached the python
file that will cause this problem (same as in the text of my original
submission - probably bad form but I couldn't see how to attach two files when
I submitted).

Steps to reproduce:
1) put file in ~/.config/libreoffice/4/user/Scripts/python directory
2) open up an empty/new calc document
3) run this script as a macro (Tools/Macro/Run Macro/Macro Selector/My
Macros/example/StartHere)

Step 1 is for linux - for Win/OS X put it in appropriate macro directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99556] CRASH: NULL pointer dereference in MathML node.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99556

--- Comment #2 from Sergey Zelenyuk  ---
The cause of problem is in mathmlimport.cxx.

// ...
void SmXMLSqrtContext_Impl::EndElement()
{
/*
 accepts any number of arguments; if this number is not 1, its
contents are treated as a single "inferred " containing its
arguments
*/
if (GetSmImport().GetNodeStack().size() - nElementCount > 1)
SmXMLRowContext_Impl::EndElement();
// ...

If  has more than one children they will be handled inside a , but
it should also be done if there is no child.

- GetSmImport().GetNodeStack().size() - nElementCount > 1
+ GetSmImport().GetNodeStack().size() - nElementCount != 1

Not only msqrt affect to this problem but also mphantom, menclose, mstyle,
mpadded and several attributes such as fontweight. Unlike msqrt, they will not
crash the program now because they have no code deals with children in their
EndElement functions, but they can do it in future.

mphantom and font attributes have been fixed in
https://bugs.documentfoundation.org/show_bug.cgi?id=98088. The fix adds a code
which checks number of children but the cause of problem remains.

menclose, mstyle and mpadded aren't cause a crash because they have no code in
mathmlimport.cxx which works with children elements but the problem at the
place anyway.

Summarize. How to fix the cause:
1) msqrt. See above.
2) mphantom, menclose, mstyle, mpadded and font attributes. Same changes as
with msqrt should be done but in other functions:
SmXMLPhantomContext_Impl::EndElement
SmXMLEncloseContext_Impl::EndElement
SmXMLStyleContext_Impl::EndElement
SmXMLPaddedContext_Impl::EndElement

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: i18npool/source

[Miklos Vajna]

 i18npool/source/localedata/localedata.cxx |   38 +++---
 1 file changed, 19 insertions(+), 19 deletions(-)

New commits:
commit 1d4974ba066174fb1e000d5e0a2c41a4f7feaf18
Author: Miklos Vajna 
Date:   Thu Apr 28 21:25:39 2016 +0200

i18npool: fix Android build

Change-Id: If7321acf4cb8542709cd3f2b418af97586862d46

diff --git a/i18npool/source/localedata/localedata.cxx 
b/i18npool/source/localedata/localedata.cxx
index bfb59aa..06da7af 100644
--- a/i18npool/source/localedata/localedata.cxx
+++ b/i18npool/source/localedata/localedata.cxx
@@ -543,43 +543,43 @@ oslGenericFunction SAL_CALL 
lcl_LookupTableHelper::getFunctionSymbolByName(
 (void) pOutCachedItem;
 
 if( strcmp(pFunction, "getAllCalendars") == 0 )
-return aLibTable[i].getAllCalendars;
+return i.getAllCalendars;
 else if( strcmp(pFunction, "getAllCurrencies") == 0 )
-return aLibTable[i].getAllCurrencies;
+return i.getAllCurrencies;
 else if( strcmp(pFunction, "getAllFormats0") == 0 )
-return aLibTable[i].getAllFormats0;
+return i.getAllFormats0;
 else if( strcmp(pFunction, "getBreakIteratorRules") == 0 )
-return aLibTable[i].getBreakIteratorRules;
+return i.getBreakIteratorRules;
 else if( strcmp(pFunction, "getCollationOptions") == 0 )
-return aLibTable[i].getCollationOptions;
+return i.getCollationOptions;
 else if( strcmp(pFunction, "getCollatorImplementation") == 0 )
-return aLibTable[i].getCollatorImplementation;
+return i.getCollatorImplementation;
 else if( strcmp(pFunction, "getContinuousNumberingLevels") == 0 )
-return aLibTable[i].getContinuousNumberingLevels;
+return i.getContinuousNumberingLevels;
 else if( strcmp(pFunction, "getDateAcceptancePatterns") == 0 )
-return aLibTable[i].getDateAcceptancePatterns;
+return i.getDateAcceptancePatterns;
 else if( strcmp(pFunction, "getFollowPageWords") == 0 )
-return aLibTable[i].getFollowPageWords;
+return i.getFollowPageWords;
 else if( strcmp(pFunction, "getForbiddenCharacters") == 0 )
-return aLibTable[i].getForbiddenCharacters;
+return i.getForbiddenCharacters;
 else if( strcmp(pFunction, "getIndexAlgorithm") == 0 )
-return aLibTable[i].getIndexAlgorithm;
+return i.getIndexAlgorithm;
 else if( strcmp(pFunction, "getLCInfo") == 0 )
-return aLibTable[i].getLCInfo;
+return i.getLCInfo;
 else if( strcmp(pFunction, "getLocaleItem") == 0 )
-return aLibTable[i].getLocaleItem;
+return i.getLocaleItem;
 else if( strcmp(pFunction, "getOutlineNumberingLevels") == 0 )
-return aLibTable[i].getOutlineNumberingLevels;
+return i.getOutlineNumberingLevels;
 else if( strcmp(pFunction, "getReservedWords") == 0 )
-return aLibTable[i].getReservedWords;
+return i.getReservedWords;
 else if( strcmp(pFunction, "getSearchOptions") == 0 )
-return aLibTable[i].getSearchOptions;
+return i.getSearchOptions;
 else if( strcmp(pFunction, "getTransliterations") == 0 )
-return aLibTable[i].getTransliterations;
+return i.getTransliterations;
 else if( strcmp(pFunction, "getUnicodeScripts") == 0 )
-return aLibTable[i].getUnicodeScripts;
+return i.getUnicodeScripts;
 else if( strcmp(pFunction, "getAllFormats1") == 0 )
-return aLibTable[i].getAllFormats1;
+return i.getAllFormats1;
 #endif
 }
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #5 from V Stuart Foote  ---
OK then, not unexpected. One last thing before we close this WFM, please post
the text from your

C:\Users\\AppData\Roaming\LibreOffice 4\cache\opengl_device.log

we use this information from troubled systems to blacklist non-functioning
OpenGL implementations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #4 from Richard  ---
I checked on the state of :
Tools -> Options -> View: Use OpenGl for all rendering (on restart)

Currently it is "checked/selected", if I "uncheck/disable" that option then the
menus seem to display correctly (if somewhat more sluggish).

Not sure why this should display fine on the primary monitor and not the
secondary since the same GPU would be involved.

But for now I'll just run with with OpenGL disabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94508] Enable gstreamer1.0 in builds

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94508

--- Comment #12 from Bryan Quigley  ---
My instructions from Mozilla should provide some hints to building on CentOS 6:
https://bugzilla.mozilla.org/show_bug.cgi?id=1122859#c9

Unfortunately building gst1.0 on centos 6 did require glib updates.  But this
was in a customized Mozilla chroot thingy... 

Ubuntu 16.04 wast just released with only gst0.10-plugins base and good
(dropped ugly and bad).  Which means many codecs won't be playable in
LibreOffice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sw/source

[Jochen Nitschke]

 sw/source/ui/dbui/dbinsdlg.cxx |   71 +++--
 1 file changed, 33 insertions(+), 38 deletions(-)

New commits:
commit f8eb7f9c7db6c3dd460868d00758733318cdc266
Author: Jochen Nitschke 
Date:   Thu Apr 28 01:35:05 2016 +0200

use initialization list

use anonymous union to make initialization and
access easier
prevent overwriting type and use scoped enum

Change-Id: I76037ec666c5740096849b0c58fd9a187ada1d54
Reviewed-on: https://gerrit.libreoffice.org/24455
Tested-by: Jenkins 
Reviewed-by: jan iversen 
Tested-by: jan iversen 
Reviewed-by: Noel Grandin 

diff --git a/sw/source/ui/dbui/dbinsdlg.cxx b/sw/source/ui/dbui/dbinsdlg.cxx
index 3fe8b9a..af78932 100644
--- a/sw/source/ui/dbui/dbinsdlg.cxx
+++ b/sw/source/ui/dbui/dbinsdlg.cxx
@@ -110,49 +110,44 @@ const char cDBFieldEnd= '>';
 // Helper structure for adding database rows as fields or text
 struct DB_Column
 {
-enum ColType { DB_FILLTEXT, DB_COL_FIELD, DB_COL_TEXT, DB_SPLITPARA } 
eColType;
+const enum class Type { FILLTEXT, COL_FIELD, COL_TEXT, SPLITPARA } 
eColType;
 
 union {
 OUString* pText;
 SwField* pField;
 sal_uLong nFormat;
-} DB_ColumnData;
+};
 const SwInsDBColumn* pColInfo;
 
-DB_Column()
-{
-pColInfo = nullptr;
-DB_ColumnData.pText = nullptr;
-eColType = DB_SPLITPARA;
-}
+DB_Column() : eColType(Type::SPLITPARA),
+  pText(nullptr),
+  pColInfo(nullptr)
+{}
 
 explicit DB_Column( const OUString& rText )
-{
-pColInfo = nullptr;
-DB_ColumnData.pText = new OUString( rText );
-eColType = DB_FILLTEXT;
-}
+: eColType(Type::FILLTEXT),
+  pText(new OUString(rText)),
+  pColInfo(nullptr)
+{}
 
-DB_Column( const SwInsDBColumn& rInfo, sal_uLong nFormat )
-{
-pColInfo = 
-DB_ColumnData.nFormat = nFormat;
-eColType = DB_COL_TEXT;
-}
+DB_Column( const SwInsDBColumn& rInfo, sal_uLong nFormat_ )
+: eColType(Type::COL_TEXT),
+  nFormat(nFormat_),
+  pColInfo()
+{}
 
 DB_Column( const SwInsDBColumn& rInfo, SwDBField& rField )
-{
-pColInfo = 
-DB_ColumnData.pField = 
-eColType = DB_COL_FIELD;
-}
+: eColType(Type::COL_FIELD),
+  pField(),
+  pColInfo()
+{}
 
 ~DB_Column()
 {
-if( DB_COL_FIELD == eColType )
-delete DB_ColumnData.pField;
-else if( DB_FILLTEXT == eColType )
-delete DB_ColumnData.pText;
+if( Type::COL_FIELD == eColType )
+delete pField;
+else if( Type::FILLTEXT == eColType )
+delete pText;
 }
 };
 
@@ -936,7 +931,7 @@ bool SwInsertDBColAutoPilot::SplitTextToColArr( const 
OUString& rText,
 static_cast(rSh.InsertFieldType( 
aFieldType )),
 nFormat ) );
 if( nSubType )
-pNew->DB_ColumnData.pField->SetSubType( nSubType );
+pNew->pField->SetSubType( nSubType );
 }
 else
 pNew = new DB_Column( rFndCol, nFormat );
@@ -1281,11 +1276,11 @@ void SwInsertDBColAutoPilot::DataToDoc( const 
Sequence& rSelection,
 OUString sIns;
 switch( pDBCol->eColType )
 {
-case DB_Column::DB_FILLTEXT:
-sIns =  *pDBCol->DB_ColumnData.pText;
+case DB_Column::Type::FILLTEXT:
+sIns =  *pDBCol->pText;
 break;
 
-case DB_Column::DB_SPLITPARA:
+case DB_Column::Type::SPLITPARA:
 rSh.SplitNode();
 // when the template is not the same as the follow 
template,
 // the selected has to be set newly
@@ -1293,10 +1288,10 @@ void SwInsertDBColAutoPilot::DataToDoc( const 
Sequence& rSelection,
 rSh.SetTextFormatColl( pColl );
 break;
 
-case DB_Column::DB_COL_FIELD:
+case DB_Column::Type::COL_FIELD:
 {
 std::unique_ptr 
pField(static_cast(
-pDBCol->DB_ColumnData.pField->CopyField()));
+pDBCol->pField->CopyField()));
 double nValue = DBL_MAX;
 
 Reference< XPropertySet > 

[Libreoffice-bugs] [Bug 99521] UI Menu problems on multi-monitor system

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99521

--- Comment #3 from Richard  ---
Created attachment 124704
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124704=edit
Screen shot of menu being displayed incorrectly on secondary monitor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99546] "Save As Template..." broken

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99546

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||rb.hensc...@t-online.de
 Resolution|--- |WORKSFORME

--- Comment #1 from Regina Henschel  ---
I have tried it in Version: 5.2.0.0.alpha0+
Build ID: ac488ccba124fc2539f765d354a0b97c9b843f51
CPU Threads: 4; OS Version: Windows 6.1; UI Render: default; 
TinderBox: Win-x86@42, Branch:master, Time: 2016-03-22_04:19:21
Locale: de-DE (de_DE)

I have used File > Templates > Save as Template. If I enter the template name
of the current default template, LibreOffice ask whether I want to overwrite it
and in case of 'yes' the newly saved templates becomes the default template
automatically.

The step "highlighted the template file (set as default)" is wrong in your
workflow. Instead use the 'save' icon in the Template Manager without selecting
any existing template, and then enter the name of the existing default template
into the name box.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Henry Castro]

 loolwsd/test/httpwstest.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 49e6eb287b15333bba8fb93edb1f2acb419ba019
Author: Henry Castro 
Date:   Thu Apr 28 14:01:28 2016 -0400

loolwsd: test: fix wrong file name

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 2a01ea4..5755a8d 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -1071,7 +1071,7 @@ void HTTPWSTest::testClientPartCalc()
 {
 // Load a document
 std::string documentPath, documentURL;
-getDocumentPathAndURL("setclientpart.odp", documentPath, documentURL);
+getDocumentPathAndURL("setclientpart.ods", documentPath, documentURL);
 
 Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
 Poco::Net::WebSocket socket = *connectLOKit(request, _response);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99558] New: UI: Calc crashes when changing color of shape object added to chart

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99558

Bug ID: 99558
   Summary: UI: Calc crashes when changing color of shape object
added to chart
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mark_t2...@outlook.com

Created attachment 124703
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124703=edit
Sample worksheet includes chart with shape added.

After adding a shape to a chart, attempting to change the area fill color using
the side toolbar always crashes Calc.

On selecting the shape in the chart, "select chart element" shows "Drawing
Object", but "Format Selection" is greyed out and not available.

The toolbar at the right can be enabled, and shows options to format the area,
"Select the fill type to apply" shows "Colour", but there is no option for
color selection.

Selecting "Colour" in "Select the fill type to apply" then shows "Select the
colour to apply" option. 

Selecting any color from this option crashes Calc and gives option to recover
documents.

Attached example sheet shows the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99542] Mathmatics formulas disappear or don't display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99542

--- Comment #8 from johnny_...@hotmail.com ---
Mine is installed in Program Files (x86) so it should be 32-bit build.

I'll try to re-install the version 5.0.5 and I'll let you know if the bug is
still here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99542] Mathmatics formulas disappear or don't display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99542

--- Comment #7 from V Stuart Foote  ---
(In reply to johnny_hil from comment #6)
> I think it is 64-bit but to be sure, where can I find that information ?

Should be in the Help -> About LibreOffice dialog

Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.29; UI Render: GL; 
Locale: en-US (en_US)

but, on a 64-bit Windows OS the 64-bit build would normally be installed to
C:\Program Files\LibreOffice 5, while the 32-bit build would normally be
intalled to C:\Program Files (x86)\LibreOffice 5

Also, if you did an upgrade install from 4.x you probably received the 32-bit
version.  You have to specifically download and install the 64-bit build
starting with the 5.0 release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97909] some custom animations not working

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97909

--- Comment #11 from David F Smith  ---
(In reply to ullix from comment #9)
> Followed your steps and - Hooray -  all animations worked the way they
> should!
> 
> Now, can you bring this into the stable 5.1 version? I feel a bit uneasy
> with alpha when doing a presentation to an auditorium.

Ullix, if this is still an issue for you, you can drop back to 5.0.5 ("Still").
 I was about to report the same bug you found in 5.1.1, and all of the
animations worked correctly in 5.0.5.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99542] Mathmatics formulas disappear or don't display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99542

--- Comment #6 from johnny_...@hotmail.com ---
I think it is 64-bit but to be sure, where can I find that information ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99556] CRASH: NULL pointer dereference in MathML node.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99556

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de
 Ever confirmed|0   |1

--- Comment #1 from Regina Henschel  ---
Import via clipboard shows the crash as well.

Making the method SmRootNode::CreateTextFromNode save is one thing, and should
be done.

But I think the error happens earlier. If a msqrt element is empty, it should
be handled as 

  
  

So it would have a child.

https://www.w3.org/TR/MathML2/chapter3.html#presm.reqarg

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92607] ACCESSIBILITY: improve one-handed usability

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92607

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||accessibility
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99542] Mathmatics formulas disappear or don't display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99542

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #5 from V Stuart Foote  ---
So your Windows is 8.1 64-bit but which LibreOffice have you installed,
64-bit build or 32-bit build?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96089] Autorecovery runs on unmodified file

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96089

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   Keywords||bibisectRequest
Summary|Autosave run on unmodified  |Autorecovery runs on
   |file|unmodified file

--- Comment #5 from Yousuf (Jay) Philips  ---
Still happening with cleared profile. Maybe someone should test it on Linux to
see if its a Linux-only bug.

Version: 5.2.0.0.alpha0+
Build ID: b19ac3c4c6b4a41a1f3acac68b299fd676428a87
CPU Threads: 2; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-04-21_08:41:08
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99320] Rotated videos cannot be inserted

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99320

--- Comment #25 from Kevin Evans  ---
(In reply to Buovjaga from comment #24)
> (In reply to Kevin Evans from comment #23)
> > OK, if you say so...I'm sure you are aware that MANY more people use Windows
> > than Unix based systems. Many of those people will have the same problem.
> 
> Unix based systems still need codecs installed, if people want to play
> videos in Impress. I just happen to have the right codecs installed on
> Linux. I do not know what codecs are missing from our Windows systems, so
> you should ask at the AskLibO site.

Sorry, but that is NOT much of an answer. LO "professes" to be an alternative
to MS Office. PP2013 works without any other codecs installed, so if LO is
supposed to be an alternative to MS Office...it should work also.

Kevin

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99557] TOOLBAR: Paste special drop down gets removed after clipboard cleared

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99557

Yousuf (Jay) Philips  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=86
   ||609

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99557] New: TOOLBAR: Paste special drop down gets removed after clipboard cleared

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99557

Bug ID: 99557
   Summary: TOOLBAR: Paste special drop down gets removed after
clipboard cleared
   Product: LibreOffice
   Version: 3.3.0 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: philip...@hotmail.com
CC: momonas...@gmail.com

Steps:
1) open calc and notice the paste special drop down button is available
2) type 'abc' in a1
3) copy a1
4) move cursor to b1 and press enter
5) clipboard is cleared and paste button is dimmed and paste special drop down
button is missing

Not inherited from OOo as it didnt have this paste method by pressing enter.

Version: 5.2.0.0.alpha0+
Build ID: b19ac3c4c6b4a41a1f3acac68b299fd676428a87
CPU Threads: 2; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-04-21_08:41:08
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 78509] FILEOPEN: ODT 1.2 links saved in MS Word showed up with incorrect blue color

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=78509

Yousuf (Jay) Philips  changed:

   What|Removed |Added

 Status|RESOLVED|NEW
 CC||momonas...@gmail.com,
   ||oliver.spe...@cib.de,
   ||rb.hensc...@t-online.de,
   ||vmik...@collabora.co.uk
Version|3.6.7.2 release |Inherited From OOo
 Resolution|NOTABUG |---

--- Comment #8 from Yousuf (Jay) Philips  ---
Reopening as this is a LO bug that is also in AOO and is broken somewhere at
the import level.

So the hyperlinks claim to be assigned to the "Default Paragraph Font >
Hyperlink" character style which is "Blue 3" (#ff), but in actuality they
are assigned to the "Internet Link" character style which is "Sky Blue 6"
(#80).

Sample ODF code

http://blogs.msdn.com/b/officeinteroperability/archive/2013/04/04/microsoft-support-for-pdf.aspx







-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99542] Mathmatics formulas disappear or don't display correctly

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99542

johnny_...@hotmail.com changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|unspecified |5.0.5.2 release

--- Comment #4 from johnny_...@hotmail.com ---
Here are the détails of my version of Libre Office :

Version: 5.0.5.2
Build ID: 55b006a02d247b5f7215fc6ea0fde844b30035b3
Locale : fr-FR (fr_FR)

It would be great if you could fix this bug in a further version because in
previous versions, there wasn't this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94587] Meta: ODF specification features missing or incorrectly imported

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94587
Bug 94587 depends on bug 78509, which changed state.

Bug 78509 Summary: FILEOPEN: ODT 1.2 links saved in MS Word showed up with 
incorrect blue color
https://bugs.documentfoundation.org/show_bug.cgi?id=78509

   What|Removed |Added

 Status|RESOLVED|NEW
 Resolution|NOTABUG |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92607] ACCESSIBILITY: improve one-handed usability

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92607

--- Comment #4 from MarjaE  ---
For Mac users, such as myself, some of the shortcuts involving function keys
are also a problem.

In Draw, I'm supposed to be able to enter a group using F3 and leave using
Control+F3. On the Mac, that becomes fn+F3 and Command+fn+F3.

Command+fn+F3 either requires (a) two hands, or (b) two thumbs on one hand, on
the same side, or (c) sticky keys, or (d) turning the keyboard around, or (e)
building a stencil to press all three eys at once.

(c) may be the most practical option.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99556] New: CRASH: NULL pointer dereference in MathML node.cxx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99556

Bug ID: 99556
   Summary: CRASH: NULL pointer dereference in MathML node.cxx
   Product: LibreOffice
   Version: 5.2.0.0.alpha1
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: framework
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: s.zelen...@yandex.ru

Abstract: MathML msqrt element will be handled improperly when it has no
children.

Problem: there is no code to check whether a node has a subnodes or not in
SmRootNode::CreateTextFromNode function:

// ...
if (!pExtra && GetSubNode(2)->GetNumSubNodes() > 1)
rText += "{ ";

GetSubNode(2)->CreateTextFromNode(rText);

if (!pExtra && GetSubNode(2)->GetNumSubNodes() > 1)
rText += "} ";
// ...

In the case of  (see below) a return value of GetSubNode will be NULL
so it cannot be dereferenced.

Solution: store a return values of GetSubNode and compare them with NULL before
dereferencing.

How to reproduce: copy the code below into example.xml and open it in
LibreOffice.
http://www.w3.org/1998/Math/MathML;>



-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99141] Text written in AndikaFrenchTight-R Font disappears when printing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99141

tomas...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from tomas...@gmail.com ---


*** This bug has been marked as a duplicate of bug 99207 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99207] Graphite fonts render in negative colors

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99207

tomas...@gmail.com changed:

   What|Removed |Added

 CC||thierry.seew...@laposte.net

--- Comment #17 from tomas...@gmail.com ---
*** Bug 99141 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: 4 commits - loolwsd/test

[Jan Holesovsky]

 loolwsd/test/Makefile.am |2 
 loolwsd/test/httpgettest.cpp |  184 
 loolwsd/test/httpposttest.cpp|  243 ---
 loolwsd/test/httptestutils.hpp   |   64 ---
 loolwsd/test/integration-http-server.cpp |  273 +++
 5 files changed, 274 insertions(+), 492 deletions(-)

New commits:
commit 407b41afb9508c805849ac72a638dc412c25d63f
Author: Jan Holesovsky 
Date:   Thu Apr 28 18:35:22 2016 +0200

Decrease verbosity of this the http server test.

And also check that we've had a hit in loleaflet.html.

diff --git a/loolwsd/test/integration-http-server.cpp 
b/loolwsd/test/integration-http-server.cpp
index e619df9..f4e7557 100644
--- a/loolwsd/test/integration-http-server.cpp
+++ b/loolwsd/test/integration-http-server.cpp
@@ -166,28 +166,28 @@ namespace {
 void assertHTTPFilesExist(const Poco::URI& uri, Poco::RegularExpression& expr, 
const std::string& html, const std::string& mimetype = std::string())
 {
 Poco::RegularExpression::MatchVec matches;
+bool found = false;
 
 for (int offset = 0; expr.match(html, offset, matches) > 0; offset = 
static_cast(matches[0].offset + matches[0].length))
 {
+found = true;
CPPUNIT_ASSERT_EQUAL(2, (int)matches.size());
Poco::URI uriScript(html.substr(matches[1].offset, matches[1].length));
if (uriScript.getHost().empty())
{
std::string scriptString(uriScript.toString());
 
-   // ignore the branding bits, they do not have to be there
+   // ignore the branding bits, it's not an error when they are not
+// present
if (scriptString.find("/branding.") != std::string::npos)
-   {
-   std::cout << "skipping test for... " << scriptString << 
std::endl;
continue;
-   }
 
 #if ENABLE_SSL
Poco::Net::HTTPSClientSession sessionScript(uri.getHost(), 
uri.getPort());
 #else
Poco::Net::HTTPClientSession sessionScript(uri.getHost(), 
uri.getPort());
 #endif
-   std::cout << "checking... " << scriptString;
+
Poco::Net::HTTPRequest 
requestScript(Poco::Net::HTTPRequest::HTTP_GET, scriptString);
sessionScript.sendRequest(requestScript);
 
@@ -197,14 +197,10 @@ void assertHTTPFilesExist(const Poco::URI& uri, 
Poco::RegularExpression& expr, c
 
if (!mimetype.empty())
CPPUNIT_ASSERT_EQUAL(mimetype, responseScript.getContentType());
-
-   std::cout << " OK" << std::endl;
-   }
-   else
-   {
-   std::cout << "skip " << uriScript.toString() << std::endl;
}
 }
+
+CPPUNIT_ASSERT_MESSAGE("No match found", found);
 }
 
 }
commit 28b7aee356625338f99e3aad34ae81c517df4239
Author: Jan Holesovsky 
Date:   Thu Apr 28 18:17:37 2016 +0200

No need for a standalone httptestutils.hpp any more.

diff --git a/loolwsd/test/httptestutils.hpp b/loolwsd/test/httptestutils.hpp
deleted file mode 100644
index c6fa398..000
--- a/loolwsd/test/httptestutils.hpp
+++ /dev/null
@@ -1,64 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; 
fill-column: 100 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- */
-
-#ifndef TEST_HTTPTESTUTILS_HPP
-#define TEST_HTTPTESTUTILS_HPP
-
-namespace httptest
-{
-
-inline void assertHTTPFilesExist(const Poco::URI& uri, 
Poco::RegularExpression& expr, const std::string& html, const std::string& 
mimetype = std::string())
-{
-Poco::RegularExpression::MatchVec matches;
-
-for (int offset = 0; expr.match(html, offset, matches) > 0; offset = 
static_cast(matches[0].offset + matches[0].length))
-{
-   CPPUNIT_ASSERT_EQUAL(2, (int)matches.size());
-   Poco::URI uriScript(html.substr(matches[1].offset, matches[1].length));
-   if (uriScript.getHost().empty())
-   {
-   std::string scriptString(uriScript.toString());
-
-   // ignore the branding bits, they do not have to be there
-   if (scriptString.find("/branding.") != std::string::npos)
-   {
-   std::cout << "skipping test for... " << scriptString << 
std::endl;
-   continue;
-   }
-
-#if ENABLE_SSL
-   Poco::Net::HTTPSClientSession sessionScript(uri.getHost(), 
uri.getPort());
-#else
-   Poco::Net::HTTPClientSession sessionScript(uri.getHost(), 
uri.getPort());
-#endif
-   std::cout << "checking... " << scriptString;
-   Poco::Net::HTTPRequest 
requestScript(Poco::Net::HTTPRequest::HTTP_GET, scriptString);
-   sessionScript.sendRequest(requestScript);
-
-   Poco::Net::HTTPResponse responseScript;
-   

[Libreoffice-bugs] [Bug 93045] FILESAVE: custom styles lost on saving to XLSX (Summary in Comment 6)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93045

Ambrose Li  changed:

   What|Removed |Added

 CC||ambrose...@gmail.com

--- Comment #15 from Ambrose Li  ---
This is still present in 5.0.5.2.

IMHO this is a serious problem, because the .xlsx file does not survive across
a round trip from Excel to LibreOffice back to Excel, making LibreOffice
useless when Excel is in the loop anywhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49853] Cmd-V or Cmd-A inside toolbar-hosted edit fields paste into document instead (OS X only)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=49853

--- Comment #145 from V Stuart Foote  ---
(In reply to Maxim Monastirsky from comment #142)
> Well, the root cause seems
...
> Now we only need to figure out what's the right way to fix this...

check out Matthew F's similar work for bug 62054
https://cgit.freedesktop.org/libreoffice/core/commit/?id=0350bcde37edb1f25cca68cb1447ba8f759aea15

and refs to
http://stackoverflow.com/questions/970707/cocoa-keyboard-shortcuts-in-dialog-without-an-edit-menu

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98639] Spacing to contents is broken after saving as docx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98639

Ivo Smelhaus  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98648] Versions > CMIS (Alfresco) - buttons does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98648

Buovjaga  changed:

   What|Removed |Added

 Status|REOPENED|UNCONFIRMED
 Ever confirmed|1   |0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Minutes of ESC call [2016-04-28]

[Jan Holesovsky]

* Present:
+ Armin, Stephan, Christian, Sophie, Norbert, Kendy, Olivier, Stefan W., 
Miklos, Caolan, jani 
  Michael S, Lionel, Eike, Thorsten, Bjoern (lurking on pad only)

* Completed Action Items:
+ build a proposal & reach-out for updated ESC composition (Michael)
+ look binding auto-CC update to adding keywords (JanI)
 + easyHacks (JanI), and ux-advice (UX list)
+ poke again at the lcov problem on tb31 ? (Bjoern)
 [ solved by dtardon (apparently) ]
+ poke at hack-fest candidate list (Bjoern)
 + see below: GUARDEC, Karlsruhe and Froscon, Bonn are possible, other 
suggestions welcome

* Pending Action Items:
+ build a plan for publishing the HTML documentation (Olivier, Kendy)
 [ updated the VM (Olivier) ]
+ investigate clobberring glew instead of lots of #ifdefs: (Marco, Oliver)
 [ Working on getting this up-stream ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
 [ pending ]
+ ask QA to re-test http://tdf.io/mmregressions (Robinson)
 [ testing underway ]
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
 [ pending ]
+ script XML / l10n string translation changes (Christian)
 [ have a partial script - but - waiting for pootle migration to
   finish -> next week. ]
 
* Release Engineering update (Christian)
+ 5.0.6 RC2 - due for tagging next Tues -April 26th
+ still patches needing tripple review
 
https://gerrit.libreoffice.org/#/q/status:open+project:core+branch:libreoffice-5-0
 → don't forget to also cherry-pick for libreoffice-5-0-6 branch
+ all patches with positive review integrated,
+ now being pushed to the mirrors
+ thank you for help with reviews! :-) (Cloph)
+ 5.1.3 RC2
+ next Tuesday
+ 5.2 Alpha 1
+ 24th May - feature freeze
+ getting close!
+ built from master, a Most Pressing bug there - OpenGL detection, 
cause unclear yet
+ the next Alpha: end of May - branchoff + feature freeze
+ Android & iOS Remote
+ expect Viewer update after Alpha a tagging
+ Aleksandar working on theming for Android remote.
+ pending
+ Cloph fixed some pieces there too
 
* ESC composition
+ Slightly nominal position:
+ https://wiki.documentfoundation.org/Development/ESC
+ Move valued previous contributors to 'Luminaries'
+ Muthu affiliation -> 'Other'
+ Eilidh -> ditto.
+ Add new members:
+ add Bubli & Armin -> CIB ?
+ JanI + Olivier -> TDF ...
+ Maxim Monistarsky (subject to his ack)
+ Markus Mohrhard (subject to his ack)
+ No private concerns expressed to Michael.
 
* Documentation (Olivier)
+ Chapter 4 of Getting Started 5.1 book delivered for revision
+ starting Chapter 5 - Calc now
+ Updated http://vm173.documentfoundation.org with tweaks in XSLT
+ it has now an index per module to ease access to a keyword
+ just hit ctrl+F in the browser to find a keyword
+ use browser navigation buttons to go back and forth.
+ use browser bookmark feature
+ l10n version of this rendering under work
+ Challenge: pass $lang, $system and $module to a XSLT in the URL.
+ will need some thin JavaScript there I fear (Kendy)
+ would be good to detect, but overriding necessary too for 
debugging
  or when displaying help for another platform (Norbert)
+ will need simplify the xslt, designed for old browsers, now some
  features are more easily accessible
 
+ pootle migration - completed ? how is it ?
+ hard work, thanks for making it possible (Sophie)
+ migration finished, works well, thank you Alex (Sophie)
+ dictionaries maintenance
 + cross-application (LibreOffice, Firefox and others), discussions
   ongoing, Sophie will report (Sophie)
 
* GSoC 2016 (JanI / Thorsten)
+ community bonding period until May, 22nd
+ still need back-up mentors for some tasks
+ please encourage your students to bond - get familiar with the project,
  Easy Hacks, etc. (Thorsten)
+ it is not a "sitting and waiting time" (Thorsten)
+ patches most appreciated, encourage your students to send them (Kendy)
 
* UX Update (Kendy/Bubli)
+ no meeting the last Friday
+ patches coming in
 
* Crashtest update (Caolan)
+ 1 import failure, 1 export failure, 0 coverity (Miklos just filled in the 
numbers)
 
* Hackfests (Bjoern)
+ next hackfests:
+ Ankara, Turkey
+ April 30th - May 1st.
+ https://wiki.documentfoundation.org/Hackfest/Ankara2016
+ plan do an overview talk on Friday with Markus & any interest 
(Michael)
+ next weekend - should be fun !

[Libreoffice-bugs] [Bug 98648] Versions > CMIS (Alfresco) - buttons does not work

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98648

Ivo Smelhaus  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |---

--- Comment #10 from Ivo Smelhaus  ---
So to be unambiguous, I am reporting about CMIS versions. The first dialogue
got after "file->versions..." shows internal versions, i.e. saved inside a file
but after pressing the mentioned "CMIS" button in this dialogue a new dialogue
is open, where are shown versions saved on server, i.e. multiple files resp.
nodes incl. all metadata for each node on the server. So "compare" button means
compare currently opened file which can have more internal versions (suppose
the current local version is used) with another file saved on the server as a
X.Y version of our currently opened document. 
So there could be probably more hidden problems. Starting with changed metadata
and their mapping to file properties which could be e.g. used in fields in a
document. Even file name could be changed. 
And additionally the older version (i.e. file) taken from server could have
more internal versions. So open third dialogue? 
And all of that is not only a question how to choose and execute some logic but
how to present this quite complicated stuff to a normal non IT user. 
But regardless all of that, this feature is, I believe, very important.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-qa] Minutes of ESC call [2016-04-28]

[Jan Holesovsky]

* Present:
+ Armin, Stephan, Christian, Sophie, Norbert, Kendy, Olivier, Stefan W., 
Miklos, Caolan, jani 
  Michael S, Lionel, Eike, Thorsten, Bjoern (lurking on pad only)

* Completed Action Items:
+ build a proposal & reach-out for updated ESC composition (Michael)
+ look binding auto-CC update to adding keywords (JanI)
 + easyHacks (JanI), and ux-advice (UX list)
+ poke again at the lcov problem on tb31 ? (Bjoern)
 [ solved by dtardon (apparently) ]
+ poke at hack-fest candidate list (Bjoern)
 + see below: GUARDEC, Karlsruhe and Froscon, Bonn are possible, other 
suggestions welcome

* Pending Action Items:
+ build a plan for publishing the HTML documentation (Olivier, Kendy)
 [ updated the VM (Olivier) ]
+ investigate clobberring glew instead of lots of #ifdefs: (Marco, Oliver)
 [ Working on getting this up-stream ]
+ tweak UI and get LiveConnect API key / build case for board (Christian)
 [ pending ]
+ ask QA to re-test http://tdf.io/mmregressions (Robinson)
 [ testing underway ]
+ attempt to re-build a recent gstreamer 1.0 / core spec file
  on our CentOS6 base (tdf#94508) (Christian)
 [ pending ]
+ script XML / l10n string translation changes (Christian)
 [ have a partial script - but - waiting for pootle migration to
   finish -> next week. ]
 
* Release Engineering update (Christian)
+ 5.0.6 RC2 - due for tagging next Tues -April 26th
+ still patches needing tripple review
 
https://gerrit.libreoffice.org/#/q/status:open+project:core+branch:libreoffice-5-0
 → don't forget to also cherry-pick for libreoffice-5-0-6 branch
+ all patches with positive review integrated,
+ now being pushed to the mirrors
+ thank you for help with reviews! :-) (Cloph)
+ 5.1.3 RC2
+ next Tuesday
+ 5.2 Alpha 1
+ 24th May - feature freeze
+ getting close!
+ built from master, a Most Pressing bug there - OpenGL detection, 
cause unclear yet
+ the next Alpha: end of May - branchoff + feature freeze
+ Android & iOS Remote
+ expect Viewer update after Alpha a tagging
+ Aleksandar working on theming for Android remote.
+ pending
+ Cloph fixed some pieces there too
 
* ESC composition
+ Slightly nominal position:
+ https://wiki.documentfoundation.org/Development/ESC
+ Move valued previous contributors to 'Luminaries'
+ Muthu affiliation -> 'Other'
+ Eilidh -> ditto.
+ Add new members:
+ add Bubli & Armin -> CIB ?
+ JanI + Olivier -> TDF ...
+ Maxim Monistarsky (subject to his ack)
+ Markus Mohrhard (subject to his ack)
+ No private concerns expressed to Michael.
 
* Documentation (Olivier)
+ Chapter 4 of Getting Started 5.1 book delivered for revision
+ starting Chapter 5 - Calc now
+ Updated http://vm173.documentfoundation.org with tweaks in XSLT
+ it has now an index per module to ease access to a keyword
+ just hit ctrl+F in the browser to find a keyword
+ use browser navigation buttons to go back and forth.
+ use browser bookmark feature
+ l10n version of this rendering under work
+ Challenge: pass $lang, $system and $module to a XSLT in the URL.
+ will need some thin JavaScript there I fear (Kendy)
+ would be good to detect, but overriding necessary too for 
debugging
  or when displaying help for another platform (Norbert)
+ will need simplify the xslt, designed for old browsers, now some
  features are more easily accessible
 
+ pootle migration - completed ? how is it ?
+ hard work, thanks for making it possible (Sophie)
+ migration finished, works well, thank you Alex (Sophie)
+ dictionaries maintenance
 + cross-application (LibreOffice, Firefox and others), discussions
   ongoing, Sophie will report (Sophie)
 
* GSoC 2016 (JanI / Thorsten)
+ community bonding period until May, 22nd
+ still need back-up mentors for some tasks
+ please encourage your students to bond - get familiar with the project,
  Easy Hacks, etc. (Thorsten)
+ it is not a "sitting and waiting time" (Thorsten)
+ patches most appreciated, encourage your students to send them (Kendy)
 
* UX Update (Kendy/Bubli)
+ no meeting the last Friday
+ patches coming in
 
* Crashtest update (Caolan)
+ 1 import failure, 1 export failure, 0 coverity (Miklos just filled in the 
numbers)
 
* Hackfests (Bjoern)
+ next hackfests:
+ Ankara, Turkey
+ April 30th - May 1st.
+ https://wiki.documentfoundation.org/Hackfest/Ankara2016
+ plan do an overview talk on Friday with Markus & any interest 
(Michael)
+ next weekend - should be fun !

[Libreoffice-bugs] [Bug 99555] FORMATTING files lost data and formatting

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99555

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Joel Madero  ---
Please provide a sample (not the xlsx that already has data loss). Attach an
ods that when saved as xlsx formatting is lost.

NEEDINFO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95357] TRACK CHANGES: Change tracking movement/action are inconsistent for replacements

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95357

Björn Michaelsen  changed:

   What|Removed |Added

Summary|Change tracking |TRACK CHANGES: Change
   |movement/action are |tracking movement/action
   |inconsistent for|are inconsistent for
   |replacements|replacements

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs