[Libreoffice-bugs] [Bug 99696] Build for x64 fails unit tests using ADODB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99696

--- Comment #2 from Tomofumi Yagi  ---
(In reply to Mark_T2016 from comment #0)

> Suspect this may be due to trying to use a win32 object from an x64
> application.

I think so,too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99594] Cannot update my Libre Office 4.4.5.2 to 5.1.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99594

--- Comment #4 from Jeff Tonne  ---
Aron, it still does not work. I still get the same gripe. Can you or somebody
please call me 951.306.8770 in California, USA or chat with me to walk me
through this.

Please advise, thank you, Jeff Tonne
ton...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99705] Active cell not highlighted / bordered when OpenGL is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99705

--- Comment #5 from Octavio Alvarez  ---
Could NOT reproduce on another machine.

Version: 5.1.3.1
Build ID: 1:5.1.3~rc1-1
CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
Locale: en-US (en_US.utf8)
OS: Ubuntu 16.04 LTS

Video card: 1002:9588, VGA compatible controller: Advanced Micro Devices, Inc.
[AMD/ATI] RV630 XT [Radeon HD 2600 XT] (prog-if 00 [VGA controller])
Subsystem: Apple Inc. RV630 XT [Radeon HD 2600 XT]
Module: radeon

Curiously enough, my LibreOffice copy on this machine doesn't show any options
to disable or enable OpenGL on [Tools » Options » LibreOffice » View] but
/etc/libreoffice/soffice.sh has OPENGL_SUPPORT=no so I'll trust that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Markus Mohrhard]

 sc/qa/unit/ucalc.cxx |  325 ---
 sc/qa/unit/ucalc.hxx |   10 -
 2 files changed, 335 deletions(-)

New commits:
commit 52871b360c73efd59bfbc811b8b89a02b6375b29
Author: Markus Mohrhard 
Date:   Sat May 7 01:34:12 2016 +0200

nuke the old ucalc perf testing

We now have the real perf tests and converting this test seems quite
complicated as it uses a lot of private symbols. If we really need these
tests again we need to write them through some exported symbols.

Change-Id: Idfb568e026d63d6784400c08a82c9a7a40039e00
Reviewed-on: https://gerrit.libreoffice.org/24711
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 228fafa..e92fd6f 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -109,35 +109,6 @@ FormulaGrammarSwitch::~FormulaGrammarSwitch()
 mpDoc->SetGrammar(meOldGrammar);
 }
 
-class MeasureTimeSwitch
-{
-double& mrDiff;
-TimeValue maTimeBefore;
-public:
-explicit MeasureTimeSwitch(double& rDiff) : mrDiff(rDiff)
-{
-mrDiff = .0;
-osl_getSystemTime();
-}
-
-~MeasureTimeSwitch()
-{
-TimeValue aTimeAfter;
-osl_getSystemTime();
-mrDiff = getTimeDiff(aTimeAfter, maTimeBefore);
-}
-
-static double getTimeDiff(const TimeValue& t1, const TimeValue& t2)
-{
-double tv1 = t1.Seconds;
-double tv2 = t2.Seconds;
-tv1 += t1.Nanosec / 10.0;
-tv2 += t2.Nanosec / 10.0;
-
-return tv1 - tv2;
-}
-};
-
 Test::Test() :
 m_pImpl(new TestImpl),
 m_pDoc(nullptr)
@@ -174,302 +145,6 @@ void Test::tearDown()
 BootstrapFixture::tearDown();
 }
 
-#define PERF_ASSERT(df,scale,time,message) \
-do { \
-double dfscaled = df / scale; \
-if ((dfscaled) >= (time)) \
-{ \
-std::ostringstream os; \
-os << message " took " << dfscaled << " pseudo-cycles (" << df << 
" real-time seconds), expected: " << time << " pseudo-cycles."; \
-CPPUNIT_FAIL(os.str().c_str()); \
-} \
-} while (false)
-
-void Test::testPerf()
-{
-CPPUNIT_ASSERT_MESSAGE ("failed to insert sheet", m_pDoc->InsertTab (0, 
"foo"));
-
-// First do a set of simple operations to try to work out
-// how fast (or not) this particular machine is:
-double scale;
-{
-MeasureTimeSwitch aTime(scale);
-for (int i = 0; i < 1000; ++i)
-{
-// Bang on the allocator
-volatile ScRange *pRange = new ScRange (ScAddress (0,0,0));
-// Calc does quite a bit of string conversion
-volatile double it = OUString::number ((double)i/253.0).toDouble();
-// Do we have floating point math ?
-volatile double another = rtl::math::sin (it);
-(void)another;
-delete pRange;
-}
-}
-printf("CPU scale factor %g\n", scale);
-
-// FIXME: we should check if this already took too long
-// and if so not run the perf. tests to have pity on some
-// slow ARM machines - I think.
-
-// to make the numbers more round and helpful,
-// but the calculation of scale reasonably precise.
-scale /= 10.0;
-
-double diff;
-
-// Clearing an already empty sheet should finish in a fraction of a
-// second.  Flag failure if it takes more than one second.  Clearing 100
-// columns should be large enough to flag if something goes wrong.
-{
-MeasureTimeSwitch aTime(diff);
-clearRange(m_pDoc, ScRange(0,0,0,99,MAXROW,0));
-}
-PERF_ASSERT(diff, scale, 1.0, "Clearing an empty sheet");
-
-{
-// Switch to R1C1 to make it easier to input relative references in 
multiple cells.
-FormulaGrammarSwitch aFGSwitch(m_pDoc, 
formula::FormulaGrammar::GRAM_ENGLISH_XL_R1C1);
-
-// Insert formulas in B1:B10. This shouldn't take long, but may 
take
-// close to a second on a slower machine. We don't measure this yet, 
for
-// now.
-for (SCROW i = 0; i < 10; ++i)
-m_pDoc->SetString(ScAddress(1,i,0), "=RC[-1]");
-
-// Now, Delete B2:B10. This should complete in a fraction of a 
second
-// (0.06 sec on my machine).
-{
-MeasureTimeSwitch aTime(diff);
-clearRange(m_pDoc, ScRange(1,1,0,1,9,0));
-}
-PERF_ASSERT(diff, scale, 2000, "Removal of a large array of formula 
cells");
-}
-
-clearRange(m_pDoc, ScRange(0,0,0,1,MAXROW,0)); // Clear columns A:B.
-CPPUNIT_ASSERT_MESSAGE("Column A shouldn't have any broadcasters.", 
!m_pDoc->HasBroadcaster(0,0));
-CPPUNIT_ASSERT_MESSAGE("Column B shouldn't have any broadcasters.", 
!m_pDoc->HasBroadcaster(0,1));
-
-{
-// Measure the performance of 

[Libreoffice-bugs] [Bug 99716] New: RFE: please break recents apart from registrymodifications.xcu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99716

Bug ID: 99716
   Summary: RFE: please break recents apart from
registrymodifications.xcu
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: enhancement
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: toddandma...@zoho.com

LibreOffice_5.1.2_Linux_x86-64_rpm.tar.gz

Dear Libre Office,

User profiles corrupt a lot after upgraded.  (It is really a common occurrence
for me.)  See bug 99490 for lost spell checker.

Now the custom dictionary is easy to copy back from the old corrupted profile
but the recents are not as it is included in registrymodifications.xcu.

Request for Enhancement:  Please break the recents into their own file so they
can be easily restored after having to create a new profile.

Many thanks,
-T

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa

[Markus Mohrhard]

 sc/qa/perf/scperfobj.cxx |   10 +-
 1 file changed, 1 insertion(+), 9 deletions(-)

New commits:
commit d223aa57a1d6e356f24cd5ac4ddd702336b2ee87
Author: Markus Mohrhard 
Date:   Sat May 7 01:22:11 2016 +0200

these static vars are cargo cult copy

Change-Id: Iabf02c2afc156cf30841eda48f3d67b18bb1e720
Reviewed-on: https://gerrit.libreoffice.org/24710
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/qa/perf/scperfobj.cxx b/sc/qa/perf/scperfobj.cxx
index 8bc12ca..c08dcb1 100644
--- a/sc/qa/perf/scperfobj.cxx
+++ b/sc/qa/perf/scperfobj.cxx
@@ -78,8 +78,7 @@ public:
 
 private:
 
-static sal_Int32 nTest;
-static uno::Reference< lang::XComponent > mxComponent;
+uno::Reference< lang::XComponent > mxComponent;
 
 // tests
 void testSheetFindAll();
@@ -102,9 +101,6 @@ private:
 void testMatConcatLarge();
 };
 
-sal_Int32 ScPerfObj::nTest = 0;
-uno::Reference< lang::XComponent > ScPerfObj::mxComponent;
-
 ScPerfObj::ScPerfObj()
 : CalcUnoApiTest("sc/qa/perf/testdocuments/")
 {
@@ -112,9 +108,6 @@ ScPerfObj::ScPerfObj()
 
 uno::Reference< uno::XInterface > ScPerfObj::init(const OUString& aFileName)
 {
-if (mxComponent.is())
-closeDocument(mxComponent);
-
 OUString aFileURL;
 createFileURL(aFileName, aFileURL);
 
@@ -127,7 +120,6 @@ uno::Reference< uno::XInterface > ScPerfObj::init(const 
OUString& aFileName)
 
 void ScPerfObj::setUp()
 {
-nTest++;
 CalcUnoApiTest::setUp();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99696] Build for x64 fails unit tests using ADODB

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99696

Tomofumi Yagi  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

--- Comment #1 from Tomofumi Yagi  ---
I can reproduce the problem with master on Windows 10(64 bit).

Version: 5.2.0.0.alpha1+ (x64)
Build ID: 945064c0b7ad4da6e215668ae7e4edb14945f00c
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: ja-JP (ja_JP)

I installed 32 bit version of Microsoft Office 2016.

My autogen.input is as follows.
--with-distro=LibreOfficeWin64
--with-visual-studio=2013
--with-ant-home=/opt/ant
--disable-firebird-sdbc
--enable-debug
--with-lang=ja

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99490] After upgrading, spell checker no longer works

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99490

--- Comment #6 from Todd  ---
Created attachment 124888
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124888=edit
offending registrymodifications that kill spell check

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99591] Math; Sidebar ‘Elements’?=:=?UTF-8?Q? spacing of the section ‘Operators’ is very small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99591

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #2 from Regina Henschel  ---
That is likely connected with the wrong rendering of "from", "to" and "csub",
see bug 98238

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: 3 commits - sc/source

[Eike Rathke]

 sc/source/core/tool/interpr8.cxx |   14 +-
 1 file changed, 5 insertions(+), 9 deletions(-)

New commits:
commit 2844f3114c2a7b122fe299ed21ed06ca57866e47
Author: Eike Rathke 
Date:   Fri May 6 22:01:46 2016 +0200

actually propagate a match expression error, tdf#97831 follow-up

Change-Id: Iaeecf371af8dd5f6c2cbdea2f114566e8bf7cf47

diff --git a/sc/source/core/tool/interpr8.cxx b/sc/source/core/tool/interpr8.cxx
index 36304d8..7d1349f 100644
--- a/sc/source/core/tool/interpr8.cxx
+++ b/sc/source/core/tool/interpr8.cxx
@@ -1952,6 +1952,7 @@ void ScInterpreter::ScSwitch_MS()
 isValue = ScMatrix::IsValueType( GetDoubleOrStringFromMatrix( 
fRefVal, aRefStr ) );
 break;
 default :
+PopError();
 PushIllegalArgument();
 return;
 }
commit c54f6161480fc3721bf8e208cd12a7446ab608b7
Author: Eike Rathke 
Date:   Fri May 6 21:52:28 2016 +0200

coverity#1359230 DEADCODE, detect missing parameter, tdf#97831 follow-up

... so SWITCH with less than 3 parameters returns the proper error code
instead of #N/A.

Change-Id: Ib5d696a640f7084ca46c3cf8f378ea6e659e3f11

diff --git a/sc/source/core/tool/interpr8.cxx b/sc/source/core/tool/interpr8.cxx
index 1b7bf6d..36304d8 100644
--- a/sc/source/core/tool/interpr8.cxx
+++ b/sc/source/core/tool/interpr8.cxx
@@ -1913,6 +1913,9 @@ void ScInterpreter::ScSwitch_MS()
 {
 short nParamCount = GetByte();
 
+if (!MustHaveParamCountMin( nParamCount, 3))
+return;
+
 ReverseStack( nParamCount );
 
 nGlobalError = 0;   // propagate only for match or active result path
@@ -1970,13 +1973,6 @@ void ScInterpreter::ScSwitch_MS()
  ( !isValue && aRefStr.getDataIgnoreCase() == 
aStr.getDataIgnoreCase() )) )
 {
 // TRUE
-if ( nParamCount < 1 )
-{
-// no parameter given for THEN
-nGlobalError = nFirstMatchError;
-PushParameterExpected();
-return;
-}
 bFinished = true;
 }
 else
commit 0ed8a6a5bbe31c9713d017594fbbcf38618e8c1d
Author: Eike Rathke 
Date:   Fri May 6 21:29:57 2016 +0200

coverity#1359229 handle PopDoubleRefOrSingleRef() as usual

Change-Id: Ib74f00725f2e8b78cbbb92ef9760da74401c1984

diff --git a/sc/source/core/tool/interpr8.cxx b/sc/source/core/tool/interpr8.cxx
index 5cb33f0..1b7bf6d 100644
--- a/sc/source/core/tool/interpr8.cxx
+++ b/sc/source/core/tool/interpr8.cxx
@@ -1933,8 +1933,7 @@ void ScInterpreter::ScSwitch_MS()
 case svDoubleRef :
 {
 ScAddress aAdr;
-PopDoubleRefOrSingleRef( aAdr );
-if ( nGlobalError )
+if (!PopDoubleRefOrSingleRef( aAdr ))
 break;
 ScRefCellValue aCell( *pDok, aAdr );
 isValue = !( aCell.hasString() || aCell.hasEmptyValue() || 
aCell.isEmpty() );
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 94642] Getting Error when installing update

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94642

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |INSUFFICIENTDATA

--- Comment #2 from Aron Budea  ---
Since several months have passed, and there are not enough details to proceed,
I'm closing this bug. Please try with latest version, and reopen with further
details if the issue persists.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94282] Confusing error during install

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94282

Aron Budea  changed:

   What|Removed |Added

 CC||ba...@caesar.elte.hu

--- Comment #3 from Aron Budea  ---
I agree that dialog is not informative. Unfortunately Files in Use is a Windows
Installer feature, and what is displayed there is up to Windows, and not the
installed application.

For your information, "Microsoft Windows Search Filter Host" is a system
service, that's why there was no such name among tasks in Task Manager, however
showing PIDs can be enabled in View/Select Column, and system processes can be
included with "Show processes from all users" button. Alternatively there's a
Services tab, which lists PIDs for running services.

Apparently, Windows Installer has a Restart Manager feature to make updating
files in use more convenient, but I have no information on how LO's installer
is set up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99715] New: Help text incorrect concerning location of autocalculate menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99715

Bug ID: 99715
   Summary: Help text incorrect concerning location of
autocalculate menu
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: b...@homefarmparham.co.uk

Selecting Help > Libre Office Help > Search tab > "Autocalculate" 
says:
"To access this command... 
Choose Tools - Cell Contents - AutoCalculate" 

However, there is no Cell Contents entry on the Tools menu.
The help text should say:
"Choose Data - Calculate - Autocalculate"

I suspect the autocalculate menu has been moved since a previous version. 


https://help.libreoffice.org/Calc/AutoCalculate
also gives the same incorrect information.

However, it is not clear (to me) how to determine what version of Calc the Help
Web site refers to, or how to get help for a specific version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99708] Calc multiline input doesn't remember state

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99708

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
I`m not sure it's always useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/osx

[Michael Stahl]

 vcl/osx/clipboard.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3342a05529b1fb33db4f1126b5836249551890f3
Author: Michael Stahl 
Date:   Fri May 6 23:49:57 2016 +0200

vcl: oops, so there was a macro there

Change-Id: I824fa3c83a5bc8b68a6554c9bfe5ce5b3c2d711f

diff --git a/vcl/osx/clipboard.cxx b/vcl/osx/clipboard.cxx
index 1e277e2..be86d28 100644
--- a/vcl/osx/clipboard.cxx
+++ b/vcl/osx/clipboard.cxx
@@ -277,7 +277,7 @@ void AquaClipboard::fireClipboardChangedEvent()
 
 void AquaClipboard::fireLostClipboardOwnershipEvent(Reference 
oldOwner, Reference oldContent)
 {
-BOOST_ASSERT(oldOwner.is());
+assert(oldOwner.is());
 
 try { oldOwner->lostOwnership(static_cast(this), 
oldContent); }
 catch(RuntimeException&) { }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 6 commits - accessibility/inc basctl/inc basegfx/inc basegfx/source connectivity/inc connectivity/source cppu/qa cui/inc oox/inc oox/source sd/inc sd/source slideshow/s

[Michael Stahl]

 accessibility/inc/pch/precompiled_acc.hxx   |1 
 basctl/inc/pch/precompiled_basctl.hxx   |1 
 basegfx/inc/pch/precompiled_basegfx.hxx |1 
 basegfx/source/range/b2drangeclipper.cxx|4 
 connectivity/inc/pch/precompiled_dbtools.hxx|1 
 connectivity/inc/pch/precompiled_odbc.hxx   |2 
 connectivity/source/commontools/FValue.cxx  |1 
 connectivity/source/drivers/odbc/OPreparedStatement.cxx |5 
 cppu/qa/test_any.cxx|   10 
 cui/inc/pch/precompiled_cui.hxx |1 
 oox/inc/pch/precompiled_oox.hxx |1 
 oox/source/drawingml/fillproperties.cxx |   49 
 sd/inc/pch/precompiled_sd.hxx   |1 
 sd/source/ui/slidesorter/controller/SlsScrollBarManager.cxx |2 
 sd/source/ui/slidesorter/inc/model/SlsPageDescriptor.hxx|4 
 slideshow/source/inc/listenercontainer.hxx  |4 
 svx/source/form/fmscriptingenv.cxx  | 1048 +---
 vcl/osx/clipboard.cxx   |1 
 xmloff/inc/pch/precompiled_xo.hxx   |1 
 xmloff/source/core/RDFaExportHelper.cxx |   24 
 xmloff/source/core/RDFaImportHelper.cxx |   30 
 21 files changed, 575 insertions(+), 617 deletions(-)

New commits:
commit 631191c72f84a4ed1c2f8312d0764ef480961dce
Author: Michael Stahl 
Date:   Fri May 6 23:17:16 2016 +0200

svx: replace boost::assign::list_of with C++11

"The purpose of this library is to make it easy to fill containers with
data by overloading operator,() and operator()()" - can't make this up!

Change-Id: Ia6f0840232a8048817dc8a09f4ab233b585ae9da

diff --git a/svx/source/form/fmscriptingenv.cxx 
b/svx/source/form/fmscriptingenv.cxx
index c4b9bc4..3cc284e 100644
--- a/svx/source/form/fmscriptingenv.cxx
+++ b/svx/source/form/fmscriptingenv.cxx
@@ -37,7 +37,6 @@
 #include 
 #include 
 
-#include 
 #include 
 #include 
 #include 
@@ -182,530 +181,529 @@ namespace svxform
 // since we got rid of the notion of oneway, this is the list
 // of oneway methods, autogenerated by postprocessing of
 // commitdiff 90eac3e69749a9227c4b6902b1f3cef1e338c6d1
-static std::set< pair< OUString, OUString > > delayed_event_listeners =
-boost::assign::list_of
-
(pair("com.sun.star.accessibility.XAccessibleComponent","grabFocus"))
-
(pair("com.sun.star.accessibility.XAccessibleEventBroadcaster","addAccessibleEventListener"))
-
(pair("com.sun.star.accessibility.XAccessibleEventBroadcaster","removeAccessibleEventListener"))
-
(pair("com.sun.star.accessibility.XAccessibleSelection","clearAccessibleSelection"))
-
(pair("com.sun.star.accessibility.XAccessibleSelection","selectAllAccessibleChildren"))
-
(pair("com.sun.star.awt.XActionListener","actionPerformed"))
-
(pair("com.sun.star.awt.XActivateListener","windowActivated"))
-
(pair("com.sun.star.awt.XActivateListener","windowDeactivated"))
-
(pair("com.sun.star.awt.XAdjustmentListener","adjustmentValueChanged"))
-
(pair("com.sun.star.awt.XButton","addActionListener"))
-
(pair("com.sun.star.awt.XButton","removeActionListener"))
-(pair("com.sun.star.awt.XButton","setLabel"))
-
(pair("com.sun.star.awt.XButton","setActionCommand"))
-
(pair("com.sun.star.awt.XCheckBox","addItemListener"))
-
(pair("com.sun.star.awt.XCheckBox","removeItemListener"))
-(pair("com.sun.star.awt.XCheckBox","setState"))
-(pair("com.sun.star.awt.XCheckBox","setLabel"))
-
(pair("com.sun.star.awt.XCheckBox","enableTriState"))
-
(pair("com.sun.star.awt.XComboBox","addItemListener"))
-
(pair("com.sun.star.awt.XComboBox","removeItemListener"))
-
(pair("com.sun.star.awt.XComboBox","addActionListener"))
-
(pair("com.sun.star.awt.XComboBox","removeActionListener"))
-(pair("com.sun.star.awt.XComboBox","addItem"))
-(pair("com.sun.star.awt.XComboBox","addItems"))
-
(pair("com.sun.star.awt.XComboBox","removeItems"))
-

Re: Fix for Bug 98940

[Michael Stahl]

On 04.05.2016 14:33, Matteo Casalin wrote:
> Hi Michael,
> thanks for the details.
> I tried the "gerrit cherry-pick to libreoffice-5-1" method, and it seems [1] 
> that the same one-line patch is enough. I agree that the fix is trivial, so I 
> would prefer not testing it since my machine is quite slow - but if required 
> I can give it a try.

great, looks like it was reviewed in the mean time :)

> Just to be sure: 5.1.4 will be branched from 5.1, not from 5.1.3, right?

yes, there is only one micro release from each libreoffice-x-y-z branch,
and the next libreoffice-x-y-z+1 is branched from libreoffice-x-y again.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 96275] FILEOPEN RTF: Incorrect basic shape position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96275

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |vmik...@collabora.co.uk
   |desktop.org |

--- Comment #9 from Miklos Vajna  ---
The "frame" shape is anchored inside a table, and the anchor position is
incorrect in this case. I'll fix that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90786] Spellchecker selected but not installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90786

--- Comment #3 from Michael Bauer  ---
Actually 3.1 by now :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64239] FILESAVE: lines not saved correctly after opened from Power Point / lines not possible to delete on slides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64239

--- Comment #7 from Ljiljan  ---
I don't have original file anymore (or if I have it I cannot find it anymore).

However, in LibreOffice 5.1. the red line can be deleted or reduced.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48459] FORMATTING - proposal for in-line headings, (run-in, inset headings)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48459

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
   See Also||https://bz.apache.org/ooo/s
   ||how_bug.cgi?id=39582

--- Comment #15 from V Stuart Foote  ---
Further to Owen's work around in comment 8, seems the desired effect can also
be achieved with a pair of linked Text Frames. 

The first Text Frame contains the text to be used as the index or ToC is linked
to a second that has the same anchor.  Simply duplicate the text and formatting
of the run-in in the second, they'll overlay (or use white space). Borders will
need to be cleared, and spacing above/below to other paragraphs might need to
be adjusted.

Apply outline level to the paragraph in 1st frame--it will pick up in
Index/ToC.

The linked frames also work for the Side headings of original AOO bz#39582

As Text Frames (unlike Draw Text Box), they take all available formatting for
the contained text.

Might be a little fiddly to get the exact spacing for a given publication
"style"--but ought to be functional until a dev decides to hack at things.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90786] Spellchecker selected but not installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90786

--- Comment #2 from Aron Budea  ---
Note to LO team: LO 5.1.2 comes with hunspell-gd v2.8, latest version is v2.9.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99594] Cannot update my Libre Office 4.4.5.2 to 5.1.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99594

--- Comment #3 from Aron Budea  ---
Can you try renaming the installer to the expected file name?
Alternatively, try reinstalling LibreOffice 4.3.7 from the installer, and then
updating to the new version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99705] Active cell not highlighted / bordered when OpenGL is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99705

--- Comment #4 from Octavio Alvarez  ---
Considering that OpenGL makes a difference in my setup, I will try to gather
information regarding video drivers and video cards.

Joel, thank you for testing. Can you post your video card model and video
driver?

Raal, can you post your complete LibO version, your Ubuntu version, your video
card model and video driver?

Raal, also, I just tested on a clean profile (renamed all my
.libreoffice-related directories and verified a new one still got created) and
the problem persists.

BTW, my version is:
Version: 5.1.3.1
Build ID: 1:5.1.3~rc1-1, CPU Threads: 4; OS Version: Linux 4.5; UI Render:
default
Locale: en-US (en_US.utf8)
OS: Debian Sid.
Video card: 8086:0046 (lspci -n), Intel Corporation Core Processor Integrated
Graphics Controller (rev 02) (prog-if 00 [VGA controller]) on Samsung R730 (as
reported by lspci -v, really an R540) and using Intel i915 driver.

I will try on two more computers in the course of the day and report back.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99714] New: Auto numbering Frames / marginalias

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99714

Bug ID: 99714
   Summary: Auto numbering Frames / marginalias
   Product: LibreOffice
   Version: 5.0.5.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hkn...@gmail.com

Numbering frames and marginalias via "paragraph style: Frame contents" does not
function properly.

First, the numbering confuses when I insert a new frame in between old frames.
The new frame in between gets the highest/last number even though it is
somewhere in the middle.

Secondly, "paragraph style: Frame contents" starts not the respond to
amendments. I remove "numbering" under "outline & numbering" tab, however
nothing changes. The frames still contain wrong numbers.

Thank you for your time,
Hakan

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99705] Active cell not highlighted / bordered when OpenGL is disabled

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99705

raal  changed:

   What|Removed |Added

 CC||r...@post.cz
Version|unspecified |5.1.2.2 release

--- Comment #3 from raal  ---
No repro 5.1.2.2, Ubuntu.

For the test, could you rename your LibreOffice directory profile (see
https://wiki.documentfoundation.org/UserProfile) and give it a new try? Thank
you

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99679] cell formatting lost when saving in xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99679

--- Comment #7 from raal  ---
No repro with 5.1.2,win7. Format 0,00  stay the same after save and reopen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90786] Spellchecker selected but not installed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=90786

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
Version|unspecified |4.3.6.2 release
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Can confirm.
I modified my LO 5.1.2 installation, and added Scottish Gaelic dictionary, but
in Writer/Calc spell checker Scottish Gaelic still did not appear among the
available languages.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source

[Eike Rathke]

 sc/source/core/tool/compiler.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit 7ff50286bf7a8d99711388dfe7bb5ebeca4aa4d0
Author: Eike Rathke 
Date:   Fri May 6 16:56:29 2016 +0200

tdf#86575 for OOXML write plain #REF! if deleted parts

(cherry picked from commit bb0ef99fb9dce30e99a7e9f7fa295a634d07b423)

write the [#REF!] as defined in ODFF, tdf#86575 related

... if a part of the reference was deleted, instead of [.#REF!A1]

Actually this is a regression that already can be tracked down to
c54616f62bc70a9d39abf8837a9d7c3031c80a41 which changed things to use
ValidAddress() only.

(cherry picked from commit eeb203089f2ba6dffba9a2543c9a7e8bf551bbc5)

70f68722d7af02f6da3380c2dd9d54704c20b451

Change-Id: Ie3233d72bdbdd0ab82386c98a46755ce64ef3e7f
Reviewed-on: https://gerrit.libreoffice.org/24705
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 9d27219..a841c80 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1023,7 +1023,8 @@ struct ConventionOOO_A1_ODF : public ConventionOOO_A1
 if( !bSingleRef )
 aAbs2 = rRef.Ref2.toAbs(rPos);
 
-if (FormulaGrammar::isODFF(eGram) && (!ValidAddress(aAbs1) || 
!ValidAddress(aAbs2)))
+if (FormulaGrammar::isODFF(eGram) && (rRef.Ref1.IsDeleted() || 
!ValidAddress(aAbs1) ||
+(!bSingleRef && (rRef.Ref2.IsDeleted() || 
!ValidAddress(aAbs2)
 {
 rBuffer.append(rErrRef);
 // For ODFF write [#REF!], but not for PODF so apps reading ODF
@@ -1421,6 +1422,14 @@ struct ConventionXL_OOX : public ConventionXL_A1
 aPos.SetRow(0);
 }
 
+if (rRef.Ref1.IsDeleted() || (!bSingleRef && rRef.Ref2.IsDeleted()))
+{
+// For OOXML write plain "#REF!" instead of detailed sheet/col/row
+// information.
+rBuf.append(rErrRef);
+return;
+}
+
 ConventionXL_A1::makeRefStr( rBuf, eGram, aPos, rErrRef, rTabNames, 
rRef, bSingleRef, bFromRangeName);
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96609] FORMATTING: Picture disappears between page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96609

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #6 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today, I could reproduce this.

Remark: the picture isn't lost, if you save and reopen the file, the image is
still here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99713] 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Resolution|NOTABUG |INVALID

--- Comment #2 from V Stuart Foote  ---
Seems an RTM issue as Sections are well documented in built-in help. And are
well covered with examples in the LibreOffice Writer Guide (4.2 version
pg.138-145)

Sections present in a document are visible with or without non-printing
characters toggled visible, and receive a default outline of the
Section--similar to what shows for page margins.

Sections are inserted into a document from the main menu Insert -> Section
launch of the Insert Section dialog. 

They also display individually in the Navigator Sidebar content panel and can
be selected for editing there.

They can be modified/reformatted from main menu Format -> Sections.

Once a Section is selected, the Options button on the "Edit Sections" dialog
reopens the dialog panels (Columns, Indents, Background, Footnotes/Endnotes)
present when created from the "Insert Section" dialog.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 99713] 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Resolution|NOTABUG |INVALID

--- Comment #2 from V Stuart Foote  ---
Seems an RTM issue as Sections are well documented in built-in help. And are
well covered with examples in the LibreOffice Writer Guide (4.2 version
pg.138-145)

Sections present in a document are visible with or without non-printing
characters toggled visible, and receive a default outline of the
Section--similar to what shows for page margins.

Sections are inserted into a document from the main menu Insert -> Section
launch of the Insert Section dialog. 

They also display individually in the Navigator Sidebar content panel and can
be selected for editing there.

They can be modified/reformatted from main menu Format -> Sections.

Once a Section is selected, the Options button on the "Edit Sections" dialog
reopens the dialog panels (Columns, Indents, Background, Footnotes/Endnotes)
present when created from the "Insert Section" dialog.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 95780] Image File read errors (multiple images displayed)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95780

Julien Nabet  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||serval2...@yahoo.fr

--- Comment #5 from Julien Nabet  ---
Files seem to be having added as relatives and not included in docx.
Indeed, unzipping the docx and taking a look word/_rels/document.xml.rels, I
noticed these links:
http://schemas.openxmlformats.org/package/2006/relationships;>
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/styles;
Target="styles.xml" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/Teleferiche%20e%20interruzioni%20stradali%20Rif%20Pedercini%20IMG_6486_cr.jpg"
  TargetMode="External" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/Ed%20So%2041%20latrina%20ufficiali%20Orinatoio%20R0018797.JPG"
  TargetMode="External" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/1916%2012%20alto%20garda%20nota%20centrale%20elettrica%20doc%20foto%20cartina%20%20f568%20(1)_cr.jpg"
  TargetMode="External" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/1916%2012%20alto%20garda%20nota%20centrale%20elettrica%20doc%20foto%20cartina%20%20f568%20(6)_cr.jpg"
  TargetMode="External" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/Interruzione%20stradale%20Strada%20Gargnano%20Vesio%20e%20Passo%20Nota%20Piano%20di%20Bondo%20SWScan00423_cr.jpg"
  TargetMode="External" />
  http://schemas.openxmlformats.org/officeDocument/2006/relationships/image;
 
Target="file:///C:/Forti%20Alto%20Garda/Progetti%20intervento/Progetti%20regionali%202014/Comunità%20Montana%20Alto%20Garda/Percorsi/Passo%20Nota/Percorso%20Rifugio%20Pedercini/Immagini/SWScan00426_cr.jpg"
TargetMode="External" />

So we can't really test your file since we don't have the jpg files.

Do you still reproduce the problem you described with last stable LO version
(5.1.2)?
Indeed, 4.X is EOL.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48459] FORMATTING - proposal for in-line headings, (run-in, inset headings)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48459

--- Comment #14 from Marc Grober  ---
(In reply to Joel Madero from comment #7)
> That being said - your description is very concise. Agreed it's a valid
> request.
> 
> Marking as:
> New
> Enhancement
> Medium - I don't see this benefiting a huge proportion of our user base
> (most use our software for basic things) but as the comment points out, it
> could be required for "higher end" tasks such as academic papers.
> 
> Also:
> Might be an easy hack so adding that, I agree with the idea that there
> should just be a check box that by default is unchecked but which can be
> unchecked and it says something like "In-Line Heading" and can be applied to
> any style

Re: "most use our software for basic things" -- I don't know what the source of
your data is, but with shrinking education budgets everywhere one looks, more
and more students employing LO, and students writing academic papers perhaps
numbering over half the potential user base for the product, I'd say you were
being a touch myopic.

Re: "might be an easy hack" -- yes, and I think simply tweaking the ToC
generator to accept Character Styles for indexing might even be easier.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48459] FORMATTING - proposal for in-line headings, (run-in, inset headings)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48459

--- Comment #13 from Marc Grober  ---
Just came across this as I discovered the ion-line/run-in key words when
building 99695 (see dup link above).  My comments there have some additional
info.

My proposal was simply to allow the use of Character Styles in the ToC in
addition to Paragraph Styles.  In that way, one could create a set of specific
inheriting Character Styles for various ToC (or index or bibs) levels, and it
would be relatively easy to share those styles, making an effective and easy to
use template much simpler.

Owen's workaround is much better than others I have seen, but it would in my
view still be an all round functional improvement to be able to use Character
Styles  in addition to Paragraph styles.

If you disagree that this is a dupe we can always split it up again

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99713] 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

larrybradley  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 99713] 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

larrybradley  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 48459] FORMATTING - proposal for in-line headings, (run-in, inset headings)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48459

Marc Grober  changed:

   What|Removed |Added

 CC||m...@interak.com

--- Comment #12 from Marc Grober  ---
*** Bug 99695 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99695] Table of Contents (ToC) can't index Character style so as to generate APA Styled ToC with Heading 3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99695

Marc Grober  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Marc Grober  ---
https://bugs.documentfoundation.org/show_bug.cgi?id=48459

*** This bug has been marked as a duplicate of bug 48459 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: LibreOffice Windows installer release build failure

[Stuart Swales]

On 05/05/2016 22:14, Markus Mohrhard wrote:

Hey,

On Thu, May 5, 2016 at 4:55 PM, Stuart Swales
> wrote:

I need to build the Windows installer in order to test some changes to
the installer code. Having had problems building before (last Dec) with
VS2013 I just checked out master and tried to build before making
any of these amendments.

Build on Windows 7 (32-bit) VM with
Visual Studio 2015 Community (Update 2)
Windows 10 SDK 10586.15
Setup with LODE

make works OK
make test-install works OK
make install FAILS

...

The _MergeErrors.idt extracted from the updated MSI is helpfully opaque:

TableNumRowMergeConflicts
s255i2
_MergeErrorsTable
_Validation2


There is no _MergeErrors table in the original MSI (copied as
libreoffice52_en-US.ms.1)

Any ideas?



We normally don't use make install. Use --with-package-format=msi in
your autogen.sh settings and it will produce the msi file during a
normal build.

Regards,
Markus


Thanks Markus - works a treat.

Regards,
Stuart

--
Stuart Swales
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99713] 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

Joel Madero  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com,
   ||libreoffice-ux-advise@lists
   ||.freedesktop.org
 Ever confirmed|0   |1

--- Comment #1 from Joel Madero  ---
UX needs to input here. Moving to NEW and letting them have their say.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72504

--- Comment #25 from Guillermo Lo Coco  ---
Thanks Joel,
I appreciate your sincerity and very fast reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99695] Table of Contents (ToC) can't index Character style so as to generate APA Styled ToC with Heading 3

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99695

--- Comment #5 from Marc Grober  ---
On further research I find that MS Word suffers from the same problem, but
manages a work around by allowing the user to select a paragraph symbol, and
then hide it. See, http://www.k-state.edu/grad/etdr/word/APAheadings.html. 
That is not possible in LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99713] New: 'Sections' in Writer completely counter-intuitive to Word users, do not appear in non-printing characters mode.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99713

Bug ID: 99713
   Summary: 'Sections' in Writer completely counter-intuitive to
Word users, do not appear in non-printing characters
mode.
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: larrywbrad...@gmail.com

As a (mostly former) power user of Word, the one feature of LO that is most
difficult for me to figure out (i.e, the most "geeky" / "techie") is Sections.
Even with Help, cannot figure out how to insert them, change them, etc. Would
help a great deal if Sections worked like something even close to how they work
in Word, and would help even more if Sections could be seen when "Non-printing
characters" function (Ctrl-F10) is invoked. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45028] label of connector gets written through line

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45028

--- Comment #15 from Hans Deragon  ---
Am curious about how The Document Foundation produced that graphic without a
hint of this bug.

https://commons.wikimedia.org/wiki/File:TDF_Orga.png

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99679] cell formatting lost when saving in xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99679

roberto  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #6 from roberto  ---
I don't know, I just wrote a comment in the previous screen. Here it is again:

The reason why I only included the .xlsx file is because that is the file that
is giving the problem. 
Column A is date format -mm-22 and column B is number format with two
decimals. I can repeatedly set these formats but every time I open the file the
number format has changed to "no decimals". Actually sometimes the date format
also changes, but I cannot consistently repeat that. Although the file started
out originally as an .ods it has for quite a while been just an .xlsx, the
reason being that is located in my Dropbox and in .xlsx format it can more
easily be read on other devices such Chromebook or my phone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99679] cell formatting lost when saving in xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99679

--- Comment #5 from roberto  ---
Created attachment 124887
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124887=edit
test file

The reason why I only included the .xlsx file is because that is the file that
is giving the problem. 
Column A is date format -mm-22 and column B is number format with two
decimals. I can repeatedly set these formats but every time I open the file the
number format has changed to "no decimals". Actually sometimes the date format
also changes, but I cannot consistently repeat that. Although the file started
out originally as an .ods it has for quite a while been just an .xlsx, the
reason being that is located in my Dropbox and in .xlsx format it can more
easily be read on other devices such Chromebook or my phone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59108] no formula update when deleteing referenced row/column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59108

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #9 from Eike Rathke  ---
This is not a bug. References referencing exactly one deleted sheet/column/row 
are invalidated if that very sheet/column/row is deleted, never point to
something different after.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 59108] no formula update when deleteing referenced row/column

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=59108

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 66545] FORMATTING: Disabling grey field shading of hyperlinks in CALC

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=66545

Jean-Baptiste Faure  changed:

   What|Removed |Added

Version|unspecified |Inherited From OOo
   Severity|normal  |enhancement

--- Comment #10 from Jean-Baptiste Faure  ---
Nothing changed in LO 5.1.4.0.0+ and master, both build at home under Ubuntu
16.04 x86-64.

Set as enhancement because this field shading is there by design.
Set version to inherited from OOo because it was already the case in OOo and LO
did not change that.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83746] FILEOPEN: When opening an .xls with a 1-1M VLOOKUP range, the range is truncated to 1-983040

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=83746

Eike Rathke  changed:

   What|Removed |Added

 CC||er...@redhat.com

--- Comment #11 from Eike Rathke  ---
We can't do anything about the 65536 row limit of .xls, but the
983040=1048576-65536 looks odd and likely should be handled differently..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88245] A specific font in an RTF file causes an endless loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88245

Joel Madero  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #6 from Joel Madero  ---
Given that Buovjaga already said it's working in 4.5 but was broken in 4.4, I'm
going to just close it as WFM.

@Urmas - if confirmed on 5.1 just set it back to NEW and leave a comment.
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47588] Calc stops indexing VLOOKUP in xls format after 65536 rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47588

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #7 from Eike Rathke  ---
It does not. However, the page stating so
http://office.microsoft.com/en-us/excel-help/excel-specifications-and-limits-HP005199291.aspx
(mentioned in bug 83746) seems to be gone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 47588] Calc stops indexing VLOOKUP in xls format after 65536 rows

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=47588

Eike Rathke  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96208] MathML-Importfehler - Wäre die application/x-tex Annotation alternativ zu StarMath 5.0 einbaubar?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96208

--- Comment #3 from Miklos Vajna  ---
Can you please also translate the summary of this bug? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 88245] A specific font in an RTF file causes an endless loop

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=88245

--- Comment #5 from Miklos Vajna  ---
Can you confirm it with 5.1 or newer? Otherwise I would suggest to close this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: New Defects reported by Coverity Scan for LibreOffice

[Caolán McNamara]

On Fri, 2016-05-06 at 08:12 -0700, scan-ad...@coverity.com wrote:


> ** CID 1359230:  Control flow issues  (DEADCODE)
> /sc/source/core/tool/interpr8.cxx: 1977 in
> ScInterpreter::ScSwitch_MS()()
> 
> 
> _
> ___
> *** CID 1359230:  Control flow issues  (DEADCODE)
> /sc/source/core/tool/interpr8.cxx: 1977 in
> ScInterpreter::ScSwitch_MS()()
> 1971  ( !isValue && aRefStr.getDataIgnoreCase() ==
> aStr.getDataIgnoreCase() )) )
> 1972 {
> 1973 // TRUE
> 1974 if ( nParamCount < 1 )
> 1975 {
> 1976 // no parameter given for THEN
> > > > CID 1359230:  Control flow issues  (DEADCODE)
> > > > Execution cannot reach this statement: "this->nGlobalError
> > > > = nFirst...".
> 1977 nGlobalError = nFirstMatchError;
> 1978 PushParameterExpected();
> 1979 return;
> 1980 }
> 1981 bFinished = true;
> 1982 }
> 
> ** CID 1359229:  Error handling issues  (CHECKED_RETURN)
> /sc/source/core/tool/interpr8.cxx: 1936 in
> ScInterpreter::ScSwitch_MS()()
> 
> 
> _
> ___
> *** CID 1359229:  Error handling issues  (CHECKED_RETURN)
> /sc/source/core/tool/interpr8.cxx: 1936 in
> ScInterpreter::ScSwitch_MS()()
> 1930 aRefStr = GetString();
> 1931 break;
> 1932 case svSingleRef :
> 1933 case svDoubleRef :
> 1934 {
> 1935 ScAddress aAdr;
> > > > CID 1359229:  Error handling issues  (CHECKED_RETURN)
> > > > Calling "PopDoubleRefOrSingleRef" without checking return
> > > > value (as is done elsewhere 24 out of 25 times).
> 1936 PopDoubleRefOrSingleRef( aAdr );
> 1937 if ( nGlobalError )
> 1938 break;
> 1939 ScRefCellValue aCell( *pDok, aAdr );
> 1940 isValue = !( aCell.hasString() ||
> aCell.hasEmptyValue() || aCell.isEmpty() );
> 1941 if ( isValue )


These look worth looking at, especially the first one.

C.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-ux-advise] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89466

--- Comment #23 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7848ba85695e715a8faaf40c22df133388da5d8c

tdf#89466: Getting/setting page background works now

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sd/source

[Caolán McNamara]

 sd/source/ui/sidebar/SlideBackground.cxx |   46 ---
 1 file changed, 25 insertions(+), 21 deletions(-)

New commits:
commit f93ab86ea42789e6c3a18de83a2c838e3cd88de2
Author: Caolán McNamara 
Date:   Fri May 6 17:31:46 2016 +0100

coverity#1359233 Unchecked dynamic_cast

Change-Id: Icafdf8c187fc69866281e90bbb575e99c0f19024

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 884eca5..67ab9fc 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -381,10 +381,12 @@ void SlideBackground::NotifyItemUpdate(
 
 case SID_ATTR_PAGE_FILLSTYLE:
 {
-if(eState >= SfxItemState::DEFAULT)
+const XFillStyleItem* pFillStyleItem = nullptr;
+if (eState >= SfxItemState::DEFAULT)
+pFillStyleItem = dynamic_cast< const XFillStyleItem* >(pState);
+if (pFillStyleItem)
 {
-const XFillStyleItem* aFillStyleItem = dynamic_cast< const 
XFillStyleItem* >(pState);
-css::drawing::FillStyle eXFS = aFillStyleItem->GetValue();
+css::drawing::FillStyle eXFS = pFillStyleItem->GetValue();
 switch(eXFS)
 {
 case drawing::FillStyle_NONE:
@@ -412,10 +414,12 @@ void SlideBackground::NotifyItemUpdate(
 
 case SID_ATTR_PAGE_SIZE:
 {
-if(eState >= SfxItemState::DEFAULT)
+const SvxSizeItem* pSizeItem = nullptr;
+if (eState >= SfxItemState::DEFAULT)
+pSizeItem = dynamic_cast< const SvxSizeItem* >(pState);
+if (pSizeItem)
 {
-const SvxSizeItem* aSizeItem = dynamic_cast< const 
SvxSizeItem* >(pState);
-Size aPaperSize = aSizeItem->GetSize();
+Size aPaperSize = pSizeItem->GetSize();
 if(mpPaperOrientation->GetSelectEntryPos() == 0)
Swap(aPaperSize);
 
@@ -438,10 +442,12 @@ void SlideBackground::NotifyItemUpdate(
 
 case SID_ATTR_PAGE:
 {
-if(eState >= SfxItemState::DEFAULT)
+const SvxPageItem* pPageItem = nullptr;
+if (eState >= SfxItemState::DEFAULT)
+pPageItem = dynamic_cast< const SvxPageItem* >(pState);
+if (pPageItem)
 {
-const SvxPageItem* aPageItem = dynamic_cast< const 
SvxPageItem* >(pState);
-bool bIsLandscape = aPageItem->IsLandscape();
+bool bIsLandscape = pPageItem->IsLandscape();
 
 mpPaperOrientation->SelectEntryPos( bIsLandscape ? 0 : 1 );
 }
@@ -450,22 +456,20 @@ void SlideBackground::NotifyItemUpdate(
 
 case SID_DISPLAY_MASTER_BACKGROUND:
 {
-if(eState >= SfxItemState::DEFAULT)
-{
-const SfxBoolItem* aBoolItem = dynamic_cast< const 
SfxBoolItem* >(pState);
-if(aBoolItem)
-mpDspMasterBackground->Check(aBoolItem->GetValue());
-}
+const SfxBoolItem* pBoolItem = dynamic_cast< const SfxBoolItem* 
>(pState);
+if (eState >= SfxItemState::DEFAULT)
+pBoolItem = dynamic_cast< const SfxBoolItem* >(pState);
+if (pBoolItem)
+mpDspMasterBackground->Check(pBoolItem->GetValue());
 }
 break;
 case SID_DISPLAY_MASTER_OBJECTS:
 {
-if(eState >= SfxItemState::DEFAULT)
-{
-const SfxBoolItem* aBoolItem = dynamic_cast< const 
SfxBoolItem* >(pState);
-if(aBoolItem)
-mpDspMasterObjects->Check(aBoolItem->GetValue());
-}
+const SfxBoolItem* pBoolItem = nullptr;
+if (eState >= SfxItemState::DEFAULT)
+pBoolItem = dynamic_cast< const SfxBoolItem* >(pState);
+if (pBoolItem)
+mpDspMasterObjects->Check(pBoolItem->GetValue());
 }
 break;
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/sdi sd/source

[Katarina Behrens]

 sd/sdi/_drvwsh.sdi   |8 -
 sd/source/ui/func/fupage.cxx |9 --
 sd/source/ui/inc/DrawViewShell.hxx   |4 
 sd/source/ui/sidebar/SlideBackground.cxx |   54 ++--
 sd/source/ui/view/drviews2.cxx   |5 -
 sd/source/ui/view/drviews7.cxx   |  133 ---
 sd/source/ui/view/drviewsf.cxx   |5 -
 7 files changed, 174 insertions(+), 44 deletions(-)

New commits:
commit 7848ba85695e715a8faaf40c22df133388da5d8c
Author: Katarina Behrens 
Date:   Wed May 4 10:44:43 2016 +0200

tdf#89466: Getting/setting page background works now

Change-Id: I60194adfdca2e4bd9d7d44cc1d43ec14f0774fc3
Reviewed-on: https://gerrit.libreoffice.org/24658
Reviewed-by: Katarina Behrens 
Tested-by: Katarina Behrens 

diff --git a/sd/sdi/_drvwsh.sdi b/sd/sdi/_drvwsh.sdi
index bce7cb6..7ed164c 100644
--- a/sd/sdi/_drvwsh.sdi
+++ b/sd/sdi/_drvwsh.sdi
@@ -2624,22 +2624,22 @@ interface DrawView
 ]
 SID_ATTR_PAGE_COLOR
 [
-ExecMethod = FuTemporary ;
+ExecMethod = SetPageProperties ;
 StateMethod = GetPageProperties;
 ]
 SID_ATTR_PAGE_GRADIENT
 [
-ExecMethod = FuTemporary ;
+ExecMethod = SetPageProperties ;
 StateMethod = GetPageProperties ;
 ]
 SID_ATTR_PAGE_HATCH
 [
-ExecMethod = FuTemporary ;
+ExecMethod = SetPageProperties ;
 StateMethod = GetPageProperties ;
 ]
 SID_ATTR_PAGE_BITMAP
 [
-ExecMethod = FuTemporary ;
+ExecMethod = SetPageProperties ;
 StateMethod = GetPageProperties ;
 ]
 SID_ATTR_PAGE_FILLSTYLE
diff --git a/sd/source/ui/func/fupage.cxx b/sd/source/ui/func/fupage.cxx
index b33783f..2ac7754b 100644
--- a/sd/source/ui/func/fupage.cxx
+++ b/sd/source/ui/func/fupage.cxx
@@ -154,15 +154,6 @@ void FuPage::DoExecute( SfxRequest& )
 ApplyItemSet( mpArgs );
 mpView->SetAttributes( *mpArgs );
 }
-
-static sal_uInt16 SidArray[] = {
-SID_ATTR_PAGE_COLOR,
-SID_ATTR_PAGE_GRADIENT,
-SID_ATTR_PAGE_HATCH,
-SID_ATTR_PAGE_BITMAP,
-SID_ATTR_PAGE_FILLSTYLE,
-0 };
-mpDrawViewShell->GetViewFrame()->GetBindings().Invalidate( SidArray );
 }
 }
 
diff --git a/sd/source/ui/inc/DrawViewShell.hxx 
b/sd/source/ui/inc/DrawViewShell.hxx
index b043f18..b96a0e2 100644
--- a/sd/source/ui/inc/DrawViewShell.hxx
+++ b/sd/source/ui/inc/DrawViewShell.hxx
@@ -148,7 +148,6 @@ public:
 voidGetCtrlState(SfxItemSet& rSet);
 voidGetDrawAttrState(SfxItemSet& rSet);
 voidGetMenuState(SfxItemSet& rSet);
-voidGetPageProperties(SfxItemSet& rSet);
 voidGetTableMenuState(SfxItemSet& rSet);
 /** Set the items of the given item set that are related to
 switching the editing mode to the correct values.
@@ -159,6 +158,9 @@ public:
 voidGetAttrState(SfxItemSet& rSet);
 voidGetSnapItemState(SfxItemSet& rSet);
 
+voidSetPageProperties (SfxRequest& rReq);
+voidGetPageProperties(SfxItemSet& rSet);
+
 voidGetState (SfxItemSet& rSet);
 voidExecute (SfxRequest& rReq);
 
diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 6f0cf41..884eca5 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -219,6 +219,15 @@ void SlideBackground::Update()
 mpFillLB->Clear();
 const SvxColorListItem aItem( *static_cast(pSh->GetItem(SID_COLOR_TABLE)));
 mpFillLB->Fill(aItem.GetColorList());
+
+const Color aColor = mpColorItem->GetColorValue();
+mpFillLB->SelectEntry( aColor );
+
+if(mpFillLB->GetSelectEntryCount() == 0)
+{
+mpFillLB->InsertEntry(aColor, OUString());
+mpFillLB->SelectEntry(aColor);
+}
 }
 break;
 case drawing::FillStyle_GRADIENT:
@@ -231,8 +240,27 @@ void SlideBackground::Update()
 mpFillGrad->Clear();
 mpFillLB->Fill(aItem.GetColorList());
 mpFillGrad->Fill(aItem.GetColorList());
+
+const XGradient xGradient = mpGradientItem->GetGradientValue();
+const Color aStartColor = xGradient.GetStartColor();
+const Color aEndColor = xGradient.GetEndColor();
+mpFillLB->SelectEntry( aStartColor );
+mpFillGrad->SelectEntry( aEndColor );
+
+if(mpFillLB->GetSelectEntryCount() == 0)
+{
+mpFillLB->InsertEntry(aStartColor, OUString());
+mpFillLB->SelectEntry(aStartColor);
+}
+

[Libreoffice-commits] core.git: 3 commits - desktop/unx sd/source vcl/source

[Caolán McNamara]

 desktop/unx/source/pagein.c  |   20 +---
 sd/source/ui/sidebar/SlideBackground.cxx |   14 --
 vcl/source/gdi/mapmod.cxx|3 ++-
 3 files changed, 19 insertions(+), 18 deletions(-)

New commits:
commit 77ba88a0beaa78024ef29b8879edce0b7371ad9e
Author: Caolán McNamara 
Date:   Fri May 6 17:15:32 2016 +0100

coverity#1359231 Unchecked dynamic_cast

and

coverity#1359232 Unchecked dynamic_cast

Change-Id: I416e9156c6f3b1a933d6d664a992420067b68d1b

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx 
b/sd/source/ui/sidebar/SlideBackground.cxx
index 370aade..6f0cf41 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -162,8 +162,8 @@ void SlideBackground::Initialize()
 
mpPaperOrientation->SetSelectHdl(LINK(this,SlideBackground,PaperOrientationModifyHdl));
 
 ::sd::DrawDocShell* pDocSh = dynamic_cast<::sd::DrawDocShell*>( 
SfxObjectShell::Current() );
-SdDrawDocument* pDoc = pDocSh->GetDoc();
-sal_uInt16 nCount = pDoc->GetMasterPageCount();
+SdDrawDocument* pDoc = pDocSh ? pDocSh->GetDoc() : nullptr;
+sal_uInt16 nCount = pDoc ? pDoc->GetMasterPageCount() : 0;
 for( sal_uInt16 nLayout = 0; nLayout < nCount; nLayout++ )
 {
 SdPage* pMaster = static_cast(pDoc->GetMasterPage(nLayout));
@@ -539,18 +539,20 @@ IMPL_LINK_NOARG_TYPED(SlideBackground, FillBackgroundHdl, 
ListBox&, void)
 IMPL_LINK_NOARG_TYPED(SlideBackground, AssignMasterPage, ListBox&, void)
 {
 ::sd::DrawDocShell* pDocSh = dynamic_cast<::sd::DrawDocShell*>( 
SfxObjectShell::Current() );
-SdDrawDocument* mpDoc = pDocSh->GetDoc();
+SdDrawDocument* pDoc = pDocSh ? pDocSh->GetDoc() : nullptr;
+if (!pDoc)
+return;
 sal_uInt16 nSelectedPage = SDRPAGE_NOTFOUND;
-for( sal_uInt16 nPage = 0; nPage < mpDoc->GetSdPageCount(PK_STANDARD); 
nPage++ )
+for( sal_uInt16 nPage = 0; nPage < pDoc->GetSdPageCount(PK_STANDARD); 
nPage++ )
 {
-if(mpDoc->GetSdPage(nPage,PK_STANDARD)->IsSelected())
+if (pDoc->GetSdPage(nPage,PK_STANDARD)->IsSelected())
 {
 nSelectedPage = nPage;
 break;
 }
 }
 OUString aLayoutName(mpMasterSlide->GetSelectEntry());
-mpDoc->SetMasterPage(nSelectedPage, aLayoutName, mpDoc, false, false);
+pDoc->SetMasterPage(nSelectedPage, aLayoutName, pDoc, false, false);
 }
 
 IMPL_LINK_NOARG_TYPED(SlideBackground, DspBackground, Button*, void)
commit bcab5bb03e2944eeb96fb0948c61e175929d07a2
Author: Caolán McNamara 
Date:   Fri May 6 17:02:40 2016 +0100

coverity#1359235 Resource leak

Change-Id: I3f307211c70384b55b62314a7aa302ffcdfc7398

diff --git a/desktop/unx/source/pagein.c b/desktop/unx/source/pagein.c
index 181637f..56baffa 100644
--- a/desktop/unx/source/pagein.c
+++ b/desktop/unx/source/pagein.c
@@ -46,27 +46,25 @@ static void do_pagein (const char * filename)
 
 int isRotational(char const * path)
 {
+int ret = 1;
 #ifdef LINUX
 FILE * fp = NULL;
 char fullpath[4096];
 struct stat out;
 int major, minor;
 char type;
-if(stat( path ,  ) == -1)
-return 1;
+if (stat(path , ) == -1)
+return ret;
 major = major(out.st_dev);
 minor = 0; /* minor(out.st_dev); only the device itself has a queue */
 sprintf(fullpath,"/sys/dev/block/%d:%d/queue/rotational",major,minor);
-if ((fp = fopen (fullpath, "r")))
-{
-if (fgets(, 1, fp))
-{
-fclose(fp);
-return type == '1';
-}
-}
+if ((fp = fopen(fullpath, "r")) == NULL)
+return ret;
+if (fgets(, 1, fp))
+ret = type == '1';
+fclose(fp);
 #endif
-return 1;
+return ret;
 }
 
 void pagein_execute(char const * path, char const * file)
commit 9a7da369f73f3306ddd6ed050df3fcdc959742e2
Author: Caolán McNamara 
Date:   Fri May 6 16:57:21 2016 +0100

coverity#1359236 Uninitialized scalar field

Change-Id: I504b84ad39a8519f495676b7821e3079ac74aaf0

diff --git a/vcl/source/gdi/mapmod.cxx b/vcl/source/gdi/mapmod.cxx
index 0a4a107..70b2065 100644
--- a/vcl/source/gdi/mapmod.cxx
+++ b/vcl/source/gdi/mapmod.cxx
@@ -57,7 +57,8 @@ MapMode::ImplMapMode::ImplMapMode( const ImplMapMode& 
rImplMapMode ) :
 meUnit( rImplMapMode.meUnit ),
 maOrigin( rImplMapMode.maOrigin ),
 maScaleX( rImplMapMode.maScaleX ),
-maScaleY( rImplMapMode.maScaleY )
+maScaleY( rImplMapMode.maScaleY ),
+mbSimple( rImplMapMode.mbSimple )
 {
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 65455] Date axis breakage

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65455

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |NOTABUG

--- Comment #6 from Jean-Baptiste Faure  ---
I confirm my comment #4, nothing wrong for me.
Closing as NotABug. Please feel free to reopen (and explain ;-) ) if you
disagree.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 65136] FILESAVE, FILEOPEN: XLS, XLSX partial-cell hyperlink is reloaded as full-cell hyperlink

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=65136

--- Comment #5 from Jean-Baptiste Faure  ---
Still reproducible in LO 5.1.4.0.0+ and master, both build at home under Ubuntu
16.04 x86-64.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 64239] FILESAVE: lines not saved correctly after opened from Power Point / lines not possible to delete on slides

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=64239

Jean-Baptiste Faure  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #6 from Jean-Baptiste Faure  ---
Please attach the original PPT file.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 63016] FILESAVE: problem with save password

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=63016

--- Comment #6 from Jean-Baptiste Faure  ---
Nothing changed in LO 5.1.4.0.0+ and master, both build at home under Ubuntu
16.04 x86-64.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99640] The character of "/" keyboard does not work to remotely access the VNC and other

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99640

Alexandre  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Alexandre  ---
To reproduce the error:

1) Install any later version to 5.0.3.2
2) Access remotely via VNC and try typing the "/" key anywhere in text,
spreadsheet and etc!

It does not work the key /

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62688] EDITING: Shortcuts like ctrl+a , ctrl+b don't work for comment edit box in impress .

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62688

--- Comment #5 from Jean-Baptiste Faure  ---
Still reproducible in LO 5.1.4.0.0+ and master, both build at home under Ubuntu
16.04 x86-64.
Crash in the master, see bug 99712

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99712] Crash in context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99712

Jean-Baptiste Faure  changed:

   What|Removed |Added

   Keywords||regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99712] New: Crash in context menu

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99712

Bug ID: 99712
   Summary: Crash in context menu
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jbfa...@libreoffice.org

When trying to reproduce bug 62688 with current master, I found the following
crash. Steps to reproduce:
1/ open a new empty Impress document
2/ ctrl+alt+C to create a comment
3/ type something in the comment field
4/ select the text of the comment (use the mouse because ctrl+A does not work
in comments, it is the bug 62688)
5/ right click on the selected text

==> the comment field close
==> crash when you choose an entry in the context menu

Found in Version: 5.2.0.0.alpha1+
Build ID: 2fb31f248fe86c52c1070cbc8b18b24872a4bedc
built at home under Ubuntu 16.04 x86-64
No crash in LO 5.1.4.0.0+, so regression.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99702] [VIEWING] Appalling performance when resizing window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99702

--- Comment #5 from Buovjaga  ---
(In reply to Luke Kendall from comment #4)
> What about if I attached to it with gdb and just got a stack backtrace -
> would that be much help?

Well, maybe you could do the callgrind and cancel out of it after you get
bored.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95780] Image File read errors (multiple images displayed)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=95780

Julien Nabet  changed:

   What|Removed |Added

 Attachment #120563|application/zip |application/vnd.openxmlform
  mime type||ats-officedocument.wordproc
   ||essingml.document

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 62277] Consecutive and duplicated error messages when save to overwrite a document without permission.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=62277

--- Comment #7 from Jean-Baptiste Faure  ---
Nothing changed in LO 5.1.4.0.0+ and master, both build at home under Ubuntu
16.04 x86-64.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99441] Critical memory leak that degrades performance to close to non-functional

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99441

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||jmadero@gmail.com
 Resolution|--- |INVALID

--- Comment #2 from Joel Madero  ---
This isn't a valid bug report - there is nothing for us to confirm. Closing as
INVALID. 

as far as working on this ASAP - that's not how open source projects work.
Unlike Microsoft (who you and its clients pay a lot of money to), we're a free
project that is based on volunteers who work on things *as they please*. We
have a strong culture of "the doers decide" - thus, the people doing the work,
decide what is done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

[Markus Mohrhard]

 sfx2/source/doc/doctemplateslocal.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ba178877324384b19709c0789f496ddf44c8556a
Author: Markus Mohrhard 
Date:   Fri May 6 16:40:55 2016 +0200

fix typo, related tdf#96890

Change-Id: I2c7663f988548449b2bfa7360279ea320e29b120
Reviewed-on: https://gerrit.libreoffice.org/24701
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/sfx2/source/doc/doctemplateslocal.cxx 
b/sfx2/source/doc/doctemplateslocal.cxx
index bbdc01b..3a9555c 100644
--- a/sfx2/source/doc/doctemplateslocal.cxx
+++ b/sfx2/source/doc/doctemplateslocal.cxx
@@ -63,7 +63,7 @@ void SAL_CALL 
DocTemplLocaleHelper::WriteGroupLocalizationSequence( const uno::R
 ::comphelper::AttributeList* pRootAttrList = new 
::comphelper::AttributeList;
 uno::Reference< xml::sax::XAttributeList > xRootAttrList( pRootAttrList );
 pRootAttrList->AddAttribute(
-"xmlns:groupinames",
+"xmlns:groupuinames",
 aCDATAString,
 "http://openoffice.org/2006/groupuinames; );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99444] calc copies region from wrong sheet

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99444

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #5 from Joel Madero  ---
Bodhi Moksha
Version: 5.2.0.0.alpha0+
Build ID: ef34535ceb60d7d63b8d8671e4c6e9e43ffbd17d
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-03-27_09:53:05
Locale: en-US (en_US.UTF-8)

Also no repro.


Closing as WFM as 3 different QA members cannot reproduce, therefore it must be
something environmental, not something about LibreOffice itself.


@documentfoundat...@semioptimal.net : Please try with a fresh profile:
https://wiki.documentfoundation.org/UserProfile

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 45065] Problem with EDITING of technical pdfs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=45065

--- Comment #13 from Jean-Baptiste Faure  ---
(In reply to brian.bj.parker99 from comment #11)
> (In reply to Jean-Baptiste Faure from comment #10)
> > (In reply to brian.bj.parker99 from comment #9)
> > > Note: this bug is now a duplicate of 61144.
> > 
> > Why "now" ?
> > 
> > Best regards. JBF
> 
> When bug 61144 was originally submitted it showed multiple problems
> including wrong line widths, long lines etc.  The only remaining issue with
> 61144 in the recent versions of LO is lines extending beyond the figure
> boundary, which is also the issue shown by this bug.

So, it is 61144 that is a duplicate of this bug because it is newer.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72504

--- Comment #24 from Joel Madero  ---
(In reply to Guillermo Lo Coco from comment #23)
> I'm migrating some Windows machines to Ubuntu 16.04 and I found this old
> annoying bug.
> 
> It seems to open ODB files when are mounted in FSTAB, but I strictly need
> "smb://server/share" URL feature.
> 
> FSTAB is not an option in my setup and I feel stuck.

Hi Guillermo,

Apologies that you feel stuck but this is a volunteer project. Thanks for
confirming you hit this issue also but that will not push the bug to being
fixed any faster. We have a few thousand open bugs, this is a volunteer project
- volunteers fix bugs when they find them interesting. 

Base is hands down our least popular component and there aren't a lot of
developers that enjoy working on it so it might be some time before it's
resolved (it might never be resolved). So, you should figure out a solution
that works for you given this constraint.

Just want to be honest with you about the status of how bugs get fixed in our
project.

Best,
Joel

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96490] Accessible object:children-changed events not emitted when paragraphs are created, destroyed, or exposed

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96490

Joanmarie Diggs  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Joanmarie Diggs  ---
I'm doing what you're doing. And I continue to not see children-changed events.
I tried with both 5.1.3.1-2.fc24 and 5.2.0.0.alpha1.

Mind you I get children-changed events from soffice. For instance, if I open a
menu. But what I am not getting is children-changed events when I type text and
press return (creating new accessible paragraph objects).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99702] [VIEWING] Appalling performance when resizing window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99702

--- Comment #4 from Luke Kendall  ---
What about if I attached to it with gdb and just got a stack backtrace - would
that be much help?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 41063] Saving/Autosaving causes view to jump to cursor position

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=41063

--- Comment #43 from Jean-Baptiste Faure  ---
(In reply to sdc.blanco from comment #42)
> (In reply to Jean-Baptiste Faure from comment #33)
> > Nobody gave a version number in which it worked differently, so it is not a
> > regression. Keyword regression removed.
> > 
> > Best regards. JBF
> 
> Just checking. It seems like there are two different bugs here,  one, where
> the cursor is in a table (the original report), and one where the cursor is
> not. 
> I believe the second case is a regression, where the latest version that
> worked correctly was 4.4.7.2. (see comment 37)  Shouldn't that be set up a
> separate bug , and marked as a regression (so that it can get a higher
> priority)? 

Yes.

Best regards. JBF

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99702] [VIEWING] Appalling performance when resizing window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99702

--- Comment #3 from Buovjaga  ---
Yeah, I guess it doesn't match.

This is a way to get data on performance problems, but it runs VERY slowly:
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#GNU.2FLinux:_How_to_get_a_callgrind_trace
Note that you would also need: "The debugging package for (older) Debian,
Ubuntu or their derivatives is libreoffice-dbg"

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99457] One-Handed Drag and Drop?

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99457

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #2 from Joel Madero  ---
Moving this out of UNCONFIRMED as it's a UX issue. UX team can close as WONTFIX
if they so choose.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99503] Calc loads sheet very long, cannot use filters.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99503

--- Comment #3 from Joel Madero  ---
Setting to:
New
Minor - will not prevent high quality work, just slows it down a bit;
Low - default for minor bugs seems appropriate here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99503] Calc loads sheet very long, cannot use filters.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99503

Joel Madero  changed:

   What|Removed |Added

   Priority|medium  |low
 Status|UNCONFIRMED |NEW
 CC||jmadero@gmail.com
 Ever confirmed|0   |1
   Severity|normal  |minor

--- Comment #2 from Joel Madero  ---
(In reply to migilenik from comment #0)
> Created attachment 124636 [details]
> Catalog in Excel sheet

> 
> It takes almost minute (or even more, depends on machine) to open sheet, and
> even if it opens, we cant use any of created filters (menu does open, but we
> cant check any of predefined options). 

This is two different issues. Let's just focus on the slow load - the other
issue should be a separate bug.
> 
> It does open in Gnumeric immediately, but predefined filters are missing.

Well - that's not a fair comparison then because the filters might be what's
causing it to run slower. Saying some other software opens it "immediately" but
it opens it incorrectly (without the filters) shouldn't be a comparison to
LibreOffice's performance that is trying to open it correctly with the filters.


+++
My results:
Bodhi Linux
Version: 5.1.1.3
Build ID: 89f508ef3ecebd2cfb8e1def0f0ba9a803b88a6d
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: en-US (en_US.UTF-8)

Opens in about 1 minute 9 seconds


Version: 5.2.0.0.alpha0+
Build ID: ef34535ceb60d7d63b8d8671e4c6e9e43ffbd17d
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-03-27_09:53:05
Locale: en-US (en_US.UTF-8)

Identical timing.

+++

Marking as NEW but see my notes below:


1) Given that you're using this in a professional setting I'd suggest reaching
out to a certified developer to get paid support (the other option is wait
until a volunteer finds this to be an interesting issue).
https://www.libreoffice.org/get-help/professional-support/

Things you can do:
2) Do a calgrind/valgrind to see what's going on:
https://wiki.documentfoundation.org/Development/How_to_debug#Valgrinding_.28memcheck.29_LibreOffice_itself

You can jump into IRC to ask developer how exactly to get a log

3) Testing older versions to see if this is a regression would be useful:
http://downloadarchive.documentfoundation.org/libreoffice/old/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96492] Broken accessibility tree when objects are accessed via flows-to/flows-from relation

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96492

Joanmarie Diggs  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Joanmarie Diggs  ---
(In reply to Buovjaga from comment #1)
> (In reply to Joanmarie Diggs from comment #0)
> > 2. Use Accerciser or an pyatspi script to get the last child of the
> > document. (Result: "Paragraph 2")
> > 

Quit Accerciser if it is running, create the document first with only page 1
showing, then launch Accerciser. In the pane on the left you should find two
children of the document accessible. You can verify which paragraphs they are
by expanding Text (Editable) in the Interface Viewer.

> > 3. Get the flows-to target of that child (Result: "Paragraph 3")

You can examine relations in the interface viewer (expand Accessible). But to
do the subsequent tasks, iPython console is probably better. So

Select paragraph 2 in the pane on the left and switch to the iPython console.
Type the following:

r = acc.getRelationSet()
flowsToRelations = [x for x in r if x.getRelationType() == RELATION_FLOWS_TO]
target = flowsToRelations[0].getTarget(0)
target.queryText().getText(0,-1)

The result I get is 'Paragraph 3'. So target is the third paragraph. With this
in mind

> > 4. Get the parent of "Paragraph 3" (Result: The accessible document which
> > contains "Paragraph 1" and "Paragraph 2")

Still in the iPython console:

parent = target.parent
children = [x.queryText().getText(0,-1) for x in parent]
children

The result I get is ['Paragraph 1', 'Paragraph 2'].

So the parent of 'Paragraph 3' has two children, neither of which is 'Paragraph
3'.

HTH.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 89466] SIDEBAR: Background and presentation sections in Properties tab in Impress

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=89466

--- Comment #22 from Commit Notification 
 ---
Katarina Behrens committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=82573976439dea2db42b350356fa4747f38f7f24

tdf#89466: Don't reset page background on size/orientation change

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sd/source

[Katarina Behrens]

 sd/source/ui/func/fupage.cxx |5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 82573976439dea2db42b350356fa4747f38f7f24
Author: Katarina Behrens 
Date:   Wed May 4 11:07:16 2016 +0200

tdf#89466: Don't reset page background on size/orientation change

Change-Id: I5fbf44235784f285d42d2e83466d2f0d70fd0f5d
Reviewed-on: https://gerrit.libreoffice.org/24659
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/sd/source/ui/func/fupage.cxx b/sd/source/ui/func/fupage.cxx
index 0978881..b33783f 100644
--- a/sd/source/ui/func/fupage.cxx
+++ b/sd/source/ui/func/fupage.cxx
@@ -129,10 +129,13 @@ void FuPage::DoExecute( SfxRequest& )
 {
 mpDrawViewShell = dynamic_cast(mpViewShell);
 DBG_ASSERT( mpDrawViewShell, "sd::FuPage::FuPage(), called without a 
current DrawViewShell!" );
+
 if( mpDrawViewShell )
 {
 mbMasterPage = mpDrawViewShell->GetEditMode() == EM_MASTERPAGE;
-mbDisplayBackgroundTabPage = (mpDrawViewShell->GetPageKind() == 
PK_STANDARD);
+// we don't really want to format page background with 
SID_ATTR_PAGE[_SIZE] slots
+mbDisplayBackgroundTabPage = ( mpDrawViewShell->GetPageKind() == 
PK_STANDARD) &&
+  ( nSlotId != SID_ATTR_PAGE_SIZE) && ( 
nSlotId != SID_ATTR_PAGE );
 mpPage = mpDrawViewShell->getCurrentPage();
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99506] EDITING: OLE Object: Can't open an object create with a display icon

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99506

Joel Madero  changed:

   What|Removed |Added

   Priority|medium  |lowest
 CC||jmadero@gmail.com
   Severity|normal  |minor

--- Comment #2 from Joel Madero  ---
Not confirming but prioritizing.

Minor: Can slow down but won't prevent high quality work;
Lowest This isn't going to affect a lot of people at all

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 72504] EDITING: Unable to edit .odb file with non-local URL

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=72504

--- Comment #23 from Guillermo Lo Coco  ---
I'm migrating some Windows machines to Ubuntu 16.04 and I found this old
annoying bug.

It seems to open ODB files when are mounted in FSTAB, but I strictly need
"smb://server/share" URL feature.

FSTAB is not an option in my setup and I feel stuck.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99679] cell formatting lost when saving in xlsx

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99679

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||jmadero@gmail.com
 Ever confirmed|0   |1

--- Comment #4 from Joel Madero  ---
Hi Roberto

We need the original ODS first - then we'll save it on our side to see what
formatting is lost. It doesn't help to just show us a post-damaged file.

Moving back to NEEDINFO. Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

New Defects reported by Coverity Scan for LibreOffice

[scan-admin]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found 
with Coverity Scan.

13 new defect(s) introduced to LibreOffice found with Coverity Scan.
13 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 13 of 13 defect(s)


** CID 1359237:  Uninitialized members  (UNINIT_CTOR)
/usr/include/c++/5.3.1/functional: 2258 in std::function> 
&)>::function> 
&), void, void>(T1)()



*** CID 1359237:  Uninitialized members  (UNINIT_CTOR)
/usr/include/c++/5.3.1/functional: 2258 in std::function> 
&)>::function> 
&), void, void>(T1)()
2252if (_My_handler::_M_not_empty_function(__f))
2253  {
2254_My_handler::_M_init_functor(_M_functor, std::move(__f));
2255_M_invoker = &_My_handler::_M_invoke;
2256_M_manager = &_My_handler::_M_manager;
2257  }
>>> CID 1359237:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "_M_invoker" is not initialized in this 
>>> constructor nor in any functions that it calls.
2258   }
2259 
2260   template
2261 _Res
2262 function<_Res(_ArgTypes...)>::
2263 operator()(_ArgTypes... __args) const

** CID 1359236:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/mapmod.cxx: 62 in MapMode::ImplMapMode::ImplMapMode(const 
MapMode::ImplMapMode&)()



*** CID 1359236:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/gdi/mapmod.cxx: 62 in MapMode::ImplMapMode::ImplMapMode(const 
MapMode::ImplMapMode&)()
56 MapMode::ImplMapMode::ImplMapMode( const ImplMapMode& rImplMapMode ) :
57 meUnit( rImplMapMode.meUnit ),
58 maOrigin( rImplMapMode.maOrigin ),
59 maScaleX( rImplMapMode.maScaleX ),
60 maScaleY( rImplMapMode.maScaleY )
61 {
>>> CID 1359236:  Uninitialized members  (UNINIT_CTOR)
>>> Non-static class member "mbSimple" is not initialized in this 
>>> constructor nor in any functions that it calls.
62 }
63 
64 bool MapMode::ImplMapMode::operator==( const ImplMapMode& rImpMapMode ) 
const
65 {
66 if (meUnit   == rImpMapMode.meUnit
67 && maOrigin == rImpMapMode.maOrigin

** CID 1359235:  Resource leaks  (RESOURCE_LEAK)
/desktop/unx/source/pagein.c: 69 in isRotational()



*** CID 1359235:  Resource leaks  (RESOURCE_LEAK)
/desktop/unx/source/pagein.c: 69 in isRotational()
63 {
64 fclose(fp);
65 return type == '1';
66 }
67 }
68 #endif
>>> CID 1359235:  Resource leaks  (RESOURCE_LEAK)
>>> Variable "fp" going out of scope leaks the storage it points to.
69 return 1;
70 }
71 
72 void pagein_execute(char const * path, char const * file)
73 {
74 char fullpath[4096];

** CID 1359234:(PASS_BY_VALUE)
/usr/include/c++/5.3.1/functional: 2247 in std::function> 
&)>::function, std::_Placeholder<(int)3>, 
std::_Placeholder<(int)4>, com::sun::star::rendering::Texture, 
com::sun::star::geometry::IntegerSize2D, com::sun::star::uno::Sequence, unsigned int, std::_Placeholder<(int)6>))(const oglcanvas::CanvasHelper 
&, const basegfx::B2DHomMatrix &, unsigned int, unsigned int, const 
com::sun::star::rendering::Texture &, const 
com::sun::star::geometry::IntegerSize2D &, const 
com::sun::star::uno::Sequence &, unsigned int, const 
std::vector 
&)>, void, void>(T1)()
/usr/include/c++/5.3.1/functional: 2247 in std::function> 
&)>::function, std::_Placeholder<(int)3>, 
std::_Placeholder<(int)4>, canvas::ParametricPolyPolygon::Values, 
com::sun::star::rendering::Texture, std::_Placeholder<(int)6>))(const 
oglcanvas::CanvasHelper &, const basegfx::B2DHomMatrix &, unsigned int, 
unsigned int, const canvas::ParametricPolyPolygon::Values &, const 
com::sun::star::rendering::Texture &, const 
std::vector 
&)>, void, void>(T1)()
/usr/include/c++/5.3.1/functional: 2247 in std::function> 
&)>::function, std::_Placeholder<(int)3>, 
std::_Placeholder<(int)4>, std::_Placeholder<(int)5>, 
oglcanvas::CanvasBitmap))(const oglcanvas::CanvasHelper &, const 
basegfx::B2DHomMatrix &, unsigned int, unsigned int, const 
com::sun::star::rendering::ARGBColor &, const oglcanvas::CanvasBitmap &)>, 
void, void>(T1)()



*** CID 1359234:(PASS_BY_VALUE)

[Libreoffice-commits] core.git: 2 commits - sc/source

[Eike Rathke]

 sc/source/core/tool/compiler.cxx |   11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

New commits:
commit bb0ef99fb9dce30e99a7e9f7fa295a634d07b423
Author: Eike Rathke 
Date:   Fri May 6 16:56:29 2016 +0200

Resolves: tdf#86575 for OOXML write plain #REF! if deleted parts

Change-Id: Ie3233d72bdbdd0ab82386c98a46755ce64ef3e7f

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index da93bad..c50174b 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1422,6 +1422,14 @@ struct ConventionXL_OOX : public ConventionXL_A1
 aPos.SetRow(0);
 }
 
+if (rRef.Ref1.IsDeleted() || (!bSingleRef && rRef.Ref2.IsDeleted()))
+{
+// For OOXML write plain "#REF!" instead of detailed sheet/col/row
+// information.
+rBuf.append(rErrRef);
+return;
+}
+
 ConventionXL_A1::makeRefStr( rBuf, eGram, aPos, rErrRef, rTabNames, 
rRef, bSingleRef, bFromRangeName);
 }
 
commit eeb203089f2ba6dffba9a2543c9a7e8bf551bbc5
Author: Eike Rathke 
Date:   Fri May 6 16:31:06 2016 +0200

write the [#REF!] as defined in ODFF, tdf#86575 related

... if a part of the reference was deleted, instead of [.#REF!A1]

Actually this is a regression that already can be tracked down to
c54616f62bc70a9d39abf8837a9d7c3031c80a41 which changed things to use
ValidAddress() only.

Change-Id: I70f68722d7af02f6da3380c2dd9d54704c20b451

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 958f5b3..da93bad 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -1023,7 +1023,8 @@ struct ConventionOOO_A1_ODF : public ConventionOOO_A1
 if( !bSingleRef )
 aAbs2 = rRef.Ref2.toAbs(rPos);
 
-if (FormulaGrammar::isODFF(eGram) && (!ValidAddress(aAbs1) || 
!ValidAddress(aAbs2)))
+if (FormulaGrammar::isODFF(eGram) && (rRef.Ref1.IsDeleted() || 
!ValidAddress(aAbs1) ||
+(!bSingleRef && (rRef.Ref2.IsDeleted() || 
!ValidAddress(aAbs2)
 {
 rBuffer.append(rErrRef);
 // For ODFF write [#REF!], but not for PODF so apps reading ODF
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/bundled loolwsd/LOOLKit.cpp

[Ashod Nakashian]

 loolwsd/LOOLKit.cpp |   37 +++-
 loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h |   13 +
 2 files changed, 20 insertions(+), 30 deletions(-)

New commits:
commit 8e480d7ac12fbdad5a983e4ef594392b440f0b7c
Author: Ashod Nakashian 
Date:   Fri May 6 11:03:34 2016 -0400

loolwsd: use paintPartTile and remove workarounds

Change-Id: Ice59004a23919c7a77a00782f7210a83bc1464e7
Reviewed-on: https://gerrit.libreoffice.org/24703
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 60b3e02..2f524cb 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -659,24 +659,11 @@ public:
 
 std::vector pixmap;
 pixmap.resize(4 * width * height);
-int oldPart = _loKitDocument->pClass->getPart(_loKitDocument);
-if (part != oldPart)
-{
-if (editLock || id != -1)
-{
-_loKitDocument->pClass->setPart(_loKitDocument, part);
-}
-else
-{
-// Session without editlock cannot change part
-Log::debug() << "Declining tile render request: " << response  
<< Log::end;
-ws->sendFrame(response.data(), response.size());
-return;
-}
-}
 
 Timestamp timestamp;
-_loKitDocument->pClass->paintTile(_loKitDocument, pixmap.data(), 
width, height, tilePosX, tilePosY, tileWidth, tileHeight);
+_loKitDocument->pClass->paintPartTile(_loKitDocument, pixmap.data(), 
part,
+  width, height, tilePosX, 
tilePosY,
+  tileWidth, tileHeight);
 Log::trace() << "paintTile at [" << tilePosX << ", " << tilePosY
  << "] rendered in " << (timestamp.elapsed()/1000.) << " 
ms" << Log::end;
 
@@ -689,12 +676,6 @@ public:
 return;
 }
 
-// restore the original part if tilepreview request changed the part
-if (id != -1)
-{
-_loKitDocument->pClass->setPart(_loKitDocument, oldPart);
-}
-
 const auto length = output.size();
 if (length > SMALL_MESSAGE_SIZE)
 {
@@ -789,11 +770,6 @@ public:
 tiles.push_back(rectangle);
 }
 
-if (_docType != "text" && part != 
_loKitDocument->pClass->getPart(_loKitDocument))
-{
-_loKitDocument->pClass->setPart(_loKitDocument, part);
-}
-
 LibreOfficeKitTileMode mode = 
static_cast(_loKitDocument->pClass->getTileMode(_loKitDocument));
 
 int tilesByX = renderArea.getWidth() / tileWidth;
@@ -807,9 +783,10 @@ public:
 std::vector pixmap(pixmapSize, 0);
 
 Timestamp timestamp;
-_loKitDocument->pClass->paintTile(_loKitDocument, pixmap.data(), 
pixmapWidth, pixmapHeight,
-  renderArea.getLeft(), 
renderArea.getTop(),
-  renderArea.getWidth(), 
renderArea.getHeight());
+_loKitDocument->pClass->paintPartTile(_loKitDocument, pixmap.data(), 
part,
+  pixmapWidth, pixmapHeight,
+  renderArea.getLeft(), 
renderArea.getTop(),
+  renderArea.getWidth(), 
renderArea.getHeight());
 
 Log::debug() << "paintTile (combined) called, tile at [" << 
renderArea.getLeft() << ", " << renderArea.getTop() << "]"
 << " (" << renderArea.getWidth() << ", " << 
renderArea.getHeight() << ") rendered in "
diff --git a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h 
b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h
index 1281a21..110d4d5 100644
--- a/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h
+++ b/loolwsd/bundled/include/LibreOfficeKit/LibreOfficeKit.h
@@ -228,6 +228,19 @@ struct _LibreOfficeKitDocumentClass
 /// @see lok::Document::getPartHash().
 char* (*getPartHash) (LibreOfficeKitDocument* pThis,
   int nPart);
+
+/// Paints a tile from a specific part.
+/// @see lok::Document::paintTile().
+void (*paintPartTile) (LibreOfficeKitDocument* pThis,
+   unsigned char* pBuffer,
+   const int nPart,
+   const int nCanvasWidth,
+   const int nCanvasHeight,
+   const int nTilePosX,
+   const int nTilePosY,
+   const int nTileWidth,
+   const int nTileHeight);
+
 #endif // defined LOK_USE_UNSTABLE_API || defined LIBO_INTERNAL_ONLY
 };
 
___
Libreoffice-commits mailing list

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - desktop/source

[Ashod Nakashian]

 desktop/source/lib/init.cxx |   14 ++
 1 file changed, 10 insertions(+), 4 deletions(-)

New commits:
commit aadab5f4a72e38ccc8bbe9b7811d2cdcaa00124c
Author: Ashod Nakashian 
Date:   Fri May 6 11:01:42 2016 -0400

Don't change part on text documents to paint tiles

Change-Id: Icb5fb46cbc9d2f72c814cf9f1f166382493d403f
Reviewed-on: https://gerrit.libreoffice.org/24702
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx
index d043a2f..8742c49 100644
--- a/desktop/source/lib/init.cxx
+++ b/desktop/source/lib/init.cxx
@@ -1101,15 +1101,21 @@ void doc_paintPartTile(LibreOfficeKitDocument* pThis,
 pDocument->mpCallbackFlushHandler->setPartTilePainting(true);
 try
 {
-const int nOrigPart = doc_getPart(pThis);
-if (nPart != nOrigPart)
+// Text documents have a single coordinate system; don't change part.
+int nOrigPart = 0;
+const bool isText = (doc_getDocumentType(pThis) == LOK_DOCTYPE_TEXT);
+if (!isText)
 {
-doc_setPart(pThis, nPart);
+nOrigPart = doc_getPart(pThis);
+if (nPart != nOrigPart)
+{
+doc_setPart(pThis, nPart);
+}
 }
 
 doc_paintTile(pThis, pBuffer, nCanvasWidth, nCanvasHeight, nTilePosX, 
nTilePosY, nTileWidth, nTileHeight);
 
-if (nPart != nOrigPart)
+if (!isText && nPart != nOrigPart)
 {
 doc_setPart(pThis, nOrigPart);
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 96487] Expose tracked changes to ATs via accessible objects and attributes

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96487

Joanmarie Diggs  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Joanmarie Diggs  ---
> Results:
> 
> 1. Visually, there is a vertical bar to the left of the changed paragraph.
> But there seems to be no way for ATs to identify the paragraph has changes.

This part seems to have been addressed via text attributes. (Interface Viewer
-> Text(Editable)). So this part is no longer a problem.

> 2. If you hover the mouse over the deleted, inserted, or formatted text, a
> tooltip provides sighted users information about the nature of the change,
> who made the change, and the time the change was made. None of this
> information seems to be exposed to ATs.

I'm no longer seeing the tooltip. So it's hard to illustrate the absence of
accessible information for something which is absent. :)

The nature of the change is in the text attribute now (part 1 above). But if
the author who made the change and the time the change was made is something
that sighted users can see, what I would suggest you do to reproduce it is use
the interface viewer to explore all aspects of the paragraph (expand
accessible, expand hypertext, expand text, ) and find it. If you thoroughly
explore all possible things in Accerciser related to the paragraph and cannot
find the author and time, then odds are Orca won't be able to find it either.

> 3. The accessible text is "HelloGoodbye cruel world" (which, when spoken by
> a screen reader, is confusing).

You can see this in the Interface viewer by expanding Text (Editable).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 96609] FORMATTING: Picture disappears between page breaks

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=96609

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||612

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=96
   ||609

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99612] Loss of all images

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99612

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||785

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99702] [VIEWING] Appalling performance when resizing window

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99702

--- Comment #2 from Luke Kendall  ---
Hmm.  It could be.  Though I'm not using Unity, I'm using Metacity (and one of
the "traditional" UI options like Flashback for the desktop).  And that freport
said it was only applicable to Unity.

Also, I just tried a little experiment:
1. Resized a short 6-page document.
   Instant resizing.
2. Resized a version of half my MS (280pp and thousands of editor comments)
   2 seconds to resize.
3. Resized my MS with just my comments (569pp and hundreds of comments)
   30-seconds to resize.

Note that this was after exiting LO some hours earlier and re-opening the files
I had open when I first reported this.  30 seconds to resize is not great, but
it's quite liveable with.  15-20 mins is not so much.  Yet this was the same
file that earlier had taken around 20 mins.  I observed the CPU went very busy,
but I brought the browser to the foreground over the top, assuming it would
take a similar length of time: it didn't.

Though I just now brought up doc #2 in the above list to the foreground, and
accidentally maximised it vertically and found I couldn't un-maximise it via
the rectangle icon of the window, nor could I dock it with the "-" icon.  I had
to Alt-mouse move it partly off screen, re-size, and then it behaved normally:
though the vertical re-sizing showed similar behaviour: window went dark grey
as it went to 100% CPU, and I got to see tiny vertical incremental redraws as
the window contents were slowly redrawn over and over to fill the space.  But
again, that only took about 20 seconds.

I just finished resizing doc #3 again, this time not obscured, but again, it
finished its incremental redraws after about 20 seconds; with each redraw
taking about 1 second, not 20-30 seconds.

I don't know what to make of the weird variability in the behaviour I'm seeing.

And it certainly seems similar to bug 99153, but again, doesn't seem to
entirely match.  What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97785] Images disappear in Write

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97785

Julien Nabet  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||612

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs