[Libreoffice-bugs] [Bug 97766] in startcenter the selected area around selected thumbnails is too small

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97766

--- Comment #6 from raal  ---
Hello bordfeldt,
what's the file name? Or it's every thumbnail?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/helpers.hpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b58b906f369d6d12c3de25cd929c4946f39e4a64
Author: Ashod Nakashian 
Date:   Mon May 9 01:28:45 2016 -0400

loolwsd: fix typo causing infinite recursion

Change-Id: I8a5ef2b65d3476a698d7dcf883ac8dc07e287533
Reviewed-on: https://gerrit.libreoffice.org/24788
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index 22f57b7..5f48ce6 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -265,7 +265,7 @@ void getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix, std
 inline
 void getResponseMessage(const std::shared_ptr& ws, const 
std::string& prefix, std::string& response, const bool isLine)
 {
-getResponseMessage(ws, prefix, response, isLine);
+getResponseMessage(*ws, prefix, response, isLine);
 }
 
 inline
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   24 +++-
 1 file changed, 23 insertions(+), 1 deletion(-)

New commits:
commit 1ab1511a0e65f16b141a48dcb861c5366b1df44b
Author: Ashod Nakashian 
Date:   Mon May 9 01:18:55 2016 -0400

loolwsd: improved auto-save tests

Change-Id: If24b5e4cb585ffc59d31583cb10dfa3e57dc3056
Reviewed-on: https://gerrit.libreoffice.org/24787
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index d760157..9432fb7 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -399,6 +399,7 @@ void HTTPWSTest::testSaveOnDisconnect()
 std::string documentPath, documentURL;
 getDocumentPathAndURL("hello.odt", documentPath, documentURL);
 
+int kitcount = -1;
 try
 {
 // Load a document and get its status.
@@ -408,14 +409,26 @@ void HTTPWSTest::testSaveOnDisconnect()
 sendTextFrame(socket, "load url=" + documentURL);
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket));
 
+Poco::Net::WebSocket socket2 = *connectLOKit(_uri, request, _response);
+sendTextFrame(socket2, "load url=" + documentURL);
+CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket2));
+sendTextFrame(socket2, "userinactive");
+
 sendTextFrame(socket, "uno .uno:SelectAll");
 sendTextFrame(socket, "uno .uno:Delete");
 sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa 
bbb ccc");
 
+// Closing connection too fast might not flush buffers.
+// Often nothing more than the SelectAll reaches the server before
+// the socket is closed, when the doc is not even modified yet.
+getResponseMessage(socket, "statechanged");
 std::cerr << "Closing connection after pasting." << std::endl;
 
+kitcount = getLoolKitProcessCount();
+
 // Shutdown abruptly.
 socket.shutdown();
+socket2.shutdown();
 }
 catch (const Poco::Exception& exc)
 {
@@ -423,7 +436,7 @@ void HTTPWSTest::testSaveOnDisconnect()
 }
 
 // Allow time to save and destroy before we connect again.
-sleep(5);
+testNoExtraLoolKitsLeft();
 std::cerr << "Loading again." << std::endl;
 try
 {
@@ -435,6 +448,9 @@ void HTTPWSTest::testSaveOnDisconnect()
 sendTextFrame(socket, "status");
 CPPUNIT_ASSERT_MESSAGE("cannot load the document " + documentURL, 
isDocumentLoaded(socket));
 
+// Should have no new instances.
+CPPUNIT_ASSERT_EQUAL(kitcount, countLoolKitProcesses(kitcount));
+
 // Check if the document contains the pasted text.
 sendTextFrame(socket, "uno .uno:SelectAll");
 sendTextFrame(socket, "gettextselection 
mimetype=text/plain;charset=utf-8");
@@ -488,6 +504,12 @@ void HTTPWSTest::testReloadWhileDisconnecting()
 sendTextFrame(socket, "uno .uno:Delete");
 sendTextFrame(socket, "paste mimetype=text/plain;charset=utf-8\naaa 
bbb ccc");
 
+// Closing connection too fast might not flush buffers.
+// Often nothing more than the SelectAll reaches the server before
+// the socket is closed, when the doc is not even modified yet.
+getResponseMessage(socket, "statechanged");
+std::cerr << "Closing connection after pasting." << std::endl;
+
 kitcount = getLoolKitProcessCount();
 
 // Shutdown abruptly.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/LOOLWSD.cpp |   53 ++--
 1 file changed, 35 insertions(+), 18 deletions(-)

New commits:
commit 4cec994c36736989681b4017c0fbec051b191f26
Author: Ashod Nakashian 
Date:   Mon May 9 01:12:13 2016 -0400

loolwsd: auto-saving improvements

When multiple clients disconnect simultaniously
auto-save could fail.

Change-Id: I8a08e23d651674f43d30e8713fa2df0acccead15
Reviewed-on: https://gerrit.libreoffice.org/24786
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 48b8d05..d089501 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -618,7 +618,7 @@ private:
 session = std::make_shared(id, 
LOOLSession::Kind::ToClient, ws, docBroker, queue);
 
 // Request the child to connect to us and add this session.
-const auto sessionsCount = docBroker->addSession(session);
+auto sessionsCount = docBroker->addSession(session);
 Log::trace(docKey + ", ws_sessions++: " + 
std::to_string(sessionsCount));
 
 // indicator to a client that is waiting to connect to lokit 
process
@@ -648,29 +648,58 @@ private:
 []() { session->closeFrame(); },
 []() { return TerminationFlag || 
!queueHandlerThread.isRunning(); });
 
-if (!session->_bLoadError)
 {
+std::unique_lock docBrokersLock(docBrokersMutex);
+
+// We can destory if this is the last session.
+// If not, we have to remove the session and check again.
+// Otherwise, we may end up removing the one and only session.
+bool removedSession = false;
+auto canDestroy = docBroker->canDestroy();
+sessionsCount = docBroker->getSessionsCount();
+if (sessionsCount > 1)
+{
+sessionsCount = docBroker->removeSession(id);
+removedSession = true;
+Log::trace(docKey + ", ws_sessions--: " + 
std::to_string(sessionsCount));
+canDestroy = docBroker->canDestroy();
+}
+
 // If we are the last, we must wait for the save to complete.
-const bool canDestroy = docBroker->canDestroy();
 if (canDestroy)
 {
 Log::info("Shutdown of the last session, saving the 
document before tearing down.");
 }
 
-// Use auto-save to save only when there are modifications 
since last save.
-// We also need to wait until the save notification reaches us
+// We need to wait until the save notification reaches us
 // and Storage persists the document.
 if (!docBroker->autoSave(canDestroy, COMMAND_TIMEOUT_MS))
 {
 Log::error("Auto-save before closing failed.");
 }
+
+if (!removedSession)
+{
+sessionsCount = docBroker->removeSession(id);
+Log::trace(docKey + ", ws_sessions--: " + 
std::to_string(sessionsCount));
+}
 }
-else
+
+if (session->_bLoadError)
 {
 Log::info("Clearing the queue.");
 queue->clear();
 }
 
+if (sessionsCount == 0)
+{
+std::unique_lock docBrokersLock(docBrokersMutex);
+Log::debug("Removing DocumentBroker for docKey [" + docKey + 
"].");
+docBrokers.erase(docKey);
+Log::info("Removing complete doc [" + docKey + "] from 
Admin.");
+Admin::instance().rmDoc(docKey);
+}
+
 Log::info("Finishing GET request handler for session [" + id + "]. 
Joining the queue.");
 queue->put("eof");
 queueHandlerThread.join();
@@ -680,18 +709,6 @@ private:
 Log::error("Error in client request handler: " + 
std::string(exc.what()));
 }
 
-docBrokersLock.lock();
-const auto sessionsCount = docBroker->removeSession(id);
-Log::trace(docKey + ", ws_sessions--: " + 
std::to_string(sessionsCount));
-if (sessionsCount == 0)
-{
-Log::debug("Removing DocumentBroker for docKey [" + docKey + "].");
-docBrokers.erase(docKey);
-Log::info("Removing complete doc [" + docKey + "] from Admin.");
-Admin::instance().rmDoc(docKey);
-}
-docBrokersLock.unlock();
-
 if (session->isCloseFrame())
 {
 Log::trace("Normal close handshake.");
___
Libreoffice-commits mailing list

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |   16 ++--
 loolwsd/LOOLWSD.cpp|5 +
 2 files changed, 11 insertions(+), 10 deletions(-)

New commits:
commit b06a07f6bc7149ffd497af5634e835f604d97d5f
Author: Ashod Nakashian 
Date:   Mon May 9 01:11:09 2016 -0400

loolwsd: auto-save checks modified state and logs decision

Change-Id: I69d32e8c5ceabd46b635aa6c5bb30ade21101fd0
Reviewed-on: https://gerrit.libreoffice.org/24785
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index f0e6173..b51f872 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -219,19 +219,23 @@ bool DocumentBroker::save()
 
 bool DocumentBroker::autoSave(const bool force, const size_t waitTimeoutMs)
 {
-Log::trace("Autosaving [" + _docKey + "].");
-
 std::unique_lock lock(_mutex);
-if (_sessions.empty() || _storage == nullptr || !_isLoaded)
+if (_sessions.empty() || _storage == nullptr || !_isLoaded ||
+(!_isModified && !force))
 {
 // Nothing to do.
 Log::trace("Nothing to autosave [" + _docKey + "].");
 return true;
 }
 
+// Remeber the last save time, since this is the predicate.
+const auto lastSaveTime = _lastSaveTime;
+Log::trace("Autosaving [" + _docKey + "].");
+
 bool sent = false;
 if (force)
 {
+Log::trace("Sending forced save command for [" + _docKey + "].");
 sent = sendUnoSave();
 }
 else if (_isModified)
@@ -251,17 +255,17 @@ bool DocumentBroker::autoSave(const bool force, const 
size_t waitTimeoutMs)
 if (inactivityTimeMs >= IdleSaveDurationMs ||
 timeSinceLastSaveMs >= AutoSaveDurationMs)
 {
+Log::trace("Sending timed save command for [" + _docKey + "].");
 sent = sendUnoSave();
 }
 }
 
 if (sent && waitTimeoutMs > 0)
 {
-// Remeber the last save time, since this is the predicate.
-const auto lastSaveTime = _lastSaveTime;
-
+Log::trace("Waiting for save event for [" + _docKey + "].");
 if (_saveCV.wait_for(lock, std::chrono::milliseconds(waitTimeoutMs)) 
== std::cv_status::no_timeout)
 {
+Log::debug("Successfully persisted document [" + _docKey + "].");
 return true;
 }
 
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 25a3801..48b8d05 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -1641,10 +1641,7 @@ int LOOLWSD::main(const std::vector& 
/*args*/)
 std::unique_lock 
docBrokersLock(docBrokersMutex);
 for (auto& brokerIt : docBrokers)
 {
-if (brokerIt.second->isModified())
-{
-brokerIt.second->autoSave(false, 0);
-}
+brokerIt.second->autoSave(false, 0);
 }
 }
 catch (const std::exception& exc)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99717] table contents only paste correctly in same document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99717

Terrence Enger  changed:

   What|Removed |Added

   Keywords||notBibisectable, regression
 Status|REOPENED|NEW
 CC||lo_b...@iseries-guru.com

--- Comment #5 from Terrence Enger  ---
I see different behaviour of the paste operation in the copied-from
document and a second document.  Here is what I did.

(1) In first document, create table with data ...

+-+-+-+-+-+
| The | Quick   | | | |
+-+-+-+-+-+
| Brown   | Fox | | | |
+-+-+-+-+-+

(2) Select the first two columns and type "+C".

(3) Create a new Writer document and in second document, create table
of 5 columns and two rows.

(4) Still in second document, select first two columns of that table
and type "+V".  Into each of the four selected cells, the
program puts a table of four cells, one word in each of the inner
cells.

(5) Still in the same table, click in row 1 column to clear selection
and put the caret in that cell.  Type "+V".  The program
puts a table of four cells into row 1 column 3 of the outer table.

(6) Type (without the space) "+ + +
" to move the caret to the end of the second document.
Type "Ctrl>+V".  The program inserts a 2-by-2 table ...

+++
| The| Quick
+++
| Brown  | Fox
+++

(7) At the end of the first document, create a second table of 5
columns a 2 rows.

(8) Still in first document, select first two columns of the new table
and type "+V".  The program puts one word into each selected
cell, with a result looking like step (1).

(9) Move the caret to the end of the first document and type
"+V".  The program inserts a 2-by-2 table looking like step
(6).

The problem is the different results of steps (4) and (8).  I think
the result of step (8) is what I would expect.


My observations are on a local build of commit ead3777, pulled
2016-05-08 03:10 UTC, configured ...
CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--enable-crashdump
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
built and running on debian-stretch.

I am setting status NEW.

I see that 50max bibisect repository version latest does the expected
cell-to-cell paste, so I am setting keyword regression.  However,
daily Linux dbgutil bibisect repository version 2015-11-25 shows the
paste-embedded-table behaviour, so I am setting keyword
notBibisectable.  (BTW, I do not understand how this can be.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 8f5f0ffdb1642f56a42e0075beb7429e754c7be0
Author: Ashod Nakashian 
Date:   Mon May 9 01:02:42 2016 -0400

loolwsd: don't persist documents again within 10 seconds

Change-Id: Ic11ef0bb4cdb85481a504729f2dfe26f5c80ee9c
Reviewed-on: https://gerrit.libreoffice.org/24784
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index adde590..f0e6173 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -177,7 +177,7 @@ bool DocumentBroker::save()
 
 const auto uri = _uriPublic.toString();
 
-// If we aren't potentially destroying just yet, and the file hasn't been
+// If we aren't potentially destroying just yet, and the file has been
 // modified within the past 10 seconds, skip saving.
 //
 // FIXME this is because currently the ChildProcessSession broadcasts the
@@ -189,7 +189,7 @@ bool DocumentBroker::save()
 // is planned post-release.
 const auto newFileModifiedTime = 
Poco::File(_storage->getLocalRootPath()).getLastModified();
 const auto elapsed = newFileModifiedTime - _lastFileModifiedTime;
-if (!canDestroy() && std::abs(elapsed) > 10 * 1000 * 1000)
+if (!canDestroy() && std::abs(elapsed) < 10 * 1000)
 {
 // Nothing to do.
 Log::debug() << "Skipping unnecessary saving to URI [" << uri
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/httpwstest.cpp |   50 
 1 file changed, 50 insertions(+)

New commits:
commit 4cba61525c31beee119c021d3075183a12d8b4f0
Author: Ashod Nakashian 
Date:   Mon May 9 00:48:30 2016 -0400

loolwsd: test notification replay on re-activation

Change-Id: I46471a2a3ecce219cf1b922aeebf0fdb02f66614
Reviewed-on: https://gerrit.libreoffice.org/24783
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index b1e6c5e..d760157 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -75,6 +75,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testInsertDelete);
 CPPUNIT_TEST(testEditLock);
 CPPUNIT_TEST(testSlideShow);
+CPPUNIT_TEST(testInactiveClient);
 
 CPPUNIT_TEST_SUITE_END();
 
@@ -99,6 +100,7 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 void testNoExtraLoolKitsLeft();
 void testEditLock();
 void testSlideShow();
+void testInactiveClient();
 
 void loadDoc(const std::string& documentURL);
 
@@ -1129,6 +1131,54 @@ void HTTPWSTest::testSlideShow()
 }
 }
 
+void HTTPWSTest::testInactiveClient()
+{
+try
+{
+std::string documentPath, documentURL;
+getDocumentPathAndURL("hello.odt", documentPath, documentURL);
+Poco::Net::HTTPRequest request(Poco::Net::HTTPRequest::HTTP_GET, 
documentURL);
+
+auto socket1 = loadDocAndGetSocket(_uri, documentURL);
+getResponseMessage(socket1, "invalidatetiles");
+
+// Connect another and go inactive.
+std::cerr << "Connecting second client." << std::endl;
+auto socket2 = loadDocAndGetSocket(_uri, documentURL);
+getResponseMessage(socket2, "status");
+sendTextFrame(socket2, "userinactive");
+
+// While second is inactive, make some changes.
+sendTextFrame(socket1, "uno .uno:SelectAll");
+sendTextFrame(socket1, "uno .uno:Delete");
+
+// Activate second.
+sendTextFrame(socket2, "useractive");
+SocketProcessor("Second", socket2, [&](const std::string& msg)
+{
+const auto token = LOOLProtocol::getFirstToken(msg);
+CPPUNIT_ASSERT_MESSAGE("unexpected message: " + msg,
+token == "textselection:" ||
+token == "textselectionstart:" ||
+token == "textselectionend:" ||
+token == "invalidatetiles:" ||
+token == "invalidatecursor:" ||
+token == "statechanged:");
+
+// End when we get state changed.
+return (token != "statechanged:");
+});
+
+std::cerr << "Second client finished." << std::endl;
+socket1->shutdown();
+socket2->shutdown();
+}
+catch (const Poco::Exception& exc)
+{
+CPPUNIT_FAIL(exc.displayText());
+}
+}
+
 void HTTPWSTest::testNoExtraLoolKitsLeft()
 {
 const auto countNow = countLoolKitProcesses(_initialLoolKitCount);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99737] New: limitation of the HTML filter to handle multiple adjacent tags

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99737

Bug ID: 99737
   Summary: limitation of the HTML filter to handle multiple
adjacent tags
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rmgh...@kreeti.com

 and  are not working together using Libreoffice "docx:Office Open
XML Text" when converting from html to docx. 

I have tried to convert from html to docx using Libreoffice  using the
following command...

soffice --headless --convert-to "docx:Office Open XML Text" 'test.html'

test.html


  
  
  
Apply em then strong
Apply strong then em
  


When I am converting this test.html to docx then `Apply em then
strong` is only taking `` and `Apply strong then
em` is only taking ``.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/WhiteBoxTests.cpp |1 -
 loolwsd/test/httpwstest.cpp|7 +--
 2 files changed, 1 insertion(+), 7 deletions(-)

New commits:
commit b18246569d3d309257f269e421236753c261dcc4
Author: Ashod Nakashian 
Date:   Mon May 9 00:44:08 2016 -0400

loolwsd: verify the number lokit instance before and after each test

Change-Id: Ia38475dc78ef5b4dc116a2d6f9791c7012985b5d
Reviewed-on: https://gerrit.libreoffice.org/24782
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/WhiteBoxTests.cpp b/loolwsd/test/WhiteBoxTests.cpp
index 92b3df9..606abfb 100644
--- a/loolwsd/test/WhiteBoxTests.cpp
+++ b/loolwsd/test/WhiteBoxTests.cpp
@@ -68,7 +68,6 @@ void WhiteBoxTests::testRegexListMatcher()
 CPPUNIT_ASSERT(matcher.match("10.10.250.254"));
 }
 
-
 void WhiteBoxTests::testRegexListMatcher_Init()
 {
 Util::RegexListMatcher matcher({"localhost", "192\\..*"}, 
{"192\\.168\\..*"});
diff --git a/loolwsd/test/httpwstest.cpp b/loolwsd/test/httpwstest.cpp
index 0da3049..b1e6c5e 100644
--- a/loolwsd/test/httpwstest.cpp
+++ b/loolwsd/test/httpwstest.cpp
@@ -56,9 +56,6 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 
 CPPUNIT_TEST_SUITE(HTTPWSTest);
 
-// This should be the first test:
-CPPUNIT_TEST(testCountHowManyLoolkits);
-
 CPPUNIT_TEST(testBadRequest);
 CPPUNIT_TEST(testHandShake);
 CPPUNIT_TEST(testCloseAfterClose);
@@ -79,9 +76,6 @@ class HTTPWSTest : public CPPUNIT_NS::TestFixture
 CPPUNIT_TEST(testEditLock);
 CPPUNIT_TEST(testSlideShow);
 
-// This should be the last test:
-CPPUNIT_TEST(testNoExtraLoolKitsLeft);
-
 CPPUNIT_TEST_SUITE_END();
 
 void testCountHowManyLoolkits();
@@ -134,6 +128,7 @@ public:
 
 void setUp()
 {
+testCountHowManyLoolkits();
 }
 
 void tearDown()
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/test

[Ashod Nakashian]

 loolwsd/test/helpers.hpp |   17 +
 1 file changed, 17 insertions(+)

New commits:
commit b0843ba443676cd24467f5eec7cbcdd4c4ec5ddc
Author: Ashod Nakashian 
Date:   Mon May 9 00:39:01 2016 -0400

loolwsd: test helpers accept smart pointer WebSocket too

Change-Id: I83e62c7ce0daa6e44fb7f163607436640c9b9f08
Reviewed-on: https://gerrit.libreoffice.org/24781
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index a31d19a..22f57b7 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -65,6 +65,12 @@ void sendTextFrame(Poco::Net::WebSocket& socket, const 
std::string& string)
 }
 
 inline
+void sendTextFrame(const std::shared_ptr& socket, const 
std::string& string)
+{
+sendTextFrame(*socket, string);
+}
+
+inline
 bool isDocumentLoaded(Poco::Net::WebSocket& ws, std::string name = "")
 {
 if (!name.empty())
@@ -257,6 +263,12 @@ void getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix, std
 }
 
 inline
+void getResponseMessage(const std::shared_ptr& ws, const 
std::string& prefix, std::string& response, const bool isLine)
+{
+getResponseMessage(ws, prefix, response, isLine);
+}
+
+inline
 std::vector getResponseMessage(Poco::Net::WebSocket& ws, const 
std::string& prefix)
 {
 try
@@ -326,6 +338,11 @@ std::vector getResponseMessage(Poco::Net::WebSocket& 
ws, const std::string
 return std::vector();
 }
 
+inline
+std::vector getResponseMessage(const 
std::shared_ptr& ws, const std::string& prefix)
+{
+return getResponseMessage(*ws, prefix);
+}
 
 inline
 std::shared_ptr loadDocAndGetSocket(const Poco::URI& 
uri, const std::string& documentURL)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian]

 loleaflet/src/map/Map.js |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 50cc60e6f6ae1f151473c81feb692ac631f34d1d
Author: Ashod Nakashian 
Date:   Sun May 8 20:23:46 2016 -0400

loleaflet: invalidate on activation

Invalidation for spreadsheet and presentation
are part-sensitive. The handler will take
care of this distinction and construct the correct
invalidate command.

Also, set active flag before firing invalidation.

Change-Id: I9e897750e0768b54cc1521d47d69b5dbb1a36244
Reviewed-on: https://gerrit.libreoffice.org/24779
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/map/Map.js b/loleaflet/src/map/Map.js
index c90035e..8b3cb77 100644
--- a/loleaflet/src/map/Map.js
+++ b/loleaflet/src/map/Map.js
@@ -699,8 +699,8 @@ L.Map = L.Evented.extend({
 
// Only activate when we are connected.
if (this._socket.connected()) {
-   this._docLayer._onMessage('invalidatetiles: 
part=0 x=0 y=0 width=2147483647 height=2147483647', null);
this._active = true;
+   this._docLayer._onMessage('invalidatetiles: 
EMPTY', null);
 
if (vex.dialogID > 0) {
var id = vex.dialogID;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLProtocol.hpp

[Ashod Nakashian]

 loolwsd/LOOLProtocol.hpp |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

New commits:
commit f20a9e94b64ca76f1ed09fedd066f630919a91e0
Author: Ashod Nakashian 
Date:   Mon May 9 00:35:45 2016 -0400

loolwsd: templatize parsing helpers

Change-Id: Ia52dbf59bf5f2a816578b75111ee9accdeaaf816
Reviewed-on: https://gerrit.libreoffice.org/24780
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/LOOLProtocol.hpp b/loolwsd/LOOLProtocol.hpp
index 05cc4b4..21d488b 100644
--- a/loolwsd/LOOLProtocol.hpp
+++ b/loolwsd/LOOLProtocol.hpp
@@ -69,8 +69,8 @@ namespace LOOLProtocol
 return getDelimitedInitialSubstring(message, length, ' ');
 }
 
-inline
-std::string getFirstToken(const std::vector& message)
+template 
+std::string getFirstToken(const T& message)
 {
 return getFirstToken(message.data(), message.size());
 }
@@ -96,8 +96,8 @@ namespace LOOLProtocol
 return getDelimitedInitialSubstring(message, length, '\n');
 }
 
-inline
-std::string getFirstLine(const std::vector& message)
+template 
+std::string getFirstLine(const T& message)
 {
 return getFirstLine(message.data(), message.size());
 }
@@ -111,8 +111,8 @@ namespace LOOLProtocol
 return getAbbreviatedMessage(message.data(), message.size());
 }
 
-inline
-std::string getAbbreviatedMessage(const std::vector& message)
+template 
+std::string getAbbreviatedMessage(const T& message)
 {
 return getAbbreviatedMessage(message.data(), message.size());
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loolwsd/LOOLProtocol.cpp

[Tor Lillqvist]

 loolwsd/LOOLProtocol.cpp |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ab92acac205f294e0e531e76e01d7792fafa6f11
Author: Tor Lillqvist 
Date:   Thu May 5 09:25:11 2016 +0300

Spelling correction

diff --git a/loolwsd/LOOLProtocol.cpp b/loolwsd/LOOLProtocol.cpp
index bdc32cd..2d5893b 100644
--- a/loolwsd/LOOLProtocol.cpp
+++ b/loolwsd/LOOLProtocol.cpp
@@ -189,7 +189,7 @@ namespace LOOLProtocol
 
 const auto firstLine = getFirstLine(message, length);
 
-// If first line is less than the length (minus newline), add eclipes.
+// If first line is less than the length (minus newline), add ellipsis.
 if (firstLine.size() < static_cast(length) - 1)
 {
 return firstLine + "...";
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sd/source

[David Tardon]

 sd/source/ui/controller/displaymodecontroller.cxx |4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 11bf96474f79eeb952d4cc36b1bf033f0569e350
Author: David Tardon 
Date:   Fri May 6 13:05:26 2016 +0200

use existing function

Change-Id: I130e701902a22016cd06649e1c9ba3d932d64e1c

diff --git a/sd/source/ui/controller/displaymodecontroller.cxx 
b/sd/source/ui/controller/displaymodecontroller.cxx
index 749ce71..8e8b6b9f 100644
--- a/sd/source/ui/controller/displaymodecontroller.cxx
+++ b/sd/source/ui/controller/displaymodecontroller.cxx
@@ -162,12 +162,10 @@ DisplayModeToolbarMenu::DisplayModeToolbarMenu( 
DisplayModeController& rControll
 appendEntry( -1, aTitle1 );
 appendEntry( 1, mpDisplayModeSet1 );
 
-mpDisplayModeSet2 = VclPtr::Create( this, WB_TABSTOP | 
WB_MENUSTYLEVALUESET | WB_FLATVALUESET | WB_NOBORDER | WB_NO_DIRECTSELECT );
+mpDisplayModeSet2 = createEmptyValueSetControl();
 
 mpDisplayModeSet2->SetSelectHdl( LINK( this, DisplayModeToolbarMenu, 
SelectValueSetHdl ) );
 mpDisplayModeSet2->SetColCount( nColCount );
-mpDisplayModeSet2->EnableFullItemMode( false );
-mpDisplayModeSet2->SetColor( GetControlBackground() );
 
 fillLayoutValueSet( mpDisplayModeSet2, [0] );
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: desktop/qa

[Tor Lillqvist]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e21611090147943e78c6d7a3a7080a9a97c54bf0
Author: Tor Lillqvist 
Date:   Mon May 9 07:35:19 2016 +0300

loplugin:redundantcast

reinterpret_cast from 'void *' to 'std::vector > *' can be simplified to static_cast.

Change-Id: I1899a1c570c4c56d8c7fe73745eac45061fb8bae

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 86ca392..6beb0e7 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1267,7 +1267,7 @@ void DesktopLOKTest::testContextMenuImpress()
 
 static void callbackCompressionTest(const int type, const char* payload, void* 
data)
 {
-std::vector>* notifs = 
reinterpret_cast>*>(data);
+std::vector>* notifs = 
static_cast>*>(data);
 notifs->emplace_back(type, std::string(payload ? payload : "(nil)"));
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

xmlreader is fast XML pull parser ?

[lgh710681...@gmail.com]

Hi!
file: xmlreader/README It says that xmlreader is fast and small XML pull parser.
I know xmlreader is currently used by configmgr, when we start up LO, configmgr 
will parse *.xcd files in /share/registry directory. It will takes several 
seconds.
so i guess that xmlreader is not real fast, i want to know how can we optimize 
the speed of parsing files? 



lgh710681...@gmail.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 97623] com.sun.star.system.SimpleCommandMail accepts no Space or german umlauts in attachment-URLs

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97623

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #1 from Aron Budea  ---
Hi, thanks for your bug report. Can you provide a simple example that could be
used to reproduce the issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99722] FILEOPEN REGRESSION: Writer 5.1.x freezes when opening particular .odt document. CPU 100%

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99722

--- Comment #4 from Terrence Enger  ---
With my local build of master commit ead3777, pulled 2016-05-08 03:10
UCT, configured ...
CC=ccache /usr/bin/gcc
CXX=ccache /usr/bin/g++
--enable-option-checking=fatal
--enable-dbgutil
--enable-debug
--enable-crashdump
--without-system-postgresql
--without-myspell-dicts
--with-extra-buildid
--without-doxygen
--with-external-tar=/home/terry/lo_hacking/git/src
built and running on debian-stretch, I see the busy loop within
SwRootFrame::CheckViewLayout, sw/source/core/layout/pagechg.cxx lines
1958 to 2178.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97431] Shlomo font not accessible

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97431

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |WORKSFORME

--- Comment #4 from Aron Budea  ---
Can't reproduce with Ubuntu 15.10, LO 5.0.5.2, shows Shlomo in font list.
Axel, can you check with a newer version?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/inc desktop/qa

[Ashod Nakashian]

 desktop/inc/lib/init.hxx|9 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   28 +++-
 2 files changed, 36 insertions(+), 1 deletion(-)

New commits:
commit 3d27afd26f7b85c46a7c7d08498000b9dbcea1c8
Author: Ashod Nakashian 
Date:   Sat Apr 23 14:06:22 2016 -0400

Desktop compresses text selection start/end notifications

Change-Id: Ia85ded04d0eaf9d9b846fab6d86a44a758fccb69
Reviewed-on: https://gerrit.libreoffice.org/24320
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 45037438d84485356a5ceb820ecc3e0bae4b112e)
Reviewed-on: https://gerrit.libreoffice.org/24380
Tested-by: Jenkins 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index df065d7..7cf81e3 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -39,6 +39,8 @@ namespace desktop {
 
 // Add the states that are safe to skip duplicates on,
 // even when not consequent.
+m_states.emplace(LOK_CALLBACK_TEXT_SELECTION_START, "NIL");
+m_states.emplace(LOK_CALLBACK_TEXT_SELECTION_END, "NIL");
 m_states.emplace(LOK_CALLBACK_TEXT_SELECTION, "NIL");
 m_states.emplace(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, "NIL");
 m_states.emplace(LOK_CALLBACK_STATE_CHANGED, "NIL");
@@ -94,6 +96,13 @@ namespace desktop {
 return;
 }
 
+if (type == LOK_CALLBACK_TEXT_SELECTION && payload.empty())
+{
+// Removing text selection invalidates the start and end as 
well.
+m_states[LOK_CALLBACK_TEXT_SELECTION_START] = "";
+m_states[LOK_CALLBACK_TEXT_SELECTION_END] = "";
+}
+
 m_queue.emplace_back(type, payload);
 
 lock.unlock();
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index f6e3d91..86ca392 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1289,10 +1289,18 @@ void DesktopLOKTest::testNotificationCompression()
 handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 8
 handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // Should be 
dropped.
 handler->queue(LOK_CALLBACK_MOUSE_POINTER, "text"); // Should be dropped.
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_START, "15 25 15 10"); // 9
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_END, "15 25 15 10"); // 10
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15 25 15 10"); // 11
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_START, "15 25 15 10"); // 
Should be dropped.
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_END, "15 25 15 10"); // Should 
be dropped.
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, ""); // 12
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_START, "15 25 15 10"); // 13
+handler->queue(LOK_CALLBACK_TEXT_SELECTION_END, "15 25 15 10"); // 14
 
 Scheduler::ProcessEventsToIdle();
 
-CPPUNIT_ASSERT_EQUAL(static_cast(9), notifs.size());
+CPPUNIT_ASSERT_EQUAL(static_cast(15), notifs.size());
 
 CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, 
(int)std::get<0>(notifs[0]));
 CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[0]));
@@ -1320,6 +1328,24 @@ void DesktopLOKTest::testNotificationCompression()
 
 CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_TILES, 
(int)std::get<0>(notifs[8]));
 CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[8]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION_START, 
(int)std::get<0>(notifs[9]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[9]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION_END, 
(int)std::get<0>(notifs[10]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[10]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION, 
(int)std::get<0>(notifs[11]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[11]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION, 
(int)std::get<0>(notifs[12]));
+CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[12]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION_START, 
(int)std::get<0>(notifs[13]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[13]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION_END, 
(int)std::get<0>(notifs[14]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[14]));
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 99134] Background in text boxes is not refreshing

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99134

Aron Budea  changed:

   What|Removed |Added

 CC||travislem@gmail.com

--- Comment #8 from Aron Budea  ---
*** Bug 94062 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 94062] ghosting text when deleting text

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=94062

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Aron Budea  ---
This looks very similar to bug 99721, which is a duplicate of bug 99134.

*** This bug has been marked as a duplicate of bug 99134 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99722] FILEOPEN REGRESSION: Writer 5.1.x freezes when opening particular .odt document. CPU 100%

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99722

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #3 from Terrence Enger  ---
Created attachment 124921
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124921=edit
bibisect results in 44max repository

Working in the 44max bibisect repository, I see that the loop was
added at ...

commit b4558b508141af16d335f45a0f12bdd34521e944
Author: Samuel Mehrbrodt 
Date:   Fri Aug 22 22:37:56 2014 +0200

fdo#73151 Make better use of the sidebar

The general idea is to encourage use of the sidebar instead of floating
windows (for Navigator, Styles and Gallery)

Changes:
* Show the sidebar by default in Writer & Impress
* Remove the Gallery floating window (Gallery now always opens in the
sidebar)
* Remove all Gallery, Navigator and Styles links from the
default toolbar in Writer
  (since they have an icon in the sidebar and the sidebar is shown by
default now)
* When selecting "More" from the Styles dropdown, the Stylelist opens
in the sidebar instead of the floating window

This has all been discussed extensively here:
https://bugs.freedesktop.org/show_bug.cgi?id=73151

Change-Id: I3a0461d1472711da7121801000af294b432fccb1
Reviewed-on: https://gerrit.libreoffice.org/11077
Reviewed-by: Thomas Arnhold 
Tested-by: Thomas Arnhold 

I am adding keyword bisected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99722] FILEOPEN REGRESSION: Writer 5.1.x freezes when opening particular .odt document. CPU 100%

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99722

Terrence Enger  changed:

   What|Removed |Added

   Keywords||bisected

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99594] Cannot update my LibreOffice 4.4.5.2 to 5.1.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99594

--- Comment #7 from Aron Budea  ---
Jeff, please give further details if you're looking for help.

For starters:
1. Which version of LibreOffice do you currently have installed, 4.4.5.2 or
4.3.7.2?

2. What happens exactly if you try to run the installer for your current
version, whichever it is?
4.3.7.2:
http://downloadarchive.documentfoundation.org/libreoffice/old/4.3.7.2/win/x86/
4.4.5.2:
http://downloadarchive.documentfoundation.org/libreoffice/old/4.4.5.2/win/x86/


Note that this is a bug report site, and not for general support. You can find
community support options here:
http://www.libreoffice.org/get-help/community-support/
Some more information on similar issues:
http://ooo-forums.apache.org/en/forum/viewtopic.php?f=15=78765
https://ask.libreoffice.org/en/questions/scope:all/sort:activity-desc/tags:error-1714/page:1/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98656] Insert rows above in Polish version at 5.1.0.3 and newer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98656

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #4 from Aron Budea  ---
I checked in 5.1.2.2, and it's correctly translated. Please verify with latest
version.

It's the one you see when you right click on a row header in Calc, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99689] Subscript not working in Illustration index

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99689

--- Comment #4 from Mark  ---
May I add that I forgot to add that this also applies to the Index of Tables.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 35438] Add a crash reporter (eg Breakpad)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=35438

Markus S.  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #21 from Markus S.  ---
Better late than never. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99736] New: overlaid dialog export pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99736

Bug ID: 99736
   Summary: overlaid dialog export pdf
   Product: LibreOffice
   Version: 5.2.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: minor
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: lo_b...@iseries-guru.com

Created attachment 124919
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124919=edit
screenshot

STR
---
(1) Open new Writer document "Untitled 1".

(2) Take menu option File > "Save as...".  Program presents dialog
"Save As" with default directory your home directory and default
file name "Untitled 1"; the caret is at the start of the file
name.

(3) Type, without the spaces, "+A /tmp ".  (Yes, I know
that this is not the right way to enter the directory name.  I
just confused myself while I was jumping between versions of
LibreOffice.)

Expected : The control for the directory name should show "/tmp".

Observed : The program displays both the default value and "/tmp"
overlaying each other.


I see this as well in the Export dialog from Writer and Save-as dialog
from Draw.

This observation is from daily Linux dbgutil bibisect repository
version 2016-05-08 running on debian stretch.

I am setting severity minor because (a) the bad result is too obvious
to cause confusion, and (b) the workaround is simply to enter the
directory name in the directory name control.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99736] overlaid dialog export pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99736

Terrence Enger  changed:

   What|Removed |Added

   Keywords||bibisected, regression
   Hardware|All |x86-64 (AMD64)
 OS|All |Linux (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99736] overlaid dialog export pdf

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99736

--- Comment #1 from Terrence Enger  ---
Created attachment 124920
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124920=edit
bibisect details from daily Linux dbgutil repository

Working in the daily Linux dbgutil bibisect repository on
debian-stretch, I have narrowed the introduction of the bug to the 48
commits ...

what   commit   dates-h
-  ---  --  ---
last good  cafe073  2016-02-11  a6f876d
first bad  3ced19f  s016-02-12  0ab6332

I am setting keywords regression bibisected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97656] Hyperlink Paste Failure

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97656

Aron Budea  changed:

   What|Removed |Added

   Keywords||bibisectRequest, regression
 Status|NEEDINFO|NEW
Version|5.0.4.2 release |4.0.0.3 release

--- Comment #9 from Aron Budea  ---
Ah, I didn't compile it as ASCII, that was the problem, thanks for the
clarification. After compiling correctly, and running the program, I can see
the pasted text as link in WordPad.

Here is my analysis:
v3.6.0.4: "" is pasted, and it is a link,
v4.0.0.3 - v5.1.2.2 (tested with some major versions): "" is pasted,
but it's not a link,
development master build: "Copy This Text as Text into Clipboard" is pasted,
and it's not a link.

I conclude that the issue is reproducible, though the last working version
seems to be 3.6.
If you want to verify whether it indeed worked in 4.x versions, "Regression
Testing" on the following page has information on installing different versions
of LO in parallel, and link to old releases:
https://wiki.documentfoundation.org/QA/Triage_For_Beginners

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99732] sum('123) = 0 wrong answer without warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99732

Spencer Graves  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #3 from Spencer Graves  ---
Thanks for the review.  My real problem is that when I paste a number like
$1,234.56 into a cell, sometimes it is converted to numeric and sometimes it
stays as character, which looks like a number and computes as a number with "+"
but not "sum".  

Worse, I could not find an easy way to convert the text into a number. 
Sometimes the number starts with a single quote, like ('1234).  If I see that,
I can remove the single quote.  Otherwise, I can't just type the number over,
because the cell is now committed to text.  I tried typing the number in
manually without "$" and "," and found that the cell was committed to text and
converted the number to text.  I have to insert a new cell, carefully enter the
number manually, then manually delete the cell committed to text.  

You are correct, that it's not a problem with "sum" -- nor with "+":  If either
were changed, it would break lots of spreadsheets people have used for years.  

Thanks, Spencer Graves

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99594] Cannot update my LibreOffice 4.4.5.2 to 5.1.2.2

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99594

--- Comment #6 from Jeff Tonne  ---
Buovjaga,

I cannot uninstall or install. Please help.
Thank you, Jeff

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

--- Comment #5 from mrelw...@yahoo.com ---
It's actually in the main application menu:
LibreOfficeDev > Preferences...

Anyway, no help from resetting the user profile, still crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

--- Comment #4 from m.a.riosv  ---
Sorry I think for mac is Menu/Edit/Preferences.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99637

--- Comment #14 from Olivier Hallot  ---
(snip)
> > (Maybe it
> > would be worth to create a list of all useful expert configuration options.
> > Then the info should be at both places I think.)
> 
> Indeed. I've no idea if such an effort already exists.
> @Olivier: do you know about that?

Documenting all Expert Configuration is not a small task, specially for a
layman.

I wrote the page 
http://vm173.documentfoundation.org/text/shared/optionen/expertconfig.xhp

as introduction to Expert Config, and with a big warning.

But I think that if a configuration is important for the user, it should be
made available in the UI, rather than in E.C. Once in the UI, a help content is
obliged.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97387] Not possible to select picture frame in the footer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97387

Regina Henschel  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||rb.hensc...@t-online.de
 Ever confirmed|0   |1

--- Comment #10 from Regina Henschel  ---
I can confirm the described behavior with the attached document using LO 5.2 on
Windows 7. You can get the frame, when you use the Navigator. Right-click the
item "Keret1" and then use Text Frame > Edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

--- Comment #3 from mrelw...@yahoo.com ---
The menu item mentioned in the wiki:
Tools > Options
does not exist.

Anyway, renaming the user profile directory and relaunching LibreOffice did not
affect this issue. Still crashes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: libre5.0 + win10 configure error

[jemmy]

I always think I solved the problem by chance. So I go back to think the
reason why the old repo code configured failed. It is not possible to cause
the problem by the renamed path and the branch of libreoffice-5-0-6. Over
the next three days, there was no progress on this matter. An accidental
opportunity, I found different unstaged changes in unmodified code repo by
using "git status" in cygwin and gitshell. The version of gitshell is "git
version 2.8.1.windows.1". Then I clone one code repo by cygwin, another one
by gitshell. The cygwin cloned code is going right. But the gitshell cloned
code will lead to errors as follow:

1、
$ ./autogen.sh --with-external-tar=/cygdrive/d/sources/lo-externalsrc
--with-junit=/cygdrive/d/sources/junit-4.10.jar
--with-ant-home=/cygdrive/d/sources/apache-ant-1.9.5 --enable-pch
--disable-ccache --enable-debug
./autogen.sh: line 1: $':\r': command not found
Running ./configure with
'--with-external-tar=/cygdrive/d/sources/lo-externalsrc
--with-junit=/cygdrive/d/sources/junit-4.10.jar
--with-ant-home=/cygdrive/d/sou --srcdir=/cygdrive/d/sources/libo-wingit
--enable-option-checking=fatal'
configure: error: invalid feature name: debug
Error running configure at ./autogen.sh line 281.

use commands as follow to pass this error
$ dos2unix autogen.sh
dos2unix: converting file autogen.sh to Unix format...
$ dos2unix config.sub
dos2unix: converting file config.sub to Unix format...
$ dos2unix config.guess
dos2unix: converting file config.guess to Unix format...

2、
cygpath: cannot create short name of 12.0\VC\Include
realpath: '12.0/VC': No such file or directory
configure: WARNING: realpath failed for "12.0/VC", not necessarily a
problem.
checking the dependency generation prefix (cl.exe -showIncludes)...
configure: error: cannot determine the -showIncludes prefix

use commands as follow to pass this error
shift+reset, go to the safe mode, do this: 
fsutil 8dot3name set c: 0 
fsutil file setshortname "Program Files (x86)" PROG~1 
fsutil file setshortname "Microsoft Visual Studio 12.0" msvc~120 
fsutil file setshortname "Windows Kits" W~Kits 

The shortname is unreadable as Tor Lillqvist-2 said. I will use better name
next time.

3、
checking whether to create huge library... no
checking whether to create hardlinks for delivering files... no
checking whether to use icerun wrapper... no
checking MPL subset... no restrictions
configure: setting up the build environment variables...
configure: creating ./config.status
.in'ig.status: error: cannot find input file: `config_host.mk
Error running configure at ./autogen.sh line 281.

There's nothing I can do about this.

Why the code cloned by cygwin and gitshell has different result of
configure. I open the same filename in different repo by UltraEdit. It shows
the difference. The cygwin cloned code is unix format, and the gitshell
cloned code is dos format.
Yes, the first problem and the third problem are caused by the dos format
files cloned by  the gitshell .





--
View this message in context: 
http://nabble.documentfoundation.org/libre5-0-win10-configure-error-tp4182634p4183051.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

m.a.riosv  changed:

   What|Removed |Added

 CC||miguelangelrv@libreoffice.o
   ||rg

--- Comment #2 from m.a.riosv  ---
Please try resetting the user profile, sometimes solves strange issues.
https://wiki.documentfoundation.org/UserProfile
Usually it's enough renaming/deleting the file
"user/registrymodifications.xcu",  it affects all the options in
Menu/Tools/Options, and the files "user/basic/dialog.xlc" and "scrip.xlc" are
overwritten, additionally custom colors in "user/config/standard.soc" are lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99725] FILEOPEN RTF layout problem with footer (Normal view not showing some text)

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99725

--- Comment #5 from Óvári  ---
(In reply to MM from comment #4)

\footeryN Footer is N twips from the bottom of the page (the default is
720).
http://www.biblioscape.com/rtf15_spec.htm

Twips are screen-independent units to ensure that the proportion of screen
elements are the same on all display systems. A twip is defined as being 1/1440
of an inch. A pixel is a screen-dependent unit, standing for 'picture element'.
A pixel is a dot that represents the smallest graphical measurement on a
screen.
https://en.wikipedia.org/wiki/Twip

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99734] Average of external linked cells are incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99734

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #1 from m.a.riosv  ---
If you do the same between ranges on the same file you have the same result.

You are using a range with a formula to calculate the average, so there are not
empty cells for the calculation.
A trick is use and array than returns an empty string to avoid zeroes so
AVARAGE() calculates without those cells because they are text, like
{=IF(B2:B7;B2:B7;"")}

Resolved as notabug, please if you are not agree reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99714] Auto numbering Frames / marginalias

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99714

Regina Henschel  changed:

   What|Removed |Added

 CC||rb.hensc...@t-online.de

--- Comment #4 from Regina Henschel  ---
Please attach the original document. The pdf does not allow to investigate,
what settings are actually used.

There exist several kind of numbering: Paragraph outline numbering, body text
lists, number ranges, line numbers. It is not clear, what you are using and
what object actually gets a number.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99732] sum('123) = 0 wrong answer without warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99732

m.a.riosv  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||miguelangelrv@libreoffice.o
   ||rg
 Resolution|--- |NOTABUG

--- Comment #2 from m.a.riosv  ---
Calc is very strict in accept text as number in formulas, and only try to
convert text to values in direct references, but none in a SUM() function.

Resolved as notabug, please if you are not agree reopen it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99735] New: FORMATTING - Adds many many carriage returns to footnotes when opening WORD file; inserts pieces of email in files

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99735

Bug ID: 99735
   Summary: FORMATTING - Adds many many carriage returns to
footnotes when opening WORD file; inserts pieces of
email in files
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mar...@gmail.com

When I open certain files originally written in MS WORD, multiple, sometimes
100s of carriage returns are added before and after the text of the note. This
happens with only one type of file, which was formatted with a different page
size and margins. Also, very frequently, the text of an email is added in many
places to a file.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 36634] Formula editor becomes slower and slower

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36634

Julien Nabet  changed:

   What|Removed |Added

 Attachment #124916|0   |1
is obsolete||

--- Comment #16 from Julien Nabet  ---
Comment on attachment 124916
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124916
proposed patch

I submitted for review the modified patch here
https://gerrit.libreoffice.org/#/c/24775/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99723] Setting image Compression in PDF export does not result in smaller file size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99723

Cor Nouws  changed:

   What|Removed |Added

 CC||michael.me...@collabora.com
   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=97
   ||662

--- Comment #4 from Cor Nouws  ---
Thanks for testing, Terrence!

@Michael: can you please have a look?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 97662] CPU burned re-compressing JPEGs to make them bigger ...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=97662

Cor Nouws  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||723

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99734] Average of external linked cells are incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99734

Niklas  changed:

   What|Removed |Added

Version|5.1.2.2 release |5.1.0.3 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 31199] Click on specific paragraph will freeze Writer

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=31199

--- Comment #35 from Rodolfo  ---
Not reproducible with LibreOffice 5.1.3.1 Build ID: 1:5.1.3~rc1-1 Locale: pt-BR
(pt_BR.utf8) Debian Testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99686] Implement a recovery utility to clear "" from corrupted content.xml in ODF archives

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99686

--- Comment #6 from shunesbur...@yahoo.fr ---
(In reply to Maxim Monastirsky from comment #5)
> And yet - why _remove_ valuable data, when it can be easily repaired?

I just propose what I try but if you have a better way, I'm ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99734] New: Average of external linked cells are incorrect

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99734

Bug ID: 99734
   Summary: Average of external linked cells are incorrect
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: hibo98.nik...@gmail.com

Created attachment 124918
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124918=edit
Screenshot of the Bug

Reproduction:

1. Open two files and save them

2. In file B add a few values with a few cells space between.

3. Copy all the cells

4. Insert into file A with [CTRL- SHIFT - V] a check "link" (don't know if its
correct in German it's "Verknüpfen")

5. Then use formula for average in both files over all cells, also the blank in
between

-> The average of the cells is not the same as it should be.
LibreOffice count the blank cells as cells that have the value '0' not as cells
that should be used for average.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99723] Setting image Compression in PDF export does not result in smaller file size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99723

Terrence Enger  changed:

   What|Removed |Added

 CC||lo_b...@iseries-guru.com

--- Comment #3 from Terrence Enger  ---
Created attachment 124917
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124917=edit
bibisect details in daily Linux dbgutil bibisect repository

Working in the daily Linux dbgutil bibisect repository, I have
narrowed introduction of the problem down ...

what   commit   dates-h
-  ---  --  ---
last good  3a67f57  2016-02-09  5381db9
first bad  4805517  2016-02-09  76ec54e

5381db9..76ec54e = 68 commits inclusive

The following jumps out at me ...

commit 76ec54e8c9f3580450bca85236a4f5af0c328588
Author: Michael Meeks 
Date:   Mon Feb 8 14:24:15 2016 +

tdf#97662 - Try to preserve original compressed JPEGs harder.

Avoiding de-compressing and re-compressing them saves lots of time too.

Change-Id: Ie8eb68554627581b2f0584a55bbbdb43c9482bed
Reviewed-on: https://gerrit.libreoffice.org/22219
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

I am removing keyword bibisectRequest, adding bibisected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99723] Setting image Compression in PDF export does not result in smaller file size

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99723

Terrence Enger  changed:

   What|Removed |Added

   Keywords|bibisectRequest |bibisected

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92768] support hiding title objects

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92768

--- Comment #4 from Commit Notification 
 ---
Feyza Yavuz committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=0ab7ad3bb0138c2614f66dba8af39cabe760f910

tdf#92768 Support hiding title objects

It will be available in 5.2.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: chart2/source

[Feyza Yavuz]

 chart2/source/controller/sidebar/ChartElementsPanel.cxx |   13 +-
 chart2/source/inc/TitleHelper.hxx   |   11 +
 chart2/source/tools/TitleHelper.cxx |   31 
 3 files changed, 52 insertions(+), 3 deletions(-)

New commits:
commit 0ab7ad3bb0138c2614f66dba8af39cabe760f910
Author: Feyza Yavuz 
Date:   Sun May 1 17:28:07 2016 +0300

tdf#92768 Support hiding title objects

Change-Id: I879fc3d81a8fe8ca2f928305f5dc7fd9ebcfd294
Reviewed-on: https://gerrit.libreoffice.org/24564
Tested-by: Jenkins 
Reviewed-by: Markus Mohrhard 

diff --git a/chart2/source/controller/sidebar/ChartElementsPanel.cxx 
b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
index b86cb14..1e52f24 100644
--- a/chart2/source/controller/sidebar/ChartElementsPanel.cxx
+++ b/chart2/source/controller/sidebar/ChartElementsPanel.cxx
@@ -116,7 +116,14 @@ void setLegendVisible(const 
css::uno::Reference& xModel, boo
 
 bool isTitleVisisble(const css::uno::Reference& xModel, 
TitleHelper::eTitleType eTitle)
 {
-return TitleHelper::getTitle(eTitle, xModel).is();
+css::uno::Reference xTitle = 
TitleHelper::getTitle(eTitle, xModel);
+if (!xTitle.is())
+return false;
+
+css::uno::Reference xPropSet(xTitle, 
css::uno::UNO_QUERY_THROW);
+css::uno::Any aAny = xPropSet->getPropertyValue("Visible");
+bool bVisible = aAny.get();
+return bVisible;
 }
 
 bool isGridVisible(const css::uno::Reference& xModel, 
GridType eType)
@@ -581,11 +588,11 @@ void 
ChartElementsPanel::setTitleVisible(TitleHelper::eTitleType eTitle, bool bV
 if (bVisible)
 {
 OUString aText = eTitle == TitleHelper::SUB_TITLE ? maTextSubTitle : 
maTextTitle;
-TitleHelper::createTitle(eTitle, aText, mxModel, 
comphelper::getProcessComponentContext());
+TitleHelper::createOrShowTitle(eTitle, aText, mxModel, 
comphelper::getProcessComponentContext());
 }
 else
 {
-TitleHelper::removeTitle(eTitle, mxModel);
+TitleHelper::hideTitle(eTitle, mxModel);
 }
 }
 
diff --git a/chart2/source/inc/TitleHelper.hxx 
b/chart2/source/inc/TitleHelper.hxx
index 5235752..89e1a7b 100644
--- a/chart2/source/inc/TitleHelper.hxx
+++ b/chart2/source/inc/TitleHelper.hxx
@@ -66,10 +66,21 @@ public:
 , const css::uno::Reference< css::frame::XModel >& xModel
 , const css::uno::Reference< css::uno::XComponentContext > 
& xContext
 , ReferenceSizeProvider * pRefSizeProvider = nullptr );
+static css::uno::Reference<
+css::chart2::XTitle >
+  createOrShowTitle(  eTitleType nTitleIndex
+, const OUString& rTitleText
+, const css::uno::Reference< css::frame::XModel >& xModel
+, const css::uno::Reference< css::uno::XComponentContext > 
& xContext
+, ReferenceSizeProvider * pRefSizeProvider = nullptr );
 
 static void removeTitle( eTitleType nTitleIndex
 , const css::uno::Reference< css::frame::XModel >& xModel 
);
 
+static void hideTitle( eTitleType nTitleIndex
+, const css::uno::Reference< css::frame::XModel >& xModel 
);
+
+
 static OUString getCompleteString( const css::uno::Reference< 
css::chart2::XTitle >& xTitle );
 static void setCompleteString( const OUString& rNewText
 , const css::uno::Reference< css::chart2::XTitle >& xTitle
diff --git a/chart2/source/tools/TitleHelper.cxx 
b/chart2/source/tools/TitleHelper.cxx
index d2adced..7a3290b 100644
--- a/chart2/source/tools/TitleHelper.cxx
+++ b/chart2/source/tools/TitleHelper.cxx
@@ -170,6 +170,26 @@ uno::Reference< XTitle > TitleHelper::getTitle( 
TitleHelper::eTitleType nTitleIn
 return nullptr;
 }
 
+uno::Reference< XTitle > TitleHelper::createOrShowTitle(
+  TitleHelper::eTitleType eTitleType
+, const OUString& rTitleText
+, const uno::Reference< frame::XModel >& xModel
+, const uno::Reference< uno::XComponentContext > & xContext
+, ReferenceSizeProvider * pRefSizeProvider )
+{
+uno::Reference< chart2::XTitle > xTitled( TitleHelper::getTitle( 
eTitleType, xModel ) );
+if( xTitled.is())
+{
+css::uno::Reference xProps(xTitled, 
css::uno::UNO_QUERY_THROW);
+xProps->setPropertyValue("Visible",css::uno::makeAny(true));
+return xTitled;
+}
+else
+{
+return createTitle(eTitleType, rTitleText, xModel, xContext, 
pRefSizeProvider);
+}
+}
+
 uno::Reference< XTitle > TitleHelper::createTitle(
   TitleHelper::eTitleType eTitleType
 , const OUString& rTitleText
@@ -373,6 +393,17 @@ void TitleHelper::removeTitle( TitleHelper::eTitleType 
nTitleIndex
 }
 }
 
+void TitleHelper::hideTitle( TitleHelper::eTitleType nTitleIndex
+, const css::uno::Reference< css::frame::XModel >& xModel )
+{

[Libreoffice-bugs] [Bug 36634] Formula editor becomes slower and slower

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=36634

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #15 from Julien Nabet  ---
Created attachment 124916
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124916=edit
proposed patch

A conflict must be resolved with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99637

Cor Nouws  changed:

   What|Removed |Added

 CC||olivier.hallot@documentfoun
   ||dation.org

--- Comment #13 from Cor Nouws  ---
(In reply to Stanislav Horacek from comment #12)
> My patch puts the info only to the page with the memory options.

Clear - thanks!

> (Maybe it
> would be worth to create a list of all useful expert configuration options.
> Then the info should be at both places I think.)

Indeed. I've no idea if such an effort already exists.
@Olivier: do you know about that?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99718] crash on saving

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99718

georges.guar...@gmail.com changed:

   What|Removed |Added

 CC||georges.guar...@gmail.com

--- Comment #2 from georges.guar...@gmail.com ---
Created attachment 124915
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124915=edit
strace.log

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93487] FORMATTING: Using Borders & Border Style button on toolbar crashes Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93487

--- Comment #35 from Maxim Monastirsky  ---
(In reply to jakub.st from comment #34)
> No, it's not fixed.
> I use Ubuntu 16.04.
> LibreOffice 5.1.2.2 10m0(Build:2)
And the same question again: What _exactly_ isn't fixed? Only the "Border
Style" button or also the "Borders" button?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99637

--- Comment #12 from Stanislav Horacek  ---
My patch puts the info only to the page with the memory options. (Maybe it
would be worth to create a list of all useful expert configuration options.
Then the info should be at both places I think.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99733] CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

--- Comment #1 from mrelw...@yahoo.com ---
Saving the spreadsheet in .xlsx or .ods and restarting LibreOffice doesn't
affect the issue, still crashes the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93487] FORMATTING: Using Borders & Border Style button on toolbar crashes Calc

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93487

--- Comment #34 from jakub...@gmail.com ---
No, it's not fixed.
I use Ubuntu 16.04.
LibreOffice 5.1.2.2 10m0(Build:2)
libreoffice-calc/xenial,now 1:5.1.2-0ubuntu1 amd64 [installed,automatic]
i3 version 4.11 (2015-09-30, branch "4.11") © 2009 Michael Stapelberg and
contributors

all from official repo.

And I know, maybe it's ubuntu fault, but I really don't care. I make bug report
in ubuntu and debian bug trackers and I'm not interested in making reports all
the time.

It's so obvious bug in so popular software (and i3 is quite popular too), that
I lose faith in FLOSS.

I think, that it was fixed in ubuntu 15.10 for some time, but it doesn't
matter.

It hard to believe that there is only one or two person that use Libreoffice
Calc with i3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99637

--- Comment #11 from Cor Nouws  ---
Hi Stanislav,

(In reply to Stanislav Horacek from comment #8)
> Instead of removing the text, I would suggest to add the property name in
> expert config to it (as I did it for some options here:
> https://cgit.freedesktop.org/libreoffice/help/commit/
> ?id=0b72dc634aa155217652973b2e801c42e16631d5). Do you agree?

Thanks. Extending Help for this option is indeed good.
Is that info also seen/linked on the Help page where the other Memory options
are described?

Ciao - Cor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99637] Tools > Options > Memory missing Undo section but listed in help

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99637

--- Comment #10 from Stanislav Horacek  ---
The expert config update submitted to Gerrit:
https://gerrit.libreoffice.org/#/c/24774/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Hackfest at the end of the month in Munich :)

[dennis knorr]

Hi,
if anyone is interested, there is a hackfest at the end of the month
(27-29) at the city of munich which organized by limuxdevs.
Our topics include usually libreoffice, kde and the linux desktop in
generell, but of course we are open to suggestions.
 If you are interested and want to come, insert yourself into
https://wiki.debian.org/BSP/2016/05/de/Munich so we can plan for food
preparations. :-)

See you,
Dennis

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 99733] New: CALC EDITING: Crash when moving range of cells

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99733

Bug ID: 99733
   Summary: CALC EDITING: Crash when moving range of cells
   Product: LibreOffice
   Version: 5.1.0.3 release
  Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mrelw...@yahoo.com

Created attachment 124914
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124914=edit
Select gray cells and move with drag & drop = crash.

ISSUE: Selecting a specific range of cells and moving them by drag & drop
crashes LibreOffice. No matter if I try to move for just one row/column or to
outside the selected region, crash every time.

REPRODUCE: In the sample document, select the gray cells and try to move them
anywhere = crash.

CULPRIT: If I delete any of the remaining calculations at column X
(=SUM(C18:W18)), the crash no longer happens. I was able to remove just one of
them (at row 20) to keep the crash happening, removing any other results in no
crash.


LIBREOFFICE VERSIONS: Crash happens in all LibreOffice versions tested, all on
MacBook Air or Pro, running OSX 10.11.4:

Version: 5.1.0.3
Build ID: 5e3e00a007d9b3b6efb6797a8b8e57b51ab1f737
CPU Threads: 4; OS Version: -; UI Render: default; 
Locale: en-US (en.UTF-8)

Version: 5.1.1.1
Build ID: c43cb650e9c145b181321ea547d38296db70f36e
CPU Threads: 4; OS Version: Mac OS X 10.11.4; UI Render: GL; 
Locale: fi-FI (en.UTF-8)

Version: 5.2.0.0.alpha0+
Build ID: 101e5bbc8aaa77d5db36e0969a512b5a283f1672
CPU Threads: 4; OS Version: Mac OS X 10.11.4; UI Render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-04-18_05:11:03
Locale: fi-FI (en.UTF-8)

Version: 5.2.0.0.alpha1+
Build ID: d223aa57a1d6e356f24cd5ac4ddd702336b2ee87
CPU Threads: 4; OS Version: Mac OS X 10.11.4; UI Render: default; 
TinderBox: MacOSX-x86_64@49-TDF, Branch:master, Time: 2016-05-07_00:24:03
Locale: fi-FI (en.UTF-8)


DUPLICATES: I found two similiar reports on Linux from 2012 (LO 3), but they
were resolved, so this should be a new issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99732] sum('123) = 0 wrong answer without warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99732

--- Comment #1 from Spencer Graves  ---
I tested this with LO 5.1.2.2, 5.0.4.2, and 4.4.0.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99732] New: sum('123) = 0 wrong answer without warning

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99732

Bug ID: 99732
   Summary: sum('123) = 0 wrong answer without warning
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: Other
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: spencer.gra...@effectivedefense.org

Created attachment 124913
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124913=edit
LOcalc sum function treats apparent numbers as 0 if storage is not numeric

c7 = number
c8 displays as a number but is not

c7+c7 gives the anticipated answer 
sum(c7:c8) treats c8 as 0 and gives a wrong answer without warning. 

Sometimes but not always, I see a single quote (') preceding the "number".  In
the attached, I could not see how to fix this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99686] Implement a recovery utility to clear "" from corrupted content.xml in ODF archives

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99686

--- Comment #5 from Maxim Monastirsky  ---
Created attachment 124912
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124912=edit
repaired with tidy

(In reply to shunesburg69 from comment #4)
> No, the formatting stay here just the automatic styles are removed,
But most of the formatting is stored in the automatic styles. I'm attaching a
file repaired with tidy (by simply running "tidy -m -xml content.xml") -
compare it with the same file repaired with your method. It's hard to not
notice the difference...

> but the
> major part of files don't change at all after the repair process.
And yet - why _remove_ valuable data, when it can be easily repaired?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99551] OpenGL: Hang on splash screen

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99551

--- Comment #5 from linus  ---
Can't reproduce with recent master - crash is not in splashscreen, but in
sidebar init code. Any default application or document you get opened? Any
other config, like installed personas etc?

OpenGL is on, config:

direct rendering: Yes
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
GLX_MESA_multithread_makecurrent, GLX_MESA_query_renderer, 
OpenGL renderer string: Gallium 0.4 on AMD PITCAIRN (DRM 2.42.0, LLVM 3.7.0)
GL_ARB_conditional_render_inverted, GL_ARB_conservative_depth, 
GL_NV_conditional_render, GL_NV_depth_clamp, GL_NV_packed_depth_stencil, 
GL_ARB_conditional_render_inverted, GL_ARB_conservative_depth, 
GL_NV_conditional_render, GL_NV_depth_clamp, GL_NV_fog_distance, 
GL_OES_fbo_render_mipmap, GL_OES_get_program_binary, GL_OES_mapbuffer,

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 93967] LibreOffice Crash always after try to save

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=93967

--- Comment #65 from Arnaud Versini  ---
Hi,

The real problem is inside vcl::Window::ImplInit can't create the SalFrame,
throw an exception and this exception leads to a crash. Perhaps we can remove
this check, can't do anything else than crash during destructor if this
exception is thrown.

The exception throwing is here :
http://opengrok.libreoffice.org/xref/core/vcl/source/window/window.cxx#986

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99731] New: UI Exit from Edit Mode stops button from acting.

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99731

Bug ID: 99731
   Summary: UI Exit from Edit Mode stops button from acting.
   Product: LibreOffice
   Version: 5.1.2.2 release
  Hardware: x86-64 (AMD64)
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: mark_t2...@outlook.com

After changing a worksheet back out of edit mode, attempt to operate the button
will fail and the mouse click will only result in selecting the cell below the
button.

Create a new worksheet document with a blank worksheet.

Add a button, using "View", "Toolbars", "Form Controls", select "Push Button"
and draw a button outline on the worksheet. At this point the worksheet is in
design mode. Disable design mode using the button on the Forms control toolbar. 

Operating the button from the mouse click shows the expected visible button
action.

Save the workbook, this seems to be required to show the Edit Mode option.

Select "Edit", note that "Edit Mode" is now active. The button can be selected
for editing but can not be actioned.

Select "Edit", "Edit Mode" to disable edit mode. 

The button can no longer be activated, attempt to click will select the cell in
the sheet behind the button.

When in this mode it's also not possible to enable or disable design mode from
the forms control toolbar, option is greyed out.

Close and re-open the workbook and the button can be activated again.

Also confirmed in 5.2.0.0.alpha1.

Possibly related to 
https://bugs.documentfoundation.org//show_bug.cgi?id=94378

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/inc desktop/qa

[Ashod Nakashian]

 desktop/inc/lib/init.hxx|1 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |   13 +
 2 files changed, 10 insertions(+), 4 deletions(-)

New commits:
commit dc464bdb08cf6a3a3b118245b6eecbda5e94fb42
Author: Ashod Nakashian 
Date:   Sat Apr 23 10:23:48 2016 -0400

Desktop compresses mouse pointer notifications

Change-Id: Id76f4e2952c4c551b626d094c11eb3339d76e50c
Reviewed-on: https://gerrit.libreoffice.org/24319
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit 7c01cf652850a8b8d3fd5ef6eb0a12ca6e725943)
Reviewed-on: https://gerrit.libreoffice.org/24379
Tested-by: Jenkins 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index b887807..df065d7 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -42,6 +42,7 @@ namespace desktop {
 m_states.emplace(LOK_CALLBACK_TEXT_SELECTION, "NIL");
 m_states.emplace(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, "NIL");
 m_states.emplace(LOK_CALLBACK_STATE_CHANGED, "NIL");
+m_states.emplace(LOK_CALLBACK_MOUSE_POINTER, "NIL");
 
 Start();
 }
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 46dde9f..f6e3d91 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1285,12 +1285,14 @@ void DesktopLOKTest::testNotificationCompression()
 handler->queue(LOK_CALLBACK_STATE_CHANGED, ""); // 4
 handler->queue(LOK_CALLBACK_STATE_CHANGED, ".uno:Bold"); // 5
 handler->queue(LOK_CALLBACK_STATE_CHANGED, ""); // 6
-handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 7
+handler->queue(LOK_CALLBACK_MOUSE_POINTER, "text"); // 7
+handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 8
 handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // Should be 
dropped.
+handler->queue(LOK_CALLBACK_MOUSE_POINTER, "text"); // Should be dropped.
 
 Scheduler::ProcessEventsToIdle();
 
-CPPUNIT_ASSERT_EQUAL(static_cast(8), notifs.size());
+CPPUNIT_ASSERT_EQUAL(static_cast(9), notifs.size());
 
 CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, 
(int)std::get<0>(notifs[0]));
 CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[0]));
@@ -1313,8 +1315,11 @@ void DesktopLOKTest::testNotificationCompression()
 CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_STATE_CHANGED, 
(int)std::get<0>(notifs[6]));
 CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[6]));
 
-CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_TILES, 
(int)std::get<0>(notifs[7]));
-CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[7]));
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_MOUSE_POINTER, 
(int)std::get<0>(notifs[7]));
+CPPUNIT_ASSERT_EQUAL(std::string("text"), std::get<1>(notifs[7]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_TILES, 
(int)std::get<0>(notifs[8]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[8]));
 }
 
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99686] Implement a recovery utility to clear "" from corrupted content.xml in ODF archives

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99686

--- Comment #4 from shunesbur...@yahoo.fr ---
No, the formatting stay here just the automatic styles are removed, but the
major part of files don't change at all after the repair process.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

--- Comment #5 from Chris Rossall  ---
Looking at the attached EMF file in a hex viewer, the font name "Calibri" can
be seen several times (in UTF-16).

I have the Calibri font on my system so it doesn't seem to be a matter of a
missing font.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99466] Opening about dialog over ssh -X hangs LibO

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99466

--- Comment #1 from linus  ---
Can't confirm:

Version: 5.0.5.2
Build ID: 00m0(Build:2)
Locale: en-US (en_US.UTF-8)

openSUSE Leap 42.1 x86_64

Also works nicely with recent master build:

Version: 5.2.0.0.alpha1+
Build ID: 0771f36bf5910a8a8103c6575792ca55cf65d5d4
CPU Threads: 4; OS Version: Linux 4.1; UI Render: default; 
Locale: en-US (en_US.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98829] Fatal Error (and exits) after Insert->Special Character...

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=98829

V Stuart Foote  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1
 OS|All |Windows (All)

--- Comment #10 from V Stuart Foote  ---
Looks to be Windows only. Please check if this is affected by method of
launching LibreOffice, e.g. use command line launch of Writer  swriter.exe --
see bug 71603.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48965] FORMATTING: Incorrect alignment of characters from Catalog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48965

robert.funn...@mcgill.ca changed:

   What|Removed |Added

Version|3.5.2 release   |Inherited From OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48965] FORMATTING: Incorrect alignment of characters from Catalog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48965

--- Comment #6 from robert.funn...@mcgill.ca ---
Tested in LO 3.3.0.4, it's the same there so I set as inherited from OOo

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

[Julien Nabet]

 sc/source/filter/xml/xmldrani.cxx|2 --
 sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx |1 -
 sc/source/ui/cctrl/cbuttonw.cxx  |3 +--
 3 files changed, 1 insertion(+), 5 deletions(-)

New commits:
commit de34052e31c6cb6caefe89e52dee3039eb3fbacb
Author: Julien Nabet 
Date:   Sun May 8 17:32:04 2016 +0200

cppcheck: fix some redundantAssignment reports

Change-Id: I8e93fc0bff95c5c7a15ccecaaf19fce12e69ca6d
Reviewed-on: https://gerrit.libreoffice.org/24765
Tested-by: Jenkins 
Reviewed-by: Julien Nabet 

diff --git a/sc/source/filter/xml/xmldrani.cxx 
b/sc/source/filter/xml/xmldrani.cxx
index 476ec86..61e154f 100644
--- a/sc/source/filter/xml/xmldrani.cxx
+++ b/sc/source/filter/xml/xmldrani.cxx
@@ -365,8 +365,6 @@ std::unique_ptr 
ScXMLDatabaseRangeContext::ConvertToDBData(const OUStr
 aParam.bCaseSens = bSubTotalsIsCaseSensitive;
 aParam.bDoSort = bSubTotalsSortGroups;
 aParam.bAscending = bSubTotalsAscending;
-aParam.bUserDef = bSubTotalsEnabledUserList;
-aParam.nUserIndex = nSubTotalsUserListIndex;
 std::vector ::iterator itr = aSubTotalRules.begin(), 
itrEnd = aSubTotalRules.end();
 for (size_t nPos = 0; itr != itrEnd; ++itr, ++nPos)
 {
diff --git a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx 
b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
index e7030b4..bab7391 100644
--- a/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
+++ b/sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx
@@ -1576,7 +1576,6 @@ void ScAccessibleSpreadsheet::NotifyRefMode()
 AccessibleEventObject aEvent;
 aEvent.Source = uno::Reference< XAccessible >(this);
 aEvent.EventId = AccessibleEventId::ACTIVE_DESCENDANT_CHANGED;
-aEvent.Source = uno::Reference< XAccessible >(this);
 aEvent.OldValue <<= 
uno::Reference(m_pAccFormulaCell.get());
 m_pAccFormulaCell = GetAccessibleCellAt(aFormulaAddr.Row(), 
aFormulaAddr.Col());
 uno::Reference< XAccessible > xNew = m_pAccFormulaCell.get();
diff --git a/sc/source/ui/cctrl/cbuttonw.cxx b/sc/source/ui/cctrl/cbuttonw.cxx
index 46ebb21..5a5a700 100644
--- a/sc/source/ui/cctrl/cbuttonw.cxx
+++ b/sc/source/ui/cctrl/cbuttonw.cxx
@@ -62,13 +62,12 @@ void ScDDComboBoxButton::Draw( const Point& rAt,
 boolbOldEnable = pOut->IsMapModeEnabled();
 
 Rectangle   aBtnRect( rAt, rSize );
-Rectangle   aInnerRect = aBtnRect;
 
 pOut->EnableMapMode( false );
 
 DecorationView aDecoView( pOut);
 
-aInnerRect=aDecoView.DrawButton( aBtnRect, DrawButtonFlags::Default );
+Rectangle aInnerRect=aDecoView.DrawButton( aBtnRect, 
DrawButtonFlags::Default );
 
 aInnerRect.Left()   += 1;
 aInnerRect.Top()+= 1;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||filter:emf
 Status|UNCONFIRMED |NEW
 CC||chris.sherloc...@gmail.com,
   ||gti...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92315] Writer renders incorrectly EMF files with text in them

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=92315

V Stuart Foote  changed:

   What|Removed |Added

   Keywords||filter:emf
 CC||vstuart.fo...@utsa.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #4 from V Stuart Foote  ---
Created attachment 124911
  --> https://bugs.documentfoundation.org/attachment.cgi?id=124911=edit
EMF table with errant fonts on printing extracted from Word document

Confirming, Windows print to PCL6 printer, export to PDF, or print to
ghostscript based PDF

On Windows 10 Pro 64-bit en-US with
Version: 5.1.2.2 (x64)
Build ID: d3bf12ecb743fc0d20e0be0c58ca359301eb705f
CPU Threads: 8; OS Version: Windows 6.19; UI Render: default; 
Locale: en-US (en_US)

Issues seems to be with the embedded EMF image, it is a table that views fully
in writer on import. The print preview of the document shows the table fully,
but when printed (or exported to PDF) only a portion of text actually prints.

If exported from Word 2007 to ODF format--the EMF image renders well and prints
in other EMF viewers (Imagamagick, Inkcape, IrfanView) 

Opening just the errant EMF into Draw (attached) it renders to canvas in Draw,
but print preview and print actions have the same missing text in the table.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: lotuswordpro/qa lotuswordpro/source

[Caolán McNamara]

 lotuswordpro/qa/cppunit/data/fail/reference-3.lwp |binary
 lotuswordpro/source/filter/lwptablelayout.cxx |   17 ++---
 2 files changed, 10 insertions(+), 7 deletions(-)

New commits:
commit 4e509d80ee7b22ce0e79d62f7afb7a008726fe5f
Author: Caolán McNamara 
Date:   Sun May 8 17:25:33 2016 +0100

fftester: fail on double parse of the same table

Change-Id: I3e462cdc8812d0ac55d9896d2b04ace34a6c4670

diff --git a/lotuswordpro/qa/cppunit/data/fail/reference-3.lwp 
b/lotuswordpro/qa/cppunit/data/fail/reference-3.lwp
new file mode 100644
index 000..6076b43
Binary files /dev/null and b/lotuswordpro/qa/cppunit/data/fail/reference-3.lwp 
differ
diff --git a/lotuswordpro/source/filter/lwptablelayout.cxx 
b/lotuswordpro/source/filter/lwptablelayout.cxx
index 4eaa7ce..0c8cbb2 100644
--- a/lotuswordpro/source/filter/lwptablelayout.cxx
+++ b/lotuswordpro/source/filter/lwptablelayout.cxx
@@ -754,9 +754,8 @@ void LwpTableLayout::RegisterStyle()
 // so the NULL pointer cause sodc freeze. Add code to check the
 // the pointer.
 //New Code
-if( GetFoundry() && GetTable() )
-
-PutCellVals( GetFoundry(),GetTable()->GetObjectID() );
+if (GetFoundry() && GetTable())
+PutCellVals(GetFoundry(), GetTable()->GetObjectID());
 }
 /**
  * @short   read table layout
@@ -765,11 +764,15 @@ void LwpTableLayout::RegisterStyle()
 void LwpTableLayout::ParseTable()
 {
 // get super table layout
-LwpSuperTableLayout * pSuper = GetSuperTableLayout();
-if(!pSuper)
+LwpSuperTableLayout* pSuper = GetSuperTableLayout();
+if (!pSuper)
 {
-assert(false);
-return;
+throw std::runtime_error("missing super table");
+}
+
+if (m_pXFTable.get())
+{
+throw std::runtime_error("this table is already parsed");
 }
 
 // set name of object
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.0' - desktop/inc desktop/qa

[Ashod Nakashian]

 desktop/inc/lib/init.hxx|   25 +
 desktop/qa/desktop_lib/test_desktop_lib.cxx |7 ++-
 2 files changed, 19 insertions(+), 13 deletions(-)

New commits:
commit 7cdfe080432f69c2247cc7ff28316b653bd654ff
Author: Ashod Nakashian 
Date:   Sun May 8 12:02:54 2016 -0400

LOK: drop identical invalidation notifications

And drop duplicate GRAPHIC_SELECTION notifications.

Change-Id: I0c372efa9a58620e24cea219d82479cdc9dff359
Reviewed-on: https://gerrit.libreoffice.org/24771
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/desktop/inc/lib/init.hxx b/desktop/inc/lib/init.hxx
index e581493..82a01b2 100644
--- a/desktop/inc/lib/init.hxx
+++ b/desktop/inc/lib/init.hxx
@@ -43,6 +43,7 @@ namespace desktop {
 m_states.emplace(LOK_CALLBACK_TEXT_SELECTION_START, "NIL");
 m_states.emplace(LOK_CALLBACK_TEXT_SELECTION_END, "NIL");
 m_states.emplace(LOK_CALLBACK_TEXT_SELECTION, "NIL");
+m_states.emplace(LOK_CALLBACK_GRAPHIC_SELECTION, "NIL");
 m_states.emplace(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, "NIL");
 m_states.emplace(LOK_CALLBACK_STATE_CHANGED, "NIL");
 m_states.emplace(LOK_CALLBACK_MOUSE_POINTER, "NIL");
@@ -85,7 +86,6 @@ namespace desktop {
 return;
 }
 
-
 const std::string payload(data ? data : "(nil)");
 std::unique_lock lock(m_mutex);
 
@@ -124,13 +124,14 @@ namespace desktop {
 case LOK_CALLBACK_TEXT_SELECTION_START:
 case LOK_CALLBACK_TEXT_SELECTION_END:
 case LOK_CALLBACK_TEXT_SELECTION:
+case LOK_CALLBACK_GRAPHIC_SELECTION:
 case LOK_CALLBACK_MOUSE_POINTER:
 case LOK_CALLBACK_CELL_CURSOR:
 case LOK_CALLBACK_CELL_FORMULA:
 case LOK_CALLBACK_CURSOR_VISIBLE:
 case LOK_CALLBACK_SET_PART:
 case LOK_CALLBACK_STATUS_INDICATOR_SET_VALUE:
-removeAllButLast(type);
+removeAllButLast(type, false);
 break;
 
 // These come with rects, so drop earlier
@@ -139,10 +140,15 @@ namespace desktop {
 case LOK_CALLBACK_INVALIDATE_TILES:
 if (payload.empty())
 {
-// Invalidating everything means previous
+// Invalidating everything means previously
 // invalidated tiles can be dropped.
-removeAllButLast(type);
+removeAllButLast(type, false);
+}
+else
+{
+removeAllButLast(type, true);
 }
+
 break;
 }
 
@@ -171,23 +177,26 @@ namespace desktop {
 }
 }
 
-void removeAllButLast(const int type)
+void removeAllButLast(const int type, const bool identical)
 {
 int i = m_queue.size() - 1;
+std::string payload;
 for (; i >= 0; --i)
 {
 if (m_queue[i].first == type)
 {
-//SAL_WARN("idle", "Found [" + std::to_string(type) + "] 
at " + std::to_string(i));
+payload = m_queue[i].second;
+//SAL_WARN("idle", "Found [" + std::to_string(type) + "] 
at " + std::to_string(i) + ": [" + payload + "].");
 break;
 }
 }
 
 for (--i; i >= 0; --i)
 {
-if (m_queue[i].first == type)
+if (m_queue[i].first == type &&
+(!identical || m_queue[i].second == payload))
 {
-//SAL_WARN("idle", "Removing [" + std::to_string(type) + 
"] at " + std::to_string(i));
+//SAL_WARN("idle", "Removing [" + std::to_string(type) + 
"] at " + std::to_string(i) + ": " + m_queue[i].second + "].");
 m_queue.erase(m_queue.begin() + i);
 }
 }
diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 0f8be8f..13382ac 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -812,7 +812,7 @@ void DesktopLOKTest::testNotificationCompression()
 handler->queue(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, ""); // 0
 handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15 25 15 10"); // Superseeded.
 handler->queue(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, ""); // Should be 
dropped.
-handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 1
+handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 
Superseeded.
 

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian]

 loleaflet/src/layer/tile/TileLayer.js |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit f9d7de86dbac428a846e85301e84135635835f59
Author: Ashod Nakashian 
Date:   Sun May 8 11:42:02 2016 -0400

loleaflet: don't show the start/end selection handles for viewers

The handles imply (and indeed are designed for) changing the
selection by dragging them around. Viewers can't change the
selection, so no reason to give them the selection handles either.

Change-Id: Ifa793ac982fd48be877e7ed7709f70890d8de194
Reviewed-on: https://gerrit.libreoffice.org/24770
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index b5d0ecb..09c8c85 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -689,7 +689,7 @@ L.TileLayer = L.GridLayer.extend({
 
_onTextSelectionEndMsg: function (textMsg) {
var strTwips = textMsg.match(/\d+/g);
-   if (strTwips != null) {
+   if (strTwips != null && this._map._editlock) {
var topLeftTwips = new L.Point(parseInt(strTwips[0]), 
parseInt(strTwips[1]));
var offset = new L.Point(parseInt(strTwips[2]), 
parseInt(strTwips[3]));
var bottomRightTwips = topLeftTwips.add(offset);
@@ -704,7 +704,7 @@ L.TileLayer = L.GridLayer.extend({
 
_onTextSelectionStartMsg: function (textMsg) {
var strTwips = textMsg.match(/\d+/g);
-   if (strTwips != null) {
+   if (strTwips != null && this._map._editlock) {
var topLeftTwips = new L.Point(parseInt(strTwips[0]), 
parseInt(strTwips[1]));
var offset = new L.Point(parseInt(strTwips[2]), 
parseInt(strTwips[3]));
var bottomRightTwips = topLeftTwips.add(offset);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/src

[Ashod Nakashian]

 loleaflet/src/control/Parts.js |3 ---
 1 file changed, 3 deletions(-)

New commits:
commit d8f6aa71464e69b585f1d03ccb4583a08a3da2c6
Author: Ashod Nakashian 
Date:   Sun May 8 11:34:34 2016 -0400

loleaflet: remove unnecessary duplicate message

This message is already sent from CalcTilelayer.js.

Change-Id: I9f84d5f365dbfea38061e206d5d52e2201be22ed
Reviewed-on: https://gerrit.libreoffice.org/24769
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/src/control/Parts.js b/loleaflet/src/control/Parts.js
index 8325e7c..79b6bb1 100644
--- a/loleaflet/src/control/Parts.js
+++ b/loleaflet/src/control/Parts.js
@@ -38,9 +38,6 @@ L.Map.include({
if (docLayer._invalidatePreview) {
docLayer._invalidatePreview();
}
-   if (docLayer._docType === 'spreadsheet') {
-   this._socket.sendMessage('commandvalues 
command=.uno:ViewRowColumnHeaders');
-   }
docLayer._drawSearchResuls();
},
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99714] Auto numbering Frames / marginalias

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99714

--- Comment #3 from Hakan  ---
As far as I can see there is another logic behind the numbering frames by using
styles. With this way, you get the ordering reflecting creation time of each
frame.

I have achieved the numbering/ordering corresponding to vertical placement of
the paragraphs/frames in the documents by using increment fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48965] FORMATTING: Incorrect alignment of characters from Catalog

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=48965

robert.funn...@mcgill.ca changed:

   What|Removed |Added

 CC||robert.funn...@mcgill.ca

--- Comment #5 from robert.funn...@mcgill.ca ---
This bug is still present in LO 5.0.1.2 (under MS Windows 7).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

--- Comment #3 from Chris Rossall  ---
It appears the table in question is some kind of embedded image.
When I try and save it the type defaults to WMF - windows metafile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loolwsd/DocumentBroker.cpp loolwsd/LOOLWSD.cpp

[Ashod Nakashian]

 loolwsd/DocumentBroker.cpp |   16 
 loolwsd/LOOLWSD.cpp|   12 
 2 files changed, 16 insertions(+), 12 deletions(-)

New commits:
commit 702dd48f1f7f671d918fbadcf98fb4ae4743dbbe
Author: Ashod Nakashian 
Date:   Sun May 8 10:07:17 2016 -0400

loolwsd: safer document saving

Relying on the filesystem to tell us when the document
was last modified (to decide whether to upload to storage or not,)
proved unreliable.

Now we always upload to storage if there is only one client.
This both minimizes the risk and also avoids the file timestamp
check as a workaround to the problem of re-uploading documents
as many time as there were clients. Since with one client we
can only upload no more than once per save, which is reasonable.

Furthermore, when a client disconnects we auto-save automatically
as a matter of precaution. However, when there are other clients
still connected, we don't wait for the save to complete, rather
we let that job to the very last one.

Change-Id: I94a2e4bddaed30a6c9c0e69f8006667d33c5b8ee
Reviewed-on: https://gerrit.libreoffice.org/24767
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loolwsd/DocumentBroker.cpp b/loolwsd/DocumentBroker.cpp
index 4c8591a..adde590 100644
--- a/loolwsd/DocumentBroker.cpp
+++ b/loolwsd/DocumentBroker.cpp
@@ -177,7 +177,9 @@ bool DocumentBroker::save()
 
 const auto uri = _uriPublic.toString();
 
-// If the file hasn't been modified within the past 10 seconds, skip 
saving.
+// If we aren't potentially destroying just yet, and the file hasn't been
+// modified within the past 10 seconds, skip saving.
+//
 // FIXME this is because currently the ChildProcessSession broadcasts the
 // unocommandresult, so we get called several times here, and have no real
 // possibility to distinguish who was the 1st caller.
@@ -187,10 +189,11 @@ bool DocumentBroker::save()
 // is planned post-release.
 const auto newFileModifiedTime = 
Poco::File(_storage->getLocalRootPath()).getLastModified();
 const auto elapsed = newFileModifiedTime - _lastFileModifiedTime;
-if (std::abs(elapsed) > 10 * 1000 * 1000)
+if (!canDestroy() && std::abs(elapsed) > 10 * 1000 * 1000)
 {
 // Nothing to do.
-Log::debug("Skipping unnecessary saving to URI [" + uri + "].");
+Log::debug() << "Skipping unnecessary saving to URI [" << uri
+ << "]. File last modified " << elapsed << " ms ago." << 
Log::end;
 return true;
 }
 
@@ -502,11 +505,8 @@ bool DocumentBroker::canDestroy()
 {
 std::unique_lock lock(_mutex);
 
-if (_sessions.size() == 1)
-{
-// Last view going away, can destroy.
-_markToDestroy = true;
-}
+// Last view going away, can destroy.
+_markToDestroy = (_sessions.size() <= 1);
 
 return _markToDestroy;
 }
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 37c71a9..25a3801 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -648,15 +648,19 @@ private:
 []() { session->closeFrame(); },
 []() { return TerminationFlag || 
!queueHandlerThread.isRunning(); });
 
-const bool canDestroy = docBroker->canDestroy();
-if (canDestroy && !session->_bLoadError)
+if (!session->_bLoadError)
 {
-Log::info("Shutdown of the last session, saving the document 
before tearing down.");
+// If we are the last, we must wait for the save to complete.
+const bool canDestroy = docBroker->canDestroy();
+if (canDestroy)
+{
+Log::info("Shutdown of the last session, saving the 
document before tearing down.");
+}
 
 // Use auto-save to save only when there are modifications 
since last save.
 // We also need to wait until the save notification reaches us
 // and Storage persists the document.
-if (!docBroker->autoSave(true, COMMAND_TIMEOUT_MS))
+if (!docBroker->autoSave(canDestroy, COMMAND_TIMEOUT_MS))
 {
 Log::error("Auto-save before closing failed.");
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] online.git: loleaflet/dist

[Ashod Nakashian]

 loleaflet/dist/toolbar/toolbar.js |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 3cefa3c6e4d2837ea204f1013ea6891306df0cb5
Author: Ashod Nakashian 
Date:   Sun May 8 10:52:17 2016 -0400

loleaflet: announce the current part after taking editing

Make sure to sync both lokit and viewers as to which
part is being edited when a previously-viewer takes
editing.

Change-Id: Ia70f647a26029447bb4360633f79233fa9596059
Reviewed-on: https://gerrit.libreoffice.org/24768
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 

diff --git a/loleaflet/dist/toolbar/toolbar.js 
b/loleaflet/dist/toolbar/toolbar.js
index fbbaa33..58a6cb5 100644
--- a/loleaflet/dist/toolbar/toolbar.js
+++ b/loleaflet/dist/toolbar/toolbar.js
@@ -280,6 +280,8 @@ function onClick(id) {
else if (id === 'takeedit') {
if (!item.checked) {
map._socket.sendMessage('takeedit');
+   // And advertise which page we're on.
+   map._socket.sendMessage('setclientpart part=' + 
map._docLayer._selectedPart);
}
}
else if (id === 'searchprev') {
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

Chris Rossall  changed:

   What|Removed |Added

Version|5.0.2.2 release |5.0.5.2 release

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: desktop/qa

[Ashod Nakashian]

 desktop/qa/desktop_lib/test_desktop_lib.cxx |   54 
 1 file changed, 54 insertions(+)

New commits:
commit ace0b3bdec391aa170fe95c16a1a5d4a07d052df
Author: Ashod Nakashian 
Date:   Sat Apr 23 09:21:00 2016 -0400

Test desktop notification compression

Reviewed-on: https://gerrit.libreoffice.org/24314
Reviewed-by: Ashod Nakashian 
Tested-by: Ashod Nakashian 
(cherry picked from commit bb52a54aa49cbb75820f8ddbfc8e9e94b63281cd)

Change-Id: Ibb9a62bb5e1500a068c24346d6d433012a1bc7dd
Reviewed-on: https://gerrit.libreoffice.org/24378
Tested-by: Jenkins 
Reviewed-by: Ashod Nakashian 

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx 
b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 5ad6c0d..46dde9f 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -90,6 +90,7 @@ public:
 void testContextMenuCalc();
 void testContextMenuWriter();
 void testContextMenuImpress();
+void testNotificationCompression();
 
 CPPUNIT_TEST_SUITE(DesktopLOKTest);
 CPPUNIT_TEST(testGetStyles);
@@ -115,6 +116,7 @@ public:
 CPPUNIT_TEST(testContextMenuCalc);
 CPPUNIT_TEST(testContextMenuWriter);
 CPPUNIT_TEST(testContextMenuImpress);
+CPPUNIT_TEST(testNotificationCompression);
 CPPUNIT_TEST_SUITE_END();
 
 uno::Reference mxComponent;
@@ -1263,6 +1265,58 @@ void DesktopLOKTest::testContextMenuImpress()
 comphelper::LibreOfficeKit::setActive(false);
 }
 
+static void callbackCompressionTest(const int type, const char* payload, void* 
data)
+{
+std::vector>* notifs = 
reinterpret_cast>*>(data);
+notifs->emplace_back(type, std::string(payload ? payload : "(nil)"));
+}
+
+void DesktopLOKTest::testNotificationCompression()
+{
+std::vector> notifs;
+std::unique_ptr handler(new 
CallbackFlushHandler(callbackCompressionTest, ));
+
+handler->queue(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, ""); // 0
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15 25 15 10"); // 1
+handler->queue(LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, ""); // Should be 
dropped.
+handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 2
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, "15 25 15 10"); // Should be 
dropped.
+handler->queue(LOK_CALLBACK_TEXT_SELECTION, ""); // 3
+handler->queue(LOK_CALLBACK_STATE_CHANGED, ""); // 4
+handler->queue(LOK_CALLBACK_STATE_CHANGED, ".uno:Bold"); // 5
+handler->queue(LOK_CALLBACK_STATE_CHANGED, ""); // 6
+handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // 7
+handler->queue(LOK_CALLBACK_INVALIDATE_TILES, "15 25 15 10"); // Should be 
dropped.
+
+Scheduler::ProcessEventsToIdle();
+
+CPPUNIT_ASSERT_EQUAL(static_cast(8), notifs.size());
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR, 
(int)std::get<0>(notifs[0]));
+CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[0]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION, 
(int)std::get<0>(notifs[1]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[1]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_TILES, 
(int)std::get<0>(notifs[2]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[2]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_TEXT_SELECTION, 
(int)std::get<0>(notifs[3]));
+CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[3]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_STATE_CHANGED, 
(int)std::get<0>(notifs[4]));
+CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[4]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_STATE_CHANGED, 
(int)std::get<0>(notifs[5]));
+CPPUNIT_ASSERT_EQUAL(std::string(".uno:Bold"), std::get<1>(notifs[5]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_STATE_CHANGED, 
(int)std::get<0>(notifs[6]));
+CPPUNIT_ASSERT_EQUAL(std::string(""), std::get<1>(notifs[6]));
+
+CPPUNIT_ASSERT_EQUAL((int)LOK_CALLBACK_INVALIDATE_TILES, 
(int)std::get<0>(notifs[7]));
+CPPUNIT_ASSERT_EQUAL(std::string("15 25 15 10"), std::get<1>(notifs[7]));
+}
+
 CPPUNIT_TEST_SUITE_REGISTRATION(DesktopLOKTest);
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

Chris Rossall  changed:

   What|Removed |Added

   Hardware|All |x86-64 (AMD64)
Version|unspecified |5.0.2.2 release
 OS|All |Windows (All)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99727] Text Disappears when printing word document

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99727

Chris Rossall  changed:

   What|Removed |Added

 Status|NEEDINFO|UNCONFIRMED
 Ever confirmed|1   |0

--- Comment #2 from Chris Rossall  ---
(In reply to Buovjaga from comment #1)
> No problem for me.
> 
> What operating system and what LibreOffice version are you using?
> 
> Set to NEEDINFO.
> Change back to UNCONFIRMED after you have provided the information.
> 
> 64-bit, KDE Plasma 5
> Build ID: 5.1.2.2 Arch Linux build-1
> CPU Threads: 8; OS Version: Linux 4.5; UI Render: default; 
> Locale: fi-FI (fi_FI.UTF-8)

Windows 10 64-bit.
Libre Office
Version: 5.0.5.2 (x64)
Build ID: 55b006a02d247b5f7215fc6ea0fde844b30035b3
Locale: en-US (en_US)

I had the same problem on an earlier version too, 4. something and the problem
still exists in 5.0.2.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99432] =Rows suddenly doesn't work anymore

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=99432

--- Comment #3 from Peter Fackelmann  ---
The problem is solved.
One has to uncheck Prefs-Calc-View-Display Formulas.
In the new v 5.1.2.2 it was checked (not by me!)

Peter Fackelmann

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs