date:20160628

[Libreoffice-bugs] [Bug 100666] New Freeze First Row/Column only works if the first row/ column is visible on the screen.

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100666

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
   Hardware|x86-64 (AMD64)  |All
Summary|New Freeze First Row only   |New Freeze First Row/Column
   |works if the first row is   |only works if the first
   |visible on the screen.  |row/column is visible on
   ||the screen.
 Ever confirmed|0   |1
 OS|Mac OS X (All)  |All

--- Comment #1 from Aron Budea  ---
Indeed, neither of Freeze First Row/Column works if the first row/column is not
visible on screen.

Reproduced with 5.2.0.1 and master builds in Windows 7.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100629] [FILEOPEN]: view of formula from files .doc imports not correctly

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100629

kompilainenn <79045_79...@mail.ru> changed:

   What|Removed |Added

 OS|Linux (All) |All

--- Comment #5 from kompilainenn <79045_79...@mail.ru> ---
(In reply to MM from comment #4)
> Still good in v5.1.4.2 under windows 10 x64 no matter which style / font I
> choose.
> But can confirm with v5.1.4.2 & v5.2.0.1 under ubuntu 16.04 x64. With those
> versions I can see the questionmark.

i reproduce this bug on Windows 7

OS -> all

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 49602] Remove deprecated OSL Profile functionality

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=49602

Tor Lillqvist  changed:

   What|Removed |Added

   Assignee|alfredocol...@gmail.com |libreoffice-b...@lists.free
   ||desktop.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51358] SVG: Add support for more slide transitions to svg documents exported by Impress

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51358

jan iversen  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100668] New: FileOpen: Mulitple instances of soffice.bin

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100668

Bug ID: 100668
   Summary: FileOpen: Mulitple instances of soffice.bin
   Product: LibreOffice
   Version: 5.0.6.3 release
  Hardware: x86-64 (AMD64)
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: andreas.stamp...@artweger.at

LibreOffice 5.0.6, Win 7 PRO SP1 64 Bit, different Hardware and different Users

When we open a LO File, nothing happens. LO will not open. The Taskmanager
shows multiple instances of soffice.exe and soffice.bin. The only way to stop
the hang is to use the Taskmanager and end all these processes. Then i can open
the file i want.
This happens very often.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-28 Thread Stephan Bergmann

 compilerplugins/clang/staticmethods.cxx |  102 +---
 1 file changed, 68 insertions(+), 34 deletions(-)

New commits:
commit 94cba04b33c9be270ee2947f2456d453cf57
Author: Stephan Bergmann 
Date:   Wed Jun 29 07:31:26 2016 +0200

Further clean-up

Change-Id: Id07b37629eb2a0b6d33297bffcf86d41c5d6fbe2

diff --git a/compilerplugins/clang/staticmethods.cxx 
b/compilerplugins/clang/staticmethods.cxx
index c533242..98fca8a 100644
--- a/compilerplugins/clang/staticmethods.cxx
+++ b/compilerplugins/clang/staticmethods.cxx
@@ -107,20 +107,19 @@ bool StaticMethods::TraverseCXXMethodDecl(const 
CXXMethodDecl * pCXXMethodDecl)
 if (aFilename == SRCDIR "/include/svl/svdde.hxx") {
 return true;
 }
-std::string aParentName = 
pCXXMethodDecl->getParent()->getQualifiedNameAsString();
+auto cdc = loplugin::DeclCheck(pCXXMethodDecl->getParent());
 // special case having something to do with static initialisation
 // sal/osl/all/utility.cxx
-if (aParentName == "osl::OGlobalTimer") {
+if (cdc.Class("OGlobalTimer").Namespace("osl").GlobalNamespace()) {
 return true;
 }
 // leave the TopLeft() method alone for consistency with the other 
"corner" methods
-if (aParentName == "BitmapInfoAccess") {
+if (cdc.Class("BitmapInfoAccess").GlobalNamespace()) {
 return true;
 }
-auto dc = loplugin::DeclCheck(pCXXMethodDecl->getParent());
 // in this case, the code is taking the address of the member function
 // shell/source/unix/sysshell/recently_used_file_handler.cxx
-if (dc.Struct("recently_used_item").AnonymousNamespace().GlobalNamespace())
+if 
(cdc.Struct("recently_used_item").AnonymousNamespace().GlobalNamespace())
 {
 return true;
 }
@@ -139,53 +138,88 @@ bool StaticMethods::TraverseCXXMethodDecl(const 
CXXMethodDecl * pCXXMethodDecl)
 return true;
 }
 // classes that have static data and some kind of weird reference-counting 
trick in its constructor
-if (aParentName == "LinguOptions" || aParentName == 
"svtools::EditableExtendedColorConfig"
-|| aParentName == "svtools::ExtendedColorConfig" || aParentName == 
"SvtMiscOptions"
-|| aParentName == "SvtAccessibilityOptions" || aParentName == 
"svtools::ColorConfig"
-|| aParentName == "SvtOptionsDrawinglayer" || aParentName == 
"SvtMenuOptions"
-|| aParentName == "SvtToolPanelOptions" || aParentName == 
"SvtSlideSorterBarOptions"
-|| aParentName == "connectivity::SharedResources"
-|| aParentName == "svxform::OParseContextClient"
-|| aParentName == "frm::OLimitedFormats" )
+if (cdc.Class("LinguOptions").GlobalNamespace()
+|| (cdc.Class("EditableExtendedColorConfig").Namespace("svtools")
+.GlobalNamespace())
+|| (cdc.Class("ExtendedColorConfig").Namespace("svtools")
+.GlobalNamespace())
+|| cdc.Class("SvtMiscOptions").GlobalNamespace()
+|| cdc.Class("SvtAccessibilityOptions").GlobalNamespace()
+|| cdc.Class("ColorConfig").Namespace("svtools").GlobalNamespace()
+|| cdc.Class("SvtOptionsDrawinglayer").GlobalNamespace()
+|| cdc.Class("SvtMenuOptions").GlobalNamespace()
+|| cdc.Class("SvtToolPanelOptions").GlobalNamespace()
+|| cdc.Class("SvtSlideSorterBarOptions").GlobalNamespace()
+|| (cdc.Class("SharedResources").Namespace("connectivity")
+.GlobalNamespace())
+|| (cdc.Class("OParseContextClient").Namespace("svxform")
+.GlobalNamespace())
+|| cdc.Class("OLimitedFormats").Namespace("frm").GlobalNamespace())
 {
 return true;
 }
-std::string fqn = aParentName + "::" + pCXXMethodDecl->getNameAsString();
+auto fdc = loplugin::DeclCheck(pCXXMethodDecl);
 // only empty on Linux, not on windows
-if (fqn == "OleEmbeddedObject::GetVisualRepresentationInNativeFormat_Impl"
-|| fqn == "OleEmbeddedObject::GetRidOfComponent"
-|| fqn == "connectivity::mozab::ProfileAccess::isProfileLocked"
-|| startsWith(fqn, "SbxDecimal::")
-|| fqn == "SbiDllMgr::Call" || fqn == "SbiDllMgr::FreeDll"
-|| fqn == "SfxApplication::InitializeDde" || fqn == 
"SfxApplication::RemoveDdeTopic"
-|| fqn == "ScannerManager::ReleaseData") {
+if ((fdc.Function("GetVisualRepresentationInNativeFormat_Impl")
+ .Class("OleEmbeddedObject").GlobalNamespace())
+|| (fdc.Function("GetRidOfComponent").Class("OleEmbeddedObject")
+.GlobalNamespace())
+|| (fdc.Function("isProfileLocked").Class("ProfileAccess")
+.Namespace("mozab").Namespace("connectivity").GlobalNamespace())
+|| cdc.Class("SbxDecimal").GlobalNamespace()
+|| fdc.Function("Call").Class("SbiDllMgr").GlobalNamespace()
+|| fdc.Function("FreeDll").Class("SbiDllMgr").GlobalNamespace()
+||

GSoC Week 5

2016-06-28 Thread Akash Jain

Hi,

In week 5 I finished integrating the new layout engine in the unx/
path. Integration in the windows code path is also almost complete. I
continue to work on this in this week.

Regards,
Akash
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100658] Crash printer properties - resolved in 5.1.4

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100658

Julien Nabet  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #3 from Julien Nabet  ---
Thank you for your feedback.
Let's put this one to WFM then.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95797] Current display of the document moves away (jumps) when saving or when autorecovery information is saved

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95797

Aron Budea  changed:

   What|Removed |Added

 CC||rich.r...@gmail.com

--- Comment #15 from Aron Budea  ---
*** Bug 100667 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100667] auto save loses scroll position

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100667

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||ba...@caesar.elte.hu
 Resolution|--- |DUPLICATE

--- Comment #1 from Aron Budea  ---
Thanks for the report. This bug has already been fixed, and will be part of
5.2. The fix is not yet ported to 5.1, but I assume it's going to happen soon.
See bug 95797.

*** This bug has been marked as a duplicate of bug 95797 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100667] New: auto save loses scroll position

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100667

Bug ID: 100667
   Summary: auto save loses scroll position
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: rcr...@yahoo.com

User-Agent:   Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/51.0.2704.103 Safari/537.36
Build Identifier: LibreOffice 5.0.6.3

steps to recreate:

Expected:



Reproducible: Always

Steps to Reproduce:
1. settings: set autosave on at interval of n
2. use scroll wheel to scroll down any amount in a long document without
anchoring the cursor in the newly scrolled-down viewing position.
3. autosave does a document save and reverts the view to the cursor position.
Actual Results:  
I lose my place, particularly when reviewing, editing, or proofreading
documents because the cursor position and the view position may be several
pages apart.

Expected Results:  
Leave the view as is on autosave, disregarding the cursor position so that I do
not lose my place every n minutes where n=autosave interval.  

partial workaround is to either anchor the cursor every time you scroll or
maybe use pg up and down instead.  Page up and down seem to not be affected,
though not sure about that.  neither of these is very helpful since for me
scrolling is the way I keep my place while proofing documents.  

[Information automatically included from LibreOffice]
Locale: en-US
Module: TextDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes


Reset User Profile?No

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100663] HLOOKUP returns wrong value

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100663

Prasad  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |---
 Ever confirmed|0   |1

--- Comment #2 from Prasad  ---
Firstly the 4th parameter is optional, so it should not be of significance. 

Secondly, the function is returning wrong values all over. Its returning a
value for a search criterion which is not in the array. Kindly see the excel
sheet attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99134] Background in text boxes is not refreshing

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99134

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||736

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99736] characters overlaid in controls

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99736

Aron Budea  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=99
   ||134

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99736] characters overlaid in controls

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99736

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #3 from Aron Budea  ---
Thanks for looking into this bug in more detail. While unfortunately it wasn't
followed up on, there's bug 99134, which appears to be the same issue, and the
bug seems to be gone now. Please verify with 5.2.0.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100666] New: New Freeze First Row only works if the first row is visible on the screen.

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100666

Bug ID: 100666
   Summary: New Freeze First Row only works if the first row is
visible on the screen.
   Product: LibreOffice
   Version: 5.2.0.1 rc
  Hardware: x86-64 (AMD64)
OS: Mac OS X (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: t...@tim-richardson.net

If I am in row 5000 of a spreadsheet and choose Freeze First Row, nothing
happens.
If I scroll to the top of the spreadsheet and choose Freeze First Row, the
first row freezes.

I would expect the first row to freeze and become visible when I execute freeze
first row, regardless of where I am in the spreadsheet.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100660] Starting document from a template crashes LibreOffice

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100660

--- Comment #5 from Commit Notification 
 ---
Akshay Deep committed a patch related to this issue.
It has been pushed to "master":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=58f578263022e9fda5c235f09f88ec02e15965a9

tdf#100660 - Starting document from a template crashes LibreOffice

It will be available in 5.3.0.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100660] Starting document from a template crashes LibreOffice

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100660

Commit Notification  changed:

   What|Removed |Added

 Whiteboard||target:5.3.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sfx2/source

2016-06-28 Thread Akshay Deep

 sfx2/source/doc/templatedlg.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 58f578263022e9fda5c235f09f88ec02e15965a9
Author: Akshay Deep 
Date:   Wed Jun 29 08:09:35 2016 +0530

tdf#100660 - Starting document from a template crashes LibreOffice

Change-Id: Ida89fa8d35d1e22c706bc3703d2397b572bc01b5
Reviewed-on: https://gerrit.libreoffice.org/26752
Reviewed-by: Akshay Deep 
Tested-by: Akshay Deep 

diff --git a/sfx2/source/doc/templatedlg.cxx b/sfx2/source/doc/templatedlg.cxx
index 1f97776..5973eb0 100644
--- a/sfx2/source/doc/templatedlg.cxx
+++ b/sfx2/source/doc/templatedlg.cxx
@@ -154,7 +154,8 @@ static bool cmpSelectionItems (const ThumbnailViewItem 
*pItem1, const ThumbnailV
 
 SfxTemplateManagerDlg::SfxTemplateManagerDlg(vcl::Window *parent)
 : ModalDialog(parent, "TemplateDialog", "sfx/ui/templatedlg.ui"),
-  maSelTemplates(cmpSelectionItems)
+  maSelTemplates(cmpSelectionItems),
+  mxDesktop( Desktop::create(comphelper::getProcessComponentContext()) )
 {
 get(mpSearchFilter, "search_filter");
 get(mpCBApp, "filter_application");
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100660] Starting document from a template crashes LibreOffice

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100660

--- Comment #4 from Akshay Deep  ---
@Julien, cor: Looks like I accidentally removed a line of code

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: starmath/source

2016-06-28 Thread Takeshi Abe

 starmath/source/node.cxx |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit f6c004800a73059eea5267f58bdac118e7a37656
Author: Takeshi Abe 
Date:   Tue Jun 28 14:33:24 2016 +0900

starmath: SmBinDiagonalNode's 3rd child must be SmPolyLineNode

Change-Id: If3b81de299eca8b398a65534d1b201bf38daf19f
Reviewed-on: https://gerrit.libreoffice.org/26733
Tested-by: Jenkins 
Reviewed-by: Takeshi Abe 

diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index 8300752..fa0c748 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -1144,12 +1144,13 @@ void SmBinDiagonalNode::Arrange(OutputDevice , 
const SmFormat )
 // Both arguments have to get into the SubNodes before the Operator so 
that clicking
 // within the GraphicWindow sets the FormulaCursor correctly (cf. 
SmRootNode)
 SmNode *pLeft  = GetSubNode(0),
-   *pRight = GetSubNode(1);
+   *pRight = GetSubNode(1),
+   *pLine  = GetSubNode(2);
 assert(pLeft);
 assert(pRight);
+assert(pLine && pLine->GetType() == NPOLYLINE);
 
-OSL_ENSURE(GetSubNode(2)->GetType() == NPOLYLINE, "Sm : wrong node type");
-SmPolyLineNode *pOper = static_cast(GetSubNode(2));
+SmPolyLineNode *pOper = static_cast(pLine);
 assert(pOper);
 
 //! some routines being called extract some info from the OutputDevice's
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 98454] Visual corruption when viewing a document in web view, help documentation, and text based controls

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98454

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1

--- Comment #3 from Aron Budea  ---
Does the visual corruption still occur in 5.2.0.1?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98001] File/New, Recent documents, Wizards cannot be disabled

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98001

Aron Budea  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||ba...@caesar.elte.hu
 Ever confirmed|0   |1
 Whiteboard|target:5.0.6|target:5.0.6
   ||backportRequest:5.1

--- Comment #4 from Aron Budea  ---
So, it seems to work in 5.2.0.1, but not in 5.1.4.2, so it's not yet in 5.1.
I also noticed in 5.2.0.1, File->New doesn't get enabled after Undo, not sure
why that is.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99882] Visual artifact when tables are moved system-driven

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99882

--- Comment #8 from Aron Budea  ---
(In reply to Heiko Tietze from comment #7)
> ESC decision. Bug 48015, comment 12 and following for more infos.

I see, that's good to know, thanks for the reply.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 71251] EDITING - Embedded Firebird - Creating table from default choices via wizard fails

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=71251

Lionel Elie Mamane  changed:

   What|Removed |Added

 CC||btom...@gmail.com

--- Comment #18 from Lionel Elie Mamane  ---
The problem with BOOLEAN will be made obsolete by the upgrade to Firebird 3, so
most of the discussion in this bug is moot.

If there are other things that keep the default wizard option from succeeding,
then they need to be fixed separately. I suggest to use this bug as a tracker
bug and to open new bugs for each issue, and add them to this bug's "depends
on".

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51780

Lionel Elie Mamane  changed:

   What|Removed |Added

 Depends on||91324


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=91324
[Bug 91324] Embedded Firebird - Current_Date gives wrong date back
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 91324] Embedded Firebird - Current_Date gives wrong date back

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=91324

Lionel Elie Mamane  changed:

   What|Removed |Added

 Blocks||51780


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=51780
[Bug 51780] default to Firebird not HSQLDB in Base
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100658] Crash printer properties - resolved in 5.1.4

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100658

Ulrich Hpfer  changed:

   What|Removed |Added

Summary|Crash printer properties|Crash printer properties -
   ||resolved in 5.1.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100658] Crash printer properties

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100658

--- Comment #2 from Ulrich Hpfer  ---
Problem resolved in version 5.1.4.  Thanks for the help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes25' - 3 commits -

2016-06-28 Thread László Németh

 0 files changed

New commits:
commit e3913df7fe9dc1941eb401a139abf17f7cf42007
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Wed Jun 29 03:04:48 2016 +0200

empty commit (repeat)

Change-Id: I155b146dc7013e7daa680da0f774fc19d95346ff
commit 93dbbcf8c91015fa0b36b7920d94086e0a73fa55
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Wed Jun 29 03:04:40 2016 +0200

empty commit (repeat)

Change-Id: I76170788979709557248717f0f67624b85983499
commit e7d3e676612242387fd8c95e79f7e2ce027e1486
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Wed Jun 29 03:03:42 2016 +0200

empty commit (base new doc)

Change-Id: I289784e9fc54f29f4fc0c4c0861c337fd5bdbcf4
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100626] SID_NEWDOCDIRECT / .uno: AddDirect assigned N_MOD1 and File menu action, opens a new document but does not direct edit cursor focus into the document

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

--- Comment #11 from V Stuart Foote  ---
(In reply to Aron Budea from comment #10)
> My curious observations after opening Start Center:
> 
> -I can't reproduce the issue by repeating Stuart's steps from Comment 3
> (Alt+F, N, T),
> 
> -if I do nothing else, but press Ctrl+N right after launch, nothing happens,
> I have to Alt+Tab out and back, or click in the window, and then Ctrl+N
> opens new document.

The +N shortcuts have been disrupted by work on the  accelerator
toggle for GTK3.

But, you can see this issue with the .uno:AddDirect if as the OP reported, you
launch Writer from StartCenter on its initial launch--then open a second Writer
instance with the +N shortcut (or the File -> New -> Document menu).

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Joel Madero  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #4 from Joel Madero  ---
I'll try to build again and see what happens.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99882] Visual artifact when tables are moved system-driven

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99882

--- Comment #7 from Heiko Tietze  ---
(In reply to Aron Budea from comment #6)
> Heiko, NEEDINFO [1] is for the reporter to provide more information, and I
> don't think they can help with code pointers.

ESC decision. Bug 48015, comment 12 and following for more infos.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #15 from Joel Madero  ---
(In reply to jan iversen from comment #14)
> (In reply to Joel Madero from comment #13)
> > Okay - I don't follow any of those decisions any more. Couple notes then:
> > 
> > 1) ESC or someone else should figure out what to do about needsDevEval
> > (which again is literally the exact same thing in this case); 
> 
> Actually not, only for easyhacks. When I look at bugs with needsDevEval
> there are typically questions about more than just code pointers.

Hm - no idea. I know that when needsDevEval was proposed it was meant to
replace propsedEasyHackif it's not being used that way, I have no idea.


> > 2) Markus before was really against using any other term that had "easyhack"
> > in it because searches become difficult so again, ESC should deal with it.
> The much simpler solution is to remove easyhack, after having monitored
> easyhacks closely for half a year, it is my experience that code pointers
> are very seldomly added later (see the current NEEDINFO and how old they are)

That's not my call to make. If easyHacks are leaving, then so be it ;) You and
ESC can make that call. I suspect some advocates won't be happy.

> > 
> > My guess is lots and lots of bugs will be inadvertently closed with this
> > method but that's no longer my issue.
> lots and lots is a bit high, we have at the moment ca. 15 issues missing
> code pointer.

Fair

> And if a code pointer is not supplied in 7 month, why should it be supplied
> later.

The problem is that these bugs are entirely valid but will be closed as INVALID
if they go to NEEDINFO and sit there for 7 months. So, the bugs are
inappropriately closed as INVALID (because they are entirely valid) they just
don't have code pointers.

> 
> Adding more keywords like proposed_easyhacks just means more maintenance and
> complexer searchs, but I am quite indifferent as long as we have a fixed
> definition.

I didn't say anything about adding new keywords - I said we have one already
that at least in theory should be used for (see
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Keywords#needsDevEval)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #15 from Joel Madero  ---
(In reply to jan iversen from comment #14)
> (In reply to Joel Madero from comment #13)
> > Okay - I don't follow any of those decisions any more. Couple notes then:
> > 
> > 1) ESC or someone else should figure out what to do about needsDevEval
> > (which again is literally the exact same thing in this case); 
> 
> Actually not, only for easyhacks. When I look at bugs with needsDevEval
> there are typically questions about more than just code pointers.

Hm - no idea. I know that when needsDevEval was proposed it was meant to
replace propsedEasyHackif it's not being used that way, I have no idea.


> > 2) Markus before was really against using any other term that had "easyhack"
> > in it because searches become difficult so again, ESC should deal with it.
> The much simpler solution is to remove easyhack, after having monitored
> easyhacks closely for half a year, it is my experience that code pointers
> are very seldomly added later (see the current NEEDINFO and how old they are)

That's not my call to make. If easyHacks are leaving, then so be it ;) You and
ESC can make that call. I suspect some advocates won't be happy.

> > 
> > My guess is lots and lots of bugs will be inadvertently closed with this
> > method but that's no longer my issue.
> lots and lots is a bit high, we have at the moment ca. 15 issues missing
> code pointer.

Fair

> And if a code pointer is not supplied in 7 month, why should it be supplied
> later.

The problem is that these bugs are entirely valid but will be closed as INVALID
if they go to NEEDINFO and sit there for 7 months. So, the bugs are
inappropriately closed as INVALID (because they are entirely valid) they just
don't have code pointers.

> 
> Adding more keywords like proposed_easyhacks just means more maintenance and
> complexer searchs, but I am quite indifferent as long as we have a fixed
> definition.

I didn't say anything about adding new keywords - I said we have one already
that at least in theory should be used for (see
https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Keywords#needsDevEval)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 100626] SID_NEWDOCDIRECT / .uno: AddDirect assigned N_MOD1 and File menu action, opens a new document but does not direct edit cursor focus into the document

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100626

--- Comment #10 from Aron Budea  ---
My curious observations after opening Start Center:

-I can't reproduce the issue by repeating Stuart's steps from Comment 3 (Alt+F,
N, T),

-if I do nothing else, but press Ctrl+N right after launch, nothing happens, I
have to Alt+Tab out and back, or click in the window, and then Ctrl+N opens new
document.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 99882] Visual artifact when tables are moved system-driven

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=99882

--- Comment #6 from Aron Budea  ---
Heiko, NEEDINFO [1] is for the reporter to provide more information, and I
don't think they can help with code pointers.

[1] https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100665] New: FORMATTING/SIDEBAR: UI issues with Presentation Styles

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100665

Bug ID: 100665
   Summary: FORMATTING/SIDEBAR: UI issues with Presentation Styles
   Product: LibreOffice
   Version: 4.2.8.2 release
  Hardware: x86-64 (AMD64)
OS: Linux (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Impress
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: tmchartr...@gmail.com

Bug 1:
Create new blank impress document. 
Open Styles and Formatting sidebar.
Select a Presentation Style (eg Title).
Select Fill Format Mode.
ISSUE: the cursor does not change, Fill format mode is not active.

Bug 2:
Create a new shape object.
In Styles and Formatting pane, switch to Presentation Styles
ISSUE: New Style From Selection allows user to create a new Presentation Style,
which should be impossible and causes issues from Bug 1 when user tries to
apply it.

Bug 3:
With Presentation Styles still open, deselect and then select the new shape
object.
ISSUE: Although shape object has default formatting, the Styles and Formatting
pane doesn't switch to Drawing Object styles to show the default style. (This
only occurs if user manually switched to Presentation Styles previously)

Fixes:
It seems that Fill format mode and New style from selection are not intended as
an option for Presentation styles, and should be greyed out. The manual says
these styles are intended only for use by AutoLayouts, although I'm not sure
why that should rule out using Fill Format with them.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #14 from jan iversen  ---
(In reply to Joel Madero from comment #13)
> Okay - I don't follow any of those decisions any more. Couple notes then:
> 
> 1) ESC or someone else should figure out what to do about needsDevEval
> (which again is literally the exact same thing in this case); 

Actually not, only for easyhacks. When I look at bugs with needsDevEval there
are typically questions about more than just code pointers.


> 2) Markus before was really against using any other term that had "easyhack"
> in it because searches become difficult so again, ESC should deal with it.
The much simpler solution is to remove easyhack, after having monitored
easyhacks closely for half a year, it is my experience that code pointers are
very seldomly added later (see the current NEEDINFO and how old they are)
> 
> My guess is lots and lots of bugs will be inadvertently closed with this
> method but that's no longer my issue.
lots and lots is a bit high, we have at the moment ca. 15 issues missing code
pointer.

And if a code pointer is not supplied in 7 month, why should it be supplied
later.


Adding more keywords like proposed_easyhacks just means more maintenance and
complexer searchs, but I am quite indifferent as long as we have a fixed
definition.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #14 from jan iversen  ---
(In reply to Joel Madero from comment #13)
> Okay - I don't follow any of those decisions any more. Couple notes then:
> 
> 1) ESC or someone else should figure out what to do about needsDevEval
> (which again is literally the exact same thing in this case); 

Actually not, only for easyhacks. When I look at bugs with needsDevEval there
are typically questions about more than just code pointers.


> 2) Markus before was really against using any other term that had "easyhack"
> in it because searches become difficult so again, ESC should deal with it.
The much simpler solution is to remove easyhack, after having monitored
easyhacks closely for half a year, it is my experience that code pointers are
very seldomly added later (see the current NEEDINFO and how old they are)
> 
> My guess is lots and lots of bugs will be inadvertently closed with this
> method but that's no longer my issue.
lots and lots is a bit high, we have at the moment ca. 15 issues missing code
pointer.

And if a code pointer is not supplied in 7 month, why should it be supplied
later.


Adding more keywords like proposed_easyhacks just means more maintenance and
complexer searchs, but I am quite indifferent as long as we have a fixed
definition.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Cor Nouws  changed:

   What|Removed |Added

 CC||c...@nouenoff.nl

--- Comment #3 from Cor Nouws  ---
No repro in Version: 5.3.0.0.alpha0+
Build ID: e74382fd6385138b164df5e4f93a0e7df2857f2c
CPU Threads: 2; OS Version: Linux 4.4; UI Render: GL (or Default); 
TinderBox: Linux-rpm_deb-x86@71-TDF, Branch:master, Time: 2016-06-28_00:20:24
Locale: nl-NL (nl_NL.UTF-8)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100629] [FILEOPEN]: view of formula from files .doc imports not correctly

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100629

MM  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
 OS|Windows (All)   |Linux (All)

--- Comment #4 from MM  ---
Still good in v5.1.4.2 under windows 10 x64 no matter which style / font I
choose.
But can confirm with v5.1.4.2 & v5.2.0.1 under ubuntu 16.04 x64. With those
versions I can see the questionmark.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100658] Crash printer properties

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100658

Julien Nabet  changed:

   What|Removed |Added

   Keywords||wantBacktrace
 Status|UNCONFIRMED |NEEDINFO
 CC||serval2...@yahoo.fr
 Ever confirmed|0   |1

--- Comment #1 from Julien Nabet  ---
Could you try 2 things:
1) Rename your LO directory profile (see
https://wiki.documentfoundation.org/UserProfile#Windows)
2) Upgrade to last stable version 5.1.4
?

If you still reproduce this, you can try to retrieve a backtrace (see
https://wiki.documentfoundation.org/QA/BugReport/Debug_Information#Windows:_How_to_get_a_backtrace),
it might help to pinpoint the root cause of the crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100624] number keypad not working

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100624

V Stuart Foote  changed:

   What|Removed |Added

 Resolution|FIXED   |NOTABUG

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100647] The "Bookmark" dialog is broken for modifying existing bookmarks

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100647

--- Comment #4 from V Stuart Foote  ---
Created attachment 125972
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125972=edit
a test ODT with four bookmarks

Another dummy text based document with four bookmarks set, bm1 - bm4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100660] Starting document from a template crashes LibreOffice

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100660

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace
   Priority|medium  |high
 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1
   Severity|normal  |major

--- Comment #3 from Julien Nabet  ---
Akshay: perhaps it's a regression from
https://cgit.freedesktop.org/libreoffice/core/commit/?id=77725bf4df6e9cf63469c1d7fea339575b5e
?
indeed nothing replaced this:
mxDesktop( Desktop::create(comphelper::getProcessComponentContext()) ),
so mxDesktop must be empty ref.
Any thoughts?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'feature/fixes25' - 3 commits -

2016-06-28 Thread László Németh

 0 files changed

New commits:
commit dc90a715e52b27c5ae96e0bb3f2615f247aa5acc
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Tue Jun 28 23:13:01 2016 +0200

empty commit (repeat)

Change-Id: I1cc0076e83b3ab6b5cb33a8aa34e7dae10e7bf90
commit 6ebc7c14451a057ebdc965fdd95ab145ffaee3d1
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Tue Jun 28 23:12:53 2016 +0200

empty commit (repeat)

Change-Id: I2c3359ce70d6a9669641484bd7248ee95b16ac8f
commit 06ab1ca1c16b3f8fb8e22fb33c4ca7da9fbb3b19
Author: LÃ¡szlÃ³ NÃ©meth 
Date:   Tue Jun 28 23:11:07 2016 +0200

empty commit (no proc. idle)

Change-Id: I9785b06e2e36b3636e51115b28c1b87062a84167
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100647] The "Bookmark" dialog is broken for modifying existing bookmarks

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100647

--- Comment #3 from V Stuart Foote  ---
(In reply to V Stuart Foote from comment #2)
> Only visual glitch is that if using the Status bar page field -> Right mouse
> context menu, edit cursor is directed to the bookmarks but cursor is not
> visible. Need to F10 to the main menu and F10 back into the document to
> expose the edit cursor.

That visual glitch in the Status bar page field is not present in
Version: 5.0.6.2
Build ID: 5.0.6.2-7.fc23
Locale: en-US (en_US.UTF-8)

Which has the old Bookmark dialog preceding bug 90855 enhancement, with no real
indication they are related.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2016-06-28 Thread Eike Rathke

 sc/source/core/tool/interpr1.cxx |   10 +++---
 1 file changed, 7 insertions(+), 3 deletions(-)

New commits:
commit ae51f416fa375ad86e1836c1ad03b5da2c551fe5
Author: Eike Rathke 
Date:   Tue Jun 28 23:10:18 2016 +0200

identify boolean element type at least for inline arrays (i#87219)

Since 23e5540a05e940cb4a591815e6b85a485b01fc32 we can use
GetDoubleOrStringFromMatrix() and check for SC_MATVAL_BOOLEAN.
Only if transported of course..
If not, then even a {FALSE,FALSE,FALSE,...} result is better than the 
previous
{FALSE,TRUE,TRUE,...} for any array sequence where all TRUE results resulted
from the previous call to ISLOGICAL() ...

Change-Id: I879e0cbc6557e73ac24713267b5122f923500501

diff --git a/sc/source/core/tool/interpr1.cxx b/sc/source/core/tool/interpr1.cxx
index 76f807d..5b18611 100644
--- a/sc/source/core/tool/interpr1.cxx
+++ b/sc/source/core/tool/interpr1.cxx
@@ -1960,9 +1960,13 @@ void ScInterpreter::ScIsLogical()
 }
 break;
 case svMatrix:
-// TODO: we don't have type information for arrays except
-// numerical/string.
-// Fall through
+{
+double fVal;
+svl::SharedString aStr;
+ScMatValType nMatValType = GetDoubleOrStringFromMatrix( fVal, 
aStr);
+bRes = (nMatValType == SC_MATVAL_BOOLEAN);
+}
+break;
 default:
 PopError();
 if ( !nGlobalError )
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100624] number keypad not working

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100624

Charles Pederson  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Charles Pederson  ---
This was not a bug in LiberOffice,  Tis was a problem with Windows 10.
Thanks for trying to help.
Charlie

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100647] The "Bookmark" dialog is broken for modifying existing bookmarks

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100647

--- Comment #2 from V Stuart Foote  ---
On Fedora 23 64-bit with LXDE and current master
Version: 5.3.0.0.alpha0+
Build ID: f07aa1136ee68329a2b5f7cb88d2a8b5c83f474b
CPU Threads: 1; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-06-28_01:15:53
Locale: en-US (en_US.UTF-8)

Could not reproduce. The Bookmark dialog allows selection and rename/delete of
the Bookmarks as well as navigation with the Go to button action.

Only visual glitch is that if using the Status bar page field -> Right mouse
context menu, edit cursor is directed to the bookmarks but cursor is not
visible. Need to F10 to the main menu and F10 back into the document to expose
the edit cursor.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100660] Starting document from a template crashes LibreOffice

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100660

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #2 from Julien Nabet  ---
Created attachment 125971
  --> https://bugs.documentfoundation.org/attachment.cgi?id=125971=edit
bt with symbols

On pc Debian x86-64 with master sources updated today, I could reproduce this.
(612ebb9b972fde18b1492b601116a8c03adb2912)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #13 from Joel Madero  ---
Okay - I don't follow any of those decisions any more. Couple notes then:

1) ESC or someone else should figure out what to do about needsDevEval (which
again is literally the exact same thing in this case); 
2) Markus before was really against using any other term that had "easyhack" in
it because searches become difficult so again, ESC should deal with it.

My guess is lots and lots of bugs will be inadvertently closed with this method
but that's no longer my issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

--- Comment #13 from Joel Madero  ---
Okay - I don't follow any of those decisions any more. Couple notes then:

1) ESC or someone else should figure out what to do about needsDevEval (which
again is literally the exact same thing in this case); 
2) Markus before was really against using any other term that had "easyhack" in
it because searches become difficult so again, ESC should deal with it.

My guess is lots and lots of bugs will be inadvertently closed with this method
but that's no longer my issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sc/source

2016-06-28 Thread Eike Rathke

 sc/source/core/tool/interpr4.cxx |   15 +--
 1 file changed, 5 insertions(+), 10 deletions(-)

New commits:
commit 23e5540a05e940cb4a591815e6b85a485b01fc32
Author: Eike Rathke 
Date:   Tue Jun 28 23:01:05 2016 +0200

do not override type SC_MATVAL_BOOLEAN with SC_MATVAL_VALUE

None of the callers checks for SC_MATVAL_VALUE but all use IsValueType()
instead, which includes SC_MATVAL_BOOLEAN, but we may want to explicitly
identify SC_MATVAL_BOOLEAN.

Change-Id: I6737eb2909c819b6c54f7e62cf8ebfc12af14fea

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 992b6cb..848bebb 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -2301,22 +2301,17 @@ ScMatValType ScInterpreter::GetDoubleOrStringFromMatrix(
 SetError( errNoValue);
 }
 
-if (nMatValType == SC_MATVAL_VALUE)
-rDouble = nMatVal.fVal;
-else if (nMatValType == SC_MATVAL_BOOLEAN)
-{
-rDouble = nMatVal.fVal;
-nMatValType = SC_MATVAL_VALUE;
-}
-else
-rString = nMatVal.GetString();
-
 if (ScMatrix::IsValueType( nMatValType))
 {
+rDouble = nMatVal.fVal;
 sal_uInt16 nError = nMatVal.GetError();
 if (nError)
 SetError( nError);
 }
+else
+{
+rString = nMatVal.GetString();
+}
 
 return nMatValType;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu

--- Comment #2 from V Stuart Foote  ---
On Fedora 23 64-bit LXDE with
Version: 5.3.0.0.alpha0+
Build ID: f07aa1136ee68329a2b5f7cb88d2a8b5c83f474b
CPU Threads: 1; OS Version: Linux 4.2; UI Render: default; 
TinderBox: Linux-rpm_deb-x86_64@70-TDF, Branch:master, Time:
2016-06-28_01:15:53
Locale: en-US (en_US.UTF-8)

Can't reproduce.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

Heiko Tietze  changed:

   What|Removed |Added

 CC||j...@documentfoundation.org

--- Comment #12 from Heiko Tietze  ---
(In reply to Joel Madero from comment #11)
> FWIW I've never heard of NEEDINFO being used for code pointers. This is
> precisely what needsDevEval is for and placing it in NEEDINFO risks the bug
> being closed as INVALID after 7 months from auto purge. A lot of the times
> needsDevEval lasts a year or longer just because experienced devs are really
> busy and can't find the time to dig into code to give code pointers.
> 
> Just my thoughts - not sure how NEEDINFO adds anything on top of
> "needsDevEval" in keywords

It was the ESC decision how to handle proposed easyhacks. Samuel also warned
about this procedure. We could introduce PROPOSED_EASYHACK.

CC'ing Jan.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 48015] Option to export all sheet from Drawing and Presentation module

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=48015

Heiko Tietze  changed:

   What|Removed |Added

 CC||j...@documentfoundation.org

--- Comment #12 from Heiko Tietze  ---
(In reply to Joel Madero from comment #11)
> FWIW I've never heard of NEEDINFO being used for code pointers. This is
> precisely what needsDevEval is for and placing it in NEEDINFO risks the bug
> being closed as INVALID after 7 months from auto purge. A lot of the times
> needsDevEval lasts a year or longer just because experienced devs are really
> busy and can't find the time to dig into code to give code pointers.
> 
> Just my thoughts - not sure how NEEDINFO adds anything on top of
> "needsDevEval" in keywords

It was the ESC decision how to handle proposed easyhacks. Samuel also warned
about this procedure. We could introduce PROPOSED_EASYHACK.

CC'ing Jan.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
On pc Debian x86-64 with master sources updated today
(612ebb9b972fde18b1492b601116a8c03adb2912), I don't reproduce this.
I tried with gtk3, gtk, gen, kde4 rendering.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Julien Nabet  changed:

   What|Removed |Added

   Keywords||wantBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100658] Crash printer properties

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100658

Julien Nabet  changed:

   What|Removed |Added

Summary|LibreOfficse crash printer  |Crash printer properties
   |properties  |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: compilerplugins/clang sal/cpprt

2016-06-28 Thread Stephan Bergmann

 compilerplugins/clang/staticmethods.cxx |5 -
 sal/cpprt/operators_new_delete.cxx  |4 ++--
 2 files changed, 2 insertions(+), 7 deletions(-)

New commits:
commit 0d3f9667bbc7b1a22d33dc92a2028fc712495a8e
Author: Stephan Bergmann 
Date:   Tue Jun 28 22:38:57 2016 +0200

AllocatorTraits::size can be static after all

Change-Id: If9ce8a094af878497e980cdcfaf11604d613e5b8

diff --git a/compilerplugins/clang/staticmethods.cxx 
b/compilerplugins/clang/staticmethods.cxx
index 7eac313..c533242 100644
--- a/compilerplugins/clang/staticmethods.cxx
+++ b/compilerplugins/clang/staticmethods.cxx
@@ -117,12 +117,7 @@ bool StaticMethods::TraverseCXXMethodDecl(const 
CXXMethodDecl * pCXXMethodDecl)
 if (aParentName == "BitmapInfoAccess") {
 return true;
 }
-// can't change it because in debug mode it can't be static
-// sal/cpprt/operators_new_delete.cxx
 auto dc = loplugin::DeclCheck(pCXXMethodDecl->getParent());
-if (dc.Struct("AllocatorTraits").AnonymousNamespace().GlobalNamespace()) {
-return true;
-}
 // in this case, the code is taking the address of the member function
 // shell/source/unix/sysshell/recently_used_file_handler.cxx
 if (dc.Struct("recently_used_item").AnonymousNamespace().GlobalNamespace())
diff --git a/sal/cpprt/operators_new_delete.cxx 
b/sal/cpprt/operators_new_delete.cxx
index 8cf69ff..40fdd33 100644
--- a/sal/cpprt/operators_new_delete.cxx
+++ b/sal/cpprt/operators_new_delete.cxx
@@ -40,7 +40,7 @@ struct AllocatorTraits
 : m_signature (s)
 {}
 
-std::size_t size (std::size_t n) const
+static std::size_t size (std::size_t n)
 {
 n = std::max(n, std::size_t(1));
 #if OSL_DEBUG_LEVEL > 0
@@ -105,7 +105,7 @@ static void default_handler()
 static void* allocate (
 std::size_t n, AllocatorTraits const & rTraits)
 {
-n = rTraits.size (n);
+n = AllocatorTraits::size (n);
 for (;;)
 {
 void * p = rtl_allocateMemory (sal_Size(n));
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: compilerplugins/clang

2016-06-28 Thread Stephan Bergmann

 compilerplugins/clang/badstatics.cxx |2 
 compilerplugins/clang/check.cxx  |  106 +++
 compilerplugins/clang/check.hxx  |  211 +++
 compilerplugins/clang/fpcomparison.cxx   |   54 +++--
 compilerplugins/clang/getimplementationname.cxx  |2 
 compilerplugins/clang/implicitboolconversion.cxx |2 
 compilerplugins/clang/passstuffbyref.cxx |   27 +-
 compilerplugins/clang/refcounting.cxx|   10 -
 compilerplugins/clang/salbool.cxx|2 
 compilerplugins/clang/staticmethods.cxx  |2 
 compilerplugins/clang/stringconstant.cxx |2 
 compilerplugins/clang/typecheck.cxx  |   96 --
 compilerplugins/clang/typecheck.hxx  |  162 -
 compilerplugins/clang/weakobject.cxx |2 
 14 files changed, 381 insertions(+), 299 deletions(-)

New commits:
commit 0d3738a2580d72b778547bfcdf691fdeb0eccbdd
Author: Stephan Bergmann 
Date:   Tue Jun 28 18:54:31 2016 +0200

More Clang 3.4 "(anonymous namespace)" fixes

Change-Id: I7cb43f915565dadd611b90ee30373e472f97efb5
Reviewed-on: https://gerrit.libreoffice.org/26748
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/compilerplugins/clang/badstatics.cxx 
b/compilerplugins/clang/badstatics.cxx
index aa50241..f316b4d 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -7,8 +7,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include "check.hxx"
 #include "plugin.hxx"
-#include "typecheck.hxx"
 
 namespace {
 
diff --git a/compilerplugins/clang/typecheck.cxx 
b/compilerplugins/clang/check.cxx
similarity index 83%
rename from compilerplugins/clang/typecheck.cxx
rename to compilerplugins/clang/check.cxx
index c293b57..c66a902 100644
--- a/compilerplugins/clang/typecheck.cxx
+++ b/compilerplugins/clang/check.cxx
@@ -7,8 +7,10 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
+#include 
+
+#include "check.hxx"
 #include "compat.hxx"
-#include "typecheck.hxx"
 
 namespace loplugin {
 
@@ -72,7 +74,15 @@ TypeCheck TypeCheck::NotSubstTemplateTypeParmType() const {
 ? *this : TypeCheck();
 }
 
-TerminalCheck NamespaceCheck::GlobalNamespace() const {
+ContextCheck DeclCheck::Operator(clang::OverloadedOperatorKind op) const {
+assert(op != clang::OO_None);
+auto f = llvm::dyn_cast_or_null(decl_);
+return ContextCheck(
+f != nullptr && f->getOverloadedOperator() == op
+? f->getDeclContext() : nullptr);
+}
+
+TerminalCheck ContextCheck::GlobalNamespace() const {
 return TerminalCheck(
 context_ != nullptr
 && ((compat::isLookupContext(*context_)
@@ -80,14 +90,14 @@ TerminalCheck NamespaceCheck::GlobalNamespace() const {
 ->isTranslationUnit()));
 }
 
-TerminalCheck NamespaceCheck::StdNamespace() const {
+TerminalCheck ContextCheck::StdNamespace() const {
 return TerminalCheck(
 context_ != nullptr && compat::isStdNamespace(*context_));
 }
 
-NamespaceCheck NamespaceCheck::AnonymousNamespace() const {
+ContextCheck ContextCheck::AnonymousNamespace() const {
 auto n = llvm::dyn_cast_or_null(context_);
-return NamespaceCheck(
+return ContextCheck(
 n != nullptr && n->isAnonymousNamespace() ? n->getParent() : nullptr);
 }
 
diff --git a/compilerplugins/clang/typecheck.hxx 
b/compilerplugins/clang/check.hxx
similarity index 53%
rename from compilerplugins/clang/typecheck.hxx
rename to compilerplugins/clang/check.hxx
index b3417bf..8381aec 100644
--- a/compilerplugins/clang/typecheck.hxx
+++ b/compilerplugins/clang/check.hxx
@@ -7,23 +7,24 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  */
 
-#ifndef INCLUDED_COMPILERPLUGINS_CLANG_TYPECHECK_HXX
-#define INCLUDED_COMPILERPLUGINS_CLANG_TYPECHECK_HXX
+#ifndef INCLUDED_COMPILERPLUGINS_CLANG_CHECK_HXX
+#define INCLUDED_COMPILERPLUGINS_CLANG_CHECK_HXX
 
 #include 
 
 #include 
 #include 
 #include 
+#include 
 
 namespace loplugin {
 
-class NamespaceCheck;
+class ContextCheck;
 class TerminalCheck;
 
 namespace detail {
 
-template NamespaceCheck checkRecordDecl(
+template ContextCheck checkRecordDecl(
 clang::Decl const * decl, clang::TagTypeKind tag, char const (& id)[N]);
 
 }
@@ -44,7 +45,7 @@ public:
 
 TypeCheck LvalueReference() const;
 
-template inline NamespaceCheck Class(char const (& id)[N])
+template inline ContextCheck Class(char const (& id)[N])
 const;
 
 TypeCheck NotSubstTemplateTypeParmType() const;
@@ -55,50 +56,65 @@ private:
 clang::QualType const type_;
 };
 
-class NamespaceCheck {
+class DeclCheck {
+public:
+explicit DeclCheck(clang::Decl const * decl): decl_(decl) {}
+
+explicit operator bool() const { return decl_ != nullptr; }
+
+template inline ContextCheck Class(char

[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' - 2 commits - sc/inc sc/qa sc/source

2016-06-28 Thread Katarina Behrens

 sc/inc/scabstdlg.hxx|3 +--
 sc/qa/unit/screenshots/screenshots.cxx  |   21 -
 sc/source/ui/attrdlg/scdlgfact.cxx  |5 ++---
 sc/source/ui/attrdlg/scdlgfact.hxx  |3 +--
 sc/source/ui/inc/tabbgcolordlg.hxx  |3 +--
 sc/source/ui/miscdlgs/tabbgcolordlg.cxx |4 +---
 sc/source/ui/view/tabvwshf.cxx  |3 +--
 7 files changed, 19 insertions(+), 23 deletions(-)

New commits:
commit 1f8de058819c68842a6518aaac6617e9aae2354b
Author: Katarina Behrens 
Date:   Tue Jun 28 22:29:52 2016 +0200

Don't crash on opening csv import dialog

Change-Id: I1ff56d79f7ff31317187cf077380481f1ef44366

diff --git a/sc/qa/unit/screenshots/screenshots.cxx 
b/sc/qa/unit/screenshots/screenshots.cxx
index ee12727..68d2814 100644
--- a/sc/qa/unit/screenshots/screenshots.cxx
+++ b/sc/qa/unit/screenshots/screenshots.cxx
@@ -96,6 +96,8 @@ private:
 ScDocShellRef xDocSh;
 ScTabViewShell* pViewShell;
 ScAbstractDialogFactory* pFact;
+
+std::unique_ptr pStream;
 };
 
 ScScreenshotTest::ScScreenshotTest()
@@ -138,6 +140,9 @@ void ScScreenshotTest::initializeWithDoc(const char* pName)
 
 pFact = ScAbstractDialogFactory::Create();
 CPPUNIT_ASSERT_MESSAGE("Failed to create dialog factory", pFact);
+
+const OUString aCsv("some, strings, here, separated, by, commas");
+pStream.reset( new ScImportStringStream( aCsv) );
 }
 
 VclAbstractDialog* ScScreenshotTest::createDialogByID( sal_uInt32 nID )
@@ -240,13 +245,11 @@ VclAbstractDialog* ScScreenshotTest::createDialogByID( 
sal_uInt32 nID )
 break;
 }
 
-//case 12:
-//{
-//const OUString aCsv("some, strings, here, separated, by, 
commas");
-//ScImportStringStream aStream( aCsv );
-//pReturnDialog = pFact->CreateScImportAsciiDlg( OUString(), 
, SC_PASTETEXT );
-//break;
-//}
+case 13:
+{
+pReturnDialog = pFact->CreateScImportAsciiDlg( OUString(), 
pStream.get(), SC_PASTETEXT );
+break;
+}
//ScopedVclPtrInstance pDlg14( 
pViewShell->GetDialogParent(),  );
 //ScopedVclPtrInstance 
pDlg16(pViewShell->GetDialogParent());
 default:
@@ -290,7 +293,7 @@ void ScScreenshotTest::testOpeningModalDialogs()
 {
 initializeWithDoc("empty.ods");
 
-const sal_uInt32 nDialogs = 13;
+const sal_uInt32 nDialogs = 14;
 
 for ( sal_uInt32 i = 0; i < nDialogs; i++ )
 {
commit b6796754edac29aff54a95706cc216652f77d7b1
Author: Katarina Behrens 
Date:   Tue Jun 28 22:03:02 2016 +0200

This dialog doesn't even have a help button

so drop helpID argument from its ctor (not to mention the fact
that a help text with ID .uno:TabBgColor doesn't exist either)

Change-Id: I0624f0474334cc799d67f7f292e11194de5195fa

diff --git a/sc/inc/scabstdlg.hxx b/sc/inc/scabstdlg.hxx
index 8c6c6c5..a7130ce 100644
--- a/sc/inc/scabstdlg.hxx
+++ b/sc/inc/scabstdlg.hxx
@@ -447,8 +447,7 @@ public:
 virtual AbstractScTabBgColorDlg * CreateScTabBgColorDlg (  vcl::Window* 
pParent,
 const 
OUString& rTitle, //Dialog Title
 const 
OUString& rTabBgColorNoColorText, //Label for no tab color
-const Color& 
rDefaultColor, //Currently selected Color
-const OString& 
) = 0;
+const Color& 
rDefaultColor ) = 0; //Currently selected Color
 
 virtual AbstractScImportOptionsDlg * CreateScImportOptionsDlg ( bool   
 bAscii = true,
 const 
ScImportOptions*  pOptions = nullptr,
diff --git a/sc/qa/unit/screenshots/screenshots.cxx 
b/sc/qa/unit/screenshots/screenshots.cxx
index b17afc9..ee12727 100644
--- a/sc/qa/unit/screenshots/screenshots.cxx
+++ b/sc/qa/unit/screenshots/screenshots.cxx
@@ -216,7 +216,7 @@ VclAbstractDialog* ScScreenshotTest::createDialogByID( 
sal_uInt32 nID )
 {
 pReturnDialog = pFact->CreateScTabBgColorDlg( 
pViewShell->GetDialogParent(),
 OUString(ScResId(SCSTR_SET_TAB_BG_COLOR)),
-OUString(ScResId(SCSTR_NO_TAB_BG_COLOR)), 
Color(0xff00ff), ".uno:TabBgColor" );
+OUString(ScResId(SCSTR_NO_TAB_BG_COLOR)), 
Color(0xff00ff) );
 break;
 }
 
diff --git a/sc/source/ui/attrdlg/scdlgfact.cxx 
b/sc/source/ui/attrdlg/scdlgfact.cxx
index af6b1cd..9e2e3bd 100644
--- a/sc/source/ui/attrdlg/scdlgfact.cxx
+++ b/sc/source/ui/attrdlg/scdlgfact.cxx
@@ -878,10 +878,9 @@ AbstractScTabBgColorDlg * 
ScAbstractDialogFactory_Impl::CreateScTabBgColorDlg(

[Libreoffice-commits] core.git: svx/source vcl/source

2016-06-28 Thread Caolán McNamara

 svx/source/tbxctrls/tbcontrl.cxx |   25 -
 vcl/source/window/floatwin.cxx   |2 +-
 2 files changed, 21 insertions(+), 6 deletions(-)

New commits:
commit 886637d355e77cd61d85279f145c06b07385fecd
Author: CaolÃ¡n McNamara 
Date:   Tue Jun 28 21:26:09 2016 +0100

Resolves: tdf#100574 Crash when selecting and applying border style...

when a first torn off instance was opened just before the second one
and then the second one sends focus back to the first when its popped
down.

The second one listens to losing the focus and disposes itself which leads 
to
dereferencing deleted stuff.

So add a reference count to the places these tear offs call popdown so its
still gets disposed but not deleted during the popdown and then protect 
against
members being disposed with a enough checks to get back to safely

Change-Id: Id5f8eb4771df36305e308a2a9a5035018948f121

diff --git a/svx/source/tbxctrls/tbcontrl.cxx b/svx/source/tbxctrls/tbcontrl.cxx
index 3c8164c..55bcd10 100644
--- a/svx/source/tbxctrls/tbcontrl.cxx
+++ b/svx/source/tbxctrls/tbcontrl.cxx
@@ -1381,6 +1381,8 @@ void SvxColorWindow_Impl::KeyInput( const KeyEvent& rKEvt 
)
 
 IMPL_LINK_TYPED(SvxColorWindow_Impl, SelectHdl, ValueSet*, pColorSet, void)
 {
+VclPtr xThis(this);
+
 Color aColor = pColorSet->GetItemColor( pColorSet->GetSelectItemId() );
 /*  #i33380# DR 2004-09-03 Moved the following line above the Dispatch() 
calls.
 This instance may be deleted in the meantime (i.e. when a dialog is 
opened
@@ -1412,6 +1414,8 @@ IMPL_LINK_NOARG_TYPED(SvxColorWindow_Impl, 
SelectPaletteHdl, ListBox&, void)
 
 IMPL_LINK_NOARG_TYPED(SvxColorWindow_Impl, AutoColorClickHdl, Button*, void)
 {
+VclPtr xThis(this);
+
 Color aColor;
 switch ( theSlotId )
 {
@@ -1443,6 +1447,8 @@ IMPL_LINK_NOARG_TYPED(SvxColorWindow_Impl, 
AutoColorClickHdl, Button*, void)
 
 IMPL_LINK_NOARG_TYPED(SvxColorWindow_Impl, OpenPickerClickHdl, Button*, void)
 {
+VclPtr xThis(this);
+
 if ( IsInPopupMode() )
 EndPopupMode();
 mrPaletteManager.PopupColorPicker(maCommand);
@@ -1685,6 +1691,8 @@ void SvxFrameWindow_Impl::DataChanged( const 
DataChangedEvent& rDCEvt )
 
 IMPL_LINK_NOARG_TYPED(SvxFrameWindow_Impl, SelectHdl, ValueSet*, void)
 {
+VclPtr xThis(this);
+
 SvxBoxItem  aBorderOuter( SID_ATTR_BORDER_OUTER );
 SvxBoxInfoItem  aBorderInner( SID_ATTR_BORDER_INNER );
 SvxBorderLine   theDefLine;
@@ -1784,10 +1792,13 @@ IMPL_LINK_NOARG_TYPED(SvxFrameWindow_Impl, SelectHdl, 
ValueSet*, void)
 aBorderInner.QueryValue( a );
 aArgs[1].Value = a;
 
-/*  #i33380# DR 2004-09-03 Moved the following line above the Dispatch() 
call.
-This instance may be deleted in the meantime (i.e. when a dialog is 
opened
-while in Dispatch()), accessing members will crash in this case. */
-aFrameSet->SetNoSelection();
+if (aFrameSet)
+{
+/* #i33380# Moved the following line above the Dispatch() call.
+   This instance may be deleted in the meantime (i.e. when a dialog is 
opened
+   while in Dispatch()), accessing members will crash in this case. */
+aFrameSet->SetNoSelection();
+}
 
 SfxToolBoxControl::Dispatch( Reference< XDispatchProvider >( 
GetFrame()->getController(), UNO_QUERY ),
  ".uno:SetBorderStyle",
@@ -1973,6 +1984,8 @@ SvxLineWindow_Impl::SvxLineWindow_Impl( sal_uInt16 nId, 
const Reference< XFrame
 
 IMPL_LINK_NOARG_TYPED(SvxCurrencyList_Impl, SelectHdl, ListBox&, void)
 {
+VclPtr xThis(this);
+
 if ( IsInPopupMode() )
 EndPopupMode();
 
@@ -1987,6 +2000,8 @@ IMPL_LINK_NOARG_TYPED(SvxCurrencyList_Impl, SelectHdl, 
ListBox&, void)
 
 IMPL_LINK_NOARG_TYPED(SvxLineWindow_Impl, SelectHdl, ListBox&, void)
 {
+VclPtr xThis(this);
+
 SvxLineItem aLineItem( SID_FRAME_LINESTYLE );
 SvxBorderStyle  nStyle = SvxBorderStyle( 
m_aLineStyleLb->GetSelectEntryStyle() );
 
@@ -3140,4 +3155,4 @@ void SvxCurrencyToolBoxControl::GetCurrencySymbols( 
std::vector& rList
 }
 }
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/source/window/floatwin.cxx b/vcl/source/window/floatwin.cxx
index 2362f13..38d9a91 100644
--- a/vcl/source/window/floatwin.cxx
+++ b/vcl/source/window/floatwin.cxx
@@ -811,7 +811,7 @@ void FloatingWindow::ImplEndPopupMode( 
FloatWinPopupEndFlags nFlags, const VclPt
 SetTitleType( mnOldTitle );
 
 // set ToolBox again to normal
-if ( mpImplData->mpBox )
+if (mpImplData && mpImplData->mpBox)
 {
 mpImplData->mpBox->ImplFloatControl( false, this );
 mpImplData->mpBox = nullptr;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org

[Libreoffice-bugs] [Bug 100657] DOC: display chapter name instead of chapter number in caption numbering

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100657

Gert Van Waelvelde  changed:

   What|Removed |Added

 CC||gvanwaelvelde+libreoffice@g
   ||mail.com

--- Comment #3 from Gert Van Waelvelde  ---
I can reproduce this in LibreOffice 5.2.0.1.0+ 
The document displays as it should in old LibreOffice version 4.2.8.2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100574] Crash when selecting and applying border style from toolbar in a certain way

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100574

Caolán McNamara  changed:

   What|Removed |Added

   Keywords|bibisectRequest |
 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |caol...@redhat.com
   |desktop.org |

--- Comment #7 from Caolán McNamara  ---
Seems to be that when the second one is popped down it gives the focus to the
old one, and the second one listens to losing the focus and disposes itself
which leads to dereferencing deleted stuff.

So add a reference count to the places these tear offs call popdown so its
still gets disposed but not deleted during the popdown and then protect against
members being disposed with a enough checks to get back to safely

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100657] DOC: display chapter name instead of chapter number in caption numbering

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100657

Gert Van Waelvelde  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: solenv/gbuild

2016-06-28 Thread Michael Stahl

 solenv/gbuild/Output.mk |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4dcba01d97b72db35885c505e647425059740a4c
Author: Michael Stahl 
Date:   Tue Jun 28 22:10:06 2016 +0200

gbuild: recognize newfangled screen TERM=screen.xterm-256color

Seems to have changed from Fedora 23, where it was just "screen", to 24.

Change-Id: I9078c337093d12d62e9afe10b1f02aaf346d4b43

diff --git a/solenv/gbuild/Output.mk b/solenv/gbuild/Output.mk
index 18f39ab..92a277c 100644
--- a/solenv/gbuild/Output.mk
+++ b/solenv/gbuild/Output.mk
@@ -62,6 +62,7 @@ KNOWN_TERM:=Eterm aterm gnome kterm linux putty rxvt 
rxvt-unicode screen xterm x
 KNOWN_TERM+=$(patsubst %,%-color,$(KNOWN_TERM))
 KNOWN_TERM+=$(patsubst %-color,%-256color,$(KNOWN_TERM))
 KNOWN_TERM+=$(patsubst %-color,%+256color,$(KNOWN_TERM))
+KNOWN_TERM+=$(patsubst %,screen.%,$(KNOWN_TERM))
 ifneq ($(strip $(gb_COLOR)),)
 ifneq ($(filter $(TERM),$(KNOWN_TERM)),)
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

Re: XFastParser - next steps ...

2016-06-28 Thread Michael Meeks

Hi Michael,

Thanks for your mail.

On Tue, 2016-06-28 at 20:53 +0200, Michael Stahl wrote:
> > Then (I guess) we could pass namespace prefixed names through for the
> > unknown attributes so eg. "office:foo" - and still have the information
> > we need to properly resolve them.
> 
> uhm... how many bad comparisons like "if (attribute == "office:foo") exist?

Apparently enough of them to stop libreoffice even starting if we don't
pass through namespace names un-modified ;-)

> a quick git grep finds only a handful, mostly in base code - wouldn't it
> be easier to just fix those?

Would be great; but I'm wary of pulling too much un-related string into
the GSOC project; Mohammed had a number of other cases I think where
this caused grief. A quick poke around shows:

$ git grep '"toolbar:'
$ git grep '"menu:'

Are rather suggestive of problems; though no idea what parser they use.
Ideally we'd move everyone to the XFastParser - it's faster ;-) in
due-course, but again - I'd rather get some of the threaded parsing
XFastParser wins for ODF - than drain this swap as part of the project.

Volunteers welcome to hunt & kill broken NS handling though !

ATB,

Michael.

-- 
michael.me...@collabora.com <><, GM Collabora Productivity
 Skype: mmeeks, Google Hangout: mejme...@gmail.com
 (M) +44 7795 666 147 - timezone usually UK / Europe

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 100664] AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Joel Madero  changed:

   What|Removed |Added

   Keywords||regression
   Priority|medium  |highest
 CC||jmadero@gmail.com
   Severity|normal  |critical

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100664] New: AutoCorrect Options . . . Crash

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100664

Bug ID: 100664
   Summary: AutoCorrect Options . . . Crash
   Product: LibreOffice
   Version: 5.3.0.0.alpha0+ Master
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: jmadero@gmail.com

Bodhi Moksha
Version: 5.3.0.0.alpha0+
Build ID: c1ab6613ae7b45f2d90aafd6c6a829a471ceca55
CPU Threads: 2; OS Version: Linux 3.16; UI Render: default; 
Locale: en-US (en_US.UTF-8)

Repo Steps:
1. Open writer;
2. Tools -> Autocorrect -> AutoCorrect Options...

Result: Crash

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73797] Allow rotation of images in Writer by any angle / degree ( currently only 90° s =?UTF-8?Q?teps=20possible?=), w/options for non-destructive handling of source image

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=73797

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=95
   ||165

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95165] Ability to Set Both Scale and Position of Bitmap in Filled Shapes

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95165

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=73
   ||797

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 73797] Allow rotation of images in Writer by any angle / degree ( currently only 90° s =?UTF-8?Q?teps=20possible?=), w/options for non-destructive handling of source image

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=73797

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=34
   ||551

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34551] FORMATTING: Option "Rotate fill effect with shape" not available

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34551

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=73
   ||797

--- Comment #11 from Luke  ---
We should limit the scope of this bug to the cases our engine supports as long
as the attribute are preserved on round trip. 

Until Bug 73797 is resolved all we can to do for is to preserve the attribute
for bitmaps. Some code pointers from Bug 36117:

doc:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbd1c167851a04c60d91daa830cf93e5b2ad7b4d

docx:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=664197d95becd516c3dac25a50439078ba61e051

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 34551] FORMATTING: Option "Rotate fill effect with shape" not available

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34551

Luke  changed:

   What|Removed |Added

   See Also||https://bugs.documentfounda
   ||tion.org/show_bug.cgi?id=73
   ||797

--- Comment #11 from Luke  ---
We should limit the scope of this bug to the cases our engine supports as long
as the attribute are preserved on round trip. 

Until Bug 73797 is resolved all we can to do for is to preserve the attribute
for bitmaps. Some code pointers from Bug 36117:

doc:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=fbd1c167851a04c60d91daa830cf93e5b2ad7b4d

docx:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=664197d95becd516c3dac25a50439078ba61e051

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 54242] [META] Incremental update support (small partial diff updates)

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54242

--- Comment #13 from V Stuart Foote  ---
a little house keeping:
Bug 68274 - provide better update mechanism -- Mozilla ARchive (mar) based
incrementals

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51780

--- Comment #21 from Gerhard Schaber  ---
P.S. Tested with 5.2.0 beta2

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: cui/Library_cui.mk cui/source cui/uiconfig cui/UIConfig_cui.mk extras/Package_palettes.mk extras/source include/svx scp2/source sc/sdi sc/source sd/sdi sd/source svx/Li

2016-06-28 Thread Rishabh Kumar

 cui/Library_cui.mk|2 
 cui/UIConfig_cui.mk   |2 
 cui/source/inc/cuires.hrc |2 
 cui/source/inc/cuitabarea.hxx |   41 
 cui/source/tabpages/strings.src   |8 
 cui/source/tabpages/tabarea.cxx   |   51 -
 cui/source/tabpages/tpbitmap.cxx  |  979 --
 cui/source/tabpages/tppattern.cxx |  876 +++
 cui/uiconfig/ui/areadialog.ui |4 
 cui/uiconfig/ui/bitmaptabpage.ui  |  347 ---
 cui/uiconfig/ui/patterntabpage.ui |  334 +++
 extras/Package_palettes.mk|1 
 extras/source/glade/libreoffice-catalog.xml.in|   11 
 extras/source/palettes/standard.sob   |binary
 extras/source/palettes/standard.sop   |binary
 include/svx/dialogs.hrc   |3 
 include/svx/dlgctrl.hxx   |   19 
 include/svx/drawitem.hxx  |   24 
 include/svx/sidebar/AreaPropertyPanelBase.hxx |2 
 include/svx/svdmodel.hxx  |1 
 include/svx/svxids.hrc|   39 
 include/svx/xtable.hxx|   26 
 sc/sdi/drawsh.sdi |1 
 sc/source/ui/docshell/docsh2.cxx  |1 
 scp2/source/ooo/registryitem_ooo.scp  |7 
 sd/sdi/_drvwsh.sdi|4 
 sd/source/ui/dlg/dlgpage.cxx  |4 
 sd/source/ui/dlg/prltempl.cxx |2 
 sd/source/ui/dlg/tabtempl.cxx |2 
 sd/source/ui/docshell/docshell.cxx|1 
 sd/source/ui/inc/dlgpage.hxx  |1 
 sd/source/ui/inc/prltempl.hxx |1 
 sd/source/ui/inc/tabtempl.hxx |1 
 sd/source/ui/sidebar/SlideBackground.cxx  |  156 ++-
 sd/source/ui/sidebar/SlideBackground.hxx  |1 
 svx/Library_svxcore.mk|1 
 svx/sdi/svx.sdi   |   16 
 svx/sdi/svxitems.sdi  |1 
 svx/source/dialog/dlgctrl.cxx |  155 +++
 svx/source/dialog/hdft.cxx|3 
 svx/source/dialog/sdstring.src|   10 
 svx/source/items/drawitem.cxx |   42 
 svx/source/sidebar/area/AreaPropertyPanel.cxx |2 
 svx/source/sidebar/area/AreaPropertyPanel.hxx |1 
 svx/source/sidebar/area/AreaPropertyPanelBase.cxx |  567 +++-
 svx/source/xoutdev/xattrbmp.cxx   |5 
 svx/source/xoutdev/xtabbtmp.cxx   |   33 
 svx/source/xoutdev/xtable.cxx |6 
 svx/source/xoutdev/xtabptrn.cxx   |   92 ++
 svx/uiconfig/ui/sidebararea.ui|  170 +--
 sw/sdi/_frmsh.sdi |6 
 sw/sdi/drawsh.sdi |5 
 sw/source/core/draw/drawdoc.cxx   |1 
 sw/source/ui/chrdlg/pardlg.cxx|2 
 sw/source/ui/frmdlg/frmdlg.cxx|2 
 sw/source/uibase/app/docshdrw.cxx |1 
 sw/source/uibase/app/docst.cxx|1 
 sw/source/uibase/app/docstyle.cxx |3 
 sw/source/uibase/shells/frmsh.cxx |2 
 sw/source/uibase/shells/grfsh.cxx |3 
 sw/source/uibase/shells/textsh.cxx|2 
 sw/source/uibase/shells/textsh1.cxx   |4 
 62 files changed, 2302 insertions(+), 1788 deletions(-)

New commits:
commit 76585ae33f3ca75c05c0ccbf6a621b6e2d42bc00
Author: Rishabh Kumar 
Date:   Tue Jun 7 16:58:20 2016 +0530

Convert Bitmap tab to Pattern tab

Change-Id: I5cf02f1889090539f7adb826483c91a1ef3c3925
Reviewed-on: https://gerrit.libreoffice.org/26015
Tested-by: Jenkins 
Reviewed-by: Katarina Behrens 

diff --git a/cui/Library_cui.mk b/cui/Library_cui.mk
index 7bb181d..c81ef962 100644
--- a/cui/Library_cui.mk
+++ b/cui/Library_cui.mk
@@ -197,13 +197,13 @@ $(eval $(call gb_Library_add_exception_objects,cui,\
 cui/source/tabpages/textanim \
 cui/source/tabpages/textattr \
 cui/source/tabpages/tparea \
-cui/source/tabpages/tpbitmap \
 cui/source/tabpages/tpcolor \
 cui/source/tabpages/tpgradnt \
 cui/source/tabpages/tphatch \
 cui/source/tabpages/tpline \
 cui/source/tabpages/tplnedef \
 cui/source/tabpages/tplneend \
+cui/source/tabpages/tppattern \
 cui/source/tabpages/tpshadow \
 cui/source/tabpages/tptrans \
 cui/source/tabpages/transfrm \
diff --git a/cui/UIConfig_cui.mk b/cui/UIConfig_cui.mk
index b0f72cb..60c8d18 100644
---

[Libreoffice-bugs] [Bug 92835] Libreoffice needs an automatic update like Chrome

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92835

V Stuart Foote  changed:

   What|Removed |Added

 Blocks|54242   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=54242
[Bug 54242] [META] Incremental update support (small partial diff updates)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54242] [META] Incremental update support (small partial diff updates)

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54242
Bug 54242 depends on bug 83406, which changed state.

Bug 83406 Summary: Redesign LO update process
https://bugs.documentfoundation.org/show_bug.cgi?id=83406

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54242] [META] Incremental update support (small partial diff updates)

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54242

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||83406


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83406
[Bug 83406] Redesign LO update process
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 51780] default to Firebird not HSQLDB in Base

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=51780

--- Comment #20 from Gerhard Schaber  ---
I would like to vote for bug #91324 to be added here. The behavior of the Date
type is generally rather unpredictable. For example, create a table with a Date
field and try to enter 2015-12-12. It always changes the date to 2016-01-12. Or
And Extract ( Year FROM x ) returns 3915 if x is a date with year 2015.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54242] [META] Incremental update support (small partial diff updates)

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54242

V Stuart Foote  changed:

   What|Removed |Added

 Depends on|83406, 92835|


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=83406
[Bug 83406] Redesign LO update process
https://bugs.documentfoundation.org/show_bug.cgi?id=92835
[Bug 92835] Libreoffice needs an automatic update like Chrome
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83406] Redesign LO update process

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83406

V Stuart Foote  changed:

   What|Removed |Added

 Blocks|54242   |


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=54242
[Bug 54242] [META] Incremental update support (small partial diff updates)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 83406] Redesign LO update process

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=83406

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||vstuart.fo...@utsa.edu
 Blocks||54242
 Resolution|--- |DUPLICATE

--- Comment #16 from V Stuart Foote  ---
No reason for this not to be resolved duplicate of 62874 -- provide better
update mechanism -- Mozilla ARchive (mar) based incrementals

*** This bug has been marked as a duplicate of bug 68274 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=54242
[Bug 54242] [META] Incremental update support (small partial diff updates)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68274] provide better update mechanism -- Mozilla ARchive (mar) based incrementals

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=68274

--- Comment #33 from V Stuart Foote  ---
*** Bug 83406 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 92835] Libreoffice needs an automatic update like Chrome

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92835

V Stuart Foote  changed:

   What|Removed |Added

 CC||vstuart.fo...@utsa.edu
 Blocks||54242

--- Comment #3 from V Stuart Foote  ---


*** This bug has been marked as a duplicate of bug 68274 ***


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=54242
[Bug 54242] [META] Incremental update support (small partial diff updates)
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 54242] [META] Incremental update support (small partial diff updates)

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=54242

V Stuart Foote  changed:

   What|Removed |Added

 Depends on||92835


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=92835
[Bug 92835] Libreoffice needs an automatic update like Chrome
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 68274] provide better update mechanism -- Mozilla ARchive (mar) based incrementals

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=68274

V Stuart Foote  changed:

   What|Removed |Added

 CC||jigglebi...@mailinator.com

--- Comment #32 from V Stuart Foote  ---
*** Bug 92835 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100663] HLOOKUP returns wrong value

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100663

GerardF  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||gerard.farg...@orange.fr
 Resolution|--- |NOTABUG

--- Comment #1 from GerardF  ---
Have a look at the help for this function.
You just have omitted the 4th parameter.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100644] change the behavior of changing line thickness with " format cells"

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100644

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|NEEDINFO|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Cor Nouws  ---
Thanks Roeland for your explanation!
I expect there are more use cases, including other attributes..

So UXEval.

Maybe it's good for people to comment to play around with various scenarios.
Of course this beside explaining your own favorite work-flow ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100644] change the behavior of changing line thickness with " format cells"

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100644

Cor Nouws  changed:

   What|Removed |Added

   Keywords||needsUXEval
 Status|NEEDINFO|NEW
 CC||libreoffice-ux-advise@lists
   ||.freedesktop.org

--- Comment #3 from Cor Nouws  ---
Thanks Roeland for your explanation!
I expect there are more use cases, including other attributes..

So UXEval.

Maybe it's good for people to comment to play around with various scenarios.
Of course this beside explaining your own favorite work-flow ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: sd/Library_sd.mk sd/source sd/uiconfig sd/UIConfig_simpress.mk

2016-06-28 Thread Szymon Kłos

 sd/Library_sd.mk   |1 
 sd/UIConfig_simpress.mk|1 
 sd/source/ui/animations/CustomAnimationBox.cxx |   81 ++
 sd/source/ui/animations/CustomAnimationPane.cxx|   60 +
 sd/source/ui/animations/CustomAnimationPane.hxx|4 
 sd/uiconfig/simpress/ui/customanimationspanelhorizontal.ui |  409 +
 sd/uiconfig/simpress/ui/notebookbar.ui |   34 -
 7 files changed, 569 insertions(+), 21 deletions(-)

New commits:
commit 6af8c9ef2de39b933274c96fd661d219b2bed8a3
Author: Szymon KÅos 
Date:   Tue Jun 28 16:09:16 2016 +0200

GSoC notebookbar: added animation tab for Impress

Change-Id: Iff9d0269f0f8ce0e0a311c1bbcaf5f749c305348
Reviewed-on: https://gerrit.libreoffice.org/26744
Tested-by: Jenkins 
Reviewed-by: Samuel Mehrbrodt 

diff --git a/sd/Library_sd.mk b/sd/Library_sd.mk
index eab6571..72ea43e 100644
--- a/sd/Library_sd.mk
+++ b/sd/Library_sd.mk
@@ -175,6 +175,7 @@ $(eval $(call gb_Library_add_exception_objects,sd,\
sd/source/ui/accessibility/AccessibleViewForwarder \
sd/source/ui/accessibility/SdShapeTypes \
 sd/source/ui/animations/CategoryListBox \
+   sd/source/ui/animations/CustomAnimationBox \
sd/source/ui/animations/CustomAnimationDialog \
sd/source/ui/animations/CustomAnimationList \
sd/source/ui/animations/CustomAnimationPane \
diff --git a/sd/UIConfig_simpress.mk b/sd/UIConfig_simpress.mk
index ef79c95..a5351dc 100644
--- a/sd/UIConfig_simpress.mk
+++ b/sd/UIConfig_simpress.mk
@@ -104,6 +104,7 @@ $(eval $(call 
gb_UIConfig_add_toolbarfiles,modules/simpress,\
 
 $(eval $(call gb_UIConfig_add_uifiles,modules/simpress,\
sd/uiconfig/simpress/ui/customanimationspanel \
+   sd/uiconfig/simpress/ui/customanimationspanelhorizontal \
sd/uiconfig/simpress/ui/customanimationproperties \
sd/uiconfig/simpress/ui/customanimationeffecttab \
sd/uiconfig/simpress/ui/customanimationtimingtab \
diff --git a/sd/source/ui/animations/CustomAnimationBox.cxx 
b/sd/source/ui/animations/CustomAnimationBox.cxx
new file mode 100644
index 000..d37de23
--- /dev/null
+++ b/sd/source/ui/animations/CustomAnimationBox.cxx
@@ -0,0 +1,81 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ *
+ * This file incorporates work covered by the following license notice:
+ *
+ *   Licensed to the Apache Software Foundation (ASF) under one or more
+ *   contributor license agreements. See the NOTICE file distributed
+ *   with this work for additional information regarding copyright
+ *   ownership. The ASF licenses this file to you under the Apache
+ *   License, Version 2.0 (the "License"); you may not use this file
+ *   except in compliance with the License. You may obtain a copy of
+ *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
+ */
+
+#include "ViewShellBase.hxx"
+#include 
+#include "CustomAnimationPane.hxx"
+#include 
+#include 
+
+namespace sd
+{
+
+class CustomAnimationBox : public VclVBox
+{
+VclPtr m_pPane;
+bool m_bIsInitialized;
+
+public:
+CustomAnimationBox(vcl::Window* pParent);
+~CustomAnimationBox() override;
+
+virtual void dispose() override;
+virtual void StateChanged(StateChangedType nStateChange) override;
+};
+
+VCL_BUILDER_FACTORY(CustomAnimationBox);
+
+CustomAnimationBox::CustomAnimationBox(vcl::Window* pParent)
+: VclVBox(pParent)
+, m_bIsInitialized(false)
+{
+}
+
+CustomAnimationBox::~CustomAnimationBox()
+{
+disposeOnce();
+}
+
+void CustomAnimationBox::dispose()
+{
+m_pPane.disposeAndClear();
+VclVBox::dispose();
+}
+
+void CustomAnimationBox::StateChanged(StateChangedType nStateChange)
+{
+if(SfxViewFrame::Current() && !m_bIsInitialized)
+{
+ViewShellBase* pBase = 
ViewShellBase::GetViewShellBase(SfxViewFrame::Current());
+
+if(pBase && pBase->GetDocShell())
+{
+css::uno::Reference xFrame;
+m_pPane = VclPtr::Create(this, *pBase, 
xFrame, true);
+m_pPane->Show();
+m_pPane->SetSizePixel(GetSizePixel());
+m_bIsInitialized = true;
+}
+}
+VclVBox::StateChanged(nStateChange);
+}
+
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx 
b/sd/source/ui/animations/CustomAnimationPane.cxx
index e8de52c..e328453 100644
--- a/sd/source/ui/animations/CustomAnimationPane.cxx
+++ b/sd/source/ui/animations/CustomAnimationPane.cxx
@@ -133,12 +133,36 @@

[Libreoffice-bugs] [Bug 100100] Emoji toolbar control

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100100

--- Comment #10 from jonathon  ---
Rather than an emoji only toolbar, ensure that bug 34882
(https://bugs.documentfoundation.org/show_bug.cgi?id=34882) is fixed.

Emoji are simply a special case of the issue described at
Really basic missing features and enhancements >  Insert Special Characters ->
Recent Characters (
https://wiki.documentfoundation.org/Development/Really_basic_missing_features_and_enhancements#Insert_Special_Characters_-.3E_Recent_Characters
)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 100100] Emoji toolbar control

2016-06-28 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100100

--- Comment #10 from jonathon  ---
Rather than an emoji only toolbar, ensure that bug 34882
(https://bugs.documentfoundation.org/show_bug.cgi?id=34882) is fixed.

Emoji are simply a special case of the issue described at
Really basic missing features and enhancements >  Insert Special Characters ->
Recent Characters (
https://wiki.documentfoundation.org/Development/Really_basic_missing_features_and_enhancements#Insert_Special_Characters_-.3E_Recent_Characters
)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: offapi/com

2016-06-28 Thread David Tardon

 offapi/com/sun/star/drawing/framework/XConfigurationController.idl |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b7c62273bc4afc5032add706f6cc301532d02831
Author: David Tardon 
Date:   Tue Jun 28 10:54:40 2016 +0200

fix assumed typo

Change-Id: Ice084d8c0651b1b08e8e8cce6f4a6f1c09e8dd3e

diff --git a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl 
b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl
index 80ebff9..3443156 100644
--- a/offapi/com/sun/star/drawing/framework/XConfigurationController.idl
+++ b/offapi/com/sun/star/drawing/framework/XConfigurationController.idl
@@ -126,7 +126,7 @@ interface XResource;
 The ResourceId and ResourceObject members are not set.
 ResourceActivation is sent when a resource is
 activated, i.e. when a new object of a resource is created (or taken
-from a cash).
+from a cache).
 The ResourceId and ResourceObject
 members are set to the XResourceId and object reference of
 the activated resource.
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: 2 commits - canvas/source vcl/headless vcl/inc

2016-06-28 Thread David Tardon

 canvas/source/cairo/cairo_canvasbitmap.cxx |7 ++
 vcl/headless/svpgdi.cxx|   30 ++---
 vcl/inc/headless/svpgdi.hxx|   16 ++-
 3 files changed, 37 insertions(+), 16 deletions(-)

New commits:
commit cff87aac4ec77957569377d690bc4aa8f7146e0d
Author: David Tardon 
Date:   Mon Jun 27 20:37:25 2016 +0200

update other places that read data from cairo image surface

Change-Id: Icb8761e5ff89e1c0e0e034a751fe9a50ad5ab90a

diff --git a/canvas/source/cairo/cairo_canvasbitmap.cxx 
b/canvas/source/cairo/cairo_canvasbitmap.cxx
index 37c8902..86020ac 100644
--- a/canvas/source/cairo/cairo_canvasbitmap.cxx
+++ b/canvas/source/cairo/cairo_canvasbitmap.cxx
@@ -152,10 +152,17 @@ namespace cairocanvas
 sal_uInt32 *pPix = reinterpret_cast(pSrc + nStride * y);
 for( unsigned long x = 0; x < (unsigned long) 
aSize.Width(); x++ )
 {
+#if defined OSL_BIGENDIAN
+sal_uInt8 nB = (*pPix >> 24);
+sal_uInt8 nG = (*pPix >> 16) & 0xff;
+sal_uInt8 nR = (*pPix >> 8) & 0xff;
+sal_uInt8 nAlpha = *pPix & 0xff;
+#else
 sal_uInt8 nAlpha = (*pPix >> 24);
 sal_uInt8 nR = (*pPix >> 16) & 0xff;
 sal_uInt8 nG = (*pPix >> 8) & 0xff;
 sal_uInt8 nB = *pPix & 0xff;
+#endif
 if( nAlpha != 0 && nAlpha != 255 )
 {
 // Cairo uses pre-multiplied alpha - we do 
not => re-multiply
diff --git a/vcl/headless/svpgdi.cxx b/vcl/headless/svpgdi.cxx
index 511a427..e9f761f 100644
--- a/vcl/headless/svpgdi.cxx
+++ b/vcl/headless/svpgdi.cxx
@@ -1059,9 +1059,9 @@ void SvpSalGraphics::drawMask( const SalTwoRect& rTR,
 unsigned char *data = row + (rTR.mnSrcX * 4);
 for (sal_Int32 x = rTR.mnSrcX; x < rTR.mnSrcX + rTR.mnSrcWidth; ++x)
 {
-sal_uInt8 b = unpremultiply(data[0], data[3]);
-sal_uInt8 g = unpremultiply(data[1], data[3]);
-sal_uInt8 r = unpremultiply(data[2], data[3]);
+sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], 
data[SVP_CAIRO_ALPHA]);
+sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], 
data[SVP_CAIRO_ALPHA]);
+sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], 
data[SVP_CAIRO_ALPHA]);
 if (r == 0 && g == 0 && b == 0)
 {
 data[0] = SALCOLOR_BLUE(nMaskColor);
@@ -1125,15 +1125,9 @@ SalColor SvpSalGraphics::getPixel( long nX, long nY )
 unsigned char *surface_data = cairo_image_surface_get_data(m_pSurface);
 unsigned char *row = surface_data + (nStride*nY);
 unsigned char *data = row + (nX * 4);
-# if defined OSL_BIGENDIAN
-sal_uInt8 b = unpremultiply(data[3], data[0]);
-sal_uInt8 g = unpremultiply(data[2], data[0]);
-sal_uInt8 r = unpremultiply(data[1], data[0]);
-#else
-sal_uInt8 b = unpremultiply(data[0], data[3]);
-sal_uInt8 g = unpremultiply(data[1], data[3]);
-sal_uInt8 r = unpremultiply(data[2], data[3]);
-#endif
+sal_uInt8 b = unpremultiply(data[SVP_CAIRO_BLUE], data[SVP_CAIRO_ALPHA]);
+sal_uInt8 g = unpremultiply(data[SVP_CAIRO_GREEN], data[SVP_CAIRO_ALPHA]);
+sal_uInt8 r = unpremultiply(data[SVP_CAIRO_RED], data[SVP_CAIRO_ALPHA]);
 return MAKE_SALCOLOR(r, g, b);
 }
 
@@ -1342,15 +1336,15 @@ void SvpSalGraphics::releaseCairoContext(cairo_t* cr, 
bool bXorModeAllowed, cons
 unsigned char *xor_data = xor_row + (nExtentsLeft * 4);
 for (sal_Int32 x = nExtentsLeft; x < nExtentsRight; ++x)
 {
-sal_uInt8 b = unpremultiply(true_data[0], true_data[3]) ^
-  unpremultiply(xor_data[0], xor_data[3]);
-sal_uInt8 g = unpremultiply(true_data[1], true_data[3]) ^
-  unpremultiply(xor_data[1], xor_data[3]);
-sal_uInt8 r = unpremultiply(true_data[2], true_data[3]) ^
-  unpremultiply(xor_data[2], xor_data[3]);
-true_data[0] = premultiply(b, true_data[3]);
-true_data[1] = premultiply(g, true_data[3]);
-true_data[2] = premultiply(r, true_data[3]);
+sal_uInt8 b = unpremultiply(true_data[SVP_CAIRO_BLUE], 
true_data[SVP_CAIRO_ALPHA]) ^
+  unpremultiply(xor_data[SVP_CAIRO_BLUE], 
xor_data[SVP_CAIRO_ALPHA]);
+sal_uInt8 g = unpremultiply(true_data[SVP_CAIRO_GREEN], 
true_data[SVP_CAIRO_ALPHA]) ^
+  unpremultiply(xor_data[SVP_CAIRO_GREEN], 
xor_data[SVP_CAIRO_ALPHA]);
+sal_uInt8 r = unpremultiply(true_data[SVP_CAIRO_RED],

Re: XFastParser - next steps ...

2016-06-28 Thread Michael Stahl

On 28.06.2016 18:28, Michael Meeks wrote:
> Hi Mohammed,
> 
>   Let me CC the dev list on the fag-end of this conversation; hopefully
> it will get more interesting over time =)
> 
> On Mon, 2016-06-27 at 22:01 +0530, Mohammed Abdul Azeem wrote:
>> I'm looking into the code paths which misuses defined namespaces
>> without resolving them. I will make test cases to cover them. 
> 
>   Ah - right =)
>
>> Sure we can do this, but it would only account for element's namespace
>> and not attributes namespaces. Also some of the implementations of
>> XDocumentHandler expects namespace declaration( looking for "xmlns" )
>> and tries to resolve them, and I think this approach wouldn't cover
>> all the namespace declaration.
> 
>   Ah ! fair enough - then (I guess) we need to implement a new
> XFastNamespaceHandler which we can register with a setNamespaceHandler()
> call on XFastParser - and which can be NULL for all the interesting
> cases where we need to be truly fast =)
> 
>   Then (I guess) we could pass namespace prefixed names through for the
> unknown attributes so eg. "office:foo" - and still have the information
> we need to properly resolve them.

uhm... how many bad comparisons like "if (attribute == "office:foo") exist?

a quick git grep finds only a handful, mostly in base code - wouldn't it
be easier to just fix those?


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

1 2 3 4 >

1 - 100 of 341 matches

Mail list logo