date:20161014

[Libreoffice-bugs] [Bug 103077] Can't connect to an existing Mariadb data base with ODBC ( unixODBC or iODBC) using Mariadb ODBC connector

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103077

--- Comment #24 from Julien Nabet  ---
I don't know how to build MariaDB odbc driver since there's no instructions
about building
Here's the output of cmake:
julien@debian:~/lo/bugs/103077_mariadb/mariadb-connector-odbc-2.0.12-ga-src$
cmake ./
-- The C compiler identification is GNU 6.1.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Looking for floor
-- Looking for floor - not found
-- Looking for floor in m
-- Looking for floor in m - found
CMake Error at CMakeLists.txt:118 (MESSAGE):
  MariaDB not found

However, I can propose this patch on
https://github.com/MariaDB/mariadb-connector-odbc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: bean/native

2016-10-14 Thread Stephan Bergmann

 bean/native/win32/com_sun_star_comp_beans_LocalOfficeWindow.c |   24 --
 1 file changed, 1 insertion(+), 23 deletions(-)

New commits:
commit 667c9c18973e00e530b25735707b2fa8c1602882
Author: Stephan Bergmann 
Date:   Fri Oct 14 16:26:22 2016 +0200

Revert "Don't use the (win32) jawt_md.h as we don't have that when 
cross-compiling"

This reverts commit db57823374ee65b80cd53c5fd4234ad3bf6e287d, as it causes
loplugin:externandnotdefined under clang-cl, and cross-compiling Windows on
Linux seems a rather dead project for now.

Change-Id: Ia7fd742385fa0d609007f70e5116a99729224f77
Reviewed-on: https://gerrit.libreoffice.org/29835
Tested-by: Jenkins 
Reviewed-by: Stephan Bergmann 

diff --git a/bean/native/win32/com_sun_star_comp_beans_LocalOfficeWindow.c 
b/bean/native/win32/com_sun_star_comp_beans_LocalOfficeWindow.c
index 42f7714..300568d 100644
--- a/bean/native/win32/com_sun_star_comp_beans_LocalOfficeWindow.c
+++ b/bean/native/win32/com_sun_star_comp_beans_LocalOfficeWindow.c
@@ -25,32 +25,10 @@
 #pragma warning(pop)
 #endif
 
-#define JAWT_GetAWT hidden_JAWT_GetAWT
-#include "jawt.h"
-#undef JAWT_GetAWT
-
 #if defined _MSC_VER
 #pragma warning(push, 1)
 #endif
-/* When cross-compiling to Windows we don't have any Windows JDK
- * available. Copying this short snippet from win32/jawt_md.h can
- * surely not be against its license. The intent is to enable
- * interoperation with real Oracle Java after all. We leave out the
- * informative comments that might have "artistic merit" and be more
- * copyrightable. Use this also for native Windows compilation for
- * simplicity.
- */
-typedef struct jawt_Win32DrawingSurfaceInfo {
-union {
-HWND hwnd;
-HBITMAP hbitmap;
-void* pbits;
-};
-HDC hdc;
-HPALETTE hpalette;
-} JAWT_Win32DrawingSurfaceInfo;
-
-JNIIMPORT unsigned char JNICALL JAWT_GetAWT(JNIEnv *, JAWT *);
+#include "jawt_md.h"
 #if defined _MSC_VER
 #pragma warning(pop)
 #endif
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #36 from tagezi  ---
(In reply to Heiko Tietze from comment #35)
> Decision was made in the design team on Oct/14 to bring back the
> functionality in the context menu but move it into the upcoming styles
> submenu. Reason to do so is that we have remove direct formatting in the
> toolbar now and want to promote styles in general.

How many time will people spend to click the item from the submenu?
It is not that there are the item in the menu or not. There are a large number
of documents, which requires the removing of direct formatting, because they
were made by ... Why if someone does not know how to work in the Writer, people
who are able to work have to spend time?

Your promotion styles, does not remove the direct formatting from the
documents, which were made since 97 year in MSO.
The problem is that the movement of the cursor or the hand of two seconds,
poured to a quarter of an hour per a page. And when you want to remove direct
formatting and assign a style for multi-page document, this movement begins to
take hours.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #36 from tagezi  ---
(In reply to Heiko Tietze from comment #35)
> Decision was made in the design team on Oct/14 to bring back the
> functionality in the context menu but move it into the upcoming styles
> submenu. Reason to do so is that we have remove direct formatting in the
> toolbar now and want to promote styles in general.

How many time will people spend to click the item from the submenu?
It is not that there are the item in the menu or not. There are a large number
of documents, which requires the removing of direct formatting, because they
were made by ... Why if someone does not know how to work in the Writer, people
who are able to work have to spend time?

Your promotion styles, does not remove the direct formatting from the
documents, which were made since 97 year in MSO.
The problem is that the movement of the cursor or the hand of two seconds,
poured to a quarter of an hour per a page. And when you want to remove direct
formatting and assign a style for multi-page document, this movement begins to
take hours.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 96583] Libreoffice reports files as corrupted when root filesystem is full.

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=96583

Buovjaga  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEW
 CC||todven...@suomi24.fi
 Ever confirmed|0   |1

--- Comment #8 from Buovjaga  ---
Let's set to NEW.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103178] Calc crashes after adding text to a chart

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103178

--- Comment #4 from Julien Nabet  ---
Created attachment 128015
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128015=edit
Valgrind trace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Hardware|x86-64 (AMD64)  |All
Version|5.1.5.2 release |3.3.1 release
 OS|Windows (All)   |All
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 98481] SUM is zero when some cells are empty and some cells reference other sheet AND file is .xlsx AND file was created by Google Sheets.

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=98481

Eike Rathke  changed:

   What|Removed |Added

Summary|SUM is zero when some cells |SUM is zero when some cells
   |are empty and some cells|are empty and some cells
   |reference other sheet AND   |reference other sheet AND
   |file is xlsx.   |file is .xlsx AND file was
   ||created by Google Sheets.

--- Comment #8 from Eike Rathke  ---
The difference seems rather to be that formulas in E2:E4 and B5:D5 are shared,
whereas the formula in E8 is not. The .xlsx file loaded and re-saved in Excel
works fine in LinreOffice. Apparently Google Sheets does something Excel does
not, which LibreOffice is not prepared for.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103167] Disable sidebar decks in Notebookbar mode

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103167

--- Comment #2 from Yousuf Philips (jay)  ---
(In reply to Cor Nouws from comment #1)
> I do not really understand what you mean with this.

So lets say the tabbed notebookbar wants to define that the properties deck of
the sidebar should be disabled when the notebookbar is enabled, we should have
the option to do that.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103077] Can't connect to an existing Mariadb data base with ODBC ( unixODBC or iODBC) using Mariadb ODBC connector

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103077

--- Comment #23 from Lionel Elie Mamane  ---
(In reply to Julien Nabet from comment #21)
> Lionel:
> I retrieved sources of MariaDB odbc.
> In file ma_connection.c, in this function::
> SQLRETURN MADB_DbcGetInfo(MADB_Dbc *Dbc, SQLUSMALLINT InfoType, SQLPOINTER
> InfoValuePtr,
>   SQLSMALLINT BufferLength, SQLSMALLINT
> *StringLengthPtr, my_bool isWChar)
> 
> I noticed this:
>1169   case SQL_FILE_USAGE:
>1170 MADB_SET_NUM_VAL(SQLUINTEGER, InfoValuePtr,
> SQL_FILE_NOT_SUPPORTED, StringLengthPtr);
>1171 break;
> ...

Try changing on this line 1170 "SQLUINTEGER" to "SQLUSMALLINT". If my guess is
right, it will solve the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103213] Database Wizard froze after changing from Forms to Tables [ Version: 5.2.2.2 (x64)] when attempting to open a linked Access MDB file

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103213

--- Comment #5 from Dirk W.  ---
Ok, Alex and Julian, first thank you for your comments

Second: I apologize for to „›forgot‹ to mention is that [my] ODB file links to
an Access mdb file (Buecher/mdb).“ The thing is: I did not come to the idea,
that Access could have to do something with it. In my operation system (Win 10
Pro 64), LO-Writer (4.3.7.2) has no problems to open the „Buecher.odb“. With
deinstalling LO-Writer 4.3.7.2 and installing version 5.2.2.2 (x64) the
problems started. This is my first bug-report in life, so I did not see any
relation to the mdb (Access).

Now I have deinstalled version 5.2.2.2 and reinstalled version 4.3.7.2. But in
my OracleBox I have installed another Win 10 („Enterprise Evaluation“, 64bit)
and installed here again the 5.2.2.2 (x64) version of LO.

The problems remain, also I created in C:\ a temp-folder (and below a
database-folder), where I copied the files like Julian said.

In my real desktop (Win 10 Pro 64, LO 4.7.3.2) I create a odb-file like this
(and there is no problem):

I take „Connect to an existing database“ and select in the Pulldownmenu
„Microsoft Access“ (not 2007). I go – for example – to „Buecher.mdb“, confirm
(„Finish“) and then I could save a new database.

In my OracleBox (Win 10 Enterprise 64, LO 5.2.2.2) this happens:

I take „Connect to an existing database“ and select in the Pulldownmenu
„Microsoft Access“ (not 2007). I go – for example – to „Buecher.mdb“, confirm
(„Finish“) and then I could save a new database, what I’m doing. But then the
database wizard opens and this error message arises:

   „The connection to the data source "New Database" could not be established.

The connection could not be created. May be the necessary data provider is
not installed.“ (SQL Status: HY000)

After this, LO does not froze at least and I could exit LO. But if I mark
„Tables“ left then the first error description goes on (frozing).

Note: In my real desktop no MS-Access is installed. I have another OracleBox
with (good old) WinXP, where Access 2.0 (16bit, 1994) is installed. Here I
change my tables. In my real desktop I only look at the tables through LO Base.

Another note: I installed Java 64 too besides Java 32 (like in „bug 97395“ is
recommended) but that didn’t help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/dist loleaflet/src

2016-10-14 Thread Henry Castro

 loleaflet/dist/spreadsheet.css|1 +
 loleaflet/src/control/Control.ColumnHeader.js |4 ++--
 loleaflet/src/control/Control.RowHeader.js|6 +++---
 3 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 1d40b1eb79ec93aebc675dae33e0023b1e55220d
Author: Henry Castro 
Date:   Fri Oct 14 14:46:46 2016 -0400

loleaflet: fix mouse over text that it changes re-size cursor

diff --git a/loleaflet/dist/spreadsheet.css b/loleaflet/dist/spreadsheet.css
index c119f05..9548f0d 100644
--- a/loleaflet/dist/spreadsheet.css
+++ b/loleaflet/dist/spreadsheet.css
@@ -185,6 +185,7 @@
margin: 0px;
border: 0px;
padding: 0px;
+   overflow: hidden;
cursor: pointer;
 
/* Make the text unselectable for all browsers */
diff --git a/loleaflet/src/control/Control.ColumnHeader.js 
b/loleaflet/src/control/Control.ColumnHeader.js
index 0535b8c..ef67d60 100644
--- a/loleaflet/src/control/Control.ColumnHeader.js
+++ b/loleaflet/src/control/Control.ColumnHeader.js
@@ -142,8 +142,8 @@ L.Control.ColumnHeader = L.Control.Header.extend({
resize.column = iterator + 1;
resize.width = width;
L.DomUtil.setStyle(column, 'width', width + 
'px');
-   L.DomUtil.setStyle(text, 'width', width - 6 + 
'px');
-   L.DomUtil.setStyle(resize, 'width', '6px');
+   L.DomUtil.setStyle(text, 'width', width - 3 + 
'px');
+   L.DomUtil.setStyle(resize, 'width', '3px');
this.mouseInit(resize);
}
L.DomEvent.addListener(text, 'click', 
this._onColumnHeaderClick, this);
diff --git a/loleaflet/src/control/Control.RowHeader.js 
b/loleaflet/src/control/Control.RowHeader.js
index 28d501e..7406131 100644
--- a/loleaflet/src/control/Control.RowHeader.js
+++ b/loleaflet/src/control/Control.RowHeader.js
@@ -139,9 +139,9 @@ L.Control.RowHeader = L.Control.Header.extend({
resize.row = iterator + 1;
resize.height = height;
L.DomUtil.setStyle(row, 'height', height + 
'px');
-   L.DomUtil.setStyle(text, 'line-height', height 
+ 'px');
-   L.DomUtil.setStyle(text, 'height', height - 6 + 
'px');
-   L.DomUtil.setStyle(resize, 'height', '6px');
+   L.DomUtil.setStyle(text, 'line-height', height 
- 3 + 'px');
+   L.DomUtil.setStyle(text, 'height', height - 3 + 
'px');
+   L.DomUtil.setStyle(resize, 'height', '3px');
this.mouseInit(resize);
}
L.DomEvent.addListener(text, 'click', 
this._onRowHeaderClick, this);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103221] core/tools/source/fsys/urlobj.cxx:4450: unmaintainable code ?

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103221

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #1 from Julien Nabet  ---
I don't know if we can consider this as a bug since there's no buggy behavior
but if interested, you can help to clean up this mess! :-)
(see https://wiki.documentfoundation.org/Development/GetInvolved)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 67649] Postgresql SDBC updatable views

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=67649

Julien Nabet  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
   Assignee|ali.jou...@gmail.com|libreoffice-b...@lists.free
   ||desktop.org

--- Comment #5 from Julien Nabet  ---
No feedback since years, let's put it to NEW and unassign.

Ali: if you want to get back to it, don't hesitate to assign yourself again.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 101705] Text selection area not showing, or scrambling words inside text selection area

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=101705

--- Comment #4 from Anne McDonald  ---
(In reply to Aron Budea from comment #3)
> I think this might be the same as bug 99927. See my comment there:
> https://bugs.documentfoundation.org/show_bug.cgi?id=99927#c3
> 
> That bug is actually a bit older, so it might be different, but the symptoms
> seem really similar. That one is triggered by changing fonts, too. The
> selection area becoming scrambled seems to be a difference, but it might
> just be a symptom occuring under certain conditions.
> Do you notice any particular significant differences between the symptoms in
> the two reports?

My apologies for the major delay in responding. I'm new to the bug reporting
process and just realized I needed to respond to your question.

The significant difference is that the document becomes completely unresponsive
and I have to force quit. 

This morning I had an added symptom of the first two paragraphs of text turning
to gibberish when I installed new fonts.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46279] Show restart message after extension installation or update menu automatically

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46279

--- Comment #24 from Cor Nouws  ---
Hi,

(In reply to jan iversen from comment #23)

> I am sorry for the fuzz on your excellent work. You did what the ticket
> asked you to do, you even asked questions about implementation details, so I
> consider your work as valuable !!

Let me support you in that, Jan!

> Sometimes when people see how a patch work, they realise the implementation
> (again not your work) detail should have been different, this is unfortunate
> but happens in real life...in this case we normally do not revert the patch,
> but open a new ticket, that can extend/change/enhance the work you have done.

Of course that is fine too. Maybe it is interesting for Irem or someone else to
expand the initial work a bit?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Bug 46279] Show restart message after extension installation or update menu automatically

2016-10-14 Thread Cor Nouws

Hi Jan,

Jan Iversen wrote on 14-10-16 19:53:

> Following our good discussion in the last ESC meeting, we have another
> example of how to demotivate a new contributor.

I share your concerns about how this all must be properly communicated.
Apart from that:

> When a easyhack no longer has “needsDevEval” and “needsUIEval” is should

this specific issue has not been discussed by UX, didn't have
needsUIEval and I commented on the problem within three weeks of the
commit, because I stumbled over the problem in a daily build. Now it is
three months after my first comment, and I asked for response
repeatedly.. and it today that it's been discussed in the UX team.
(Where it also was announced last week IIRC..)
We know problems caused by unpolished but committed hacks that affected
(..s) users for years. So I want to express my concern on that side of
the situation too.
And IMO it's not optimal that there was no response (in the issue or
direct) on the noticed problem.

> make a new easyhack, describing how the current status can be
> enhanced/changed.

In general I say yes, when it's a glitch.

> That way we do not tell a new contributor his/hers work is rubbish
> (another less polite word for “revert”). Please remember the contributor

So that could have been done earlier.

> Sorry for a frank mail on a friday afternoon, but this is slowly
> becoming a bigger problem. We have enough problems helping new
> contributors become skilled LO developers, there are absolutely no need
> to create more problems.

I hope my view on the situation does help a bit in our mutual effort :)

Ciao - Cor


-- 
Cor Nouws
GPD key ID: 0xB13480A6 - 591A 30A7 36A0 CE3C 3D28  A038 E49D 7365 B134 80A6
- vrijwilliger http://nl.libreoffice.org
- volunteer http://www.libreoffice.org
- The Document Foundation Membership Committee Member
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: basctl/source compilerplugins/clang desktop/source include/vcl sw/source vcl/source

2016-10-14 Thread Noel Grandin

 basctl/source/basicide/baside2.cxx   |4 
 basctl/source/basicide/baside2.hxx   |   16 -
 basctl/source/basicide/baside2b.cxx  |4 
 compilerplugins/clang/mergeclasses.results   |1 
 desktop/source/deployment/gui/license_dialog.cxx |2 
 include/vcl/texteng.hxx  |1 
 include/vcl/textview.hxx |   37 +++-
 include/vcl/vclmedit.hxx |4 
 include/vcl/xtextedt.hxx |   18 --
 sw/source/ui/dbui/mmaddressblockpage.cxx |   16 -
 sw/source/uibase/docvw/srcedtw.cxx   |2 
 sw/source/uibase/inc/srcedtw.hxx |   10 -
 sw/source/uibase/uiview/srcview.cxx  |2 
 vcl/source/edit/textview.cxx |  189 +--
 vcl/source/edit/vclmedit.cxx |8 
 vcl/source/edit/xtextedt.cxx |  181 --
 16 files changed, 240 insertions(+), 255 deletions(-)

New commits:
commit 3223c551c37c6b10b5b7de23ffa4520d720338b6
Author: Noel Grandin 
Date:   Fri Oct 14 14:35:04 2016 +0200

loplugin:mergeclasses merge TextView with ExtTextView

Change-Id: If7e11dd8f6b2cb6dc19c6aa3f7e50e2e88861eac
Reviewed-on: https://gerrit.libreoffice.org/29828
Tested-by: Jenkins 
Reviewed-by: Noel Grandin 

diff --git a/basctl/source/basicide/baside2.cxx 
b/basctl/source/basicide/baside2.cxx
index 7ece041..9d3f9cf 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -560,7 +560,7 @@ void ModulWindow::BasicToggleBreakPointEnabled()
 {
 AssertValidEditEngine();
 
-ExtTextView* pView = GetEditView();
+TextView* pView = GetEditView();
 if ( pView )
 {
 TextSelection aSel = pView->GetSelection();
@@ -1211,7 +1211,7 @@ sal_uInt16 ModulWindow::StartSearchAndReplace( const 
SvxSearchItem& rSearchItem,
 
 // one could also relinquish syntaxhighlighting/formatting instead of the 
stupid replace-everything...
 AssertValidEditEngine();
-ExtTextView* pView = GetEditView();
+TextView* pView = GetEditView();
 TextSelection aSel;
 if ( bFromStart )
 {
diff --git a/basctl/source/basicide/baside2.hxx 
b/basctl/source/basicide/baside2.hxx
index c8bf2e6..9a51560 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -26,9 +26,6 @@
 #include "breakpoint.hxx"
 #include "linenumberwindow.hxx"
 
-class ExtTextEngine;
-class ExtTextView;
-class SvxSearchItem;
 #include 
 #include 
 
@@ -50,6 +47,9 @@ class SvxSearchItem;
 #include 
 #include 
 
+class ExtTextEngine;
+class TextView;
+class SvxSearchItem;
 namespace com { namespace sun { namespace star { namespace beans {
 class XMultiPropertySet;
 } } } }
@@ -74,8 +74,8 @@ friend class CodeCompleteListBox;
 private:
 class ChangesListener;
 
-std::unique_ptr   pEditView;
-std::unique_ptr pEditEngine;
+std::unique_ptrpEditView;
+std::unique_ptr   pEditEngine;
 ModulWindow& rModulWindow;
 
 rtl::Reference< ChangesListener > listener_;
@@ -139,7 +139,7 @@ public:
 virtual voiddispose() override;
 
 ExtTextEngine*  GetEditEngine() const   { return pEditEngine.get(); }
-ExtTextView*GetEditView() const { return pEditView.get(); }
+TextView*   GetEditView() const { return pEditView.get(); }
 
 voidCreateProgress( const OUString& rText, sal_uLong nRange );
 voidDestroyProgress();
@@ -389,7 +389,7 @@ public:
 LineNumberWindow&   GetLineNumberWindow()   { return 
m_aXEditorWindow->GetLineNumberWindow(); }
 ScrollBar&  GetEditVScrollBar() { return 
m_aXEditorWindow->GetEWVScrollBar(); }
 ExtTextEngine*  GetEditEngine() { return 
GetEditorWindow().GetEditEngine(); }
-ExtTextView*GetEditView()   { return 
GetEditorWindow().GetEditView(); }
+TextView*   GetEditView()   { return 
GetEditorWindow().GetEditView(); }
 BreakPointList& GetBreakPoints(){ return 
GetBreakPointWindow().GetBreakPoints(); }
 ModulWindowLayout&  GetLayout (){ return m_rLayout; }
 
@@ -486,7 +486,7 @@ private:
 
 void SetMatchingEntries(); // sets the visible entries based on 
aFuncBuffer variable
 void HideAndRestoreFocus();
-ExtTextView* GetParentEditView();
+TextView* GetParentEditView();
 
 public:
 explicit CodeCompleteListBox( CodeCompleteWindow* pPar );
diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index d02782e..64003b6 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -954,7 +954,7 @@ void EditorWindow::CreateEditEngine()
 return;
 
 pEditEngine.reset(new ExtTextEngine);
-pEditView.reset(new

[Libreoffice-bugs] [Bug 95957] LibreOffice 5.0.3.2 - crashes with std::bad_alloc

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95957

Buovjaga  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #28 from Buovjaga  ---
Let's set this to NEW per Keith's input.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103182] [META] GTK3-specific bugs

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103182

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||103220


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103220
[Bug 103220] UI is broken with GTK 3.22 on HiDPI screens
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103220] UI is broken with GTK 3.22 on HiDPI screens

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103220

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Blocks||90796, 103182


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=90796
[Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=103182
[Bug 103182] [META] GTK3-specific bugs
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=90796

Yousuf Philips (jay)  changed:

   What|Removed |Added

 Depends on||103220


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=103220
[Bug 103220] UI is broken with GTK 3.22 on HiDPI screens
-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103221] New: core/tools/source/fsys/urlobj.cxx:4450: unmaintainable code ?

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103221

Bug ID: 103221
   Summary: core/tools/source/fsys/urlobj.cxx:4450: unmaintainable
code ?
   Product: LibreOffice
   Version: unspecified
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: LibreOffice
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: dcb...@hotmail.com

tools/source/fsys/urlobj.cxx:4450:1: error: V502 Perhaps the '?:' operator
works in a different way than it was expected. The '?:' operator has a lower
priority than the '&&' operator.

Source code is


eStyle = eStyle & FSYS_VOS
 && m_aHost.isPresent()
 && m_aHost.getLength() > 0 ?
 FSYS_VOS :
 hasDosVolume(eStyle)
 || ((eStyle & FSYS_DOS) != 0
&& m_aHost.isPresent()
&& m_aHost.getLength() > 0) ?
 FSYS_DOS :
 eStyle & FSYS_UNX
 && (!m_aHost.isPresent() || m_aHost.getLength() == 0) ?
 FSYS_UNX :
 FSysStyle(0);

What a mess ! Nested ternary operators are worth avoiding.

Suggest recode with a clear sequence of if-then-else statements.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103186] LOGINV function

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103186

Eike Rathke  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice
   |desktop.org |.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #35 from Heiko Tietze  ---
Decision was made in the design team on Oct/14 to bring back the functionality
in the context menu but move it into the upcoming styles submenu. Reason to do
so is that we have remove direct formatting in the toolbar now and want to
promote styles in general.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102915] Restore Clear Direct Formatting (an uno: ResetAttributes command) to the context menu

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102915

--- Comment #35 from Heiko Tietze  ---
Decision was made in the design team on Oct/14 to bring back the functionality
in the context menu but move it into the upcoming styles submenu. Reason to do
so is that we have remove direct formatting in the toolbar now and want to
promote styles in general.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - sc/source

2016-10-14 Thread Winfried Donkers

 sc/source/core/tool/interpr8.cxx |   37 +
 1 file changed, 13 insertions(+), 24 deletions(-)

New commits:
commit f617d9466632f656811474cd49311e13ab950753
Author: Winfried Donkers 
Date:   Tue Sep 20 08:04:50 2016 +0200

tdf#94635 follow up; correct handling of double x-values in case of

month intervals.

Change-Id: I310d8d127d6b9ca571200ba8974a980430d69eb7
Reviewed-on: https://gerrit.libreoffice.org/29076
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
(cherry picked from commit ad707a3dafd020949cfd94098dc51c69466dafb8)
Reviewed-on: https://gerrit.libreoffice.org/29886

diff --git a/sc/source/core/tool/interpr8.cxx b/sc/source/core/tool/interpr8.cxx
index 972b125..7a02955 100644
--- a/sc/source/core/tool/interpr8.cxx
+++ b/sc/source/core/tool/interpr8.cxx
@@ -221,16 +221,14 @@ bool ScETSForecastCalculation::PreprocessDataRange( const 
ScMatrixRef& rMatX, co
 mfStepSize = ::std::numeric_limits::max();
 if ( mnMonthDay )
 {
-aDate = aNullDate + static_cast< long >( maRange[ 0 ].X );
-maRange[ 0 ].X = aDate.GetYear() * 12 + aDate.GetMonth();
-}
-for ( SCSIZE i = 1; i < mnCount; i++ )
-{
-if ( mnMonthDay )
+for ( SCSIZE i = 0; i < mnCount; i++ )
 {
 aDate = aNullDate + static_cast< long >( maRange[ i ].X );
 maRange[ i ].X = aDate.GetYear() * 12 + aDate.GetMonth();
 }
+}
+for ( SCSIZE i = 1; i < mnCount; i++ )
+{
 double fStep = maRange[ i ].X - maRange[ i - 1 ].X;
 if ( fStep == 0.0 )
 {
@@ -245,15 +243,20 @@ bool ScETSForecastCalculation::PreprocessDataRange( const 
ScMatrixRef& rMatX, co
 switch ( nAggregation )
 {
 case 1 : // AVERAGE (default)
+ while ( maRange[ i ].X == maRange[ i - 1 ].X  && i < 
mnCount )
+ {
+ maRange.erase( maRange.begin() + i );
+ --mnCount;
+ }
+ break;
 case 7 : // SUM
  while ( maRange[ i ].X == maRange[ i - 1 ].X  && i < 
mnCount )
  {
  fTmp += maRange[ i ].Y;
- nCounter++;
  maRange.erase( maRange.begin() + i );
  --mnCount;
  }
- maRange[ i - 1 ].Y = ( nAggregation == 1 ? fTmp / 
nCounter : fTmp );
+ maRange[ i - 1 ].Y = fTmp;
  break;
 
 case 2 : // COUNT
@@ -310,22 +313,11 @@ bool ScETSForecastCalculation::PreprocessDataRange( const 
ScMatrixRef& rMatX, co
  break;
 }
 if ( i < mnCount - 1 )
-{
-i++;
-if ( mnMonthDay )
-{
-Date aDate1 = aNullDate + static_cast< long >( maRange[ i 
].X );
-fStep = 12 * ( aDate1.GetYear() - aDate.GetYear() ) +
-( aDate1.GetMonth() - aDate.GetMonth() );
-aDate = aDate1;
-}
-else
-fStep = maRange[ i ].X - maRange[ i - 1 ].X;
-}
+fStep = maRange[ i ].X - maRange[ i - 1 ].X;
 else
fStep = mfStepSize;
 }
-if ( fStep < mfStepSize )
+if ( fStep > 0 && fStep < mfStepSize )
 mfStepSize = fStep;
 }
 
@@ -972,9 +964,6 @@ bool ScETSForecastCalculation::GetStatisticValue( const 
ScMatrixRef& rTypeMat, c
 
 bool ScETSForecastCalculation::GetSamplesInPeriod( double& rVal )
 {
-if ( !initCalc() )
-return false;
-
 rVal = mnSmplInPrd;
 return true;
 }
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 67145] CRASH: ODBC - Firebird: Attempting to edit table definition causes abort

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=67145

--- Comment #28 from Julien Nabet  ---
Just for information, there's 2.0.4 version (see
http://firebirdsql.org/en/odbc-driver/)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46279] Show restart message after extension installation or update menu automatically

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46279

--- Comment #23 from jan iversen  ---
Hi Irem

I am sorry for the fuzz on your excellent work. You did what the ticket asked
you to do, you even asked questions about implementation details, so I consider
your work as valuable !!

Sometimes when people see how a patch work, they realise the implementation
(again not your work) detail should have been different, this is unfortunate
but happens in real life...in this case we normally do not revert the patch,
but open a new ticket, that can extend/change/enhance the work you have done.

I hope you will continue have fun with LO, and please contact me, if I can do
anything to help.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: [Bug 46279] Show restart message after extension installation or update menu automatically

2016-10-14 Thread Jan Iversen

Hi

Following our good discussion in the last ESC meeting, we have another example 
of how to demotivate a new contributor.

When a easyhack no longer has “needsDevEval” and “needsUIEval” is should be 
considered an accepted easyhack with sufficient implementation details.
When a patch has been submitted to gerrit and has been reviewed (in this case 
it pended quite long in gerrit) and has been merged, we should not start to 
discuss how the implementation should be on the BZ Issue.

Of course we all learn, and sometimes when we see the effect of an 
implementation, we realise how it should have been done, this is natural and 
not a problem. BUT please do not reopen the easyhack and do not suggest to 
revert it, instead take the positive approach and:

make a new easyhack, describing how the current status can be enhanced/changed.

That way we do not tell a new contributor his/hers work is rubbish (another 
less polite word for “revert”). Please remember the contributor did the best to 
follow the demands, so the problem is that the easyhack was accepted (in 2012) 
and nobody cared to give more implementation advice, before the work was done.

Sorry for a frank mail on a friday afternoon, but this is slowly becoming a 
bigger problem. We have enough problems helping new contributors become skilled 
LO developers, there are absolutely no need to create more problems.

rgds
jan I.

> On 14 Oct 2016, at 19:10, bugzilla-dae...@bugs.documentfoundation.org wrote:
> 
> 
> Comment # 22  
> on bug 46279  from 
> Heiko Tietze 
> As discussed in the UX meeting Oct/14 the recommendation is to revert the
> patch; and in general to add the restart option to the extension 
> specification.
> 
> You are receiving this mail because:
> You are on the CC list for the bug.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 103220] UI is broken with GTK 3.22 on HiDPI screens

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103220

--- Comment #2 from Khaled Hosny  ---
No problem with non-HiDPI screens.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103159] unable to compile in 12.04: Namespace prefix manifest on file-entry is not defined"

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103159

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 QA Contact||jl...@mail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 89317] Table corrupted when saved as doc

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=89317

Justin L  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Assignee|libreoffice-b...@lists.free |jl...@mail.com
   |desktop.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103220] UI is broken with GTK 3.22 on HiDPI screens

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103220

--- Comment #1 from Khaled Hosny  ---
Created attachment 128014
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128014=edit
Screenshot

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103220] New: UI is broken with GTK 3.22 on HiDPI screens

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103220

Bug ID: 103220
   Summary: UI is broken with GTK 3.22 on HiDPI screens
   Product: LibreOffice
   Version: 5.2.2.2 release
  Hardware: All
OS: Linux (All)
Status: UNCONFIRMED
  Severity: major
  Priority: medium
 Component: UI
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: khaledho...@eglug.org

Description:
After upgarding to GTK 3.22, the UI became completely unusable. Only 1 quarter
of the document area is drawn and everything inside it seems to be 2x scaled.
The menu bar is drawn fine, but the menus are displaced and cropped, and
eventually the application would crash after repeatedly opening the menus. The
console shows the following errors and warnings (after I start opening the
menus):

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed

(soffice:28076): Gtk-CRITICAL **: gtk_widget_get_preferred_height_for_width:
assertion 'width >= 0' failed
*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug


(soffice:28076): Gtk-WARNING **: GtkAccelLabel 0x6167780 attempted to adjust
its size allocation from 6,1594303988 109x797151984 to 6,1992879970 109x19.
adjust_size_allocation must keep allocation inside original bounds
*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug


(soffice:28076): Gtk-WARNING **: GtkAccelLabel 0x6157d60 attempted to adjust
its size allocation from 6,2082248644 109x797151984 to 6,-1814142670 109x19.
adjust_size_allocation must keep allocation inside original bounds
*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a

[Libreoffice-bugs] [Bug 103077] Can't connect to an existing Mariadb data base with ODBC ( unixODBC or iODBC) using Mariadb ODBC connector

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103077

--- Comment #22 from Julien Nabet  ---
Would this patch help?
diff --git a/connectivity/source/drivers/odbc/ODatabaseMetaData.cxx
b/connectivity/source/drivers/odbc/ODatabaseMetaData.cxx
index 65336c2..992f3b5 100644
--- a/connectivity/source/drivers/odbc/ODatabaseMetaData.cxx
+++ b/connectivity/source/drivers/odbc/ODatabaseMetaData.cxx
@@ -50,6 +50,16 @@ ODatabaseMetaData::ODatabaseMetaData(const SQLHANDLE
_pHandle,OConnection* _pCon
 try
 {
 m_bUseCatalog   = !(usesLocalFiles() || usesLocalFilePerTable());
+}
+catch(SQLException& )
+{ // doesn't matter here
+}
+catch(RuntimeException& )
+{
+m_bUseCatalog = true;
+}
+try
+{
 OUString sVersion = getDriverVersion();
 m_bOdbc3=  sVersion != "02.50" && sVersion != "02.00";
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102936] ALL LO v5.2.2.2 Modules get Crash Dialog on Exit

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102936

--- Comment #5 from Buovjaga  ---
Ok, that doesn't look like a backtrace. If you have any problems with the
process, you can join us on IRC:
https://wiki.documentfoundation.org/QA/GetInvolved#Contact

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103077] Can't connect to an existing Mariadb data base with ODBC ( unixODBC or iODBC) using Mariadb ODBC connector

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103077

--- Comment #21 from Julien Nabet  ---
Lionel:
I retrieved sources of MariaDB odbc.
In file ma_connection.c, in this function::
SQLRETURN MADB_DbcGetInfo(MADB_Dbc *Dbc, SQLUSMALLINT InfoType, SQLPOINTER
InfoValuePtr,
  SQLSMALLINT BufferLength, SQLSMALLINT
*StringLengthPtr, my_bool isWChar)

I noticed this:
   1169   case SQL_FILE_USAGE:
   1170 MADB_SET_NUM_VAL(SQLUINTEGER, InfoValuePtr, SQL_FILE_NOT_SUPPORTED,
StringLengthPtr);
   1171 break;
...

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102868] No "jump back" option, after jump to another cell ( with Cell Name box, TLHC of the sheet), to return to the previous cell address

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102868

--- Comment #8 from Dean  ---
A widget would be fine.  Keystrokes work for me as well.

It occurred to me after posting my previous comment that "RETURN" would
probably NOT be the best choice, if that was the method that you chose.  I
suspect that anybody doing financial calculations could be interested in some
sort of Rate of Return, and might want to abbreviate it to RETURN.  Just a
thought..

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 46279] Show restart message after extension installation or update menu automatically

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=46279

--- Comment #22 from Heiko Tietze  ---
As discussed in the UX meeting Oct/14 the recommendation is to revert the
patch; and in general to add the restart option to the extension specification.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102868] No "jump back" option, after jump to another cell ( with Cell Name box, TLHC of the sheet), to return to the previous cell address

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102868

--- Comment #8 from Dean  ---
A widget would be fine.  Keystrokes work for me as well.

It occurred to me after posting my previous comment that "RETURN" would
probably NOT be the best choice, if that was the method that you chose.  I
suspect that anybody doing financial calculations could be interested in some
sort of Rate of Return, and might want to abbreviate it to RETURN.  Just a
thought..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-bugs] [Bug 102493] FILESAVE: save to HTML, list elements formatted incorrectly

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102493

V Stuart Foote  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW
 CC||vstuart.fo...@utsa.edu

--- Comment #5 from V Stuart Foote  ---
Confirmed New -> HTML Document and enabling a bullets, then typing several
lines into the list.

On save the HTML 4 or 5 tag should be 

entry first
entry second


But here the  to start each list item is weird. Browsers deal with it, but
it is not HTML

Version: 5.2.2.2 (x64)
Build ID: 8f96e87c890bf8fa77463cd4b640a2312823f3ad
CPU Threads: 8; OS Version: Windows 6.19; UI Render: GL; 
Locale: en-US (en_US); Calc: group

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 58622] EDITING: Missing space after the number and point (regression)

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=58622

Miklos Vajna  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #19 from Miklos Vajna  ---
Björn, the mentioned commit doesn't seem to be relevant, it's the numbering
manager of the DOCX import, while here the bug is about an ODT import and PDF
export.

To the reporter: can you still reproduce this problem? There is one ODT
attached to this bugreport. With that, I tried to do PDF export with LO 3.6 and
4.0, but I don't see any difference on the "10. xxx" lines.

The other 3 attachments are PNG files, so they are not relevant. Is there still
something to fix here?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103219] New: Renaming Images is Wrong if New Name Already Exists

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103219

Bug ID: 103219
   Summary: Renaming Images is Wrong if New Name Already Exists
   Product: LibreOffice
   Version: Inherited From OOo
  Hardware: All
OS: Windows (All)
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Writer
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: harald.koes...@mail.de

Steps to reproduce:
[1] Create new text document and insert 2 images.
[2] Open Navigator. Two images with names 'Image1' and 'Image2' are displayed.
[3] Working area: Right click on 'Image1' > Properties… > Tab 'Options'
[4] Insert new name, then OK. Name is changed to new name in Navigator.
[5] Working area: Right click on 'Image2' > Properties… > Tab 'Options'
[6] Insert same name as in step 4, then OK. Name changes from 'Image2' to
'Image1' in Navigator. Expected: Either error message, that name already exists
or button 'OK' should be greyed, when same name is inserted (equal if you
rename image in Navigator).

Used version: 5.2.2.2 release.

Bug already exists in version 3.3.0 with slight differences of the user
interface. Hence inherited from OOo.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103178] Calc crashes after adding text to a chart

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103178

Julien Nabet  changed:

   What|Removed |Added

   Keywords||haveBacktrace

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103178] Calc crashes after adding text to a chart

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103178

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #3 from Julien Nabet  ---
Created attachment 128013
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128013=edit
bt with symbols

On pc Debian x86-64 with master sources updated yesterday, I could reproduce
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/source

2016-10-14 Thread Miklos Vajna

 sc/source/ui/view/tabview3.cxx |1 +
 1 file changed, 1 insertion(+)

New commits:
commit d7afcb0e72aaa1c8f55b6a82fa40bebc6565c283
Author: Miklos Vajna 
Date:   Fri Oct 14 18:30:30 2016 +0200

sc: silence loplugin:staticmethods

Where it complains about one specialization, but other ones can't be
static.

Change-Id: I031ddb795914c778f363b11ba16065e2b372b381

diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index 6c387bf..41a0679 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -128,6 +128,7 @@ void ScExtraEditViewManager::Apply(SfxViewShell* 
pViewShell, ScSplitPos eWhich)
 template
 void ScExtraEditViewManager::Modifier(ScGridWindow* /*pWin*/)
 {
+(void)this;
 SAL_WARN("sc", "ScExtraEditViewManager::Modifier: 
non-specialized version should not be invoked.");
 }
 
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

--- Comment #5 from Commit Notification 
 ---
lbenes committed a patch related to this issue.
It has been pushed to "libreoffice-5-2":

http://cgit.freedesktop.org/libreoffice/core/commit/?id=24998064599e3371208ad8ae4b149d754828d35b=libreoffice-5-2

tdf#102997 Fix Error in OOXML Transparency Conversion Math

It will be available in 5.2.4.

The patch should be included in the daily builds available at
http://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
http://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102997] FILEOPEN: Error in OOXML Transparency Conversion Math

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102997

Commit Notification  changed:

   What|Removed |Added

 Whiteboard|target:5.3.0|target:5.3.0 target:5.2.4

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'libreoffice-5-2' - oox/source sw/qa

2016-10-14 Thread lbenes

 oox/source/drawingml/fillproperties.cxx  |2 +-
 sw/qa/extras/ooxmlimport/data/tdf100830.docx |binary
 sw/qa/extras/ooxmlimport/ooxmlimport.cxx |2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 24998064599e3371208ad8ae4b149d754828d35b
Author: lbenes 
Date:   Thu Oct 6 15:57:22 2016 -0400

tdf#102997 Fix Error in OOXML Transparency Conversion Math

This fixes the import logic for tdf#100830 to handle transparencies other 
than 50%.

(cherry picked from commit ade43e6a86e4f864e771f4b3008a428bc10fa55f)

Conflicts:
oox/source/drawingml/fillproperties.cxx

Change-Id: If4e2e369a9674488878bb0a4378d48292ea4e0cb
Reviewed-on: https://gerrit.libreoffice.org/29830
Reviewed-by: Michael Stahl 
Tested-by: Jenkins 

diff --git a/oox/source/drawingml/fillproperties.cxx 
b/oox/source/drawingml/fillproperties.cxx
index c283212..81a3747 100644
--- a/oox/source/drawingml/fillproperties.cxx
+++ b/oox/source/drawingml/fillproperties.cxx
@@ -655,7 +655,7 @@ void FillProperties::pushToPropMap( ShapePropertyMap& 
rPropMap,
 }
 
 if (maBlipProps.moAlphaModFix.has())
-rPropMap.setProperty(SHAPEPROP_FillTransparency, 
static_cast(maBlipProps.moAlphaModFix.get() / PER_PERCENT));
+rPropMap.setProperty(SHAPEPROP_FillTransparency, 
static_cast(100 - (maBlipProps.moAlphaModFix.get() / PER_PERCENT)));
 }
 break;
 
diff --git a/sw/qa/extras/ooxmlimport/data/tdf100830.docx 
b/sw/qa/extras/ooxmlimport/data/tdf100830.docx
old mode 100644
new mode 100755
index a51b890..6c43217
Binary files a/sw/qa/extras/ooxmlimport/data/tdf100830.docx and 
b/sw/qa/extras/ooxmlimport/data/tdf100830.docx differ
diff --git a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx 
b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
index 59a015b..417af48 100644
--- a/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
+++ b/sw/qa/extras/ooxmlimport/ooxmlimport.cxx
@@ -3248,7 +3248,7 @@ DECLARE_OOXMLIMPORT_TEST(testTdf99140, "tdf99140.docx")
 DECLARE_OOXMLIMPORT_TEST(testTdf100830, "tdf100830.docx")
 {
 // FillTransparence wasn't imported, this was 0.
-CPPUNIT_ASSERT_EQUAL(static_cast(50), 
getProperty(getShape(1), "FillTransparence"));
+CPPUNIT_ASSERT_EQUAL(static_cast(30), 
getProperty(getShape(1), "FillTransparence"));
 }
 
 CPPUNIT_PLUGIN_IMPLEMENT();
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz

2016-10-14 Thread Khaled Hosny

Rebased ref, commits from common ancestor:
commit 7ea4cca3d3a1912e59e113d756ed3fe1662f96fb
Author: Khaled Hosny 
Date:   Fri Oct 14 02:50:27 2016 -0700

Support font fallback on macOS for CommonSalLayout

Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index f7e5156..6958541 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -102,6 +102,8 @@ public:
 hb_font_t* GetHbFont() const { return mpHbFont; }
 void   SetHbFont(hb_font_t* pHbFont) const { mpHbFont = pHbFont; }
 
+CFMutableDictionaryRef  GetStyleDict( void ) const { return mpStyleDict; }
+
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
 float   mfFontStretch;
@@ -113,11 +115,6 @@ private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
 mutable hb_font_t*  mpHbFont;
-
-friend class CTLayout;
-friend class AquaSalGraphics;
-friend class CommonSalLayout;
-CFMutableDictionaryRef  GetStyleDict( void ) const { return mpStyleDict; }
 };
 
 // TODO: move into cross-platform headers
@@ -172,8 +169,8 @@ protected:
 RGBAColor   maFillColor;
 
 // Device Font settings
-const CoreTextFontFace* mpFontData;
-CoreTextStyle*  mpTextStyle;
+const CoreTextFontFace* mpFontData[MAX_FALLBACK];
+CoreTextStyle*  mpTextStyle[MAX_FALLBACK];
 RGBAColor   maTextColor;
 /// allows text to be rendered without antialiasing
 boolmbNonAntialiasedText;
diff --git a/vcl/quartz/ctlayout.cxx b/vcl/quartz/ctlayout.cxx
index 856e066..983f50b 100644
--- a/vcl/quartz/ctlayout.cxx
+++ b/vcl/quartz/ctlayout.cxx
@@ -28,7 +28,6 @@
 #include "quartz/ctfonts.hxx"
 #include "CTRunData.hxx"
 #include "quartz/utils.h"
-#include "CommonSalLayout.hxx"
 
 
 class CTLayout : public SalLayout
@@ -782,10 +781,7 @@ void CTLayout::Simplify( bool /*bIsBase*/ ) {}
 
 SalLayout* CoreTextStyle::GetTextLayout() const
 {
-if (SalLayout::UseCommonLayout())
-return new CommonSalLayout(*this);
-else
-return new CTLayout(this);
+return new CTLayout(this);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index bb99737..caa7e35 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -42,6 +42,8 @@
 #include "impfontcharmap.hxx"
 #include "impfontmetricdata.hxx"
 #include "CommonSalLayout.hxx"
+#include "outdev.h"
+#include "PhysicalFontCollection.hxx"
 
 #ifdef MACOSX
 #include "osx/salframe.h"
@@ -55,6 +57,49 @@
 
 using namespace vcl;
 
+class CoreTextGlyphFallbackSubstititution
+:public ImplGlyphFallbackFontSubstitution
+{
+public:
+bool FindFontSubstitute(FontSelectPattern&, OUString&) const override;
+};
+
+bool 
CoreTextGlyphFallbackSubstititution::FindFontSubstitute(FontSelectPattern& 
rPattern,
+OUString& rMissingChars) const
+{
+bool bFound = false;
+CoreTextStyle rStyle(rPattern);
+CTFontRef pFont = 
static_cast(CFDictionaryGetValue(rStyle.GetStyleDict(), 
kCTFontAttributeName));
+CFStringRef pStr = CreateCFString(rMissingChars);
+if (pStr)
+{
+CTFontRef pFallback = CTFontCreateForString(pFont, pStr, 
CFRangeMake(0, CFStringGetLength(pStr)));
+if (pFallback)
+{
+bFound = true;
+
+CTFontDescriptorRef pDesc = CTFontCopyFontDescriptor(pFallback);
+FontAttributes rAttr = DevFontFromCTFontDescriptor(pDesc, nullptr);
+
+rPattern.maSearchName = rAttr.GetFamilyName();
+
+rPattern.SetWeight(rAttr.GetWeight());
+rPattern.SetItalic(rAttr.GetItalic());
+rPattern.SetPitch(rAttr.GetPitch());
+rPattern.SetWidthType(rAttr.GetWidthType());
+
+SalData* pSalData = GetSalData();
+if (pSalData->mpFontList)
+rPattern.mpFontData = 
pSalData->mpFontList->GetFontDataFromId(reinterpret_cast(pDesc));
+
+CFRelease(pFallback);
+}
+CFRelease(pStr);
+}
+
+return bFound;
+}
+
 CoreTextFontFace::CoreTextFontFace( const CoreTextFontFace& rSrc )
   : PhysicalFontFace( rSrc )
   , mnFontId( rSrc.mnFontId )
@@ -245,8 +290,6 @@ AquaSalGraphics::AquaSalGraphics()
 , mxClipPath( nullptr )
 , maLineColor( COL_WHITE )
 , maFillColor( COL_BLACK )
-, mpFontData( nullptr )
-, mpTextStyle( nullptr )
 , maTextColor( COL_BLACK )
 , mbNonAntialiasedText( false )
 , mbPrinter( false )
@@ -258,6 +301,12 @@ AquaSalGraphics::AquaSalGraphics()
 #endif
 {
 SAL_INFO( "vcl.quartz", "AquaSalGraphics::AquaSalGraphics() this=" << this 
);
+
+for (int i = 0; i < MAX_FALLBACK; ++i)
+{
+mpTextStyle[i] = nullptr;
+

[Libreoffice-commits] core.git: xmlsecurity/source

2016-10-14 Thread Miklos Vajna

 xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx |6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit 28fcdc4fecd373c8142376532004528d3d619306
Author: Miklos Vajna 
Date:   Fri Oct 14 18:09:31 2016 +0200

xmlsecurity: avoid checking storage streams of PDF files

DocumentSignatureHelper::isOOo3_2_Signature() checks if the manifest
stream of the ZIP package is signed. A PDF file has no storage, so don't
do that check for that format.

With this, a valid PDF signature is shown as valid in the Digital
Signatures dialog as well.

Change-Id: I58c1cbd665b7c5894d1cfa193061a9370f76c8c4

diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx 
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index d99590a..c82cff0 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -508,9 +508,11 @@ void DigitalSignaturesDialog::ImplFillSignaturesBox()
 }
 //Check if the signature is a "old" document signature, that is, 
which was created
 //by an version of OOo previous to 3.2
+// If there is no storage, then it's pointless to check storage
+// stream references.
 else if (maSignatureManager.meSignatureMode == 
SignatureModeDocumentContent
-&& bSigValid && bCertValid && 
!DocumentSignatureHelper::isOOo3_2_Signature(
-maSignatureManager.maCurrentSignatureInformations[n]))
+&& bSigValid && bCertValid && (maSignatureManager.mxStore.is() 
&& !DocumentSignatureHelper::isOOo3_2_Signature(
+maSignatureManager.maCurrentSignatureInformations[n])))
 {
 aImage = m_pSigsNotvalidatedImg->GetImage();
 bAllNewSignatures &= false;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: sc/source

2016-10-14 Thread Marco Cecchetti

 sc/source/ui/inc/viewdata.hxx  |2 ++
 sc/source/ui/view/viewdata.cxx |   20 +++-
 2 files changed, 21 insertions(+), 1 deletion(-)

New commits:
commit e5e461dd60e7d104f6eb1187949c161372e7b02e
Author: Marco Cecchetti 
Date:   Wed Oct 12 21:41:26 2016 +0200

tdf#103211 Calc: it is insane to call EditGrowX/Y while the edit view is 
growing.

That could occur because of the call to SetDefaultItem later.
We end up with wrong start/end edit columns and the changes
to the output area performed by the inner call to EditGrowX are
useless since they are discarded by the outer call.

In the inner call the output area is not the new one computed by the
outer call, on the contrary the data field `nEditStartCol` and
`nEditEndCol` have been already modified, so the inner call would
modify them using the wrong output area width.

Maybe the call to SetDefaultItem should be performed in another place,
anyway the outer call takes into account the correct horizontal adjust
when computing the new start/end edit columns and the new left/right
output area.

Change-Id: I56d038f33ab9d1933c4c6cd1db6d9cd012fb6db1
Reviewed-on: https://gerrit.libreoffice.org/29784
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/source/ui/inc/viewdata.hxx b/sc/source/ui/inc/viewdata.hxx
index 4986e1f..9323dad 100644
--- a/sc/source/ui/inc/viewdata.hxx
+++ b/sc/source/ui/inc/viewdata.hxx
@@ -227,6 +227,8 @@ private:
 boolbSelCtrlMouseClick:1;   // special selection 
handling for ctrl-mouse-click
 boolbMoveArea:1;
 
+boolbGrowing;
+
 longm_nLOKPageUpDownOffset;
 
 DECL_DLLPRIVATE_LINK( EditEngineHdl, EditStatus&, void );
diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index a569559..b37af92 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -60,9 +60,10 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
-#include 
 
 #include 
 #include 
@@ -356,6 +357,7 @@ ScViewData::ScViewData( ScDocShell* pDocSh, ScTabViewShell* 
pViewSh ) :
 bPagebreak  ( false ),
 bSelCtrlMouseClick( false ),
 bMoveArea ( false ),
+bGrowing (false),
 m_nLOKPageUpDownOffset( 0 )
 {
 mpMarkData->SelectOneTable(0); // Sync with nTabNo
@@ -447,6 +449,7 @@ ScViewData::ScViewData( const ScViewData& rViewData ) :
 bPagebreak  ( rViewData.bPagebreak ),
 bSelCtrlMouseClick( rViewData.bSelCtrlMouseClick ),
 bMoveArea ( rViewData.bMoveArea ),
+bGrowing( rViewData.bGrowing ),
 m_nLOKPageUpDownOffset( rViewData.m_nLOKPageUpDownOffset )
 {
 
@@ -1201,6 +1204,16 @@ IMPL_LINK( ScViewData, EditEngineHdl, EditStatus&, 
rStatus, void )
 
 void ScViewData::EditGrowX()
 {
+// It is insane to call EditGrowX while the output area is already growing.
+// That could occur because of the call to SetDefaultItem later.
+// We end up with wrong start/end edit columns and the changes
+// to the output area performed by the inner call to this method are
+// useless since they are discarded by the outer call.
+if (bGrowing)
+return;
+
+comphelper::FlagRestorationGuard aFlagGuard(bGrowing, true);
+
 ScDocument* pLocalDoc = GetDocument();
 
 ScSplitPos eWhich = GetActivePart();
@@ -1387,6 +1400,11 @@ void ScViewData::EditGrowX()
 
 void ScViewData::EditGrowY( bool bInitial )
 {
+if (bGrowing)
+return;
+
+comphelper::FlagRestorationGuard aFlagGuard(bGrowing, true);
+
 ScSplitPos eWhich = GetActivePart();
 ScVSplitPos eVWhich = WhichV(eWhich);
 EditView* pCurView = pEditView[eWhich];
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 103213] Database Wizard froze after changing from Forms to Tables [ Version: 5.2.2.2 (x64)] when attempting to open a linked Access MDB file

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103213

Julien Nabet  changed:

   What|Removed |Added

 CC||serval2...@yahoo.fr

--- Comment #4 from Julien Nabet  ---
The pb is LO doesn't find Buecher.mdb

In your case, if you put Buecher.odb in: c:\temp\database,
you must have Buecher.mdb in c:\temp

Indeed, unzipping your odb file and reading content.xml, I found this:


Could you check and give a feedback?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103213] Database Wizard froze after changing from Forms to Tables [ Version: 5.2.2.2 (x64)] when attempting to open a linked Access MDB file

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103213

--- Comment #3 from Alex Thurgood  ---
The reported behaviour is similar to bug 97395, possible DUP.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103213] Database Wizard froze after changing from Forms to Tables [ Version: 5.2.2.2 (x64)] when attempting to open a linked Access MDB file

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103213

Alex Thurgood  changed:

   What|Removed |Added

Summary|Database Wizard froze after |Database Wizard froze after
   |changing from Forms to  |changing from Forms to
   |Tables [Version: 5.2.2.2|Tables [Version: 5.2.2.2
   |(x64)]  |(x64)] when attempting to
   ||open a linked Access MDB
   ||file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103213] Database Wizard froze after changing from Forms to Tables [ Version: 5.2.2.2 (x64)]

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103213

Alex Thurgood  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDINFO
 Ever confirmed|0   |1

--- Comment #2 from Alex Thurgood  ---
OK, so what you "forgot" to mention is that your ODB file links to an Access
mdb file (Buecher/mdb).

For that to work on a 64bit version of LibreOffice you need the 64bit version
of the Microsoft Data Access Component, unless you were previously accessing
the file via ODBC (which you don't say).

Please provide complete details of the setup you were using to gain access to
the mdb file, including any drivers used (Jet, DAC, ODBC, etc).


Setting to NEEDINFO, please set back to UNCONFIRMED once you have provided the
required information.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: Branch 'private/jmux/sorted-pagedesc+spzfrmfmts' - 0 commits -

2016-10-14 Thread Unknown

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: Branch 'private/jmux/fast-mm-5-0' - 0 commits -

2016-10-14 Thread Unknown

Rebased ref, commits from common ancestor:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: formula/source sc/source

2016-10-14 Thread Winfried Donkers

 formula/source/core/api/token.cxx |   16 
 sc/source/core/inc/interpre.hxx   |3 +--
 sc/source/core/tool/interpr3.cxx  |   38 ++
 sc/source/core/tool/interpr4.cxx  |4 ++--
 sc/source/ui/src/scfuncs.src  |   10 +-
 5 files changed, 38 insertions(+), 33 deletions(-)

New commits:
commit cf43ff5262a111f9fbebe58d254b704ec057cbf6
Author: Winfried Donkers 
Date:   Thu Oct 13 13:49:18 2016 +0200

tdf#102948 Make HYPGEOMDIST ODFF1.2 compliant.

Also reduce duplicate code.
On Export to OOXML, HYPGEOMDIST is converted to HYPGEOM.DIST.

Change-Id: I70a70ee6b5c542e272ef574073ebcd1924f31083
Reviewed-on: https://gerrit.libreoffice.org/29767
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/formula/source/core/api/token.cxx 
b/formula/source/core/api/token.cxx
index 7d5528c..a9abdd0 100644
--- a/formula/source/core/api/token.cxx
+++ b/formula/source/core/api/token.cxx
@@ -,10 +,12 @@ inline bool MissingConventionOOXML::isRewriteNeeded( 
OpCode eOp )
 case ocPoissonDist:
 case ocNormDist:
 case ocLogNormDist:
+case ocHypGeomDist:
 
 case ocDBCount:
 case ocDBCount2:
 return true;
+
 default:
 return false;
 }
@@ -1244,6 +1246,14 @@ void FormulaMissingContext::AddMoreArgs( 
FormulaTokenArray *pNewArr, const Missi
 }
 break;
 
+case ocHypGeomDist:
+if ( mnCurArg == 3 )
+{
+pNewArr->AddOpCode( ocSep );
+pNewArr->AddDouble( 0.0 );  // 5th, Cumulative 
= false()
+}
+break;
+
 case ocRound:
 case ocRoundUp:
 case ocRoundDown:
@@ -1515,6 +1525,12 @@ FormulaTokenArray * FormulaTokenArray::RewriteMissing( 
const MissingConvention &
 ( pCur->GetOpCode() == ocCeil ? ocCeil_Math : 
ocFloor_Math ) );
 pNewArr->Add( pToken );
 }
+else if ( pCur->GetOpCode() == ocHypGeomDist &&
+  rConv.getConvention() == 
MissingConvention::FORMULA_MISSING_CONVENTION_OOXML )
+{
+FormulaToken *pToken = new FormulaToken( svByte, 
ocHypGeomDist_MS );
+pNewArr->Add( pToken );
+}
 else
 pNewArr->AddToken( *pCur );
 }
diff --git a/sc/source/core/inc/interpre.hxx b/sc/source/core/inc/interpre.hxx
index fadd474..47d5afd 100644
--- a/sc/source/core/inc/interpre.hxx
+++ b/sc/source/core/inc/interpre.hxx
@@ -866,8 +866,7 @@ void ScCombinA();
 void ScPermut();
 void ScPermutationA();
 void ScB();
-void ScHypGeomDist();
-void ScHypGeomDist_MS();
+void ScHypGeomDist( int nMinParamCount );
 void ScLogNormDist( int nMinParamCount );
 void ScLogNormInv();
 void ScTDist();
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index 18f8e33..04b0343 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -1844,39 +1844,21 @@ static void lcl_PutFactorialElements( ::std::vector< 
double >& cn, double fLower
 
 @see #i47296#
 
- */
-void ScInterpreter::ScHypGeomDist()
-{
-if ( !MustHaveParamCount( GetByte(), 4 ) )
-return;
-
-double N = ::rtl::math::approxFloor(GetDouble());
-double M = ::rtl::math::approxFloor(GetDouble());
-double n = ::rtl::math::approxFloor(GetDouble());
-double x = ::rtl::math::approxFloor(GetDouble());
-
-if( (x < 0.0) || (n < x) || (M < x) || (N < n) || (N < M) || (x < n - N + 
M) )
-{
-PushIllegalArgument();
-return;
-}
-
-PushDouble( GetHypGeomDist( x, n, M, N ) );
-}
-
-/** Calculates a value of the hypergeometric distribution (Excel 2010 
function).
-
-This function has an extra argument bCumulative as compared to 
ScHypGeomDist(),
-which only calculates the non-cumulative distribution.
+This function has an extra argument bCumulative,
+which only calculates the non-cumulative distribution and
+which is optional in Calc and mandatory with Excel's HYPGEOM.DIST()
 
 @see fdo#71722
-*/
-void ScInterpreter::ScHypGeomDist_MS()
+@see tdf#102948, make Calc function ODFF1.2-compliant
+
+ */
+void ScInterpreter::ScHypGeomDist( int nMinParamCount )
 {
-if ( !MustHaveParamCount( GetByte(), 5 ) )
+sal_uInt8 nParamCount = GetByte();
+if ( !MustHaveParamCount( nParamCount, nMinParamCount, 5 ) )
 return;
 
-bool bCumulative = GetBool();
+bool bCumulative = ( nParamCount == 5 && GetBool() );
 double N = ::rtl::math::approxFloor(GetDouble());
 double M = ::rtl::math::approxFloor(GetDouble());
 double

[Libreoffice-commits] core.git: Branch 'feature/commonsallayout' - vcl/inc vcl/quartz

2016-10-14 Thread Khaled Hosny

Rebased ref, commits from common ancestor:
commit 06971a9d9a17e73c8f589df1f9a0402c8ce8cab7
Author: Khaled Hosny 
Date:   Fri Oct 14 02:50:27 2016 -0700

Support font fallback on macOS for CommonSalLayout

Change-Id: Ifd26b7f14ed77a3aa2a38e5961cac5f9bbb6d796

diff --git a/vcl/inc/quartz/salgdi.h b/vcl/inc/quartz/salgdi.h
index f7e5156..6958541 100644
--- a/vcl/inc/quartz/salgdi.h
+++ b/vcl/inc/quartz/salgdi.h
@@ -102,6 +102,8 @@ public:
 hb_font_t* GetHbFont() const { return mpHbFont; }
 void   SetHbFont(hb_font_t* pHbFont) const { mpHbFont = pHbFont; }
 
+CFMutableDictionaryRef  GetStyleDict( void ) const { return mpStyleDict; }
+
 const CoreTextFontFace*  mpFontData;
 /// <1.0: font is squeezed, >1.0 font is stretched, else 1.0
 float   mfFontStretch;
@@ -113,11 +115,6 @@ private:
 /// CoreText text style object
 CFMutableDictionaryRef  mpStyleDict;
 mutable hb_font_t*  mpHbFont;
-
-friend class CTLayout;
-friend class AquaSalGraphics;
-friend class CommonSalLayout;
-CFMutableDictionaryRef  GetStyleDict( void ) const { return mpStyleDict; }
 };
 
 // TODO: move into cross-platform headers
@@ -172,8 +169,8 @@ protected:
 RGBAColor   maFillColor;
 
 // Device Font settings
-const CoreTextFontFace* mpFontData;
-CoreTextStyle*  mpTextStyle;
+const CoreTextFontFace* mpFontData[MAX_FALLBACK];
+CoreTextStyle*  mpTextStyle[MAX_FALLBACK];
 RGBAColor   maTextColor;
 /// allows text to be rendered without antialiasing
 boolmbNonAntialiasedText;
diff --git a/vcl/quartz/ctlayout.cxx b/vcl/quartz/ctlayout.cxx
index 856e066..983f50b 100644
--- a/vcl/quartz/ctlayout.cxx
+++ b/vcl/quartz/ctlayout.cxx
@@ -28,7 +28,6 @@
 #include "quartz/ctfonts.hxx"
 #include "CTRunData.hxx"
 #include "quartz/utils.h"
-#include "CommonSalLayout.hxx"
 
 
 class CTLayout : public SalLayout
@@ -782,10 +781,7 @@ void CTLayout::Simplify( bool /*bIsBase*/ ) {}
 
 SalLayout* CoreTextStyle::GetTextLayout() const
 {
-if (SalLayout::UseCommonLayout())
-return new CommonSalLayout(*this);
-else
-return new CTLayout(this);
+return new CTLayout(this);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index bb99737..a7895c3 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -42,6 +42,8 @@
 #include "impfontcharmap.hxx"
 #include "impfontmetricdata.hxx"
 #include "CommonSalLayout.hxx"
+#include "outdev.h"
+#include "PhysicalFontCollection.hxx"
 
 #ifdef MACOSX
 #include "osx/salframe.h"
@@ -55,6 +57,49 @@
 
 using namespace vcl;
 
+class CoreTextGlyphFallbackSubstititution
+:public ImplGlyphFallbackFontSubstitution
+{
+public:
+bool FindFontSubstitute(FontSelectPattern&, OUString&) const override;
+};
+
+bool 
CoreTextGlyphFallbackSubstititution::FindFontSubstitute(FontSelectPattern& 
rPattern,
+OUString& rMissingChars) const
+{
+bool bFound = false;
+CoreTextStyle rStyle(rPattern);
+CTFontRef pFont = 
static_cast(CFDictionaryGetValue(rStyle.GetStyleDict(), 
kCTFontAttributeName));
+CFStringRef pStr = CreateCFString(rMissingChars);
+if (pStr)
+{
+CTFontRef pFallback = CTFontCreateForString(pFont, pStr, 
CFRangeMake(0, CFStringGetLength(pStr)));
+if (pFallback)
+{
+bFound = true;
+
+CTFontDescriptorRef pDesc = CTFontCopyFontDescriptor(pFallback);
+FontAttributes rAttr = DevFontFromCTFontDescriptor(pDesc, nullptr);
+
+rPattern.maSearchName = rAttr.GetFamilyName();
+
+rPattern.SetWeight(rAttr.GetWeight());
+rPattern.SetItalic(rAttr.GetItalic());
+rPattern.SetPitch(rAttr.GetPitch());
+rPattern.SetWidthType(rAttr.GetWidthType());
+
+SalData* pSalData = GetSalData();
+if (pSalData->mpFontList)
+rPattern.mpFontData = 
pSalData->mpFontList->GetFontDataFromId(reinterpret_cast(pDesc));
+
+CFRelease(pFallback);
+}
+CFRelease(pStr);
+}
+
+return bFound;
+}
+
 CoreTextFontFace::CoreTextFontFace( const CoreTextFontFace& rSrc )
   : PhysicalFontFace( rSrc )
   , mnFontId( rSrc.mnFontId )
@@ -245,8 +290,6 @@ AquaSalGraphics::AquaSalGraphics()
 , mxClipPath( nullptr )
 , maLineColor( COL_WHITE )
 , maFillColor( COL_BLACK )
-, mpFontData( nullptr )
-, mpTextStyle( nullptr )
 , maTextColor( COL_BLACK )
 , mbNonAntialiasedText( false )
 , mbPrinter( false )
@@ -258,6 +301,12 @@ AquaSalGraphics::AquaSalGraphics()
 #endif
 {
 SAL_INFO( "vcl.quartz", "AquaSalGraphics::AquaSalGraphics() this=" << this 
);
+
+for (int i = 0; i < MAX_FALLBACK; ++i)
+{
+mpTextStyle[i] = nullptr;
+

[Libreoffice-bugs] [Bug 95957] LibreOffice 5.0.3.2 - crashes with std::bad_alloc

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95957

--- Comment #27 from Keith Refson  ---
Adi - your symptoms seem different and point to a different bug.

I see the same behaviour first reported, namely, LO will start up without any
file.  However any attempt to open a file opens up the sub-component window,
but which immediately fails, displaying an error message window containing
"std::bad_alloc".  LO exits upon clicking the OK button.

You reported that
"LibreOffice crashes Plasma (and/or X) on opening any type of file "

which is clearly different.  I do not see that behaviour, and that is not what
the original reporter stated either.

I suggest that this is clearly a separate issue, and you should open a new bug
report.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: editeng/source include/editeng sc/source

2016-10-14 Thread Marco Cecchetti

 editeng/source/editeng/editview.cxx |   25 ++--
 editeng/source/editeng/impedit.cxx  |4 ++
 editeng/source/editeng/impedit3.cxx |8 -
 include/editeng/editview.hxx|2 +
 sc/source/ui/inc/tabview.hxx|4 +-
 sc/source/ui/view/tabview3.cxx  |   34 +++---
 sc/source/ui/view/tabview5.cxx  |6 ++--
 sc/source/ui/view/viewdata.cxx  |   54 
 8 files changed, 92 insertions(+), 45 deletions(-)

New commits:
commit d4ddc8cb005887e4b2810006425cccf12937347f
Author: Marco Cecchetti 
Date:   Tue Oct 11 22:50:53 2016 +0200

LOK: Calc: fixed missed tile invalidations on cell text editing

What's new:
1) when an edit view is killed, the area which was used by the edit
view is invalidated for both own window and other view windows after
the edit view has been destroyed;

2) when an edit view is created or its out area is expanded, the
windows of other views are invalidated too;

3) when a vertical scroll occurs in the edit view area the windows of
other view are invalidated too;

4) same methods renaming since now we add/remove windows not edit
views.

Change-Id: Iac54f5b182c9562f08bb724f9ddde1c26cffa2e7
Reviewed-on: https://gerrit.libreoffice.org/29783
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 

diff --git a/editeng/source/editeng/editview.cxx 
b/editeng/source/editeng/editview.cxx
index 63b7b30..3ada3d3 100644
--- a/editeng/source/editeng/editview.cxx
+++ b/editeng/source/editeng/editview.cxx
@@ -173,10 +173,10 @@ EditEngine* EditView::GetEditEngine() const
 return pImpEditView->pEditEngine;
 }
 
-void EditView::Invalidate()
+Rectangle EditView::GetInvalidateRect() const
 {
 if ( !pImpEditView->DoInvalidateMore() )
-pImpEditView->GetWindow()->Invalidate( pImpEditView->aOutArea );
+return pImpEditView->aOutArea;
 else
 {
 Rectangle aRect( pImpEditView->aOutArea );
@@ -185,10 +185,29 @@ void EditView::Invalidate()
 aRect.Right() += nMore;
 aRect.Top() -= nMore;
 aRect.Bottom() += nMore;
-pImpEditView->GetWindow()->Invalidate( aRect );
+return aRect;
+}
+}
+
+void EditView::InvalidateOtherViewWindows( const Rectangle& rInvRect )
+{
+if (comphelper::LibreOfficeKit::isActive())
+{
+for (auto& pWin: GetOtherViewWindows())
+{
+if (pWin)
+pWin->Invalidate( rInvRect );
+}
 }
 }
 
+void EditView::Invalidate()
+{
+const Rectangle& rInvRect = GetInvalidateRect();
+pImpEditView->GetWindow()->Invalidate( rInvRect );
+InvalidateOtherViewWindows( rInvRect );
+}
+
 void EditView::SetReadOnly( bool bReadOnly )
 {
 pImpEditView->bReadOnly = bReadOnly;
diff --git a/editeng/source/editeng/impedit.cxx 
b/editeng/source/editeng/impedit.cxx
index 7426862..f23bd81 100644
--- a/editeng/source/editeng/impedit.cxx
+++ b/editeng/source/editeng/impedit.cxx
@@ -1150,8 +1150,10 @@ Pair ImpEditView::Scroll( long ndX, long ndY, 
ScrollRangeCheck nRangeCheck )
 pOutWin->Scroll( nRealDiffX, nRealDiffY, aRect, ScrollFlags::Clip );
 
 if (comphelper::LibreOfficeKit::isActive())
+{
 // Need to invalidate the window, otherwise no tile will be 
re-painted.
-pOutWin->Invalidate();
+pEditView->Invalidate();
+}
 
 pOutWin->Update();
 pCrsr->SetPos( pCrsr->GetPos() + Point( nRealDiffX, nRealDiffY ) );
diff --git a/editeng/source/editeng/impedit3.cxx 
b/editeng/source/editeng/impedit3.cxx
index 7d30eda..1d62eba 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -289,13 +289,7 @@ void ImpEditEngine::UpdateViews( EditView* pCurView )
 // convert to window coordinates 
 aClipRect = pView->pImpEditView->GetWindowPos( aClipRect );
 pView->GetWindow()->Invalidate( aClipRect );
-
-EditView::OutWindowSet& rOutWindowSet = 
pView->GetOtherViewWindows();
-for (auto pWin: rOutWindowSet)
-{
-if (pWin)
-pWin->Invalidate(aClipRect);
-}
+pView->InvalidateOtherViewWindows( aClipRect );
 }
 }
 
diff --git a/include/editeng/editview.hxx b/include/editeng/editview.hxx
index b66486d..007f368 100644
--- a/include/editeng/editview.hxx
+++ b/include/editeng/editview.hxx
@@ -115,6 +115,8 @@ public:
 boolRemoveOtherViewWindow( vcl::Window* pWin );
 
 voidPaint( const Rectangle& rRect, OutputDevice* pTargetDevice 
= nullptr );
+Rectangle   GetInvalidateRect() const;
+voidInvalidateOtherViewWindows( const Rectangle& rInvRect );
 voidInvalidate();
 PairScroll( long nHorzScroll, long nVertScroll,

[Libreoffice-commits] core.git: 3 commits - editeng/source include/editeng sc/qa sc/source

2016-10-14 Thread Marco Cecchetti

 editeng/source/editeng/editview.cxx  |   30 +
 editeng/source/editeng/impedit.cxx   |6 -
 editeng/source/editeng/impedit.hxx   |   19 +--
 editeng/source/editeng/impedit3.cxx  |7 +
 include/editeng/editview.hxx |   10 +
 sc/qa/unit/tiledrendering/tiledrendering.cxx |   17 +++
 sc/source/ui/inc/tabview.hxx |   40 ++-
 sc/source/ui/view/gridwin4.cxx   |  140 +--
 sc/source/ui/view/tabview3.cxx   |   68 +++--
 sc/source/ui/view/viewdata.cxx   |4 
 10 files changed, 180 insertions(+), 161 deletions(-)

New commits:
commit cec94a4ecaad666f7222598fd1e2ad9ac05fb878
Author: Marco Cecchetti 
Date:   Sun Oct 9 22:06:40 2016 +0200

LOK: Calc: an edit view may be not displayed when a 2nd one is killed

- description: when in view #1 text editing of a cell is over (edit
view killed) a cell still text edited in view #2 can stop to be
painted correctly;

- reason: when an edit view is killed an
ScTabViewShell::UpdateFormulas is broadcasted to all views which in
turn ends by invoking ScViewData::SetEditEngine for already existent
edit views: if the needed output area size for the actual text content
is less then the actual output area size (once grown, output area is
never shrunk) leads to this issue;

- solution: skip to invoke ScViewData::SetEditEngine when LOK is
active and the related view is not the current view.

Change-Id: I2a97966c7c04701f0a5443aaaeb74760b622045d
Reviewed-on: https://gerrit.libreoffice.org/29627
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 
Reviewed-on: https://gerrit.libreoffice.org/29660

diff --git a/sc/source/ui/view/viewdata.cxx b/sc/source/ui/view/viewdata.cxx
index 4eb61f0..d14d721 100644
--- a/sc/source/ui/view/viewdata.cxx
+++ b/sc/source/ui/view/viewdata.cxx
@@ -970,6 +970,10 @@ void ScViewData::SetEditEngine( ScSplitPos eWhich,
 ScEditEngineDefaulter* pNewEngine,
 vcl::Window* pWin, SCCOL nNewX, SCROW nNewY )
 {
+if (comphelper::LibreOfficeKit::isActive()
+&& GetViewShell() != SfxViewShell::Current())
+return;
+
 bool bLayoutRTL = pDoc->IsLayoutRTL( nTabNo );
 ScHSplitPos eHWhich = WhichH(eWhich);
 
commit 606b69a5d3885ccda91a4dccbf0b22c634b2f2a9
Author: Marco Cecchetti 
Date:   Sun Oct 9 21:58:40 2016 +0200

LOK: Calc: if text of 2 cells overlaps, painting occurs in wrong order

- description: when text content of two near cells (edited in 2
different views) overlaps, the input content showed is the one entered
in the other view;

- reason: the edit view of other views was painted after the edit view
owned by the current view;

Change-Id: I7c47f63bc46f7ce43fc494f018167918d44314b6
Reviewed-on: https://gerrit.libreoffice.org/29626
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 
Reviewed-on: https://gerrit.libreoffice.org/29659

diff --git a/sc/source/ui/view/gridwin4.cxx b/sc/source/ui/view/gridwin4.cxx
index 6d329cb..15edd26 100644
--- a/sc/source/ui/view/gridwin4.cxx
+++ b/sc/source/ui/view/gridwin4.cxx
@@ -902,76 +902,6 @@ void ScGridWindow::DrawContent(OutputDevice , 
const ScTableInfo& rTableI
 }
 }
 
-// In-place editing - when the user is typing, we need to paint the text
-// using the editeng.
-// It's being done after EndDrawLayers() to get it outside the overlay
-// buffer and on top of everything.
-if ( bEditMode && (pViewData->GetRefTabNo() == pViewData->GetTabNo()) )
-{
-// get the coordinates of the area we need to clear (overpaint by
-// the background)
-SCCOL nCol1 = pViewData->GetEditStartCol();
-SCROW nRow1 = pViewData->GetEditStartRow();
-SCCOL nCol2 = pViewData->GetEditEndCol();
-SCROW nRow2 = pViewData->GetEditEndRow();
-rDevice.SetLineColor();
-rDevice.SetFillColor(pEditView->GetBackgroundColor());
-Point aStart = pViewData->GetScrPos( nCol1, nRow1, eWhich );
-Point aEnd = pViewData->GetScrPos( nCol2+1, nRow2+1, eWhich );
-
-// don't overwrite grid
-long nLayoutSign = bLayoutRTL ? -1 : 1;
-aEnd.X() -= 2 * nLayoutSign;
-aEnd.Y() -= 2;
-
-// toggle the cursor off if its on to ensure the cursor invert
-// background logic remains valid after the background is cleared on
-// the next cursor flash
-vcl::Cursor* pCrsr = pEditView->GetCursor();
-const bool bVisCursor = pCrsr && pCrsr->IsVisible();
-if (bVisCursor)
-pCrsr->Hide();
-
-// set the correct mapmode
-Rectangle aBackground(aStart, aEnd);
-if

[Libreoffice-commits] core.git: sc/source

2016-10-14 Thread Marco Cecchetti

 sc/source/ui/inc/tabview.hxx   |   59 
 sc/source/ui/view/tabview.cxx  |1 
 sc/source/ui/view/tabview3.cxx |  196 -
 sc/source/ui/view/tabvwsh4.cxx |   12 --
 4 files changed, 140 insertions(+), 128 deletions(-)

New commits:
commit a6c008b12cd2c2daf95a18eff0d72239588a5321
Author: Marco Cecchetti 
Date:   Thu Oct 6 23:29:40 2016 +0200

LOK: Calc: parallel cell editing: small code improvements

- A single instance of ScExtraEditViewManager is created per
ScTabView;

- On destruction a counter is checked in order to be sure that all
created edit views have been destroyed.

- BoolLock has been replaced by comphelper::FlagRestorationGuard

Change-Id: I6b0293c4d2e9151dff8b13601d0074c4b2567b25
Reviewed-on: https://gerrit.libreoffice.org/29582
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 
Reviewed-on: https://gerrit.libreoffice.org/29657

diff --git a/sc/source/ui/inc/tabview.hxx b/sc/source/ui/inc/tabview.hxx
index ceb1531..f1f9431 100644
--- a/sc/source/ui/inc/tabview.hxx
+++ b/sc/source/ui/inc/tabview.hxx
@@ -77,6 +77,63 @@ public:
 virtual voidDataChanged( const DataChangedEvent& rDCEvt ) override;
 };
 
+class ScExtraEditViewManager
+{
+public:
+ScExtraEditViewManager(ScTabViewShell* pThisViewShell, 
VclPtr* pGridWin)
+: mpThisViewShell(pThisViewShell)
+, mpGridWin(pGridWin)
+, mpOtherEditView(nullptr)
+, mpOtherEngine(nullptr)
+, maSameEditViewChecker()
+, nTotalActiveEditViews(0)
+{}
+
+~ScExtraEditViewManager();
+
+void Add(SfxViewShell* pViewShell, ScSplitPos eWhich)
+{
+Apply(pViewShell, eWhich, ::Adder);
+}
+
+void Remove(SfxViewShell* pViewShell, ScSplitPos eWhich)
+{
+Apply(pViewShell, eWhich, ::Remover);
+}
+
+private:
+class SameEditViewChecker
+{
+public:
+SameEditViewChecker()
+: mpOtherEditView(nullptr)
+, mpWindow(nullptr)
+{}
+void SetEditView(EditView* pOtherEditView) { mpOtherEditView = 
pOtherEditView; }
+void SetWindow(ScGridWindow* pWindow) { mpWindow = pWindow; }
+bool operator() (const EditView* pView) const;
+
+private:
+EditView* mpOtherEditView;
+ScGridWindow* mpWindow;
+};
+
+private:
+typedef void (ScExtraEditViewManager::* FuncType)(ScGridWindow* );
+
+void Apply(SfxViewShell* pViewShell, ScSplitPos eWhich, FuncType fHandler);
+void Adder(ScGridWindow* pWin);
+void Remover(ScGridWindow* pWin);
+
+private:
+ScTabViewShell* mpThisViewShell;
+VclPtr* mpGridWin;
+EditView* mpOtherEditView;
+EditEngine* mpOtherEngine;
+SameEditViewChecker maSameEditViewChecker;
+int nTotalActiveEditViews;
+};
+
 class ScTabView
 {
 private:
@@ -127,6 +184,8 @@ private:
 VclPtr   pTimerWindow;
 MouseEvent  aTimerMEvt;
 
+ScExtraEditViewManager aExtraEditViewManager;
+
 sal_uLong   nTipVisible;
 
 longnPrevDragPos;
diff --git a/sc/source/ui/view/tabview.cxx b/sc/source/ui/view/tabview.cxx
index e2fa248..dc5c221c 100644
--- a/sc/source/ui/view/tabview.cxx
+++ b/sc/source/ui/view/tabview.cxx
@@ -208,6 +208,7 @@ ScTabView::ScTabView( vcl::Window* pParent, ScDocShell& 
rDocSh, ScTabViewShell*
 pBrushDocument( nullptr ),
 pDrawBrushSet( nullptr ),
 pTimerWindow( nullptr ),
+aExtraEditViewManager( pViewShell, pGridWin ),
 nTipVisible( 0 ),
 nPrevDragPos( 0 ),
 meBlockMode(None),
diff --git a/sc/source/ui/view/tabview3.cxx b/sc/source/ui/view/tabview3.cxx
index f574b09..68a37a9 100644
--- a/sc/source/ui/view/tabview3.cxx
+++ b/sc/source/ui/view/tabview3.cxx
@@ -98,6 +98,83 @@ ScRange lcl_getSubRangeByIndex( const ScRange& rRange, 
sal_Int32 nIndex )
 
 using namespace com::sun::star;
 
+ScExtraEditViewManager::~ScExtraEditViewManager()
+{
+assert(nTotalActiveEditViews == 0);
+}
+
+void ScExtraEditViewManager::Apply(SfxViewShell* pViewShell, ScSplitPos 
eWhich, FuncType fHandler)
+{
+ScTabViewShell* pOtherViewShell = 
dynamic_cast(pViewShell);
+if (pOtherViewShell != nullptr && pOtherViewShell != mpThisViewShell)
+{
+mpOtherEditView = pOtherViewShell->GetViewData().GetEditView(eWhich);
+if (mpOtherEditView != nullptr)
+{
+mpOtherEngine = mpOtherEditView->GetEditEngine();
+if (mpOtherEngine != nullptr)
+{
+maSameEditViewChecker.SetEditView(mpOtherEditView);
+for (int i = 0; i < 4; ++i)
+{
+(this->*fHandler)(mpGridWin[i].get());
+}
+}
+}
+}
+}
+
+void ScExtraEditViewManager::Adder(ScGridWindow* pWin)
+{
+if (pWin != nullptr)
+{
+EditEngine::ViewsType& rEditViews =

[Libreoffice-commits] core.git: sfx2/source

2016-10-14 Thread Mike Kaganski

 sfx2/source/doc/docfile.cxx |6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

New commits:
commit c3fa866e768b67650b1e52308565e9344db0b4b4
Author: Mike Kaganski 
Date:   Sat Oct 15 00:26:09 2016 +1000

tdf#92817: re-implement empty lockfile fix

As stated in original commit 8d411a4a1ef6844c00bc714f8b144d3729e4f4e8,
An empty lock file doesn't have OOOUSERNAME and SYSUSERNAME.

Change-Id: I17fc6d3375f411749fcbbe80535beb8ba53a0e71
Reviewed-on: https://gerrit.libreoffice.org/29834
Reviewed-by: Michael Meeks 
Tested-by: Michael Meeks 

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index e93e954..2179f82 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -838,10 +838,8 @@ SfxMedium::ShowLockResult 
SfxMedium::ShowLockedDocumentDialog( const LockFileEnt
 {
 ShowLockResult nResult = ShowLockResult::NoLock;
 
-if( aData[LockFileComponent::OOOUSERNAME] == 
aData[LockFileComponent::SYSUSERNAME] ||
-  
aData[LockFileComponent::OOOUSERNAME].isEmpty()  ||
-  
aData[LockFileComponent::SYSUSERNAME].isEmpty()
-)
+// tdf#92817: Simple check for empty lock file that needs to be deleted
+if( aData[LockFileComponent::OOOUSERNAME].isEmpty() && 
aData[LockFileComponent::SYSUSERNAME].isEmpty() )
 bOwnLock=true;
 
 // show the interaction regarding the document opening
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: helpcontent2

2016-10-14 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0b7e11a2a7ade0b565c18d1deb58c19848f6ceef
Author: Gabor Kelemen 
Date:   Fri Oct 14 14:29:59 2016 +0200

Updated core
Project: help  599f664d48f995c461e06daf2295c1f9921fbcb8

Format - Slide Design menu item is now Slide - Slide Master Design

Change-Id: I3a823853f513c66a4a5b66ed86d9201730d09c5e
Reviewed-on: https://gerrit.libreoffice.org/29821
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index cf275eb..599f664 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit cf275ebb3fd3535f191ed02632dae2d5d7950657
+Subproject commit 599f664d48f995c461e06daf2295c1f9921fbcb8
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102950] Formatting of Comments is not persistent

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102950

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|
 Ever confirmed|0   |1

--- Comment #2 from Yousuf Philips (jay)  ---
Yes after setting it to format all the next inserted one should retain the set
formatting.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-ux-advise] [Bug 102950] Formatting of Comments is not persistent

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102950

Yousuf Philips (jay)  changed:

   What|Removed |Added

   Keywords|needsUXEval |
 Status|UNCONFIRMED |NEW
 CC|libreoffice-ux-advise@lists |philip...@hotmail.com
   |.freedesktop.org|
 Ever confirmed|0   |1

--- Comment #2 from Yousuf Philips (jay)  ---
Yes after setting it to format all the next inserted one should retain the set
formatting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Libreoffice-ux-advise mailing list
Libreoffice-ux-advise@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise

[Libreoffice-commits] core.git: helpcontent2

2016-10-14 Thread Gabor Kelemen

 helpcontent2 |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 194038b04525458b05b5b91af745dace85c23feb
Author: Gabor Kelemen 
Date:   Fri Oct 14 13:56:10 2016 +0200

Updated core
Project: help  cf275ebb3fd3535f191ed02632dae2d5d7950657

Drop the obsolete Task Panes help

- Move the still used ahelp contents to masterpage.xhp
- Add description of the Table Design command directly to
the Table toolbars help page

Change-Id: I44f679a29fc26d4930ec91314022e890c3559e50
Reviewed-on: https://gerrit.libreoffice.org/29820
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/helpcontent2 b/helpcontent2
index 0f18a22..cf275eb 16
--- a/helpcontent2
+++ b/helpcontent2
@@ -1 +1 @@
-Subproject commit 0f18a22ab657aa080900ecb6d851da0e27bd6ca3
+Subproject commit cf275ebb3fd3535f191ed02632dae2d5d7950657
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] help.git: 2 commits - AllLangHelp_simpress.mk source/text

2016-10-14 Thread Gabor Kelemen

 AllLangHelp_simpress.mk   |1 
 source/text/shared/main0204.xhp   |   20 ++-
 source/text/simpress/00/0405.xhp  |2 
 source/text/simpress/01/taskpanel.xhp |   78 --
 source/text/simpress/guide/masterpage.xhp |   16 +-
 5 files changed, 33 insertions(+), 84 deletions(-)

New commits:
commit 599f664d48f995c461e06daf2295c1f9921fbcb8
Author: Gabor Kelemen 
Date:   Fri Oct 14 14:29:59 2016 +0200

Format - Slide Design menu item is now Slide - Slide Master Design

Change-Id: I3a823853f513c66a4a5b66ed86d9201730d09c5e
Reviewed-on: https://gerrit.libreoffice.org/29821
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/source/text/simpress/00/0405.xhp 
b/source/text/simpress/00/0405.xhp
index 6f4301e..c9b7809 100644
--- a/source/text/simpress/00/0405.xhp
+++ b/source/text/simpress/00/0405.xhp
@@ -47,7 +47,7 @@
 
 Choose Format - Layer (only $[officename] 
Draw)
 
-Choose Format - Slide 
Design
+Choose Slide - Slide Master 
Design
 
 
 
diff --git a/source/text/simpress/guide/masterpage.xhp 
b/source/text/simpress/guide/masterpage.xhp
index d6546e3..8375168 100644
--- a/source/text/simpress/guide/masterpage.xhp
+++ b/source/text/simpress/guide/masterpage.xhp
@@ -41,7 +41,7 @@
 To apply a new slide master
 
 
-Select Format - Slide Design.
+Select Slide - Slide Master Design.
 
 
 Click Load.
commit cf275ebb3fd3535f191ed02632dae2d5d7950657
Author: Gabor Kelemen 
Date:   Fri Oct 14 13:56:10 2016 +0200

Drop the obsolete Task Panes help

- Move the still used ahelp contents to masterpage.xhp
- Add description of the Table Design command directly to
the Table toolbars help page

Change-Id: I44f679a29fc26d4930ec91314022e890c3559e50
Reviewed-on: https://gerrit.libreoffice.org/29820
Reviewed-by: Olivier Hallot 
Tested-by: Olivier Hallot 

diff --git a/AllLangHelp_simpress.mk b/AllLangHelp_simpress.mk
index 78ce2d2..633fd53 100644
--- a/AllLangHelp_simpress.mk
+++ b/AllLangHelp_simpress.mk
@@ -120,7 +120,6 @@ $(eval $(call gb_AllLangHelp_add_helpfiles,simpress,\
 helpcontent2/source/text/simpress/01/effectoptionstext \
 helpcontent2/source/text/simpress/01/effectoptionstiming \
 helpcontent2/source/text/simpress/01/slidesorter \
-helpcontent2/source/text/simpress/01/taskpanel \
 helpcontent2/source/text/simpress/02/0401 \
 helpcontent2/source/text/simpress/02/0402 \
 helpcontent2/source/text/simpress/02/0403 \
diff --git a/source/text/shared/main0204.xhp b/source/text/shared/main0204.xhp
index 5971517..d7068f5 100644
--- a/source/text/shared/main0204.xhp
+++ b/source/text/shared/main0204.xhp
@@ -63,9 +63,23 @@
 
 
 following only optional, ext.help is available: Select Table Select 
Column Select Row
-Table Design
-Opens the Table Design. Double-click a preview to insert a new 
table.Impress: Table Design tab page in task pane.
-Draw: Table Design dialog
+
+Table Design
+Opens the Table Design. Double-click a 
preview to format the table.
+
+
+
+
+
+Icon
+   
+
+
+Table 
Design
+
+
+
+
 Table Properties
 
 
diff --git a/source/text/simpress/01/taskpanel.xhp 
b/source/text/simpress/01/taskpanel.xhp
deleted file mode 100644
index aae1b5c..000
--- a/source/text/simpress/01/taskpanel.xhp
+++ /dev/null
@@ -1,78 +0,0 @@
-
-
-   
-
- 
-   
-
-
-Task Pane
-/text/simpress/01/taskpanel.xhp
-
-
-
-
-task pane
-
-
-Task 
Pane
-Switches the %PRODUCTNAME Impress task pane on and 
off.
-
-
-
-
-The 
task pane contains pages to specify the master pages, layouts, custom 
animation, and slide transition. Click another heading to open another 
page.
-
-
-   
-
-
-Master Page
-Opens the Master Pages tab page, 
where you apply a master page (background) to all slides (left-click) or to the 
selected slides (right-click).
-Used in this presentation
-Lists the currently used master 
pages.
-Recently used
-Lists the recently used master 
pages.
-Available for Use
-Lists all available master 
pages.
-
-
-
-Left-click to apply the master 
page to all slides. Right-click for a submenu.
-
-Applies the master page to all 
slides.
-
-Applies the master page or the 
slide design to the selected slides.
-
-
-Resizes the preview of the master 
pages.
-Layouts
-Opens the Layouts tab page, where 
you apply a slide design to the selected slide or slides.
-
-Click to apply a slide design to 
all selected slides. Right-click for a submenu.
-Custom Animation
-Opens the Custom Animation tab 
page, where you apply effects to the selected objects on a 
slide.
-Slide Transition
-Opens the Slide Transition tab 
page, where you apply transition effects to the selected 
slides.Table Design
-
-
-Opens the Table Design. 
Double-click a preview to insert a new table.Impress: Table 
Design tab page in

RE: led surgical lights manufacturer from China

2016-10-14 Thread Mary



 Hi
Friend,
 






 Wish you have a nice day! 
 




This is Mary from Shanghai Huifeng Medical Instrument Co., LTD
which mainly produces high-end operating light, operating table,medical
pendent, Oxygen bag, Air cushion, Pneumatic tourniquet, electric boiling
sterilizer and so on. We have our own factory and all the products have
passed CE, FDA, ISO
certification.
If you keen on our products,
let's further talk about it.
 
Waiting for your reply! Thanks
very
much! 

 






 


 







 
 
 


29th INDONESIAN HOSPITAL EXPO Time:19-22,Oct,2016 Booth No.: AS-221

---
CMEF Fair In Shenzhen Convention
Center
Time: 29th Oct --4th Nov, 2016Booth NO:
H8-E23
 













Best wishes Mary  Ma
Sales
Director-Sales Dept.Shanghai Huifeng Medical Instrument Co., LTD.


Add: No. 7753,Chuannanfeng Highroad,Datuan Town,Pudong District,Shanghai,China

Tel: 86-21-60640265
QQ: 2355332341
TM: cn1000399872
Wechat / Line:
86-18917525227
Mobile/ Viber / whatsapp:
86-18917525227
skype:huifen...@hotmail.com 
Mail: huife...@sh-huifeng.com；huife...@huifeng-co.com
Web：en.huifeng-co.com
 




___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-bugs] [Bug 92817] misleading error on save with empty lock-file ...

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=92817

Mike Kaganski  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---
   Assignee|libreoffice-b...@lists.free |mikekagan...@hotmail.com
   |desktop.org |

--- Comment #6 from Mike Kaganski  ---
The committed fix causes a regression. If ooousername in the lockfile happens
to be empty (user hadn't filled in relevant information in LO), then the
lockfile generated by that user is always treated as "empty" (=own) by any
other LO.

A revised patch submitted for review: https://gerrit.libreoffice.org/29834

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: vcl/unx

2016-10-14 Thread Caolán McNamara

 vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx |5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 1054eb97a61d916b27ef4d0916b58a5a4fc6586b
Author: CaolÃ¡n McNamara 
Date:   Fri Oct 14 15:29:27 2016 +0100

provide another fallback

Change-Id: I1438986674f7b4edb015f436bcaf7f07fd61d778

diff --git a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx 
b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
index 0a9eddf..4ee12db 100644
--- a/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx
@@ -680,6 +680,8 @@ void GtkSalGraphics::PaintSpinButton(GtkStyleContext 
*context,
 cairo_translate(cr, rControlRectangle.Left(), rControlRectangle.Top());
 }
 
+#define FALLBACK_ARROW_SIZE 11 * 0.85
+
 Rectangle GtkSalGraphics::NWGetComboBoxButtonRect( ControlType nType,
ControlPart nPart,
Rectangle aAreaRect )
@@ -691,7 +693,7 @@ Rectangle GtkSalGraphics::NWGetComboBoxButtonRect( 
ControlType nType,
 GtkBorder padding;
 gtk_style_context_get_padding( mpButtonStyle, 
gtk_style_context_get_state(mpButtonStyle), );
 
-gint nArrowWidth;
+gint nArrowWidth = FALLBACK_ARROW_SIZE;
 gtk_style_context_get(mpComboboxButtonArrowStyle,
 gtk_style_context_get_state(mpComboboxButtonArrowStyle),
 "min-width", , nullptr);
@@ -726,7 +728,6 @@ Rectangle GtkSalGraphics::NWGetComboBoxButtonRect( 
ControlType nType,
 return aButtonRect;
 }
 
-#define FALLBACK_ARROW_SIZE 11 * 0.85
 void GtkSalGraphics::PaintCombobox( GtkStateFlags flags, cairo_t *cr,
 const Rectangle& rControlRectangle,
 ControlType nType,
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] core.git: solenv/Module_solenv.mk

2016-10-14 Thread Stephan Bergmann

 solenv/Module_solenv.mk |2 ++
 1 file changed, 2 insertions(+)

New commits:
commit edc7a6692ccdcef8f26d228cc37f5b24fb1433a9
Author: Stephan Bergmann 
Date:   Fri Oct 14 16:22:10 2016 +0200

Disable PythonTest_solenv_python on Windows for now

...causes all gerrit/jenkins Windows builds to fail in test_gbuildtoide; 
BjÃ¶rn
to investigate...

Change-Id: I90f95e4a91f40835d2b2d9c67a6473b95fb81597

diff --git a/solenv/Module_solenv.mk b/solenv/Module_solenv.mk
index d179771..f471374 100644
--- a/solenv/Module_solenv.mk
+++ b/solenv/Module_solenv.mk
@@ -22,9 +22,11 @@ $(eval $(call gb_Module_add_targets,solenv,\
 endif
 
 ifneq ($(DISABLE_PYTHON),TRUE)
+ifneq ($(OS),WNT) # disable on Windows for now, causes gerrit/jenkins failures
 $(eval $(call gb_Module_add_subsequentcheck_targets,solenv,\
PythonTest_solenv_python \
 ))
 endif
+endif
 
 # vim: set shiftwidth=4 tabstop=4 noexpandtab:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102985] [META] Font bugs and enhancements

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102985

--- Comment #5 from Yousuf Philips (jay)  ---
Embedding Fonts
Bug 65353 - LibreOffice embeds fonts that arent used in the document
Bug 77753 - When LibreOffice is open, it wont load embedded fonts (Windows)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102493] FILESAVE: save to HTML, list elements formatted incorrectly

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102493

--- Comment #4 from j...@jamesahart.us ---
Oh, sorry I wasn't clear. The document was never ODT. It was saved in HTML
format the very first time.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100994] Freeze / Crash on first action after launch with OSX Sierra with discrete graphics card deactivated

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100994

--- Comment #96 from Norbert Thiebaud  ---
confirmed that changing the color space (I picked adobe-1998 to try)
hang. I've attached a sampling of the app while hung.
there is a abort() in the call stack withing a system memory operation, which
dead-lock in the signal handler because it try to allocate memory and at that
point the memory system is already under it's own lock.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103170] Notebookbar: Implementation of the contextual group layout

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103170

Yousuf Philips (jay)  changed:

   What|Removed |Added

  Alias||heikobar

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: svl/Library_svl.mk svl/source

2016-10-14 Thread Stephan Bergmann

 svl/Library_svl.mk  |1 -
 svl/source/svdde/ddeimp.hxx |2 --
 svl/source/svdde/ddeinf.cxx |   33 -
 3 files changed, 36 deletions(-)

New commits:
commit 5b9a25883d59570915e5cdc53c6542def1fdb739
Author: Stephan Bergmann 
Date:   Fri Oct 14 13:51:49 2016 +0200

DdeInternal::InfCallback is unused

...since b5863b83d212ae344cefe0aefdfd4caddaded02b "Remove classes 
DdeServiceList
& DdeTopicList"

Change-Id: I9cd90cb6b50f72966210c0035034cdc6b6d2230c
Reviewed-on: https://gerrit.libreoffice.org/29819
Reviewed-by: Stephan Bergmann 
Tested-by: Stephan Bergmann 

diff --git a/svl/Library_svl.mk b/svl/Library_svl.mk
index 3a7b00d..8e7b9a2 100644
--- a/svl/Library_svl.mk
+++ b/svl/Library_svl.mk
@@ -147,7 +147,6 @@ ifeq ($(OS),WNT)
 $(eval $(call gb_Library_add_exception_objects,svl,\
 svl/source/svdde/ddecli \
 svl/source/svdde/ddedata \
-svl/source/svdde/ddeinf \
 svl/source/svdde/ddestrg \
 svl/source/svdde/ddesvr \
 ))
diff --git a/svl/source/svdde/ddeimp.hxx b/svl/source/svdde/ddeimp.hxx
index 28f611b..37f3447 100644
--- a/svl/source/svdde/ddeimp.hxx
+++ b/svl/source/svdde/ddeimp.hxx
@@ -44,8 +44,6 @@ public:
( WORD, WORD, HCONV, HSZ, HSZ, HDDEDATA, DWORD, DWORD );
 static HDDEDATA CALLBACK SvrCallback
( WORD, WORD, HCONV, HSZ, HSZ, HDDEDATA, DWORD, DWORD );
-static HDDEDATA CALLBACK InfCallback
-   ( WORD, WORD, HCONV, HSZ, HSZ, HDDEDATA, DWORD, DWORD );
 static DdeService*  FindService( HSZ );
 static DdeTopic*FindTopic( DdeService&, HSZ );
 static DdeItem* FindItem( DdeTopic&, HSZ );
diff --git a/svl/source/svdde/ddeinf.cxx b/svl/source/svdde/ddeinf.cxx
deleted file mode 100644
index d4b0702..000
--- a/svl/source/svdde/ddeinf.cxx
+++ /dev/null
@@ -1,33 +0,0 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-
-#define UNICODE
-
-#include 
-#include "ddeimp.hxx"
-#include 
-
-HDDEDATA CALLBACK DdeInternal::InfCallback(
-WORD, WORD, HCONV, HSZ, HSZ, HDDEDATA, DWORD, DWORD )
-{
-return (HDDEDATA)DDE_FNOTPROCESSED;
-}
-
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 34804] EDITING: Keyboard shortcut for Format-Highlighting does not work

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=34804

Johan Brink  changed:

   What|Removed |Added

   Hardware|Other   |x86-64 (AMD64)
Version|3.3.1 release   |5.1.5.2 release
 OS|All |Windows (All)
   Severity|minor   |normal

--- Comment #13 from Johan Brink  ---
as of 5.1.5.2 this is still a thing.
This has been a problem for a long time, as I have also had the same issue in
earlier versions. I am disappointed to see that it is still not working
properly.
As a teacher I have to be able to highlight texts A LOT, when evaluating
student works. Having a working keyboard shortcut for this is essential and
should be an elementary feature.

As per the original report, the highlight color function works to UNhighligt an
already highlighted text, but fails to actually highlight it in the first
place.
Now I know there is a highlight fill function that is supposed to be a
workaround for this. But no. That's not working properly either. Highlight
fill, out of the box does nothing when assigned a shortcut.

As I'm writing this and tinkering with the program (going by earlier comments),
I seem to be able to get it to sometimes work. If I first use the toolbar
option. Then subsequently I can use the shortcut for highlight fill. But it
stops working at random if I do something else in-between. Especially the
highlight function, which there are two of, for some reason (one of which
doesn't work at all) and the highlight fill seem to actively interfere with one
another.

This is clearly not a working solution. It's an un-intuitive mess that has a
life of it's own.

Please prioritize this issue to at least normal level. This is such a basic
function that it is quite literately a deal-breaker for me and I am sure others
as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100994] Freeze / Crash on first action after launch with OSX Sierra with Display color space not 'default'

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100994

Norbert Thiebaud  changed:

   What|Removed |Added

Summary|Freeze / Crash on first |Freeze / Crash on first
   |action after launch with|action after launch with
   |OSX Sierra with discrete|OSX Sierra with Display
   |graphics card deactivated   |color space not 'default'

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Alex Kempshall  changed:

   What|Removed |Added

 CC||mcmurchy1917-bugzilla@yahoo
   ||.co.uk

--- Comment #6 from Alex Kempshall  ---
Created attachment 128011
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128011=edit
bisect log for this bug

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: sc/qa sc/source

2016-10-14 Thread Winfried Donkers

 sc/qa/unit/data/functions/fods/binom.inv.fods | 2698 +++---
 sc/source/core/tool/interpr3.cxx  |6 
 2 files changed, 1660 insertions(+), 1044 deletions(-)

New commits:
commit f613f6e6973b2069c5f4c5b56efa4c355118387e
Author: Winfried Donkers 
Date:   Thu Sep 15 18:10:28 2016 +0200

tdf#102212: correct constraints for Calc functions CRITBINOM, BINOM.INV.

Argument alpha can be 0<=alpha<=1.

Change-Id: Ic1e6dec52bcfe227de49f6b9af38a618f4602c95
Reviewed-on: https://gerrit.libreoffice.org/28934
Tested-by: Jenkins 
Reviewed-by: Eike Rathke 
Tested-by: Eike Rathke 

diff --git a/sc/qa/unit/data/functions/fods/binom.inv.fods 
b/sc/qa/unit/data/functions/fods/binom.inv.fods
index 7c987fb..7b30515 100644
--- a/sc/qa/unit/data/functions/fods/binom.inv.fods
+++ b/sc/qa/unit/data/functions/fods/binom.inv.fods
@@ -1,20 +1,20 @@
 
 
 http://www.w3.org/1999/xlink; 
xmlns:dc="http://purl.org/dc/elements/1.1/; 
xmlns:meta="urn:oasis:names:tc:opendocument:xmlns:meta:1.0" 
xmlns:number="urn:oasis:names:tc:opendocument:xmlns:datastyle:1.0" 
xmlns:presentation="urn:oasis:names:tc:opendocument:xmlns:presentation:1.0" 
xmlns:svg="urn:oasis:names:tc:opendocument:xmlns:svg-compatible:1.0" 
xmlns:chart="urn:oasis:names:tc:opendocument:xmlns:chart:1.0" 
xmlns:dr3d="urn:oasis:names:tc:opendocument:xmlns:dr3d:1.0" 
xmlns:math="http://www.w3.org/1998/Math/MathML; 
xmlns:form="urn:oasis:names:tc:opendocument:xmlns:form:1.0" xmlns:scr
 ipt="urn:oasis:names:tc:opendocument:xmlns:script:1.0" 
xmlns:config="urn:oasis:names:tc:opendocument:xmlns:config:1.0" 
xmlns:ooo="http://openoffice.org/2004/office; 
xmlns:ooow="http://openoffice.org/2004/writer; 
xmlns:oooc="http://openoffice.org/2004/calc; 
xmlns:dom="http://www.w3.org/2001/xml-events; 
xmlns:xforms="http://www.w3.org/2002/xforms; 
xmlns:xsd="http://www.w3.org/2001/XMLSchema; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xmlns:rpt="http://openoffice.org/2005/report; 
xmlns:of="urn:oasis:names:tc:opendocument:xmlns:of:1.2" 
xmlns:xhtml="http://www.w3.org/1999/xhtml; 
xmlns:grddl="http://www.w3.org/2003/g/data-view#; 
xmlns:tableooo="http://openoffice.org/2009/table; 
xmlns:drawooo="http://openoffice.org/2010/draw; 
xmlns:calcext="urn:org:documentfoundation:names:experimental:calc:xmlns:calcext:1.0"
 
xmlns:loext="urn:org:documentfoundation:names:experimental:office:xmlns:loext:1.0"
 xmlns:field="urn:openoffice:names:experimental:ooo-ms-interop:xmlns:field:1.0" 
xmlns:form
 x="urn:openoffice:names:experimental:ooxml-odf-interop:xmlns:form:1.0" 
xmlns:css3t="http://www.w3.org/TR/css3-text/; office:version="1.2" 
office:mimetype="application/vnd.oasis.opendocument.spreadsheet">
- 
2016-08-16T20:24:05.334009545P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/93eb0896bc30163dba47e20459dd0d14fb9770f9
+ 
2016-08-16T20:24:05.334009545P0D1LibreOfficeDev/5.3.0.0.alpha0$Linux_X86_64
 
LibreOffice_project/6f628a4045f647e42d6a1e7940e965cfa8b9ae11
  
   
0
0
89632
-   7500
+   13955

 
  view1
  
   
-   2
-   8
+   1
+   7
0
0
0
@@ -31,8 +31,8 @@
false
   
   
-   4
-   4
+   1
+   42
0
0
0
@@ -50,7 +50,7 @@
   
  
  Sheet2
- 1241
+ 1014
  0
  75
  60
@@ -63,7 +63,7 @@
  true
  true
  true
- false
+ true
  false
  false
  1270
@@ -94,7 +94,7 @@
false
12632256
false
-   Lexmark-E352dn
+   prn_Algemeen

 
  cs
@@ -125,7 +125,7 @@
true
1
true
-   kQH+/0xleG1hcmstRTM1MmRuQ1VQUzpMZXhtYXJrLUUzNTJkbgAWAAMAtwAIAFZUAAAkbQAASm9iRGF0YSAxCnByaW50ZXI9TGV4bWFyay1FMzUyZG4Kb3JpZW50YXRpb249UG9ydHJhaXQKY29waWVzPTEKY29sbGF0ZT1mYWxzZQptYXJnaW5kYWp1c3RtZW50PTAsMCwwLDAKY29sb3JkZXB0aD0yNApwc2xldmVsPTAKcGRmZGV2aWNlPTEKY29sb3JkZXZpY2U9MApQUERDb250ZXhEYXRhClBhZ2VTaXplOkxldHRlcgAAEgBDT01QQVRfRFVQTEVYX01PREUKAERVUExFWF9PRkY=
+   rQH+/3Bybl9BbGdlbWVlbgAAQ1VQUzpwcm5fQWxnZW1lZW4WAAMAzgAEAAhSAAAEdAAASm9iRGF0YSAxCnByaW50ZXI9cHJuX0FsZ2VtZWVuCm9yaWVudGF0aW9uPVBvcnRyYWl0CmNvcGllcz0xCmNvbGxhdGU9ZmFsc2UKbWFyZ2luZGFqdXN0bWVudD0wLDAsMCwwCmNvbG9yZGVwdGg9MjQKcHNsZXZlbD0wCnBkZmRldmljZT0xCmNvbG9yZGV2aWNlPTAKUFBEQ29udGV4RGF0YQpJbnB1dFNsb3Q6UEY3MDBBAFBhZ2VTaXplOkE0AER1cGxleDpOb25lAAASAENPTVBBVF9EVVBMRVhfTU9ERQ8ARHVwbGV4TW9kZTo6T2Zm
false
0
   
@@ -138,6 +138,8 @@
   
  
  
+  
+  
   
   
   
@@ -155,275 +157,341 @@
  
  
   
-   
+   

   
   

   
-  
+

[Libreoffice-bugs] [Bug 102010] MAILMERGE: Output Filename changed using CLI_UNO

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102010

Alex Kempshall  changed:

   What|Removed |Added

   Keywords||bisected, regression

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102212] CRITBINOM function, constraint Alpha >= 1

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102212

Eike Rathke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|libreoffice-b...@lists.free |winfrieddonkers@libreoffice
   |desktop.org |.org

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 100994] Freeze / Crash on first action after launch with OSX Sierra with discrete graphics card deactivated

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=100994

--- Comment #95 from Norbert Thiebaud  ---
Created attachment 128012
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128012=edit
sampling done while hanging

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103218] Imported XSLX wrong image boundaries

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103218

--- Comment #3 from Leonardo M. Ramé  ---
Please not I've attached both files.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103218] Imported XSLX wrong image boundaries

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103218

--- Comment #2 from Leonardo M. Ramé  ---
Created attachment 128010
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128010=edit
Original Excel file

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103218] Imported XSLX wrong image boundaries

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103218

--- Comment #1 from Leonardo M. Ramé  ---
Created attachment 128009
  --> https://bugs.documentfoundation.org/attachment.cgi?id=128009=edit
Comparison between excel and calc

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 103218] New: Imported XSLX wrong image boundaries

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=103218

Bug ID: 103218
   Summary: Imported XSLX wrong image boundaries
   Product: LibreOffice
   Version: 5.2.2.2 release
  Hardware: All
OS: All
Status: UNCONFIRMED
  Severity: normal
  Priority: medium
 Component: Calc
  Assignee: libreoffice-bugs@lists.freedesktop.org
  Reporter: l.r...@griensu.com

Description:
When opening an .xslx file LibreOffice Calc displays our logo image wrongly
sized.

Please, download a sample file from here:
http://45.63.8.72/libreoffice/ImageError.xlsx

Also you can see a picture showing how it is displayed in Excel and Calc, to
easily grasp what I mean: http://45.63.8.72/libreoffice/imageerror.jpg

Regards,
Leonardo.

Steps to Reproduce:
1. Just open the file http://45.63.8.72/libreoffice/ImageError.xlsx in LO Calc
(any version).

Actual Results:  
The logo image is displayed wrongly sized.

Expected Results:
It should be displayed as in Excel (see
http://45.63.8.72/libreoffice/imageerror.jpg).


Reproducible: Always

User Profile Reset: No

Additional Info:


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101
Firefox/49.0

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Re: Add arguments to Calc functions when exporting to xls

2016-10-14 Thread Winfried Donkers


Hi Eike,


Appending parameters is done in sc/source/filter/excel/xeformula.cxx
XclExpFmlaCompImpl::AppendTrailingParam()



Thanks! :-)

Winfried
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: external/poppler

2016-10-14 Thread Stephan Bergmann

 external/poppler/ubsan.patch.0 |  218 +
 1 file changed, 218 insertions(+)

New commits:
commit 55013a7776a43bb18b7fb8faa1839369c3383cb7
Author: Stephan Bergmann 
Date:   Fri Oct 14 15:34:53 2016 +0200

external/poppler: Avoid UBSan warning about undefined downcast

...of this-ptr of in-construction FormFieldSignature while still in the base
FormField ctor, as happens (in the xpdfimport process) during
CppunitTest_xmlsecurity_signing:

> Form.cc:448:12: runtime error: downcast of address 0x60f00040 which 
does not point to an object of type 'FormFieldSignature'
> 0x60f00040: note: object is of type 'FormField'
>  03 00 00 6d  50 84 f2 00 00 00 00 00  03 00 00 00 04 00 00 00  00 00 00 
00 01 be be be  07 00 00 00
>   ^~~
>   vptr for 'FormField'
> #0 0x73d7f4 in FormWidgetSignature::FormWidgetSignature(PDFDoc*, 
Object*, unsigned int, Ref, FormField*) 
workdir/UnpackedTarball/poppler/poppler/Form.cc:448:12
> #1 0x741713 in FormField::_createWidget(Object*, Ref) 
workdir/UnpackedTarball/poppler/poppler/Form.cc:677:34
> #2 0x73e747 in FormField::FormField(PDFDoc*, Object*, Ref const&, 
FormField*, std::set*, 
FormFieldType) workdir/UnpackedTarball/poppler/poppler/Form.cc:547:7
> #3 0x74ec2b in FormFieldSignature::FormFieldSignature(PDFDoc*, 
Object*, Ref const&, FormField*, std::set*) workdir/UnpackedTarball/poppler/poppler/Form.cc:1383:5
> #4 0x740d7f in Form::createFieldFromDict(Object*, PDFDoc*, Ref 
const&, FormField*, std::set*) 
workdir/UnpackedTarball/poppler/poppler/Form.cc:1700:19
> #5 0x750727 in Form::Form(PDFDoc*, Object*) 
workdir/UnpackedTarball/poppler/poppler/Form.cc:1623:33
> #6 0x71d440 in Catalog::getForm() 
workdir/UnpackedTarball/poppler/poppler/Catalog.cc:1042:18
> #7 0x708572 in Annots::createAnnot(Dict*, Object*) 
workdir/UnpackedTarball/poppler/poppler/Annot.cc:7218:41
> #8 0x70772b in Annots::Annots(PDFDoc*, int, Object*) 
workdir/UnpackedTarball/poppler/poppler/Annot.cc:7128:17
> #9 0x87f3e9 in Page::getAnnots(XRef*) 
workdir/UnpackedTarball/poppler/poppler/Page.cc:405:18
> #10 0x8814b0 in Page::displaySlice(OutputDev*, double, double, int, 
bool, bool, int, int, int, int, bool, bool (*)(void*), void*, bool (*)(Annot*, 
void*), void*, bool) workdir/UnpackedTarball/poppler/poppler/Page.cc:611:15
> #11 0x880ff6 in Page::display(OutputDev*, double, double, int, bool, 
bool, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, bool) 
workdir/UnpackedTarball/poppler/poppler/Page.cc:521:3
> #12 0x88d906 in PDFDoc::displayPage(OutputDev*, int, double, double, 
int, bool, bool, bool, bool (*)(void*), void*, bool (*)(Annot*, void*), void*, 
bool) workdir/UnpackedTarball/poppler/poppler/PDFDoc.cc:491:20
> #13 0x5d59fb in main 
sdext/source/pdfimport/xpdfwrapper/wrapper_gpl.cxx:142:14
> #14 0x7f11600ea730 in __libc_start_main (/lib64/libc.so.6+0x20730)
> #15 0x459388 in _start (instdir/program/xpdfimport+0x459388)

Change-Id: Ia808919c8d2363d616feb4664f314a77b40dfbb8

diff --git a/external/poppler/ubsan.patch.0 b/external/poppler/ubsan.patch.0
index 623858da9..a27f00f 100644
--- a/external/poppler/ubsan.patch.0
+++ b/external/poppler/ubsan.patch.0
@@ -9,6 +9,224 @@
memcpy(s1, s, length);
}
if (s != sStatic)
+--- poppler/Form.cc
 poppler/Form.cc
+@@ -463,12 +463,11 @@
+ // FormField
+ //
+ 
+-FormField::FormField(PDFDoc *docA, Object *aobj, const Ref& aref, FormField 
*parentA, std::set *usedParents, FormFieldType ty)
++FormField::FormField(PDFDoc *docA, Object *aobj, const Ref& aref, FormField 
*parentA, FormFieldType ty)
+ {
+   doc = docA;
+   xref = doc->getXRef();
+   aobj->copy();
+-  Dict* dict = obj.getDict();
+   ref.num = ref.gen = 0;
+   type = ty;
+   parent = parentA;
+@@ -483,7 +482,11 @@
+   hasQuadding = gFalse;
+ 
+   ref = aref;
++}
+ 
++void FormField::init(std::set *usedParents)
++{
++  Dict* dict = obj.getDict();
+   Object obj1;
+   //childs
+   if (dict->lookup("Kids", )->isArray()) {
+@@ -803,9 +806,15 @@
+ //
+ // FormFieldButton
+ //
+-FormFieldButton::FormFieldButton(PDFDoc *docA, Object *aobj, const Ref& ref, 
FormField *parent, std::set *usedParents)
+-  : FormField(docA, aobj, ref, parent, usedParents, formButton)
++FormFieldButton::FormFieldButton(PDFDoc *docA, Object *aobj, const Ref& ref, 
FormField *parent)
++  : FormField(docA, aobj, ref, parent, formButton)
+ {
++}
++
++void FormFieldButton::init(std::set *usedParents)
++{

[Libreoffice-commits] core.git: xmlsecurity/inc xmlsecurity/source

2016-10-14 Thread Miklos Vajna

 xmlsecurity/inc/pdfio/pdfdocument.hxx|3 +
 xmlsecurity/source/pdfio/pdfdocument.cxx |   80 ++-
 2 files changed, 61 insertions(+), 22 deletions(-)

New commits:
commit d550f5e6b670e75907be5ea81e8fd5c0f4f67401
Author: Miklos Vajna 
Date:   Fri Oct 14 15:38:57 2016 +0200

xmlsecurity: expose reason string of PDF signatures

Also known as comment or description. And since then we need the hex
decoding mechanism for this and Content as well, extract that to a new
DecodeHexString().

Change-Id: Ie260b470c951661c80c0921b5ce2aa4c461f692c

diff --git a/xmlsecurity/inc/pdfio/pdfdocument.hxx 
b/xmlsecurity/inc/pdfio/pdfdocument.hxx
index 79cd716..0eaaa09 100644
--- a/xmlsecurity/inc/pdfio/pdfdocument.hxx
+++ b/xmlsecurity/inc/pdfio/pdfdocument.hxx
@@ -25,6 +25,7 @@ namespace pdfio
 
 class PDFTrailerElement;
 class PDFObjectElement;
+class PDFHexStringElement;
 
 /// A byte range in a PDF file.
 class PDFElement
@@ -44,6 +45,8 @@ class XMLSECURITY_DLLPUBLIC PDFDocument
 PDFTrailerElement* m_pTrailer;
 
 static int AsHex(char ch);
+/// Decode a hex dump.
+static std::vector DecodeHexString(PDFHexStringElement* 
pElement);
 
 public:
 PDFDocument();
diff --git a/xmlsecurity/source/pdfio/pdfdocument.cxx 
b/xmlsecurity/source/pdfio/pdfdocument.cxx
index 225c588..3766e4d 100644
--- a/xmlsecurity/source/pdfio/pdfdocument.cxx
+++ b/xmlsecurity/source/pdfio/pdfdocument.cxx
@@ -681,6 +681,37 @@ int PDFDocument::AsHex(char ch)
 return nRet;
 }
 
+std::vector PDFDocument::DecodeHexString(PDFHexStringElement* 
pElement)
+{
+std::vector aRet;
+const OString& rHex = pElement->GetValue();
+size_t nHexLen = rHex.getLength();
+{
+int nByte = 0;
+int nCount = 2;
+for (size_t i = 0; i < nHexLen; ++i)
+{
+nByte = nByte << 4;
+sal_Int8 nParsed = AsHex(rHex[i]);
+if (nParsed == -1)
+{
+SAL_WARN("xmlsecurity.pdfio", "PDFDocument::DecodeHexString: 
invalid hex value");
+return aRet;
+}
+nByte += nParsed;
+--nCount;
+if (!nCount)
+{
+aRet.push_back(nByte);
+nCount = 2;
+nByte = 0;
+}
+}
+}
+
+return aRet;
+}
+
 bool PDFDocument::ValidateSignature(SvStream& rStream, PDFObjectElement* 
pSignature, SignatureInformation& rInformation)
 {
 PDFObjectElement* pValue = pSignature->LookupObject("V");
@@ -711,33 +742,38 @@ bool PDFDocument::ValidateSignature(SvStream& rStream, 
PDFObjectElement* pSignat
 return false;
 }
 
-// At this point there is no obviously missing info to validate the
-// signature, so let's turn the hex dump of the signature into a memory
-// stream.
-const OString& rSignatureHex = pContents->GetValue();
-size_t nSignatureHexLen = rSignatureHex.getLength();
-std::vector aSignature;
+// Reason / comment / description is optional.
+auto pReason = 
dynamic_cast(pValue->Lookup("Reason"));
+if (pReason)
 {
-int nByte = 0;
-int nCount = 2;
-for (size_t i = 0; i < nSignatureHexLen; ++i)
+// See appendUnicodeTextString() for the export equivalent of this.
+std::vector aReason = 
PDFDocument::DecodeHexString(pReason);
+OUStringBuffer aBuffer;
+sal_uInt16 nByte = 0;
+for (size_t i = 0; i < aReason.size(); ++i)
 {
-nByte = nByte << 4;
-sal_Int8 nParsed = AsHex(rSignatureHex[i]);
-if (nParsed == -1)
-{
-SAL_WARN("xmlsecurity.pdfio", "PDFDocument::ValidateSignature: 
invalid hex value");
-return false;
-}
-nByte += nParsed;
---nCount;
-if (!nCount)
+if (i % 2 == 0)
+nByte = aReason[i];
+else
 {
-aSignature.push_back(nByte);
-nCount = 2;
-nByte = 0;
+sal_Unicode nUnicode;
+nUnicode = (nByte << 8);
+nUnicode |= aReason[i];
+aBuffer.append(nUnicode);
 }
 }
+
+if (!aBuffer.isEmpty())
+rInformation.ouDescription = aBuffer.makeStringAndClear();
+}
+
+// At this point there is no obviously missing info to validate the
+// signature.
+std::vector aSignature = 
PDFDocument::DecodeHexString(pContents);
+if (aSignature.empty())
+{
+SAL_WARN("xmlsecurity.pdfio", "PDFDocument::ValidateSignature: empty 
contents");
+return false;
 }
 
 #ifdef XMLSEC_CRYPTO_NSS
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102288] TerminationVetoException should only prevent termination, not closing windows

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102288

Samuel Mehrbrodt (CIB)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||s.mehrbr...@gmail.com
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 95957] LibreOffice 5.0.3.2 - crashes with std::bad_alloc

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=95957

--- Comment #26 from Adi Meyerhofer  ---
(In reply to Keith Refson from comment #25)
> Sorry about the delay with this.  I was not yet able to get debugging symbol
> information.
> 
> However I have managed to narrow down the cause a lot further, after
> recovering the "setuptools.pth" in my Python 2.7 local site-packages.  This
> allowed me to identify the single Python package at the root of the crash.
> 
> Skipping any more tedious details, the conclusion is
> 
> If my installation of the Python package "enum" is in the PYTHONPATH, LO
> fails on startup with std::Bad_Alloc.
> 
> If the installation of the Python package "enum" is NOT in PYTHONPATH, LO
> startup succeeds.
> 
> I will upload a tarball containing the offending Python package.  Perhaps
> others can try to see if adding this to your Pythonpath replicates the
> failure?

As promising as your comments are I must say that n my setup, I can not
replicate your solution. That is: 1) I have had NO PYTHONPATH set, 2) even
after (temporarily) renaming the folder /usr/lib/python2.7/site-packages/enum/
LO crashe on startup as described earlier, viz.:  ksmserver, kdeinit5 and
kglobalaccel5 -- each with segmentation faults.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] core.git: xmlsecurity/CppunitTest_xmlsecurity_signing.mk

2016-10-14 Thread Stephan Bergmann

 xmlsecurity/CppunitTest_xmlsecurity_signing.mk |4 
 1 file changed, 4 insertions(+)

New commits:
commit b3722cd9d33317c202b8492348cb4c75d02640f3
Author: Stephan Bergmann 
Date:   Fri Oct 14 15:34:16 2016 +0200

Missing dependency

Change-Id: Ic8a97ec13613758f24996aa8a3ef8c0380cc2fae

diff --git a/xmlsecurity/CppunitTest_xmlsecurity_signing.mk 
b/xmlsecurity/CppunitTest_xmlsecurity_signing.mk
index e22a2ca..24713cb 100644
--- a/xmlsecurity/CppunitTest_xmlsecurity_signing.mk
+++ b/xmlsecurity/CppunitTest_xmlsecurity_signing.mk
@@ -48,4 +48,8 @@ $(eval $(call 
gb_CppunitTest_use_rdb,xmlsecurity_signing,services))
 
 $(eval $(call gb_CppunitTest_use_configuration,xmlsecurity_signing))
 
+ifeq ($(ENABLE_PDFIMPORT),TRUE)
+$(eval $(call gb_CppunitTest_use_executable,xmlsecurity_signing,xpdfimport))
+endif
+
 # vim: set noet sw=4 ts=4:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-bugs] [Bug 102274] Closing LibreOffice should not kill active UNO connections

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102274

Thorsten Behrens (CIB)  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Thorsten Behrens (CIB)  ---
This looks fixed as reported - further improvements into separate bug reports
please.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-bugs] [Bug 102312] Rendering in v5 is terrible, a bit in v4, non-existant in v3

2016-10-14 Thread bugzilla-daemon

https://bugs.documentfoundation.org/show_bug.cgi?id=102312

--- Comment #15 from Aprax  ---
(In reply to Buovjaga from comment #14)
> Aprax: maybe try this:
> https://wiki.documentfoundation.org/
> UserProfile#Resolving_corruption_in_the_user_profile

OK, I'll wait until I have a system backup tomorrow morning, then I'll
uninstall v 4, rename all the folders, etc. that are not removed by the
uninstall to get a completely clean system.
Then I'll install v 5 as a pristine new install and make my custom changes and
hope for the best.
Thanks for the tip...
J

-- 
You are receiving this mail because:
You are the assignee for the bug.___
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

[Libreoffice-commits] online.git: loleaflet/src

2016-10-14 Thread Marco Cecchetti

 loleaflet/src/layer/tile/TileLayer.js |7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit 78e707393e2f630cb2c9ca7aa5b14d4947f3b9ed
Author: Marco Cecchetti 
Date:   Tue Oct 11 22:27:04 2016 +0200

loleaflet: handle EMPTY invalid tiles msg with part in the payload

Change-Id: I84ae55440b540dc027bddf341994d34d411f2a3a
Reviewed-on: https://gerrit.libreoffice.org/29826
Reviewed-by: Marco Cecchetti 
Tested-by: Marco Cecchetti 

diff --git a/loleaflet/src/layer/tile/TileLayer.js 
b/loleaflet/src/layer/tile/TileLayer.js
index 9672459..dfe8b7a 100644
--- a/loleaflet/src/layer/tile/TileLayer.js
+++ b/loleaflet/src/layer/tile/TileLayer.js
@@ -304,15 +304,16 @@ L.TileLayer = L.GridLayer.extend({
else if (textMsg.startsWith('invalidatecursor:')) {
this._onInvalidateCursorMsg(textMsg);
}
-   else if (textMsg.startsWith('invalidatetiles:') && 
!textMsg.match('EMPTY')) {
+   else if (textMsg.startsWith('invalidatetiles:') && 
!textMsg.startsWith('EMPTY')) {
this._onInvalidateTilesMsg(textMsg);
}
-   else if (textMsg.startsWith('invalidatetiles:') && 
textMsg.match('EMPTY')) {
+   else if (textMsg.startsWith('invalidatetiles:') && 
textMsg.startsWith('EMPTY')) {
var msg = 'invalidatetiles: ';
if (this._docType === 'text') {
msg += 'part=0 ';
} else {
-   msg += 'part=' + this._selectedPart + ' ';
+   var partNumber = parseInt(textMsg.substring(6));
+   msg += 'part=' + (isNaN(partNumber) ? 
this._selectedPart : partNumber) + ' ';
}
msg += 'x=0 y=0 ';
msg += 'width=' + this._docWidthTwips + ' ';
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

< 1 2 3 4 >

101 - 200 of 327 matches

Mail list logo